Re: [PATCH] media: imx-pxp: fix compilation on i386 or x86_64

[Randy Dunlap]

On 9/14/18 12:10 AM, Philipp Zabel wrote:
> Include the missing interrupt.h header to fix compilation on i386 or
> x86_64:
> 
>  ../drivers/media/platform/imx-pxp.c:988:1: error: unknown type name 
> 'irqreturn_t'
>   static irqreturn_t pxp_irq_handler(int irq, void *dev_id)
>   ^
>  ../drivers/media/platform/imx-pxp.c: In function 'pxp_irq_handler':
>  ../drivers/media/platform/imx-pxp.c:1012:9: error: 'IRQ_HANDLED' undeclared 
> (first use in this function)
>return IRQ_HANDLED;
>   ^
>  ../drivers/media/platform/imx-pxp.c:1012:9: note: each undeclared identifier 
> is reported only once for each function it appears in
>  ../drivers/media/platform/imx-pxp.c: In function 'pxp_probe':
>  ../drivers/media/platform/imx-pxp.c:1660:2: error: implicit declaration of 
> function 'devm_request_threaded_irq' [-Werror=implicit-function-declaration]
>ret = devm_request_threaded_irq(>dev, irq, NULL, pxp_irq_handler,
>^
>  ../drivers/media/platform/imx-pxp.c:1661:4: error: 'IRQF_ONESHOT' undeclared 
> (first use in this function)
>  IRQF_ONESHOT, dev_name(>dev), dev);
> 
> Fixes: 51abcf7fdb70 ("media: imx-pxp: add i.MX Pixel Pipeline driver")
> Reported-by: Randy Dunlap 
> Signed-off-by: Philipp Zabel 

Thanks.  You can choose/add:
Acked-by: Randy Dunlap 
Build-tested-by: Randy Dunlap 

> ---
>  drivers/media/platform/imx-pxp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/imx-pxp.c 
> b/drivers/media/platform/imx-pxp.c
> index 68ecfed7098b..229c23ae4029 100644
> --- a/drivers/media/platform/imx-pxp.c
> +++ b/drivers/media/platform/imx-pxp.c
> @@ -13,6 +13,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> 


-- 
~Randy

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

[Randy Dunlap]

On 05/14/2018 02:10 PM, Sean Young wrote:
> Add support for BPF_PROG_IR_DECODER. This type of BPF program can call

Kconfig file below uses IR_BPF_DECODER instead of the symbol name above.

and then patch 3 says a third choice:
The context provided to a BPF_PROG_RAWIR_DECODER is a struct ir_raw_event;

> rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report
> that the last key should be repeated.
> 
> Signed-off-by: Sean Young 
> ---
>  drivers/media/rc/Kconfig  |  8 +++
>  drivers/media/rc/Makefile |  1 +
>  drivers/media/rc/ir-bpf-decoder.c | 93 +++
>  include/linux/bpf_types.h |  3 +
>  include/uapi/linux/bpf.h  | 16 +-
>  5 files changed, 120 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/media/rc/ir-bpf-decoder.c
> 
> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
> index eb2c3b6eca7f..10ad6167d87c 100644
> --- a/drivers/media/rc/Kconfig
> +++ b/drivers/media/rc/Kconfig
> @@ -120,6 +120,14 @@ config IR_IMON_DECODER
>  remote control and you would like to use it with a raw IR
>  receiver, or if you wish to use an encoder to transmit this IR.
>  
> +config IR_BPF_DECODER
> + bool "Enable IR raw decoder using BPF"
> + depends on BPF_SYSCALL
> + depends on RC_CORE=y
> + help
> +Enable this option to make it possible to load custom IR
> +decoders written in BPF.
> +
>  endif #RC_DECODERS
>  
>  menuconfig RC_DEVICES
> diff --git a/drivers/media/rc/Makefile b/drivers/media/rc/Makefile
> index 2e1c87066f6c..12e1118430d0 100644
> --- a/drivers/media/rc/Makefile
> +++ b/drivers/media/rc/Makefile
> @@ -5,6 +5,7 @@ obj-y += keymaps/
>  obj-$(CONFIG_RC_CORE) += rc-core.o
>  rc-core-y := rc-main.o rc-ir-raw.o
>  rc-core-$(CONFIG_LIRC) += lirc_dev.o
> +rc-core-$(CONFIG_IR_BPF_DECODER) += ir-bpf-decoder.o


-- 
~Randy

Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()

[Randy Dunlap]

On 05/08/2018 03:56 PM, Randy Dunlap wrote:
> On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote:
>> Em Sat, 5 May 2018 10:59:23 -0700
>> Randy Dunlap <rdun...@infradead.org> escreveu:
>>
>>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
>>>> Just checking for ifdefs cause build issues as reported by
>>>> kernel test:
>>>>
>>>> config: openrisc-allmodconfig (attached as .config)
>>>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 
>>>> 'omapfb_init_connections':  
>>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit 
>>>>>> declaration of function 'omapdss_find_mgr_from_display' 
>>>>>> [-Werror=implicit-function-declaration]  
>>>>  mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>>^
>>>>drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: 
>>>> assignment makes pointer from integer without a cast [-Wint-conversion]
>>>>  mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>>  ^
>>>>drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 
>>>> 'omapfb_find_default_display':  
>>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit 
>>>>>> declaration of function 'omapdss_get_default_display_name' 
>>>>>> [-Werror=implicit-function-declaration]  
>>>>  def_name = omapdss_get_default_display_name();
>>>> ^~~~
>>>>drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: 
>>>> assignment makes pointer from integer without a cast [-Wint-conversion]
>>>>  def_name = omapdss_get_default_display_name();
>>>>   ^
>>>>
>>>> So, use IS_ENABLED() instead.  
>>>
>>> Hi,
>>>
>>> I would like to test this (the change doesn't make much sense to me),
>>> but I cannot find the kernel config file nor the kernel test robot's
>>> email of this report.
>>>
>>> Please include an lkml.kernel.org/r/ reference to such emails
>>> so that interested parties can join the party.
>>
>> The message was not c/c to lkml. You can see the original here:
>>
>> https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>>
>>
>>>
>>> Does this patch apply only to your media tree?  so hopefully I can see it in
>>> linux-next on Monday.
>>
>> Yes, as it is over another two patches applied there.
>>
>> If you want to test it earlier, it is in the top of the master branch:
>>  https://git.linuxtv.org/media_tree.git
>>
>>>
>>> Thanks.
>>>
>>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
>>>> Cc: Randy Dunlap <rdun...@infradead.org>
>>>> Cc: tomi.valkei...@ti.com
>>>> Cc: linux-o...@vger.kernel.org
>>>> Cc: linux-fb...@vger.kernel.org
>>>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with 
>>>> COMPILE_TEST && DRM_OMAP")
>>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>
>>>> ---
>>>>  include/video/omapfb_dss.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
>>>> index e9775144ff3b..12755d8d9b4f 100644
>>>> --- a/include/video/omapfb_dss.h
>>>> +++ b/include/video/omapfb_dss.h
>>>> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>>>>  
>>>>  typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>>>>  
>>>> -#ifdef CONFIG_FB_OMAP2
>>>> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>>>>  
>>>>  enum omapdss_version omapdss_get_version(void);
>>>>  bool omapdss_is_initialized(void);
> 
> The patch doesn't make any sense to me.  I would like to see an
> explanation of why this is needed, other than "it fixes the build." ;)

I get it now.  Using
#if IS_ENABLED(CONFIG_FB_OMAP2)

is just the "modern" way of saying
#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)

which also builds without errors.



> But it does fix the build, so:
> Tested-by: Randy Dunlap <rdun...@infradead.org>
Acked-by: Randy Dunlap <rdun...@infradead.org>

-- 
~Randy

Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()

[Randy Dunlap]

On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote:
> Em Sat, 5 May 2018 10:59:23 -0700
> Randy Dunlap <rdun...@infradead.org> escreveu:
> 
>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
>>> Just checking for ifdefs cause build issues as reported by
>>> kernel test:
>>>
>>> config: openrisc-allmodconfig (attached as .config)
>>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 
>>> 'omapfb_init_connections':  
>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit 
>>>>> declaration of function 'omapdss_find_mgr_from_display' 
>>>>> [-Werror=implicit-function-declaration]  
>>>  mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>^
>>>drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: 
>>> assignment makes pointer from integer without a cast [-Wint-conversion]
>>>  mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>  ^
>>>drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 
>>> 'omapfb_find_default_display':  
>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit 
>>>>> declaration of function 'omapdss_get_default_display_name' 
>>>>> [-Werror=implicit-function-declaration]  
>>>  def_name = omapdss_get_default_display_name();
>>> ^~~~
>>>drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: 
>>> assignment makes pointer from integer without a cast [-Wint-conversion]
>>>  def_name = omapdss_get_default_display_name();
>>>   ^
>>>
>>> So, use IS_ENABLED() instead.  
>>
>> Hi,
>>
>> I would like to test this (the change doesn't make much sense to me),
>> but I cannot find the kernel config file nor the kernel test robot's
>> email of this report.
>>
>> Please include an lkml.kernel.org/r/ reference to such emails
>> so that interested parties can join the party.
> 
> The message was not c/c to lkml. You can see the original here:
> 
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
> 
> 
>>
>> Does this patch apply only to your media tree?  so hopefully I can see it in
>> linux-next on Monday.
> 
> Yes, as it is over another two patches applied there.
> 
> If you want to test it earlier, it is in the top of the master branch:
>   https://git.linuxtv.org/media_tree.git
> 
>>
>> Thanks.
>>
>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
>>> Cc: Randy Dunlap <rdun...@infradead.org>
>>> Cc: tomi.valkei...@ti.com
>>> Cc: linux-o...@vger.kernel.org
>>> Cc: linux-fb...@vger.kernel.org
>>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with 
>>> COMPILE_TEST && DRM_OMAP")
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>
>>> ---
>>>  include/video/omapfb_dss.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
>>> index e9775144ff3b..12755d8d9b4f 100644
>>> --- a/include/video/omapfb_dss.h
>>> +++ b/include/video/omapfb_dss.h
>>> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>>>  
>>>  typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>>>  
>>> -#ifdef CONFIG_FB_OMAP2
>>> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>>>  
>>>  enum omapdss_version omapdss_get_version(void);
>>>  bool omapdss_is_initialized(void);

The patch doesn't make any sense to me.  I would like to see an
explanation of why this is needed, other than "it fixes the build." ;)

But it does fix the build, so:
Tested-by: Randy Dunlap <rdun...@infradead.org>


thanks,
-- 
~Randy

Re: [PATCH v3 13/14] media: imx7.rst: add documentation for i.MX7 media driver

[Randy Dunlap]

Hi,

I have a few editing suggestions below...

On 05/07/2018 09:21 AM, Rui Miguel Silva wrote:
> Add rst document to describe the i.MX7 media driver and also a working example
> from the Warp7 board usage with a OV2680 sensor.
> 
> Signed-off-by: Rui Miguel Silva 
> ---
>  Documentation/media/v4l-drivers/imx7.rst  | 157 ++
>  Documentation/media/v4l-drivers/index.rst |   1 +
>  2 files changed, 158 insertions(+)
>  create mode 100644 Documentation/media/v4l-drivers/imx7.rst
> 
> diff --git a/Documentation/media/v4l-drivers/imx7.rst 
> b/Documentation/media/v4l-drivers/imx7.rst
> new file mode 100644
> index ..64b97b442277
> --- /dev/null
> +++ b/Documentation/media/v4l-drivers/imx7.rst
> @@ -0,0 +1,157 @@
> +i.MX7 Video Capture Driver
> +==
> +
> +Introduction
> +
> +
> +The i.MX7 contrary to the i.MX5/6 family does not contain an Image Processing
> +Unit (IPU), because of that the capabilities to perform operations or

s/,/;/

> +manipulation of the capture frames is less feature rich.

  are less

> +
> +For image capture the i.MX7 have three units:

   has

> +- CMOS Sensor Interface (CSI)
> +- Video Multiplexer
> +- MIPI CSI-2 Receiver
> +
> +::
> +   |\
> +   MIPI Camera Input ---> MIPI CSI-2 --- > | \
> +   |  \
> +   | M |
> +   | U | -->  CSI ---> Capture
> +   | X |
> +   |  /
> +   Parallel Camera Input > | /
> +   |/
> +
> +For additional information, please refer to the latest versions of the i.MX7
> +reference manual [#f1]_.
> +
> +Entities
> +
> +
> +imx7-mipi-csi2
> +--
> +
> +This is the MIPI CSI-2 recevier entity. It has one sink pad to receive the 
> pixel

  receiver

> +data from MIPI CSI-2 camera sensor. It has one source pad, corresponding to 
> the
> +virtual channel 0. This module is compliant to previous version of Samsung
> +D-phy, and support two D-PHY Rx Data lanes.

  supports

> +
> +csi_mux
> +---
> +
> +This is the video multiplexer. It has two sink pads to select from either 
> camera
> +sensors with a parallel interface or from MIPI CSI-2 virtual channel 0.  It 
> has

   sensor

> +a single source pad that routes to the CSI.
> +
> +csi
> +---
> +
> +The CSI enables the chip to connect directly to external CMOS image sensor. 
> CSI
> +can interfaces directly with Parallel and MIPI CSI-2 buses. It has 256 x 64 
> FIFO

   interface

> +to store received image pixel data and embedded DMA controllers to transfer 
> data
> +from the FIFO through AHB bus.
> +
> +This entity has one sink pad that receive from the csi_mux entity and a 
> single

 receives

> +source pad that route video frames directly to memory buffers, this pad is

   routesbuffers. This pad is

> +routed to a capture device node.
> +
> +Usage Notes
> +---
> +
> +To aid in configuration and for backward compatibility with V4L2 applications
> +that access controls only from video device nodes, the capture device 
> interfaces
> +inherit controls from the active entities in the current pipeline, so 
> controls
> +can be accessed either directly from the subdev or from the active capture
> +device interface. For example, the sensor controls are available either from 
> the
> +sensor subdevs or from the active capture device.
> +
> +Warp7 with OV2680
> +-
> +
> +On this platform an OV2680 MIPI CSI-2 module is connected to the internal 
> MIPI
> +CSI-2 receiver. The following example configures a video capture pipeline 
> with
> +an output of 800x600, and BGGR 10 bit bayer format:
> +
> +.. code-block:: none
> +   # Setup links
> +   media-ctl -l "'ov2680 1-0036':0 -> 'imx7-mipi-csis.0':0[1]"
> +   media-ctl -l "'imx7-mipi-csis.0':1 -> 'csi_mux':1[1]"
> +   media-ctl -l "'csi_mux':2 -> 'csi':0[1]"
> +   media-ctl -l "'csi':1 -> 'csi capture':0[1]"
> +
> +   # Configure pads for pipeline
> +   media-ctl -V "'ov2680 1-0036':0 [fmt:SBGGR10_1X10/800x600 field:none]"
> +   media-ctl -V "'csi_mux':1 [fmt:SBGGR10_1X10/800x600 field:none]"
> +   media-ctl -V "'csi_mux':2 [fmt:SBGGR10_1X10/800x600 field:none]"
> +   media-ctl -V "'imx7-mipi-csis.0':0 [fmt:SBGGR10_1X10/800x600 field:none]"
> +   media-ctl -V "'csi':0 [fmt:SBGGR10_1X10/800x600 field:none]"
> +
> +After this streaming can start, the v4l2-ctl tool can be used to select any 
> of

can start. The

> +the resolutions supported by the sensor.
> +
> +.. code-block:: none
> +root@imx7s-warp:~# media-ctl -p
> +Media 

Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()

[Randy Dunlap]

On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
> Just checking for ifdefs cause build issues as reported by
> kernel test:
> 
> config: openrisc-allmodconfig (attached as .config)
> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
> 
> All errors (new ones prefixed by >>):
> 
>drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 
> 'omapfb_init_connections':
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit 
>>> declaration of function 'omapdss_find_mgr_from_display' 
>>> [-Werror=implicit-function-declaration]
>  mgr = omapdss_find_mgr_from_display(def_dssdev);
>^
>drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment 
> makes pointer from integer without a cast [-Wint-conversion]
>  mgr = omapdss_find_mgr_from_display(def_dssdev);
>  ^
>drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 
> 'omapfb_find_default_display':
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit 
>>> declaration of function 'omapdss_get_default_display_name' 
>>> [-Werror=implicit-function-declaration]
>  def_name = omapdss_get_default_display_name();
> ^~~~
>drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: 
> assignment makes pointer from integer without a cast [-Wint-conversion]
>  def_name = omapdss_get_default_display_name();
>   ^
> 
> So, use IS_ENABLED() instead.

Hi,

I would like to test this (the change doesn't make much sense to me),
but I cannot find the kernel config file nor the kernel test robot's
email of this report.

Please include an lkml.kernel.org/r/ reference to such emails
so that interested parties can join the party.

Does this patch apply only to your media tree?  so hopefully I can see it in
linux-next on Monday.

Thanks.

> Cc: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
> Cc: Randy Dunlap <rdun...@infradead.org>
> Cc: tomi.valkei...@ti.com
> Cc: linux-o...@vger.kernel.org
> Cc: linux-fb...@vger.kernel.org
> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with 
> COMPILE_TEST && DRM_OMAP")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>
> ---
>  include/video/omapfb_dss.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
> index e9775144ff3b..12755d8d9b4f 100644
> --- a/include/video/omapfb_dss.h
> +++ b/include/video/omapfb_dss.h
> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>  
>  typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>  
> -#ifdef CONFIG_FB_OMAP2
> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>  
>  enum omapdss_version omapdss_get_version(void);
>  bool omapdss_is_initialized(void);
> 


-- 
~Randy

Re: linux-next: Tree for Apr 20 (media/platform/marvell-ccic/)

[Randy Dunlap]

On 04/19/18 23:11, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20180419:
> 
> I have added a patch to the arm-current tree to fix build problems
> discovered overnight.
> 
> Non-merge commits (relative to Linus' tree): 1278
>  1324 files changed, 47025 insertions(+), 20625 deletions(-)
> 
> 
> 
> I have created today's linux-next tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> (patches at http://www.kernel.org/pub/linux/kernel/next/ ).  If you
> are tracking the linux-next tree using git, you should not use "git pull"
> to do so as that will try to merge the new linux-next release with the
> old one.  You should use "git fetch" and checkout or reset to the new
> master.
> 
> You can see which trees have been included by looking in the Next/Trees
> file in the source.  There are also quilt-import.log and merge.log
> files in the Next directory.  Between each merge, the tree was built
> with a ppc64_defconfig for powerpc, an allmodconfig for x86_64, a
> multi_v7_defconfig for arm and a native build of tools/perf. After
> the final fixups (if any), I do an x86_64 modules_install followed by
> builds for x86_64 allnoconfig, powerpc allnoconfig (32 and 64 bit),
> ppc44x_defconfig, allyesconfig and pseries_le_defconfig and i386, sparc
> and sparc64 defconfig. And finally, a simple boot test of the powerpc
> pseries_le_defconfig kernel in qemu (with and without kvm enabled).
> 
> Below is a summary of the state of the merge.
> 
> I am currently merging 258 trees (counting Linus' and 44 trees of bug
> fix patches pending for the current merge release).
> 
> Stats about the size of the tree over time can be seen at
> http://neuling.org/linux-next-size.html .
> 
> Status of my local build tests will be at
> http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
> advice about cross compilers/configs that work, we are always open to add
> more builds.
> 
> Thanks to Randy Dunlap for doing many randconfig builds.  And to Paul
> Gortmaker for triage and bug fixes.
> 

on x86_64 (randconfig):

drivers/media/platform/marvell-ccic/mcam-core.o: In function `mccic_register':
mcam-core.c:(.text+0x1ce0): undefined reference to `__this_module'
drivers/media/platform/marvell-ccic/mcam-core.o:(.rodata+0x0): undefined 
reference to `__this_module'
drivers/media/platform/marvell-ccic/mcam-core.o:(__param+0x8): undefined 
reference to `__this_module'
drivers/media/platform/marvell-ccic/mcam-core.o:(__param+0x30): undefined 
reference to `__this_module'
drivers/media/platform/marvell-ccic/mcam-core.o:(__param+0x58): undefined 
reference to `__this_module'
drivers/media/platform/marvell-ccic/mcam-core.o:(__param+0x80): more undefined 
references to `__this_module' follow


Full randconfig file is attached.


-- 
~Randy
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 4.17.0-rc1 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_OUTPUT_FORMAT="elf64-x86-64"
CONFIG_ARCH_DEFCONFIG="arch/x86/configs/x86_64_defconfig"
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_MMU=y
CONFIG_ARCH_MMAP_RND_BITS_MIN=28
CONFIG_ARCH_MMAP_RND_BITS_MAX=32
CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MIN=8
CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MAX=16
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_KASAN_SHADOW_OFFSET=0xdc00
CONFIG_X86_64_SMP=y
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_PGTABLE_LEVELS=4
CONFIG_CONSTRUCTORS=y
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y
CONFIG_THREAD_INFO_IN_TASK=y

#
# General setup
#
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=""
CONFIG_COMPILE_TEST=y
CONFIG_LOCALVERSION=""
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
CONFIG_KERNEL_LZO=y
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME="(none)"
# CONFIG_SYSVIPC is not set
CONFIG_CROSS_MEMORY

Re: [RFCv3 15/17] v4l2: document the request API interface

[Randy Dunlap]

Hi,

A few comments below...

On 02/06/2018 05:48 PM, Alexandre Courbot wrote:
> Document how the request API can be used along with the existing V4L2
> interface.
> 
> Signed-off-by: Alexandre Courbot 
> ---
>  Documentation/media/uapi/v4l/buffer.rst|  10 +-
>  Documentation/media/uapi/v4l/common.rst|   1 +
>  Documentation/media/uapi/v4l/request-api.rst   | 236 
> +
>  .../media/uapi/v4l/vidioc-g-ext-ctrls.rst  |  16 +-
>  Documentation/media/uapi/v4l/vidioc-qbuf.rst   |  21 ++
>  5 files changed, 280 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/media/uapi/v4l/request-api.rst


> diff --git a/Documentation/media/uapi/v4l/request-api.rst 
> b/Documentation/media/uapi/v4l/request-api.rst
> new file mode 100644
> index ..4c61a0dbe3a9
> --- /dev/null
> +++ b/Documentation/media/uapi/v4l/request-api.rst
> @@ -0,0 +1,236 @@
> +.. -*- coding: utf-8; mode: rst -*-
> +
> +.. _media-request-api:
> +
> +Request API
> +===
> +
> +The Request API has been designed to allow V4L2 to deal with requirements of
> +modern devices (stateless codecs, MIPI cameras, ...) and APIs (Android Codec
> +v2). One such requirement is the ability for devices belonging to the same
> +pipeline to reconfigure and collaborate closely on a per-frame basis. 
> Another is
> +efficient support of stateless codecs, which need per-frame controls to be 
> set
> +asynchronously in order to be efficiently used.

   to be used efficiently.

> +
> +Supporting these features without the Request API is possible but terribly
> +inefficient: user-space would have to flush all activity on the media 
> pipeline,
> +reconfigure it for the next frame, queue the buffers to be processed with 
> that
> +configuration, and wait until they are all available for dequeing before

"dequeing" should be dequeueing or dequeuing.

> +considering the next frame. This defeats the purpose of having buffer queues
> +since in practice only one buffer would be queued at a time.
> +
> +The Request API allows a specific configuration of the pipeline (media
> +controller topology + controls for each device) to be associated with 
> specific
> +buffers. The parameters are applied by each participating device as buffers
> +associated to a request flow in. This allows user-space to schedule several
> +tasks ("requests") with different parameters in advance, knowing that the
> +parameters will be applied when needed to get the expected result. Controls
> +values at the time of request completion are also available for reading.
> +
> +Usage
> +=
> +
> +The Request API is used on top of standard media controller and V4L2 calls,
> +which are augmented with an extra ``request_fd`` parameter. All operations on
> +requests themselves are performed using the command parameter of the
> +:c:func:`MEDIA_IOC_REQUEST_CMD` ioctl.
> +
> +Request Allocation
> +--
> +
> +User-space allocates requests using the ``MEDIA_REQ_CMD_ALLOC`` command on
> +an opened media device. This returns a file descriptor representing the
> +request. Typically, several such requests will be allocated.
> +
> +Request Preparation
> +---
> +
> +Standard V4L2 ioctls can then receive a request file descriptor to express 
> the
> +fact that the ioctl is part of said request, and is not to be applied
> +immediately. V4L2 ioctls supporting this are :c:func:`VIDIOC_S_EXT_CTRLS` and
> +:c:func:`VIDIOC_QBUF`. Controls set with a request parameter are stored 
> instead
> +of being immediately applied, and queued buffers will block the buffer queue
> +until the request becomes active.
> +
> +RFC Note: currently several buffers can be queued to the same queue with the
> +same request. The request parameters will be only be applied when processing
> +the first buffer. Does it make more sense to allow at most one buffer per
> +request per queue instead?
> +
> +Request Submission
> +--
> +
> +Once the parameters and buffers of the request are specified, it can be
> +submitted with the ``MEDIA_REQ_CMD_SUBMIT`` command. This will make the 
> buffers
> +associated to the request available to their driver, which can then apply the
> +saved controls as buffers are processed. A submitted request cannot be 
> modified
> +anymore.
> +
> +If several devices are part of the request, individual drivers may 
> synchronize
> +so the requested pipeline's topology is applied before the buffers are
> +processed. This is at the discretion of the drivers and is not a requirement.
> +
> +Buffers queued without an associated request after a request-bound buffer 
> will
> +be processed using the state of the hardware at the time of the request
> +completion. All the same, controls set without a request are applied
> +immediately, regardless of whether a request is in use or not.
> +
> +User-space can ``poll()`` a request FD in order to wait until the request

Re: [PATCH v8 1/7] v4l2-dv-timings: add v4l2_hdmi_colorimetry()

[Randy Dunlap]

On 02/06/2018 12:27 PM, Tim Harvey wrote:
> From: Hans Verkuil 
> 
> Add the v4l2_hdmi_colorimetry() function so we have a single function
> that determines the colorspace, YCbCr encoding, quantization range and
> transfer function from the InfoFrame data.
> 
> Signed-off-by: Hans Verkuil 
> Signed-off-by: Tim Harvey 
> ---
>  drivers/media/v4l2-core/v4l2-dv-timings.c | 141 
> ++
>  include/media/v4l2-dv-timings.h   |  21 +
>  2 files changed, 162 insertions(+)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c 
> b/drivers/media/v4l2-core/v4l2-dv-timings.c
> index 930f9c5..0182d3d 100644
> --- a/drivers/media/v4l2-core/v4l2-dv-timings.c
> +++ b/drivers/media/v4l2-core/v4l2-dv-timings.c
> @@ -27,6 +27,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  MODULE_AUTHOR("Hans Verkuil");
>  MODULE_DESCRIPTION("V4L2 DV Timings Helper Functions");
> @@ -814,3 +815,143 @@ struct v4l2_fract v4l2_calc_aspect_ratio(u8 
> hor_landscape, u8 vert_portrait)
>   return aspect;
>  }
>  EXPORT_SYMBOL_GPL(v4l2_calc_aspect_ratio);
> +
> +/** v4l2_hdmi_rx_colorimetry - determine HDMI colorimetry information
> + *   based on various InfoFrames.
> + * @avi - the AVI InfoFrame
> + * @hdmi - the HDMI Vendor InfoFrame, may be NULL
> + * @height - the frame height

kernel-doc format for function parameters is like:

 * @avi: the AVI InfoFrame

etc.

> + *
> + * Determines the HDMI colorimetry information, i.e. how the HDMI
> + * pixel color data should be interpreted.
> + *
> + * Note that some of the newer features (DCI-P3, HDR) are not yet
> + * implemented: the hdmi.h header needs to be updated to the HDMI 2.0
> + * and CTA-861-G standards.
> + */
> +struct v4l2_hdmi_colorimetry
> +v4l2_hdmi_rx_colorimetry(const struct hdmi_avi_infoframe *avi,
> +  const struct hdmi_vendor_infoframe *hdmi,
> +  unsigned int height)
> +{


thanks,
-- 
~Randy

Re: [RFCv2 05/17] media: Document the media request API

[Randy Dunlap]

On 01/31/2018 02:24 AM, Alexandre Courbot wrote:
> From: Laurent Pinchart 
> 
> The media request API is made of a new ioctl to implement request
> management. Document it.
> 
> Signed-off-by: Laurent Pinchart 
> [acour...@chromium.org: adapt for newest API]
> Signed-off-by: Alexandre Courbot 
> ---
>  Documentation/media/uapi/mediactl/media-funcs.rst  |   1 +
>  .../media/uapi/mediactl/media-ioc-request-cmd.rst  | 141 
> +
>  2 files changed, 142 insertions(+)
>  create mode 100644 
> Documentation/media/uapi/mediactl/media-ioc-request-cmd.rst
> 
> diff --git a/Documentation/media/uapi/mediactl/media-funcs.rst 
> b/Documentation/media/uapi/mediactl/media-funcs.rst
> index 076856501cdb..e3a45d82ffcb 100644
> --- a/Documentation/media/uapi/mediactl/media-funcs.rst
> +++ b/Documentation/media/uapi/mediactl/media-funcs.rst
> @@ -15,4 +15,5 @@ Function Reference
>  media-ioc-g-topology
>  media-ioc-enum-entities
>  media-ioc-enum-links
> +media-ioc-request-cmd
>  media-ioc-setup-link
> diff --git a/Documentation/media/uapi/mediactl/media-ioc-request-cmd.rst 
> b/Documentation/media/uapi/mediactl/media-ioc-request-cmd.rst
> new file mode 100644
> index ..723b422afcce
> --- /dev/null
> +++ b/Documentation/media/uapi/mediactl/media-ioc-request-cmd.rst
> @@ -0,0 +1,141 @@
> +.. -*- coding: utf-8; mode: rst -*-
> +
> +.. _media_ioc_request_cmd:
> +
> +***
> +ioctl MEDIA_IOC_REQUEST_CMD
> +***
> +
> +Name
> +
> +
> +MEDIA_IOC_REQUEST_CMD - Manage media device requests
> +
> +
> +Synopsis
> +
> +
> +.. c:function:: int ioctl( int fd, MEDIA_IOC_REQUEST_CMD, struct 
> media_request_cmd *argp )
> +:name: MEDIA_IOC_REQUEST_CMD
> +
> +
> +Arguments
> +=
> +
> +``fd``
> +File descriptor returned by :ref:`open() `.
> +
> +``argp``
> +
> +
> +Description
> +===
> +
> +The MEDIA_IOC_REQUEST_CMD ioctl allow applications to manage media device

   allows

> +requests. A request is an object that can group media device configuration
> +parameters, including subsystem-specific parameters, in order to apply all 
> the
> +parameters atomically. Applications are responsible for allocating and
> +deleting requests, filling them with configuration parameters submitting 
> them.

and submitting 
them.

> +
> +Request operations are performed by calling the MEDIA_IOC_REQUEST_CMD ioctl
> +with a pointer to a struct :c:type:`media_request_cmd` with the cmd field set
> +to the appropriate command. :ref:`media-request-command` lists the commands
> +supported by the ioctl.
> +
> +The struct :c:type:`media_request_cmd` request field contains the file
> +descriptorof the request on which the command operates. For the

   descriptor of

> +``MEDIA_REQ_CMD_ALLOC`` command the field is set to zero by applications and
> +filled by the driver. For all other commands the field is set by applications
> +and left untouched by the driver.
> +
> +To allocate a new request applications use the ``MEDIA_REQ_CMD_ALLOC``
> +command. The driver will allocate a new request and return its FD in the
> +request field. After allocation, the request is "empty", which means that it
> +does not hold any state of its own, and that the hardware's state will not be
> +affected by it unless it is passed as argument to V4L2 or media controller
> +commands.
> +
> +Requests are reference-counted. A newly allocated request is referenced
> +by the returned file descriptor, and can be later referenced by
> +subsystem-specific operations. Requests will thus be automatically deleted
> +when they're not longer used after the returned file descriptor is closed.

 no longer

> +
> +If a request isn't needed applications can delete it by calling ``close()``
> +on it. The driver will drop the file handle reference. The request will not
> +be usable through the MEDIA_IOC_REQUEST_CMD ioctl anymore, but will only be
> +deleted when the last reference is released. If no other reference exists 
> when
> +``close()`` is invoked the request will be deleted immediately.
> +
> +After creating a request applications should fill it with configuration
> +parameters. This is performed through subsystem-specific request APIs outside
> +the scope of the media controller API. See the appropriate subsystem APIs for
> +more information, including how they interact with the MEDIA_IOC_REQUEST_CMD
> +ioctl.
> +
> +Once a request contains all the desired configuration parameters it can be
> +submitted using the ``MEDIA_REQ_CMD_SUBMIT`` command. This will let the
> +buffers queued for the request be passed to their respective drivers, which
> +will then apply the request's parameters before processing them.
> +
> +Once a request has been queued 

Re: [PATCH v7 2/2] media: V3s: Add support for Allwinner CSI.

[Randy Dunlap]

On 01/29/2018 01:21 AM, Yong Deng wrote:
> Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2
> interface and CSI1 is used for parallel interface. This is not
> documented in datasheet but by test and guess.
> 
> This patch implement a v4l2 framework driver for it.
> 
> Currently, the driver only support the parallel interface. MIPI-CSI2,
> ISP's support are not included in this patch.
> 
> Tested-by: Maxime Ripard 
> Signed-off-by: Yong Deng 
> ---


A previous version (I think v6) had a build error with the use of
PHYS_OFFSET, so Kconfig was modified to depend on ARM and ARCH_SUNXI
(one of which seems to be overkill).  As is here, the COMPILE_TEST piece is
meaningless for all arches except ARM.  If you care enough for COMPILE_TEST
(and I would), then you could make COMPILE_TEST useful on any arch by
removing the "depends on ARM" (the ARCH_SUNXI takes care of that) and by
having an alternate value for PHYS_OFFSET, like so:

+#if defined(CONFIG_COMPILE_TEST) && !defined(PHYS_OFFSET)
+#define PHYS_OFFSET0
+#endif

With those 2 changes, the driver builds for me on x86_64.

> diff --git a/drivers/media/platform/sunxi/sun6i-csi/Kconfig 
> b/drivers/media/platform/sunxi/sun6i-csi/Kconfig
> new file mode 100644
> index 000..f80c965
> --- /dev/null
> +++ b/drivers/media/platform/sunxi/sun6i-csi/Kconfig
> @@ -0,0 +1,10 @@
> +config VIDEO_SUN6I_CSI
> + tristate "Allwinner V3s Camera Sensor Interface driver"
> + depends on ARM
> + depends on VIDEO_V4L2 && COMMON_CLK && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> + depends on ARCH_SUNXI || COMPILE_TEST
> + select VIDEOBUF2_DMA_CONTIG
> + select REGMAP_MMIO
> + select V4L2_FWNODE
> + ---help---
> +Support for the Allwinner Camera Sensor Interface Controller on V3s.

thanks,
-- 
~Randy

Re: [RFC PATCH 6/8] v4l2: document the request API interface

[Randy Dunlap]

On 01/25/2018 10:02 PM, Alexandre Courbot wrote:
> Document how the request API can be used along with the existing V4L2
> interface.
> 

> +Request API
> +===
> +
> +The Request API has been designed to allow V4L2 to deal with requirements of
> +modern IPs (stateless codecs, MIPI cameras, ...) and APIs (Android Codec v2).

Hi,
Just a quick question:  What are IPs?

Not Internet Protocols. Hopefully not Intellectual Properties.
Maybe Intelligent Processors?

thanks,
-- 
~Randy

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

[Randy Dunlap]

On 01/21/2018 09:54 AM, jacopo mondi wrote:
> Hi Randy,
>thanks for noticing,
> 
> On Fri, Jan 19, 2018 at 02:12:19PM -0800, Randy Dunlap wrote:
>> On 01/16/2018 01:44 PM, Jacopo Mondi wrote:
>>> Hello,
>>>new version of CEU after Hans' review.
>>>
>>> Added his Acked-by to most patches and closed review comments.
>>> Running v4l2-compliance, I noticed a new failure introduced by the way I now
>>> calculate the plane sizes in set/try_fmt.
>>
>> I would expect that you have already seen this, but I get a build error
>> in renesas-ceu.c.  Here is a small patch for it.
> 
> Actually I did not.
> The compile error has been introduced by this commit
> 
> commit 4e48afecd5ee3a394d228349fc1c33982e9fb557
> Author: Mauro Carvalho Chehab <mche...@s-opensource.com>
> Date:   Wed Sep 27 10:12:00 2017 -0400
> media: v4l2-async: simplify v4l2_async_subdev structure
> 
> Which is not in v4.15-rc8 on which I have based my work on.
> 
> As a general question, if I'm aiming to have my driver included in
> next release, should I always base my work on linux-next or it depends
> on sub-system/maintainers preferences?

That's up to the subsystem maintainer, but usually you should make sure
that it will apply to linux-next or to the subsystem's "-next" tree,
whatever that is called.

>>
>> ---
>> From: Randy Dunlap <rdun...@infradead.org>
>>
>> Fix build error (on x86 with COMPILE_TEST):
>>
>> ../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt':
>> ../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 
>> 'fwnode' in something not a structure or union
>>ceu_sd->asd.match.fwnode.fwnode =
>>
>> Signed-off-by: Randy Dunlap <rdun...@infradead.org>
>> ---
>>  drivers/media/platform/renesas-ceu.c |2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c
>> +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c
>> @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic
>>
>>  ceu_sd->mbus_flags = fw_ep.bus.parallel.flags;
>>  ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE;
>> -ceu_sd->asd.match.fwnode.fwnode =
>> +ceu_sd->asd.match.fwnode =
>>  fwnode_graph_get_remote_port_parent(
>>  of_fwnode_handle(ep));
>>
>>


-- 
~Randy

Re: [PATCH v5 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

[Randy Dunlap]

On 01/19/2018 01:17 PM, Icenowy Zheng wrote:
> 在 2018年1月20日星期六 CST 上午5:14:09，Rob Herring 写道：
>> On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote:
>>> Add binding documentation for Allwinner V3s CSI.
>>>
>>> Signed-off-by: Yong Deng 
>>> ---
>>>
>>>  .../devicetree/bindings/media/sun6i-csi.txt| 59
>>>  ++ 1 file changed, 59 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt
>>
>> Reviewed-by: Rob Herring 
> 
> I think other subsystem's maintainer may expect a Acked-by from you here.
> 
> Why do you use Reviewed-by here instead?

The Reviewed-by: tag is a stronger ACK than the Acked-by: tag, so this
should be sufficient for other subsystem maintainers.

Please see Documentation/process/submitting-patches.rst, section 13.


-- 
~Randy

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

[Randy Dunlap]

On 01/16/2018 01:44 PM, Jacopo Mondi wrote:
> Hello,
>new version of CEU after Hans' review.
> 
> Added his Acked-by to most patches and closed review comments.
> Running v4l2-compliance, I noticed a new failure introduced by the way I now
> calculate the plane sizes in set/try_fmt.

I would expect that you have already seen this, but I get a build error
in renesas-ceu.c.  Here is a small patch for it.

---
From: Randy Dunlap <rdun...@infradead.org>

Fix build error (on x86 with COMPILE_TEST):

../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt':
../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 
'fwnode' in something not a structure or union
   ceu_sd->asd.match.fwnode.fwnode =

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
---
 drivers/media/platform/renesas-ceu.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c
+++ linux-next-20180119/drivers/media/platform/renesas-ceu.c
@@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic
 
ceu_sd->mbus_flags = fw_ep.bus.parallel.flags;
ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE;
-   ceu_sd->asd.match.fwnode.fwnode =
+   ceu_sd->asd.match.fwnode =
fwnode_graph_get_remote_port_parent(
of_fwnode_handle(ep));
 

Re: [RFT PATCH v3 0/6] Asynchronous UVC

[Randy Dunlap]

On 01/12/2018 01:19 AM, Kieran Bingham wrote:
> The Linux UVC driver has long provided adequate performance capabilities for
> web-cams and low data rate video devices in Linux while resolutions were low.
> 
> Modern USB cameras are now capable of high data rates thanks to USB3 with
> 1080p, and even 4k capture resolutions supported.
> 
> Cameras such as the Stereolabs ZED (bulk transfers) or the Logitech BRIO
> (isochronous transfers) can generate more data than an embedded ARM core is
> able to process on a single core, resulting in frame loss.
> 
> A large part of this performance impact is from the requirement to
> ‘memcpy’ frames out from URB packets to destination frames. This unfortunate
> requirement is due to the UVC protocol allowing a variable length header, and
> thus it is not possible to provide the target frame buffers directly.
> 
> Extra throughput is possible by moving the actual memcpy actions to a work
> queue, and moving the memcpy out of interrupt context thus allowing work tasks
> to be scheduled across multiple cores.
> 
> This series has been tested on both the ZED and BRIO cameras on arm64
> platforms, however due to the intrinsic changes in the driver I would like to
> see it tested with other devices and other platforms, so I'd appreciate if
> anyone can test this on a range of USB cameras.
> 
> In particular, any iSight devices, or devices which use UVC to encode data
> (output device) would certainly be great to be tested with these patches.
> 
> v2:
>  - Fix race reported by Guennadi
> 
> v3:
>  - Fix similar race reported by Laurent
>  - Only queue work if required (encode/isight do not queue work)
>  - Refactor/Rename variables for clarity
> 
> Kieran Bingham (6):
>   uvcvideo: Refactor URB descriptors
>   uvcvideo: Convert decode functions to use new context structure
>   uvcvideo: Protect queue internals with helper
>   uvcvideo: queue: Simplify spin-lock usage
>   uvcvideo: queue: Support asynchronous buffer handling
>   uvcvideo: Move decode processing to process context
> 
>  drivers/media/usb/uvc/uvc_isight.c |   4 +-
>  drivers/media/usb/uvc/uvc_queue.c  | 114 +
>  drivers/media/usb/uvc/uvc_video.c  | 198 ++
>  drivers/media/usb/uvc/uvcvideo.h   |  56 +++-
>  4 files changed, 296 insertions(+), 76 deletions(-)
> 
> base-commit: 6f0e5fd39143a59c22d60e7befc4f33f22aeed2f

Hi,

Tested on x86_64, Linux 4.15-rc8 + these 9 patches, with 3 UVC webcams.

1.
usb 1-1.3: Product: Dynex 1.3MP Webcam
usb 1-1.3: Manufacturer: Dynex
uvcvideo: Found UVC 1.00 device Dynex 1.3MP Webcam (19ff:0102)

2. uvcvideo: Found UVC 1.00 device 2SF001 (0bda:58f5)  (builtin on Toshiba 
laptop)

3.
usb 1-1.3: New USB device found, idVendor=0c45, idProduct=62c0
usb 1-1.3: New USB device strings: Mfr=2, Product=1, SerialNumber=3
usb 1-1.3: Product: USB 2.0 Camera
usb 1-1.3: Manufacturer: Sonix Technology Co., Ltd.
usb 1-1.3: SerialNumber: SN0001
uvcvideo: Found UVC 1.00 device USB 2.0 Camera (0c45:62c0)


BTW, qv4l2 was very useful for this.  Thanks, Hans.

Tested-by: Randy Dunlap <rdun...@infradead.org>


-- 
~Randy

Re: [PATCH v2] kernel-doc: parse DECLARE_KFIFO and DECLARE_KFIFO_PTR()

[Randy Dunlap]

On 12/08/2017 06:05 AM, Mauro Carvalho Chehab wrote:
> On media, we now have an struct declared with:
> 
> struct lirc_fh {
> struct list_head list;
> struct rc_dev *rc;
> int carrier_low;
> boolsend_timeout_reports;
> DECLARE_KFIFO_PTR(rawir, unsigned int);
> DECLARE_KFIFO_PTR(scancodes, struct lirc_scancode);
> wait_queue_head_t   wait_poll;
> u8  send_mode;
> u8  rec_mode;
> };
> 
> gpiolib.c has a similar declaration with DECLARE_KFIFO().
> 
> Currently, those produce the following error:
> 
>   ./include/media/rc-core.h:96: warning: No description found for 
> parameter 'int'
>   ./include/media/rc-core.h:96: warning: No description found for 
> parameter 'lirc_scancode'
>   ./include/media/rc-core.h:96: warning: Excess struct member 'rawir' 
> description in 'lirc_fh'
>   ./include/media/rc-core.h:96: warning: Excess struct member 'scancodes' 
> description in 'lirc_fh'
>   ../drivers/gpio/gpiolib.c:601: warning: No description found for 
> parameter '16'
>   ../drivers/gpio/gpiolib.c:601: warning: Excess struct member 'events' 
> description in 'lineevent_state'
> 
> So, teach kernel-doc how to parse DECLARE_KFIFO() and DECLARE_KFIFO_PTR().
> 
> While here, relax at the past DECLARE_foo() macros, accepting a random
> number of spaces after comma.
> 
> The addition of DECLARE_KFIFO() was
> Suggested-by: Randy Dunlap <rdun...@infradead.org>
> 
> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>

Tested-by: Randy Dunlap <rdun...@infradead.org>
Acked-by: Randy Dunlap <rdun...@infradead.org>

Thanks.

> ---
>  scripts/kernel-doc | 8 ++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index bd29a92b4b48..cfdabdd08631 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -2208,9 +2208,13 @@ sub dump_struct($$) {
>   $members =~ s/__aligned\s*\([^;]*\)//gos;
>   $members =~ s/\s*CRYPTO_MINALIGN_ATTR//gos;
>   # replace DECLARE_BITMAP
> - $members =~ s/DECLARE_BITMAP\s*\(([^,)]+), ([^,)]+)\)/unsigned long 
> $1\[BITS_TO_LONGS($2)\]/gos;
> + $members =~ s/DECLARE_BITMAP\s*\(([^,)]+),\s*([^,)]+)\)/unsigned long 
> $1\[BITS_TO_LONGS($2)\]/gos;
>   # replace DECLARE_HASHTABLE
> - $members =~ s/DECLARE_HASHTABLE\s*\(([^,)]+), ([^,)]+)\)/unsigned long 
> $1\[1 << (($2) - 1)\]/gos;
> + $members =~ s/DECLARE_HASHTABLE\s*\(([^,)]+),\s*([^,)]+)\)/unsigned 
> long $1\[1 << (($2) - 1)\]/gos;
> + # replace DECLARE_KFIFO
> + $members =~ s/DECLARE_KFIFO\s*\(([^,)]+),\s*([^,)]+),\s*([^,)]+)\)/$2 
> \*$1/gos;
> + # replace DECLARE_KFIFO_PTR
> + $members =~ s/DECLARE_KFIFO_PTR\s*\(([^,)]+),\s*([^,)]+)\)/$2 \*$1/gos;
>  
>   create_parameterlist($members, ';', $file);
>   check_sections($file, $declaration_name, $decl_type, $sectcheck, 
> $struct_actual, $nested);
> 


-- 
~Randy

Re: [PATCH] kernel-doc: parse DECLARE_KFIFO_PTR()

[Randy Dunlap]

On 11/30/2017 05:42 AM, Mauro Carvalho Chehab wrote:
> On media, we now have an struct declared with:
> 
[snip]
> 
> So, teach kernel-doc how to parse a DECLARE_KFIFO_PTR();
> 
> While here, relax at the past DECLARE_foo() macros,
> accepting a random number of spaces after comma.
> 
> Signed-off-by: Mauro Carvalho Chehab 

Hi,

Would you mind adding the parsing of DECLARE_KFIFO() also?

../drivers/gpio/gpiolib.c:601: warning: No description found for parameter '16'
../drivers/gpio/gpiolib.c:601: warning: Excess struct member 'events' 
description in 'lineevent_state'

struct lineevent_state {
struct gpio_device *gdev;
const char *label;
struct gpio_desc *desc;
u32 eflags;
int irq;
wait_queue_head_t wait;
DECLARE_KFIFO(events, struct gpioevent_data, 16);
struct mutex read_lock;
};

> ---
>  scripts/kernel-doc | 7 ---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index bd29a92b4b48..5c12208f8c89 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -2208,10 +2208,11 @@ sub dump_struct($$) {
>   $members =~ s/__aligned\s*\([^;]*\)//gos;
>   $members =~ s/\s*CRYPTO_MINALIGN_ATTR//gos;
>   # replace DECLARE_BITMAP
> - $members =~ s/DECLARE_BITMAP\s*\(([^,)]+), ([^,)]+)\)/unsigned long 
> $1\[BITS_TO_LONGS($2)\]/gos;
> + $members =~ s/DECLARE_BITMAP\s*\(([^,)]+),\s*([^,)]+)\)/unsigned long 
> $1\[BITS_TO_LONGS($2)\]/gos;
>   # replace DECLARE_HASHTABLE
> - $members =~ s/DECLARE_HASHTABLE\s*\(([^,)]+), ([^,)]+)\)/unsigned long 
> $1\[1 << (($2) - 1)\]/gos;
> -
> + $members =~ s/DECLARE_HASHTABLE\s*\(([^,)]+),\s*([^,)]+)\)/unsigned 
> long $1\[1 << (($2) - 1)\]/gos;
> + # replace DECLARE_KFIFO_PTR(fifo, type)
> + $members =~ s/DECLARE_KFIFO_PTR\s*\(([^,)]+),\s*([^,)]+)\)/$2 \*$1/gos;
>   create_parameterlist($members, ';', $file);
>   check_sections($file, $declaration_name, $decl_type, $sectcheck, 
> $struct_actual, $nested);
>  
> 


-- 
~Randy

Re: [PATCH] media: mtk-vcodec: add missing MODULE_LICENSE/DESCRIPTION

[Randy Dunlap]

On 11/21/17 23:41, kbuild test robot wrote:
> Hi Jesse,
> 
> Thank you for the patch! Yet something to improve:

missing
#include 

Jesse, did you build all of these driver changes?


> [auto build test ERROR on linuxtv-media/master]
> [also build test ERROR on v4.14 next-20171121]
> [if your patch is applied to the wrong git tree, please drop us a note to 
> help improve the system]
> 
> url:
> https://github.com/0day-ci/linux/commits/Jesse-Chan/media-mtk-vcodec-add-missing-MODULE_LICENSE-DESCRIPTION/20171122-124620
> base:   git://linuxtv.org/media_tree.git master
> config: xtensa-allmodconfig (attached as .config)
> compiler: xtensa-linux-gcc (GCC) 4.9.0
> reproduce:
> wget 
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
> ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> make.cross ARCH=xtensa 
> 
> All errors (new ones prefixed by >>):
> 
>>> drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:55:16: error: expected 
>>> declaration specifiers or '...' before string constant
> MODULE_LICENSE("GPL v2");
>^
>drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c:56:20: error: expected 
> declaration specifiers or '...' before string constant
> MODULE_DESCRIPTION("Mediatek video codec driver");
>^
> 
> vim +55 drivers/media/platform/mtk-vcodec/mtk_vcodec_intr.c
> 
> 54
>   > 55MODULE_LICENSE("GPL v2");
> 
> ---
> 0-DAY kernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all   Intel Corporation
> 


-- 
~Randy

[PATCH] media: ddbridge: fix build warnings

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

Fix 2 build warnings.
These functions are void, so drop the "return"s.

./drivers/media/pci/ddbridge/ddbridge-io.h: warning: 'return' with a value, in 
function returning void [enabled by default]:  => 50:2, 55:2

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Cc: Daniel Scheller <d.scheller@gmail.com>
Cc: Mauro Carvalho Chehab <mche...@s-opensource.com>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
Reported-by: Geert Uytterhoeven <ge...@linux-m68k.org>
---
 drivers/media/pci/ddbridge/ddbridge-io.h |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- lnx-414-rc8.orig/drivers/media/pci/ddbridge/ddbridge-io.h
+++ lnx-414-rc8/drivers/media/pci/ddbridge/ddbridge-io.h
@@ -47,12 +47,12 @@ static inline void ddbwritel(struct ddb
 
 static inline void ddbcpyto(struct ddb *dev, u32 adr, void *src, long count)
 {
-   return memcpy_toio(dev->regs + adr, src, count);
+   memcpy_toio(dev->regs + adr, src, count);
 }
 
 static inline void ddbcpyfrom(struct ddb *dev, void *dst, u32 adr, long count)
 {
-   return memcpy_fromio(dst, dev->regs + adr, count);
+   memcpy_fromio(dst, dev->regs + adr, count);
 }
 
 static inline u32 safe_ddbreadl(struct ddb *dev, u32 adr)

Re: [PATCH v7 4/7] media: open.rst: document devnode-centric and mc-centric types

[Randy Dunlap]

On 09/27/17 15:23, Mauro Carvalho Chehab wrote:
> 
> Signed-off-by: Mauro Carvalho Chehab 
> ---
>  Documentation/media/uapi/v4l/open.rst | 40 
> +++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/Documentation/media/uapi/v4l/open.rst 
> b/Documentation/media/uapi/v4l/open.rst
> index 18030131ef77..f603bc9b49a0 100644
> --- a/Documentation/media/uapi/v4l/open.rst
> +++ b/Documentation/media/uapi/v4l/open.rst
> @@ -7,6 +7,46 @@ Opening and Closing Devices
>  ***
>  
>  
> +.. _v4l2_hardware_control:
> +
> +
> +Types of V4L2 media hardware control
> +
> +
> +V4L2 hardware periferal is usually complex: support for it is

 peripheral (in several places...)

> +implemented via a V4L2 main driver and often by several additional drivers.
> +The main driver always exposes one or more **V4L2 device nodes**
> +(see :ref:`v4l2_device_naming`) with are responsible for implementing
> +data streaming, if applicable.
> +
> +The other drivers are called **V4L2 sub-devices** and provide control to
> +other hardware components usually connected via a serial bus (like
> +I²C, SMBus or SPI). Depending on the main driver, they can be implicitly
> +controlled directly by the main driver or explicitly via
> +the **V4L2 sub-device API** (see :ref:`subdev`).
> +
> +When V4L2 was originally designed, there was only one type of
> +media hardware control: via the **V4L2 device nodes**. We refer to this kind
> +of control as **V4L2 device node centric** (or, simply, 
> "**vdevnode-centric**").
> +
> +Later (kernel 2.6.39), a new type of periferal control was
> +added in order to support complex media hardware that are common for embedded
> +systems. This type of periferal is controlled mainly via the media
> +controller and V4L2 sub-devices. So, it is called
> +**Media controller centric** (or, simply, "**MC-centric**") control.
> +
> +For **vdevnode-centric** media hardware control, the media hardware is
> +controlled via the **V4L2 device nodes**. They may optionally support the
> +:ref:`media controller API ` as well,
> +in order to inform the application which device nodes are available
> +(see :ref:`related`).
> +
> +For **MC-centric** media hardware control it is required to configure
> +the pipelines via the :ref:`media controller API ` before
> +the periferal can be used. For such devices, the sub-devices' configuration
> +can be controlled via the :ref:`sub-device API `, which creates one
> +device node per sub-device.
> +
>  .. _v4l2_device_naming:
>  
>  V4L2 Device Node Naming
> 


-- 
~Randy

Re: [PATCH v2 07/13] docs: kernel-doc.rst: add documentation about man pages

[Randy Dunlap]

On 09/27/17 14:10, Mauro Carvalho Chehab wrote:
> kernel-doc-nano-HOWTO.txt has a chapter about man pages

  kernel-doc.rst has a chapter (or section)

> production. While we don't have a working  "make manpages"
> target, add it.
> 
> Signed-off-by: Mauro Carvalho Chehab 
> ---
>  Documentation/doc-guide/kernel-doc.rst | 34 
> ++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/Documentation/doc-guide/kernel-doc.rst 
> b/Documentation/doc-guide/kernel-doc.rst
> index 0923c8bd5769..96012f9e314d 100644
> --- a/Documentation/doc-guide/kernel-doc.rst
> +++ b/Documentation/doc-guide/kernel-doc.rst


-- 
~Randy

Re: [PATCH 07/10] docs: kernel-doc.rst: add documentation about man pages

[Randy Dunlap]

On 09/26/17 10:59, Mauro Carvalho Chehab wrote:
> kernel-doc-nano-HOWTO.txt has a chapter about man pages
> production. While we don't have a working  "make manpages"
> target, add it.
> 
> Signed-off-by: Mauro Carvalho Chehab 
> ---
>  Documentation/doc-guide/kernel-doc.rst | 61 
> ++
>  1 file changed, 47 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/doc-guide/kernel-doc.rst 
> b/Documentation/doc-guide/kernel-doc.rst
> index 9777aa53e3dd..50473f0db345 100644
> --- a/Documentation/doc-guide/kernel-doc.rst
> +++ b/Documentation/doc-guide/kernel-doc.rst
> @@ -377,7 +377,6 @@ cross-references.
>  For further details, please refer to the `Sphinx C Domain`_ documentation.
>  
>  
> -
>  In-line member documentation comments
>  ~
>  
> @@ -391,19 +390,19 @@ on a line of their own, like all other kernel-doc 
> comments::
> * @foo: The Foo member.
> */
>struct foo {
> -int foo;
> -/**
> - * @bar: The Bar member.
> - */
> -int bar;
> -/**
> - * @baz: The Baz member.
> - *
> - * Here, the member description may contain several paragraphs.
> - */
> -int baz;
> -/** @foobar: Single line description. */
> -int foobar;
> + int foo;
> + /**
> +  * @bar: The Bar member.
> +  */
> + int bar;
> + /**
> +  * @baz: The Baz member.
> +  *
> +  * Here, the member description may contain several paragraphs.
> +  */
> + int baz;
> + /** @foobar: Single line description. */
> + int foobar;
>}

The above doesn't belong in this patch. (??)

>  
> @@ -452,3 +451,37 @@ file.
>  
>  Data structures visible in kernel include files should also be documented 
> using
>  kernel-doc formatted comments.
> +
> +How to use kernel-doc to generate man pages
> +---
> +
> +If you just want to use kernel-doc to generate man pages you can do this
> +from the Kernel git tree::
> +
> +  $ scripts/kernel-doc -man $(git grep -l '/\*\*' |grep -v Documentation/) | 
> ./split-man.pl /tmp/man
> +
> +Using the small ``split-man.pl`` script below::
> +
> +
> +  #!/usr/bin/perl
> +
> +  if ($#ARGV < 0) {
> + die "where do I put the results?\n";
> +  }
> +
> +  mkdir $ARGV[0],0777;
> +  $state = 0;
> +  while () {
> +  if (/^\.TH \"[^\"]*\" 9 \"([^\"]*)\"/) {
> + if ($state == 1) { close OUT }
> + $state = 1;
> + $fn = "$ARGV[0]/$1.9";
> + print STDERR "Creating $fn\n";
> + open OUT, ">$fn" or die "can't open $fn: $!\n";
> + print OUT $_;
> +  } elsif ($state != 0) {
> + print OUT $_;
> +  }
> +  }
> +
> +  close OUT;
> 


-- 
~Randy

Re: [PATCH 02/10] docs: kernel-doc.rst: better describe kernel-doc arguments

[Randy Dunlap]

On 09/26/17 10:59, Mauro Carvalho Chehab wrote:
> Add a new section to describe kernel-doc arguments,
> adding examples about how identation should happen, as failing
> to do that causes Sphinx to do the wrong thing.
> 
> Signed-off-by: Mauro Carvalho Chehab 
> ---
>  Documentation/doc-guide/kernel-doc.rst | 44 
> +++---
>  1 file changed, 41 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/doc-guide/kernel-doc.rst 
> b/Documentation/doc-guide/kernel-doc.rst
> index b24854b5d6be..7a3f5c710c0b 100644
> --- a/Documentation/doc-guide/kernel-doc.rst
> +++ b/Documentation/doc-guide/kernel-doc.rst
> @@ -112,16 +112,17 @@ Example kernel-doc function comment::
>  
>/**
> * foobar() - Brief description of foobar.
> -   * @arg: Description of argument of foobar.
> +   * @argument1: Description of parameter argument1 of foobar.
> +   * @argument1: Description of parameter argument2 of foobar.

@argument2:

> *
> * Longer description of foobar.
> *
> * Return: Description of return value of foobar.
> */
> -  int foobar(int arg)
> +  int foobar(int argument1, char *argument2)


-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/31/17 10:55, Jani Nikula wrote:
> On Thu, 31 Aug 2017, Randy Dunlap <rdun...@infradead.org> wrote:
>> On 08/31/17 09:36, Jani Nikula wrote:
>>> On Thu, 31 Aug 2017, Jani Nikula <jani.nik...@linux.intel.com> wrote:
>>>> On Thu, 31 Aug 2017, Randy Dunlap <rdun...@infradead.org> wrote:
>>>>> On 08/31/17 07:17, Jonathan Corbet wrote:
>>>>>> On Thu, 31 Aug 2017 10:56:26 -0300
>>>>>> Mauro Carvalho Chehab <mche...@s-opensource.com> wrote:
>>>>>>
>>>>>>> It should have something to do with python version and/or to some
>>>>>>> locale info at the system, as neither I or Jon can reproduce it.
>>>>>>
>>>>>> I can't reproduce it here, but I have certainly seen situations where
>>>>>> Python 2 wants to run with the ascii codec by default.
>>>>>>
>>>>>> Note that the exception happens in our Sphinx extension, not in Sphinx
>>>>>> itself.  We've had other non-ascii text in our docs, so I think Sphinx is
>>>>>> doing the right thing.  The problem is with our own code.  If I could
>>>>>> reproduce it, it shouldn't be too hard to track down - take out that
>>>>>> massive "except anything" block and see where it explodes.
>>>>>>
>>>>>> Randy, which distribution are you running, and are you using their 
>>>>>> version
>>>>>> of Sphinx?
>>>>>
>>>>> opensuse LEAP 42.2
>>>>> Yes, their sphinx 1.3.1.
>>>>
>>>> What's your LANG setting? I think that's what it boils down to, and
>>>> trying to work around non-UTF-8 LANG in both python 2 and 3 compatible
>>>> ways.
>>>>
>>>> The odd thing is that I can reproduce the issue using a small python
>>>> snippet, but not through Sphinx.
>>>
>>> Your original error message suggests your Sphinx actually uses python
>>> 3. Can you check that? The clue is that it's the *decode* that fails.
>>
>> Where do you see that clue?
> 
> The message, "'ascii' codec can't decode byte 0xe2 in position 6368:
> ordinal not in range(128)". In my testing I could only get that *decode*
> error message using python 3.
> 
>> My /usr/bin/python is linked to python2.7:
>>
>>> ll /usr/bin/python
>> lrwxrwxrwx 1 root root 9 Jun 10 19:59 /usr/bin/python -> python2.7*
> 
> Sure, but how about 'head $(which sphinx-build)'?

You are correct:

#!/usr/bin/python3

> I could be completely mistaken too. ;)


-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/31/17 10:34, Randy Dunlap wrote:
> On 08/31/17 09:36, Jani Nikula wrote:
>> On Thu, 31 Aug 2017, Jani Nikula <jani.nik...@linux.intel.com> wrote:
>>> On Thu, 31 Aug 2017, Randy Dunlap <rdun...@infradead.org> wrote:
>>>> On 08/31/17 07:17, Jonathan Corbet wrote:
>>>>> On Thu, 31 Aug 2017 10:56:26 -0300
>>>>> Mauro Carvalho Chehab <mche...@s-opensource.com> wrote:
>>>>>
>>>>>> It should have something to do with python version and/or to some
>>>>>> locale info at the system, as neither I or Jon can reproduce it.
>>>>>
>>>>> I can't reproduce it here, but I have certainly seen situations where
>>>>> Python 2 wants to run with the ascii codec by default.
>>>>>
>>>>> Note that the exception happens in our Sphinx extension, not in Sphinx
>>>>> itself.  We've had other non-ascii text in our docs, so I think Sphinx is
>>>>> doing the right thing.  The problem is with our own code.  If I could
>>>>> reproduce it, it shouldn't be too hard to track down - take out that
>>>>> massive "except anything" block and see where it explodes.
>>>>>
>>>>> Randy, which distribution are you running, and are you using their version
>>>>> of Sphinx?
>>>>
>>>> opensuse LEAP 42.2
>>>> Yes, their sphinx 1.3.1.
>>>
>>> What's your LANG setting? I think that's what it boils down to, and
>>> trying to work around non-UTF-8 LANG in both python 2 and 3 compatible
>>> ways.
>>>
>>> The odd thing is that I can reproduce the issue using a small python
>>> snippet, but not through Sphinx.
>>
>> Your original error message suggests your Sphinx actually uses python
>> 3. Can you check that? The clue is that it's the *decode* that fails.
> 
> Where do you see that clue?
> My /usr/bin/python is linked to python2.7:
> 
>> ll /usr/bin/python
> lrwxrwxrwx 1 root root 9 Jun 10 19:59 /usr/bin/python -> python2.7*
> 
>> Does the below patch help? It avoids the implicit ascii decoding due to
>> universal_newlines=True and your LANG setting, and does explicit utf-8
>> decoding instead.
>>
>> Fingers crossed.
> 
> testing now.

Yes, that works for me.  Thanks.

-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/31/17 09:36, Jani Nikula wrote:
> On Thu, 31 Aug 2017, Jani Nikula <jani.nik...@linux.intel.com> wrote:
>> On Thu, 31 Aug 2017, Randy Dunlap <rdun...@infradead.org> wrote:
>>> On 08/31/17 07:17, Jonathan Corbet wrote:
>>>> On Thu, 31 Aug 2017 10:56:26 -0300
>>>> Mauro Carvalho Chehab <mche...@s-opensource.com> wrote:
>>>>
>>>>> It should have something to do with python version and/or to some
>>>>> locale info at the system, as neither I or Jon can reproduce it.
>>>>
>>>> I can't reproduce it here, but I have certainly seen situations where
>>>> Python 2 wants to run with the ascii codec by default.
>>>>
>>>> Note that the exception happens in our Sphinx extension, not in Sphinx
>>>> itself.  We've had other non-ascii text in our docs, so I think Sphinx is
>>>> doing the right thing.  The problem is with our own code.  If I could
>>>> reproduce it, it shouldn't be too hard to track down - take out that
>>>> massive "except anything" block and see where it explodes.
>>>>
>>>> Randy, which distribution are you running, and are you using their version
>>>> of Sphinx?
>>>
>>> opensuse LEAP 42.2
>>> Yes, their sphinx 1.3.1.
>>
>> What's your LANG setting? I think that's what it boils down to, and
>> trying to work around non-UTF-8 LANG in both python 2 and 3 compatible
>> ways.
>>
>> The odd thing is that I can reproduce the issue using a small python
>> snippet, but not through Sphinx.
> 
> Your original error message suggests your Sphinx actually uses python
> 3. Can you check that? The clue is that it's the *decode* that fails.

Where do you see that clue?
My /usr/bin/python is linked to python2.7:

> ll /usr/bin/python
lrwxrwxrwx 1 root root 9 Jun 10 19:59 /usr/bin/python -> python2.7*

> Does the below patch help? It avoids the implicit ascii decoding due to
> universal_newlines=True and your LANG setting, and does explicit utf-8
> decoding instead.
> 
> Fingers crossed.

testing now.

-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/31/17 09:05, Jani Nikula wrote:
> On Thu, 31 Aug 2017, Randy Dunlap <rdun...@infradead.org> wrote:
>> On 08/31/17 07:17, Jonathan Corbet wrote:
>>> On Thu, 31 Aug 2017 10:56:26 -0300
>>> Mauro Carvalho Chehab <mche...@s-opensource.com> wrote:
>>>
>>>> It should have something to do with python version and/or to some
>>>> locale info at the system, as neither I or Jon can reproduce it.
>>>
>>> I can't reproduce it here, but I have certainly seen situations where
>>> Python 2 wants to run with the ascii codec by default.
>>>
>>> Note that the exception happens in our Sphinx extension, not in Sphinx
>>> itself.  We've had other non-ascii text in our docs, so I think Sphinx is
>>> doing the right thing.  The problem is with our own code.  If I could
>>> reproduce it, it shouldn't be too hard to track down - take out that
>>> massive "except anything" block and see where it explodes.
>>>
>>> Randy, which distribution are you running, and are you using their version
>>> of Sphinx?
>>
>> opensuse LEAP 42.2
>> Yes, their sphinx 1.3.1.
> 
> What's your LANG setting? I think that's what it boils down to, and
> trying to work around non-UTF-8 LANG in both python 2 and 3 compatible
> ways.

(default)
LANG=C

until I add the patch:
+LANG=C.utf-8

> The odd thing is that I can reproduce the issue using a small python
> snippet, but not through Sphinx.



-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/31/17 02:49, Mauro Carvalho Chehab wrote:
> Em Wed, 30 Aug 2017 15:02:59 -0700
> Randy Dunlap <rdun...@infradead.org> escreveu:
> 
>> On 08/30/17 14:23, Jonathan Corbet wrote:
>>> On Mon, 28 Aug 2017 16:10:09 -0700
>>> Randy Dunlap <rdun...@infradead.org> wrote:
>>>   
>>>> kernel-doc parsing uses as ASCII codec, so let people know that
>>>> kernel-doc comments should be in ASCII characters only.
>>>>
>>>> WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno 
>>>> ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec 
>>>> can't decode byte 0xe2 in position 6368: ordinal not in range(128)  
>>>
>>> So I don't get this error.  What kind of system are you running the docs
>>> build on?  I would really rather that the docs system could handle modern
>>> text if possible, so it would be better to figure out what's going on
>>> here...  
>>
>> I'm OK with that. Source files in general don't need to be ASCII (0-127).
>>
>> I did this patch based on this (private) comment:
>>
>>> Yes, using ASCII should fix the problem.  
>>
>> what kind of system?  HP laptop.
>>
>> Linux midway.site 4.4.79-18.26-default #1 SMP Thu Aug 10 20:30:05 UTC 2017 
>> (fa5a935) x86_64 x86_64 x86_64 GNU/Linux
>>
>>> sphinx-build --version  
>> Sphinx (sphinx-build) 1.3.1
> 
> I tried hard to reproduce the error here... I even added some Chinese
> chars on a kernel-doc markup and changed the language on my system
> to LANG=en_US.iso885915.
> 
> No luck. 
> 
> As Documentation/conf.py has:
> 
>   # -*- coding: utf-8 -*-
> 
> on its first line, I suspect that the error you're getting is likely
> due to the usage of a python version that doesn't recognize this.
> 
> It seems that such dialect was introduced on python version 2.3:
> 
>   https://docs.python.org/2.3/whatsnew/section-encodings.html
> 
> Yet, the documentation there seems to require a line before it,
> e. g.:
> 
>   #!/usr/bin/env python
>   # -*- coding: UTF-8 -*-
> 
> I suspect, however, that, if such line is added, on some systems it
> may not work, e. g. if both python 2 and 3 are installed, it could
> use the python version that doesn't have Sphinx installed.
> 
> So, I suspect that the safest way to fix it is with something like the
> enclosed patch. Still, it could be useful to know what's happening,
> just in case we get other reports.
> 
> Randy,
> 
> What's your python version?

> python --version
Python 2.7.13



-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/31/17 07:17, Jonathan Corbet wrote:
> On Thu, 31 Aug 2017 10:56:26 -0300
> Mauro Carvalho Chehab  wrote:
> 
>> It should have something to do with python version and/or to some
>> locale info at the system, as neither I or Jon can reproduce it.
> 
> I can't reproduce it here, but I have certainly seen situations where
> Python 2 wants to run with the ascii codec by default.
> 
> Note that the exception happens in our Sphinx extension, not in Sphinx
> itself.  We've had other non-ascii text in our docs, so I think Sphinx is
> doing the right thing.  The problem is with our own code.  If I could
> reproduce it, it shouldn't be too hard to track down - take out that
> massive "except anything" block and see where it explodes.
> 
> Randy, which distribution are you running, and are you using their version
> of Sphinx?

opensuse LEAP 42.2
Yes, their sphinx 1.3.1.


-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/30/17 16:04, Randy Dunlap wrote:
> On 08/30/17 16:01, Randy Dunlap wrote:
>> On 08/30/17 15:31, Jonathan Corbet wrote:
>>> On Wed, 30 Aug 2017 19:15:53 -0300
>>> Mauro Carvalho Chehab <mche...@s-opensource.com> wrote:
>>>
>>>> I suspect that the problem is not related to the version, but to
>>>> what you might have set on LANG.
>>>>
>>>> Maybe if we add something like:
>>>>LANG=C.utf-8
>>>>
>>>> to the Documentation/Makefile 
>>>
>>> That's worth a try; Randy, can you give it a quick go?
>>
>> Yes, that fixes it for me.  Thanks.
> 
> Wait!  I forgot to unpatch demux.h.  I'll test again now

OK, still works for me.

> 
>>>> or adding:
>>>>
>>>>.. -*- coding: utf-8; mode: rst -*-
>>>>
>>>> as the first line on the *.rst file that include the kernel-doc 
>>>> directive would solve the issue.
>>>
>>> I guess I don't see how that would help, instead.  Emacs reads that line,
>>> but it's not involved in the problem.
>>>
>>> I wish I could reproduce this, then we could see what in that massive
>>> try..except block in kerneldoc.py is throwing the exception.  Putting in
>>> an explicit decode call might be enough to make the problem go away.
>>
>>
>>
> 
> 


-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/30/17 16:01, Randy Dunlap wrote:
> On 08/30/17 15:31, Jonathan Corbet wrote:
>> On Wed, 30 Aug 2017 19:15:53 -0300
>> Mauro Carvalho Chehab <mche...@s-opensource.com> wrote:
>>
>>> I suspect that the problem is not related to the version, but to
>>> what you might have set on LANG.
>>>
>>> Maybe if we add something like:
>>> LANG=C.utf-8
>>>
>>> to the Documentation/Makefile 
>>
>> That's worth a try; Randy, can you give it a quick go?
> 
> Yes, that fixes it for me.  Thanks.

Wait!  I forgot to unpatch demux.h.  I'll test again now

>>> or adding:
>>>
>>> .. -*- coding: utf-8; mode: rst -*-
>>>
>>> as the first line on the *.rst file that include the kernel-doc 
>>> directive would solve the issue.
>>
>> I guess I don't see how that would help, instead.  Emacs reads that line,
>> but it's not involved in the problem.
>>
>> I wish I could reproduce this, then we could see what in that massive
>> try..except block in kerneldoc.py is throwing the exception.  Putting in
>> an explicit decode call might be enough to make the problem go away.
> 
> 
> 


-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/30/17 15:31, Jonathan Corbet wrote:
> On Wed, 30 Aug 2017 19:15:53 -0300
> Mauro Carvalho Chehab  wrote:
> 
>> I suspect that the problem is not related to the version, but to
>> what you might have set on LANG.
>>
>> Maybe if we add something like:
>>  LANG=C.utf-8
>>
>> to the Documentation/Makefile 
> 
> That's worth a try; Randy, can you give it a quick go?

Yes, that fixes it for me.  Thanks.

>> or adding:
>>
>>  .. -*- coding: utf-8; mode: rst -*-
>>
>> as the first line on the *.rst file that include the kernel-doc 
>> directive would solve the issue.
> 
> I guess I don't see how that would help, instead.  Emacs reads that line,
> but it's not involved in the problem.
> 
> I wish I could reproduce this, then we could see what in that massive
> try..except block in kerneldoc.py is throwing the exception.  Putting in
> an explicit decode call might be enough to make the problem go away.



-- 
~Randy

Re: [PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

On 08/30/17 14:23, Jonathan Corbet wrote:
> On Mon, 28 Aug 2017 16:10:09 -0700
> Randy Dunlap <rdun...@infradead.org> wrote:
> 
>> kernel-doc parsing uses as ASCII codec, so let people know that
>> kernel-doc comments should be in ASCII characters only.
>>
>> WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno 
>> ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec 
>> can't decode byte 0xe2 in position 6368: ordinal not in range(128)
> 
> So I don't get this error.  What kind of system are you running the docs
> build on?  I would really rather that the docs system could handle modern
> text if possible, so it would be better to figure out what's going on
> here...

I'm OK with that. Source files in general don't need to be ASCII (0-127).

I did this patch based on this (private) comment:

> Yes, using ASCII should fix the problem.

what kind of system?  HP laptop.

Linux midway.site 4.4.79-18.26-default #1 SMP Thu Aug 10 20:30:05 UTC 2017 
(fa5a935) x86_64 x86_64 x86_64 GNU/Linux

> sphinx-build --version
Sphinx (sphinx-build) 1.3.1


-- 
~Randy

[PATCH 2/2] media: dvb-core: fix demux.h non-ASCII characters

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

Fix non-ASCII charactes in kernel-doc comment to prevent the kernel-doc
build warning below.

WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno 
../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec can't 
decode byte 0xe2 in position 6368: ordinal not in range(128)

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
---
 drivers/media/dvb-core/demux.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-413-rc7.orig/drivers/media/dvb-core/demux.h
+++ lnx-413-rc7/drivers/media/dvb-core/demux.h
@@ -210,7 +210,7 @@ struct dmx_section_feed {
  * the start of the first undelivered TS packet within a circular buffer.
  * The @buffer2 buffer parameter is normally NULL, except when the received
  * TS packets have crossed the last address of the circular buffer and
- * ”wrapped” to the beginning of the buffer. In the latter case the @buffer1
+ * "wrapped" to the beginning of the buffer. In the latter case the @buffer1
  * parameter would contain an address within the circular buffer, while the
  * @buffer2 parameter would contain the first address of the circular buffer.
  * The number of bytes delivered with this function (i.e. @buffer1_length +

[PATCH 1/2] docs: kernel-doc comments are ASCII

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

kernel-doc parsing uses as ASCII codec, so let people know that
kernel-doc comments should be in ASCII characters only.

WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno 
../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec can't 
decode byte 0xe2 in position 6368: ordinal not in range(128)

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
---
 Documentation/doc-guide/kernel-doc.rst |3 +++
 1 file changed, 3 insertions(+)

--- lnx-413-rc7.orig/Documentation/doc-guide/kernel-doc.rst
+++ lnx-413-rc7/Documentation/doc-guide/kernel-doc.rst
@@ -108,6 +108,9 @@ The function and type kernel-doc comment
 function or type being described. The overview kernel-doc comments may be 
freely
 placed at the top indentation level.
 
+.. attention:: kernel-doc comments should be written **only** in ASCII
+  characters since they are processed as ASCII input.
+
 Example kernel-doc function comment::
 
   /**

Re: linux-next: Tree for Jul 21 (drivers/media: use of __WARN())

[Randy Dunlap]

On 07/20/2017 09:10 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20170720:
> 

on x86_64:
when CONFIG_BUG is not enabled:

../drivers/media/platform/pxa_camera.c:642:3: error: implicit declaration of 
function ‘__WARN’ [-Werror=implicit-function-declaration]
../drivers/media/platform/soc_camera/soc_mediabus.c:512:3: error: implicit 
declaration of function ‘__WARN’ [-Werror=implicit-function-declaration]


-- 
~Randy

[PATCH -next] media: ov5670: add depends to fix build errors

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

Fix build errors by adding dependency on VIDEO_V4L2_SUBDEV_API:

../drivers/media/i2c/ov5670.c: In function 'ov5670_open':
../drivers/media/i2c/ov5670.c:1917:5: error: implicit declaration of function 
'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
 v4l2_subdev_get_try_format(sd, fh->pad, 0);
../drivers/media/i2c/ov5670.c:1917:38: error: 'struct v4l2_subdev_fh' has no 
member named 'pad'
 v4l2_subdev_get_try_format(sd, fh->pad, 0);
../drivers/media/i2c/ov5670.c: In function 'ov5670_do_get_pad_format':
../drivers/media/i2c/ov5670.c:2198:17: error: invalid type argument of unary 
'*' (have 'int')
   fmt->format = *v4l2_subdev_get_try_format(>sd, cfg,
../drivers/media/i2c/ov5670.c: In function 'ov5670_set_pad_format':
../drivers/media/i2c/ov5670.c:2236:3: error: invalid type argument of unary '*' 
(have 'int')
   *v4l2_subdev_get_try_format(sd, cfg, fmt->pad) = fmt->format;
../drivers/media/i2c/ov5670.c: At top level:
../drivers/media/i2c/ov5670.c:2444:19: error: 'v4l2_subdev_link_validate' 
undeclared here (not in a function)
  .link_validate = v4l2_subdev_link_validate,
../drivers/media/i2c/ov5670.c: In function 'ov5670_probe':
../drivers/media/i2c/ov5670.c:2492:12: error: 'struct v4l2_subdev' has no 
member named 'entity'
  ov5670->sd.entity.ops = _subdev_entity_ops;
../drivers/media/i2c/ov5670.c:2493:12: error: 'struct v4l2_subdev' has no 
member named 'entity'
  ov5670->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
../drivers/media/i2c/ov5670.c:2497:42: error: 'struct v4l2_subdev' has no 
member named 'entity'
  ret = media_entity_pads_init(>sd.entity, 1, >pad);
../drivers/media/i2c/ov5670.c:2524:34: error: 'struct v4l2_subdev' has no 
member named 'entity'
  media_entity_cleanup(>sd.entity);
../drivers/media/i2c/ov5670.c: In function 'ov5670_remove':
../drivers/media/i2c/ov5670.c:2544:26: error: 'struct v4l2_subdev' has no 
member named 'entity'
  media_entity_cleanup(>entity);

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Cc: "Rapolu, Chiranjeevi" <chiranjeevi.rap...@intel.com>
Cc: "Yang, Hyungwoo" <hyungwoo.y...@intel.com>
---
 drivers/media/i2c/Kconfig |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20170720.orig/drivers/media/i2c/Kconfig
+++ linux-next-20170720/drivers/media/i2c/Kconfig
@@ -618,7 +618,7 @@ config VIDEO_OV6650
 
 config VIDEO_OV5670
tristate "OmniVision OV5670 sensor support"
-   depends on I2C && VIDEO_V4L2
+   depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
depends on MEDIA_CAMERA_SUPPORT
select V4L2_FWNODE
---help---

Re: linux-next: Tree for Jun 8 (drivers/media/i2c/adv7604.c)

[Randy Dunlap]

On 06/08/17 00:50, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20170607:
> 

on x86_64: (randconfig)

CONFIG_VIDEO_ADV7604=y
# CONFIG_VIDEO_ADV7604_CEC is not set
CONFIG_COMPILE_TEST=y


drivers/built-in.o: In function `adv76xx_unregistered':
adv7604.c:(.text+0x43ad91): undefined reference to `cec_unregister_adapter'
drivers/built-in.o: In function `adv76xx_registered':
adv7604.c:(.text+0x43adc4): undefined reference to `cec_register_adapter'
adv7604.c:(.text+0x43adef): undefined reference to `cec_delete_adapter'
drivers/built-in.o: In function `adv76xx_set_edid':
adv7604.c:(.text+0x43daab): undefined reference to `cec_get_edid_phys_addr'
adv7604.c:(.text+0x43dabd): undefined reference to `cec_phys_addr_validate'
adv7604.c:(.text+0x43df5d): undefined reference to `cec_s_phys_addr'




-- 
~Randy

[PATCH -next] media/platform/mtk-jpeg: add slab.h to fix build errors

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

Include  to fix these build errors:

../drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function 'mtk_jpeg_open':
../drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:2: error: implicit 
declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
  ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
../drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning: assignment 
makes pointer from integer without a cast [enabled by default]
  ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
../drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit 
declaration of function 'kfree' [-Werror=implicit-function-declaration]
  kfree(ctx);

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Cc: Ming Hsiu Tsai <minghsiu.t...@mediatek.com>
Cc: Rick Chang <rick.ch...@mediatek.com>
Cc: Bin Liu <bin@mediatek.com>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c |1 +
 1 file changed, 1 insertion(+)

--- linux-next-20170306.orig/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ linux-next-20170306/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -22,6 +22,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 

[PATCH] media: fix dm1105.c build error

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

Fix dm1105 build error when CONFIG_I2C_ALGOBIT=m and
CONFIG_DVB_DM1105=y.

drivers/built-in.o: In function `dm1105_probe':
dm1105.c:(.text+0x2836e7): undefined reference to `i2c_bit_add_bus'

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Reported-by: kbuild test robot <fengguang...@intel.com>
Cc: Javier Martinez Canillas <jav...@osg.samsung.com>
Cc: sta...@vger.kernel.org # applies to 4.0 (maybe even 3.x)
---
 drivers/media/pci/dm1105/Kconfig |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-410-rc2.orig/drivers/media/pci/dm1105/Kconfig
+++ lnx-410-rc2/drivers/media/pci/dm1105/Kconfig
@@ -1,6 +1,6 @@
 config DVB_DM1105
tristate "SDMC DM1105 based PCI cards"
-   depends on DVB_CORE && PCI && I2C
+   depends on DVB_CORE && PCI && I2C && I2C_ALGOBIT
select DVB_PLL if MEDIA_SUBDRV_AUTOSELECT
select DVB_STV0299 if MEDIA_SUBDRV_AUTOSELECT
select DVB_STV0288 if MEDIA_SUBDRV_AUTOSELECT
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] media: usb: dvb-usb: fix DIBUSB_MB usage of dib3000mc functions

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

The problem is that this driver uses a "common" driver supplement
which calls a few dib3000mc*() functions but that driver is not
"select"ed by DVB_USB_DIBUSB_MB. We can fix the build errors by
selecting DVB_DIB3000MC (at the expense of around 8 KB on x86_64)
just to add a few "library-like" functions.

Or someone can split the required functions into a separate
buildable file, but for such an ancient driver, I don't see the
need to do this.

Fixes these build errors:

drivers/built-in.o: In function `dibusb_dib3000mc_frontend_attach':
(.text+0x1a63bd): undefined reference to `dib3000mc_pid_parse'
drivers/built-in.o: In function `dibusb_dib3000mc_frontend_attach':
(.text+0x1a63c5): undefined reference to `dib3000mc_pid_control'
drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach':
(.text+0x1a6610): undefined reference to `dib3000mc_set_config'

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Reported-by: Fengguang Wu <fengguang...@intel.com>
Cc: Joe Perches <j...@perches.com>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
Cc: linux-media@vger.kernel.org
---
 drivers/media/usb/dvb-usb/Kconfig |1 +
 1 file changed, 1 insertion(+)

--- lnx-48-rc3.orig/drivers/media/usb/dvb-usb/Kconfig
+++ lnx-48-rc3/drivers/media/usb/dvb-usb/Kconfig
@@ -34,6 +34,7 @@ config DVB_USB_DIBUSB_MB
depends on DVB_USB
select DVB_PLL if MEDIA_SUBDRV_AUTOSELECT
select DVB_DIB3000MB
+   select DVB_DIB3000MC
select MEDIA_TUNER_MT2060 if MEDIA_SUBDRV_AUTOSELECT
help
  Support for USB 1.1 and 2.0 DVB-T receivers based on reference 
designs made by
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] dma-buf: fix kernel-doc warning and typos

[Randy Dunlap]

From: Randy Dunlap <rdun...@infradead.org>

Fix dma-buf kernel-doc warning and 2 minor typos in
fence_array_create().

Fixes this warning:
..//drivers/dma-buf/fence-array.c:124: warning: No description found for 
parameter 'signal_on_any'

Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Cc: Sumit Semwal <sumit.sem...@linaro.org>
Cc: linux-media@vger.kernel.org
Cc: dri-de...@lists.freedesktop.org
Cc: linaro-mm-...@lists.linaro.org
---
 drivers/dma-buf/fence-array.c |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- lnx-48-rc2.orig/drivers/dma-buf/fence-array.c
+++ lnx-48-rc2/drivers/dma-buf/fence-array.c
@@ -106,14 +106,14 @@ const struct fence_ops fence_array_ops =
  * @fences:[in]array containing the fences
  * @context:   [in]fence context to use
  * @seqno: [in]sequence number to use
- * @signal_on_any  [in]signal on any fence in the array
+ * @signal_on_any: [in]signal on any fence in the array
  *
  * Allocate a fence_array object and initialize the base fence with 
fence_init().
  * In case of error it returns NULL.
  *
- * The caller should allocte the fences array with num_fences size
+ * The caller should allocate the fences array with num_fences size
  * and fill it with the fences it wants to add to the object. Ownership of this
- * array is take and fence_put() is used on each fence on release.
+ * array is taken and fence_put() is used on each fence on release.
  *
  * If @signal_on_any is true the fence array signals if any fence in the array
  * signals, otherwise it signals when all fences in the array signal.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro

[Randy Dunlap]

On 08/02/16 05:51, Mauro Carvalho Chehab wrote:
> Em Tue,  2 Aug 2016 20:01:34 +0800
> Baole Ni  escreveu:
> 
>> I find that the developers often just specified the numeric value
>> when calling a macro which is defined with a parameter for access permission.
>> As we know, these numeric value for access permission have had the 
>> corresponding macro,
>> and that using macro can improve the robustness and readability of the code,
>> thus, I suggest replacing the numeric parameter with the macro.
> 
> Gah!
> 
> A patch series with 1285 patches with identical subject!
> 
> Please don't ever do something like that. My inbox is not trash!
> 
> Instead, please group the changes per subsystem, and use different
> names for each patch. Makes easier for people to review.
> 
> also, you need to send the patches to the subsystem mainatiner, and
> not adding a random list of people like this:
> 
> To: gre...@linuxfoundation.org, mauroche...@gmail.com, mche...@infradead.org, 
> mche...@redhat.com, m.che...@samsung.com, m.szyprow...@samsung.com, 
> kyungmin.p...@samsung.com, k.kozlow...@samsung.com
> 
> Btw, use *just* the more recent email of the maintainer, instead of
> spamming trash to all our emails (even to the ones that we don't use
> anymore!
> 
> I'll just send all those things to /dev/null until you fix your
> email sending process.
>
+1285

There are people at Intel who know about things like this.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Failed to build on 4.2.6

[Randy Dunlap]

On 12/07/15 07:25, Steven Rostedt wrote:
> Hi,
> 
> The attached config doesn't build on 4.2.6, but changing it to the
> following:
> 
>  VIDEO_V4L2_SUBDEV_API n -> y
> +V4L2_FLASH_LED_CLASS n
> 
> does build.
> 
> Sorry, I lost the build error (currently building now with a good
> config), But it's because in drivers/media/i2c/adv7604.c,
> v4l2_subdev_get_try_format() is not defined.
> 
> -- Steve
> 

4.2 stable needs this patch:

commit fc88dd16a0e430f57458e6bd9b62a631c6ea53a1
Author: Hans Verkuil 
Date:   Mon Sep 21 08:42:04 2015 -0300

[media] cobalt: fix Kconfig dependency

The cobalt driver should depend on VIDEO_V4L2_SUBDEV_API.

===

There was also an intervening patch which may cause some editing:

commit 2f8e75d2762496bb2fcea7fa437a3339d2a6d9d4
Author: Geert Uytterhoeven 
Date:   Mon Jun 29 10:45:56 2015 -0300

[media] adv7604/cobalt: Allow compile test if !GPIOLIB



-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ERROR: "vb2_ops_wait_finish" [drivers/input/touchscreen/sur40.ko] undefined!

[Randy Dunlap]

On 10/17/15 17:38, kbuild test robot wrote:
> Hi Florian,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
> master
> head:   81429a6dbcbf3a01830de42dbdf0d9acbe68e1c1
> commit: e831cd251fb91d6c25352d322743db0d17ea11dd [media] add raw video stream 
> support for Samsung SUR40
> date:   7 months ago
> config: x86_64-randconfig-s5-10180707 (attached as .config)
> reproduce:
> git checkout e831cd251fb91d6c25352d322743db0d17ea11dd
> # save the attached .config to linux build tree
> make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>>> ERROR: "vb2_ops_wait_finish" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_ops_wait_prepare" [drivers/input/touchscreen/sur40.ko] 
>>> undefined!
>>> ERROR: "vb2_fop_release" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "v4l2_fh_open" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_fop_mmap" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "video_ioctl2" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_fop_poll" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_fop_read" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_ioctl_streamoff" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_ioctl_streamon" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_ioctl_create_bufs" [drivers/input/touchscreen/sur40.ko] 
>>> undefined!
>>> ERROR: "vb2_ioctl_dqbuf" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_ioctl_expbuf" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_ioctl_qbuf" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_ioctl_querybuf" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_ioctl_reqbufs" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "__video_register_device" [drivers/input/touchscreen/sur40.ko] 
>>> undefined!
>>> ERROR: "video_device_release_empty" [drivers/input/touchscreen/sur40.ko] 
>>> undefined!
>>> ERROR: "vb2_dma_sg_init_ctx" [drivers/input/touchscreen/sur40.ko] undefined!
>>> ERROR: "vb2_queue_init" [drivers/input/touchscreen/sur40.ko] undefined!
> 
> ---
> 0-DAY kernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all   Intel Corporation
> 

patch is here:  https://lkml.org/lkml/2015/7/10/507


-- 
~Randy Dunlab

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH, newbie, HELP] lirc devices: Missing uapi header lirc.h

[Randy Dunlap]

[adding linux-media + Alan Cox]


On 09/08/15 03:51, Alec Leamas wrote:
> Hi,
> 
> I have filed a bug + a patch at [1]. This is my first contact with the kernel 
> community, and I probably make it the wrong way. That said, after a first 
> acknowledge in the tracker that this indeed a bug, I've got no response since 
> last Christmas.
> 
> Is there anything I can do to get this rolling?
> 
> Cheers!
> 
> --alec
> 
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=75751
> -- 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Aug 24 (media/i2c/tc358743.c)

[Randy Dunlap]

On 08/24/15 04:52, Stephen Rothwell wrote:
 Hi all,
 
 Changes since 20150821:
 


on x86_64:

drivers/built-in.o: In function `print_avi_infoframe':
tc358743.c:(.text.unlikely+0x7849): undefined reference to 
`hdmi_infoframe_unpack'
tc358743.c:(.text.unlikely+0x787e): undefined reference to `hdmi_infoframe_log'


Needs to select HDMI ?


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Aug 18 (drivers/media/i2c/tc358743.c)

[Randy Dunlap]

On 08/18/15 04:40, Stephen Rothwell wrote:
 Hi all,
 
 Changes since 20150817:
 

on i386:

when CONFIG_MEDIA_CONTROLLER is not enabled:

../drivers/media/i2c/tc358743.c: In function 'tc358743_probe':
../drivers/media/i2c/tc358743.c:1890:29: error: 'struct v4l2_subdev' has no 
member named 'entity'
  err = media_entity_init(sd-entity, 1, state-pad, 0);
 ^
../drivers/media/i2c/tc358743.c:1940:26: error: 'struct v4l2_subdev' has no 
member named 'entity'
  media_entity_cleanup(sd-entity);
  ^
../drivers/media/i2c/tc358743.c: In function 'tc358743_remove':
../drivers/media/i2c/tc358743.c:1955:26: error: 'struct v4l2_subdev' has no 
member named 'entity'
  media_entity_cleanup(sd-entity);
  ^



-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: randconfig build error with next-20150620, in drivers/media/v4l2-core/videobuf2-core.c

[Randy Dunlap]

On 06/20/15 09:44, Jim Davis wrote:
 Building with the attached random configuration file,
 
 drivers/media/v4l2-core/videobuf2-core.c: In function 
 ‘vb2_warn_zero_bytesused’:
 drivers/media/v4l2-core/videobuf2-core.c:1253:2: error: implicit declaration 
 of
 function ‘__WARN’ [-Werror=implicit-function-declaration]
   __WARN();
   ^
 

When CONFIG_BUG is not enabled, there is no definition of __WARN().

Should be add an empty stub for __WARN() or just change the only
user (caller) of it to do something different?

-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] media/pci/cobalt: fix Kconfig and build when SND is not enabled

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix build errors in cobalt driver when CONFIG_SND is not enabled.
Fixes these build errors:

ERROR: snd_pcm_period_elapsed [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: _snd_pcm_stream_lock_irqsave [drivers/media/pci/cobalt/cobalt.ko] 
undefined!
ERROR: snd_pcm_hw_constraint_integer [drivers/media/pci/cobalt/cobalt.ko] 
undefined!
ERROR: snd_pcm_set_ops [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: snd_pcm_stream_unlock_irqrestore [drivers/media/pci/cobalt/cobalt.ko] 
undefined!
ERROR: snd_pcm_lib_ioctl [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: snd_card_new [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: snd_card_free [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: snd_card_register [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: snd_pcm_new [drivers/media/pci/cobalt/cobalt.ko] undefined!

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Hans Verkuil hans.verk...@cisco.com
---
 drivers/media/pci/cobalt/Kconfig |1 +
 1 file changed, 1 insertion(+)

--- linux-next-20150626.orig/drivers/media/pci/cobalt/Kconfig
+++ linux-next-20150626/drivers/media/pci/cobalt/Kconfig
@@ -2,6 +2,7 @@ config VIDEO_COBALT
tristate Cisco Cobalt support
depends on VIDEO_V4L2  I2C  MEDIA_CONTROLLER
depends on PCI_MSI  MTD_COMPLEX_MAPPINGS  GPIOLIB
+   depends on SND
select I2C_ALGOBIT
select VIDEO_ADV7604
select VIDEO_ADV7511
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] media/dvb: fix ts2020.c Kconfig and build

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix kconfig warning that is caused by DVB_TS2020:

warning: (DVB_TS2020  SND_SOC_ADAU1761_I2C  SND_SOC_ADAU1781_I2C  
SND_SOC_ADAU1977_I2C  SND_SOC_RT5677  EXTCON_MAX14577  EXTCON_MAX77693  
EXTCON_MAX77843) selects REGMAP_I2C which has unmet direct dependencies (I2C)

This fixes many subsequent build errors.

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Mauro Carvalho Chehab mche...@osg.samsung.com
Cc: Konstantin Dimitrov kosio.dimit...@gmail.com
---
 drivers/media/dvb-frontends/Kconfig |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20150626.orig/drivers/media/dvb-frontends/Kconfig
+++ linux-next-20150626/drivers/media/dvb-frontends/Kconfig
@@ -240,7 +240,7 @@ config DVB_SI21XX
 
 config DVB_TS2020
tristate Montage Tehnology TS2020 based tuners
-   depends on DVB_CORE
+   depends on DVB_CORE  I2C
select REGMAP_I2C
default m if !MEDIA_SUBDRV_AUTOSELECT
help
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for May 29 (media/i2c/ov2659)

[Randy Dunlap]

On 05/29/15 05:18, Stephen Rothwell wrote:
 Hi all,
 
 Changes since 20150528:
 

on x86_64:

../drivers/media/i2c/ov2659.c: In function 'ov2659_get_fmt':
../drivers/media/i2c/ov2659.c:1054:3: error: implicit declaration of function 
'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
   mf = v4l2_subdev_get_try_format(sd, cfg, 0);
   ^
../drivers/media/i2c/ov2659.c:1054:6: warning: assignment makes pointer from 
integer without a cast [enabled by default]
   mf = v4l2_subdev_get_try_format(sd, cfg, 0);
  ^
../drivers/media/i2c/ov2659.c: In function 'ov2659_set_fmt':
../drivers/media/i2c/ov2659.c:1129:6: warning: assignment makes pointer from 
integer without a cast [enabled by default]
   mf = v4l2_subdev_get_try_format(sd, cfg, fmt-pad);
  ^
../drivers/media/i2c/ov2659.c: In function 'ov2659_open':
../drivers/media/i2c/ov2659.c:1264:38: error: 'struct v4l2_subdev_fh' has no 
member named 'pad'
 v4l2_subdev_get_try_format(sd, fh-pad, 0);
  ^


Full randconfig file is attached.


-- 
~Randy
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 4.1.0-rc5 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_OUTPUT_FORMAT=elf64-x86-64
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_X86_64_SMP=y
CONFIG_X86_HT=y
CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx 
-fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10 
-fcall-saved-r11
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_PGTABLE_LEVELS=4
CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y

#
# General setup
#
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=
CONFIG_COMPILE_TEST=y
CONFIG_LOCALVERSION=
# CONFIG_LOCALVERSION_AUTO is not set
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
CONFIG_KERNEL_BZIP2=y
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
# CONFIG_KERNEL_LZO is not set
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME=(none)
# CONFIG_SWAP is not set
# CONFIG_SYSVIPC is not set
CONFIG_KDBUS=y
# CONFIG_CROSS_MEMORY_ATTACH is not set
# CONFIG_FHANDLE is not set
# CONFIG_USELIB is not set
CONFIG_HAVE_ARCH_AUDITSYSCALL=y

#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_PENDING_IRQ=y
CONFIG_IRQ_DOMAIN=y
CONFIG_IRQ_DOMAIN_HIERARCHY=y
CONFIG_IRQ_DOMAIN_DEBUG=y
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONFIG_GENERIC_CMOS_UPDATE=y

#
# Timers subsystem
#
CONFIG_HZ_PERIODIC=y
# CONFIG_NO_HZ_IDLE is not set
# CONFIG_NO_HZ_FULL is not set
CONFIG_NO_HZ=y
# CONFIG_HIGH_RES_TIMERS is not set

#
# CPU/Task time and stats accounting
#
CONFIG_TICK_CPU_ACCOUNTING=y
# CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set
# CONFIG_IRQ_TIME_ACCOUNTING is not set
CONFIG_BSD_PROCESS_ACCT=y
CONFIG_BSD_PROCESS_ACCT_V3=y

#
# RCU Subsystem
#
CONFIG_PREEMPT_RCU=y
CONFIG_RCU_EXPERT=y
CONFIG_SRCU=y
CONFIG_TASKS_RCU=y
CONFIG_RCU_STALL_COMMON=y
CONFIG_RCU_FANOUT=64
CONFIG_RCU_FANOUT_LEAF=16
# CONFIG_TREE_RCU_TRACE is not set
CONFIG_RCU_BOOST=y
CONFIG_RCU_KTHREAD_PRIO=1
CONFIG_RCU_BOOST_DELAY=500
CONFIG_RCU_NOCB_CPU=y
# CONFIG_RCU_NOCB_CPU_NONE is not set
CONFIG_RCU_NOCB_CPU_ZERO=y
# CONFIG_RCU_NOCB_CPU_ALL is not set
# CONFIG_RCU_EXPEDITE_BOOT is not set
CONFIG_BUILD_BIN2C=y
CONFIG_IKCONFIG=y
# CONFIG_IKCONFIG_PROC is not set
CONFIG_HAVE_UNSTABLE_SCHED_CLOCK=y
CONFIG_ARCH_SUPPORTS_NUMA_BALANCING=y
CONFIG_ARCH_SUPPORTS_INT128=y
# CONFIG_CGROUPS is not set
CONFIG_CHECKPOINT_RESTORE=y
CONFIG_NAMESPACES=y
# CONFIG_UTS_NS is not set
# CONFIG_USER_NS is not set
# CONFIG_PID_NS is not set
# CONFIG_SCHED_AUTOGROUP is not set
# CONFIG_SYSFS_DEPRECATED is not set
CONFIG_RELAY=y
# CONFIG_BLK_DEV_INITRD is not set
# 

[PATCH] media: fix gspca drivers build dependencies

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Several (15) drivers in media/usb/gspca use IF_ENABLED(CONFIG_INPUT)
to decide if they should call input* interfaces, but those drivers
do not build successfully when CONFIG_INPUT=m and the gspca drivers
are builtin (=y).  Making USB_GSPCA depend on INPUT || INPUT=n
fixes the build dependencies and allows all of them to build
cleanly.

Fixes these build errors (selections, not all are listed):

drivers/built-in.o: In function `gspca_disconnect':
(.text+0x32ed0f): undefined reference to `input_unregister_device'
drivers/built-in.o: In function `sd_isoc_irq':
konica.c:(.text+0x333098): undefined reference to `input_event'
konica.c:(.text+0x3330ab): undefined reference to `input_event'
drivers/built-in.o: In function `sd_stopN':
konica.c:(.text+0x3338d3): undefined reference to `input_event'
konica.c:(.text+0x3338e5): undefined reference to `input_event'
drivers/built-in.o: In function `ov51x_handle_button':
ov519.c:(.text+0x335ddb): undefined reference to `input_event'
drivers/built-in.o:ov519.c:(.text+0x335ded): more undefined references to 
`input_event' follow
pac7302.c:(.text+0x336ea1): undefined reference to `input_event'
pac7302.c:(.text+0x336eb3): undefined reference to `input_event'
drivers/built-in.o: In function `sd_pkt_scan':
spca561.c:(.text+0x338fd8): undefined reference to `input_event'
drivers/built-in.o:spca561.c:(.text+0x338feb): more undefined references to 
`input_event' follow
t613.c:(.text+0x33a6fd): undefined reference to `input_event'
drivers/built-in.o:t613.c:(.text+0x33a70f): more undefined references to 
`input_event' follow

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Hans de Goede hdego...@redhat.com
---
 drivers/media/usb/gspca/Kconfig |1 +
 1 file changed, 1 insertion(+)

--- linux-next-20150223.orig/drivers/media/usb/gspca/Kconfig
+++ linux-next-20150223/drivers/media/usb/gspca/Kconfig
@@ -1,6 +1,7 @@
 menuconfig USB_GSPCA
tristate GSPCA based webcams
depends on VIDEO_V4L2
+   depends on INPUT || INPUT=n
default m
---help---
  Say Y here if you want to enable selecting webcams based
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Jan 8 (media, v4l2, vb2)

[Randy Dunlap]

On 01/07/15 21:13, Stephen Rothwell wrote:
 Hi all,
 
 Changes since 20150107:
 
 *crickets*
 
 Non-merge commits (relative to Linus' tree): 1616
  1841 files changed, 45068 insertions(+), 27290 deletions(-)
 

on x86_64:

CONFIG_VIDEO_V4L2=m
CONFIG_VIDEOBUF2_CORE=y
CONFIG_VIDEOBUF2_MEMOPS=y
CONFIG_VIDEOBUF2_DMA_CONTIG=y
CONFIG_VIDEOBUF2_VMALLOC=m

Full randconfig file is attached.


drivers/built-in.o: In function `vb2_fop_mmap':
(.text+0xa19f3): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_expbuf':
(.text+0xa1a31): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_streamoff':
(.text+0xa1abb): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_streamon':
(.text+0xa1b45): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_create_bufs':
(.text+0xa1bd3): undefined reference to `video_devdata'
drivers/built-in.o:(.text+0xa2bdd): more undefined references to 
`video_devdata' follow
drivers/built-in.o: In function `_vb2_fop_release':
(.text+0xa3978): undefined reference to `v4l2_fh_release'
drivers/built-in.o: In function `vb2_fop_release':
(.text+0xa39a5): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_thread':
videobuf2-core.c:(.text+0xa43a5): undefined reference to `v4l2_get_timestamp'
drivers/built-in.o: In function `__vb2_perform_fileio':
videobuf2-core.c:(.text+0xa536a): undefined reference to `v4l2_get_timestamp'
drivers/built-in.o: In function `vb2_fop_write':
(.text+0xa5508): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_fop_read':
(.text+0xa56d8): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_poll':
(.text+0xa5886): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_poll':
(.text+0xa58e0): undefined reference to `v4l2_event_pending'
drivers/built-in.o: In function `vb2_fop_poll':
(.text+0xa5fb9): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_qbuf':
(.text+0xa61d3): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_prepare_buf':
(.text+0xa63fc): undefined reference to `video_devdata'



-- 
~Randy
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 3.19.0-rc3 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_OUTPUT_FORMAT=elf64-x86-64
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx 
-fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10 
-fcall-saved-r11
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config
CONFIG_CONSTRUCTORS=y
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y

#
# General setup
#
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=
CONFIG_COMPILE_TEST=y
CONFIG_LOCALVERSION=
# CONFIG_LOCALVERSION_AUTO is not set
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
CONFIG_KERNEL_LZO=y
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME=(none)
CONFIG_SYSVIPC=y
# CONFIG_POSIX_MQUEUE is not set
CONFIG_CROSS_MEMORY_ATTACH=y
# CONFIG_FHANDLE is not set
CONFIG_USELIB=y
CONFIG_AUDIT=y
CONFIG_HAVE_ARCH_AUDITSYSCALL=y
# CONFIG_AUDITSYSCALL is not set

#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_IRQ_LEGACY_ALLOC_HWIRQ=y
CONFIG_IRQ_DOMAIN=y
# CONFIG_IRQ_DOMAIN_DEBUG is not set
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BUILD=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONFIG_GENERIC_CMOS_UPDATE=y

#
# Timers subsystem
#
CONFIG_HZ_PERIODIC=y
# CONFIG_NO_HZ_IDLE is not set
CONFIG_NO_HZ=y
# CONFIG_HIGH_RES_TIMERS is not set

#
# CPU/Task 

Re: mmotm 2014-11-12-16-34 uploaded (media: v4l2)

[Randy Dunlap]

On 11/12/14 16:36, a...@linux-foundation.org wrote:
 The mm-of-the-moment snapshot 2014-11-12-16-34 has been uploaded to
 
http://www.ozlabs.org/~akpm/mmotm/
 
 mmotm-readme.txt says
 
 README for mm-of-the-moment:
 
 http://www.ozlabs.org/~akpm/mmotm/
 

on i386:

drivers/built-in.o: In function `vb2_ioctl_streamon':
(.text+0x78bcb): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_streamoff':
(.text+0x78c0b): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_expbuf':
(.text+0x78c4b): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_fop_mmap':
(.text+0x78c88): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_querybuf':
(.text+0x78fb7): undefined reference to `video_devdata'
drivers/built-in.o:(.text+0x7923b): more undefined references to 
`video_devdata' follow
drivers/built-in.o: In function `vb2_thread':
videobuf2-core.c:(.text+0x7a322): undefined reference to `v4l2_get_timestamp'
drivers/built-in.o: In function `_vb2_fop_release':
(.text+0x7a75b): undefined reference to `video_devdata'
drivers/built-in.o: In function `_vb2_fop_release':
(.text+0x7a7bb): undefined reference to `v4l2_fh_release'
drivers/built-in.o: In function `vb2_fop_release':
(.text+0x7a7d7): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_poll':
(.text+0x7ac43): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_poll':
(.text+0x7ac7c): undefined reference to `v4l2_event_pending'
drivers/built-in.o: In function `vb2_fop_poll':
(.text+0x7af0e): undefined reference to `video_devdata'
drivers/built-in.o: In function `__vb2_perform_fileio':
videobuf2-core.c:(.text+0x7b429): undefined reference to `v4l2_get_timestamp'
drivers/built-in.o: In function `vb2_fop_write':
(.text+0x7b532): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_fop_read':
(.text+0x7b612): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_reqbufs':
(.text+0x7b7fd): undefined reference to `video_devdata'
make[1]: *** [vmlinux] Error 1



Full randconfig file is attached.

-- 
~Randy
#
# Automatically generated file; DO NOT EDIT.
# Linux/i386 3.18.0-rc4-mm1 Kernel Configuration
#
# CONFIG_64BIT is not set
CONFIG_X86_32=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_OUTPUT_FORMAT=elf32-i386
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/i386_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
# CONFIG_ZONE_DMA32 is not set
# CONFIG_AUDIT_ARCH is not set
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_X86_32_LAZY_GS=y
CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-ecx -fcall-saved-edx
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y

#
# General setup
#
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=
CONFIG_COMPILE_TEST=y
CONFIG_LOCALVERSION=
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
CONFIG_KERNEL_BZIP2=y
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
# CONFIG_KERNEL_LZO is not set
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME=(none)
# CONFIG_SYSVIPC is not set
CONFIG_CROSS_MEMORY_ATTACH=y
CONFIG_FHANDLE=y
# CONFIG_USELIB is not set
CONFIG_HAVE_ARCH_AUDITSYSCALL=y

#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_IRQ_LEGACY_ALLOC_HWIRQ=y
CONFIG_IRQ_DOMAIN=y
CONFIG_IRQ_DOMAIN_DEBUG=y
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BUILD=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONFIG_GENERIC_CMOS_UPDATE=y

#
# Timers subsystem
#
CONFIG_TICK_ONESHOT=y
CONFIG_HZ_PERIODIC=y
# CONFIG_NO_HZ_IDLE is not set
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y

#
# CPU/Task time and stats accounting
#
CONFIG_TICK_CPU_ACCOUNTING=y
# CONFIG_IRQ_TIME_ACCOUNTING is not set
CONFIG_BSD_PROCESS_ACCT=y
CONFIG_BSD_PROCESS_ACCT_V3=y

#
# RCU Subsystem
#
CONFIG_TINY_RCU=y
# CONFIG_TASKS_RCU is not set

Re: linux-next: Tree for Oct 22 (media/usb/dvb-usb/az6027)

[Randy Dunlap]

On 10/21/14 20:42, Stephen Rothwell wrote:
 Hi all,
 
 Changes since 20141021:
 

on x86_64:

when MEDIA_SUBDRV_AUTOSELECT is not enabled:

when DVB_USB_AZ6027=y and DVB_STB0899=m and DVB_STB6100=m:

drivers/built-in.o: In function `az6027_frontend_attach':
az6027.c:(.text+0x18c50d): undefined reference to `stb0899_attach'
az6027.c:(.text+0x18c536): undefined reference to `stb6100_attach'



-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] DocBook: fix media build error

[Randy Dunlap]

On 10/20/14 09:06, Vincent Palatin wrote:
 On Sun, Oct 19, 2014 at 7:39 PM, Randy Dunlap rdun...@infradead.org wrote:
 From: Randy Dunlap rdun...@infradead.org

 Fix media DocBook build errors by making the orderedlist balanced.

 DOC1/Documentation/DocBook/compat.xml:2576: parser error : Opening and 
 ending tag mismatch: orderedlist line 2560 and section
 DOC1/Documentation/DocBook/compat.xml:2726: parser error : Premature end of 
 data in tag section line 884
 DOC1/Documentation/DocBook/compat.xml:2726: parser error : chunk is not well 
 balanced

 Signed-off-by: Randy Dunlap rdun...@infradead.org
 Cc: Vincent Palatin vpala...@chromium.org
 ---
  Documentation/DocBook/media/v4l/compat.xml |1 +
  1 file changed, 1 insertion(+)

 --- lnx-318-rc1.orig/Documentation/DocBook/media/v4l/compat.xml
 +++ lnx-318-rc1/Documentation/DocBook/media/v4l/compat.xml
 @@ -2566,6 +2566,7 @@ fields changed from _s32 to _u32.
   paraAdded compound control types and VIDIOC-QUERY-EXT-CTRL;.
   /para
  /listitem
 +  /orderedlist
titleV4L2 in Linux 3.18/title
orderedlist
 listitem
 
 Compared to the original patch, it's actually also missing the
  /section
 
 section
 which were lost in the merge.
 
 

Would you please send a complete fix for it?
then Mauro can drop my patch.

Thanks.


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] DocBook: fix media build error

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix media DocBook build errors by making the orderedlist balanced.

DOC1/Documentation/DocBook/compat.xml:2576: parser error : Opening and ending 
tag mismatch: orderedlist line 2560 and section
DOC1/Documentation/DocBook/compat.xml:2726: parser error : Premature end of 
data in tag section line 884
DOC1/Documentation/DocBook/compat.xml:2726: parser error : chunk is not well 
balanced

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Vincent Palatin vpala...@chromium.org
---
 Documentation/DocBook/media/v4l/compat.xml |1 +
 1 file changed, 1 insertion(+)

--- lnx-318-rc1.orig/Documentation/DocBook/media/v4l/compat.xml
+++ lnx-318-rc1/Documentation/DocBook/media/v4l/compat.xml
@@ -2566,6 +2566,7 @@ fields changed from _s32 to _u32.
  paraAdded compound control types and VIDIOC-QUERY-EXT-CTRL;.
  /para
 /listitem
+  /orderedlist
   titleV4L2 in Linux 3.18/title
   orderedlist
listitem
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

DocBook error in v4l compat.xml (3.18-rc1)

[Randy Dunlap]

In Linux 3.18-rc1, building DocBooks gives this error:

lnx-318-rc1/DOC1/Documentation/DocBook/compat.xml:2576: parser error : Opening 
and ending tag mismatch: orderedlist line 2560 and section

It looks like the section on V4L2 in Linux 3.18 added unmatched orderedlist 
without and
ending /orderedlist ... or that section was inserted at an incorrect location.

-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Oct 8 (media/usb/gspca)

[Randy Dunlap]

On 10/07/14 23:49, Stephen Rothwell wrote:
 Hi all,
 
 Please do not add any material intended for v3.19 to you linux-next
 included trees until after v3.18-rc1 has been released.
 
 Changes since 20141007:
 

I saw these build errors in gspca when CONFIG_INPUT=m but the gspca
sub-drivers are builtin:

drivers/built-in.o: In function `gspca_dev_probe2':
(.text+0x10ef43): undefined reference to `input_allocate_device'
drivers/built-in.o: In function `gspca_dev_probe2':
(.text+0x10efdd): undefined reference to `input_register_device'
drivers/built-in.o: In function `gspca_dev_probe2':
(.text+0x10f002): undefined reference to `input_free_device'
drivers/built-in.o: In function `gspca_dev_probe2':
(.text+0x10f0ac): undefined reference to `input_unregister_device'
drivers/built-in.o: In function `gspca_disconnect':
(.text+0x10f186): undefined reference to `input_unregister_device'
drivers/built-in.o: In function `sd_int_pkt_scan':
se401.c:(.text+0x11373d): undefined reference to `input_event'
se401.c:(.text+0x11374e): undefined reference to `input_event'
drivers/built-in.o: In function `sd_pkt_scan':
t613.c:(.text+0x119f0e): undefined reference to `input_event'
t613.c:(.text+0x119f1f): undefined reference to `input_event'
drivers/built-in.o: In function `sd_stopN':
t613.c:(.text+0x11a047): undefined reference to `input_event'
drivers/built-in.o:t613.c:(.text+0x11a058): more undefined references to 
`input_event' follow

These could be fixed in Kconfig by something like (for each sub-driver that 
tests
CONFIG_INPUT):

depends on INPUT || INPUT=n

Do you have another preference for fixing this?

thanks,
-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Oct 8 (media/usb/gspca)

[Randy Dunlap]

On 10/08/14 11:31, Mauro Carvalho Chehab wrote:
 Em Wed, 08 Oct 2014 10:13:39 -0700
 Randy Dunlap rdun...@infradead.org escreveu:
 
 On 10/07/14 23:49, Stephen Rothwell wrote:
 Hi all,

 Please do not add any material intended for v3.19 to you linux-next
 included trees until after v3.18-rc1 has been released.

 Changes since 20141007:


 I saw these build errors in gspca when CONFIG_INPUT=m but the gspca
 sub-drivers are builtin:

 drivers/built-in.o: In function `gspca_dev_probe2':
 (.text+0x10ef43): undefined reference to `input_allocate_device'
 drivers/built-in.o: In function `gspca_dev_probe2':
 (.text+0x10efdd): undefined reference to `input_register_device'
 drivers/built-in.o: In function `gspca_dev_probe2':
 (.text+0x10f002): undefined reference to `input_free_device'
 drivers/built-in.o: In function `gspca_dev_probe2':
 (.text+0x10f0ac): undefined reference to `input_unregister_device'
 drivers/built-in.o: In function `gspca_disconnect':
 (.text+0x10f186): undefined reference to `input_unregister_device'
 drivers/built-in.o: In function `sd_int_pkt_scan':
 se401.c:(.text+0x11373d): undefined reference to `input_event'
 se401.c:(.text+0x11374e): undefined reference to `input_event'
 drivers/built-in.o: In function `sd_pkt_scan':
 t613.c:(.text+0x119f0e): undefined reference to `input_event'
 t613.c:(.text+0x119f1f): undefined reference to `input_event'
 drivers/built-in.o: In function `sd_stopN':
 t613.c:(.text+0x11a047): undefined reference to `input_event'
 drivers/built-in.o:t613.c:(.text+0x11a058): more undefined references to 
 `input_event' follow

 These could be fixed in Kconfig by something like (for each sub-driver that 
 tests
 CONFIG_INPUT):

  depends on INPUT || INPUT=n

 Do you have another preference for fixing this?
 
 Hmm... The code at the gspca subdrivers looks like:
 
 #if IS_ENABLED(CONFIG_INPUT)

For builtin only, that should be

#if IS_BUILTIN(CONFIG_INPUT)

   if (data[0]  0x20) {
   input_report_key(gspca_dev-input_dev, KEY_CAMERA, 1);
   input_sync(gspca_dev-input_dev);
   input_report_key(gspca_dev-input_dev, KEY_CAMERA, 0);
   input_sync(gspca_dev-input_dev);
   }
 #endif
 
 As we never got any report about such bug, and this is there for a long
 time, I suspect that maybe the IS_ENABLED() macro had some changes on
 its behavior. So, IMHO, we should first check if something changed there.

I don't see any changes in linux/kconfig.h.

 From gpsca's PoV, IMHO, it should be fine to disable the webcam buttons if
 the webcam was compiled as builtin and the input subsystem is compiled as 
 module. The core feature expected on a camera is to capture streams. 
 Buttons are just a plus.
 
 Also, most cams don't even have buttons. The gspca subdriver has support 
 for buttons for the few models that have it.
 
 So, IMHO, it should be ok to have GSPCA=y and INPUT=m, provided that 
 the buttons will be disabled.

Then all of the sub-drivers that use IS_ENABLED(CONFIG_INPUT) should be
changed to use IS_BUILTIN(CONFIG_INPUT).

But that is too restrictive IMO.  The input subsystem will work fine when
CONFIG_INPUT=m and the GSPCA drivers are also loadable modules.
That's simple to express in Kconfig language but probly more messy in CPP.


Thanks.


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] media: tw68: fix build errors and warnings

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix build errors and kconfig warning: since 'select' does not check
Kconfig symbol dependencies, add that dependency explicitly.

VIDEO_TW68 selects I2C_ALGOBIT, so it should depend on I2C to
prevent build errors and warnings.

warning: (CAN_PEAK_PCIEC  SFC  IGB  VIDEO_TW68  DRM  FB_DDC  
FB_VIA) selects I2C_ALGOBIT which has unmet direct dependencies (I2C)
  CC [M]  drivers/i2c/algos/i2c-algo-bit.o
../drivers/i2c/algos/i2c-algo-bit.c: In function 'i2c_bit_add_bus':
../drivers/i2c/algos/i2c-algo-bit.c:658:33: error: 'i2c_add_adapter' undeclared 
(first use in this function)
../drivers/i2c/algos/i2c-algo-bit.c:658:33: note: each undeclared identifier is 
reported only once for each function it appears in
../drivers/i2c/algos/i2c-algo-bit.c: In function 'i2c_bit_add_numbered_bus':
../drivers/i2c/algos/i2c-algo-bit.c:664:33: error: 'i2c_add_numbered_adapter' 
undeclared (first use in this function)
../drivers/i2c/algos/i2c-algo-bit.c: In function 'i2c_bit_add_bus':
../drivers/i2c/algos/i2c-algo-bit.c:659:1: warning: control reaches end of 
non-void function [-Wreturn-type]
../drivers/i2c/algos/i2c-algo-bit.c: In function 'i2c_bit_add_numbered_bus':
../drivers/i2c/algos/i2c-algo-bit.c:665:1: warning: control reaches end of 
non-void function [-Wreturn-type]

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Hans Verkuil hverk...@xs4all.nl
---
 drivers/media/pci/tw68/Kconfig |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20141001.orig/drivers/media/pci/tw68/Kconfig
+++ linux-next-20141001/drivers/media/pci/tw68/Kconfig
@@ -1,6 +1,6 @@
 config VIDEO_TW68
tristate Techwell tw68x Video For Linux
-   depends on VIDEO_DEV  PCI  VIDEO_V4L2
+   depends on VIDEO_DEV  PCI  VIDEO_V4L2  I2C
select I2C_ALGOBIT
select VIDEOBUF2_DMA_SG
---help---
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: randconfig build error with next-20141001, in drivers/i2c/algos/i2c-algo-bit.c

[Randy Dunlap]

On 10/01/14 14:37, Jim Davis wrote:
 Building with the attached random configuration file,

Also:
warning: (CAN_PEAK_PCIEC  SFC  IGB  VIDEO_TW68  DRM  FB_DDC  
FB_VIA) selects I2C_ALGOBIT which has unmet direct dependencies (I2C)

 drivers/i2c/algos/i2c-algo-bit.c: In function ‘i2c_bit_add_bus’:
 drivers/i2c/algos/i2c-algo-bit.c:658:33: error: ‘i2c_add_adapter’
 undeclared (first use in this function)
   return __i2c_bit_add_bus(adap, i2c_add_adapter);
  ^
 drivers/i2c/algos/i2c-algo-bit.c:658:33: note: each undeclared
 identifier is reported only once for each function it appears in
 drivers/i2c/algos/i2c-algo-bit.c: In function ‘i2c_bit_add_numbered_bus’:
 drivers/i2c/algos/i2c-algo-bit.c:664:33: error:
 ‘i2c_add_numbered_adapter’ undeclared (first use in this function)
   return __i2c_bit_add_bus(adap, i2c_add_numbered_adapter);
  ^
   CC  net/openvswitch/actions.o
 drivers/i2c/algos/i2c-algo-bit.c: In function ‘i2c_bit_add_bus’:
 drivers/i2c/algos/i2c-algo-bit.c:659:1: warning: control reaches end of 
 non-void
  function [-Wreturn-type]
  }
  ^
 drivers/i2c/algos/i2c-algo-bit.c: In function ‘i2c_bit_add_numbered_bus’:
 drivers/i2c/algos/i2c-algo-bit.c:665:1: warning: control reaches end of 
 non-void
  function [-Wreturn-type]
  }
  ^
 make[3]: *** [drivers/i2c/algos/i2c-algo-bit.o] Error 1

In drivers/media/pci/tw68/Kconfig, VIDEO_TW68 should depend on I2C in order
to make it safe to select I2C_ALGOBIT.

In drivers/net/can/sja1000/Kconfig, CAN_PEAK_PCIEC should depend on I2C
instead of selecting I2C (and change the help text).


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Sep 26 (media/pci/pt3)

[Randy Dunlap]

On 09/26/14 04:10, Stephen Rothwell wrote:
 Hi all,
 
 There will be no linux-next release on Monday.
 
 This has not been a good day :-(
 
 Changes since 20140925:


on x86_64:
when CONFIG_MODULES is not enabled:

../drivers/media/pci/pt3/pt3.c: In function 'pt3_attach_fe':
../drivers/media/pci/pt3/pt3.c:433:6: error: implicit declaration of function 
'module_is_live' [-Werror=implicit-function-declaration]



-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] media/radio: fix radio-miropcm20.c build with io.h header file

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix build errors in radio-miropcm20.c due to missing header file:

drivers/media/radio/radio-miropcm20.c: In function 'rds_waitread':
drivers/media/radio/radio-miropcm20.c:90:3: error: implicit declaration of 
function 'inb' [-Werror=implicit-function-declaration]
drivers/media/radio/radio-miropcm20.c: In function 'rds_rawwrite':
drivers/media/radio/radio-miropcm20.c:106:3: error: implicit declaration of 
function 'outb' [-Werror=implicit-function-declaration]

Reported-by: Jim Davis jim.ep...@gmail.com
Signed-off-by: Randy Dunlap rdun...@infradead.org
---
 drivers/media/radio/radio-miropcm20.c |1 +
 1 file changed, 1 insertion(+)

Index: linux-next-20140828/drivers/media/radio/radio-miropcm20.c
===
--- linux-next-20140828.orig/drivers/media/radio/radio-miropcm20.c
+++ linux-next-20140828/drivers/media/radio/radio-miropcm20.c
@@ -27,6 +27,7 @@
 
 #include linux/module.h
 #include linux/init.h
+#include linux/io.h
 #include linux/delay.h
 #include linux/videodev2.h
 #include linux/kthread.h
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Documentation/video4linux: don't build without CONFIG_VIDEO_V4L2

[Randy Dunlap]

On 08/28/14 13:34, Andrey Vagin wrote:
 Otherwise we get warnings:
 WARNING: vb2_ops_wait_finish 
 [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
 WARNING: vb2_ops_wait_prepare 
 [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
 ...
 WARNING: video_unregister_device 
 [Documentation//video4linux/v4l2-pci-skeleton.ko] undefined!
 
 Fixes: 8db5ab4b50fb (Documentation: add makefiles for more targets)
 
 Cc: Peter Foley pefol...@pefoley.com
 Cc: Mauro Carvalho Chehab m.che...@samsung.com
 Cc: Randy Dunlap rdun...@infradead.org
 Signed-off-by: Andrey Vagin ava...@openvz.org
 ---
  Documentation/video4linux/Makefile | 2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/Documentation/video4linux/Makefile 
 b/Documentation/video4linux/Makefile
 index d58101e..f19f38e 100644
 --- a/Documentation/video4linux/Makefile
 +++ b/Documentation/video4linux/Makefile
 @@ -1 +1,3 @@
 +ifneq ($(CONFIG_VIDEO_V4L2),)
  obj-m := v4l2-pci-skeleton.o
 +endif
 

The Kconfig file for this module says:

config VIDEO_PCI_SKELETON
tristate Skeleton PCI V4L2 driver
depends on PCI  BUILD_DOCSRC
depends on VIDEO_V4L2  VIDEOBUF2_CORE  VIDEOBUF2_MEMOPS

so it should already be limited to VIDEO_V4L2 being enabled.

What kernel or linux-next version did you see a problem with?

Please send the failing .config file so that I can check it.

Thanks.

-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: randconfig build error with next-20140826, in Documentation/video4linux

[Randy Dunlap]

On 08/27/14 03:58, Sudip Mukherjee wrote:
 On Tue, Aug 26, 2014 at 09:50:43AM -0700, Jim Davis wrote:
 Building with the attached random configuration file,

 ERROR: vb2_ops_wait_finish
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ops_wait_prepare
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_event_unsubscribe
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_subscribe_event
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_log_status
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_streamoff
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_streamon
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_create_bufs
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_dqbuf
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_expbuf
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_qbuf
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_querybuf
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_reqbufs
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_fop_release
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_fh_open [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: vb2_fop_mmap [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: video_ioctl2 [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: vb2_fop_poll [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: vb2_fop_read [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: vb2_buffer_done
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: __video_register_device
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: video_device_release_empty
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_dma_contig_init_ctx
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_queue_init
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_dma_contig_memops
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_new_std
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_handler_init_class
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_device_register
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_match_dv_timings
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_find_dv_timings_cap
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_valid_dv_timings
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_enum_dv_timings_cap
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: video_devdata
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_device_unregister
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_dma_contig_cleanup_ctx
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_handler_free
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: video_unregister_device
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 make[1]: *** [__modpost] Error 1
 make: *** [modules] Error 2

 Similar to a build error from January 7th:
 https://lists.01.org/pipermail/kbuild-all/2014-January/002566.html
 
 Hi,
 I tried to build next-20140826 with your given config file . But for me 
 everything was fine.
 And I was just wondering why the skeleton code in the Documentation is 
 building ?

It builds if the Kconfig symbol BUILD_DOCSRC is enabled.
Building of this module was just added to linux-next.


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: randconfig build error with next-20140826, in Documentation/video4linux

[Randy Dunlap]

On 08/27/14 10:17, Mauro Carvalho Chehab wrote:
 Em Wed, 27 Aug 2014 07:36:05 -0700
 Randy Dunlap rdun...@infradead.org escreveu:
 
 On 08/27/14 03:58, Sudip Mukherjee wrote:
 On Tue, Aug 26, 2014 at 09:50:43AM -0700, Jim Davis wrote:
 Building with the attached random configuration file,

 ERROR: vb2_ops_wait_finish
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ops_wait_prepare
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_event_unsubscribe
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_subscribe_event
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_log_status
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_streamoff
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_streamon
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_create_bufs
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_dqbuf
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_expbuf
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_qbuf
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_querybuf
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_ioctl_reqbufs
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_fop_release
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_fh_open [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: vb2_fop_mmap [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: video_ioctl2 [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: vb2_fop_poll [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: vb2_fop_read [Documentation/video4linux/v4l2-pci-skeleton.ko]
 undefined!
 ERROR: vb2_buffer_done
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: __video_register_device
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: video_device_release_empty
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_dma_contig_init_ctx
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_queue_init
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_dma_contig_memops
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_new_std
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_handler_init_class
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_device_register
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_match_dv_timings
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_find_dv_timings_cap
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_valid_dv_timings
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_enum_dv_timings_cap
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: video_devdata
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_device_unregister
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: vb2_dma_contig_cleanup_ctx
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: v4l2_ctrl_handler_free
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 ERROR: video_unregister_device
 [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
 make[1]: *** [__modpost] Error 1
 make: *** [modules] Error 2

 Similar to a build error from January 7th:
 https://lists.01.org/pipermail/kbuild-all/2014-January/002566.html

 Hi,
 I tried to build next-20140826 with your given config file . But for me 
 everything was fine.
 And I was just wondering why the skeleton code in the Documentation is 
 building ?

 It builds if the Kconfig symbol BUILD_DOCSRC is enabled.
 Building of this module was just added to linux-next.
 
 It makes sense to add a depends on BUILD_DOCSRC, PCI and MEDIA_V4L2
 inside the docs Makefile, instead of moving the Kconfig to 
 drivers/media, IMHO.

No, the dependencies should be in a Kconfig file, not in a Makefile.
If you insist, I'll look into moving the Kconfig contents into Documentation/.


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available

[Randy Dunlap]

On 08/26/14 10:25, Mark Brown wrote:
 From: Mark Brown broo...@linaro.org
 
 Currently arm64 does not support PCI but it does support v4l2. Since the
 PCI skeleton driver is built unconditionally as a module with no dependency
 on PCI this causes build failures for arm64 allmodconfig. Fix this by
 defining a symbol VIDEO_PCI_SKELETON for the skeleton and conditionalising
 the build on that.

Looks good.  Applied.  Thanks.

I'm pretty sure that it also needs depends on VIDEOBUF2_CORE or
something in that family.  I'll check that and add it.

 Signed-off-by: Mark Brown broo...@linaro.org
 ---
 
 The patch adding the Makefile was added to the Documentation tree,
 either it should be reverted or something like this added on top.
 
  Documentation/video4linux/Makefile | 2 +-
  drivers/media/v4l2-core/Kconfig| 7 +++
  2 files changed, 8 insertions(+), 1 deletion(-)
 
 diff --git a/Documentation/video4linux/Makefile 
 b/Documentation/video4linux/Makefile
 index d58101e788fc..65a351d75c95 100644
 --- a/Documentation/video4linux/Makefile
 +++ b/Documentation/video4linux/Makefile
 @@ -1 +1 @@
 -obj-m := v4l2-pci-skeleton.o
 +obj-$(CONFIG_VIDEO_PCI_SKELETON) := v4l2-pci-skeleton.o
 diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
 index 9ca0f8d59a14..2b368f711c9e 100644
 --- a/drivers/media/v4l2-core/Kconfig
 +++ b/drivers/media/v4l2-core/Kconfig
 @@ -25,6 +25,13 @@ config VIDEO_FIXED_MINOR_RANGES
  
 When in doubt, say N.
  
 +config VIDEO_PCI_SKELETON
 + tristate Skeleton PCI V4L2 driver
 + depends on PCI  COMPILE_TEST
 + ---help---
 +   Enable build of the skeleton PCI driver, used as a reference
 +   when developign new drivers.
 +
  # Used by drivers that need tuner.ko
  config VIDEO_TUNER
   tristate
 


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available

[Randy Dunlap]

On 08/26/14 10:25, Mark Brown wrote:
 From: Mark Brown broo...@linaro.org
 
 Currently arm64 does not support PCI but it does support v4l2. Since the
 PCI skeleton driver is built unconditionally as a module with no dependency
 on PCI this causes build failures for arm64 allmodconfig. Fix this by
 defining a symbol VIDEO_PCI_SKELETON for the skeleton and conditionalising
 the build on that.
 
 Signed-off-by: Mark Brown broo...@linaro.org
 ---
 
 The patch adding the Makefile was added to the Documentation tree,
 either it should be reverted or something like this added on top.
 
  Documentation/video4linux/Makefile | 2 +-
  drivers/media/v4l2-core/Kconfig| 7 +++
  2 files changed, 8 insertions(+), 1 deletion(-)
 
 diff --git a/Documentation/video4linux/Makefile 
 b/Documentation/video4linux/Makefile
 index d58101e788fc..65a351d75c95 100644
 --- a/Documentation/video4linux/Makefile
 +++ b/Documentation/video4linux/Makefile
 @@ -1 +1 @@
 -obj-m := v4l2-pci-skeleton.o
 +obj-$(CONFIG_VIDEO_PCI_SKELETON) := v4l2-pci-skeleton.o
 diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
 index 9ca0f8d59a14..2b368f711c9e 100644
 --- a/drivers/media/v4l2-core/Kconfig
 +++ b/drivers/media/v4l2-core/Kconfig
 @@ -25,6 +25,13 @@ config VIDEO_FIXED_MINOR_RANGES
  
 When in doubt, say N.
  
 +config VIDEO_PCI_SKELETON
 + tristate Skeleton PCI V4L2 driver
 + depends on PCI  COMPILE_TEST

??  No, don't require COMPILE_TEST.
However, PCI || COMPILE_TEST would allow it to build on arm64
if COMPILE_TEST is enabled, guaranteeing build errors.
Is that what should happen?  I suppose so...


 + ---help---
 +   Enable build of the skeleton PCI driver, used as a reference
 +   when developign new drivers.
 +
  # Used by drivers that need tuner.ko
  config VIDEO_TUNER
   tristate
 


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available

[Randy Dunlap]

On 08/26/14 12:26, Mark Brown wrote:
 On Tue, Aug 26, 2014 at 12:20:54PM -0700, Randy Dunlap wrote:
 On 08/26/14 10:25, Mark Brown wrote:
 
 index d58101e788fc..65a351d75c95 100644
 --- a/Documentation/video4linux/Makefile
 +++ b/Documentation/video4linux/Makefile
 @@ -1 +1 @@
 -obj-m := v4l2-pci-skeleton.o
 +obj-$(CONFIG_VIDEO_PCI_SKELETON) := v4l2-pci-skeleton.o
 diff --git a/drivers/media/v4l2-core/Kconfig 
 b/drivers/media/v4l2-core/Kconfig
 
 +config VIDEO_PCI_SKELETON
 +   tristate Skeleton PCI V4L2 driver
 +   depends on PCI  COMPILE_TEST
 
  ??  No, don't require COMPILE_TEST.
 
 That's a very deliberate choice.  There's no reason I can see to build
 this code other than to check that it builds, it's reference code rather
 than something that someone is expected to actually use in their system.  
 This seems like a perfect candidate for COMPILE_TEST.
 
  However, PCI || COMPILE_TEST would allow it to build on arm64
  if COMPILE_TEST is enabled, guaranteeing build errors.
  Is that what should happen?  I suppose so...
 
 No, it's not - if it's going to depend on COMPILE_TEST at all it need to
 be a hard dependency.

How about just drop COMPILE_TEST?  This code only builds if someone enabled
BUILD_DOCSRC.  That should be enough (along with PCI and some VIDEO kconfig
symbols) to qualify it.


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available

[Randy Dunlap]

On 08/26/14 12:59, Randy Dunlap wrote:
 On 08/26/14 12:26, Mark Brown wrote:
 On Tue, Aug 26, 2014 at 12:20:54PM -0700, Randy Dunlap wrote:
 On 08/26/14 10:25, Mark Brown wrote:

 index d58101e788fc..65a351d75c95 100644
 --- a/Documentation/video4linux/Makefile
 +++ b/Documentation/video4linux/Makefile
 @@ -1 +1 @@
 -obj-m := v4l2-pci-skeleton.o
 +obj-$(CONFIG_VIDEO_PCI_SKELETON) := v4l2-pci-skeleton.o
 diff --git a/drivers/media/v4l2-core/Kconfig 
 b/drivers/media/v4l2-core/Kconfig

 +config VIDEO_PCI_SKELETON
 +  tristate Skeleton PCI V4L2 driver
 +  depends on PCI  COMPILE_TEST

 ??  No, don't require COMPILE_TEST.

 That's a very deliberate choice.  There's no reason I can see to build
 this code other than to check that it builds, it's reference code rather
 than something that someone is expected to actually use in their system.  
 This seems like a perfect candidate for COMPILE_TEST.

 However, PCI || COMPILE_TEST would allow it to build on arm64
 if COMPILE_TEST is enabled, guaranteeing build errors.
 Is that what should happen?  I suppose so...

 No, it's not - if it's going to depend on COMPILE_TEST at all it need to
 be a hard dependency.
 
 How about just drop COMPILE_TEST?  This code only builds if someone enabled
 BUILD_DOCSRC.  That should be enough (along with PCI and some VIDEO kconfig
 symbols) to qualify it.

I'll add BUILD_DOCSRC to the depends list in the Kconfig file...


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

[Randy Dunlap]

On 08/22/14 10:04, Jeff Mahoney wrote:
 On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote:
 We should not select SPI bus when sub-driver auto-select is
 selected. That option is meant for auto-selecting all possible
 ancillary drivers used for selected board driver. Ancillary
 drivers should define needed dependencies itself.

 I2C and I2C_MUX are still selected here for a reason described on
 commit 347f7a3763601d7b466898d1f10080b7083ac4a3

 Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a

 Reported-by: Jeff Mahoney je...@suse.com
 Signed-off-by: Antti Palosaari cr...@iki.fi
 ---
  drivers/media/Kconfig | 1 -
  1 file changed, 1 deletion(-)

 diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
 index f60bad4..3c89fcb 100644
 --- a/drivers/media/Kconfig
 +++ b/drivers/media/Kconfig
 @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT
  depends on HAS_IOMEM
  select I2C
  select I2C_MUX
 -select SPI
  default y
  help
By default, a media driver auto-selects all possible ancillary
 
 FWIW, in the patch I used locally, I also did a 'select SPI' in the 
 MSI2500 driver since it wouldn't otherwise be obvious that a USB device 
 depends on SPI.

It already has depends on SPI.  That should be enough.

-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] dma-buf: fix linux/seqno-fence.h kernel-doc warning

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix kernel-doc warning, missing parameter description:

Warning(..//include/linux/seqno-fence.h:99): No description found for parameter 
'cond'

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Rob Clark robdcl...@gmail.com
Cc: Maarten Lankhorst maarten.lankho...@canonical.com
---
 include/linux/seqno-fence.h |1 +
 1 file changed, 1 insertion(+)

Index: lnx-317-rc1/include/linux/seqno-fence.h
===
--- lnx-317-rc1.orig/include/linux/seqno-fence.h
+++ lnx-317-rc1/include/linux/seqno-fence.h
@@ -62,6 +62,7 @@ to_seqno_fence(struct fence *fence)
  * @context: the execution context this fence is a part of
  * @seqno_ofs: the offset within @sync_buf
  * @seqno: the sequence # to signal on
+ * @cond: the fence condition to check
  * @ops: the fence_ops for operations on this seqno fence
  *
  * This function initializes a struct seqno_fence with passed parameters,
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [linuxtv-media:devel 498/499] av7110.c:undefined reference to `av7110_ir_exit'

[Randy Dunlap]

On 08/15/14 15:03, kbuild test robot wrote:
 tree:   git://linuxtv.org/media_tree.git devel
 head:   f1d2fd677f61bf4d649098317497db11a958a021
 commit: 277c0ffaea64c71c39f03b9ee6818de600c38fc3 [498/499] [media] media: 
 ttpci: build av7110_ir.c only when allowed by CONFIG_INPUT_EVDEV
 config: x86_64-randconfig-s1-08160530 (attached as .config)

Argh, thanks, fix is on the way.


 All error/warnings:
 
drivers/built-in.o: In function `av7110_detach':
 av7110.c:(.text+0x228d4a): undefined reference to `av7110_ir_exit'
drivers/built-in.o: In function `arm_thread':
 av7110.c:(.text+0x22a404): undefined reference to `av7110_check_ir_config'
 av7110.c:(.text+0x22a626): undefined reference to `av7110_check_ir_config'
drivers/built-in.o: In function `av7110_attach':
 av7110.c:(.text+0x22b08c): undefined reference to `av7110_ir_init'
 
 ---
 0-DAY kernel build testing backend  Open Source Technology Center
 http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
 


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] media: ttpci: fix av7110 build to be compatible with CONFIG_INPUT_EVDEV

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix build when CONFIG_INPUT_EVDEV=m and DVB_AV7110=y.
Only build av7110_ir.c when CONFIG_INPUT_EVDEV is compatible with
CONFIG_DVB_AV7110.

Fixes these build errors:

drivers/built-in.o: In function `input_sync':
av7110_ir.c:(.text+0x1223ac): undefined reference to `input_event'
drivers/built-in.o: In function `av7110_emit_key':
av7110_ir.c:(.text+0x12247c): undefined reference to `input_event'
av7110_ir.c:(.text+0x122495): undefined reference to `input_event'
av7110_ir.c:(.text+0x122569): undefined reference to `input_event'
av7110_ir.c:(.text+0x1225a7): undefined reference to `input_event'
drivers/built-in.o:av7110_ir.c:(.text+0x122629): more undefined
references to `input_event' follow
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x1227e4): undefined reference to `input_allocate_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x12298f): undefined reference to `input_register_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x12299e): undefined reference to `input_free_device'
drivers/built-in.o: In function `av7110_ir_exit':
(.text+0x122a94): undefined reference to `input_unregister_device'

drivers/built-in.o: In function `av7110_detach':
av7110.c:(.text+0x228d4a): undefined reference to `av7110_ir_exit'
drivers/built-in.o: In function `arm_thread':
av7110.c:(.text+0x22a404): undefined reference to `av7110_check_ir_config'
av7110.c:(.text+0x22a626): undefined reference to `av7110_check_ir_config'
drivers/built-in.o: In function `av7110_attach':
av7110.c:(.text+0x22b08c): undefined reference to `av7110_ir_init'

Signed-off-by: Randy Dunlap rdun...@infradead.org
Reported-by: Randy Dunlap rdun...@infradead.org
Reported-by: Jim Davis jim.ep...@gmail.com
Reported-by: Fengguang Wu fengguang...@intel.com
Cc: Holger Waechtler hol...@convergence.de
Cc: Oliver Endriss o.endr...@gmx.de
---
 drivers/media/pci/ttpci/Kconfig  |4 
 drivers/media/pci/ttpci/Makefile |2 +-
 drivers/media/pci/ttpci/av7110.c |8 
 3 files changed, 9 insertions(+), 5 deletions(-)

Mauro: please drop the v1 patch, which is commit ID
277c0ffaea64c71c39f03b9ee6818de600c38fc3 in your tree and
http://patchwork.linuxtv.org/patch/25342/ in patchwork.


Index: lnx-316/drivers/media/pci/ttpci/Kconfig
===
--- lnx-316.orig/drivers/media/pci/ttpci/Kconfig
+++ lnx-316/drivers/media/pci/ttpci/Kconfig
@@ -1,8 +1,12 @@
+config DVB_AV7110_IR
+   bool
+
 config DVB_AV7110
tristate AV7110 cards
depends on DVB_CORE  PCI  I2C
select TTPCI_EEPROM
select VIDEO_SAA7146_VV
+   select DVB_AV7110_IR if INPUT_EVDEV=y || INPUT_EVDEV=DVB_AV7110
depends on VIDEO_DEV# dependencies of VIDEO_SAA7146_VV
select DVB_VES1820 if MEDIA_SUBDRV_AUTOSELECT
select DVB_VES1X93 if MEDIA_SUBDRV_AUTOSELECT
Index: lnx-316/drivers/media/pci/ttpci/Makefile
===
--- lnx-316.orig/drivers/media/pci/ttpci/Makefile
+++ lnx-316/drivers/media/pci/ttpci/Makefile
@@ -5,7 +5,7 @@
 
 dvb-ttpci-objs := av7110_hw.o av7110_v4l.o av7110_av.o av7110_ca.o av7110.o 
av7110_ipack.o
 
-ifdef CONFIG_INPUT_EVDEV
+ifdef CONFIG_DVB_AV7110_IR
 dvb-ttpci-objs += av7110_ir.o
 endif
 
Index: lnx-316/drivers/media/pci/ttpci/av7110.c
===
--- lnx-316.orig/drivers/media/pci/ttpci/av7110.c
+++ lnx-316/drivers/media/pci/ttpci/av7110.c
@@ -235,7 +235,7 @@ static void recover_arm(struct av7110 *a
 
restart_feeds(av7110);
 
-#if IS_ENABLED(CONFIG_INPUT_EVDEV)
+#if IS_ENABLED(CONFIG_DVB_AV7110_IR)
av7110_check_ir_config(av7110, true);
 #endif
 }
@@ -268,7 +268,7 @@ static int arm_thread(void *data)
if (!av7110-arm_ready)
continue;
 
-#if IS_ENABLED(CONFIG_INPUT_EVDEV)
+#if IS_ENABLED(CONFIG_DVB_AV7110_IR)
av7110_check_ir_config(av7110, false);
 #endif
 
@@ -2725,7 +2725,7 @@ static int av7110_attach(struct saa7146_
 
mutex_init(av7110-ioctl_mutex);
 
-#if IS_ENABLED(CONFIG_INPUT_EVDEV)
+#if IS_ENABLED(CONFIG_DVB_AV7110_IR)
av7110_ir_init(av7110);
 #endif
printk(KERN_INFO dvb-ttpci: found av7110-%d.\n, av7110_num);
@@ -2768,7 +2768,7 @@ static int av7110_detach(struct saa7146_
struct av7110 *av7110 = saa-ext_priv;
dprintk(4, %p\n, av7110);
 
-#if IS_ENABLED(CONFIG_INPUT_EVDEV)
+#if IS_ENABLED(CONFIG_DVB_AV7110_IR)
av7110_ir_exit(av7110);
 #endif
if (budgetpatch || av7110-full_ts) {
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: randconfig build error with next-20140813, in drivers/media/pci/ttpci/av7110_ir.c

[Randy Dunlap]

On 08/13/14 09:23, Jim Davis wrote:
 Building with the attached random configuration file,
 
   LD  init/built-in.o
 drivers/built-in.o: In function `input_sync':
 av7110_ir.c:(.text+0x1223ac): undefined reference to `input_event'
 drivers/built-in.o: In function `av7110_emit_key':
 av7110_ir.c:(.text+0x12247c): undefined reference to `input_event'
 av7110_ir.c:(.text+0x122495): undefined reference to `input_event'
 av7110_ir.c:(.text+0x122569): undefined reference to `input_event'
 av7110_ir.c:(.text+0x1225a7): undefined reference to `input_event'
 drivers/built-in.o:av7110_ir.c:(.text+0x122629): more undefined
 references to `input_event' follow
 drivers/built-in.o: In function `av7110_ir_init':
 (.text+0x1227e4): undefined reference to `input_allocate_device'
 drivers/built-in.o: In function `av7110_ir_init':
 (.text+0x12298f): undefined reference to `input_register_device'
 drivers/built-in.o: In function `av7110_ir_init':
 (.text+0x12299e): undefined reference to `input_free_device'
 drivers/built-in.o: In function `av7110_ir_exit':
 (.text+0x122a94): undefined reference to `input_unregister_device'
 make: *** [vmlinux] Error 1
 

I reported this on Feb. 14 and July 11 of 2014.  :(


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] media: ttpci: build av7110_ir.c only when allowed by CONFIG_INPUT_EVDEV

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix build when CONFIG_INPUT_EVDEV=m and DVB_AV7110=y.
Only build av7110_ir.c when CONFIG_INPUT_EVDEV is compatible with
CONFIG_DVB_AV7110.

Fixes these build errors:

drivers/built-in.o: In function `input_sync':
av7110_ir.c:(.text+0x1223ac): undefined reference to `input_event'
drivers/built-in.o: In function `av7110_emit_key':
av7110_ir.c:(.text+0x12247c): undefined reference to `input_event'
av7110_ir.c:(.text+0x122495): undefined reference to `input_event'
av7110_ir.c:(.text+0x122569): undefined reference to `input_event'
av7110_ir.c:(.text+0x1225a7): undefined reference to `input_event'
drivers/built-in.o:av7110_ir.c:(.text+0x122629): more undefined
references to `input_event' follow
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x1227e4): undefined reference to `input_allocate_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x12298f): undefined reference to `input_register_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x12299e): undefined reference to `input_free_device'
drivers/built-in.o: In function `av7110_ir_exit':
(.text+0x122a94): undefined reference to `input_unregister_device'

Signed-off-by: Randy Dunlap rdun...@infradead.org
Reported-by: Randy Dunlap rdun...@infradead.org
Reported-by: Jim Davis jim.ep...@gmail.com
Cc: Holger Waechtler hol...@convergence.de
Cc: Oliver Endriss o.endr...@gmx.de
---
 drivers/media/pci/ttpci/Kconfig  |4 
 drivers/media/pci/ttpci/Makefile |2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Index: linux-next-20140813/drivers/media/pci/ttpci/Kconfig
===
--- linux-next-20140813.orig/drivers/media/pci/ttpci/Kconfig
+++ linux-next-20140813/drivers/media/pci/ttpci/Kconfig
@@ -1,8 +1,12 @@
+config DVB_AV7110_IR
+   bool
+
 config DVB_AV7110
tristate AV7110 cards
depends on DVB_CORE  PCI  I2C
select TTPCI_EEPROM
select VIDEO_SAA7146_VV
+   select DVB_AV7110_IR if INPUT_EVDEV=y || INPUT_EVDEV=DVB_AV7110
depends on VIDEO_DEV# dependencies of VIDEO_SAA7146_VV
select DVB_VES1820 if MEDIA_SUBDRV_AUTOSELECT
select DVB_VES1X93 if MEDIA_SUBDRV_AUTOSELECT
Index: linux-next-20140813/drivers/media/pci/ttpci/Makefile
===
--- linux-next-20140813.orig/drivers/media/pci/ttpci/Makefile
+++ linux-next-20140813/drivers/media/pci/ttpci/Makefile
@@ -5,7 +5,7 @@
 
 dvb-ttpci-objs := av7110_hw.o av7110_v4l.o av7110_av.o av7110_ca.o av7110.o 
av7110_ipack.o
 
-ifdef CONFIG_INPUT_EVDEV
+ifdef CONFIG_DVB_AV7110_IR
 dvb-ttpci-objs += av7110_ir.o
 endif
 
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Jul 11 (media/pci/ttpci/av7110)

[Randy Dunlap]

On 07/11/14 00:18, Stephen Rothwell wrote:
 Hi all,
 
 Changes since 20140710:
 

on x86_64:

CONFIG_DVB_AV7110=y
CONFIG_INPUT_EVDEV=m

drivers/built-in.o: In function `av7110_emit_keyup':
av7110_ir.c:(.text+0x76b608): undefined reference to `input_event'
av7110_ir.c:(.text+0x76b61a): undefined reference to `input_event'
drivers/built-in.o: In function `av7110_emit_key':
av7110_ir.c:(.text+0x76b6b4): undefined reference to `input_event'
av7110_ir.c:(.text+0x76b6cd): undefined reference to `input_event'
av7110_ir.c:(.text+0x76b7b0): undefined reference to `input_event'
drivers/built-in.o:av7110_ir.c:(.text+0x76b7ca): more undefined references to 
`input_event' follow
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x76bcdb): undefined reference to `input_allocate_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x76bf93): undefined reference to `input_register_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x76c073): undefined reference to `input_free_device'
drivers/built-in.o: In function `av7110_ir_exit':
(.text+0x76c1db): undefined reference to `input_unregister_device'


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Documentation: Fix DocBook build with relative $(srctree)

[Randy Dunlap]

On 06/18/14 08:27, Michal Marek wrote:
 After commits 890676c6 (kbuild: Use relative path when building in the source
 tree) and 9da0763b (kbuild: Use relative path when building in a subdir
 of the source tree), the $(srctree) variable can be a relative path.
 This breaks Documentation/DocBook/media/Makefile, because it tries to
 create symlinks from a subdirectory of the object tree to the source
 tree. Fix this by using a full path in this case.
 
 Reported-by: Randy Dunlap rdun...@infradead.org
 Signed-off-by: Michal Marek mma...@suse.cz

Thanks.

Acked-by: Randy Dunlap rdun...@infradead.org
Tested-by: Randy Dunlap rdun...@infradead.org

Please merge to Linus sooner instead of later.


 ---
  Documentation/DocBook/media/Makefile | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/Documentation/DocBook/media/Makefile 
 b/Documentation/DocBook/media/Makefile
 index 1d27f0a..639e748 100644
 --- a/Documentation/DocBook/media/Makefile
 +++ b/Documentation/DocBook/media/Makefile
 @@ -202,8 +202,8 @@ $(MEDIA_OBJ_DIR)/%: $(MEDIA_SRC_DIR)/%.b64
  
  $(MEDIA_OBJ_DIR)/v4l2.xml: $(OBJIMGFILES)
   @$($(quiet)gen_xml)
 - @(ln -sf $(MEDIA_SRC_DIR)/v4l/*xml $(MEDIA_OBJ_DIR)/)
 - @(ln -sf $(MEDIA_SRC_DIR)/dvb/*xml $(MEDIA_OBJ_DIR)/)
 + @(ln -sf `cd $(MEDIA_SRC_DIR)  /bin/pwd`/v4l/*xml $(MEDIA_OBJ_DIR)/)
 + @(ln -sf `cd $(MEDIA_SRC_DIR)  /bin/pwd`/dvb/*xml $(MEDIA_OBJ_DIR)/)
  
  $(MEDIA_OBJ_DIR)/videodev2.h.xml: $(srctree)/include/uapi/linux/videodev2.h 
 $(MEDIA_OBJ_DIR)/v4l2.xml
   @$($(quiet)gen_xml)
 


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

MANY errors while building media docbooks

[Randy Dunlap]

on Linux v3.16-rc1, building docbooks to a separate build directory
(mkdir DOC; make O=DOC htmldocs) gives me more than 12,000 lines like this:

grep: ./Documentation/DocBook//vidioc-subdev-g-fmt.xml: No such file or 
directory
grep: ./Documentation/DocBook//vidioc-subdev-g-frame-interval.xml: No such file 
or directory
grep: ./Documentation/DocBook//vidioc-subdev-g-selection.xml: No such file or 
directory
grep: ./Documentation/DocBook//vidioc-subscribe-event.xml: No such file or 
directory
grep: ./Documentation/DocBook//media-ioc-device-info.xml: No such file or 
directory
grep: ./Documentation/DocBook//media-ioc-enum-entities.xml: No such file or 
directory
grep: ./Documentation/DocBook//media-ioc-enum-links.xml: No such file or 
directory
grep: ./Documentation/DocBook//media-ioc-setup-link.xml: No such file or 
directory

-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mmotm 2014-03-10-15-35 uploaded (media/pci/ttpci/av7110)

[Randy Dunlap]

On 03/10/2014 03:37 PM, a...@linux-foundation.org wrote:
 The mm-of-the-moment snapshot 2014-03-10-15-35 has been uploaded to
 
http://www.ozlabs.org/~akpm/mmotm/
 
 mmotm-readme.txt says
 
 README for mm-of-the-moment:
 
 http://www.ozlabs.org/~akpm/mmotm/
 
 This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
 more than once a week.
 
 You will need quilt to apply these patches to the latest Linus release (3.x
 or 3.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
 http://ozlabs.org/~akpm/mmotm/series
 
 The file broken-out.tar.gz contains two datestamp files: .DATE and
 .DATE--mm-dd-hh-mm-ss.  Both contain the string -mm-dd-hh-mm-ss,
 followed by the base kernel version against which this patch series is to
 be applied.
 
 This tree is partially included in linux-next.  To see which patches are
 included in linux-next, consult the `series' file.  Only the patches
 within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in
 linux-next.
 

on i386:
(not from mmotm patches, so must be from linux-next or mainline)

CONFIG_INPUT=m
CONFIG_INPUT_EVDEV=m
CONFIG_DVB_AV7110=y


drivers/built-in.o: In function `input_sync':
av7110_ir.c:(.text+0x14b999): undefined reference to `input_event'
drivers/built-in.o: In function `av7110_emit_key':
av7110_ir.c:(.text+0x14ba4b): undefined reference to `input_event'
av7110_ir.c:(.text+0x14ba63): undefined reference to `input_event'
av7110_ir.c:(.text+0x14bb20): undefined reference to `input_event'
av7110_ir.c:(.text+0x14bb35): undefined reference to `input_event'
drivers/built-in.o:av7110_ir.c:(.text+0x14bb76): more undefined references to 
`input_event' follow
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x14bec7): undefined reference to `input_allocate_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x14bf95): undefined reference to `input_register_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x14bfa5): undefined reference to `input_free_device'
drivers/built-in.o: In function `av7110_ir_exit':
(.text+0x14c0ad): undefined reference to `input_unregister_device'


Possibly just make DVB_AV7110 depend on INPUT.

-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Feb 14 (media/pci/ttpci/av7110_ir.c)

[Randy Dunlap]

On 02/13/2014 09:28 PM, Stephen Rothwell wrote:
 Hi all,
 
 If you see failures in building this tree due to missing declarations of
 k..alloc/free, then it may be caused by commit 2bd59d48ebfb (cgroup:
 convert to kernfs).  Please send Tejun Heo t...@kernel.org a patch
 adding an inclusion of linux/slab.h to the appropriate file(s).
 
 This tree fails (more than usual) the powerpc allyesconfig build.
 
 Changes since 20140213:
 

on i386:

when
CONFIG_DVB_AV7110=y
CONFIG_INPUT=m
CONFIG_INPUT_EVDEV=m


drivers/built-in.o: In function `input_sync':
av7110_ir.c:(.text+0x247276): undefined reference to `input_event'
drivers/built-in.o: In function `av7110_emit_key':
av7110_ir.c:(.text+0x247308): undefined reference to `input_event'
av7110_ir.c:(.text+0x24731e): undefined reference to `input_event'
av7110_ir.c:(.text+0x247384): undefined reference to `input_event'
av7110_ir.c:(.text+0x247399): undefined reference to `input_event'
drivers/built-in.o:av7110_ir.c:(.text+0x2473da): more undefined references to 
`input_event' follow
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x2475b7): undefined reference to `input_allocate_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x247738): undefined reference to `input_register_device'
drivers/built-in.o: In function `av7110_ir_init':
(.text+0x247748): undefined reference to `input_free_device'
drivers/built-in.o: In function `av7110_ir_exit':
(.text+0x24780a): undefined reference to `input_unregister_device'



-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Feb 4 (media/radio/si4713/radio-usb-si4713.c)

[Randy Dunlap]

On 02/03/2014 09:07 PM, Stephen Rothwell wrote:
 Hi all,
 
 This tree fails (more than usual) the powerpc allyesconfig build.
 
 Changes since 20140203:
 

on i386:

# CONFIG_I2C is not set

  CC [M]  drivers/media/radio/si4713/radio-usb-si4713.o
drivers/media/radio/si4713/radio-usb-si4713.c: In function 
'usb_si4713_video_device_release':
drivers/media/radio/si4713/radio-usb-si4713.c:147:2: error: implicit 
declaration of function 'i2c_del_adapter' 
[-Werror=implicit-function-declaration]
drivers/media/radio/si4713/radio-usb-si4713.c: In function 
'si4713_register_i2c_adapter':
drivers/media/radio/si4713/radio-usb-si4713.c:424:2: error: implicit 
declaration of function 'i2c_add_adapter' 
[-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[5]: *** [drivers/media/radio/si4713/radio-usb-si4713.o] Error 1



-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] staging/media: fix sn9c102 dependencies

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix numerous build errors when USB is not enabled.  Examples:

drivers/built-in.o: In function `sn9c102_stop_transfer':
sn9c102_core.c:(.text+0xccbd0a): undefined reference to `usb_kill_urb'
sn9c102_core.c:(.text+0xccbd15): undefined reference to `usb_free_urb'
sn9c102_core.c:(.text+0xccbd4c): undefined reference to `usb_set_interface'
drivers/built-in.o: In function `sn9c102_urb_complete':
sn9c102_core.c:(.text+0xccdca5): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `sn9c102_release_resources':
sn9c102_core.c:(.text+0xcce62b): undefined reference to `usb_put_dev'
drivers/built-in.o: In function `sn9c102_match_id':
(.text+0xcce9d7): undefined reference to `usb_ifnum_to_if'
drivers/built-in.o: In function `sn9c102_match_id':
(.text+0xcce9de): undefined reference to `usb_match_id'
drivers/built-in.o: In function `sn9c102_write_regs':
(.text+0xccea7a): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `sn9c102_open':
sn9c102_core.c:(.text+0xcd17b4): undefined reference to 
`usb_altnum_to_altsetting'
sn9c102_core.c:(.text+0xcd1851): undefined reference to `usb_alloc_urb'
drivers/built-in.o: In function `sn9c102_read_reg':
(.text+0xcd1fdf): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `sn9c102_usb_probe':
sn9c102_core.c:(.text+0xcd275d): undefined reference to `usb_get_dev'
drivers/built-in.o: In function `sn9c102_usb_driver_init':
sn9c102_core.c:(.init.text+0x3e4eb): undefined reference to 
`usb_register_driver'
drivers/built-in.o: In function `sn9c102_usb_driver_exit':
sn9c102_core.c:(.exit.text+0x7226): undefined reference to `usb_deregister'

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Luca Risolia luca.riso...@studio.unibo.it
Cc: Mauro Carvalho Chehab m.che...@samsung.com
---
 drivers/staging/media/sn9c102/Kconfig |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20140107.orig/drivers/staging/media/sn9c102/Kconfig
+++ linux-next-20140107/drivers/staging/media/sn9c102/Kconfig
@@ -1,6 +1,6 @@
 config USB_SN9C102
tristate USB SN9C1xx PC Camera Controller support (DEPRECATED)
-   depends on VIDEO_V4L2
+   depends on VIDEO_V4L2  USB
---help---
  This driver is DEPRECATED, please use the gspca sonixb and
  sonixj modules instead.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] media/platform/marvell-ccic: fix cafe_ccic build error

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

The cafe_ccic driver (the mcam-core.c part of it) uses dma_sg
interfaces so it needs to select VIDEOBUF2_DMA_SG to prevent
build errors.

drivers/built-in.o: In function `mcam_v4l_open':
mcam-core.c:(.text+0x14643e): undefined reference to `vb2_dma_sg_memops'

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Jonathan Corbet cor...@lwn.net
Cc: Hans Verkuil hverk...@xs4all.nl
---
 drivers/media/platform/marvell-ccic/Kconfig |1 +
 1 file changed, 1 insertion(+)

--- linux-next-20131031.orig/drivers/media/platform/marvell-ccic/Kconfig
+++ linux-next-20131031/drivers/media/platform/marvell-ccic/Kconfig
@@ -4,6 +4,7 @@ config VIDEO_CAFE_CCIC
select VIDEO_OV7670
select VIDEOBUF2_VMALLOC
select VIDEOBUF2_DMA_CONTIG
+   select VIDEOBUF2_DMA_SG
---help---
  This is a video4linux2 driver for the Marvell 88ALP01 integrated
  CMOS camera controller.  This is the controller found on first-
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[stable] Re: Dependency bug in the uvcvideo Kconfig

[Randy Dunlap]

On 09/19/13 13:17, Randy Dunlap wrote:
 On 09/18/13 20:44, Jeff P. Zacher wrote:
  

 You are correct that this problem shown in the forum was in 3.5.4. However, 
 I am 
 having wither the same or similar problem in 3.10.7.
 Here is the broken config file, saved as .config-bad

 
 The failing kernel config file is attached.

For Linux 3.10.x:


This is already fixed in mainline but patches need to be backported.
Specifically these 2 commits (in this order):


commit a0f9354b1a319cb29c331bfd2e5a15d7f9b87fa4
Author: Randy Dunlap rdun...@infradead.org
Date:   Wed May 8 17:28:13 2013 -0300

[media] media/usb: fix kconfig dependencies

and

commit 5077ac3b8108007f4a2b4589f2d373cf55453206
Author: Mauro Carvalho Chehab mche...@redhat.com
Date:   Wed May 22 11:25:52 2013 -0300

Properly handle tristate dependencies on USB/PCI menus


  

  

 On Wednesday, September 18, 2013 03:52:36 PM you wrote:

 On 09/18/13 08:37, Peter Senna Tschudin wrote:

 Hi Randy,



 I've tried to download the .config file from the link on the forum,

 but it tries to install something in my browser and the file is not

 downloadable for me. Can you provide it over an simpler interface such

 as pastebin.com?



 Thanks



 The original poster (Jeff) should have mentioned that is is a build bug

 problem in Linux 3.5.4. Jeff, have you tried 3.5.7? I expect that this

 problem is already fixed, if not in 3.5.x then in some later kernel

 version.



 Jeff, also please provide the kernel .config file as an attachment here

 since the one posted in the forum does not download (or has been deleted).

 On Wed, Sep 18, 2013 at 4:59 PM, Randy Dunlap rdun...@infradead.org 
 wrote:

 [adding linux-media mailing list]



 On 09/18/13 06:18, Jeff P. Zacher wrote:

 Not subscribed, please CC'me in replies:



 There seems to be a dependency bug in the Kconfig for the uvcvideo

 kernel

 module. If uvcvideo is built in and usb support is built as a module,

 the

 kernel build will fail with the obviously missing dependanies.





 Error logs:



 * ERROR: Failed to compile the bzImage target...

 *

 * -- Grepping log... --

 *

 * SHIPPED scripts/genksyms/keywords.hash.c

 * SHIPPED scripts/genksyms/parse.tab.h

 * SHIPPED scripts/genksyms/parse.tab.c

 * HOSTCC scripts/genksyms/lex.lex.o

 *scripts/genksyms/lex.lex.c_shipped: In function ‘yylex1’:

 *scripts/genksyms/lex.lex.c_shipped:904:1: warning: ignoring return

 value of ‘fwrite’, declared with attribute warn_unused_result

 [-Wunused-result] *--

 * CC drivers/video/console/font_8x16.o

 * CC drivers/video/console/softcursor.o

 * CC sound/core/seq/seq_memory.o

 * CC drivers/video/console/fbcondecor.o

 * CC sound/core/seq/seq_queue.o

 *drivers/video/console/fbcondecor.c:511:6: warning: function declaration

 isn’t a prototype [-Wstrict-prototypes]

 *--

 *(.text+0xf8fb1): undefined reference to `usb_submit_urb'

 *drivers/built-in.o: In function `uvc_init':

 *uvc_driver.c:(.init.text+0x908a): undefined reference to

 `usb_register_driver'

 *drivers/built-in.o: In function `uvc_cleanup':

 *uvc_driver.c:(.exit.text+0x67e): undefined reference to

 `usb_deregister'

 *make: *** [vmlinux] Error 1

 *--

 * Running with options: --lvm --menuconfig all

 * Using genkernel.conf from /etc/genkernel.conf

 * Sourcing arch-specific config.sh from

 /usr/share/genkernel/arch/x86_64/config.sh ..

 * Sourcing arch-specific modules_load from

 /usr/share/genkernel/arch/x86_64/modules_load ..

 *

 * ERROR: Failed to compile the bzImage target...

 *

 * -- End log... --



 Compiling uvc as a module allows the compilation to complete.



 Platform x86_64



 Ref: http://forums.gentoo.org/viewtopic-p-7398782.html#7398782


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Dependency bug in the uvcvideo Kconfig

[Randy Dunlap]

[adding linux-media mailing list]


On 09/18/13 06:18, Jeff P. Zacher wrote:
 Not subscribed, please CC'me in replies:
 
 There seems to be a dependency bug in the Kconfig for the uvcvideo kernel 
 module.  If uvcvideo is built in and usb support is built as a module, the 
 kernel build will fail with the obviously missing dependanies.
 
 
 Error logs:
 
 * ERROR: Failed to compile the bzImage target...
 * 
 * -- Grepping log... --
 * 
 *  SHIPPED scripts/genksyms/keywords.hash.c
 *  SHIPPED scripts/genksyms/parse.tab.h
 *  SHIPPED scripts/genksyms/parse.tab.c
 *  HOSTCC  scripts/genksyms/lex.lex.o
 *scripts/genksyms/lex.lex.c_shipped: In function ‘yylex1’:
 *scripts/genksyms/lex.lex.c_shipped:904:1: warning: ignoring return value of 
 ‘fwrite’, declared with attribute warn_unused_result [-Wunused-result]
 *--
 *  CC  drivers/video/console/font_8x16.o
 *  CC  drivers/video/console/softcursor.o
 *  CC  sound/core/seq/seq_memory.o
 *  CC  drivers/video/console/fbcondecor.o
 *  CC  sound/core/seq/seq_queue.o
 *drivers/video/console/fbcondecor.c:511:6: warning: function declaration 
 isn’t 
 a prototype [-Wstrict-prototypes]
 *--
 *(.text+0xf8fb1): undefined reference to `usb_submit_urb'
 *drivers/built-in.o: In function `uvc_init':
 *uvc_driver.c:(.init.text+0x908a): undefined reference to 
 `usb_register_driver'
 *drivers/built-in.o: In function `uvc_cleanup':
 *uvc_driver.c:(.exit.text+0x67e): undefined reference to `usb_deregister'
 *make: *** [vmlinux] Error 1
 *--
 * Running with options: --lvm --menuconfig all
 * Using genkernel.conf from /etc/genkernel.conf
 * Sourcing arch-specific config.sh from 
 /usr/share/genkernel/arch/x86_64/config.sh ..
 * Sourcing arch-specific modules_load from 
 /usr/share/genkernel/arch/x86_64/modules_load ..
 *
 * ERROR: Failed to compile the bzImage target...
 * 
 * -- End log... --
 
 Compiling uvc as a module allows the compilation to complete.
 
 Platform x86_64
 
 Ref: http://forums.gentoo.org/viewtopic-p-7398782.html#7398782
 
 
 -- Jeff P. Zacher
 ad_si...@yahoo.com


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Dependency bug in the uvcvideo Kconfig

[Randy Dunlap]

On 09/18/13 08:37, Peter Senna Tschudin wrote:
 Hi Randy,
 
 I've tried to download the .config file from the link on the forum,
 but it tries to install something in my browser and the file is not
 downloadable for me. Can you provide it over an simpler interface such
 as pastebin.com?
 
 Thanks

The original poster (Jeff) should have mentioned that is is a build bug problem 
in
Linux 3.5.4.  Jeff, have you tried 3.5.7?  I expect that this problem is already
fixed, if not in 3.5.x then in some later kernel version.

Jeff, also please provide the kernel .config file as an attachment here since
the one posted in the forum does not download (or has been deleted).


 On Wed, Sep 18, 2013 at 4:59 PM, Randy Dunlap rdun...@infradead.org wrote:
 [adding linux-media mailing list]


 On 09/18/13 06:18, Jeff P. Zacher wrote:
 Not subscribed, please CC'me in replies:

 There seems to be a dependency bug in the Kconfig for the uvcvideo kernel
 module.  If uvcvideo is built in and usb support is built as a module, the
 kernel build will fail with the obviously missing dependanies.


 Error logs:

 * ERROR: Failed to compile the bzImage target...
 *
 * -- Grepping log... --
 *
 *  SHIPPED scripts/genksyms/keywords.hash.c
 *  SHIPPED scripts/genksyms/parse.tab.h
 *  SHIPPED scripts/genksyms/parse.tab.c
 *  HOSTCC  scripts/genksyms/lex.lex.o
 *scripts/genksyms/lex.lex.c_shipped: In function ‘yylex1’:
 *scripts/genksyms/lex.lex.c_shipped:904:1: warning: ignoring return value of
 ‘fwrite’, declared with attribute warn_unused_result [-Wunused-result]
 *--
 *  CC  drivers/video/console/font_8x16.o
 *  CC  drivers/video/console/softcursor.o
 *  CC  sound/core/seq/seq_memory.o
 *  CC  drivers/video/console/fbcondecor.o
 *  CC  sound/core/seq/seq_queue.o
 *drivers/video/console/fbcondecor.c:511:6: warning: function declaration 
 isn’t
 a prototype [-Wstrict-prototypes]
 *--
 *(.text+0xf8fb1): undefined reference to `usb_submit_urb'
 *drivers/built-in.o: In function `uvc_init':
 *uvc_driver.c:(.init.text+0x908a): undefined reference to
 `usb_register_driver'
 *drivers/built-in.o: In function `uvc_cleanup':
 *uvc_driver.c:(.exit.text+0x67e): undefined reference to `usb_deregister'
 *make: *** [vmlinux] Error 1
 *--
 * Running with options: --lvm --menuconfig all
 * Using genkernel.conf from /etc/genkernel.conf
 * Sourcing arch-specific config.sh from
 /usr/share/genkernel/arch/x86_64/config.sh ..
 * Sourcing arch-specific modules_load from
 /usr/share/genkernel/arch/x86_64/modules_load ..
 *
 * ERROR: Failed to compile the bzImage target...
 *
 * -- End log... --

 Compiling uvc as a module allows the compilation to complete.

 Platform x86_64

 Ref: http://forums.gentoo.org/viewtopic-p-7398782.html#7398782


 -- Jeff P. Zacher
 ad_si...@yahoo.com


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] staging/media: fix msi3101 build errors

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix build error when VIDEOBUF2_CORE=m and USB_MSI3101=y.

drivers/built-in.o: In function `msi3101_buf_queue':
sdr-msi3101.c:(.text+0x1298d6): undefined reference to `vb2_buffer_done'
drivers/built-in.o: In function `msi3101_cleanup_queued_bufs':
sdr-msi3101.c:(.text+0x1299c7): undefined reference to `vb2_buffer_done'
drivers/built-in.o: In function `msi3101_isoc_handler':
sdr-msi3101.c:(.text+0x12a08d): undefined reference to `vb2_plane_vaddr'
sdr-msi3101.c:(.text+0x12a0b9): undefined reference to `vb2_buffer_done'
drivers/built-in.o: In function `msi3101_probe':
sdr-msi3101.c:(.text+0x12a1c5): undefined reference to `vb2_vmalloc_memops'
sdr-msi3101.c:(.text+0x12a1d7): undefined reference to `vb2_queue_init'
drivers/built-in.o:(.rodata+0x34cf0): undefined reference to `vb2_ioctl_reqbufs'
drivers/built-in.o:(.rodata+0x34cf4): undefined reference to 
`vb2_ioctl_querybuf'
drivers/built-in.o:(.rodata+0x34cf8): undefined reference to `vb2_ioctl_qbuf'
drivers/built-in.o:(.rodata+0x34d00): undefined reference to `vb2_ioctl_dqbuf'
drivers/built-in.o:(.rodata+0x34d04): undefined reference to 
`vb2_ioctl_create_bufs'
drivers/built-in.o:(.rodata+0x34d08): undefined reference to 
`vb2_ioctl_prepare_buf'
drivers/built-in.o:(.rodata+0x34d18): undefined reference to 
`vb2_ioctl_streamon'
drivers/built-in.o:(.rodata+0x34d1c): undefined reference to 
`vb2_ioctl_streamoff'
drivers/built-in.o:(.rodata+0x35580): undefined reference to `vb2_fop_read'
drivers/built-in.o:(.rodata+0x35588): undefined reference to `vb2_fop_poll'
drivers/built-in.o:(.rodata+0x35598): undefined reference to `vb2_fop_mmap'
drivers/built-in.o:(.rodata+0x355a0): undefined reference to `vb2_fop_release'
drivers/built-in.o:(.data+0x23b40): undefined reference to 
`vb2_ops_wait_prepare'
drivers/built-in.o:(.data+0x23b44): undefined reference to `vb2_ops_wait_finish'

Signed-off-by: Randy Dunlap rdun...@infradead.org
Cc: Antti Palosaari cr...@iki.fi
---
 drivers/staging/media/msi3101/Kconfig |2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20130912.orig/drivers/staging/media/msi3101/Kconfig
+++ linux-next-20130912/drivers/staging/media/msi3101/Kconfig
@@ -1,3 +1,5 @@
 config USB_MSI3101
tristate Mirics MSi3101 SDR Dongle
depends on USB  VIDEO_DEV  VIDEO_V4L2
+   select VIDEOBUF2_CORE
+   select VIDEOBUF2_VMALLOC
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usbtv: fix dependency

[Randy Dunlap]

On 06/28/13 10:54, Mauro Carvalho Chehab wrote:
 Em Fri, 28 Jun 2013 10:55:15 -0300
 Mauro Carvalho Chehab mche...@redhat.com escreveu:
 
 This patch

 http://git.linuxtv.org/gliakhovetski/v4l-dvb.git/commitdiff/a92d0222c693db29a5d00eaedcdebf748789c38e

 has been pushed 3 days ago:

 https://patchwork.linuxtv.org/patch/19090/

 As, according with:
  https://lwn.net/Articles/556034/rss

 -rc7 is likely the last one before 3.10, that means that the media merge
 window for 3.11 is closed already (as we close it one week before, in order
 to give more time for reviewing the patches better at -next).

 So, please split the fix patches from it on a separate pull request.
 
 Hmm... just took a look at the actual pull request... from the description,
 it seems to contain just fixes/documentation, so, I'll be handling it
 in a few.

Has this patch been merged yet?  If so, where?

This build failure is still occurring in linux-next-20130703.


thanks,

-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Jun 27 (v4l2 usbtv)

[Randy Dunlap]

On 06/27/13 02:24, Stephen Rothwell wrote:
 Hi all,
 
 Changes since 20130626:
 

on i386:

CONFIG_VIDEO_USBTV=y
CONFIG_I2C=m
CONFIG_VIDEO_V4L2=m


Looks like VIDEO_USBTV should depend on VIDEO_V4L2.


drivers/built-in.o: In function `vb2_fop_mmap':
(.text+0x199b4e): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_streamoff':
(.text+0x19a00b): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_streamon':
(.text+0x19a134): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_expbuf':
(.text+0x19a2cb): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_ioctl_querybuf':
(.text+0x19a3fe): undefined reference to `video_devdata'
drivers/built-in.o:(.text+0x19ad7d): more undefined references to 
`video_devdata' follow
drivers/built-in.o: In function `vb2_poll':
(.text+0x19bef0): undefined reference to `v4l2_event_pending'
drivers/built-in.o: In function `vb2_fop_poll':
(.text+0x19c0ce): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_fop_release':
(.text+0x19c21c): undefined reference to `video_devdata'
drivers/built-in.o: In function `vb2_fop_release':
(.text+0x19c24a): undefined reference to `v4l2_fh_release'
drivers/built-in.o: In function `usbtv_release':
usbtv.c:(.text+0x1a9411): undefined reference to `v4l2_device_unregister'
drivers/built-in.o: In function `usbtv_querycap':
usbtv.c:(.text+0x1a942e): undefined reference to `video_devdata'
drivers/built-in.o: In function `usbtv_probe':
usbtv.c:(.text+0x1a95da): undefined reference to `v4l2_device_register'
usbtv.c:(.text+0x1a961e): undefined reference to `video_device_release_empty'
usbtv.c:(.text+0x1a9689): undefined reference to `__video_register_device'
usbtv.c:(.text+0x1a96a3): undefined reference to `v4l2_device_unregister'
drivers/built-in.o: In function `usbtv_disconnect':
usbtv.c:(.text+0x1a9937): undefined reference to `video_unregister_device'
usbtv.c:(.text+0x1a993e): undefined reference to `v4l2_device_disconnect'
drivers/built-in.o: In function `usbtv_iso_cb':
usbtv.c:(.text+0x1a9b5c): undefined reference to `v4l2_get_timestamp'
drivers/built-in.o: In function `usbtv_disconnect':
usbtv.c:(.text+0x1a9966): undefined reference to `v4l2_device_put'
drivers/built-in.o:(.data+0x22918): undefined reference to `video_ioctl2'
drivers/built-in.o:(.data+0x22924): undefined reference to `v4l2_fh_open'



-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mmotm 2013-06-27-16-36 uploaded (v4l2 without I2C)

[Randy Dunlap]

On 06/27/13 16:37, a...@linux-foundation.org wrote:
 The mm-of-the-moment snapshot 2013-06-27-16-36 has been uploaded to
 
http://www.ozlabs.org/~akpm/mmotm/
 
 mmotm-readme.txt says
 
 README for mm-of-the-moment:
 
 http://www.ozlabs.org/~akpm/mmotm/
 

on x86_64:

CONFIG_I2C is not enabled.

drivers/built-in.o: In function `match_i2c':
v4l2-async.c:(.text+0x12f4c8): undefined reference to `i2c_verify_client'


Full randconfig file is attached.


-- 
~Randy
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 3.10.0-rc7-mm1 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_OUTPUT_FORMAT=elf64-x86-64
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_ARCH_HAS_CPU_AUTOPROBE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx 
-fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10 
-fcall-saved-r11
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config
CONFIG_CONSTRUCTORS=y
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y

#
# General setup
#
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=
CONFIG_COMPILE_TEST=y
CONFIG_LOCALVERSION=
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
CONFIG_KERNEL_LZO=y
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME=(none)
# CONFIG_SWAP is not set
# CONFIG_SYSVIPC is not set
CONFIG_POSIX_MQUEUE=y
CONFIG_POSIX_MQUEUE_SYSCTL=y
CONFIG_FHANDLE=y
# CONFIG_AUDIT is not set
CONFIG_HAVE_GENERIC_HARDIRQS=y

#
# IRQ subsystem
#
CONFIG_GENERIC_HARDIRQS=y
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_IRQ_DOMAIN=y
# CONFIG_IRQ_DOMAIN_DEBUG is not set
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BUILD=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONFIG_GENERIC_CMOS_UPDATE=y

#
# Timers subsystem
#
CONFIG_TICK_ONESHOT=y
CONFIG_NO_HZ_COMMON=y
# CONFIG_HZ_PERIODIC is not set
CONFIG_NO_HZ_IDLE=y
# CONFIG_NO_HZ is not set
# CONFIG_HIGH_RES_TIMERS is not set

#
# CPU/Task time and stats accounting
#
CONFIG_TICK_CPU_ACCOUNTING=y
# CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set
# CONFIG_IRQ_TIME_ACCOUNTING is not set
# CONFIG_BSD_PROCESS_ACCT is not set
# CONFIG_TASKSTATS is not set

#
# RCU Subsystem
#
CONFIG_TINY_RCU=y
# CONFIG_PREEMPT_RCU is not set
# CONFIG_RCU_STALL_COMMON is not set
# CONFIG_TREE_RCU_TRACE is not set
# CONFIG_IKCONFIG is not set
CONFIG_LOG_BUF_SHIFT=17
CONFIG_HAVE_UNSTABLE_SCHED_CLOCK=y
CONFIG_ARCH_SUPPORTS_NUMA_BALANCING=y
CONFIG_ARCH_WANTS_PROT_NUMA_PROT_NONE=y
CONFIG_CGROUPS=y
# CONFIG_CGROUP_DEBUG is not set
CONFIG_CGROUP_FREEZER=y
CONFIG_CGROUP_DEVICE=y
CONFIG_CPUSETS=y
CONFIG_PROC_PID_CPUSET=y
# CONFIG_CGROUP_CPUACCT is not set
CONFIG_RESOURCE_COUNTERS=y
# CONFIG_MEMCG is not set
# CONFIG_CGROUP_PERF is not set
CONFIG_CGROUP_SCHED=y
CONFIG_FAIR_GROUP_SCHED=y
CONFIG_CFS_BANDWIDTH=y
# CONFIG_RT_GROUP_SCHED is not set
CONFIG_BLK_CGROUP=y
CONFIG_DEBUG_BLK_CGROUP=y
# CONFIG_CHECKPOINT_RESTORE is not set
CONFIG_NAMESPACES=y
# CONFIG_UTS_NS is not set
CONFIG_IPC_NS=y
CONFIG_PID_NS=y
# CONFIG_NET_NS is not set
CONFIG_SCHED_AUTOGROUP=y
# CONFIG_SYSFS_DEPRECATED is not set
CONFIG_RELAY=y
# CONFIG_BLK_DEV_INITRD is not set
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_SYSCTL=y
CONFIG_ANON_INODES=y
CONFIG_SYSCTL_EXCEPTION_TRACE=y
CONFIG_HAVE_PCSPKR_PLATFORM=y
# CONFIG_EXPERT is not set
# CONFIG_SYSCTL_SYSCALL is not set
CONFIG_KALLSYMS=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_PCSPKR_PLATFORM=y
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_EPOLL=y
CONFIG_SIGNALFD=y
CONFIG_TIMERFD=y
CONFIG_EVENTFD=y
CONFIG_SHMEM=y
CONFIG_AIO=y
# CONFIG_EMBEDDED is not set
CONFIG_HAVE_PERF_EVENTS=y

#
# Kernel Performance Events And Counters
#
CONFIG_PERF_EVENTS=y
CONFIG_VM_EVENT_COUNTERS=y
# 

Re: [PATCH] uvc: Depend on VIDEO_V4L2

[Randy Dunlap]

On 06/22/13 07:25, Laurent Pinchart wrote:
 The uvcvideo driver lost its dependency on VIDEO_V4L2 during the big
 media directory reorganization. Add it back.
 
 Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Reported-by: Randy Dunlap rdun...@infradead.org
Acked-by: Randy Dunlap rdun...@infradead.org

Thanks.


 ---
  drivers/media/usb/uvc/Kconfig | 1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/media/usb/uvc/Kconfig b/drivers/media/usb/uvc/Kconfig
 index 541c9f1..6ed85ef 100644
 --- a/drivers/media/usb/uvc/Kconfig
 +++ b/drivers/media/usb/uvc/Kconfig
 @@ -1,5 +1,6 @@
  config USB_VIDEO_CLASS
   tristate USB Video Class (UVC)
 + depends on VIDEO_V4L2
   select VIDEOBUF2_VMALLOC
   ---help---
 Support for the USB Video Class (UVC).  Currently only video
 


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Jun 3 (fonts.c vivi)

[Randy Dunlap]

On 06/02/13 23:37, Stephen Rothwell wrote:
 Hi all,
 
 Changes since 20130531:
 


on x86_64:

warning: (VIDEO_VIVI  USB_SISUSBVGA  SOLO6X10) selects FONT_SUPPORT which 
has unmet direct dependencies (HAS_IOMEM  VT)
warning: (VIDEO_VIVI  FB_VGA16  FB_S3  FB_VT8623  FB_ARK  
USB_SISUSBVGA_CON  SOLO6X10) selects FONT_8x16 which has unmet direct 
dependencies (HAS_IOMEM  VT  FONT_SUPPORT)


drivers/built-in.o: In function `vivi_init':
vivi.c:(.init.text+0x1a3da): undefined reference to `find_font'

when CONFIG_VT is not enabled.

Just make CONFIG_VIDEO_VIVI depend on VT ?


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Tree for Jun 3 (fonts.c vivi)

[Randy Dunlap]

On 06/03/13 13:54, Geert Uytterhoeven wrote:
 On Mon, Jun 3, 2013 at 10:34 PM, Randy Dunlap rdun...@infradead.org wrote:
 On 06/02/13 23:37, Stephen Rothwell wrote:
 Changes since 20130531:
 on x86_64:

 warning: (VIDEO_VIVI  USB_SISUSBVGA  SOLO6X10) selects FONT_SUPPORT 
 which has unmet direct dependencies (HAS_IOMEM  VT)
 warning: (VIDEO_VIVI  FB_VGA16  FB_S3  FB_VT8623  FB_ARK  
 USB_SISUSBVGA_CON  SOLO6X10) selects FONT_8x16 which has unmet direct 
 dependencies (HAS_IOMEM  VT  FONT_SUPPORT)
 
 I knew about thet warning. But I thought it was harmless, as none of the font
 code really depends on console support...
 
 drivers/built-in.o: In function `vivi_init':
 vivi.c:(.init.text+0x1a3da): undefined reference to `find_font'

 when CONFIG_VT is not enabled.
 
 ... but I missed that drivers/video/console is not used if CONFIG_VT=y.
 Sorry for that.
 
 Just make CONFIG_VIDEO_VIVI depend on VT ?
 
 Does this (whitespace-damaged copy-and-paste) help?

Yes, that works.  Thanks.

Acked-by: Randy Dunlap rdun...@infradead.org


 --- a/drivers/video/Makefile
 +++ b/drivers/video/Makefile
 @@ -12,7 +12,7 @@ fb-y  := fbmem.o fbmon.o 
 fbcmap.o
   modedb.o fbcvt.o
  fb-objs   := $(fb-y)
 
 -obj-$(CONFIG_VT) += console/
 +obj-y+= console/
  obj-$(CONFIG_LOGO)   += logo/
  obj-y+= backlight/
 
 It shouldn't make a difference if nothing inside drivers/video/console
 is enabled,
 as all objects in drivers/video/console/Makefile are conditional.
 
 BTW, my plan was to move the font code to lib/font, but I haven't done that 
 yet.


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH -next] media: fix hdpvr kconfig/build errors

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

Fix hdpvr build errors when CONFIG_I2C=m and VIDEO_V4L2=m and
VIDEO_HDPVR=y.

drivers/built-in.o: In function `hdpvr_disconnect':
hdpvr-core.c:(.text+0xef542): undefined reference to `v4l2_device_disconnect'
hdpvr-core.c:(.text+0xef57e): undefined reference to `i2c_del_adapter'
hdpvr-core.c:(.text+0xef58a): undefined reference to `video_unregister_device'
drivers/built-in.o: In function `hdpvr_delete':
(.text+0xef5b9): undefined reference to `video_device_release'
drivers/built-in.o: In function `hdpvr_probe':
hdpvr-core.c:(.text+0xef63a): undefined reference to `v4l2_device_register'
hdpvr-core.c:(.text+0xefd97): undefined reference to `i2c_del_adapter'
drivers/built-in.o: In function `hdpvr_s_ctrl':
hdpvr-video.c:(.text+0xf03c0): undefined reference to `v4l2_ctrl_activate'
drivers/built-in.o: In function `hdpvr_device_release':
hdpvr-video.c:(.text+0xf0470): undefined reference to `v4l2_device_unregister'
hdpvr-video.c:(.text+0xf0479): undefined reference to `v4l2_ctrl_handler_free'
hdpvr-video.c:(.text+0xf048f): undefined reference to `i2c_del_adapter'
drivers/built-in.o: In function `hdpvr_open':
hdpvr-video.c:(.text+0xf0570): undefined reference to `video_devdata'
hdpvr-video.c:(.text+0xf057b): undefined reference to `v4l2_fh_init'
hdpvr-video.c:(.text+0xf0583): undefined reference to `v4l2_fh_add'
drivers/built-in.o: In function `video_drvdata':
hdpvr-video.c:(.text+0xf08a0): undefined reference to `video_devdata'
drivers/built-in.o: In function `vidioc_s_dv_timings':
hdpvr-video.c:(.text+0xf0d34): undefined reference to `v4l_match_dv_timings'
drivers/built-in.o: In function `hdpvr_poll':
hdpvr-video.c:(.text+0xf1455): undefined reference to `v4l2_ctrl_poll'
drivers/built-in.o: In function `hdpvr_release':
hdpvr-video.c:(.text+0xf18f6): undefined reference to `v4l2_fh_release'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1be3): undefined reference to `v4l2_ctrl_handler_init_class'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1c19): undefined reference to `v4l2_ctrl_new_std'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1c42): undefined reference to `v4l2_ctrl_new_std'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1c6b): undefined reference to `v4l2_ctrl_new_std'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1cac): undefined reference to `v4l2_ctrl_new_std'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1cd5): undefined reference to `v4l2_ctrl_new_std'
drivers/built-in.o:(.text+0xf1cfe): more undefined references to 
`v4l2_ctrl_new_std' follow
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1d75): undefined reference to `v4l2_ctrl_new_std_menu'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1d9e): undefined reference to `v4l2_ctrl_new_std_menu'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1dc3): undefined reference to `v4l2_ctrl_new_std_menu'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1de5): undefined reference to `v4l2_ctrl_new_std_menu'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1e18): undefined reference to `v4l2_ctrl_new_std'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1e4b): undefined reference to `v4l2_ctrl_new_std'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1e90): undefined reference to `v4l2_ctrl_cluster'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1e98): undefined reference to `v4l2_ctrl_handler_setup'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1ec1): undefined reference to `video_device_alloc'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1f85): undefined reference to `__video_register_device'
drivers/built-in.o: In function `hdpvr_register_videodev':
(.text+0xf1fac): undefined reference to `v4l2_ctrl_handler_free'
drivers/built-in.o: In function `hdpvr_register_ir_tx_i2c':
(.text+0xf238f): undefined reference to `i2c_new_device'
drivers/built-in.o: In function `hdpvr_register_ir_rx_i2c':
(.text+0xf2434): undefined reference to `i2c_new_device'
drivers/built-in.o: In function `hdpvr_register_i2c_adapter':
(.text+0xf2514): undefined reference to `i2c_add_adapter'
drivers/built-in.o:(.rodata+0x1b368): undefined reference to `video_ioctl2'
drivers/built-in.o:(.rodata+0x1b690): undefined reference to 
`v4l2_ctrl_log_status'
drivers/built-in.o:(.rodata+0x1b6f8): undefined reference to 
`v4l2_ctrl_subscribe_event'
drivers/built-in.o:(.rodata+0x1b700): undefined reference to 
`v4l2_event_unsubscribe'

Signed-off-by: Randy Dunlap rdun...@infradead.org
---
 drivers/media/usb/hdpvr/Kconfig |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20130520.orig/drivers/media/usb/hdpvr/Kconfig
+++ linux-next-20130520/drivers/media/usb/hdpvr/Kconfig
@@ -1,7 +1,7

[PATCH -next] media/usb: fix kconfig dependencies (aka bool depending on tristate considered harmful)

[Randy Dunlap]

From: Randy Dunlap rdun...@infradead.org

(a.k.a. Kconfig bool depending on a tristate considered harmful)

Fix various build errors when CONFIG_USB=m and media USB drivers
are builtin.  In this case, CONFIG_USB_ZR364XX=y,
CONFIG_VIDEO_PVRUSB2=y, and CONFIG_VIDEO_STK1160=y.

This is caused by (from drivers/media/usb/Kconfig):

menuconfig MEDIA_USB_SUPPORT
bool Media USB Adapters
depends on USB  MEDIA_SUPPORT
   =m =y
so MEDIA_USB_SUPPORT=y and all following Kconfig 'source' lines
are included.  By adding an if USB guard around the 'source' lines,
the needed dependencies are enforced.


drivers/built-in.o: In function `zr364xx_start_readpipe':
zr364xx.c:(.text+0xc726a): undefined reference to `usb_alloc_urb'
zr364xx.c:(.text+0xc72bb): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `zr364xx_stop_readpipe':
zr364xx.c:(.text+0xc72fd): undefined reference to `usb_kill_urb'
zr364xx.c:(.text+0xc7309): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `read_pipe_completion':
zr364xx.c:(.text+0xc7acc): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `send_control_msg.constprop.12':
zr364xx.c:(.text+0xc7d2f): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `pvr2_ctl_timeout':
pvrusb2-hdw.c:(.text+0xcadb6): undefined reference to `usb_unlink_urb'
pvrusb2-hdw.c:(.text+0xcadcb): undefined reference to `usb_unlink_urb'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc42c): undefined reference to `usb_alloc_urb'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc448): undefined reference to `usb_alloc_urb'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc5f9): undefined reference to `usb_set_interface'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc65a): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc666): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `pvr2_send_request_ex.part.22':
pvrusb2-hdw.c:(.text+0xccbe3): undefined reference to `usb_submit_urb'
pvrusb2-hdw.c:(.text+0xccc83): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `pvr2_hdw_remove_usb_stuff.part.25':
pvrusb2-hdw.c:(.text+0xcd3f9): undefined reference to `usb_kill_urb'
pvrusb2-hdw.c:(.text+0xcd405): undefined reference to `usb_free_urb'
pvrusb2-hdw.c:(.text+0xcd421): undefined reference to `usb_kill_urb'
pvrusb2-hdw.c:(.text+0xcd42d): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `pvr2_hdw_device_reset':
(.text+0xcd658): undefined reference to `usb_lock_device_for_reset'
drivers/built-in.o: In function `pvr2_hdw_device_reset':
(.text+0xcd664): undefined reference to `usb_reset_device'
drivers/built-in.o: In function `pvr2_hdw_cpureset_assert':
(.text+0xcd6f9): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `pvr2_hdw_cpufw_set_enabled':
(.text+0xcd84e): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `pvr2_upload_firmware1':
pvrusb2-hdw.c:(.text+0xcda47): undefined reference to `usb_clear_halt'
pvrusb2-hdw.c:(.text+0xcdb04): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `pvr2_upload_firmware2':
(.text+0xce7dc): undefined reference to `usb_bulk_msg'
drivers/built-in.o: In function `pvr2_stream_buffer_count':
pvrusb2-io.c:(.text+0xd2e05): undefined reference to `usb_alloc_urb'
pvrusb2-io.c:(.text+0xd2e5b): undefined reference to `usb_kill_urb'
pvrusb2-io.c:(.text+0xd2e9f): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `pvr2_stream_internal_flush':
pvrusb2-io.c:(.text+0xd2f9b): undefined reference to `usb_kill_urb'
drivers/built-in.o: In function `pvr2_buffer_queue':
(.text+0xd3328): undefined reference to `usb_kill_urb'
drivers/built-in.o: In function `pvr2_buffer_queue':
(.text+0xd33ea): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `stk1160_read_reg':
(.text+0xd3efa): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `stk1160_write_reg':
(.text+0xd3f4f): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `stop_streaming':
stk1160-v4l.c:(.text+0xd4997): undefined reference to `usb_set_interface'
drivers/built-in.o: In function `start_streaming':
stk1160-v4l.c:(.text+0xd4a9f): undefined reference to `usb_set_interface'
stk1160-v4l.c:(.text+0xd4afa): undefined reference to `usb_submit_urb'
stk1160-v4l.c:(.text+0xd4ba3): undefined reference to `usb_set_interface'
drivers/built-in.o: In function `stk1160_isoc_irq':
stk1160-video.c:(.text+0xd509b): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `stk1160_cancel_isoc':
(.text+0xd50ef): undefined reference to `usb_kill_urb'
drivers/built-in.o: In function `stk1160_free_isoc':
(.text+0xd5155): undefined reference to `usb_free_coherent'
drivers/built-in.o: In function `stk1160_free_isoc':
(.text+0xd515d): undefined

[PATCH -next v2] media/usb: fix kconfig dependencies (aka bool depending on tristate considered harmful)

[Randy Dunlap]

On 05/08/13 14:18, Yann E. MORIN wrote:
 Randy, All,
 
 Why not starting the 'if USB' block just above MEDIA_USB_SUPPORT, and
 removing the 'depends on USB' from MEDIA_USB_SUPPORT :
 
 ---8--- 
 if USB
 menuconfig MEDIA_USB_SUPPORT
 bool Media USB Adapters
 depends on MEDIA_SUPPORT
 
 if MEDIA_USB_SUPPORT
 ---8--- 
 
 And keeping this hunk as-is:
 @@ -52,3 +53,4 @@ source drivers/media/usb/em28xx/Kconfig
  endif
  
  endif #MEDIA_USB_SUPPORT
 +endif #USB
 
 Regards,
 Yann E. MORIN.

Sure, that works also.  New patch here:

---
From: Randy Dunlap rdun...@infradead.org

(a.k.a. Kconfig bool depending on a tristate considered harmful)

Fix various build errors when CONFIG_USB=m and media USB drivers
are builtin.  In this case, CONFIG_USB_ZR364XX=y,
CONFIG_VIDEO_PVRUSB2=y, and CONFIG_VIDEO_STK1160=y.

This is caused by (from drivers/media/usb/Kconfig):

menuconfig MEDIA_USB_SUPPORT
bool Media USB Adapters
depends on USB  MEDIA_SUPPORT
   =m =y
so MEDIA_USB_SUPPORT=y and all following Kconfig 'source' lines
are included.  By adding an if USB guard around most of this file,
the needed dependencies are enforced.


drivers/built-in.o: In function `zr364xx_start_readpipe':
zr364xx.c:(.text+0xc726a): undefined reference to `usb_alloc_urb'
zr364xx.c:(.text+0xc72bb): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `zr364xx_stop_readpipe':
zr364xx.c:(.text+0xc72fd): undefined reference to `usb_kill_urb'
zr364xx.c:(.text+0xc7309): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `read_pipe_completion':
zr364xx.c:(.text+0xc7acc): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `send_control_msg.constprop.12':
zr364xx.c:(.text+0xc7d2f): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `pvr2_ctl_timeout':
pvrusb2-hdw.c:(.text+0xcadb6): undefined reference to `usb_unlink_urb'
pvrusb2-hdw.c:(.text+0xcadcb): undefined reference to `usb_unlink_urb'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc42c): undefined reference to `usb_alloc_urb'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc448): undefined reference to `usb_alloc_urb'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc5f9): undefined reference to `usb_set_interface'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc65a): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `pvr2_hdw_create':
(.text+0xcc666): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `pvr2_send_request_ex.part.22':
pvrusb2-hdw.c:(.text+0xccbe3): undefined reference to `usb_submit_urb'
pvrusb2-hdw.c:(.text+0xccc83): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `pvr2_hdw_remove_usb_stuff.part.25':
pvrusb2-hdw.c:(.text+0xcd3f9): undefined reference to `usb_kill_urb'
pvrusb2-hdw.c:(.text+0xcd405): undefined reference to `usb_free_urb'
pvrusb2-hdw.c:(.text+0xcd421): undefined reference to `usb_kill_urb'
pvrusb2-hdw.c:(.text+0xcd42d): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `pvr2_hdw_device_reset':
(.text+0xcd658): undefined reference to `usb_lock_device_for_reset'
drivers/built-in.o: In function `pvr2_hdw_device_reset':
(.text+0xcd664): undefined reference to `usb_reset_device'
drivers/built-in.o: In function `pvr2_hdw_cpureset_assert':
(.text+0xcd6f9): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `pvr2_hdw_cpufw_set_enabled':
(.text+0xcd84e): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `pvr2_upload_firmware1':
pvrusb2-hdw.c:(.text+0xcda47): undefined reference to `usb_clear_halt'
pvrusb2-hdw.c:(.text+0xcdb04): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `pvr2_upload_firmware2':
(.text+0xce7dc): undefined reference to `usb_bulk_msg'
drivers/built-in.o: In function `pvr2_stream_buffer_count':
pvrusb2-io.c:(.text+0xd2e05): undefined reference to `usb_alloc_urb'
pvrusb2-io.c:(.text+0xd2e5b): undefined reference to `usb_kill_urb'
pvrusb2-io.c:(.text+0xd2e9f): undefined reference to `usb_free_urb'
drivers/built-in.o: In function `pvr2_stream_internal_flush':
pvrusb2-io.c:(.text+0xd2f9b): undefined reference to `usb_kill_urb'
drivers/built-in.o: In function `pvr2_buffer_queue':
(.text+0xd3328): undefined reference to `usb_kill_urb'
drivers/built-in.o: In function `pvr2_buffer_queue':
(.text+0xd33ea): undefined reference to `usb_submit_urb'
drivers/built-in.o: In function `stk1160_read_reg':
(.text+0xd3efa): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `stk1160_write_reg':
(.text+0xd3f4f): undefined reference to `usb_control_msg'
drivers/built-in.o: In function `stop_streaming':
stk1160-v4l.c:(.text+0xd4997): undefined reference to `usb_set_interface'
drivers/built-in.o: In function `start_streaming':
stk1160-v4l.c:(.text+0xd4a9f): undefined reference to `usb_set_interface'
stk1160-v4l.c:(.text+0xd4afa