Re: [PATCH 2/3] media: ov2640: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY
Hi Akinobu, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Akinobu-Mita/media-ov2640-fix-two-problems/20181208-165345 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-x011-201848 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers/media//i2c/ov2640.c: In function 'ov2640_get_fmt': >> drivers/media//i2c/ov2640.c:930:8: error: implicit declaration of function >> 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? >> [-Werror=implicit-function-declaration] mf = v4l2_subdev_get_try_format(sd, cfg, 0); ^~ v4l2_subdev_notify_event >> drivers/media//i2c/ov2640.c:930:6: warning: assignment makes pointer from >> integer without a cast [-Wint-conversion] mf = v4l2_subdev_get_try_format(sd, cfg, 0); ^ drivers/media//i2c/ov2640.c: In function 'ov2640_init_cfg': >> drivers/media//i2c/ov2640.c:1007:3: warning: initialization makes pointer >> from integer without a cast [-Wint-conversion] v4l2_subdev_get_try_format(sd, cfg, 0); ^~ cc1: some warnings being treated as errors vim +930 drivers/media//i2c/ov2640.c 917 918 static int ov2640_get_fmt(struct v4l2_subdev *sd, 919 struct v4l2_subdev_pad_config *cfg, 920 struct v4l2_subdev_format *format) 921 { 922 struct v4l2_mbus_framefmt *mf = >format; 923 struct i2c_client *client = v4l2_get_subdevdata(sd); 924 struct ov2640_priv *priv = to_ov2640(client); 925 926 if (format->pad) 927 return -EINVAL; 928 929 if (format->which == V4L2_SUBDEV_FORMAT_TRY) { > 930 mf = v4l2_subdev_get_try_format(sd, cfg, 0); 931 format->format = *mf; 932 933 return 0; 934 } 935 936 mf->width = priv->win->width; 937 mf->height = priv->win->height; 938 mf->code= priv->cfmt_code; 939 mf->colorspace = V4L2_COLORSPACE_SRGB; 940 mf->field = V4L2_FIELD_NONE; 941 942 return 0; 943 } 944 945 static int ov2640_set_fmt(struct v4l2_subdev *sd, 946 struct v4l2_subdev_pad_config *cfg, 947 struct v4l2_subdev_format *format) 948 { 949 struct v4l2_mbus_framefmt *mf = >format; 950 struct i2c_client *client = v4l2_get_subdevdata(sd); 951 struct ov2640_priv *priv = to_ov2640(client); 952 const struct ov2640_win_size *win; 953 int ret = 0; 954 955 if (format->pad) 956 return -EINVAL; 957 958 mutex_lock(>lock); 959 960 /* select suitable win */ 961 win = ov2640_select_win(mf->width, mf->height); 962 mf->width = win->width; 963 mf->height = win->height; 964 965 mf->field = V4L2_FIELD_NONE; 966 mf->colorspace = V4L2_COLORSPACE_SRGB; 967 968 switch (mf->code) { 969 case MEDIA_BUS_FMT_RGB565_2X8_BE: 970 case MEDIA_BUS_FMT_RGB565_2X8_LE: 971 case MEDIA_BUS_FMT_YUYV8_2X8: 972 case MEDIA_BUS_FMT_UYVY8_2X8: 973 case MEDIA_BUS_FMT_YVYU8_2X8: 974 case MEDIA_BUS_FMT_VYUY8_2X8: 975 break; 976 default: 977 mf->code = MEDIA_BUS_FMT_UYVY8_2X8; 978 break; 979 } 980 981 if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) { 982 struct ov2640_priv *priv = to_ov2640(client); 983 984 if (priv->streaming) { 985 ret = -EBUSY; 986 goto out; 987 } 988 /* select win */ 989 priv->win = win; 990 /* select format */ 991 priv->cfmt_code = mf->code; 992 } else { 993 cfg->try_fmt = *mf; 994 } 995 out: 996 mutex_unlock(>lock); 997 998 return ret; 999 } 1000 1001 static int ov2640_init_cfg(struct v4l2_subdev *sd, 1002 struct v4l2_subdev_pad_config *cfg) 1003 { 1004 struct i2c_client *client = v4l2_get_subdevdata(sd); 1005 struct ov2640_priv *priv = to_ov2640(client); 1006
Re: [PATCHv3 1/1] Add ir-rcmm-driver
Hi Patrick, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Patrick-LERDA/Add-ir-rcmm-driver/20181208-02 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' include/net/mac80211.h:477: warning: cannot understand function prototype: 'struct ieee80211_ftm_responder_params ' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' kernel/rcu/tree.c:685: warning: Excess function parameter 'irq' description in 'rcu_nmi_exit' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array' include/linux/gpio/driver.h:375: warning: Function parameter or member 'init_valid_mask' not described in 'gpio_chip' include/linux/iio/hw-consumer.h:1: warning: no structured comments found include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not
[ragnatech:media-tree 198/228] arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t'
tree: git://git.ragnatech.se/linux media-tree head: da2c94c8f9739e4099ea3cfefc208fc721b22a9c commit: b6973637c4cc842c1aa7d6c848781b4bdeb4415b [198/228] media: ddbridge: remove another duplicate of io.h and sort includes config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout b6973637c4cc842c1aa7d6c848781b4bdeb4415b # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm All errors (new ones prefixed by >>): In file included from drivers/media/pci/ddbridge/ddbridge.h:22:0, from drivers/media/pci/ddbridge/ddbridge-hw.c:19: >> arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' extern void arch_trigger_cpumask_backtrace(const cpumask_t *mask, ^ >> arch/arm/include/asm/irq.h:36:9: error: unknown type name 'bool'; did you >> mean '_Bool'? bool exclude_self); ^~~~ _Bool vim +/cpumask_t +35 arch/arm/include/asm/irq.h 446616db Russell King 2008-09-06 33 96f0e003 Russell King 2014-09-03 34 #ifdef CONFIG_SMP 9a01c3ed Chris Metcalf 2016-10-07 @35 extern void arch_trigger_cpumask_backtrace(const cpumask_t *mask, 9a01c3ed Chris Metcalf 2016-10-07 @36 bool exclude_self); 9a01c3ed Chris Metcalf 2016-10-07 37 #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace 96f0e003 Russell King 2014-09-03 38 #endif 96f0e003 Russell King 2014-09-03 39 :: The code at line 35 was first introduced by commit :: 9a01c3ed5cdb35d9004eb92510ee6ea11b4a5f16 nmi_backtrace: add more trigger_*_cpu_backtrace() methods :: TO: Chris Metcalf :: CC: Linus Torvalds --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[ragnatech:media-tree] BUILD INCOMPLETE 9b90dc85c718443a3e573a0ccf55900ff4fa73ae
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 9b90dc85c718443a3e573a0ccf55900ff4fa73ae media: seco-cec: add missing header file to fix build TIMEOUT after 1554m Sorry we cannot finish the testset for your branch within a reasonable time. It's our fault -- either some build server is down or some build worker is busy doing bisects for _other_ trees. The branch will get more complete coverage and possible error reports when our build infrastructure is restored or catches up. There will be no more build success notification for this branch head, but you can expect reasonably good test coverage after waiting for 1 day. configs timed out: 151 alphaallmodconfig alphaallyesconfig alpha defconfig arm allnoconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 allnoconfig arm64 defconfig i386 allmodconfig i386randconfig-a0 i386randconfig-a1 i386randconfig-a2 i386randconfig-a3 i386randconfig-f0 i386randconfig-f1 i386randconfig-f2 i386randconfig-f3 i386randconfig-i0 i386randconfig-i1 i386randconfig-i2 i386randconfig-i3 i386randconfig-j0 i386randconfig-j1 i386randconfig-j2 i386randconfig-j3 i386randconfig-k0 i386randconfig-k1 i386randconfig-k2 i386randconfig-k3 i386randconfig-n0 i386randconfig-n1 i386randconfig-n2 i386randconfig-n3 i386randconfig-s0 i386randconfig-s1 i386randconfig-s2 i386randconfig-s3 i386 randconfig-x010 i386 randconfig-x011 i386 randconfig-x012 i386 randconfig-x013 i386 randconfig-x014 i386 randconfig-x015 i386 randconfig-x016 i386 randconfig-x017 i386 randconfig-x018 i386 randconfig-x019 i386 tinyconfig ia64 allmodconfig ia64 allyesconfig m68k allmodconfig m68k allyesconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig microblaze mmu_defconfig microblazenommu_defconfig mips 32r2_defconfig mips 64r6el_defconfig mips allmodconfig mips allyesconfig mips jz4740 mips txx9 nds32allmodconfig nds32allyesconfig openriscor1ksim_defconfig parisc allmodconfig pariscallnoconfig parisc allyesconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig powerpc allmodconfig powerpc allnoconfig powerpc allyesconfig powerpc defconfig powerpc ppc64_defconfig riscvallmodconfig riscvallyesconfig riscv tinyconfig s390 allmodconfig s390 allyesconfig s390default_defconfig sh allmodconfig shallnoconfig sh allyesconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shtitan_defconfig
[ragnatech:media-tree 32/140] drivers/media/platform/seco-cec/seco-cec.c:237:4: error: implicit declaration of function 'cec_transmit_attempt_done'
tree: git://git.ragnatech.se/linux media-tree head: 708d75fe1c7c6e9abc5381b6fcc32b49830383d0 commit: b03c2fb97adcc65d3c4098c4aa41fbaa6623ebf2 [32/140] media: add SECO cec driver config: i386-randconfig-x006-201847 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout b03c2fb97adcc65d3c4098c4aa41fbaa6623ebf2 # save the attached .config to linux build tree make ARCH=i386 Note: the ragnatech/media-tree HEAD 708d75fe1c7c6e9abc5381b6fcc32b49830383d0 builds fine. It only hurts bisectibility. All error/warnings (new ones prefixed by >>): drivers/media/platform/seco-cec/seco-cec.c: In function 'secocec_tx_done': >> drivers/media/platform/seco-cec/seco-cec.c:237:4: error: implicit >> declaration of function 'cec_transmit_attempt_done' >> [-Werror=implicit-function-declaration] cec_transmit_attempt_done(adap, CEC_TX_STATUS_NACK); ^ drivers/media/platform/seco-cec/seco-cec.c: In function 'secocec_rx_done': >> drivers/media/platform/seco-cec/seco-cec.c:316:2: error: implicit >> declaration of function 'cec_received_msg'; did you mean >> 'free_reserved_page'? [-Werror=implicit-function-declaration] cec_received_msg(cec->cec_adap, ); ^~~~ free_reserved_page drivers/media/platform/seco-cec/seco-cec.c: In function 'secocec_probe': >> drivers/media/platform/seco-cec/seco-cec.c:527:22: error: implicit >> declaration of function 'cec_allocate_adapter'; did you mean >> 'cec_delete_adapter'? [-Werror=implicit-function-declaration] secocec->cec_adap = cec_allocate_adapter(_cec_adap_ops, ^~~~ cec_delete_adapter >> drivers/media/platform/seco-cec/seco-cec.c:527:20: warning: assignment makes >> pointer from integer without a cast [-Wint-conversion] secocec->cec_adap = cec_allocate_adapter(_cec_adap_ops, ^ cc1: some warnings being treated as errors vim +/cec_transmit_attempt_done +237 drivers/media/platform/seco-cec/seco-cec.c 232 233 static void secocec_tx_done(struct cec_adapter *adap, u16 status_val) 234 { 235 if (status_val & SECOCEC_STATUS_TX_ERROR_MASK) { 236 if (status_val & SECOCEC_STATUS_TX_NACK_ERROR) > 237 cec_transmit_attempt_done(adap, > CEC_TX_STATUS_NACK); 238 else 239 cec_transmit_attempt_done(adap, CEC_TX_STATUS_ERROR); 240 } else { 241 cec_transmit_attempt_done(adap, CEC_TX_STATUS_OK); 242 } 243 244 /* Reset status reg */ 245 status_val = SECOCEC_STATUS_TX_ERROR_MASK | 246 SECOCEC_STATUS_MSG_SENT_MASK | 247 SECOCEC_STATUS_TX_NACK_ERROR; 248 smb_wr16(SECOCEC_STATUS, status_val); 249 } 250 251 static void secocec_rx_done(struct cec_adapter *adap, u16 status_val) 252 { 253 struct secocec_data *cec = cec_get_drvdata(adap); 254 struct device *dev = cec->dev; 255 struct cec_msg msg = { }; 256 bool flag_overflow = false; 257 u8 payload_len, i = 0; 258 u8 *payload_msg; 259 u16 val = 0; 260 int status; 261 262 if (status_val & SECOCEC_STATUS_RX_OVERFLOW_MASK) { 263 /* NOTE: Untested, it also might not be necessary */ 264 dev_warn(dev, "Received more than 16 bytes. Discarding"); 265 flag_overflow = true; 266 } 267 268 if (status_val & SECOCEC_STATUS_RX_ERROR_MASK) { 269 dev_warn(dev, "Message received with errors. Discarding"); 270 status = -EIO; 271 goto rxerr; 272 } 273 274 /* Read message length */ 275 status = smb_rd16(SECOCEC_READ_DATA_LENGTH, ); 276 if (status) 277 return; 278 279 /* Device msg len already accounts for the header */ 280 msg.len = min(val + 1, CEC_MAX_MSG_SIZE); 281 282 /* Read logical address */ 283 status = smb_rd16(SECOCEC_READ_BYTE0, ); 284 if (status) 285 return; 286 287 /* device stores source LA and destination */ 288 msg.msg[0] = val; 289 290 /* Read operation ID */ 291 status = smb_rd16(SECOCEC_READ_OPERATION_ID, ); 292 if (status) 293 return; 294 295 msg.msg[1] = val; 296 297 /* Read data if present */ 298 if (msg.len > 1) { 299 payload_len = msg.len - 2; 300 payload_msg = [2]; 301 302 /* device stores 2 bytes in every 16-bit val */ 303 for (i =
Re: [PATCH v8 04/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7
Hi Rui, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-staging-imx7-add-i-MX7-media-driver/20181122-024200 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/staging/media/imx/imx7-mipi-csis.c:1125:3-8: No need to set .owner >> here. The core will do it. Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] media: staging/imx7: fix platform_no_drv_owner.cocci warnings
From: kbuild test robot drivers/staging/media/imx/imx7-mipi-csis.c:1125:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 181331ab8acb ("media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7") CC: Rui Miguel Silva Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-staging-imx7-add-i-MX7-media-driver/20181122-024200 base: git://linuxtv.org/media_tree.git master imx7-mipi-csis.c |1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/media/imx/imx7-mipi-csis.c +++ b/drivers/staging/media/imx/imx7-mipi-csis.c @@ -1122,7 +1122,6 @@ static struct platform_driver mipi_csis_ .driver = { .of_match_table = mipi_csis_of_match, .name = CSIS_DRIVER_NAME, - .owner = THIS_MODULE, .pm = _csis_pm_ops, }, };
Re: [PATCH v8 01/12] media: staging/imx: refactor imx media device probe
Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rui-Miguel-Silva/media-staging-imx7-add-i-MX7-media-driver/20181122-024200 base: git://linuxtv.org/media_tree.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> make[5]: *** No rule to make target >> 'drivers/staging/media/imx/imx-media-dev-common.o', needed by >> 'drivers/staging/media/imx/imx-media.o'. make[5]: Target '__build' not remade because of errors. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS
Hi Hans, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-Verkuil/videodev2-h-add-V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF-CREATE_BUFS/20181120-190153 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x070-201846 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/linux/err.h:5:0, from drivers/media/common/videobuf2/videobuf2-v4l2.c:17: drivers/media/common/videobuf2/videobuf2-v4l2.c: In function 'fill_buf_caps_vdev': drivers/media/common/videobuf2/videobuf2-v4l2.c:878:21: error: dereferencing pointer to incomplete type 'const struct v4l2_ioctl_ops' if (vdev->ioctl_ops->vidioc_prepare_buf) ^ include/linux/compiler.h:58:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^~~~ >> drivers/media/common/videobuf2/videobuf2-v4l2.c:878:2: note: in expansion of >> macro 'if' if (vdev->ioctl_ops->vidioc_prepare_buf) ^~ vim +/if +878 drivers/media/common/videobuf2/videobuf2-v4l2.c 873 874 static void fill_buf_caps_vdev(struct video_device *vdev, u32 *caps) 875 { 876 *caps = 0; 877 fill_buf_caps(vdev->queue, caps); > 878 if (vdev->ioctl_ops->vidioc_prepare_buf) 879 *caps |= V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF; 880 if (vdev->ioctl_ops->vidioc_create_bufs) 881 *caps |= V4L2_BUF_CAP_SUPPORTS_CREATE_BUFS; 882 } 883 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-Verkuil/videodev2-h-add-V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF-CREATE_BUFS/20181120-190153 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x077-201846 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/media/common/videobuf2/videobuf2-v4l2.c: In function 'fill_buf_caps_vdev': >> drivers/media/common/videobuf2/videobuf2-v4l2.c:878:21: error: dereferencing >> pointer to incomplete type 'const struct v4l2_ioctl_ops' if (vdev->ioctl_ops->vidioc_prepare_buf) ^~ vim +878 drivers/media/common/videobuf2/videobuf2-v4l2.c 873 874 static void fill_buf_caps_vdev(struct video_device *vdev, u32 *caps) 875 { 876 *caps = 0; 877 fill_buf_caps(vdev->queue, caps); > 878 if (vdev->ioctl_ops->vidioc_prepare_buf) 879 *caps |= V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF; 880 if (vdev->ioctl_ops->vidioc_create_bufs) 881 *caps |= V4L2_BUF_CAP_SUPPORTS_CREATE_BUFS; 882 } 883 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] Input: Add missing event codes for common IR remote buttons
Hi Derek, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on v4.19 next-20181102] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Derek-Kelly/Input-Add-missing-event-codes-for-common-IR-remote-buttons/20181103-135217 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=powerpc All warnings (new ones prefixed by >>): In file included from sound/ppc/pmac.h:39:0, from sound/ppc/beep.c:30: >> arch/powerpc/include/asm/dbdma.h:70:0: warning: "KEY_SYSTEM" redefined #define KEY_SYSTEM 0x600 /* system memory-mapped space */ In file included from include/uapi/linux/input.h:20:0, from include/linux/input.h:13, from sound/ppc/beep.c:25: include/uapi/linux/input-event-codes.h:698:0: note: this is the location of the previous definition #define KEY_SYSTEM 0x2ed /* Open systems menu/display */ vim +/KEY_SYSTEM +70 arch/powerpc/include/asm/dbdma.h ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 63 ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 64 /* Key values in command field */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 65 #define KEY_STREAM0 0 /* usual data stream */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 66 #define KEY_STREAM1 0x100 /* control/status stream */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 67 #define KEY_STREAM2 0x200 /* device-dependent stream */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 68 #define KEY_STREAM3 0x300 /* device-dependent stream */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 69 #define KEY_REGS0x500 /* device register space */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 @70 #define KEY_SYSTEM 0x600 /* system memory-mapped space */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 71 #define KEY_DEVICE 0x700 /* device memory-mapped space */ ^1da177e include/asm-ppc/dbdma.h Linus Torvalds 2005-04-16 72 :: The code at line 70 was first introduced by commit :: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :: TO: Linus Torvalds :: CC: Linus Torvalds --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 4/4] media: mt9m111: allow to setup pixclk polarity
Hi Enrico, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Marco-Felsch/media-mt9m111-features/20181020-022716 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-x000-201841 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/media//i2c/mt9m111.c: In function 'mt9m111_probe': >> drivers/media//i2c/mt9m111.c:1185:9: error: implicit declaration of function >> 'mt9m111_probe_of'; did you mean 'mt9m111_probe'? >> [-Werror=implicit-function-declaration] ret = mt9m111_probe_of(client, mt9m111); ^~~~ mt9m111_probe cc1: some warnings being treated as errors vim +1185 drivers/media//i2c/mt9m111.c 1159 1160 static int mt9m111_probe(struct i2c_client *client, 1161 const struct i2c_device_id *did) 1162 { 1163 struct mt9m111 *mt9m111; 1164 struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); 1165 int ret; 1166 1167 if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) { 1168 dev_warn(>dev, 1169 "I2C-Adapter doesn't support I2C_FUNC_SMBUS_WORD\n"); 1170 return -EIO; 1171 } 1172 1173 mt9m111 = devm_kzalloc(>dev, sizeof(struct mt9m111), GFP_KERNEL); 1174 if (!mt9m111) 1175 return -ENOMEM; 1176 1177 mt9m111->clk = v4l2_clk_get(>dev, "mclk"); 1178 if (IS_ERR(mt9m111->clk)) 1179 return PTR_ERR(mt9m111->clk); 1180 1181 /* Default HIGHPOWER context */ 1182 mt9m111->ctx = _b; 1183 1184 if (IS_ENABLED(CONFIG_OF)) { > 1185 ret = mt9m111_probe_of(client, mt9m111); 1186 if (ret) 1187 return ret; 1188 } else { 1189 /* use default chip hardware values */ 1190 mt9m111->pclk_sample = 1; 1191 } 1192 1193 v4l2_i2c_subdev_init(>subdev, client, _subdev_ops); 1194 mt9m111->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; 1195 1196 v4l2_ctrl_handler_init(>hdl, 5); 1197 v4l2_ctrl_new_std(>hdl, _ctrl_ops, 1198 V4L2_CID_VFLIP, 0, 1, 1, 0); 1199 v4l2_ctrl_new_std(>hdl, _ctrl_ops, 1200 V4L2_CID_HFLIP, 0, 1, 1, 0); 1201 v4l2_ctrl_new_std(>hdl, _ctrl_ops, 1202 V4L2_CID_AUTO_WHITE_BALANCE, 0, 1, 1, 1); 1203 mt9m111->gain = v4l2_ctrl_new_std(>hdl, _ctrl_ops, 1204 V4L2_CID_GAIN, 0, 63 * 2 * 2, 1, 32); 1205 v4l2_ctrl_new_std_menu(>hdl, 1206 _ctrl_ops, V4L2_CID_EXPOSURE_AUTO, 1, 0, 1207 V4L2_EXPOSURE_AUTO); 1208 v4l2_ctrl_new_std_menu_items(>hdl, 1209 _ctrl_ops, V4L2_CID_TEST_PATTERN, 1210 ARRAY_SIZE(mt9m111_test_pattern_menu) - 1, 0, 0, 1211 mt9m111_test_pattern_menu); 1212 mt9m111->subdev.ctrl_handler = >hdl; 1213 if (mt9m111->hdl.error) { 1214 ret = mt9m111->hdl.error; 1215 goto out_clkput; 1216 } 1217 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[ragnatech:media-tree] BUILD SUCCESS 490d84f6d73c12f4204241cff8651eed60aae914
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 490d84f6d73c12f4204241cff8651eed60aae914 media: cec: forgot to cancel delayed work elapsed time: 1093m configs tested: 210 The following configs have been built successfully. More configs may be tested in the coming days. alpha defconfig pariscallnoconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig m68k apollo_defconfig mips lemote2f_defconfig x86_64 randconfig-a0-10161216 x86_64 acpi-redef x86_64 allyesdebian x86_64nfsroot shtitan_defconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shallnoconfig i386 randconfig-c0-10161145 arm s3c6400_defconfig mips loongson1c_defconfig i386 randconfig-x019-201841 i386 randconfig-x016-201841 i386 randconfig-x018-201841 i386 randconfig-x014-201841 i386 randconfig-x015-201841 i386 randconfig-x011-201841 i386 randconfig-x012-201841 i386 randconfig-x017-201841 i386 randconfig-x010-201841 i386 randconfig-x013-201841 microblaze mmu_defconfig microblazenommu_defconfig i386 randconfig-n0-201841 i386 randconfig-n1-201841 i386 randconfig-n2-201841 i386 randconfig-n3-201841 x86_64 randconfig-x000-201841 x86_64 randconfig-x005-201841 x86_64 randconfig-x002-201841 x86_64 randconfig-x001-201841 x86_64 randconfig-x008-201841 x86_64 randconfig-x007-201841 x86_64 randconfig-x009-201841 x86_64 randconfig-x003-201841 x86_64 randconfig-x006-201841 x86_64 randconfig-x004-201841 ia64 allnoconfig ia64defconfig ia64 alldefconfig powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig s390default_defconfig i386 randconfig-i0-201841 i386 randconfig-i1-201841 i386 randconfig-i2-201841 i386 randconfig-i3-201841 arm allnoconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 allnoconfig arm64 defconfig mipsnlm_xlr_defconfig sh se7343_defconfig x86_64 randconfig-g0-10161105 openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig nios2 10m50_defconfig xtensa common_defconfig xtensa iss_defconfig i386 allmodconfig i386 randconfig-x002-201841 i386 randconfig-x006-201841 i386 randconfig-x005-201841 i386 randconfig-x000-201841 i386 randconfig-x007-201841 i386 randconfig-x004-201841 i386 randconfig-x001-201841 i386 randconfig-x009-201841 i386 randconfig-x008-201841 i386 randconfig-x003-201841 arm allmodconfig arm arm5 arm arm67 arm imx_v6_v7_defconfig arm ixp4xx_defconfig armmvebu_v7_defconfig arm omap2plus_defconfig armsa1100 arm samsung armsh arm tegra_defconfig arm64alldefconfig arm64allmodconfig x86_64 randconfig-s0-10161132 x86_64 randconfig-s1-10161132 x86_64
[linuxtv-media:request_api 77/78] cedrus_hw.c:undefined reference to `sunxi_sram_release'
tree: git://linuxtv.org/media_tree.git request_api head: e4183d3256e3cd668e899d06af66da5aac3a51af commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 [77/78] media: platform: Add Cedrus VPU decoder driver config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 # save the attached .config to linux build tree make ARCH=i386 Note: the linuxtv-media/request_api HEAD e4183d3256e3cd668e899d06af66da5aac3a51af builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/staging/media/sunxi/cedrus/cedrus_hw.o: In function `cedrus_hw_remove': >> cedrus_hw.c:(.text+0x39a): undefined reference to `sunxi_sram_release' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[linuxtv-media:request_api 77/77] drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: potential null dereference 'ctx->ctrls'. (kzalloc returns null)
tree: git://linuxtv.org/media_tree.git request_api head: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 [77/77] media: platform: Add Cedrus VPU decoder driver smatch warnings: drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: potential null dereference 'ctx->ctrls'. (kzalloc returns null) vim +93 drivers/staging/media/sunxi/cedrus/cedrus.c 57 58 static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx) 59 { 60 struct v4l2_ctrl_handler *hdl = >hdl; 61 struct v4l2_ctrl *ctrl; 62 unsigned int ctrl_size; 63 unsigned int i; 64 65 v4l2_ctrl_handler_init(hdl, CEDRUS_CONTROLS_COUNT); 66 if (hdl->error) { 67 v4l2_err(>v4l2_dev, 68 "Failed to initialize control handler\n"); 69 return hdl->error; 70 } 71 72 ctrl_size = sizeof(ctrl) * CEDRUS_CONTROLS_COUNT + 1; 73 74 ctx->ctrls = kzalloc(ctrl_size, GFP_KERNEL); 75 memset(ctx->ctrls, 0, ctrl_size); 76 77 for (i = 0; i < CEDRUS_CONTROLS_COUNT; i++) { 78 struct v4l2_ctrl_config cfg = { 0 }; 79 80 cfg.elem_size = cedrus_controls[i].elem_size; 81 cfg.id = cedrus_controls[i].id; 82 83 ctrl = v4l2_ctrl_new_custom(hdl, , NULL); 84 if (hdl->error) { 85 v4l2_err(>v4l2_dev, 86 "Failed to create new custom control\n"); 87 88 v4l2_ctrl_handler_free(hdl); 89 kfree(ctx->ctrls); 90 return hdl->error; 91 } 92 > 93 ctx->ctrls[i] = ctrl; 94 } 95 96 ctx->fh.ctrl_handler = hdl; 97 v4l2_ctrl_handler_setup(hdl); 98 99 return 0; 100 } 101 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 4/5] v4l: controls: QUERY_EXT_CTRL support for base, prefix and unit
Hi Sakari, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.19-rc5 next-20180926] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/Add-units-to-controls/20180925-183703 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' include/linux/mod_devicetable.h:763: warning: Function parameter or member 'driver_data' not described in 'typec_device_id' kernel/sched/fair.c:3371: warning: Function parameter or member 'flags' not described in 'attach_entity_load_avg' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'i' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'v' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:96: warning: Excess function parameter 'v' description in 'arch_atomic_inc' arch/x86/include/asm/atomic.h:109: warning: Excess function parameter 'v' description in 'arch_atomic_dec' arch/x86/include/asm/atomic.h:124: warning: Excess function parameter 'v' description in 'arch_atomic_dec_and_test' arch/x86/include/asm/atomic.h:138: warning: Excess function parameter 'v' description in 'arch_atomic_inc_and_test' arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'i' description in 'arch_atomic_add_negative' arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'v'
[linuxtv-media:request_api 77/77] ERROR: "sunxi_sram_release" [drivers/staging/media/sunxi/cedrus/sunxi-cedrus.ko] undefined!
tree: git://linuxtv.org/media_tree.git request_api head: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 [77/77] media: platform: Add Cedrus VPU decoder driver config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "sunxi_sram_release" >> [drivers/staging/media/sunxi/cedrus/sunxi-cedrus.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[ragnatech:media-tree] BUILD SUCCESS 4158757395b300b6eb308fc20b96d1d231484413
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 4158757395b300b6eb308fc20b96d1d231484413 media: davinci: Fix implicit enum conversion warning elapsed time: 228m configs tested: 87 The following configs have been built successfully. More configs may be tested in the coming days. x86_64 acpi-redef x86_64 allyesdebian x86_64nfsroot i386 randconfig-x010-201838 i386 randconfig-x011-201838 i386 randconfig-x012-201838 i386 randconfig-x013-201838 i386 randconfig-x014-201838 i386 randconfig-x015-201838 i386 randconfig-x016-201838 i386 randconfig-x017-201838 i386 randconfig-x018-201838 i386 randconfig-x019-201838 microblaze mmu_defconfig microblazenommu_defconfig x86_64 randconfig-x000-201838 x86_64 randconfig-x001-201838 x86_64 randconfig-x002-201838 x86_64 randconfig-x003-201838 x86_64 randconfig-x004-201838 x86_64 randconfig-x005-201838 x86_64 randconfig-x006-201838 x86_64 randconfig-x007-201838 x86_64 randconfig-x008-201838 x86_64 randconfig-x009-201838 i386 allmodconfig i386 randconfig-x000-201838 i386 randconfig-x001-201838 i386 randconfig-x002-201838 i386 randconfig-x003-201838 i386 randconfig-x004-201838 i386 randconfig-x005-201838 i386 randconfig-x006-201838 i386 randconfig-x007-201838 i386 randconfig-x008-201838 i386 randconfig-x009-201838 x86_64 randconfig-x010-201838 x86_64 randconfig-x011-201838 x86_64 randconfig-x012-201838 x86_64 randconfig-x013-201838 x86_64 randconfig-x014-201838 x86_64 randconfig-x015-201838 x86_64 randconfig-x016-201838 x86_64 randconfig-x017-201838 x86_64 randconfig-x018-201838 x86_64 randconfig-x019-201838 ia64 alldefconfig ia64 allnoconfig ia64defconfig shallnoconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shtitan_defconfig openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig nios2 10m50_defconfig xtensa common_defconfig xtensa iss_defconfig arm nuc960_defconfig powerpc eiger_defconfig powerpc sbc8548_defconfig sh sh7724_generic_defconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig i386 randconfig-s0-201838 i386 randconfig-s1-201838 i386 randconfig-s2-201838 i386 randconfig-s3-201838 x86_64 randconfig-s3-09251250 x86_64 randconfig-s4-09251250 x86_64 randconfig-s5-09251250 sparc defconfig sparc64 allnoconfig sparc64 defconfig powerpc ebony_defconfig x86_64 randconfig-h0-09251147 mips 32r2_defconfig mips 64r6el_defconfig mips allnoconfig mips fuloong2e_defconfig mips jz4740 mips malta_kvm_defconfig mips txx9 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH v6] media: add imx319 camera sensor driver
Hi Bingbu, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180922-115504 base: git://linuxtv.org/media_tree.git master config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): drivers/media//i2c/imx319.c: In function 'imx319_set_stream': >> drivers/media//i2c/imx319.c:2153:2: error: implicit declaration of function >> '__v4l2_ctrl_grab' [-Werror=implicit-function-declaration] __v4l2_ctrl_grab(imx319->vflip, enable); ^~~~ cc1: some warnings being treated as errors vim +/__v4l2_ctrl_grab +2153 drivers/media//i2c/imx319.c 2118 2119 static int imx319_set_stream(struct v4l2_subdev *sd, int enable) 2120 { 2121 struct imx319 *imx319 = to_imx319(sd); 2122 struct i2c_client *client = v4l2_get_subdevdata(sd); 2123 int ret = 0; 2124 2125 mutex_lock(>mutex); 2126 if (imx319->streaming == enable) { 2127 mutex_unlock(>mutex); 2128 return 0; 2129 } 2130 2131 if (enable) { 2132 ret = pm_runtime_get_sync(>dev); 2133 if (ret < 0) { 2134 pm_runtime_put_noidle(>dev); 2135 goto err_unlock; 2136 } 2137 2138 /* 2139 * Apply default & customized values 2140 * and then start streaming. 2141 */ 2142 ret = imx319_start_streaming(imx319); 2143 if (ret) 2144 goto err_rpm_put; 2145 } else { 2146 imx319_stop_streaming(imx319); 2147 pm_runtime_put(>dev); 2148 } 2149 2150 imx319->streaming = enable; 2151 2152 /* vflip and hflip cannot change during streaming */ > 2153 __v4l2_ctrl_grab(imx319->vflip, enable); 2154 __v4l2_ctrl_grab(imx319->hflip, enable); 2155 2156 mutex_unlock(>mutex); 2157 2158 return ret; 2159 2160 err_rpm_put: 2161 pm_runtime_put(>dev); 2162 err_unlock: 2163 mutex_unlock(>mutex); 2164 2165 return ret; 2166 } 2167 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[experimental:tvp5150-5 135/138] drivers/media/i2c/tvp5150.c:1018:10: error: implicit declaration of function 'v4l2_subdev_get_try_crop'; did you mean 'v4l2_subdev_has_op'?
tree: git://linuxtv.org/mchehab/experimental tvp5150-5 head: c223c451df23ac71a844d05aab65ede057b70eb0 commit: bc93ce496fa909d8fa9496c93d36e9ea413a9065 [135/138] tvp5150: add FORMAT_TRY support for get/set selection handlers config: x86_64-randconfig-s5-09181631 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout bc93ce496fa909d8fa9496c93d36e9ea413a9065 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/media/i2c/tvp5150.c:72:32: error: 'TVP5150_NUM_PADS' undeclared here (not in a function); did you mean 'TVP5150_H_MAX'? struct device_node *endpoints[TVP5150_NUM_PADS + 1]; ^~~~ TVP5150_H_MAX drivers/media/i2c/tvp5150.c: In function '__tvp5150_get_pad_crop': >> drivers/media/i2c/tvp5150.c:1018:10: error: implicit declaration of function >> 'v4l2_subdev_get_try_crop'; did you mean 'v4l2_subdev_has_op'? >> [-Werror=implicit-function-declaration] return v4l2_subdev_get_try_crop(>sd, cfg, pad); ^~~~ v4l2_subdev_has_op drivers/media/i2c/tvp5150.c:1018:10: warning: return makes pointer from integer without a cast [-Wint-conversion] return v4l2_subdev_get_try_crop(>sd, cfg, pad); ^~~~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_fill_fmt': drivers/media/i2c/tvp5150.c:1034:33: error: 'TVP5150_PAD_VID_OUT' undeclared (first use in this function); did you mean 'TVP5150_SVIDEO'? if (!format || (format->pad != TVP5150_PAD_VID_OUT)) ^~~ TVP5150_SVIDEO drivers/media/i2c/tvp5150.c:1034:33: note: each undeclared identifier is reported only once for each function it appears in drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init': drivers/media/i2c/tvp5150.c:1881:9: error: 'ret' undeclared (first use in this function); did you mean 'net'? return ret; ^~~ net drivers/media/i2c/tvp5150.c:1880:1: warning: label 'out' defined but not used [-Wunused-label] out: ^~~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_of_valid_input': drivers/media/i2c/tvp5150.c:1893:7: error: 'TVP5150_PAD_AIP1A' undeclared (first use in this function); did you mean 'TVP5150_VDPOE'? case TVP5150_PAD_AIP1A: ^ TVP5150_VDPOE drivers/media/i2c/tvp5150.c:1901:7: error: 'TVP5150_PAD_AIP1B' undeclared (first use in this function); did you mean 'TVP5150_PAD_AIP1A'? case TVP5150_PAD_AIP1B: ^ TVP5150_PAD_AIP1A drivers/media/i2c/tvp5150.c: In function 'tvp5150_parse_dt': drivers/media/i2c/tvp5150.c:1945:8: error: 'TVP5150_PAD_AIP1A' undeclared (first use in this function); did you mean 'TVP5150_VDPOE'? case TVP5150_PAD_AIP1A: ^ TVP5150_VDPOE drivers/media/i2c/tvp5150.c:1946:8: error: 'TVP5150_PAD_AIP1B' undeclared (first use in this function); did you mean 'TVP5150_PAD_AIP1A'? case TVP5150_PAD_AIP1B: ^ TVP5150_PAD_AIP1A drivers/media/i2c/tvp5150.c:1956:8: error: 'TVP5150_PAD_VID_OUT' undeclared (first use in this function); did you mean 'TVP5150_PAD_AIP1B'? case TVP5150_PAD_VID_OUT: ^~~ TVP5150_PAD_AIP1B drivers/media/i2c/tvp5150.c:1988:9: error: 'struct tvp5150' has no member named 'connectors_num' decoder->connectors_num = in; ^~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init': drivers/media/i2c/tvp5150.c:1882:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ cc1: some warnings being treated as errors vim +1018 drivers/media/i2c/tvp5150.c 1010 1011 static struct v4l2_rect * 1012 __tvp5150_get_pad_crop(struct tvp5150 *decoder, 1013 struct v4l2_subdev_pad_config *cfg, unsigned int pad, 1014 enum v4l2_subdev_format_whence which) 1015 { 1016 switch (which) { 1017 case V4L2_SUBDEV_FORMAT_TRY: > 1018 return v4l2_subdev_get_try_crop(>sd, cfg, pad); 1019 case V4L2_SUBDEV_FORMAT_ACTIVE: 1020 return >rect; 1021 default: 1022 return NULL; 1023 } 1024 } 1025 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[experimental:tvp5150-5 131/138] drivers/media//i2c/tvp5150.c:71:32: error: 'TVP5150_NUM_PADS' undeclared here (not in a function); did you mean 'TVP5150_H_MAX'?
tree: git://linuxtv.org/mchehab/experimental tvp5150-5 head: c223c451df23ac71a844d05aab65ede057b70eb0 commit: 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b [131/138] tvp5150: add input source selection of_graph support config: x86_64-randconfig-s5-09181631 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers/media//i2c/tvp5150.c:71:32: error: 'TVP5150_NUM_PADS' undeclared >> here (not in a function); did you mean 'TVP5150_H_MAX'? struct device_node *endpoints[TVP5150_NUM_PADS + 1]; ^~~~ TVP5150_H_MAX drivers/media//i2c/tvp5150.c: In function 'tvp5150_fill_fmt': >> drivers/media//i2c/tvp5150.c:1017:33: error: 'TVP5150_PAD_VID_OUT' >> undeclared (first use in this function); did you mean 'TVP5150_SVIDEO'? if (!format || (format->pad != TVP5150_PAD_VID_OUT)) ^~~ TVP5150_SVIDEO drivers/media//i2c/tvp5150.c:1017:33: note: each undeclared identifier is reported only once for each function it appears in drivers/media//i2c/tvp5150.c: In function 'tvp5150_mc_init': >> drivers/media//i2c/tvp5150.c:1840:9: error: 'ret' undeclared (first use in >> this function); did you mean 'net'? return ret; ^~~ net drivers/media//i2c/tvp5150.c:1839:1: warning: label 'out' defined but not used [-Wunused-label] out: ^~~ drivers/media//i2c/tvp5150.c: In function 'tvp5150_of_valid_input': >> drivers/media//i2c/tvp5150.c:1852:7: error: 'TVP5150_PAD_AIP1A' undeclared >> (first use in this function); did you mean 'TVP5150_VDPOE'? case TVP5150_PAD_AIP1A: ^ TVP5150_VDPOE >> drivers/media//i2c/tvp5150.c:1860:7: error: 'TVP5150_PAD_AIP1B' undeclared >> (first use in this function); did you mean 'TVP5150_PAD_AIP1A'? case TVP5150_PAD_AIP1B: ^ TVP5150_PAD_AIP1A drivers/media//i2c/tvp5150.c: In function 'tvp5150_parse_dt': drivers/media//i2c/tvp5150.c:1904:8: error: 'TVP5150_PAD_AIP1A' undeclared (first use in this function); did you mean 'TVP5150_VDPOE'? case TVP5150_PAD_AIP1A: ^ TVP5150_VDPOE drivers/media//i2c/tvp5150.c:1905:8: error: 'TVP5150_PAD_AIP1B' undeclared (first use in this function); did you mean 'TVP5150_PAD_AIP1A'? case TVP5150_PAD_AIP1B: ^ TVP5150_PAD_AIP1A >> drivers/media//i2c/tvp5150.c:1915:8: error: 'TVP5150_PAD_VID_OUT' undeclared >> (first use in this function); did you mean 'TVP5150_PAD_AIP1B'? case TVP5150_PAD_VID_OUT: ^~~ TVP5150_PAD_AIP1B drivers/media//i2c/tvp5150.c:1947:9: error: 'struct tvp5150' has no member named 'connectors_num' decoder->connectors_num = in; ^~ drivers/media//i2c/tvp5150.c: In function 'tvp5150_mc_init': drivers/media//i2c/tvp5150.c:1841:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ vim +71 drivers/media//i2c/tvp5150.c 67 68 struct tvp5150 { 69 struct v4l2_subdev sd; 70 /* additional additional endpoint for the svideo connector */ > 71 struct device_node *endpoints[TVP5150_NUM_PADS + 1]; 72 unsigned int endpoints_num; 73 #if defined(CONFIG_MEDIA_CONTROLLER) 74 struct media_pad pads[TVP5150_NUM_PADS]; 75 int pads_state[TVP5150_NUM_PADS]; 76 struct tvp5150_connector *connectors; 77 int connectors_num; 78 bool modify_second_link; 79 #endif 80 struct v4l2_ctrl_handler hdl; 81 struct v4l2_rect rect; 82 struct regmap *regmap; 83 int irq; 84 85 v4l2_std_id norm; /* Current set standard */ 86 v4l2_std_id detected_norm; 87 u32 input; 88 u32 output; 89 u32 oe; 90 int enable; 91 bool lock; 92 93 u16 dev_id; 94 u16 rom_ver; 95 96 enum v4l2_mbus_type mbus_type; 97 }; 98 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[experimental:tvp5150-5 135/138] drivers/media/i2c/tvp5150.c:1018:10: error: implicit declaration of function 'v4l2_subdev_get_try_crop'
tree: git://linuxtv.org/mchehab/experimental tvp5150-5 head: c223c451df23ac71a844d05aab65ede057b70eb0 commit: bc93ce496fa909d8fa9496c93d36e9ea413a9065 [135/138] tvp5150: add FORMAT_TRY support for get/set selection handlers config: i386-randconfig-s0-09171149 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: git checkout bc93ce496fa909d8fa9496c93d36e9ea413a9065 # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): drivers/media/i2c/tvp5150.c:72:32: error: 'TVP5150_NUM_PADS' undeclared here (not in a function) struct device_node *endpoints[TVP5150_NUM_PADS + 1]; ^~~~ drivers/media/i2c/tvp5150.c: In function '__tvp5150_get_pad_crop': >> drivers/media/i2c/tvp5150.c:1018:10: error: implicit declaration of function >> 'v4l2_subdev_get_try_crop' [-Werror=implicit-function-declaration] return v4l2_subdev_get_try_crop(>sd, cfg, pad); ^~~~ >> drivers/media/i2c/tvp5150.c:1018:10: warning: return makes pointer from >> integer without a cast [-Wint-conversion] return v4l2_subdev_get_try_crop(>sd, cfg, pad); ^~~~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_fill_fmt': drivers/media/i2c/tvp5150.c:1034:33: error: 'TVP5150_PAD_VID_OUT' undeclared (first use in this function) if (!format || (format->pad != TVP5150_PAD_VID_OUT)) ^~~ drivers/media/i2c/tvp5150.c:1034:33: note: each undeclared identifier is reported only once for each function it appears in drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init': drivers/media/i2c/tvp5150.c:1881:9: error: 'ret' undeclared (first use in this function) return ret; ^~~ drivers/media/i2c/tvp5150.c:1880:1: warning: label 'out' defined but not used [-Wunused-label] out: ^~~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_of_valid_input': drivers/media/i2c/tvp5150.c:1893:7: error: 'TVP5150_PAD_AIP1A' undeclared (first use in this function) case TVP5150_PAD_AIP1A: ^ drivers/media/i2c/tvp5150.c:1901:7: error: 'TVP5150_PAD_AIP1B' undeclared (first use in this function) case TVP5150_PAD_AIP1B: ^ drivers/media/i2c/tvp5150.c: In function 'tvp5150_parse_dt': drivers/media/i2c/tvp5150.c:1945:8: error: 'TVP5150_PAD_AIP1A' undeclared (first use in this function) case TVP5150_PAD_AIP1A: ^ drivers/media/i2c/tvp5150.c:1946:8: error: 'TVP5150_PAD_AIP1B' undeclared (first use in this function) case TVP5150_PAD_AIP1B: ^ drivers/media/i2c/tvp5150.c:1956:8: error: 'TVP5150_PAD_VID_OUT' undeclared (first use in this function) case TVP5150_PAD_VID_OUT: ^~~ drivers/media/i2c/tvp5150.c:1988:9: error: 'struct tvp5150' has no member named 'connectors_num' decoder->connectors_num = in; ^~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init': drivers/media/i2c/tvp5150.c:1882:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ cc1: some warnings being treated as errors vim +/v4l2_subdev_get_try_crop +1018 drivers/media/i2c/tvp5150.c 1010 1011 static struct v4l2_rect * 1012 __tvp5150_get_pad_crop(struct tvp5150 *decoder, 1013 struct v4l2_subdev_pad_config *cfg, unsigned int pad, 1014 enum v4l2_subdev_format_whence which) 1015 { 1016 switch (which) { 1017 case V4L2_SUBDEV_FORMAT_TRY: > 1018 return v4l2_subdev_get_try_crop(>sd, cfg, pad); 1019 case V4L2_SUBDEV_FORMAT_ACTIVE: 1020 return >rect; 1021 default: 1022 return NULL; 1023 } 1024 } 1025 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[experimental:tvp5150-5 131/138] drivers/media/i2c/tvp5150.c:71:32: error: 'TVP5150_NUM_PADS' undeclared here (not in a function)
tree: git://linuxtv.org/mchehab/experimental tvp5150-5 head: c223c451df23ac71a844d05aab65ede057b70eb0 commit: 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b [131/138] tvp5150: add input source selection of_graph support config: i386-randconfig-s0-09171149 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: git checkout 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): >> drivers/media/i2c/tvp5150.c:71:32: error: 'TVP5150_NUM_PADS' undeclared here >> (not in a function) struct device_node *endpoints[TVP5150_NUM_PADS + 1]; ^~~~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_fill_fmt': >> drivers/media/i2c/tvp5150.c:1017:33: error: 'TVP5150_PAD_VID_OUT' undeclared >> (first use in this function) if (!format || (format->pad != TVP5150_PAD_VID_OUT)) ^~~ drivers/media/i2c/tvp5150.c:1017:33: note: each undeclared identifier is reported only once for each function it appears in drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init': >> drivers/media/i2c/tvp5150.c:1840:9: error: 'ret' undeclared (first use in >> this function) return ret; ^~~ drivers/media/i2c/tvp5150.c:1839:1: warning: label 'out' defined but not used [-Wunused-label] out: ^~~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_of_valid_input': >> drivers/media/i2c/tvp5150.c:1852:7: error: 'TVP5150_PAD_AIP1A' undeclared >> (first use in this function) case TVP5150_PAD_AIP1A: ^ >> drivers/media/i2c/tvp5150.c:1860:7: error: 'TVP5150_PAD_AIP1B' undeclared >> (first use in this function) case TVP5150_PAD_AIP1B: ^ drivers/media/i2c/tvp5150.c: In function 'tvp5150_parse_dt': drivers/media/i2c/tvp5150.c:1904:8: error: 'TVP5150_PAD_AIP1A' undeclared (first use in this function) case TVP5150_PAD_AIP1A: ^ drivers/media/i2c/tvp5150.c:1905:8: error: 'TVP5150_PAD_AIP1B' undeclared (first use in this function) case TVP5150_PAD_AIP1B: ^ drivers/media/i2c/tvp5150.c:1915:8: error: 'TVP5150_PAD_VID_OUT' undeclared (first use in this function) case TVP5150_PAD_VID_OUT: ^~~ >> drivers/media/i2c/tvp5150.c:1947:9: error: 'struct tvp5150' has no member >> named 'connectors_num' decoder->connectors_num = in; ^~ drivers/media/i2c/tvp5150.c: In function 'tvp5150_mc_init': >> drivers/media/i2c/tvp5150.c:1841:1: warning: control reaches end of non-void >> function [-Wreturn-type] } ^ vim +/TVP5150_NUM_PADS +71 drivers/media/i2c/tvp5150.c 67 68 struct tvp5150 { 69 struct v4l2_subdev sd; 70 /* additional additional endpoint for the svideo connector */ > 71 struct device_node *endpoints[TVP5150_NUM_PADS + 1]; 72 unsigned int endpoints_num; 73 #if defined(CONFIG_MEDIA_CONTROLLER) 74 struct media_pad pads[TVP5150_NUM_PADS]; 75 int pads_state[TVP5150_NUM_PADS]; 76 struct tvp5150_connector *connectors; 77 int connectors_num; 78 bool modify_second_link; 79 #endif 80 struct v4l2_ctrl_handler hdl; 81 struct v4l2_rect rect; 82 struct regmap *regmap; 83 int irq; 84 85 v4l2_std_id norm; /* Current set standard */ 86 v4l2_std_id detected_norm; 87 u32 input; 88 u32 output; 89 u32 oe; 90 int enable; 91 bool lock; 92 93 u16 dev_id; 94 u16 rom_ver; 95 96 enum v4l2_mbus_type mbus_type; 97 }; 98 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 1/1] v4l: samsung, ov9650: Rely on V4L2-set sub-device names
Hi Sakari, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20180913] [cannot apply to v4.19-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-samsung-ov9650-Rely-on-V4L2-set-sub-device-names/20180916-232558 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x0-09171846 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function 's5c73m3_probe': >> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1686:2: error: implicit declaration >> of function 'v4l2_i2c_subdev_set_name' >> [-Werror=implicit-function-declaration] v4l2_i2c_subdev_set_name(sd, client, NULL, NULL); ^ cc1: some warnings being treated as errors vim +/v4l2_i2c_subdev_set_name +1686 drivers/media/i2c/s5c73m3/s5c73m3-core.c 1660 1661 static int s5c73m3_probe(struct i2c_client *client, 1662 const struct i2c_device_id *id) 1663 { 1664 struct device *dev = >dev; 1665 struct v4l2_subdev *sd; 1666 struct v4l2_subdev *oif_sd; 1667 struct s5c73m3 *state; 1668 int ret, i; 1669 1670 state = devm_kzalloc(dev, sizeof(*state), GFP_KERNEL); 1671 if (!state) 1672 return -ENOMEM; 1673 1674 state->i2c_client = client; 1675 ret = s5c73m3_get_platform_data(state); 1676 if (ret < 0) 1677 return ret; 1678 1679 mutex_init(>lock); 1680 sd = >sensor_sd; 1681 oif_sd = >oif_sd; 1682 1683 v4l2_subdev_init(sd, _subdev_ops); 1684 sd->owner = client->dev.driver->owner; 1685 v4l2_set_subdevdata(sd, state); > 1686 v4l2_i2c_subdev_set_name(sd, client, NULL, NULL); 1687 1688 sd->internal_ops = _internal_ops; 1689 sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; 1690 1691 state->sensor_pads[S5C73M3_JPEG_PAD].flags = MEDIA_PAD_FL_SOURCE; 1692 state->sensor_pads[S5C73M3_ISP_PAD].flags = MEDIA_PAD_FL_SOURCE; 1693 sd->entity.function = MEDIA_ENT_F_CAM_SENSOR; 1694 1695 ret = media_entity_pads_init(>entity, S5C73M3_NUM_PADS, 1696 state->sensor_pads); 1697 if (ret < 0) 1698 return ret; 1699 1700 v4l2_i2c_subdev_init(oif_sd, client, _subdev_ops); 1701 v4l2_i2c_subdev_set_name(sd, client, NULL, "-oif"); 1702 1703 oif_sd->internal_ops = _internal_ops; 1704 oif_sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; 1705 1706 state->oif_pads[OIF_ISP_PAD].flags = MEDIA_PAD_FL_SINK; 1707 state->oif_pads[OIF_JPEG_PAD].flags = MEDIA_PAD_FL_SINK; 1708 state->oif_pads[OIF_SOURCE_PAD].flags = MEDIA_PAD_FL_SOURCE; 1709 oif_sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_SCALER; 1710 1711 ret = media_entity_pads_init(_sd->entity, OIF_NUM_PADS, 1712 state->oif_pads); 1713 if (ret < 0) 1714 return ret; 1715 1716 ret = s5c73m3_configure_gpios(state); 1717 if (ret) 1718 goto out_err; 1719 1720 for (i = 0; i < S5C73M3_MAX_SUPPLIES; i++) 1721 state->supplies[i].supply = s5c73m3_supply_names[i]; 1722 1723 ret = devm_regulator_bulk_get(dev, S5C73M3_MAX_SUPPLIES, 1724 state->supplies); 1725 if (ret) { 1726 dev_err(dev, "failed to get regulators\n"); 1727 goto out_err; 1728 } 1729 1730 ret = s5c73m3_init_controls(state); 1731 if (ret) 1732 goto out_err; 1733 1734 state->sensor_pix_size[RES_ISP] = _isp_resolutions[1]; 1735 state->sensor_pix_size[RES_JPEG] = _jpeg_resolutions[1]; 1736 state->oif_pix_size[RES_ISP] = state->sensor_pix_size[RES_ISP]; 1737 state->oif_pix_size[RES_JPEG] = state->sensor_pix_size[RES_JPEG]; 1738 1739 state->mbus_code = S5C73M3_ISP_FMT; 1740 1741 state->fiv = _intervals[S5C73M3_DEFAULT_FRAME_INTERVAL]; 1742 1743 state->fw_file_version[0] = 'G'; 1744 state->fw_file_version[1] = 'C'; 1745 1746 ret = s5c73m3_register_spi_driver(state); 1747 if (ret < 0) 1748 goto out_err; 1749 1750 oif_sd->dev = dev; 1751 1752 ret =
Re: [PATCH v5] media: add imx319 camera sensor driver
Hi Bingbu, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc4 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180917-135744 base: git://linuxtv.org/media_tree.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/media/i2c/imx319.c: In function 'imx319_set_stream': >> drivers/media/i2c/imx319.c:2146:2: error: implicit declaration of function >> '__v4l2_ctrl_grab'; did you mean 'v4l2_ctrl_grab'? >> [-Werror=implicit-function-declaration] __v4l2_ctrl_grab(imx319->vflip, enable); ^~~~ v4l2_ctrl_grab cc1: some warnings being treated as errors vim +2146 drivers/media/i2c/imx319.c 2111 2112 static int imx319_set_stream(struct v4l2_subdev *sd, int enable) 2113 { 2114 struct imx319 *imx319 = to_imx319(sd); 2115 struct i2c_client *client = v4l2_get_subdevdata(sd); 2116 int ret = 0; 2117 2118 mutex_lock(>mutex); 2119 if (imx319->streaming == enable) { 2120 mutex_unlock(>mutex); 2121 return 0; 2122 } 2123 2124 if (enable) { 2125 ret = pm_runtime_get_sync(>dev); 2126 if (ret < 0) { 2127 pm_runtime_put_noidle(>dev); 2128 goto err_unlock; 2129 } 2130 2131 /* 2132 * Apply default & customized values 2133 * and then start streaming. 2134 */ 2135 ret = imx319_start_streaming(imx319); 2136 if (ret) 2137 goto err_rpm_put; 2138 } else { 2139 imx319_stop_streaming(imx319); 2140 pm_runtime_put(>dev); 2141 } 2142 2143 imx319->streaming = enable; 2144 2145 /* vflip and hflip cannot change during streaming */ > 2146 __v4l2_ctrl_grab(imx319->vflip, enable); 2147 __v4l2_ctrl_grab(imx319->hflip, enable); 2148 2149 mutex_unlock(>mutex); 2150 2151 return ret; 2152 2153 err_rpm_put: 2154 pm_runtime_put(>dev); 2155 err_unlock: 2156 mutex_unlock(>mutex); 2157 2158 return ret; 2159 } 2160 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 02/14] media: v4l2: taint pads with the signal types for consumer devices
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.19-rc4 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Better-handle-pads-for-tuning-decoder-part-of-the-devices/20180916-233739 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' include/linux/mod_devicetable.h:763: warning: Function parameter or member 'driver_data' not described in 'typec_device_id' kernel/sched/fair.c:3371: warning: Function parameter or member 'flags' not described in 'attach_entity_load_avg' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'i' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'v' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:96: warning: Excess function parameter 'v' description in 'arch_atomic_inc' arch/x86/include/asm/atomic.h:109: warning: Excess function parameter 'v' description in 'arch_atomic_dec' arch/x86/include/asm/atomic.h:124: warning: Excess function parameter 'v' description in 'arch_atomic_dec_and_test' arch/x86/include/asm/atomic.h:138: warning: Excess function parameter 'v' description in 'arch_atomic_inc_and_test' arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'i' description in 'arch_atomic_add_negative' arch/x86/include/asm/atomic.h:153: warning: Excess function parameter 'v' description in 'arch_atomic_add_negative' include/linux/dma-buf.h:304: warning:
Re: [PATCHv2 5/5] adv7842: enable reduced fps detection
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.18 next-20180815] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-Verkuil/Handling-of-reduced-FPS-in-V4L2/20180816-051924 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-a0-201832 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/media/i2c/adv7842.o: In function `adv7842_query_dv_timings': >> drivers/media/i2c/adv7842.c:1602: undefined reference to `__udivdi3' vim +1602 drivers/media/i2c/adv7842.c 1530 1531 static int adv7842_query_dv_timings(struct v4l2_subdev *sd, 1532 struct v4l2_dv_timings *timings) 1533 { 1534 struct adv7842_state *state = to_state(sd); 1535 struct v4l2_bt_timings *bt = >bt; 1536 struct stdi_readback stdi = { 0 }; 1537 1538 v4l2_dbg(1, debug, sd, "%s:\n", __func__); 1539 1540 memset(timings, 0, sizeof(struct v4l2_dv_timings)); 1541 1542 /* SDP block */ 1543 if (state->mode == ADV7842_MODE_SDP) 1544 return -ENODATA; 1545 1546 /* read STDI */ 1547 if (read_stdi(sd, )) { 1548 state->restart_stdi_once = true; 1549 v4l2_dbg(1, debug, sd, "%s: no valid signal\n", __func__); 1550 return -ENOLINK; 1551 } 1552 bt->interlaced = stdi.interlaced ? 1553 V4L2_DV_INTERLACED : V4L2_DV_PROGRESSIVE; 1554 bt->standards = V4L2_DV_BT_STD_CEA861 | V4L2_DV_BT_STD_DMT | 1555 V4L2_DV_BT_STD_GTF | V4L2_DV_BT_STD_CVT; 1556 1557 if (is_digital_input(sd)) { 1558 u32 freq; 1559 1560 timings->type = V4L2_DV_BT_656_1120; 1561 1562 bt->width = (hdmi_read(sd, 0x07) & 0x0f) * 256 + hdmi_read(sd, 0x08); 1563 bt->height = (hdmi_read(sd, 0x09) & 0x0f) * 256 + hdmi_read(sd, 0x0a); 1564 freq = ((hdmi_read(sd, 0x51) << 1) + (hdmi_read(sd, 0x52) >> 7)) * 100; 1565 freq += ((hdmi_read(sd, 0x52) & 0x7f) * 7813); 1566 if (is_hdmi(sd)) { 1567 /* adjust for deep color mode */ 1568 freq = freq * 8 / (((hdmi_read(sd, 0x0b) & 0xc0) >> 6) * 2 + 8); 1569 } 1570 bt->pixelclock = freq; 1571 bt->hfrontporch = (hdmi_read(sd, 0x20) & 0x03) * 256 + 1572 hdmi_read(sd, 0x21); 1573 bt->hsync = (hdmi_read(sd, 0x22) & 0x03) * 256 + 1574 hdmi_read(sd, 0x23); 1575 bt->hbackporch = (hdmi_read(sd, 0x24) & 0x03) * 256 + 1576 hdmi_read(sd, 0x25); 1577 bt->vfrontporch = ((hdmi_read(sd, 0x2a) & 0x1f) * 256 + 1578 hdmi_read(sd, 0x2b)) / 2; 1579 bt->vsync = ((hdmi_read(sd, 0x2e) & 0x1f) * 256 + 1580 hdmi_read(sd, 0x2f)) / 2; 1581 bt->vbackporch = ((hdmi_read(sd, 0x32) & 0x1f) * 256 + 1582 hdmi_read(sd, 0x33)) / 2; 1583 bt->polarities = ((hdmi_read(sd, 0x05) & 0x10) ? V4L2_DV_VSYNC_POS_POL : 0) | 1584 ((hdmi_read(sd, 0x05) & 0x20) ? V4L2_DV_HSYNC_POS_POL : 0); 1585 if (bt->interlaced == V4L2_DV_INTERLACED) { 1586 bt->height += (hdmi_read(sd, 0x0b) & 0x0f) * 256 + 1587 hdmi_read(sd, 0x0c); 1588 bt->il_vfrontporch = ((hdmi_read(sd, 0x2c) & 0x1f) * 256 + 1589 hdmi_read(sd, 0x2d)) / 2; 1590 bt->il_vsync = ((hdmi_read(sd, 0x30) & 0x1f) * 256 + 1591 hdmi_read(sd, 0x31)) / 2; 1592 bt->il_vbackporch = ((hdmi_read(sd, 0x34) & 0x1f) * 256 + 1593 hdmi_read(sd, 0x35)) / 2; 1594 } else { 1595 bt->il_vfrontporch = 0; 1596 bt->il_vsync = 0; 1597 bt->il_vbackporch = 0; 1598 } 1599 adv7842_fill_optional_dv_timings_fields(sd, timings); 1600 if ((timings->bt.flags & V4L2_DV_FL_CAN_REDUCE_FPS) && 1601 freq < bt->pixelclock) { > 1602 u32 reduced_freq = (bt->pixelclock / 1001) * >
[ragnatech:media-tree 273/382] drivers/media/i2c/mt9v111.c:801:10: error: implicit declaration of function 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'?
tree: git://git.ragnatech.se/linux media-tree head: 12f336c88090fb8004736fd4329184326a49673b commit: aab7ed1c392703604fbdc5bd5005dfb61a0b32f9 [273/382] media: i2c: Add driver for Aptina MT9V111 config: x86_64-randconfig-x010-201831 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: git checkout aab7ed1c392703604fbdc5bd5005dfb61a0b32f9 # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): drivers/media/i2c/mt9v111.c: In function '__mt9v111_get_pad_format': >> drivers/media/i2c/mt9v111.c:801:10: error: implicit declaration of function >> 'v4l2_subdev_get_try_format'; did you mean 'v4l2_subdev_notify_event'? >> [-Werror=implicit-function-declaration] return v4l2_subdev_get_try_format(>sd, cfg, pad); ^~ v4l2_subdev_notify_event >> drivers/media/i2c/mt9v111.c:801:10: warning: return makes pointer from >> integer without a cast [-Wint-conversion] return v4l2_subdev_get_try_format(>sd, cfg, pad); ^~ drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format': drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in this function [-Wmaybe-uninitialized] unsigned int idx; ^~~ cc1: some warnings being treated as errors vim +801 drivers/media/i2c/mt9v111.c 791 792 static struct v4l2_mbus_framefmt *__mt9v111_get_pad_format( 793 struct mt9v111_dev *mt9v111, 794 struct v4l2_subdev_pad_config *cfg, 795 unsigned int pad, 796 enum v4l2_subdev_format_whence which) 797 { 798 switch (which) { 799 case V4L2_SUBDEV_FORMAT_TRY: 800 #if IS_ENABLED(CONFIG_MEDIA_CONTROLLER) > 801 return v4l2_subdev_get_try_format(>sd, cfg, > pad); 802 #else 803 return >try_fmt; 804 #endif 805 case V4L2_SUBDEV_FORMAT_ACTIVE: 806 return >fmt; 807 default: 808 return NULL; 809 } 810 } 811 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[RFC PATCH ragnatech] media: tvp5150: tvp5150_volatile_reg() can be static
Fixes: 07dff5b8c030 ("media: tvp5150: convert register access to regmap") Signed-off-by: kbuild test robot --- tvp5150.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index b3c7b65..2bd9500 100644 --- a/drivers/media/i2c/tvp5150.c +++ b/drivers/media/i2c/tvp5150.c @@ -1321,7 +1321,7 @@ static const struct regmap_range tvp5150_readable_ranges[] = { }, }; -bool tvp5150_volatile_reg(struct device *dev, unsigned int reg) +static bool tvp5150_volatile_reg(struct device *dev, unsigned int reg) { switch (reg) { case TVP5150_VERT_LN_COUNT_MSB:
[ragnatech:media-tree 311/324] drivers/media/i2c/tvp5150.c:1324:6: sparse: symbol 'tvp5150_volatile_reg' was not declared. Should it be static?
tree: git://git.ragnatech.se/linux media-tree head: 1d06352e18ef502e30837cedfe618298816fb48c commit: 07dff5b8c03053db6fb6e33fd38c3e5d37f67bc5 [311/324] media: tvp5150: convert register access to regmap reproduce: # apt-get install sparse git checkout 07dff5b8c03053db6fb6e33fd38c3e5d37f67bc5 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:893:21: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) drivers/media/i2c/tvp5150.c:894:20: sparse: expression using sizeof(void) >> drivers/media/i2c/tvp5150.c:1324:6: sparse: symbol 'tvp5150_volatile_reg' >> was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[RFC PATCH] media: rc: repeat_period() can be static
Fixes: f52e85dbaa91 ("media: rc: read out of bounds if bpf reports high protocol number") Signed-off-by: kbuild test robot --- rc-main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index a24850b..ca68e1d 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -679,7 +679,7 @@ static void ir_timer_repeat(struct timer_list *t) spin_unlock_irqrestore(>keylock, flags); } -unsigned int repeat_period(int protocol) +static unsigned int repeat_period(int protocol) { if (protocol >= ARRAY_SIZE(protocols)) return 100;
Re: [PATCH] media: rc: read out of bounds if bpf reports high protocol number
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.18-rc6 next-20180727] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sean-Young/media-rc-read-out-of-bounds-if-bpf-reports-high-protocol-number/20180729-035942 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/media/rc/rc-main.c:682:14: sparse: symbol 'repeat_period' was not >> declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[ragnatech:media-tree] BUILD SUCCESS 4070fc9ade52f7d0ad1397fe74f564ae95e68a4f
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 4070fc9ade52f7d0ad1397fe74f564ae95e68a4f media: rcar-csi2: update stream start for V3M elapsed time: 160m configs tested: 195 The following configs have been built successfully. More configs may be tested in the coming days. alpha defconfig pariscallnoconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig powerpc mpc834x_itx_defconfig sh sh7770_generic_defconfig arm pcm027_defconfig sh polaris_defconfig armmulti_v7_defconfig sh landisk_defconfig x86_64 randconfig-a0-07272220 x86_64 randconfig-a0-07272321 i386 tinyconfig powerpc tqm8555_defconfig sh magicpanelr2_defconfig armtrizeps4_defconfig m68k sun3_defconfig shallnoconfig sh rsk7269_defconfig sh sh7785lcr_32bit_defconfig shtitan_defconfig powerpc pq2fads_defconfig sh se7705_defconfig mips ip27_defconfig powerpc mpc8540_ads_defconfig i386 randconfig-x012-201829 i386 randconfig-x017-201829 i386 randconfig-x014-201829 i386 randconfig-x016-201829 i386 randconfig-x013-201829 i386 randconfig-x011-201829 i386 randconfig-x018-201829 i386 randconfig-x010-201829 i386 randconfig-x015-201829 i386 randconfig-x019-201829 microblaze mmu_defconfig microblazenommu_defconfig i386 randconfig-n0-201829 x86_64 randconfig-x007-201829 x86_64 randconfig-x003-201829 x86_64 randconfig-x000-201829 x86_64 randconfig-x005-201829 x86_64 randconfig-x004-201829 x86_64 randconfig-x008-201829 x86_64 randconfig-x001-201829 x86_64 randconfig-x009-201829 x86_64 randconfig-x002-201829 x86_64 randconfig-x006-201829 i386 randconfig-i0-201829 i386 randconfig-i1-201829 mips xway_defconfig sh j2_defconfig x86_64allnoconfig arm nuc960_defconfig x86_64 randconfig-v0-07272303 arm allnoconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armshmobile_defconfig arm sunxi_defconfig arm64 allnoconfig arm64 defconfig powerpc mpc834x_mds_defconfig um allyesconfig x86_64 fedora-25 x86_64 kexec x86_64 rhel x86_64 rhel-7.2 powerpc defconfig s390default_defconfig powerpc ppc64_defconfig powerpc allnoconfig x86_64 randconfig-g0-07272246 openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig nios2 10m50_defconfig xtensa common_defconfig xtensa iss_defconfig x86_64 randconfig-x018-201829 x86_64 randconfig-x011-201829 x86_64 randconfig-x015-201829 x86_64 randconfig-x019-201829 x86_64 randconfig-x014-201829 x86_64 randconfig-x010-201829 x86_64 randconfig-x013-201829 x86_64 randconfig-x016-201829 x86_64 randconfig-x017-201829 x86_64 randconfig-x012-201829 ia64 alldefconfig ia64 allnoconfig ia64defconfig arm allmodconfig arm arm5 arm arm67 arm imx_v6_v7_defconfig arm ixp4xx_defconfig arm
[linux-next:master 9330/9982] fs/compat_ioctl.c:218:45: error: invalid application of 'sizeof' to incomplete type 'struct video_spu_palette'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 639d109b21f1413c54ca7042e40a57856e7679bb commit: f863ce990030cfc5a57a490b4613be4a523ffce1 [9330/9982] media: dvb: get rid of VIDEO_SET_SPU_PALETTE config: x86_64-kexec (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: git checkout f863ce990030cfc5a57a490b4613be4a523ffce1 # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-next/master HEAD 639d109b21f1413c54ca7042e40a57856e7679bb builds fine. It may have been fixed somewhere. All errors (new ones prefixed by >>): fs/compat_ioctl.c: In function 'do_video_set_spu_palette': >> fs/compat_ioctl.c:218:45: error: invalid application of 'sizeof' to >> incomplete type 'struct video_spu_palette' up_native = compat_alloc_user_space(sizeof(struct video_spu_palette)); ^~ In file included from include/linux/uaccess.h:14:0, from include/linux/compat.h:19, from fs/compat_ioctl.c:17: >> fs/compat_ioctl.c:219:46: error: dereferencing pointer to incomplete type >> 'struct video_spu_palette' err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:257:15: note: in definition of macro 'put_user' __typeof__(*(ptr)) __pu_val;\ ^~~ arch/x86/include/asm/uaccess.h:260:11: warning: assignment makes integer from pointer without a cast [-Wint-conversion] __pu_val = x; \ ^ fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^~~~ At top level: fs/compat_ioctl.c:206:12: warning: 'do_video_set_spu_palette' defined but not used [-Wunused-function] static int do_video_set_spu_palette(struct file *file, ^~~~ vim +218 fs/compat_ioctl.c 6e87abd0 David S. Miller 2005-11-16 205 66cf191f Al Viro 2016-01-07 206 static int do_video_set_spu_palette(struct file *file, b4341721 Jann Horn 2016-01-05 207unsigned int cmd, struct compat_video_spu_palette __user *up) 6e87abd0 David S. Miller 2005-11-16 208 { 6e87abd0 David S. Miller 2005-11-16 209struct video_spu_palette __user *up_native; 6e87abd0 David S. Miller 2005-11-16 210compat_uptr_t palp; 6e87abd0 David S. Miller 2005-11-16 211int length, err; 6e87abd0 David S. Miller 2005-11-16 212 6e87abd0 David S. Miller 2005-11-16 213err = get_user(palp, >palette); 6e87abd0 David S. Miller 2005-11-16 214err |= get_user(length, >length); 12176503 Kees Cook 2012-10-25 215if (err) 12176503 Kees Cook 2012-10-25 216return -EFAULT; 6e87abd0 David S. Miller 2005-11-16 217 6e87abd0 David S. Miller 2005-11-16 @218up_native = compat_alloc_user_space(sizeof(struct video_spu_palette)); 7116e994 Heiko Carstens 2006-12-06 @219err = put_user(compat_ptr(palp), _native->palette); 7116e994 Heiko Carstens 2006-12-06 220err |= put_user(length, _native->length); 7116e994 Heiko Carstens 2006-12-06 221if (err) 7116e994 Heiko Carstens 2006-12-06 222return -EFAULT; 6e87abd0 David S. Miller 2005-11-16 223 66cf191f Al Viro 2016-01-07 224err = do_ioctl(file, cmd, (unsigned long) up_native); 6e87abd0 David S. Miller 2005-11-16 225 6e87abd0 David S. Miller 2005-11-16 226return err; 6e87abd0 David S. Miller 2005-11-16 227 } 6e87abd0 David S. Miller 2005-11-16 228 :: The code at line 218 was first introduced by commit :: 6e87abd0b8cbb23ed9ffe5cc9f790fb5cac45eae [DVB]: Add compat ioctl handling. :: TO: David S. Miller :: CC: David S. Miller --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[ragnatech:media-tree 247/250] arch/arm64/include/asm/uaccess.h:403:18: note: in expansion of macro '__put_user'
tree: git://git.ragnatech.se/linux media-tree head: 343b23a7c6b6680ef949e6112a4ee60688acf39d commit: f863ce990030cfc5a57a490b4613be4a523ffce1 [247/250] media: dvb: get rid of VIDEO_SET_SPU_PALETTE config: arm64-allmodconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout f863ce990030cfc5a57a490b4613be4a523ffce1 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm64 All warnings (new ones prefixed by >>): fs/compat_ioctl.c: In function 'do_video_set_spu_palette': fs/compat_ioctl.c:218:45: error: invalid application of 'sizeof' to incomplete type 'struct video_spu_palette' up_native = compat_alloc_user_space(sizeof(struct video_spu_palette)); ^~ In file included from include/linux/uaccess.h:14:0, from include/linux/compat.h:19, from fs/compat_ioctl.c:17: fs/compat_ioctl.c:219:46: error: dereferencing pointer to incomplete type 'struct video_spu_palette' err = put_user(compat_ptr(palp), _native->palette); ^ arch/arm64/include/asm/uaccess.h:380:15: note: in definition of macro '__put_user_check' __typeof__(*(ptr)) __user *__p = (ptr);\ ^~~ >> arch/arm64/include/asm/uaccess.h:403:18: note: in expansion of macro >> '__put_user' #define put_user __put_user ^~ fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^~~~ >> arch/arm64/include/asm/uaccess.h:352:32: warning: initialization makes >> integer from pointer without a cast [-Wint-conversion] __typeof__(*(ptr)) __pu_val = (x);\ ^ >> arch/arm64/include/asm/uaccess.h:384:3: note: in expansion of macro >> '__put_user_err' __put_user_err((x), __p, (err)); \ ^~ >> arch/arm64/include/asm/uaccess.h:399:2: note: in expansion of macro >> '__put_user_check' __put_user_check((x), (ptr), __pu_err);\ ^~~~ >> arch/arm64/include/asm/uaccess.h:403:18: note: in expansion of macro >> '__put_user' #define put_user __put_user ^~ fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^~~~ At top level: fs/compat_ioctl.c:206:12: warning: 'do_video_set_spu_palette' defined but not used [-Wunused-function] static int do_video_set_spu_palette(struct file *file, ^~~~ vim +/__put_user +403 arch/arm64/include/asm/uaccess.h 84624087 Will Deacon 2018-02-05 335 57f4959b James Morse 2016-02-05 336 #define __put_user_asm(instr, alt_instr, reg, x, addr, err, feature) \ 0aea86a2 Catalin Marinas 2012-03-05 337asm volatile( \ 57f4959b James Morse 2016-02-05 338"1:"ALTERNATIVE(instr " " reg "1, [%2]\n", \ 57f4959b James Morse 2016-02-05 339alt_instr " " reg "1, [%2]\n", feature) \ 0aea86a2 Catalin Marinas 2012-03-05 340"2:\n" \ 0aea86a2 Catalin Marinas 2012-03-05 341" .section .fixup,\"ax\"\n" \ 0aea86a2 Catalin Marinas 2012-03-05 342" .align 2\n" \ 0aea86a2 Catalin Marinas 2012-03-05 343"3: mov %w0, %3\n" \ 0aea86a2 Catalin Marinas 2012-03-05 344" b 2b\n" \ 0aea86a2 Catalin Marinas 2012-03-05 345" .previous\n" \ 6c94f27a Ard Biesheuvel 2016-01-01 346_ASM_EXTABLE(1b, 3b) \ 0aea86a2 Catalin Marinas 2012-03-05 347: "+r" (err) \ 0aea86a2 Catalin Marinas 2012-03-05 348: "r" (x), "r" (addr), "i" (-EFAULT)) 0aea86a2 Catalin Marinas 2012-03-05 349 0aea86a2 Catalin Marinas 2012-03-05 350 #define __put_user_err(x, ptr, err) \ 0aea86a2 Catalin Marinas 2012-03-05 351 do { \ 0aea86a2 Catalin Marinas 2012-03-05 @352__typeof__(*(ptr)) __pu_val = (x); \ 0aea86a2 Catalin Marinas 2012-03-05 353__chk_user_ptr(ptr); \ bd38967d Catalin Marinas 2016-07-01 354
[linuxtv-media:master 247/250] arch/mips/include/asm/uaccess.h:445:32: warning: initialization makes integer from pointer without a cast
tree: git://linuxtv.org/media_tree.git master head: 343b23a7c6b6680ef949e6112a4ee60688acf39d commit: f863ce990030cfc5a57a490b4613be4a523ffce1 [247/250] media: dvb: get rid of VIDEO_SET_SPU_PALETTE config: mips-fuloong2e_defconfig (attached as .config) compiler: mips64el-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout f863ce990030cfc5a57a490b4613be4a523ffce1 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=mips All warnings (new ones prefixed by >>): fs/compat_ioctl.c: In function 'do_video_set_spu_palette': fs/compat_ioctl.c:218:45: error: invalid application of 'sizeof' to incomplete type 'struct video_spu_palette' up_native = compat_alloc_user_space(sizeof(struct video_spu_palette)); ^~ In file included from include/linux/uaccess.h:14:0, from include/linux/compat.h:19, from fs/compat_ioctl.c:17: fs/compat_ioctl.c:219:46: error: dereferencing pointer to incomplete type 'struct video_spu_palette' err = put_user(compat_ptr(palp), _native->palette); ^ arch/mips/include/asm/uaccess.h:444:15: note: in definition of macro '__put_user_check' __typeof__(*(ptr)) __user *__pu_addr = (ptr); \ ^~~ fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^~~~ >> arch/mips/include/asm/uaccess.h:445:32: warning: initialization makes >> integer from pointer without a cast [-Wint-conversion] __typeof__(*(ptr)) __pu_val = (x);\ ^ >> arch/mips/include/asm/uaccess.h:158:2: note: in expansion of macro >> '__put_user_check' __put_user_check((x), (ptr), sizeof(*(ptr))) ^~~~ fs/compat_ioctl.c:219:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^~~~ At top level: fs/compat_ioctl.c:206:12: warning: 'do_video_set_spu_palette' defined but not used [-Wunused-function] static int do_video_set_spu_palette(struct file *file, ^~~~ vim +445 arch/mips/include/asm/uaccess.h ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 441 ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 442 #define __put_user_check(x, ptr, size)\ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 443 ({ \ fe00f943 include/asm-mips/uaccess.h Ralf Baechle2005-03-01 @444 __typeof__(*(ptr)) __user *__pu_addr = (ptr); \ fe00f943 include/asm-mips/uaccess.h Ralf Baechle2005-03-01 @445 __typeof__(*(ptr)) __pu_val = (x); \ 8d2d91e8 include/asm-mips/uaccess.h Ralf Baechle2008-10-11 446 int __pu_err = -EFAULT; \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 447 \ ef41f460 arch/mips/include/asm/uaccess.h Ralf Baechle2009-04-28 448 might_fault(); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 449 if (likely(access_ok(VERIFY_WRITE, __pu_addr, size))) {\ 12060666 arch/mips/include/asm/uaccess.h Paul Burton 2015-05-24 450 if (eva_kernel_access())\ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 451 __put_kernel_common(__pu_addr, size); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 452 else\ ec56b1d4 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-17 453 __put_user_common(__pu_addr, size); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 454 } \ ec56b1d4 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-17 455 \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 456 __pu_err; \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 457 }) ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 458 :: The code at line 445 was first introduced by commit ::
[PATCH] media: omap2: omapfb: fix bugon.cocci warnings
From: kbuild test robot drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h) Use BUG_ON instead of a if condition followed by BUG. Semantic patch information: This makes an effort to find cases where BUG() follows an if condition on an expression and replaces the if condition and BUG() with a BUG_ON having the conditional expression of the if statement as argument. Generated by: scripts/coccinelle/misc/bugon.cocci Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") Signed-off-by: kbuild test robot --- Please take the patch only if it's a positive warning. Thanks! dss_features.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/video/fbdev/omap2/omapfb/dss/dss_features.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss_features.c @@ -891,8 +891,7 @@ bool dss_has_feature(enum dss_feat_id id void dss_feat_get_reg_field(enum dss_feat_reg_field id, u8 *start, u8 *end) { - if (id >= omap_current_dss_features->num_reg_fields) - BUG(); + BUG_ON(id >= omap_current_dss_features->num_reg_fields); *start = omap_current_dss_features->reg_fields[id].start; *end = omap_current_dss_features->reg_fields[id].end;
[PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings
From: kbuild test robot drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1 in function 'cmp_var_to_colormode' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") Signed-off-by: kbuild test robot --- omapfb-main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c +++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c @@ -287,7 +287,7 @@ static bool cmp_var_to_colormode(struct var->red.length == 0 || var->blue.length == 0 || var->green.length == 0) - return 0; + return false; return var->bits_per_pixel == color->bits_per_pixel && cmp_component(>red, >red) &&
[PATCH] media: omap2: omapfb: fix ifnullfree.cocci warnings
From: kbuild test robot drivers/video/fbdev/omap2/omapfb/dss/core.c:141:2-26: WARNING: NULL check before some freeing functions is not needed. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST") Signed-off-by: kbuild test robot --- Please take the patch only if it's a positive warning. Thanks! core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -137,8 +137,7 @@ static int dss_initialize_debugfs(void) static void dss_uninitialize_debugfs(void) { - if (dss_debugfs_dir) - debugfs_remove_recursive(dss_debugfs_dir); + debugfs_remove_recursive(dss_debugfs_dir); } int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of 0/1 in function 'cmp_var_to_colormode' with return type bool
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9981b4fb8684883dcc0daf088891ff32260b9794 commit: 7378f1149884b183631c6c16c0f1c62bcd7d759d media: omap2: omapfb: allow building it with COMPILE_TEST date: 3 months ago coccinelle warnings: (new ones prefixed by >>) >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of >> 0/1 in function 'cmp_var_to_colormode' with return type bool -- >> drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use >> BUG_ON instead of if condition followed by BUG. Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h) -- >> drivers/video/fbdev/omap2/omapfb/dss/core.c:141:2-26: WARNING: NULL check >> before some freeing functions is not needed. Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[ragnatech:media-tree] BUILD INCOMPLETE 231783073ebfc4acf02a45cb78a52ffa16e4e6d3
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 231783073ebfc4acf02a45cb78a52ffa16e4e6d3 media: v4l: rcar_fdp1: Enable compilation on Gen2 platforms TIMEOUT after 600m Sorry we cannot finish the testset for your branch within a reasonable time. It's our fault -- either some build server is down or some build worker is busy doing bisects for _other_ trees. The branch will get more complete coverage and possible error reports when our build infrastructure is restored or catches up. There will be no more build success notification for this branch head, but you can expect reasonably good test coverage after waiting for 1 day. configs tested: 50 i386 tinyconfig i386 randconfig-x012-201829 i386 randconfig-x017-201829 i386 randconfig-x014-201829 i386 randconfig-x016-201829 i386 randconfig-x013-201829 i386 randconfig-x011-201829 i386 randconfig-x018-201829 i386 randconfig-x010-201829 i386 randconfig-x015-201829 i386 randconfig-x019-201829 x86_64 randconfig-x007-201829 x86_64 randconfig-x003-201829 x86_64 randconfig-x000-201829 x86_64 randconfig-x005-201829 x86_64 randconfig-x004-201829 x86_64 randconfig-x008-201829 x86_64 randconfig-x001-201829 x86_64 randconfig-x009-201829 x86_64 randconfig-x002-201829 x86_64 randconfig-x006-201829 x86_64 acpi-redef x86_64 allyesdebian x86_64nfsroot x86_64 randconfig-x010-201829 x86_64 randconfig-x011-201829 x86_64 randconfig-x012-201829 x86_64 randconfig-x013-201829 x86_64 randconfig-x014-201829 x86_64 randconfig-x015-201829 x86_64 randconfig-x016-201829 x86_64 randconfig-x017-201829 x86_64 randconfig-x018-201829 x86_64 randconfig-x019-201829 ia64 alldefconfig ia64 allnoconfig ia64defconfig openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig c6xevmc6678_defconfig h8300h8300h-sim_defconfig nios2 10m50_defconfig xtensa common_defconfig xtensa iss_defconfig alpha defconfig pariscallnoconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH] media: imx208: Add imx208 camera sensor driver
Hi Ping-chung, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.18-rc4 next-20180709] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ping-chung-Chen/media-imx208-Add-imx208-camera-sensor-driver/20180710-153546 base: git://linuxtv.org/media_tree.git master config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/media/i2c/imx208.c: In function 'imx208_probe': drivers/media/i2c/imx208.c:881:20: error: 'struct media_entity' has no member named 'type'; did you mean 'pipe'? imx208->sd.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ^~~~ pipe >> drivers/media/i2c/imx208.c:881:27: error: 'MEDIA_ENT_T_V4L2_SUBDEV_SENSOR' >> undeclared (first use in this function); did you mean >> 'MEDIA_ENTITY_TYPE_V4L2_SUBDEV'? imx208->sd.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ^~ MEDIA_ENTITY_TYPE_V4L2_SUBDEV drivers/media/i2c/imx208.c:881:27: note: each undeclared identifier is reported only once for each function it appears in drivers/media/i2c/imx208.c:885:8: error: implicit declaration of function 'media_entity_init'; did you mean 'media_entity_put'? [-Werror=implicit-function-declaration] ret = media_entity_init(>sd.entity, 1, >pad, 0); ^ media_entity_put cc1: some warnings being treated as errors vim +881 drivers/media/i2c/imx208.c 848 849 static int imx208_probe(struct i2c_client *client) 850 { 851 struct imx208 *imx208; 852 int ret; 853 u32 val = 0; 854 855 device_property_read_u32(>dev, "clock-frequency", ); 856 if (val != 1920) 857 return -EINVAL; 858 859 imx208 = devm_kzalloc(>dev, sizeof(*imx208), GFP_KERNEL); 860 if (!imx208) 861 return -ENOMEM; 862 863 /* Initialize subdev */ 864 v4l2_i2c_subdev_init(>sd, client, _subdev_ops); 865 866 /* Check module identity */ 867 ret = imx208_identify_module(imx208); 868 if (ret) 869 return ret; 870 871 /* Set default mode to max resolution */ 872 imx208->cur_mode = _modes[0]; 873 874 ret = imx208_init_controls(imx208); 875 if (ret) 876 return ret; 877 878 /* Initialize subdev */ 879 imx208->sd.internal_ops = _internal_ops; 880 imx208->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > 881 imx208->sd.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; 882 883 /* Initialize source pad */ 884 imx208->pad.flags = MEDIA_PAD_FL_SOURCE; 885 ret = media_entity_init(>sd.entity, 1, >pad, 0); 886 if (ret) { 887 dev_err(>dev, "%s failed:%d\n", __func__, ret); 888 goto error_handler_free; 889 } 890 891 ret = v4l2_async_register_subdev_sensor_common(>sd); 892 if (ret < 0) 893 goto error_media_entity; 894 895 pm_runtime_set_active(>dev); 896 pm_runtime_enable(>dev); 897 pm_runtime_idle(>dev); 898 899 return 0; 900 901 error_media_entity: 902 media_entity_cleanup(>sd.entity); 903 904 error_handler_free: 905 imx208_free_controls(imx208); 906 907 return ret; 908 } 909 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] media: imx208: Add imx208 camera sensor driver
Hi Ping-chung, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.18-rc4 next-20180709] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ping-chung-Chen/media-imx208-Add-imx208-camera-sensor-driver/20180710-153546 base: git://linuxtv.org/media_tree.git master config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/media/i2c/imx208.c:881:26: sparse: no member 'type' in struct media_entity drivers/media/i2c/imx208.c:885:15: sparse: undefined identifier 'media_entity_init' drivers/media/i2c/imx208.c:881:26: sparse: generating address of non-lvalue (8) drivers/media/i2c/imx208.c:885:32: sparse: call with no type! drivers/media/i2c/imx208.c: In function 'imx208_probe': >> drivers/media/i2c/imx208.c:881:20: error: 'struct media_entity' has no >> member named 'type'; did you mean 'pipe'? imx208->sd.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ^~~~ pipe >> drivers/media/i2c/imx208.c:881:27: error: 'MEDIA_ENT_T_V4L2_SUBDEV_SENSOR' >> undeclared (first use in this function); did you mean >> 'MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN'? imx208->sd.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ^~ MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN drivers/media/i2c/imx208.c:881:27: note: each undeclared identifier is reported only once for each function it appears in >> drivers/media/i2c/imx208.c:885:8: error: implicit declaration of function >> 'media_entity_init'; did you mean 'media_entity_put'? >> [-Werror=implicit-function-declaration] ret = media_entity_init(>sd.entity, 1, >pad, 0); ^ media_entity_put cc1: some warnings being treated as errors sparse warnings: (new ones prefixed by >>) drivers/media/i2c/imx208.c:881:26: sparse: no member 'type' in struct media_entity drivers/media/i2c/imx208.c:885:15: sparse: undefined identifier 'media_entity_init' >> drivers/media/i2c/imx208.c:881:26: sparse: generating address of non-lvalue >> (8) >> drivers/media/i2c/imx208.c:885:32: sparse: call with no type! drivers/media/i2c/imx208.c: In function 'imx208_probe': drivers/media/i2c/imx208.c:881:20: error: 'struct media_entity' has no member named 'type'; did you mean 'pipe'? imx208->sd.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ^~~~ pipe drivers/media/i2c/imx208.c:881:27: error: 'MEDIA_ENT_T_V4L2_SUBDEV_SENSOR' undeclared (first use in this function); did you mean 'MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN'? imx208->sd.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; ^~ MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN drivers/media/i2c/imx208.c:881:27: note: each undeclared identifier is reported only once for each function it appears in drivers/media/i2c/imx208.c:885:8: error: implicit declaration of function 'media_entity_init'; did you mean 'media_entity_put'? [-Werror=implicit-function-declaration] ret = media_entity_init(>sd.entity, 1, >pad, 0); ^ media_entity_put cc1: some warnings being treated as errors vim +881 drivers/media/i2c/imx208.c 848 849 static int imx208_probe(struct i2c_client *client) 850 { 851 struct imx208 *imx208; 852 int ret; 853 u32 val = 0; 854 855 device_property_read_u32(>dev, "clock-frequency", ); 856 if (val != 1920) 857 return -EINVAL; 858 859 imx208 = devm_kzalloc(>dev, sizeof(*imx208), GFP_KERNEL); 860 if (!imx208) 861 return -ENOMEM; 862 863 /* Initialize subdev */ 864 v4l2_i2c_subdev_init(>sd, client, _subdev_ops); 865 866 /* Check module identity */ 867 ret = imx208_identify_module(imx208); 868 if (ret) 869 return ret; 870 871 /* Set default mode to max resolution */ 872 imx208->cur_mode = _modes[0]; 873 874 ret = imx208_init_controls(imx208); 875 if (ret) 876 return ret; 877 878 /* Initialize subdev */ 879 imx208->sd.internal_ops = _internal_ops; 880 imx208->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > 881 imx208->sd.entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; 882 883 /* Initialize source pad */ 884 imx208->pad.flags = MEDIA_PAD_FL_SOURCE; > 885 ret =
[PATCH] media: dvb: fix noderef.cocci warnings
From: kbuild test robot drivers/media/dvb-core/dvb_frontend.c:2396:18-24: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci Fixes: 07acff734698 ("media: dvb: represent min/max/step/tolerance freqs in Hz") CC: Mauro Carvalho Chehab Signed-off-by: kbuild test robot --- dvb_frontend.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/dvb-core/dvb_frontend.c +++ b/drivers/media/dvb-core/dvb_frontend.c @@ -2393,7 +2393,7 @@ static int dvb_frontend_handle_ioctl(str case FE_GET_INFO: { struct dvb_frontend_info *info = parg; - memset(info, 0, sizeof(info)); + memset(info, 0, sizeof(*info)); dvb_frontend_get_frequency_limits(fe, >frequency_min, >frequency_max); strcpy(info->name, fe->ops.info.name);
Re: [PATCH 2/2] media: dvb: represent min/max/step/tolerance freqs in Hz
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.18-rc3 next-20180704] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/DVB-represent-frequencies-at-tuner-frontend-info-in-Hz/20180705-105703 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/media/dvb-core/dvb_frontend.c:2396:18-24: ERROR: application of >> sizeof to pointer Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 2/2] media: dvb: represent min/max/step/tolerance freqs in Hz
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.18-rc3 next-20180704] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/DVB-represent-frequencies-at-tuner-frontend-info-in-Hz/20180705-105703 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x002-201826 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from arch/x86/include/asm/string.h:3:0, from include/linux/string.h:20, from drivers/media/dvb-core/dvb_frontend.c:30: drivers/media/dvb-core/dvb_frontend.c: In function 'dvb_frontend_handle_ioctl': >> drivers/media/dvb-core/dvb_frontend.c:2396:25: warning: argument to 'sizeof' >> in '__builtin_memset' call is the same expression as the destination; did >> you mean to dereference it? [-Wsizeof-pointer-memaccess] memset(info, 0, sizeof(info)); ^ arch/x86/include/asm/string_32.h:325:52: note: in definition of macro 'memset' #define memset(s, c, count) __builtin_memset(s, c, count) ^ Cyclomatic Complexity 5 include/linux/compiler.h:__read_once_size Cyclomatic Complexity 5 include/linux/compiler.h:__write_once_size Cyclomatic Complexity 1 include/linux/kasan-checks.h:kasan_check_read Cyclomatic Complexity 1 include/linux/kasan-checks.h:kasan_check_write Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:constant_test_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:variable_test_bit Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:fls Cyclomatic Complexity 1 include/linux/log2.h:__ilog2_u32 Cyclomatic Complexity 3 include/linux/log2.h:is_power_of_2 Cyclomatic Complexity 1 arch/x86/include/asm/atomic.h:arch_atomic_read Cyclomatic Complexity 1 arch/x86/include/asm/atomic.h:arch_atomic_set Cyclomatic Complexity 1 include/asm-generic/atomic-instrumented.h:atomic_read Cyclomatic Complexity 1 include/asm-generic/atomic-instrumented.h:atomic_set Cyclomatic Complexity 1 arch/x86/include/asm/current.h:get_current Cyclomatic Complexity 1 include/asm-generic/getorder.h:__get_order Cyclomatic Complexity 1 include/linux/err.h:PTR_ERR Cyclomatic Complexity 1 include/linux/err.h:IS_ERR Cyclomatic Complexity 2 include/linux/thread_info.h:test_ti_thread_flag Cyclomatic Complexity 2 include/linux/thread_info.h:check_object_size Cyclomatic Complexity 2 include/linux/thread_info.h:copy_overflow Cyclomatic Complexity 4 include/linux/thread_info.h:check_copy_size Cyclomatic Complexity 70 include/linux/ktime.h:ktime_divns Cyclomatic Complexity 1 include/linux/ktime.h:ktime_to_us Cyclomatic Complexity 1 include/linux/ktime.h:ktime_us_delta Cyclomatic Complexity 1 include/linux/ktime.h:ktime_add_us Cyclomatic Complexity 1 include/linux/timekeeping.h:ktime_get_boottime Cyclomatic Complexity 1 include/linux/refcount.h:refcount_set Cyclomatic Complexity 1 arch/x86/include/asm/refcount.h:refcount_inc Cyclomatic Complexity 1 arch/x86/include/asm/refcount.h:refcount_dec_and_test Cyclomatic Complexity 1 include/linux/sched.h:task_thread_info Cyclomatic Complexity 1 include/linux/sched.h:test_tsk_thread_flag Cyclomatic Complexity 1 include/linux/sched/signal.h:signal_pending Cyclomatic Complexity 28 include/linux/slab.h:kmalloc_index Cyclomatic Complexity 67 include/linux/slab.h:kmalloc_large Cyclomatic Complexity 5 include/linux/slab.h:kmalloc Cyclomatic Complexity 1 include/linux/slab.h:kzalloc Cyclomatic Complexity 1 include/linux/semaphore.h:sema_init Cyclomatic Complexity 2 include/linux/uaccess.h:copy_to_user Cyclomatic Complexity 4 include/linux/poll.h:poll_wait Cyclomatic Complexity 1 include/linux/kref.h:kref_init Cyclomatic Complexity 1 include/linux/kref.h:kref_get Cyclomatic Complexity 2 include/linux/kref.h:kref_put Cyclomatic Complexity 2 include/linux/freezer.h:freezing Cyclomatic Complexity 2 include/linux/freezer.h:try_to_freeze_unsafe Cyclomatic Complexity 2 include/linux/freezer.h:try_to_freeze Cyclomatic Complexity 1 drivers/media/dvb-core/dvb_frontend.c:dvb_frontend_get Cyclomatic Complexity 1 drivers/media/dvb-core/dvb_frontend.c:has_get_frontend Cyclomatic Complexity 5 drivers/media/dvb-core/dvb_frontend.c:dvbv3_type Cyclomatic Complexity 5 drivers/media/dvb-core/dvb_frontend.c:dvb_frontend_init Cyclomatic Complexity 2 drivers/media/dvb-core/dvb_frontend.c:dvb_frontend_swzigzag_update_delay Cyclomatic Complexity 20 drivers/media/dvb-core/dvb_frontend.c:dvb_frontend_swzigzag_autotune Cyclomatic Complexity 6
Re: [PATCH 2/2] media: dvb: represent min/max/step/tolerance freqs in Hz
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.18-rc3 next-20180704] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/DVB-represent-frequencies-at-tuner-frontend-info-in-Hz/20180705-105703 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-x004-201826 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): drivers/media/dvb-core/dvb_frontend.c: In function 'dvb_frontend_handle_ioctl': >> drivers/media/dvb-core/dvb_frontend.c:2396:25: warning: argument to 'sizeof' >> in 'memset' call is the same expression as the destination; did you mean to >> dereference it? [-Wsizeof-pointer-memaccess] memset(info, 0, sizeof(info)); ^ vim +2396 drivers/media/dvb-core/dvb_frontend.c 2295 2296 static int dvb_frontend_handle_ioctl(struct file *file, 2297 unsigned int cmd, void *parg) 2298 { 2299 struct dvb_device *dvbdev = file->private_data; 2300 struct dvb_frontend *fe = dvbdev->priv; 2301 struct dvb_frontend_private *fepriv = fe->frontend_priv; 2302 struct dtv_frontend_properties *c = >dtv_property_cache; 2303 int i, err = -ENOTSUPP; 2304 2305 dev_dbg(fe->dvb->device, "%s:\n", __func__); 2306 2307 switch (cmd) { 2308 case FE_SET_PROPERTY: { 2309 struct dtv_properties *tvps = parg; 2310 struct dtv_property *tvp = NULL; 2311 2312 dev_dbg(fe->dvb->device, "%s: properties.num = %d\n", 2313 __func__, tvps->num); 2314 dev_dbg(fe->dvb->device, "%s: properties.props = %p\n", 2315 __func__, tvps->props); 2316 2317 /* 2318 * Put an arbitrary limit on the number of messages that can 2319 * be sent at once 2320 */ 2321 if (!tvps->num || (tvps->num > DTV_IOCTL_MAX_MSGS)) 2322 return -EINVAL; 2323 2324 tvp = memdup_user((void __user *)tvps->props, tvps->num * sizeof(*tvp)); 2325 if (IS_ERR(tvp)) 2326 return PTR_ERR(tvp); 2327 2328 for (i = 0; i < tvps->num; i++) { 2329 err = dtv_property_process_set(fe, file, 2330 (tvp + i)->cmd, 2331 (tvp + i)->u.data); 2332 if (err < 0) { 2333 kfree(tvp); 2334 return err; 2335 } 2336 } 2337 kfree(tvp); 2338 err = 0; 2339 break; 2340 } 2341 case FE_GET_PROPERTY: { 2342 struct dtv_properties *tvps = parg; 2343 struct dtv_property *tvp = NULL; 2344 struct dtv_frontend_properties getp = fe->dtv_property_cache; 2345 2346 dev_dbg(fe->dvb->device, "%s: properties.num = %d\n", 2347 __func__, tvps->num); 2348 dev_dbg(fe->dvb->device, "%s: properties.props = %p\n", 2349 __func__, tvps->props); 2350 2351 /* 2352 * Put an arbitrary limit on the number of messages that can 2353 * be sent at once 2354 */ 2355 if (!tvps->num || (tvps->num > DTV_IOCTL_MAX_MSGS)) 2356 return -EINVAL; 2357 2358 tvp = memdup_user((void __user *)tvps->props, tvps->num * sizeof(*tvp)); 2359 if (IS_ERR(tvp)) 2360 return PTR_ERR(tvp); 2361 2362 /* 2363 * Let's use our own copy of property cache, in order to 2364 * avoid mangling with DTV zigzag logic, as drivers might 2365 * return crap, if they don't check if the data is available 2366 * before updating the properties cache. 2367 */ 2368 if (fepriv->state != FESTATE_IDLE) { 2369 err = dtv_get_frontend(fe, , NULL); 2370 if (err < 0) { 2371 kfree(tvp); 2372 return err; 2373 } 2374
Re: [PATCH 16/16] media: imx: add mem2mem device
Hi Philipp, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.18-rc1 next-20180622] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/i-MX-media-mem2mem-scaler/20180623-024533 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=ia64 All warnings (new ones prefixed by >>): drivers/staging/media/imx/imx-media-mem2mem.c: In function 'vidioc_querycap': >> drivers/staging/media/imx/imx-media-mem2mem.c:160:2: warning: 'strncpy' >> output truncated copying 15 bytes from a string of length 17 >> [-Wstringop-truncation] strncpy(cap->driver, "imx-media-mem2mem", sizeof(cap->driver) - 1); ^~ vim +/strncpy +160 drivers/staging/media/imx/imx-media-mem2mem.c 153 154 /* 155 * Video ioctls 156 */ 157 static int vidioc_querycap(struct file *file, void *priv, 158 struct v4l2_capability *cap) 159 { > 160 strncpy(cap->driver, "imx-media-mem2mem", sizeof(cap->driver) - > 1); 161 strncpy(cap->card, "imx-media-mem2mem", sizeof(cap->card) - 1); 162 strncpy(cap->bus_info, "platform:imx-media-mem2mem", 163 sizeof(cap->bus_info) - 1); 164 cap->device_caps = V4L2_CAP_VIDEO_M2M | V4L2_CAP_STREAMING; 165 cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS; 166 167 return 0; 168 } 169 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 1/2] media: add helpers for memory-to-memory media controller
Hi Ezequiel, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.18-rc1 next-20180620] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ezequiel-Garcia/media-add-helpers-for-memory-to-memory-media-controller/20180621-050216 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-x012-201824 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/media/v4l2-core/v4l2-mem2mem.c: In function 'v4l2_m2m_unregister_media_controller': >> drivers/media/v4l2-core/v4l2-mem2mem.c:624:34: error: 'struct v4l2_m2m_dev' >> has no member named 'intf_devnode' media_remove_intf_links(_dev->intf_devnode->intf); ^~ drivers/media/v4l2-core/v4l2-mem2mem.c:625:30: error: 'struct v4l2_m2m_dev' has no member named 'intf_devnode' media_devnode_remove(m2m_dev->intf_devnode); ^~ >> drivers/media/v4l2-core/v4l2-mem2mem.c:627:35: error: 'struct v4l2_m2m_dev' >> has no member named 'source' media_entity_remove_links(m2m_dev->source); ^~ >> drivers/media/v4l2-core/v4l2-mem2mem.c:628:36: error: 'struct v4l2_m2m_dev' >> has no member named 'sink' media_entity_remove_links(_dev->sink); ^~ >> drivers/media/v4l2-core/v4l2-mem2mem.c:629:36: error: 'struct v4l2_m2m_dev' >> has no member named 'proc' media_entity_remove_links(_dev->proc); ^~ drivers/media/v4l2-core/v4l2-mem2mem.c:630:40: error: 'struct v4l2_m2m_dev' has no member named 'source' media_device_unregister_entity(m2m_dev->source); ^~ drivers/media/v4l2-core/v4l2-mem2mem.c:631:41: error: 'struct v4l2_m2m_dev' has no member named 'sink' media_device_unregister_entity(_dev->sink); ^~ drivers/media/v4l2-core/v4l2-mem2mem.c:632:41: error: 'struct v4l2_m2m_dev' has no member named 'proc' media_device_unregister_entity(_dev->proc); ^~ vim +624 drivers/media/v4l2-core/v4l2-mem2mem.c 621 622 void v4l2_m2m_unregister_media_controller(struct v4l2_m2m_dev *m2m_dev) 623 { > 624 media_remove_intf_links(_dev->intf_devnode->intf); > 625 media_devnode_remove(m2m_dev->intf_devnode); 626 > 627 media_entity_remove_links(m2m_dev->source); > 628 media_entity_remove_links(_dev->sink); > 629 media_entity_remove_links(_dev->proc); 630 media_device_unregister_entity(m2m_dev->source); 631 media_device_unregister_entity(_dev->sink); 632 media_device_unregister_entity(_dev->proc); 633 } 634 EXPORT_SYMBOL_GPL(v4l2_m2m_unregister_media_controller); 635 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v3] media: ov5640: fix frame interval enumeration
Hi Hugues, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.18-rc1 next-20180619] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hugues-Fruchet/media-ov5640-fix-frame-interval-enumeration/20180620-175405 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/media/i2c/ov5640.c:1394:14: sparse: incorrect type in assignment >> (different base types) @@expected struct ov5640_mode_info const *mode @@ >>got ststruct ov5640_mode_info const *mode @@ drivers/media/i2c/ov5640.c:1394:14:expected struct ov5640_mode_info const *mode drivers/media/i2c/ov5640.c:1394:14:got struct ov5640_mode_info const ( * )[9] vim +1394 drivers/media/i2c/ov5640.c 1387 1388 static const struct ov5640_mode_info * 1389 ov5640_find_mode(struct ov5640_dev *sensor, enum ov5640_frame_rate fr, 1390 int width, int height, bool nearest) 1391 { 1392 const struct ov5640_mode_info *mode; 1393 > 1394 mode = v4l2_find_nearest_size(ov5640_mode_data[fr], 1395ARRAY_SIZE(ov5640_mode_data[fr]), 1396hact, vact, 1397width, height); 1398 1399 if (!mode || 1400 (!nearest && (mode->hact != width || mode->vact != height))) 1401 return NULL; 1402 1403 return mode; 1404 } 1405 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI
Hi Yong, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17 next-20180614] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yong-Zhi/doc-rst-Add-Intel-IPU3-documentation/20180615-113101 config: i386-tinyconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ./usr/include/linux/intel-ipu3.h:7: included file 'linux/bitmap.h' is not >> exported --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 2/2] media: i2c: Add driver for Aptina MT9V111
Hi Jacopo, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17 next-20180608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jacopo-Mondi/media-i2c-mt9v111-sensor-driver/20180611-233038 base: git://linuxtv.org/media_tree.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format': >> drivers/media/i2c/mt9v111.c:929:15: warning: 'idx' may be used uninitialized >> in this function [-Wmaybe-uninitialized] unsigned int idx; ^~~ vim +/idx +929 drivers/media/i2c/mt9v111.c 920 921 static int mt9v111_set_format(struct v4l2_subdev *subdev, 922struct v4l2_subdev_pad_config *cfg, 923struct v4l2_subdev_format *format) 924 { 925 struct mt9v111_dev *mt9v111 = sd_to_mt9v111(subdev); 926 struct v4l2_mbus_framefmt new_fmt; 927 struct v4l2_mbus_framefmt *__fmt; 928 unsigned int best_fit = ~0L; > 929 unsigned int idx; 930 unsigned int i; 931 932 mutex_lock(>stream_mutex); 933 if (mt9v111->streaming) { 934 mutex_unlock(>stream_mutex); 935 return -EBUSY; 936 } 937 mutex_unlock(>stream_mutex); 938 939 if (format->pad) 940 return -EINVAL; 941 942 /* Update mbus format code and sizes. */ 943 for (i = 0; i < ARRAY_SIZE(mt9v111_formats); i++) { 944 if (format->format.code == mt9v111_formats[i].code) { 945 new_fmt.code = mt9v111_formats[i].code; 946 break; 947 } 948 } 949 if (i == ARRAY_SIZE(mt9v111_formats)) 950 new_fmt.code = mt9v111_formats[0].code; 951 952 for (i = 0; i < ARRAY_SIZE(mt9v111_frame_sizes); i++) { 953 unsigned int fit = abs(mt9v111_frame_sizes[i].width - 954 format->format.width) + 955 abs(mt9v111_frame_sizes[i].height - 956 format->format.height); 957 if (fit < best_fit) { 958 best_fit = fit; 959 idx = i; 960 961 if (fit == 0) 962 break; 963 } 964 } 965 new_fmt.width = mt9v111_frame_sizes[idx].width; 966 new_fmt.height = mt9v111_frame_sizes[idx].height; 967 968 /* Update the device (or pad) format if it has changed. */ 969 __fmt = __mt9v111_get_pad_format(mt9v111, cfg, format->pad, 970 format->which); 971 972 /* Format hasn't changed, stop here. */ 973 if (__fmt->code == new_fmt.code && 974 __fmt->width == new_fmt.width && 975 __fmt->height == new_fmt.height) 976 goto done; 977 978 /* Update the format and sizes, then mark changes as pending. */ 979 __fmt->code = new_fmt.code; 980 __fmt->width = new_fmt.width; 981 __fmt->height = new_fmt.height; 982 983 if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) 984 mt9v111->pending = true; 985 986 dev_info(mt9v111->dev, "%s: mbus_code: %x - (%ux%u)\n", 987 __func__, __fmt->code, __fmt->width, __fmt->height); 988 989 done: 990 format->format = *__fmt; 991 992 return 0; 993 } 994 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] media: stm32-dcmi: add power saving support
Hi Hugues, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17 next-20180608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hugues-Fruchet/media-stm32-dcmi-add-power-saving-support/20180611-174016 base: git://linuxtv.org/media_tree.git master config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sparc64 All errors (new ones prefixed by >>): drivers/media//platform/stm32/stm32-dcmi.c: In function 'dcmi_suspend': drivers/media//platform/stm32/stm32-dcmi.c:1886:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration] pinctrl_pm_select_sleep_state(dev); ^ drivers/media//platform/stm32/stm32-dcmi.c: In function 'dcmi_resume': >> drivers/media//platform/stm32/stm32-dcmi.c:1894:2: error: implicit >> declaration of function 'pinctrl_pm_select_default_state'; did you mean >> 'irq_set_default_host'? [-Werror=implicit-function-declaration] pinctrl_pm_select_default_state(dev); ^~~ irq_set_default_host cc1: some warnings being treated as errors vim +1894 drivers/media//platform/stm32/stm32-dcmi.c 1879 1880 static __maybe_unused int dcmi_suspend(struct device *dev) 1881 { 1882 /* disable clock */ 1883 pm_runtime_force_suspend(dev); 1884 1885 /* change pinctrl state */ > 1886 pinctrl_pm_select_sleep_state(dev); 1887 1888 return 0; 1889 } 1890 1891 static __maybe_unused int dcmi_resume(struct device *dev) 1892 { 1893 /* restore pinctl default state */ > 1894 pinctrl_pm_select_default_state(dev); 1895 1896 /* clock enable */ 1897 pm_runtime_force_resume(dev); 1898 1899 return 0; 1900 } 1901 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] media: stm32-dcmi: add power saving support
Hi Hugues, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17 next-20180608] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hugues-Fruchet/media-stm32-dcmi-add-power-saving-support/20180611-174016 base: git://linuxtv.org/media_tree.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/media/platform/stm32/stm32-dcmi.c: In function 'dcmi_suspend': >> drivers/media/platform/stm32/stm32-dcmi.c:1886:2: error: implicit >> declaration of function 'pinctrl_pm_select_sleep_state' >> [-Werror=implicit-function-declaration] pinctrl_pm_select_sleep_state(dev); ^ drivers/media/platform/stm32/stm32-dcmi.c: In function 'dcmi_resume': >> drivers/media/platform/stm32/stm32-dcmi.c:1894:2: error: implicit >> declaration of function 'pinctrl_pm_select_default_state' >> [-Werror=implicit-function-declaration] pinctrl_pm_select_default_state(dev); ^~~ cc1: some warnings being treated as errors vim +/pinctrl_pm_select_sleep_state +1886 drivers/media/platform/stm32/stm32-dcmi.c 1879 1880 static __maybe_unused int dcmi_suspend(struct device *dev) 1881 { 1882 /* disable clock */ 1883 pm_runtime_force_suspend(dev); 1884 1885 /* change pinctrl state */ > 1886 pinctrl_pm_select_sleep_state(dev); 1887 1888 return 0; 1889 } 1890 1891 static __maybe_unused int dcmi_resume(struct device *dev) 1892 { 1893 /* restore pinctl default state */ > 1894 pinctrl_pm_select_default_state(dev); 1895 1896 /* clock enable */ 1897 pm_runtime_force_resume(dev); 1898 1899 return 0; 1900 } 1901 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] media: dvb: get rid of VIDEO_SET_SPU_PALETTE
Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc7 next-20180529] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-dvb-get-rid-of-VIDEO_SET_SPU_PALETTE/20180530-033705 config: x86_64-randconfig-g0-05291849 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): fs/compat_ioctl.c: In function 'do_video_set_spu_palette': fs/compat_ioctl.c:220:45: error: invalid application of 'sizeof' to incomplete type 'struct video_spu_palette' up_native = compat_alloc_user_space(sizeof(struct video_spu_palette)); ^ In file included from include/linux/uaccess.h:14:0, from include/linux/compat.h:20, from fs/compat_ioctl.c:17: >> fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:257:15: note: in definition of macro 'put_user' __typeof__(*(ptr)) __pu_val;\ ^ arch/x86/include/asm/uaccess.h:260:11: warning: assignment makes integer from pointer without a cast __pu_val = x; \ ^ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^ >> fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:261:19: note: in definition of macro 'put_user' switch (sizeof(*(ptr))) {\ ^ >> fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:187:25: note: in definition of macro '__put_user_x' : "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx") ^ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^ >> fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:187:42: note: in definition of macro '__put_user_x' : "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx") ^ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^ >> fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:187:25: note: in definition of macro '__put_user_x' : "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx") ^ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^ >> fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:187:42: note: in definition of macro '__put_user_x' : "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx") ^ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^ >> fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:187:25: note: in definition of macro '__put_user_x' : "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx") ^ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^ >> fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type err = put_user(compat_ptr(palp), _native->palette); ^ arch/x86/include/asm/uaccess.h:187:42: note: in definition of macro '__put_user_x' : "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx") ^ fs/compat_ioctl.c:221:9: note: in expansion of macro
Re: [PATCH] media: dvb: get rid of VIDEO_SET_SPU_PALETTE
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc7 next-20180529] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-dvb-get-rid-of-VIDEO_SET_SPU_PALETTE/20180530-033705 config: mips-fuloong2e_defconfig (attached as .config) compiler: mips64el-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=mips All warnings (new ones prefixed by >>): fs/compat_ioctl.c: In function 'do_video_set_spu_palette': fs/compat_ioctl.c:220:45: error: invalid application of 'sizeof' to incomplete type 'struct video_spu_palette' up_native = compat_alloc_user_space(sizeof(struct video_spu_palette)); ^~ In file included from include/linux/uaccess.h:14:0, from include/linux/compat.h:20, from fs/compat_ioctl.c:17: fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type 'struct video_spu_palette' err = put_user(compat_ptr(palp), _native->palette); ^ arch/mips/include/asm/uaccess.h:444:15: note: in definition of macro '__put_user_check' __typeof__(*(ptr)) __user *__pu_addr = (ptr); \ ^~~ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^~~~ >> arch/mips/include/asm/uaccess.h:445:32: warning: initialization makes >> integer from pointer without a cast [-Wint-conversion] __typeof__(*(ptr)) __pu_val = (x);\ ^ >> arch/mips/include/asm/uaccess.h:158:2: note: in expansion of macro >> '__put_user_check' __put_user_check((x), (ptr), sizeof(*(ptr))) ^~~~ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), _native->palette); ^~~~ At top level: fs/compat_ioctl.c:208:12: warning: 'do_video_set_spu_palette' defined but not used [-Wunused-function] static int do_video_set_spu_palette(struct file *file, ^~~~ vim +445 arch/mips/include/asm/uaccess.h ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 441 ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 442 #define __put_user_check(x, ptr, size)\ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 443 ({ \ fe00f943 include/asm-mips/uaccess.h Ralf Baechle2005-03-01 @444 __typeof__(*(ptr)) __user *__pu_addr = (ptr); \ fe00f943 include/asm-mips/uaccess.h Ralf Baechle2005-03-01 @445 __typeof__(*(ptr)) __pu_val = (x); \ 8d2d91e8 include/asm-mips/uaccess.h Ralf Baechle2008-10-11 446 int __pu_err = -EFAULT; \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 447 \ ef41f460 arch/mips/include/asm/uaccess.h Ralf Baechle2009-04-28 448 might_fault(); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 449 if (likely(access_ok(VERIFY_WRITE, __pu_addr, size))) {\ 12060666 arch/mips/include/asm/uaccess.h Paul Burton 2015-05-24 450 if (eva_kernel_access())\ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 451 __put_kernel_common(__pu_addr, size); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 452 else\ ec56b1d4 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-17 453 __put_user_common(__pu_addr, size); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 454 } \ ec56b1d4 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-17 455 \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 456 __pu_err; \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 457 }) ^1da177e include/asm-mips/uaccess.h Linus Torvalds
[ragnatech:media-tree 442/456] drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: pvr2_v4l2_dev_init.cold.3()+0x4a: return with modified stack frame
tree: git://git.ragnatech.se/linux media-tree head: a00031c159748f322f771f3c1d5ed944cba4bd30 commit: eba09b5b3dfb1b79db4428b6f379f68db4b62056 [442/456] media: pvrusb2: replace pvr2_v4l2_ioctl by video_ioctl2 config: x86_64-allyesconfig (attached as .config) compiler: gcc-8 (Debian 8.1.0-3) 8.1.0 reproduce: git checkout eba09b5b3dfb1b79db4428b6f379f68db4b62056 # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: pvr2_queryctrl()+0x365: sibling call from callable instruction with modified stack frame drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: pvr2_v4l2_dev_init()+0x29c: sibling call from callable instruction with modified stack frame drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: pvr2_v4l2_destroy_no_lock()+0xa2: sibling call from callable instruction with modified stack frame drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: pvr2_v4l2_release()+0xa7: sibling call from callable instruction with modified stack frame drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: pvr2_v4l2_open()+0x76: sibling call from callable instruction with modified stack frame drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: pvr2_v4l2_create()+0x70: sibling call from callable instruction with modified stack frame >> drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: >> pvr2_v4l2_dev_init.cold.3()+0x4a: return with modified stack frame --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[ragnatech:media-tree 10/456] drivers/media/platform/davinci/vpbe.o: warning: objtool: vpbe_probe()+0x2b: sibling call from callable instruction with modified stack frame
tree: git://git.ragnatech.se/linux media-tree head: a00031c159748f322f771f3c1d5ed944cba4bd30 commit: 05c90900e24be491102a6018e242ee7ca602918b [10/456] media: davinci: allow build vpbe_display with COMPILE_TEST config: x86_64-allyesconfig (attached as .config) compiler: gcc-8 (Debian 8.1.0-3) 8.1.0 reproduce: git checkout 05c90900e24be491102a6018e242ee7ca602918b # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): >> drivers/media/platform/davinci/vpbe.o: warning: objtool: vpbe_probe()+0x2b: >> sibling call from callable instruction with modified stack frame >> drivers/media/platform/davinci/vpbe.o: warning: objtool: >> vpbe_initialize()+0x21: sibling call from callable instruction with modified >> stack frame >> drivers/media/platform/davinci/vpbe.o: warning: objtool: >> vpbe_initialize.cold.7()+0x703: stack state mismatch: reg1[13]=-1+0 >> reg2[13]=-2+32 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[ragnatech:media-tree] BUILD SUCCESS a00031c159748f322f771f3c1d5ed944cba4bd30
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: a00031c159748f322f771f3c1d5ed944cba4bd30 media: ddbridge: conditionally enable fast TS for stv0910-equipped bridges elapsed time: 31m configs tested: 107 The following configs have been built successfully. More configs may be tested in the coming days. alpha defconfig pariscallnoconfig parisc b180_defconfig pariscc3000_defconfig parisc defconfig i386 tinyconfig i386 randconfig-x012-201821 i386 randconfig-x017-201821 i386 randconfig-x014-201821 i386 randconfig-x016-201821 i386 randconfig-x018-201821 i386 randconfig-x013-201821 i386 randconfig-x011-201821 i386 randconfig-x015-201821 i386 randconfig-x019-201821 i386 randconfig-x010-201821 x86_64 randconfig-x003-201821 x86_64 randconfig-x007-201821 x86_64 randconfig-x000-201821 x86_64 randconfig-x005-201821 x86_64 randconfig-x004-201821 x86_64 randconfig-x001-201821 x86_64 randconfig-x008-201821 x86_64 randconfig-x002-201821 x86_64 randconfig-x006-201821 x86_64 randconfig-x009-201821 i386 randconfig-i0-201821 i386 randconfig-i1-201821 i386 allmodconfig x86_64 randconfig-x011-201821 x86_64 randconfig-x015-201821 x86_64 randconfig-x018-201821 x86_64 randconfig-x010-201821 x86_64 randconfig-x019-201821 x86_64 randconfig-x014-201821 x86_64 randconfig-x013-201821 x86_64 randconfig-x016-201821 x86_64 randconfig-x017-201821 x86_64 randconfig-x012-201821 ia64 alldefconfig ia64 allnoconfig ia64defconfig i386 randconfig-a0-201821 i386 randconfig-a1-201821 armmini2440_defconfig m68k bvme6000_defconfig powerpc g5_defconfig powerpc mpc832x_mds_defconfig m68k m5475evb_defconfig m68k multi_defconfig m68k sun3_defconfig i386 randconfig-s0-201821 i386 randconfig-s1-201821 openriscor1ksim_defconfig um i386_defconfig um x86_64_defconfig x86_64 randconfig-i0-201821 sparc defconfig sparc64 allnoconfig sparc64 defconfig x86_64 randconfig-u0-05290433 i386 randconfig-x078-201821 i386 randconfig-x079-201821 i386 randconfig-x070-201821 i386 randconfig-x075-201821 i386 randconfig-x076-201821 i386 randconfig-x074-201821 i386 randconfig-x071-201821 i386 randconfig-x073-201821 i386 randconfig-x077-201821 i386 randconfig-x072-201821 i386 randconfig-x008-201821 i386 randconfig-x009-201821 i386 randconfig-x005-201821 i386 randconfig-x000-201821 i386 randconfig-x003-201821 i386 randconfig-x001-201821 i386 randconfig-x004-201821 i386 randconfig-x006-201821 i386 randconfig-x002-201821 i386 randconfig-x007-201821 mips 32r2_defconfig mips 64r6el_defconfig mips allnoconfig mips fuloong2e_defconfig mips jz4740 mips malta_kvm_defconfig mips txx9 powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig s390default_defconfig microblaze mmu_defconfig microblazenommu_defconfig arm allnoconfig arm at91_dt_defconfig arm efm32_defconfig arm exynos_defconfig armmulti_v5_defconfig armmulti_v7_defconfig armshmobile_defconfig arm
[ragnatech:media-tree 167/415] drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:45:6: error: implicit declaration of function 'omapdss_device_is_connected'; did you mean 'pci_device_is_prese
tree: git://git.ragnatech.se/linux media-tree head: e646e17713eeb3b6484b6d7a24ce34854123fa39 commit: 771f7be87ff921e9a3d744febd606af39a150e14 [167/415] media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP config: s390-allmodconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 771f7be87ff921e9a3d744febd606af39a150e14 # save the attached .config to linux build tree make.cross ARCH=s390 Note: the ragnatech/media-tree HEAD e646e17713eeb3b6484b6d7a24ce34854123fa39 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_connect': >> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:45:6: error: >> implicit declaration of function 'omapdss_device_is_connected'; did you mean >> 'pci_device_is_present'? [-Werror=implicit-function-declaration] if (omapdss_device_is_connected(dssdev)) ^~~ pci_device_is_present drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_enable': >> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:91:6: error: >> implicit declaration of function 'omapdss_device_is_enabled'; did you mean >> 'pci_dev_msi_enabled'? [-Werror=implicit-function-declaration] if (omapdss_device_is_enabled(dssdev)) ^ pci_dev_msi_enabled drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_probe': drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration] in = omapdss_of_find_source_for_first_ep(node); ^~~ drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion] in = omapdss_of_find_source_for_first_ep(node); ^ drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:225:6: error: implicit declaration of function 'omapdss_register_output'; did you mean 'omap_dispc_register_isr'? [-Werror=implicit-function-declaration] r = omapdss_register_output(dssdev); ^~~ omap_dispc_register_isr drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_remove': drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:243:2: error: implicit declaration of function 'omapdss_unregister_output'; did you mean 'omap_dispc_unregister_isr'? [-Werror=implicit-function-declaration] omapdss_unregister_output(>dssdev); ^ omap_dispc_unregister_isr cc1: some warnings being treated as errors -- drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_connect': >> drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:39:6: error: >> implicit declaration of function 'omapdss_device_is_connected'; did you mean >> 'pci_device_is_present'? [-Werror=implicit-function-declaration] if (omapdss_device_is_connected(dssdev)) ^~~ pci_device_is_present drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_enable': >> drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:81:6: error: >> implicit declaration of function 'omapdss_device_is_enabled'; did you mean >> 'pci_dev_msi_enabled'? [-Werror=implicit-function-declaration] if (omapdss_device_is_enabled(dssdev)) ^ pci_dev_msi_enabled drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_probe_of': drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:184:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration] in = omapdss_of_find_source_for_first_ep(node); ^~~ drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:184:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion] in = omapdss_of_find_source_for_first_ep(node); ^ drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_probe': drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:233:6: error: implicit declaration of function 'omapdss_register_output'; did you mean 'omap_dispc_register_isr'? [-Werror=implicit-function-declaration] r = omapdss_register_output(dssdev); ^~~ omap_dispc_register_isr drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function
[ragnatech:media-tree 247/415] drivers/i2c/Kconfig:61: symbol I2C_MUX is selected by VIDEO_CX231XX
tree: git://git.ragnatech.se/linux media-tree head: e646e17713eeb3b6484b6d7a24ce34854123fa39 commit: 7b5e3da52a3058e981c8f9331cea8efea25312d6 [247/415] media: cx231xx: Add I2C_MUX dependency config: sparc-defconfig (attached as .config) compiler: sparc-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 7b5e3da52a3058e981c8f9331cea8efea25312d6 # save the attached .config to linux build tree make.cross ARCH=sparc Note: the ragnatech/media-tree HEAD e646e17713eeb3b6484b6d7a24ce34854123fa39 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): >> drivers/i2c/Kconfig:61:error: recursive dependency detected! >> drivers/i2c/Kconfig:61: symbol I2C_MUX is selected by VIDEO_CX231XX >> drivers/media/usb/cx231xx/Kconfig:1: symbol VIDEO_CX231XX depends on I2C_MUX For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" vim +61 drivers/i2c/Kconfig 16538e6b Jan Engelhardt 2007-05-01 37 9c1600ed David Brownell 2007-05-01 38 config I2C_BOARDINFO 6341e62b Christoph Jaeger 2014-12-20 39bool 9c1600ed David Brownell 2007-05-01 40default y 9c1600ed David Brownell 2007-05-01 41 2bb5095a Jean Delvare 2009-09-18 42 config I2C_COMPAT 6341e62b Christoph Jaeger 2014-12-20 43bool "Enable compatibility bits for old user-space" 2bb5095a Jean Delvare 2009-09-18 44default y 2bb5095a Jean Delvare 2009-09-18 45help 2bb5095a Jean Delvare 2009-09-18 46 Say Y here if you intend to run lm-sensors 3.1.1 or older, or any 2bb5095a Jean Delvare 2009-09-18 47 other user-space package which expects i2c adapters to be class 2bb5095a Jean Delvare 2009-09-18 48 devices. If you don't know, say Y. 2bb5095a Jean Delvare 2009-09-18 49 ^1da177e Linus Torvalds 2005-04-16 50 config I2C_CHARDEV ^1da177e Linus Torvalds 2005-04-16 51tristate "I2C device interface" ^1da177e Linus Torvalds 2005-04-16 52help ^1da177e Linus Torvalds 2005-04-16 53 Say Y here to use i2c-* device files, usually found in the /dev ^1da177e Linus Torvalds 2005-04-16 54 directory on your system. They make it possible to have user-space ^1da177e Linus Torvalds 2005-04-16 55 programs use the I2C bus. Information on how to do this is ^1da177e Linus Torvalds 2005-04-16 56 contained in the file . ^1da177e Linus Torvalds 2005-04-16 57 ^1da177e Linus Torvalds 2005-04-16 58 This support is also available as a module. If so, the module ^1da177e Linus Torvalds 2005-04-16 59 will be called i2c-dev. ^1da177e Linus Torvalds 2005-04-16 60 0826374b Michael Lawnick 2010-08-11 @61 config I2C_MUX 0826374b Michael Lawnick 2010-08-11 62tristate "I2C bus multiplexing support" 0826374b Michael Lawnick 2010-08-11 63help 0826374b Michael Lawnick 2010-08-11 64 Say Y here if you want the I2C core to support the ability to 0826374b Michael Lawnick 2010-08-11 65 handle multiplexed I2C bus topologies, by presenting each 0826374b Michael Lawnick 2010-08-11 66 multiplexed segment as a I2C adapter. 0826374b Michael Lawnick 2010-08-11 67 0826374b Michael Lawnick 2010-08-11 68 This support is also available as a module. If so, the module 0826374b Michael Lawnick 2010-08-11 69 will be called i2c-mux. 0826374b Michael Lawnick 2010-08-11 70 :: The code at line 61 was first introduced by commit :: 0826374bff57411d239f2fcb15da3c35af0a93cd i2c: Multiplexed I2C bus core support :: TO: Michael Lawnick:: CC: Jean Delvare --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2] media: imx319: Add imx319 camera sensor driver
Hi Bingbu, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20180517] [also build test WARNING on v4.17-rc6] [cannot apply to linuxtv-media/master linus/master v4.17-rc6 v4.17-rc5 v4.17-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-imx319-Add-imx319-camera-sensor-driver/20180522-020817 coccinelle warnings: (new ones prefixed by >>) >> drivers/media/i2c/imx319.c:1874:2-3: Unneeded semicolon drivers/media/i2c/imx319.c:1917:2-3: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] media: imx319: fix semicolon.cocci warnings
From: kbuild test robot <fengguang...@intel.com> drivers/media/i2c/imx319.c:1874:2-3: Unneeded semicolon drivers/media/i2c/imx319.c:1917:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 6ee66fafab37 ("media: imx319: Add imx319 camera sensor driver") CC: Bingbu Cao <bingbu@intel.com> Signed-off-by: kbuild test robot <fengguang...@intel.com> --- imx319.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/media/i2c/imx319.c +++ b/drivers/media/i2c/imx319.c @@ -1871,7 +1871,7 @@ static int imx319_set_ctrl(struct v4l2_c imx319->exposure->minimum, max, imx319->exposure->step, max); break; - }; + } /* * Applying V4L2 control value only happens @@ -1914,7 +1914,7 @@ static int imx319_set_ctrl(struct v4l2_c "ctrl(id:0x%x,val:0x%x) is not handled\n", ctrl->id, ctrl->val); break; - }; + } pm_runtime_put(>dev);
Re: [PATCH] media: imx319: Add imx319 camera sensor driver
Hi Bingbu, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc5 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-imx319-Add-imx319-camera-sensor-driver/20180519-213616 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/media/i2c/imx319.c:219:24: sparse: symbol 'imx319_global_setting' >> was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[RFC PATCH] media: imx319: imx319_global_setting can be static
Fixes: aa51064f24f3 ("media: imx319: Add imx319 camera sensor driver") Signed-off-by: kbuild test robot <fengguang...@intel.com> --- imx319.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx319.c b/drivers/media/i2c/imx319.c index e6a918e..44a9bda 100644 --- a/drivers/media/i2c/imx319.c +++ b/drivers/media/i2c/imx319.c @@ -216,7 +216,7 @@ static const struct imx319_reg imx319_global_regs[] = { { 0xf2d9, 0x02 }, }; -struct imx319_reg_list imx319_global_setting = { +static struct imx319_reg_list imx319_global_setting = { .num_of_regs = ARRAY_SIZE(imx319_global_regs), .regs = imx319_global_regs, };
[ragnatech:media-tree] BUILD SUCCESS 8ed8bba70b4355b1ba029b151ade84475dd12991
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 8ed8bba70b4355b1ba029b151ade84475dd12991 media: imx274: remove non-indexed pointers from mode_table elapsed time: 1273m configs tested: 359 The following configs have been built successfully. More configs may be tested in the coming days. powerpc makalu_defconfig xtensa iss_defconfig arm axm55xx_defconfig m68k alldefconfig ia64 allnoconfig umallnoconfig m68k allmodconfig powerpc storcenter_defconfig arm lpd270_defconfig openrisc allnoconfig arm iop32x_defconfig arm spear13xx_defconfig powerpc64alldefconfig arm aspeed_g4_defconfig parisc defconfig microblazenommu_defconfig xtensageneric_kc705_defconfig powerpc mpc5200_defconfig sh apsh4a3a_defconfig powerpc tqm8xx_defconfig sh landisk_defconfig x86_64 randconfig-a0-05181009 x86_64 randconfig-a0-05181107 x86_64 randconfig-a0-05181147 x86_64 randconfig-a0-05181225 x86_64 randconfig-a0-05181250 x86_64 randconfig-a0-05181322 x86_64 randconfig-a0-05181425 x86_64 acpi-redef x86_64 allyesdebian x86_64nfsroot m68k hp300_defconfig mips bmips_be_defconfig powerpc ps3_defconfig s390 allnoconfig arm davinci_all_defconfig sh microdev_defconfig powerpc mpc8315_rdb_defconfig powerpcmvme5100_defconfig armspear3xx_defconfig pariscallnoconfig mipsnlm_xlr_defconfig sh se7780_defconfig parisc a500_defconfig powerpc acadia_defconfig m68k allyesconfig mipsmalta_qemu_32r6_defconfig i386 randconfig-c0-05181104 i386 randconfig-c0-05181219 i386 randconfig-c0-05181303 i386 randconfig-c0-05181349 i386 randconfig-c0-05181425 i386 randconfig-c0-05181512 arm h5000_defconfig armmini2440_defconfig mips tb0219_defconfig sh se7343_defconfig shsh7785lcr_defconfig xtensa common_defconfig m68k allnoconfig arm shannon_defconfig sh urquell_defconfig arm64allyesconfig mipsqi_lb60_defconfig x86_64randconfig-in0-05181216 x86_64randconfig-in0-05181315 x86_64randconfig-in0-05181403 i386 randconfig-x010-201819 i386 randconfig-x011-201819 i386 randconfig-x012-201819 i386 randconfig-x013-201819 i386 randconfig-x014-201819 i386 randconfig-x015-201819 i386 randconfig-x016-201819 i386 randconfig-x017-201819 i386 randconfig-x018-201819 i386 randconfig-x019-201819 x86_64 fedora-25 x86_64lkp x86_64 rhel x86_64 rhel-7.2 microblaze mmu_defconfig i386 randconfig-n0-201819 ia64 alldefconfig ia64defconfig powerpc allnoconfig powerpc defconfig powerpc ppc64_defconfig s390default_defconfig i386 randconfig-i0-201819 i386 randconfig-i1-201819 arm pxa910_defconfig sh r7785rp_defconfig arm pxa168_defconfig arm s5pv210_defconfig arm iop33x_defconfig sh r7780mp_defconfig arm simpad_defconfig powerpc mpc85xx_basic_defconfig i386 allnoconfig x86_64 randconfig-v0-05181209 x86_64
htmldocs: include/net/mac80211.h:950: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info'
Hi Mauro, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3acf4e395260e3bd30a6fa29ba7eada4bf7566ca commit: d404d57955a6f67365423f9d0b89ad1881799087 docs: kernel-doc: fix parsing of arrays date: 7 weeks ago reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/crypto.h:477: warning: Function parameter or member 'cra_u.ablkcipher' not described in 'crypto_alg' include/linux/crypto.h:477: warning: Function parameter or member 'cra_u.blkcipher' not described in 'crypto_alg' include/linux/crypto.h:477: warning: Function parameter or member 'cra_u.cipher' not described in 'crypto_alg' include/linux/crypto.h:477: warning: Function parameter or member 'cra_u.compress' not described in 'crypto_alg' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4129: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2259: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2259: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' >> include/net/mac80211.h:950: warning: Function parameter or member >> 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' >> include/net/mac80211.h:950: warning: Function parameter or member >> 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:950: warning: Function parameter or member 'driver_rates'
Re: [Intel-gfx] [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver
Hi Neil, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17-rc5 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/Add-ChromeOS-EC-CEC-Support/20180516-180519 base: git://linuxtv.org/media_tree.git master config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=m68k All errors (new ones prefixed by >>): drivers/media//platform/cros-ec-cec/cros-ec-cec.c: In function 'cros_ec_cec_get_notifier': >> drivers/media//platform/cros-ec-cec/cros-ec-cec.c:231:33: error: >> 'pci_bus_type' undeclared (first use in this function); did you mean >> 'pci_pcie_type'? d = bus_find_device_by_name(_bus_type, NULL, ^~~~ pci_pcie_type drivers/media//platform/cros-ec-cec/cros-ec-cec.c:231:33: note: each undeclared identifier is reported only once for each function it appears in vim +231 drivers/media//platform/cros-ec-cec/cros-ec-cec.c 217 218 static int cros_ec_cec_get_notifier(struct device *dev, 219 struct cec_notifier **notify) 220 { 221 int i; 222 223 for (i = 0 ; i < ARRAY_SIZE(cec_dmi_match_table) ; ++i) { 224 const struct cec_dmi_match *m = _dmi_match_table[i]; 225 226 if (dmi_match(DMI_SYS_VENDOR, m->sys_vendor) && 227 dmi_match(DMI_PRODUCT_NAME, m->product_name)) { 228 struct device *d; 229 230 /* Find the device, bail out if not yet registered */ > 231 d = bus_find_device_by_name(_bus_type, NULL, 232 m->devname); 233 if (!d) 234 return -EPROBE_DEFER; 235 236 *notify = cec_notifier_get_conn(d, m->conn); 237 return 0; 238 } 239 } 240 241 /* Hardware support must be added in the cec_dmi_match_table */ 242 dev_warn(dev, "CEC notifier not configured for this hardware\n"); 243 244 return -ENODEV; 245 } 246 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[linux-next:master 875/8111] drivers/media//platform/fsl-viu.c:41:0: warning: "out_be32" redefined
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: fbbe3b8c2c9c5f84caf668703c26154cb4fbb9d1 commit: 29d750686331a1a9ceeb97e81d3770f57bed5f72 [875/8111] media: fsl-viu: allow building it with COMPILE_TEST config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 29d750686331a1a9ceeb97e81d3770f57bed5f72 # save the attached .config to linux build tree make.cross ARCH=m68k All warnings (new ones prefixed by >>): >> drivers/media//platform/fsl-viu.c:41:0: warning: "out_be32" redefined #define out_be32(v, a) iowrite32be(a, (void __iomem *)v) In file included from arch/m68k/include/asm/io_mm.h:27:0, from arch/m68k/include/asm/io.h:5, from include/linux/io.h:25, from drivers/media//platform/fsl-viu.c:23: arch/m68k/include/asm/raw_io.h:46:0: note: this is the location of the previous definition #define out_be32(addr,l) (void)((*(__force volatile u32 *) (addr)) = (l)) >> drivers/media//platform/fsl-viu.c:42:0: warning: "in_be32" redefined #define in_be32(a) ioread32be((void __iomem *)a) In file included from arch/m68k/include/asm/io_mm.h:27:0, from arch/m68k/include/asm/io.h:5, from include/linux/io.h:25, from drivers/media//platform/fsl-viu.c:23: arch/m68k/include/asm/raw_io.h:37:0: note: this is the location of the previous definition #define in_be32(addr) \ vim +/out_be32 +41 drivers/media//platform/fsl-viu.c > 23 #include 24 #include 25 #include 26 #include 27 #include 28 #include 29 #include 30 #include 31 #include 32 #include 33 #include 34 #include 35 36 #define DRV_NAME"fsl_viu" 37 #define VIU_VERSION "0.5.1" 38 39 /* Allow building this driver with COMPILE_TEST */ 40 #ifndef CONFIG_PPC > 41 #define out_be32(v, a) iowrite32be(a, (void __iomem *)v) > 42 #define in_be32(a) ioread32be((void __iomem *)a) 43 #endif 44 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[ragnatech:media-tree 13/389] drivers/video/fbdev//omap2/omapfb/dss/dispc.c:1859:2: warning: this 'else' clause does not guard...
tree: git://git.ragnatech.se/linux media-tree head: 7e6b6b945272c20f6b78d319e07f27897a8373c9 commit: 7378f1149884b183631c6c16c0f1c62bcd7d759d [13/389] media: omap2: omapfb: allow building it with COMPILE_TEST config: mips-allyesconfig (attached as .config) compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 7378f1149884b183631c6c16c0f1c62bcd7d759d # save the attached .config to linux build tree make.cross ARCH=mips All warnings (new ones prefixed by >>): drivers/video/fbdev//omap2/omapfb/dss/dispc.c: In function 'pixinc': >> drivers/video/fbdev//omap2/omapfb/dss/dispc.c:1859:2: warning: this 'else' >> clause does not guard... [-Wmisleading-indentation] else ^~~~ drivers/video/fbdev//omap2/omapfb/dss/dispc.c:1861:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else' return 0; ^~ vim +/else +1859 drivers/video/fbdev//omap2/omapfb/dss/dispc.c f76ee892 Tomi Valkeinen 2015-12-09 1850 f76ee892 Tomi Valkeinen 2015-12-09 1851 static s32 pixinc(int pixels, u8 ps) f76ee892 Tomi Valkeinen 2015-12-09 1852 { f76ee892 Tomi Valkeinen 2015-12-09 1853if (pixels == 1) f76ee892 Tomi Valkeinen 2015-12-09 1854return 1; f76ee892 Tomi Valkeinen 2015-12-09 1855else if (pixels > 1) f76ee892 Tomi Valkeinen 2015-12-09 1856return 1 + (pixels - 1) * ps; f76ee892 Tomi Valkeinen 2015-12-09 1857else if (pixels < 0) f76ee892 Tomi Valkeinen 2015-12-09 1858return 1 - (-pixels + 1) * ps; f76ee892 Tomi Valkeinen 2015-12-09 @1859else f76ee892 Tomi Valkeinen 2015-12-09 1860BUG(); f76ee892 Tomi Valkeinen 2015-12-09 1861return 0; f76ee892 Tomi Valkeinen 2015-12-09 1862 } f76ee892 Tomi Valkeinen 2015-12-09 1863 :: The code at line 1859 was first introduced by commit :: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays for omapfb :: TO: Tomi Valkeinen:: CC: Tomi Valkeinen --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v3 08/14] media: v4l: Add definitions for MPEG2 frame format and header metadata
Hi Florent, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc5 next-20180516] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Paul-Kocialkowski/Sunxi-Cedrus-driver-for-the-Allwinner-Video-Engine-using-media-requests/20180508-004955 base: git://linuxtv.org/media_tree.git master config: x86_64-acpi-redef (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): >> ./usr/include/linux/v4l2-controls.h:1082: found __[us]{8,16,32,64} type >> without #include --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [Intel-gfx] [PATCH 5/5] media: platform: Add Chrome OS EC CEC driver
Hi Neil, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17-rc5 next-20180515] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/Add-ChromeOS-EC-CEC-Support/20180516-053811 base: git://linuxtv.org/media_tree.git master config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sh All errors (new ones prefixed by >>): drivers/media/platform/cros-ec-cec/cros-ec-cec.c: In function 'cros_ec_cec_get_notifier': >> drivers/media/platform/cros-ec-cec/cros-ec-cec.c:232:33: error: >> 'pci_bus_type' undeclared (first use in this function); did you mean >> 'pci_pcie_type'? d = bus_find_device_by_name(_bus_type, NULL, ^~~~ pci_pcie_type drivers/media/platform/cros-ec-cec/cros-ec-cec.c:232:33: note: each undeclared identifier is reported only once for each function it appears in vim +232 drivers/media/platform/cros-ec-cec/cros-ec-cec.c 218 219 static int cros_ec_cec_get_notifier(struct device *dev, 220 struct cec_notifier **notify) 221 { 222 int i; 223 224 for (i = 0 ; i < ARRAY_SIZE(cec_dmi_match_table) ; ++i) { 225 const struct cec_dmi_match *m = _dmi_match_table[i]; 226 227 if (dmi_match(DMI_SYS_VENDOR, m->sys_vendor) && 228 dmi_match(DMI_PRODUCT_NAME, m->product_name)) { 229 struct device *d; 230 231 /* Find the device, bail out if not yet registered */ > 232 d = bus_find_device_by_name(_bus_type, NULL, 233 m->devname); 234 if (!d) 235 return -EPROBE_DEFER; 236 237 *notify = cec_notifier_get_conn(d, m->conn); 238 return 0; 239 } 240 } 241 242 /* Hardware support must be added in the cec_dmi_match_table */ 243 dev_warn(dev, "CEC notifier not configured for this hardware\n"); 244 245 return -ENODEV; 246 } 247 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] media: helene: add I2C device probe function
Hi Katsuhiro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc5 next-20180514] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Katsuhiro-Suzuki/media-helene-add-I2C-device-probe-function/20180515-134502 base: git://linuxtv.org/media_tree.git master reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > net/mac80211/sta_info.h:586: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' kernel/sched/fair.c:3731: warning: Function parameter or member 'flags' not described in 'attach_entity_load_avg' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array' include/linux/gpio/driver.h:142: warning: Function parameter or member 'request_key' not described in 'gpio_irq_chip' include/linux/iio/iio.h:270: warning: Function parameter or member 'scan_type.sign' not described in 'iio_chan_spec' include/linux/iio/iio.h:270: warning: Function
Re: [PATCH] media: dvb-frontends: add Socionext SC1501A ISDB-S/T demodulator driver
Hi Katsuhiro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17-rc5 next-20180514] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Katsuhiro-Suzuki/media-dvb-frontends-add-Socionext-SC1501A-ISDB-S-T-demodulator-driver/20180515-091453 base: git://linuxtv.org/media_tree.git master config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/media/dvb-frontends/sc1501a.o: In function `sc1501a_set_frontend': >> sc1501a.c:(.text+0xbe0): undefined reference to `__divdi3' sc1501a.c:(.text+0xc01): undefined reference to `__divdi3' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] media: dvb-frontends: add Socionext SC1501A ISDB-S/T demodulator driver
Hi Katsuhiro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc5 next-20180514] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Katsuhiro-Suzuki/media-dvb-frontends-add-Socionext-SC1501A-ISDB-S-T-demodulator-driver/20180515-091453 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/media/dvb-frontends/sc1501a.c:313:47: sparse: constant 211243671486 >> is so big it is long vim +313 drivers/media/dvb-frontends/sc1501a.c 258 259 static int sc1501a_s_read_status(struct sc1501a_priv *chip, 260 struct dtv_frontend_properties *c, 261 enum fe_status *status) 262 { 263 struct regmap *r_s = chip->regmap_s; 264 u32 cpmon, tmpu, tmpl, flg; 265 u64 tmp; 266 267 /* Sync detection */ 268 regmap_read(r_s, CPMON1_S, ); 269 270 *status = 0; 271 if (cpmon & CPMON1_S_FSYNC) 272 *status |= FE_HAS_VITERBI | FE_HAS_SYNC | FE_HAS_LOCK; 273 if (cpmon & CPMON1_S_W2LOCK) 274 *status |= FE_HAS_SIGNAL | FE_HAS_CARRIER; 275 276 /* Signal strength */ 277 c->strength.stat[0].scale = FE_SCALE_NOT_AVAILABLE; 278 279 if (*status & FE_HAS_SIGNAL) { 280 u32 agc; 281 282 regmap_read(r_s, AGCREAD_S, ); 283 agc = tmpu << 8; 284 285 c->strength.len = 1; 286 c->strength.stat[0].scale = FE_SCALE_RELATIVE; 287 c->strength.stat[0].uvalue = agc; 288 } 289 290 /* C/N rate */ 291 c->cnr.stat[0].scale = FE_SCALE_NOT_AVAILABLE; 292 293 if (*status & FE_HAS_VITERBI) { 294 u32 cnr = 0, x, y, d; 295 u64 d_3 = 0; 296 297 regmap_read(r_s, CNRDXU_S, ); 298 regmap_read(r_s, CNRDXL_S, ); 299 x = (tmpu << 8) | tmpl; 300 regmap_read(r_s, CNRDYU_S, ); 301 regmap_read(r_s, CNRDYL_S, ); 302 y = (tmpu << 8) | tmpl; 303 304 /* CNR[dB]: 10 * log10(D) - 30.74 / D^3 - 3 */ 305 /* D = x^2 / (2^15 * y - x^2) */ 306 d = (y << 15) - x * x; 307 if (d > 0) { 308 /* (2^4 * D)^3 = 2^12 * D^3 */ 309 /* 3.074 * 2^(12 + 24) = 211243671486 */ 310 d_3 = div_u64(16 * x * x, d); 311 d_3 = d_3 * d_3 * d_3; 312 if (d_3) > 313 d_3 = div_u64(211243671486, d_3); 314 } 315 316 if (d_3) { 317 /* 0.3 * 2^24 = 5033164 */ 318 tmp = (s64)2 * intlog10(x) - intlog10(abs(d)) - d_3 319 - 5033164; 320 cnr = div_u64(tmp * 1, 1 << 24); 321 } 322 323 if (cnr) { 324 c->cnr.len = 1; 325 c->cnr.stat[0].scale = FE_SCALE_DECIBEL; 326 c->cnr.stat[0].uvalue = cnr; 327 } 328 } 329 330 /* BER */ 331 c->post_bit_error.stat[0].scale = FE_SCALE_NOT_AVAILABLE; 332 c->post_bit_count.stat[0].scale = FE_SCALE_NOT_AVAILABLE; 333 334 regmap_read(r_s, BERCNFLG_S, ); 335 336 if ((*status & FE_HAS_VITERBI) && (flg & BERCNFLG_S_BERVRDY)) { 337 u32 bit_err, bit_cnt; 338 339 regmap_read(r_s, BERVRDU_S, ); 340 regmap_read(r_s, BERVRDL_S, ); 341 bit_err = (tmpu << 8) | tmpl; 342 bit_cnt = (1 << 13) * 204; 343 344 if (bit_cnt) { 345 c->post_bit_error.len = 1; 346 c->post_bit_error.stat[0].scale = FE_SCALE_COUNTER; 347 c->post_bit_error.stat[0].uvalue = bit_err; 348 c->post_bit_count.len = 1; 349 c->post_bit_count.stat[0].scale = FE_SCALE_COUNTER; 350 c->post_bit_count.stat[0].uvalue = bit_cnt; 351 } 352 } 353 354 return 0; 355 } 356 --- 0-DAY
Re: [PATCH v1 2/4] media: bpf: allow raw IR decoder bpf programs to be used
Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc5] [cannot apply to next-20180514] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sean-Young/media-rc-introduce-BPF_PROG_IR_DECODER/20180515-093234 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> drivers/media/rc/lirc_dev.c:32:10: fatal error: linux/bpf-rcdev.h: No such >> file or directory #include ^~~ compilation terminated. -- >> kernel/bpf/syscall.c:30:10: fatal error: linux/bpf-rcdev.h: No such file or >> directory #include ^~~ compilation terminated. vim +32 drivers/media/rc/lirc_dev.c 31 > 32 #include 33 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v1 3/4] media: rc bpf: move ir_raw_event to uapi
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc5] [cannot apply to next-20180514] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sean-Young/media-rc-introduce-BPF_PROG_IR_DECODER/20180515-093234 config: i386-tinyconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): >> ./usr/include/linux/bpf_rcdev.h:13: found __[us]{8,16,32,64} type without >> #include --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v3 11/14] media: platform: Add Sunxi-Cedrus VPU decoder driver
Hi Paul, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17-rc4 next-20180507] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Paul-Kocialkowski/Sunxi-Cedrus-driver-for-the-Allwinner-Video-Engine-using-media-requests/20180508-004955 base: git://linuxtv.org/media_tree.git master config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All error/warnings (new ones prefixed by >>): >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus.c:205:3: error: 'const >> struct media_device_ops' has no member named 'req_validate' .req_validate = vb2_request_validate, ^~~~ >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus.c:205:18: error: >> 'vb2_request_validate' undeclared here (not in a function); did you mean >> 'vb2_queue_release'? .req_validate = vb2_request_validate, ^~~~ vb2_queue_release >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus.c:206:3: error: 'const >> struct media_device_ops' has no member named 'req_queue' .req_queue = vb2_m2m_request_queue, ^ >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus.c:206:15: error: >> 'vb2_m2m_request_queue' undeclared here (not in a function); did you mean >> 'v4l2_m2m_buf_queue'? .req_queue = vb2_m2m_request_queue, ^ v4l2_m2m_buf_queue >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus.c:206:15: warning: excess >> elements in struct initializer drivers/media//platform/sunxi/cedrus/sunxi_cedrus.c:206:15: note: (near initialization for 'sunxi_cedrus_m2m_media_ops') -- drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c: In function 'sunxi_cedrus_stop_streaming': >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c:437:3: error: >> implicit declaration of function 'v4l2_ctrl_request_complete'; did you mean >> 'v4l2_ctrl_replace'? [-Werror=implicit-function-declaration] v4l2_ctrl_request_complete(vbuf->vb2_buf.req_obj.req, ^~ v4l2_ctrl_replace >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c:437:43: error: >> 'struct vb2_buffer' has no member named 'req_obj' v4l2_ctrl_request_complete(vbuf->vb2_buf.req_obj.req, ^ drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c: In function 'sunxi_cedrus_buf_request_complete': drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c:455:31: error: 'struct vb2_buffer' has no member named 'req_obj' v4l2_ctrl_request_complete(vb->req_obj.req, >hdl); ^~ drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c: At top level: >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c:464:3: error: >> 'struct vb2_ops' has no member named 'buf_request_complete' .buf_request_complete = sunxi_cedrus_buf_request_complete, ^~~~ >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c:464:26: warning: >> excess elements in struct initializer .buf_request_complete = sunxi_cedrus_buf_request_complete, ^ drivers/media//platform/sunxi/cedrus/sunxi_cedrus_video.c:464:26: note: (near initialization for 'sunxi_cedrus_qops') cc1: some warnings being treated as errors -- drivers/media//platform/sunxi/cedrus/sunxi_cedrus_dec.c: In function 'sunxi_cedrus_device_run': >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus_dec.c:100:28: error: >> 'struct vb2_buffer' has no member named 'req_obj' src_req = run.src->vb2_buf.req_obj.req; ^ drivers/media//platform/sunxi/cedrus/sunxi_cedrus_dec.c:101:28: error: 'struct vb2_buffer' has no member named 'req_obj' dst_req = run.dst->vb2_buf.req_obj.req; ^ >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus_dec.c:104:3: error: >> implicit declaration of function 'v4l2_ctrl_request_setup'; did you mean >> 'v4l2_ctrl_handler_setup'? [-Werror=implicit-function-declaration] v4l2_ctrl_request_setup(src_req, >hdl); ^~~ v4l2_ctrl_handler_setup >> drivers/media//platform/sunxi/cedrus/sunxi_cedrus_dec.c:138:3: error: >> implicit declaration of function 'v4l2_ctrl_request_complete'; did you mean >> 'v4l2_ctrl_replace'? [-Werror=implicit-function-declaration] v4l2_ctrl_request_complete(src_req, >hdl); ^~ v4l2_ctrl_replace cc1: some warnings
[linuxtv-media:master] BUILD REGRESSION 8d718e5376c602dfd41b599dcc2a7b1be07c7b6b
tree/branch: git://linuxtv.org/media_tree.git master branch HEAD: 8d718e5376c602dfd41b599dcc2a7b1be07c7b6b media: frontends: fix ops get_algo()'s return type Regressions in current branch: drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:183:21: error: 'omapdss_default_get_resolution' undeclared here (not in a function); did you mean 'omapdss_get_version'? drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:197:7: error: implicit declaration of function 'omap_dss_find_output'; did you mean 'omap_dss_get_overlay'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:219:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:264:6: error: implicit declaration of function 'omapdss_register_display'; did you mean 'omap_dispc_register_isr'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:282:2: error: implicit declaration of function 'omapdss_unregister_display'; did you mean 'omap_dispc_unregister_isr'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:57:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:91:6: error: implicit declaration of function 'omapdss_device_is_enabled'; did you mean 'movable_node_is_enabled'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:232:20: error: 'omapdss_default_get_resolution' undeclared here (not in a function); did you mean 'omapdss_get_version'? drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:246:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:297:6: error: implicit declaration of function 'omapdss_register_display'; did you mean 'omap_dispc_register_isr'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:319:2: error: implicit declaration of function 'omapdss_unregister_display'; did you mean 'omap_dispc_unregister_isr'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:59:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:89:6: error: implicit declaration of function 'omapdss_device_is_enabled'; did you mean 'movable_node_is_enabled'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:200:21: error: 'omapdss_default_get_resolution' undeclared here (not in a function); did you mean 'omapdss_get_version'? drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:222:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:269:6: error: implicit declaration of function 'omapdss_register_display'; did you mean 'omap_dispc_register_isr'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:287:2: error: implicit declaration of function 'omapdss_unregister_display'; did you mean 'omap_dispc_unregister_isr'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:60:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:94:6: error: implicit declaration of function 'omapdss_device_is_enabled'; did you mean 'movable_node_is_enabled'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:225:6: error: implicit declaration of function 'omapdss_register_output'; did you mean 'omap_dispc_register_isr'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:243:2: error: implicit declaration of function 'omapdss_unregister_output'; did you mean 'omap_dispc_unregister_isr'? [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:45:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration] drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:91:6: error: implicit declaration of function 'omapdss_device_is_enabled'; did you mean 'movable_node_is_enabled'?
[linuxtv-media:master 167/254] drivers/video/fbdev//omap2/omapfb/dss/overlay.c:41:5: error: redefinition of 'omap_dss_get_num_overlays'
tree: git://linuxtv.org/media_tree.git master head: 8d718e5376c602dfd41b599dcc2a7b1be07c7b6b commit: 771f7be87ff921e9a3d744febd606af39a150e14 [167/254] media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 771f7be87ff921e9a3d744febd606af39a150e14 # save the attached .config to linux build tree make.cross ARCH=sh All errors (new ones prefixed by >>): >> drivers/video/fbdev//omap2/omapfb/dss/overlay.c:41:5: error: redefinition of >> 'omap_dss_get_num_overlays' int omap_dss_get_num_overlays(void) ^ In file included from drivers/video/fbdev//omap2/omapfb/dss/overlay.c:33:0: include/video/omapfb_dss.h:900:19: note: previous definition of 'omap_dss_get_num_overlays' was here static inline int omap_dss_get_num_overlays(void) ^ >> drivers/video/fbdev//omap2/omapfb/dss/overlay.c:47:22: error: redefinition >> of 'omap_dss_get_overlay' struct omap_overlay *omap_dss_get_overlay(int num) ^~~~ In file included from drivers/video/fbdev//omap2/omapfb/dss/overlay.c:33:0: include/video/omapfb_dss.h:903:36: note: previous definition of 'omap_dss_get_overlay' was here static inline struct omap_overlay *omap_dss_get_overlay(int num) ^~~~ drivers/video/fbdev//omap2/omapfb/dss/overlay.c: In function 'dss_init_overlays': >> drivers/video/fbdev//omap2/omapfb/dss/overlay.c:60:17: error: implicit >> declaration of function 'dss_feat_get_num_ovls'; did you mean >> 'dss_feat_get_reg_field'? [-Werror=implicit-function-declaration] num_overlays = dss_feat_get_num_ovls(); ^ dss_feat_get_reg_field drivers/video/fbdev//omap2/omapfb/dss/overlay.c:91:4: error: implicit declaration of function 'dss_feat_get_supported_color_modes'; did you mean 'dss_feat_get_supported_outputs'? [-Werror=implicit-function-declaration] dss_feat_get_supported_color_modes(ovl->id); ^~ dss_feat_get_supported_outputs cc1: some warnings being treated as errors -- drivers/video/fbdev//omap2/omapfb/dss/apply.c: In function 'apply_init_priv': >> drivers/video/fbdev//omap2/omapfb/dss/apply.c:141:23: error: implicit >> declaration of function 'dss_feat_get_num_ovls'; did you mean >> 'dss_feat_get_reg_field'? [-Werror=implicit-function-declaration] const int num_ovls = dss_feat_get_num_ovls(); ^ dss_feat_get_reg_field drivers/video/fbdev//omap2/omapfb/dss/apply.c: In function 'need_isr': >> drivers/video/fbdev//omap2/omapfb/dss/apply.c:264:23: error: implicit >> declaration of function 'dss_feat_get_num_mgrs'; did you mean >> 'dss_feat_get_param_max'? [-Werror=implicit-function-declaration] const int num_mgrs = dss_feat_get_num_mgrs(); ^ dss_feat_get_param_max drivers/video/fbdev//omap2/omapfb/dss/apply.c: At top level: drivers/video/fbdev//omap2/omapfb/dss/apply.c:1598:5: error: redefinition of 'omapdss_compat_init' int omapdss_compat_init(void) ^~~ In file included from drivers/video/fbdev//omap2/omapfb/dss/apply.c:26:0: include/video/omapfb_dss.h:889:19: note: previous definition of 'omapdss_compat_init' was here static inline int omapdss_compat_init(void) ^~~ drivers/video/fbdev//omap2/omapfb/dss/apply.c:1682:6: error: redefinition of 'omapdss_compat_uninit' void omapdss_compat_uninit(void) ^ In file included from drivers/video/fbdev//omap2/omapfb/dss/apply.c:26:0: include/video/omapfb_dss.h:892:20: note: previous definition of 'omapdss_compat_uninit' was here static inline void omapdss_compat_uninit(void) {}; ^ cc1: some warnings being treated as errors -- drivers/video/fbdev//omap2/omapfb/dss/dpi.c: In function 'dpi_connect': drivers/video/fbdev//omap2/omapfb/dss/dpi.c:680:6: error: implicit declaration of function 'omapdss_output_set_device'; did you mean 'omap_dss_put_device'? [-Werror=implicit-function-declaration] r = omapdss_output_set_device(dssdev, dst); ^ omap_dss_put_device drivers/video/fbdev//omap2/omapfb/dss/dpi.c: In function 'dpi_disconnect': drivers/video/fbdev//omap2/omapfb/dss/dpi.c:699:2: error: implicit declaration of function 'omapdss_output_unset_device'; did you mean 'omap_dss_get_next_device'?
[linuxtv-media:master 235/238] drivers/media//pci/pt1/pt1.c:1433:5: warning: "CONFIG_PM_SLEEP" is not defined, evaluates to 0
tree: git://linuxtv.org/media_tree.git master head: fbfb3a75bd52249fe6e91b420cf2ae135ad5 commit: 41cb54e20543d436ee6331cd66dd0413a7452804 [235/238] media: dvb: earth-pt1: add support for suspend/resume config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 41cb54e20543d436ee6331cd66dd0413a7452804 # save the attached .config to linux build tree make.cross ARCH=xtensa All warnings (new ones prefixed by >>): >> drivers/media//pci/pt1/pt1.c:1433:5: warning: "CONFIG_PM_SLEEP" is not >> defined, evaluates to 0 [-Wundef] #if CONFIG_PM_SLEEP ^~~ vim +/CONFIG_PM_SLEEP +1433 drivers/media//pci/pt1/pt1.c 1427 1428 static struct pci_driver pt1_driver = { 1429 .name = DRIVER_NAME, 1430 .probe = pt1_probe, 1431 .remove = pt1_remove, 1432 .id_table = pt1_id_table, > 1433 #if CONFIG_PM_SLEEP 1434 .driver.pm = _pm_ops, 1435 #endif 1436 }; 1437 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 9/9] cx231xx: Add I2C_MUX dependency
Hi Brad, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Brad-Love/cx231xx-House-cleaning/20180505-040333 base: git://linuxtv.org/media_tree.git master config: x86_64-lkp (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers/i2c/Kconfig:61:error: recursive dependency detected! >> drivers/i2c/Kconfig:61: symbol I2C_MUX is selected by VIDEO_CX231XX >> drivers/media/usb/cx231xx/Kconfig:1: symbol VIDEO_CX231XX depends on I2C_MUX For a resolution refer to Documentation/kbuild/kconfig-language.txt subsection "Kconfig recursive dependency limitations" vim +61 drivers/i2c/Kconfig 16538e6b Jan Engelhardt 2007-05-01 37 9c1600ed David Brownell 2007-05-01 38 config I2C_BOARDINFO 6341e62b Christoph Jaeger 2014-12-20 39bool 9c1600ed David Brownell 2007-05-01 40default y 9c1600ed David Brownell 2007-05-01 41 2bb5095a Jean Delvare 2009-09-18 42 config I2C_COMPAT 6341e62b Christoph Jaeger 2014-12-20 43bool "Enable compatibility bits for old user-space" 2bb5095a Jean Delvare 2009-09-18 44default y 2bb5095a Jean Delvare 2009-09-18 45help 2bb5095a Jean Delvare 2009-09-18 46 Say Y here if you intend to run lm-sensors 3.1.1 or older, or any 2bb5095a Jean Delvare 2009-09-18 47 other user-space package which expects i2c adapters to be class 2bb5095a Jean Delvare 2009-09-18 48 devices. If you don't know, say Y. 2bb5095a Jean Delvare 2009-09-18 49 ^1da177e Linus Torvalds 2005-04-16 50 config I2C_CHARDEV ^1da177e Linus Torvalds 2005-04-16 51tristate "I2C device interface" ^1da177e Linus Torvalds 2005-04-16 52help ^1da177e Linus Torvalds 2005-04-16 53 Say Y here to use i2c-* device files, usually found in the /dev ^1da177e Linus Torvalds 2005-04-16 54 directory on your system. They make it possible to have user-space ^1da177e Linus Torvalds 2005-04-16 55 programs use the I2C bus. Information on how to do this is ^1da177e Linus Torvalds 2005-04-16 56 contained in the file . ^1da177e Linus Torvalds 2005-04-16 57 ^1da177e Linus Torvalds 2005-04-16 58 This support is also available as a module. If so, the module ^1da177e Linus Torvalds 2005-04-16 59 will be called i2c-dev. ^1da177e Linus Torvalds 2005-04-16 60 0826374b Michael Lawnick 2010-08-11 @61 config I2C_MUX 0826374b Michael Lawnick 2010-08-11 62tristate "I2C bus multiplexing support" 0826374b Michael Lawnick 2010-08-11 63help 0826374b Michael Lawnick 2010-08-11 64 Say Y here if you want the I2C core to support the ability to 0826374b Michael Lawnick 2010-08-11 65 handle multiplexed I2C bus topologies, by presenting each 0826374b Michael Lawnick 2010-08-11 66 multiplexed segment as a I2C adapter. 0826374b Michael Lawnick 2010-08-11 67 0826374b Michael Lawnick 2010-08-11 68 This support is also available as a module. If so, the module 0826374b Michael Lawnick 2010-08-11 69 will be called i2c-mux. 0826374b Michael Lawnick 2010-08-11 70 :: The code at line 61 was first introduced by commit :: 0826374bff57411d239f2fcb15da3c35af0a93cd i2c: Multiplexed I2C bus core support :: TO: Michael Lawnick:: CC: Jean Delvare --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[linuxtv-media:master 167/207] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:319:2: error: implicit declaration of function 'omapdss_unregister_display'
tree: git://linuxtv.org/media_tree.git master head: 53dcd70eb710607b2d4085ca91a433cd9feb7b41 commit: 771f7be87ff921e9a3d744febd606af39a150e14 [167/207] media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 771f7be87ff921e9a3d744febd606af39a150e14 # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections': >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit >> declaration of function 'omapdss_find_mgr_from_display' >> [-Werror=implicit-function-declaration] mgr = omapdss_find_mgr_from_display(def_dssdev); ^ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] mgr = omapdss_find_mgr_from_display(def_dssdev); ^ drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display': >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit >> declaration of function 'omapdss_get_default_display_name' >> [-Werror=implicit-function-declaration] def_name = omapdss_get_default_display_name(); ^~~~ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion] def_name = omapdss_get_default_display_name(); ^ cc1: some warnings being treated as errors -- drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_connect': drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:45:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration] if (omapdss_device_is_connected(dssdev)) ^~~ drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_enable': >> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:91:6: error: >> implicit declaration of function 'omapdss_device_is_enabled' >> [-Werror=implicit-function-declaration] if (omapdss_device_is_enabled(dssdev)) ^ drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_probe': drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration] in = omapdss_of_find_source_for_first_ep(node); ^~~ drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion] in = omapdss_of_find_source_for_first_ep(node); ^ >> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:225:6: error: >> implicit declaration of function 'omapdss_register_output' >> [-Werror=implicit-function-declaration] r = omapdss_register_output(dssdev); ^~~ drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_remove': >> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:243:2: error: >> implicit declaration of function 'omapdss_unregister_output' >> [-Werror=implicit-function-declaration] omapdss_unregister_output(>dssdev); ^ cc1: some warnings being treated as errors -- drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_connect': drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:39:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration] if (omapdss_device_is_connected(dssdev)) ^~~ drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_enable': >> drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:81:6: error: >> implicit declaration of function 'omapdss_device_is_enabled' >> [-Werror=implicit-function-declaration] if (omapdss_device_is_enabled(dssdev)) ^ drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_probe_of': drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:184:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration] in = omapdss_of_find_source_for_first_ep(node); ^~~
[linuxtv-media:master 167/207] drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:44: sparse: call with no type!
tree: git://linuxtv.org/media_tree.git master head: 53dcd70eb710607b2d4085ca91a433cd9feb7b41 commit: 771f7be87ff921e9a3d744febd606af39a150e14 [167/207] media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP reproduce: # apt-get install sparse git checkout 771f7be87ff921e9a3d744febd606af39a150e14 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/video/fbdev/omap2/omapfb/omapfb-main.c:1461:32: sparse: expression using sizeof(void) drivers/video/fbdev/omap2/omapfb/omapfb-main.c:1461:32: sparse: expression using sizeof(void) drivers/video/fbdev/omap2/omapfb/omapfb-main.c:1924:25: sparse: expression using sizeof(void) drivers/video/fbdev/omap2/omapfb/omapfb-main.c:1924:25: sparse: expression using sizeof(void) drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:15: sparse: undefined identifier 'omapdss_find_mgr_from_display' drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:20: sparse: undefined identifier 'omapdss_get_default_display_name' >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:44: sparse: call with no >> type! drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:52: sparse: call with no type! drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections': drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display'; did you mean 'omapfb_init_display'? [-Werror=implicit-function-declaration] mgr = omapdss_find_mgr_from_display(def_dssdev); ^ omapfb_init_display drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] mgr = omapdss_find_mgr_from_display(def_dssdev); ^ drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display': drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name'; did you mean 'omapfb_find_default_display'? [-Werror=implicit-function-declaration] def_name = omapdss_get_default_display_name(); ^~~~ omapfb_find_default_display drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion] def_name = omapdss_get_default_display_name(); ^ cc1: some warnings being treated as errors -- drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:45:13: sparse: undefined identifier 'omapdss_device_is_connected' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:66:9: sparse: undefined identifier 'omapdss_device_is_connected' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:67:14: sparse: undefined identifier 'omapdss_device_is_connected' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:88:14: sparse: undefined identifier 'omapdss_device_is_connected' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:91:13: sparse: undefined identifier 'omapdss_device_is_enabled' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:115:14: sparse: undefined identifier 'omapdss_device_is_enabled' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:14: sparse: undefined identifier 'omapdss_of_find_source_for_first_ep' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:225:13: sparse: undefined identifier 'omapdss_register_output' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:243:9: sparse: undefined identifier 'omapdss_unregister_output' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:245:9: sparse: undefined identifier 'omapdss_device_is_enabled' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:246:13: sparse: undefined identifier 'omapdss_device_is_enabled' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:249:9: sparse: undefined identifier 'omapdss_device_is_connected' drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:250:13: sparse: undefined identifier 'omapdss_device_is_connected' >> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:45:40: sparse: >> call with no type! drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:66:9: sparse: call with no type! drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:67:41: sparse: call with no type! drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:88:41: sparse: call with no type! drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:91:38: sparse: call with no type! drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:115:39: sparse: call with no type! drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:49: sparse: call with no type!
Re: [PATCH v2] saa7164: Fix driver name in debug output
Hi Brad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Brad-Love/saa7164-Fix-driver-name-in-debug-output/20180504-114908 base: git://linuxtv.org/media_tree.git master config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/media/pci/saa7164/saa7164-fw.c: In function 'saa7164_downloadfirmware': >> drivers/media/pci/saa7164/saa7164-fw.c:429:11: warning: format '%ld' expects >> argument of type 'long int', but argument 2 has type 'size_t {aka const >> unsigned int}' [-Wformat=] printk(KERN_ERR "saa7164: firmware incorrect size %ld != %u\n", ^~ fw->size, fwlength); vim +429 drivers/media/pci/saa7164/saa7164-fw.c 195 196 /* TODO: Excessive debug */ 197 /* Load the firmware. Optionally it can be in ROM or newer versions 198 * can be on disk, saving the expense of the ROM hardware. */ 199 int saa7164_downloadfirmware(struct saa7164_dev *dev) 200 { 201 /* u32 second_timeout = 60 * SAA_DEVICE_TIMEOUT; */ 202 u32 tmp, filesize, version, err_flags, first_timeout, fwlength; 203 u32 second_timeout, updatebootloader = 1, bootloadersize = 0; 204 const struct firmware *fw = NULL; 205 struct fw_header *hdr, *boothdr = NULL, *fwhdr; 206 u32 bootloaderversion = 0, fwloadersize; 207 u8 *bootloaderoffset = NULL, *fwloaderoffset; 208 char *fwname; 209 int ret; 210 211 dprintk(DBGLVL_FW, "%s()\n", __func__); 212 213 if (saa7164_boards[dev->board].chiprev == SAA7164_CHIP_REV2) { 214 fwname = SAA7164_REV2_FIRMWARE; 215 fwlength = SAA7164_REV2_FIRMWARE_SIZE; 216 } else { 217 fwname = SAA7164_REV3_FIRMWARE; 218 fwlength = SAA7164_REV3_FIRMWARE_SIZE; 219 } 220 221 version = saa7164_getcurrentfirmwareversion(dev); 222 223 if (version == 0x00) { 224 225 second_timeout = 100; 226 first_timeout = 100; 227 err_flags = saa7164_readl(SAA_BOOTLOADERERROR_FLAGS); 228 dprintk(DBGLVL_FW, "%s() err_flags = %x\n", 229 __func__, err_flags); 230 231 while (err_flags != SAA_DEVICE_IMAGE_BOOTING) { 232 dprintk(DBGLVL_FW, "%s() err_flags = %x\n", 233 __func__, err_flags); 234 msleep(10); /* Checkpatch throws a < 20ms warning */ 235 236 if (err_flags & SAA_DEVICE_IMAGE_CORRUPT) { 237 printk(KERN_ERR "%s() firmware corrupt\n", 238 __func__); 239 break; 240 } 241 if (err_flags & SAA_DEVICE_MEMORY_CORRUPT) { 242 printk(KERN_ERR "%s() device memory corrupt\n", 243 __func__); 244 break; 245 } 246 if (err_flags & SAA_DEVICE_NO_IMAGE) { 247 printk(KERN_ERR "%s() no first image\n", 248 __func__); 249 break; 250 } 251 if (err_flags & SAA_DEVICE_IMAGE_SEARCHING) { 252 first_timeout -= 10; 253 if (first_timeout == 0) { 254 printk(KERN_ERR 255 "%s() no first image\n", 256 __func__); 257 break; 258 } 259 } else if (err_flags & SAA_DEVICE_IMAGE_LOADING) { 260 second_timeout -= 10; 261 if (second_timeout == 0) { 262 printk(KERN_ERR 263 "%s() FW load time exceeded\n", 264 __func__); 265 break; 266 } 267
Re: [PATCH 2/2] media: imx: add support for RGB565_2X8 on parallel bus
Hi Jan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc3 next-20180503] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jan-Luebbe/media-imx-add-capture-support-for-RGB565_2X8-on-parallel-bus/20180504-120003 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) vim +652 drivers/staging/media/imx/imx-media-csi.c 640 641 /* Update the CSI whole sensor and active windows */ 642 static int csi_setup(struct csi_priv *priv) 643 { 644 struct v4l2_mbus_framefmt *infmt, *outfmt; 645 struct v4l2_mbus_config mbus_cfg; 646 struct v4l2_mbus_framefmt if_fmt; 647 struct imx_media_pixfmt *outcc; 648 struct v4l2_rect crop; 649 650 infmt = >format_mbus[CSI_SINK_PAD]; 651 outfmt = >format_mbus[priv->active_output_pad]; > 652 outcc = priv->cc[priv->active_output_pad]; 653 654 /* compose mbus_config from the upstream endpoint */ 655 mbus_cfg.type = priv->upstream_ep.bus_type; 656 mbus_cfg.flags = (priv->upstream_ep.bus_type == V4L2_MBUS_CSI2) ? 657 priv->upstream_ep.bus.mipi_csi2.flags : 658 priv->upstream_ep.bus.parallel.flags; 659 660 /* 661 * we need to pass input frame to CSI interface, but 662 * with translated field type from output format 663 */ 664 if_fmt = *infmt; 665 if_fmt.field = outfmt->field; 666 crop = priv->crop; 667 668 /* 669 * if cycles is set, we need to handle this over multiple cycles as 670 * generic/bayer data 671 */ 672 if ((priv->upstream_ep.bus_type != V4L2_MBUS_CSI2) && outcc->cycles) { 673 if_fmt.width *= outcc->cycles; 674 crop.width *= outcc->cycles; 675 } 676 677 ipu_csi_set_window(priv->csi, ); 678 679 ipu_csi_set_downsize(priv->csi, 680 priv->crop.width == 2 * priv->compose.width, 681 priv->crop.height == 2 * priv->compose.height); 682 683 ipu_csi_init_interface(priv->csi, _cfg, _fmt); 684 685 ipu_csi_set_dest(priv->csi, priv->dest); 686 687 if (priv->dest == IPU_CSI_DEST_IDMAC) 688 ipu_csi_set_skip_smfc(priv->csi, priv->skip->skip_smfc, 689priv->skip->max_ratio - 1, 0); 690 691 ipu_csi_dump(priv->csi); 692 693 return 0; 694 } 695 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 2/2] media: imx: add support for RGB565_2X8 on parallel bus
Hi Jan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc3 next-20180503] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jan-Luebbe/media-imx-add-capture-support-for-RGB565_2X8-on-parallel-bus/20180504-120003 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/staging/media/imx/imx-media-csi.c:443:3-4: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] media: imx: fix semicolon.cocci warnings
From: Fengguang Wudrivers/staging/media/imx/imx-media-csi.c:443:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: ad2cc62e77ef ("media: imx: add support for RGB565_2X8 on parallel bus") CC: Jan Luebbe Signed-off-by: Fengguang Wu --- imx-media-csi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -440,7 +440,7 @@ static int csi_idmac_setup_channel(struc passthrough_bits = 8; passthrough_cycles = 2; break; - }; + } /* fallthrough */ default: burst_size = (image.pix.width & 0xf) ? 8 : 16;
Re: [PATCH v2] saa7164: Fix driver name in debug output
Hi Brad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc3 next-20180503] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Brad-Love/saa7164-Fix-driver-name-in-debug-output/20180504-114908 base: git://linuxtv.org/media_tree.git master config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from ./arch/xtensa/include/generated/asm/bug.h:1, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/gfp.h:5, from include/linux/firmware.h:7, from drivers/media//pci/saa7164/saa7164-fw.c:18: drivers/media//pci/saa7164/saa7164-fw.c: In function 'saa7164_downloadfirmware': >> include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of >> type 'long int', but argument 2 has type 'size_t {aka const unsigned int}' >> [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' #define KERN_ERR KERN_SOH "3" /* error conditions */ ^~~~ drivers/media//pci/saa7164/saa7164-fw.c:429:11: note: in expansion of macro 'KERN_ERR' printk(KERN_ERR "saa7164: firmware incorrect size %ld != %u\n", ^~~~ drivers/media//pci/saa7164/saa7164-fw.c:429:56: note: format string is defined here printk(KERN_ERR "saa7164: firmware incorrect size %ld != %u\n", ~~^ %d -- In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from ./arch/xtensa/include/generated/asm/bug.h:1, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/gfp.h:5, from include/linux/firmware.h:7, from drivers/media/pci/saa7164/saa7164-fw.c:18: drivers/media/pci/saa7164/saa7164-fw.c: In function 'saa7164_downloadfirmware': >> include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of >> type 'long int', but argument 2 has type 'size_t {aka const unsigned int}' >> [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' #define KERN_ERR KERN_SOH "3" /* error conditions */ ^~~~ drivers/media/pci/saa7164/saa7164-fw.c:429:11: note: in expansion of macro 'KERN_ERR' printk(KERN_ERR "saa7164: firmware incorrect size %ld != %u\n", ^~~~ drivers/media/pci/saa7164/saa7164-fw.c:429:56: note: format string is defined here printk(KERN_ERR "saa7164: firmware incorrect size %ld != %u\n", ~~^ %d vim +5 include/linux/kern_levels.h 314ba352 Joe Perches 2012-07-30 4 04d2c8c8 Joe Perches 2012-07-30 @5 #define KERN_SOH"\001" /* ASCII Start Of Header */ 04d2c8c8 Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c8 Joe Perches 2012-07-30 7 :: The code at line 5 was first introduced by commit :: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_ to a 2 byte pattern :: TO: Joe Perches:: CC: Linus Torvalds --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 2/2] media: imx: add support for RGB565_2X8 on parallel bus
Hi Jan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc3 next-20180503] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jan-Luebbe/media-imx-add-capture-support-for-RGB565_2X8-on-parallel-bus/20180504-120003 base: git://linuxtv.org/media_tree.git master config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All warnings (new ones prefixed by >>): drivers/staging/media/imx/imx-media-csi.c: In function 'csi_setup': >> drivers/staging/media/imx/imx-media-csi.c:652:8: warning: assignment >> discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] outcc = priv->cc[priv->active_output_pad]; ^ vim +/const +652 drivers/staging/media/imx/imx-media-csi.c 640 641 /* Update the CSI whole sensor and active windows */ 642 static int csi_setup(struct csi_priv *priv) 643 { 644 struct v4l2_mbus_framefmt *infmt, *outfmt; 645 struct v4l2_mbus_config mbus_cfg; 646 struct v4l2_mbus_framefmt if_fmt; 647 struct imx_media_pixfmt *outcc; 648 struct v4l2_rect crop; 649 650 infmt = >format_mbus[CSI_SINK_PAD]; 651 outfmt = >format_mbus[priv->active_output_pad]; > 652 outcc = priv->cc[priv->active_output_pad]; 653 654 /* compose mbus_config from the upstream endpoint */ 655 mbus_cfg.type = priv->upstream_ep.bus_type; 656 mbus_cfg.flags = (priv->upstream_ep.bus_type == V4L2_MBUS_CSI2) ? 657 priv->upstream_ep.bus.mipi_csi2.flags : 658 priv->upstream_ep.bus.parallel.flags; 659 660 /* 661 * we need to pass input frame to CSI interface, but 662 * with translated field type from output format 663 */ 664 if_fmt = *infmt; 665 if_fmt.field = outfmt->field; 666 crop = priv->crop; 667 668 /* 669 * if cycles is set, we need to handle this over multiple cycles as 670 * generic/bayer data 671 */ 672 if ((priv->upstream_ep.bus_type != V4L2_MBUS_CSI2) && outcc->cycles) { 673 if_fmt.width *= outcc->cycles; 674 crop.width *= outcc->cycles; 675 } 676 677 ipu_csi_set_window(priv->csi, ); 678 679 ipu_csi_set_downsize(priv->csi, 680 priv->crop.width == 2 * priv->compose.width, 681 priv->crop.height == 2 * priv->compose.height); 682 683 ipu_csi_init_interface(priv->csi, _cfg, _fmt); 684 685 ipu_csi_set_dest(priv->csi, priv->dest); 686 687 if (priv->dest == IPU_CSI_DEST_IDMAC) 688 ipu_csi_set_skip_smfc(priv->csi, priv->skip->skip_smfc, 689priv->skip->max_ratio - 1, 0); 690 691 ipu_csi_dump(priv->csi); 692 693 return 0; 694 } 695 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] saa7164: Fix driver name in debug output
Hi Brad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc3 next-20180502] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Brad-Love/saa7164-Fix-driver-name-in-debug-output/20180503-133636 base: git://linuxtv.org/media_tree.git master config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc64 All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from arch/sparc/include/asm/bug.h:25, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/gfp.h:5, from include/linux/firmware.h:7, from drivers/media//pci/saa7164/saa7164-fw.c:18: drivers/media//pci/saa7164/saa7164-fw.c: In function 'saa7164_downloadfirmware': include/linux/kern_levels.h:5:18: warning: format '%d' expects argument of type 'int', but argument 2 has type 'size_t {aka const long unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' #define KERN_ERR KERN_SOH "3" /* error conditions */ ^~~~ >> drivers/media//pci/saa7164/saa7164-fw.c:429:11: note: in expansion of macro >> 'KERN_ERR' printk(KERN_ERR "saa7164: firmware incorrect size %d != %d\n", ^~~~ drivers/media//pci/saa7164/saa7164-fw.c:429:55: note: format string is defined here printk(KERN_ERR "saa7164: firmware incorrect size %d != %d\n", ~^ %ld vim +/KERN_ERR +429 drivers/media//pci/saa7164/saa7164-fw.c 195 196 /* TODO: Excessive debug */ 197 /* Load the firmware. Optionally it can be in ROM or newer versions 198 * can be on disk, saving the expense of the ROM hardware. */ 199 int saa7164_downloadfirmware(struct saa7164_dev *dev) 200 { 201 /* u32 second_timeout = 60 * SAA_DEVICE_TIMEOUT; */ 202 u32 tmp, filesize, version, err_flags, first_timeout, fwlength; 203 u32 second_timeout, updatebootloader = 1, bootloadersize = 0; 204 const struct firmware *fw = NULL; 205 struct fw_header *hdr, *boothdr = NULL, *fwhdr; 206 u32 bootloaderversion = 0, fwloadersize; 207 u8 *bootloaderoffset = NULL, *fwloaderoffset; 208 char *fwname; 209 int ret; 210 211 dprintk(DBGLVL_FW, "%s()\n", __func__); 212 213 if (saa7164_boards[dev->board].chiprev == SAA7164_CHIP_REV2) { 214 fwname = SAA7164_REV2_FIRMWARE; 215 fwlength = SAA7164_REV2_FIRMWARE_SIZE; 216 } else { 217 fwname = SAA7164_REV3_FIRMWARE; 218 fwlength = SAA7164_REV3_FIRMWARE_SIZE; 219 } 220 221 version = saa7164_getcurrentfirmwareversion(dev); 222 223 if (version == 0x00) { 224 225 second_timeout = 100; 226 first_timeout = 100; 227 err_flags = saa7164_readl(SAA_BOOTLOADERERROR_FLAGS); 228 dprintk(DBGLVL_FW, "%s() err_flags = %x\n", 229 __func__, err_flags); 230 231 while (err_flags != SAA_DEVICE_IMAGE_BOOTING) { 232 dprintk(DBGLVL_FW, "%s() err_flags = %x\n", 233 __func__, err_flags); 234 msleep(10); /* Checkpatch throws a < 20ms warning */ 235 236 if (err_flags & SAA_DEVICE_IMAGE_CORRUPT) { 237 printk(KERN_ERR "%s() firmware corrupt\n", 238 __func__); 239 break; 240 } 241 if (err_flags & SAA_DEVICE_MEMORY_CORRUPT) { 242 printk(KERN_ERR "%s() device memory corrupt\n", 243 __func__); 244 break; 245 } 246 if (err_flags & SAA_DEVICE_NO_IMAGE) { 247
[linux-stable-rc:linux-4.4.y 8340/8366] drivers/media//v4l2-core/videobuf2-vmalloc.c:103:20: error: implicit declaration of function '__pfn_to_phys'; did you mean 'dma_to_phys'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y head: a33ce4af3470ca75091b7a05ed6259e938186054 commit: 38b2082959efe95b2aa41c38c6a4f2dcdd6c2df1 [8340/8366] media: vb2: Fix videobuf2 to map correct area config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 38b2082959efe95b2aa41c38c6a4f2dcdd6c2df1 # save the attached .config to linux build tree make.cross ARCH=ia64 All errors (new ones prefixed by >>): drivers/media//v4l2-core/videobuf2-vmalloc.c: In function 'vb2_vmalloc_get_userptr': >> drivers/media//v4l2-core/videobuf2-vmalloc.c:103:20: error: implicit >> declaration of function '__pfn_to_phys'; did you mean 'dma_to_phys'? >> [-Werror=implicit-function-declaration] ioremap_nocache(__pfn_to_phys(nums[0]), size + offset); ^ dma_to_phys cc1: some warnings being treated as errors vim +103 drivers/media//v4l2-core/videobuf2-vmalloc.c 71 72 static void *vb2_vmalloc_get_userptr(void *alloc_ctx, unsigned long vaddr, 73 unsigned long size, 74 enum dma_data_direction dma_dir) 75 { 76 struct vb2_vmalloc_buf *buf; 77 struct frame_vector *vec; 78 int n_pages, offset, i; 79 80 buf = kzalloc(sizeof(*buf), GFP_KERNEL); 81 if (!buf) 82 return NULL; 83 84 buf->dma_dir = dma_dir; 85 offset = vaddr & ~PAGE_MASK; 86 buf->size = size; 87 vec = vb2_create_framevec(vaddr, size, dma_dir == DMA_FROM_DEVICE); 88 if (IS_ERR(vec)) 89 goto fail_pfnvec_create; 90 buf->vec = vec; 91 n_pages = frame_vector_count(vec); 92 if (frame_vector_to_pages(vec) < 0) { 93 unsigned long *nums = frame_vector_pfns(vec); 94 95 /* 96 * We cannot get page pointers for these pfns. Check memory is 97 * physically contiguous and use direct mapping. 98 */ 99 for (i = 1; i < n_pages; i++) 100 if (nums[i-1] + 1 != nums[i]) 101 goto fail_map; 102 buf->vaddr = (__force void *) > 103 ioremap_nocache(__pfn_to_phys(nums[0]), size + > offset); 104 } else { 105 buf->vaddr = vm_map_ram(frame_vector_pages(vec), n_pages, -1, 106 PAGE_KERNEL); 107 } 108 109 if (!buf->vaddr) 110 goto fail_map; 111 buf->vaddr += offset; 112 return buf; 113 114 fail_map: 115 vb2_destroy_framevec(vec); 116 fail_pfnvec_create: 117 kfree(buf); 118 119 return NULL; 120 } 121 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] media: vb2: Print the queue pointer in debug messages
Hi Laurent, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Laurent-Pinchart/media-vb2-Print-the-queue-pointer-in-debug-messages/20180428-184113 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-a1-201816 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/media/common/videobuf2/videobuf2-core.c: In function '__vb2_buf_mem_alloc': >> drivers/media/common/videobuf2/videobuf2-core.c:72:9: warning: format '%p' >> expects argument of type 'void *', but argument 4 has type 'unsigned int' >> [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:210:14: note: in expansion of macro 'call_ptr_memop' mem_priv = call_ptr_memop(vb, alloc, ^ >> drivers/media/common/videobuf2/videobuf2-core.c:72:9: warning: format '%d' >> expects argument of type 'int', but argument 5 has type 'char *' [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:210:14: note: in expansion of macro 'call_ptr_memop' mem_priv = call_ptr_memop(vb, alloc, ^ >> drivers/media/common/videobuf2/videobuf2-core.c:72:9: warning: format '%s' >> expects a matching 'char *' argument [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:210:14: note: in expansion of macro 'call_ptr_memop' mem_priv = call_ptr_memop(vb, alloc, ^ drivers/media/common/videobuf2/videobuf2-core.c:84:9: warning: format '%p' expects argument of type 'void *', but argument 4 has type 'unsigned int' [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:227:3: note: in expansion of macro 'call_void_memop' call_void_memop(vb, put, vb->planes[plane - 1].mem_priv); ^ drivers/media/common/videobuf2/videobuf2-core.c:84:9: warning: format '%d' expects argument of type 'int', but argument 5 has type 'char *' [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:227:3: note: in expansion of macro 'call_void_memop' call_void_memop(vb, put, vb->planes[plane - 1].mem_priv); ^ drivers/media/common/videobuf2/videobuf2-core.c:84:9: warning: format '%s' expects a matching 'char *' argument [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:227:3: note: in expansion of macro 'call_void_memop' call_void_memop(vb, put, vb->planes[plane - 1].mem_priv); ^ drivers/media/common/videobuf2/videobuf2-core.c: In function '__vb2_buf_mem_free': drivers/media/common/videobuf2/videobuf2-core.c:84:9: warning: format '%p' expects argument of type 'void *', but argument 4 has type 'unsigned int' [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:242:3: note: in expansion of macro 'call_void_memop' call_void_memop(vb, put, vb->planes[plane].mem_priv); ^ drivers/media/common/videobuf2/videobuf2-core.c:84:9: warning: format '%d' expects argument of type 'int', but argument 5 has type 'char *' [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:242:3: note: in expansion of macro 'call_void_memop' call_void_memop(vb, put, vb->planes[plane].mem_priv); ^ drivers/media/common/videobuf2/videobuf2-core.c:84:9: warning: format '%s' expects a matching 'char *' argument [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:242:3: note: in expansion of macro 'call_void_memop' call_void_memop(vb, put, vb->planes[plane].mem_priv); ^ drivers/media/common/videobuf2/videobuf2-core.c: In function '__vb2_buf_userptr_put': drivers/media/common/videobuf2/videobuf2-core.c:84:9: warning: format '%p' expects argument of type 'void *', but argument 4 has type 'unsigned int' [-Wformat=] struct vb2_queue *_q = (vb)->vb2_queue;\ ^ drivers/media/common/videobuf2/videobuf2-core.c:259:4: note: in expansion of macro 'call_void_memop' call_void_memop(vb, put_userptr, vb->planes[plane].mem_priv); ^ drivers/media/common/videobuf2/videobuf2-core.c:84:9: warning: format '%d' expects argument of type 'int', but argument 5 has type 'char *'
Re: [PATCH] media: vb2: Print the queue pointer in debug messages
Hi Laurent, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Laurent-Pinchart/media-vb2-Print-the-queue-pointer-in-debug-messages/20180428-184113 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x014-201816 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from drivers/media//common/videobuf2/videobuf2-core.c:20: drivers/media//common/videobuf2/videobuf2-core.c: In function '__vb2_buf_mem_alloc': >> include/linux/kern_levels.h:5:18: warning: format '%p' expects argument of >> type 'void *', but argument 4 has type 'unsigned int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' #define KERN_INFO KERN_SOH "6" /* informational */ ^~~~ include/linux/printk.h:311:9: note: in expansion of macro 'KERN_INFO' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^ >> drivers/media//common/videobuf2/videobuf2-core.c:40:4: note: in expansion of >> macro 'pr_info' pr_info("(q=%p) %s: " fmt, q, __func__, ## arg);\ ^~~ >> drivers/media//common/videobuf2/videobuf2-core.c:54:2: note: in expansion of >> macro 'dprintk' dprintk((vb)->vb2_queue, 2, "call_memop(%p, %d, %s)%s\n", \ ^~~ >> drivers/media//common/videobuf2/videobuf2-core.c:75:2: note: in expansion of >> macro 'log_memop' log_memop(vb, op); \ ^ >> drivers/media//common/videobuf2/videobuf2-core.c:210:14: note: in expansion >> of macro 'call_ptr_memop' mem_priv = call_ptr_memop(vb, alloc, ^~ >> include/linux/kern_levels.h:5:18: warning: format '%d' expects argument of >> type 'int', but argument 5 has type 'char *' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' #define KERN_INFO KERN_SOH "6" /* informational */ ^~~~ include/linux/printk.h:311:9: note: in expansion of macro 'KERN_INFO' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^ >> drivers/media//common/videobuf2/videobuf2-core.c:40:4: note: in expansion of >> macro 'pr_info' pr_info("(q=%p) %s: " fmt, q, __func__, ## arg);\ ^~~ >> drivers/media//common/videobuf2/videobuf2-core.c:54:2: note: in expansion of >> macro 'dprintk' dprintk((vb)->vb2_queue, 2, "call_memop(%p, %d, %s)%s\n", \ ^~~ >> drivers/media//common/videobuf2/videobuf2-core.c:75:2: note: in expansion of >> macro 'log_memop' log_memop(vb, op); \ ^ >> drivers/media//common/videobuf2/videobuf2-core.c:210:14: note: in expansion >> of macro 'call_ptr_memop' mem_priv = call_ptr_memop(vb, alloc, ^~ include/linux/kern_levels.h:5:18: warning: format '%s' expects a matching 'char *' argument [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' #define KERN_INFO KERN_SOH "6" /* informational */ ^~~~ include/linux/printk.h:311:9: note: in expansion of macro 'KERN_INFO' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ^ >> drivers/media//common/videobuf2/videobuf2-core.c:40:4: note: in expansion of >> macro 'pr_info' pr_info("(q=%p) %s: " fmt, q, __func__, ## arg);\ ^~~ >> drivers/media//common/videobuf2/videobuf2-core.c:54:2: note: in expansion of >> macro 'dprintk' dprintk((vb)->vb2_queue, 2, "call_memop(%p, %d, %s)%s\n", \ ^~~ >> drivers/media//common/videobuf2/videobuf2-core.c:75:2: note: in expansion of >> macro 'log_memop' log_memop(vb, op); \ ^ >> drivers/media//common/videobuf2/videobuf2-core.c:210:14: note: in expansion >> of macro 'call_ptr_memop' mem_priv = call_ptr_memop(vb, alloc, ^~ >> include/linux/kern_levels.h:5:18: warning: format '%p' expects argument of >> type 'void *', but argument 4 has type 'unsigned int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH' #define KERN_INFO KERN_SOH "6" /* informational */ ^~~~ include/linux/printk.h:311:9: note: in
Re: [PATCH] media: zoran: move to dma-mapping interface
Hi Arnd, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/media-zoran-move-to-dma-mapping-interface/20180426-032120 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/media/pci/zoran/zoran_driver.c:419:33: sparse: incorrect type in >> argument 2 (different base types) @@expected unsigned long long >> [unsigned] [usertype] addr @@got nsigned long long [unsigned] [usertype] >> addr @@ drivers/media/pci/zoran/zoran_driver.c:419:33:expected unsigned long long [unsigned] [usertype] addr drivers/media/pci/zoran/zoran_driver.c:419:33:got restricted __le32 [assigned] [usertype] frag_tab vim +419 drivers/media/pci/zoran/zoran_driver.c 395 396 /* free the MJPEG grab buffers */ 397 static void jpg_fbuffer_free(struct zoran_fh *fh) 398 { 399 struct zoran *zr = fh->zr; 400 int i, j, off; 401 unsigned char *mem; 402 __le32 frag_tab; 403 struct zoran_buffer *buffer; 404 405 dprintk(4, KERN_DEBUG "%s: %s\n", ZR_DEVNAME(zr), __func__); 406 407 for (i = 0, buffer = >buffers.buffer[0]; 408 i < fh->buffers.num_buffers; i++, buffer++) { 409 if (!buffer->jpg.frag_tab) 410 continue; 411 412 if (fh->buffers.need_contiguous) { 413 frag_tab = buffer->jpg.frag_tab[0]; 414 415 if (frag_tab) { 416 mem = buffer->jpg.frag_virt_tab[0]; 417 for (off = 0; off < fh->buffers.buffer_size; off += PAGE_SIZE) 418 ClearPageReserved(virt_to_page(mem + off)); > 419 dma_unmap_single(>pci_dev->dev, > frag_tab, PAGE_SIZE, DMA_FROM_DEVICE); 420 kfree(mem); 421 buffer->jpg.frag_tab[0] = 0; 422 buffer->jpg.frag_tab[1] = 0; 423 } 424 } else { 425 for (j = 0; j < fh->buffers.buffer_size / PAGE_SIZE; j++) { 426 frag_tab = buffer->jpg.frag_tab[2 * j]; 427 428 if (!frag_tab) 429 break; 430 ClearPageReserved(virt_to_page(buffer->jpg.frag_virt_tab[j])); 431 dma_unmap_single(>pci_dev->dev, le32_to_cpu(frag_tab), PAGE_SIZE, DMA_FROM_DEVICE); 432 free_page((unsigned long)buffer->jpg.frag_virt_tab[j]); 433 buffer->jpg.frag_virt_tab[j] = NULL; 434 buffer->jpg.frag_tab[2 * j] = 0; 435 buffer->jpg.frag_tab[2 * j + 1] = 0; 436 } 437 } 438 439 dma_unmap_single(>pci_dev->dev, buffer->jpg.frag_tab_dma, PAGE_SIZE, DMA_TO_DEVICE); 440 free_page((unsigned long)buffer->jpg.frag_tab); 441 free_page((unsigned long)buffer->jpg.frag_virt_tab); 442 buffer->jpg.frag_virt_tab = NULL; 443 buffer->jpg.frag_tab = NULL; 444 } 445 446 fh->buffers.allocated = 0; 447 } 448 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 11/28] venus: add common capability parser
Hi Stanimir, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stanimir-Varbanov/Venus-updates/20180426-030344 base: git://linuxtv.org/media_tree.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/media/platform/qcom/venus/core.c: In function 'venus_enumerate_codecs': >> drivers/media/platform/qcom/venus/core.c:225:1: warning: the frame size of >> 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ vim +225 drivers/media/platform/qcom/venus/core.c 181 182 static int venus_enumerate_codecs(struct venus_core *core, u32 type) 183 { 184 const struct hfi_inst_ops dummy_ops = {}; 185 struct venus_inst inst; 186 unsigned int i; 187 u32 codec, codecs; 188 int ret; 189 190 if (core->res->hfi_version != HFI_VERSION_1XX) 191 return 0; 192 193 memset(, 0, sizeof(inst)); 194 mutex_init(); 195 inst.core = core; 196 inst.session_type = type; 197 if (type == VIDC_SESSION_TYPE_DEC) 198 codecs = core->dec_codecs; 199 else 200 codecs = core->enc_codecs; 201 202 ret = hfi_session_create(, _ops); 203 if (ret) 204 return ret; 205 206 for (i = 0; i < MAX_CODEC_NUM; i++) { 207 codec = (1 << i) & codecs; 208 if (!codec) 209 continue; 210 211 ret = hfi_session_init(, to_v4l2_codec_type(codec)); 212 if (ret) 213 goto done; 214 215 ret = hfi_session_deinit(); 216 if (ret) 217 goto done; 218 } 219 220 done: 221 hfi_session_destroy(); 222 mutex_destroy(); 223 224 return ret; > 225 } 226 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 1/5] dma-buf: use parameter structure for dma_buf_attach
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.17-rc2 next-20180424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Christian-K-nig/dma-buf-use-parameter-structure-for-dma_buf_attach/20180413-080639 base: git://people.freedesktop.org/~airlied/linux.git drm-next config: openrisc-allyesconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): drivers/staging//media/tegra-vde/tegra-vde.c: In function 'tegra_vde_attach_dmabuf': >> drivers/staging//media/tegra-vde/tegra-vde.c:534:13: error: 'dmabuf' >> undeclared (first use in this function) .dmabuf = dmabuf ^~ drivers/staging//media/tegra-vde/tegra-vde.c:534:13: note: each undeclared identifier is reported only once for each function it appears in vim +/dmabuf +534 drivers/staging//media/tegra-vde/tegra-vde.c 521 522 static int tegra_vde_attach_dmabuf(struct device *dev, 523 int fd, 524 unsigned long offset, 525 unsigned int min_size, 526 struct dma_buf_attachment **a, 527 dma_addr_t *addr, 528 struct sg_table **s, 529 size_t *size, 530 enum dma_data_direction dma_dir) 531 { 532 struct dma_buf_attach_info attach_info = { 533 .dev = dev, > 534 .dmabuf = dmabuf 535 }; 536 struct dma_buf_attachment *attachment; 537 struct dma_buf *dmabuf; 538 struct sg_table *sgt; 539 int err; 540 541 dmabuf = dma_buf_get(fd); 542 if (IS_ERR(dmabuf)) { 543 dev_err(dev, "Invalid dmabuf FD\n"); 544 return PTR_ERR(dmabuf); 545 } 546 547 if ((u64)offset + min_size > dmabuf->size) { 548 dev_err(dev, "Too small dmabuf size %zu @0x%lX, " 549 "should be at least %d\n", 550 dmabuf->size, offset, min_size); 551 return -EINVAL; 552 } 553 554 attachment = dma_buf_attach(_info); 555 if (IS_ERR(attachment)) { 556 dev_err(dev, "Failed to attach dmabuf\n"); 557 err = PTR_ERR(attachment); 558 goto err_put; 559 } 560 561 sgt = dma_buf_map_attachment(attachment, dma_dir); 562 if (IS_ERR(sgt)) { 563 dev_err(dev, "Failed to get dmabufs sg_table\n"); 564 err = PTR_ERR(sgt); 565 goto err_detach; 566 } 567 568 if (sgt->nents != 1) { 569 dev_err(dev, "Sparse DMA region is unsupported\n"); 570 err = -EINVAL; 571 goto err_unmap; 572 } 573 574 *addr = sg_dma_address(sgt->sgl) + offset; 575 *a = attachment; 576 *s = sgt; 577 578 if (size) 579 *size = dmabuf->size - offset; 580 581 return 0; 582 583 err_unmap: 584 dma_buf_unmap_attachment(attachment, sgt, dma_dir); 585 err_detach: 586 dma_buf_detach(dmabuf, attachment); 587 err_put: 588 dma_buf_put(dmabuf); 589 590 return err; 591 } 592 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 1/5] dma-buf: use parameter structure for dma_buf_attach
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.17-rc2 next-20180424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Christian-K-nig/dma-buf-use-parameter-structure-for-dma_buf_attach/20180413-080639 base: git://people.freedesktop.org/~airlied/linux.git drm-next config: powerpc64-allmodconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=powerpc64 All errors (new ones prefixed by >>): drivers/staging/media/tegra-vde/tegra-vde.c: In function 'tegra_vde_attach_dmabuf': >> drivers/staging/media/tegra-vde/tegra-vde.c:534:13: error: 'dmabuf' >> undeclared (first use in this function); did you mean 'dma_buf'? .dmabuf = dmabuf ^~ dma_buf drivers/staging/media/tegra-vde/tegra-vde.c:534:13: note: each undeclared identifier is reported only once for each function it appears in vim +534 drivers/staging/media/tegra-vde/tegra-vde.c 521 522 static int tegra_vde_attach_dmabuf(struct device *dev, 523 int fd, 524 unsigned long offset, 525 unsigned int min_size, 526 struct dma_buf_attachment **a, 527 dma_addr_t *addr, 528 struct sg_table **s, 529 size_t *size, 530 enum dma_data_direction dma_dir) 531 { 532 struct dma_buf_attach_info attach_info = { 533 .dev = dev, > 534 .dmabuf = dmabuf 535 }; 536 struct dma_buf_attachment *attachment; 537 struct dma_buf *dmabuf; 538 struct sg_table *sgt; 539 int err; 540 541 dmabuf = dma_buf_get(fd); 542 if (IS_ERR(dmabuf)) { 543 dev_err(dev, "Invalid dmabuf FD\n"); 544 return PTR_ERR(dmabuf); 545 } 546 547 if ((u64)offset + min_size > dmabuf->size) { 548 dev_err(dev, "Too small dmabuf size %zu @0x%lX, " 549 "should be at least %d\n", 550 dmabuf->size, offset, min_size); 551 return -EINVAL; 552 } 553 554 attachment = dma_buf_attach(_info); 555 if (IS_ERR(attachment)) { 556 dev_err(dev, "Failed to attach dmabuf\n"); 557 err = PTR_ERR(attachment); 558 goto err_put; 559 } 560 561 sgt = dma_buf_map_attachment(attachment, dma_dir); 562 if (IS_ERR(sgt)) { 563 dev_err(dev, "Failed to get dmabufs sg_table\n"); 564 err = PTR_ERR(sgt); 565 goto err_detach; 566 } 567 568 if (sgt->nents != 1) { 569 dev_err(dev, "Sparse DMA region is unsupported\n"); 570 err = -EINVAL; 571 goto err_unmap; 572 } 573 574 *addr = sg_dma_address(sgt->sgl) + offset; 575 *a = attachment; 576 *s = sgt; 577 578 if (size) 579 *size = dmabuf->size - offset; 580 581 return 0; 582 583 err_unmap: 584 dma_buf_unmap_attachment(attachment, sgt, dma_dir); 585 err_detach: 586 dma_buf_detach(dmabuf, attachment); 587 err_put: 588 dma_buf_put(dmabuf); 589 590 return err; 591 } 592 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 09/13] media: imx274: get rid of mode_index
Hi Luca, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luca-Ceresoli/media-imx274-cleanups-improvements-and-SELECTION-API-support/20180424-220137 base: git://linuxtv.org/media_tree.git master config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc64 All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:332:0, from include/linux/kernel.h:14, from include/linux/clk.h:16, from drivers/media//i2c/imx274.c:22: drivers/media//i2c/imx274.c: In function 'imx274_s_stream': >> drivers/media//i2c/imx274.c:1027:32: warning: format '%d' expects argument >> of type 'int', but argument 6 has type 'long int' [-Wformat=] dev_dbg(>client->dev, "%s : %s, mode index = %d\n", __func__, ^ drivers/media//i2c/imx274.c:1029:3: imx274->mode - _formats[0]); ~ include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg' __dynamic_dev_dbg(, dev, fmt, \ ^~~ drivers/media//i2c/imx274.c:1027:2: note: in expansion of macro 'dev_dbg' dev_dbg(>client->dev, "%s : %s, mode index = %d\n", __func__, ^~~ vim +1027 drivers/media//i2c/imx274.c 0985dd30 Leon Luo 2017-10-05 1011 0985dd30 Leon Luo 2017-10-05 1012 /** 0985dd30 Leon Luo 2017-10-05 1013 * imx274_s_stream - It is used to start/stop the streaming. 0985dd30 Leon Luo 2017-10-05 1014 * @sd: V4L2 Sub device 0985dd30 Leon Luo 2017-10-05 1015 * @on: Flag (True / False) 0985dd30 Leon Luo 2017-10-05 1016 * 0985dd30 Leon Luo 2017-10-05 1017 * This function controls the start or stop of streaming for the 0985dd30 Leon Luo 2017-10-05 1018 * imx274 sensor. 0985dd30 Leon Luo 2017-10-05 1019 * 0985dd30 Leon Luo 2017-10-05 1020 * Return: 0 on success, errors otherwise 0985dd30 Leon Luo 2017-10-05 1021 */ 0985dd30 Leon Luo 2017-10-05 1022 static int imx274_s_stream(struct v4l2_subdev *sd, int on) 0985dd30 Leon Luo 2017-10-05 1023 { 0985dd30 Leon Luo 2017-10-05 1024 struct stimx274 *imx274 = to_imx274(sd); 0985dd30 Leon Luo 2017-10-05 1025 int ret = 0; 0985dd30 Leon Luo 2017-10-05 1026 0985dd30 Leon Luo 2017-10-05 @1027 dev_dbg(>client->dev, "%s : %s, mode index = %d\n", __func__, f5180bf1 Luca Ceresoli 2018-04-24 1028 on ? "Stream Start" : "Stream Stop", f5180bf1 Luca Ceresoli 2018-04-24 1029 imx274->mode - _formats[0]); 0985dd30 Leon Luo 2017-10-05 1030 0985dd30 Leon Luo 2017-10-05 1031 mutex_lock(>lock); 0985dd30 Leon Luo 2017-10-05 1032 0985dd30 Leon Luo 2017-10-05 1033 if (on) { 0985dd30 Leon Luo 2017-10-05 1034 /* load mode registers */ da5bbae7 Luca Ceresoli 2018-04-24 1035 ret = imx274_mode_regs(imx274); 0985dd30 Leon Luo 2017-10-05 1036 if (ret) 0985dd30 Leon Luo 2017-10-05 1037 goto fail; 0985dd30 Leon Luo 2017-10-05 1038 0985dd30 Leon Luo 2017-10-05 1039 /* 0985dd30 Leon Luo 2017-10-05 1040 * update frame rate & expsoure. if the last mode is different, 0985dd30 Leon Luo 2017-10-05 1041 * HMAX could be changed. As the result, frame rate & exposure 0985dd30 Leon Luo 2017-10-05 1042 * are changed. 0985dd30 Leon Luo 2017-10-05 1043 * gain is not affected. 0985dd30 Leon Luo 2017-10-05 1044 */ 0985dd30 Leon Luo 2017-10-05 1045 ret = imx274_set_frame_interval(imx274, 0985dd30 Leon Luo 2017-10-05 1046 imx274->frame_interval); 0985dd30 Leon Luo 2017-10-05 1047 if (ret) 0985dd30 Leon Luo 2017-10-05 1048 goto fail; 0985dd30 Leon Luo 2017-10-05 1049 0985dd30 Leon Luo 2017-10-05 1050 /* update exposure time */ 0985dd30 Leon Luo 2017-10-05 1051 ret = __v4l2_ctrl_s_ctrl(imx274->ctrls.exposure, 0985dd30 Leon Luo 2017-10-05 1052 imx274->ctrls.exposure->val); 0985dd30 Leon Luo 2017-10-05
[linux-next:master 1383/2517] sound/isa/ad1816a/ad1816a_lib.c:93:14: sparse: restricted snd_pcm_format_t degrades to integer
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 43cd1f4979998ba0ef1c0b8e1c5d23d2de5ab172 commit: da112f13996de6e8dc0011f77ce8f7d0353dd14e [1383/2517] media: sound, isapnp: allow building more drivers with COMPILE_TEST reproduce: # apt-get install sparse git checkout da112f13996de6e8dc0011f77ce8f7d0353dd14e make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> sound/isa/ad1816a/ad1816a_lib.c:93:14: sparse: restricted snd_pcm_format_t >> degrades to integer sound/isa/ad1816a/ad1816a_lib.c:96:14: sparse: restricted snd_pcm_format_t degrades to integer sound/isa/ad1816a/ad1816a_lib.c:99:14: sparse: restricted snd_pcm_format_t degrades to integer sound/isa/ad1816a/ad1816a_lib.c:102:14: sparse: restricted snd_pcm_format_t degrades to integer >> sound/isa/ad1816a/ad1816a_lib.c:253:53: sparse: incorrect type in argument 2 >> (different base types) @@expected unsigned int [unsigned] format @@ >> got restricted snd_unsigned int [unsigned] format @@ sound/isa/ad1816a/ad1816a_lib.c:253:53:expected unsigned int [unsigned] format sound/isa/ad1816a/ad1816a_lib.c:253:53:got restricted snd_pcm_format_t [usertype] format sound/isa/ad1816a/ad1816a_lib.c:285:53: sparse: incorrect type in argument 2 (different base types) @@expected unsigned int [unsigned] format @@got restricted snd_unsigned int [unsigned] format @@ sound/isa/ad1816a/ad1816a_lib.c:285:53:expected unsigned int [unsigned] format sound/isa/ad1816a/ad1816a_lib.c:285:53:got restricted snd_pcm_format_t [usertype] format vim +93 sound/isa/ad1816a/ad1816a_lib.c ^1da177e4 Linus Torvalds 2005-04-16 85 ^1da177e4 Linus Torvalds 2005-04-16 86 cbdd0dd15 Takashi Iwai 2005-11-17 87 static unsigned char snd_ad1816a_get_format(struct snd_ad1816a *chip, ^1da177e4 Linus Torvalds 2005-04-16 88 unsigned int format, int channels) ^1da177e4 Linus Torvalds 2005-04-16 89 { ^1da177e4 Linus Torvalds 2005-04-16 90unsigned char retval = AD1816A_FMT_LINEAR_8; ^1da177e4 Linus Torvalds 2005-04-16 91 ^1da177e4 Linus Torvalds 2005-04-16 92switch (format) { ^1da177e4 Linus Torvalds 2005-04-16 @93case SNDRV_PCM_FORMAT_MU_LAW: ^1da177e4 Linus Torvalds 2005-04-16 94retval = AD1816A_FMT_ULAW_8; ^1da177e4 Linus Torvalds 2005-04-16 95break; ^1da177e4 Linus Torvalds 2005-04-16 96case SNDRV_PCM_FORMAT_A_LAW: ^1da177e4 Linus Torvalds 2005-04-16 97retval = AD1816A_FMT_ALAW_8; ^1da177e4 Linus Torvalds 2005-04-16 98break; ^1da177e4 Linus Torvalds 2005-04-16 99case SNDRV_PCM_FORMAT_S16_LE: ^1da177e4 Linus Torvalds 2005-04-16 100retval = AD1816A_FMT_LINEAR_16_LIT; ^1da177e4 Linus Torvalds 2005-04-16 101break; ^1da177e4 Linus Torvalds 2005-04-16 102case SNDRV_PCM_FORMAT_S16_BE: ^1da177e4 Linus Torvalds 2005-04-16 103retval = AD1816A_FMT_LINEAR_16_BIG; ^1da177e4 Linus Torvalds 2005-04-16 104} ^1da177e4 Linus Torvalds 2005-04-16 105return (channels > 1) ? (retval | AD1816A_FMT_STEREO) : retval; ^1da177e4 Linus Torvalds 2005-04-16 106 } ^1da177e4 Linus Torvalds 2005-04-16 107 cbdd0dd15 Takashi Iwai 2005-11-17 108 static int snd_ad1816a_open(struct snd_ad1816a *chip, unsigned int mode) ^1da177e4 Linus Torvalds 2005-04-16 109 { ^1da177e4 Linus Torvalds 2005-04-16 110unsigned long flags; ^1da177e4 Linus Torvalds 2005-04-16 111 ^1da177e4 Linus Torvalds 2005-04-16 112spin_lock_irqsave(>lock, flags); ^1da177e4 Linus Torvalds 2005-04-16 113 ^1da177e4 Linus Torvalds 2005-04-16 114if (chip->mode & mode) { ^1da177e4 Linus Torvalds 2005-04-16 115 spin_unlock_irqrestore(>lock, flags); ^1da177e4 Linus Torvalds 2005-04-16 116return -EAGAIN; ^1da177e4 Linus Torvalds 2005-04-16 117} ^1da177e4 Linus Torvalds 2005-04-16 118 ^1da177e4 Linus Torvalds 2005-04-16 119switch ((mode &= AD1816A_MODE_OPEN)) { ^1da177e4 Linus Torvalds 2005-04-16 120case AD1816A_MODE_PLAYBACK: ^1da177e4 Linus Torvalds 2005-04-16 121 snd_ad1816a_out_mask(chip, AD1816A_INTERRUPT_STATUS, ^1da177e4 Linus Torvalds 2005-04-16 122 AD1816A_PLAYBACK_IRQ_PENDING, 0x00); ^1da177e4 Linus Torvalds 2005-04-16 123 snd_ad1816a_write_mask(chip, AD1816A_INTERRUPT_ENABLE, ^1da177e4 Linus Torvalds 2005-04-16 124 AD1816A_PLAYBACK_IRQ_ENABLE, 0x); ^1da177e4 Linus Torvalds 2005-04-16 125break; ^1da177e4 Linus Torvalds 2005-04-16 126case AD1816A_MODE_CAPTURE: ^1da177e4 Linus Torvalds 2005-04-16 127 snd_ad1816a_out_mask(chip, AD1816A_INTERRUPT_STATUS, ^1da177e4 Linus Torvalds