Re: [GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2011-01-16 Thread Mauro Carvalho Chehab
Em 13-01-2011 14:30, Jean-Francois Moine escreveu:
 On Thu, 13 Jan 2011 12:38:04 +0100
 Antonio Ospite osp...@studenti.unina.it wrote:
 
 Jean-François Moine (9):  
 [...]
   gspca - ov534: Use the new video control mechanism  

 In this commit, is there a reason why you didn't rename also
 sd_setagc() into setagc() like for the other functions?

 I am going to test the changes and report back if there's anything
 more, I like the cleanup tho.
 
 Hi Antonio,
 
 With the new video control mechanism, the '.set_control' function is
 called only when capture is active. Otherwise, the '.set' function is
 called in any case, and here, it activates/inactivates the auto white
 balance control... Oh, I forgot to disable the awb when the agc is
 disabled!
 
 Thank you for reporting any problem. BTW, the webcam 06f8:3002 which
 had been removed some time ago is being tested. I will add it to this
 subdriver as soon as it works correctly.

I'm applying the remaining 8 patches from this series, as they seem to be ok.

Please send me a new pull request when you fix the issues with the ov534 new
video control mechanism.

Thanks,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2011-01-14 Thread Antonio Ospite
On Thu, 13 Jan 2011 17:30:21 +0100
Jean-Francois Moine moin...@free.fr wrote:

 On Thu, 13 Jan 2011 12:38:04 +0100
 Antonio Ospite osp...@studenti.unina.it wrote:
 
   Jean-François Moine (9):  
  [...]
 gspca - ov534: Use the new video control mechanism  
  
  In this commit, is there a reason why you didn't rename also
  sd_setagc() into setagc() like for the other functions?
  
  I am going to test the changes and report back if there's anything
  more, I like the cleanup tho.
 
 Hi Antonio,
 
 With the new video control mechanism, the '.set_control' function is
 called only when capture is active. Otherwise, the '.set' function is
 called in any case, and here, it activates/inactivates the auto white
 balance control... Oh, I forgot to disable the awb when the agc is
 disabled!


So the convention you used for function names is:
 .set = sd_setFOO;
and
 .set_control = setBAR;

right?

Tested with guvcview, when toggling the Autoexposure control I get this
message:
  control id: 0x009a0901 failed to set (error -1)
  control id: 0x009a0901 failed to get value (error -1)

Similar error with qv4l2:
  Error Auto Exposure (1): Invalid argument

And because of that the manual Exposure control does not work either.

However I verified these errors are also in 2.6.35, so I think your
conversion is fine, there must be something else going on; maybe I
should open another thread, as there is also the pending issue of
changing framerates live, unrelated to the control changes as well.

I hope to be able to look at these issues soon, if nobody else does
before.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?


pgplS6ExHdskm.pgp
Description: PGP signature


[GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2011-01-13 Thread Jean-Francois Moine
The following changes since commit
353b61709a555fab9745cb7aea18e1c376c413ce:

  [media] radio-si470x: Always report support for RDS (2011-01-11 14:44:28 
-0200)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.38

Jean-François Moine (9):
  gspca: Version change.
  gspca: Remove __devinit, __devinitconst and __devinitdata
  gspca: Remove useless instructions
  gspca - ov519: Cleanup source and add a comment
  gspca - ov534: Clearer debug messages
  gspca - ov534: Propagate errors to higher level
  gspca - ov534: Use the new video control mechanism
  gspca - sonixj: Infrared bug fix and enhancement
  gspca - sonixj: Add LED (illuminator) control to the webcam 0c45:614a.

 drivers/media/video/gspca/benq.c |2 +-
 drivers/media/video/gspca/conex.c|4 +-
 drivers/media/video/gspca/cpia1.c|2 +-
 drivers/media/video/gspca/etoms.c|4 +-
 drivers/media/video/gspca/finepix.c  |2 +-
 drivers/media/video/gspca/gl860/gl860.c  |2 +-
 drivers/media/video/gspca/gspca.c|2 +-
 drivers/media/video/gspca/jeilinj.c  |2 +-
 drivers/media/video/gspca/jpeg.h |4 +-
 drivers/media/video/gspca/konica.c   |2 +-
 drivers/media/video/gspca/m5602/m5602_core.c |2 +-
 drivers/media/video/gspca/mars.c |2 +-
 drivers/media/video/gspca/mr97310a.c |2 +-
 drivers/media/video/gspca/ov519.c|8 +-
 drivers/media/video/gspca/ov534.c|  473 +++---
 drivers/media/video/gspca/ov534_9.c  |2 +-
 drivers/media/video/gspca/pac207.c   |2 +-
 drivers/media/video/gspca/pac7302.c  |4 +-
 drivers/media/video/gspca/pac7311.c  |4 +-
 drivers/media/video/gspca/sn9c2028.c |2 +-
 drivers/media/video/gspca/sn9c20x.c  |2 +-
 drivers/media/video/gspca/sonixb.c   |4 +-
 drivers/media/video/gspca/sonixj.c   |   92 +++---
 drivers/media/video/gspca/spca1528.c |2 +-
 drivers/media/video/gspca/spca500.c  |2 +-
 drivers/media/video/gspca/spca501.c  |2 +-
 drivers/media/video/gspca/spca505.c  |2 +-
 drivers/media/video/gspca/spca508.c  |2 +-
 drivers/media/video/gspca/spca561.c  |2 +-
 drivers/media/video/gspca/sq905.c|2 +-
 drivers/media/video/gspca/sq905c.c   |2 +-
 drivers/media/video/gspca/sq930x.c   |2 +-
 drivers/media/video/gspca/stk014.c   |2 +-
 drivers/media/video/gspca/stv0680.c  |2 +-
 drivers/media/video/gspca/stv06xx/stv06xx.c  |2 +-
 drivers/media/video/gspca/sunplus.c  |2 +-
 drivers/media/video/gspca/t613.c |2 +-
 drivers/media/video/gspca/tv8532.c   |2 +-
 drivers/media/video/gspca/vc032x.c   |2 +-
 drivers/media/video/gspca/xirlink_cit.c  |2 +-
 drivers/media/video/gspca/zc3xx.c|2 +-
 41 files changed, 218 insertions(+), 443 deletions(-)

-- 
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef |   http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2011-01-13 Thread Antonio Ospite
On Thu, 13 Jan 2011 11:59:53 +0100
Jean-Francois Moine moin...@free.fr wrote:

 The following changes since commit
 353b61709a555fab9745cb7aea18e1c376c413ce:
 
   [media] radio-si470x: Always report support for RDS (2011-01-11 14:44:28 
 -0200)
 
 are available in the git repository at:
   git://linuxtv.org/jfrancois/gspca.git for_2.6.38


Hi Jean-François, I had a look at the ov534 changes.

 Jean-François Moine (9):
[...]
   gspca - ov534: Use the new video control mechanism

In this commit, is there a reason why you didn't rename also
sd_setagc() into setagc() like for the other functions?

I am going to test the changes and report back if there's anything
more, I like the cleanup tho.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?


pgp2QgWA1sUVW.pgp
Description: PGP signature


Re: [GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2011-01-13 Thread Jean-Francois Moine
On Thu, 13 Jan 2011 12:38:04 +0100
Antonio Ospite osp...@studenti.unina.it wrote:

  Jean-François Moine (9):  
 [...]
gspca - ov534: Use the new video control mechanism  
 
 In this commit, is there a reason why you didn't rename also
 sd_setagc() into setagc() like for the other functions?
 
 I am going to test the changes and report back if there's anything
 more, I like the cleanup tho.

Hi Antonio,

With the new video control mechanism, the '.set_control' function is
called only when capture is active. Otherwise, the '.set' function is
called in any case, and here, it activates/inactivates the auto white
balance control... Oh, I forgot to disable the awb when the agc is
disabled!

Thank you for reporting any problem. BTW, the webcam 06f8:3002 which
had been removed some time ago is being tested. I will add it to this
subdriver as soon as it works correctly.

Cheers.

-- 
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef |   http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2010-12-28 Thread Jean-Francois Moine
The following changes since commit
fc43dd115e1c07af122440971177451cef5c45c0:

  [media] MEDIA: RC: Provide full scancodes for TT-1500 remote control 
(2010-12-27 19:26:56 -0200)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.38

Jean-François Moine (9):
  gspca - main: Fix some warnings
  gspca - pac7302/pac7311: Fix some warnings
  gspca: Bad comment
  gspca - zc3xx: Keep sorted the device table
  gspca - zc3xx: Use the new video control mechanism
  gspca - zc3xx: The sensor of the VF0250 is a GC0303
  gspca - vc032x: Cleanup source
  gspca - stv06xx/st6422: Use the new video control mechanism
  gspca - sonixj: Bad clock for om6802 in 640x480

 drivers/media/video/gspca/gspca.c  |   10 +-
 drivers/media/video/gspca/gspca.h  |2 +-
 drivers/media/video/gspca/pac7302.c|2 +-
 drivers/media/video/gspca/pac7311.c|2 +-
 drivers/media/video/gspca/sonixj.c |2 +-
 drivers/media/video/gspca/stv06xx/stv06xx_st6422.c |  272 ---
 drivers/media/video/gspca/stv06xx/stv06xx_st6422.h |   10 -
 drivers/media/video/gspca/vc032x.c |   74 +++---
 drivers/media/video/gspca/zc3xx.c  |  290 ++--
 9 files changed, 251 insertions(+), 413 deletions(-)

-- 
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef |   http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2010-12-25 Thread Jean-Francois Moine
The following changes since commit
884d09f0d9f2eb6848c71fd024c250816f835572:

  [media] drivers:media:dvb: add USB PIDs for Elgato EyeTV Sat (2010-12-22 
15:57:42 -0200)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.38

Jean-François Moine (7):
  gspca - sq930x: Don't register a webcam when there are USB errors
  gspca - sq930x: Some detected sensors are not handled yet
  gspca - sq930x: Fix a bad comment
  gspca - main: Check the isoc packet status before its length
  gspca: Use the global error status for get/set streamparm
  gspca - ov519: Bad detection of some ov7670 sensors
  gspca - ov534_9: Remove a useless instruction

Theodore Kilgore (1):
  gspca - sq905c: Adds the Lego Bionicle

 Documentation/video4linux/gspca.txt |1 +
 drivers/media/video/gspca/gspca.c   |   34 ++
 drivers/media/video/gspca/gspca.h   |2 +-
 drivers/media/video/gspca/ov519.c   |4 ++--
 drivers/media/video/gspca/ov534.c   |   14 ++
 drivers/media/video/gspca/ov534_9.c |1 -
 drivers/media/video/gspca/sq905c.c  |1 +
 drivers/media/video/gspca/sq930x.c  |   28 
 8 files changed, 45 insertions(+), 40 deletions(-)

-- 
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef |   http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2010-11-13 Thread Jean-Francois Moine
The following changes since commit
af9f14f7fc31f0d7b7cdf8f7f7f15a3c3794aea3:

  [media] IR: add tv power scancode to rc6 mce keymap (2010-11-10 00:58:49 
-0200)

are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.38

Jean-François Moine (16):
  gspca - ov519: Handle the snapshot on capture stop when CONFIG_INPUT=m
  gspca - ov519: Don't do USB exchanges after disconnection
  gspca - ov519: Change types '__xx' to 'xx'
  gspca - ov519: Reduce the size of some variables
  gspca - ov519: Define the sensor types in an enum
  gspca - ov519: Cleanup source
  gspca - ov519: Set their numbers in the ov519 and ov7670 register names
  gspca - ov519: Define the disabled controls in a table
  gspca - ov519: Propagate errors to higher level
  gspca - ov519: Clearer debug and error messages
  gspca - ov519: Check the disabled controls at start time only
  gspca - ov519: Simplify the LED control functions
  gspca - ov519: Change the ov519 start and stop sequences
  gspca - ov519: Initialize the ov519 snapshot register
  gspca - ov519: Re-initialize the webcam at resume time
  gspca - ov519: New sensor ov7660 with bridge ov530 (ov519)

Nicolas Kaiser (1):
  gspca - cpia1: Fix error check

 drivers/media/video/gspca/cpia1.c   |2 +-
 drivers/media/video/gspca/ov519.c   | 1671 +--
 drivers/media/video/gspca/w996Xcf.c |  325 +++
 3 files changed, 1131 insertions(+), 867 deletions(-)

-- 
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef |   http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2010-11-13 Thread Anca Emanuel
On Sat, Nov 13, 2010 at 11:46 AM, Jean-Francois Moine moin...@free.fr wrote:
 The following changes since commit
 af9f14f7fc31f0d7b7cdf8f7f7f15a3c3794aea3:

  [media] IR: add tv power scancode to rc6 mce keymap (2010-11-10 00:58:49 
 -0200)

 are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.38

 Jean-François Moine (16):
      gspca - ov519: Handle the snapshot on capture stop when CONFIG_INPUT=m
      gspca - ov519: Don't do USB exchanges after disconnection
      gspca - ov519: Change types '__xx' to 'xx'
      gspca - ov519: Reduce the size of some variables
      gspca - ov519: Define the sensor types in an enum
      gspca - ov519: Cleanup source
      gspca - ov519: Set their numbers in the ov519 and ov7670 register names
      gspca - ov519: Define the disabled controls in a table
      gspca - ov519: Propagate errors to higher level
      gspca - ov519: Clearer debug and error messages
      gspca - ov519: Check the disabled controls at start time only
      gspca - ov519: Simplify the LED control functions
      gspca - ov519: Change the ov519 start and stop sequences
      gspca - ov519: Initialize the ov519 snapshot register
      gspca - ov519: Re-initialize the webcam at resume time
      gspca - ov519: New sensor ov7660 with bridge ov530 (ov519)

 Nicolas Kaiser (1):
      gspca - cpia1: Fix error check

  drivers/media/video/gspca/cpia1.c   |    2 +-
  drivers/media/video/gspca/ov519.c   | 1671 
 +--
  drivers/media/video/gspca/w996Xcf.c |  325 +++
  3 files changed, 1131 insertions(+), 867 deletions(-)

Some conflicts against mainline:
diff --cc drivers/staging/cx25821/Kconfig
index 1d73334,9c2e259..000
--- a/drivers/staging/cx25821/Kconfig
+++ b/drivers/staging/cx25821/Kconfig
@@@ -1,7 -1,6 +1,11 @@@
  config VIDEO_CX25821
tristate Conexant cx25821 support
++ HEAD
 +  depends on DVB_CORE  VIDEO_DEV  PCI  I2C  INPUT
 +  depends on BKL # please fix
++===
+   depends on DVB_CORE  VIDEO_DEV  PCI  I2C
++ b49b143975141c461bfd11dd1c6632c1a1c7f8ff
select I2C_ALGOBIT
select VIDEO_BTCX
select VIDEO_TVEEPROM
diff --cc drivers/staging/go7007/Kconfig
index 3aecd30,75ddaad..000
--- a/drivers/staging/go7007/Kconfig
+++ b/drivers/staging/go7007/Kconfig
@@@ -1,10 -1,9 +1,14 @@@
  config VIDEO_GO7007
tristate WIS GO7007 MPEG encoder support
++ HEAD
 +  depends on VIDEO_DEV  PCI  I2C  INPUT
 +  depends on BKL # please fix
++===
+   depends on VIDEO_DEV  PCI  I2C
++ b49b143975141c461bfd11dd1c6632c1a1c7f8ff
depends on SND
select VIDEOBUF_DMA_SG
-   depends on VIDEO_IR
+   depends on IR_CORE
select VIDEO_TUNER
select VIDEO_TVEEPROM
select SND_PCM

Running new kernel now, ov7660 works. Thank you.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [GIT PATCHES FOR 2.6.38] gspca for_2.6.38

2010-11-13 Thread Mauro Carvalho Chehab
Em 13-11-2010 10:16, Anca Emanuel escreveu:
 On Sat, Nov 13, 2010 at 11:46 AM, Jean-Francois Moine moin...@free.fr wrote:
 The following changes since commit
 af9f14f7fc31f0d7b7cdf8f7f7f15a3c3794aea3:

  [media] IR: add tv power scancode to rc6 mce keymap (2010-11-10 00:58:49 
 -0200)

 are available in the git repository at:
  git://linuxtv.org/jfrancois/gspca.git for_2.6.38

 Jean-François Moine (16):
  gspca - ov519: Handle the snapshot on capture stop when CONFIG_INPUT=m
  gspca - ov519: Don't do USB exchanges after disconnection
  gspca - ov519: Change types '__xx' to 'xx'
  gspca - ov519: Reduce the size of some variables
  gspca - ov519: Define the sensor types in an enum
  gspca - ov519: Cleanup source
  gspca - ov519: Set their numbers in the ov519 and ov7670 register names
  gspca - ov519: Define the disabled controls in a table
  gspca - ov519: Propagate errors to higher level
  gspca - ov519: Clearer debug and error messages
  gspca - ov519: Check the disabled controls at start time only
  gspca - ov519: Simplify the LED control functions
  gspca - ov519: Change the ov519 start and stop sequences
  gspca - ov519: Initialize the ov519 snapshot register
  gspca - ov519: Re-initialize the webcam at resume time
  gspca - ov519: New sensor ov7660 with bridge ov530 (ov519)

 Nicolas Kaiser (1):
  gspca - cpia1: Fix error check

  drivers/media/video/gspca/cpia1.c   |2 +-
  drivers/media/video/gspca/ov519.c   | 1671 
 +--
  drivers/media/video/gspca/w996Xcf.c |  325 +++
  3 files changed, 1131 insertions(+), 867 deletions(-)
 
 Some conflicts against mainline:

Didn't get any conflict against branch staging/for_v2.6.38.

Patches applied, thanks.
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html