Re: [PATCH 0/5] soc-camera: convert to platform device
On Mon, 20 Apr 2009, Magnus Damm wrote: On Fri, Apr 17, 2009 at 7:43 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 17 Apr 2009, Magnus Damm wrote: On Fri, Apr 17, 2009 at 4:51 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 17 Apr 2009, Magnus Damm wrote: On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: This patch series is a preparation for the v4l2-subdev conversion. Please, review and test. My current patch-stack in the form of a (manually-created) quilt-series is at http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Testing on Migo-R board with 2.6.30-rc2-git-something and the following cherry-picked patches: 0007-driver-core-fix-driver_match_device.patch 0033-soc-camera-host-driver-cleanup.patch 0034-soc-camera-remove-an-extra-device-generation-from-s.patch 0035-soc-camera-simplify-register-access-routines-in-mul.patch and part of 0036 (avoiding rejects, ap325 seems broken btw) Have I broken it or is it unrelated? 2.6.30-rc seems broken on Migo-R. A quick check suggests the following: Ok, before we come to Migo-R, what is with ap325? Have I broken it with this my series or is it a different problem? Not sure. I used 2.6.30-rc but I guess your patches are aimed at linux-next. V4L/DVB (10141): OK V4L/DVB (10672): BAD V4L/DVB (11024): BAD These seem to be pretty random snapshots... Are they all on Linus' master or on next or on v4l-dvb? You did pick up the 0007-driver-core-fix-driver_match_device.patch Yeah, I tried that one. I'm not sure what was the problem, but it's gone now. Today I've tested the following on top of linux-2.6 (stable 2.6.30-rc) d91dfbb41bb2e9bdbfbd2cc7078ed7436eab027a 0033-soc-camera-host-driver-cleanup.patch 0034-soc-camera-remove-an-extra-device-generation-from-s.patch 0035-soc-camera-simplify-register-access-routines-in-mul.patch So far OK. However, applying 0036- or v2 from the mailing list results in rejects (probably because linux-next vs linux-2.6 differences) but the files should not affect Migo-R. So with 0036 or v2 applied it builds ok for Migo-R, but I can't open /dev/video0 for some reason. Reverting the patch and only using 0033-0035 above results in ok /dev/video0 opening. Did you have video drivers build in or as modules? If modules - in which order did you load them? Unfortunately, at the moment it might be important:-( What's in dmesg after loading all drivers? What are your dependencies? I'll try out your 20090415/series on top of the matching linux-next for now. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
On Mon, Apr 20, 2009 at 4:22 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 20 Apr 2009, Magnus Damm wrote: On Fri, Apr 17, 2009 at 7:43 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 17 Apr 2009, Magnus Damm wrote: On Fri, Apr 17, 2009 at 4:51 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 17 Apr 2009, Magnus Damm wrote: On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: This patch series is a preparation for the v4l2-subdev conversion. Please, review and test. My current patch-stack in the form of a (manually-created) quilt-series is at http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Today I've tested the following on top of linux-2.6 (stable 2.6.30-rc) d91dfbb41bb2e9bdbfbd2cc7078ed7436eab027a 0033-soc-camera-host-driver-cleanup.patch 0034-soc-camera-remove-an-extra-device-generation-from-s.patch 0035-soc-camera-simplify-register-access-routines-in-mul.patch So far OK. However, applying 0036- or v2 from the mailing list results in rejects (probably because linux-next vs linux-2.6 differences) but the files should not affect Migo-R. So with 0036 or v2 applied it builds ok for Migo-R, but I can't open /dev/video0 for some reason. Reverting the patch and only using 0033-0035 above results in ok /dev/video0 opening. Did you have video drivers build in or as modules? If modules - in which order did you load them? Unfortunately, at the moment it might be important:-( What's in dmesg after loading all drivers? They are compiled-in. No modules. What are your dependencies? I'll try out your 20090415/series on top of the matching linux-next for now. So linux-next fa169db2b277ebafa466d625ed2d16b2d2a4bc82 with 20090415/series applies without any rejects and compiles just fine for Migo-R. However, during runtime I experience the same problem as with 2.6.30-rc plus 0033-0035 + 0036 or v2: / # /mplayer -flip -vf mirror -quiet tv:// MPlayer dev-SVN-rUNKNOWN-4.2-SH4-LINUX_v0701 (C) 2000-2008 MPlayer Team Playing tv://. TV file format detected. Selected driver: v4l2 name: Video 4 Linux 2 input author: Martin Olschewski olschew...@zpr.uni-koeln.de comment: first try, more to come ;-) v4l2: unable to open '/dev/video0': No such device or address v4l2: ioctl set mute failed: Bad file descriptor v4l2: 0 frames successfully processed, 0 frames dropped. Exiting... (End of file) / # Removing 0036 unbreaks the code and mplayer/capture.c works as expected. I also tried out v2 of your soc-camera-platform patch but it still does not work. Can you please test on your Migo-R board? I'd be happy to assist you in setting up your environment. / magnus -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
On Mon, 20 Apr 2009, Magnus Damm wrote: So linux-next fa169db2b277ebafa466d625ed2d16b2d2a4bc82 with 20090415/series applies without any rejects and compiles just fine for Migo-R. However, during runtime I experience the same problem as with 2.6.30-rc plus 0033-0035 + 0036 or v2: / # /mplayer -flip -vf mirror -quiet tv:// MPlayer dev-SVN-rUNKNOWN-4.2-SH4-LINUX_v0701 (C) 2000-2008 MPlayer Team Playing tv://. TV file format detected. Selected driver: v4l2 name: Video 4 Linux 2 input author: Martin Olschewski olschew...@zpr.uni-koeln.de comment: first try, more to come ;-) v4l2: unable to open '/dev/video0': No such device or address v4l2: ioctl set mute failed: Bad file descriptor v4l2: 0 frames successfully processed, 0 frames dropped. Exiting... (End of file) / # Removing 0036 unbreaks the code and mplayer/capture.c works as expected. I also tried out v2 of your soc-camera-platform patch but it still does not work. Can you please test on your Migo-R board? I'd be happy to assist you in setting up your environment. I did test it and it worked - exactly as you say - with the entire patch stack + v2 of soc-camera: convert to platform device, the only difference that I can see so far, is that I used modules. So, you can either look in dmesg for driver initialisation whether ov772x and tw9910 have found theit i2c chips, or just wait until I test a monolitic build myself. It can be problematic if the i2c-host driver initialises too late... If you want to test a modular build it would be enough to just have sh_mobile_ceu_camera.ko as a module, the rest can stay built in. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
On Mon, Apr 20, 2009 at 5:14 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 20 Apr 2009, Magnus Damm wrote: Can you please test on your Migo-R board? I'd be happy to assist you in setting up your environment. I did test it and it worked - exactly as you say - with the entire patch stack + v2 of soc-camera: convert to platform device, the only difference that I can see so far, is that I used modules. So, you can either look in dmesg for driver initialisation whether ov772x and tw9910 have found theit i2c chips, or just wait until I test a monolitic build myself. It can be problematic if the i2c-host driver initialises too late... If you want to test a modular build it would be enough to just have sh_mobile_ceu_camera.ko as a module, the rest can stay built in. I prefer to wait then. Please consider the built-in case broken. Usually I get some output similar to this during boot: camera 0-0: SuperH Mobile CEU driver attached to camera 0 camera 0-0: ov7725 Product ID 77:21 Manufacturer ID 7f:a2 camera 0-0: SuperH Mobile CEU driver detached from camera 0 But with the convert to platform device patch appied I see nothing like that. The migor_defconfig should give you the static non-module configuration that is broken. Cheers, / magnus -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
v4l2-subdev Re: [PATCH 0/5] soc-camera: convert to platform device
On Mon, 20 Apr 2009, Magnus Damm wrote: On Mon, Apr 20, 2009 at 5:14 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 20 Apr 2009, Magnus Damm wrote: Can you please test on your Migo-R board? I'd be happy to assist you in setting up your environment. I did test it and it worked - exactly as you say - with the entire patch stack + v2 of soc-camera: convert to platform device, the only difference that I can see so far, is that I used modules. So, you can either look in dmesg for driver initialisation whether ov772x and tw9910 have found theit i2c chips, or just wait until I test a monolitic build myself. It can be problematic if the i2c-host driver initialises too late... If you want to test a modular build it would be enough to just have sh_mobile_ceu_camera.ko as a module, the rest can stay built in. I prefer to wait then. Please consider the built-in case broken. Usually I get some output similar to this during boot: camera 0-0: SuperH Mobile CEU driver attached to camera 0 camera 0-0: ov7725 Product ID 77:21 Manufacturer ID 7f:a2 camera 0-0: SuperH Mobile CEU driver detached from camera 0 But with the convert to platform device patch appied I see nothing like that. The migor_defconfig should give you the static non-module configuration that is broken. Ok, static build is indeed broken. The reason is the wrong initialisation order. First, internally we have to link camera host drivers after camera device drivers, that's easy. But unfortunately that alone doesn't help. The second problem is that i2c is linked after media, or, maybe rather media is linked before i2c. Currently in drivers/Makefile media is on the same line as base and block, way before IDE, ATA, SCSI, firewire, mtd, spi, usb, input... Is there a reason for that? Mauro, would anything break if we move it down right after i2c? Another hackish interim solution would be to replace module_init with subsys_init in i2c-sh_mobile.c like some other i2c adapters do (including MXC, PXA). That's certainly easier, but then we'd also have to modify i2c-imx, later maybe i2c-at91.c... Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: v4l2-subdev Re: [PATCH 0/5] soc-camera: convert to platform device
On Mon, Apr 20, 2009 at 03:50:44PM +0200, Guennadi Liakhovetski wrote: break if we move it down right after i2c? Another hackish interim solution would be to replace module_init with subsys_init in i2c-sh_mobile.c like some other i2c adapters do (including MXC, PXA). That's certainly easier, but then we'd also have to modify i2c-imx, later maybe i2c-at91.c... That'd be sensible long term anyway - voltage and current regulators are often I2C devices and they need to be initialised very early in order to be available for general use. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: v4l2-subdev Re: [PATCH 0/5] soc-camera: convert to platform device
On Mon, 20 Apr 2009, Mark Brown wrote: On Mon, Apr 20, 2009 at 03:50:44PM +0200, Guennadi Liakhovetski wrote: break if we move it down right after i2c? Another hackish interim solution would be to replace module_init with subsys_init in i2c-sh_mobile.c like some other i2c adapters do (including MXC, PXA). That's certainly easier, but then we'd also have to modify i2c-imx, later maybe i2c-at91.c... That'd be sensible long term anyway - voltage and current regulators are often I2C devices and they need to be initialised very early in order to be available for general use. If there are other requirements to have i2c initialise early we can well move it up the chain. I think it would be preferable to modifying each i2c host adapter driver to use subsys_init(). Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: v4l2-subdev Re: [PATCH 0/5] soc-camera: convert to platform device
On Mon, Apr 20, 2009 at 04:18:41PM +0200, Guennadi Liakhovetski wrote: If there are other requirements to have i2c initialise early we can well move it up the chain. I think it would be preferable to modifying each i2c host adapter driver to use subsys_init(). IIRC there are other ordering constraints on I2C in general that cause problems there in non-embedded cases but I might be misremembering. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
Hi Magnus http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Testing on Migo-R board with 2.6.30-rc2-git-something and the following cherry-picked patches: 0007-driver-core-fix-driver_match_device.patch 0033-soc-camera-host-driver-cleanup.patch 0034-soc-camera-remove-an-extra-device-generation-from-s.patch 0035-soc-camera-simplify-register-access-routines-in-mul.patch and part of 0036 (avoiding rejects, ap325 seems broken btw) Have I broken it or is it unrelated? I don't know about current 2.6.30-rc2 git. But when I used 2.6.30-rc1, It doesn't work either. The reason was soc_camera_bus_type doesn't has match function. please check 49b420a13ff95b449947181190b08367348e3e1b And please see http://marc.info/?t=12324585986r=1w=2 I send patch to this problem. 2009/03/31 [PATCH] soc_camera: Add soc_camera_match function And please check this patch. This patch needed on ov772x, but may be rc2 already have it. 06/09: ov772x: wrong pointer for soc_camera_link is modified http://linuxtv.org/hg/~gliakhovetski/v4l-dvb?cmd=changeset;node=157893ad8d0b Best regards -- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
Hello, I've got one more thing to ask. Is SoC camera framework supporting for selecting video standards between camera interface and external camera module? I mean ITU-R BT 601 and 656 things. Or any different way that I'm not aware is supported? On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: This patch series is a preparation for the v4l2-subdev conversion. Please, review and test. My current patch-stack in the form of a (manually-created) quilt-series is at http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- DongSoo, Nathaniel Kim Engineer Mobile S/W Platform Lab. Digital Media Communications RD Centre Samsung Electronics CO., LTD. e-mail : dongsoo@gmail.com dongsoo45@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
Hi Guennadi, On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: This patch series is a preparation for the v4l2-subdev conversion. Please, review and test. My current patch-stack in the form of a (manually-created) quilt-series is at http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Testing on Migo-R board with 2.6.30-rc2-git-something and the following cherry-picked patches: 0007-driver-core-fix-driver_match_device.patch 0033-soc-camera-host-driver-cleanup.patch 0034-soc-camera-remove-an-extra-device-generation-from-s.patch 0035-soc-camera-simplify-register-access-routines-in-mul.patch and part of 0036 (avoiding rejects, ap325 seems broken btw) It compiles just fine, boots up allright, but I can't open /dev/video0 anymore. It's still supposed to work with all drivers compiled-in, right? I'll investigate a bit more and update to latest linux-2.6 git. / magnus -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
On Fri, 17 Apr 2009, Dongsoo, Nathaniel Kim wrote: I've got one more thing to ask. Is SoC camera framework supporting for selecting video standards between camera interface and external camera module? I mean ITU-R BT 601 and 656 things. Or any different way that I'm not aware is supported? I thought someone did it already, maybe there were some patches that didn't make it in yet, cannot find ATM. In any case, we do have a pretty advanced (!:-)) bus parameter negotiation infrastructure, so, you would just have a couple more SOCAM_* flags, like SOCAM_BT601, SOCAM_BT656 or similar and use them to configure your host-camera link, depending upon their capabilities and platform flags. See for example how SOCAM_MASTER / SOCAM_SLAVE is selected. Also don't forget to extend the soc_camera_bus_param_compatible() function. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
On Fri, Apr 17, 2009 at 4:51 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 17 Apr 2009, Magnus Damm wrote: On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: This patch series is a preparation for the v4l2-subdev conversion. Please, review and test. My current patch-stack in the form of a (manually-created) quilt-series is at http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Testing on Migo-R board with 2.6.30-rc2-git-something and the following cherry-picked patches: 0007-driver-core-fix-driver_match_device.patch 0033-soc-camera-host-driver-cleanup.patch 0034-soc-camera-remove-an-extra-device-generation-from-s.patch 0035-soc-camera-simplify-register-access-routines-in-mul.patch and part of 0036 (avoiding rejects, ap325 seems broken btw) Have I broken it or is it unrelated? 2.6.30-rc seems broken on Migo-R. A quick check suggests the following: V4L/DVB (10141): OK V4L/DVB (10672): BAD V4L/DVB (11024): BAD OK means mplayer capture works as excepted with CEU and ov772x. BAD means failure to open() /dev/video0 in the case of CEU. vivi works fine. Morimoto-san and/or Guennadi, do you see the same thing? Cheers, / magnus -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
On Fri, 17 Apr 2009, Magnus Damm wrote: On Fri, Apr 17, 2009 at 4:51 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 17 Apr 2009, Magnus Damm wrote: On Wed, Apr 15, 2009 at 9:17 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: This patch series is a preparation for the v4l2-subdev conversion. Please, review and test. My current patch-stack in the form of a (manually-created) quilt-series is at http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Testing on Migo-R board with 2.6.30-rc2-git-something and the following cherry-picked patches: 0007-driver-core-fix-driver_match_device.patch 0033-soc-camera-host-driver-cleanup.patch 0034-soc-camera-remove-an-extra-device-generation-from-s.patch 0035-soc-camera-simplify-register-access-routines-in-mul.patch and part of 0036 (avoiding rejects, ap325 seems broken btw) Have I broken it or is it unrelated? 2.6.30-rc seems broken on Migo-R. A quick check suggests the following: Ok, before we come to Migo-R, what is with ap325? Have I broken it with this my series or is it a different problem? V4L/DVB (10141): OK V4L/DVB (10672): BAD V4L/DVB (11024): BAD These seem to be pretty random snapshots... Are they all on Linus' master or on next or on v4l-dvb? You did pick up the 0007-driver-core-fix-driver_match_device.patch above, so, you know about that problem (I am very much surprised in fact that patch is still not in the mainline, just sent a reminder...), and you did use it in all your tests with kernels past 49b420a13ff95b449947181190b08367348e3e1b didn't you? OK means mplayer capture works as excepted with CEU and ov772x. BAD means failure to open() /dev/video0 in the case of CEU. vivi works fine. Morimoto-san and/or Guennadi, do you see the same thing? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
Robert Jarzmik robert.jarz...@free.fr writes: I need to make some additionnal tests with I2C loading/unloading, but otherwise it works perfectly for (soc_camera / pxa_camera /mt9m111 combination). Guennadi, I made some testing, and there is something I don't understand in the new device model. This is the testcase I'm considering : - I unload i2c-pxa, pxa-camera, mt9m111, soc-camera modules - I load pxa-camera, mt9m111, soc-camera modules - I then load i2c-pxa = the mt9m111 is not detected - I unload and reload mt9m111 and pxa_camera = not any better - I unload soc_camera, mt9m111, pxa_camera and reload = this time the video device is detected What I'm getting at is that if soc_camera is loaded before the i2c host driver, no camera will get any chance to work. Is that normal considering the new driver model ? I was naively thinking that there would be a rescan when the control was being available for a sensor. Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
On Thu, 16 Apr 2009, Robert Jarzmik wrote: Robert Jarzmik robert.jarz...@free.fr writes: I need to make some additionnal tests with I2C loading/unloading, but otherwise it works perfectly for (soc_camera / pxa_camera /mt9m111 combination). Guennadi, I made some testing, and there is something I don't understand in the new device model. This is the testcase I'm considering : - I unload i2c-pxa, pxa-camera, mt9m111, soc-camera modules - I load pxa-camera, mt9m111, soc-camera modules - I then load i2c-pxa = the mt9m111 is not detected correct - I unload and reload mt9m111 and pxa_camera = not any better Actually, I think, in this case it should be found again, as long as you reload pxa-camera while i2c-pxa is already loaded. - I unload soc_camera, mt9m111, pxa_camera and reload = this time the video device is detected What I'm getting at is that if soc_camera is loaded before the i2c host driver, no camera will get any chance to work. Is that normal considering the new driver model ? I was naively thinking that there would be a rescan when the control was being available for a sensor. Yes, unfortunately, it is normal:-( On the one hand, we shouldn't really spend _too_ much time on this intermediate version, because, as I said, it is just a preparatory step for v4l2-subdev. We just have to make sure it doesn't introduce any significant regressions and doesn't crash too often. OTOH, this is also how it is with v4l2-subdev. With it you first must have the i2c-adapter driver loaded. Then, when a match between a camera host and a camera client (sensor) platform device is detected, it is reported to the v4l2-subdev core, which loads the respective camera i2c driver. If you then unload the camera-host and i2c adapter drivers, and then you load the camera-host driver, it then fails to get the adapter, and if you then load it, nothing else happens. To reprobe you have to unload and reload the camera host driver. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: - I unload and reload mt9m111 and pxa_camera = not any better Actually, I think, in this case it should be found again, as long as you reload pxa-camera while i2c-pxa is already loaded. Damn, you're right. I cross-checked, and reloading pxa_camera rescans the sensor. What I'm getting at is that if soc_camera is loaded before the i2c host driver, no camera will get any chance to work. Is that normal considering the new driver model ? I was naively thinking that there would be a rescan when the control was being available for a sensor. Yes, unfortunately, it is normal:-( On the one hand, we shouldn't really spend _too_ much time on this intermediate version, because, as I said, it is just a preparatory step for v4l2-subdev. We just have to make sure it doesn't introduce any significant regressions and doesn't crash too often. OK. So from my side everything is OK (let aside my nitpicking in mioa701.c and mt9m111.c). OTOH, this is also how it is with v4l2-subdev. With it you first must have the i2c-adapter driver loaded. Then, when a match between a camera host and a camera client (sensor) platform device is detected, it is reported to the v4l2-subdev core, which loads the respective camera i2c driver. OK, why not. If you then unload the camera-host and i2c adapter drivers, and then you load the camera-host driver, it then fails to get the adapter, and if you then load it, nothing else happens. To reprobe you have to unload and reload the camera host driver. So be it. I'm sure we'll be through it once more in the v4l2-subdev transition, so I'll let aside any objection I could mutter :) Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/5] soc-camera: convert to platform device
This patch series is a preparation for the v4l2-subdev conversion. Please, review and test. My current patch-stack in the form of a (manually-created) quilt-series is at http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] soc-camera: convert to platform device
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: This patch series is a preparation for the v4l2-subdev conversion. Please, review and test. My current patch-stack in the form of a (manually-created) quilt-series is at http://www.open-technology.de/download/20090415/ based on linux-next history branch, commit ID in -base file. Don't be surprised, that patch-set also contains a few not directly related patches. Right, apart from a few comments, the bright side is your serie resists my full test campaign. I need to make some additionnal tests with I2C loading/unloading, but otherwise it works perfectly for (soc_camera / pxa_camera /mt9m111 combination). Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
