Re: [RFCv2 PATCH 0/9] Integration of videobuf2 with dmabuf
Hi Sumit, On Tuesday 20 March 2012 20:45:00 Semwal, Sumit wrote: On Tue, Mar 6, 2012 at 5:08 PM, Tomasz Stanislawski wrote: Hello everyone, This patchset is an incremental patch to patchset created by Sumit Semwal [1]. The patches are dedicated to help find a better solution for support of buffer sharing by V4L2 API. It is expected to start discussion on the final installment for dma-buf in vb2-dma-contig allocator. Current version of the patches contain little documentation. It is going to be fixed after achieving consensus about design for buffer exporting. Moreover the API between vb2-core and the allocator should be revised. I like your approach in general quite a bit. May I request you, though, to maybe split it over into two portions - the preparation patches, and the exporter portion. This would help as the exporter portion is quite dependent on dma_get_pages and dma-mapping patches. (Maybe also indirectly on DRM prime?) With that split, we could try to target the preparation patches for 3.4 while we continue to debate on the exporter patches? I just saw the dma-mapping pull request from Marek, so the dependencies might become available soon. If you agree, then I can post the patch version of my 'v4l2 as dma-buf user' patches, [except the patch that you've included in this series] so we can try to hit 3.4 merge window. I've raised a couple of questions regarding the first patch, I'm afraid we will likely miss 3.4 :-/ If you consider important to get the patches in 3.4 I can try working with Tomasz to fix them ASAP. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFCv2 PATCH 0/9] Integration of videobuf2 with dmabuf
Hi Tomasz, On Tue, Mar 6, 2012 at 5:08 PM, Tomasz Stanislawski t.stanisl...@samsung.com wrote: Hello everyone, This patchset is an incremental patch to patchset created by Sumit Semwal [1]. The patches are dedicated to help find a better solution for support of buffer sharing by V4L2 API. It is expected to start discussion on the final installment for dma-buf in vb2-dma-contig allocator. Current version of the patches contain little documentation. It is going to be fixed after achieving consensus about design for buffer exporting. Moreover the API between vb2-core and the allocator should be revised. I like your approach in general quite a bit. May I request you, though, to maybe split it over into two portions - the preparation patches, and the exporter portion. This would help as the exporter portion is quite dependent on dma_get_pages and dma-mapping patches. (Maybe also indirectly on DRM prime?) With that split, we could try to target the preparation patches for 3.4 while we continue to debate on the exporter patches? I just saw the dma-mapping pull request from Marek, so the dependencies might become available soon. If you agree, then I can post the patch version of my 'v4l2 as dma-buf user' patches, [except the patch that you've included in this series] so we can try to hit 3.4 merge window. snip Best regards, ~Sumit. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFCv2 PATCH 0/9] Integration of videobuf2 with dmabuf
Hello everyone, This patchset is an incremental patch to patchset created by Sumit Semwal [1]. The patches are dedicated to help find a better solution for support of buffer sharing by V4L2 API. It is expected to start discussion on the final installment for dma-buf in vb2-dma-contig allocator. Current version of the patches contain little documentation. It is going to be fixed after achieving consensus about design for buffer exporting. Moreover the API between vb2-core and the allocator should be revised. The patches were successfully tested to cooperate with EXYNOS DRM driver using DMABUF mechanism. Please note, that the amount of changes to vb2-dma-contig.c was significant making the difference patch very difficult to read. The patchset makes use of dma_get_pages extension for DMA API, which is posted on a top of dma-mapping patches by Marek Szyprowski [4] [5]. The tree, that contains all needed patches, can be found here [6]. v2: - extended VIDIOC_EXPBUF argument from integer memoffset to struct v4l2_exportbuffer - added patch that breaks DMABUF spec on (un)map_atachment callcacks but allows to work with existing implementation of DMABUF prime in DRM - all dma-contig code refactoring patches were squashed - bugfixes v1: List of changes since [1]. - support for DMA api extension dma_get_pages, the function is used to retrieve pages used to create DMA mapping. - small fixes/code cleanup to videobuf2 - added prepare and finish callbacks to vb2 allocators, it is used keep consistency between dma-cpu acess to the memory (by Marek Szyprowski) - support for exporting of DMABUF buffer in V4L2 and Videobuf2, originated from [3]. - support for dma-buf exporting in vb2-dma-contig allocator - support for DMABUF for s5p-tv and s5p-fimc (capture interface) drivers, originated from [3] - changed handling for userptr buffers (by Marek Szyprowski, Andrzej Pietrasiewicz) - let mmap method to use dma_mmap_writecombine call (by Marek Szyprowski) [1] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/42966/focus=42968 [2] https://lkml.org/lkml/2011/12/26/29 [3] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/36354/focus=36355 [4] http://thread.gmane.org/gmane.linux.kernel.cross-arch/12819 [5] http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/heads/3.3-rc5-dma-v7 [6] http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/heads/3.3-rc5-vb2-dma-contig-dmabuf-drm Sumit Semwal (1): v4l: vb2: Add dma-contig allocator as dma_buf user Tomasz Stanislawski (8): v4l: vb2: fixes for DMABUF support v4l: vb2-dma-contig: update and code refactoring v4l: add buffer exporting via dmabuf v4l: vb2: add buffer exporting via dmabuf v4l: vb2-dma-contig: add support for DMABUF exporting v4l: vb2-dma-contig: change map/unmap behaviour v4l: fimc: integrate capture i-face with dmabuf v4l: s5p-tv: mixer: integrate with dmabuf drivers/media/video/Kconfig |1 + drivers/media/video/s5p-fimc/fimc-capture.c | 11 +- drivers/media/video/s5p-tv/Kconfig |1 + drivers/media/video/s5p-tv/mixer_video.c| 12 +- drivers/media/video/v4l2-compat-ioctl32.c |1 + drivers/media/video/v4l2-ioctl.c| 11 + drivers/media/video/videobuf2-core.c| 88 +++- drivers/media/video/videobuf2-dma-contig.c | 717 --- include/linux/videodev2.h | 20 + include/media/v4l2-ioctl.h |2 + include/media/videobuf2-core.h |8 +- 11 files changed, 779 insertions(+), 93 deletions(-) -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
