Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-06-03 Thread Davor Emard
 Didn't have time to look for gpios, tomorrow I will have. But I can
 tell that this change is not working for me:
 
   case SAA7134_BOARD_VIDEOMATE_T750:
   dev-has_remote = SAA7134_REMOTE_GPIO;
   saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8082c000, 0x8082c000);
   saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8082c000, 0x0080c000);
   break;

Thanx for testing it out, If it doesn't work, try this:

saa_andorl(SAA7134_GPIO_GPMODE0  2,   /* keep */ 0x8082c000, /* keep */   
0x8082c000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, /* keep */ 0x8082c000, /* modify */ 
0x0080c000);

modify only the indicated number, try 0, try 0x8082c000 and if
you have time try all combinations of bits 0x8082c000 optionally set to 0
e.g. 0x8002c000, 0x8080c000, 0x80828000, 0x0080c000 etc...

It is possible that you and I don't have same revision of the
card and you need a slightly different initialization procedure.
If you get something to work for your card then I can try it back at
mine there's a changes that we get a common setup which works for both.

 OK, I'm not having any personal opinion about the keys nor a
 application which I'm using, I'm just noticed that the keys differ
 against standard keys defined at linuxtv wiki. But if the keys at
 wiki are not correct, then perhaps should we change them there and
 let all use the same keys.
 
 If we have standard keys, than userspace applications programmers
 can make a use of it and assign the keys to their applications and
 to have just work experience to their users. But maybe I'm terrible
 wrong...

Yeah I know, almost every remote has its own logic so it seems my version
is yet-another-bla... I'm hoping for upcoming X11 xinput2 layer hopefully 
get full support of MCE remotes and nicely integrate with X applications
therefore I produced MCE stuff here for a challenge to the xinput2

For integrated TV and PC to work well we need all remote keys be different 
than any other existing key used by keyboard.

Without this, when X11 based TV view application gets out of input focus
means it becomes irresponsive to ambiguity keys on the remote controller 
(in this example cursor keys) and we need to first use mouse to click on 
TV application and then continue using cursors on remote control 
(imagine how practical it is to make mouse click when watching TV from sofa) 

best regards, d.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-06-03 Thread semiRocket
On Thu, 03 Jun 2010 16:04:07 +0200, Davor Emard davorem...@gmail.com  
wrote:



Didn't have time to look for gpios, tomorrow I will have. But I can
tell that this change is not working for me:

case SAA7134_BOARD_VIDEOMATE_T750:
dev-has_remote = SAA7134_REMOTE_GPIO;
saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8082c000, 0x8082c000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8082c000, 0x0080c000);
break;


Thanx for testing it out, If it doesn't work, try this:

saa_andorl(SAA7134_GPIO_GPMODE0  2,   /* keep */ 0x8082c000, /* keep  
*/   0x8082c000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, /* keep */ 0x8082c000, /* modify  
*/ 0x0080c000);


modify only the indicated number, try 0, try 0x8082c000 and if
you have time try all combinations of bits 0x8082c000 optionally set to 0
e.g. 0x8002c000, 0x8080c000, 0x80828000, 0x0080c000 etc...

It is possible that you and I don't have same revision of the
card and you need a slightly different initialization procedure.
If you get something to work for your card then I can try it back at
mine there's a changes that we get a common setup which works for both.



OK, do I need to do cold boot or reboot anytime I try different gpio value?
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-06-02 Thread semiRocket
On Mon, 31 May 2010 09:52:14 +0200, Davor Emard davorem...@gmail.com  
wrote:



HI!

I just went to compro website and have seen that *f cards
have some identical MCE-alike but also slightly different remotes,
so we have to invent some better names to distinguish between
them (compro itself might have some names for them)

d.


Hi,


Tested your new patch with Gerd's input-events utility. input-events is  
reporting wrong key (KEY_MIN_INTERESTING) for KEY_MUTE, not sure why.


input-events is reporting ??? for all KEY_NUMERIC_*.


Perhaps you could use KEY_PREVIOUS and KEY_NEXT instead of  
KEY_PREVIOUSSONG and KEY_NEXTSONG.


For the naming you could use K100

http://www.comprousa.com/en/pctv_remote.php

Lirc has definitions for K300 and it seems that it's using totally  
different codes:

http://lirc.sourceforge.net/remotes/compro/VideoMate-K300

So I think too this would be a better naming sheme.


Regards,
Samuel
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-06-02 Thread Davor Emard
 HI!
 
 I just went to compro website and have seen that *f cards
 have some identical MCE-alike but also slightly different remotes,
 so we have to invent some better names to distinguish between
 them (compro itself might have some names for them)
 
 Tested your new patch with Gerd's input-events utility. input-events
 is reporting wrong key (KEY_MIN_INTERESTING) for KEY_MUTE, not sure
 why.

HI! Is at least tuner (and loading of the firmware) working now without 
preinitialization with windows?

About remote keys:
My evtest in debian is outdated (probably also your input-events). 
Not only it doesn't support all KEY_*s but also for some existing keys it 
reports the wrong names (like KEY_MIN_INTERESTING). 

Try it with xev, at least MUTE should work correctly there (reports 
XF86AudioMute).
However KEY_NUMERIC_* won't be recognized by xev because X11 doesn't map
them to anything by default

However only the input layer keycodes matter, we can ignore it's name 
interpreted 
by some application (every app may name it different or even wrong...).

The tools should be compiled against latest /usr/include/linux/input.h
and have all new key names there (and corrected some existing names).

My intention was to map remote key pictograms to most appropriate
event in latest kernel's input.h, avoiding PC keyboard ambiguity as
much as I can.

Because in the kernel they have expanded input.h with a number of new keys to 
better cover MCE remotes and new media keyboards, so you get those ??? for
old apps but the keycode numbers should still be correct according to the 
kernel's input layer. input layer Applications map key events to the keycode 
numbers, and have freedom to give any name to the key.

The KEY_PREVIOUS and KEY_NEXT are actually keys for prev page and
next page on the keyboard, used for scrolling text. PREVIOUSSONG 
NEXTSIONG are used to skip to songs and are also expanded to skipping
to video DVD chapters, so I thought they are more appropriate for the
remote pictograms | | at VCR key group. I wanted to avoid ambiguity
between keyboard events and remote, however I still have KEY_ENTER
and KEY_BACKSPACE and the cursors, which is in ambiguity to the
normal keyboard - any idea what to replace them with in MCE style?

I have no issue of mapping all current keys to VDR. If you have any real issue 
of
mapping keys to some other TV view application or to the linux console or X11, 
feel free to change them and suggest a patch

d.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-06-02 Thread Davor Emard
HI!

Have you tested my lastest GPIO suggestion, or come up
with your own initialization? Does it allow
to load firmware without windows booting?

Key namings of the remote must be some from linux input.h
I welcome you to change whatever is needed to fit any of your
application if current scheme is not suitable. I use VDR whcih 
can adapt to just anything event layer gives.

d.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-06-02 Thread Samuel Rakitničan
On Wed, 02 Jun 2010 20:27:59 +0200, Davor Emard davorem...@gmail.com  
wrote:



HI!

Have you tested my lastest GPIO suggestion, or come up
with your own initialization? Does it allow
to load firmware without windows booting?



Didn't have time to look for gpios, tomorrow I will have. But I can tell  
that this change is not working for me:


case SAA7134_BOARD_VIDEOMATE_T750:
dev-has_remote = SAA7134_REMOTE_GPIO;
saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8082c000, 0x8082c000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8082c000, 0x0080c000);
break;


Key namings of the remote must be some from linux input.h
I welcome you to change whatever is needed to fit any of your
application if current scheme is not suitable. I use VDR whcih
can adapt to just anything event layer gives.

d.


OK, I'm not having any personal opinion about the keys nor a application  
which I'm using, I'm just noticed that the keys differ against standard  
keys defined at linuxtv wiki. But if the keys at wiki are not correct,  
then perhaps should we change them there and let all use the same keys.


If we have standard keys, than userspace applications programmers can make  
a use of it and assign the keys to their applications and to have just  
work experience to their users. But maybe I'm terrible wrong...



Best regards,
Samuel
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-31 Thread Davor Emard
HI!

I just went to compro website and have seen that *f cards
have some identical MCE-alike but also slightly different remotes, 
so we have to invent some better names to distinguish between 
them (compro itself might have some names for them)

d.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-30 Thread Davor Emard
HI!

I have downloaded latest hg v4l and adapted the compro 
t750f support patch. The patch is the same but v4l code is
newer so there's some improvement

Restarting VDR is now stable. Tried it cca 10x VDR restarts, 
DVB-T tuner always worked. Remote still has 10% keys lost.

ALSA device now appears with alsa=1 in the list
arecord -l (but I haven't tried to capture anything yet)

Someone mentioned that MCE-alike remote is the same to all 
f-series of the cards so I called it rc-videomate-f.

Here's the patch

diff -r 304cfde05b3f linux/drivers/media/IR/keymaps/Makefile
--- a/linux/drivers/media/IR/keymaps/Makefile   Tue May 25 23:50:51 2010 -0400
+++ b/linux/drivers/media/IR/keymaps/Makefile   Mon May 31 01:18:12 2010 +0200
@@ -63,5 +63,6 @@
rc-tt-1500.o \
rc-videomate-s350.o \
rc-videomate-tv-pvr.o \
+   rc-videomate-f.o \
rc-winfast.o \
rc-winfast-usbii-deluxe.o
diff -r 304cfde05b3f linux/drivers/media/video/saa7134/saa7134-cards.c
--- a/linux/drivers/media/video/saa7134/saa7134-cards.c Tue May 25 23:50:51 
2010 -0400
+++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Mon May 31 01:18:12 
2010 +0200
@@ -4920,12 +4920,14 @@
},
[SAA7134_BOARD_VIDEOMATE_T750] = {
/* John Newbigin j...@it.swin.edu.au */
+   /* Emard 2010-05-10 v18-v4l davorem...@gmail.com */
.name   = Compro VideoMate T750,
.audio_clock= 0x00187de7,
.tuner_type = TUNER_XC2028,
.radio_type = UNSET,
-   .tuner_addr = ADDR_UNSET,
+   .tuner_addr = 0x61,
.radio_addr = ADDR_UNSET,
+   .mpeg   = SAA7134_MPEG_DVB,
.inputs = {{
.name   = name_tv,
.vmux   = 3,
@@ -6752,6 +6754,11 @@
msleep(10);
saa7134_set_gpio(dev, 18, 1);
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   saa7134_set_gpio(dev, 20, 0);
+   msleep(10);
+   saa7134_set_gpio(dev, 20, 1);
+   break;
}
return 0;
}
@@ -7171,6 +7178,11 @@
saa_andorl(SAA7134_GPIO_GPMODE0  2,   0xC000, 0xC000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0xC000, 0xC000);
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   dev-has_remote = SAA7134_REMOTE_GPIO;
+   saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
+   saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
+   break;
}
return 0;
 }
diff -r 304cfde05b3f linux/drivers/media/video/saa7134/saa7134-dvb.c
--- a/linux/drivers/media/video/saa7134/saa7134-dvb.c   Tue May 25 23:50:51 
2010 -0400
+++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c   Mon May 31 01:18:12 
2010 +0200
@@ -55,6 +55,7 @@
 #include tda8290.h
 
 #include zl10353.h
+#include qt1010.h
 
 #include zl10036.h
 #include zl10039.h
@@ -886,6 +887,17 @@
.disable_i2c_gate_ctrl = 1,
 };
 
+static struct zl10353_config videomate_t750_zl10353_config = {
+   .demod_address  = 0x0f,
+   .no_tuner = 1,
+   .parallel_ts = 1,
+};
+
+static struct qt1010_config videomate_t750_qt1010_config = {
+   .i2c_address = 0x62
+};
+
+
 /* ==
  * tda10086 based DVB-S cards, helper functions
  */
@@ -1569,6 +1581,21 @@
__func__);
 
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   printk(Compro VideoMate T750 DVB setup\n);
+   fe0-dvb.frontend = dvb_attach(zl10353_attach,
+   videomate_t750_zl10353_config,
+   dev-i2c_adap);
+   if (fe0-dvb.frontend != NULL) {
+   // if there is a gate function then the i2c bus 
breaks.!
+   fe0-dvb.frontend-ops.i2c_gate_ctrl = 0;
+   if (dvb_attach(qt1010_attach,
+   fe0-dvb.frontend,
+   dev-i2c_adap,
+   videomate_t750_qt1010_config) == NULL)
+   wprintk(error attaching QT1010\n);
+   }
+   break;
case SAA7134_BOARD_ZOLID_HYBRID_PCI:
fe0-dvb.frontend = dvb_attach(tda10048_attach,
   zolid_tda10048_config,
diff -r 304cfde05b3f linux/drivers/media/video/saa7134/saa7134-input.c
--- a/linux/drivers/media/video/saa7134/saa7134-input.c Tue May 25 23:50:51 
2010 -0400
+++ 

Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-30 Thread hermann pitton

Hi Davor,

Am Montag, den 31.05.2010, 01:48 +0200 schrieb Davor Emard:
 HI!
 
 I have downloaded latest hg v4l and adapted the compro 
 t750f support patch. The patch is the same but v4l code is
 newer so there's some improvement
 
 Restarting VDR is now stable. Tried it cca 10x VDR restarts, 
 DVB-T tuner always worked. Remote still has 10% keys lost.
 
 ALSA device now appears with alsa=1 in the list
 arecord -l (but I haven't tried to capture anything yet)
 
 Someone mentioned that MCE-alike remote is the same to all 
 f-series of the cards so I called it rc-videomate-f.
 
 Here's the patch

likely one of the most difficult cards on that driver during the last
time.

Does't look such bad to me, after all, without having one.

Hmm, somehow its #define in the saa7134.h header is missing?

I'm also wondering, why we don't see the usual three lines offset on the
end of current patches.

Cheers,
Hermann


 diff -r 304cfde05b3f linux/drivers/media/IR/keymaps/Makefile
 --- a/linux/drivers/media/IR/keymaps/Makefile Tue May 25 23:50:51 2010 -0400
 +++ b/linux/drivers/media/IR/keymaps/Makefile Mon May 31 01:18:12 2010 +0200
 @@ -63,5 +63,6 @@
   rc-tt-1500.o \
   rc-videomate-s350.o \
   rc-videomate-tv-pvr.o \
 + rc-videomate-f.o \
   rc-winfast.o \
   rc-winfast-usbii-deluxe.o
 diff -r 304cfde05b3f linux/drivers/media/video/saa7134/saa7134-cards.c
 --- a/linux/drivers/media/video/saa7134/saa7134-cards.c   Tue May 25 
 23:50:51 2010 -0400
 +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c   Mon May 31 
 01:18:12 2010 +0200
 @@ -4920,12 +4920,14 @@
   },
   [SAA7134_BOARD_VIDEOMATE_T750] = {
   /* John Newbigin j...@it.swin.edu.au */
 + /* Emard 2010-05-10 v18-v4l davorem...@gmail.com */
   .name   = Compro VideoMate T750,
   .audio_clock= 0x00187de7,
   .tuner_type = TUNER_XC2028,
   .radio_type = UNSET,
 - .tuner_addr = ADDR_UNSET,
 + .tuner_addr = 0x61,
   .radio_addr = ADDR_UNSET,
 + .mpeg   = SAA7134_MPEG_DVB,
   .inputs = {{
   .name   = name_tv,
   .vmux   = 3,
 @@ -6752,6 +6754,11 @@
   msleep(10);
   saa7134_set_gpio(dev, 18, 1);
   break;
 + case SAA7134_BOARD_VIDEOMATE_T750:
 + saa7134_set_gpio(dev, 20, 0);
 + msleep(10);
 + saa7134_set_gpio(dev, 20, 1);
 + break;
   }
   return 0;
   }
 @@ -7171,6 +7178,11 @@
   saa_andorl(SAA7134_GPIO_GPMODE0  2,   0xC000, 0xC000);
   saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0xC000, 0xC000);
   break;
 + case SAA7134_BOARD_VIDEOMATE_T750:
 + dev-has_remote = SAA7134_REMOTE_GPIO;
 + saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
 + saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
 + break;
   }
   return 0;
  }
 diff -r 304cfde05b3f linux/drivers/media/video/saa7134/saa7134-dvb.c
 --- a/linux/drivers/media/video/saa7134/saa7134-dvb.c Tue May 25 23:50:51 
 2010 -0400
 +++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c Mon May 31 01:18:12 
 2010 +0200
 @@ -55,6 +55,7 @@
  #include tda8290.h
  
  #include zl10353.h
 +#include qt1010.h
  
  #include zl10036.h
  #include zl10039.h
 @@ -886,6 +887,17 @@
   .disable_i2c_gate_ctrl = 1,
  };
  
 +static struct zl10353_config videomate_t750_zl10353_config = {
 + .demod_address  = 0x0f,
 + .no_tuner = 1,
 + .parallel_ts = 1,
 +};
 +
 +static struct qt1010_config videomate_t750_qt1010_config = {
 + .i2c_address = 0x62
 +};
 +
 +
  /* ==
   * tda10086 based DVB-S cards, helper functions
   */
 @@ -1569,6 +1581,21 @@
   __func__);
  
   break;
 + case SAA7134_BOARD_VIDEOMATE_T750:
 + printk(Compro VideoMate T750 DVB setup\n);
 + fe0-dvb.frontend = dvb_attach(zl10353_attach,
 + videomate_t750_zl10353_config,
 + dev-i2c_adap);
 + if (fe0-dvb.frontend != NULL) {
 + // if there is a gate function then the i2c bus 
 breaks.!
 + fe0-dvb.frontend-ops.i2c_gate_ctrl = 0;
 + if (dvb_attach(qt1010_attach,
 + fe0-dvb.frontend,
 + dev-i2c_adap,
 + videomate_t750_qt1010_config) == NULL)
 + wprintk(error attaching QT1010\n);
 + }
 +   

Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-30 Thread hermann pitton

 
 Hmm, somehow its #define in the saa7134.h header is missing?
 
 I'm also wondering, why we don't see the usual three lines offset on the
 end of current patches.

Forget about the later, is in new file mode.

Hermann



--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-30 Thread Davor Emard
HI

 
 Forget about the later, is in new file mode.

I wanted the new file but I don't know hg diff too much
so I just manually cat  to append to the hg diff output...

d.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-30 Thread Davor Emard
HI!

Can you also try this GPIO settings? It's my try to use last summer's
registers dump to setup gpio mask and value

case SAA7134_BOARD_VIDEOMATE_T750:
dev-has_remote = SAA7134_REMOTE_GPIO;
saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8082c000, 0x8082c000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8082c000, 0x0080c000);
break;
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-28 Thread Davor Emard
 The IR code suffered a major change during this development cycle. So, this 
 patch doesn't apply
 anymore.

OK, let's delay IR part for a while I'd like to try the new IR code,
mainly because of keystroke loss issue if the new code perhaps
works better.

In this patch is just my suggestion of remote key events to generate, 
(this a MCE alike remote) as you can see I avoided normal key events 
from ordinary keyboard (numeric 0-9) because now in the kernel are more 
suitable events for this for the OS to immediately recognize related 
keypress 1 and start the related application (e.g. TV viewer)

Emard
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-27 Thread Davor Emard
HI

This code is responsible to prepare the card to load the firmware
I have no true clue what it actually does, possible it is a
reset sequence for onboard tuner chips or just a matter of 
enabling some power to them. 

I have googled for compro 750 related discussions and seen various posts 
so I narrowed to this. Feel free to either comment out the code or
try slightly different values to see if they leat to more reliable
loading of the firmware at your hardware

+   case SAA7134_BOARD_VIDEOMATE_T750:
+   saa7134_set_gpio(dev, 20, 0);
+   msleep(10);
+   saa7134_set_gpio(dev, 20, 1);
+   break;

+   case SAA7134_BOARD_VIDEOMATE_T750:
+   dev-has_remote = SAA7134_REMOTE_GPIO;
+   saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
+   saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
+   break;

some similar cards use instead of 0x8000 use 0xC000
also it's possible to try other values if they can help on
your hardware (I tried a lots of them, some work, some don't 
but with not obvious improvement for my card so I left the 
minimum that works)

Emard
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-27 Thread Mauro Carvalho Chehab
Em Sun, 9 May 2010 20:48:22 +0200
Emard davorem...@gmail.com escreveu:

 Yes, almost everything:
 DVB-T, Analog TV, FM Radio, IR Remote control.
 
 I haven't tested too much analog TV (it seems to work,
 receivers some snowy channels but I don't have good antenna).
 Also didn't test video inputs at all.
 
 Not supported is onboard RTC timer that can wake up the 
 computer.
 
 Here's a cleaned up patch
 -
 
 --- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c.orig   
 2010-05-08 16:13:28.0 +0200
 +++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c
 2010-05-09 20:19:03.0 +0200
 @@ -4881,12 +4881,14 @@ struct saa7134_board saa7134_boards[] =
   },
   [SAA7134_BOARD_VIDEOMATE_T750] = {
   /* John Newbigin j...@it.swin.edu.au */
 + /* Emard 2010-05-09 v16 davorem...@gmail.com */
   .name   = Compro VideoMate T750,
   .audio_clock= 0x00187de7,
   .tuner_type = TUNER_XC2028,
   .radio_type = UNSET,
 - .tuner_addr = ADDR_UNSET,
 + .tuner_addr = 0x61,
   .radio_addr = ADDR_UNSET,
 + .mpeg   = SAA7134_MPEG_DVB,
   .inputs = {{
   .name   = name_tv,
   .vmux   = 3,
 @@ -6550,6 +6552,11 @@ static int saa7134_xc2028_callback(struc
   msleep(10);
   saa7134_set_gpio(dev, 18, 1);
   break;
 + case SAA7134_BOARD_VIDEOMATE_T750:
 + saa7134_set_gpio(dev, 20, 0);
 + msleep(10);
 + saa7134_set_gpio(dev, 20, 1);
 + break;
   }
   return 0;
   }
 @@ -6955,6 +6962,11 @@ int saa7134_board_init1(struct saa7134_d
   dev-has_remote = SAA7134_REMOTE_GPIO;
   saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
   saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
 + break;
 + case SAA7134_BOARD_VIDEOMATE_T750:
 + dev-has_remote = SAA7134_REMOTE_GPIO;
 + saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
 + saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
   break;
   }
   return 0;
 --- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c.orig 
 2010-05-08 16:20:12.0 +0200
 +++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c  2010-05-09 
 15:33:30.0 +0200
 @@ -55,6 +55,7 @@
  #include tda8290.h
  
  #include zl10353.h
 +#include qt1010.h
  
  #include zl10036.h
  #include zl10039.h
 @@ -886,6 +887,17 @@ static struct zl10353_config behold_x7_c
   .disable_i2c_gate_ctrl = 1,
  };
  
 +static struct zl10353_config videomate_t750_zl10353_config = {
 +   .demod_address  = 0x0f,
 +   .no_tuner = 1,
 +   .parallel_ts = 1,
 +};
 +
 +static struct qt1010_config videomate_t750_qt1010_config = {
 +   .i2c_address = 0x62
 +};
 +
 +
  /* ==
   * tda10086 based DVB-S cards, helper functions
   */
 @@ -1556,6 +1568,24 @@ static int dvb_init(struct saa7134_dev *
   __func__);
  
   break;
 +case SAA7134_BOARD_VIDEOMATE_T750:
 +printk(Compro VideoMate T750 DVB setup\n);
 +fe0-dvb.frontend = dvb_attach(zl10353_attach,
 +
 videomate_t750_zl10353_config,
 +dev-i2c_adap);
 +if (fe0-dvb.frontend != NULL) {
 +// if there is a gate function then the i2c bus 
 breaks.!
 +fe0-dvb.frontend-ops.i2c_gate_ctrl = 0;
 + 
 +if (dvb_attach(qt1010_attach,
 +   fe0-dvb.frontend,
 +   dev-i2c_adap,
 +   videomate_t750_qt1010_config) == 
 NULL)
 +{
 +wprintk(error attaching QT1010\n);
 +}
 +}
 +break;
   case SAA7134_BOARD_ZOLID_HYBRID_PCI:
   fe0-dvb.frontend = dvb_attach(tda10048_attach,
  zolid_tda10048_config,
 --- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-input.c.orig   
 2010-05-08 16:52:20.0 +0200
 +++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-input.c
 2010-05-09 17:32:25.0 +0200
 @@ -671,6 +671,11 @@ int saa7134_input_init1(struct saa7134_d
   mask_keycode = 0x003f00;
   mask_keydown = 0x04;
   break;
 + case SAA7134_BOARD_VIDEOMATE_T750:
 + ir_codes = ir_codes_videomate_t750_table;
 + mask_keycode 

Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-27 Thread Davor Emard
Another idea:

compare syslog line 
May 27 14:33:42 emard kernel: saa7133[0]: board init: gpio is 84bf00

when trying to load firmware without preparing with windows and
after windows - see if there's a difference between bits of the hex
value (0x84bf00 in my case)

that's a probable clue to modify this 0x0008000 value to either
include the missing bits or remove the excess ones

Emard
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-16 Thread semiRocket

On Mon, 10 May 2010 01:15:35 +0200, Emard davorem...@gmail.com wrote:


HI

This is even more cleanup from spaces into tabs
and replacing KEY_BACKSPACE with KEY_BACK
which I think is more appropriate for this remote.

compro t750f patch v17

About the remote - I noticed 2-10% of the keypresses
are not recognized, seems like it either looses packets
or saa7134 gpio should be scanned faster/better/more_reliable?
I think this may be the issue with other 7134 based
remotes too

Best Regards, Emard



Hi Davor,


Unfortunately it doesn't work for me. It can't load firmware like before,  
I've attached patch against recent hg tree I applied manually (without IR  
code part) and dmesg output.


In tvtime it shows black screen in PAL mode, if switch to SECAM, it's  
still black screen but with some random flickering occurring represented  
by horizontal red/green lines. No white/black dots noise present.


Thanks,
Samuel
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-16 Thread Samuel Rakitničan

Sorry, here's the attachments.


On Sun, 16 May 2010 12:38:03 +0200, semiRocket semiroc...@gmail.com  
wrote:



On Mon, 10 May 2010 01:15:35 +0200, Emard davorem...@gmail.com wrote:


HI

This is even more cleanup from spaces into tabs
and replacing KEY_BACKSPACE with KEY_BACK
which I think is more appropriate for this remote.

compro t750f patch v17

About the remote - I noticed 2-10% of the keypresses
are not recognized, seems like it either looses packets
or saa7134 gpio should be scanned faster/better/more_reliable?
I think this may be the issue with other 7134 based
remotes too

Best Regards, Emard



Hi Davor,


Unfortunately it doesn't work for me. It can't load firmware like  
before, I've attached patch against recent hg tree I applied manually  
(without IR code part) and dmesg output.


In tvtime it shows black screen in PAL mode, if switch to SECAM, it's  
still black screen but with some random flickering occurring represented  
by horizontal red/green lines. No white/black dots noise present.


Thanks,
Samuel

--
Lorem ipsum

hg-20100516.diff
Description: Binary data


dmesg
Description: Binary data


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-11 Thread davor emard
HI

I tried to fix unreliable IR remote keys (cca 10% lost key presses),
the similar problem has been reported on the same card with
windows driver too and I had other saa7134 analog tv card also
loosing IR keys

I have tried modifying saa7134-input.c to use gpio polling with interval
of 15ms and 5ms but it did not help - always some IR key presses are
lost.

Is it any workarond possible for lost keys, that's pretty annoying?
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-09 Thread Samuel Rakitničan

On Sun, 09 May 2010 19:32:43 +0200, Emard davorem...@gmail.com wrote:


Hmm, power on is pure hardware thing on this card I think, it
doesn't need a driver.


But it seems it needs a driver. Although pin is connected to MB power  
switch,

the card has to be in certain state (GPIOs programmed, pci standby power
enabled e.g.) in order for this to work.

Anyway, I have fixed the remote control issue and supported the
whole remote keycode set.

Here's the patch v15



(cc-ing linux-media)

Great! So everything works now?

Still cannot test this code as I've pulled new version of tree (from hg)  
which doesn't compile on my Slackware 13. In fact new tree compile to only  
a few kernel versions right now according to Hans Verkuil daily builds.




So you are aware that your diff must be in against current development  
tree in other to apply? According to recent changes keytables for remotes  
are presented as separate modules under linux/drivers/media/IR/keymaps:



http://linuxtv.org/hg/v4l-dvb/file/4a8d6d981f07/linux/drivers/media/IR/keymaps

One other thing is that t750 and t750f are shipped with two different  
remotes, so it may probably be needed to add code for auto detection  
between the two or add a modprobe parameter, or even add a separate card  
entry.


Older mail for reference:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg07478.html

In fact remote shipped with t750f is common between all f series I  
believe, so I think that it could be named rc-videomate-mce.c or  
rc-videomate-f-series.c.





---  
linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c.orig	2010-05-08  
16:13:28.0 +0200
+++  
linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c	2010-05-09  
17:35:29.0 +0200

@@ -4881,12 +4881,14 @@ struct saa7134_board saa7134_boards[] =
},
[SAA7134_BOARD_VIDEOMATE_T750] = {
/* John Newbigin j...@it.swin.edu.au */
+   /* Emard 2010-05-09 davorem...@gmail.com */
.name   = Compro VideoMate T750,
.audio_clock= 0x00187de7,
.tuner_type = TUNER_XC2028,
.radio_type = UNSET,
-   .tuner_addr = ADDR_UNSET,
+   .tuner_addr = 0x61,
.radio_addr = ADDR_UNSET,
+   .mpeg   = SAA7134_MPEG_DVB,
.inputs = {{
.name   = name_tv,
.vmux   = 3,
@@ -6550,6 +6552,11 @@ static int saa7134_xc2028_callback(struc
msleep(10);
saa7134_set_gpio(dev, 18, 1);
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   saa7134_set_gpio(dev, 20, 0);
+   msleep(10);
+   saa7134_set_gpio(dev, 20, 1);
+   break;
}
return 0;
}
@@ -6956,6 +6963,11 @@ int saa7134_board_init1(struct saa7134_d
saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   dev-has_remote = SAA7134_REMOTE_GPIO;
+   saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x00848000, 0x00808000);
+   saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x00848000, 0x00808000);
+   break;
}
return 0;
 }
@@ -7132,6 +7144,7 @@ int saa7134_board_init2(struct saa7134_d
}
/* break intentionally omitted */
case SAA7134_BOARD_VIDEOMATE_DVBT_300:
+   case SAA7134_BOARD_VIDEOMATE_T750:
case SAA7134_BOARD_ASUS_EUROPA2_HYBRID:
case SAA7134_BOARD_ASUS_EUROPA_HYBRID:
{
---  
linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c.orig	2010-05-08  
16:20:12.0 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c	2010-05-09  
15:33:30.0 +0200

@@ -55,6 +55,7 @@
 #include tda8290.h
#include zl10353.h
+#include qt1010.h
#include zl10036.h
 #include zl10039.h
@@ -886,6 +887,17 @@ static struct zl10353_config behold_x7_c
.disable_i2c_gate_ctrl = 1,
 };
+static struct zl10353_config videomate_t750_zl10353_config = {
+   .demod_address  = 0x0f,
+   .no_tuner = 1,
+   .parallel_ts = 1,
+};
+
+static struct qt1010_config videomate_t750_qt1010_config = {
+   .i2c_address = 0x62
+};
+
+
 /* ==
  * tda10086 based DVB-S cards, helper functions
  */
@@ -1556,6 +1568,24 @@ static int dvb_init(struct saa7134_dev *
__func__);
break;
+case SAA7134_BOARD_VIDEOMATE_T750:
+printk(Compro VideoMate T750 DVB setup\n);
+fe0-dvb.frontend = dvb_attach(zl10353_attach,
+ 

Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-09 Thread Emard
Yes, almost everything:
DVB-T, Analog TV, FM Radio, IR Remote control.

I haven't tested too much analog TV (it seems to work,
receivers some snowy channels but I don't have good antenna).
Also didn't test video inputs at all.

Not supported is onboard RTC timer that can wake up the 
computer.

Here's a cleaned up patch
-

--- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c.orig 
2010-05-08 16:13:28.0 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c  2010-05-09 
20:19:03.0 +0200
@@ -4881,12 +4881,14 @@ struct saa7134_board saa7134_boards[] =
},
[SAA7134_BOARD_VIDEOMATE_T750] = {
/* John Newbigin j...@it.swin.edu.au */
+   /* Emard 2010-05-09 v16 davorem...@gmail.com */
.name   = Compro VideoMate T750,
.audio_clock= 0x00187de7,
.tuner_type = TUNER_XC2028,
.radio_type = UNSET,
-   .tuner_addr = ADDR_UNSET,
+   .tuner_addr = 0x61,
.radio_addr = ADDR_UNSET,
+   .mpeg   = SAA7134_MPEG_DVB,
.inputs = {{
.name   = name_tv,
.vmux   = 3,
@@ -6550,6 +6552,11 @@ static int saa7134_xc2028_callback(struc
msleep(10);
saa7134_set_gpio(dev, 18, 1);
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   saa7134_set_gpio(dev, 20, 0);
+   msleep(10);
+   saa7134_set_gpio(dev, 20, 1);
+   break;
}
return 0;
}
@@ -6955,6 +6962,11 @@ int saa7134_board_init1(struct saa7134_d
dev-has_remote = SAA7134_REMOTE_GPIO;
saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
+   break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   dev-has_remote = SAA7134_REMOTE_GPIO;
+   saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
+   saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
break;
}
return 0;
--- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c.orig   
2010-05-08 16:20:12.0 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c2010-05-09 
15:33:30.0 +0200
@@ -55,6 +55,7 @@
 #include tda8290.h
 
 #include zl10353.h
+#include qt1010.h
 
 #include zl10036.h
 #include zl10039.h
@@ -886,6 +887,17 @@ static struct zl10353_config behold_x7_c
.disable_i2c_gate_ctrl = 1,
 };
 
+static struct zl10353_config videomate_t750_zl10353_config = {
+   .demod_address  = 0x0f,
+   .no_tuner = 1,
+   .parallel_ts = 1,
+};
+
+static struct qt1010_config videomate_t750_qt1010_config = {
+   .i2c_address = 0x62
+};
+
+
 /* ==
  * tda10086 based DVB-S cards, helper functions
  */
@@ -1556,6 +1568,24 @@ static int dvb_init(struct saa7134_dev *
__func__);
 
break;
+case SAA7134_BOARD_VIDEOMATE_T750:
+printk(Compro VideoMate T750 DVB setup\n);
+fe0-dvb.frontend = dvb_attach(zl10353_attach,
+videomate_t750_zl10353_config,
+dev-i2c_adap);
+if (fe0-dvb.frontend != NULL) {
+// if there is a gate function then the i2c bus 
breaks.!
+fe0-dvb.frontend-ops.i2c_gate_ctrl = 0;
+ 
+if (dvb_attach(qt1010_attach,
+   fe0-dvb.frontend,
+   dev-i2c_adap,
+   videomate_t750_qt1010_config) == NULL)
+{
+wprintk(error attaching QT1010\n);
+}
+}
+break;
case SAA7134_BOARD_ZOLID_HYBRID_PCI:
fe0-dvb.frontend = dvb_attach(tda10048_attach,
   zolid_tda10048_config,
--- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-input.c.orig 
2010-05-08 16:52:20.0 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-input.c  2010-05-09 
17:32:25.0 +0200
@@ -671,6 +671,11 @@ int saa7134_input_init1(struct saa7134_d
mask_keycode = 0x003f00;
mask_keydown = 0x04;
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   ir_codes = ir_codes_videomate_t750_table;
+   mask_keycode = 0x003f00;
+   mask_keyup   = 0x04;
+   break;
case 

Re: [PATCH] Compro Videomate T750F Vista digital+analog support

2010-05-09 Thread Emard
HI

This is even more cleanup from spaces into tabs 
and replacing KEY_BACKSPACE with KEY_BACK
which I think is more appropriate for this remote.

compro t750f patch v17

About the remote - I noticed 2-10% of the keypresses
are not recognized, seems like it either looses packets
or saa7134 gpio should be scanned faster/better/more_reliable?
I think this may be the issue with other 7134 based
remotes too

Best Regards, Emard


--- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c.orig 
2010-05-08 16:13:28.0 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c  2010-05-10 
00:48:08.0 +0200
@@ -4881,12 +4881,14 @@ struct saa7134_board saa7134_boards[] =
},
[SAA7134_BOARD_VIDEOMATE_T750] = {
/* John Newbigin j...@it.swin.edu.au */
+   /* Emard 2010-05-10 v17 davorem...@gmail.com */
.name   = Compro VideoMate T750,
.audio_clock= 0x00187de7,
.tuner_type = TUNER_XC2028,
.radio_type = UNSET,
-   .tuner_addr = ADDR_UNSET,
+   .tuner_addr = 0x61,
.radio_addr = ADDR_UNSET,
+   .mpeg   = SAA7134_MPEG_DVB,
.inputs = {{
.name   = name_tv,
.vmux   = 3,
@@ -6550,6 +6552,11 @@ static int saa7134_xc2028_callback(struc
msleep(10);
saa7134_set_gpio(dev, 18, 1);
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   saa7134_set_gpio(dev, 20, 0);
+   msleep(10);
+   saa7134_set_gpio(dev, 20, 1);
+   break;
}
return 0;
}
@@ -6955,6 +6962,11 @@ int saa7134_board_init1(struct saa7134_d
dev-has_remote = SAA7134_REMOTE_GPIO;
saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
+   break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   dev-has_remote = SAA7134_REMOTE_GPIO;
+   saa_andorl(SAA7134_GPIO_GPMODE0  2,   0x8000, 0x8000);
+   saa_andorl(SAA7134_GPIO_GPSTATUS0  2, 0x8000, 0x8000);
break;
}
return 0;
--- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c.orig   
2010-05-08 16:20:12.0 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c2010-05-10 
00:47:23.0 +0200
@@ -55,6 +55,7 @@
 #include tda8290.h
 
 #include zl10353.h
+#include qt1010.h
 
 #include zl10036.h
 #include zl10039.h
@@ -886,6 +887,17 @@ static struct zl10353_config behold_x7_c
.disable_i2c_gate_ctrl = 1,
 };
 
+static struct zl10353_config videomate_t750_zl10353_config = {
+   .demod_address  = 0x0f,
+   .no_tuner = 1,
+   .parallel_ts = 1,
+};
+
+static struct qt1010_config videomate_t750_qt1010_config = {
+   .i2c_address = 0x62
+};
+
+
 /* ==
  * tda10086 based DVB-S cards, helper functions
  */
@@ -1556,6 +1568,21 @@ static int dvb_init(struct saa7134_dev *
__func__);
 
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   printk(Compro VideoMate T750 DVB setup\n);
+   fe0-dvb.frontend = dvb_attach(zl10353_attach,
+   videomate_t750_zl10353_config,
+   dev-i2c_adap);
+   if (fe0-dvb.frontend != NULL) {
+   // if there is a gate function then the i2c bus 
breaks.!
+   fe0-dvb.frontend-ops.i2c_gate_ctrl = 0;
+   if (dvb_attach(qt1010_attach,
+   fe0-dvb.frontend,
+   dev-i2c_adap,
+   videomate_t750_qt1010_config) == NULL)
+   wprintk(error attaching QT1010\n);
+   }
+   break;
case SAA7134_BOARD_ZOLID_HYBRID_PCI:
fe0-dvb.frontend = dvb_attach(tda10048_attach,
   zolid_tda10048_config,
--- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-input.c.orig 
2010-05-08 16:52:20.0 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-input.c  2010-05-09 
17:32:25.0 +0200
@@ -671,6 +671,11 @@ int saa7134_input_init1(struct saa7134_d
mask_keycode = 0x003f00;
mask_keydown = 0x04;
break;
+   case SAA7134_BOARD_VIDEOMATE_T750:
+   ir_codes = ir_codes_videomate_t750_table;
+   mask_keycode = 0x003f00;
+   mask_keyup   = 0x04;
+   break;
case