Hi Sylwester,
On Thu, Oct 17, 2013 at 10:33 PM, Sylwester Nawrocki
wrote:
> Hi Arun,
>
> My apologies for the delay.
>
> On 27/09/13 12:59, Arun Kumar K wrote:
>> s5k6a3 sensor has actual pixel resolution of 1408x1402 against
>> the active resolution 1392x1392. The real resolution is needed
>> when raw sensor SRGB data is dumped to memory by fimc-lite.
>>
>> Signed-off-by: Arun Kumar K
>> Reviewed-by: Sylwester Nawrocki
>> ---
>> drivers/media/i2c/s5k6a3.c | 10 ++
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c
>> index ccbb4fc..e70e217 100644
>> --- a/drivers/media/i2c/s5k6a3.c
>> +++ b/drivers/media/i2c/s5k6a3.c
>> @@ -25,10 +25,12 @@
>> #include
>> #include
>>
>> -#define S5K6A3_SENSOR_MAX_WIDTH 1392
>> -#define S5K6A3_SENSOR_MAX_HEIGHT 1392
>> -#define S5K6A3_SENSOR_MIN_WIDTH 32
>> -#define S5K6A3_SENSOR_MIN_HEIGHT 32
>> +#define S5K6A3_SENSOR_MAX_WIDTH 1408
>> +#define S5K6A3_SENSOR_MAX_HEIGHT 1402
>
> Where these numbers come from ? I digged in the datasheet and the pixel
> array size for S5K6A3YX is 1412 x 1412 pixels. I will use this value
> in my updated s5k6a3 driver patch I'm going to post today. And I will
> drop this patch from this series.
>
These are the numbers used in the the reference driver. I will check if
the values 1412x1412 works or not. There are also limitations imposed by the
fimc-is firmware too as we just pass on the sensor_id to the firmware and I can
see from the firmware log that it assumes max size of 1408x1402 for 6a3.
>> +#define S5K6A3_SENSOR_ACTIVE_WIDTH 1392
>> +#define S5K6A3_SENSOR_ACTIVE_HEIGHT 1392
>
>
> S5K6A3_SENSOR_ACTIVE_* macros are not used anywhere ? Can they be dropped ?
> Same applies to your S5K4E5 driver patch.
>
Yes I will drop them.
In my next series, I will drop this 6a3 patch and keep only 4e5 sensor.
Regards
Arun
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
