Re: [PATCH 0/3] drivers: net: cpsw: phy-handle fixes

[David Miller]

From: "David Rivshin (Allworx)" 
Date: Tue, 22 Dec 2015 19:36:31 -0500

> Testing by anyone who has real hardware using phy-handle or dual_emac
> with fixed-link would be appreciated.

I'm going to wait for such testing before applying this series.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

[David Miller]

From: "David Rivshin (Allworx)" 
Date: Wed, 16 Dec 2015 23:02:08 -0500

> Commit 1f71e8c96fc654724723ce987e0a8b2aeb81746d ("drivers: net: cpsw:
> Add support for fixed-link PHY") added initial fixed-link PHY support
> for CPSW, but missed a few considerations.
> 
> This series is based on the tip of the net tree. The first two patches
> fix user-visible errors in different hardware configurations. The third
> patch is for an internal reference counting issue. They are logically
> independent changes, but in the same function, so must be applied in
> order to apply cleanly.
> 
> The first patch was originally submitted by Pascal Speck on December 4,
> but was not picked up by patchwork. I suspect that is because the patch
> was mangled by the mailer. I fixed the mangling and am including it in
> this series, as I believe it is the correct change.
> 
> I have tested on the following hardware configurations:
>  - (EVMSK) dual emac with two real MDIO-connected phys using RGMII-TXID
>  - single emac with fixed-link using RGMII
> Testing of other CPSW emac configurations that folks may have would
> be appreciated.

Series applied, thanks David.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] drivers: net: cpsw: Fix bugs in fixed-link PHY DT parsing

[David Miller]

From: "David Rivshin (Allworx)" 
Date: Wed, 16 Dec 2015 23:02:08 -0500

> I have tested on the following hardware configurations:
>  - (EVMSK) dual emac with two real MDIO-connected phys using RGMII-TXID
>  - single emac with fixed-link using RGMII
> Testing of other CPSW emac configurations that folks may have would
> be appreciated.

I'm going to wait until some others give some feedback and testing
results on this one, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: cpsw: Fix ethernet regression for dm814x

[David Miller]

From: Tony Lindgren 
Date: Wed, 18 Nov 2015 17:27:25 -0800

> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") started using of_machine_is_compatible for detecting
> type but missed at dm8148 causing Ethernet to stop working.
> 
> Let's fix the issue by adding handling for dm814x.
> 
> Cc: Mugunthan V N 
> Signed-off-by: Tony Lindgren 

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drivers: net: cpsw: Add support for fixed-link PHY

[David Miller]

From: Markus Brunner 
Date: Tue, 03 Nov 2015 22:09:51 +0100

> Add support for a fixed-link devicetree sub-node in case the the 
> cpsw MAC is directly connected to a non-mdio PHY/device. 
> 
> Signed-off-by: Markus Brunner 

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drivers: net: cpsw: use module_platform_driver

[David Miller]

From: Grygorii Strashko 
Date: Fri, 23 Oct 2015 14:41:12 +0300

> There is no reasons to probe cpsw from late_initcall level
> and it's not recommended. Hence, use module_platform_driver()
> to register and probe cpsw driver from module_init() level.
> 
> Cc: Tony Lindgren 
> Acked-by: Mugunthan V N 
> Signed-off-by: Grygorii Strashko 

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 0/4] Add support for reading macid when DT macid not found

[David Miller]

From: Mugunthan V N 
Date: Mon, 21 Sep 2015 15:56:49 +0530

> Did a boot test on dra7-evm [1] and am437x-gp-evm [2].
> Pushed a branch [3] for others to test the patch.
> 
> [1]: http://pastebin.ubuntu.com/12513420/
> [2]: http://pastebin.ubuntu.com/12513428/
> [3]: git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git 
> cpsw-macid-read-support

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v3] drivers: net: cpsw: Add support to drive gpios for ethernet to be functional

[David Miller]

From: Mugunthan V N 
Date: Mon, 7 Sep 2015 15:16:44 +0530

> In DRA72x EVM, by default slave 1 is connected to the onboard
> phy, but slave 2 pins are also muxed with video input module
> which is controlled by pcf857x gpio and currently to select slave
> 0 to connect to phy gpio hogging is used, but with
> omap2plus_defconfig the pcf857x gpio is built as module. So when
> using NFS on DRA72x EVM, board doesn't boot as gpio hogging do
> not set proper gpio state to connect slave 0 to phy as it is
> built as module and you do not see any errors for not setting
> gpio and just mentions dhcp reply not got.
> 
> To solve this issue, introducing "mode-gpios" in DT when gpio
> based muxing is required. This will throw a warning when gpio
> get fails and returns probe defer. When gpio-pcf857x module is
> installed, cpsw probes again and ethernet becomes functional.
> Verified this on DRA72x with pcf as module and ramdisk.
> 
> Signed-off-by: Mugunthan V N 

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/smsc911x: Fix deferred probe for interrupt

[David Miller]

From: Tony Lindgren t...@atomide.com
Date: Fri, 28 Aug 2015 11:50:15 -0700

 The interrupt handler may not be available when smsc911x probes if the
 interrupt handler is a GPIO controller for example. Let's fix that
 by adding handling for -EPROBE_DEFER.
 
 Cc: Steve Glendinning steve.glendinn...@shawell.net
 Signed-off-by: Tony Lindgren t...@atomide.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 0/3] Add AM335x PG1.0 CPSW errata workaround

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Wed, 12 Aug 2015 15:22:52 +0530

 With commit 870915feabdc (drivers: net: cpsw: remove
 disable_irq/enable_irq as irq can be masked from cpsw itself),
 CPSW on AM335x beagle bone white is broken as there is a errata
 for AM335x PG1.0. This patch series implements the workaround by
 disabling the interrupts from ARM IRQ controller for AM335x SoC
 in addition to the masking of interrupts in CPSW.

Series applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH] net: Reserve skb headroom and set skb-dev even if using __alloc_skb

[David Miller]

From: Alexander Duyck alexander.h.du...@redhat.com
Date: Wed, 13 May 2015 13:34:13 -0700

 When I had inlined __alloc_rx_skb into __netdev_alloc_skb and
 __napi_alloc_skb I had overlooked the fact that there was a return in the
 __alloc_rx_skb.  As a result we weren't reserving headroom or setting the
 skb-dev in certain cases.  This change corrects that by adding a couple of
 jump labels to jump to depending on __alloc_skb either succeeding or failing.
 
 Fixes: 9451980a6646 (net: Use cached copy of pfmemalloc to avoid accessing 
 page)
 Reported-by: Felipe Balbi ba...@ti.com
 Signed-off-by: Alexander Duyck alexander.h.du...@redhat.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] net: davinci_mdio: add hibernation callbacks

[David Miller]

From: grygorii.stras...@linaro.org
Date: Fri, 27 Feb 2015 13:19:44 +0200

 From: Grygorii Strashko grygorii.stras...@linaro.org
 
 Setting a dev_pm_ops suspend_late/resume_early pair but not a
 set of hibernation functions means those pm functions will
 not be called upon hibernation.
 Fix this by using SET_LATE_SYSTEM_SLEEP_PM_OPS, which appropriately
 assigns the suspend and hibernation handlers and move
 davinci_mdio_x callbacks under CONFIG_PM_SLEEP to avoid build warnings.
 
 Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] net: ti: cpsw: add hibernation callbacks

[David Miller]

From: grygorii.stras...@linaro.org
Date: Fri, 27 Feb 2015 13:19:45 +0200

 From: Grygorii Strashko grygorii.stras...@linaro.org
 
 Setting a dev_pm_ops suspend/resume pair but not a set of
 hibernation functions means those pm functions will not be
 called upon hibernation.
 Fix this by using SIMPLE_DEV_PM_OPS, which appropriately
 assigns the suspend and hibernation handlers and move
 cpsw_suspend/resume calbacks under CONFIG_PM_SLEEP
 to avoid build warnings.
 
 Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Changes to cpsw and davinci_emac for getting MAC address

[David Miller]

From: Tony Lindgren t...@atomide.com
Date: Wed, 28 Jan 2015 11:33:03 -0800

 Here are a few patches to add common code for cpsw and davinci_emac for
 getting the MAC address. Looks like we can also now add code to get the
 MAC address on 3517 but in a slightly different way.

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch-net-next v3 2/2] net: ethernet: cpsw: don't requests IRQs we don't use

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Mon, 19 Jan 2015 08:40:17 -0600

 On Sun, Jan 18, 2015 at 01:07:50AM -0500, David Miller wrote:
 From: Felipe Balbi ba...@ti.com
 Date: Fri, 16 Jan 2015 10:11:12 -0600
 
  CPSW never uses RX_THRESHOLD or MISC interrupts. In
  fact, they are always kept masked in their appropriate
  IRQ Enable register.
  
  Instead of allocating an IRQ that never fires, it's best
  to remove that code altogether and let future patches
  implement it if anybody needs those.
  
  Signed-off-by: Felipe Balbi ba...@ti.com
 
 Applied.
 
 looks like randconfig caught a build break. Do you want an incremental
 patch or this patch again with the fix in it ?

Always incremental patches.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch-net-next v3] net: ethernet: ti: cpsw: fix buld break when NET_POLL_CONTROLLER

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Mon, 19 Jan 2015 11:52:36 -0600

 Commit c03abd84634d (net: ethernet: cpsw: don't requests IRQs we don't
 use) left one build breakage when NET_POLL_CONTROLLER is enabled.
 
 Fix this build break by referring to the correct irqs_table array.
 
 Fixes: c03abd84634d (net: ethernet: cpsw: don't requests IRQs we don't use)
 Reported-by: kbuild test robot fengguang...@intel.com
 Signed-off-by: Felipe Balbi ba...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch-net-next v3 1/2] net: ethernet: cpsw: unroll IRQ request loop

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Fri, 16 Jan 2015 10:11:11 -0600

 This patch is in preparation for a nicer IRQ
 handling scheme where we use different IRQ
 handlers for each IRQ line (as it should be).
 
 Later, we will also drop IRQs offset 0 and 3
 because they are always disabled in this driver.
 
 Signed-off-by: Felipe Balbi ba...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch-net-next v3 2/2] net: ethernet: cpsw: don't requests IRQs we don't use

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Fri, 16 Jan 2015 10:11:12 -0600

 CPSW never uses RX_THRESHOLD or MISC interrupts. In
 fact, they are always kept masked in their appropriate
 IRQ Enable register.
 
 Instead of allocating an IRQ that never fires, it's best
 to remove that code altogether and let future patches
 implement it if anybody needs those.
 
 Signed-off-by: Felipe Balbi ba...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Thu, 15 Jan 2015 09:20:53 -0600

 On Thu, Jan 15, 2015 at 01:19:16PM +0530, Mugunthan V N wrote:
 On Wednesday 14 January 2015 10:28 PM, Felipe Balbi wrote:
  CPSW never uses RX_THRESHOLD or MISC interrupts. In
  fact, they are always kept masked in their appropriate
  IRQ Enable register.
  
  Instead of allocating an IRQ that never fires, it's best
  to remove that code altogether and let future patches
  implement it if anybody needs those.
  
  Signed-off-by: Felipe Balbi ba...@ti.com
 
 Instead of introducing dummy ISR in previous patch and then removing in
 this patch, both can be squashed into a single patch.
 
 sure they can. I decided to split to ease review and to make sure only
 one thing happens in a single patch.

Indeed, I agree that adding something as a placeholder that just gets
immediately removed should be avoided unless it is extremely difficult
to do so.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Thu, 15 Jan 2015 19:28:52 -0600

 On Thu, Jan 15, 2015 at 06:16:15PM -0500, David Miller wrote:
 Indeed, I agree that adding something as a placeholder that just gets
 immediately removed should be avoided unless it is extremely difficult
 to do so.
 
 what does this mean ? you prefer both patches to be combined ?

Yes, something like that.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 0/6] Fixes for davinci_emac

[David Miller]

From: Tony Lindgren t...@atomide.com
Date: Thu, 15 Jan 2015 14:45:08 -0800

 Here's a repost of the fixes for davinci_emac with patches
 updated for comments and acks collected.

Series applied, thanks Tony.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch-net-next 1/3] net: ethernet: cpsw: unroll IRQ request loop

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Tue, 13 Jan 2015 13:44:46 -0600

 + ret = devm_request_irq(pdev-dev, irq, cpsw_interrupt,
 + 0, dev_name(pdev-dev), priv);

When a function call spans multiple lines, the argument on the second
and subsequent lines must start on the first column after the openning
parenthesis of the function call.

If you are using only TAB characters to indent, you are likely not
doing it correctly.

 + ret = devm_request_irq(pdev-dev, irq, cpsw_interrupt,
 + 0, dev_name(pdev-dev), priv);

Likewise.

 + ret = devm_request_irq(pdev-dev, irq, cpsw_interrupt,
 + 0, dev_name(pdev-dev), priv);

Likewise.

 + ret = devm_request_irq(pdev-dev, irq, cpsw_interrupt,
 + 0, dev_name(pdev-dev), priv);

Likewise.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/6] net: davinci_emac: Free clock after checking the frequency

[David Miller]

From: Tony Lindgren t...@atomide.com
Date: Tue, 13 Jan 2015 11:54:16 -0800

 * Tom Lendacky thomas.lenda...@amd.com [150113 11:51]:
 On 01/13/2015 01:29 PM, Tony Lindgren wrote:
 We only use clk_get() to get the frequency, the rest is done by
 the runtime PM calls. Let's free the clock too.
 
 Cc: Brian Hutchinson b.hutch...@gmail.com
 Cc: Felipe Balbi ba...@ti.com
 Signed-off-by: Tony Lindgren t...@atomide.com
 ---
   drivers/net/ethernet/ti/davinci_emac.c | 1 +
   1 file changed, 1 insertion(+)
 
 diff --git a/drivers/net/ethernet/ti/davinci_emac.c 
 b/drivers/net/ethernet/ti/davinci_emac.c
 index deb43b3..e9efc74 100644
 --- a/drivers/net/ethernet/ti/davinci_emac.c
 +++ b/drivers/net/ethernet/ti/davinci_emac.c
 @@ -1881,6 +1881,7 @@ static int davinci_emac_probe(struct platform_device 
 *pdev)
 return -EBUSY;
 }
 emac_bus_frequency = clk_get_rate(emac_clk);
 +   clk_put(emac_clk);
 
 The devm_clk_get call is used to get the clock so either a devm_clk_put
 needs to be used here or just let the devm_ call do its thing and
 automatically do the put when the module is unloaded.
 
 Thanks good catch, updated patch below.

Please, once all the feedback has been addressed, repost the entire
series.

THanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Tue, 6 Jan 2015 11:43:32 -0600

 CPSW completely hangs if we add, and later remove,
 VLAN ID #1. What happens is that after removing
 VLAN ID #1, no packets will be received by CPSW
 rendering network unusable.
 
 In order to fix the issue, we're returning -EINVAL
 if anybody tries to add VLAN ID #1. While at that,
 also filter out any ID  4095 because we only have
 12 bits for VLAN IDs.
 
 Fixes: 3b72c2f (drivers: net:ethernet: cpsw: add support for VLAN)
 Cc: sta...@vger.kernel.org # v3.9+
 Cc: Mugunthan V N mugunthan...@ti.com
 Tested-by: Schuyler Patton spat...@ti.com
 Signed-off-by: Felipe Balbi ba...@ti.com

You can't just unilaterally make one VLAN ID unusable.

A better way to handle this situation must be found,
and if that means turning off hw VLAN support completely,
that's a much better alternative to this.

I'm not applying this patch, sorry.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Tue, 6 Jan 2015 14:31:19 -0600

 What you're saying here is that you prefer to drop a feature that works
 for all other 1023 IDs because 1 ID is quirky. Sounds like overkill
 to me.

The other option is to software fallback only for VLAN 1.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: ethernet: cpsw: fix hangs with interrupts

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Fri, 2 Jan 2015 16:15:59 -0600

 The CPSW IP implements pulse-signaled interrupts. Due to
 that we must write a correct, pre-defined value to the
 CPDMA_MACEOIVECTOR register so the controller generates
 a pulse on the correct IRQ line to signal the End Of
 Interrupt.
 
 The way the driver is written today, all four IRQ lines
 are requested using the same IRQ handler and, because of
 that, we could fall into situations where a TX IRQ fires
 but we tell the controller that we ended an RX IRQ (or
 vice-versa). This situation triggers an IRQ storm on the
 reserved IRQ 127 of INTC which will in turn call ack_bad_irq()
 which will, then, print a ton of:
 ...
 Reported-by: Yegor Yefremov yegorsli...@googlemail.com
 Fixes: 510a1e7 (drivers: net: davinci_cpdma: acknowledge interrupt properly)
 Cc: sta...@vger.kernel.org # v3.9+
 Signed-off-by: Felipe Balbi ba...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] net: cpsw: fix hangs and improve IRQ handling

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Fri, 2 Jan 2015 12:10:24 -0600

 In any case, patch 1 should go in during the -rc an get backported
 all the way back to v3.9, while the other patches can (should) be
 delayed for v3.20 merge window.

If that's what you want, the way you submitted these changes it not
the correct way to do it.

You should instead submit patch #1 all by itself, correctly targetting
'net'.

Then, after the next time I merge 'net' into 'net-next', you can submit
the rest of the changes.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] net: cpsw: fix hangs and improve IRQ handling

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Fri, 2 Jan 2015 15:53:35 -0600

 On Fri, Jan 02, 2015 at 04:45:36PM -0500, David Miller wrote:
 You should instead submit patch #1 all by itself, correctly targetting
 'net'.
 
 Then, after the next time I merge 'net' into 'net-next', you can submit
 the rest of the changes.
 
 then take patch 1 and I'll resend the other in a couple weeks, no
 problem.

Please resubmit the patches in the proper manner.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] drivers: net : cpsw: Update Kconfig for CPSW

[David Miller]

From: Lokesh Vutla lokeshvu...@ti.com
Date: Thu, 4 Dec 2014 10:24:29 +0530

 CPSW is present in AM33xx, AM43xx, DRA7xx.
 Updating the Kconfig to depend on ARCH_OMAP2PLUS instead of listing
 all SoC's.
 
 Signed-off-by: Lokesh Vutla lokeshvu...@ti.com

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: smc91x: Fix gpios for device tree based booting

[David Miller]

From: Tony Lindgren t...@atomide.com
Date: Mon, 27 Oct 2014 13:25:56 -0700

 +/**
 + * of_try_set_control_gpio - configure a gpio if it exists
 + */
 +static int try_toggle_control_gpio(struct device *dev,
 +struct gpio_desc **desc,
 +const char *name, int index,
 +int value, unsigned int nsdelay)

This needs to be under CONFIG_OF cpp protection just like the code that
calls it.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND v6 0/7] net: cpsw: Support for am335x chip MACIDs

[David Miller]

From: Markus Pargmann m...@pengutronix.de
Date: Mon, 29 Sep 2014 08:53:12 +0200

 Another resend of this series to add the netdev list.
 
 This series adds support to the cpsw driver to read the MACIDs of the am335x
 chip and use them as fallback. These addresses are only used if there are no
 mac addresses in the devicetree, for example set by a bootloader.

Series applied to net-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND v6 0/7] DT doc: net: cpsw mac-address is optional

[David Miller]

From: Markus Pargmann m...@pengutronix.de
Date: Sun, 28 Sep 2014 18:59:14 +0200

 This is a resend of v6 of this series. I added the Acked-by of Tony Lindgren
 for patch 5/7. There are no other changes.
 
 This series adds support to the cpsw driver to read the MACIDs of the am335x
 chip and use them as fallback. These addresses are only used if there are no
 mac addresses in the devicetree, for example set by a bootloader.

Networking changes not CC:'d to netdev will be completely ignored
by me.

Thank you.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/6] Add CPTS support for AM437x

[David Miller]

From: George Cherian george.cher...@ti.com
Date: Fri, 2 May 2014 12:01:58 +0530

 The series adds CPTS support for AM4372.
 
 Patch 1 - DT changes w.r.t clock changes for AM33xx.
 Patch 2 - CPTS clock name harcoding in the driver is removed. 
 Easier to pass the clock name from dt rather than hardcoding in 
 driver.
 Also in prepration for DRA7x CPTS support.
 Patch 3 - Enable the CPTS support for both DRA7x and AM4372 in the driver.
 Patch 4 - Enable the Annexe F for L2 PTP for AM437x and DRA7x.
 Patch 5 - Change the default clocksource to dpll_core_m5 
 Patch 6 - DT changes for AM4372.
 
 v1 - v2
   Patch 1 and 2 Re-ordering.
   Seperate TS_BITS define for Hw version V2 and V3

Series applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: micrel : ks8851-ml: add vdd-supply support

[David Miller]

From: Nishanth Menon n...@ti.com
Date: Fri, 21 Mar 2014 01:52:48 -0500

 Few platforms use external regulator to keep the ethernet MAC supplied.
 So, request and enable the regulator for driver functionality.
 
 Fixes: 66fda75f47dc (regulator: core: Replace direct ops-disable usage)
 Reported-by: Russell King rmk+ker...@arm.linux.org.uk
 Suggested-by: Markus Pargmann m...@pengutronix.de
 Signed-off-by: Nishanth Menon n...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] net: cpsw: fix cpdma rx descriptor leak on down interface

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 3 Mar 2014 16:19:06 +0530

 From: Schuyler Patton spat...@ti.com
 
 This patch fixes a CPDMA RX Descriptor leak that occurs after taking
 the interface down when the CPSW is in Dual MAC mode. Previously
 the CPSW_ALE port was left open up which causes packets to be received
 and processed by the RX interrupt handler and were passed to the
 non active network interface where they were ignored.
 
 The fix is for the slave_stop function of the selected interface
 to disable the respective CPSW_ALE Port from forwarding packets. This
 blocks traffic from being received on the inactive interface.
 
 Signed-off-by: Schuyler Patton spat...@ti.com
 Reviewed-by: Felipe Balbi ba...@ti.com
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: enable promiscuous mode support

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Thu, 23 Jan 2014 00:03:12 +0530

 Enable promiscuous mode support for CPSW.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 1/1] drivers: net: cpsw: enable promiscuous mode support

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 20 Jan 2014 17:38:38 +0530

 + if (!enable  ((priv-slaves[0].ndev-flags  IFF_PROMISC) ||
 + (priv-slaves[1].ndev-flags  IFF_PROMISC))) {

This assumption that there are exactly 2 slaves is not valid.

Use the appropriate for_each_slave() et al. abstractions to access
the slaves.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH v3 1/1] drivers: net : cpsw: pass proper device name while requesting irq

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Wed, 18 Dec 2013 21:33:50 +0530

 During checking the interrupts with cat /proc/interrupts, it is showing
 device name as (null), this change was done with commit id aa1a15e2d where
 request_irq is changed to devm_request_irq also changing the irq name from
 platform device name to net device name, but the net device is not
 registered at this point with the network frame work, so devm_request_irq
 is called with device name as NULL, by which it is showed as (null) in
 cat /proc/interrupts. So this patch changes back irq name to platform
 device name itself in devm_request_irq so that the device name shows as
 below.
 ...
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

This looks a lot better, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] drivers: net cpsw: Enable In Band mode in cpsw for 10 mbps

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Fri, 13 Dec 2013 18:42:55 +0530

 This patch adds support for enabling In Band mode in 10 mbps speed.
 RGMII supports 1 Gig and 100 mbps mode for Forced mode of operation.
 For 10mbps mode it should be configured to in band mode so that link
 status, duplexity and speed are determined from the RGMII input data
 stream
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH v2 1/1] drivers: net : cpsw: pass proper device name while requesting irq

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Fri, 13 Dec 2013 14:35:27 +0530

 During checking the interrupts with cat /proc/interrupts, it is showing
 device name as (null), this change was done with commit id aa1a15e2d where
 request_irq is changed to devm_request_irq also changing the irq name from
 platform device name to net device name, but the net device is not
 registered at this point with the network frame work, so devm_request_irq
 is called with device name as NULL, by which it is showed as (null) in
 cat /proc/interrupts. So this patch moved the devm_request_irq after
 the net device register so that the device name shows as eth*.

This change is buggy.

If the request irq fails, you have to unregister the network device,
branching to clean_ale_ret is insufficient.

And this shows the more fundamental problem with your change, you
cannot register the network device before you request the IRQs
if your -open() method assumes that the IRQs are registered already.

Which this driver does.

The very moment you call request_irq(), the interface can be brought
up and then -open() method invoked.

Therefore, register_netdevice() absolutely must be the very last
action during the probe function.

Why don't you just use the platform device name as the interrupt
name?  The other alternative is to only register the IRQs in the
-open() routine and free the IRQ in the -close() method.

I can't apply this, sorry.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] drivers: net: cpsw: fix for cpsw crash when build as modules

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Wed, 11 Dec 2013 22:09:05 -0600

 From: Mugunthan V N mugunthan...@ti.com
 
 When CPSW and Davinci MDIO are build as modules, CPSW crashes when
 accessing CPSW registers in CPSW probe. The same is working in built-in
 as the CPSW clocks are enabled in Davindi MDIO probe, SO Enabling the
 clocks before accessing the version register and moving out the other
 register access to cpsw device open.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com
 Signed-off-by: Felipe Balbi ba...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] net: eth: davinci_cpdma: 64-bit phys/dma_addr_t cleanup

[David Miller]

From: Olof Johansson o...@lixom.net
Date: Wed, 11 Dec 2013 15:51:20 -0800

 Silences the below warnings when building with ARM_LPAE enabled, which
 gives longer dma_addr_t by default:
 
 drivers/net/ethernet/ti/davinci_cpdma.c: In function 'cpdma_desc_pool_create':
 drivers/net/ethernet/ti/davinci_cpdma.c:182:3: warning: passing argument 3 of 
 'dma_alloc_attrs' from incompatible pointer type [enabled by default]
 drivers/net/ethernet/ti/davinci_cpdma.c: In function 'desc_phys':
 drivers/net/ethernet/ti/davinci_cpdma.c:222:25: warning: cast from pointer to 
 integer of different size [-Wpointer-to-int-cast]
 drivers/net/ethernet/ti/davinci_cpdma.c:223:8: warning: cast from pointer to 
 integer of different size [-Wpointer-to-int-cast]
 
 Signed-off-by: Olof Johansson o...@lixom.net

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: eth: cpsw: 64-bit phys_addr_t and sparse cleanup

[David Miller]

From: Olof Johansson o...@lixom.net
Date: Wed, 11 Dec 2013 15:58:07 -0800

 Minor fix for printk format of a phys_addr_t, and the switch of two local
 functions to static since they're not used outside of the file.
 
 Signed-off-by: Olof Johansson o...@lixom.net

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] net: eth: davinci_cpdma: Mark a local variable static

[David Miller]

From: Olof Johansson o...@lixom.net
Date: Wed, 11 Dec 2013 15:51:21 -0800

 Only used locally. Found by sparse.
 
 Signed-off-by: Olof Johansson o...@lixom.net

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting irq

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 9 Dec 2013 14:59:05 +0530

 commit 50a5fb068

This commit doesn't appear in any tree.

And any change which makes a real struct device return NULL
for dev_name() is broken.

I'm not applying this patch, you have completely failed to
provide any information necessary to support and justify
your change.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting irq

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Fri, 6 Dec 2013 12:28:27 +0530

 From: George Cherian george.cher...@ti.com
 
 Use netdev_name while requesting irq so that eth* name is shown
 in /proc/interrupts. Previously it was showing device name as (null)
 for cpsw interrupts. For using netdev_name register_netdev and then
 call devm_request_irq.
 
 Signed-off-by: George Cherian george.cher...@ti.com
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Why is it showing (null) as the name, is dev_name() not working
properly for this device?

The only change you are making is passing netdev_name() instead
of dev_name().  dev_name() giving NULL doesn't make much sense
to me.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: davinci_emac: Fix platform data handling and make usable for am3517

[David Miller]

From: Tony Lindgren t...@atomide.com
Date: Tue, 3 Dec 2013 15:13:02 -0800

 When booted with device tree, we may still have platform data passed
 as auxdata. For am3517 this is needed for passing the interrupt_enable
 and interrupt_disable callbacks that access the omap system control module
 registers. These callback functions will eventually go away when we have
 a separate system control module driver.
 
 Some of the things that are currently passed as platform data we don't need
 to set up as device tree properties as they are always the same on am3517.
 So let's use a new compatible flag for those so we can get those from
 the device tree match data.
 
 Also note that we need to fix setting of phy_dev to NULL instead of an empty
 string as the code later on uses that to find the first phy on the mdio bus.
 This seems to have been caused by 5d69e0076a72 (net: davinci_emac: switch to
 new mdio).
 
 Signed-off-by: Tony Lindgren t...@atomide.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] drivers: net: cpsw: fix dt probe for one port ethernet

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 2 Dec 2013 12:53:39 +0530

 When only one port of the two port is pinned out, then dt probe is failing
 because second port phy is not found. fixing this by checking the number of
 slaves and breaking the loop.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Of course, this patch assumes that slaves are pinned out in order.

But, no matter, this makes more configurations work than before so
it's a good patch.

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH 1/1] drivers: net: cpsw: fix kernel warn during iperf test with interrupt pacing

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Sun, 20 Oct 2013 12:32:26 +0530

 When interrupt pacing is enabled, receive/transmit statistics are not
 updated properly by hardware which leads to ISR return with IRQ_NONE
 and inturn kernel disables the interrupt. This patch removed the checking
 of receive/transmit statistics from ISR.
 
 This patch is verified with AM335x Beagle Bone Black and below is the
 kernel warn when interrupt pacing is enabled.
...
 Cc: Sebastian Siewior bige...@linutronix.de
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 0/4] cpsw: support for control module register

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Sat, 21 Sep 2013 00:50:37 +0530

 This patch series adds the support for configuring GMII_SEL register
 of control module to select the phy mode type and also to configure
 the clock source for RMII phy mode whether to use internal clock or
 the external clock from the phy itself.
 
 Till now CPSW works as this configuration is done in U-Boot and carried
 over to the kernel. But during suspend/resume Control module tends to
 lose its configured value for GMII_SEL register in AM33xx PG1.0, so
 if CPSW is used in RMII or RGMII mode, on resume cpsw is not working
 as GMII_SEL register lost its configuration values.
 
 The initial version of the patch is done by Daniel Mack but as per
 Tony's comment he wants it as a seperate driver as it is done in USB
 control module. I have created a seperate driver for the same.

Series applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] cpsw: support for control module register

[David Miller]

Patch #3 doesn't apply to net-next because it makes changes to
a file include/linux/platform_data/cpsw.h which doesn't exist.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: Add support for new CPSW IP version

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 5 Aug 2013 17:30:05 +0530

 The new IP version has a minor changes and the offsets are same as the
 previous version, so adding new IP version support in the driver.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com
 Reviewed-by: Felipe Balbi ba...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH 1/1] net: ethernet: davinci_emac: drop IRQF_DISABLED

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Sat, 3 Aug 2013 16:39:45 +0530

 IRQF_DISABLED is a no-op by now and should be removed.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: ethernet: cpsw: drop IRQF_DISABLED

[David Miller]

From: Felipe Balbi ba...@ti.com
Date: Fri, 2 Aug 2013 10:44:10 +0300

 IRQF_DISABLED is a no-op by now and should be
 removed.
 
 Signed-off-by: Felipe Balbi ba...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 1/1] drivers: net: cpsw: Add support for new CPSW IP version

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Wed, 31 Jul 2013 17:42:26 +0530

 The new IP version has a minor changes and the offsets are same as the 
 previous
 version, so instead of adding CPSW version number in the driver, make the 
 driver
 to fall through to the latest versions so that the new version of CPSW which 
 has
 the same register offsets will work directly without patching the driver.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com
 Reviewed-by: Felipe Balbi ba...@ti.com

Like others, I really think you should check the version explicitly.

Please respin this patch so that it supports new IP versions in that
way.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: add support to show hw stats via ethtool

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 23 Jul 2013 15:38:17 +0530

 Add support to show CPSW hardware statistics to user via ethtool
 so user can find if there were any error reported by hardware or
 the system is over loaded duing high data rate transfer.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com
 ---
 Changes from initial version
 * Change hw_stats variable from struct cpsw_hw_stats __iomem * to u8 __iomem 
 *,
   so that accessing hw_stats doesn't require type casting.

This looks a lot better, applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 1/1] drivers: net: cpsw: add support to show hw stats via ethtool get_regs

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Fri, 19 Jul 2013 19:37:21 +0530

 Add support to show CPSW hardware statistics to user via ethtool get_regs
 ops so user can find if there were any error reported or the system is
 over loaded duing hagh data rate transfer.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

This is not the correct way to provide this functionality.  -get_regs()
is for dumping the raw hardware registers to userspace for low level
debugging purposes, not for providing HW specific statistics.

The correct thing to do is provide an appropriate implementation of
the -get_strings() and -get_ethtool_stats() methods.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v4 1/5] net: cpsw: enhance pinctrl support

[David Miller]

From: Linus Walleij linus.wall...@linaro.org
Date: Mon, 10 Jun 2013 17:48:16 +0200

 On Fri, Jun 7, 2013 at 4:49 PM, Mugunthan V N mugunthan...@ti.com wrote:
 
 If you want to merge the direct networking parts of this series into
 another tree, I'm fine with that:

 Acked-by: David S. Miller da...@davemloft.net

 David

 Can you the below patch series as i have adopted pinctrl PM api in another
 series,
 this patch has direct usage of pinctrl_select_state apis
 http://marc.info/?l=linux-netdevm=137054250018667w=2

 Linus Walleij

 Please drop this patch series and take my other [atch set mentioned above
 with David's Ack.
 
 Sure I didn't see David ACK the new versions explicitly but
 since they're even less intrusive I'll apply them assuming
 his ACK on these versions too...

Just in case it isn't clear:

Acked-by: David S. Miller da...@davemloft.net
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH 0/2] Fixes for davinci MDIO on suspend/resume

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 11 Jun 2013 15:32:03 +0530

 This patch series fixes the following issues with Davinci MDIO
 * Bring up MDIO driver earlier than Ethernet driver so that ethernet driver
   can communicate with the phy as soon as it is resumed.
 * On suspend/resume cycle the MDIO divider will be set to reset value so
   this has to be programmed after resume.

Series applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v4 1/5] net: cpsw: enhance pinctrl support

[David Miller]

From: Linus Walleij linus.wall...@linaro.org
Date: Fri, 7 Jun 2013 09:31:58 +0200

 On Thu, Jun 6, 2013 at 10:50 AM, Mark Brown broo...@kernel.org wrote:
 On Thu, Jun 06, 2013 at 11:29:39AM +0530, Mugunthan V N wrote:
 On 6/6/2013 12:53 AM, Mark Brown wrote:

 Linus Walleij posted some patches which factor the state setting code
 out into generic functions earlier on today - it probably makes sense to
 pick those up rather than open coding

 But this can go in as Linus Walleij's patch is not accepted yet.
 Once that is
 accepted and present in net git repo I will submit a separate patch to use
 those APIs from pin ctrl core.

 Linus' change has pretty much gone in already but in any case what would
 be sensible here would be to write this in turns of Linus' changes and
 then send the patch to him to add to his series so it can go in via the
 same route.  One of the major reasons for the patch was that lots of
 people were querying the amount of noise caused by this sort of change.
 
 I agree. We should be able to settle on the new core API quite soon,
 then I can carry the patch to this driver if you obtain David's ACK.

If you want to merge the direct networking parts of this series into
another tree, I'm fine with that:

Acked-by: David S. Miller da...@davemloft.net
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 0/8] add phy driver for Atheros AR8031 and CPSW phy-mode DT enhancement

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 4 Jun 2013 11:40:03 +0530

 This patch series adds the following feature
 * Atheros phy driver code cleanup
 * Add AT8031 phy driver to at803x driver
 * Add RGMII tx delay support via phy_if
 * Add phy_if DT enhancement to CPSW Driver and DT

Series applied to net-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 1/1] drivers: net: davinci_cpdma: remove CRC bytes from skb added by CPDMA

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Thu, 30 May 2013 11:52:01 +0530

 Additional 4 bytes found in the skb is the CRC calculated by the
 CPDMA hardware, check the CRC bit in CPDMA status field of
 Descriptor and remove the CRC length from the skb. This extra
 4 byte can be seen when capturing packets using tcpdump.
 This has been tested in TI816x platform.
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v2 1/6] net: cpsw: enhance pinctrl support

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Thu, 23 May 2013 18:00:23 +0530

 From: Hebbar Gururaja gururaja.heb...@ti.com
 
 Amend cpsw controller to optionally take a pin control handle and set
 the state of the pins to:
 
 - default on boot, resume
 - sleep on suspend()
 
 This should make it possible to optimize energy usage for the pins
 for the suspend/resume cycle.
 
 If any of the above pin states are missing in dt, a warning message
 about the missing state is displayed.
 If certain pin-states are not available, to remove this warning message
 pass respective state name with null phandler.
 
 Signed-off-by: Hebbar Gururaja gururaja.heb...@ti.com
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

This still needs some work:

 + /*
 + * Since we continue even when pinctrl node is not found,
 + * Invalidate pins as not available. This is to make sure that
 + * IS_ERR(pins_xxx) results in failure when used.
 + */

The second, third, fourth, and fifth lines are not tabbed correctly.  They
should all be two TABs and a SPACE.

Secondly, comments in the networking are to be formatted:

/* Like
 * this.
 */
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 21 May 2013 15:24:58 +0530

 + priv-pins_default = pinctrl_lookup_state(priv-pinctrl,
 + PINCTRL_STATE_DEFAULT);

This is not indented correctly.

Argument on the second, and subsequent, lines of a function call
must start at the first column after the openning parenthesis of
the function call itself.

Please audit for this problem in your entire patch series, fix
it up, and resubmit the full set of patches.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

[David Miller]

From: Hebbar, Gururaja gururaja.heb...@ti.com
Date: Thu, 23 May 2013 11:28:38 +

 On Thu, May 23, 2013 at 12:27:41, David Miller wrote:
 From: Mugunthan V N mugunthan...@ti.com
 Date: Tue, 21 May 2013 15:24:58 +0530
 
  +  priv-pins_default = pinctrl_lookup_state(priv-pinctrl,
  +  PINCTRL_STATE_DEFAULT);
 
 This is not indented correctly.
 
 Argument on the second, and subsequent, lines of a function call
 must start at the first column after the openning parenthesis of
 the function call itself.
 
 Well, if I am correct, doing so will make the line cross 80 character limit.
 If you could (please I ask), can you let me know how it can be handled in 
 above situation. I will make the changes/corrections and re-send it.
 
 Thanks a lot in advance.

Avoid the deep indentation by coding the basic block into a helper
function.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 0/6] Adding pinctrl PM support for CPSW and Davinci MDIO drivers

[David Miller]

Please read:

http://marc.info/?l=linux-netdevm=136730964130303w=2
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH v2 1/1] drivers: net: cpsw: fix kernel warn on cpsw irq enable

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 30 Apr 2013 14:57:28 +0530

 With the commit a11fbba (net/cpsw: fix irq_disable() with threaded interrupts)
 from Sebastian Siewior, a kernel warning is generated as below. This warning
 is generated as the irq_enabled is not initialized for the primary interface
 and in probe it is initialized for the second interface. This patch moves
 irq_enabled initialization from second interface to primary interface.
 ...
 Cc: Sebastian Siewior bige...@linutronix.de
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 1/1] drivers: net: cpsw: fix kernel warn on cpsw irq enable

[David Miller]

From: Sebastian Andrzej Siewior bige...@linutronix.de
Date: Fri, 26 Apr 2013 14:03:24 +0200

 David, how did this happen? The patch I've sent
 
http://www.spinics.net/lists/netdev/msg234240.html
 
 adds this to the probe function, according to the net-next tree it was
 added to cpsw_probe_dual_emac(). The context is similar but not exact
 the same.

This is usually I ask people to respin patches even if there are minor
fuzz differences when I try to apply this patch.

I tried to be nice and save you some work this time, 'patch' accepted
it with minor offsets, and with a cursory glance I didn't see any
problems.

Next time I'll be a hardliner and request a respin :-)
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 1/3] drivers: of: add phy fixup support in DT

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 22 Apr 2013 23:50:36 +0530

 In earlier case phy fixup are added in board file as this is no more the case
 so adding support for phy register fixup in Device Tree
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

When people put a series of undocumented PHY register writes using
constants, we tell them it's firmware.

If these PHY registers are actually documented in the driver, write a
function in that driver which does the programming sequence, then add
a property that the driver looks for in order to determine whether to
call that sequence or not.

I don't want people putting random PHY raw programming sequences and
other crap like that into the OF device nodes.  It's extremely
inelegant and inviting abuse.

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH 1/1] drivers: net: ethernet: cpsw: get slave VLAN id from slave node instead of cpsw node

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 15 Apr 2013 23:01:28 +0530

 Dual EMAC slave VLAN id must be got from slave node instead of cpsw node as
 VLAN id for each slave will be different.
 
 Reported-by: Mark Jackson mpfj-l...@mimc.co.uk
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/6] Generic PHY Framework

[David Miller]

From: Kishon Vijay Abraham I kis...@ti.com
Date: Wed, 3 Apr 2013 11:29:53 +0530

 Hi,
 
 On Friday 29 March 2013 12:01 AM, David Miller wrote:

 You really need to CC: net...@vger.kernel.org rather than me
 explicitly
 on this patch set.
 
 I was CC'ing whatever get_maintainer shows. I'll make sure to CC
 net...@vger.kernel.org though there's nothing related to network in
 this patch series (Maybe sometime in the future it'll be used).

What about drivers/net/phy isn't networking?
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/6] Generic PHY Framework

[David Miller]

From: Kishon Vijay Abraham I kis...@ti.com
Date: Wed, 3 Apr 2013 12:05:30 +0530

 This patch series is about drivers/phy which will be used for now by
 usb, sata and maybe some video PHY's. Network itself has a
 comprehensive PHY in drivers/net/phy which we'd like to merge it with
 drivers/phy so that we have all the phy stuff in drivers/phy but we
 are not planning too far ahead here.

Ok, that makes sense, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/6] Generic PHY Framework

[David Miller]

You really need to CC: net...@vger.kernel.org rather than me explicitly
on this patch set.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 1/1] drivers: net: ethernet: ti: sparse warning fix for ti ethernet drivers

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Wed, 27 Mar 2013 15:28:07 +0530

 @@ -179,7 +179,7 @@ cpdma_desc_pool_create(struct device *dev, u32 phys, u32 
 hw_addr,
   } else {
   pool-cpumap = dma_alloc_coherent(dev, size, pool-phys,
 GFP_KERNEL);
 - pool-iomap = pool-cpumap;
 + pool-iomap = (void __iomem *) pool-cpumap;

This is bogus.

Either a pointer is to RAM, or it's an IOMEM pointer.  It cannot be both.

This indicates that pool-iomap's usage in this scenerio is not correct
at all.

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net-next PATCH 0/2] network performance improvement patches for TI CPSW and Davinci EMAC drivers

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Wed, 27 Mar 2013 20:11:58 +0530

 This patch series improves network performance of TI CPSW and Davinci EMAC
 drivers during bulk transfer. During heavy Tx load CPDMA may run out of
 descriptors and tx queue is stopped. When it descriptors are available it
 is reported to the stack via netif_start_queue which doesn't schedule tx
 queue immediately, so there can be dead time during continuous transfer,
 this can be fixed by using netif_wake_queue api which will schedule tx queue
 immediately.

Both applied to 'net'.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [net PATCH 1/1] drivers: net: ethernet: ti: davinci_emac: fix usage of cpdma_check_free_tx_desc()

[David Miller]

From: Prabhakar Lad prabhakar.cse...@gmail.com
Date: Sat, 16 Mar 2013 12:43:14 +0530

 Hi Mugunthan
 
 Thanks for the patch!
 
 On Fri, Mar 15, 2013 at 7:40 PM, Mugunthan V N mugunthan...@ti.com wrote:
 Fix which was done in the following commit in cpsw driver has
 to be taken forward to davinci emac driver as well.

 commit d35162f89b8f00537d7b240b76d2d0e8b8d29aa0
 Author: Daniel Mack zon...@gmail.com
 Date:   Tue Mar 12 06:31:19 2013 +

 net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc()

 Commit fae50823d0 (net: ethernet: davinci_cpdma: Add boundary for rx
 and tx descriptors) introduced a function to check the current
 allocation state of tx packets. The return value is taken into account
 to stop the netqork queue on the adapter in case there are no free
 slots.

 However, cpdma_check_free_tx_desc() returns 'true' if there is room in
 the bitmap, not 'false', so the usage of the function is wrong.

 Reported-by: Prabhakar Lad prabhakar.cse...@gmail.com
 Signed-off-by: Mugunthan V N mugunthan...@ti.com
 
  Tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/5] cpsw interrupt pacing and get/set phy setting implementation

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 12 Mar 2013 14:46:33 +0530

 This patch serires implements the following features in CPSW driver
 * get/set phy link settings
 * interrupt pacing
 * get phy id via ioctl cmd SIOCGMIIPHY
 
 Changes from initial version
 * Made active-slave common for cpts, ethtool and SIOCGMIIPHY ioctl
 * Cleaned CPSW DT binding documentation by seperating slave nodes
   under sub-section
 * implemented get phy id via ioctl cmd SIOCGMIIPHY

Series applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 net-next 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 18 Feb 2013 13:49:20 +0530

 CPDMA interrupts are not properly acknowledged which leads to interrupt
 storm, only cpdma interrupt 0 is acknowledged in Davinci CPDMA driver.
 Changed cpdma_ctlr_eoi api to acknowledge 1 and 2 interrupts which are
 used for rx and tx respectively.
 
 Reported-by: Pantelis Antoniou pa...@antoniou-consulting.com
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Thu, 14 Feb 2013 23:56:46 +0530

 +enum {
 + CPDMA_EOI_RX_THRESH = 0,
 + CPDMA_EOI_RX,
 + CPDMA_EOI_TX,
 + CPDMA_EOI_MISC,
 +};

Do not use enumerations for hardware register values, which must be
exact, otherwise you are potentially going to succumb to the vagaries
of C language enumeration value assignment.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

[David Miller]

Also please indicate, clearly, what tree your patch is targetted at.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

[David Miller]

From: Joe Perches j...@perches.com
Date: Fri, 15 Feb 2013 12:18:59 -0800

 On Fri, 2013-02-15 at 15:05 -0500, David Miller wrote:
 From: Mugunthan V N mugunthan...@ti.com
 Date: Thu, 14 Feb 2013 23:56:46 +0530
 
  +enum {
  + CPDMA_EOI_RX_THRESH = 0,
  + CPDMA_EOI_RX,
  + CPDMA_EOI_TX,
  + CPDMA_EOI_MISC,
  +};
 
 Do not use enumerations for hardware register values, which must be
 exact, otherwise you are potentially going to succumb to the vagaries
 of C language enumeration value assignment.
 
 Vagaries?
 
 In what way is c enumeration (6.7.2.2) vague?
 char vs int?  Isn't smaller mostly better?
 
 Concern about possible future reordering given an
 insertion or deletion might be the only consideration
 I could imagine.

Right.  That's why you should use explicit CPP defines for
register offsets and values.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Dual EMAC mode implementation of CPSW

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 12 Feb 2013 01:22:17 +0530

 This patch series implements Dual EMAC mode implementation of CPSW
 which acts as two standalone EMAC by segregating the switch using VIDs
 and port VLAN
 
 Mugunthan V N (3):
   driver: net: ethernet: davinci_cpdma: add support for directed packet
 and source port detection
   driver: net: ethernet: cpsw: make cpts as pointer
   driver: net: ethernet: cpsw: dual emac interface implementation

Series applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/2] Add CPSW VLAN Support

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 5 Feb 2013 23:56:46 +0530

 CPSW is capable of filtering VLAN packets in hardware. This patch series
 implements VLAN support to CPSW driver.
 This patch series is tested on net-next with AM335x EVM with ping test.

Series applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] drivers: net:ethernet: cpsw: add support for VLAN

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Fri, 1 Feb 2013 00:33:20 +0530

 diff --git a/Documentation/devicetree/bindings/net/cpsw.txt 
 b/Documentation/devicetree/bindings/net/cpsw.txt
 index 6ddd028..99696bf 100644
 --- a/Documentation/devicetree/bindings/net/cpsw.txt
 +++ b/Documentation/devicetree/bindings/net/cpsw.txt
 @@ -24,6 +24,8 @@ Required properties:
  Optional properties:
  - ti,hwmods  : Must be cpgmac0
  - no_bd_ram  : Must be 0 or 1
 +- default_vlan   : Specifies Default VLAN for non tagged packets
 +   ALE processing
  
  Note: ti,hwmods field is used to fetch the base address and irq
  resources from TI, omap hwmod data base during device registration.

You guys have to get away from this idea that you can basically pepper
devicetree bindings with all sorts of random behavioral knobs like
this, it's terrible.

Make this an ethtool configurable entity or similar, and don't even
think about adding a module parameter.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/2] cpts fixes for v3.8-rc2

[David Miller]

From: Richard Cochran richardcoch...@gmail.com
Date: Mon, 24 Dec 2012 08:19:08 +0100

 Changed in v2:
 Use clk_prepare_enable instead of clk_prepare + clk_enable.
 
 The new cpts driver has two small issues, but it otherwise seems to be
 working in -rc1.

Both applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: cpts: Fix build error caused by include of plat/clock.h

[David Miller]

From: Richard Cochran richardcoch...@gmail.com
Date: Fri, 14 Dec 2012 12:09:18 +0100

 On Fri, Dec 14, 2012 at 10:55:56AM +0100, Koen Kooi wrote:
 
 Op 14 dec. 2012, om 08:13 heeft Richard Cochran richardcoch...@gmail.com 
 het volgende geschreven:
 
  On Thu, Dec 13, 2012 at 01:36:41PM -0800, Tony Lindgren wrote:
  Commit 87c0e764 (cpts: introduce time stamping code and a PTP hardware 
  clock)
  mistakenly included plat/clock.h that should not be included by drivers
  even if it exists.
  
  Hasn't this already been fixed?
  
   https://patchwork.kernel.org/patch/1810481/
   http://www.spinics.net/lists/linux-omap/msg83132.html
 
 That patch didn't get applied, so it's still broken in Linus' tree :(
 
 In netdev's patchwork, this was marked Not Applicable. Dave, can you
 possibly take this patch? If not, who should I ask next?

That's strange, when I look at that patch it's marked Accepted ;-)
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors

[David Miller]

You cannot do this.

After your changes the driver no longer does any TX flow control.

It never stops the TX queue and never wakes it up later.

It just drops packets on the floor when it runs out of descriptors.

This breaks everything, and in particular packet schedulers and
TCP.

I'm not applying this.

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors

[David Miller]

From: David Miller da...@davemloft.net
Date: Tue, 11 Dec 2012 13:30:58 -0500 (EST)

 
 You cannot do this.
 
 After your changes the driver no longer does any TX flow control.
 
 It never stops the TX queue and never wakes it up later.
 
 It just drops packets on the floor when it runs out of descriptors.
 
 This breaks everything, and in particular packet schedulers and
 TCP.
 
 I'm not applying this.

And yes I mean that the fail_tx path of the transmit method
is bogus too.

You can't signal out of descriptors and stop the queue after the
fact.  NETDEV_TX_BUSY is for handling exceptional and extraordinary
conditions, not for the normal queue full handling.

You have to stop the queue before you run out of descriptors.  When
the queue is not stopped, you are telling the core networking that you
absoultely will be able to successfully queue a packet and enough
descriptors are available.

This means the other CPDMA driver needs to be reworked too.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/1] net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors

[David Miller]

From: Eric Dumazet erdnet...@gmail.com
Date: Tue, 11 Dec 2012 10:54:56 -0800

 Suggested fix : add a TCQ_F_MQSLAVE flag to allow dequeue_skb() to test
 the netif_xmit_frozen_or_stopped() status _before_ dequeing packet from
 qdisc.

This sounds fine to me.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] net: ethernet: cpsw: fix build warnings for CPSW when CPTS not selected

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Tue, 27 Nov 2012 23:23:40 +0530

   CC  drivers/net/ethernet/ti/cpsw.o
 drivers/net/ethernet/ti/cpsw.c: In function 'cpsw_ndo_ioctl':
 drivers/net/ethernet/ti/cpsw.c:881:20: warning: unused variable 'priv'
 
 The build warning is generated when CPTS is not selected in Kernel Build.
 Fixing by passing the net_device pointer to cpts IOCTL instead of passing priv
 
 Signed-off-by: Mugunthan V N mugunthan...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V5 0/7] ARM: AM33XX: net: Add DT support to CPSW and MDIO driver

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Thu, 15 Nov 2012 00:37:53 +0530

 This patch-series adds support for,
 
 [1/7]: Typo mistake in CPSW driver while invoking runtime_pm api's
 
 [2/7]: Adds parent-child relation between CPSW  MDIO module inside cpsw
driver, as in case of AM33XX, the resources are shared and common
register bit-field is provided to control module/clock enable/disable,
makes it difficult to handle common resource.
 
So the solution here is, to create parent-child relation between 
 them.
 
 [3/7]: cpsw: simplify the setup of the register pointers
 
 [4/7]: cpsw: Kernel warn fix during suspend
 
 [5/7]: Add hwmod entry for MDIO module, required for MDIO driver.
 
 [6/7]: Enable CPSW support to omap2plus_defconfig
 
 [7/7]: Add DT device nodes for both CPSW and MDIO modules in am33xx.dtsi,
am335x-evm.dts and am335x-bone.dts file
 
 This patch series has been created on top of net-next/master and tested
 on BeagleBone platform for NFS boot and basic ping test cases.

All applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] Add device tree support for davinci_mdio driver and fix cpsw DT binding documentation

[David Miller]

From: Mugunthan V N mugunthan...@ti.com
Date: Mon, 6 Aug 2012 20:35:56 +0530

 This patch set adds support for device tree for Davinci MDIO driver and fixes
 CPSW DT binding documentation to make it copy pastable to dts file.
 
 This patch set is tested with the following git tree on AM335X Beagle Bone
 https://github.com/hvaibhav/am335x-linux/tree/am335x-upstream-staging-cpsw
 
 Mugunthan V N (2):
   drivers: net: ethernet: davince_mdio: device tree implementation
   documentation: dt: bindings: cpsw: fixing the examples for directly
 using it in dts file

Applied to net-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/2] net: ethernet: davinci_emac: fixups + pm_runtime

[David Miller]

From: Mark A. Greer mgr...@animalcreek.com
Date: Fri, 20 Jul 2012 18:19:20 -0700

 From: Mark A. Greer mgr...@animalcreek.com
 
 This series fixes a compile error in, and adds pm_runtime support
 to, the davinci_emac driver.
 
 To test on a davinci platform, you will need another patch just
 submitted to netdev:
 
   http://marc.info/?l=linux-netdevm=134282758408187w=2
 
 Mark A. Greer (2):
   net: ethernet: davinci_emac: Remove unnecessary #include
   net: ethernet: davinci_emac: add pm_runtime support

All applied to net-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ethernet: add export.h in davinci_cpdma.c

[David Miller]

From: Kim, Milo milo@ti.com
Date: Mon, 2 Jul 2012 01:17:03 +

 To remove warning messages about 'EXPORT_SYMBOL_GPL', include export header.
 ...
 @@ -19,6 +19,7 @@
  #include linux/err.h
  #include linux/dma-mapping.h
  #include linux/io.h
 +#include linux/export.h

You aren't generating this patch against current sources, otherwise
you'd see that linux/module.h is included in this driver and therefore
the problem you ran into is not possible.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ethernet: add export.h in davinci_cpdma.c

[David Miller]

Also, networking patches should always be CC:'d to net...@vger.kernel.org
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ks8851: Fix NOHZ local_softirq_pending 08 warning

[David Miller]

From: Benoit Cousson b-cous...@ti.com
Date: Mon, 13 Feb 2012 18:37:12 +0100

 This fix a similar problem as in 72092cc45378176ba700034c91b7af2db524df26
 and 481a8199142c050b72bff8a1956a49fd0a75bbe0 (can:
 fix NOHZ local_softirq_pending 08 warning). This fix replaces netif_rx()
 with netif_rx_ni() which has to be used from process/softirq context.
 
 Signed-off-by: Benoit Cousson b-cous...@ti.com

Applied.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2 v5] net/smsc911x: Add regulator support

[David Miller]

From: Robert Marklund robert.markl...@stericsson.com
Date: Thu, 24 Nov 2011 12:03:07 +0100

 Add some basic regulator support for the power pins, as needed
 by the ST-Ericsson Snowball platform that powers up the SMSC911
 chip using an external regulator.
 
 Platforms that use regulators and the smsc911x and have no defined
 regulator for the smsc911x and claim complete regulator
 constraints with no dummy regulators will need to provide it, for
 example using a fixed voltage regulator. It appears that this may
 affect (apart from Ux500 Snowball) possibly these archs/machines
 that from some grep:s appear to define both CONFIG_SMSC911X and
 CONFIG_REGULATOR:
 
 - ARM Freescale mx3 and OMAP 2 plus, Raumfeld machines
 - Blackfin
 - Super-H
 
 Cc: Paul Mundt let...@linux-sh.org
 Cc: linux...@vger.kernel.org
 Cc: Sascha Hauer s.ha...@pengutronix.de
 Cc: Tony Lindgren t...@atomide.com
 Cc: linux-omap@vger.kernel.org
 Cc: Mike Frysinger vap...@gentoo.org
 Cc: uclinux-dist-de...@blackfin.uclinux.org
 Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com
 Signed-off-by: Robert Marklund robert.markl...@stericsson.com
 Signed-off-by: Linus Walleij linus.wall...@linaro.org

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: Add back alignment for size for __alloc_skb

[David Miller]

From: Tony Lindgren t...@atomide.com
Date: Wed, 2 Nov 2011 16:40:28 -0700

 Subject: [PATCH] net: Add back alignment for size for __alloc_skb

Applied, thanks a lot!
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: Add back alignment for size for __alloc_skb

[David Miller]

From: Eric Dumazet eric.duma...@gmail.com
Date: Wed, 02 Nov 2011 23:55:11 +0100

 There is a problem with your kmalloc() or alignments on your architecture.
 
 What is the SMP_CACHE_BYTES value ?

kmalloc() behavior doesn't have anything to do with this bug.

The issue is calculation of skb-end, which is based upon calculated
'size' variable.

skb-end determines alignment of skb_shared_info, which is where the
alignment problem is occuring for Tony.

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net: Add back alignment for size for __alloc_skb

[David Miller]

From: David Miller da...@davemloft.net
Date: Wed, 02 Nov 2011 19:09:55 -0400 (EDT)

 From: Eric Dumazet eric.duma...@gmail.com
 Date: Wed, 02 Nov 2011 23:55:11 +0100
 
 There is a problem with your kmalloc() or alignments on your architecture.
 
 What is the SMP_CACHE_BYTES value ?
 
 kmalloc() behavior doesn't have anything to do with this bug.

Sorry, I take that back, I see now how ksize() and friends are being
used here.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html