Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
On Thu, Feb 23, 2012 at 12:59 PM, Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi Tony, On 02/23/2012 01:07 AM, Tony Lindgren wrote: * Peter Ujfalusi peter.ujfal...@ti.com [120217 00:54]: CCDN is the last common channel register in all OMAP4 versions. Use cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not doing what it supposed to do. This is a bit unclear.. Which is not doing what is supposed to do? DMA driver? Or one of the cpu_is_omap? The cpu_is_omap4430() returns 0 unconditionally. Because of this the dma_common_ch_end is wrongly configured on OMAP4 (even on OMAP4430). If this should be queued as a fix, then we need some kind of description here what breaks. I will resend the patch with a better commit message. This is a bug for sure, but I'm not sure how severe it is. At best we are not clearing the registers between CCFN, and CCDN on OMAP4. The bug is not severe. Infact these registers are needed for descriptor loading sDMA feature which never made it to mainline :) So nothing should get impacted. Regards Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
On 02/23/2012 10:42 AM, Shilimkar, Santosh wrote: The bug is not severe. Infact these registers are needed for descriptor loading sDMA feature which never made it to mainline :) So nothing should get impacted. Yes, this is my understanding as well. -- Péter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
* Peter Ujfalusi peter.ujfal...@ti.com [120217 00:54]: CCDN is the last common channel register in all OMAP4 versions. Use cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not doing what it supposed to do. This is a bit unclear.. Which is not doing what is supposed to do? DMA driver? Or one of the cpu_is_omap? If this should be queued as a fix, then we need some kind of description here what breaks. Regards, Tony Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-omap2/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c index a59a45a..b19d849 100644 --- a/arch/arm/mach-omap2/dma.c +++ b/arch/arm/mach-omap2/dma.c @@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused) dma_stride = OMAP2_DMA_STRIDE; dma_common_ch_start = CSDP; - if (cpu_is_omap3630() || cpu_is_omap4430()) + if (cpu_is_omap3630() || cpu_is_omap44xx()) dma_common_ch_end = CCDN; else dma_common_ch_end = CCFN; -- 1.7.8.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
Hi Tony, On 02/23/2012 01:07 AM, Tony Lindgren wrote: * Peter Ujfalusi peter.ujfal...@ti.com [120217 00:54]: CCDN is the last common channel register in all OMAP4 versions. Use cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not doing what it supposed to do. This is a bit unclear.. Which is not doing what is supposed to do? DMA driver? Or one of the cpu_is_omap? The cpu_is_omap4430() returns 0 unconditionally. Because of this the dma_common_ch_end is wrongly configured on OMAP4 (even on OMAP4430). If this should be queued as a fix, then we need some kind of description here what breaks. I will resend the patch with a better commit message. This is a bug for sure, but I'm not sure how severe it is. At best we are not clearing the registers between CCFN, and CCDN on OMAP4. -- Péter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] OMAP4: dma: Correct CPU version check for dma_common_ch_end
CCDN is the last common channel register in all OMAP4 versions. Use cpu_is_omap44xx() instead of the cpu_is_omap4430() - which is anyway not doing what it supposed to do. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-omap2/dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c index a59a45a..b19d849 100644 --- a/arch/arm/mach-omap2/dma.c +++ b/arch/arm/mach-omap2/dma.c @@ -227,7 +227,7 @@ static int __init omap2_system_dma_init_dev(struct omap_hwmod *oh, void *unused) dma_stride = OMAP2_DMA_STRIDE; dma_common_ch_start = CSDP; - if (cpu_is_omap3630() || cpu_is_omap4430()) + if (cpu_is_omap3630() || cpu_is_omap44xx()) dma_common_ch_end = CCDN; else dma_common_ch_end = CCFN; -- 1.7.8.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
