Re: [PATCH 23/30] ARM: omap2: select twl4030 support on boards that need it
On Monday 03 October 2011 10:49:10 Santosh Shilimkar wrote: diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 57b66d5..4deeade 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -253,6 +253,8 @@ config MACH_OMAP_ZOOM2 select SERIAL_CORE_CONSOLE select SERIAL_8250_CONSOLE select REGULATOR_FIXED_VOLTAGE + select TWL4030_CORE + select I2C Another option to ensure I2C is selected when TWL* drivers are selected is let it depends on I2C. That wat we can avoid patching every machine entry with I2C option. Not a strong opinion though. I generally try to avoid having select statements where a depends on works fine, as in the generic TWL4030_CORE config. For platforms that require TWL4030, this does not work, although it would be better not to have this strict dependency and make the configuration build if the driver is disabled, even if that is rather pointless. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 23/30] ARM: omap2: select twl4030 support on boards that need it
* Arnd Bergmann a...@arndb.de [111002 07:13]: These three boards unconditionally use the twl4030 driver from the board-zoom-display.c file. Make sure that the driver is always there. We also need to select the I2C core so we are able to build that driver. Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/Kconfig |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 57b66d5..4deeade 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -253,6 +253,8 @@ config MACH_OMAP_ZOOM2 select SERIAL_CORE_CONSOLE select SERIAL_8250_CONSOLE select REGULATOR_FIXED_VOLTAGE + select TWL4030_CORE + select I2C config MACH_OMAP_ZOOM3 bool OMAP3630 Zoom3 board @@ -263,6 +265,8 @@ config MACH_OMAP_ZOOM3 select SERIAL_CORE_CONSOLE select SERIAL_8250_CONSOLE select REGULATOR_FIXED_VOLTAGE + select TWL4030_CORE + select I2C config MACH_CM_T35 bool CompuLab CM-T35/CM-T3730 modules @@ -304,6 +308,8 @@ config MACH_OMAP_3630SDP depends on ARCH_OMAP3 default y select OMAP_PACKAGE_CBP + select TWL4030_CORE + select I2C config MACH_TI8168EVM bool TI8168 Evaluation Module -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 23/30] ARM: omap2: select twl4030 support on boards that need it
These three boards unconditionally use the twl4030 driver from the board-zoom-display.c file. Make sure that the driver is always there. We also need to select the I2C core so we are able to build that driver. Signed-off-by: Arnd Bergmann a...@arndb.de --- arch/arm/mach-omap2/Kconfig |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 57b66d5..4deeade 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -253,6 +253,8 @@ config MACH_OMAP_ZOOM2 select SERIAL_CORE_CONSOLE select SERIAL_8250_CONSOLE select REGULATOR_FIXED_VOLTAGE + select TWL4030_CORE + select I2C config MACH_OMAP_ZOOM3 bool OMAP3630 Zoom3 board @@ -263,6 +265,8 @@ config MACH_OMAP_ZOOM3 select SERIAL_CORE_CONSOLE select SERIAL_8250_CONSOLE select REGULATOR_FIXED_VOLTAGE + select TWL4030_CORE + select I2C config MACH_CM_T35 bool CompuLab CM-T35/CM-T3730 modules @@ -304,6 +308,8 @@ config MACH_OMAP_3630SDP depends on ARCH_OMAP3 default y select OMAP_PACKAGE_CBP + select TWL4030_CORE + select I2C config MACH_TI8168EVM bool TI8168 Evaluation Module -- 1.7.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 23/30] ARM: omap2: select twl4030 support on boards that need it
On Sunday 02 October 2011 08:15 PM, Arnd Bergmann wrote: These three boards unconditionally use the twl4030 driver from the board-zoom-display.c file. Make sure that the driver is always there. We also need to select the I2C core so we are able to build that driver. Signed-off-by: Arnd Bergmann a...@arndb.de --- arch/arm/mach-omap2/Kconfig |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 57b66d5..4deeade 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -253,6 +253,8 @@ config MACH_OMAP_ZOOM2 select SERIAL_CORE_CONSOLE select SERIAL_8250_CONSOLE select REGULATOR_FIXED_VOLTAGE + select TWL4030_CORE + select I2C Another option to ensure I2C is selected when TWL* drivers are selected is let it depends on I2C. That wat we can avoid patching every machine entry with I2C option. Not a strong opinion though. Regards Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
