Re: [PATCHv2 13/14] ARM: OMAP24xx: clock: remove legacy clock data
On 03/05/2014 08:10 PM, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [140305 09:12]: * Tero Kristo t-kri...@ti.com [140305 00:17]: On 03/04/2014 11:28 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [140304 10:58]: On 03/04/2014 07:32 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [140304 01:22]: This is no longer needed as clock data is provided through DT. Looks like there's a new error even before applying this patch in the series as I'm now getting the following oops on n8x0. So cannot test this patch yet. Is this with OMAP2 only boot? Yeah that's with omap2 only. That explains it, as previous series was never boot tested in omap2 only config (due to build issues.) I just force pushed the branch with the below additional patch, can you check if it works now? Yes seems to work with that thanks. And with the omap2 legacy clock data removed too, it boots fine on n8x0 and 2430sdp. I suggest you drop the omap3 legacy data patch from this branch as it's not omap2 related and cannot be done yet. Then try to get acks from Paul. And if there are no issues, it seems Mike could take the whole branch as it seems to merge just fine with what I have queued. So for all the patches except for the omap3 legacy data removal, feel free to add: Acked-by: Tony Lindgren t...@atomide.com Found one randconfig error with this series when CONFIG_ARCH_OMAP2 is not set: /drivers/clk/ti/dpll.c:273: undefined reference to `omap2xxx_clkt_dpllcore_init' drivers/clk/ti/dpll.c:311: undefined reference to `clkhwops_omap2xxx_dpll' Yeah, this is in this series. Force pushed a minor update to patch #4 to fix this. I can repost the series if Mike or Paul or someone requests this. -Tero It's also possible the error is the PRM clean up series, but probably in this series based drivers/clk/ti/dpll.c path. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 13/14] ARM: OMAP24xx: clock: remove legacy clock data
On 03/04/2014 11:28 PM, Tony Lindgren wrote:
* Tero Kristo t-kri...@ti.com [140304 10:58]:
On 03/04/2014 07:32 PM, Tony Lindgren wrote:
* Tero Kristo t-kri...@ti.com [140304 01:22]:
This is no longer needed as clock data is provided through DT.
Looks like there's a new error even before applying this patch in
the series as I'm now getting the following oops on n8x0. So cannot
test this patch yet.
Is this with OMAP2 only boot?
Yeah that's with omap2 only.
That explains it, as previous series was never boot tested in omap2 only
config (due to build issues.)
I just force pushed the branch with the below additional patch, can you
check if it works now?
-Tero
From b8be115c8bba8088f7b25922ed81c1d5867af974 Mon Sep 17 00:00:00 2001
From: Tero Kristo t-kri...@ti.com
Date: Wed, 5 Mar 2014 10:03:38 +0200
Subject: [PATCH 12/15] CLK: TI: gate: add composite interface clock to OMAP2
only build
Composite interface clock is needed by OMAP2, but it was only built
in for OMAP3. Fixed the conditional build flag checks for this.
Signed-off-by: Tero Kristo t-kri...@ti.com
---
drivers/clk/ti/gate.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/ti/gate.c b/drivers/clk/ti/gate.c
index 3e2999d..474c171 100644
--- a/drivers/clk/ti/gate.c
+++ b/drivers/clk/ti/gate.c
@@ -185,7 +185,7 @@ of_ti_composite_no_wait_gate_clk_setup(struct
device_node *node)
CLK_OF_DECLARE(ti_composite_no_wait_gate_clk,
ti,composite-no-wait-gate-clock,
of_ti_composite_no_wait_gate_clk_setup);
-#ifdef CONFIG_ARCH_OMAP3
+#if defined(CONFIG_ARCH_OMAP2) || defined(CONFIG_ARCH_OMAP3)
static void __init of_ti_composite_interface_clk_setup(struct
device_node *node)
{
_of_ti_composite_gate_clk_setup(node, clkhwops_iclk_wait);
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 13/14] ARM: OMAP24xx: clock: remove legacy clock data
* Tero Kristo t-kri...@ti.com [140305 00:17]: On 03/04/2014 11:28 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [140304 10:58]: On 03/04/2014 07:32 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [140304 01:22]: This is no longer needed as clock data is provided through DT. Looks like there's a new error even before applying this patch in the series as I'm now getting the following oops on n8x0. So cannot test this patch yet. Is this with OMAP2 only boot? Yeah that's with omap2 only. That explains it, as previous series was never boot tested in omap2 only config (due to build issues.) I just force pushed the branch with the below additional patch, can you check if it works now? Yes seems to work with that thanks. And with the omap2 legacy clock data removed too, it boots fine on n8x0 and 2430sdp. I suggest you drop the omap3 legacy data patch from this branch as it's not omap2 related and cannot be done yet. Then try to get acks from Paul. And if there are no issues, it seems Mike could take the whole branch as it seems to merge just fine with what I have queued. So for all the patches except for the omap3 legacy data removal, feel free to add: Acked-by: Tony Lindgren t...@atomide.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 13/14] ARM: OMAP24xx: clock: remove legacy clock data
* Tony Lindgren t...@atomide.com [140305 09:12]: * Tero Kristo t-kri...@ti.com [140305 00:17]: On 03/04/2014 11:28 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [140304 10:58]: On 03/04/2014 07:32 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [140304 01:22]: This is no longer needed as clock data is provided through DT. Looks like there's a new error even before applying this patch in the series as I'm now getting the following oops on n8x0. So cannot test this patch yet. Is this with OMAP2 only boot? Yeah that's with omap2 only. That explains it, as previous series was never boot tested in omap2 only config (due to build issues.) I just force pushed the branch with the below additional patch, can you check if it works now? Yes seems to work with that thanks. And with the omap2 legacy clock data removed too, it boots fine on n8x0 and 2430sdp. I suggest you drop the omap3 legacy data patch from this branch as it's not omap2 related and cannot be done yet. Then try to get acks from Paul. And if there are no issues, it seems Mike could take the whole branch as it seems to merge just fine with what I have queued. So for all the patches except for the omap3 legacy data removal, feel free to add: Acked-by: Tony Lindgren t...@atomide.com Found one randconfig error with this series when CONFIG_ARCH_OMAP2 is not set: /drivers/clk/ti/dpll.c:273: undefined reference to `omap2xxx_clkt_dpllcore_init' drivers/clk/ti/dpll.c:311: undefined reference to `clkhwops_omap2xxx_dpll' It's also possible the error is the PRM clean up series, but probably in this series based drivers/clk/ti/dpll.c path. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 13/14] ARM: OMAP24xx: clock: remove legacy clock data
* Tero Kristo t-kri...@ti.com [140304 01:22]: This is no longer needed as clock data is provided through DT. Looks like there's a new error even before applying this patch in the series as I'm now getting the following oops on n8x0. So cannot test this patch yet. Regards, Tony [0.00] Linux version 3.14.0-rc4-00012-g4c73c72 (tmlind@muffinssi) (gcc version 4.3.5 (Debian 4.3.5-4) ) #393 Tue Mar 4 09:28:18 PST 2014 [0.00] CPU: ARMv6-compatible processor [4107b362] revision 2 (ARMv6TEJ), cr=00c5387d [0.00] CPU: VIPT aliasing data cache, VIPT aliasing instruction cache [0.00] Machine model: Nokia N800 [0.00] bootconsole [earlycon0] enabled [0.00] debug: ignoring loglevel setting. [0.00] Memory policy: Data cache writeback [0.00] On node 0 totalpages: 32768 [0.00] free_area_init_node: node 0, pgdat c0764e70, node_mem_map c7ef9000 [0.00] Normal zone: 256 pages used for memmap [0.00] Normal zone: 0 pages reserved [0.00] Normal zone: 32768 pages, LIFO batch:7 [0.00] CPU: All CPU(s) started in SVC mode. [0.00] OMAP2420 [0.00] [0.00] pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768 [0.00] pcpu-alloc: [0] 0 [0.00] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 32512 [0.00] Kernel command line: root=/dev/mmcblk0p2 rootwait console=ttyO2,115200 earlyprintk ignore_loglevel [0.00] PID hash table entries: 512 (order: -1, 2048 bytes) [0.00] Dentry cache hash table entries: 16384 (order: 4, 65536 bytes) [0.00] Inode-cache hash table entries: 8192 (order: 3, 32768 bytes) [0.00] Memory: 116716K/131072K available (5085K kernel code, 354K rwdata, 1828K rodata, 278K init, 5483K bss, 14356K reserved, 0K highmem) [0.00] Virtual kernel memory layout: [0.00] vector : 0x - 0x1000 ( 4 kB) [0.00] fixmap : 0xfff0 - 0xfffe ( 896 kB) [0.00] vmalloc : 0xc880 - 0xff00 ( 872 MB) [0.00] lowmem : 0xc000 - 0xc800 ( 128 MB) [0.00] pkmap : 0xbfe0 - 0xc000 ( 2 MB) [0.00] modules : 0xbf00 - 0xbfe0 ( 14 MB) [0.00] .text : 0xc0008000 - 0xc06c8a68 (6915 kB) [0.00] .init : 0xc06c9000 - 0xc070e9ac ( 279 kB) [0.00] .data : 0xc071 - 0xc0768b50 ( 355 kB) [0.00].bss : 0xc0768b50 - 0xc0cc3a10 (5484 kB) [0.00] NR_IRQS:16 nr_irqs:16 16 [0.00] IRQ: Found an INTC at 0xfa0fe000 (revision 2.0) with 96 interrupts [0.00] Total of 96 interrupts on 1 active controller [0.00] ti_dt_clocks_register: failed to lookup clock node usb_l4_ick [0.00] ti_dt_clocks_register: failed to lookup clock node dsp_ick [0.00] Clocking rate (Crystal/DPLL/MPU): 19.2/658/329 MHz [0.00] OMAP clockevent source: timer1 at 32768 Hz [0.61] sched_clock: 32 bits at 32kHz, resolution 30517ns, wraps every 655360ns [0.008758] OMAP clocksource: 32k_counter at 32768 Hz [0.014465] hw-breakpoint: CPUID feature registers not supported. Assuming v6 debug is present. [0.026245] Console: colour dummy device 80x30 [0.030975] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar [0.039184] ... MAX_LOCKDEP_SUBCLASSES: 8 [0.043609] ... MAX_LOCK_DEPTH: 48 [0.048004] ... MAX_LOCKDEP_KEYS:8191 [0.052673] ... CLASSHASH_SIZE: 4096 [0.057250] ... MAX_LOCKDEP_ENTRIES: 16384 [0.061981] ... MAX_LOCKDEP_CHAINS: 32768 [0.066680] ... CHAINHASH_SIZE: 16384 [0.071411] memory used by lock dependency info: 3695 kB [0.077056] per task-struct memory footprint: 1152 bytes [0.082916] Calibrating delay loop... 324.40 BogoMIPS (lpj=1622016) [0.143707] pid_max: default: 32768 minimum: 301 [0.149230] Security Framework initialized [0.153930] Mount-cache hash table entries: 512 [0.246917] CPU: Testing write buffer coherency: ok [0.256347] Setting up static identity map for 0x804d7bf0 - 0x804d7c60 [0.286285] VFP support v0.3: implementor 41 architecture 1 part 20 variant b rev 2 [0.313659] omap_hwmod: dsp: cannot clk_get interface_clk dsp_ick [0.320068] omap_hwmod: dsp: cannot _init_clocks [0.325042] [ cut here ] [0.329956] WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2543 _init+0xcc/0x18c() [0.339019] omap_hwmod: dsp: couldn't init clocks [0.344024] Modules linked in: [0.347320] CPU: 0 PID: 1 Comm: swapper Not tainted 3.14.0-rc4-00012-g4c73c72 #393 [0.355346] [c0013f9c] (unwind_backtrace) from [c00123cc] (show_stack+0x14/0x1c) [0.363555] [c00123cc] (show_stack) from [c00369ac] (warn_slowpath_common+0x64/0x84) [0.372100] [c00369ac] (warn_slowpath_common) from [c0036a60] (warn_slowpath_fmt+0x30/0x40)
Re: [PATCHv2 13/14] ARM: OMAP24xx: clock: remove legacy clock data
On 03/04/2014 07:32 PM, Tony Lindgren wrote: * Tero Kristo t-kri...@ti.com [140304 01:22]: This is no longer needed as clock data is provided through DT. Looks like there's a new error even before applying this patch in the series as I'm now getting the following oops on n8x0. So cannot test this patch yet. Is this with OMAP2 only boot? -Tero Regards, Tony [0.00] Linux version 3.14.0-rc4-00012-g4c73c72 (tmlind@muffinssi) (gcc version 4.3.5 (Debian 4.3.5-4) ) #393 Tue Mar 4 09:28:18 PST 2014 [0.00] CPU: ARMv6-compatible processor [4107b362] revision 2 (ARMv6TEJ), cr=00c5387d [0.00] CPU: VIPT aliasing data cache, VIPT aliasing instruction cache [0.00] Machine model: Nokia N800 [0.00] bootconsole [earlycon0] enabled [0.00] debug: ignoring loglevel setting. [0.00] Memory policy: Data cache writeback [0.00] On node 0 totalpages: 32768 [0.00] free_area_init_node: node 0, pgdat c0764e70, node_mem_map c7ef9000 [0.00] Normal zone: 256 pages used for memmap [0.00] Normal zone: 0 pages reserved [0.00] Normal zone: 32768 pages, LIFO batch:7 [0.00] CPU: All CPU(s) started in SVC mode. [0.00] OMAP2420 [0.00] [0.00] pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768 [0.00] pcpu-alloc: [0] 0 [0.00] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 32512 [0.00] Kernel command line: root=/dev/mmcblk0p2 rootwait console=ttyO2,115200 earlyprintk ignore_loglevel [0.00] PID hash table entries: 512 (order: -1, 2048 bytes) [0.00] Dentry cache hash table entries: 16384 (order: 4, 65536 bytes) [0.00] Inode-cache hash table entries: 8192 (order: 3, 32768 bytes) [0.00] Memory: 116716K/131072K available (5085K kernel code, 354K rwdata, 1828K rodata, 278K init, 5483K bss, 14356K reserved, 0K highmem) [0.00] Virtual kernel memory layout: [0.00] vector : 0x - 0x1000 ( 4 kB) [0.00] fixmap : 0xfff0 - 0xfffe ( 896 kB) [0.00] vmalloc : 0xc880 - 0xff00 ( 872 MB) [0.00] lowmem : 0xc000 - 0xc800 ( 128 MB) [0.00] pkmap : 0xbfe0 - 0xc000 ( 2 MB) [0.00] modules : 0xbf00 - 0xbfe0 ( 14 MB) [0.00] .text : 0xc0008000 - 0xc06c8a68 (6915 kB) [0.00] .init : 0xc06c9000 - 0xc070e9ac ( 279 kB) [0.00] .data : 0xc071 - 0xc0768b50 ( 355 kB) [0.00].bss : 0xc0768b50 - 0xc0cc3a10 (5484 kB) [0.00] NR_IRQS:16 nr_irqs:16 16 [0.00] IRQ: Found an INTC at 0xfa0fe000 (revision 2.0) with 96 interrupts [0.00] Total of 96 interrupts on 1 active controller [0.00] ti_dt_clocks_register: failed to lookup clock node usb_l4_ick [0.00] ti_dt_clocks_register: failed to lookup clock node dsp_ick [0.00] Clocking rate (Crystal/DPLL/MPU): 19.2/658/329 MHz [0.00] OMAP clockevent source: timer1 at 32768 Hz [0.61] sched_clock: 32 bits at 32kHz, resolution 30517ns, wraps every 655360ns [0.008758] OMAP clocksource: 32k_counter at 32768 Hz [0.014465] hw-breakpoint: CPUID feature registers not supported. Assuming v6 debug is present. [0.026245] Console: colour dummy device 80x30 [0.030975] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar [0.039184] ... MAX_LOCKDEP_SUBCLASSES: 8 [0.043609] ... MAX_LOCK_DEPTH: 48 [0.048004] ... MAX_LOCKDEP_KEYS:8191 [0.052673] ... CLASSHASH_SIZE: 4096 [0.057250] ... MAX_LOCKDEP_ENTRIES: 16384 [0.061981] ... MAX_LOCKDEP_CHAINS: 32768 [0.066680] ... CHAINHASH_SIZE: 16384 [0.071411] memory used by lock dependency info: 3695 kB [0.077056] per task-struct memory footprint: 1152 bytes [0.082916] Calibrating delay loop... 324.40 BogoMIPS (lpj=1622016) [0.143707] pid_max: default: 32768 minimum: 301 [0.149230] Security Framework initialized [0.153930] Mount-cache hash table entries: 512 [0.246917] CPU: Testing write buffer coherency: ok [0.256347] Setting up static identity map for 0x804d7bf0 - 0x804d7c60 [0.286285] VFP support v0.3: implementor 41 architecture 1 part 20 variant b rev 2 [0.313659] omap_hwmod: dsp: cannot clk_get interface_clk dsp_ick [0.320068] omap_hwmod: dsp: cannot _init_clocks [0.325042] [ cut here ] [0.329956] WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2543 _init+0xcc/0x18c() [0.339019] omap_hwmod: dsp: couldn't init clocks [0.344024] Modules linked in: [0.347320] CPU: 0 PID: 1 Comm: swapper Not tainted 3.14.0-rc4-00012-g4c73c72 #393 [0.355346] [c0013f9c] (unwind_backtrace) from [c00123cc] (show_stack+0x14/0x1c) [0.363555] [c00123cc] (show_stack) from [c00369ac] (warn_slowpath_common+0x64/0x84) [
