Re: [PATCHv5 0/6] ARM: OMAP3+: IO daisy chain support fixes
On Fri, 2012-03-09 at 21:05 -0700, Paul Walmsley wrote: Hi On Tue, 6 Mar 2012, Tero Kristo wrote: Changes compared to previous version: - patch2: * fixed the timeout for waiting for ST_IO_CHAIN == 1 * added clear for ST_IO_CHAIN bit (as per spec + implementation in patch 1) * replaced the timeout at the end of function with a simple register readback (timing out on a register value that we are clearing does not make that much sense, the bit is cleared the very first time CPU manages to read it) - patch5: * added spinlock for protecting io_chain_trigger operation Tested on omap3 beagle + omap4 blaze. Also did measurements for the cost of IO chain trigger operation with ARM performance counters: - omap3 approx 7...8us - omap4 approx 2...4us Thanks for the changes. So as you probably already saw, a few changes have been made. The updated series is in the branch 'io_chain_devel_3.4' on git://git.pwsan.com/linux-2.6. The main outstanding question is whether the OMAP4 WUCLKOUT poll should be removed to match the v5 changes to the OMAP3 function. Please let me know. Any other testing or comments are of course welcome. Just tested your branch with omap3 beagle + omap4 blaze (with my omap4 cswr set on top), and it works on both. For the WUCLK poll bit I added detailed comments on patch 2 thread, but my current understanding is that the implementation now on omap3 / omap4 is what they should be due to IP differences (except maybe the small optimization for omap3 part you commented about.) -Tero -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv5 0/6] ARM: OMAP3+: IO daisy chain support fixes
Hi Tero, Rajendra, On Mon, 12 Mar 2012, Tero Kristo wrote: Just tested your branch with omap3 beagle + omap4 blaze (with my omap4 cswr set on top), and it works on both. For the WUCLK poll bit I added detailed comments on patch 2 thread, but my current understanding is that the implementation now on omap3 / omap4 is what they should be due to IP differences (except maybe the small optimization for omap3 part you commented about.) Thank you both for the detailed comments and explanation on this series, and the testing... sounds like this set is okay to go. - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv5 0/6] ARM: OMAP3+: IO daisy chain support fixes
On Saturday 10 March 2012 09:35 AM, Paul Walmsley wrote: The main outstanding question is whether the OMAP4 WUCLKOUT poll should be removed to match the v5 changes to the OMAP3 function. Please let me know. Any other testing or comments are of course welcome. I think we should instead add it back in omap3 and keep the omap4 as is. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv5 0/6] ARM: OMAP3+: IO daisy chain support fixes
On Sunday 11 March 2012 02:59 AM, Paul Walmsley wrote: Hi Hi Paul, By the way, one other thing I forgot to mention. It would be really great if kerneldoc comments can be created for any new functions added to hwmod, PRCM, clock, or omap_device code. The intention is to help not only people unfamiliar with the code, but even ourselves in the future. I've been adding these by hand on Tero's last few patch series, but at some point I'll probably stop accepting patches without kerneldoc. Thanks for updating the kerneldoc comments this time around. Will make sure patches hence forth come with adequate documentation added. thanks, Rajendra thanks, - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv5 0/6] ARM: OMAP3+: IO daisy chain support fixes
Hi By the way, one other thing I forgot to mention. It would be really great if kerneldoc comments can be created for any new functions added to hwmod, PRCM, clock, or omap_device code. The intention is to help not only people unfamiliar with the code, but even ourselves in the future. I've been adding these by hand on Tero's last few patch series, but at some point I'll probably stop accepting patches without kerneldoc. thanks, - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv5 0/6] ARM: OMAP3+: IO daisy chain support fixes
Hi On Tue, 6 Mar 2012, Tero Kristo wrote: Changes compared to previous version: - patch2: * fixed the timeout for waiting for ST_IO_CHAIN == 1 * added clear for ST_IO_CHAIN bit (as per spec + implementation in patch 1) * replaced the timeout at the end of function with a simple register readback (timing out on a register value that we are clearing does not make that much sense, the bit is cleared the very first time CPU manages to read it) - patch5: * added spinlock for protecting io_chain_trigger operation Tested on omap3 beagle + omap4 blaze. Also did measurements for the cost of IO chain trigger operation with ARM performance counters: - omap3 approx 7...8us - omap4 approx 2...4us Thanks for the changes. So as you probably already saw, a few changes have been made. The updated series is in the branch 'io_chain_devel_3.4' on git://git.pwsan.com/linux-2.6. The main outstanding question is whether the OMAP4 WUCLKOUT poll should be removed to match the v5 changes to the OMAP3 function. Please let me know. Any other testing or comments are of course welcome. - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCHv5 0/6] ARM: OMAP3+: IO daisy chain support fixes
Hi, Changes compared to previous version: - patch2: * fixed the timeout for waiting for ST_IO_CHAIN == 1 * added clear for ST_IO_CHAIN bit (as per spec + implementation in patch 1) * replaced the timeout at the end of function with a simple register readback (timing out on a register value that we are clearing does not make that much sense, the bit is cleared the very first time CPU manages to read it) - patch5: * added spinlock for protecting io_chain_trigger operation Tested on omap3 beagle + omap4 blaze. Also did measurements for the cost of IO chain trigger operation with ARM performance counters: - omap3 approx 7...8us - omap4 approx 2...4us -Tero -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
