Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
>- Please ping me one that happens Well, to ease and speed up things, I'll simply resend in a minute based on arm64-dt-for-v4.12. signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
Hi Simon, On Fri, Jan 27, 2017 at 09:16:08AM +0100, Simon Horman wrote: > On Fri, Jan 27, 2017 at 08:27:28AM +0100, Wolfram Sang wrote: > > > > > Using renesas-next without mmc-next I see the problem above on the M3-W. > > > Using renesas-next with mmc-next I do not see the problem above. > > > Using v4.10-rc2 I also do not see the problem above. > > > > OK. So there is no problem with the code, at least. > > > > > So I believe we should delay the integration change, which is currently in > > > renesas-next, until the driver change in mmc-next hits Linus's tree. > > > > Whatever you do, H3 and M3-W should be treated equally IMO. > > Sure, that is reasonable. This is what I plan to do: > > 1. Drop this series from v4.11 > 2. Re-queue them for v4.12 once the driver changes hit an rc release >- Please ping me one that happens Ping :) Do I need to resend? If so, what branch should I base this on? Have a nice weekend, Wolfram signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Fri, Jan 27, 2017 at 08:27:28AM +0100, Wolfram Sang wrote: > > > Using renesas-next without mmc-next I see the problem above on the M3-W. > > Using renesas-next with mmc-next I do not see the problem above. > > Using v4.10-rc2 I also do not see the problem above. > > OK. So there is no problem with the code, at least. > > > So I believe we should delay the integration change, which is currently in > > renesas-next, until the driver change in mmc-next hits Linus's tree. > > Whatever you do, H3 and M3-W should be treated equally IMO. Sure, that is reasonable. This is what I plan to do: 1. Drop this series from v4.11 2. Re-queue them for v4.12 once the driver changes hit an rc release - Please ping me one that happens
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
> Using renesas-next without mmc-next I see the problem above on the M3-W. > Using renesas-next with mmc-next I do not see the problem above. > Using v4.10-rc2 I also do not see the problem above. OK. So there is no problem with the code, at least. > So I believe we should delay the integration change, which is currently in > renesas-next, until the driver change in mmc-next hits Linus's tree. Whatever you do, H3 and M3-W should be treated equally IMO. signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Thu, Jan 26, 2017 at 09:17:02PM +0100, Wolfram Sang wrote: > > > The problem I see is the following logged to the console > > (which makes the console semi-unusable). > > > > sh_mobile_sdhi ee14.sd: timeout waiting for hardware interrupt (CMD13) > > Just to make sure: with the HS200 enablement patches present? Using renesas-next without mmc-next I see the problem above on the M3-W. Using renesas-next with mmc-next I do not see the problem above. Using v4.10-rc2 I also do not see the problem above. So I believe we should delay the integration change, which is currently in renesas-next, until the driver change in mmc-next hits Linus's tree.
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
> The problem I see is the following logged to the console > (which makes the console semi-unusable). > > sh_mobile_sdhi ee14.sd: timeout waiting for hardware interrupt (CMD13) Just to make sure: with the HS200 enablement patches present? signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Thu, Jan 26, 2017 at 03:16:57PM +0100, Wolfram Sang wrote: > > > I have tested with "the new mmc/next" and things seem better. > > Good. The issue you saw is expected when you have not the enablement > patches in place. > > > I am still of a mind to drop the M3-W patch of this series because unless > > we can control the order that things are merged into Linus's tree > > there will be a temporary regression there. Moreover I'm not very excited > > about renesas-next having regressed. > > I have not heard of a regression. Geert, did you report that? Did I miss > that? As you can see, I did test the patches with M3 as well: > > http://elinux.org/Tests:eMMC-HS > > and Jinso test team (Duc-san) confirmed it works for them with H3 and > M3-W. In private communication, though. The problem I see is the following logged to the console (which makes the console semi-unusable). sh_mobile_sdhi ee14.sd: timeout waiting for hardware interrupt (CMD13) I'm on IRC if you'd like to chat there.
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
> The issue happened with renesas-devel, i.e. without those patches. > It was mentioned during last core meeting, so have a look at that log. No need to. As I said, the behaviour is expected without the patches. Thanks for the update! signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
Hi Wolfram, On Thu, Jan 26, 2017 at 3:16 PM, Wolfram Sangwrote: >> I have tested with "the new mmc/next" and things seem better. > > Good. The issue you saw is expected when you have not the enablement > patches in place. > >> I am still of a mind to drop the M3-W patch of this series because unless >> we can control the order that things are merged into Linus's tree >> there will be a temporary regression there. Moreover I'm not very excited >> about renesas-next having regressed. > > I have not heard of a regression. Geert, did you report that? Did I miss > that? As you can see, I did test the patches with M3 as well: > > http://elinux.org/Tests:eMMC-HS > > and Jinso test team (Duc-san) confirmed it works for them with H3 and > M3-W. In private communication, though. The issue happened with renesas-devel, i.e. without those patches. It was mentioned during last core meeting, so have a look at that log. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
> I have tested with "the new mmc/next" and things seem better. Good. The issue you saw is expected when you have not the enablement patches in place. > I am still of a mind to drop the M3-W patch of this series because unless > we can control the order that things are merged into Linus's tree > there will be a temporary regression there. Moreover I'm not very excited > about renesas-next having regressed. I have not heard of a regression. Geert, did you report that? Did I miss that? As you can see, I did test the patches with M3 as well: http://elinux.org/Tests:eMMC-HS and Jinso test team (Duc-san) confirmed it works for them with H3 and M3-W. In private communication, though. Regards, Wolfram signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Thu, Jan 26, 2017 at 02:54:53PM +0100, Wolfram Sang wrote: > > > > Do you already fetch from Ulf's kernel.org tree? He switched away from > > > the Linaro tree for MMC for a while. I only realized when he complained > > "since a while" not "for a while", of course. > > > Thanks, I had not realised that. I've pulled the kernel.org tree. I have tested with "the new mmc/next" and things seem better. The problem does not appear to manifest in light testing. > So, there is hope for the patches to be in v4.11? :) On Thu, Jan 26, 2017 at 02:58:58PM +0100, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Thu, Jan 26, 2017 at 11:03 AM, Wolfram Sangwrote: > > On Thu, Jan 26, 2017 at 11:01:17AM +0100, Simon Horman wrote: > >> On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote: > >> > > Sorry for missing these. > >> > > I have queued them up for v4.11. > >> > > >> > Thank you! > >> > >> On my r8a7796/salvator-x I see the following with this series applied: > >> > >> sh_mobile_sdhi ee14.sd: timeout waiting for hardware interrupt (CMD13) > > > > Do you have the HS200 enablement patches in that branch? They are > > currently in -next. > > I saw the same thing with renesas-devel last week, only on M3-W. > The same kernel on H3 didn't spew such messages. > According to Shimoda-san, it was due to different eMMCs on H3 and M3-W. Thanks, my interpretation of that is that the H3 patch of this series is fine. I am still of a mind to drop the M3-W patch of this series because unless we can control the order that things are merged into Linus's tree there will be a temporary regression there. Moreover I'm not very excited about renesas-next having regressed.
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
Hi Wolfram, On Thu, Jan 26, 2017 at 11:03 AM, Wolfram Sangwrote: > On Thu, Jan 26, 2017 at 11:01:17AM +0100, Simon Horman wrote: >> On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote: >> > > Sorry for missing these. >> > > I have queued them up for v4.11. >> > >> > Thank you! >> >> On my r8a7796/salvator-x I see the following with this series applied: >> >> sh_mobile_sdhi ee14.sd: timeout waiting for hardware interrupt (CMD13) > > Do you have the HS200 enablement patches in that branch? They are > currently in -next. I saw the same thing with renesas-devel last week, only on M3-W. The same kernel on H3 didn't spew such messages. According to Shimoda-san, it was due to different eMMCs on H3 and M3-W. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
> > Do you already fetch from Ulf's kernel.org tree? He switched away from > > the Linaro tree for MMC for a while. I only realized when he complained "since a while" not "for a while", of course. > Thanks, I had not realised that. I've pulled the kernel.org tree. So, there is hope for the patches to be in v4.11? :) signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Thu, Jan 26, 2017 at 12:36:57PM +0100, Wolfram Sang wrote: > > > > Do you have the HS200 enablement patches in that branch? They are > > > currently in -next. > > > > I tried mmc/next (but didn't notice anything special there). > > Which patches should I be looking for? > > The series starting with 59c21074b582aa ("mmc: sh_mobile_sdhi: simplify > accessing DT data") up to 8c81459fa8adec ("mmc: sh_mobile_sdhi: enable > HS200"). > > Do you already fetch from Ulf's kernel.org tree? He switched away from > the Linaro tree for MMC for a while. I only realized when he complained > that he can't apply my patches. Thanks, I had not realised that. I've pulled the kernel.org tree.
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
> > Do you have the HS200 enablement patches in that branch? They are > > currently in -next. > > I tried mmc/next (but didn't notice anything special there). > Which patches should I be looking for? The series starting with 59c21074b582aa ("mmc: sh_mobile_sdhi: simplify accessing DT data") up to 8c81459fa8adec ("mmc: sh_mobile_sdhi: enable HS200"). Do you already fetch from Ulf's kernel.org tree? He switched away from the Linaro tree for MMC for a while. I only realized when he complained that he can't apply my patches. signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Thu, Jan 26, 2017 at 11:03:56AM +0100, Wolfram Sang wrote: > On Thu, Jan 26, 2017 at 11:01:17AM +0100, Simon Horman wrote: > > On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote: > > > > Sorry for missing these. > > > > I have queued them up for v4.11. > > > > > > Thank you! > > > > On my r8a7796/salvator-x I see the following with this series applied: > > > > sh_mobile_sdhi ee14.sd: timeout waiting for hardware interrupt (CMD13) > > Do you have the HS200 enablement patches in that branch? They are > currently in -next. I tried mmc/next (but didn't notice anything special there). Which patches should I be looking for?
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Thu, Jan 26, 2017 at 11:01:17AM +0100, Simon Horman wrote: > On Fri, Jan 13, 2017 at 09:39:28AM +0100, Wolfram Sang wrote: > > > Sorry for missing these. > > > I have queued them up for v4.11. > > > > Thank you! > > On my r8a7796/salvator-x I see the following with this series applied: > > sh_mobile_sdhi ee14.sd: timeout waiting for hardware interrupt (CMD13) Do you have the HS200 enablement patches in that branch? They are currently in -next. signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
> Sorry for missing these. > I have queued them up for v4.11. Thank you! signature.asc Description: PGP signature
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Thu, Jan 12, 2017 at 11:43:53PM +0100, Wolfram Sang wrote: > On Wed, Jan 04, 2017 at 06:39:52PM +0100, Wolfram Sang wrote: > > Simon, > > > > as Ulf picked up the driver patches for HS200 support, it is now safe to > > pick > > up the DTS patches, I'd say? I rebased them to the dt-for-4.11 branch. > > > > All the best, > > > >Wolfram > > > > > > Wolfram Sang (2): > > arm64: dts: r8a7795: enable HS200 for eMMC > > arm64: dts: r8a7796: enable HS200 for eMMC > > > > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 + > > arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 + > > 2 files changed, 2 insertions(+) > > Ping :) Sorry for missing these. I have queued them up for v4.11.
Re: [PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
On Wed, Jan 04, 2017 at 06:39:52PM +0100, Wolfram Sang wrote: > Simon, > > as Ulf picked up the driver patches for HS200 support, it is now safe to pick > up the DTS patches, I'd say? I rebased them to the dt-for-4.11 branch. > > All the best, > >Wolfram > > > Wolfram Sang (2): > arm64: dts: r8a7795: enable HS200 for eMMC > arm64: dts: r8a7796: enable HS200 for eMMC > > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 + > arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 + > 2 files changed, 2 insertions(+) Ping :) signature.asc Description: PGP signature
[PATCH RESEND 0/2] arm64: gen3: enable eMMC HS200 in DT
Simon, as Ulf picked up the driver patches for HS200 support, it is now safe to pick up the DTS patches, I'd say? I rebased them to the dt-for-4.11 branch. All the best, Wolfram Wolfram Sang (2): arm64: dts: r8a7795: enable HS200 for eMMC arm64: dts: r8a7796: enable HS200 for eMMC arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 + arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 1 + 2 files changed, 2 insertions(+) -- 2.10.2