Re: [PATCH v2 8/8] arm64: dts: renesas: ebisu: Add HDMI and CVBS input
On Wed, Sep 12, 2018 at 01:08:21PM +0200, jacopo mondi wrote: > Hi Simon, > > On Wed, Sep 12, 2018 at 11:29:51AM +0200, Simon Horman wrote: > > On Mon, Sep 10, 2018 at 05:21:08PM +0300, Laurent Pinchart wrote: > > > Hi Jacopo, > > > > > > Thank you for the patch. > > > > > > On Wednesday, 5 September 2018 18:29:45 EEST Jacopo Mondi wrote: > > > > Add HDMI and CVBS inputs device nodes to R-Car E3 Ebisu board. > > > > > > > > Both HDMI and CVBS inputs are connected to an ADV7482 video decoder > > > > hooked > > > > to the SoC CSI-2 receiver port. > > > > > > > > Signed-off-by: Jacopo Mondi > > > > > > Reviewed-by: Laurent Pinchart > > > > Jacopo, > > > > I assume that this patch depends on 7/8. > > Please repost this patch when you repost that one, > > addressing Laurent's feedback. > > Sorry, I'm now confused :) > I don't see any pending comment on [7/8] nor on this one ([8/8]). > [7/8] has been applied to your "arm64-dt-for-v4.20" branch already > (just checked). > > I have a small comment on [6/8] and one open question on [5/8]. All > the other patches have been reviewed/acked already. > > To sum up: do you want me to repost [7/8] when re-sending this series? No need. I now see that 6/8 and 7/8 are in my tree. And that this patch, 8/8, has now been reviewed so I have applied it too. So I think all the patches in this series targeted at my tree have now been applied. Please consider a follow-up patch to address the review of 6/8.
Re: [PATCH v2 8/8] arm64: dts: renesas: ebisu: Add HDMI and CVBS input
Hi Simon, On Wed, Sep 12, 2018 at 11:29:51AM +0200, Simon Horman wrote: > On Mon, Sep 10, 2018 at 05:21:08PM +0300, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > > > On Wednesday, 5 September 2018 18:29:45 EEST Jacopo Mondi wrote: > > > Add HDMI and CVBS inputs device nodes to R-Car E3 Ebisu board. > > > > > > Both HDMI and CVBS inputs are connected to an ADV7482 video decoder hooked > > > to the SoC CSI-2 receiver port. > > > > > > Signed-off-by: Jacopo Mondi > > > > Reviewed-by: Laurent Pinchart > > Jacopo, > > I assume that this patch depends on 7/8. > Please repost this patch when you repost that one, > addressing Laurent's feedback. Sorry, I'm now confused :) I don't see any pending comment on [7/8] nor on this one ([8/8]). [7/8] has been applied to your "arm64-dt-for-v4.20" branch already (just checked). I have a small comment on [6/8] and one open question on [5/8]. All the other patches have been reviewed/acked already. To sum up: do you want me to repost [7/8] when re-sending this series? Thanks j signature.asc Description: PGP signature
Re: [PATCH v2 8/8] arm64: dts: renesas: ebisu: Add HDMI and CVBS input
On Mon, Sep 10, 2018 at 05:21:08PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Wednesday, 5 September 2018 18:29:45 EEST Jacopo Mondi wrote: > > Add HDMI and CVBS inputs device nodes to R-Car E3 Ebisu board. > > > > Both HDMI and CVBS inputs are connected to an ADV7482 video decoder hooked > > to the SoC CSI-2 receiver port. > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Laurent Pinchart Jacopo, I assume that this patch depends on 7/8. Please repost this patch when you repost that one, addressing Laurent's feedback.
Re: [PATCH v2 8/8] arm64: dts: renesas: ebisu: Add HDMI and CVBS input
Hi Jacopo,
Thank you for the patch.
On Wednesday, 5 September 2018 18:29:45 EEST Jacopo Mondi wrote:
> Add HDMI and CVBS inputs device nodes to R-Car E3 Ebisu board.
>
> Both HDMI and CVBS inputs are connected to an ADV7482 video decoder hooked
> to the SoC CSI-2 receiver port.
>
> Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
> ---
> arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 86 +++
> 1 file changed, 86 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index 2bc3a48..d2faf3e
> 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -28,6 +28,29 @@
> /* first 128MB is reserved for secure area. */
> reg = <0x0 0x4800 0x0 0x3800>;
> };
> +
> + cvbs-in {
> + compatible = "composite-video-connector";
> + label = "CVBS IN";
> +
> + port {
> + cvbs_con: endpoint {
> + remote-endpoint = <&adv7482_ain7>;
> + };
> + };
> + };
> +
> + hdmi-in {
> + compatible = "hdmi-connector";
> + label = "HDMI IN";
> + type = "a";
> +
> + port {
> + hdmi_in_con: endpoint {
> + remote-endpoint = <&adv7482_hdmi>;
> + };
> + };
> + };
> };
>
> &avb {
> @@ -47,6 +70,22 @@
> };
> };
>
> +&csi40 {
> + status = "okay";
> +
> + ports {
> + port@0 {
> + reg = <0>;
> +
> + csi40_in: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2>;
> + remote-endpoint = <&adv7482_txa>;
> + };
> + };
> + };
> +};
> +
> &ehci0 {
> status = "okay";
> };
> @@ -55,6 +94,49 @@
> clock-frequency = <4800>;
> };
>
> +&i2c0 {
> + status = "okay";
> +
> + video-receiver@70 {
> + compatible = "adi,adv7482";
> + reg = <0x70>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + interrupt-parent = <&gpio0>;
> + interrupt-names = "intrq1", "intrq2";
> + interrupts = <7 IRQ_TYPE_LEVEL_LOW>,
> + <17 IRQ_TYPE_LEVEL_LOW>;
> +
> + port@7 {
> + reg = <7>;
> +
> + adv7482_ain7: endpoint {
> + remote-endpoint = <&cvbs_con>;
> + };
> + };
> +
> + port@8 {
> + reg = <8>;
> +
> + adv7482_hdmi: endpoint {
> + remote-endpoint = <&hdmi_in_con>;
> + };
> + };
> +
> + port@a {
> + reg = <0xa>;
> +
> + adv7482_txa: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2>;
> + remote-endpoint = <&csi40_in>;
> + };
> + };
> + };
> +};
> +
> &ohci0 {
> status = "okay";
> };
> @@ -94,6 +176,10 @@
> status = "okay";
> };
>
> +&vin4 {
> + status = "okay";
> +};
> +
> &xhci0 {
> pinctrl-0 = <&usb30_pins>;
> pinctrl-names = "default";
--
Regards,
Laurent Pinchart
[PATCH v2 8/8] arm64: dts: renesas: ebisu: Add HDMI and CVBS input
Add HDMI and CVBS inputs device nodes to R-Car E3 Ebisu board.
Both HDMI and CVBS inputs are connected to an ADV7482 video decoder hooked to
the SoC CSI-2 receiver port.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 86 ++
1 file changed, 86 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 2bc3a48..d2faf3e 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -28,6 +28,29 @@
/* first 128MB is reserved for secure area. */
reg = <0x0 0x4800 0x0 0x3800>;
};
+
+ cvbs-in {
+ compatible = "composite-video-connector";
+ label = "CVBS IN";
+
+ port {
+ cvbs_con: endpoint {
+ remote-endpoint = <&adv7482_ain7>;
+ };
+ };
+ };
+
+ hdmi-in {
+ compatible = "hdmi-connector";
+ label = "HDMI IN";
+ type = "a";
+
+ port {
+ hdmi_in_con: endpoint {
+ remote-endpoint = <&adv7482_hdmi>;
+ };
+ };
+ };
};
&avb {
@@ -47,6 +70,22 @@
};
};
+&csi40 {
+ status = "okay";
+
+ ports {
+ port@0 {
+ reg = <0>;
+
+ csi40_in: endpoint {
+ clock-lanes = <0>;
+ data-lanes = <1 2>;
+ remote-endpoint = <&adv7482_txa>;
+ };
+ };
+ };
+};
+
&ehci0 {
status = "okay";
};
@@ -55,6 +94,49 @@
clock-frequency = <4800>;
};
+&i2c0 {
+ status = "okay";
+
+ video-receiver@70 {
+ compatible = "adi,adv7482";
+ reg = <0x70>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ interrupt-parent = <&gpio0>;
+ interrupt-names = "intrq1", "intrq2";
+ interrupts = <7 IRQ_TYPE_LEVEL_LOW>,
+<17 IRQ_TYPE_LEVEL_LOW>;
+
+ port@7 {
+ reg = <7>;
+
+ adv7482_ain7: endpoint {
+ remote-endpoint = <&cvbs_con>;
+ };
+ };
+
+ port@8 {
+ reg = <8>;
+
+ adv7482_hdmi: endpoint {
+ remote-endpoint = <&hdmi_in_con>;
+ };
+ };
+
+ port@a {
+ reg = <0xa>;
+
+ adv7482_txa: endpoint {
+ clock-lanes = <0>;
+ data-lanes = <1 2>;
+ remote-endpoint = <&csi40_in>;
+ };
+ };
+ };
+};
+
&ohci0 {
status = "okay";
};
@@ -94,6 +176,10 @@
status = "okay";
};
+&vin4 {
+ status = "okay";
+};
+
&xhci0 {
pinctrl-0 = <&usb30_pins>;
pinctrl-names = "default";
--
2.7.4
