Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi

[Simon Horman]

On Tue, Nov 06, 2018 at 11:18:14AM +0100, Geert Uytterhoeven wrote:
> Hi Biju,
> 
> On Fri, Oct 26, 2018 at 11:40 AM Biju Das  wrote:
> > This patch adds watchdog support to the r8a77470 SoC dtsi.
> >
> > Signed-off-by: Biju Das 
> 
> Thanks for your patch!
> 
> > --- a/arch/arm/boot/dts/r8a77470.dtsi
> > +++ b/arch/arm/boot/dts/r8a77470.dtsi
> > @@ -196,6 +196,16 @@
> > reg = <0 0xe616 0 0x100>;
> > };
> >
> > +   rwdt: watchdog@e602 {
> 
> Please follow the sort order rules:
>   - By unit-address (if present), per group,
>   - Alphabetically.

Thanks for noticing.

As I had already applied this patch I took the liberty of updating
it to preserve node sort order. The updates patch is as follows:

From: Biju Das 
Date: Fri, 26 Oct 2018 10:32:26 +0100
Subject: [PATCH] ARM: dts: r8a77470: Add watchdog support to SoC dtsi

This patch adds watchdog support to the r8a77470 SoC dtsi.

Signed-off-by: Biju Das 
Reviewed-by: Fabrizio Castro 
[simon: moved node to preserve sort order]
Signed-off-by: Simon Horman 
---
 arch/arm/boot/dts/r8a77470.dtsi | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 6ac7f467065e..a703b74cc1f9 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -79,6 +79,16 @@
#size-cells = <2>;
ranges;
 
+   rwdt: watchdog@e602 {
+   compatible = "renesas,r8a77470-wdt",
+"renesas,rcar-gen2-wdt";
+   reg = <0 0xe602 0 0x0c>;
+   clocks = < CPG_MOD 402>;
+   power-domains = < R8A77470_PD_ALWAYS_ON>;
+   resets = < 402>;
+   status = "disabled";
+   };
+
gpio0: gpio@e605 {
compatible = "renesas,gpio-r8a77470",
 "renesas,rcar-gen2-gpio";
-- 
2.11.0

Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi

[Geert Uytterhoeven]

Hi Biju,

On Fri, Oct 26, 2018 at 11:40 AM Biju Das  wrote:
> This patch adds watchdog support to the r8a77470 SoC dtsi.
>
> Signed-off-by: Biju Das 

Thanks for your patch!

> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> @@ -196,6 +196,16 @@
> reg = <0 0xe616 0 0x100>;
> };
>
> +   rwdt: watchdog@e602 {

Please follow the sort order rules:
  - By unit-address (if present), per group,
  - Alphabetically.

> +   compatible = "renesas,r8a77470-wdt",
> +"renesas,rcar-gen2-wdt";
> +   reg = <0 0xe602 0 0x0c>;
> +   clocks = < CPG_MOD 402>;
> +   power-domains = < R8A77470_PD_ALWAYS_ON>;
> +   resets = < 402>;
> +   status = "disabled";
> +   };
> +
> sysc: system-controller@e618 {
> compatible = "renesas,r8a77470-sysc";
> reg = <0 0xe618 0 0x200>;

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi

[Simon Horman]

On Fri, Oct 26, 2018 at 09:42:38AM +, Fabrizio Castro wrote:
> > Subject: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
> >
> > This patch adds watchdog support to the r8a77470 SoC dtsi.
> >
> > Signed-off-by: Biju Das 
> 
> Reviewed-by: Fabrizio Castro 

Thanks, applied for v4.21.

RE: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi

[Fabrizio Castro]

> Subject: [PATCH 1/2] ARM: dts: r8a77470: Add watchdog support to SoC dtsi
>
> This patch adds watchdog support to the r8a77470 SoC dtsi.
>
> Signed-off-by: Biju Das 

Reviewed-by: Fabrizio Castro 

> ---
> This patch tested against renesas-dev
> ---
>  arch/arm/boot/dts/r8a77470.dtsi | 10 ++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
> index e40f5a9..872ad3a 100644
> --- a/arch/arm/boot/dts/r8a77470.dtsi
> +++ b/arch/arm/boot/dts/r8a77470.dtsi
> @@ -196,6 +196,16 @@
>  reg = <0 0xe616 0 0x100>;
>  };
>
> +rwdt: watchdog@e602 {
> +compatible = "renesas,r8a77470-wdt",
> + "renesas,rcar-gen2-wdt";
> +reg = <0 0xe602 0 0x0c>;
> +clocks = < CPG_MOD 402>;
> +power-domains = < R8A77470_PD_ALWAYS_ON>;
> +resets = < 402>;
> +status = "disabled";
> +};
> +
>  sysc: system-controller@e618 {
>  compatible = "renesas,r8a77470-sysc";
>  reg = <0 0xe618 0 0x200>;
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.