RE: [PATCH 2/4] pinctrl: sh-pfc: r8a77470: Add SDHI2 voltage switch
Hello Geert, hello Wolfram,
Thank you both for your feedback.
> Subject: Re: [PATCH 2/4] pinctrl: sh-pfc: r8a77470: Add SDHI2 voltage switch
>
> On Sat, Sep 22, 2018 at 8:44 PM Wolfram Sang wrote:
> > On Fri, Sep 21, 2018 at 12:55:09PM +0100, Fabrizio Castro wrote:
> > > Add SH_PFC_PIN_CFG_IO_VOLTAGE definition for the SDHI2 pins
> > > capable of switching voltage. Please note that with the
> > > RZ/G1C only 1 bit of the POC Control Register is used to
> > > control each interface.
> > >
> > > Signed-off-by: Fabrizio Castro
> > > Reviewed-by: Biju Das
> >
> > In general:
> >
> > Acked-by: Wolfram Sang
> >
> > > + if (_bank == 4 && _pin >= 14 && _pin <= 19)
> > > + return 1;
> > > +
> > > + return -EINVAL;
> >
> > I'd like a tad better to bail out on the error case and have the main
> > path returning on the good case, but no strong opinion...
>
> And we have these nice RCAR_GP_PIN() macros to check pin ranges.
> Please have a look at the flow in e.g. r8a7795_pin_to_pocctrl().
I'll send a v2 to address this, thank you for pointing me to the right
direction.
Cheers,
Fab
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End,
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered
No. 04586709.
Re: [PATCH 2/4] pinctrl: sh-pfc: r8a77470: Add SDHI2 voltage switch
On Sat, Sep 22, 2018 at 8:44 PM Wolfram Sang wrote:
> On Fri, Sep 21, 2018 at 12:55:09PM +0100, Fabrizio Castro wrote:
> > Add SH_PFC_PIN_CFG_IO_VOLTAGE definition for the SDHI2 pins
> > capable of switching voltage. Please note that with the
> > RZ/G1C only 1 bit of the POC Control Register is used to
> > control each interface.
> >
> > Signed-off-by: Fabrizio Castro
> > Reviewed-by: Biju Das
>
> In general:
>
> Acked-by: Wolfram Sang
>
> > + if (_bank == 4 && _pin >= 14 && _pin <= 19)
> > + return 1;
> > +
> > + return -EINVAL;
>
> I'd like a tad better to bail out on the error case and have the main
> path returning on the good case, but no strong opinion...
And we have these nice RCAR_GP_PIN() macros to check pin ranges.
Please have a look at the flow in e.g. r8a7795_pin_to_pocctrl().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 2/4] pinctrl: sh-pfc: r8a77470: Add SDHI2 voltage switch
On Fri, Sep 21, 2018 at 12:55:09PM +0100, Fabrizio Castro wrote: > Add SH_PFC_PIN_CFG_IO_VOLTAGE definition for the SDHI2 pins > capable of switching voltage. Please note that with the > RZ/G1C only 1 bit of the POC Control Register is used to > control each interface. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das In general: Acked-by: Wolfram Sang > + if (_bank == 4 && _pin >= 14 && _pin <= 19) > + return 1; > + > + return -EINVAL; I'd like a tad better to bail out on the error case and have the main path returning on the good case, but no strong opinion... signature.asc Description: PGP signature
