Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in
Am 29.09.2015 um 14:42 schrieb Javier Martinez Canillas: > diff --git a/arch/arm/configs/exynos_defconfig > b/arch/arm/configs/exynos_defconfig > index d4f6063d8a72..5aad617f02c7 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -64,8 +64,8 @@ CONFIG_SMSC911X=y > CONFIG_USB_USBNET=y > CONFIG_USB_NET_SMSC75XX=y > CONFIG_USB_NET_SMSC95XX=y > -CONFIG_MWIFIEX=y > -CONFIG_MWIFIEX_SDIO=y > +CONFIG_MWIFIEX=m > +CONFIG_MWIFIEX_SDIO=m > CONFIG_INPUT_EVDEV=y > CONFIG_KEYBOARD_GPIO=y > CONFIG_KEYBOARD_CROS_EC=y Makes sense, Reviewed-by: Andreas Färber <afaer...@suse.de> What about multi_v7? Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski: W dniu 16.03.2015 o 07:00, Andreas Färber pisze: Signed-off-by: Hakjoo Kim ruppi@hardkernel.com Signed-off-by: Andreas Färber afaer...@suse.de --- v2 - v3: Unchanged v1 - v2: * Filled in Sob from Hakjoo Kim arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 + 1 file changed, 25 insertions(+) What is the rationale behind doing this in separate patch, not as part of 2/5? You can just add new board DTS with all of its features at once, but maybe I am missing something? This patch depends on the pinctrl driver, 2/5 on nothing. By keeping it a separate patch it was intended to go in more quickly (clear fail there ;)) and it's easier to review the actual changes - squashing is always easier than picking apart. Thanks for your review! Both me and Ben have follow-ups once this moves forward. Kind regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFT PATCHv2] drm/exynos: Enable DP clock to fix display on Exynos5250 and other
Am 27.03.2015 um 20:21 schrieb Javier Martinez Canillas: Hello Krzysztof, On 03/27/2015 05:08 PM, Krzysztof Kozlowski wrote: After adding display power domain for Exynos5250 in commit 2d2c9a8d0a4f (ARM: dts: add display power domain for exynos5250) the display on Chromebook Snow and others stopped working after boot. The reason for this suggested Andrzej Hajda: the DP clock was disabled. This clock is required by Display Port and is enabled by bootloader. However when FIMD driver probing was deferred, the display power domain was turned off. This effectively reset the value of DP clock enable register. When exynos-dp is later probed, the clock is not enabled and display is not properly configured: exynos-dp 145b.dp-controller: Timeout of video streamclk ok exynos-dp 145b.dp-controller: unable to config video Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reported-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Fixes: 2d2c9a8d0a4f (ARM: dts: add display power domain for exynos5250) Cc: sta...@vger.kernel.org --- This should fix issue reported by Javier [1][2]. I tested this patch and does indeed solves both issues I reported The exynos-dp probe deferral does not make the display to not be working and also disabling and enabling the display with: with /sys/devices/platform/exynos-drm/graphics/fb0/blank works. Thanks a lot for fixing this issue. On an Exynos5250 Snow Chromebook: Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Seems to fix Spring Chromebook as well, Tested-by: Andreas Färber afaer...@suse.de Thanks a lot, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250
Am 14.03.2015 um 09:11 schrieb Javier Martinez Canillas: By making the DP controller a consumer of DISP1, the PD is powered off when the exynos-dp probe is deferred and powered on again when the exynos-drm driver is probed. But this causes the exynos-dp driver failing to obtain the stream clock since the FIMD has been powered off with the DISP1 PD: exynos-dp 145b.dp-controller: Timeout of video streamclk ok exynos-dp 145b.dp-controller: unable to config video The Exynos5250 documentation doesn't mention that the Display Port Transmitter module is included in the DISP1 PD so the device should not have a reference to this Power Domain. This patch fixes video display on an Exynos5250 Snow Chromebook. Fixes: 2d2c9a8d0a4f (ARM: dts: add display power domain for exynos5250) Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Hello Andrzej and Marek, I need this patch to have display working on an Snow Chromebook Tested-by: Andreas Färber afaer...@suse.de This fixes the display on the Spring Chromebook as well! Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
Hi Javier,
Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas:
On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber afaer...@suse.de wrote:
Derived from exynos5410-smdk5410.dts.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2 - v3: Unchanged
Forgot to update the in-patch changelogs: v4 is unchanged as well
arch/arm/boot/dts/Makefile| 1 +
arch/arm/boot/dts/exynos5410-odroidxu.dts | 78
+++
2 files changed, 79 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a1c776b8dcec..b040737edcbc 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
exynos5250-snow.dtb \
exynos5250-spring.dtb \
exynos5260-xyref5260.dtb \
+ exynos5410-odroidxu.dtb \
exynos5410-smdk5410.dtb \
exynos5420-arndale-octa.dtb \
exynos5420-peach-pit.dtb \
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
b/arch/arm/boot/dts/exynos5410-odroidxu.dts
new file mode 100644
index ..97310bb727e2
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -0,0 +1,78 @@
+/*
+ * Hardkernel ODROID-XU device tree source
+ *
+ * Copyright (c) 2014 SUSE LINUX Products GmbH
+ *
+ * Based on exynos5410-smdk5410.dts:
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+#include exynos5410.dtsi
+/ {
+ model = ODROID-XU based on EXYNOS5410;
+ compatible = hardkernel,odroid-xu, samsung,exynos5410,
samsung,exynos5;
+
+ memory {
+ reg = 0x4000 0x8000;
+ };
+
+ chosen {
+ bootargs = console=ttySAC2,115200;
+ };
+
After commit a208ffd251d0 (of: Enable console on serial ports
specified by /chosen/stdout-path) the kernel is able to know what
serial console to use if the DT defined an stdout-path property so
should be preferred instead of using a console= parameter.
I'll post today a series to change that on all exynos5 boards so you
can base on that.
Okay, if no one else does, I could update smdk5410 before splitting.
+ fin_pll: xxti {
+ compatible = fixed-clock;
+ clock-frequency = 2400;
+ clock-output-names = fin_pll;
+ #clock-cells = 0;
+ };
+
I think this should be defined in exynos5410.dtsi instead since is an
IP block in the SoC and referenced in the .dts using a label to change
the clock-frequency in the board.
I hope you understood that this is a literal copy of smdk5410, so I'm
not going to make random changes here. If the Samsung guys want to make
this change for smdk5410, then fine, but otherwise - like for Snow and
Spring - I want to keep the diff -u low between the two.
+ firmware@02037000 {
+ compatible = samsung,secure-firmware;
+ reg = 0x02037000 0x1000;
+ };
+
+};
+
+mmc_0 {
+ status = okay;
+ num-slots = 1;
+ cap-mmc-highspeed;
+ broken-cd;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 2 3;
+ samsung,dw-mshc-ddr-timing = 1 2;
+ bus-width = 8;
+};
+
+mmc_2 {
+ status = okay;
+ num-slots = 1;
+ cap-sd-highspeed;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 2 3;
+ samsung,dw-mshc-ddr-timing = 1 2;
+ bus-width = 4;
+ disable-wp;
+};
+
+uart0 {
+ status = okay;
+};
+
+uart1 {
+ status = okay;
+};
+
+uart2 {
+ status = okay;
+};
--
With those two changes:
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Thanks, first review after posting for the third time... ;)
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] ARM: dts: Define stdout-path property for Spring board
Hi,
Am 16.03.2015 um 11:28 schrieb Javier Martinez Canillas:
The kernel can use as the default console a serial port if is defined
The kernel can use a serial port as the default console if it's defined
...
as stdout device in the Device Tree.
This allows a board to be booted without the need of having a console
parameter in the kernel command line.
Currently the Spring DTS has bootargs in the /chosen node and this is
kept since users that don't have a serial console on this board might
be using it to have the boot log shown in the display. This will have
more precedence than the stdout-path but it's fine since is only used
since it's
when CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is enabled.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5250-spring.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
index f02775487cd4..b9ec763a5602 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -25,6 +25,7 @@
chosen {
bootargs = console=tty1;
+ stdout-path = serial3:115200n8;
Is this a guess or did you verify that against some schematics?
};
gpio-keys {
Assuming that bootargs still work,
Reviewed-by: Andreas Färber afaer...@suse.de
I do wonder why this mechanism could not point to the same location as
bootargs? (dp-controller?) The device does not even have screws for
opening it, so accessing the serial port is highly theoretical.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: Update lid and power pin-functions for exynos5250-spring
Kukjin, Am 19.02.2015 um 12:49 schrieb Javier Martinez Canillas: Hello Andreas, On 02/18/2015 05:17 PM, Andreas Färber wrote: Configure the pins in external interrupt mode, as done for Snow in e5e5c6d14e39 (ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow). Reported-by: Kukjin Kim kg...@kernel.org Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Fixes: 53dd4138bb0a (ARM: dts: Add exynos5250-spring device tree) Signed-off-by: Andreas Färber afaer...@suse.de --- Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Ping? Regards, Andreas Best regards, Javier -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: Update exynos5250-spring with mmc node changes
Am 19.02.2015 um 12:46 schrieb Javier Martinez Canillas:
Hello Andreas,
On 02/18/2015 05:10 PM, Andreas Färber wrote:
Resolve a merge conflict with mmc refactoring aaa25a5a33cb (ARM: dts:
unuse the slot-node and deprecate the supports-highspeed for dw-mmc in
exynos) by dropping the slot@0 nodes, moving its bus-width property to
the mmc node and replacing supports-highspeed with cap-{mmc,sd}-highspeed,
matching exynos5250-snow.
Cc: Jaehoon Chung jh80.ch...@samsung.com
Fixes: 53dd4138bb0a (ARM: dts: Add exynos5250-spring device tree)
Signed-off-by: Andreas Färber afaer...@suse.de
---
arch/arm/boot/dts/exynos5250-spring.dts | 16
1 file changed, 4 insertions(+), 12 deletions(-)
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Ping!
Best regards,
Javier
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410
From: Hakjoo Kim ruppi@hardkernel.com
Add the required pin configuration support to Exynos5410 using pinctrl
interface.
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
[AF: Rebased, style changes]
Signed-off-by: Andreas Färber afaer...@suse.de
---
v2 - v3:
* Added wake-up IRQ controller node (Tomasz Figa)
v1 - v2:
* Filled in Sob from Hakjoo Kim
arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 406 ++
arch/arm/boot/dts/exynos5410.dtsi | 36 +++
2 files changed, 442 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi
diff --git a/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
new file mode 100644
index ..f9aa6bb55464
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
@@ -0,0 +1,406 @@
+/*
+ * Exynos5410 SoC pin-mux and pin-config device tree source
+ *
+ * Copyright (c) 2013 Hardkernel Co., Ltd.
+ * http://www.hardkernel.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+pinctrl_0 {
+ gpa0: gpa0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpa1: gpa1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpa2: gpa2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb0: gpb0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb1: gpb1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb2: gpb2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb3: gpb3 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc0: gpc0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc3: gpc3 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc1: gpc1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc2: gpc2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpm5: gpm5 {
+ gpio-controller;
+ #gpio-cells = 2;
+ };
+
+ gpd1: gpd1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpe0: gpe0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpe1: gpe1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpf0: gpf0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpf1: gpf1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg0: gpg0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg1: gpg1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg2: gpg2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gph0: gph0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gph1: gph1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller
[PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v2 - v3: Unchanged
v1 - v2:
* Filled in Sob from Hakjoo Kim
arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +
1 file changed, 25 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 97310bb727e2..b02cd3ab7b38 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -15,6 +15,7 @@
/dts-v1/;
#include exynos5410.dtsi
+#include dt-bindings/gpio/gpio.h
/ {
model = ODROID-XU based on EXYNOS5410;
compatible = hardkernel,odroid-xu, samsung,exynos5410,
samsung,exynos5;
@@ -39,6 +40,30 @@
reg = 0x02037000 0x1000;
};
+ leds {
+ compatible = gpio-leds;
+
+ blue {
+ label = blue:heartbeat;
+ gpios = gpb2 2 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = heartbeat;
+ };
+
+ green {
+ label = green:activity;
+ gpios = gpb2 1 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = mmc0;
+ };
+
+ red {
+ label = red:activity;
+ gpios = gpx2 3 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = mmc1;
+ };
+ };
};
mmc_0 {
--
2.3.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs
Hello,
This series adds a dedicated ODROID-XU device tree and enhances it with
LED configuration, to match the downstream 3.14 based behavior.
Regards,
Andreas
v3 - v4:
* Rebased pinctrl (.label field dropped, const'ified, __initconst)
* Edited dts subjects to match Kukjin's preferred style
v2 - v3:
* Actually rebased pinctrl (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
* Added wake-up IRQ controller node (Tomasz Figa)
v1 - v2:
* Inserted needed Sobs from Hakjoo Kim
Andreas Färber (3):
ARM: dts: Clean up exynos5410-smdk5410 indentation
ARM: dts: Prepare exynos5410-odroidxu device tree
ARM: dts: Add LEDs to exynos5410-odroidxu
Hakjoo Kim (2):
pinctrl: exynos: add exynos5410 SoC specific data
ARM: dts: add pinctrl support to Exynos5410
.../bindings/pinctrl/samsung-pinctrl.txt | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/exynos5410-odroidxu.dts | 103 ++
arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 406 +
arch/arm/boot/dts/exynos5410-smdk5410.dts | 6 +-
arch/arm/boot/dts/exynos5410.dtsi | 36 ++
drivers/pinctrl/samsung/pinctrl-exynos.c | 103 ++
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +
drivers/pinctrl/samsung/pinctrl-samsung.h | 1 +
9 files changed, 656 insertions(+), 3 deletions(-)
create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi
--
2.3.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation
The UART status properties are indented one level too deep, and we want
to derive a device tree for the ODROID-XU. Fix this before it propagates.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2 - v3: Unchanged
arch/arm/boot/dts/exynos5410-smdk5410.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5410-smdk5410.dts
b/arch/arm/boot/dts/exynos5410-smdk5410.dts
index be3e02530b42..cebeaab3abec 100644
--- a/arch/arm/boot/dts/exynos5410-smdk5410.dts
+++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts
@@ -62,13 +62,13 @@
};
uart0 {
- status = okay;
+ status = okay;
};
uart1 {
- status = okay;
+ status = okay;
};
uart2 {
- status = okay;
+ status = okay;
};
--
2.3.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
Derived from exynos5410-smdk5410.dts.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2 - v3: Unchanged
arch/arm/boot/dts/Makefile| 1 +
arch/arm/boot/dts/exynos5410-odroidxu.dts | 78 +++
2 files changed, 79 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a1c776b8dcec..b040737edcbc 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
exynos5250-snow.dtb \
exynos5250-spring.dtb \
exynos5260-xyref5260.dtb \
+ exynos5410-odroidxu.dtb \
exynos5410-smdk5410.dtb \
exynos5420-arndale-octa.dtb \
exynos5420-peach-pit.dtb \
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
b/arch/arm/boot/dts/exynos5410-odroidxu.dts
new file mode 100644
index ..97310bb727e2
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -0,0 +1,78 @@
+/*
+ * Hardkernel ODROID-XU device tree source
+ *
+ * Copyright (c) 2014 SUSE LINUX Products GmbH
+ *
+ * Based on exynos5410-smdk5410.dts:
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+#include exynos5410.dtsi
+/ {
+ model = ODROID-XU based on EXYNOS5410;
+ compatible = hardkernel,odroid-xu, samsung,exynos5410,
samsung,exynos5;
+
+ memory {
+ reg = 0x4000 0x8000;
+ };
+
+ chosen {
+ bootargs = console=ttySAC2,115200;
+ };
+
+ fin_pll: xxti {
+ compatible = fixed-clock;
+ clock-frequency = 2400;
+ clock-output-names = fin_pll;
+ #clock-cells = 0;
+ };
+
+ firmware@02037000 {
+ compatible = samsung,secure-firmware;
+ reg = 0x02037000 0x1000;
+ };
+
+};
+
+mmc_0 {
+ status = okay;
+ num-slots = 1;
+ cap-mmc-highspeed;
+ broken-cd;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 2 3;
+ samsung,dw-mshc-ddr-timing = 1 2;
+ bus-width = 8;
+};
+
+mmc_2 {
+ status = okay;
+ num-slots = 1;
+ cap-sd-highspeed;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 2 3;
+ samsung,dw-mshc-ddr-timing = 1 2;
+ bus-width = 4;
+ disable-wp;
+};
+
+uart0 {
+ status = okay;
+};
+
+uart1 {
+ status = okay;
+};
+
+uart2 {
+ status = okay;
+};
--
2.3.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling
Hi, Am 23.02.2015 um 09:29 schrieb Javier Martinez Canillas: On 02/20/2015 04:27 AM, Tushar Behera wrote: On 02/20/2015 12:48 AM, Andreas Färber wrote: If master clock is provided through device tree, then update the master clock frequency during set_sysclk. Cc: Tushar Behera tushar.beh...@linaro.org Signed-off-by: Andreas Färber afaer...@suse.de --- sound/soc/codecs/max98088.c | 24 1 file changed, 24 insertions(+) Looks good. Acked-by: Tushar Behera trbli...@gmail.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Thanks guys. One self-doubt: Is there any downside to returning -EPROBE_DEFER after regcache_mark_dirty(max98088-regmap)? I.e., should I move the last hunk some lines up to be the very first thing executed? Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 05/18] ARM: dts: exynos5420: add sysmmu nodes
Am 23.01.2015 um 16:51 schrieb Marek Szyprowski:
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
---
arch/arm/boot/dts/exynos5420.dtsi | 181
++
1 file changed, 181 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi
b/arch/arm/boot/dts/exynos5420.dtsi
index 1b62410..b8f1c9f 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
[...]
@@ -925,4 +932,178 @@
samsung,sysreg-phandle = sysreg_system_controller;
samsung,pmureg-phandle = pmu_system_controller;
};
+
+ sysmmu_g2dr: sysmmu@0x10A6 {
[snip]
Unit addresses are without 0x. Please also check the sort order.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 04/18] ARM: dts: exynos5250: add sysmmu nodes
Am 23.01.2015 um 16:51 schrieb Marek Szyprowski:
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
---
arch/arm/boot/dts/exynos5250.dtsi | 250
++
1 file changed, 250 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index ae22bd9..8583b9e 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -224,6 +224,7 @@
interrupts = 0 91 0;
clocks = clock CLK_G2D;
clock-names = fimg2d;
+ iommus = sysmmu_g2d;
};
mfc: codec@1100 {
@@ -233,6 +234,8 @@
power-domains = pd_mfc;
clocks = clock CLK_MFC;
clock-names = mfc;
+ iommus = sysmmu_mfc_l, sysmmu_mfc_r;
+ iommu-names = left, right;
};
rtc: rtc@101E {
@@ -693,6 +696,7 @@
power-domains = pd_gsc;
clocks = clock CLK_GSCL0;
clock-names = gscl;
+ iommu = sysmmu_gsc1;
};
gsc_1: gsc@13e1 {
@@ -702,6 +706,7 @@
power-domains = pd_gsc;
clocks = clock CLK_GSCL1;
clock-names = gscl;
+ iommu = sysmmu_gsc1;
};
gsc_2: gsc@13e2 {
@@ -711,6 +716,7 @@
power-domains = pd_gsc;
clocks = clock CLK_GSCL2;
clock-names = gscl;
+ iommu = sysmmu_gsc2;
};
gsc_3: gsc@13e3 {
@@ -720,6 +726,7 @@
power-domains = pd_gsc;
clocks = clock CLK_GSCL3;
clock-names = gscl;
+ iommu = sysmmu_gsc3;
};
hdmi: hdmi {
@@ -743,6 +750,7 @@
clocks = clock CLK_MIXER, clock CLK_HDMI,
clock CLK_SCLK_HDMI;
clock-names = mixer, hdmi, sclk_hdmi;
+ iommus = sysmmu_tv;
};
dp_phy: video-phy@10040720 {
@@ -763,6 +771,7 @@
power-domains = pd_disp1;
clocks = clock CLK_SCLK_FIMD1, clock CLK_FIMD1;
clock-names = sclk_fimd, fimd;
+ iommus = sysmmu_fimd1;
};
adc: adc@12D1 {
@@ -784,4 +793,245 @@
clocks = clock CLK_SSS;
clock-names = secss;
};
+
+ sysmmu_gsc0: sysmmu@13E8 {
+ compatible = samsung,exynos-sysmmu;
+ reg = 0x13E8 0x1000;
+ interrupt-parent = combiner;
+ interrupts = 2 0;
+ power-domains = pd_gsc;
+ clock-names = sysmmu, master;
+ clocks = clock CLK_SMMU_GSCL0, clock CLK_GSCL0;
+ #iommu-cells = 0;
+ };
+
+ sysmmu_gsc1: sysmmu@13E9 {
+ compatible = samsung,exynos-sysmmu;
+ reg = 0x13E9 0x1000;
+ interrupt-parent = combiner;
+ interrupts = 2 2;
+ power-domains = pd_gsc;
+ clock-names = sysmmu, master;
+ clocks = clock CLK_SMMU_GSCL1, clock CLK_GSCL1;
+ #iommu-cells = 0;
+ };
+
+ sysmmu_gsc2: sysmmu@13EA {
+ compatible = samsung,exynos-sysmmu;
+ reg = 0x13EA 0x1000;
+ interrupt-parent = combiner;
+ interrupts = 2 4;
+ power-domains = pd_gsc;
+ clock-names = sysmmu, master;
+ clocks = clock CLK_SMMU_GSCL2, clock CLK_GSCL2;
+ #iommu-cells = 0;
+ };
+
+ sysmmu_gsc3: sysmmu@13EB {
+ compatible = samsung,exynos-sysmmu;
+ reg = 0x13EB 0x1000;
+ interrupt-parent = combiner;
+ interrupts = 2 6;
+ power-domains = pd_gsc;
+ clock-names = sysmmu, master;
+ clocks = clock CLK_SMMU_GSCL3, clock CLK_GSCL3;
+ #iommu-cells = 0;
+ };
+
+ sysmmu_mfc_r: sysmmu@1120 {
+ compatible = samsung,exynos-sysmmu;
+ reg = 0x1120 0x1000;
+ interrupt-parent = combiner;
+ interrupts = 6 2;
+ power-domains = pd_mfc;
+ clock-names = sysmmu, master;
+ clocks = clock CLK_SMMU_MFCR, clock CLK_MFC;
+ #iommu-cells = 0;
+ };
+
+ sysmmu_mfc_l: sysmmu@1121 {
+ compatible = samsung,exynos-sysmmu;
+ reg = 0x1121 0x1000;
+ interrupt-parent = combiner;
+ interrupts = 8 5;
+ power-domains = pd_mfc;
+ clock-names = sysmmu, master;
+ clocks = clock CLK_SMMU_MFCL, clock CLK_MFC;
+ #iommu-cells = 0;
+ };
These two nodes (and further ones below) seem sorted wrongly. Please
order by unit address.
Regards,
Andreas
+
+ sysmmu_tv: sysmmu@1465 {
+ compatible = samsung,exynos-sysmmu;
+ reg =
[PATCH] ASoC: max98088: Add master clock handling
If master clock is provided through device tree, then update
the master clock frequency during set_sysclk.
Cc: Tushar Behera tushar.beh...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
sound/soc/codecs/max98088.c | 24
1 file changed, 24 insertions(+)
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index 69a21d1946e3..1aa81321afba 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -16,6 +16,7 @@
#include linux/pm.h
#include linux/i2c.h
#include linux/regmap.h
+#include linux/clk.h
#include sound/core.h
#include sound/pcm.h
#include sound/pcm_params.h
@@ -42,6 +43,7 @@ struct max98088_priv {
struct regmap *regmap;
enum max98088_type devtype;
struct max98088_pdata *pdata;
+ struct clk *mclk;
unsigned int sysclk;
struct max98088_cdata dai[2];
int eq_textcnt;
@@ -1361,6 +1363,11 @@ static int max98088_dai_set_sysclk(struct snd_soc_dai
*dai,
if (freq == max98088-sysclk)
return 0;
+ if (!IS_ERR(max98088-mclk)) {
+ freq = clk_round_rate(max98088-mclk, freq);
+ clk_set_rate(max98088-mclk, freq);
+ }
+
/* Setup clocks for slave mode, and using the PLL
* PSCLK = 0x01 (when master clk is 10MHz to 20MHz)
* 0x02 (when master clk is 20MHz to 30MHz)..
@@ -1568,6 +1575,19 @@ static int max98088_set_bias_level(struct snd_soc_codec
*codec,
break;
case SND_SOC_BIAS_PREPARE:
+ /*
+* SND_SOC_BIAS_PREPARE is called while preparing for a
+* transition to ON or away from ON. If current bias_level
+* is SND_SOC_BIAS_ON, then it is preparing for a transition
+* away from ON. Disable the clock in that case, otherwise
+* enable it.
+*/
+ if (!IS_ERR(max98088-mclk)) {
+ if (codec-dapm.bias_level == SND_SOC_BIAS_ON)
+ clk_disable_unprepare(max98088-mclk);
+ else
+ clk_prepare_enable(max98088-mclk);
+ }
break;
case SND_SOC_BIAS_STANDBY:
@@ -1900,6 +1920,10 @@ static int max98088_probe(struct snd_soc_codec *codec)
max98088-sysclk = (unsigned)-1;
max98088-eq_textcnt = 0;
+ max98088-mclk = devm_clk_get(codec-dev, mclk);
+ if (PTR_ERR(max98088-mclk) == -EPROBE_DEFER)
+ return -EPROBE_DEFER;
+
cdata = max98088-dai[0];
cdata-rate = (unsigned)-1;
cdata-fmt = (unsigned)-1;
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089
Am 19.02.2015 um 10:44 schrieb Mark Brown:
On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote:
static const struct of_device_id snow_of_match[] = {
+{ .compatible = google,snow-audio-max98089, },
{ .compatible = google,snow-audio-max98090, },
{ .compatible = google,snow-audio-max98091, },
{ .compatible = google,snow-audio-max98095, },
Since we completely ignore the CODEC in the property might it not be
better to just add a plain old snow-audio compatible and bind to that,
that way we don't need these driver updates? Just the snow bit should
be enough to know it's one of this class of machines.
Personally I don't mind either way, but I'd rather leave that decision
to Google/Samsung people.
With all those Tegra and Rockchip based Chromebooks popping up, are
there any further Exynos based Chromebooks planned using this driver, or
is it the last of its kind?
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
signature.asc
Description: OpenPGP digital signature
Re: [PATCH 1/6] ASoC: max98088: Document DT bindings
Am 19.02.2015 um 19:40 schrieb Andreas Färber:
Am 19.02.2015 um 18:48 schrieb Doug Anderson:
On Thu, Feb 19, 2015 at 6:13 AM, Andreas Färber afaer...@suse.de wrote:
I see that a master clock (mclk) is added in patch 6/6 but the
max98088 codec driver does handle this clock.
If the SoC XCLKOUT provides the master clock to the max98089
codec in Spring like is the case for the max9809{0,5} codecs
in the Snow and Peach Pit/Pi Chromebooks then you need to do
something along the lines of the following commits:
e3048c3d2be5 ASoC: max98095: Add master clock handling
b10ab7b838bd ASoC: max98090: Add master clock handling
If that's the case you also have to mention in the DT binding
doc that clocks and clock-names are optional properties
like Documentation/devicetree/bindings/sound/max9809{0,5}.txt.
When I prepared this patch, I believe it was a straight copy from
max98090. Sounds like they changed since then.
My 6/6 adopted the mclk clock from your now-cancelled v2 patch for Snow,
assuming it would be the same on all Chromebooks. I tested that last
change by checking for errors in dmesg.
Doug, can you advise on how the clock wiring is for Spring?
I can confirm that XCLKOUT is connected to the codec MCLK on the
Spring schematics I have.
Thanks! I updated max98088 and had it working on first boot, but on
second boot it complained about the frequency:
[7.896834] max98088 7-0010: revision A
[7.912776] snow-audio sound: HiFi - 383.i2s mapping ok
[7.919367] max98088 7-0010: Invalid master clock frequency
[7.919429] snow-audio sound: ASoC: Spring-I2S-MAX98089 late_probe()
failed: -22
[7.920019] snow-audio sound: snd_soc_register_card failed (-22)
[7.920109] snow-audio: probe of sound failed with error -22
Reproducible on third boot.
On a suspicion, the fourth boot I waited for the double-beep of the
firmware (waiting for Ctrl+d/u), and then it did work.
So it seems the mclk is not always set up properly by the kernel,
relying on firmware. Who's in charge of setting that clock up?
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] ASoC: max98088: Document DT bindings
Am 19.02.2015 um 18:48 schrieb Doug Anderson:
On Thu, Feb 19, 2015 at 6:13 AM, Andreas Färber afaer...@suse.de wrote:
I see that a master clock (mclk) is added in patch 6/6 but the
max98088 codec driver does handle this clock.
If the SoC XCLKOUT provides the master clock to the max98089
codec in Spring like is the case for the max9809{0,5} codecs
in the Snow and Peach Pit/Pi Chromebooks then you need to do
something along the lines of the following commits:
e3048c3d2be5 ASoC: max98095: Add master clock handling
b10ab7b838bd ASoC: max98090: Add master clock handling
If that's the case you also have to mention in the DT binding
doc that clocks and clock-names are optional properties
like Documentation/devicetree/bindings/sound/max9809{0,5}.txt.
When I prepared this patch, I believe it was a straight copy from
max98090. Sounds like they changed since then.
My 6/6 adopted the mclk clock from your now-cancelled v2 patch for Snow,
assuming it would be the same on all Chromebooks. I tested that last
change by checking for errors in dmesg.
Doug, can you advise on how the clock wiring is for Spring?
I can confirm that XCLKOUT is connected to the codec MCLK on the
Spring schematics I have.
Thanks! I updated max98088 and had it working on first boot, but on
second boot it complained about the frequency:
[7.896834] max98088 7-0010: revision A
[7.912776] snow-audio sound: HiFi - 383.i2s mapping ok
[7.919367] max98088 7-0010: Invalid master clock frequency
[7.919429] snow-audio sound: ASoC: Spring-I2S-MAX98089 late_probe()
failed: -22
[7.920019] snow-audio sound: snd_soc_register_card failed (-22)
[7.920109] snow-audio: probe of sound failed with error -22
Will investigate.
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] ASoC: max98088: Document DT bindings
Hello Javier, Doug,
Am 19.02.2015 um 14:55 schrieb Javier Martinez Canillas:
On 02/18/2015 07:25 PM, Andreas Färber wrote:
Signed-off-by: Andreas Färber afaer...@suse.de
---
Documentation/devicetree/bindings/sound/max98088.txt | 16
1 file changed, 16 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/max98088.txt
diff --git a/Documentation/devicetree/bindings/sound/max98088.txt
b/Documentation/devicetree/bindings/sound/max98088.txt
new file mode 100644
index ..6f8fe85040ee
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/max98088.txt
@@ -0,0 +1,16 @@
+MAX98088 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+- compatible : maxim,max98088 or maxim,max98089.
+
+- reg : The I2C address of the device.
+
+Example:
+
+max98089: codec@10 {
+compatible = maxim,max98089;
+reg = 0x10;
+};
I see that a master clock (mclk) is added in patch 6/6 but the
max98088 codec driver does handle this clock.
If the SoC XCLKOUT provides the master clock to the max98089
codec in Spring like is the case for the max9809{0,5} codecs
in the Snow and Peach Pit/Pi Chromebooks then you need to do
something along the lines of the following commits:
e3048c3d2be5 ASoC: max98095: Add master clock handling
b10ab7b838bd ASoC: max98090: Add master clock handling
If that's the case you also have to mention in the DT binding
doc that clocks and clock-names are optional properties
like Documentation/devicetree/bindings/sound/max9809{0,5}.txt.
When I prepared this patch, I believe it was a straight copy from
max98090. Sounds like they changed since then.
My 6/6 adopted the mclk clock from your now-cancelled v2 patch for Snow,
assuming it would be the same on all Chromebooks. I tested that last
change by checking for errors in dmesg.
Doug, can you advise on how the clock wiring is for Spring?
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089
Am 19.02.2015 um 18:44 schrieb Doug Anderson:
On Thu, Feb 19, 2015 at 1:44 AM, Mark Brown broo...@kernel.org wrote:
On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote:
static const struct of_device_id snow_of_match[] = {
+ { .compatible = google,snow-audio-max98089, },
{ .compatible = google,snow-audio-max98090, },
{ .compatible = google,snow-audio-max98091, },
{ .compatible = google,snow-audio-max98095, },
Since we completely ignore the CODEC in the property might it not be
better to just add a plain old snow-audio compatible and bind to that,
that way we don't need these driver updates? Just the snow bit should
be enough to know it's one of this class of machines.
I think what you're suggesting is that here we should add a new
compatible string google,snow-audio instead of adding
google,snow-audio-max98089 here. Then the sound node in the spring
DTS would look like:
compatible = google,snow-audio-max98089, google,snow-audio;
If we want to be specific just in case, was it an active decision not to
use google,peach-pi[t]-audio-max98...?
Again, either way works for me.
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] ASoC: max98088: Document DT bindings
Am 19.02.2015 um 21:48 schrieb Javier Martinez Canillas:
On 02/19/2015 07:54 PM, Andreas Färber wrote:
Am 19.02.2015 um 19:40 schrieb Andreas Färber:
I updated max98088 and had it working on first boot, but on
second boot it complained about the frequency:
[7.896834] max98088 7-0010: revision A
[7.912776] snow-audio sound: HiFi - 383.i2s mapping ok
[7.919367] max98088 7-0010: Invalid master clock frequency
[7.919429] snow-audio sound: ASoC: Spring-I2S-MAX98089 late_probe()
failed: -22
[7.920019] snow-audio sound: snd_soc_register_card failed (-22)
[7.920109] snow-audio: probe of sound failed with error -22
I had the same error on Snow but even on the first boot and after doing some
code archeology, I found the following commit [0] in a Samsung downstream
tree that solves the issue.
The problem is that clk_round_rate(max98095-mclk, freq) returns 0 as the
rounded rate if XCLOUT is not allowed to be re-parented on rate change.
Same on Spring:
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index 1aa81321afba..46dc64675c26 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -1365,6 +1365,7 @@ static int max98088_dai_set_sysclk(struct
snd_soc_dai *dai,
if (!IS_ERR(max98088-mclk)) {
freq = clk_round_rate(max98088-mclk, freq);
+ dev_warn(codec-dev, freq = %u\n, freq);
clk_set_rate(max98088-mclk, freq);
}
With Tushar's patch I see that clk_round_rate() returns 2400 (24MHz)
so the codec driver setups the correct PLL clock.
Ditto. With the clkout reparenting patch, clk_round_rate() returns 24MHz
just like when double-beep-initialized. However when not
double-beep-initialized, the driver initializes, but no audible output,
so there must be another missing puzzle piece.
On a suspicion, the fourth boot I waited for the double-beep of the
firmware (waiting for Ctrl+d/u), and then it did work.
So it seems the mclk is not always set up properly by the kernel,
relying on firmware. Who's in charge of setting that clock up?
Right, it seems audio is only working due the firmware doing some previous
setup. Probably it works on every boot if you have sound init as a part of
the u-boot boot commands?
Indeed it does, 24 MHz without the reparenting patch, and sound working.
'sound init' code:
https://github.com/afaerber/u-boot/blob/spring/drivers/sound/max98088.c
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089
This is needed for Spring.
Signed-off-by: Andreas Färber afaer...@suse.de
---
sound/soc/samsung/Kconfig | 1 +
sound/soc/samsung/snow.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
index 3cebf6ca03df..222181655e4f 100644
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -214,6 +214,7 @@ config SND_SOC_LITTLEMILL
config SND_SOC_SNOW
tristate Audio support for Google Snow boards
depends on SND_SOC_SAMSUNG I2C
+ select SND_SOC_MAX98088
select SND_SOC_MAX98090
select SND_SOC_MAX98095
select SND_SAMSUNG_I2S
diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c
index 7651dc924161..89d7e39b206e 100644
--- a/sound/soc/samsung/snow.c
+++ b/sound/soc/samsung/snow.c
@@ -105,6 +105,7 @@ static int snow_probe(struct platform_device *pdev)
}
static const struct of_device_id snow_of_match[] = {
+ { .compatible = google,snow-audio-max98089, },
{ .compatible = google,snow-audio-max98090, },
{ .compatible = google,snow-audio-max98091, },
{ .compatible = google,snow-audio-max98095, },
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/6] ASoC: max98088: Document DT bindings
Signed-off-by: Andreas Färber afaer...@suse.de
---
Documentation/devicetree/bindings/sound/max98088.txt | 16
1 file changed, 16 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/max98088.txt
diff --git a/Documentation/devicetree/bindings/sound/max98088.txt
b/Documentation/devicetree/bindings/sound/max98088.txt
new file mode 100644
index ..6f8fe85040ee
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/max98088.txt
@@ -0,0 +1,16 @@
+MAX98088 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+- compatible : maxim,max98088 or maxim,max98089.
+
+- reg : The I2C address of the device.
+
+Example:
+
+max98089: codec@10 {
+ compatible = maxim,max98089;
+ reg = 0x10;
+};
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/6] ASoC: max98088: Add DT bindings
maxim,max98089 will be used for the Spring Chromebook.
Signed-off-by: Andreas Färber afaer...@suse.de
---
sound/soc/codecs/max98088.c | 8
1 file changed, 8 insertions(+)
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index 805b3f8cd39d..69a21d1946e3 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -2009,10 +2009,18 @@ static const struct i2c_device_id max98088_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, max98088_i2c_id);
+static const struct of_device_id max98088_of_match[] = {
+ { .compatible = maxim,max98088 },
+ { .compatible = maxim,max98089 },
+ { }
+};
+MODULE_DEVICE_TABLE(of, max98088_of_match);
+
static struct i2c_driver max98088_i2c_driver = {
.driver = {
.name = max98088,
.owner = THIS_MODULE,
+ .of_match_table = of_match_ptr(max98088_of_match),
},
.probe = max98088_i2c_probe,
.remove = max98088_i2c_remove,
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/6] ASoC: samsung: Spring sound support
Hello, This series prepares sound support for the HP Chromebook 11. Regards, Andreas Andreas Färber (6): ASoC: max98088: Document DT bindings ASoC: max98088: Add DT bindings ARM: dts: Add max98089 to exynos5250-spring ASoC: samsung: Document binding for max98089 based Snow driver ASoC: samsung: Extend Snow driver to support max98089 ARM: dts: Add sound support to exynos5250-spring .../devicetree/bindings/sound/max98088.txt | 16 Documentation/devicetree/bindings/sound/snow.txt | 1 + arch/arm/boot/dts/exynos5250-spring.dts| 30 ++ sound/soc/codecs/max98088.c| 8 ++ sound/soc/samsung/Kconfig | 1 + sound/soc/samsung/snow.c | 1 + 6 files changed, 57 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/max98088.txt -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/6] ASoC: max98088: Add DT bindings
Hi,
Am 18.02.2015 um 20:08 schrieb Sergei Shtylyov:
On 02/18/2015 09:25 PM, Andreas Färber wrote:
maxim,max98089 will be used for the Spring Chromebook.
Signed-off-by: Andreas Färber afaer...@suse.de
---
sound/soc/codecs/max98088.c | 8
1 file changed, 8 insertions(+)
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index 805b3f8cd39d..69a21d1946e3 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -2009,10 +2009,18 @@ static const struct i2c_device_id
max98088_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, max98088_i2c_id);
+static const struct of_device_id max98088_of_match[] = {
If I don't mistake, gcc will complain about this variable being
unused if CONFIG_OF=n.
I assume there will be no warning because of the const.
For just static you would be right.
+{ .compatible = maxim,max98088 },
+{ .compatible = maxim,max98089 },
+{ }
+};
+MODULE_DEVICE_TABLE(of, max98088_of_match);
+
static struct i2c_driver max98088_i2c_driver = {
.driver = {
.name = max98088,
.owner = THIS_MODULE,
+.of_match_table = of_match_ptr(max98088_of_match),
You probably don;t need of_match_ptr(). Either that or do something
with the match table, like enclosing into #ifdef or annotating with
'__maybe_unused'.
This was copied from max98090 and max98095.
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/6] ASoC: samsung: Document binding for max98089 based Snow driver
Signed-off-by: Andreas Färber afaer...@suse.de --- Documentation/devicetree/bindings/sound/snow.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sound/snow.txt b/Documentation/devicetree/bindings/sound/snow.txt index 6df74f15687f..1430a6bdb2ae 100644 --- a/Documentation/devicetree/bindings/sound/snow.txt +++ b/Documentation/devicetree/bindings/sound/snow.txt @@ -2,6 +2,7 @@ Audio Binding for Snow boards Required properties: - compatible : Can be one of the following, + google,snow-audio-max98089 or google,snow-audio-max98090 or google,snow-audio-max98091 or google,snow-audio-max98095 -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 6/6] ARM: dts: Add sound support to exynos5250-spring
Signed-off-by: Andreas Färber afaer...@suse.de
---
arch/arm/boot/dts/exynos5250-spring.dts | 25 +
1 file changed, 25 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
index 866beb4e0597..142e0550e223 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -49,6 +49,17 @@
};
};
+ sound {
+ compatible = google,snow-audio-max98089;
+ samsung,model = Spring-I2S-MAX98089;
+ samsung,i2s-controller = i2s0;
+ samsung,audio-codec = max98089;
+ clocks = pmu_system_controller 0;
+ clock-names = mclk;
+ pinctrl-names = default;
+ pinctrl-0 = mic_det_gpio, hp_det_gpio;
+ };
+
usb-hub {
compatible = smsc,usb3503a;
reset-gpios = gpe1 0 GPIO_ACTIVE_LOW;
@@ -499,6 +510,20 @@
samsung,pin-drv = 0;
};
+ mic_det_gpio: mic-det-gpio {
+ samsung,pins = gpx2-0;
+ samsung,pin-function = 0;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+
+ hp_det_gpio: hp-det-gpio {
+ samsung,pins = gpx2-2;
+ samsung,pin-function = 0;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+
s5m8767_ds: s5m8767-ds {
samsung,pins = gpx2-3, gpx2-4, gpx2-5;
samsung,pin-function = 0;
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/6] ARM: dts: Add max98089 to exynos5250-spring
Signed-off-by: Andreas Färber afaer...@suse.de
---
arch/arm/boot/dts/exynos5250-spring.dts | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
index d075a68ac078..866beb4e0597 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -400,6 +400,11 @@
samsung,i2c-sda-delay = 100;
samsung,i2c-max-bus-freq = 66000;
+ max98089: codec@10 {
+ compatible = maxim,max98089, maxim,max98088;
+ reg = 0x10;
+ };
+
temperature-sensor@4c {
compatible = gmt,g781;
reg = 0x4c;
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: dts: Update lid and power pin-functions for exynos5250-spring
Configure the pins in external interrupt mode, as done for Snow in
e5e5c6d14e39 (ARM: dts: Add power and lid GPIO keys pinctrl for
exynos5250-snow).
Reported-by: Kukjin Kim kg...@kernel.org
Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Fixes: 53dd4138bb0a (ARM: dts: Add exynos5250-spring device tree)
Signed-off-by: Andreas Färber afaer...@suse.de
---
arch/arm/boot/dts/exynos5250-spring.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
index c41600e587e0..d075a68ac078 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -482,7 +482,7 @@
power_key_irq: power-key-irq {
samsung,pins = gpx1-3;
- samsung,pin-function = 0;
+ samsung,pin-function = 0xf;
samsung,pin-pud = 0;
samsung,pin-drv = 0;
};
@@ -510,7 +510,7 @@
lid_irq: lid-irq {
samsung,pins = gpx3-5;
- samsung,pin-function = 0;
+ samsung,pin-function = 0xf;
samsung,pin-pud = 0;
samsung,pin-drv = 0;
};
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board
Am 18.02.2015 um 11:07 schrieb Lukasz Majewski:
From: Kamil Debski k.deb...@samsung.com
Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the
cooling fan. In addition, add the pwm label to the pwm@139D node
in the exynos4412.dtsi.
Signed-off-by: Kamil Debski k.deb...@samsung.com
[Rebased on the newest mainline by l.majew...@samsung.com]
You need to sign off patches you submit.
---
Changes since v1:
- added pwm label to the pwm@139D node in exynos4.dtsi
- use the pwm label in the exynos4412-odroidu3.dts
- change order or properties in the pwn-fan node, to be sorted
in alphabetical order
---
arch/arm/boot/dts/exynos4.dtsi| 2 +-
arch/arm/boot/dts/exynos4412-odroidu3.dts | 13 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index f18d746..75266e3 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -582,7 +582,7 @@
status = disabled;
};
- pwm@139D {
+ pwm: pwm@139D {
compatible = samsung,exynos4210-pwm;
reg = 0x139D 0x1000;
interrupts = 0 37 0, 0 38 0, 0 39 0, 0 40 0, 0 41 0;
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts
b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index c8a64be..60bd1e4 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -31,6 +31,19 @@
linux,default-trigger = heartbeat;
};
};
+
+ pwm-fan {
+ compatible = pwm-fan;
+ pwms = pwm 0 1 0;
+ status = okay;
Status okay is only needed for pre-existing nodes that would have
status disabled otherwise, such as below. Just drop it here.
Regards,
Andreas
+ };
+};
+
+pwm {
+ pinctrl-0 = pwm0_out;
+ pinctrl-names = default;
+ samsung,pwm-outputs = 0;
+ status = okay;
};
usb3503 {
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: dts: Update exynos5250-spring with mmc node changes
Resolve a merge conflict with mmc refactoring aaa25a5a33cb (ARM: dts:
unuse the slot-node and deprecate the supports-highspeed for dw-mmc in
exynos) by dropping the slot@0 nodes, moving its bus-width property to
the mmc node and replacing supports-highspeed with cap-{mmc,sd}-highspeed,
matching exynos5250-snow.
Cc: Jaehoon Chung jh80.ch...@samsung.com
Fixes: 53dd4138bb0a (ARM: dts: Add exynos5250-spring device tree)
Signed-off-by: Andreas Färber afaer...@suse.de
---
arch/arm/boot/dts/exynos5250-spring.dts | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
index f02775487cd4..c41600e587e0 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -429,7 +429,6 @@
mmc_0 {
status = okay;
num-slots = 1;
- supports-highspeed;
broken-cd;
card-detect-delay = 200;
samsung,dw-mshc-ciu-div = 3;
@@ -437,11 +436,8 @@
samsung,dw-mshc-ddr-timing = 1 2;
pinctrl-names = default;
pinctrl-0 = sd0_clk sd0_cmd sd0_cd sd0_bus4 sd0_bus8;
-
- slot@0 {
- reg = 0;
- bus-width = 8;
- };
+ bus-width = 8;
+ cap-mmc-highspeed;
};
/*
@@ -451,7 +447,6 @@
mmc_1 {
status = okay;
num-slots = 1;
- supports-highspeed;
broken-cd;
card-detect-delay = 200;
samsung,dw-mshc-ciu-div = 3;
@@ -459,11 +454,8 @@
samsung,dw-mshc-ddr-timing = 1 2;
pinctrl-names = default;
pinctrl-0 = sd1_clk sd1_cmd sd1_cd sd1_bus4;
-
- slot@0 {
- reg = 0;
- bus-width = 4;
- };
+ bus-width = 4;
+ cap-sd-highspeed;
};
pinctrl_0 {
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 8/9] ARM: dts: exynos5250: add display power domain
Am 02.02.2015 um 14:20 schrieb Marek Szyprowski: From: Andrzej Hajda a.ha...@samsung.com The patch adds domain definition and references to it in appropriate devices. Signed-off-by: Andrzej Hajda a.ha...@samsung.com [mszyprow: rebased onto generic power domains dt bindings] Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk On Spring, Tested-by: Andreas Färber afaer...@suse.de Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 7/9] ARM: dts: Exynos: add 'hdmi' clock to mixer nodes
Am 02.02.2015 um 14:20 schrieb Marek Szyprowski:
Mixed block needs to control hdmi clock to properly perform power on/off
operation, so add 'hdmi' clock also to mixer nodes.
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
---
arch/arm/boot/dts/exynos5250.dtsi | 5 +++--
arch/arm/boot/dts/exynos5420.dtsi | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 9bb1b0b738f5..e8c67fdb69fb 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -732,8 +732,9 @@
compatible = samsung,exynos5250-mixer;
reg = 0x1445 0x1;
interrupts = 0 94 0;
- clocks = clock CLK_MIXER, clock CLK_SCLK_HDMI;
- clock-names = mixer, sclk_hdmi;
+ clocks = clock CLK_MIXER, clock CLK_HDMI,
+ clock CLK_SCLK_HDMI;
+ clock-names = mixer, hdmi, sclk_hdmi;
};
dp_phy: video-phy@10040720 {
[snip]
Tested-by: Andreas Färber afaer...@suse.de
Without this patch, next-20150218 exynos drm mixer fails to locate the
hdmi clock on Spring.
Kukjin, can you please queue the remaining patches 1-8?
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 2/2] net: stmmac: add fixed_phy support via fixed-link DT binding
Am 26.01.2015 um 03:37 schrieb Ming Lei:
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 8c6b7c16..ddb4351 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -847,8 +847,11 @@ static int stmmac_init_phy(struct net_device *dev)
* 0 rather than 0x. Catch this here and treat 0 as a non-existent
* device as well.
* Note: phydev-phy_id is the result of reading the UID PHY registers.
+ * But phy_id returned from fixed phy is always zero, so bypass the
+ * check for fixed phy.
*/
- if (phydev-phy_id == 0) {
+ if (phydev-phy_id == 0 (!priv-plat-phy_bus_name ||
+ strcmp(priv-plat-phy_bus_name,fixed))) {
Small nit here: There's a space missing between the arguments.
Cheers,
Andreas
phy_disconnect(phydev);
return -ENODEV;
}
[snip]
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
signature.asc
Description: OpenPGP digital signature
Re: [PATCH v3 3/5] pinctrl: exynos: add exynos5410 SoC specific data
Am 28.11.2014 um 12:59 schrieb Linus Walleij:
On Sat, Nov 22, 2014 at 11:26 PM, Andreas Färber afaer...@suse.de wrote:
From: Hakjoo Kim ruppi@hardkernel.com
Add Samsung EXYNOS5410 SoC specific data to enable pinctrl
support for all platforms based on EXYNOS5410.
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
[AF: Rebased onto Exynos5260 and irq_chip consolidation]
Signed-off-by: Andreas Färber afaer...@suse.de
---
v2 - v3:
* Rebased (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
v1 - v2:
* Filled in Sob from Hakjoo Kim
Is this based on the pinctrl devel branch so I can apply it?
It was based on the Samsung for-next tree. I can rebase if needed.
I'd like Tomasz ACK on it first though.
Thanks,
Andreas
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: exynos_defconfig: Enable CONFIG_FHANDLE
Am 28.11.2014 um 13:06 schrieb Sjoerd Simons: CONFIG_FHANDLE is required by systemd, which is the default init system in more and more distributions. So lets enable it for Exynos as well (it's already enabled in multi_v7_defconfig) Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk Reviewed-by: Andreas Färber afaer...@suse.de Thanks, Andreas -- SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 4/5] ARM: dts: add pinctrl support to Exynos5410
Am 22.11.2014 um 21:26 schrieb Andreas Färber: From: Hakjoo Kim ruppi@hardkernel.com Add the required pin configuration support to Exynos5410 using pinctrl interface. Signed-off-by: Hakjoo Kim ruppi@hardkernel.com [AF: Rebased, style changes] Signed-off-by: Andreas Färber afaer...@suse.de --- v1 - v2: * Filled in Sob from Hakjoo Kim Missed one review comment from the RFC, v3 coming up. Andreas -- SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 4/5] ARM: dts: add pinctrl support to Exynos5410
From: Hakjoo Kim ruppi@hardkernel.com
Add the required pin configuration support to Exynos5410 using pinctrl
interface.
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
[AF: Rebased, style changes]
Signed-off-by: Andreas Färber afaer...@suse.de
---
v2 - v3:
* Added wake-up IRQ controller node (Tomasz Figa)
v1 - v2:
* Filled in Sob from Hakjoo Kim
arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 406 ++
arch/arm/boot/dts/exynos5410.dtsi | 36 +++
2 files changed, 442 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi
diff --git a/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
new file mode 100644
index ..f9aa6bb55464
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
@@ -0,0 +1,406 @@
+/*
+ * Exynos5410 SoC pin-mux and pin-config device tree source
+ *
+ * Copyright (c) 2013 Hardkernel Co., Ltd.
+ * http://www.hardkernel.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+pinctrl_0 {
+ gpa0: gpa0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpa1: gpa1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpa2: gpa2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb0: gpb0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb1: gpb1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb2: gpb2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb3: gpb3 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc0: gpc0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc3: gpc3 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc1: gpc1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc2: gpc2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpm5: gpm5 {
+ gpio-controller;
+ #gpio-cells = 2;
+ };
+
+ gpd1: gpd1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpe0: gpe0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpe1: gpe1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpf0: gpf0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpf1: gpf1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg0: gpg0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg1: gpg1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg2: gpg2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gph0: gph0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gph1: gph1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller
[PATCH v2 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs
Hello,
This series adds a dedicated ODROID-XU device tree and enhances it with
LED configuration, to match the downstream 3.14 based behavior.
Regards,
Andreas
v1 - v2:
* Inserted needed Sobs from Hakjoo Kim
* Rebased pinctrl (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
Andreas Färber (3):
ARM: dts: exynos5410: Clean up SMDK5410 indentation
ARM: dts: exynos5410: Prepare ODROID-XU device tree
ARM: dts: exynos5410: Add ODROID-XU LEDs
Hakjoo Kim (2):
pinctrl: exynos: add exynos5410 SoC specific data
ARM: dts: add pinctrl support to Exynos5410
.../bindings/pinctrl/samsung-pinctrl.txt | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/exynos5410-odroidxu.dts | 103 ++
arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 406 +
arch/arm/boot/dts/exynos5410-smdk5410.dts | 6 +-
arch/arm/boot/dts/exynos5410.dtsi | 30 ++
drivers/pinctrl/samsung/pinctrl-exynos.c | 126 +++
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +
drivers/pinctrl/samsung/pinctrl-samsung.h | 1 +
9 files changed, 673 insertions(+), 3 deletions(-)
create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi
--
2.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 2/5] ARM: dts: exynos5410: Prepare ODROID-XU device tree
Derived from exynos5410-smdk5410.dts.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2: Unchanged
arch/arm/boot/dts/Makefile| 1 +
arch/arm/boot/dts/exynos5410-odroidxu.dts | 78 +++
2 files changed, 79 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 91cd4d08b7f1..5b7cddbcb959 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -84,6 +84,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-rinato.dtb \
exynos5250-snow.dtb \
exynos5250-spring.dtb \
exynos5260-xyref5260.dtb \
+ exynos5410-odroidxu.dtb \
exynos5410-smdk5410.dtb \
exynos5420-arndale-octa.dtb \
exynos5420-peach-pit.dtb \
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
b/arch/arm/boot/dts/exynos5410-odroidxu.dts
new file mode 100644
index ..97310bb727e2
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -0,0 +1,78 @@
+/*
+ * Hardkernel ODROID-XU device tree source
+ *
+ * Copyright (c) 2014 SUSE LINUX Products GmbH
+ *
+ * Based on exynos5410-smdk5410.dts:
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+#include exynos5410.dtsi
+/ {
+ model = ODROID-XU based on EXYNOS5410;
+ compatible = hardkernel,odroid-xu, samsung,exynos5410,
samsung,exynos5;
+
+ memory {
+ reg = 0x4000 0x8000;
+ };
+
+ chosen {
+ bootargs = console=ttySAC2,115200;
+ };
+
+ fin_pll: xxti {
+ compatible = fixed-clock;
+ clock-frequency = 2400;
+ clock-output-names = fin_pll;
+ #clock-cells = 0;
+ };
+
+ firmware@02037000 {
+ compatible = samsung,secure-firmware;
+ reg = 0x02037000 0x1000;
+ };
+
+};
+
+mmc_0 {
+ status = okay;
+ num-slots = 1;
+ cap-mmc-highspeed;
+ broken-cd;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 2 3;
+ samsung,dw-mshc-ddr-timing = 1 2;
+ bus-width = 8;
+};
+
+mmc_2 {
+ status = okay;
+ num-slots = 1;
+ cap-sd-highspeed;
+ card-detect-delay = 200;
+ samsung,dw-mshc-ciu-div = 3;
+ samsung,dw-mshc-sdr-timing = 2 3;
+ samsung,dw-mshc-ddr-timing = 1 2;
+ bus-width = 4;
+ disable-wp;
+};
+
+uart0 {
+ status = okay;
+};
+
+uart1 {
+ status = okay;
+};
+
+uart2 {
+ status = okay;
+};
--
2.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 3/5] pinctrl: exynos: add exynos5410 SoC specific data
From: Hakjoo Kim ruppi@hardkernel.com
Add Samsung EXYNOS5410 SoC specific data to enable pinctrl
support for all platforms based on EXYNOS5410.
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
[AF: Rebased onto Exynos5260]
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2:
* Filled in Sob from Hakjoo Kim
* Rebased (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
.../bindings/pinctrl/samsung-pinctrl.txt | 1 +
drivers/pinctrl/samsung/pinctrl-exynos.c | 126 +
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +
drivers/pinctrl/samsung/pinctrl-samsung.h | 1 +
4 files changed, 130 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
index e82aaf492517..b87a176e730e 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
@@ -17,6 +17,7 @@ Required Properties:
- samsung,exynos4x12-pinctrl: for Exynos4x12 compatible pin-controller.
- samsung,exynos5250-pinctrl: for Exynos5250 compatible pin-controller.
- samsung,exynos5260-pinctrl: for Exynos5260 compatible pin-controller.
+ - samsung,exynos5410-pinctrl: for Exynos5410 compatible pin-controller.
- samsung,exynos5420-pinctrl: for Exynos5420 compatible pin-controller.
- reg: Base address of the pin controller hardware module and length of
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c
b/drivers/pinctrl/samsung/pinctrl-exynos.c
index d7154ed0b0eb..ef0e2a0d26eb 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -1084,6 +1084,132 @@ struct samsung_pin_ctrl exynos5260_pin_ctrl[] = {
},
};
+/* pin banks of exynos5410 pin-controller 0 */
+static struct samsung_pin_bank exynos5410_pin_banks0[] = {
+ EXYNOS_PIN_BANK_EINTG(8, 0x000, gpa0, 0x00),
+ EXYNOS_PIN_BANK_EINTG(6, 0x020, gpa1, 0x04),
+ EXYNOS_PIN_BANK_EINTG(8, 0x040, gpa2, 0x08),
+ EXYNOS_PIN_BANK_EINTG(5, 0x060, gpb0, 0x0c),
+ EXYNOS_PIN_BANK_EINTG(5, 0x080, gpb1, 0x10),
+ EXYNOS_PIN_BANK_EINTG(4, 0x0A0, gpb2, 0x14),
+ EXYNOS_PIN_BANK_EINTG(4, 0x0C0, gpb3, 0x18),
+ EXYNOS_PIN_BANK_EINTG(7, 0x0E0, gpc0, 0x1c),
+ EXYNOS_PIN_BANK_EINTG(4, 0x100, gpc3, 0x20),
+ EXYNOS_PIN_BANK_EINTG(7, 0x120, gpc1, 0x24),
+ EXYNOS_PIN_BANK_EINTG(7, 0x140, gpc2, 0x28),
+ EXYNOS_PIN_BANK_EINTN(2, 0x160, gpm5),
+ EXYNOS_PIN_BANK_EINTG(8, 0x180, gpd1, 0x2c),
+ EXYNOS_PIN_BANK_EINTG(8, 0x1A0, gpe0, 0x30),
+ EXYNOS_PIN_BANK_EINTG(2, 0x1C0, gpe1, 0x34),
+ EXYNOS_PIN_BANK_EINTG(6, 0x1E0, gpf0, 0x38),
+ EXYNOS_PIN_BANK_EINTG(8, 0x200, gpf1, 0x3c),
+ EXYNOS_PIN_BANK_EINTG(8, 0x220, gpg0, 0x40),
+ EXYNOS_PIN_BANK_EINTG(8, 0x240, gpg1, 0x44),
+ EXYNOS_PIN_BANK_EINTG(2, 0x260, gpg2, 0x48),
+ EXYNOS_PIN_BANK_EINTG(4, 0x280, gph0, 0x4c),
+ EXYNOS_PIN_BANK_EINTG(8, 0x2A0, gph1, 0x50),
+ EXYNOS_PIN_BANK_EINTN(8, 0x2C0, gpm7),
+ EXYNOS_PIN_BANK_EINTN(6, 0x2E0, gpy0),
+ EXYNOS_PIN_BANK_EINTN(4, 0x300, gpy1),
+ EXYNOS_PIN_BANK_EINTN(6, 0x320, gpy2),
+ EXYNOS_PIN_BANK_EINTN(8, 0x340, gpy3),
+ EXYNOS_PIN_BANK_EINTN(8, 0x360, gpy4),
+ EXYNOS_PIN_BANK_EINTN(8, 0x380, gpy5),
+ EXYNOS_PIN_BANK_EINTN(8, 0x3A0, gpy6),
+ EXYNOS_PIN_BANK_EINTN(8, 0x3C0, gpy7),
+ EXYNOS_PIN_BANK_EINTW(8, 0xC00, gpx0, 0x00),
+ EXYNOS_PIN_BANK_EINTW(8, 0xC20, gpx1, 0x04),
+ EXYNOS_PIN_BANK_EINTW(8, 0xC40, gpx2, 0x08),
+ EXYNOS_PIN_BANK_EINTW(8, 0xC60, gpx3, 0x0c),
+};
+
+/* pin banks of exynos5410 pin-controller 1 */
+static struct samsung_pin_bank exynos5410_pin_banks1[] = {
+ EXYNOS_PIN_BANK_EINTG(5, 0x000, gpj0, 0x00),
+ EXYNOS_PIN_BANK_EINTG(8, 0x020, gpj1, 0x04),
+ EXYNOS_PIN_BANK_EINTG(8, 0x040, gpj2, 0x08),
+ EXYNOS_PIN_BANK_EINTG(8, 0x060, gpj3, 0x0c),
+ EXYNOS_PIN_BANK_EINTG(2, 0x080, gpj4, 0x10),
+ EXYNOS_PIN_BANK_EINTG(8, 0x0A0, gpk0, 0x14),
+ EXYNOS_PIN_BANK_EINTG(8, 0x0C0, gpk1, 0x18),
+ EXYNOS_PIN_BANK_EINTG(8, 0x0E0, gpk2, 0x1c),
+ EXYNOS_PIN_BANK_EINTG(7, 0x100, gpk3, 0x20),
+};
+
+/* pin banks of exynos5410 pin-controller 2 */
+static struct samsung_pin_bank exynos5410_pin_banks2[] = {
+ EXYNOS_PIN_BANK_EINTG(8, 0x000, gpv0, 0x00),
+ EXYNOS_PIN_BANK_EINTG(8, 0x020, gpv1, 0x04),
+ EXYNOS_PIN_BANK_EINTG(8, 0x060, gpv2, 0x08),
+ EXYNOS_PIN_BANK_EINTG(8, 0x080, gpv3, 0x0c),
+ EXYNOS_PIN_BANK_EINTG(2, 0x0C0, gpv4, 0x10),
+};
+
+/* pin banks of exynos5410 pin-controller 3 */
+static struct samsung_pin_bank exynos5410_pin_banks3[] = {
+ EXYNOS_PIN_BANK_EINTG(7, 0x000, gpz, 0x00),
+};
+
+/*
+ * Samsung pinctrl driver data for Exynos5410 SoC. Exynos5410 SoC includes
+ * four gpio/pin-mux/pinconfig controllers.
+ */
+struct
[PATCH v2 5/5] ARM: dts: exynos5410: Add ODROID-XU LEDs
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2:
* Filled in Sob from Hakjoo Kim
arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +
1 file changed, 25 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 97310bb727e2..b02cd3ab7b38 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -15,6 +15,7 @@
/dts-v1/;
#include exynos5410.dtsi
+#include dt-bindings/gpio/gpio.h
/ {
model = ODROID-XU based on EXYNOS5410;
compatible = hardkernel,odroid-xu, samsung,exynos5410,
samsung,exynos5;
@@ -39,6 +40,30 @@
reg = 0x02037000 0x1000;
};
+ leds {
+ compatible = gpio-leds;
+
+ blue {
+ label = blue:heartbeat;
+ gpios = gpb2 2 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = heartbeat;
+ };
+
+ green {
+ label = green:activity;
+ gpios = gpb2 1 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = mmc0;
+ };
+
+ red {
+ label = red:activity;
+ gpios = gpx2 3 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = mmc1;
+ };
+ };
};
mmc_0 {
--
2.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 4/5] ARM: dts: add pinctrl support to Exynos5410
From: Hakjoo Kim ruppi@hardkernel.com
Add the required pin configuration support to Exynos5410 using pinctrl
interface.
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
[AF: Rebased, style changes]
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2:
* Filled in Sob from Hakjoo Kim
arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 406 ++
arch/arm/boot/dts/exynos5410.dtsi | 30 +++
2 files changed, 436 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi
diff --git a/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
new file mode 100644
index ..f9aa6bb55464
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
@@ -0,0 +1,406 @@
+/*
+ * Exynos5410 SoC pin-mux and pin-config device tree source
+ *
+ * Copyright (c) 2013 Hardkernel Co., Ltd.
+ * http://www.hardkernel.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+pinctrl_0 {
+ gpa0: gpa0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpa1: gpa1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpa2: gpa2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb0: gpb0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb1: gpb1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb2: gpb2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpb3: gpb3 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc0: gpc0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc3: gpc3 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc1: gpc1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpc2: gpc2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpm5: gpm5 {
+ gpio-controller;
+ #gpio-cells = 2;
+ };
+
+ gpd1: gpd1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpe0: gpe0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpe1: gpe1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpf0: gpf0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpf1: gpf1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg0: gpg0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg1: gpg1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpg2: gpg2 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gph0: gph0 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gph1: gph1 {
+ gpio-controller;
+ #gpio-cells = 2;
+
+ interrupt-controller;
+ #interrupt-cells = 2;
+ };
+
+ gpm7: gpm7
[PATCH v2 1/5] ARM: dts: exynos5410: Clean up SMDK5410 indentation
The UART status properties are indented one level too deep, and we want
to derive a device tree for the ODROID-XU. Fix this before it propagates.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2: Unchanged
arch/arm/boot/dts/exynos5410-smdk5410.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5410-smdk5410.dts
b/arch/arm/boot/dts/exynos5410-smdk5410.dts
index be3e02530b42..cebeaab3abec 100644
--- a/arch/arm/boot/dts/exynos5410-smdk5410.dts
+++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts
@@ -62,13 +62,13 @@
};
uart0 {
- status = okay;
+ status = okay;
};
uart1 {
- status = okay;
+ status = okay;
};
uart2 {
- status = okay;
+ status = okay;
};
--
2.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/5] pinctrl: exynos: add exynos5410 SoC specific data
Am 22.11.2014 um 21:26 schrieb Andreas Färber:
From: Hakjoo Kim ruppi@hardkernel.com
Add Samsung EXYNOS5410 SoC specific data to enable pinctrl
support for all platforms based on EXYNOS5410.
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
[AF: Rebased onto Exynos5260]
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2:
* Filled in Sob from Hakjoo Kim
* Rebased (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
Ugh, this patch is actually missing exactly this change! Stay tuned...
Andreas
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 3/5] pinctrl: exynos: add exynos5410 SoC specific data
From: Hakjoo Kim ruppi@hardkernel.com
Add Samsung EXYNOS5410 SoC specific data to enable pinctrl
support for all platforms based on EXYNOS5410.
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
[AF: Rebased onto Exynos5260 and irq_chip consolidation]
Signed-off-by: Andreas Färber afaer...@suse.de
---
v2 - v3:
* Rebased (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
v1 - v2:
* Filled in Sob from Hakjoo Kim
.../bindings/pinctrl/samsung-pinctrl.txt | 1 +
drivers/pinctrl/samsung/pinctrl-exynos.c | 107 +
drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +
drivers/pinctrl/samsung/pinctrl-samsung.h | 1 +
4 files changed, 111 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
index e82aaf492517..b87a176e730e 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
@@ -17,6 +17,7 @@ Required Properties:
- samsung,exynos4x12-pinctrl: for Exynos4x12 compatible pin-controller.
- samsung,exynos5250-pinctrl: for Exynos5250 compatible pin-controller.
- samsung,exynos5260-pinctrl: for Exynos5260 compatible pin-controller.
+ - samsung,exynos5410-pinctrl: for Exynos5410 compatible pin-controller.
- samsung,exynos5420-pinctrl: for Exynos5420 compatible pin-controller.
- reg: Base address of the pin controller hardware module and length of
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c
b/drivers/pinctrl/samsung/pinctrl-exynos.c
index d7154ed0b0eb..0580399a6587 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -1084,6 +1084,113 @@ struct samsung_pin_ctrl exynos5260_pin_ctrl[] = {
},
};
+/* pin banks of exynos5410 pin-controller 0 */
+static struct samsung_pin_bank exynos5410_pin_banks0[] = {
+ EXYNOS_PIN_BANK_EINTG(8, 0x000, gpa0, 0x00),
+ EXYNOS_PIN_BANK_EINTG(6, 0x020, gpa1, 0x04),
+ EXYNOS_PIN_BANK_EINTG(8, 0x040, gpa2, 0x08),
+ EXYNOS_PIN_BANK_EINTG(5, 0x060, gpb0, 0x0c),
+ EXYNOS_PIN_BANK_EINTG(5, 0x080, gpb1, 0x10),
+ EXYNOS_PIN_BANK_EINTG(4, 0x0A0, gpb2, 0x14),
+ EXYNOS_PIN_BANK_EINTG(4, 0x0C0, gpb3, 0x18),
+ EXYNOS_PIN_BANK_EINTG(7, 0x0E0, gpc0, 0x1c),
+ EXYNOS_PIN_BANK_EINTG(4, 0x100, gpc3, 0x20),
+ EXYNOS_PIN_BANK_EINTG(7, 0x120, gpc1, 0x24),
+ EXYNOS_PIN_BANK_EINTG(7, 0x140, gpc2, 0x28),
+ EXYNOS_PIN_BANK_EINTN(2, 0x160, gpm5),
+ EXYNOS_PIN_BANK_EINTG(8, 0x180, gpd1, 0x2c),
+ EXYNOS_PIN_BANK_EINTG(8, 0x1A0, gpe0, 0x30),
+ EXYNOS_PIN_BANK_EINTG(2, 0x1C0, gpe1, 0x34),
+ EXYNOS_PIN_BANK_EINTG(6, 0x1E0, gpf0, 0x38),
+ EXYNOS_PIN_BANK_EINTG(8, 0x200, gpf1, 0x3c),
+ EXYNOS_PIN_BANK_EINTG(8, 0x220, gpg0, 0x40),
+ EXYNOS_PIN_BANK_EINTG(8, 0x240, gpg1, 0x44),
+ EXYNOS_PIN_BANK_EINTG(2, 0x260, gpg2, 0x48),
+ EXYNOS_PIN_BANK_EINTG(4, 0x280, gph0, 0x4c),
+ EXYNOS_PIN_BANK_EINTG(8, 0x2A0, gph1, 0x50),
+ EXYNOS_PIN_BANK_EINTN(8, 0x2C0, gpm7),
+ EXYNOS_PIN_BANK_EINTN(6, 0x2E0, gpy0),
+ EXYNOS_PIN_BANK_EINTN(4, 0x300, gpy1),
+ EXYNOS_PIN_BANK_EINTN(6, 0x320, gpy2),
+ EXYNOS_PIN_BANK_EINTN(8, 0x340, gpy3),
+ EXYNOS_PIN_BANK_EINTN(8, 0x360, gpy4),
+ EXYNOS_PIN_BANK_EINTN(8, 0x380, gpy5),
+ EXYNOS_PIN_BANK_EINTN(8, 0x3A0, gpy6),
+ EXYNOS_PIN_BANK_EINTN(8, 0x3C0, gpy7),
+ EXYNOS_PIN_BANK_EINTW(8, 0xC00, gpx0, 0x00),
+ EXYNOS_PIN_BANK_EINTW(8, 0xC20, gpx1, 0x04),
+ EXYNOS_PIN_BANK_EINTW(8, 0xC40, gpx2, 0x08),
+ EXYNOS_PIN_BANK_EINTW(8, 0xC60, gpx3, 0x0c),
+};
+
+/* pin banks of exynos5410 pin-controller 1 */
+static struct samsung_pin_bank exynos5410_pin_banks1[] = {
+ EXYNOS_PIN_BANK_EINTG(5, 0x000, gpj0, 0x00),
+ EXYNOS_PIN_BANK_EINTG(8, 0x020, gpj1, 0x04),
+ EXYNOS_PIN_BANK_EINTG(8, 0x040, gpj2, 0x08),
+ EXYNOS_PIN_BANK_EINTG(8, 0x060, gpj3, 0x0c),
+ EXYNOS_PIN_BANK_EINTG(2, 0x080, gpj4, 0x10),
+ EXYNOS_PIN_BANK_EINTG(8, 0x0A0, gpk0, 0x14),
+ EXYNOS_PIN_BANK_EINTG(8, 0x0C0, gpk1, 0x18),
+ EXYNOS_PIN_BANK_EINTG(8, 0x0E0, gpk2, 0x1c),
+ EXYNOS_PIN_BANK_EINTG(7, 0x100, gpk3, 0x20),
+};
+
+/* pin banks of exynos5410 pin-controller 2 */
+static struct samsung_pin_bank exynos5410_pin_banks2[] = {
+ EXYNOS_PIN_BANK_EINTG(8, 0x000, gpv0, 0x00),
+ EXYNOS_PIN_BANK_EINTG(8, 0x020, gpv1, 0x04),
+ EXYNOS_PIN_BANK_EINTG(8, 0x060, gpv2, 0x08),
+ EXYNOS_PIN_BANK_EINTG(8, 0x080, gpv3, 0x0c),
+ EXYNOS_PIN_BANK_EINTG(2, 0x0C0, gpv4, 0x10),
+};
+
+/* pin banks of exynos5410 pin-controller 3 */
+static struct samsung_pin_bank exynos5410_pin_banks3[] = {
+ EXYNOS_PIN_BANK_EINTG(7, 0x000, gpz, 0x00),
+};
+
+/*
+ * Samsung pinctrl driver data for Exynos5410 SoC. Exynos5410 SoC includes
+ * four gpio/pin-mux
Re: [PATCH v2 5/5] ARM: dts: exynos5410: Add ODROID-XU LEDs
Hello Hakjoo,
Am 22.11.2014 um 21:26 schrieb Andreas Färber:
Signed-off-by: Hakjoo Kim ruppi@hardkernel.com
Sorry, I was too quick here: Only the previous two patches got signed
off by you, plus the last one on your 3.14 branch. Are you able to sign
off all patches authored by you there? (An email reply indicating the
Signed-off-by should do, if updating the branch is too much work.)
Thanks,
Andreas
Signed-off-by: Andreas Färber afaer...@suse.de
---
v1 - v2:
* Filled in Sob from Hakjoo Kim
arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +
1 file changed, 25 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 97310bb727e2..b02cd3ab7b38 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -15,6 +15,7 @@
/dts-v1/;
#include exynos5410.dtsi
+#include dt-bindings/gpio/gpio.h
/ {
model = ODROID-XU based on EXYNOS5410;
compatible = hardkernel,odroid-xu, samsung,exynos5410,
samsung,exynos5;
@@ -39,6 +40,30 @@
reg = 0x02037000 0x1000;
};
+ leds {
+ compatible = gpio-leds;
+
+ blue {
+ label = blue:heartbeat;
+ gpios = gpb2 2 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = heartbeat;
+ };
+
+ green {
+ label = green:activity;
+ gpios = gpb2 1 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = mmc0;
+ };
+
+ red {
+ label = red:activity;
+ gpios = gpx2 3 GPIO_ACTIVE_HIGH;
+ default-state = off;
+ linux,default-trigger = mmc1;
+ };
+ };
};
mmc_0 {
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/1] drm/exynos: Move platform drivers registration to module init
Am 21.11.2014 um 00:49 schrieb Paolo Pisati: vanilla kgene/for-next as of today: 7552917 Revert ARM: exynos_defconfig: Enable options for display panel support ff0391a Merge branch 'v3.19-samsung-defconfig' into for-next 26c6283 Merge branch 'v3.18-samsung-fixes' into for-next cf864fd Merge branch 'v3.18-samsung-defconfig' into for-next 98b6380 ARM: exynos_defconfig: Enable max77802 rtc and clock drivers 839275c ARM: exynos_defconfig: Use 16 minors per MMC block device 0526f27 ARM: dts: Explicitly set dr_mode on exynos5250-snow fc14f9c Linux 3.18-rc5 ... plus 5e1e068 arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy 36d908e drm/exynos: dp: Remove support for unused dptx-phy 624bff2 POSTED: mfd: syscon: Decouple syscon interface from syscon devices 68944e3 Revert Revert ARM: exynos_defconfig: Enable options for display panel support vanilla exynos_defconfig with SND_SOC_SNOW disabled. I should probably try linux-next at this point, but i wonder if people who reported kgene/for-next working were testing with a vanilla exynos_defconfig on a peach pi. On Spring, I am able to boot my kgene/for-next based queue with just: mfd: syscon: Decouple syscon interface from platform devices arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy with DRM_EXYNOS*=y (except IOMMU) and SND_SOC_SNOW=m enabled in the config, while using simplefb rather than the Exynos DRM and thus clk_ignore_unused. Regarding SND_SOC_SNOW: Note that I recently submitted a patch to enable module-loading, which is missing in kgene/for-next and -rc5 but is in linux-next.git - it might uncover problems that previously went unnoticed: https://patchwork.kernel.org/patch/5235951/ exynos_defconfig has SND_SOC_SNOW=y, whereas multi_v7_defconfig doesn't have it. Regards, Andreas -- SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v12 3/6] ARM: dts: Exynos: add CPU OPP and regulator supply property
Javier, Doug,
Am 21.11.2014 um 14:31 schrieb Thomas Abraham:
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
b/arch/arm/boot/dts/exynos5250-arndale.dts
index 3acd97e..da2b3e1 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -563,3 +563,7 @@
};
};
};
+
+cpu0 {
+ cpu0-supply = buck2_reg;
+};
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 6a0f4c0..0eedb88 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -406,3 +406,7 @@
};
};
};
+
+cpu0 {
+ cpu0-supply = buck2_reg;
+};
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index e51fcef..865f68a 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -345,6 +345,10 @@
};
};
+cpu0 {
+ cpu0-supply = buck2_reg;
+};
+
i2c_0 {
status = okay;
samsung,i2c-sda-delay = 100;
Not sure whether I've asked before... Do you know what needs to be
specified for exynos5250-spring.dts, which has in the meantime landed in
kgene/for-next?
Regards,
Andreas
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index f21b9aa..d4b418e 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -58,11 +58,34 @@
#address-cells = 1;
#size-cells = 0;
- cpu@0 {
+ cpu0: cpu@0 {
device_type = cpu;
compatible = arm,cortex-a15;
reg = 0;
clock-frequency = 17;
+
+ clocks = clock CLK_ARM_CLK;
+ clock-names = cpu;
+ clock-latency = 14;
+
+ operating-points =
+ 170 130
+ 160 125
+ 150 1225000
+ 140 120
+ 130 115
+ 120 1125000
+ 110 110
+ 100 1075000
+ 90 105
+ 80 1025000
+ 70 1012500
+ 60 100
+ 50 975000
+ 40 95
+ 30 937500
+ 20 925000
+ ;
};
cpu@1 {
device_type = cpu;
[snip]
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/4] ARM: dts: exynos: Second round of Spring support
Hello, Following the initial merge of the HP Chromebook 11 device tree, here's a few follow-ups. A sound series is prepared separately. Regards, Andreas Andreas Färber (4): ARM: dts: Add usb3503 pinctrl to exynos5250-spring ARM: dts: Add temperature sensor to exynos5250-spring ARM: exynos_defconfig: Enable LM90 driver ARM: dts: Add trackpad to exynos5250-spring arch/arm/boot/dts/exynos5250-spring.dts | 30 ++ arch/arm/configs/exynos_defconfig | 3 ++- 2 files changed, 32 insertions(+), 1 deletion(-) -- 2.1.2 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/4] ARM: dts: Add trackpad to exynos5250-spring
The HP Chromebook 11 uses an Atmel maXTouch as trackpad.
The keymap was found by trial-and-error.
Signed-off-by: Andreas Färber afaer...@suse.de
---
arch/arm/boot/dts/exynos5250-spring.dts | 23 +++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
index cc3361afba49..2fa207c9e5e2 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -330,6 +330,22 @@
status = okay;
samsung,i2c-sda-delay = 100;
samsung,i2c-max-bus-freq = 378000;
+
+ trackpad@4b {
+ compatible = atmel,maxtouch;
+ reg = 0x4b;
+ interrupt-parent = gpx1;
+ interrupts = 2 IRQ_TYPE_EDGE_FALLING;
+ pinctrl-names = default;
+ pinctrl-0 = trackpad_irq;
+ linux,gpio-keymap = KEY_RESERVED
+KEY_RESERVED
+KEY_RESERVED
+KEY_RESERVED
+KEY_RESERVED
+BTN_LEFT;
+ wakeup-source;
+ };
};
/*
@@ -465,6 +481,13 @@
samsung,pin-drv = 0;
};
+ trackpad_irq: trackpad-irq {
+ samsung,pins = gpx1-2;
+ samsung,pin-function = 0xf;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+
power_key_irq: power-key-irq {
samsung,pins = gpx1-3;
samsung,pin-function = 0;
--
2.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/4] ARM: exynos_defconfig: Enable LM90 driver
multi_v7_defconfig has it as Y already, so build it in here, too, for consistency, and therefore build in HWMON as well. Signed-off-by: Andreas Färber afaer...@suse.de --- arch/arm/configs/exynos_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 8dfa7d312f51..2d7d2027aeb9 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -84,7 +84,8 @@ CONFIG_DEBUG_GPIO=y CONFIG_POWER_SUPPLY=y CONFIG_BATTERY_SBS=y CONFIG_CHARGER_TPS65090=y -# CONFIG_HWMON is not set +CONFIG_HWMON=y +CONFIG_SENSORS_LM90=y CONFIG_THERMAL=y CONFIG_EXYNOS_THERMAL=y CONFIG_EXYNOS_THERMAL_CORE=y -- 2.1.2 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/4] ARM: dts: Add usb3503 pinctrl to exynos5250-spring
Reported-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
arch/arm/boot/dts/exynos5250-spring.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
index f5566f84d885..310764b6e28d 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -52,6 +52,8 @@
usb-hub {
compatible = smsc,usb3503a;
reset-gpios = gpe1 0 GPIO_ACTIVE_LOW;
+ pinctrl-names = default;
+ pinctrl-0 = hsic_reset;
};
fixed-rate-clocks {
--
2.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/4] ARM: dts: Add temperature sensor to exynos5250-spring
Spotted in the Chrome OS 3.8 based device tree.
Needs CONFIG_SENSORS_LM90.
Signed-off-by: Andreas Färber afaer...@suse.de
---
arch/arm/boot/dts/exynos5250-spring.dts | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
index 310764b6e28d..cc3361afba49 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -383,6 +383,11 @@
status = okay;
samsung,i2c-sda-delay = 100;
samsung,i2c-max-bus-freq = 66000;
+
+ temperature-sensor@4c {
+ compatible = gmt,g781;
+ reg = 0x4c;
+ };
};
i2c_8 {
--
2.1.2
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support
Am 19.11.2014 um 17:28 schrieb Javier Martinez Canillas: On 11/19/2014 05:22 PM, Paolo Pisati wrote: On Wed, Nov 19, 2014 at 12:20:53PM +0100, Javier Martinez Canillas wrote: If someone else is interested, I've pushed a branch [0] with 3.18-rc5 + all the needed patches. Ajay, feel free to add to your series: Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier [0]: git://git.collabora.co.uk/git/user/javier/linux.git wip/exynos/dp-integ doesn't peach pi require the same dts modification as peach pit/snow? No, because the Peach Pit and Snow have an eDP to LVDS bridge chip but the Peach Pi does not have a bridge. Ajay's series is to add DRM bridge support to Exynos Display Port driver and so is only relevant to Snow and Pit. ... and to Spring. So, what's the timing here - is this series headed for 3.20 now or 3.19? Regards, Andreas -- SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow
Am 05.11.2014 um 18:09 schrieb Mark Brown: On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote: This enables the snd_soc_snow module to be auto-loaded. Applied, thanks. Thanks. I notice you dropped my Fixes: line that SubmittingPatches asks for. When do I need it and when should I leave it out? I thought it tells GregKH more precisely which stable branches are affected for backports than just a CC. Regards, Andreas -- SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg signature.asc Description: OpenPGP digital signature
nv u-boot for spring (was: building nv-uboot for nyan-big.)
Dear Stephan, Am 03.11.2014 um 11:42 schrieb S.J.R. van Schaik: [...] I have done some research to figure out how to build a working nv u-boot binary, and working instructions can be found on the linux-exynos wiki [1]. However, when I tried to apply them to the snow and spring boards, by selecting a different branch and a different u-boot configuration, those attempts were of no success. [...] [...] The u-boot.bin binary seems to build fine. However, the problem is similar to the snow and spring boards, where I can't seem to build the DTB-files. You didn't ask me. ;) My Spring branch with patches is located here: https://github.com/afaerber/u-boot/commits/spring For my convenience I changed the sources to default to the right device tree, and I manually inlined exynos-periph-id.dtsi. If you need further info on my build steps, I can look them up in my scripts (on another machine) - I mainly derived them from the official instructions for Snow on the Chromium Wiki. I'm pretty sure I did not mess with the EC firmware at all. But whatever workarounds exist, the Chromium folks should really be working on upstreaming U-Boot support for all those Chromebooks, that usually sanitizes the build process as a side-effect, resulting in less user questions. :) For Snow I believe that to be done. Regards, Andreas 1. http://linux-exynos.org/wiki/ARM_Chromebook/Building_u-boot#Building_U-Boot_for_Peach_Pi.2FPit -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: dts: Add rtc_src clk for s3c-rtc on exynos5250-snow
Am 17.09.2014 um 17:47 schrieb Doug Anderson:
Hi,
On Wed, Sep 17, 2014 at 4:50 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
commit 546b117fdf17 (rtc: s3c: add support for RTC of Exynos3250 SoC)
added an rtc_src DT property for the Samsung's S3C Real Time Clock
controller that specifies the 32.768 kHz clock that uses the RTC as its
source clock. In the case of the Exynos5250 based Snow board, the Maxim
77686 32kHz AP clock is used as the source clock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
arch/arm/boot/dts/exynos5250-snow.dts | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index e51fcef..56eec56 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -10,6 +10,7 @@
/dts-v1/;
#include dt-bindings/gpio/gpio.h
+#include dt-bindings/clock/maxim,max77686.h
#include exynos5250.dtsi
/ {
@@ -29,6 +30,8 @@
rtc@101E {
status = okay;
+ clocks = clock CLK_RTC, max77686 MAX77686_CLK_AP;
+ clock-names = rtc, rtc_src;
Wait, seriously? Snow is still using the rtc@101E syntax?
Whatever happened to the series that Andreas worked so hard on,
including https://patchwork.kernel.org/patch/4664801/?
Kukjin: Andreas's patch series was Reviewed long ago I think and by
now I'd imagine it's got some conflicts due to it not having been
applied in a timely fashion. Perhaps you could fix it up for Andreas
(since he's already rebased it several times) and land it?
If I had to guess, outstanding from Andreas's series (patchwork IDs listed):
4751131 New [v7] ARM: dts: Prepare node labels for exynos5250
4664801 New [v6,04/10] ARM: dts: Clean up exynos5250-snow
4664771 New [v6,05/10] ARM: dts: Fill in bootargs for exynos5250-snow
4664731 New [v6,06/10] ARM: dts: Clean up exynos5250-smdk5250
4664751 New [v6,07/10] ARM: dts: Clean up exynos5250-arndale
4664711 New [v6,08/10] ARM: dts: Fix apparent GPIO typo in
exynos5250-arndale
4664681 New [v6,09/10] ARM: dts: Simplify USB3503 on
exynos5250-arndale
4664691 New [v6,10/10] ARM: dts: Add exynos5250-spring device tree
Yes, Kukjin told me not to resend anything, and I haven't heard back
from him since his Kernel Summit trip.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad
Hi Javier,
Am 27.08.2014 09:13, schrieb Javier Martinez Canillas:
On 08/27/2014 12:53 AM, Andreas Färber wrote:
+hsi2c_8 {
+ status = okay;
+ clock-frequency = 333000;
+
+ trackpad@4b {
+ compatible=atmel,maxtouch;
+ reg=0x4b;
+ interrupt-parent=gpx1;
+ interrupts=1 IRQ_TYPE_EDGE_FALLING;
Nit: Here's a style break (4x spaces around '=' missing).
True, these bits were copied from the downstream Chrome OS verbatim and
the missing space around '=' was there, I missed that when reviewing.
I'll re-spin and fix those style issues.
+ wakeup-source;
+ pinctrl-names = default;
+ pinctrl-0 = trackpad_irq;
+ linux,gpio-keymap = KEY_RESERVED
+ KEY_RESERVED
+ 0 /* GPIO 0 */
+ 0 /* GPIO 1 */
+ 0 /* GPIO 2 */
+ BTN_LEFT /* GPIO 3 */
+ KEY_RESERVED
+ KEY_RESERVED ;
+ };
Coincidentally, I experimentally came up with a very similar DT node for
Spring the weekend:
+trackpad@4b {
+compatible = atmel,maxtouch;
+reg = 0x4b;
+interrupt-parent = gpx1;
+interrupts = 2 IRQ_TYPE_NONE;
+pinctrl-names = default;
+pinctrl-0 = trackpad_irq;
+linux,gpio-keymap = KEY_RESERVED
+ KEY_RESERVED
+ KEY_RESERVED
+ KEY_RESERVED
+ KEY_RESERVED
+ BTN_LEFT;
+wakeup-source;
+};
0 == KEY_RESERVED, so you can consistently use it for GPIO 0-2, too. :)
I know that the value of KEY_RESERVED is 0 but I didn't use KEY_RESERVED
for the GPIO on purpose.
What I understood is that the SPT_GPIOPWN_T19 object sends messages using
a status byte so you have a maximum of 8 GPIO but not every maXTouch
devices use all of them. So in the particular case of the device in the
Peach Pit, from the 8 possible GPIO only 4 can be used and these are pins
2-5. So in theory you could connect 3 more GPIO in case you had more
buttons (e.g: BTN_RIGHT, BTN_MIDDLE) but only 1 is used since the
Chromebook just have BTN_LEFT.
FWIW when I press to the bottom right of my touchpad, I do get
right-click functionality even with just BTN_LEFT specified in the
keymap. Magic. :)
Nick sent a patch [0] that extend the atmel touchpad DT binding and the
doc says Use KEY_RESERVED for unused padding values. But is not clear
what value you should use for GPIO that are actually supported by the
device but have no keycode associated.
So by using 0 instead of KEY_RESERVED I wanted to document that pins 2-4
are actually supported and not reserved by the device but there is no
keycode associated with that GPIO.
You already documented that via comments though.
If there was a BTN_NONE or KEY_UNUSED it would had been better but I think
that making a distinction between these two cases (reserved pin vs GPIO
available but not used) is useful.
Maybe Nick can comment here.
I probably should add the two trailing _RESERVEDs, too?
I see that is used for properties that are arrays, for example
linux,keymap in Documentation/devicetree/bindings/input/matrix-keymap.txt.
That does not answer my question: Do all maxTouch touchpads (or
specifically that in Spring) need eight entries, padded with said
KEY_RESERVED? In my experiments using just six entries (i.e., until the
non-zero entry) worked okay - so does this T19 message have specifically
eight bits? Tegra used just four entries iirc.
With my above snippet I got an awful lot of Interrupt triggered but
zero messages warnings (which I simply commented out as quickfix).
Is that why you are using _EDGE_FALLING? Or pin-function 0xf?
(In my case the ChromeOS DT had IRQ_TYPE_NONE and pin-function 0x0.)
These are two separate but related things:
a) IRQF_TRIGGER_FALLING:
Yes, the Chrome OS DT for Peach Pit also has IRQ_TYPE_NONE but the DTS is
not correct.
If you look at the Chrome OS atmel driver
(drivers/input/touchscreen/atmel_mxt_ts.c), it passes IRQF_TRIGGER_FALLING
to request_threaded_irq():
/* Default to falling edge if no platform data provided */
irqflags = data-pdata ? data-pdata-irqflags : IRQF_TRIGGER_FALLING;
error = request_threaded_irq(client-irq, NULL, mxt_interrupt,
irqflags | IRQF_ONESHOT,
client-name, data);
The above code is wrong since is overwriting the edge/level type flags set
by OF when parsing the interrupts property so you have to use the
expected IRQ flags in your DTS.
b) pin-function 0xf instead of 0x0:
The pin-function 0x0 is GPIO input while 0xf is GPIO IRQ. Usually
Re: [PATCH 1/2] ARM: exynos_defconfig: Enable Control Groups support
Am 27.08.2014 13:02, schrieb Javier Martinez Canillas: systemd needs control groups support to be enabled in the kernel so let's enable it by default since is quite likely that a user-space with systemd will be used. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- arch/arm/configs/exynos_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 676c744..590abde 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -1,6 +1,7 @@ CONFIG_SYSVIPC=y CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y +CONFIG_CGROUPS=y CONFIG_BLK_DEV_INITRD=y CONFIG_KALLSYMS_ALL=y CONFIG_MODULES=y CONFIG_FHANDLE=y is also needed for systemd to get a serial console. multi_v7 has that already. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad
Hi Javier,
Am 26.08.2014 17:28, schrieb Javier Martinez Canillas:
From: Sjoerd Simons sjoerd.sim...@collabora.co.uk
The Peach Pit board has an Atmel maXTouch trackpad device.
Add the needed Device Tree nodes to support it.
This Device Tree change is based on the Chrome OS 3.8 tree
but adapted to use the mainline Atmel maXTouch DT binding.
Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk
[javier.martinez: added linux,gpio-keymap property and changed IRQ type]
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v1:
- Change trackpad IRQ pad function from 0x0 (GPIO input) to 0xf (GPIO IRQ).
suggested by Tomasz Figa.
- Remove BTN_TOOL_* from linux,gpio-keymap property since those are set
by input mt core if INPUT_MT_POINTER is set. Suggested by Nick Dyer.
- Use correct values for linux,gpio-keymap property. Suggested by Nick
Dyer.
- Remove support for Peach Pi board since it uses a different Atmel touchpad
that requires an Atmel object protocol (T100) not supported by the driver.
- Use IRQ type constants from dt-bindings/interrupt-controller/irq.h
instead
of magic numbers. Suggested by Andreas Farber.
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 31
++
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..e4f82d5 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -11,6 +11,7 @@
/dts-v1/;
#include dt-bindings/input/input.h
#include dt-bindings/gpio/gpio.h
+#include dt-bindings/interrupt-controller/irq.h
#include exynos5420.dtsi
/ {
@@ -157,6 +158,29 @@
};
};
+hsi2c_8 {
+ status = okay;
+ clock-frequency = 333000;
+
+ trackpad@4b {
+ compatible=atmel,maxtouch;
+ reg=0x4b;
+ interrupt-parent=gpx1;
+ interrupts=1 IRQ_TYPE_EDGE_FALLING;
Nit: Here's a style break (4x spaces around '=' missing).
+ wakeup-source;
+ pinctrl-names = default;
+ pinctrl-0 = trackpad_irq;
+ linux,gpio-keymap = KEY_RESERVED
+ KEY_RESERVED
+ 0 /* GPIO 0 */
+ 0 /* GPIO 1 */
+ 0 /* GPIO 2 */
+ BTN_LEFT /* GPIO 3 */
+ KEY_RESERVED
+ KEY_RESERVED ;
+ };
Coincidentally, I experimentally came up with a very similar DT node for
Spring the weekend:
+ trackpad@4b {
+ compatible = atmel,maxtouch;
+ reg = 0x4b;
+ interrupt-parent = gpx1;
+ interrupts = 2 IRQ_TYPE_NONE;
+ pinctrl-names = default;
+ pinctrl-0 = trackpad_irq;
+ linux,gpio-keymap = KEY_RESERVED
+KEY_RESERVED
+KEY_RESERVED
+KEY_RESERVED
+KEY_RESERVED
+BTN_LEFT;
+ wakeup-source;
+ };
0 == KEY_RESERVED, so you can consistently use it for GPIO 0-2, too. :)
I probably should add the two trailing _RESERVEDs, too?
With my above snippet I got an awful lot of Interrupt triggered but
zero messages warnings (which I simply commented out as quickfix).
Is that why you are using _EDGE_FALLING? Or pin-function 0xf?
(In my case the ChromeOS DT had IRQ_TYPE_NONE and pin-function 0x0.)
Regards,
Andreas
+};
+
hsi2c_9 {
status = okay;
clock-frequency = 40;
@@ -249,6 +273,13 @@
samsung,pin-drv = 0;
};
+ trackpad_irq: trackpad-irq {
+ samsung,pins = gpx1-1;
+ samsung,pin-function = 0xf;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+
power_key_irq: power-key-irq {
samsung,pins = gpx1-2;
samsung,pin-function = 0;
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2 v2] ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
Am 26.08.2014 09:30, schrieb Sjoerd Simons:
In case the optional dr_mode property isn't set in the dwc3 nodes the
the controller will go into OTG mode iff both USB host and USB gadget
functionality are enabled in the kernel configuration. Unfortunately this
results in USB not working on exynos5420-peach-pit and
exynos5800-peach-pi with such a kernel configuration unless manually
change the mode. To resolve that explicitely configure the dual role
explicitly
mode as host
Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk
---
Changes in v2: alphabetically sort the dts entries
arch/arm/boot/dts/exynos5420-peach-pit.dts | 8
arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
arch/arm/boot/dts/exynos5800-peach-pi.dts | 8
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..29d3a59 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -427,6 +427,14 @@
status = okay;
};
+usbdrd_dwc3_0 {
+ dr_mode = host;
+};
+
+usbdrd_dwc3_1 {
+ dr_mode = host;
+};
+
usbdrd_phy0 {
vbus-supply = usb300_vbus_reg;
};
diff --git a/arch/arm/boot/dts/exynos5420.dtsi
b/arch/arm/boot/dts/exynos5420.dtsi
index bfe056d..8617a03 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -815,7 +815,7 @@
#size-cells = 1;
ranges;
- dwc3 {
+ usbdrd_dwc3_0: dwc3 {
compatible = snps,dwc3;
reg = 0x1200 0x1;
interrupts = 0 72 0;
@@ -841,7 +841,7 @@
#size-cells = 1;
ranges;
- dwc3 {
+ usbdrd_dwc3_1: dwc3 {
compatible = snps,dwc3;
reg = 0x1240 0x1;
interrupts = 0 73 0;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..2064550 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -425,6 +425,14 @@
status = okay;
};
+usbdrd_dwc3_0 {
+ dr_mode = host;
+};
+
+usbdrd_dwc3_1 {
+ dr_mode = host;
+};
+
usbdrd_phy0 {
vbus-supply = usb300_vbus_reg;
};
Thanks,
Reviewed-by: Andreas Färber afaer...@suse.de
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2 v2] ARM: exynos_defconfig: enable USB gadget support
Am 26.08.2014 09:30, schrieb Sjoerd Simons: Enable USB gadget support without support for any specific gadgets to more easily catch cases where a devices dts doesn't specify the usb controllers dr_mode while it should. Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk --- Changes in v2: none arch/arm/configs/exynos_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index fc7d168..3664120 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -54,6 +54,7 @@ CONFIG_SMSC911X=y CONFIG_USB_USBNET=y CONFIG_USB_NET_SMSC75XX=y CONFIG_USB_NET_SMSC95XX=y +CONFIG_USB_GADGET=y Do we also need CONFIG_USB_DWC3_DUAL_ROLE=y? The default seemed to be CONFIG_USB_DWC3_HOST. CONFIG_INPUT_EVDEV=y CONFIG_KEYBOARD_GPIO=y CONFIG_KEYBOARD_CROS_EC=y Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2 v2] Fix Exynos peach USB on kernels with USB Gadget support
Hi, Am 26.08.2014 09:30, schrieb Sjoerd Simons: I suspect other boards base using exynos5420/5800 might need the similar fixes (Arndale Octa and Samsung SMDK5420) to their dts files, so would be great if folks with those board could verify this. usbdrd_dwc3_1 is indeed required for the Arndale Octa. Not sure about 0. I tested my attaching a USB 3.0 disk - is there an easier way to tell? Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/1] ARM: exynos_defconfig: Enable options for display panel support
Hi, Am 25.08.2014 13:43, schrieb Bartlomiej Zolnierkiewicz: On Monday, August 25, 2014 10:45:36 AM Javier Martinez Canillas wrote: Many Exynos devices have a display panel. Most of them just have a simple panel while others have more complex configurations that requires an embedded DisplayPort (eDP) to LVDS bridges. This patch enables the following features to be built in the kernel image to suport both setups: - Direct Rendering Manager (DRM) - DRM bridge registration and lookup framework - Parade ps8622/ps8625 eDP/LVDS bridge - NXP ptn3460 eDP/LVDS bridge - Exynos Fully Interactive Mobile Display controller (FIMD) - Panel registration and lookup framework - Simple panels - Backlight LCD device support Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Kevin Hilman khil...@linaro.org Could you please also do corresponding update to multi_v7_defconfig? As was mentioned in v1 (but now below), some of these options depend on patches yet to be respun and be accepted into drm, so I would consider this an RFC patch and suggest to wait with multi_v7. It could of course be split, as CONFIG_DRM_EXYNOS* and backlight parts are certainly okay. Regards, Andreas Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics --- Changes since v1: - Forgot to enable ptn3460 eDP/LVDS bridge config option which is used for some boards (e.g: Exynos5250 Snow). arch/arm/configs/exynos_defconfig | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 676c744..d6d1f7c 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -101,11 +101,26 @@ CONFIG_REGULATOR_S2MPA01=y CONFIG_REGULATOR_S2MPS11=y CONFIG_REGULATOR_S5M8767=y CONFIG_REGULATOR_TPS65090=y +CONFIG_DRM=y +CONFIG_DRM_BRIDGE=y +CONFIG_DRM_PTN3460=y +CONFIG_DRM_PS8622=y +CONFIG_DRM_EXYNOS=y +CONFIG_DRM_EXYNOS_FIMD=y +CONFIG_DRM_EXYNOS_DP=y +CONFIG_DRM_PANEL=y +CONFIG_DRM_PANEL_SIMPLE=y CONFIG_FB=y CONFIG_FB_MODE_HELPERS=y CONFIG_FB_SIMPLE=y CONFIG_EXYNOS_VIDEO=y CONFIG_EXYNOS_MIPI_DSI=y +CONFIG_BACKLIGHT_LCD_SUPPORT=y +CONFIG_LCD_CLASS_DEVICE=y +CONFIG_LCD_PLATFORM=y +CONFIG_BACKLIGHT_CLASS_DEVICE=y +CONFIG_BACKLIGHT_GENERIC=y +CONFIG_BACKLIGHT_PWM=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=y CONFIG_FONT_7x14=y -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi
Seeing a Reviewed-by, I'm recording comments from another thread so that
they don't get forgotten:
Am 25.07.2014 21:44, schrieb Ajay Kumar:
Add DT nodes for panel-simple auo,b133htn01 panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add panel phandle needed by dp to enable display on peach_pi.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..5342638 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -28,11 +28,13 @@
i2c20 = /spi@12d4/cros-ec@0/i2c-tunnel;
};
- backlight {
+ backlight: backlight {
compatible = pwm-backlight;
pwms = pwm 0 100 0;
brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
default-brightness-level = 7;
+ enable-gpios = gpx2 2 0;
+ power-supply = tps65090_fet1;
pinctrl-0 = pwm0_out;
pinctrl-names = default;
};
@@ -98,6 +100,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
Just panel? (AF)
+ compatible = auo,b133htn01, simple-panel;
Drop simple-panel (Thierry)
+ power-supply = tps65090_fet6;
+ backlight = backlight;
+ };
};
dp {
@@ -111,22 +119,7 @@
samsung,link-rate = 0x0a;
samsung,lane-count = 2;
samsung,hpd-gpio = gpx2 6 0;
-
- display-timings {
- native-mode = timing1;
-
- timing1: timing@1 {
- clock-frequency = 15066;
- hactive = 1920;
- vactive = 1080;
- hfront-porch = 60;
- hback-porch = 172;
- hsync-len = 80;
- vback-porch = 25;
- vfront-porch = 10;
- vsync-len = 10;
- };
- };
+ panel = panel;
};
fimd {
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit
Am 25.07.2014 21:44, schrieb Ajay Kumar:
Add DT nodes for ps8622 bridge chip and panel-simple panel.
simple-panel
Add backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on peach_pit.
Note that peach_pi[t] is inconsistent with the file names being
peach-pi[t] here and in the two subjects.
Note that, peach_pit doesn't support chunghwa,claa101wb01 panel,
but still we choose to reuse the binding since chunghwa,claa101wb01
has similar LCD timings.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 36
+++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..79beba8 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -30,11 +30,12 @@
i2c20 = /spi@12d4/cros-ec@0/i2c-tunnel;
};
- backlight {
+ backlight: backlight {
compatible = pwm-backlight;
pwms = pwm 0 100 0;
brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
default-brightness-level = 7;
+ power-supply = tps65090_fet1;
pinctrl-0 = pwm0_out;
pinctrl-names = default;
};
@@ -100,6 +101,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
Just panel? (AF)
+ compatible = chunghwa,claa101wb01, simple-panel;
Drop simple-panel (Thierry)
+ power-supply = tps65090_fet6;
+ backlight = backlight;
+ };
};
dp {
@@ -113,22 +120,7 @@
samsung,link-rate = 0x06;
samsung,lane-count = 2;
samsung,hpd-gpio = gpx2 6 0;
-
- display-timings {
- native-mode = timing1;
-
- timing1: timing@1 {
- clock-frequency = 70589280;
- hactive = 1366;
- vactive = 768;
- hfront-porch = 40;
- hback-porch = 40;
- hsync-len = 32;
- vback-porch = 10;
- vfront-porch = 12;
- vsync-len = 6;
- };
- };
+ bridge = ps8625;
};
fimd {
@@ -155,6 +147,16 @@
pinctrl-names = default;
pinctrl-0 = max98090_irq;
};
+
+ ps8625: ps8625-bridge@48 {
lvds-bridge? (AF)
+ compatible = parade,ps8625;
+ reg = 0x48;
+ sleep-gpios = gpx3 5 0;
+ reset-gpios = gpy7 7 0;
+ lane-count = 2;
+ panel = panel;
+ backlight = backlight;
+ };
};
hsi2c_9 {
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] ARM: dts: Add DT changes for display on snow
Am 25.07.2014 21:44, schrieb Ajay Kumar:
Add DT nodes for ptn3460 bridge chip and panel-simple panel.
simple-panel
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add bridge phandle needed by dp to enable display on snow.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
arch/arm/boot/dts/exynos5250-snow.dts | 40
+
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index 6c36d41..f57f993 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -270,7 +270,7 @@
dcdc3 {
ti,enable-ext-control;
};
- fet1 {
+ fet1: fet1 {
regulator-name = vcd_led;
ti,overcurrent-wait = 3;
};
@@ -293,7 +293,7 @@
regulator-always-on;
ti,overcurrent-wait = 3;
};
- fet6 {
+ fet6: fet6 {
regulator-name = lcd_vdd;
ti,overcurrent-wait = 3;
};
@@ -342,6 +342,15 @@
pinctrl-0 = max98095_en;
pinctrl-names = default;
};
+
+ ptn3460: ptn3460-bridge@20 {
lvds-bridge? (AF)
+ compatible = nxp,ptn3460;
+ reg = 0x20;
+ powerdown-gpios = gpy2 5 0;
+ reset-gpios = gpx1 5 0;
+ edid-emulation = 5;
+ panel = panel;
+ };
};
i2s0: i2s@0383 {
@@ -389,11 +398,13 @@
vdd_pll-supply = ldo8_reg;
};
- backlight {
+ backlight: backlight {
compatible = pwm-backlight;
pwms = pwm 0 100 0;
brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
default-brightness-level = 7;
+ enable-gpios = gpx3 0 0;
+ power-supply = fet1;
pinctrl-0 = pwm0_out;
pinctrl-names = default;
};
@@ -403,6 +414,12 @@
samsung,invert-vclk;
};
+ panel: panel-simple {
Just panel? (AF)
+ compatible = simple-panel;
Use something more concrete than simple-panel? (Thierry)
+ power-supply = fet6;
+ backlight = backlight;
+ };
+
dp-controller@145B {
status = okay;
pinctrl-names = default;
@@ -414,21 +431,6 @@
samsung,link-rate = 0x0a;
samsung,lane-count = 2;
samsung,hpd-gpio = gpx0 7 0;
-
- display-timings {
- native-mode = timing1;
-
- timing1: timing@1 {
- clock-frequency = 70589280;
- hactive = 1366;
- vactive = 768;
- hfront-porch = 40;
- hback-porch = 40;
- hsync-len = 32;
- vback-porch = 10;
- vfront-porch = 12;
- vsync-len = 6;
- };
- };
+ bridge = ptn3460;
};
};
This patch will trivially conflict with my Snow cleanup [1]; ptn3460
would go into the appropriate i2c_* and this hunk into dp then.
Regards,
Andreas
[1] https://patchwork.kernel.org/patch/4664801/
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] phy: exynos5-usbdrd: Add MODULE_DEVICE_TABLE entry
Hi,
Am 22.08.2014 15:58, schrieb Sjoerd Simons:
Add a MODULE_DEVICE_TABLE call for OF match tables. This allows the
module to be autoloaded based on devicetree information.
Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk
---
drivers/phy/phy-exynos5-usbdrd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/phy-exynos5-usbdrd.c
b/drivers/phy/phy-exynos5-usbdrd.c
index b05302b..e9a0f54 100644
--- a/drivers/phy/phy-exynos5-usbdrd.c
+++ b/drivers/phy/phy-exynos5-usbdrd.c
@@ -542,6 +542,7 @@ static const struct of_device_id
exynos5_usbdrd_phy_of_match[] = {
},
{ },
};
+MODULE_DEVICE_TABLE (of, exynos5_usbdrd_phy_of_match);
Nit: Probably there should be no space before '('?
static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
{
Otherwise certainly sensible. I ran into another such case myself.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 04/11] arm: Support restart through restart handler call chain
Am 22.08.2014 04:19, schrieb Guenter Roeck:
On Fri, Aug 22, 2014 at 03:32:42AM +0200, Andreas Färber wrote:
Am 20.08.2014 02:45, schrieb Guenter Roeck:
The kernel core now supports a restart handler call chain for system
restart functions.
With this change, the arm_pm_restart callback is now optional, so
drop its initialization and check if it is set before calling it.
Only call the kernel restart handler if arm_pm_restart is not set.
[...]
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 81ef686..ea279f7 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -114,17 +114,13 @@ void soft_restart(unsigned long addr)
BUG();
}
-static void null_restart(enum reboot_mode reboot_mode, const char *cmd)
-{
-}
-
/*
* Function pointers to optional machine specific functions
*/
void (*pm_power_off)(void);
EXPORT_SYMBOL(pm_power_off);
-void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd) =
null_restart;
+void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd);
Stupid newbie question maybe, but isn't this variable uninitialized now,
like any non-static variable in C99? Or does the kernel assure that all
such fields are zero-initialized?
It is initialized with NULL, like all other global and static variables in the
kernel (and like pm_power_off a few lines above).
Thanks for the explanation. In that case FWIW
Reviewed-by: Andreas Färber afaer...@suse.de
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 3/4] usb: hcd: Caibrate PHY post hcd reset
Hi, s/Caibrate/Calibrate/ Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7] ARM: dts: Prepare node labels for exynos5250
Am 22.08.2014 12:49, schrieb Kukjin Kim:
Andreas Färber wrote:
Allows them to be extended by reference.
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v6 - v7:
* Dropped uart* labels (Tomasz Figa)
v6: Split off from Snow/SMDK cleanups (Doug Anderson)
arch/arm/boot/dts/exynos5250.dtsi | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 492e1eff37bd..42eafd19cfb2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -218,7 +218,7 @@
clock-names = fimg2d;
};
-codec@1100 {
+mfc: codec@1100 {
compatible = samsung,mfc-v6;
reg = 0x1100 0x1;
interrupts = 0 96 0;
@@ -227,7 +227,7 @@
clock-names = mfc;
};
-rtc@101E {
+rtc: rtc@101E {
clocks = clock CLK_RTC;
clock-names = rtc;
status = disabled;
@@ -261,7 +261,7 @@
clock-names = uart, clk_uart_baud0;
};
-sata@122F {
+sata: sata@122F {
compatible = snps,dwc-ahci;
samsung,sata-freq = 66;
reg = 0x122F 0x1ff;
@@ -573,7 +573,7 @@
#phy-cells = 1;
};
-usb@1211 {
+ehci: usb@1211 {
I'm not sure which one is recommended between above and ehci: ehci@1211
{
compatible = samsung,exynos4210-ehci;
reg = 0x1211 0x100;
interrupts = 0 71 0;
@@ -588,7 +588,7 @@
};
};
-usb@1212 {
+ohci: usb@1212 {
Same as above...
A quick git-grep in v3.16.1 shows both ways used in arch/arm/boot/dts/:
usb@: 232
xhci@: 0
ehci@: 41
ohci@: 60
uhci@: 7
compatible = samsung,exynos4210-ohci;
reg = 0x1212 0x100;
interrupts = 0 71 0;
@@ -725,7 +725,7 @@
clock-names = gscl;
};
-hdmi {
+hdmi: hdmi {
Should be
+ hdmi: hdmi@1453 { ?
Actually, without applying this patch and my follow-up cleanups strictly
using these new labels, we can't rename any of the nodes here, since it
would break the derived .dts files. It was specifically requested in v5
to make this patch here separate from subsequent uses of the new labels
for the benefit of cherry-picking.
So since you don't seem to disagree with the label names that I add
here, I consider renaming nodes outside the scope of this patch.
+1 for reflecting the reg address in the unit address of the hdmi node
as a follow-up to the refactorings, if that does not break any driver
assumptions.
Regards,
Andreas
compatible = samsung,exynos4212-hdmi;
reg = 0x1453 0x7;
interrupts = 0 95 0;
@@ -751,14 +751,14 @@
#phy-cells = 0;
};
-dp-controller@145B {
+dp: dp-controller@145B {
clocks = clock CLK_DP;
clock-names = dp;
phys = dp_phy;
phy-names = dp;
};
-fimd@1440 {
+fimd: fimd@1440 {
clocks = clock CLK_SCLK_FIMD1, clock CLK_FIMD1;
clock-names = sclk_fimd, fimd;
};
--
2.0.4
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/5] ARM: dts: remove old USB2 PHY node hook for Arndale
Am 22.08.2014 18:59, schrieb Bartlomiej Zolnierkiewicz:
drivers/usb/phy/phy-samsung-usb2 driver got replaced by
drivers/phy/phy-samsung-usb2 one. Remove the leftover hook
from Arndale dts file.
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Acked-by: Kyungmin Park kyungmin.p...@samsung.com
Reviewed-by: Vivek Gautam gautam.vi...@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
Acked-by: Kishon Vijay Abraham I kis...@ti.com
Cc: Mark Brown broo...@linaro.org
Cc: Kamil Debski k.deb...@samsung.com
---
arch/arm/boot/dts/exynos5250-arndale.dts | 4
1 file changed, 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
b/arch/arm/boot/dts/exynos5250-arndale.dts
index d0de1f5..dad8f9b 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -570,8 +570,4 @@
connect-gpios = gpd1 7 1;
};
};
-
- usb@1211 {
- usb-phy = usb2_phy;
- };
};
This will trivially conflict with my exynos5250 cleanups in the Spring
series: ehci {...} there.
https://patchwork.kernel.org/patch/4664751/
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: exynos: Explicitly set dr_mode on peach-pit and peach-pi
Hi,
Am 22.08.2014 22:57, schrieb Sjoerd Simons:
In case the optional dr_mode property isn't set in the dwc3 nodes the
the controller will go into OTG mode iff both USB host and USB gadget
functionality are enabled in the kernel configuration. Unfortunately this
results in USB not working on exynos5420-peach-pit and
exynos5800-peach-pi with such a kernel configuration unless manually
change the mode. To resolve that explicitely configure the dual role
mode as host
Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 8
arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
arch/arm/boot/dts/exynos5800-peach-pi.dts | 8
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..6c22610 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -427,10 +427,18 @@
status = okay;
};
+usbdrd_dwc3_0 {
+ dr_mode = host;
+};
+
usbdrd_phy0 {
vbus-supply = usb300_vbus_reg;
};
+usbdrd_dwc3_1 {
+ dr_mode = host;
+};
The sort order should be alphabetical here, which means dwc before phy.
+
usbdrd_phy1 {
vbus-supply = usb301_vbus_reg;
};
[...]
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..166b352 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -425,10 +425,18 @@
status = okay;
};
+usbdrd_dwc3_0 {
+ dr_mode = host;
+};
+
usbdrd_phy0 {
vbus-supply = usb300_vbus_reg;
};
+usbdrd_dwc3_1 {
+ dr_mode = host;
+};
Dito.
+
usbdrd_phy1 {
vbus-supply = usb301_vbus_reg;
};
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv3] thermal: exynos: Add support for TRIM_RELOAD feature at Exynos3250
Hello,
Am 21.08.2014 03:38, schrieb Chanwoo Choi:
On 08/20/2014 10:38 PM, edubez...@gmail.com wrote:
On Tue, Aug 19, 2014 at 7:52 PM, Chanwoo Choi cw00.c...@samsung.com wrote:
diff --git a/drivers/thermal/samsung/exynos_tmu_data.c
b/drivers/thermal/samsung/exynos_tmu_data.c
index aa8e0de..8cd609c 100644
--- a/drivers/thermal/samsung/exynos_tmu_data.c
+++ b/drivers/thermal/samsung/exynos_tmu_data.c
@@ -95,6 +95,8 @@ static const struct exynos_tmu_registers
exynos3250_tmu_registers = {
.triminfo_data = EXYNOS_TMU_REG_TRIMINFO,
.triminfo_25_shift = EXYNOS_TRIMINFO_25_SHIFT,
.triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,
+ .triminfo_ctrl[0] = EXYNOS_TMU_TRIMINFO_CON1,
+ .triminfo_ctrl[1] = EXYNOS_TMU_TRIMINFO_CON2,
.tmu_ctrl = EXYNOS_TMU_REG_CONTROL,
.test_mux_addr_shift = EXYNOS4412_MUX_ADDR_SHIFT,
.buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT,
@@ -160,8 +162,11 @@ static const struct exynos_tmu_registers
exynos3250_tmu_registers = {
.temp_level = 95, \
}, \
.freq_tab_count = 2, \
+ .triminfo_reload[0] = 0x1, \
+ .triminfo_reload[1] = 0x11, \
What does 0x1 mean? How about 0x11?
The bit of 'RELOAD' field in TRIMINFO_CONTROL register is [0].
and The bit of 'AC Time' field in TRIMINFO_CONTROL register is [5:4].
0x1 means that set RELOAD field.
0x11 means that set RELOAD field and ACTIME field.
Might be a good idea to use #defines for 0x1 and 0x10 then?
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 04/11] arm: Support restart through restart handler call chain
Hi,
Am 20.08.2014 02:45, schrieb Guenter Roeck:
The kernel core now supports a restart handler call chain for system
restart functions.
With this change, the arm_pm_restart callback is now optional, so
drop its initialization and check if it is set before calling it.
Only call the kernel restart handler if arm_pm_restart is not set.
[...]
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 81ef686..ea279f7 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -114,17 +114,13 @@ void soft_restart(unsigned long addr)
BUG();
}
-static void null_restart(enum reboot_mode reboot_mode, const char *cmd)
-{
-}
-
/*
* Function pointers to optional machine specific functions
*/
void (*pm_power_off)(void);
EXPORT_SYMBOL(pm_power_off);
-void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd) =
null_restart;
+void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd);
Stupid newbie question maybe, but isn't this variable uninitialized now,
like any non-static variable in C99? Or does the kernel assure that all
such fields are zero-initialized?
EXPORT_SYMBOL_GPL(arm_pm_restart);
(This doesn't seem to be affecting the value of arm_pm_restart, just
redeclaring it extern and adding further derived symbols.)
/*
@@ -230,7 +226,10 @@ void machine_restart(char *cmd)
local_irq_disable();
smp_send_stop();
- arm_pm_restart(reboot_mode, cmd);
+ if (arm_pm_restart)
Here we seem to be relying on arm_pm_restart to be NULL when not
callable. I.e., wondering whether it's ruled out that the following line
is triggered due to non-zero garbage in arm_pm_restart?
Thanks,
Andreas
+ arm_pm_restart(reboot_mode, cmd);
+ else
+ do_kernel_restart(cmd);
/* Give a grace period for failure to restart of 1s */
mdelay(1000);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree
Kukjin,
Am 04.08.2014 17:22, schrieb Doug Anderson:
On Fri, Aug 1, 2014 at 5:52 PM, Andreas Färber afaer...@suse.de wrote:
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
new file mode 100644
index ..f5566f84d885
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
[...]
+ usb-hub {
+ compatible = smsc,usb3503a;
+ reset-gpios = gpe1 0 GPIO_ACTIVE_LOW;
+ };
Last I remember hearing about this, Julius said that the generic
usb-hub driver didn't work right for asserting the reset line.
Something about needing the reset at a very specific time in the USB
enumeration, I think. Maybe it's somehow been fixed since then and
that's why it's working?
Also: you technically should have a pinctrl-0 and pinctrl-names
referencing hsic_reset below to make sure the pin gets initted
properly.
[...]
Technically the missing pinctrl for hsic-reset is something that out
to be fixed and we should figure out whether the reset line is
actually working properly anyway. ...but I think this has been
through enough spins and any additional fixup can happen later, so you
can add my:
Reviewed-by: Doug Anderson diand...@chromium.org
I wonder how to proceed now... Are you planning to continue inserting my
remaining snow/smdk/arndale refactoring patches [1,2,3,4] before the mmc
slot node refactoring on v3.18-next/dt-samsung branch?
I.e., should I send out a v7 rebasing either the remainder or just
Spring on top of your for-next, or should I just post new follow-up
patches to this series and wait?
I've prepared and successfully tested a patch adding the pinctrl Doug
requested above. Additionally, I have another follow-up ready, adding a
gmt,g781 temperature sensor (with v3.17-rc1 that actually works).
Also I understood that Javier is waiting for my remaining Snow bits to
be applied before sending out further Snow DT cleanups/fixes of his.
Thanks,
Andreas
[1] https://patchwork.kernel.org/patch/4664881/
[2] https://patchwork.kernel.org/patch/4664801/
[3] https://patchwork.kernel.org/patch/4664731/
[4] https://patchwork.kernel.org/patch/4664751/
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250
Am 02.08.2014 15:00, schrieb Andreas Färber:
Am 02.08.2014 14:19, schrieb Tomasz Figa:
Andreas,
Ehh, one more thing. It looks like my memory is playing tricks on me.
Please see inline.
On 02.08.2014 02:52, Andreas Färber wrote:
Allows them to be extended by reference.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v6: Split off from Snow/SMDK cleanups (Doug Anderson)
[snip]
- serial@12C0 {
+ uart0: serial@12C0 {
clocks = clock CLK_UART0, clock CLK_SCLK_UART0;
clock-names = uart, clk_uart_baud0;
};
- serial@12C1 {
+ uart1: serial@12C1 {
clocks = clock CLK_UART1, clock CLK_SCLK_UART1;
clock-names = uart, clk_uart_baud0;
};
- serial@12C2 {
+ uart2: serial@12C2 {
clocks = clock CLK_UART2, clock CLK_SCLK_UART2;
clock-names = uart, clk_uart_baud0;
};
- serial@12C3 {
+ uart3: serial@12C3 {
clocks = clock CLK_UART3, clock CLK_SCLK_UART3;
clock-names = uart, clk_uart_baud0;
};
I forgot about a series [1] that went through tty tree, which is going
to conflict with this patch. It already adds labels to uart nodes in
serial_X format. I don't really remember why I went with this format for
Exynos SoCs and with uartX for older ones...
[1]
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts?id=1e64f48ea7c59fb94acd7551dd9fa68b8a752efc
I doubt that I'll manage to resend another time today, [...]
Sorry, forgot about this. Done now. v7 as individual reply.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v7] ARM: dts: Prepare node labels for exynos5250
Allows them to be extended by reference.
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v6 - v7:
* Dropped uart* labels (Tomasz Figa)
v6: Split off from Snow/SMDK cleanups (Doug Anderson)
arch/arm/boot/dts/exynos5250.dtsi | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 492e1eff37bd..42eafd19cfb2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -218,7 +218,7 @@
clock-names = fimg2d;
};
- codec@1100 {
+ mfc: codec@1100 {
compatible = samsung,mfc-v6;
reg = 0x1100 0x1;
interrupts = 0 96 0;
@@ -227,7 +227,7 @@
clock-names = mfc;
};
- rtc@101E {
+ rtc: rtc@101E {
clocks = clock CLK_RTC;
clock-names = rtc;
status = disabled;
@@ -261,7 +261,7 @@
clock-names = uart, clk_uart_baud0;
};
- sata@122F {
+ sata: sata@122F {
compatible = snps,dwc-ahci;
samsung,sata-freq = 66;
reg = 0x122F 0x1ff;
@@ -573,7 +573,7 @@
#phy-cells = 1;
};
- usb@1211 {
+ ehci: usb@1211 {
compatible = samsung,exynos4210-ehci;
reg = 0x1211 0x100;
interrupts = 0 71 0;
@@ -588,7 +588,7 @@
};
};
- usb@1212 {
+ ohci: usb@1212 {
compatible = samsung,exynos4210-ohci;
reg = 0x1212 0x100;
interrupts = 0 71 0;
@@ -725,7 +725,7 @@
clock-names = gscl;
};
- hdmi {
+ hdmi: hdmi {
compatible = samsung,exynos4212-hdmi;
reg = 0x1453 0x7;
interrupts = 0 95 0;
@@ -751,14 +751,14 @@
#phy-cells = 0;
};
- dp-controller@145B {
+ dp: dp-controller@145B {
clocks = clock CLK_DP;
clock-names = dp;
phys = dp_phy;
phy-names = dp;
};
- fimd@1440 {
+ fimd: fimd@1440 {
clocks = clock CLK_SCLK_FIMD1, clock CLK_FIMD1;
clock-names = sclk_fimd, fimd;
};
--
2.0.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem
Hi Marek and Inki, Am 19.08.2014 08:07, schrieb Marek Szyprowski: On 2014-08-19 01:32, Joerg Roedel wrote: On Tue, Aug 05, 2014 at 12:47:28PM +0200, Marek Szyprowski wrote: [...] 33 files changed, 1016 insertions(+), 356 deletions(-) This touches a lot of non-iommu stuff. What is your strategy on getting this in, do you plan to get the non-iommu changes merged first or do you want to collect the respective Acks and merge this all through one tree? Those patches are posted as one patchset mainly to demonstrate how to get everything to work together. I also posted this as a single patch series to get some feedback from other iommu developers, especially all those involved in the generic iommu dt bindings. For merging, I will split them into smaller series and try to get respective acks. I'm working on 5250 based Spring Chromebook and noticed that v3.17-rc1 got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=y my machine stops booting. So I'm wondering, is any of this a fix for 3.17, or is all of this unrelated -next material? Also, are you or someone working on the respective DT changes for Exynos5? Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem
Hi, Am 19.08.2014 14:01, schrieb Marek Szyprowski: On 2014-08-19 13:39, Andreas Färber wrote: I'm working on 5250 based Spring Chromebook and noticed that v3.17-rc1 got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=y my machine stops booting. So I'm wondering, is any of this a fix for 3.17, or is all of this unrelated -next material? This is probably a side effect of patch 3170447c1f264d51b8d1f3898bf2588588a64fdc (iommu/exynos: Select ARM_DMA_USE_IOMMU). It added selection of ARM_DMA_USE_IOMMU symbol, on which IOMMU support in Exynos DRM subsystem depends. However selecting this symbol is all that this patch does, without providing any code code which implements real support for ARM DMA IOMMU integration, which is needed by Exynos DRM driver. Please disable CONFIG_DRM_EXYNOS_IOMMU in kernel .config and your system should be bootable again. Yes, that's what my report implied. :) I'm bringing this up for -rc2 though: It sounds as if that option should remain unavailable until the required code is in? Thanks. Also, are you or someone working on the respective DT changes for Exynos5? I can prepare DT changes for Exynos5 as well, but first I wanted to clarify if everyone involved in generic IOMMU bindings and Exynos IOMMU driver agrees on my proposal. Sure. I'm updating my old spring-bridge.v6 branch [1] to 3.17-rc1 [2], which involves three drm bridge patches rebased onto the new drm panel prepare/unprepare infrastructure plus two LVDS DT patches in addition to the IOMMU patches. That old branch included DT changes for 5250 in ARM: dts: add System MMU nodes of Exynos SoCs, but that'll probably need updating for the new bindings. Regards, Andreas [1] https://github.com/afaerber/linux/commits/spring-bridge.v6 [2] https://github.com/afaerber/linux/commits/spring-next -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards
Hi Javier,
Am 19.08.2014 17:08, schrieb Javier Martinez Canillas:
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 8e50042..5b9dbb9 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -547,6 +547,8 @@
};
mmc_2 {
+ vmmc-supply = tps65090_fet4;
+ vqmmc-supply = vqmmc_sdcard;
status = okay;
num-slots = 1;
supports-highspeed;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 939f91c..dcac443 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -545,6 +545,8 @@
};
mmc_2 {
+ vmmc-supply = tps65090_fet4;
+ vqmmc-supply = vqmmc_sdcard;
status = okay;
num-slots = 1;
supports-highspeed;
A convention that I picked up was to place overridden status property
first. Do your new properties really need to go before that?
Also, if you look at today's for-next, then supports-highspeed should be
cap-{sd,mmc}-highspeed, so it may be worth to rebase.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] ARM: dts: Add Peach Pit and Pi dts entry for max77802 PMIC
Am 19.08.2014 17:08, schrieb Javier Martinez Canillas:
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..8619d58 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -144,6 +144,339 @@
ddc = i2c_2;
};
+hsi2c_4 {
+ status = okay;
+ clock-frequency = 40;
+
+ max77802-pmic@9 {
+ compatible = maxim,max77802;
+ interrupt-parent = gpx3;
+ interrupts = 1 0;
1 IRQ_TYPE_NONE?
[...]
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..f753eae 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -142,6 +142,339 @@
ddc = i2c_2;
};
+hsi2c_4 {
+ status = okay;
+ clock-frequency = 40;
+
+ max77802-pmic@9 {
+ compatible = maxim,max77802;
+ interrupt-parent = gpx3;
+ interrupts = 1 0;
Dito?
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv10 3/5] ARM: dts: exynos: unuse the slot-node and deprecate the supports-highspeed for dw-mmc
Hi Jaehoon, Am 18.08.2014 14:23, schrieb Jaehoon Chung: Socfpga and Rockchip were queued into each SoC tree. I want to know whether this patch is queued or not into Samsung-Soc tree. Do you have any other plan for this patch? It isn't applied in his tree: http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/ In fact Kukjin has not applied any patches for 3 weeks now, which likely means he's on vacation. I am hoping he will review this and the other pending conflicting patches to decide on a merge order and fix any trivial conflicts himself. ;) Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv10 3/5] ARM: dts: exynos: unuse the slot-node and deprecate the supports-highspeed for dw-mmc
Am 18.08.2014 18:54, schrieb Kukjin Kim: On 08/18/14 09:10, Andreas Färber wrote: Hi Jaehoon, Am 18.08.2014 14:23, schrieb Jaehoon Chung: Socfpga and Rockchip were queued into each SoC tree. I want to know whether this patch is queued or not into Samsung-Soc tree. Do you have any other plan for this patch? It isn't applied in his tree: http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/ In fact Kukjin has not applied any patches for 3 weeks now, which likely means he's on vacation. I am hoping he will review this and the other pending conflicting patches to decide on a merge order and fix any trivial conflicts himself. ;) Oh, I thought it has been queued in previous merge window with my ack. OK, I've applied this in my tree for 3.18. So, are you dropping the snow mmc pinctrl patch Doug asked you to queue before this one, and are you merging this with my exynos5250 cros-common/style cleanups yourself or do I need yet another respin? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow
Hi, Am 18.08.2014 22:03, schrieb Kukjin Kim: On 08/18/14 13:48, Tomasz Figa wrote: On 18.08.2014 20:37, Kukjin Kim wrote: On 08/01/14 11:26, Doug Anderson wrote: On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färberafaer...@suse.de wrote: The pinctrl properties should be on the device directly and not on the slot sub-node. Reported-by: Doug Andersondiand...@chromium.org Cc: Jaehoon Chungjh80.ch...@samsung.com Reviewed-by: Tomasz Figat.f...@samsung.com Signed-off-by: Andreas Färberafaer...@suse.de Let's land this one before Jaehoon's, since it was a hidden functionality change in his patch. It will be an easy conflict to resolve when his patch is applied. Sounds good to me, I've applied this before Jaehoon's change. Reviewed-by: Doug Andersondiand...@chromium.org Version 6 of this series has been already posted. However this particular patch has not changed, so it's fine. Oh, got it. Hope this and 2nd should be same with version 6 ;) It is documented as such. :) Others did have changes, of course. I've started looking into rebasing myself: beware that the smdk5250 cleanup has an additional conflict in the spi node (cs-gpios movement). http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/arch/arm/boot/dts/exynos5250-smdk5250.dts?h=v3.18-next/dt-samsungid=e138d4333aa02a3daa12c04192bc5c842bffee74 Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow
Hi Jingoo,
Am 05.08.2014 13:16, schrieb Jingoo Han:
On Saturday, August 02, 2014 5:57 AM, Tomasz Figa wrote:
On 01.08.2014 22:54, Andreas Färber wrote:
Am 01.08.2014 22:33, schrieb Doug Anderson:
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
Spring uses a different GPIO, so this is not a generic SoC piece.
Suggested-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5: New (Tomasz Figa)
Frees dp_hpd for Spring.
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 ---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +
arch/arm/boot/dts/exynos5250-snow.dts | 7 +++
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index 886cfca044ac..ed0e5230514b 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -581,13 +581,6 @@
samsung,pin-pud = 0;
samsung,pin-drv = 0;
};
-
- dp_hpd: dp_hpd {
- samsung,pins = gpx0-7;
- samsung,pin-function = 3;
- samsung,pin-pud = 0;
- samsung,pin-drv = 0;
- };
};
pinctrl@1340 {
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index aaa055ac0fe3..5d30fe1dcda4 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -414,3 +414,12 @@
};
};
};
+
+pinctrl_0 {
+ dp_hpd: dp_hpd {
+ samsung,pins = gpx0-7;
+ samsung,pin-function = 3;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+};
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index c4b0c73c736d..a9a2f2743794 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -547,6 +547,13 @@
};
pinctrl_0 {
+ dp_hpd: dp_hpd {
+ samsung,pins = gpx0-7;
+ samsung,pin-function = 3;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+
NAK. dp_hpd is a generic SoC piece. Pin function 0 and 1 are GPIOs.
Pin function 3 is special function. This pin _is_ the hot plug detect
pin for display port. When it's set as special function 3 it goes
straight into the hot plug logic of the display port controller.
Spring may have had its reasons to detect hot plug events on a GPIO
instead of using this pin, but that doesn't make this pin any less the
hot plug pin.
Please advise how to handle it then: Should there be two different
pinctrl entries (if so, how should it be named?),
IMHO this is the right way. Just name the GPIO variant dp_hpd_gpio.
Hi Andreas Färber,
I agree with Tomasz Figa and Doug Anderson.
Please refer to the following.
1. case: Standard HPD pin is used. (smdk5420)
arch/arm/boot/dts/exynos5420-pinctrl.dts
pinctrl@1340 {
dp_hpd: dp_hpd {
samsung,pins = gpx0-7;
samsung,pin-function = 3;
samsung,pin-pud = 0;
samsung,pin-drv = 0;
};
arch/arm/boot/dts/exynos5420-smdk5420.dts
dp-controller@145B {
pinctrl-names = default;
pinctrl-0 = dp_hpd;
...
2. case: non-standard HPD pin such as GPIO is used. (peach pit)
arch/arm/boot/dts/exynos5420-peach-pit.dts
pinctrl@1340 {
dp_hpd_gpio: dp_hpd_gpio {
samsung,pins = gpx2-6;
samsung,pin-function = 0;
samsung,pin-pud = 3;
samsung,pin-drv = 0;
};
dp-controller@145B {
pinctrl-names = default;
pinctrl-0 = dp_hpd_gpio;
...
samsung,hpd-gpio = gpx2 6 0;
So, you need to follow the second case.
dp_hpd_gpio can be used for Spring board.
I believe I already did so in v6 [0]? Please take a look there and let
me know if you still need anything changed. The label name seems
identical, whereas for the node name I adopted the dashes convention.
Thanks,
Andreas
[0] https://patchwork.kernel.org/patch/4664691/
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree
Am 02.08.2014 07:15, schrieb Doug Anderson:
On Thu, Jul 31, 2014 at 12:40 PM, Tomasz Figa tomasz.f...@gmail.com wrote:
On 31.07.2014 21:20, Andreas Färber wrote:
Am 31.07.2014 21:05, schrieb Tomasz Figa:
On 31.07.2014 18:08, Andreas Färber wrote:
+sd1_clk {
+ samsung,pin-drv = 0;
+};
+
+sd1_cmd {
+ samsung,pin-pud = 3;
+ samsung,pin-drv = 0;
+};
+
+sd1_cd {
+ samsung,pin-drv = 0;
+};
+
+sd1_bus4 {
+ samsung,pin-drv = 0;
+};
Here generic settings are being overridden, so it might be a good idea
to explain why, like with i2c pull-up above.
Snow does not have an explanation either, so please suggest what comment
you'd like to see. Consider me just a user with no specs. :)
Doug, Vincent, someone else?
The comment is just in a different place--it's in the dw_mmc node.
Probably belongs here, though:
/*
* Wifi is a SiP, so can keep drive strengths low
* to reduce EMI.
*/
I did copy such a comment for the MMC node in v5, still present in v6.
Andreas
I guess the cmd line isn't documented. There is no external pull on
the command line and on most boards there is one. Our hardware guys
thought we didn't need it and apparently we don't...
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring
Hi, Am 02.08.2014 06:57, schrieb Doug Anderson: On Fri, Aug 1, 2014 at 7:34 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: On 08/02/2014 02:52 AM, Andreas Färber wrote: Based on the preinstalled 3.8 based ChromeOS kernel and previous 3.15 based attempts by Stephan and me that broke for 3.16, I've prepared a device tree for the HP Chromebook 11 aka Google Spring. v6 renames a node and reverts dp_hpd. Not yet enabled are trackpad, Wifi and sound. I made a comment on patch 05/10 but the rest of the series looks good to me. So for the remaining patches: Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk NOTE: I thought that Tomasz Figa gave you his Reviewed-by on v5 for the whole series as well but I didn't see his tag on the v6 patches. Yes, I thought that too. I assume he's OK with the small changes you made between v5 and v6. In the very least his Reviewed-by could be present on the patches that didn't change between the last two revs. I did add it to the bootargs, GPIO, USB3503 patches. All other patches were either split off or slightly changed due to dp_hpd[_gpio], so I didn't carry it over. Given Javier's review and Tomasz's review and Vincent's comments, I'll probably skip all the work of reviewing the rest of the series unless someone really wants me to. ;) Could you maybe give an Rb or Ab for the actual Spring patch to have the Cc: updated? :) Note that if there's some problem that can't be resolved by selectively dropping patches, I won't be available next week, so you'll either have to provide fixups for Kukjin to squash or wait till I've returned. One thing I've wondered is whether we should put status = disabled on the dp node with some comment, since it's known not to work as is (but better having the data here than leaving it out, I believe). Of course if either of you has input on the discussions on the drm bridge/panel series V6 [1] for how to enable non-simplefb display and iommus, that would be valuable. [1] http://www.spinics.net/lists/linux-samsung-soc/msg35274.html And when one thing is accomplished, I am always quick to look forward: I've taken a quick look at sound nodes: According to 3.8 DT, Spring uses max98089 whereas Snow has 98091, so different codec driver and still lacking DT binding support. I might look into trivially enabling sound/soc/codecs/max98089.c through a maxim,max98089 OF match table once this series lands in linux-next. As for the driver, can we reuse http://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/tree/sound/soc/samsung/snow.c?h=for-next with a google,spring-audio-max98089, or are code changes needed? Both of you mentioned limitations of cros_ec i2c passthrough leading to a forked tps65090 driver downstream - I don't think I can be of help there, as I guess simply copying a driver will not be an option. ;) https://code.google.com/p/chromium/issues/detail?id=391797 For the touchpad it seems DT support has landed in the input tree as atmel,maxtouch. Backporting just that patch does not make it work though. (Tried the rejected pinctrl approach to be on the safe side.) https://code.google.com/p/chromium/issues/detail?id=371114 https://patchwork.kernel.org/patch/3976801/ I thought the internal xhci would have the webcam on it, but I don't see it in lsusb. Does that need some pinctrl or tps65090 regulator? Once appearing on a bus, which driver config option will it need? Many thanks for your support, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250
Am 02.08.2014 14:19, schrieb Tomasz Figa:
Andreas,
Ehh, one more thing. It looks like my memory is playing tricks on me.
Please see inline.
On 02.08.2014 02:52, Andreas Färber wrote:
Allows them to be extended by reference.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v6: Split off from Snow/SMDK cleanups (Doug Anderson)
[snip]
-serial@12C0 {
+uart0: serial@12C0 {
clocks = clock CLK_UART0, clock CLK_SCLK_UART0;
clock-names = uart, clk_uart_baud0;
};
-serial@12C1 {
+uart1: serial@12C1 {
clocks = clock CLK_UART1, clock CLK_SCLK_UART1;
clock-names = uart, clk_uart_baud0;
};
-serial@12C2 {
+uart2: serial@12C2 {
clocks = clock CLK_UART2, clock CLK_SCLK_UART2;
clock-names = uart, clk_uart_baud0;
};
-serial@12C3 {
+uart3: serial@12C3 {
clocks = clock CLK_UART3, clock CLK_SCLK_UART3;
clock-names = uart, clk_uart_baud0;
};
I forgot about a series [1] that went through tty tree, which is going
to conflict with this patch. It already adds labels to uart nodes in
serial_X format. I don't really remember why I went with this format for
Exynos SoCs and with uartX for older ones...
[1]
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts?id=1e64f48ea7c59fb94acd7551dd9fa68b8a752efc
I doubt that I'll manage to resend another time today, so please just
drop those hunks from my patch before applying - I ended up not using
them here.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow
Am 02.08.2014 14:56, schrieb Tomasz Figa:
On 02.08.2014 14:21, Tomasz Figa wrote:
On 02.08.2014 02:52, Andreas Färber wrote:
Use the new style of referencing inherited nodes and use symbolic names.
Reorder one pinctrl node in GPIO order.
Goal is the alignment of all exynos5250 based device trees for comparison.
Suggested-by: Doug Anderson diand...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Split off label additions (Doug Anderson)
* Fixed alphabetical order of sd3_* nodes (Doug Anderson)
v4 - v5:
* Introduced labels to consistently use new referencing style (Tomasz Figa)
* Use IRQ_TYPE_* constants
* Use some more GPIO_ACTIVE_*
v3 - v4: Unchanged
v3: New (Doug Anderson)
arch/arm/boot/dts/exynos5250-snow.dts | 291
+-
1 file changed, 145 insertions(+), 146 deletions(-)
Reviewed-by: Tomasz Figa t.f...@samsung.com
Just for convenience of other reviewers, here are actual changes done do
the device tree after compiling into dtb and then back into dts:
Erm, to not confuse reviewers, this must be over the whole series:
--- exynos5250-snow.dtb.dts 2014-08-02 14:54:15.145905921 +0200
+++ ../dtbs.post/exynos5250-snow.dtb.dts 2014-08-02 14:54:15.146905921
+0200
@@ -8,6 +8,7 @@
model = Google Snow;
chosen {
+bootargs = console=tty1;
};
aliases {
This is optional follow-on patch 05/10.
@@ -829,15 +830,6 @@
phandle = 0x44;
};
-hdmi-hpd-irq {
-samsung,pins = gpx3-7;
-samsung,pin-function = 0x0;
-samsung,pin-pud = 0x1;
-samsung,pin-drv = 0x0;
-linux,phandle = 0x33;
-phandle = 0x33;
-};
-
max77686-irq {
samsung,pins = gpx3-2;
samsung,pin-function = 0x0;
@@ -846,6 +838,15 @@
linux,phandle = 0xe;
phandle = 0xe;
};
+
+hdmi-hpd-irq {
+samsung,pins = gpx3-7;
+samsung,pin-function = 0x0;
+samsung,pin-pud = 0x1;
+samsung,pin-drv = 0x0;
+linux,phandle = 0x33;
+phandle = 0x33;
+};
};
pinctrl@1340 {
This is this patch 04/10. Just a movement.
@@ -1703,12 +1704,12 @@
samsung,dw-mshc-ciu-div = 0x3;
samsung,dw-mshc-sdr-timing = 0x2 0x3;
samsung,dw-mshc-ddr-timing = 0x1 0x2;
+pinctrl-names = default;
+pinctrl-0 = 0x27 0x28 0x29;
slot@0 {
reg = 0x0;
bus-width = 0x4;
-pinctrl-names = default;
-pinctrl-0 = 0x27 0x28 0x29;
};
};
This is preceding patch 01/10.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale
Am 02.08.2014 15:02, schrieb Tomasz Figa:
On 02.08.2014 02:52, Andreas Färber wrote:
Use the new style of referencing inherited nodes, use symbolic names,
tidy indentation and reorder includes.
Goal is the alignment of all exynos5250 based device trees for comparison.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Updated for mfc node label
v5: New
Aligns with SMDK.
arch/arm/boot/dts/exynos5250-arndale.dts | 929
---
1 file changed, 466 insertions(+), 463 deletions(-)
Diff in resulting dtb:
Same here, appears to be over whole series:
--- exynos5250-arndale.dtb.dts 2014-08-02 14:54:15.102905920 +0200
+++ ../dtbs.post/exynos5250-arndale.dtb.dts 2014-08-02 14:54:15.104905920
+0200
@@ -1977,7 +1977,7 @@
clocks = 0x2 0x158 0x2 0x88 0x2 0x89 0x2 0x9f 0x2 0x400;
clock-names = hdmi, sclk_hdmi, sclk_pixel,
sclk_hdmiphy, mout_hdmi;
samsung,syscon-phandle = 0x7;
-hpd-gpio = 0xc 0x7 0x2;
+hpd-gpio = 0xc 0x7 0x1;
vdd_osc-supply = 0x31;
vdd_pll-supply = 0x32;
vdd-supply = 0x32;
Optional follow-up patch 08/10.
@@ -2104,15 +2104,9 @@
};
};
-usb_hub_bus {
-compatible = simple-bus;
-#address-cells = 0x1;
-#size-cells = 0x0;
-
-usb_hub {
-compatible = smsc,usb3503a;
-reset-gpios = 0xc 0x5 0x1;
-connect-gpios = 0x10 0x7 0x1;
-};
+usb-hub {
+compatible = smsc,usb3503a;
+reset-gpios = 0xc 0x5 0x1;
+connect-gpios = 0x10 0x7 0x1;
};
};
Optional follow-up patch 09/10.
Reviewed-by: Tomasz Figa t.f...@samsung.com
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 06/10] ARM: dts: Clean up exynos5250-smdk5250
Am 01.08.2014 06:54, schrieb Andreas Färber:
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index ff1c09607631..30482fc523f9 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -215,7 +215,7 @@
clock-names = fimg2d;
};
- codec@1100 {
+ codec: codec@1100 {
compatible = samsung,mfc-v6;
reg = 0x1100 0x1;
interrupts = 0 96 0;
I notice that Ajay's iommu patch uses mfc here, so let's use it here,
too. Affects patches 7 and 10.
Andreas
@@ -258,7 +258,7 @@
clock-names = uart, clk_uart_baud0;
};
- sata@122F {
+ sata: sata@122F {
compatible = snps,dwc-ahci;
samsung,sata-freq = 66;
reg = 0x122F 0x1ff;
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support
Hi Ajay, Am 01.08.2014 09:02, schrieb Ajay kumar: On Thu, Jul 31, 2014 at 7:52 PM, Andreas Färber afaer...@suse.de wrote: So, with simplefb reverted in U-Boot and ... * with just the v6 applied (...~2), I get only a black screen from Linux, no penguins, but the backlight seems on. System comes up okay, ssh available, and nothing stands out in dmesg. * with the two iommu patches on top, something breaks badly, no backlight, no USB/network, system inaccessible. I.e. U-Boot had no noticeable impact on these symptoms. * with the iommu patches, but dp-controller, ps8622, panel commented out, I do get backlight but USB/network not working, system inaccessible. With simplefb support in U-Boot and with just v6 applied, but dp-controller, ps8622, panel commented out, things work as well as before, i.e. this series has no bad side effects. Note that I never claimed Ajay's series were broken, just reported that things regressed for me from v4, which may well be DT-related. The iommu patches interfere with my USB somehow (none or not all devices powered; with v4, plugging my wifi dongle led to oops but ethernet dongle worked, so not entirely new symptom), which is bad since my rootfs is on USB. The internal SDIO-connected Wifi is not enabled yet, so USB based network is my only alternative to a working display once we reach userspace. Well, there are 2 variants here: 1) Bootloader 2) config Type of the bootloader should not matter unless its switching on FET1 and FET6 of tps65090 for you. But, config can be different! I have attached a config i used to get display with your latest spring-bridge.v6. Uncomment the DT nodes for DP and bridge chip and you should be able to get display and also the login. I think that you have not selected all the configs needed for IOMMU to work properly. When I deselected few IOMMU configs, I could see system crashing when FIMD + DP path was being initialized. May be, that is why your USB stops working. Even I have root file system on USB drive. Find attached a diff between our configs. The following stand out: * I have LPAE enabled * you don't have DMA enabled * I have CMA enabled (like in the new defconfigs) * I have the arch timer disabled (which you suggested earlier for delay) * I have more devices enabled (SPI, PWM, cpufreq, watchdog, ...) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg --- .config 2014-08-01 14:03:18.255022463 +0200 +++ ../config-ajay.txt 2014-08-01 13:19:01.875021197 +0200 @@ -34,7 +34,7 @@ CONFIG_CROSS_COMPILE= # CONFIG_COMPILE_TEST is not set CONFIG_LOCALVERSION= -# CONFIG_LOCALVERSION_AUTO is not set +CONFIG_LOCALVERSION_AUTO=y CONFIG_HAVE_KERNEL_GZIP=y CONFIG_HAVE_KERNEL_LZMA=y CONFIG_HAVE_KERNEL_XZ=y @@ -51,7 +51,7 @@ CONFIG_SYSVIPC_SYSCTL=y # CONFIG_POSIX_MQUEUE is not set CONFIG_CROSS_MEMORY_ATTACH=y -CONFIG_FHANDLE=y +# CONFIG_FHANDLE is not set CONFIG_USELIB=y # CONFIG_AUDIT is not set CONFIG_HAVE_ARCH_AUDITSYSCALL=y @@ -106,19 +106,10 @@ # CONFIG_TREE_RCU_TRACE is not set # CONFIG_RCU_BOOST is not set # CONFIG_RCU_NOCB_CPU is not set -CONFIG_IKCONFIG=y -CONFIG_IKCONFIG_PROC=y +# CONFIG_IKCONFIG is not set CONFIG_LOG_BUF_SHIFT=17 CONFIG_GENERIC_SCHED_CLOCK=y -CONFIG_CGROUPS=y -# CONFIG_CGROUP_DEBUG is not set -# CONFIG_CGROUP_FREEZER is not set -# CONFIG_CGROUP_DEVICE is not set -# CONFIG_CPUSETS is not set -# CONFIG_CGROUP_CPUACCT is not set -# CONFIG_RESOURCE_COUNTERS is not set -# CONFIG_CGROUP_SCHED is not set -# CONFIG_BLK_CGROUP is not set +# CONFIG_CGROUPS is not set # CONFIG_CHECKPOINT_RESTORE is not set CONFIG_NAMESPACES=y CONFIG_UTS_NS=y @@ -204,7 +195,6 @@ CONFIG_HAVE_CONTEXT_TRACKING=y CONFIG_HAVE_VIRT_CPU_ACCOUNTING_GEN=y CONFIG_HAVE_IRQ_TIME_ACCOUNTING=y -CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE=y CONFIG_HAVE_MOD_ARCH_SPECIFIC=y CONFIG_MODULES_USE_ELF_REL=y CONFIG_CLONE_BACKWARDS=y @@ -228,7 +218,7 @@ CONFIG_STOP_MACHINE=y CONFIG_BLOCK=y CONFIG_LBDAF=y -CONFIG_BLK_DEV_BSG=y +# CONFIG_BLK_DEV_BSG is not set # CONFIG_BLK_DEV_BSGLIB is not set # CONFIG_BLK_DEV_INTEGRITY is not set # CONFIG_BLK_CMDLINE_PARSER is not set @@ -267,7 +257,6 @@ CONFIG_DEFAULT_CFQ=y # CONFIG_DEFAULT_NOOP is not set CONFIG_DEFAULT_IOSCHED=cfq -CONFIG_PREEMPT_NOTIFIERS=y CONFIG_UNINLINE_SPIN_UNLOCK=y CONFIG_ARCH_SUPPORTS_ATOMIC_RMW=y CONFIG_RWSEM_SPIN_ON_OWNER=y @@ -323,7 +312,6 @@ # CONFIG_ARCH_MULTI_CPU_AUTO is not set # CONFIG_ARCH_VIRT is not set # CONFIG_ARCH_MVEBU is not set -# CONFIG_ARCH_AXXIA is not set # CONFIG_ARCH_BCM is not set # CONFIG_ARCH_BERLIN is not set # CONFIG_ARCH_HIGHBANK is not set @@ -358,10 +346,11 @@ CONFIG_SOC_EXYNOS4212=y CONFIG_SOC_EXYNOS4412=y CONFIG_SOC_EXYNOS5250=y -# CONFIG_SOC_EXYNOS5260 is not set -# CONFIG_SOC_EXYNOS5410 is not set -# CONFIG_SOC_EXYNOS5420 is not set -# CONFIG_SOC_EXYNOS5440 is not set +CONFIG_SOC_EXYNOS5260=y
Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support
Ajay, Am 01.08.2014 09:02, schrieb Ajay kumar: On Thu, Jul 31, 2014 at 7:52 PM, Andreas Färber afaer...@suse.de wrote: Am 31.07.2014 12:23, schrieb Thierry Reding: On Thu, Jul 31, 2014 at 10:57:55AM +0200, Andreas Färber wrote: Am 31.07.2014 10:38, schrieb Ajay kumar: With just the spring-bridge.v6 branch of your own tree, I am able to see bootup logo on Skate(a variant of spring which also contains ps8622). I have tried both exynos_defconfig and multi_v7_defconfig. I enable DRM, EXYNOS DRM, BRIDGE CHIPS, IOMMU, EXYNOS IOMMU in configs. [...] If you have something like simplefb enabled in addition to a DRM driver, then perhaps the DRM driver isn't properly taking over the framebuffer console. So, with simplefb reverted in U-Boot and ... * with just the v6 applied (...~2), I get only a black screen from Linux, no penguins, but the backlight seems on. System comes up okay, ssh available, and nothing stands out in dmesg. * with the two iommu patches on top, something breaks badly, no backlight, no USB/network, system inaccessible. I.e. U-Boot had no noticeable impact on these symptoms. * with the iommu patches, but dp-controller, ps8622, panel commented out, I do get backlight but USB/network not working, system inaccessible. With simplefb support in U-Boot and with just v6 applied, but dp-controller, ps8622, panel commented out, things work as well as before, i.e. this series has no bad side effects. Note that I never claimed Ajay's series were broken, just reported that things regressed for me from v4, which may well be DT-related. The iommu patches interfere with my USB somehow (none or not all devices powered; with v4, plugging my wifi dongle led to oops but ethernet dongle worked, so not entirely new symptom), which is bad since my rootfs is on USB. The internal SDIO-connected Wifi is not enabled yet, so USB based network is my only alternative to a working display once we reach userspace. Well, there are 2 variants here: 1) Bootloader 2) config Unfortunately your config doesn't work for me either, on my latest spring-bridge.v6 branch. Type of the bootloader should not matter unless its switching on FET1 and FET6 of tps65090 for you. It does switch them on, if I'm reading correctly: https://github.com/afaerber/u-boot/blob/spring/board/samsung/smdk5250/smdk5250.c#L599 https://github.com/afaerber/u-boot/blob/spring/board/samsung/smdk5250/smdk5250.c#L907 Another observation I made is that sometimes in my testing (didn't spot a pattern yet) after reboot or power-off/power-on the initial white screen with the warning did not come up (no backlight), but Ctrl+U worked fine and chain-loaded nv u-boot came up on screen okay. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: dts: Add DT changes for display on peach_pi
Hi,
Am 01.08.2014 18:24, schrieb Ajay Kumar:
Add DT nodes for panel-simple auo,b133htn01 panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add panel phandle needed by dp to enable display on peach_pi.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
Changes since V1:
Remove simple-panel compatible string and use only auo,b133htn01.
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..f8c2e61 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -28,11 +28,13 @@
i2c20 = /spi@12d4/cros-ec@0/i2c-tunnel;
};
- backlight {
+ backlight: backlight {
compatible = pwm-backlight;
pwms = pwm 0 100 0;
brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
default-brightness-level = 7;
+ enable-gpios = gpx2 2 0;
For Spring I was asked to use GPIO_ACTIVE_* - here that would mean
s/0/GPIO_ACTIVE_HIGH/ IIUC and if necessary
#include dt-bindings/gpio/gpio.h before the .dtsi #include.
A modified version of your patch for Snow, rebased onto my cleanups, can
be found on my spring-next branch.
+ power-supply = tps65090_fet1;
pinctrl-0 = pwm0_out;
pinctrl-names = default;
};
@@ -98,6 +100,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
Nit: panel-simple seems backwards in English language, and given that
simple-panel would be referring to the implementation, I used just
panel for Spring.
+ compatible = auo,b133htn01;
FWIW this depends on auo,b133htn01 getting added to Documentation and
panel-simple, which I think hasn't happened yet?
https://patchwork.kernel.org/patch/4625321/
+ power-supply = tps65090_fet6;
+ backlight = backlight;
+ };
};
dp {
@@ -111,22 +119,7 @@
samsung,link-rate = 0x0a;
samsung,lane-count = 2;
samsung,hpd-gpio = gpx2 6 0;
-
- display-timings {
- native-mode = timing1;
-
- timing1: timing@1 {
- clock-frequency = 15066;
- hactive = 1920;
- vactive = 1080;
- hfront-porch = 60;
- hback-porch = 172;
- hsync-len = 80;
- vback-porch = 25;
- vfront-porch = 10;
- vsync-len = 10;
- };
- };
+ panel = panel;
};
fimd {
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 03/10] ARM: dts: Clean up exynos5250-snow
Am 01.08.2014 22:24, schrieb Doug Anderson:
Andreas,
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
Use the new style of referencing inherited nodes and use symbolic names.
Reorder one pinctrl node in GPIO order.
Goal is the alignment of all exynos5250 based device trees for comparison.
Suggested-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v4 - v5:
* Introduced labels to consistently use new referencing style (Tomasz)
* Use IRQ_TYPE_* constants
* Use some more GPIO_ACTIVE_*
v3 - v4: Unchanged
v3: New (Doug Anderson)
arch/arm/boot/dts/exynos5250-snow.dts | 291
+-
arch/arm/boot/dts/exynos5250.dtsi | 20 +--
As much as possible it's nice to touch the main exynos dtsi file and
specific board files in different patches. Among other things it
makes backporting the patch and resolving merge conflicts easier (if
someone doesn't care about snow they could just pick up the main dtsi,
for instance).
I'm not a total stickler and I'd love to see this land quickly to
avoid conflicts, though...
+sd3_clk {
+ samsung,pin-drv = 0;
+};
+
+sd3_cmd {
+ samsung,pin-pud = 3;
+ samsung,pin-drv = 0;
+};
+
+sd3_bus4 {
Itty bitty bitty nit that bus sorts alphabetically above clk. ;)
True. I guess I just reused the original order from within pinctrl.
Maybe Kukjin would be willing to sort these when he applies?
Thank you for all your hard work on this one. Things look MUCH MUCH
nicer! I did a pretty thorough review of your changes and it all
looks good.
Reviewed-by: Doug Anderson diand...@chromium.org
I need to respin anyway for a .dtsi label, so I can factor this out
while at it.
Patches 1-2 could meanwhile already be applied by Kukjin.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
