Re: [PATCH 0/3] libfc: fix potential timer list corruption

[Johannes Thumshirn]

On 05/30/2017 05:14 PM, Hannes Reinecke wrote:
> Hi all,
> 
> we've seen reports for a crash with an invalid timer_list->function,
> which turned out to be an unsafe usage of libfc discovery callbacks.
> This patchset fixes up the problem
> 
> As usual, comments and reviews are welcome.

The patches look good themselves, but I'd prefer a *why* in the commit
message. For instance in patch 1 you have:

"Move 'pending' and 'requested' setting out of fc_disc_gpn_fc_req()
into the calling function.

No functional change."

But why do you need to move the 'pending' and 'requested' settings?

With an a bit more verbose changelog

Acked-by: Johannes Thumshirn 

for the whole series

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH 0/3] libfc: fix potential timer list corruption

[Hannes Reinecke]

Hi all,

we've seen reports for a crash with an invalid timer_list->function,
which turned out to be an unsafe usage of libfc discovery callbacks.
This patchset fixes up the problem

As usual, comments and reviews are welcome.

Hannes Reinecke (3):
  libfc: move 'pending' and 'requested' setting
  libfc: only restart discovery after timeout if not already running
  libfc: fixup locking in fc_disc_stop()

 drivers/scsi/libfc/fc_disc.c | 26 +++---
 1 file changed, 19 insertions(+), 7 deletions(-)

-- 
1.8.5.6