Re: [PATCH 0/8] usb: typec: A few more improvements for Intel CHT
On Mon, Sep 03, 2018 at 03:08:46PM +0300, Andy Shevchenko wrote: > On Mon, Sep 3, 2018 at 10:19 AM Heikki Krogerus > wrote: > > > > On Mon, Sep 03, 2018 at 09:17:13AM +0300, Andy Shevchenko wrote: > > > On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus > > > wrote: > > > > > > > > Hi, > > > > > > > > The second last patch in this series will make it possible to use > > > > multiport USB Type-C and PD controllers with the muxes. The CHT > > > > connections are simply adapted to that. The rest of the series will > > > > mainly allow us to use the USB Type-C on CHT boards even without a > > > > USB device controller. > > > > > > > > > > Throught which tree you are planning to direct this? > > > > The series is about USB Type-C, so USB would make sense to me. But > > it's up to you guys of course. > > My vacation is about to start, and from my prospective patch series > looks good (taking into account the changes Hans asked for). > > Thus, > > Acked-by: Andy Shevchenko > > for PDx86 bits on condition that Hans is fine with them. OK, thanks Andy. Because of the change, we have to make the int33fe driver depend on the muxes, so since you are about to leave, I'll resend the patches right now. Hope you have time to take a look at them. In any case, have good vacation :-) Cheers, -- heikki
Re: [PATCH 0/8] usb: typec: A few more improvements for Intel CHT
On Mon, Sep 3, 2018 at 10:19 AM Heikki Krogerus wrote: > > On Mon, Sep 03, 2018 at 09:17:13AM +0300, Andy Shevchenko wrote: > > On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus > > wrote: > > > > > > Hi, > > > > > > The second last patch in this series will make it possible to use > > > multiport USB Type-C and PD controllers with the muxes. The CHT > > > connections are simply adapted to that. The rest of the series will > > > mainly allow us to use the USB Type-C on CHT boards even without a > > > USB device controller. > > > > > > > Throught which tree you are planning to direct this? > > The series is about USB Type-C, so USB would make sense to me. But > it's up to you guys of course. My vacation is about to start, and from my prospective patch series looks good (taking into account the changes Hans asked for). Thus, Acked-by: Andy Shevchenko for PDx86 bits on condition that Hans is fine with them. -- With Best Regards, Andy Shevchenko
Re: [PATCH 0/8] usb: typec: A few more improvements for Intel CHT
Hi, On Mon, Sep 03, 2018 at 10:01:52AM +0200, Hans de Goede wrote: > Besides my comments on patches 3 and 4, one small nitpick, > platform is spelled wrong (as plarform) in the subject of > a number of the patches. Thanks Hans. I'll fix them. Cheers, -- heikki
Re: [PATCH 0/8] usb: typec: A few more improvements for Intel CHT
Hi, On 31-08-18 16:20, Heikki Krogerus wrote: Hi, The second last patch in this series will make it possible to use multiport USB Type-C and PD controllers with the muxes. The CHT connections are simply adapted to that. The rest of the series will mainly allow us to use the USB Type-C on CHT boards even without a USB device controller. Heikki Krogerus (8): drivers: base: Helpers for adding device connection descriptions plarform: x86: intel_cht_int33fe: Register all connections at once plarform: x86: intel_cht_int33fe: Use the USB role switch conditionally usb: xhci: pci: Only create Intel mux device when it's needed plarform: x86: intel_cht_int33fe: Fix the identifier for the mux connection plarform: x86: intel_cht_int33fe: Add connections for the USB Type-C port usb: typec: class: Don't use port parent for getting mux handles plarform: x86: intel_cht_int33fe: Remove the old connections for the muxes drivers/platform/x86/intel_cht_int33fe.c | 34 +++-- drivers/usb/host/xhci-pci.c | 20 +++-- drivers/usb/typec/class.c| 38 ++-- include/linux/device.h | 24 +++ 4 files changed, 74 insertions(+), 42 deletions(-) Besides my comments on patches 3 and 4, one small nitpick, platform is spelled wrong (as plarform) in the subject of a number of the patches. Regards, Hans
Re: [PATCH 0/8] usb: typec: A few more improvements for Intel CHT
On Mon, Sep 03, 2018 at 09:17:13AM +0300, Andy Shevchenko wrote: > On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus > wrote: > > > > Hi, > > > > The second last patch in this series will make it possible to use > > multiport USB Type-C and PD controllers with the muxes. The CHT > > connections are simply adapted to that. The rest of the series will > > mainly allow us to use the USB Type-C on CHT boards even without a > > USB device controller. > > > > Throught which tree you are planning to direct this? The series is about USB Type-C, so USB would make sense to me. But it's up to you guys of course. Thanks, -- heikki
Re: [PATCH 0/8] usb: typec: A few more improvements for Intel CHT
On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus wrote: > > Hi, > > The second last patch in this series will make it possible to use > multiport USB Type-C and PD controllers with the muxes. The CHT > connections are simply adapted to that. The rest of the series will > mainly allow us to use the USB Type-C on CHT boards even without a > USB device controller. > Throught which tree you are planning to direct this? > > Heikki Krogerus (8): > drivers: base: Helpers for adding device connection descriptions > plarform: x86: intel_cht_int33fe: Register all connections at once > plarform: x86: intel_cht_int33fe: Use the USB role switch > conditionally > usb: xhci: pci: Only create Intel mux device when it's needed > plarform: x86: intel_cht_int33fe: Fix the identifier for the mux > connection > plarform: x86: intel_cht_int33fe: Add connections for the USB Type-C > port > usb: typec: class: Don't use port parent for getting mux handles > plarform: x86: intel_cht_int33fe: Remove the old connections for the > muxes > > drivers/platform/x86/intel_cht_int33fe.c | 34 +++-- > drivers/usb/host/xhci-pci.c | 20 +++-- > drivers/usb/typec/class.c| 38 ++-- > include/linux/device.h | 24 +++ > 4 files changed, 74 insertions(+), 42 deletions(-) > > -- > 2.18.0 > -- With Best Regards, Andy Shevchenko
[PATCH 0/8] usb: typec: A few more improvements for Intel CHT
Hi, The second last patch in this series will make it possible to use multiport USB Type-C and PD controllers with the muxes. The CHT connections are simply adapted to that. The rest of the series will mainly allow us to use the USB Type-C on CHT boards even without a USB device controller. Heikki Krogerus (8): drivers: base: Helpers for adding device connection descriptions plarform: x86: intel_cht_int33fe: Register all connections at once plarform: x86: intel_cht_int33fe: Use the USB role switch conditionally usb: xhci: pci: Only create Intel mux device when it's needed plarform: x86: intel_cht_int33fe: Fix the identifier for the mux connection plarform: x86: intel_cht_int33fe: Add connections for the USB Type-C port usb: typec: class: Don't use port parent for getting mux handles plarform: x86: intel_cht_int33fe: Remove the old connections for the muxes drivers/platform/x86/intel_cht_int33fe.c | 34 +++-- drivers/usb/host/xhci-pci.c | 20 +++-- drivers/usb/typec/class.c| 38 ++-- include/linux/device.h | 24 +++ 4 files changed, 74 insertions(+), 42 deletions(-) -- 2.18.0
