Re: VM Fails to Start When Passing Through PCIe Card

[Mathias Nyman]

On 10.02.2018 01:46, Blake lee wrote:

I tested along with another person from the VFIO community that was
having the same issue. Resolved in both cases.



Thanks, patches sent forward.

-Mathias

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: VM Fails to Start When Passing Through PCIe Card

[Blake lee]

I tested along with another person from the VFIO community that was
having the same issue. Resolved in both cases.

Thanks!
Blake Lee

On Fri, Feb 9, 2018 at 3:54 AM, Mathias Nyman
 wrote:
> On 08.02.2018 18:54, Greg KH wrote:
>>
>> On Wed, Feb 07, 2018 at 08:03:54PM -0500, Blake lee wrote:
>>>
>>> Greg,
>>>
>>> I apologize as I've forgot to cc the mailing list.
>>>
>>> Anyway some people in the VFIO Discord were having similar issues and
>>> reverting the commit below fixed their issue.
>>>
>>> https://github.com/torvalds/linux/commit/052f71e25a7ecd80a9567b291df8ea333d9a8565
>>>
>>> I just tested and it has resolved my issue as well. It would seem as
>>> though that patch is the offender. Also below I have the kernel oops
>>> in a pastebin for you.
>>> https://pastebin.com/D51uZCFU
>>
>>
>> Ah, the debugfs mess, yeah, this should be fixed soon, there are some
>> patches queued up somewhere for this.
>>
>> Mathias, any ideas when those are going to get sent out?  It seems that
>> this is hitting lots more people than expected :(
>>
>
> If someone could test if the series solves the VM issues as well then I
> think it could
> be queued right away.
>
> It did solve the suspend to ram xhci debugfs issues Jose Marino reported
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git debugfs-fixes
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/?h=debugfs-fixes
>
> -Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: VM Fails to Start When Passing Through PCIe Card

[Mathias Nyman]

On 08.02.2018 18:54, Greg KH wrote:

On Wed, Feb 07, 2018 at 08:03:54PM -0500, Blake lee wrote:

Greg,

I apologize as I've forgot to cc the mailing list.

Anyway some people in the VFIO Discord were having similar issues and
reverting the commit below fixed their issue.
https://github.com/torvalds/linux/commit/052f71e25a7ecd80a9567b291df8ea333d9a8565

I just tested and it has resolved my issue as well. It would seem as
though that patch is the offender. Also below I have the kernel oops
in a pastebin for you.
https://pastebin.com/D51uZCFU


Ah, the debugfs mess, yeah, this should be fixed soon, there are some
patches queued up somewhere for this.

Mathias, any ideas when those are going to get sent out?  It seems that
this is hitting lots more people than expected :(



If someone could test if the series solves the VM issues as well then I think 
it could
be queued right away.

It did solve the suspend to ram xhci debugfs issues Jose Marino reported

git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git debugfs-fixes

https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/log/?h=debugfs-fixes

-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: VM Fails to Start When Passing Through PCIe Card

[Greg KH]

On Wed, Feb 07, 2018 at 08:03:54PM -0500, Blake lee wrote:
> Greg,
> 
> I apologize as I've forgot to cc the mailing list.
> 
> Anyway some people in the VFIO Discord were having similar issues and
> reverting the commit below fixed their issue.
> https://github.com/torvalds/linux/commit/052f71e25a7ecd80a9567b291df8ea333d9a8565
> 
> I just tested and it has resolved my issue as well. It would seem as
> though that patch is the offender. Also below I have the kernel oops
> in a pastebin for you.
> https://pastebin.com/D51uZCFU

Ah, the debugfs mess, yeah, this should be fixed soon, there are some
patches queued up somewhere for this.

Mathias, any ideas when those are going to get sent out?  It seems that
this is hitting lots more people than expected :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: VM Fails to Start When Passing Through PCIe Card

[Blake lee]

Greg,

I apologize as I've forgot to cc the mailing list.

Anyway some people in the VFIO Discord were having similar issues and
reverting the commit below fixed their issue.
https://github.com/torvalds/linux/commit/052f71e25a7ecd80a9567b291df8ea333d9a8565

I just tested and it has resolved my issue as well. It would seem as
though that patch is the offender. Also below I have the kernel oops
in a pastebin for you.
https://pastebin.com/D51uZCFU


Thanks!
Blake Lee

On Wed, Feb 7, 2018 at 7:50 PM, Blake lee  wrote:
> Greg,
>
> I reverted that commit, tested and everything seems to be working
> fine. I would say that's the offending patch. Below is a pastbin to
> the kernel oops in case you need it as well.
>
> output of the kernel oops:
> https://pastebin.com/RDN6Xaqw
>
> Looking forward to an upstream fix
> Thanks!
> Blake Lee
>
> On Wed, Feb 7, 2018 at 6:19 PM, Blake lee  wrote:
>> Yes, I can a bit later. In the VFIO Discord they were saying this
>> commit helped fix their issues that were similar. I need to test that
>> later tonight when I get a chance and see if that solves mine.
>>
>> https://github.com/torvalds/linux/commit/052f71e25a7ecd80a9567b291df8ea333d9a8565
>>
>> Thanks,
>> Blake Lee
>>
>> On Wed, Feb 7, 2018 at 5:59 PM, Greg KH  wrote:
>>> On Wed, Feb 07, 2018 at 11:11:49AM -0500, Blake lee wrote:
 Virtual Machine fails to start when trying to pass through USB PCIe card.

 Virtual Machine setup in libvirt with USB PCie card set to pass through.

 06:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720201 USB
 3.0 Host Controller [1912:0014] (rev 03)
 Kernel driver in use: xhci_hcd
 Kernel modules: xhci_pci

 Starting the VM causes the oops immediately.

 Actual Results: VM Fails to start
 Expected Results: VM starts and usb devices plugged into the USB card
 are passed through.

 Linux volidesk 4.15.1-acs #1 SMP Fri Feb 2 10:00:52 EST 2018 x86_64 
 GNU/Linux

 This works fine with 4.14.16.
>>>
>>> Any chance you can run 'git bisect' to find the offending patch?
>>>
>>> Any chance you can provide the output of the oops message you get?
>>>
>>> thanks,
>>>
>>> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: VM Fails to Start When Passing Through PCIe Card

[Greg KH]

On Wed, Feb 07, 2018 at 11:11:49AM -0500, Blake lee wrote:
> Virtual Machine fails to start when trying to pass through USB PCIe card.
> 
> Virtual Machine setup in libvirt with USB PCie card set to pass through.
> 
> 06:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720201 USB
> 3.0 Host Controller [1912:0014] (rev 03)
> Kernel driver in use: xhci_hcd
> Kernel modules: xhci_pci
> 
> Starting the VM causes the oops immediately.
> 
> Actual Results: VM Fails to start
> Expected Results: VM starts and usb devices plugged into the USB card
> are passed through.
> 
> Linux volidesk 4.15.1-acs #1 SMP Fri Feb 2 10:00:52 EST 2018 x86_64 GNU/Linux
> 
> This works fine with 4.14.16.

Any chance you can run 'git bisect' to find the offending patch?

Any chance you can provide the output of the oops message you get?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

VM Fails to Start When Passing Through PCIe Card

[Blake lee]

Virtual Machine fails to start when trying to pass through USB PCIe card.

Virtual Machine setup in libvirt with USB PCie card set to pass through.

06:00.0 USB controller [0c03]: Renesas Technology Corp. uPD720201 USB
3.0 Host Controller [1912:0014] (rev 03)
Kernel driver in use: xhci_hcd
Kernel modules: xhci_pci

Starting the VM causes the oops immediately.

Actual Results: VM Fails to start
Expected Results: VM starts and usb devices plugged into the USB card
are passed through.

Linux volidesk 4.15.1-acs #1 SMP Fri Feb 2 10:00:52 EST 2018 x86_64 GNU/Linux

This works fine with 4.14.16.

output of the kernel oops:
https://pastebin.com/RDN6Xaqw

Libvirt Configuration
https://pastebin.com/UbitetE6


GRUB_CMDLINE_LINUX="pcie_acs_override=downstream intel_iommu=on
rd.luks.options=discard"

Kernel is vanilla 4.15.1 with the acs override patch. Also did not
work with 4.15. Has worked on all previous 4.x.x kernels.

Here is a pastebin of the acs patch. It's the only patch I'm using on
the vanilla kernel
https://pastebin.com/4gbjTG5Y

v/r
Blake Lee
lee.blak...@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html