Re: [Linux-uvc-devel] 3.0 - exposure settings.

2011-08-04 Thread Carl Michal

On Wed, 3 Aug 2011, Laurent Pinchart wrote:


exposure back on. luvcview says either:

Auto Exposure set to 1
or
Set Auto Exposure off error

It looks like luvcview wants to set values of either 0 or 1, when the
legal values are 1 or 3.

with v4l2-ctl, I can set the Auto Exposure control to 1 or 3 and it seems
to work correctly. So looks like the driver does the right thing but maybe
both guvcview and luvcview are confused by the available values?


That's quite likely. Do you want to have a try at fixing them ? :-)


It sounds like Paulo has already dealt with guvcview.  luvcview looks to 
be fairly trivial to fix. The values are hardcoded - they were actually 
1 and 8 in the source - which probably didn't work for my cameras before, 
but changing them to 3 and 1 makes it work for me.  Not the most elegant 
solution, but there you go...


Carl



--- luvcview.c~ 2011-08-03 23:17:17.362307573 -0700
+++ luvcview.c  2011-08-03 23:18:35.870305604 -0700
@@ -829,7 +829,7 @@
break;
case A_EXPOSURE_ON:
control.id=V4L2_CID_EXPOSURE_AUTO;
-   control.value =1;
+   control.value =3;
if ((value = ioctl(videoIn-fd, VIDIOC_S_CTRL, 
control))  0)
printf(Set Auto Exposure on 
error\n);
else
@@ -837,7 +837,7 @@
break;
case A_EXPOSURE_OFF:
control.id=V4L2_CID_EXPOSURE_AUTO;
-   control.value =8;
+   control.value =1;
if ((value = ioctl(videoIn-fd, VIDIOC_S_CTRL, 
control))  0)
printf(Set Auto Exposure off 
error\n);
else


___
Linux-uvc-devel mailing list
Linux-uvc-devel@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel


Re: [Linux-uvc-devel] 3.0 - exposure settings.

2011-08-03 Thread Carl Michal

Hi,

On Tue, 2 Aug 2011, Laurent Pinchart wrote:


Hi Carl,

On Tuesday 02 August 2011 07:29:47 Carl Michal wrote:

Hi Laurent,

I understand there were changes made in the exposure settings
in 3.0.  I just installed 3.0 and have some new/different issues here.

I have two cameras available: a quanta integrated webcam in a dell XPS 15
and a logitech C910.

For either camera, guvcview used to give me a drop-down menu with 4
exposure options in addition to an auto priority checkbox and a slider to
manually set the exposure. Two of the drop-down settings didn't seem to
work, but two of them did. With a 3.0 kernel, there is only an auto
exposure check-box and manual exposure slider - but the exposure slider no
longer works and guvcview says:
control id: 0x009a0902 failed to set (error -1) (for the quanta)
or
control id: 0x009a0902 failed to set (error -1) (for the logitech)


So pretty much the same error for both :-)


err - somehow they looked a little less identical when I went to paste 
the second one in.  Blame that on the new baby...




Could you try listing the controls with v4l2-ctl or yavta ? The auto-exposure
control should still be a menu (I expect guvcview to convert it to a boolean
control automatically for some reason, maybe because it has two values only),
and if the values reported by the driver match the two values that worked
before ?



yavta -l for either camera lists three exposure controls (with different 
values for the min, max and default):


control 0x009a0901 `Exposure, Auto' min 0 max 3 step 1 default 3 current 3.
  1: Manual Mode
  3: Aperture Priority Mode
control 0x009a0902 `Exposure (Absolute)' min 3 max 2047 step 1 default 166 
current 166.
control 0x009a0903 `Exposure, Auto Priority' min 0 max 1 step 1 default 0 
current 0.

The two values reported for the 'Exposure, Auto' control are the two 
values in the drop down that worked before. But that control isn't drawn 
by guvcview at all now (tried guvcview: 1.4.2, 1.4.4 or 1.4.5).


Interesting though, luvcview (0.2.6) draws the first two of those controls 
(but not the third). So - I turned off the auto exposure in luvcview and now 
the manual exposure setting works.  But - now I can't turn auto exposure 
back on. luvcview says either:


Auto Exposure set to 1
or
Set Auto Exposure off error

It looks like luvcview wants to set values of either 0 or 1, when the 
legal values are 1 or 3.


with v4l2-ctl, I can set the Auto Exposure control to 1 or 3 and it seems 
to work correctly. So looks like the driver does the right thing but maybe 
both guvcview and luvcview are confused by the available values?


Carl


___
Linux-uvc-devel mailing list
Linux-uvc-devel@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel


Re: [Linux-uvc-devel] 3.0 - exposure settings.

2011-08-03 Thread Laurent Pinchart
Hi Carl,

On Wednesday 03 August 2011 08:29:56 Carl Michal wrote:
 On Tue, 2 Aug 2011, Laurent Pinchart wrote:
  On Tuesday 02 August 2011 07:29:47 Carl Michal wrote:
  Hi Laurent,
  
  I understand there were changes made in the exposure settings
  in 3.0.  I just installed 3.0 and have some new/different issues here.
  
  I have two cameras available: a quanta integrated webcam in a dell XPS
  15 and a logitech C910.
  
  For either camera, guvcview used to give me a drop-down menu with 4
  exposure options in addition to an auto priority checkbox and a slider
  to manually set the exposure. Two of the drop-down settings didn't seem
  to work, but two of them did. With a 3.0 kernel, there is only an auto
  exposure check-box and manual exposure slider - but the exposure slider
  no longer works and guvcview says:
  control id: 0x009a0902 failed to set (error -1) (for the quanta)
  or
  control id: 0x009a0902 failed to set (error -1) (for the logitech)
  
  So pretty much the same error for both :-)
 
 err - somehow they looked a little less identical when I went to paste
 the second one in.  Blame that on the new baby...
 
  Could you try listing the controls with v4l2-ctl or yavta ? The
  auto-exposure control should still be a menu (I expect guvcview to
  convert it to a boolean control automatically for some reason, maybe
  because it has two values only), and if the values reported by the
  driver match the two values that worked before ?
 
 yavta -l for either camera lists three exposure controls (with different
 values for the min, max and default):
 
 control 0x009a0901 `Exposure, Auto' min 0 max 3 step 1 default 3 current 3.
1: Manual Mode
3: Aperture Priority Mode
 control 0x009a0902 `Exposure (Absolute)' min 3 max 2047 step 1 default 166
 current 166. control 0x009a0903 `Exposure, Auto Priority' min 0 max 1 step
 1 default 0 current 0.
 
 The two values reported for the 'Exposure, Auto' control are the two
 values in the drop down that worked before. But that control isn't drawn
 by guvcview at all now (tried guvcview: 1.4.2, 1.4.4 or 1.4.5).
 
 Interesting though, luvcview (0.2.6) draws the first two of those controls
 (but not the third). So - I turned off the auto exposure in luvcview and
 now the manual exposure setting works.  But - now I can't turn auto
 exposure back on. luvcview says either:
 
 Auto Exposure set to 1
 or
 Set Auto Exposure off error
 
 It looks like luvcview wants to set values of either 0 or 1, when the
 legal values are 1 or 3.
 
 with v4l2-ctl, I can set the Auto Exposure control to 1 or 3 and it seems
 to work correctly. So looks like the driver does the right thing but maybe
 both guvcview and luvcview are confused by the available values?

That's quite likely. Do you want to have a try at fixing them ? :-)

-- 
Regards,

Laurent Pinchart
___
Linux-uvc-devel mailing list
Linux-uvc-devel@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel


Re: [Linux-uvc-devel] 3.0 - exposure settings.

2011-08-03 Thread Paulo Assis
Hi,
guvcview had a little problem when handling menu control indexes, it
was using the combo box index instead of the real control menu index.
This should be fixed in svn (svn://svn.berlios.de/guvcview/trunk) if
you care to test it.

This worked fine for sequential menu indexes, but this specific case
revealed the bug.

In any case I can't see how it turned a menu combo into a check box,
It just hasn't that type of code.

Regards,
Paulo

2011/8/3 Laurent Pinchart laurent.pinch...@ideasonboard.com:
 Hi Carl,

 On Wednesday 03 August 2011 08:29:56 Carl Michal wrote:
 On Tue, 2 Aug 2011, Laurent Pinchart wrote:
  On Tuesday 02 August 2011 07:29:47 Carl Michal wrote:
  Hi Laurent,
 
  I understand there were changes made in the exposure settings
  in 3.0.  I just installed 3.0 and have some new/different issues here.
 
  I have two cameras available: a quanta integrated webcam in a dell XPS
  15 and a logitech C910.
 
  For either camera, guvcview used to give me a drop-down menu with 4
  exposure options in addition to an auto priority checkbox and a slider
  to manually set the exposure. Two of the drop-down settings didn't seem
  to work, but two of them did. With a 3.0 kernel, there is only an auto
  exposure check-box and manual exposure slider - but the exposure slider
  no longer works and guvcview says:
  control id: 0x009a0902 failed to set (error -1) (for the quanta)
  or
  control id: 0x009a0902 failed to set (error -1) (for the logitech)
 
  So pretty much the same error for both :-)

 err - somehow they looked a little less identical when I went to paste
 the second one in.  Blame that on the new baby...

  Could you try listing the controls with v4l2-ctl or yavta ? The
  auto-exposure control should still be a menu (I expect guvcview to
  convert it to a boolean control automatically for some reason, maybe
  because it has two values only), and if the values reported by the
  driver match the two values that worked before ?

 yavta -l for either camera lists three exposure controls (with different
 values for the min, max and default):

 control 0x009a0901 `Exposure, Auto' min 0 max 3 step 1 default 3 current 3.
    1: Manual Mode
    3: Aperture Priority Mode
 control 0x009a0902 `Exposure (Absolute)' min 3 max 2047 step 1 default 166
 current 166. control 0x009a0903 `Exposure, Auto Priority' min 0 max 1 step
 1 default 0 current 0.

 The two values reported for the 'Exposure, Auto' control are the two
 values in the drop down that worked before. But that control isn't drawn
 by guvcview at all now (tried guvcview: 1.4.2, 1.4.4 or 1.4.5).

 Interesting though, luvcview (0.2.6) draws the first two of those controls
 (but not the third). So - I turned off the auto exposure in luvcview and
 now the manual exposure setting works.  But - now I can't turn auto
 exposure back on. luvcview says either:

 Auto Exposure set to 1
 or
 Set Auto Exposure off error

 It looks like luvcview wants to set values of either 0 or 1, when the
 legal values are 1 or 3.

 with v4l2-ctl, I can set the Auto Exposure control to 1 or 3 and it seems
 to work correctly. So looks like the driver does the right thing but maybe
 both guvcview and luvcview are confused by the available values?

 That's quite likely. Do you want to have a try at fixing them ? :-)

 --
 Regards,

 Laurent Pinchart
 ___
 Linux-uvc-devel mailing list
 Linux-uvc-devel@lists.berlios.de
 https://lists.berlios.de/mailman/listinfo/linux-uvc-devel

___
Linux-uvc-devel mailing list
Linux-uvc-devel@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel


Re: [Linux-uvc-devel] 3.0 - exposure settings.

2011-08-03 Thread Paulo Assis
OK, I've just test it under 3.0 and it seems to be working fine now.
The way menu entries were listed was causing it to misbehave, when
querying for the menu items if one happened to fail then the loop
would break, not listing the remaining entries. Now we just continue
until the last index (maximum value).

Regards,
Paulo

2011/8/3 Paulo Assis pj.as...@gmail.com:
 Hi,
 guvcview had a little problem when handling menu control indexes, it
 was using the combo box index instead of the real control menu index.
 This should be fixed in svn (svn://svn.berlios.de/guvcview/trunk) if
 you care to test it.

 This worked fine for sequential menu indexes, but this specific case
 revealed the bug.

 In any case I can't see how it turned a menu combo into a check box,
 It just hasn't that type of code.

 Regards,
 Paulo

 2011/8/3 Laurent Pinchart laurent.pinch...@ideasonboard.com:
 Hi Carl,

 On Wednesday 03 August 2011 08:29:56 Carl Michal wrote:
 On Tue, 2 Aug 2011, Laurent Pinchart wrote:
  On Tuesday 02 August 2011 07:29:47 Carl Michal wrote:
  Hi Laurent,
 
  I understand there were changes made in the exposure settings
  in 3.0.  I just installed 3.0 and have some new/different issues here.
 
  I have two cameras available: a quanta integrated webcam in a dell XPS
  15 and a logitech C910.
 
  For either camera, guvcview used to give me a drop-down menu with 4
  exposure options in addition to an auto priority checkbox and a slider
  to manually set the exposure. Two of the drop-down settings didn't seem
  to work, but two of them did. With a 3.0 kernel, there is only an auto
  exposure check-box and manual exposure slider - but the exposure slider
  no longer works and guvcview says:
  control id: 0x009a0902 failed to set (error -1) (for the quanta)
  or
  control id: 0x009a0902 failed to set (error -1) (for the logitech)
 
  So pretty much the same error for both :-)

 err - somehow they looked a little less identical when I went to paste
 the second one in.  Blame that on the new baby...

  Could you try listing the controls with v4l2-ctl or yavta ? The
  auto-exposure control should still be a menu (I expect guvcview to
  convert it to a boolean control automatically for some reason, maybe
  because it has two values only), and if the values reported by the
  driver match the two values that worked before ?

 yavta -l for either camera lists three exposure controls (with different
 values for the min, max and default):

 control 0x009a0901 `Exposure, Auto' min 0 max 3 step 1 default 3 current 3.
    1: Manual Mode
    3: Aperture Priority Mode
 control 0x009a0902 `Exposure (Absolute)' min 3 max 2047 step 1 default 166
 current 166. control 0x009a0903 `Exposure, Auto Priority' min 0 max 1 step
 1 default 0 current 0.

 The two values reported for the 'Exposure, Auto' control are the two
 values in the drop down that worked before. But that control isn't drawn
 by guvcview at all now (tried guvcview: 1.4.2, 1.4.4 or 1.4.5).

 Interesting though, luvcview (0.2.6) draws the first two of those controls
 (but not the third). So - I turned off the auto exposure in luvcview and
 now the manual exposure setting works.  But - now I can't turn auto
 exposure back on. luvcview says either:

 Auto Exposure set to 1
 or
 Set Auto Exposure off error

 It looks like luvcview wants to set values of either 0 or 1, when the
 legal values are 1 or 3.

 with v4l2-ctl, I can set the Auto Exposure control to 1 or 3 and it seems
 to work correctly. So looks like the driver does the right thing but maybe
 both guvcview and luvcview are confused by the available values?

 That's quite likely. Do you want to have a try at fixing them ? :-)

 --
 Regards,

 Laurent Pinchart
 ___
 Linux-uvc-devel mailing list
 Linux-uvc-devel@lists.berlios.de
 https://lists.berlios.de/mailman/listinfo/linux-uvc-devel


___
Linux-uvc-devel mailing list
Linux-uvc-devel@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel


Re: [Linux-uvc-devel] 3.0 - exposure settings.

2011-08-02 Thread Laurent Pinchart
Hi Carl,

On Tuesday 02 August 2011 07:29:47 Carl Michal wrote:
 Hi Laurent,
 
 I understand there were changes made in the exposure settings
 in 3.0.  I just installed 3.0 and have some new/different issues here.
 
 I have two cameras available: a quanta integrated webcam in a dell XPS 15
 and a logitech C910.
 
 For either camera, guvcview used to give me a drop-down menu with 4
 exposure options in addition to an auto priority checkbox and a slider to
 manually set the exposure. Two of the drop-down settings didn't seem to
 work, but two of them did. With a 3.0 kernel, there is only an auto
 exposure check-box and manual exposure slider - but the exposure slider no
 longer works and guvcview says:
 control id: 0x009a0902 failed to set (error -1) (for the quanta)
 or
 control id: 0x009a0902 failed to set (error -1) (for the logitech)

So pretty much the same error for both :-)

Could you try listing the controls with v4l2-ctl or yavta ? The auto-exposure 
control should still be a menu (I expect guvcview to convert it to a boolean 
control automatically for some reason, maybe because it has two values only), 
and if the values reported by the driver match the two values that worked 
before ?

yavta -l /dev/video0 reports

control 0x009a0901 `Exposure, Auto' min 0 max 3 step 1 default 3 current 3.
  1: Manual Mode
  3: Aperture Priority Mode

on my C905. Writing to the Exposure (Absolute) control when Exposure, Auto is 
set to 3 fails with EIO, and succeeds if Exposure, Auto is set to 1.

-- 
Regards,

Laurent Pinchart
___
Linux-uvc-devel mailing list
Linux-uvc-devel@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel