Re: [PATCH] mac80211: add back support for radiotap vendor namespace data
On 11/07/14 20:37, Luca Coelho wrote: On November 7, 2014 9:15:21 PM EET, Johannes Bergjohan...@sipsolutions.net wrote: On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote: +#if 0 + struct ieee80211_vendor_radiotap *rtap; + + rtap = (void *)skb_push(skb, sizeof(*rtap) + 8 + 4); + /* +* Don't enable this code by default as the OUI 00:00:00 +* is registered to Xerox so we shouldn't use it here, it +* might find its way into pcap files. +* Note that this code requires the headroom in the SKB +* that was allocated earlier. +*/ Is this #if 0'ed section here on purpose? If yes, maybe explain it in the commit message? You're the second person to ask this, but come on ... really? :) Okay, I know I'm missing something. But i just hate #if 0s, especially when I don't easily understand the need for them. Hi Luca, You should read the comment block in the '#if 0' section. Maybe it helps :-p Regards, Arend johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mac80211: add back support for radiotap vendor namespace data
On November 7, 2014 9:15:21 PM EET, Johannes Berg johan...@sipsolutions.net wrote: On Fri, 2014-11-07 at 14:37 +0200, Luca Coelho wrote: +#if 0 + struct ieee80211_vendor_radiotap *rtap; + + rtap = (void *)skb_push(skb, sizeof(*rtap) + 8 + 4); + /* + * Don't enable this code by default as the OUI 00:00:00 + * is registered to Xerox so we shouldn't use it here, it + * might find its way into pcap files. + * Note that this code requires the headroom in the SKB + * that was allocated earlier. + */ Is this #if 0'ed section here on purpose? If yes, maybe explain it in the commit message? You're the second person to ask this, but come on ... really? :) Okay, I know I'm missing something. But i just hate #if 0s, especially when I don't easily understand the need for them. johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mac80211: add back support for radiotap vendor namespace data
On 11/06/2014 02:29 PM, Johannes Berg wrote: From: Johannes Berg johannes.b...@intel.com Radiotap vendor namespace data might still be useful, but we reverted it because it used too much space in the RX status. Put it back, but address the space problem by using a single but only and putting everything else into the skb-data. ^^ typo? I didn't look at the rest... Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mac80211: add back support for radiotap vendor namespace data
On Thu, 2014-11-06 at 14:31 -0800, Ben Greear wrote: On 11/06/2014 02:29 PM, Johannes Berg wrote: From: Johannes Berg johannes.b...@intel.com Radiotap vendor namespace data might still be useful, but we reverted it because it used too much space in the RX status. Put it back, but address the space problem by using a single but only and putting everything else into the skb-data. ^^ typo? yeah, should say single bit, thanks! johannes -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
