Re: B43 driver no longer works in Linux 4.15 (bisected)

[Greg Kroah-Hartman]

On Mon, Feb 12, 2018 at 03:22:32PM +, James Hogan wrote:
> On Mon, Feb 12, 2018 at 05:08:10PM +0200, Kalle Valo wrote:
> > James Hogan  writes:
> > > On Mon, Feb 05, 2018 at 01:23:31PM -0500, Adric Blake wrote:
> > >> I bisected to this "first bad commit:"
> > >> 
> > >> commit 58eae1416b804d900014d84feadda7195007cc30
> > >> Author: James Hogan 
> > >> Date:   Mon Jan 15 21:17:14 2018 +
> > >> 
> > >> ssb: Disable PCI host for PCI_DRIVERS_GENERIC
> > >
> > > Yes, really sorry about that and thanks for going to the effort of
> > > bisecting. There is a patch here:
> > > https://patchwork.kernel.org/patch/10185397/
> > >
> > > which is applied to linux-next as commit
> > > a9e6d44ddeccd3522670e641f1ed9b068e746ff7, and is tagged for stable,
> > > though I've just noticed the stable email address is incorrect... I'll
> > > make sure it gets applied to the 4.15 stable branch though as soon as
> > > I notice its merged.
> > 
> > The commit is now in v4.16-rc1.
> 
> Yes, thanks,
> 
> Greg: Please can commit a9e6d44ddeccd3522670e641f1ed9b068e746ff7 ("ssb:
> Do not disable PCI host on non-Mips") be applied to 4.15 stable (the
> wrong stable email address was Cc'd in the commit message).

Now applied, thanks.

greg k-h

Re: B43 driver no longer works in Linux 4.15 (bisected)

[James Hogan]

On Mon, Feb 12, 2018 at 05:08:10PM +0200, Kalle Valo wrote:
> James Hogan  writes:
> > On Mon, Feb 05, 2018 at 01:23:31PM -0500, Adric Blake wrote:
> >> I bisected to this "first bad commit:"
> >> 
> >> commit 58eae1416b804d900014d84feadda7195007cc30
> >> Author: James Hogan 
> >> Date:   Mon Jan 15 21:17:14 2018 +
> >> 
> >> ssb: Disable PCI host for PCI_DRIVERS_GENERIC
> >
> > Yes, really sorry about that and thanks for going to the effort of
> > bisecting. There is a patch here:
> > https://patchwork.kernel.org/patch/10185397/
> >
> > which is applied to linux-next as commit
> > a9e6d44ddeccd3522670e641f1ed9b068e746ff7, and is tagged for stable,
> > though I've just noticed the stable email address is incorrect... I'll
> > make sure it gets applied to the 4.15 stable branch though as soon as
> > I notice its merged.
> 
> The commit is now in v4.16-rc1.

Yes, thanks,

Greg: Please can commit a9e6d44ddeccd3522670e641f1ed9b068e746ff7 ("ssb:
Do not disable PCI host on non-Mips") be applied to 4.15 stable (the
wrong stable email address was Cc'd in the commit message).

Thanks
James


signature.asc
Description: Digital signature

Re: B43 driver no longer works in Linux 4.15 (bisected)

[Kalle Valo]

James Hogan  writes:

> Hi Adric,
>
> On Mon, Feb 05, 2018 at 01:23:31PM -0500, Adric Blake wrote:
>> In the time between Linux 4.15-rc8 and -rc9, my wireless driver, b43,
>> would no longer load automatically. When I modprobe the b43 (and ssb)
>> modules, the device still didn't appear in NetworkManager. Comparing
>> the kernel logs between working (4.14.16-lts) and nonworking (4.15)
>> kernels reveals that there is zero output from the ssb module, and no
>> devices recognized by the b43 driver:
>
> ...
>
>> I had my suspicions at this point, but I had a lull and decided to
>> bisect it anyways.
>> I bisected to this "first bad commit:"
>> 
>> commit 58eae1416b804d900014d84feadda7195007cc30
>> Author: James Hogan 
>> Date:   Mon Jan 15 21:17:14 2018 +
>> 
>> ssb: Disable PCI host for PCI_DRIVERS_GENERIC
>
> Yes, really sorry about that and thanks for going to the effort of
> bisecting. There is a patch here:
> https://patchwork.kernel.org/patch/10185397/
>
> which is applied to linux-next as commit
> a9e6d44ddeccd3522670e641f1ed9b068e746ff7, and is tagged for stable,
> though I've just noticed the stable email address is incorrect... I'll
> make sure it gets applied to the 4.15 stable branch though as soon as
> I notice its merged.

The commit is now in v4.16-rc1.

-- 
Kalle Valo

Re: B43 driver no longer works in Linux 4.15 (bisected)

[Michael Büsch]

On Mon, 5 Feb 2018 13:14:28 -0500
Adric Blake  wrote:

> In the time between Linux 4.15-rc8 and -rc9, my wireless driver, b43, would
> no longer load automatically. When I modprobe the b43 (and ssb) modules,
> the device still didn't appear in NetworkManager. Comparing the kernel logs
> between working (4.14.16-lts) and nonworking (4.15) kernels reveals that
> there is zero output from the ssb module, and no devices recognized by the
> b43 driver:


Thanks for your bug report.
A fix for this exists already:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=a9e6d44ddeccd3522670e641f1ed9b068e746ff7

-- 
Michael


pgppKiWy8UTXl.pgp
Description: OpenPGP digital signature

Re: B43 driver no longer works in Linux 4.15 (bisected)

[James Hogan]

Hi Adric,

On Mon, Feb 05, 2018 at 01:23:31PM -0500, Adric Blake wrote:
> In the time between Linux 4.15-rc8 and -rc9, my wireless driver, b43,
> would no longer load automatically. When I modprobe the b43 (and ssb)
> modules, the device still didn't appear in NetworkManager. Comparing
> the kernel logs between working (4.14.16-lts) and nonworking (4.15)
> kernels reveals that there is zero output from the ssb module, and no
> devices recognized by the b43 driver:

...

> I had my suspicions at this point, but I had a lull and decided to
> bisect it anyways.
> I bisected to this "first bad commit:"
> 
> commit 58eae1416b804d900014d84feadda7195007cc30
> Author: James Hogan 
> Date:   Mon Jan 15 21:17:14 2018 +
> 
> ssb: Disable PCI host for PCI_DRIVERS_GENERIC

Yes, really sorry about that and thanks for going to the effort of
bisecting. There is a patch here:
https://patchwork.kernel.org/patch/10185397/

which is applied to linux-next as commit
a9e6d44ddeccd3522670e641f1ed9b068e746ff7, and is tagged for stable,
though I've just noticed the stable email address is incorrect... I'll
make sure it gets applied to the 4.15 stable branch though as soon as
I notice its merged.

Thanks
James


signature.asc
Description: Digital signature

B43 driver no longer works in Linux 4.15 (bisected)

[Adric Blake]

In the time between Linux 4.15-rc8 and -rc9, my wireless driver, b43,
would no longer load automatically. When I modprobe the b43 (and ssb)
modules, the device still didn't appear in NetworkManager. Comparing
the kernel logs between working (4.14.16-lts) and nonworking (4.15)
kernels reveals that there is zero output from the ssb module, and no
devices recognized by the b43 driver:

Compare:

working:

 kernel: ssb: Found chip with id 0x4312, rev 0x01 and package 0x00
 kernel: ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x16, vendor 0x4243)
 kernel: ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x0F, vendor 0x4243)
 kernel: ssb: Core 2 found: PCMCIA (cc 0x80D, rev 0x0A, vendor 0x4243)
 kernel: ssb: Core 3 found: PCI-E (cc 0x820, rev 0x09, vendor 0x4243)
 kernel: ssb: Sonics Silicon Backplane found on PCI device :0c:00.0
 kernel: b43-phy0: Broadcom 4312 WLAN found (core revision 15)
 kernel: b43-phy0: Found PHY: Analog 6, Type 5 (LP), Revision 1
 kernel: b43-phy0: Found Radio: Manuf 0x17F, ID 0x2062, Revision 2, Version 0
 kernel: Broadcom 43xx driver loaded [ Features: PNLS ]
 kernel: b43-phy0: Loading firmware version 784.2 (2012-08-15 21:35:19)

vs nonworking, with manual modprobe:

 kernel: platform regulatory.0: Direct firmware load for regulatory.db
failed with error -2
 kernel: cfg80211: failed to load regulatory.db
 kernel: Broadcom 43xx driver loaded [ Features: NLS ]

I had my suspicions at this point, but I had a lull and decided to
bisect it anyways.
I bisected to this "first bad commit:"

commit 58eae1416b804d900014d84feadda7195007cc30
Author: James Hogan 
Date:   Mon Jan 15 21:17:14 2018 +

ssb: Disable PCI host for PCI_DRIVERS_GENERIC

Since commit d41e6858ba58 ("MIPS: Kconfig: Set default MIPS system type
as generic") changed the default MIPS platform to the "generic"
platform, which uses PCI_DRIVERS_GENERIC instead of PCI_DRIVERS_LEGACY,
various files in drivers/ssb/ have failed to build.

This is particularly due to the existence of struct pci_controller being
dependent on PCI_DRIVERS_LEGACY since commit c5611df96804 ("MIPS: PCI:
Introduce CONFIG_PCI_DRIVERS_LEGACY"), so add that dependency to Kconfig
to prevent these files being built for the "generic" platform including
all{yes,mod}config builds.

Fixes: c5611df96804 ("MIPS: PCI: Introduce CONFIG_PCI_DRIVERS_LEGACY")
Signed-off-by: James Hogan 
Cc: Michael Buesch 
Cc: Ralf Baechle 
Cc: Paul Burton 
Cc: Matt Redfearn 
Cc: Guenter Roeck 
Cc: linux-wireless@vger.kernel.org
Cc: linux-m...@linux-mips.org
Tested-by: Guenter Roeck 
Signed-off-by: Kalle Valo 

:04 04 b7b4c5908ec800fbba19a9615049648d488a5771
18d76731ebb799fc1892d01da59d4c268229d51e Mdrivers

Since it was just a one-line Kconfig change, i investigated further,
and noted how a dependency change affects the build:

 missing config: SSB_B43_PCI_BRIDGE
 caused by missing dependency config: SSB_PCIHOST_POSSIBLE
 disabling pseudo-config: B43_PCI_AUTOSELECT

 also missing config: CONFIG_SSB_DRIVER_PCICORE
 caused by missing dependency config: SSB_DRIVER_PCICORE_POSSIBLE
 which is missing because of missing dependency config: SSB_PCIHOST
 which is missing because of missing dependency config: SSB_PCIHOST_POSSIBLE
 disabling pseudo-config: B43_PCICORE_AUTOSELECT

The responsible config SSB_PCIHOST_POSSIBLE was disabled because
PCI_DRIVERS_LEGACY is not enabled. The PCI_DRIVERS_LEGACY config
dependency was added by the "bad" commit, which was apparently made to
fix build errors that resulted from a change a year ago. The problem,
as far as I can tell, is that the PCI_DRIVERS_LEGACY config is meant
to enable a MIPS-only API, but then it also disables building for
hardware that is not exclusive to MIPS, thus disabling my driver.

A solution would be to revert that commit, but the commit/kconfig
needs to be fixed

Anyways, here is my device details from the working kernel, from the
output of lspci -vv

0c:00.0 Network controller: Broadcom Limited BCM4312 802.11b/g LP-PHY (rev 01)
Subsystem: Dell Wireless 1397 WLAN Mini-Card
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR+ FastB2B- DisINTx-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
SERR- 
Capabilities: [e8] MSI: Enable- Count=1/1 Maskable- 64bit+
Address:   Data: 
Capabilities: [d0] Express (v1) Endpoint, MSI 00
DevCap:MaxPayload 128 bytes, PhantFunc 0, Latency L0s
<4us, L1 unlimited
ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
SlotPowerLimit 6.500W
DevCtl:Report errors: Correctable- Non-Fatal- Fatal- Unsupported-
RlxdOrd- ExtTag+ PhantFunc- AuxPwr- NoSnoop-
MaxPayload 128 bytes, MaxReadReq