[linux-yocto] [PATCH] mtd: spi_nor: fix build issue for S25FL{064|128|256}L

2023-07-20 Thread Ruiqiang Hao via lists.yoctoproject.org
From: Ruiqiang Hao 

commit 4e35f5591b43 (mtd: spi-nor: Use CLSR command for FL-L chips) and
commit c9d6aaec411f (mtd/spi-nor: enable USE_CLSR capability for Cypress
FL-L product family) are based on kernel v5.15, after commit 51c55506a7b1
(mtd: spi-nor: spansion: convert USE_CLSR to a manufacturer flag), there
will be build issue below. According to this commit to fix it.

drivers/mtd/spi-nor/spansion.c: In function 'spi_nor_s25fl_l_sr_ready':
drivers/mtd/spi-nor/spansion.c:554:26: error: 'SNOR_F_USE_CLSR' undeclared 
(first use in this function)
  554 | if (nor->flags & SNOR_F_USE_CLSR && sr[1] & (SR_E_ERR | 
SR_P_ERR)) {
  |  ^~~
drivers/mtd/spi-nor/spansion.c:554:26: note: each undeclared identifier is 
reported only once for each function it appears in
drivers/mtd/spi-nor/spansion.c:560:17: error: implicit declaration of function 
'spi_nor_clear_sr'; did you mean 'spi_nor_read_sr'? 
[-Werror=implicit-function-declaration]
  560 | spi_nor_clear_sr(nor);
  | ^~~~
  | spi_nor_read_sr
drivers/mtd/spi-nor/spansion.c: In function 'spansion_nor_sr_ready_and_clear':
drivers/mtd/spi-nor/spansion.c:588:68: error: too few arguments to function 
'spi_nor_read_id'
  588 | const struct flash_info *tmpinfo = nor->info ? nor->info : 
spi_nor_read_id(nor);
  |
^~~
In file included from drivers/mtd/spi-nor/spansion.c:9:
drivers/mtd/spi-nor/core.h:652:5: note: declared here
  652 | int spi_nor_read_id(struct spi_nor *nor, u8 naddr, u8 ndummy, u8 *id,
  | ^~~

Signed-off-by: Ruiqiang Hao 
---
 drivers/mtd/spi-nor/core.c |  2 +-
 drivers/mtd/spi-nor/core.h |  1 +
 drivers/mtd/spi-nor/spansion.c | 15 +--
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index bde32d0e8e38..dccf4169e301 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -1655,7 +1655,7 @@ static const struct flash_info *spi_nor_match_id(struct 
spi_nor *nor,
return NULL;
 }
 
-static const struct flash_info *spi_nor_detect(struct spi_nor *nor)
+const struct flash_info *spi_nor_detect(struct spi_nor *nor)
 {
const struct flash_info *info;
u8 *id = nor->bouncebuf;
diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
index 290613fd63ae..2f9871751544 100644
--- a/drivers/mtd/spi-nor/core.h
+++ b/drivers/mtd/spi-nor/core.h
@@ -651,6 +651,7 @@ int spi_nor_sr2_bit1_quad_enable(struct spi_nor *nor);
 int spi_nor_sr2_bit7_quad_enable(struct spi_nor *nor);
 int spi_nor_read_id(struct spi_nor *nor, u8 naddr, u8 ndummy, u8 *id,
enum spi_nor_protocol reg_proto);
+const struct flash_info *spi_nor_detect(struct spi_nor *nor);
 int spi_nor_read_sr(struct spi_nor *nor, u8 *sr);
 int spi_nor_sr_ready(struct spi_nor *nor);
 int spi_nor_read_cr(struct spi_nor *nor, u8 *cr);
diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
index b2e220e6b111..18b8f9a564b8 100644
--- a/drivers/mtd/spi-nor/spansion.c
+++ b/drivers/mtd/spi-nor/spansion.c
@@ -441,13 +441,16 @@ static const struct flash_info spansion_nor_parts[] = {
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ) },
{ "s25fl064l",  INFO(0x016017,  0,  64 * 1024, 128)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
-   FIXUP_FLAGS(SPI_NOR_4B_OPCODES | USE_CLSR) },
+   FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
+   MFR_FLAGS(USE_CLSR) },
{ "s25fl128l",  INFO(0x016018,  0,  64 * 1024, 256)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
-   FIXUP_FLAGS(SPI_NOR_4B_OPCODES | USE_CLSR) },
+   FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
+   MFR_FLAGS(USE_CLSR) },
{ "s25fl256l",  INFO(0x016019,  0,  64 * 1024, 512)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
-   FIXUP_FLAGS(SPI_NOR_4B_OPCODES | USE_CLSR) },
+   FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
+   MFR_FLAGS(USE_CLSR) },
{ "s25hl512t",  INFO6(0x342a1a, 0x0f0390, 256 * 1024, 256)
PARSE_SFDP
MFR_FLAGS(USE_CLSR)
@@ -551,13 +554,13 @@ static int spi_nor_s25fl_l_sr_ready(struct spi_nor *nor)
if (ret)
return ret;
 
-   if (nor->flags & SNOR_F_USE_CLSR && sr[1] & (SR_E_ERR | SR_P_ERR)) {
+   if (nor->info->mfr_flags & USE_CLSR && sr[1] & (SR_E_ERR | SR_P_ERR)) {
if (sr[1] & SR_E_ERR)
dev_err(nor->dev, "Erase Error occurred\n");
else
dev_err(nor->dev, "Programming Error occurred\n");
 
-   spi_nor_clear_sr(nor);
+   spansion_nor_clear_sr(nor);
 
/*
   

[linux-yocto][linux-yocto v6.1] fix build issue for s25fl064l

2023-07-20 Thread Ruiqiang Hao via lists.yoctoproject.org
Hi Bruce,

Please help to merge this patch into our linux-yocto repo.

repo:
linux-yocto
branch:
v6.1/standard/cn-sdkv5.15/octeon
v6.1/standard/preempt-rt/cn-sdkv5.15/octeon

Thanks,
Ruiqiang

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12882): 
https://lists.yoctoproject.org/g/linux-yocto/message/12882
Mute This Topic: https://lists.yoctoproject.org/mt/100271680/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[linux-yocto] [PATCH] coresight: tmc: secure-etr: mark the timer as hard interrupt expire mode for RT kernel

2023-07-20 Thread Ruiqiang Hao via lists.yoctoproject.org
From: Ruiqiang Hao 

In function tmc_etr_timer_cance(), we try to cancel an hrtimer in the
interrupt context, this will trigger warning below, mark this hrtimer
as hard interrupt expire mode to solve this problem.

WARNING: CPU: 6 PID: 63 at kernel/softirq.c:163 
__local_bh_disable_ip+0x220/0x24c
Modules linked in: 8021q sch_fq_codel openvswitch nsh nf_conncount nf_nat 
nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4
CPU: 6 PID: 63 Comm: ksoftirqd/6 Not tainted 5.15.120-rt61-yocto-preempt-rt #3
Hardware name: Marvell OcteonTX CN96XX board (DT)
pstate: 004000c9 (nzcv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : __local_bh_disable_ip+0x220/0x24c
lr : hrtimer_cancel_wait_running+0x7c/0x110
sp : 8b4efe10
x29: 8b4efe10 x28: 000102be9080 x27: 8b4eff80
x26: 8e26fa70 x25:  x24: 8b4eff40
x23:  x22:  x21: 0200
x20: 88111944 x19: 000bf3f13ec0 x18: 
x17: 800bea62 x16: 8b4e x15: 13b81b7517e6
x14: 004f10fcbc83e338 x13: 89051530 x12: eac0c6e6
x11: 00020009 x10: bcbc83c7 x9 : 8811195c
x8 : 89fa6990 x7 :  x6 : 000102be9c48
x5 : 8ab60416 x4 : 00010001 x3 : 89720008
x2 : 0001 x1 : 0200 x0 : 88111944
Call trace:
 __local_bh_disable_ip+0x220/0x24c
 hrtimer_cancel_wait_running+0x7c/0x110
 hrtimer_cancel+0x44/0x70
 tmc_etr_timer_cancel+0x34/0x70
 flush_smp_call_function_queue+0x16c/0x340
 generic_smp_call_function_single_interrupt+0x1c/0x30
 do_handle_IPI+0x74/0x330
 ipi_handler+0x24/0x34
 handle_percpu_devid_irq+0xb0/0x174
 handle_domain_irq+0xa0/0xec
 gic_handle_irq+0x64/0xdc
 call_on_irq_stack+0x20/0x2c
 do_interrupt_handler+0x5c/0x68
 el1_interrupt+0x30/0x150
 el1h_64_irq_handler+0x18/0x24
 el1h_64_irq+0x78/0x7c
 seqcount_lockdep_reader_access.constprop.0+0xbc/0x100
 ktime_get+0x3c/0x120
 tmc_etr_timer_handler_percore+0x34/0x6c
 __run_hrtimer+0xe0/0x34c
 __hrtimer_run_queues+0xbc/0x164
 hrtimer_run_softirq+0x90/0xd0
 __do_softirq+0x13c/0x51c
 run_ksoftirqd+0xd4/0x14c
 smpboot_thread_fn+0x290/0x350
 kthread+0x164/0x170
 ret_from_fork+0x10/0x20

Signed-off-by: Ruiqiang Hao 
---
 drivers/hwtracing/coresight/coresight-tmc-secure-etr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-tmc-secure-etr.c 
b/drivers/hwtracing/coresight/coresight-tmc-secure-etr.c
index 60849e91c546..59bee8fd2279 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-secure-etr.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-secure-etr.c
@@ -167,7 +167,7 @@ void tmc_etr_timer_init(struct tmc_drvdata *drvdata)
 
timer = coresight_get_etm_sync_mode() == SYNC_MODE_SW_GLOBAL ?
tmc_etr_tsync_global_timer() : >timer;
-   hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
+   hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_HARD);
 }
 
 /* Timer setup API common for both global and per core mode
@@ -203,7 +203,7 @@ void tmc_etr_timer_start(void *data)
tmc_etr_timer_handler_global : tmc_etr_timer_handler_percore;
dev_dbg(>csdev->dev, "Starting sync timer, mode:%s period:%lld 
ns\n",
mode_global ? "global" : "percore", tick);
-   hrtimer_start(timer, ns_to_ktime(tick), HRTIMER_MODE_REL_PINNED);
+   hrtimer_start(timer, ns_to_ktime(tick), HRTIMER_MODE_REL_PINNED_HARD);
 }
 
 /* Timer cancel API common for both global and per core mode
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12881): 
https://lists.yoctoproject.org/g/linux-yocto/message/12881
Mute This Topic: https://lists.yoctoproject.org/mt/100271671/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[linux-yocto][linux-yocto v5.15] kernel code for marvell cn96xx

2023-07-20 Thread Ruiqiang Hao via lists.yoctoproject.org
Hi Bruce,

Please help to merge this patch into our linux-yocto repo.

repo:
linux-yocto
branch:
v5.15/standard/cn-sdkv5.4/octeon
v5.15/standard/preempt-rt/cn-sdkv5.4/octeon

Thanks,
Ruiqiang

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12880): 
https://lists.yoctoproject.org/g/linux-yocto/message/12880
Mute This Topic: https://lists.yoctoproject.org/mt/100271670/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[linux-yocto] Trial merge of v6.1.39 for linux-yocto

2023-07-20 Thread Kevin Hao
Hi Bruce,

This is a trial merge of the stable kernel v6.1.39 for the following branches 
in the linux-yocto.
  c15aedac6560  v6.1/standard/base
  05252966a8da  v6.1/standard/preempt-rt/base   
 #Have textual conflicts
  203bcd45f90c  v6.1/standard/ti-sdk-6.1/ti-j7xxx
  0040816c8c4b  v6.1/standard/preempt-rt/ti-sdk-6.1/ti-j7xxx
 #Have textual conflicts
  1ba4f7be  v6.1/standard/nxp-sdk-6.1/nxp-soc   
 #Have textual conflicts
  27db06c3eb69  v6.1/standard/preempt-rt/nxp-sdk-6.1/nxp-soc
 #Have textual conflicts
  b8e1985498e0  v6.1/standard/cn-sdkv5.15/octeon
 #Have textual conflicts
  0a48762a7eaf  v6.1/standard/preempt-rt/cn-sdkv5.15/octeon 
 #Have textual conflicts
  4e9ca7028c63  v6.1/standard/bcm-2xxx-rpi  
 #Have textual and semantic conflicts
  cf277331fd11  v6.1/standard/preempt-rt/bcm-2xxx-rpi   
 #Have textual and semantic conflicts
  b5a8248a926c  v6.1/standard/nxp-sdk-5.15/nxp-s32g
  c7a73778d2f1  v6.1/standard/preempt-rt/nxp-sdk-5.15/nxp-s32g  
 #Have textual conflicts
  03a9ebef451a  v6.1/standard/intel-sdk-6.1/intel-socfpga   
 #Have textual conflicts
  7bab4820cbe3  v6.1/standard/preempt-rt/intel-sdk-6.1/intel-socfpga
 #Have textual conflicts
  bcc2fb463237  v6.1/standard/x86
  b5b938edc4f1  v6.1/standard/preempt-rt/x86
 #Have textual conflicts
  ca5e4cce220f  v6.1/standard/sdkv6.1/xlnx-soc  
 #Have textual conflicts
  13f75d49c376  v6.1/standard/preempt-rt/sdkv6.1/xlnx-soc   
 #Have textual conflicts

The v6.1.39 is a rather significant release, consisting of 588 patches. As 
expected,
it also brings along a substantial number of nasty merge conflicts. I hope I 
have
correctly resolved every merge conflict. I also observed a build failure on the
octeon branches, but it has nothing to do with the stable release and Ruiqiang 
is
working on it. All the branches have passed my build test. I have pushed all 
these
branches to:
https://github.com/haokexin/linux

You can use this as a reference for the linux-yocto stable kernel bump.

Thanks,
Kevin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12879): 
https://lists.yoctoproject.org/g/linux-yocto/message/12879
Mute This Topic: https://lists.yoctoproject.org/mt/100271615/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [linux-yocto]: [kernel for intel-socfpga]: usb: dwc2: add new compatible for Intel SoCFPGA Stratix10 platform

2023-07-20 Thread Meng Li via lists.yoctoproject.org


> -Original Message-
> From: Bruce Ashfield 
> Sent: Friday, July 21, 2023 5:07 AM
> To: Li, Meng 
> Cc: linux-yocto@lists.yoctoproject.org
> Subject: Re: [linux-yocto]: [kernel for intel-socfpga]: usb: dwc2: add new
> compatible for Intel SoCFPGA Stratix10 platform
> 
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
> 
> On Mon, Jul 17, 2023 at 11:50 PM Meng Li  wrote:
> >
> > From: Limeng 
> >
> > Hi Bruce,
> >
> > This patch is used to add new compatible for Intel SoCFPGA Stratix10
> > platform Could you please help to merge it into linux-ycoto kernel
> > repo, both standard and rt branches
> > v6.1/standard/intel-sdk-6.1/intel-socfpga
> > v6.1/standard/preempt-rt/intel-sdk-6.1/intel-socfpga
> 
> merged.
> 
> If I grabbed the wrong version, send an incremental patch. When upstream
> finally accepts it, also send an incremental patch!
> 

Ok!
Got it.

Thanks,
LImeng

> Bruce
> 
> >
> > diffstat info as below:
> >
> >  socfpga_stratix10.dtsi |4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >
> > thanks,
> > Limeng
> 
> 
> 
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee at
> its end
> - "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12878): 
https://lists.yoctoproject.org/g/linux-yocto/message/12878
Mute This Topic: https://lists.yoctoproject.org/mt/100209590/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [linux-yocto] [PATCH] leds : do not enable CONFIG_LEDS_TRIGGER_GPIO by default

2023-07-20 Thread Bruce Ashfield
Indeed!

This is merged to 6.4 and master.

Brue

In message: [PATCH] leds : do not enable CONFIG_LEDS_TRIGGER_GPIO by default
on 20/07/2023 Yogesh Tyagi wrote:

> Following commit marked GPIO LED trigger driver 'broken'from 6.4 onward
> https://github.com/torvalds/linux/commit/8f0adae1cb1a3cf83e38dd435831baa38dd84b4c
> 
> Having CONFIG_LEDS_TRIGGER_GPIO enabled by default is causing below warning 
> during build:
> 
> WARNING: linux-intel-6.4.0+gitAUTOINC+de40822021_9bcda79692-r0 
> do_kernel_configcheck: [kernel config]: specified values did not make it into 
> the kernel's final configuration:
> 
> [NOTE]: 'CONFIG_LEDS_TRIGGER_GPIO' last val (y) and .config val (n) do 
> not match
> [INFO]: CONFIG_LEDS_TRIGGER_GPIO : n
> [INFO]: raw config text:
> 
> config LEDS_TRIGGER_GPIO
>   tristate "LED GPIO Trigger"
>   depends on (GPIOLIB || COMPILE_TEST) && BROKEN && LEDS_TRIGGERS 
> && NEW_LEDS
>   help
> This allows LEDs to be controlled by gpio events. It's good
> when using gpios as switches and triggering the needed LEDs
> from there. One use case is n810's keypad LEDs that could
> be triggered by this trigger when user slides up to show
> keypad.
> 
> If unsure, say N.
> 
> Config 'LEDS_TRIGGER_GPIO' has the following Direct dependencies 
> (LEDS_TRIGGER_GPIO=n):
> GPIOLIB(=y) || COMPILE_TEST(=n) (=y) && BROKEN(=n) && 
> LEDS_TRIGGERS(=y) && NEW_LEDS(=y)
> Parent dependencies are:
>  BROKEN [n] LEDS_TRIGGERS [y] COMPILE_TEST [n] GPIOLIB [y] 
> NEW_LEDS [y]
> [INFO]: config 'CONFIG_LEDS_TRIGGER_GPIO' was set, but it wasn't 
> assignable, check (parent) dependencies
> 
> So let's not enable it by default.
> 
> Signed-off-by: Yogesh Tyagi 
> ---
>  features/leds/leds.cfg | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/features/leds/leds.cfg b/features/leds/leds.cfg
> index eb40627c..33f3da76 100644
> --- a/features/leds/leds.cfg
> +++ b/features/leds/leds.cfg
> @@ -13,4 +13,3 @@ CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>  # Include them here, but they won't be enabled unless GPIO is explicitly
>  # enabled as well.
>  CONFIG_LEDS_GPIO=y
> -CONFIG_LEDS_TRIGGER_GPIO=y
> -- 
> 2.34.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12877): 
https://lists.yoctoproject.org/g/linux-yocto/message/12877
Mute This Topic: https://lists.yoctoproject.org/mt/100253175/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: 
https://lists.yoctoproject.org/g/linux-yocto/leave/6687884/21656/624485779/xyzzy
 [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [linux-yocto]: [kernel for intel-socfpga]: usb: dwc2: add new compatible for Intel SoCFPGA Stratix10 platform

2023-07-20 Thread Bruce Ashfield
On Mon, Jul 17, 2023 at 11:50 PM Meng Li  wrote:
>
> From: Limeng 
>
> Hi Bruce,
>
> This patch is used to add new compatible for Intel SoCFPGA Stratix10 platform
> Could you please help to merge it into linux-ycoto kernel repo, both standard 
> and rt branches
> v6.1/standard/intel-sdk-6.1/intel-socfpga
> v6.1/standard/preempt-rt/intel-sdk-6.1/intel-socfpga

merged.

If I grabbed the wrong version, send an incremental patch. When
upstream finally accepts it, also send an incremental patch!

Bruce

>
> diffstat info as below:
>
>  socfpga_stratix10.dtsi |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> thanks,
> Limeng



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12876): 
https://lists.yoctoproject.org/g/linux-yocto/message/12876
Mute This Topic: https://lists.yoctoproject.org/mt/100209590/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: 
https://lists.yoctoproject.org/g/linux-yocto/leave/6687884/21656/624485779/xyzzy
 [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[linux-yocto] [PATCH] leds : do not enable CONFIG_LEDS_TRIGGER_GPIO by default

2023-07-20 Thread Yogesh Tyagi
Following commit marked GPIO LED trigger driver 'broken'from 6.4 onward
https://github.com/torvalds/linux/commit/8f0adae1cb1a3cf83e38dd435831baa38dd84b4c

Having CONFIG_LEDS_TRIGGER_GPIO enabled by default is causing below warning 
during build:

WARNING: linux-intel-6.4.0+gitAUTOINC+de40822021_9bcda79692-r0 
do_kernel_configcheck: [kernel config]: specified values did not make it into 
the kernel's final configuration:

[NOTE]: 'CONFIG_LEDS_TRIGGER_GPIO' last val (y) and .config val (n) do not 
match
[INFO]: CONFIG_LEDS_TRIGGER_GPIO : n
[INFO]: raw config text:

config LEDS_TRIGGER_GPIO
tristate "LED GPIO Trigger"
depends on (GPIOLIB || COMPILE_TEST) && BROKEN && LEDS_TRIGGERS 
&& NEW_LEDS
help
  This allows LEDs to be controlled by gpio events. It's good
  when using gpios as switches and triggering the needed LEDs
  from there. One use case is n810's keypad LEDs that could
  be triggered by this trigger when user slides up to show
  keypad.

  If unsure, say N.

Config 'LEDS_TRIGGER_GPIO' has the following Direct dependencies 
(LEDS_TRIGGER_GPIO=n):
GPIOLIB(=y) || COMPILE_TEST(=n) (=y) && BROKEN(=n) && 
LEDS_TRIGGERS(=y) && NEW_LEDS(=y)
Parent dependencies are:
 BROKEN [n] LEDS_TRIGGERS [y] COMPILE_TEST [n] GPIOLIB [y] NEW_LEDS 
[y]
[INFO]: config 'CONFIG_LEDS_TRIGGER_GPIO' was set, but it wasn't 
assignable, check (parent) dependencies

So let's not enable it by default.

Signed-off-by: Yogesh Tyagi 
---
 features/leds/leds.cfg | 1 -
 1 file changed, 1 deletion(-)

diff --git a/features/leds/leds.cfg b/features/leds/leds.cfg
index eb40627c..33f3da76 100644
--- a/features/leds/leds.cfg
+++ b/features/leds/leds.cfg
@@ -13,4 +13,3 @@ CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
 # Include them here, but they won't be enabled unless GPIO is explicitly
 # enabled as well.
 CONFIG_LEDS_GPIO=y
-CONFIG_LEDS_TRIGGER_GPIO=y
-- 
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12875): 
https://lists.yoctoproject.org/g/linux-yocto/message/12875
Mute This Topic: https://lists.yoctoproject.org/mt/100253175/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-