Re: [Linux-zigbee-devel] [PATCH 0/3] Patches to 6lowpan.c to fix link-local address uncompression

2013-04-12 Thread Tony Cheneau
Hi,

Replying to myself again. I made some tests, using only Link-Local 
addresses this time. Ping worked just fine (between two Linux host and 
between a Contiki mote and a Linux host). I did not test other transport 
protocols, as they should not be affected by the patchset anyway.

Regards,
Tony


Le 2013-04-11 22:26, Tony Cheneau a écrit :
> Hi,
>
> Replying to myself. Christophe's email made me realize that I use
> additional Link-Local addresses that are not obtained through SLAAC.
> This means that my test between the two Linux hosts are completely
> useless (as it might have not made any use of your new code). I'll
> perform some additional tests tonight and let you know the outcome.
> The test I performed with Contiki stands, because it verifies that a
> Linux host can understand a compressed header sent from a
> Contiki-enabled mote.
>
> As a side note, I read RFC 4944 and RFC 6282 (this is what you
> implemented actually) and I'd say the current code pretty much follow
> the standard. I'm not too sure it would work well with short 
> addresses,
> but that not part of your patch anyway. The whole address 
> uncompression
> would need to be rewritten IMHO (and I believe Alexander Arig is on 
> it).
>
> Regards,
> Tony
>
> Le 2013-04-11 15:57, Tony Cheneau a écrit :
>> Hi Ralph,
>>
>> First, thank you for your patches. I've tested them yesterday.
>> Because
>> I didn't had enough hardware to perform a proper packet capture, so 
>> I
>> just checked the connectivity.
>>
>> I could run all my regression tests (ICMP, TCP, UDP, varying packet
>> length) between two linux hosts with your patches applied. They all
>> passed and looked fine.
>>
>> I could also do basic interrop with Contiki (yeah!). Using one linux
>> host with your patches, I could ping a Contiki device on its
>> Link-Local
>> Address (I could not ping the global address though, but I guess 
>> it's
>> not supposed to be fixed by this patch, and I'll need to look more
>> into
>> it). I did not modify the Contiki example much, so I could not check
>> that UDP/TCP would work as well (those are done using the global
>> addresses by default). Still, I can also confirm that without the
>> patches, the ping echo requests are just not answered.
>>
>>  From a functional perspective, your patches look fine. I didn't
>> checked
>> that your patches are good from a logical point of view (making sure
>> they indeed match the RFC better). I'll try to read both RFC 4944 
>> and
>> RFC 6282 today, and provide additional comments.
>>
>> Regards,
>> Tony
>>
>>
>> Le 2013-04-11 13:51, Ralph Droms a écrit :
>>> These patches fix link-local address uncompression, for both source
>>> and destination addresses.
>>>
>>> - Ralph
>>>
>>> Ralph Droms (3):
>>>   net/ieee802154: 6lowpan.c: Fixes for stateless address
>>> decompression
>>> to use MAC address
>>>   net/ieee802154: 6lowpan.c: This patch fixes source address
>>> uncompression to send the MAC address to lowpan_uncompress_addr
>>>   net/ieee802154: 6lowpan.c: This patch fixes destination address
>>> uncompression to send the MAC address to lowpan_uncompress_addr
>>>
>>>  net/ieee802154/6lowpan.c |   53
>>> +++--
>>>  1 files changed, 32 insertions(+), 21 deletions(-)
>>
>>
>> 
>> --
>> Precog is a next-generation analytics platform capable of advanced
>> analytics on semi-structured data. The platform includes APIs for
>> building
>> apps and a phenomenal toolset for data science. Developers can use
>> our toolset for easy data analysis & visualization. Get a free
>> account!
>> http://www2.precog.com/precogplatform/slashdotnewsletter
>> ___
>> Linux-zigbee-devel mailing list
>> Linux-zigbee-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
>
> 
> --
> Precog is a next-generation analytics platform capable of advanced
> analytics on semi-structured data. The platform includes APIs for 
> building
> apps and a phenomenal toolset for data science. Developers can use
> our toolset for easy data analysis & visualization. Get a free 
> account!
> http://www2.precog.com/precogplatform/slashdotnewsletter
> ___
> Linux-zigbee-devel mailing list
> Linux-zigbee-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

--
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter

Re: [Linux-zigbee-devel] [PATCH 0/3] Patches to 6lowpan.c to fix link-local address uncompression

2013-04-12 Thread Ralph Droms (rdroms)
I neglected to cc linux-zigbee-devel@lists.sourceforge.net in my original reply.

- Ralph

> 
> Le 11.04.2013 18:59, Ralph Droms (rdroms) a écrit :
>> 
>> On Apr 11, 2013, at 10:33 AM 4/11/13, Christophe Aeschlimann 
>> 
>> wrote:
>> 
>>> Hi Ralph,
>>> 
>>> Le 11.04.2013 13:51, Ralph Droms a écrit :
 
 These patches fix link-local address uncompression, for both source
 and destination addresses.
 
 - Ralph
 
 Ralph Droms (3):
 net/ieee802154: 6lowpan.c: Fixes for stateless address decompression
   to use MAC address
 net/ieee802154: 6lowpan.c: This patch fixes source address
   uncompression to send the MAC address to lowpan_uncompress_addr
 net/ieee802154: 6lowpan.c: This patch fixes destination address
   uncompression to send the MAC address to lowpan_uncompress_addr
 
 net/ieee802154/6lowpan.c |   53 
 +++--
 1 files changed, 32 insertions(+), 21 deletions(-)
>>> 
>>> The patches fix the "ICMPv6 checksum failed" I was getting when using
>>> SLAAC addresses.
>>> 
>>> The patches content look ok for me apart from a few minor typos (RFC
>>> number and "contex" which is missing a "t". I would also suggest making
>>> the patch title a bit less verbose.
>> 
>> OK, thanks.  I know of at least one diagnostic "pr_debug" that should be 
>> fixed, as well.
>> 
>> I'll take a look at some other patches and update the titles for these 
>> patches.
>> 
>>> 
>>> Please note that this patch doesn't allow me to use fragmented packets
>>> when using SLAAC addresses. e.g.
>>> 
>>> $ping6 -s 4 fe80::200:0:0:1%lowpan0   => WORKS OK
>>> $ping6 -s 200 fe80::200:0:0:1%lowpan0 => DOESN'T WORK
>>> 
>>> But if I add another "link-local" address to the 6lowpan interface on
>>> each system:
>>> 
>>> system 1 : $ip -6 addr add dev lowpan0 fe80::1
>>> system 2 : $ip -6 addr add dev lowpan0 fe80::2
>>> 
>>> Then  from system 2 :
>>> 
>>> $ping6 -s 4 fe80::1%lowpan0=> WORKS OK
>>> $ping6 -s 200 fe80::1%lowpan0  => WORKS OK
>>> 
>>> I don't have the hardware to test contiki's interoperability.
>> 
>> Fragmentation in 6lowpan.c is not RFC 4944 compliant.  Fragmentation may 
>> work between linux systems using 6lowpan.c, but those implementations won't 
>> interoperate with other implementations and wireshark flags these packets as 
>> in error.
>> 
>> In this particular case, lowpan_alloc_new_frame doesn't copy the MAC 
>> addresses from the received fragment into the reassembly skb, so the 
>> link-local uncompression code can't reconstruct the link-local address.
>> 
>> I have a fix for this problem in a patch I hope to publish for review soon.  
>> This patch also fixes the code so the offset is handled in compliance with 
>> RFC 4944.
>> 
>> - Ralph
> 
> 
> -- 
> Christophe Aeschlimann
> 
> Embedded Software Engineer & IT Manager
> ACN Advanced Communications Networks S.A.
> 2000 - Neuchâtel, Switzerland
> Tel. +41 32 724 74 31

--
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
___
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel


Re: [Linux-zigbee-devel] [PATCH 1/2 v2] at86rf230: add irq type configuration option

2013-04-12 Thread David Miller
From: Sascha Herrmann 
Date: Fri, 12 Apr 2013 00:16:13 +0200

>  static int at86rf230_hw_init(struct at86rf230_local *lp)
>  {
>   u8 status;
> - int rc;
> + int rc, irq_pol;
> + struct at86rf230_platform_data *pdata = lp->spi->dev.platform_data;

Please order local variable declarations from longest line to
shortest line, not the other way around.

Thanks.

--
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
___
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel