I neglected to cc linux-zigbee-devel@lists.sourceforge.net in my original reply.
- Ralph > > Le 11.04.2013 18:59, Ralph Droms (rdroms) a écrit : >> >> On Apr 11, 2013, at 10:33 AM 4/11/13, Christophe Aeschlimann >> <c.aeschlim...@acn-group.ch> >> wrote: >> >>> Hi Ralph, >>> >>> Le 11.04.2013 13:51, Ralph Droms a écrit : >>>> >>>> These patches fix link-local address uncompression, for both source >>>> and destination addresses. >>>> >>>> - Ralph >>>> >>>> Ralph Droms (3): >>>> net/ieee802154: 6lowpan.c: Fixes for stateless address decompression >>>> to use MAC address >>>> net/ieee802154: 6lowpan.c: This patch fixes source address >>>> uncompression to send the MAC address to lowpan_uncompress_addr >>>> net/ieee802154: 6lowpan.c: This patch fixes destination address >>>> uncompression to send the MAC address to lowpan_uncompress_addr >>>> >>>> net/ieee802154/6lowpan.c | 53 >>>> +++++++++++++++++++++++++++------------------ >>>> 1 files changed, 32 insertions(+), 21 deletions(-) >>> >>> The patches fix the "ICMPv6 checksum failed" I was getting when using >>> SLAAC addresses. >>> >>> The patches content look ok for me apart from a few minor typos (RFC >>> number and "contex" which is missing a "t". I would also suggest making >>> the patch title a bit less verbose. >> >> OK, thanks. I know of at least one diagnostic "pr_debug" that should be >> fixed, as well. >> >> I'll take a look at some other patches and update the titles for these >> patches. >> >>> >>> Please note that this patch doesn't allow me to use fragmented packets >>> when using SLAAC addresses. e.g. >>> >>> $ping6 -s 4 fe80::200:0:0:1%lowpan0 => WORKS OK >>> $ping6 -s 200 fe80::200:0:0:1%lowpan0 => DOESN'T WORK >>> >>> But if I add another "link-local" address to the 6lowpan interface on >>> each system: >>> >>> system 1 : $ip -6 addr add dev lowpan0 fe80::1 >>> system 2 : $ip -6 addr add dev lowpan0 fe80::2 >>> >>> Then from system 2 : >>> >>> $ping6 -s 4 fe80::1%lowpan0 => WORKS OK >>> $ping6 -s 200 fe80::1%lowpan0 => WORKS OK >>> >>> I don't have the hardware to test contiki's interoperability. >> >> Fragmentation in 6lowpan.c is not RFC 4944 compliant. Fragmentation may >> work between linux systems using 6lowpan.c, but those implementations won't >> interoperate with other implementations and wireshark flags these packets as >> in error. >> >> In this particular case, lowpan_alloc_new_frame doesn't copy the MAC >> addresses from the received fragment into the reassembly skb, so the >> link-local uncompression code can't reconstruct the link-local address. >> >> I have a fix for this problem in a patch I hope to publish for review soon. >> This patch also fixes the code so the offset is handled in compliance with >> RFC 4944. >> >> - Ralph > > > -- > Christophe Aeschlimann > > Embedded Software Engineer & IT Manager > ACN Advanced Communications Networks S.A. > 2000 - Neuchâtel, Switzerland > Tel. +41 32 724 74 31 ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
