Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER
On Wed, Oct 04, 2017 at 04:27:04PM -0700, Kees Cook wrote: > Subject: [PATCH 10/13] timer: Remove expires and data arguments from > DEFINE_TIMER > > Drop the arguments from the macro and adjust all callers with the > following script: > > perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \ > $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h) > > Signed-off-by: Kees Cook <keesc...@chromium.org> > Acked-by: Geert Uytterhoeven <ge...@linux-m68k.org> # for m68k parts > --- > arch/arm/mach-ixp4xx/dsmg600-setup.c | 2 +- > arch/arm/mach-ixp4xx/nas100d-setup.c | 2 +- > arch/m68k/amiga/amisound.c| 2 +- > arch/m68k/mac/macboing.c | 2 +- > arch/mips/mti-malta/malta-display.c | 2 +- > arch/parisc/kernel/pdc_cons.c | 2 +- > arch/s390/mm/cmm.c| 2 +- > drivers/atm/idt77105.c| 4 ++-- > drivers/atm/iphase.c | 2 +- > drivers/block/ataflop.c | 8 > drivers/char/dtlk.c | 2 +- > drivers/char/hangcheck-timer.c| 2 +- > drivers/char/nwbutton.c | 2 +- > drivers/char/rtc.c| 2 +- > drivers/input/touchscreen/s3c2410_ts.c| 2 +- > drivers/net/cris/eth_v10.c| 6 +++--- > drivers/net/hamradio/yam.c| 2 +- > drivers/net/wireless/atmel/at76c50x-usb.c | 2 +- > drivers/staging/speakup/main.c| 2 +- > drivers/staging/speakup/synth.c | 2 +- > drivers/tty/cyclades.c| 2 +- > drivers/tty/isicom.c | 2 +- > drivers/tty/moxa.c| 2 +- > drivers/tty/rocket.c | 2 +- > drivers/tty/vt/keyboard.c | 2 +- > drivers/tty/vt/vt.c | 2 +- > drivers/watchdog/alim7101_wdt.c | 2 +- > drivers/watchdog/machzwd.c| 2 +- > drivers/watchdog/mixcomwd.c | 2 +- > drivers/watchdog/sbc60xxwdt.c | 2 +- > drivers/watchdog/sc520_wdt.c | 2 +- > drivers/watchdog/via_wdt.c| 2 +- > drivers/watchdog/w83877f_wdt.c| 2 +- > drivers/xen/grant-table.c | 2 +- > fs/pstore/platform.c | 2 +- > include/linux/timer.h | 4 ++-- > kernel/irq/spurious.c | 2 +- > lib/random32.c| 2 +- > net/atm/mpc.c | 2 +- > net/decnet/dn_route.c | 2 +- > net/ipv6/ip6_flowlabel.c | 2 +- > net/netrom/nr_loopback.c | 2 +- > security/keys/gc.c| 2 +- > sound/oss/midibuf.c | 2 +- > sound/oss/soundcard.c | 2 +- > sound/oss/sys_timer.c | 2 +- > sound/oss/uart6850.c | 2 +- > 47 files changed, 54 insertions(+), 54 deletions(-) Acked-by: Ralf Baechle <r...@linux-mips.org> Thanks, Ralf
Re: [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER
On Wed, Oct 04, 2017 at 04:27:03PM -0700, Kees Cook wrote: > Subject: [PATCH 09/13] timer: Remove users of expire and data arguments to > DEFINE_TIMER > > The expire and data arguments of DEFINE_TIMER are only used in two places > and are ignored by the code (malta-display.c only uses mod_timer(), > never add_timer(), so the preset expires value is ignored). Set both > sets of arguments to zero. > > Cc: Ralf Baechle <r...@linux-mips.org> > Cc: Wim Van Sebroeck <w...@iguana.be> > Cc: Guenter Roeck <li...@roeck-us.net> > Cc: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: linux-m...@linux-mips.org > Cc: linux-watch...@vger.kernel.org > Signed-off-by: Kees Cook <keesc...@chromium.org> > --- > arch/mips/mti-malta/malta-display.c | 6 +++--- > drivers/watchdog/alim7101_wdt.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) For malta-display: Acked-by: Ralf Baechle <r...@linux-mips.org> Ralf
Re: [PATCH 1/4] PCI: Remove redundant pcibios_set_master() declarations
On Thu, Oct 05, 2017 at 03:38:42PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelg...@google.com> > > All users of pcibios_set_master() include , which already has > a declaration. Remove the unnecessary declarations from the > files. > > Signed-off-by: Bjorn Helgaas <bhelg...@google.com> > --- > arch/alpha/include/asm/pci.h |2 -- > arch/cris/include/asm/pci.h|1 - > arch/frv/include/asm/pci.h |2 -- > arch/mips/include/asm/pci.h|2 -- > arch/mn10300/include/asm/pci.h |2 -- > arch/parisc/include/asm/pci.h |1 - > arch/sh/include/asm/pci.h |2 -- > arch/x86/include/asm/pci.h |1 - > 8 files changed, 13 deletions(-) For MIPS: Acked-by: Ralf Baechle <r...@linux-mips.org> Ralf
Re: [PATCH 2/4] PCI: Remove redundant pci_dev, pci_bus, resource declarations
On Thu, Oct 05, 2017 at 03:38:49PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelg...@google.com> > > defines struct pci_bus and struct pci_dev and includes the > struct resource definition before including . Nobody includes > directly, so they don't need their own declarations. > > Remove the redundant struct pci_dev, pci_bus, resource declarations. > > Signed-off-by: Bjorn Helgaas <bhelg...@google.com> For MIPS: Acked-by: Ralf Baechle <r...@linux-mips.org> Ralf
Re: [v3,11/41] mips: reuse asm-generic/barrier.h
On Thu, Jan 14, 2016 at 04:47:53PM -0800, Paul E. McKenney wrote: > So you need to build a different kernel for some types of MIPS systems? Yes. We can't really do without. Classic MIPS code is not relocatable without the complexity of PIC code as used by ELF DSOs - and their performanc penalty. Plus we have a number of architecture revisions ovr the decades, big and little endian, 32 and 64 bit as the major stumbling stones. There however are groups of similar systems that can share kernel binaries. > Or do you do boot-time rewriting, like a number of other arches do? We don't rewrite the code (as in the .text of the vmlinux binary) but we do runtime code generation for a few highly performance sensitive area of the kernel code such as copy_page() or TLB exception handlers. This allows more flexibility than just inserting templates into the kernel code. Downside - it means we have some of the complexity of as and ld in the kernel. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2] arch: use WRITE_ONCE/READ_ONCE in smp_store_release/smp_load_acquire
On Sun, Aug 02, 2015 at 05:11:04PM +0200, Andrey Konovalov wrote:
diff --git a/arch/mips/include/asm/barrier.h b/arch/mips/include/asm/barrier.h
index 7ecba84..752e0b8 100644
--- a/arch/mips/include/asm/barrier.h
+++ b/arch/mips/include/asm/barrier.h
@@ -133,12 +133,12 @@
do { \
compiletime_assert_atomic_type(*p); \
smp_mb(); \
- ACCESS_ONCE(*p) = (v); \
+ WRITE_ONCE(*p, v); \
} while (0)
#define smp_load_acquire(p) \
({ \
- typeof(*p) ___p1 = ACCESS_ONCE(*p); \
+ typeof(*p) ___p1 = READ_ONCE(*p); \
compiletime_assert_atomic_type(*p); \
smp_mb(); \
___p1; \
Acked-by: Ralf Baechle r...@linux-mips.org
Ralf
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH V4 2/6] mm: mlock: Add new mlock, munlock, and munlockall system calls
On Wed, Jul 22, 2015 at 10:15:01AM -0400, Eric B Munson wrote: You haven't wired it up properly on powerpc, but I haven't mentioned it because I'd rather we did it. cheers It looks like I will be spinning a V5, so I will drop all but the x86 system calls additions in that version. The MIPS bits are looking good however, so Acked-by: Ralf Baechle r...@linux-mips.org With my ack, will you keep them or maybe carry them as a separate patch? Cheers, Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 5/7] PCI: Remove unnecessary #includes of asm/pci.h
Acked-by: Ralf Baechle r...@linux-mips.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] of: clean-up unnecessary libfdt include paths
On Wed, Jun 03, 2015 at 12:10:25AM -0500, Rob Herring wrote: Date: Wed, 3 Jun 2015 00:10:25 -0500 From: Rob Herring r...@kernel.org To: devicet...@vger.kernel.org, linux-ker...@vger.kernel.org Cc: Grant Likely grant.lik...@linaro.org, Rob Herring r...@kernel.org, Ralf Baechle r...@linux-mips.org, Benjamin Herrenschmidt b...@kernel.crashing.org, Paul Mackerras pau...@samba.org, Michael Ellerman m...@ellerman.id.au, linux-m...@linux-mips.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH] of: clean-up unnecessary libfdt include paths With the latest dtc import include fixups, it is no longer necessary to add explicit include paths to use libfdt. Remove these across the kernel. Signed-off-by: Rob Herring r...@kernel.org Cc: Ralf Baechle r...@linux-mips.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: Michael Ellerman m...@ellerman.id.au Cc: Grant Likely grant.lik...@linaro.org Cc: linux-m...@linux-mips.org Cc: linuxppc-dev@lists.ozlabs.org For the MIPS bits; Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 3/5] mm/hugetlb: remove arch_prepare/release_hugepage from arch headers
On Thu, May 28, 2015 at 01:52:35PM +0200, Dominik Dingel wrote: Acked-by: Ralf Baechle r...@linux-mips.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v3 16/27] Mips/MSI: Save msi chip in pci sysdata
On Wed, Oct 15, 2014 at 11:07:04AM +0800, Yijing Wang wrote:
+static inline struct msi_chip *pci_msi_chip(struct pci_bus *bus)
+{
+ struct pci_controller *control = (struct pci_controller *)bus-sysdata;
bus-sysdata is void * so this cast is unnecessary.
Ralf
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v3 18/27] MIPS/Xlp: Remove the dead function destroy_irq() to fix build error
Applied, thanks. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2 08/47] kernel: Move pm_power_off to common code
On Mon, Oct 20, 2014 at 09:12:24PM -0700, Guenter Roeck wrote: pm_power_off is defined for all architectures. Move it to common code. Have all architectures call do_kernel_power_off instead of pm_power_off. Some architectures point pm_power_off to machine_power_off. For those, call do_kernel_power_off from machine_power_off instead. Acked-by: David Vrabel david.vra...@citrix.com Acked-by: Geert Uytterhoeven ge...@linux-m68k.org Acked-by: Hirokazu Takata tak...@linux-m32r.org Acked-by: Jesper Nilsson jesper.nils...@axis.com Acked-by: Max Filippov jcmvb...@gmail.com Acked-by: Rafael J. Wysocki r...@rjwysocki.net Acked-by: Richard Weinberger rich...@nod.at Acked-by: Xuetao Guan g...@mprc.pku.edu.cn Signed-off-by: Guenter Roeck li...@roeck-us.net Acked-by: Ralf Baechle r...@linux-mips.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v3] arch: Kconfig: Let all architectures set endian explicitly
On Fri, Aug 15, 2014 at 12:54:53AM +0800, Chen Gang wrote: Normal architectures: - Big endian: avr32, frv, m68k, openrisc, parisc, s390, sparc - Little endian: alpha, blackfin, cris, hexagon, ia64, metag, mn10300, score, unicore32, x86 - Choose in config time: arc, arm, arm64, c6x, m32r, mips, powerpc, sh Nak for MIPS. On MIPS Kconfig already always sets one of CPU_BIG_ENDIAN and CPU_LITTLE_ENDIAN depending on platforms and where both endianess are supported by a platform, user choice: config FOO bool foo select SYS_SUPPORTS_LITTLE_ENDIAN config FOO bool foo select SYS_SUPPORTS_BIG_ENDIAN select SYS_SUPPORTS_LITTLE_ENDIAN [...] choice prompt Endianess selection help Some MIPS machines can be configured for either little or big endian byte order. These modes require different kernels and a different Linux distribution. In general there is one preferred byteorder for a particular system but some systems are just as commonly used in the one or the other endianness. config CPU_BIG_ENDIAN bool Big endian depends on SYS_SUPPORTS_BIG_ENDIAN config CPU_LITTLE_ENDIAN bool Little endian depends on SYS_SUPPORTS_LITTLE_ENDIAN help endchoice So I think you can just drop the MIPS segment from your patch. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void
On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: + if (test_bit(FLAG_REQUESTED, chip-desc[id].flags)) + panic(gpio: removing gpiochip with gpios still requested\n); panic? Is this likely to happen? And while we're at it - panic() is going to add a \n itself so don't pass a string ending in \n to panic(). Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies
On Sat, Dec 14, 2013 at 11:59:36AM -0500, Mark Salter wrote: - depends on !PARISC (!ARM || FOOTBRIDGE_HOST) \ -(!SUPERH || SH_CAYMAN) !M68K !BLACKFIN !S390 \ -!ARC + depends on ARCH_MIGHT_HAVE_PC_SERIO Most dependencies on an architecture's kconfig symbol outside arch/ should probably be treated as a bug. Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 24/34] PCI: use weak functions for MSI arch-specific functions
On Wed, Nov 20, 2013 at 10:50:43AM +0800, Richard Zhu wrote: Looking good, Acked-by: Ralf Baechle r...@linux-mips.org Nevertheless I'd again like to express that I'm not that fond of of the increasing number of weak functions in the kernel. In the old days things were such that when an a platform didn't provice a platform hook or enable a default hook function, one would get a build error - an unmistakable sign to the maintainer that something needs attention. Weak functions mean default functions may result in subtly incorrect operation. Been there, got bitten. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 24/34] PCI: use weak functions for MSI arch-specific functions
On Thu, Nov 21, 2013 at 08:08:04PM +0100, Thomas Petazzoni wrote: I think this patch was mistakenly sent by Richard Zhu. It is already part of mainline since 3.12: Explains the deja vue ... Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2 14/14] Kconfig cleanup (PARPORT_PC dependencies)
On Tue, Oct 08, 2013 at 01:10:30AM -0400, Mark Salter wrote: Remove messy dependencies from PARPORT_PC by having it depend on one Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures which need it, select ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig. New architectures are unlikely to need PARPORT_PC, so this avoids having an ever growing list of architectures to exclude. Those architectures which do select ARCH_MAY_HAVE_PC_PARPORT in this patch are the ones which have an asm/parport.h (or use the generic version). Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2 04/10] irqdomain: Return errors from irq_create_of_mapping()
On Wed, Sep 18, 2013 at 03:24:46PM +0200, Thierry Reding wrote: For the MIPS bits: Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2 07/10] of/irq: Propagate errors in of_irq_to_resource_table()
On Wed, Sep 18, 2013 at 03:24:49PM +0200, Thierry Reding wrote: For the MIPS bits: Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2 38/45] MIPS: Use get/put_online_cpus_atomic() to prevent CPU offline
On Wed, Jun 26, 2013 at 02:02:57AM +0530, Srivatsa S. Bhat wrote:
Once stop_machine() is gone from the CPU offline path, we won't be able
to depend on disabling preemption to prevent CPUs from going offline
from under us.
Use the get/put_online_cpus_atomic() APIs to prevent CPUs from going
offline, while invoking from atomic context.
I think the same change also needs to be applied to r4k_on_each_cpu() in
arch/mips/mm/c-r4k.c which currently looks like:
static inline void r4k_on_each_cpu(void (*func) (void *info), void *info)
{
preempt_disable();
#if !defined(CONFIG_MIPS_MT_SMP) !defined(CONFIG_MIPS_MT_SMTC)
smp_call_function(func, info, 1);
#endif
func(info);
preempt_enable();
}
This is a slightly specialized version of on_each_cpu() which only calls
out to other CPUs in actual multi-core environments and also - unlike
on_each_cpu() doesn't disable interrupts for the sake of better
interrupt latencies.
Which reminds me ...
Andrew, I was wondering why did 78eef01b0fae087c5fadbd85dd4fe2918c3a015f
[[PATCH] on_each_cpu(): disable local interrupts] disable interrupts?
The log is:
- snip -
When on_each_cpu() runs the callback on other CPUs, it runs with local
interrupts disabled. So we should run the function with local interrupts
disabled on this CPU, too.
And do the same for UP, so the callback is run in the same environment on bo
UP and SMP. (strictly it should do preempt_disable() too, but I think
local_irq_disable is sufficiently equivalent).
[...]
- snip -
I'm not entirely convinced the symmetry between UP and SMP environments is
really worth it. Would anybody mind removing the local_irq_disable() ...
local_irq_enable() from on_each_cpu()?
Ralf
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] MIPS: fix bug.h MIPS build regression
On Wed, Jun 20, 2012 at 03:27:59PM +0900, Yoichi Yuasa wrote: Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 breaks all MIPS builds. Thanks, fix applied. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 61/62] highmem: kill all __kmap_atomic()
On Sun, Nov 27, 2011 at 01:27:41PM +0800, Cong Wang wrote: Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 3/5] treewide: Remove useless NORET_TYPE macro and uses
On Thu, Nov 10, 2011 at 01:41:44AM -0800, Joe Perches wrote: arch/mips/include/asm/ptrace.h |2 +- arch/mips/kernel/traps.c |2 +- For the MIPS bits: Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 4/5] treewide: Convert uses of ATTRIB_NORETURN to __noreturn
On Thu, Nov 10, 2011 at 01:41:45AM -0800, Joe Perches wrote: Use the more commonly used __noreturn instead of ATTRIB_NORETURN. Subject and here: s/ATTRIB_NORETURN/ATTRIB_NORET/ Signed-off-by: Joe Perches j...@perches.com --- arch/ia64/kernel/machine_kexec.c |2 +- arch/m68k/amiga/config.c |2 +- arch/mips/include/asm/ptrace.h |2 +- arch/mips/kernel/traps.c |2 +- For the MIPS bits: Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCHv4 01/11] atomic: add *_dec_not_zero
On Wed, Jul 27, 2011 at 11:47:40AM +0200, Sven Eckelmann wrote: For MIPS: Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE
On Thu, Jun 23, 2011 at 12:53:36PM +0100, Martyn Welch wrote: On 23/06/11 12:45, Ralf Baechle wrote: On architectures that don't define PAGE_KERNEL_NOCACHE, the Comedi driver turns into tragedy: CC [M] drivers/staging/comedi/drivers.o drivers/staging/comedi/drivers.c: In function ‘comedi_buf_alloc’: drivers/staging/comedi/drivers.c:505:41: error: ‘PAGE_KERNEL_NOCACHE’ undeclared (first use in this function) drivers/staging/comedi/drivers.c:505:41: note: each undeclared identifier is rep orted only once for each function it appears in make[3]: *** [drivers/staging/comedi/drivers.o] Error 1 Restrict the driver to only those architectures that define PAGE_KERNEL_NOCACHE. PAGE_KERNEL_NOCACHE is a kludge - some system architectures such as SGI IP27 are even uable to offer uncached operation - at least in the way an unwitting driver might assume. I haven't looked in details how the driver is using the area vmaped with PAGE_KERNEL_NOCACHE but maybe doing it XFS-style using cached memory and the flush_kernel_vmap_range / invalidate_kernel_vmap_range APIs in conjunction with the DMA API is a practical alternative. Signed-off-by: Ralf Baechle r...@linux-mips.org drivers/staging/comedi/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig index 1502d80..bccdc12 100644 --- a/drivers/staging/comedi/Kconfig +++ b/drivers/staging/comedi/Kconfig @@ -2,6 +2,7 @@ config COMEDI tristate Data acquisition support (comedi) default N depends on m + depends on BROKEN || FRV || M32R || MN10300 || SUPERH || TILE || X86 I'm sure I got comedi to compile on a 32-bit PPC board not that long ago. Has something changed, or is this just not an exhaustive list? (Adding the PPC folks to cc.) A git grep -w PAGE_KERNEL_NOCACHE arch/powerpc/ doesn't find anything so I don't think the driver will build there. I don't have a PPC toolchain to verify that. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [RFC,PATCH] Cleanup PC parallel port Kconfig
On Tue, Jun 14, 2011 at 09:18:36PM -0700, H. Peter Anvin wrote: On 06/14/2011 03:34 PM, Ralf Baechle wrote: There is no point in offering to build something that couldn't possibly be used. It just makes the kernel harder to configure and inflates the test matrix for no good reason. I see... that's why a bunch of devices that only exist on ARM and MIPS SoCs are offered on x86 platforms? Well, if you notice one of those, yell. Or send patches. Most of those have been fixed. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[RFC,PATCH] Cleanup PC parallel port Kconfig
The PC parallel port Kconfig as acquired one of those messy terms to describe it's architecture dependencies: depends on (!SPARC64 || PCI) !SPARC32 !M32R !FRV \ (!M68K || ISA) !MN10300 !AVR32 !BLACKFIN This isn't just ugly - it also almost certainly describes the dependencies too coarse grainedly. This is an attempt at cleaing the mess up. I tried to faithfully aproximate the old behaviour but the existing behaviour seems inacurate if not wrong for some architectures or platforms. To improve on this I rely on comments from other arch and platforms maintainers. Any system that can take PCI multi-IO card or has a PC-style parallel port on the mainboard should probably should now do a select HAVE_PC_PARPORT. And some arch Kconfig files should further restrict the use of HAVE_PC_PARPORT to only those platforms that actually need it. Thanks, Ralf Signed-off-by: Ralf Baechle r...@linux-mips.org arch/alpha/Kconfig |1 + arch/arm/Kconfig|1 + arch/cris/Kconfig |1 + arch/h8300/Kconfig |1 + arch/ia64/Kconfig |1 + arch/m68k/Kconfig.mmu |1 + arch/microblaze/Kconfig |1 + arch/mips/Kconfig | 16 arch/parisc/Kconfig |1 + arch/powerpc/Kconfig|1 + arch/score/Kconfig |7 --- arch/sh/Kconfig |1 + arch/sparc/Kconfig |1 + arch/tile/Kconfig |1 + arch/unicore32/Kconfig |1 + arch/x86/Kconfig|1 + arch/xtensa/Kconfig |1 + drivers/parport/Kconfig |6 -- 18 files changed, 39 insertions(+), 5 deletions(-) diff --git a/arch/alpha/Kconfig b/arch/alpha/Kconfig index 60219bf..2ba8dd7 100644 --- a/arch/alpha/Kconfig +++ b/arch/alpha/Kconfig @@ -9,6 +9,7 @@ config ALPHA select HAVE_PERF_EVENTS select HAVE_DMA_ATTRS select HAVE_GENERIC_HARDIRQS + select HAVE_PC_PARPORT select GENERIC_IRQ_PROBE select AUTO_IRQ_AFFINITY if SMP select GENERIC_IRQ_SHOW diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 9adc278..2968751f 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -21,6 +21,7 @@ config ARM select HAVE_KERNEL_LZO select HAVE_KERNEL_LZMA select HAVE_IRQ_WORK + select HAVE_PC_PARPORT select HAVE_PERF_EVENTS select PERF_USE_VMALLOC select HAVE_REGS_AND_STACK_ACCESS_API diff --git a/arch/cris/Kconfig b/arch/cris/Kconfig index 17addac..2eda6cf 100644 --- a/arch/cris/Kconfig +++ b/arch/cris/Kconfig @@ -51,6 +51,7 @@ config CRIS default y select HAVE_IDE select HAVE_GENERIC_HARDIRQS + select HAVE_PC_PARPORT select GENERIC_IRQ_SHOW config HZ diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig index 091ed61..da08646 100644 --- a/arch/h8300/Kconfig +++ b/arch/h8300/Kconfig @@ -3,6 +3,7 @@ config H8300 default y select HAVE_IDE select HAVE_GENERIC_HARDIRQS + select HAVE_PC_PARPORT select GENERIC_IRQ_SHOW config SYMBOL_PREFIX diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig index 38280ef..849805a 100644 --- a/arch/ia64/Kconfig +++ b/arch/ia64/Kconfig @@ -23,6 +23,7 @@ config IA64 select HAVE_ARCH_TRACEHOOK select HAVE_DMA_API_DEBUG select HAVE_GENERIC_HARDIRQS + select HAVE_PC_PARPORT select GENERIC_IRQ_PROBE select GENERIC_PENDING_IRQ if SMP select IRQ_PER_CPU diff --git a/arch/m68k/Kconfig.mmu b/arch/m68k/Kconfig.mmu index 16539b1..6db5a3e 100644 --- a/arch/m68k/Kconfig.mmu +++ b/arch/m68k/Kconfig.mmu @@ -399,6 +399,7 @@ config ISA bool depends on Q40 || AMIGA_PCMCIA default y + select PARPORT_PC help Find out whether you have ISA slots on your motherboard. ISA is the name of a bus system, i.e. the way the CPU talks to the other stuff diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig index e446bab..ceac9b5 100644 --- a/arch/microblaze/Kconfig +++ b/arch/microblaze/Kconfig @@ -15,6 +15,7 @@ config MICROBLAZE select OF select OF_EARLY_FLATTREE select HAVE_GENERIC_HARDIRQS + select HAVE_PC_PARPORT select GENERIC_IRQ_PROBE select GENERIC_IRQ_SHOW diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 653da62..51170ba 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -39,6 +39,7 @@ config MIPS_ALCHEMY select 64BIT_PHYS_ADDR select CEVT_R4K_LIB select CSRC_R4K_LIB + select HAVE_PC_PARPORT select IRQ_CPU select SYS_HAS_CPU_MIPS32_R1 select SYS_SUPPORTS_32BIT_KERNEL @@ -127,6 +128,7 @@ config MIPS_COBALT select CSRC_R4K select CEVT_GT641XX select DMA_NONCOHERENT + select HAVE_PC_PARPORT select HW_HAS_PCI select I8253 select I8259 @@ -185,6 +187,7 @@ config MACH_JAZZ select CSRC_R4K select DEFAULT_SGI_PARTITION if CPU_BIG_ENDIAN
Re: [RFC,PATCH] Cleanup PC parallel port Kconfig
On Tue, Jun 14, 2011 at 01:25:46PM -0700, H. Peter Anvin wrote: On 06/14/2011 12:08 PM, Ralf Baechle wrote: The PC parallel port Kconfig as acquired one of those messy terms to describe it's architecture dependencies: depends on (!SPARC64 || PCI) !SPARC32 !M32R !FRV \ (!M68K || ISA) !MN10300 !AVR32 !BLACKFIN This isn't just ugly - it also almost certainly describes the dependencies too coarse grainedly. This is an attempt at cleaing the mess up. I tried to faithfully aproximate the old behaviour but the existing behaviour seems inacurate if not wrong for some architectures or platforms. To improve on this I rely on comments from other arch and platforms maintainers. Any system that can take PCI multi-IO card or has a PC-style parallel port on the mainboard should probably should now do a select HAVE_PC_PARPORT. And some arch Kconfig files should further restrict the use of HAVE_PC_PARPORT to only those platforms that actually need it. Why on earth restrict it like that? It's just a device driver, like more or less any other device driver... Some of the older MIPS systems are based on PC chipsets from Intel, OPTi or others. On those you can expect the parport_pc driver to actually work. The ISA/PCI implementations are often between lackluster and pure brokeness such as with non-functioning I/O port address space. So I don't want to run such drivers on such a platforms, things might turn ugly. Embedded systems often have PCI but no PCI slots or there may even be an apropriate SuperIO chip in the the system but nothing wired to the parallel port bits. And there are systems such as DECstations which have nothing that even at a parsec's distance has a similarity to (E)ISA or PCI - but still PARPORT_PC is offered along with 40 other options that depend on it. There is no point in offering to build something that couldn't possibly be used. It just makes the kernel harder to configure and inflates the test matrix for no good reason. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH -v2] Audit: push audit success and retcode into arch ptrace.h
On Fri, Jun 03, 2011 at 06:04:51PM -0400, Eric Paris wrote: Thanks, this looks good compiles, so: Acked-by: Ralf Baechle r...@linux-mips.org I will rebase my pending MIPS audit patches on top of this patch and resend. Thanks, Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [patch 00/14] Sort out i8253 and PC speaker locking and headers
On Thu, Jun 02, 2011 at 09:11:19PM +0200, Gerhard Pircher wrote:
#if defined(CONFIG_MIPS) || defined(CONFIG_X86)
/* Use the global PIT lock ! */
#include asm/i8253.h
#else
#include asm/8253pit.h
static DEFINE_RAW_SPINLOCK(i8253_lock);
#endif
sound/drivers/pcsp/pcsp.h:
#if defined(CONFIG_MIPS) || defined(CONFIG_X86)
/* Use the global PIT lock ! */
#include asm/i8253.h
#else
#include asm/8253pit.h
static DEFINE_RAW_SPINLOCK(i8253_lock);
$ git grep -F pcsp.h sound/drivers/pcsp
sound/drivers/pcsp/pcsp.c:#include pcsp.h
sound/drivers/pcsp/pcsp_input.c:#include pcsp.h
sound/drivers/pcsp/pcsp_lib.c:#include pcsp.h
sound/drivers/pcsp/pcsp_mixer.c:#include pcsp.h
$ git grep -w i8253_lock sound/drivers/pcsp/
sound/drivers/pcsp/pcsp.h:static DEFINE_RAW_SPINLOCK(i8253_lock);
sound/drivers/pcsp/pcsp_input.c:raw_spin_lock_irqsave(i8253_lock,
flags
sound/drivers/pcsp/pcsp_input.c:
raw_spin_unlock_irqrestore(i8253_lock,
sound/drivers/pcsp/pcsp_lib.c: raw_spin_lock_irqsave(i8253_lock,
flags
sound/drivers/pcsp/pcsp_lib.c:
raw_spin_unlock_irqrestore(i8253_lock,
sound/drivers/pcsp/pcsp_lib.c: raw_spin_lock(i8253_lock);
sound/drivers/pcsp/pcsp_lib.c: raw_spin_unlock(i8253_lock);
sound/drivers/pcsp/pcsp_lib.c: raw_spin_lock(i8253_lock);
sound/drivers/pcsp/pcsp_lib.c: raw_spin_unlock(i8253_lock);
Locks are great, everybody should have their own lock!
$ find . -name 8253pit.h
./arch/powerpc/include/asm/8253pit.h
./arch/alpha/include/asm/8253pit.h
$ cat arch/*/include/asm/8253pit.h
/*
* 8253/8254 Programmable Interval Timer
*/
/*
* 8253/8254 Programmable Interval Timer
*/
$
Eh...
$ git grep -w PCSPKR_PLATFORM
arch/mips/Kconfig: select PCSPKR_PLATFORM
arch/mips/Kconfig: select PCSPKR_PLATFORM
arch/mips/Kconfig: select PCSPKR_PLATFORM
arch/powerpc/platforms/amigaone/Kconfig:select PCSPKR_PLATFORM
drivers/input/misc/Kconfig: depends on PCSPKR_PLATFORM
init/Kconfig:config PCSPKR_PLATFORM
sound/drivers/Kconfig: depends on PCSPKR_PLATFORM X86
HIGH_RES_TIMERS
So the status is:
Alpha: There is no PCSPKR_PLATFORM so while a platform device is
being installed no drivers will be built. I don't know
which Alpha platforms or even if all of Alpha should be
doing a PCSPKR_PLATFORM so I haven't even tried to sort
this.
ARM: No PC speaker supported, yeah :)
PowerPC: Should compile but the locking is wrong but only the
AmigaOne platforms should be affected.
The Kconfig dependencies cleanup patch for CHRP, PSERIES, etc. should
also apply to the AmigaOne. Can you resend it with a fix for the
AmigaOne, or should I send a patch?
I can sort that; it's easy enough.
I'll check next week, if the PC speaker is still working on my AmigaOne.
I can't imagine that it's going to break - the code is sorta simple ;-)
One obscurity I noticed is this bit in the amigaone.dts:
timer@40 {
// Also adds pcspkr to platform devices.
compatible = pnpPNP,100;
reg = 1 0x0040 0x0020;
};
Shouldn't that rather be something like the following?
pcspeaker@61 {
device_type = sound;
compatible = pnpPNP,800;
reg = 1 0x61 1;
};
pnpPNP,100 is the i8253 timer as I understand and pnpPNP,800 the PC speaker.
If you interpret pnpPNP,100 to imply the presence of a PC speaker you can't
express a system that has a i8253 but no PCspeaker in a DT so maybe
amigaone.dts and arch/powerpc/kernel/setup-common.c should be changed to
use pnpPNP,800 instead?
Ralf
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] fix build warnings on defconfigs
On Sun, Apr 10, 2011 at 03:04:18AM +0800, wanlong@gmail.com wrote: Subject: [PATCH] fix build warnings on defconfigs From: Wanlong Gao wanlong@gmail.com Change the BT_L2CAP and BT_SCO defconfigs from 'm' to 'y', since BT_L2CAP and BT_SCO had changed to bool configs. Signed-off-by: Wanlong Gao wanlong@gmail.com I've queued the MIPS bits only for 2.6.40. Thanks. Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] lib: Consolidate DEBUG_STACK_USAGE option
On Fri, May 06, 2011 at 10:57:11PM -0700, Stephen Boyd wrote: Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] atomic: add *_dec_not_zero
On Tue, May 03, 2011 at 11:30:35PM +0200, Sven Eckelmann wrote: arch/mips/include/asm/atomic.h |2 ++ arch/mips/include/asm/local.h |1 + Acked-by: Ralf Baechle r...@linux-mips.org Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 10/14] PM / MIPS: Use struct syscore_ops instead of sysdevs for PM
This patch breaks the Alchemy kernel compile; below patch on top of it fixes
that again.
Signed-off-by: Ralf Baechle r...@linux-mips.org
---
arch/mips/alchemy/common/irq.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-mips/arch/mips/alchemy/common/irq.c
===
--- linux-mips.orig/arch/mips/alchemy/common/irq.c
+++ linux-mips/arch/mips/alchemy/common/irq.c
@@ -619,8 +619,8 @@ static struct syscore_ops alchemy_ic_sys
static int __init alchemy_ic_syscore_init(void)
{
- alchemy_ic_data[0].base = ioremap(icbase[IC0_PHYS_ADDR], 0x1000);
- alchemy_ic_data[1].base = ioremap(icbase[IC1_PHYS_ADDR], 0x1000);
+ alchemy_ic_data[0].base = ioremap(IC0_PHYS_ADDR, 0x1000);
+ alchemy_ic_data[1].base = ioremap(IC1_PHYS_ADDR, 0x1000);
register_syscore_ops(alchemy_ic_syscore_ops);
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/2 v3]Update broken web addresses.
On Tue, Sep 21, 2010 at 06:29:16PM -0700, Justin P. Mattock wrote: Date: Tue, 21 Sep 2010 18:29:16 -0700 From: Justin P. Mattock justinmatt...@gmail.com To: triv...@kernel.org Cc: linux-arm-ker...@lists.infradead.org, linux-ker...@vger.kernel.org, linux-o...@vger.kernel.org, linux-m...@ml.linux-m32r.org, linux-m...@lists.linux-m68k.org, linux-m...@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-lap...@vger.kernel.org, Justin P. Mattock justinmatt...@gmail.com, Maciej W. Rozycki ma...@linux-mips.org, Finn Thain fth...@telegraphics.com.au, Randy Dunlap rdun...@xenotime.net Subject: [PATCH 1/2 v3]Update broken web addresses. Content-Type: text/plain; charset=UTF-8 Patchwork MIME butchers the subject of this patch, see https://patchwork.linux-mips.org/patch/1587/ https://patchwork.kernel.org/patch/198382/ Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [RFC PATCH 0/2] Merge HUGETLB_PAGE and HUGETLBFS Kconfig options
On Thu, Jun 12, 2008 at 02:49:00PM -0400, Adam Litke wrote: There are currently two global Kconfig options that enable/disable the hugetlb code: CONFIG_HUGETLB_PAGE and CONFIG_HUGETLBFS. This may have made sense before hugetlbfs became ubiquitous but now the pair of options are redundant. Merging these two options into one will simplify the code slightly and will, more importantly, avoid confusion and questions like: Which hugetlbfs CONFIG option should my code depend on? CONFIG_HUGETLB_PAGE is aliased to the value of CONFIG_HUGETLBFS, so one option can be removed without any effect. The first patch merges the two options into one option: CONFIG_HUGETLB. The second patch updates the defconfigs to set the one new option appropriately. I have cross-compiled this on i386, x86_64, ia64, powerpc, sparc64 and sh with the option enabled and disabled. This is completely mechanical but, due to the large number of files affected (especially defconfigs), could do well with a review from several sets of eyeballs. Thanks. MIPS doesn't do HUGETLB (at least not in-tree atm) so I'm not sure why [EMAIL PROTECTED] was cc'ed at all. So feel free to add my Couldnt-care-less: ack line ;-) Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH (2.6.25) 2/2] suspend: clean up Kconfig
On Wed, Nov 07, 2007 at 02:58:00PM +0100, Johannes Berg wrote: This cleans up the suspend Kconfig and removes the need to declare centrally which architectures support suspend. All architectures that currently support suspend are modified accordingly. Acked-by: Ralf Baechle [EMAIL PROTECTED] Cheers, Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
