Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

[Richard Holden]

On Nov 30, 2009, at 10:23 PM, Albert Herranz wrote:

> Richard Holden wrote:
>> Albert Herranz wrote:
> The first patch is generic, and uses PPC_EARLY_DEBUG.
> This is the first patch where PPC_EARLY_DEBUG_USBGECKO is referenced.

Sorry, you are correct.

>>> diff --git a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c 
>>> b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
>>> index ba4c7cc..3f125b6 100644
>>> --- a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
>>> +++ b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
>>> @@ -17,6 +17,7 @@
>>> #include 
>>> #include 
>>> #include 
>>> +#include 
>>> 
>>> #include "usbgecko_udbg.h"
>>> 
>>> @@ -270,3 +271,61 @@ done:
>>> of_node_put(np);
>>> return;
>>> }
>>> +
>>> +#ifdef CONFIG_PPC_EARLY_DEBUG_USBGECKO
>>> +
>>> +static void __init ug_early_remap(void)
>> 
>> you may want to rename the ug_ prefix, it took me a while looking back
>> and forth through the patch to convince myself it wasn't a typo.
>> 
> 
> What's wrong with ug_ ? (ug = (u)sb(g)ecko)
> 

At first look I thought it was a typo of udbg_early_remap. I prefer the longer 
names although we could use gecko_early_remap unless the gecko prefix conflicts 
with anything else. If there is not going to be a non usb gecko then there is 
no need to have usb in the prefix.

-Richard Holden
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

[Richard Holden]

Albert Herranz wrote:
> Add support for using the USB Gecko adapter as an early debugging
> console on the Nintendo GameCube and Wii video game consoles.
> The USB Gecko is a 3rd party memory card interface adapter that provides
> a EXI (External Interface) to USB serial converter.
> 
> Signed-off-by: Albert Herranz 
> ---
>  arch/powerpc/Kconfig.debug |8 +++
>  arch/powerpc/include/asm/udbg.h|1 +
>  arch/powerpc/kernel/head_32.S  |   21 +++
>  arch/powerpc/kernel/udbg.c |2 +
>  arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c |   59 
> 
>  arch/powerpc/platforms/embedded6xx/usbgecko_udbg.h |2 +
>  6 files changed, 93 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
> index 3b10051..11e385b 100644
> --- a/arch/powerpc/Kconfig.debug
> +++ b/arch/powerpc/Kconfig.debug
> @@ -254,6 +254,14 @@ config PPC_EARLY_DEBUG_CPM
> using a CPM-based serial port.  This assumes that the bootwrapper
> has run, and set up the CPM in a particular way.
>  
> +config PPC_EARLY_DEBUG_USBGECKO
> + bool "Early debugging through the USB Gecko adapter"
> + depends on GAMECUBE_COMMON
> + select USBGECKO_UDBG
> + help
> +   Select this to enable early debugging for Nintendo GameCube/Wii
> +   consoles via an external USB Gecko adapter.
> +
>  endchoice
>  
>  config PPC_EARLY_DEBUG_44x_PHYSLOW

Small nit, my preference would be for this to be in the patch 1 where it
is first referenced.

> diff --git a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c 
> b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> index ba4c7cc..3f125b6 100644
> --- a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> +++ b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> @@ -17,6 +17,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  #include "usbgecko_udbg.h"
>  
> @@ -270,3 +271,61 @@ done:
>   of_node_put(np);
>   return;
>  }
> +
> +#ifdef CONFIG_PPC_EARLY_DEBUG_USBGECKO
> +
> +static void __init ug_early_remap(void)

you may want to rename the ug_ prefix, it took me a while looking back
and forth through the patch to convince myself it wasn't a typo.

-Richard Holden
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev