Re: [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards

2008-12-03 Thread Timur Tabi
On Fri, Oct 17, 2008 at 12:57 PM, Anton Vorontsov
[EMAIL PROTECTED] wrote:
 MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
 provide soft power-off function, but also exports two GPIOs (wired to
 the LEDs and also available from the external headers).

 Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]

Kumar, I think you merged this patch incorrectly ...

 diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts 
 b/arch/powerpc/boot/dts/mpc8349emitx.dts
 index 7fc5414..4bdbaf4 100644
 --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
 +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
 @@ -91,6 +91,14 @@
interrupts = 18 0x8;
interrupt-parent = ipic;
};
 +
 +   mcu_pio: [EMAIL PROTECTED] {
 +   #gpio-cells = 2;
 +   compatible = fsl,mc9s08qg8-mpc8349emitx,
 +fsl,mcu-mpc8349emitx;
 +   reg = 0x0a;
 +   gpio-controller;
 +   };

This node is supposed to go under the I2C node, but you put it under
the DMA node.

-- 
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards

2008-12-03 Thread Anton Vorontsov
On Wed, Dec 03, 2008 at 05:10:30PM -0600, Timur Tabi wrote:
 On Fri, Oct 17, 2008 at 12:57 PM, Anton Vorontsov
 [EMAIL PROTECTED] wrote:
  MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
  provide soft power-off function, but also exports two GPIOs (wired to
  the LEDs and also available from the external headers).
 
  Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
 
 Kumar, I think you merged this patch incorrectly ...
[...]
 This node is supposed to go under the I2C node, but you put it under
 the DMA node.

I've noticed this on the other 'stg pull', when it told me that the
patch isn't empty (stg patch becomes empty if merged).

This should be fixed already:

http://ozlabs.org/pipermail/linuxppc-dev/2008-November/065666.html

Anyway, thanks for heads up!

-- 
Anton Vorontsov
email: [EMAIL PROTECTED]
irc://irc.freenode.net/bd2
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH 2/2] powerpc/83xx: add support for MCU on 8349emitx, 837xrdb and 8315erdb boards

2008-10-20 Thread Kumar Gala


On Oct 17, 2008, at 1:57 PM, Anton Vorontsov wrote:


MCU is an external Freescale MC9S08QG8 microcontroller, mainly used to
provide soft power-off function, but also exports two GPIOs (wired to
the LEDs and also available from the external headers).

Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8315erdb.dts  |8 
arch/powerpc/boot/dts/mpc8349emitx.dts |8 
arch/powerpc/boot/dts/mpc8377_rdb.dts  |8 
arch/powerpc/boot/dts/mpc8378_rdb.dts  |8 
arch/powerpc/boot/dts/mpc8379_rdb.dts  |8 
5 files changed, 40 insertions(+), 0 deletions(-)


applied

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev