Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
David Gibson wrote: On Thu, Jun 05, 2008 at 08:43:51AM -0500, Kumar Gala wrote: On Jun 5, 2008, at 4:05 AM, Wolfgang Grandegger wrote: [snip] + timebase-frequency = 0; // from U-Boot + bus-frequency = 0;// from U-Boot + clock-frequency = 0; // from U-Boot u-boot will add this for us so no need for them. I think it's worth including them (with the comments) for documentation purposes though. Plus allowing the bootloader and bootwrapper to just replace property values without resizing or inserting is somewhat worthwhile of itself. I understand your point and while testing the new blob, I realized that the DTB image created with $ make ARCH=powerpc tqm8548.dtb does not work because work space is missing: ## Flattened Device Tree blob at 0090 Booting using the fdt blob at 0x90 Loading Device Tree to 007fe000, end 007ff8e0 ... OK WARNING: could not create /chosen FDT_ERR_NOSPACE. ERROR: /chosen node create failed - must RESET the board to recover. As I see it, I have to define DTS_FLAGS manually $ export DTS_FLAGS=-R4 -S0x3000 $ make ARCH=powerpc tqm8548.dtb to get a working blob. Is that the intended behavior? Wolfgang. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
On Jun 6, 2008, at 5:09 AM, Wolfgang Grandegger wrote: David Gibson wrote: On Thu, Jun 05, 2008 at 08:43:51AM -0500, Kumar Gala wrote: On Jun 5, 2008, at 4:05 AM, Wolfgang Grandegger wrote: [snip] + timebase-frequency = 0; // from U-Boot + bus-frequency = 0; // from U-Boot + clock-frequency = 0;// from U-Boot u-boot will add this for us so no need for them. I think it's worth including them (with the comments) for documentation purposes though. Plus allowing the bootloader and bootwrapper to just replace property values without resizing or inserting is somewhat worthwhile of itself. I understand your point and while testing the new blob, I realized that the DTB image created with $ make ARCH=powerpc tqm8548.dtb does not work because work space is missing: ## Flattened Device Tree blob at 0090 Booting using the fdt blob at 0x90 Loading Device Tree to 007fe000, end 007ff8e0 ... OK WARNING: could not create /chosen FDT_ERR_NOSPACE. ERROR: /chosen node create failed - must RESET the board to recover. As I see it, I have to define DTS_FLAGS manually $ export DTS_FLAGS=-R4 -S0x3000 $ make ARCH=powerpc tqm8548.dtb to get a working blob. Is that the intended behavior? this is normal. Andy Fleming has posted a patch to u-boot to help improve the situation. I'm not sure if WD has picked it up for 1.3.4 yet. - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
In message [EMAIL PROTECTED] you wrote: As I see it, I have to define DTS_FLAGS manually $ export DTS_FLAGS=-R4 -S0x3000 $ make ARCH=powerpc tqm8548.dtb to get a working blob. Is that the intended behavior? this is normal. Andy Fleming has posted a patch to u-boot to help improve the situation. I'm not sure if WD has picked it up for 1.3.4 yet. I will. But wouldn't it make sense to allow at least for some level of compatibility with older versions of U-Boot? Adding these options as default would probably not hurt? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Anarchy may not be the best form of government, but it's better than no government at all. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
On Jun 5, 2008, at 4:05 AM, Wolfgang Grandegger wrote:
[POWERPC] 85xx: add board support for the TQM8548 modules
This patch adds support for the TQM8548 modules from TQ-Components
GmbH (http://www.tqc.de).
Signed-off-by: Wolfgang Grandegger [EMAIL PROTECTED]
---
arch/powerpc/boot/Makefile |1
arch/powerpc/boot/dts/tqm8548.dts | 368 +
arch/powerpc/boot/wrapper |2
arch/powerpc/configs/85xx/tqm8548_defconfig | 1094 ++
++
arch/powerpc/platforms/85xx/Kconfig |8
arch/powerpc/platforms/85xx/tqm85xx.c | 15
6 files changed, 1485 insertions(+), 3 deletions(-)
create mode 100644 arch/powerpc/boot/dts/tqm8548.dts
create mode 100644 arch/powerpc/configs/85xx/tqm8548_defconfig
Index: linux-2.6-galak/arch/powerpc/boot/Makefile
===
--- linux-2.6-galak.orig/arch/powerpc/boot/Makefile
+++ linux-2.6-galak/arch/powerpc/boot/Makefile
@@ -255,6 +255,7 @@ image-$(CONFIG_MPC85xx_DS) += cuImage.m
cuImage.mpc8572ds
image-$(CONFIG_TQM8540) += cuImage.tqm8540
image-$(CONFIG_TQM8541) += cuImage.tqm8541
+image-$(CONFIG_TQM8548)+= cuImage.tqm8548
image-$(CONFIG_TQM8555) += cuImage.tqm8555
image-$(CONFIG_TQM8560) += cuImage.tqm8560
image-$(CONFIG_SBC8548) += cuImage.sbc8548
Index: linux-2.6-galak/arch/powerpc/boot/dts/tqm8548.dts
===
--- /dev/null
+++ linux-2.6-galak/arch/powerpc/boot/dts/tqm8548.dts
@@ -0,0 +1,368 @@
+/*
+ * TQM8548 Device Tree Source
+ *
+ * Copyright 2006 Freescale Semiconductor Inc.
+ * Copyright 2008 Wolfgang Grandegger [EMAIL PROTECTED]
+ *
+ * This program is free software; you can redistribute it and/or
modify it
+ * under the terms of the GNU General Public License as
published by the
+ * Free Software Foundation; either version 2 of the License, or
(at your
+ * option) any later version.
+ */
+
+/dts-v1/;
+
+/ {
+ model = tqm,8548;
+ compatible = tqm,8548, tqm,85xx;
+ #address-cells = 1;
+ #size-cells = 1;
+
+ aliases {
+ ethernet0 = enet0;
+ ethernet1 = enet1;
+ ethernet2 = enet2;
+ ethernet3 = enet3;
+
+ serial0 = serial0;
+ serial1 = serial1;
+ pci0 = pci0;
+ pci1 = pci1;
+ };
+
+ cpus {
+ #address-cells = 1;
+ #size-cells = 0;
+
+ PowerPC,[EMAIL PROTECTED] {
+ device_type = cpu;
+ reg = 0;
+ d-cache-line-size = 32; // 32 bytes
+ i-cache-line-size = 32; // 32 bytes
+ d-cache-size = 0x8000; // L1, 32K
+ i-cache-size = 0x8000; // L1, 32K
+ timebase-frequency = 0; // from U-Boot
+ bus-frequency = 0; // from U-Boot
+ clock-frequency = 0;// from U-Boot
u-boot will add this for us so no need for them.
+ next-level-cache = L2;
+ };
+ };
+
+ memory {
+ device_type = memory;
+ reg = 0x 0x2000;
+ };
+
+ [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 1;
+ device_type = soc;
+ ranges = 0x0 0xe000 0x10;
+ reg = 0xe000 0x1000;// CCSRBAR
+ bus-frequency = 0;
+
+ [EMAIL PROTECTED] {
+ compatible = fsl,8548-memory-controller;
Can you make this fsl,mpc8548...
I need to fix all the other device trees
+ reg = 0x2000 0x1000;
+ interrupt-parent = mpic;
+ interrupts = 18 2;
+ };
+
+ L2: [EMAIL PROTECTED] {
+ compatible = fsl,8548-l2-cache-controller;
Can you make this fsl,mpc8548
+ reg = 0x2 0x1000;
+ cache-line-size = 32; // 32 bytes
+ cache-size = 0x8; // L2, 512K
+ interrupt-parent = mpic;
+ interrupts = 16 2;
+ };
+
+ [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 0;
+ cell-index = 0;
+ compatible = fsl-i2c;
+ reg = 0x3000 0x100;
+ interrupts = 43 2;
+ interrupt-parent = mpic;
+ dfsrr;
+ };
+
+ [EMAIL PROTECTED] {
+ #address-cells = 1;
+
Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
Kumar Gala wrote: On Jun 5, 2008, at 4:05 AM, Wolfgang Grandegger wrote: [POWERPC] 85xx: add board support for the TQM8548 modules This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). Signed-off-by: Wolfgang Grandegger [EMAIL PROTECTED] [...deletions...] === --- linux-2.6-galak.orig/arch/powerpc/boot/wrapper +++ linux-2.6-galak/arch/powerpc/boot/wrapper @@ -177,7 +177,7 @@ cuboot*) *-tqm8541|*-mpc8560*|*-tqm8560|*-tqm8555|*-ksi8560*) platformo=$object/cuboot-85xx-cpm2.o ;; -*-mpc85*|*-tqm8540|*-sbc85*) +*-mpc85*|*-tqm8540|*-tqm8548|*-sbc85*) why not just *-tqm85* Hm, yes, *-tqm85* should cover all TQM85xx without CPM. I just sent out v3 patches addressing this and all other issues. Hope they are OK now. Wolfgang. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules
On Thu, Jun 05, 2008 at 08:43:51AM -0500, Kumar Gala wrote: On Jun 5, 2008, at 4:05 AM, Wolfgang Grandegger wrote: [snip] +timebase-frequency = 0; // from U-Boot +bus-frequency = 0;// from U-Boot +clock-frequency = 0; // from U-Boot u-boot will add this for us so no need for them. I think it's worth including them (with the comments) for documentation purposes though. Plus allowing the bootloader and bootwrapper to just replace property values without resizing or inserting is somewhat worthwhile of itself. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
