Re: fs_enet build breakage
On May 18, 2009, at 4:50 PM, Benjamin Herrenschmidt wrote: On Mon, 2009-05-18 at 12:20 -0500, Scott Wood wrote: I'm pretty sure the driver changes to address this are in dave's net- next tree. Won't this break git bisect? Not to mention anyone trying to use your tree now... Right, though if you have the commit ID in DaveM tree, I can work with him to sort out that driver, for example by having the same commit in my tree. As discussed on IRC, its easier to modify the commit that cause the issue to drop removing IMAP_ADDR for cpm1 devices for now. I'll generate a separate patch for us to deal w/during the merge window for .31 - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: fs_enet build breakage
On May 18, 2009, at 2:01 AM, Benjamin Herrenschmidt wrote: Hi Kumar Commit 4484079d517c2b6521621be0b1ea246ccc55c7d7 from your next branch breaks my 8xx test config with the following error: /home/benh/linux-powerpc-test/drivers/net/fs_enet/fs_enet-main.c: In function ‘setup_immap’: /home/benh/linux-powerpc-test/drivers/net/fs_enet/fs_enet-main.c: 947: error: ‘IMAP_ADDR’ undeclared (first use in this function) /home/benh/linux-powerpc-test/drivers/net/fs_enet/fs_enet-main.c: 947: error: (Each undeclared identifier is reported only once /home/benh/linux-powerpc-test/drivers/net/fs_enet/fs_enet-main.c: 947: error: for each function it appears in.) I'm still pushing it with a bunch of other stuff to test so people get to find more breakage but it will need to be fixed for the actual next branch. Cheers, Ben. I'm pretty sure the driver changes to address this are in dave's net- next tree. - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: fs_enet build breakage
On Mon, May 18, 2009 at 08:23:17AM -0500, Kumar Gala wrote: On May 18, 2009, at 2:01 AM, Benjamin Herrenschmidt wrote: Hi Kumar Commit 4484079d517c2b6521621be0b1ea246ccc55c7d7 from your next branch breaks my 8xx test config with the following error: /home/benh/linux-powerpc-test/drivers/net/fs_enet/fs_enet-main.c: In function ‘setup_immap’: /home/benh/linux-powerpc-test/drivers/net/fs_enet/fs_enet-main.c: 947: error: ‘IMAP_ADDR’ undeclared (first use in this function) /home/benh/linux-powerpc-test/drivers/net/fs_enet/fs_enet-main.c: 947: error: (Each undeclared identifier is reported only once /home/benh/linux-powerpc-test/drivers/net/fs_enet/fs_enet-main.c: 947: error: for each function it appears in.) I'm still pushing it with a bunch of other stuff to test so people get to find more breakage but it will need to be fixed for the actual next branch. Cheers, Ben. I'm pretty sure the driver changes to address this are in dave's net- next tree. Won't this break git bisect? Not to mention anyone trying to use your tree now... -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: fs_enet build breakage
On Mon, 2009-05-18 at 12:20 -0500, Scott Wood wrote: I'm pretty sure the driver changes to address this are in dave's net- next tree. Won't this break git bisect? Not to mention anyone trying to use your tree now... Right, though if you have the commit ID in DaveM tree, I can work with him to sort out that driver, for example by having the same commit in my tree. Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
