Re: [Linuxwacom-devel] [PATCH libwacom] data: the 22HD(T) have virtual modes - note it as a comment

[Jason Gerecke]

On 08/29/2016 10:57 PM, Peter Hutterer wrote:
> Not adding the actual StripsNumModes entry because this would require callers
> to display an OSD for mode changes. Right now callers (GNOME anyway) relies
> on LEDs to show the mode, not an on-screen notification. Also, since the modes
> are completely caller-controlled without any LEDs the caller could implement
> any number of modes, not just what libwacom suggests.
> 
> Add the modes as a comment so we have an explanation.
> 
> Signed-off-by: Peter Hutterer 
> ---
>  data/cintiq-22hd.tablet  | 3 +++
>  data/cintiq-22hdt.tablet | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/data/cintiq-22hd.tablet b/data/cintiq-22hd.tablet
> index 54f3219..bfdffcd 100644
> --- a/data/cintiq-22hd.tablet
> +++ b/data/cintiq-22hd.tablet
> @@ -54,3 +54,6 @@ Right=K;L;M;N;J;O;P;Q;R
>  
>  Touchstrip=A
>  Touchstrip2=J
> +# This tablet has mode buttons but no LEDs to signal the current mode to the
> +# user and thus requires the caller to display an on-screen notification.
> +# StripsNumModes=4
> diff --git a/data/cintiq-22hdt.tablet b/data/cintiq-22hdt.tablet
> index 9e74c41..6258436 100644
> --- a/data/cintiq-22hdt.tablet
> +++ b/data/cintiq-22hdt.tablet
> @@ -56,3 +56,6 @@ Right=K;L;M;N;J;O;P;Q;R
>  
>  Touchstrip=A
>  Touchstrip2=J
> +# This tablet has mode buttons but no LEDs to signal the current mode to the
> +# user and thus requires the caller to display an on-screen notification.
> +# StripsNumModes=4
> 

Should the 'Touchstrip=A' and 'Touchstrip2=J' lines in both these files
be commented out as well?

There's a small difference between commenting and uncommenting here. If
they're commented, then the buttons may be assigned to perform any
action, which is reasonable since they can't be used for mode switching
until on-screen notifications are implemented. On the downside though,
once those notifications are implemented, the user's assignments to
those buttons will stop working since the compositor will start
reserving them for mode-switch duties. This probably isn't a huge issue
though, IMO (under Wayland at least, applications will have to get used
to the fact that arbitrary buttons may be reserved by the compositor at
any time).

Uncommenting makes them inaccessible for button mapping and virtually
useless since they'll control touchstrips that have a single mode each
until such time as we can also uncomment 'StripsNumModes=4' when
on-screen feedback becomes possible. Who knows how far out that feature
may be though...

Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours

--
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Re: [Linuxwacom-devel] [PATCH libwacom] data: the 22HD(T) have virtual modes - note it as a comment

[Ping Cheng]

On Monday, August 29, 2016, Peter Hutterer  wrote:

> Not adding the actual StripsNumModes entry because this would require
> callers
> to display an OSD for mode changes. Right now callers (GNOME anyway) relies
> on LEDs to show the mode,


Can you add the connection between LED and  mode to the comments of
https://sourceforge.net/p/linuxwacom/libwacom/ci/master/tree/data/wacom.example
?

Except that, the patch is fine.


> not an on-screen notification. Also, since the modes
>
are completely caller-controlled without any LEDs the caller could implement
> any number of modes, not just what libwacom suggests.
>
> Add the modes as a comment so we have an explanation.
>
> Signed-off-by: Peter Hutterer >


Reviewed-by: Ping Cheng 

Thanks,

Ping


> ---
>  data/cintiq-22hd.tablet  | 3 +++
>  data/cintiq-22hdt.tablet | 3 +++
>  2 files changed, 6 insertions(+)
>
> diff --git a/data/cintiq-22hd.tablet b/data/cintiq-22hd.tablet
> index 54f3219..bfdffcd 100644
> --- a/data/cintiq-22hd.tablet
> +++ b/data/cintiq-22hd.tablet
> @@ -54,3 +54,6 @@ Right=K;L;M;N;J;O;P;Q;R
>
>  Touchstrip=A
>  Touchstrip2=J
> +# This tablet has mode buttons but no LEDs to signal the current mode to
> the
> +# user and thus requires the caller to display an on-screen notification.
> +# StripsNumModes=4
> diff --git a/data/cintiq-22hdt.tablet b/data/cintiq-22hdt.tablet
> index 9e74c41..6258436 100644
> --- a/data/cintiq-22hdt.tablet
> +++ b/data/cintiq-22hdt.tablet
> @@ -56,3 +56,6 @@ Right=K;L;M;N;J;O;P;Q;R
>
>  Touchstrip=A
>  Touchstrip2=J
> +# This tablet has mode buttons but no LEDs to signal the current mode to
> the
> +# user and thus requires the caller to display an on-screen notification.
> +# StripsNumModes=4
> --
> 2.7.4
>
>
> 
> --
> ___
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net 
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
--
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

[Linuxwacom-devel] [PATCH libwacom] data: the 22HD(T) have virtual modes - note it as a comment

[Peter Hutterer]

Not adding the actual StripsNumModes entry because this would require callers
to display an OSD for mode changes. Right now callers (GNOME anyway) relies
on LEDs to show the mode, not an on-screen notification. Also, since the modes
are completely caller-controlled without any LEDs the caller could implement
any number of modes, not just what libwacom suggests.

Add the modes as a comment so we have an explanation.

Signed-off-by: Peter Hutterer 
---
 data/cintiq-22hd.tablet  | 3 +++
 data/cintiq-22hdt.tablet | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/data/cintiq-22hd.tablet b/data/cintiq-22hd.tablet
index 54f3219..bfdffcd 100644
--- a/data/cintiq-22hd.tablet
+++ b/data/cintiq-22hd.tablet
@@ -54,3 +54,6 @@ Right=K;L;M;N;J;O;P;Q;R
 
 Touchstrip=A
 Touchstrip2=J
+# This tablet has mode buttons but no LEDs to signal the current mode to the
+# user and thus requires the caller to display an on-screen notification.
+# StripsNumModes=4
diff --git a/data/cintiq-22hdt.tablet b/data/cintiq-22hdt.tablet
index 9e74c41..6258436 100644
--- a/data/cintiq-22hdt.tablet
+++ b/data/cintiq-22hdt.tablet
@@ -56,3 +56,6 @@ Right=K;L;M;N;J;O;P;Q;R
 
 Touchstrip=A
 Touchstrip2=J
+# This tablet has mode buttons but no LEDs to signal the current mode to the
+# user and thus requires the caller to display an on-screen notification.
+# StripsNumModes=4
-- 
2.7.4


--
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel