[Lldb-commits] [lldb] r232618 - Clean up CommandObjectBreakpointNameList: remove duplicated 'protected' access modifier
Author: ki.stfu
Date: Wed Mar 18 04:14:49 2015
New Revision: 232618
URL: http://llvm.org/viewvc/llvm-project?rev=232618view=rev
Log:
Clean up CommandObjectBreakpointNameList: remove duplicated 'protected' access
modifier
Modified:
lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp?rev=232618r1=232617r2=232618view=diff
==
--- lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp Wed Mar 18 04:14:49
2015
@@ -2208,7 +2208,6 @@ public:
}
protected:
-protected:
virtual bool
DoExecute (Args command, CommandReturnObject result)
{
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [Diffusion] rL232396: Remove redundant comments from lldb-mi source files.
USERS abidh (Author) ki.stfu (Auditor) http://reviews.llvm.org/rL232396 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [Diffusion] rL232396: Remove redundant comments from lldb-mi source files.
In Most of the file, it just said that Implementation of ABC classs, there I have removed it. In other places, it described many commands implemented in that file, I left it there. May be that can be removed too as new commands have been added and that list may not be quite accurate. Regards, Abid On Wed, Mar 18, 2015 at 8:20 AM, Ilia K ki.s...@gmail.com wrote: USERS abidh (Author) ki.stfu (Auditor) http://reviews.llvm.org/rL232396 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.
Comment at: test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:51 @@ +50,3 @@ + +self.expect(thread step-over) +self.expect(thread list, STOPPED_DUE_TO_WATCHPOINT, This test relies on step-over being implemented using (instruction) single-stepping. If that is ever changed to do a run to temporary breakpoint, the test will be ineffective. Could the check be implemented using thread step-inst in a loop? If not then at least make a note of this somewhere. http://reviews.llvm.org/D8404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232625 - Parse .note.android.ident header from elf files
Author: tberghammer
Date: Wed Mar 18 05:36:27 2015
New Revision: 232625
URL: http://llvm.org/viewvc/llvm-project?rev=232625view=rev
Log:
Parse .note.android.ident header from elf files
In android a .note.android.ident section header is added to the elf
files to provide information for the debuggers that it is an android
specific module. This CL add logic to parse it out from the elf files
and set the module specification based on it.
Differential revision: http://reviews.llvm.org/D8377
Modified:
lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp?rev=232625r1=232624r2=232625view=diff
==
--- lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Wed Mar 18
05:36:27 2015
@@ -48,6 +48,7 @@ const char *const LLDB_NT_OWNER_FREEBSD
const char *const LLDB_NT_OWNER_GNU = GNU;
const char *const LLDB_NT_OWNER_NETBSD = NetBSD;
const char *const LLDB_NT_OWNER_CSR = csr;
+const char *const LLDB_NT_OWNER_ANDROID = Android;
// ELF note type definitions
const elf_word LLDB_NT_FREEBSD_ABI_TAG = 0x01;
@@ -1362,6 +1363,11 @@ ObjectFileELF::RefineModuleDetailsFromNo
(void)cstr;
}
}
+else if (note.n_name == LLDB_NT_OWNER_ANDROID)
+{
+arch_spec.GetTriple().setOS(llvm::Triple::OSType::Linux);
+
arch_spec.GetTriple().setEnvironment(llvm::Triple::EnvironmentType::Android);
+}
if (!processed)
offset += llvm::RoundUpToAlignment(note.n_descsz, 4);
@@ -1478,7 +1484,15 @@ ObjectFileELF::GetSectionHeaderInfo(Sect
}
// Process ELF note section entries.
-if (header.sh_type == SHT_NOTE)
+bool is_note_header = (header.sh_type == SHT_NOTE);
+
+// The section header .note.android.ident is stored as a
+// PROGBITS type header but it is actually a note header.
+static ConstString g_sect_name_android_ident
(.note.android.ident);
+if (!is_note_header name == g_sect_name_android_ident)
+is_note_header = true;
+
+if (is_note_header)
{
// Allow notes to refine module info.
DataExtractor data;
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Fix memory allocating inside signal handler (MI)
Please, take a look again. http://reviews.llvm.org/D8256 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Fix memory allocating inside signal handler (MI)
Remove unused IDS_PROCESS_SIGNAL_RECEIVED from CMICmnResources
http://reviews.llvm.org/D8256
Files:
tools/lldb-mi/MICmnResources.cpp
tools/lldb-mi/MICmnResources.h
tools/lldb-mi/MIDriverMain.cpp
Index: tools/lldb-mi/MICmnResources.cpp
===
--- tools/lldb-mi/MICmnResources.cpp
+++ tools/lldb-mi/MICmnResources.cpp
@@ -91,7 +91,6 @@
{IDS_CMDFACTORY_ERR_CMD_ALREADY_REGED, Command factory. Command '%s' by
that name already registered},
{IDS_CMDMGR_ERR_CMD_FAILED_CREATE, Command manager. Command creation
failed. %s},
{IDS_CMDMGR_ERR_CMD_INVOKER, Command manager. %s },
-{IDS_PROCESS_SIGNAL_RECEIVED, Process signal. Application received signal
'%s' (%d)},
{IDS_MI_INIT_ERR_LOG, Log. Error occurred during initialisation %s},
{IDS_MI_INIT_ERR_RESOURCES, Resources. Error occurred during
initialisation %s},
{IDS_MI_INIT_ERR_INIT, Driver. Error occurred during initialisation %s},
Index: tools/lldb-mi/MICmnResources.h
===
--- tools/lldb-mi/MICmnResources.h
+++ tools/lldb-mi/MICmnResources.h
@@ -104,8 +104,6 @@
IDS_CMDMGR_ERR_CMD_FAILED_CREATE,
IDS_CMDMGR_ERR_CMD_INVOKER,
-IDS_PROCESS_SIGNAL_RECEIVED,
-
IDS_MI_INIT_ERR_LOG,
IDS_MI_INIT_ERR_RESOURCES,
IDS_MI_INIT_ERR_INIT,
Index: tools/lldb-mi/MIDriverMain.cpp
===
--- tools/lldb-mi/MIDriverMain.cpp
+++ tools/lldb-mi/MIDriverMain.cpp
@@ -39,7 +39,6 @@
#include MICmnResources.h
#include MICmnStreamStdin.h
#include MIUtilDebug.h
-#include MICmnLog.h
#if MICONFIG_COMPILE_MIDRIVER_VERSION
@@ -74,8 +73,6 @@
rDriverMgr.DriverResizeWindow((uint32_t)window_size.ws_col);
}
}
-
-
CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED),
SIGWINCH, vSigno));
}
// CODETAG_IOR_SIGNALS
@@ -109,8 +106,6 @@
}
}
-
CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED),
SIGINT, vSigno));
-
// Send signal to driver so that it can take suitable action
rDriverMgr.DeliverSignal (vSigno);
}
@@ -141,8 +136,6 @@
pDebugger-SaveInputTerminalState();
}
-
CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED),
SIGTSTP, vSigno));
-
// Send signal to driver so that it can take suitable action
rDriverMgr.DeliverSignal (vSigno);
}
@@ -172,8 +165,6 @@
pDebugger-RestoreInputTerminalState();
}
-
CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED),
SIGCONT, vSigno));
-
// Send signal to driver so that it can take suitable action
rDriverMgr.DeliverSignal (vSigno);
}
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: tools/lldb-mi/MICmnResources.cpp
===
--- tools/lldb-mi/MICmnResources.cpp
+++ tools/lldb-mi/MICmnResources.cpp
@@ -91,7 +91,6 @@
{IDS_CMDFACTORY_ERR_CMD_ALREADY_REGED, Command factory. Command '%s' by that name already registered},
{IDS_CMDMGR_ERR_CMD_FAILED_CREATE, Command manager. Command creation failed. %s},
{IDS_CMDMGR_ERR_CMD_INVOKER, Command manager. %s },
-{IDS_PROCESS_SIGNAL_RECEIVED, Process signal. Application received signal '%s' (%d)},
{IDS_MI_INIT_ERR_LOG, Log. Error occurred during initialisation %s},
{IDS_MI_INIT_ERR_RESOURCES, Resources. Error occurred during initialisation %s},
{IDS_MI_INIT_ERR_INIT, Driver. Error occurred during initialisation %s},
Index: tools/lldb-mi/MICmnResources.h
===
--- tools/lldb-mi/MICmnResources.h
+++ tools/lldb-mi/MICmnResources.h
@@ -104,8 +104,6 @@
IDS_CMDMGR_ERR_CMD_FAILED_CREATE,
IDS_CMDMGR_ERR_CMD_INVOKER,
-IDS_PROCESS_SIGNAL_RECEIVED,
-
IDS_MI_INIT_ERR_LOG,
IDS_MI_INIT_ERR_RESOURCES,
IDS_MI_INIT_ERR_INIT,
Index: tools/lldb-mi/MIDriverMain.cpp
===
--- tools/lldb-mi/MIDriverMain.cpp
+++ tools/lldb-mi/MIDriverMain.cpp
@@ -39,7 +39,6 @@
#include MICmnResources.h
#include MICmnStreamStdin.h
#include MIUtilDebug.h
-#include MICmnLog.h
#if MICONFIG_COMPILE_MIDRIVER_VERSION
@@ -74,8 +73,6 @@
rDriverMgr.DriverResizeWindow((uint32_t)window_size.ws_col);
}
}
-
-CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGWINCH, vSigno));
}
// CODETAG_IOR_SIGNALS
@@ -109,8 +106,6 @@
}
}
-CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGINT, vSigno));
-
// Send signal to driver so that it can take suitable action
rDriverMgr.DeliverSignal (vSigno);
}
@@ -141,8 +136,6 @@
[Lldb-commits] [lldb] r232619 - Initial Assembly profiler for mips64
Author: bhushan.attarde Date: Wed Mar 18 04:21:29 2015 New Revision: 232619 URL: http://llvm.org/viewvc/llvm-project?rev=232619view=rev Log: Initial Assembly profiler for mips64 Summary: This is initial implementation of assembly profiler which only scans prologue/epilogue assembly instructions to create CFI instructions. Reviewers: clayborg, jasonmolenda Differential Revision: http://reviews.llvm.org/D7696 Added: lldb/trunk/source/Plugins/Instruction/MIPS64/ lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h lldb/trunk/source/Plugins/Instruction/MIPS64/Makefile Modified: lldb/trunk/cmake/LLDBDependencies.cmake lldb/trunk/lib/Makefile lldb/trunk/source/Plugins/Instruction/CMakeLists.txt lldb/trunk/source/Plugins/Makefile lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp lldb/trunk/source/lldb.cpp Modified: lldb/trunk/cmake/LLDBDependencies.cmake URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/LLDBDependencies.cmake?rev=232619r1=232618r2=232619view=diff == --- lldb/trunk/cmake/LLDBDependencies.cmake (original) +++ lldb/trunk/cmake/LLDBDependencies.cmake Wed Mar 18 04:21:29 2015 @@ -49,6 +49,7 @@ set( LLDB_USED_LIBS lldbPluginABISysV_ppc64 lldbPluginInstructionARM lldbPluginInstructionARM64 + lldbPluginInstructionMIPS64 lldbPluginObjectFilePECOFF lldbPluginOSPython lldbPluginMemoryHistoryASan Modified: lldb/trunk/lib/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lib/Makefile?rev=232619r1=232618r2=232619view=diff == --- lldb/trunk/lib/Makefile (original) +++ lldb/trunk/lib/Makefile Wed Mar 18 04:21:29 2015 @@ -45,6 +45,7 @@ USEDLIBS = lldbAPI.a \ lldbPluginDynamicLoaderMacOSX.a \ lldbPluginEmulateInstructionARM.a \ lldbPluginEmulateInstructionARM64.a \ +lldbPluginEmulateInstructionMIPS64.a \ lldbPluginInstrumentationRuntimeAddressSanitizer.a \ lldbPluginLanguageRuntimeCPlusPlusItaniumABI.a \ lldbPluginLanguageRuntimeObjCAppleObjCRuntime.a \ Modified: lldb/trunk/source/Plugins/Instruction/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/CMakeLists.txt?rev=232619r1=232618r2=232619view=diff == --- lldb/trunk/source/Plugins/Instruction/CMakeLists.txt (original) +++ lldb/trunk/source/Plugins/Instruction/CMakeLists.txt Wed Mar 18 04:21:29 2015 @@ -1,2 +1,3 @@ add_subdirectory(ARM) add_subdirectory(ARM64) +add_subdirectory(MIPS64) Added: lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt?rev=232619view=auto == --- lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt (added) +++ lldb/trunk/source/Plugins/Instruction/MIPS64/CMakeLists.txt Wed Mar 18 04:21:29 2015 @@ -0,0 +1,5 @@ +set(LLVM_NO_RTTI 1) + +add_lldb_library(lldbPluginInstructionMIPS64 + EmulateInstructionMIPS64.cpp + ) Added: lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp?rev=232619view=auto == --- lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp (added) +++ lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp Wed Mar 18 04:21:29 2015 @@ -0,0 +1,444 @@ +//===-- EmulateInstructionMIPS64.cpp ---*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===--===// + +#include EmulateInstructionMIPS64.h + +#include stdlib.h + +#include lldb/Core/ArchSpec.h +#include lldb/Core/Address.h +#include lldb/Core/ConstString.h +#include lldb/Core/PluginManager.h +#include lldb/Core/Stream.h +#include lldb/Symbol/UnwindPlan.h + +#include llvm/ADT/STLExtras.h +//#include llvm/Support/MathExtras.h // for SignExtend32 template function + +#include Plugins/Process/Utility/InstructionUtils.h +#include Plugins/Process/Utility/RegisterContext_mips64.h + +using namespace lldb; +using namespace lldb_private; + +#define UInt(x) ((uint64_t)x) +#define integer int64_t + + +//-- +// +//
Re: [Lldb-commits] [Diffusion] rL232396: Remove redundant comments from lldb-mi source files.
In Most of the file, it just said that Implementation of ABC classs, there I have removed it. In other places, it described many commands implemented in that file, I left it there. May be that can be removed too as new commands have been added and that list may not be quite accurate. Ok. Thanks for explaining. USERS abidh (Author) ki.stfu (Auditor) http://reviews.llvm.org/rL232396 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Make lldb-mi handle only MI commands
In http://reviews.llvm.org/D8381#142042, @ki.stfu wrote: All tests pass on OS X. As I understood you will remove Driver.cpp later, right? Yes. I will remove it later. Thanks for review. http://reviews.llvm.org/D8381 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232621 - Make lldb-mi handle only MI commands
Author: abidh
Date: Wed Mar 18 05:07:46 2015
New Revision: 232621
URL: http://llvm.org/viewvc/llvm-project?rev=232621view=rev
Log:
Make lldb-mi handle only MI commands
Summary:
Previously lldb-mi can also act as a driver like normal lldb. It needed a lot
of redundant code in the lldb-mi for that. I think that if a user wants command
line lldb driver then he/she should use the lldb for it. This change will
cleanup
the code a lot. When this change goes in, it will allow us to remove some more
redundant code too.
All tests pass on Linux. Did some sanity testing on command line and with
eclipse.
Reviewers: ki.stfu
Reviewed By: ki.stfu
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D8381
Modified:
lldb/trunk/tools/lldb-mi/MICmnConfig.h
lldb/trunk/tools/lldb-mi/MICmnResources.cpp
lldb/trunk/tools/lldb-mi/MIDriver.cpp
lldb/trunk/tools/lldb-mi/MIDriverMain.cpp
lldb/trunk/tools/lldb-mi/MIDriverMgr.cpp
lldb/trunk/tools/lldb-mi/MIReadMe.txt
Modified: lldb/trunk/tools/lldb-mi/MICmnConfig.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnConfig.h?rev=232621r1=232620r2=232621view=diff
==
--- lldb/trunk/tools/lldb-mi/MICmnConfig.h (original)
+++ lldb/trunk/tools/lldb-mi/MICmnConfig.h Wed Mar 18 05:07:46 2015
@@ -9,30 +9,10 @@
//--
#pragma once
-// 1 = Yes compile MI Driver version, 0 = compile original LLDB driver code
only.
-// 0 was mainly just for testing purposes and so may be removed at a later
time.
-#define MICONFIG_COMPILE_MIDRIVER_VERSION 1
-
// 1 = Show debug process attach modal dialog, 0 = do not show
// For windows only ATM, other OS's code is an infinite loop which a debugger
must change a value to continue
#define MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG 0
-// 1 = Compile in and init LLDB driver code alongside MI version, 0 = do not
compile in
-#define MICONFIG_COMPILE_MIDRIVER_WITH_LLDBDRIVER 1
-
-// 1 = Give runtime our own custom buffer, 0 = Use runtime managed buffer
-#define MICONFIG_CREATE_OWN_STDIN_BUFFER 0
-
-// 1 = Use the MI driver regardless of --interpreter, 0 = require
--interpreter argument
-// This depends on MICONFIG_COMPILE_MIDRIVER_WITH_LLDBDRIVER
-#define MICONFIG_DEFAULT_TO_MI_DRIVER 0
-
-// 1 = Check for stdin before we issue blocking read, 0 = issue blocking call
always
-#define MICONFIG_POLL_FOR_STD_IN 1
-
// 1 = Write to MI's Log file warnings about commands that did not handle
arguments or
// options present to them by the driver's client, 0 = no warnings given
#define MICONFIG_GIVE_WARNING_CMD_ARGS_NOT_HANDLED 1
-
-// 1 = Enable MI Driver in MI mode to create a local debug session, 0 = Report
Not implemented
-#define MICONFIG_ENABLE_MI_DRIVER_MI_MODE_CMDLINE_ARG_EXECUTABLE_DEBUG_SESSION
1
Modified: lldb/trunk/tools/lldb-mi/MICmnResources.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmnResources.cpp?rev=232621r1=232620r2=232621view=diff
==
--- lldb/trunk/tools/lldb-mi/MICmnResources.cpp (original)
+++ lldb/trunk/tools/lldb-mi/MICmnResources.cpp Wed Mar 18 05:07:46 2015
@@ -63,13 +63,8 @@ const CMICmnResources::SRsrcTextData CMI
{IDE_MI_APP_ARG_HELP, -h\n--help\n\tPrints out usage information for the
MI debugger. Exit the MI\n\tDriver immediately.},
{IDE_MI_APP_ARG_VERSION, --version\n\tPrints out GNU (gdb) version
information. Exit the MI Driver\n\timmediately.},
{IDE_MI_APP_ARG_VERSION_LONG, --versionLong\n\tPrints out MI Driver
version information. Exit the MI Driver\n\timmediately.},
-{IDE_MI_APP_ARG_INTERPRETER, --interpreter\n\tUse the MI Driver for the
debugger (MI mode)(Default is the\n\tLLDB driver). Any LLDB
- command line options are ignored even\n\tif
the MI Driver falls through to the LLDB driver.
- (Depends\n\ton the build configuration see
MICmnConfig.h)\n\tNormally specified by the driver client
- i.e. Eclipse.\n\tCannot specify an
executable with this option, use --executable.},
-{IDE_MI_APP_ARG_EXECUTEABLE, --executable\n\tUse the MI Driver in MI mode
for the debugging the specified\n\texecutable. Any LLDB
- command line options are ignored even\n\tif
the MI Driver falls through to the LLDB driver.
- (Depends\n\ton the build configuration see
MICmnConfig.h)\n\tNormally specified from the command line.},
+{IDE_MI_APP_ARG_INTERPRETER, --interpreter\n\t This option is kept for
backward compatibility. This executable always run in MI mode},
+{IDE_MI_APP_ARG_EXECUTEABLE, --executable\n\tUse the MI Driver in MI mode
for the debugging the specified executable. },
{IDE_MI_APP_ARG_APP_LOG, --log\n\tUse this argument to tell the MI Driver
to update it's log\n\tfile '%s'.},
[Lldb-commits] [PATCH] Fix -break-insert for system functions (MI)
Hi abidh, clayborg,
# Fix -break-insert for system functions
# Fix MiExecTestCase to use -break-insert instead of CLI b
# Improve MiBreakTestCase: now it uses printf() instead of in-house function
All tests pass on OS X.
http://reviews.llvm.org/D8412
Files:
test/tools/lldb-mi/breakpoint/TestMiBreak.py
test/tools/lldb-mi/breakpoint/main.cpp
test/tools/lldb-mi/control/TestMiExec.py
tools/lldb-mi/MICmdCmdBreak.cpp
Index: test/tools/lldb-mi/breakpoint/TestMiBreak.py
===
--- test/tools/lldb-mi/breakpoint/TestMiBreak.py
+++ test/tools/lldb-mi/breakpoint/TestMiBreak.py
@@ -21,7 +21,7 @@
self.runCmd(-file-exec-and-symbols %s % self.myexe)
self.expect(\^done)
-self.runCmd(-break-insert -f g_MyFunction)
+self.runCmd(-break-insert -f printf)
self.expect(\^done,bkpt={number=\1\)
self.runCmd(-exec-run)
@@ -46,7 +46,7 @@
self.expect(\^running)
self.expect(\*stopped,reason=\breakpoint-hit\)
-self.runCmd(-break-insert g_MyFunction)
+self.runCmd(-break-insert printf)
self.expect(\^done,bkpt={number=\2\)
self.runCmd(-exec-continue)
Index: test/tools/lldb-mi/breakpoint/main.cpp
===
--- test/tools/lldb-mi/breakpoint/main.cpp
+++ test/tools/lldb-mi/breakpoint/main.cpp
@@ -7,14 +7,11 @@
//
//===--===//
-void
-g_MyFunction(void)
-{
-}
+#include cstdio
int
main(int argc, char const *argv[])
{
-g_MyFunction();
+printf();
return 0; // BP_return
}
Index: test/tools/lldb-mi/control/TestMiExec.py
===
--- test/tools/lldb-mi/control/TestMiExec.py
+++ test/tools/lldb-mi/control/TestMiExec.py
@@ -430,9 +430,8 @@
#self.expect(\^error: Frame index 10 is out of range)
# Set BP at printf and run to BP
-# FIXME: BP at printf not resolved and never hit!
-self.runCmd(-interpreter-exec command \breakpoint set --name
printf\) #FIXME: self.runCmd(-break-insert -f printf)
-self.expect(\^done)
#FIXME: self.expect(\^done,bkpt={number=\3\)
+self.runCmd(-break-insert -f printf)
+self.expect(\^done,bkpt={number=\3\)
self.runCmd(-exec-continue)
self.expect(\^running)
self.expect(\*stopped,reason=\breakpoint-hit\)
Index: tools/lldb-mi/MICmdCmdBreak.cpp
===
--- tools/lldb-mi/MICmdCmdBreak.cpp
+++ tools/lldb-mi/MICmdCmdBreak.cpp
@@ -232,7 +232,7 @@
m_brkPt = sbTarget.BreakpointCreateByLocation(fileName.c_str(),
nFileLine);
break;
case eBreakPoint_ByName:
-m_brkPt = sbTarget.BreakpointCreateByName(m_brkName.c_str(),
sbTarget.GetExecutable().GetFilename());
+m_brkPt = sbTarget.BreakpointCreateByName(m_brkName.c_str(),
nullptr);
break;
case eBreakPoint_count:
case eBreakPoint_NotDefineYet:
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: test/tools/lldb-mi/breakpoint/TestMiBreak.py
===
--- test/tools/lldb-mi/breakpoint/TestMiBreak.py
+++ test/tools/lldb-mi/breakpoint/TestMiBreak.py
@@ -21,7 +21,7 @@
self.runCmd(-file-exec-and-symbols %s % self.myexe)
self.expect(\^done)
-self.runCmd(-break-insert -f g_MyFunction)
+self.runCmd(-break-insert -f printf)
self.expect(\^done,bkpt={number=\1\)
self.runCmd(-exec-run)
@@ -46,7 +46,7 @@
self.expect(\^running)
self.expect(\*stopped,reason=\breakpoint-hit\)
-self.runCmd(-break-insert g_MyFunction)
+self.runCmd(-break-insert printf)
self.expect(\^done,bkpt={number=\2\)
self.runCmd(-exec-continue)
Index: test/tools/lldb-mi/breakpoint/main.cpp
===
--- test/tools/lldb-mi/breakpoint/main.cpp
+++ test/tools/lldb-mi/breakpoint/main.cpp
@@ -7,14 +7,11 @@
//
//===--===//
-void
-g_MyFunction(void)
-{
-}
+#include cstdio
int
main(int argc, char const *argv[])
{
-g_MyFunction();
+printf();
return 0; // BP_return
}
Index: test/tools/lldb-mi/control/TestMiExec.py
===
--- test/tools/lldb-mi/control/TestMiExec.py
+++ test/tools/lldb-mi/control/TestMiExec.py
@@ -430,9 +430,8 @@
#self.expect(\^error: Frame index 10 is out of range)
# Set BP at printf and run to BP
-# FIXME: BP at printf not resolved and never hit!
-self.runCmd(-interpreter-exec command \breakpoint set --name printf\)
[Lldb-commits] [lldb] r232633 - Fix comment in tools/lldb-mi/MIDriver.cpp
Author: ki.stfu Date: Wed Mar 18 08:08:52 2015 New Revision: 232633 URL: http://llvm.org/viewvc/llvm-project?rev=232633view=rev Log: Fix comment in tools/lldb-mi/MIDriver.cpp Modified: lldb/trunk/tools/lldb-mi/MIDriver.cpp Modified: lldb/trunk/tools/lldb-mi/MIDriver.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIDriver.cpp?rev=232633r1=232632r2=232633view=diff == --- lldb/trunk/tools/lldb-mi/MIDriver.cpp (original) +++ lldb/trunk/tools/lldb-mi/MIDriver.cpp Wed Mar 18 08:08:52 2015 @@ -388,7 +388,7 @@ CMIDriver::DoParseArgs(const int argc, c // --executable // The application's options --interpreter and --executable in code act very similar. // The --executable is necessary to differentiate whether the MI Driver is being -// used by a client i.e. Eclipse or from the command line. Eclipse issues the option +// used by a client (e.g. Eclipse) or from the command line. Eclipse issues the option // --interpreter and also passes additional arguments which can be interpreted as an // executable if called from the command line. Using --executable tells the MI // Driver is being called the command line and that the executable argument is indeed ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Convert open options for POSIX open on target platform.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8395
Files:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
Index:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
===
---
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
+++
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
@@ -3233,8 +3233,7 @@
return UINT64_MAX;
stream.PutCStringAsRawHex8(path.c_str());
stream.PutChar(',');
-const uint32_t posix_open_flags =
File::ConvertOpenOptionsForPOSIXOpen(flags);
-stream.PutHex32(posix_open_flags);
+stream.PutHex32(flags);
stream.PutChar(',');
stream.PutHex32(mode);
const char* packet = stream.GetData();
Index:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
===
---
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
+++
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
@@ -567,7 +567,8 @@
{
if (packet.GetChar() == ',')
{
-uint32_t flags = packet.GetHexMaxU32(false, 0);
+uint32_t flags = File::ConvertOpenOptionsForPOSIXOpen(
+packet.GetHexMaxU32(false, 0));
if (packet.GetChar() == ',')
{
mode_t mode = packet.GetHexMaxU32(false, 0600);
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
===
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
@@ -3233,8 +3233,7 @@
return UINT64_MAX;
stream.PutCStringAsRawHex8(path.c_str());
stream.PutChar(',');
-const uint32_t posix_open_flags = File::ConvertOpenOptionsForPOSIXOpen(flags);
-stream.PutHex32(posix_open_flags);
+stream.PutHex32(flags);
stream.PutChar(',');
stream.PutHex32(mode);
const char* packet = stream.GetData();
Index: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
===
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
@@ -567,7 +567,8 @@
{
if (packet.GetChar() == ',')
{
-uint32_t flags = packet.GetHexMaxU32(false, 0);
+uint32_t flags = File::ConvertOpenOptionsForPOSIXOpen(
+packet.GetHexMaxU32(false, 0));
if (packet.GetChar() == ',')
{
mode_t mode = packet.GetHexMaxU32(false, 0600);
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232634 - Convert open options for POSIX open on target platform.
Author: flackr
Date: Wed Mar 18 08:55:48 2015
New Revision: 232634
URL: http://llvm.org/viewvc/llvm-project?rev=232634view=rev
Log:
Convert open options for POSIX open on target platform.
This moves the conversion of the open options to the target platform. On mac
fcntl.h has different values for O_CREAT and O_TRUNC than on linux so by
transmitting the standardized lldb open options we can correctly convert them
on the target platform.
Test Plan:
On linux:
lldb-server p --listen *:1234
On mac:
lldb
platform select remote-linux
platform connect connect://ip-of-linux-box:1234
target create ~/path/to/linux/binary
b main
process launch
Binary is successfully pushed to linux remote, process successfully launches
and break in the main method.
Differential Revision: http://reviews.llvm.org/D8395
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=232634r1=232633r2=232634view=diff
==
---
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
(original)
+++
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
Wed Mar 18 08:55:48 2015
@@ -3233,8 +3233,7 @@ GDBRemoteCommunicationClient::OpenFile (
return UINT64_MAX;
stream.PutCStringAsRawHex8(path.c_str());
stream.PutChar(',');
-const uint32_t posix_open_flags =
File::ConvertOpenOptionsForPOSIXOpen(flags);
-stream.PutHex32(posix_open_flags);
+stream.PutHex32(flags);
stream.PutChar(',');
stream.PutHex32(mode);
const char* packet = stream.GetData();
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp?rev=232634r1=232633r2=232634view=diff
==
---
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
(original)
+++
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
Wed Mar 18 08:55:48 2015
@@ -567,7 +567,8 @@ GDBRemoteCommunicationServerCommon::Hand
{
if (packet.GetChar() == ',')
{
-uint32_t flags = packet.GetHexMaxU32(false, 0);
+uint32_t flags = File::ConvertOpenOptionsForPOSIXOpen(
+packet.GetHexMaxU32(false, 0));
if (packet.GetChar() == ',')
{
mode_t mode = packet.GetHexMaxU32(false, 0600);
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Initial Assembly profiler for mips64
FYI, this seems to have broken the xcode build for me: Undefined symbols for architecture x86_64: EmulateInstructionMIPS64::Initialize(), referenced from: lldb_private::Initialize() in liblldb-core.a(lldb.o) EmulateInstructionMIPS64::Terminate(), referenced from: lldb_private::Terminate() in liblldb-core.a(lldb.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) - BUILD FAILED ** I'm assuming it just needs an xcodeproj update. REPOSITORY rL LLVM http://reviews.llvm.org/D7696 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Remove hack about the size of long doubles from DataExtractor
Fine as long as clang no longer asserts and float values display correctly on x86_64 systems. http://reviews.llvm.org/D8417 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232640 - Skip intermittently failing test on FreeBSD
Author: emaste Date: Wed Mar 18 10:23:53 2015 New Revision: 232640 URL: http://llvm.org/viewvc/llvm-project?rev=232640view=rev Log: Skip intermittently failing test on FreeBSD It is already skipped on the other platforms anyhow. llvm.org/pr19246 Modified: lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py Modified: lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py?rev=232640r1=232639r2=232640view=diff == --- lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py (original) +++ lldb/trunk/test/expression_command/call-restarts/TestCallThatRestarts.py Wed Mar 18 10:23:53 2015 @@ -28,6 +28,7 @@ class ExprCommandThatRestartsTestCase(Te self.call_function() @dwarf_test +@skipIfFreeBSD # llvm.org/pr19246: intermittent failure @skipIfLinux # llvm.org/pr19246: intermittent failure @skipIfDarwin # llvm.org/pr19246: intermittent failure @skipIfWindows # Test relies on signals, unsupported on Windows ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Fix -break-insert for system functions (MI)
lgtm http://reviews.llvm.org/D8412 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.
Comment at: test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:37-38 @@ +36,4 @@ +self.runCmd(target create + exe, CURRENT_EXECUTABLE_SET) +self.runCmd(breakpoint set --name main, BREAKPOINT_CREATED) + +self.runCmd(process launch, RUN_SUCCEEDED) Please don't use self.runCmd(breakpoint set --name main) bare like this in test cases. This makes a breakpoint but never checks that the breakpoint gets set. If something goes wrong with that you'll get some confusing error message later on which won't tell you what really happened. lldbutil has a bunch of utility functions for setting breakpoints that set the breakpoint, and then check that it actually was set - so you can easily set breakpoints without having to do all the checking by hand. run_break_set_by_symbol is the one you want in this case. http://reviews.llvm.org/D8404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] Fix xcodeproj build after http://reviews.llvm.org/rL232619
Hi clayborg,
Adds EmulateInstructionMIPS64 to the xcodeproj build so that it's found when
linking.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8420
Files:
lldb.xcodeproj/project.pbxproj
Index: lldb.xcodeproj/project.pbxproj
===
--- lldb.xcodeproj/project.pbxproj
+++ lldb.xcodeproj/project.pbxproj
@@ -920,6 +920,7 @@
B2B7CCF015D1C20F00EEFB57 /* WatchpointOptions.cpp in Sources */
= {isa = PBXBuildFile; fileRef = B2B7CCEF15D1C20F00EEFB57
E769331C1A94D15400C73337 /* lldb-gdbserver.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 26D6F3F4183E7F9300194858 /*
E769331E1A94D18100C73337 /* lldb-server.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = E769331D1A94D18100C73337 /* lld
+ E7FA0A8D1AB9EF1000626A5B /* EmulateInstructionMIPS64.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = E7FA0A8A1AB9EF1000
ED88244E15114A9200BC98B9 /* Security.framework in Frameworks */
= {isa = PBXBuildFile; fileRef = EDB919B414F6F10D008FF64B
ED88245015114CA200BC98B9 /* main.mm in Sources */ = {isa =
PBXBuildFile; fileRef = ED88244F15114CA200BC98B9 /* main.mm */;
ED88245115114CA200BC98B9 /* main.mm in Sources */ = {isa =
PBXBuildFile; fileRef = ED88244F15114CA200BC98B9 /* main.mm */;
@@ -2663,6 +2664,8 @@
B2B7CCEF15D1C20F00EEFB57 /* WatchpointOptions.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sour
B2D3033612EFA5C500F84EB3 /* InstructionUtils.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcec
E769331D1A94D18100C73337 /* lldb-server.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode
+ E7FA0A8A1AB9EF1000626A5B /* EmulateInstructionMIPS64.cpp */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType
+ E7FA0A8B1AB9EF1000626A5B /* EmulateInstructionMIPS64.h */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
ED88244F15114CA200BC98B9 /* main.mm */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.obj
ED88245215114CFC00BC98B9 /* LauncherRootXPCService.mm */ = {isa
= PBXFileReference; fileEncoding = 4; lastKnownFileType =
EDB919B214F6EC85008FF64B /* LauncherXPCService.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourc
@@ -4608,6 +4611,7 @@
26D9FDCA12F785120003F2EE /* Instruction */ = {
isa = PBXGroup;
children = (
+ E7FA0A881AB9EF1000626A5B /* MIPS64 */,
26D9FDCB12F785270003F2EE /* ARM */,
264A12F91372522000875C42 /* ARM64 */,
);
@@ -5122,6 +5126,15 @@
name = lldb-server;
sourceTree = group;
};
+ E7FA0A881AB9EF1000626A5B /* MIPS64 */ = {
+ isa = PBXGroup;
+ children = (
+ E7FA0A8A1AB9EF1000626A5B /*
EmulateInstructionMIPS64.cpp */,
+ E7FA0A8B1AB9EF1000626A5B /*
EmulateInstructionMIPS64.h */,
+ );
+ path = MIPS64;
+ sourceTree = group;
+ };
EDC6D49114E5C15C001B75F8 /* launcherXPCService */ = {
isa = PBXGroup;
children = (
@@ -6143,6 +6156,7 @@
2689010A13353E6F00698AC0 /*
ThreadPlanTracer.cpp in Sources */,
AF37E10A17C861F20061E18E /* ProcessRunLock.cpp
in Sources */,
26474CAA18D0CB070073DEBA /*
RegisterContextFreeBSD_mips64.cpp in Sources */,
+ E7FA0A8D1AB9EF1000626A5B /*
EmulateInstructionMIPS64.cpp in Sources */,
26CA97A1172B1FD5005DC71B /*
RegisterContextThreadMemory.cpp in Sources */,
2689010B13353E6F00698AC0 /* ThreadSpec.cpp in
Sources */,
2689010C13353E6F00698AC0 /* UnixSignals.cpp in
Sources */,
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: lldb.xcodeproj/project.pbxproj
===
--- lldb.xcodeproj/project.pbxproj
+++ lldb.xcodeproj/project.pbxproj
@@ -920,6 +920,7 @@
B2B7CCF015D1C20F00EEFB57 /* WatchpointOptions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B2B7CCEF15D1C20F00EEFB57
E769331C1A94D15400C73337 /* lldb-gdbserver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26D6F3F4183E7F9300194858 /*
E769331E1A94D18100C73337 /* lldb-server.cpp in Sources */ = {isa =
[Lldb-commits] [lldb] r232653 - Move lldb-log.cpp to core/Logging.cpp
Author: zturner Date: Wed Mar 18 13:20:42 2015 New Revision: 232653 URL: http://llvm.org/viewvc/llvm-project?rev=232653view=rev Log: Move lldb-log.cpp to core/Logging.cpp So that we don't have to update every single #include in the entire codebase to #include this new header (which used to get included by lldb-private-log.h, we automatically #include Logging.h from within Log.h. Added: lldb/trunk/include/lldb/Core/Logging.h - copied, changed from r232649, lldb/trunk/include/lldb/lldb-private-log.h lldb/trunk/source/Core/Logging.cpp - copied, changed from r232649, lldb/trunk/source/lldb-log.cpp Removed: lldb/trunk/include/lldb/lldb-private-log.h lldb/trunk/source/lldb-log.cpp Modified: lldb/trunk/include/lldb/Core/Log.h lldb/trunk/include/lldb/lldb-private.h lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/source/Breakpoint/Breakpoint.cpp lldb/trunk/source/Breakpoint/BreakpointLocation.cpp lldb/trunk/source/Breakpoint/BreakpointResolver.cpp lldb/trunk/source/Breakpoint/BreakpointResolverAddress.cpp lldb/trunk/source/Breakpoint/BreakpointResolverFileLine.cpp lldb/trunk/source/Breakpoint/BreakpointResolverFileRegex.cpp lldb/trunk/source/CMakeLists.txt lldb/trunk/source/Commands/CommandObjectLog.cpp lldb/trunk/source/Core/AddressResolver.cpp lldb/trunk/source/Core/AddressResolverFileLine.cpp lldb/trunk/source/Core/AddressResolverName.cpp lldb/trunk/source/Core/Broadcaster.cpp lldb/trunk/source/Core/CMakeLists.txt lldb/trunk/source/Core/Communication.cpp lldb/trunk/source/Core/ConnectionMachPort.cpp lldb/trunk/source/Core/ConnectionSharedMemory.cpp lldb/trunk/source/Core/DataBufferMemoryMap.cpp lldb/trunk/source/Core/FileLineResolver.cpp lldb/trunk/source/Core/Listener.cpp lldb/trunk/source/Core/Module.cpp lldb/trunk/source/Expression/ClangModulesDeclVendor.cpp lldb/trunk/source/Expression/DWARFExpression.cpp lldb/trunk/source/Host/common/NativeRegisterContext.cpp lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp lldb/trunk/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp lldb/trunk/source/Plugins/Process/Linux/NativeThreadLinux.cpp lldb/trunk/source/Symbol/Block.cpp lldb/trunk/source/Symbol/ObjectFile.cpp lldb/trunk/source/Target/Process.cpp lldb/trunk/source/Target/Target.cpp lldb/trunk/source/Target/Thread.cpp lldb/trunk/source/Target/ThreadPlanCallFunction.cpp lldb/trunk/source/Target/ThreadPlanCallUserExpression.cpp lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp lldb/trunk/source/Target/ThreadPlanStepInRange.cpp lldb/trunk/source/Target/ThreadPlanStepInstruction.cpp lldb/trunk/source/Target/ThreadPlanStepOut.cpp lldb/trunk/source/Target/ThreadPlanStepOverBreakpoint.cpp lldb/trunk/source/Target/ThreadPlanStepOverRange.cpp lldb/trunk/source/Target/ThreadPlanStepRange.cpp lldb/trunk/source/Target/ThreadPlanStepThrough.cpp lldb/trunk/source/Target/ThreadPlanStepUntil.cpp lldb/trunk/source/lldb.cpp lldb/trunk/tools/lldb-server/CMakeLists.txt lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp lldb/trunk/tools/lldb-server/lldb-platform.cpp Modified: lldb/trunk/include/lldb/Core/Log.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Log.h?rev=232653r1=232652r2=232653view=diff == --- lldb/trunk/include/lldb/Core/Log.h (original) +++ lldb/trunk/include/lldb/Core/Log.h Wed Mar 18 13:20:42 2015 @@ -22,6 +22,7 @@ #include lldb/lldb-private.h #include lldb/Core/ConstString.h #include lldb/Core/Flags.h +#include lldb/Core/Logging.h #include lldb/Core/PluginInterface.h //-- Copied: lldb/trunk/include/lldb/Core/Logging.h (from r232649, lldb/trunk/include/lldb/lldb-private-log.h) URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Logging.h?p2=lldb/trunk/include/lldb/Core/Logging.hp1=lldb/trunk/include/lldb/lldb-private-log.hr1=232649r2=232653rev=232653view=diff == --- lldb/trunk/include/lldb/lldb-private-log.h (original) +++ lldb/trunk/include/lldb/Core/Logging.h Wed Mar 18 13:20:42 2015 @@ -1,4 +1,4 @@ -//===-- lldb-private-log.h --*- C++ -*-===// +//===-- Logging.h ---*- C++ -*-===// // // The LLVM Compiler Infrastructure // @@ -7,8 +7,8 @@ // //===--===// -#ifndef liblldb_lldb_private_log_h_ -#define liblldb_lldb_private_log_h_ +#ifndef liblldb_Core_Logging_h_ +#define liblldb_Core_Logging_h_ // C Includes // C++ Includes @@ -90,4 +90,4 @@ ListLogCategories (Stream
[Lldb-commits] [lldb] r232649 - Always add some fake threads with x86_64 registers no matter what the architecture since this is just for testing that we can add new threads with completely different
Author: gclayton
Date: Wed Mar 18 12:03:13 2015
New Revision: 232649
URL: http://llvm.org/viewvc/llvm-project?rev=232649view=rev
Log:
Always add some fake threads with x86_64 registers no matter what the
architecture since this is just for testing that we can add new threads with
completely different registers contexts to a process.
Modified:
lldb/trunk/test/functionalities/plugins/python_os_plugin/operating_system.py
Modified:
lldb/trunk/test/functionalities/plugins/python_os_plugin/operating_system.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/plugins/python_os_plugin/operating_system.py?rev=232649r1=232648r2=232649view=diff
==
---
lldb/trunk/test/functionalities/plugins/python_os_plugin/operating_system.py
(original)
+++
lldb/trunk/test/functionalities/plugins/python_os_plugin/operating_system.py
Wed Mar 18 12:03:13 2015
@@ -59,34 +59,30 @@ class OperatingSystemPlugIn(object):
def get_register_info(self):
if self.registers == None:
self.registers = dict()
-triple = self.process.target.triple
-if triple:
-arch = triple.split('-')[0]
-if arch == 'x86_64':
-self.registers['sets'] = ['GPR', 'FPU', 'EXC']
-self.registers['registers'] = [
-{ 'name':'rax' , 'bitsize' : 64, 'offset' :
0, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 0, 'dwarf' :
0},
-{ 'name':'rbx' , 'bitsize' : 64, 'offset' :
8, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 3, 'dwarf' :
3},
-{ 'name':'rcx' , 'bitsize' : 64, 'offset' :
16, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 2, 'dwarf'
: 2, 'generic':'arg4', 'alt-name':'arg4', },
-{ 'name':'rdx' , 'bitsize' : 64, 'offset' :
24, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 1, 'dwarf'
: 1, 'generic':'arg3', 'alt-name':'arg3', },
-{ 'name':'rdi' , 'bitsize' : 64, 'offset' :
32, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 5, 'dwarf'
: 5, 'generic':'arg1', 'alt-name':'arg1', },
-{ 'name':'rsi' , 'bitsize' : 64, 'offset' :
40, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 4, 'dwarf'
: 4, 'generic':'arg2', 'alt-name':'arg2', },
-{ 'name':'rbp' , 'bitsize' : 64, 'offset' :
48, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 6, 'dwarf'
: 6, 'generic':'fp' , 'alt-name':'fp', },
-{ 'name':'rsp' , 'bitsize' : 64, 'offset' :
56, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 7, 'dwarf'
: 7, 'generic':'sp' , 'alt-name':'sp', },
-{ 'name':'r8', 'bitsize' : 64, 'offset' :
64, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 8, 'dwarf'
: 8, 'generic':'arg5', 'alt-name':'arg5', },
-{ 'name':'r9', 'bitsize' : 64, 'offset' :
72, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 9, 'dwarf'
: 9, 'generic':'arg6', 'alt-name':'arg6', },
-{ 'name':'r10' , 'bitsize' : 64, 'offset' :
80, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 10, 'dwarf'
: 10},
-{ 'name':'r11' , 'bitsize' : 64, 'offset' :
88, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 11, 'dwarf'
: 11},
-{ 'name':'r12' , 'bitsize' : 64, 'offset' :
96, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 12, 'dwarf'
: 12},
-{ 'name':'r13' , 'bitsize' : 64, 'offset' :
104, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 13,
'dwarf' : 13},
-{ 'name':'r14' , 'bitsize' : 64, 'offset' :
112, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 14,
'dwarf' : 14},
-{ 'name':'r15' , 'bitsize' : 64, 'offset' :
120, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 15,
'dwarf' : 15},
-{ 'name':'rip' , 'bitsize' : 64, 'offset' :
128, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'gcc' : 16,
'dwarf' : 16, 'generic':'pc', 'alt-name':'pc' },
-{ 'name':'rflags', 'bitsize' : 64, 'offset' :
136, 'encoding':'uint' , 'format':'hex' , 'set': 0, 'generic':'flags',
'alt-name':'flags' },
-{ 'name':'cs', 'bitsize' : 64, 'offset' :
144, 'encoding':'uint' , 'format':'hex' , 'set': 0
},
-{ 'name':'fs', 'bitsize' : 64, 'offset' :
152,
Re: [Lldb-commits] [PATCH] Fix xcodeproj build after http://reviews.llvm.org/rL232619
Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D8420 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232655 - Fix the Xcode build after the MIPS64 changes
Author: enrico
Date: Wed Mar 18 13:42:41 2015
New Revision: 232655
URL: http://llvm.org/viewvc/llvm-project?rev=232655view=rev
Log:
Fix the Xcode build after the MIPS64 changes
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=232655r1=232654r2=232655view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Mar 18 13:42:41 2015
@@ -797,6 +797,7 @@
947A1D651616476B0017C8D1 /* CommandObjectPlugin.h in Headers */
= {isa = PBXBuildFile; fileRef = 947A1D631616476A0017C8D1 /*
CommandObjectPlugin.h */; };
9492E2A51A8AC11000295BBD /* CoreMedia.cpp in Sources */ = {isa
= PBXBuildFile; fileRef = 9492E2A41A8AC11000295BBD /* CoreMedia.cpp */; };
949ADF031406F648004833E1 /* ValueObjectConstResultImpl.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = 949ADF021406F648004833E1 /*
ValueObjectConstResultImpl.cpp */; };
+ 94A5B3971AB9FE8D00A5EE7F /* EmulateInstructionMIPS64.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = 94A5B3951AB9FE8300A5EE7F /*
EmulateInstructionMIPS64.cpp */; };
94B6E76213D88365005F417F /* ValueObjectSyntheticFilter.cpp in
Sources */ = {isa = PBXBuildFile; fileRef = 94B6E76113D88362005F417F /*
ValueObjectSyntheticFilter.cpp */; };
94BA8B6D176F8C9B005A91B5 /* Range.cpp in Sources */ = {isa =
PBXBuildFile; fileRef = 94BA8B6C176F8C9B005A91B5 /* Range.cpp */; };
94BA8B70176F97CE005A91B5 /* CommandHistory.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 94BA8B6F176F97CE005A91B5 /* CommandHistory.cpp
*/; };
@@ -2448,6 +2449,8 @@
9492E2A41A8AC11000295BBD /* CoreMedia.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = CoreMedia.cpp; path = source/DataFormatters/CoreMedia.cpp; sourceTree =
group; };
949ADF001406F62E004833E1 /* ValueObjectConstResultImpl.h */ =
{isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name =
ValueObjectConstResultImpl.h; path =
include/lldb/Core/ValueObjectConstResultImpl.h; sourceTree = group; };
949ADF021406F648004833E1 /* ValueObjectConstResultImpl.cpp */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.cpp.cpp; name = ValueObjectConstResultImpl.cpp; path =
source/Core/ValueObjectConstResultImpl.cpp; sourceTree = group; };
+ 94A5B3951AB9FE8300A5EE7F /* EmulateInstructionMIPS64.cpp */ =
{isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name =
EmulateInstructionMIPS64.cpp; path = MIPS64/EmulateInstructionMIPS64.cpp;
sourceTree = group; };
+ 94A5B3961AB9FE8300A5EE7F /* EmulateInstructionMIPS64.h */ =
{isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name =
EmulateInstructionMIPS64.h; path = MIPS64/EmulateInstructionMIPS64.h;
sourceTree = group; };
94B6E76013D8833C005F417F /* ValueObjectSyntheticFilter.h */ =
{isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name =
ValueObjectSyntheticFilter.h; path =
include/lldb/Core/ValueObjectSyntheticFilter.h; sourceTree = group; };
94B6E76113D88362005F417F /* ValueObjectSyntheticFilter.cpp */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.cpp.cpp; name = ValueObjectSyntheticFilter.cpp; path =
source/Core/ValueObjectSyntheticFilter.cpp; sourceTree = group; };
94BA8B6C176F8C9B005A91B5 /* Range.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = Range.cpp; path = source/Utility/Range.cpp; sourceTree = group; };
@@ -3347,8 +3350,9 @@
264A12FA1372522000875C42 /*
EmulateInstructionARM64.cpp */,
264A12FB1372522000875C42 /*
EmulateInstructionARM64.h */,
);
- path = ARM64;
- sourceTree = group;
+ name = ARM64;
+ path = source/Plugins/Instruction/ARM64;
+ sourceTree = SOURCE_ROOT;
};
264A97BC133918A30017F0BE /* GDB Server */ = {
isa = PBXGroup;
@@ -4610,6 +4614,7 @@
children = (
26D9FDCB12F785270003F2EE /* ARM */,
264A12F91372522000875C42 /* ARM64 */,
+ 94A5B3941AB9FE5F00A5EE7F /* MIPS64 */,
);
path = Instruction;
sourceTree = group;
@@ -5002,6 +5007,15 @@
name = POSIX;
sourceTree = group;
};
+
Re: [Lldb-commits] [PATCH] Fix memory allocating inside signal handler (MI)
Revert CMICmnResources; Remove logging from signal handlers http://reviews.llvm.org/D8256 Files: tools/lldb-mi/MIDriverMain.cpp Index: tools/lldb-mi/MIDriverMain.cpp === --- tools/lldb-mi/MIDriverMain.cpp +++ tools/lldb-mi/MIDriverMain.cpp @@ -39,7 +39,6 @@ #include MICmnResources.h #include MICmnStreamStdin.h #include MIUtilDebug.h -#include MICmnLog.h #if MICONFIG_COMPILE_MIDRIVER_VERSION @@ -74,8 +73,6 @@ rDriverMgr.DriverResizeWindow((uint32_t)window_size.ws_col); } } - - CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGWINCH, vSigno)); } // CODETAG_IOR_SIGNALS @@ -109,8 +106,6 @@ } } - CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGINT, vSigno)); - // Send signal to driver so that it can take suitable action rDriverMgr.DeliverSignal (vSigno); } @@ -141,8 +136,6 @@ pDebugger-SaveInputTerminalState(); } - CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGTSTP, vSigno)); - // Send signal to driver so that it can take suitable action rDriverMgr.DeliverSignal (vSigno); } @@ -172,8 +165,6 @@ pDebugger-RestoreInputTerminalState(); } - CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGCONT, vSigno)); - // Send signal to driver so that it can take suitable action rDriverMgr.DeliverSignal (vSigno); } EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: tools/lldb-mi/MIDriverMain.cpp === --- tools/lldb-mi/MIDriverMain.cpp +++ tools/lldb-mi/MIDriverMain.cpp @@ -39,7 +39,6 @@ #include MICmnResources.h #include MICmnStreamStdin.h #include MIUtilDebug.h -#include MICmnLog.h #if MICONFIG_COMPILE_MIDRIVER_VERSION @@ -74,8 +73,6 @@ rDriverMgr.DriverResizeWindow((uint32_t)window_size.ws_col); } } - -CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGWINCH, vSigno)); } // CODETAG_IOR_SIGNALS @@ -109,8 +106,6 @@ } } -CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGINT, vSigno)); - // Send signal to driver so that it can take suitable action rDriverMgr.DeliverSignal (vSigno); } @@ -141,8 +136,6 @@ pDebugger-SaveInputTerminalState(); } -CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGTSTP, vSigno)); - // Send signal to driver so that it can take suitable action rDriverMgr.DeliverSignal (vSigno); } @@ -172,8 +165,6 @@ pDebugger-RestoreInputTerminalState(); } -CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), SIGCONT, vSigno)); - // Send signal to driver so that it can take suitable action rDriverMgr.DeliverSignal (vSigno); } ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Fix xcodeproj build after http://reviews.llvm.org/rL232619
Thanks for the FYI, you beat me to landing the fix :-). In hindsight I see that simple patches which fix build breakages can be landed before review. REPOSITORY rL LLVM http://reviews.llvm.org/D8420 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Move LLDB initialization / shutdown to Application
Or APIPrivate or PrivateAPI? http://reviews.llvm.org/D8428 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] expose 64 bit addresses through MI
I am now using the PRIx64 macro in all locations. I checked and made sure that
every type being used is either an MIUint64 or and lldb::addr_t, both of with
are uint64s. I also noticed that IDS_CMD_ERR_LLDB_ERR_READ_MEM_BYTES was being
initialized twice, and switched the second initialization to the correct
IDS_CMD_ERR_LLDB_ERR_NOT_WRITE_WHOLEBLK
http://reviews.llvm.org/D8238
Files:
tools/lldb-mi/MICmdCmdBreak.cpp
tools/lldb-mi/MICmdCmdData.cpp
tools/lldb-mi/MICmdCmdGdbInfo.cpp
tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp
tools/lldb-mi/MICmnLLDBDebugSessionInfo.h
tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp
tools/lldb-mi/MICmnResources.cpp
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: tools/lldb-mi/MICmdCmdBreak.cpp
===
--- tools/lldb-mi/MICmdCmdBreak.cpp
+++ tools/lldb-mi/MICmdCmdBreak.cpp
@@ -324,7 +324,7 @@
sBrkPtInfo.m_nBrkPtThreadId = m_nBrkPtThreadId;
// MI print
-// ^done,bkpt={number=\%d\,type=\breakpoint\,disp=\%s\,enabled=\%c\,addr=\0x%08x\,func=\%s\,file=\%s\,fullname=\%s/%s\,line=\%d\,thread-groups=[\%s\],times=\%d\,original-location=\%s\}
+// ^done,bkpt={number=\%d\,type=\breakpoint\,disp=\%s\,enabled=\%c\,addr=\0x%016 PRIx64 \,func=\%s\,file=\%s\,fullname=\%s/%s\,line=\%d\,thread-groups=[\%s\],times=\%d\,original-location=\%s\}
CMICmnMIValueTuple miValueTuple;
if (!rSessionInfo.MIResponseFormBrkPtInfo(sBrkPtInfo, miValueTuple))
{
Index: tools/lldb-mi/MICmdCmdData.cpp
===
--- tools/lldb-mi/MICmdCmdData.cpp
+++ tools/lldb-mi/MICmdCmdData.cpp
@@ -18,6 +18,7 @@
// CMICmdCmdDataWriteMemoryimplementation.
// Third Party Headers:
+#include inttypes.h //PRIx64
#include lldb/API/SBThread.h
#include lldb/API/SBInstruction.h
#include lldb/API/SBInstructionList.h
@@ -418,8 +419,8 @@
pStrOperands = (pStrOperands != nullptr) ? pStrOperands : pUnknown;
const size_t instrtSize = instrt.GetByteSize();
-// MI {address=\0x%08llx\,func-name=\%s\,offset=\%lld\,inst=\%s %s\}
-const CMICmnMIValueConst miValueConst(CMIUtilString::Format(0x%08llx, addr));
+// MI {address=\0x%016 PRIx64 \,func-name=\%s\,offset=\%lld\,inst=\%s %s\}
+const CMICmnMIValueConst miValueConst(CMIUtilString::Format(0x%016 PRIx64, addr));
const CMICmnMIValueResult miValueResult(address, miValueConst);
CMICmnMIValueTuple miValueTuple(miValueResult);
const CMICmnMIValueConst miValueConst2(pFnName);
@@ -629,14 +630,14 @@
bool
CMICmdCmdDataReadMemoryBytes::Acknowledge(void)
{
-// MI: memory=[{begin=\0x%08x\,offset=\0x%08x\,end=\0x%08x\,contents=\ \ }]
-const CMICmnMIValueConst miValueConst(CMIUtilString::Format(0x%08llx, m_nAddrStart));
+// MI: memory=[{begin=\0x%016 PRIx64 \,offset=\0x%016 PRIx64 \,end=\0x%016 PRIx64 \,contents=\ \ }]
+const CMICmnMIValueConst miValueConst(CMIUtilString::Format(0x%016 PRIx64, m_nAddrStart));
const CMICmnMIValueResult miValueResult(begin, miValueConst);
CMICmnMIValueTuple miValueTuple(miValueResult);
-const CMICmnMIValueConst miValueConst2(CMIUtilString::Format(0x%08llx, m_nAddrOffset));
+const CMICmnMIValueConst miValueConst2(CMIUtilString::Format(0x%016 PRIx64, m_nAddrOffset));
const CMICmnMIValueResult miValueResult2(offset, miValueConst2);
miValueTuple.Add(miValueResult2);
-const CMICmnMIValueConst miValueConst3(CMIUtilString::Format(0x%08llx, m_nAddrStart + m_nAddrNumBytesToRead));
+const CMICmnMIValueConst miValueConst3(CMIUtilString::Format(0x%016 PRIx64, m_nAddrStart + m_nAddrNumBytesToRead));
const CMICmnMIValueResult miValueResult3(end, miValueConst3);
miValueTuple.Add(miValueResult3);
Index: tools/lldb-mi/MICmdCmdGdbInfo.cpp
===
--- tools/lldb-mi/MICmdCmdGdbInfo.cpp
+++ tools/lldb-mi/MICmdCmdGdbInfo.cpp
@@ -10,6 +10,7 @@
// Overview:CMICmdCmdGdbInfoimplementation.
// Third party headers:
+#include inttypes.h //PRIx64
#include lldb/API/SBCommandReturnObject.h
// In-house headers:
@@ -199,7 +200,7 @@
const CMIUtilString strModuleFileName(module.GetFileSpec().GetFilename());
const CMIUtilString strModuleFullPath(CMIUtilString::Format(%s/%s, strModuleFilePath.c_str(), strModuleFileName.c_str()));
const CMIUtilString strHasSymbols = (module.GetNumSymbols() 0) ? Yes : No;
-lldb::addr_t addrLoadS = 0x;
+lldb::addr_t addrLoadS = 0x;
lldb::addr_t addrLoadSize = 0;
bool bHaveAddrLoad = false;
const MIuint nSections = module.GetNumSections();
@@ -219,7 +220,7 @@
}
}
bOk = bOk
- rStdout.TextToStdout(CMIUtilString::Format(~\0x%08x\t0x%08x\t%s\t\t%s\,
[Lldb-commits] [lldb] r232689 - Comment discouraging writing command based test cases.
Author: jingham Date: Wed Mar 18 18:16:58 2015 New Revision: 232689 URL: http://llvm.org/viewvc/llvm-project?rev=232689view=rev Log: Comment discouraging writing command based test cases. Modified: lldb/trunk/test/README-TestSuite Modified: lldb/trunk/test/README-TestSuite URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/README-TestSuite?rev=232689r1=232688r2=232689view=diff == --- lldb/trunk/test/README-TestSuite (original) +++ lldb/trunk/test/README-TestSuite Wed Mar 18 18:16:58 2015 @@ -133,3 +133,27 @@ $ DOTEST_PROFILE=YES DOTEST_SCRIPT_DIR=/ After that, I used the pstats.py module to browse the statistics: $ python /System/Library/Frameworks/Python.framework/Versions/Current/lib/python2.6/pstats.py my.profile + +o Writing test cases: + + We strongly prefer writing test cases using the SB API's rather than the runCmd expect. + Unless you are actually testing some feature of the command line, please don't write + command based tests. For historical reasons there are plenty of examples of tests in the + test suite that use runCmd where they shouldn't, but don't copy them, copy the plenty that + do use the SB API's instead. + + The reason for this is that our policy is that we will maintain compatibility with the + SB API's. But we don't make any similar guarantee about the details of command result format. + If your test is using the command line, it is going to have to check against the command result + text, and you either end up writing your check pattern by checking as little as possible so + you won't be exposed to random changes in the text; in which case you can end up missing some + failure, or you test too much and it means irrelevant changes break your tests. + + However, if you use the Python API's it is possible to check all the results you want + to check in a very explicit way, which makes the tests much more robust. + + Even if you are testing that a command-line command does some specific thing, it is still + better in general to use the SB API's to drive to the point where you want to run the test, + then use SBInterpreter::HandleCommand to run the command. You get the full result text + from the command in the command return object, and all the part where you are driving the + debugger to the point you want to test will be more robust. ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Move LLDB initialization / shutdown to Application
I actually had it called Initialization originally. I like Initialization slightly better than InternalAPI because it makes it clear that that the stuff is specific to initialization. InternalAPI makes me think I can go put a bunch of random stuff in it which might make more sense somewhere else where it's more logically grouped. Other names might be something like DebuggerInit or DebuggerLifetime http://reviews.llvm.org/D8428 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Move LLDB initialization / shutdown to Application
Initialization would be fine. http://reviews.llvm.org/D8428 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232687 - Enable TestCallStdStringFunction for GCC.
Author: sivachandra
Date: Wed Mar 18 18:02:28 2015
New Revision: 232687
URL: http://llvm.org/viewvc/llvm-project?rev=232687view=rev
Log:
Enable TestCallStdStringFunction for GCC.
Test Plan: dotest.py -C gcc -p TestCallStdStringFunction
Reviewers: vharron
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D8426
Modified:
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
Modified:
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py?rev=232687r1=232686r2=232687view=diff
==
---
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
(original)
+++
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
Wed Mar 18 18:02:28 2015
@@ -28,7 +28,6 @@ class ExprCommandCallFunctionTestCase(Te
@dwarf_test
@expectedFailureFreeBSD('llvm.org/pr17807') # Fails on FreeBSD buildbot
-@expectedFailureGcc # llvm.org/pr14437, fails with GCC 4.6.3 and 4.7.2
@expectedFailureIcc # llvm.org/pr14437, fails with ICC 13.1
@expectedFailureDarwin(16361880) # rdar://problem/16361880, we get the
result correctly, but fail to invoke the Summary formatter.
def test_with_dwarf(self):
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Enable TestCallStdStringFunction for GCC.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8426
Files:
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
Index:
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
===
---
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
+++
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
@@ -28,7 +28,6 @@
@dwarf_test
@expectedFailureFreeBSD('llvm.org/pr17807') # Fails on FreeBSD buildbot
-@expectedFailureGcc # llvm.org/pr14437, fails with GCC 4.6.3 and 4.7.2
@expectedFailureIcc # llvm.org/pr14437, fails with ICC 13.1
@expectedFailureDarwin(16361880) # rdar://problem/16361880, we get the
result correctly, but fail to invoke the Summary formatter.
def test_with_dwarf(self):
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
===
--- lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
+++ lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
@@ -28,7 +28,6 @@
@dwarf_test
@expectedFailureFreeBSD('llvm.org/pr17807') # Fails on FreeBSD buildbot
-@expectedFailureGcc # llvm.org/pr14437, fails with GCC 4.6.3 and 4.7.2
@expectedFailureIcc # llvm.org/pr14437, fails with ICC 13.1
@expectedFailureDarwin(16361880) # rdar://problem/16361880, we get the result correctly, but fail to invoke the Summary formatter.
def test_with_dwarf(self):
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232702 - Add NameMatches.h header to fix FreeBSD build after r232673
Author: emaste Date: Wed Mar 18 21:47:36 2015 New Revision: 232702 URL: http://llvm.org/viewvc/llvm-project?rev=232702view=rev Log: Add NameMatches.h header to fix FreeBSD build after r232673 Modified: lldb/trunk/source/Host/freebsd/Host.cpp Modified: lldb/trunk/source/Host/freebsd/Host.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/freebsd/Host.cpp?rev=232702r1=232701r2=232702view=diff == --- lldb/trunk/source/Host/freebsd/Host.cpp (original) +++ lldb/trunk/source/Host/freebsd/Host.cpp Wed Mar 18 21:47:36 2015 @@ -38,6 +38,7 @@ #include lldb/Core/DataBufferHeap.h #include lldb/Core/DataExtractor.h #include lldb/Utility/CleanUp.h +#include lldb/Utility/NameMatches.h #include Plugins/Process/Utility/FreeBSDSignals.h ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Fix handling of CommandInterpreter's events in lldb-mi
Friendly ping http://reviews.llvm.org/D8382 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] Initial Assembly profiler for mips64
In http://reviews.llvm.org/D7696#142754, @flackr wrote: FYI, this seems to have broken the xcode build for me: Undefined symbols for architecture x86_64: EmulateInstructionMIPS64::Initialize(), referenced from: lldb_private::Initialize() in liblldb-core.a(lldb.o) EmulateInstructionMIPS64::Terminate(), referenced from: lldb_private::Terminate() in liblldb-core.a(lldb.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) - BUILD FAILED ** I'm assuming it just needs an xcodeproj update. I put up a review to fix it: http://reviews.llvm.org/D8420 REPOSITORY rL LLVM http://reviews.llvm.org/D7696 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [lldb] r232653 - Move lldb-log.cpp to core/Logging.cpp
On 18 March 2015 at 14:20, Zachary Turner ztur...@google.com wrote: Author: zturner Date: Wed Mar 18 13:20:42 2015 New Revision: 232653 URL: http://llvm.org/viewvc/llvm-project?rev=232653view=rev Log: Move lldb-log.cpp to core/Logging.cpp Looks like we need a Makefile update too: http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/4973 gmake[3]: *** No rule to make target '/usr/home/buildslave/slave_as-bldslv5/lldb-x86_64-freebsd/llvm.src/tools/lldb/source/lldb-log.cpp', needed by '/usr/home/buildslave/slave_as-bldslv5/lldb-x86_64-freebsd/llvm.obj/tools/lldb/source/Release+Asserts/lldb-log.o'. Stop. ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232669 - Try to fix the Makefile build.
Author: zturner Date: Wed Mar 18 15:58:39 2015 New Revision: 232669 URL: http://llvm.org/viewvc/llvm-project?rev=232669view=rev Log: Try to fix the Makefile build. I deleted lldb-log.cpp, but the Makefile build lists this file explicitly, so it is removed in this patch. Modified: lldb/trunk/source/Makefile Modified: lldb/trunk/source/Makefile URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Makefile?rev=232669r1=232668r2=232669view=diff == --- lldb/trunk/source/Makefile (original) +++ lldb/trunk/source/Makefile Wed Mar 18 15:58:39 2015 @@ -19,7 +19,7 @@ ifeq (Darwin,$(shell uname -s)) BUILT_SOURCES = LLDB_vers.c endif -SOURCES := lldb-log.cpp lldb.cpp +SOURCES := lldb.cpp include $(LLDB_LEVEL)/Makefile ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r232673 - Move some functions from source/lldb.cpp to Utility.
Author: zturner
Date: Wed Mar 18 16:31:45 2015
New Revision: 232673
URL: http://llvm.org/viewvc/llvm-project?rev=232673view=rev
Log:
Move some functions from source/lldb.cpp to Utility.
Specifically, there were some functions for converting enums
to strings and a function for matching a string using a specific
matching algorithm. This moves those functions to more appropriate
headers in lldb/Utility and updates references to include the
new headers.
Added:
lldb/trunk/include/lldb/Utility/ConvertEnum.h
lldb/trunk/include/lldb/Utility/NameMatches.h
lldb/trunk/source/Utility/ConvertEnum.cpp
lldb/trunk/source/Utility/NameMatches.cpp
Modified:
lldb/trunk/include/lldb/lldb-private.h
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/source/Core/ArchSpec.cpp
lldb/trunk/source/Core/Log.cpp
lldb/trunk/source/Core/Section.cpp
lldb/trunk/source/Host/macosx/Host.mm
lldb/trunk/source/Target/Process.cpp
lldb/trunk/source/Target/ThreadList.cpp
lldb/trunk/source/Target/ThreadPlan.cpp
lldb/trunk/source/Utility/CMakeLists.txt
lldb/trunk/source/lldb.cpp
Added: lldb/trunk/include/lldb/Utility/ConvertEnum.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/ConvertEnum.h?rev=232673view=auto
==
--- lldb/trunk/include/lldb/Utility/ConvertEnum.h (added)
+++ lldb/trunk/include/lldb/Utility/ConvertEnum.h Wed Mar 18 16:31:45 2015
@@ -0,0 +1,22 @@
+//===-- ConvertEnum.h ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+#ifndef LLDB_UTILITY_CONVERTENUM_H
+#define LLDB_UTILITY_CONVERTENUM_H
+
+#include lldb/lldb-enumerations.h
+#include lldb/lldb-private-enumerations.h
+
+namespace lldb_private
+{
+
+const char *GetVoteAsCString(Vote vote);
+const char *GetSectionTypeAsCString(lldb::SectionType sect_type);
+}
+
+#endif
Added: lldb/trunk/include/lldb/Utility/NameMatches.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/NameMatches.h?rev=232673view=auto
==
--- lldb/trunk/include/lldb/Utility/NameMatches.h (added)
+++ lldb/trunk/include/lldb/Utility/NameMatches.h Wed Mar 18 16:31:45 2015
@@ -0,0 +1,19 @@
+//===-- NameMatches.h ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+#ifndef LLDB_UTILITY_NAMEMATCHES_H
+#define LLDB_UTILITY_NAMEMATCHES_H
+
+#include lldb/lldb-private-enumerations.h
+
+namespace lldb_private
+{
+bool NameMatches(const char *name, NameMatchType match_type, const char
*match);
+}
+
+#endif
Modified: lldb/trunk/include/lldb/lldb-private.h
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/lldb-private.h?rev=232673r1=232672r2=232673view=diff
==
--- lldb/trunk/include/lldb/lldb-private.h (original)
+++ lldb/trunk/include/lldb/lldb-private.h Wed Mar 18 16:31:45 2015
@@ -94,15 +94,6 @@ TerminateLLGS();
const char *
GetVersion ();
-const char *
-GetVoteAsCString (Vote vote);
-
-const char *
-GetSectionTypeAsCString (lldb::SectionType sect_type);
-
-bool
-NameMatches (const char *name, NameMatchType match_type, const char *match);
-
} // namespace lldb_private
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=232673r1=232672r2=232673view=diff
==
--- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)
+++ lldb/trunk/lldb.xcodeproj/project.pbxproj Wed Mar 18 16:31:45 2015
@@ -684,6 +684,8 @@
33E5E8461A6736D30024ED68 /* StringConvert.h in CopyFiles */ =
{isa = PBXBuildFile; fileRef = 33E5E8451A6736D30024ED68 /* StringConvert.h */;
};
33E5E8471A674FB60024ED68 /* StringConvert.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 33E5E8411A672A240024ED68 /* StringConvert.cpp
*/; };
3F8160A61AB9F7DD001DA9DF /* Logging.cpp in Sources */ = {isa =
PBXBuildFile; fileRef = 3F8160A51AB9F7DD001DA9DF /* Logging.cpp */; };
+ 3F8169191ABA2419001DA9DF /* ConvertEnum.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 3F8169171ABA2419001DA9DF /* ConvertEnum.cpp */;
};
+ 3F81691A1ABA2419001DA9DF /* NameMatches.cpp in Sources */ =
{isa = PBXBuildFile; fileRef = 3F8169181ABA2419001DA9DF
