[llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
Changes in directory llvm-test/MultiSource/Benchmarks/Olden/voronoi: newvor.c updated: 1.11 - 1.12 --- Log message: I think the correct thing to do is decide if malloc.h should be included based on OS, not arch --- Diffs of the changes: (+1 -1) newvor.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c diff -u llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11 llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.12 --- llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11Mon Apr 17 12:55:40 2006 +++ llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c Thu Apr 26 14:55:25 2007 @@ -4,7 +4,7 @@ #include stdlib.h #include defines.h -#if defined(__alpha__) +#if defined(__alpha__) || defined(__x86_64__) #include malloc.h #endif ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
Absolutely true. This change will cause the test to fail on the BSDs, which will complain that malloc.h has been replaced by stdlib.h. Please use a different test. Andrew Lenharth wrote: Changes in directory llvm-test/MultiSource/Benchmarks/Olden/voronoi: newvor.c updated: 1.11 - 1.12 --- Log message: I think the correct thing to do is decide if malloc.h should be included based on OS, not arch --- Diffs of the changes: (+1 -1) newvor.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c diff -u llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11 llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.12 --- llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11 Mon Apr 17 12:55:40 2006 +++ llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c Thu Apr 26 14:55:25 2007 @@ -4,7 +4,7 @@ #include stdlib.h #include defines.h -#if defined(__alpha__) +#if defined(__alpha__) || defined(__x86_64__) #include malloc.h #endif ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
[llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
Changes in directory llvm-test/MultiSource/Benchmarks/Olden/voronoi: newvor.c updated: 1.12 - 1.13 --- Log message: test os rather than arch --- Diffs of the changes: (+1 -1) newvor.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c diff -u llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.12 llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.13 --- llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.12Thu Apr 26 14:55:25 2007 +++ llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c Thu Apr 26 15:19:47 2007 @@ -4,7 +4,7 @@ #include stdlib.h #include defines.h -#if defined(__alpha__) || defined(__x86_64__) +#if defined(__linux__) #include malloc.h #endif ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
On Apr 26, 2007, at 1:11 PM, Jeff Cohen wrote: Absolutely true. This change will cause the test to fail on the BSDs, which will complain that malloc.h has been replaced by stdlib.h. Please use a different test. Better yet, just unconditionally #include stdlib.h and eliminate malloc.h -Chris Andrew Lenharth wrote: Changes in directory llvm-test/MultiSource/Benchmarks/Olden/voronoi: newvor.c updated: 1.11 - 1.12 --- Log message: I think the correct thing to do is decide if malloc.h should be included based on OS, not arch --- Diffs of the changes: (+1 -1) newvor.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c diff -u llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c: 1.11 llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.12 --- llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11 Mon Apr 17 12:55:40 2006 +++ llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c Thu Apr 26 14:55:25 2007 @@ -4,7 +4,7 @@ #include stdlib.h #include defines.h -#if defined(__alpha__) +#if defined(__alpha__) || defined(__x86_64__) #include malloc.h #endif ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
Chris Lattner wrote: On Apr 26, 2007, at 1:11 PM, Jeff Cohen wrote: Absolutely true. This change will cause the test to fail on the BSDs, which will complain that malloc.h has been replaced by stdlib.h. Please use a different test. Better yet, just unconditionally #include stdlib.h and eliminate malloc.h -Chris It already does include stdlib.h. I assume it isn't enough on his system. Andrew Lenharth wrote: Changes in directory llvm-test/MultiSource/Benchmarks/Olden/voronoi: newvor.c updated: 1.11 - 1.12 --- Log message: I think the correct thing to do is decide if malloc.h should be included based on OS, not arch --- Diffs of the changes: (+1 -1) newvor.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c diff -u llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11 llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.12 --- llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11 Mon Apr 17 12:55:40 2006 +++ llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.cThu Apr 26 14:55:25 2007 @@ -4,7 +4,7 @@ #include stdlib.h #include defines.h -#if defined(__alpha__) +#if defined(__alpha__) || defined(__x86_64__) #include malloc.h #endif ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
Chris Lattner wrote: On Apr 26, 2007, at 2:23 PM, Jeff Cohen wrote: Chris Lattner wrote: On Apr 26, 2007, at 1:11 PM, Jeff Cohen wrote: Absolutely true. This change will cause the test to fail on the BSDs, which will complain that malloc.h has been replaced by stdlib.h. Please use a different test. Better yet, just unconditionally #include stdlib.h and eliminate malloc.h -Chris It already does include stdlib.h. I assume it isn't enough on his system. Andrew, can alpha drop the malloc.h #include? If not, why not? We should remove all instances of malloc.h from llvm-test. -Chris A more interesting question is why he needed to add it for x86_64. If Linux doesn't need it for x86, it shouldn't need it for x86_64 either. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
I need it because it isn't defined by stdlib.h on linux. I need it because it is defaulting to: int memalign(...), lacking any other definition. It happens to work in most usage this way, but it isn't correct. Andrew On 4/26/07, Jeff Cohen [EMAIL PROTECTED] wrote: Chris Lattner wrote: On Apr 26, 2007, at 2:23 PM, Jeff Cohen wrote: Chris Lattner wrote: On Apr 26, 2007, at 1:11 PM, Jeff Cohen wrote: Absolutely true. This change will cause the test to fail on the BSDs, which will complain that malloc.h has been replaced by stdlib.h. Please use a different test. Better yet, just unconditionally #include stdlib.h and eliminate malloc.h -Chris It already does include stdlib.h. I assume it isn't enough on his system. Andrew, can alpha drop the malloc.h #include? If not, why not? We should remove all instances of malloc.h from llvm-test. -Chris A more interesting question is why he needed to add it for x86_64. If Linux doesn't need it for x86, it shouldn't need it for x86_64 either. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
Re: [llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
On Apr 26, 2007, at 2:42 PM, Andrew Lenharth wrote: I need it because it isn't defined by stdlib.h on linux. I need it because it is defaulting to: int memalign(...), lacking any other definition. It happens to work in most usage this way, but it isn't correct. Easy solution. In that source file, unconditionally define MEMALIGN_IS_NOT_AVAILABLE -Chris Andrew On 4/26/07, Jeff Cohen [EMAIL PROTECTED] wrote: Chris Lattner wrote: On Apr 26, 2007, at 2:23 PM, Jeff Cohen wrote: Chris Lattner wrote: On Apr 26, 2007, at 1:11 PM, Jeff Cohen wrote: Absolutely true. This change will cause the test to fail on the BSDs, which will complain that malloc.h has been replaced by stdlib.h. Please use a different test. Better yet, just unconditionally #include stdlib.h and eliminate malloc.h -Chris It already does include stdlib.h. I assume it isn't enough on his system. Andrew, can alpha drop the malloc.h #include? If not, why not? We should remove all instances of malloc.h from llvm-test. -Chris A more interesting question is why he needed to add it for x86_64. If Linux doesn't need it for x86, it shouldn't need it for x86_64 either. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
[llvm-commits] CVS: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
Changes in directory llvm-test/MultiSource/Benchmarks/Olden/voronoi:
newvor.c updated: 1.10 - 1.11
---
Log message:
Add checks for __OpenBSD__.
---
Diffs of the changes: (+1 -1)
newvor.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c
diff -u llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.10
llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.11
--- llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c:1.10Fri Jul
15 19:26:48 2005
+++ llvm-test/MultiSource/Benchmarks/Olden/voronoi/newvor.c Mon Apr 17
12:55:40 2006
@@ -165,7 +165,7 @@
void delete_all_edges() { next_edge= 0; avail_edge = NYL;}
-#if defined(__APPLE__) || defined(__FreeBSD__)
+#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__OpenBSD__)
#define MEMALIGN_IS_NOT_AVAILABLE
#endif
___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
