[jira] (LOG4J2-1431) Simplify log4j system property naming scheme

[Gary Gregory (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Gary Gregory commented on  LOG4J2-1431 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Simplify log4j system property naming scheme  
 
 
 
 
 
 
 
 
 
 
I like simplification and consistency  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   

Re: logging-log4j2 git commit: Normalize use of markdown headers

[Remko Popma]

Probably an artifact of the diffing format. Sorry about that. 

Sent from my iPhone

> On Jan 30, 2017, at 8:42, Matt Sicker  wrote:
> 
> I see in the file:
> 
> Apache Log4j ${Log4jReleaseVersion} is signed by ${Log4jReleaseManager} 
> (${Log4jReleaseKey})
> 
> Email might've been buggy.
> 
>> On 29 January 2017 at 17:20, Remko Popma  wrote:
>> Dangling curly in download.md?
>> 
>> Apache Log4j ${Log4jReleaseVersion} is signed by ${Log4jReleaseManager} 
>> (${Log4j
>> Alternatively, you can verify
>> 
>> Sent from my iPhone
>> 
>> > On Jan 30, 2017, at 2:44, mattsic...@apache.org wrote:
>> >
>> > Apache Log4j ${Log4jReleaseVersion} is signed by ${Log4jReleaseManager} 
>> > (${Log4j
>> > Alternatively, you can verify
>> 
>> -
>> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
>> For additional commands, e-mail: log4j-dev-h...@logging.apache.org
>> 
> 
> 
> 
> -- 
> Matt Sicker 

Re: logging-log4j2 git commit: Normalize use of markdown headers

[Matt Sicker]

I see in the file:

Apache Log4j ${Log4jReleaseVersion} is signed by ${Log4jReleaseManager}
(${Log4jReleaseKey})

Email might've been buggy.

On 29 January 2017 at 17:20, Remko Popma  wrote:

> Dangling curly in download.md?
>
> Apache Log4j ${Log4jReleaseVersion} is signed by ${Log4jReleaseManager}
> (${Log4j
> Alternatively, you can verify
>
> Sent from my iPhone
>
> > On Jan 30, 2017, at 2:44, mattsic...@apache.org wrote:
> >
> > Apache Log4j ${Log4jReleaseVersion} is signed by ${Log4jReleaseManager}
> (${Log4j
> > Alternatively, you can verify
>
> -
> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
> For additional commands, e-mail: log4j-dev-h...@logging.apache.org
>
>


-- 
Matt Sicker 

Re: logging-log4j2 git commit: Normalize use of markdown headers

[Remko Popma]

Dangling curly in download.md?

Apache Log4j ${Log4jReleaseVersion} is signed by ${Log4jReleaseManager} (${Log4j
Alternatively, you can verify

Sent from my iPhone

> On Jan 30, 2017, at 2:44, mattsic...@apache.org wrote:
> 
> Apache Log4j ${Log4jReleaseVersion} is signed by ${Log4jReleaseManager} 
> (${Log4j
> Alternatively, you can verify

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Build failed in Jenkins: Log4j 2.x #2639

[Apache Jenkins Server]

See 

Changes:

[Matt Sicker] Add fake site distribution to make maven-site-plugin happy

[Matt Sicker] [LOG4J2-1802]: Migrate component sites to markdown

--
[...truncated 327 lines...]
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[56,78]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[64,78]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[72,78]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[80,78]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[88,78]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[96,78]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[104,78]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[112,78]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[117,61]
 non-varargs call of varargs method with inexact argument type for last 
parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] 
:[797,14]
 [deprecation] MessageSupplier in org.apache.logging.log4j.util has been 
deprecated
[WARNING] 
:[797,45]
 [deprecation] MessageSupplier in org.apache.logging.log4j.util has been 
deprecated
[WARNING] 
:[825,14]
 [deprecation] MessageSupplier in org.apache.logging.log4j.util has been 
deprecated
[WARNING] 
:[825,45]
 [deprecation] MessageSupplier in org.apache.logging.log4j.util has been 
deprecated
[WARNING] 
:[46,50]
 [deprecation] MessageSupplier in org.apache.logging.log4j.util has been 
deprecated
[WARNING] 
:[63,46]
 [deprecation] MessageSupplier in org.apache.logging.log4j.util has been 
deprecated
[WARNING] 

[jira] (LOG4J2-1802) Convert documentation into Markdown

[ASF subversion and git services (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 ASF subversion and git services commented on  LOG4J2-1802 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Convert documentation into Markdown  
 
 
 
 
 
 
 
 
 
 
Commit 2f0c6064a337fb7e9a6001f6a8648400a51fea25 in logging-log4j2's branch refs/heads/master from Matt Sicker [ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=2f0c606 ] 
LOG4J2-1802: Migrate component sites to markdown 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   

Jenkins build is back to normal : Log4j 2.x #2638

[Apache Jenkins Server]

See 


-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Build failed in Jenkins: Log4j 2.x #2637

[Apache Jenkins Server]

See 

Changes:

[Matt Sicker] Refactor dependency output into macros

[Matt Sicker] Add maven/gradle/sbt instructions for using snapshots repository

--
[...truncated 9875 lines...]

Tests run: 59, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] --- maven-jar-plugin:3.0.0:jar (default-jar) @ log4j-api-scala_2.11 ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
log4j-api-scala_2.11 ---
[INFO] 
[INFO] --- maven-failsafe-plugin:2.19.1:integration-test (integration-tests) @ 
log4j-api-scala_2.11 ---
[JENKINS] Recording test results
[INFO] 
[INFO] --- maven-failsafe-plugin:2.19.1:verify (verify) @ log4j-api-scala_2.11 
---
[JENKINS] Recording test results
[INFO] 
[INFO] --- maven-source-plugin:3.0.1:jar-no-fork (attach-sources) @ 
log4j-api-scala_2.11 ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
log4j-api-scala_2.11 ---
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/logging/log4j/log4j-api-scala_2.11/2.8.1-SNAPSHOT/log4j-api-scala_2.11-2.8.1-SNAPSHOT.jar
[INFO] Installing 
 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/logging/log4j/log4j-api-scala_2.11/2.8.1-SNAPSHOT/log4j-api-scala_2.11-2.8.1-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/logging/log4j/log4j-api-scala_2.11/2.8.1-SNAPSHOT/log4j-api-scala_2.11-2.8.1-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- maven-resources-plugin:3.0.1:copy-resources (copy-sitecss) @ 
log4j-api-scala_2.11 ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 154 resources
[INFO] 
[INFO] --- maven-site-plugin:3.4:site (default-site) @ log4j-api-scala_2.11 ---
[INFO] configuring report plugin 
org.apache.maven.plugins:maven-changes-plugin:2.12.1
[WARNING] changes-report report is declared twice in default reportSet
[INFO] configuring report plugin 
org.apache.maven.plugins:maven-project-info-reports-plugin:2.8.1
[INFO] configuring report plugin 
org.apache.maven.plugins:maven-surefire-report-plugin:2.19.1
[INFO] configuring report plugin org.apache.rat:apache-rat-plugin:0.12
[INFO] configuring report plugin org.apache.maven.plugins:maven-pmd-plugin:3.7
[INFO] configuring report plugin net.alchim31.maven:scala-maven-plugin:3.2.2
[INFO] preparing 'doc-jar' report requires 'generate-sources' forked phase 
execution
[INFO] 
[INFO] >>> scala-maven-plugin:3.2.2:doc-jar > generate-sources @ 
log4j-api-scala_2.11 >>>
[INFO] 
[INFO] <<< scala-maven-plugin:3.2.2:doc-jar < generate-sources @ 
log4j-api-scala_2.11 <<<
[INFO] preparing 'doc' report requires 'generate-sources' forked phase execution
[INFO] 
[INFO] >>> scala-maven-plugin:3.2.2:doc > generate-sources @ 
log4j-api-scala_2.11 >>>
[INFO] 
[INFO] <<< scala-maven-plugin:3.2.2:doc < generate-sources @ 
log4j-api-scala_2.11 <<<
[WARNING] Unable to locate Source XRef to link to - DISABLED
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] Parent project loaded from repository: 
org.apache.logging:logging-parent:pom:1
[INFO] Parent project loaded from repository: org.apache:apache:pom:18
[INFO] Relativizing decoration links with respect to project URL: 
https://logging.apache.org/log4j/2.x/log4j-api-scala_2.11/
[INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.0 
skin.
[INFO] Skipped "ScalaDocs" report (scala-maven-plugin:3.2.2:doc), file 
"scaladocs/index.html" already exists for the English version.
[INFO] Generating "JIRA Report" report  --- 
maven-changes-plugin:2.12.1:jira-report
[INFO] Generating "About" report--- 
maven-project-info-reports-plugin:2.8.1:index
[INFO] Generating "Dependencies" report --- 
maven-project-info-reports-plugin:2.8.1:dependencies
[INFO] Generating "Dependency Information" report --- 
maven-project-info-reports-plugin:2.8.1:dependency-info
[INFO] Generating "Dependency Convergence" report --- 
maven-project-info-reports-plugin:2.8.1:dependency-convergence
[INFO] Generating "Dependency Management" report --- 
maven-project-info-reports-plugin:2.8.1:dependency-management
[INFO] Generating "Project Team" report --- 
maven-project-info-reports-plugin:2.8.1:project-team
[INFO] Generating "Mailing Lists" report--- 

Jenkins build is back to stable : Log4j 2.x #2636

[Apache Jenkins Server]

See 


-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Jenkins build is still unstable: Log4j 2.x #2635

[Apache Jenkins Server]

See 


-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] (LOG4J2-1802) Convert documentation into Markdown

[Matt Sicker (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Matt Sicker created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Log4j 2 /  LOG4J2-1802 
 
 
 
  Convert documentation into Markdown  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Documentation 
 
 
 

Assignee:
 
 Matt Sicker 
 
 
 

Components:
 

 Documentation 
 
 
 

Created:
 

 29/Jan/17 18:09 
 
 
 

Priority:
 
  Major 
 
 
 

Reporter:
 
 Matt Sicker 
 
 
 
 
 
 
 
 
 
 
The xdoc system currently in place is difficult to use correctly (it expects proper XHTML, no block level elements inside inline level elements, the usual pedantry from an XHTML/XML validator) and is needlessly verbose for writing documentation. 
The plugin we already use (maven-site-plugin) supports Markdown as an alternative (amongst others). Most text can be formatted as plain Markdown which simplifies the format a bit, plus anything complex can still be written in regular HTML (e.g., special tables). This will also allow for the documentation to be viewable on GitHub (at least for non-templated files) as seen in this example page. 
I suggest using Markdown instead of something like Asciidoc as it's simpler to convert from xdoc and because I'm far more experienced with the syntax. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add 

Re: logging-log4j-scala git commit: Update README to be similar to logging-log4j2

[Matt Sicker]

I fixed that typo in the commons-build-plugin template as well. Looks like
all the Commons projects have that exact typo!

On 29 January 2017 at 10:52, Matt Sicker  wrote:

> Thanks! That's what I get for copying things from Commons instead of
> writing them myself! :P
>
> On 28 January 2017 at 18:25, Remko Popma  wrote:
>
>> Spelling nag:
>> discuss you're changes -> your
>> (Contributing.md)
>>
>>
>> (Away from pc) Remko
>>
>> Sent from my iPhone
>>
>> > On Jan 29, 2017, at 4:13, mattsic...@apache.org wrote:
>> >
>> > discuss you're changes
>>
>> -
>> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
>> For additional commands, e-mail: log4j-dev-h...@logging.apache.org
>>
>>
>
>
> --
> Matt Sicker 
>



-- 
Matt Sicker 

[jira] (LOG4J2-1431) Simplify log4j system property naming scheme

[Matt Sicker (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Matt Sicker commented on  LOG4J2-1431 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Simplify log4j system property naming scheme  
 
 
 
 
 
 
 
 
 
 
Bringing this topic back up before I plan any code changes, I'd like to elaborate on the idea. Right now, configuration done via the normal config file system is rather well supported in the documentation. One of the key improvements in Log4j 2's configuration format was getting rid of the need to specify internal class names to configure plugins. This feature request follows a similar philosophy in simplifying the global Log4j 2 settings that are normally specified as system properties or through a log4j2.component.properties file on the classpath. System property settings are documented all over the manual where appropriate, but the general system of how to use them other than as command line flags is not very well explained. 
What I'd like to propose here, besides simplifying the base naming scheme and supporting them all (along with updating the documentation to normalize on the prefix log4j2. as discussed above), would be supporting a general property name format like such. All the following property names would be equivalent: 
 

log4j.configurationFile
 

log4j2.configurationFile
 

Log4jConfigurationFile
 

org.apache.logging.log4j.configurationFile
 

LOG4J_CONFIGURATIONFILE
 

LOG4J_CONFIGURATION_FILE 
 

Log4j-configurationFile
 

Log4j-ConfigurationFile 
 

log4j.configuration.file 
 
 
The idea here being that dots, dashes, and underscores should all be equivalent (underscores being supported for allowing environment variables to be used instead of system properties in a 12factor system, and dashes being added possibly to allow for alternate styles to be used, but I have no personal request for that other than completeness); properties could either be case-insensitive or we could support a system where CamelCaseWords are treated the same as camel.case.words or CAMEL_CASE_WORDS (so, somewhat case insensitive, but after parsing into words); and this would in general provide the possibility to inject configuration in a cloud environment through any arbitrary configuration system (although supporting environment variables in addition to system properties would handle the majority of cases; it's not like global settings from PropertiesUtil are reconfigurable at runtime, so supporting hot-reload via some configuration management 

Re: FileAppenderBenchmark

[Matt Sicker]

That maven-compiler-plugin config was originally only included in
log4j-core in order to allow the PluginProcessor annotation processor to
re-run against log4j-core without needing to split it into its own jar. I'm
not sure why it's configured for everything now.

On 29 January 2017 at 08:59, Ralph Goers  wrote:

> Yes.
>
> Ralph
>
> On Jan 28, 2017, at 11:59 PM, Remko Popma  wrote:
>
> Ralph, are your benchmark results with 4 threads (-t 4)?
>
> On Sun, Jan 29, 2017 at 5:51 PM, Apache 
> wrote:
>
>> While I couldn’t get it to work with Log4j 2.8 the results I get for 2.7
>> do not match Ceki’s at all.  These are the results for Java 7:
>>
>> Benchmark   Mode
>>  SamplesScoreError  Units
>> o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt   10
>> 105746.361 ±   2995.187  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File   thrpt   10
>> 811996.955 ±  18110.525  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File   thrpt   10
>> 1986884.744 ±  42949.953  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   10
>> 4020251.137 ± 176621.025  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   10
>>  228331.672 ±   2420.898  ops/s
>>
>> Here are the numbers for Java 8:
>>
>> Benchmark   Mode
>>  SamplesScoreError  Units
>> o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt   10
>> 105836.910 ±   9430.973  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File   thrpt   10
>> 816316.422 ±  12492.398  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File   thrpt   10
>>  2042991.944 ±  15957.247  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   10
>> 4006968.171 ± 285275.918  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   10
>>  231574.725 ±   2266.484  ops/s
>>
>>
>> To correlate to microseconds as Ceki is doing, I get 105 for jul, 816 for
>> log4j 1, 2042 for Log4j 2, 4007 for Log4j 2 RAF, and 232 for Logback. I
>> think he must have somehow lost a digit for log4j as that would correlate
>> with the numbers he reported.
>>
>> My machine has 4 cores (8 hyper threads) and is using an SSD.
>>
>> Ralph
>>
>> On Jan 29, 2017, at 12:39 AM, Apache  wrote:
>>
>> I can no longer get the benchmarks to work. I get
>>
>> java.lang.IllegalArgumentException: Benchmark does not match a class
>> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:90)
>> at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:198)
>> at org.openjdk.jmh.runner.BaseRunner.runBenchmarks(BaseRunner.java:95)
>> at org.openjdk.jmh.runner.ForkedRunner.run(ForkedRunner.java:51)
>> at org.openjdk.jmh.runner.ForkedMain.main(ForkedMain.java:68)
>> Caused by: java.lang.ClassNotFoundException:
>> org.apache.logging.log4j.perf.jmh.generated.FileAppenderBenchmark_julFile
>> at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
>> at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
>> at java.security.AccessController.doPrivileged(Native Method)
>> at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
>> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
>> at java.lang.Class.forName0(Native Method)
>> at java.lang.Class.forName(Class.java:195)
>> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:72)
>> ... 4 more
>>
>> On Jan 28, 2017, at 6:13 PM, Remko Popma  wrote:
>>
>>
>> On Jan 29, 2017, at 9:38, Remko Popma  wrote:
>>
>> I want to ask a favor: can anyone run the FileAppenderBenchmark
>> benchmark
>> (with -f 1 -wi 10 -i 10 -t 4) and post the summary? Someone is reporting
>> a performance regression.
>>
>> This is the regression report:
>> https://mobile.twitter.com/ceki/status/825368324146155520
>>
>> https://mobile.twitter.com/ceki/status/825370795157368832
>>
>>
>> I get a strange error when trying to run JMH benchmarks and wonder if it
>> is just me.
>>
>> Remko
>>
>> Sent from my iPhone
>>
>>
>>
>>
>


-- 
Matt Sicker 

Re: logging-log4j-scala git commit: Add intro to README

[Matt Sicker]

I noticed that right after I pushed it. Fixed in subsequent commit, thanks.

On 28 January 2017 at 18:47, Remko Popma  wrote:

> Spelling nag:
> introduced as in Log4j 2.8.1 -> introduced in
>
> Sent from my iPhone
>
> > On Jan 29, 2017, at 4:27, mattsic...@apache.org wrote:
> >
> > introduced
> > +as in Log4j 2.8.1
>
> -
> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
> For additional commands, e-mail: log4j-dev-h...@logging.apache.org
>
>


-- 
Matt Sicker 

Re: logging-log4j-scala git commit: Update README to be similar to logging-log4j2

[Matt Sicker]

Thanks! That's what I get for copying things from Commons instead of
writing them myself! :P

On 28 January 2017 at 18:25, Remko Popma  wrote:

> Spelling nag:
> discuss you're changes -> your
> (Contributing.md)
>
>
> (Away from pc) Remko
>
> Sent from my iPhone
>
> > On Jan 29, 2017, at 4:13, mattsic...@apache.org wrote:
> >
> > discuss you're changes
>
> -
> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
> For additional commands, e-mail: log4j-dev-h...@logging.apache.org
>
>


-- 
Matt Sicker 

[jira] (LOG4J2-1561) print expected mdc info to each line of the exception stacktrace

[ASF GitHub Bot (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 ASF GitHub Bot commented on  LOG4J2-1561 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: print expected mdc info to each line of the exception stacktrace  
 
 
 
 
 
 
 
 
 
 
Github user mikaelstaldal commented on the issue: 
 https://github.com/apache/logging-log4j2/pull/38 
 This has not been implemented yet. You can follow the progress in the JIRA ticket: https://issues.apache.org/jira/browse/LOG4J2-1561 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   

Re: FileAppenderBenchmark

[Ralph Goers]

Yes.

Ralph

> On Jan 28, 2017, at 11:59 PM, Remko Popma  wrote:
> 
> Ralph, are your benchmark results with 4 threads (-t 4)?
> 
>> On Sun, Jan 29, 2017 at 5:51 PM, Apache  wrote:
>> While I couldn’t get it to work with Log4j 2.8 the results I get for 2.7 do 
>> not match Ceki’s at all.  These are the results for Java 7:
>> 
>> Benchmark   Mode  
>> SamplesScoreError  Units
>> o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt   10 
>> 105746.361 ±   2995.187  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File   thrpt   10 
>> 811996.955 ±  18110.525  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File   thrpt   10   
>> 1986884.744 ±  42949.953  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   10   
>> 4020251.137 ± 176621.025  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   10  
>> 228331.672 ±   2420.898  ops/s
>> 
>> Here are the numbers for Java 8:
>> 
>> Benchmark   Mode  
>> SamplesScoreError  Units
>> o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt   10 
>> 105836.910 ±   9430.973  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File   thrpt   10 
>> 816316.422 ±  12492.398  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File   thrpt   10
>> 2042991.944 ±  15957.247  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   10   
>> 4006968.171 ± 285275.918  ops/s
>> o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   10  
>> 231574.725 ±   2266.484  ops/s
>> 
>> 
>> To correlate to microseconds as Ceki is doing, I get 105 for jul, 816 for 
>> log4j 1, 2042 for Log4j 2, 4007 for Log4j 2 RAF, and 232 for Logback. I 
>> think he must have somehow lost a digit for log4j as that would correlate 
>> with the numbers he reported.
>> 
>> My machine has 4 cores (8 hyper threads) and is using an SSD.
>> 
>> Ralph
>> 
>>> On Jan 29, 2017, at 12:39 AM, Apache  wrote:
>>> 
>>> I can no longer get the benchmarks to work. I get
>>> 
>>> java.lang.IllegalArgumentException: Benchmark does not match a class
>>> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:90)
>>> at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:198)
>>> at org.openjdk.jmh.runner.BaseRunner.runBenchmarks(BaseRunner.java:95)
>>> at org.openjdk.jmh.runner.ForkedRunner.run(ForkedRunner.java:51)
>>> at org.openjdk.jmh.runner.ForkedMain.main(ForkedMain.java:68)
>>> Caused by: java.lang.ClassNotFoundException: 
>>> org.apache.logging.log4j.perf.jmh.generated.FileAppenderBenchmark_julFile
>>> at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
>>> at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
>>> at java.security.AccessController.doPrivileged(Native Method)
>>> at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
>>> at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
>>> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
>>> at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
>>> at java.lang.Class.forName0(Native Method)
>>> at java.lang.Class.forName(Class.java:195)
>>> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:72)
>>> ... 4 more
>>> 
 On Jan 28, 2017, at 6:13 PM, Remko Popma  wrote:
 
 
 On Jan 29, 2017, at 9:38, Remko Popma  wrote:
 
> I want to ask a favor: can anyone run the FileAppenderBenchmark benchmark 
> (with -f 1 -wi 10 -i 10 -t 4) and post the summary? Someone is reporting 
> a performance regression. 
 This is the regression report:
 https://mobile.twitter.com/ceki/status/825368324146155520
 
 https://mobile.twitter.com/ceki/status/825370795157368832
> 
> I get a strange error when trying to run JMH benchmarks and wonder if it 
> is just me. 
> 
> Remko 
> 
> Sent from my iPhone
>>> 
>> 
> 

Re: FileAppenderBenchmark

[Remko Popma]

The cause seems to be a change in the master pom:
the maven-compiler-plugin plugin now has the below section which was not
there in 2.7.
If I take it out and build only log4j-perf, the benchmarks run without
error. (But building all modules fails: some problem in log4j-core...)

  

  
  default-compile
  
compile
  
  compile
  
none
  


  
  process-plugins
  
compile
  
  process-classes
  
only
  

  



On Sun, Jan 29, 2017 at 6:57 PM, Remko Popma  wrote:

> That error is exactly what I am seeing.
> For some reason the class files under 
> log4j-perf\target\generated-sources\annotations
> (generated by JMH) are not included in the shaded benchmarks.jar or in
> log4j-perf-2.8.1-SNAPSHOT.jar...
>
> Thanks for mentioning that it works with 2.7. That means it is likely one
> of the changes to either the main pom or the log4j-perf pom since 2.7.
>
> On Sun, Jan 29, 2017 at 4:39 PM, Apache 
> wrote:
>
>> I can no longer get the benchmarks to work. I get
>>
>> java.lang.IllegalArgumentException: Benchmark does not match a class
>> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:90)
>> at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:198)
>> at org.openjdk.jmh.runner.BaseRunner.runBenchmarks(BaseRunner.java:95)
>> at org.openjdk.jmh.runner.ForkedRunner.run(ForkedRunner.java:51)
>> at org.openjdk.jmh.runner.ForkedMain.main(ForkedMain.java:68)
>> Caused by: java.lang.ClassNotFoundException:
>> org.apache.logging.log4j.perf.jmh.generated.FileAppenderBenchmark_julFile
>> at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
>> at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
>> at java.security.AccessController.doPrivileged(Native Method)
>> at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
>> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
>> at java.lang.Class.forName0(Native Method)
>> at java.lang.Class.forName(Class.java:195)
>> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:72)
>> ... 4 more
>>
>> On Jan 28, 2017, at 6:13 PM, Remko Popma  wrote:
>>
>>
>> On Jan 29, 2017, at 9:38, Remko Popma  wrote:
>>
>> I want to ask a favor: can anyone run the FileAppenderBenchmark
>> benchmark
>> (with -f 1 -wi 10 -i 10 -t 4) and post the summary? Someone is reporting
>> a performance regression.
>>
>> This is the regression report:
>> https://mobile.twitter.com/ceki/status/825368324146155520
>>
>> https://mobile.twitter.com/ceki/status/825370795157368832
>>
>>
>> I get a strange error when trying to run JMH benchmarks and wonder if it
>> is just me.
>>
>> Remko
>>
>> Sent from my iPhone
>>
>>
>>
>

[jira] (LOG4J2-1561) print expected mdc info to each line of the exception stacktrace

[ASF GitHub Bot (JIRA)]

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 ASF GitHub Bot commented on  LOG4J2-1561 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: print expected mdc info to each line of the exception stacktrace  
 
 
 
 
 
 
 
 
 
 
Github user tapman commented on the issue: 
 https://github.com/apache/logging-log4j2/pull/38 
 Hiya 
 Could you tell me if this is implemented yet, please? I'm processing the stacktrace to add a log ID to each line but this is way better 
 Thanks, Tony 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   

Re: FileAppenderBenchmark

[Remko Popma]

Ralph, are your benchmark results with 4 threads (-t 4)?

On Sun, Jan 29, 2017 at 5:51 PM, Apache  wrote:

> While I couldn’t get it to work with Log4j 2.8 the results I get for 2.7
> do not match Ceki’s at all.  These are the results for Java 7:
>
> Benchmark   Mode
>  SamplesScoreError  Units
> o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt   10
> 105746.361 ±   2995.187  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File   thrpt   10
> 811996.955 ±  18110.525  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File   thrpt   10
> 1986884.744 ±  42949.953  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   10
> 4020251.137 ± 176621.025  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   10
>  228331.672 ±   2420.898  ops/s
>
> Here are the numbers for Java 8:
>
> Benchmark   Mode
>  SamplesScoreError  Units
> o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt   10
> 105836.910 ±   9430.973  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File   thrpt   10
> 816316.422 ±  12492.398  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File   thrpt   10
>  2042991.944 ±  15957.247  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   10
> 4006968.171 ± 285275.918  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   10
>  231574.725 ±   2266.484  ops/s
>
>
> To correlate to microseconds as Ceki is doing, I get 105 for jul, 816 for
> log4j 1, 2042 for Log4j 2, 4007 for Log4j 2 RAF, and 232 for Logback. I
> think he must have somehow lost a digit for log4j as that would correlate
> with the numbers he reported.
>
> My machine has 4 cores (8 hyper threads) and is using an SSD.
>
> Ralph
>
> On Jan 29, 2017, at 12:39 AM, Apache  wrote:
>
> I can no longer get the benchmarks to work. I get
>
> java.lang.IllegalArgumentException: Benchmark does not match a class
> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:90)
> at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:198)
> at org.openjdk.jmh.runner.BaseRunner.runBenchmarks(BaseRunner.java:95)
> at org.openjdk.jmh.runner.ForkedRunner.run(ForkedRunner.java:51)
> at org.openjdk.jmh.runner.ForkedMain.main(ForkedMain.java:68)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.logging.log4j.perf.jmh.generated.FileAppenderBenchmark_julFile
> at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:195)
> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:72)
> ... 4 more
>
> On Jan 28, 2017, at 6:13 PM, Remko Popma  wrote:
>
>
> On Jan 29, 2017, at 9:38, Remko Popma  wrote:
>
> I want to ask a favor: can anyone run the FileAppenderBenchmark benchmark
> (with -f 1 -wi 10 -i 10 -t 4) and post the summary? Someone is reporting
> a performance regression.
>
> This is the regression report:
> https://mobile.twitter.com/ceki/status/825368324146155520
>
> https://mobile.twitter.com/ceki/status/825370795157368832
>
>
> I get a strange error when trying to run JMH benchmarks and wonder if it
> is just me.
>
> Remko
>
> Sent from my iPhone
>
>
>
>

Re: FileAppenderBenchmark

[Remko Popma]

That error is exactly what I am seeing.
For some reason the class files under
log4j-perf\target\generated-sources\annotations
(generated by JMH) are not included in the shaded benchmarks.jar or in
log4j-perf-2.8.1-SNAPSHOT.jar...

Thanks for mentioning that it works with 2.7. That means it is likely one
of the changes to either the main pom or the log4j-perf pom since 2.7.

On Sun, Jan 29, 2017 at 4:39 PM, Apache  wrote:

> I can no longer get the benchmarks to work. I get
>
> java.lang.IllegalArgumentException: Benchmark does not match a class
> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:90)
> at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:198)
> at org.openjdk.jmh.runner.BaseRunner.runBenchmarks(BaseRunner.java:95)
> at org.openjdk.jmh.runner.ForkedRunner.run(ForkedRunner.java:51)
> at org.openjdk.jmh.runner.ForkedMain.main(ForkedMain.java:68)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.logging.log4j.perf.jmh.generated.FileAppenderBenchmark_julFile
> at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:195)
> at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:72)
> ... 4 more
>
> On Jan 28, 2017, at 6:13 PM, Remko Popma  wrote:
>
>
> On Jan 29, 2017, at 9:38, Remko Popma  wrote:
>
> I want to ask a favor: can anyone run the FileAppenderBenchmark benchmark
> (with -f 1 -wi 10 -i 10 -t 4) and post the summary? Someone is reporting
> a performance regression.
>
> This is the regression report:
> https://mobile.twitter.com/ceki/status/825368324146155520
>
> https://mobile.twitter.com/ceki/status/825370795157368832
>
>
> I get a strange error when trying to run JMH benchmarks and wonder if it
> is just me.
>
> Remko
>
> Sent from my iPhone
>
>
>

Re: FileAppenderBenchmark

[Apache]

While I couldn’t get it to work with Log4j 2.8 the results I get for 2.7 do not 
match Ceki’s at all.  These are the results for Java 7:

Benchmark   Mode  
SamplesScoreError  Units
o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt   10 
105746.361 ±   2995.187  ops/s
o.a.l.l.p.j.FileAppenderBenchmark.log4j1File   thrpt   10 
811996.955 ±  18110.525  ops/s
o.a.l.l.p.j.FileAppenderBenchmark.log4j2File   thrpt   10   1986884.744 
±  42949.953  ops/s
o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   10   4020251.137 ± 
176621.025  ops/s
o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   10  228331.672 
±   2420.898  ops/s

Here are the numbers for Java 8:

Benchmark   Mode  
SamplesScoreError  Units
o.a.l.l.p.j.FileAppenderBenchmark.julFile thrpt   10 
105836.910 ±   9430.973  ops/s
o.a.l.l.p.j.FileAppenderBenchmark.log4j1File   thrpt   10 
816316.422 ±  12492.398  ops/s
o.a.l.l.p.j.FileAppenderBenchmark.log4j2File   thrpt   10
2042991.944 ±  15957.247  ops/s
o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   10   4006968.171 ± 
285275.918  ops/s
o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   10  231574.725 
±   2266.484  ops/s


To correlate to microseconds as Ceki is doing, I get 105 for jul, 816 for log4j 
1, 2042 for Log4j 2, 4007 for Log4j 2 RAF, and 232 for Logback. I think he must 
have somehow lost a digit for log4j as that would correlate with the numbers he 
reported.

My machine has 4 cores (8 hyper threads) and is using an SSD.

Ralph

> On Jan 29, 2017, at 12:39 AM, Apache  wrote:
> 
> I can no longer get the benchmarks to work. I get
> 
> java.lang.IllegalArgumentException: Benchmark does not match a class
>   at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:90)
>   at org.openjdk.jmh.runner.BaseRunner.runBenchmark(BaseRunner.java:198)
>   at org.openjdk.jmh.runner.BaseRunner.runBenchmarks(BaseRunner.java:95)
>   at org.openjdk.jmh.runner.ForkedRunner.run(ForkedRunner.java:51)
>   at org.openjdk.jmh.runner.ForkedMain.main(ForkedMain.java:68)
> Caused by: java.lang.ClassNotFoundException: 
> org.apache.logging.log4j.perf.jmh.generated.FileAppenderBenchmark_julFile
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
>   at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
>   at java.security.AccessController.doPrivileged(Native Method)
>   at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
>   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:195)
>   at org.openjdk.jmh.util.ClassUtils.loadClass(ClassUtils.java:72)
>   ... 4 more
> 
>> On Jan 28, 2017, at 6:13 PM, Remko Popma > > wrote:
>> 
>> 
>> On Jan 29, 2017, at 9:38, Remko Popma > > wrote:
>> 
>>> I want to ask a favor: can anyone run the FileAppenderBenchmark benchmark 
>>> (with -f 1 -wi 10 -i 10 -t 4) and post the summary? Someone is reporting a 
>>> performance regression. 
>> This is the regression report:
>> https://mobile.twitter.com/ceki/status/825368324146155520 
>> 
>> 
>> https://mobile.twitter.com/ceki/status/825370795157368832 
>> 
>>> I get a strange error when trying to run JMH benchmarks and wonder if it is 
>>> just me. 
>>> 
>>> Remko 
>>> 
>>> Sent from my iPhone
>