Re: org.apache.logging.log4j.core.config.Configurator.initialize(String, String)

2017-04-11 Thread Gary Gregory
The problem with the API as it is now is that I have no idea if the API did
what I asked it to do. It does initialize log4j all right but not in a way
I expect.

I see that we could:

1) make the current API throw an IllegalArgumentException that means "file
not found", this keeps the API signature the same.
2) make the current API return null (but should it still initialize log4j
with the 'next' config file it finds?). Not great as this would likely
break some apps.
3) add a new API that throws an exception that means 'config file not found'
4) add a new API that returns null

The nice thing about throwing an exception is that you can give a detailed
error message. Returning null tells you something is wrong, not what, still
a mystery.

So I prefer 3).

Regardless, we need some better Javadocs on the existing APIs... the
behavior is just too surprising IMO.

Thoughts?

Gary



On Tue, Apr 11, 2017 at 10:01 PM, Ralph Goers <ralph.go...@dslextreme.com>
wrote:

> That’s a good point. It is a programmatic interface so it should return an
> error. But generally we want logging to do something reasonable other than
> fail, so it should either use whatever configuration it finds or use the
> default.
>
> Ralph
>
> On Apr 11, 2017, at 8:42 PM, Remko Popma <remko.po...@gmail.com> wrote:
>
> I thought Gary needed a way to detect that the specified location didn't
> work. But perhaps a warning message is sufficient.
>
> Sent from my iPhone
>
> On Apr 12, 2017, at 10:05, Ralph Goers <ralph.go...@dslextreme.com> wrote:
>
> I'd prefer an error message but then have it continue with the current
> behavior.
>
> Sent from my iPhone
>
> On Apr 11, 2017, at 5:47 PM, Remko Popma <remko.po...@gmail.com> wrote:
>
> I can see both sides of the argument.
>
> Rather than changing the semantics of the existing method, what about
> adding a method `Configurator.initializeStrict(String, String)` which
> fails if the specified file doesn't exist? Not sure what the best way to
> fail is: return null or throw exception...
>
> Sent from my iPhone
>
> On Apr 12, 2017, at 9:13, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Hi All:
>
> Using 2.8.2, I call 
> org.apache.logging.log4j.core.config.Configurator.initialize(String,
> String) with a non-exiting file location.
>
> The method does not return null because it found another log4j2.xml file
> on my classpath. So I get a LoggerContext but not what I expect...
>
> That does not sound right to me, it should return null, and then I can
> look in the status logger to see what went wrong (if I happen to have it
> set to DEBUG in the log4j2.xml file it did find.)
>
> Thoughts?
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


org.apache.logging.log4j.core.config.Configurator.initialize(String, String)

2017-04-11 Thread Gary Gregory
Hi All:

Using 2.8.2, I
call org.apache.logging.log4j.core.config.Configurator.initialize(String,
String) with a non-exiting file location.

The method does not return null because it found another log4j2.xml file on
my classpath. So I get a LoggerContext but not what I expect...

That does not sound right to me, it should return null, and then I can look
in the status logger to see what went wrong (if I happen to have it set to
DEBUG in the log4j2.xml file it did find.)

Thoughts?

Gary

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[jira] [Updated] (LOG4J2-1879) Update JAnsi from 1.14 to 1.15

2017-04-11 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1879:
-
Summary: Update JAnsi from 1.14 to 1.15  (was: Update Jansi from 1.14 to 
1.15)

> Update JAnsi from 1.14 to 1.15
> --
>
> Key: LOG4J2-1879
> URL: https://issues.apache.org/jira/browse/LOG4J2-1879
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8.2
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.9
>
>
> Update Jansi from 1.14 to 1.15



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1879) Update JAnsi from 1.14 to 1.15

2017-04-11 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1879:
-
Description: Update JAnsi from 1.14 to 1.15  (was: Update Jansi from 1.14 
to 1.15)

> Update JAnsi from 1.14 to 1.15
> --
>
> Key: LOG4J2-1879
> URL: https://issues.apache.org/jira/browse/LOG4J2-1879
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8.2
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.9
>
>
> Update JAnsi from 1.14 to 1.15



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Closed] (LOG4J2-1879) Update JAnsi from 1.14 to 1.15

2017-04-11 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1879.

   Resolution: Fixed
Fix Version/s: 2.9

In Git master.

> Update JAnsi from 1.14 to 1.15
> --
>
> Key: LOG4J2-1879
> URL: https://issues.apache.org/jira/browse/LOG4J2-1879
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8.2
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.9
>
>
> Update JAnsi from 1.14 to 1.15



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Created] (LOG4J2-1879) Update Jansi from 1.14 to 1.15

2017-04-11 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1879:


 Summary: Update Jansi from 1.14 to 1.15
 Key: LOG4J2-1879
 URL: https://issues.apache.org/jira/browse/LOG4J2-1879
 Project: Log4j 2
  Issue Type: Improvement
  Components: Appenders
Affects Versions: 2.8.2
Reporter: Gary Gregory
Assignee: Gary Gregory


Update Jansi from 1.14 to 1.15



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Wiki still mainly features 1.2

2017-04-11 Thread Gary Gregory
Hi All,

This site could use a dust up: https://wiki.apache.org/logging-log4j

Gary

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: [14/14] logging-log4j2 git commit: Update BOM

2017-04-10 Thread Gary Gregory
Is this where a Chainsaw refresh would live?

Gary

On Apr 10, 2017 9:01 AM, "Ralph Goers"  wrote:

> I’m fine with that. I just don’t want more modules in the main project.
>
> Ralph
>
> On Apr 10, 2017, at 8:56 AM, Mikael Ståldal 
> wrote:
>
> The whole point of this is to get the server components out of log4j-core,
> so we need to create a new module. Maybe this new module can be moved to
> log4j2-tools repo.
>
> On Mon, Apr 10, 2017 at 5:48 PM, Ralph Goers 
> wrote:
>
>> I created a new git repo for log4j2-tools.  We should not create any more
>> modules if we can avoid it.
>>
>> Ralph
>>
>> On Apr 10, 2017, at 7:28 AM, Remko Popma  wrote:
>>
>> I guess this is a matter of preference but we already have a lot of
>> modules.
>> Having one for all standalone applications makes it easier for our users
>> to find things.
>>
>> On Mon, Apr 10, 2017 at 11:24 PM, Mikael Ståldal <
>> mikael.stal...@magine.com> wrote:
>>
>>> Wouldn't it be better to have one for server and another for the other
>>> tools?
>>>
>>> On Mon, Apr 10, 2017 at 4:23 PM, Remko Popma 
>>> wrote:
>>>
 I thought we were going to name this module log4j-tools instead of
 log4j-server, so it can host all our standalone apps?

 On Mon, Apr 10, 2017 at 11:11 PM,  wrote:

> Update BOM
>
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit
> /fea17ad6
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/f
> ea17ad6
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/f
> ea17ad6
>
> Branch: refs/heads/master
> Commit: fea17ad6bdc47825ec5b58b9df9e031936182d79
> Parents: 1051081
> Author: Mikael Ståldal 
> Authored: Mon Apr 10 16:11:24 2017 +0200
> Committer: Mikael Ståldal 
> Committed: Mon Apr 10 16:11:24 2017 +0200
>
> --
>  log4j-bom/pom.xml | 6 ++
>  1 file changed, 6 insertions(+)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/f
> ea17ad6/log4j-bom/pom.xml
> --
> diff --git a/log4j-bom/pom.xml b/log4j-bom/pom.xml
> index 920f6a0..382f16e 100644
> --- a/log4j-bom/pom.xml
> +++ b/log4j-bom/pom.xml
> @@ -96,6 +96,12 @@
>  log4j-iostreams
>  ${project.version}
>
> +  
> +  
> +org.apache.logging.log4j
> +log4j-server
> +${project.version}
> +  
>
>
>  org.apache.logging.log4j
>
>

>>>
>>>
>>> --
>>> [image: MagineTV]
>>>
>>> *Mikael Ståldal*
>>> Senior software developer
>>>
>>> *Magine TV*
>>> mikael.stal...@magine.com
>>> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com
>>>
>>> Privileged and/or Confidential Information may be contained in this
>>> message. If you are not the addressee indicated in this message
>>> (or responsible for delivery of the message to such a person), you may
>>> not copy or deliver this message to anyone. In such case,
>>> you should destroy this message and kindly notify the sender by reply
>>> email.
>>>
>>
>>
>>
>
>
> --
> [image: MagineTV]
>
> *Mikael Ståldal*
> Senior software developer
>
> *Magine TV*
> mikael.stal...@magine.com
> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com
>
> Privileged and/or Confidential Information may be contained in this
> message. If you are not the addressee indicated in this message
> (or responsible for delivery of the message to such a person), you may not
> copy or deliver this message to anyone. In such case,
> you should destroy this message and kindly notify the sender by reply
> email.
>
>
>


[jira] [Commented] (LOG4J2-1873) Implement UTF-8 encoding that doesn't use CharsetEncoder

2017-04-10 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963050#comment-15963050
 ] 

Gary Gregory commented on LOG4J2-1873:
--

ICU4J might have something we can optionally depend on or copy.

> Implement UTF-8 encoding that doesn't use CharsetEncoder
> 
>
> Key: LOG4J2-1873
> URL: https://issues.apache.org/jira/browse/LOG4J2-1873
> Project: Log4j 2
>  Issue Type: Improvement
>Reporter: Roman Leventov
>
> CharsetEncoder accepts only CharBuffers, and for the sake of being entirely 
> garbage-free we don't want to use CharBuffer.wrap(stringBuilder), when 
> encoding an event.
> That forces us to make additional data copy from StringBuilder to a 
> thread-local CharBuffer.
> This could be avoided by implementing UTF-8 encoding logic in log4j-core 
> itself, and not using CharsetEncoder.
> This issue is specifically about UTF-8 because it is used predominantly and 
> it's relatively easy to implement. There are also likely some open-source 
> Apache 2-compatible implementations in Java out there already that we could 
> just copy and adapt.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1864) Support capped collection for MongoDB Log-Provider

2017-04-10 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963043#comment-15963043
 ] 

Gary Gregory commented on LOG4J2-1864:
--

The old factory method does not come into play if you remove its annotation, 
which is what I have done in the past when adding a builder.

> Support capped collection for MongoDB Log-Provider
> --
>
> Key: LOG4J2-1864
> URL: https://issues.apache.org/jira/browse/LOG4J2-1864
> Project: Log4j 2
>  Issue Type: New Feature
>  Components: Appenders
>Reporter: Matt
>
> MongoDB supports sth. called capped collections. If the 
> nosql-mongodb-appender supports this feature, the mongodb-collection could 
> never "overflow" and stick to a defined maximum size.
> see [pull request 62|https://github.com/apache/logging-log4j2/pull/62] for 
> more details.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Closed] (LOG4J2-1872) Update JavaMail from 1.5.5 to 1.5.6

2017-04-09 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1872.

   Resolution: Fixed
Fix Version/s: 2.9

In Git master.

> Update JavaMail from 1.5.5 to 1.5.6
> ---
>
> Key: LOG4J2-1872
> URL: https://issues.apache.org/jira/browse/LOG4J2-1872
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders
>Affects Versions: 2.8.2
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.9
>
>
> Update JavaMail from 1.5.5 to 1.5.6.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Closed] (LOG4J2-1869) Update Kafka client from 0.10.1.1 to 0.10.2.0

2017-04-09 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1869.

   Resolution: Fixed
Fix Version/s: 2.9

Marking for 2.9.

> Update Kafka client from 0.10.1.1 to 0.10.2.0
> -
>
> Key: LOG4J2-1869
> URL: https://issues.apache.org/jira/browse/LOG4J2-1869
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8.2
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.9
>
>
> Update Kafka client from 0.10.1.1 to 0.10.2.0



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Reopened] (LOG4J2-1869) Update Kafka client from 0.10.1.1 to 0.10.2.0

2017-04-09 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory reopened LOG4J2-1869:
--

> Update Kafka client from 0.10.1.1 to 0.10.2.0
> -
>
> Key: LOG4J2-1869
> URL: https://issues.apache.org/jira/browse/LOG4J2-1869
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8.2
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.9
>
>
> Update Kafka client from 0.10.1.1 to 0.10.2.0



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Created] (LOG4J2-1872) Update JavaMail from 1.5.5 to 1.5.6

2017-04-09 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1872:


 Summary: Update JavaMail from 1.5.5 to 1.5.6
 Key: LOG4J2-1872
 URL: https://issues.apache.org/jira/browse/LOG4J2-1872
 Project: Log4j 2
  Issue Type: Bug
  Components: Appenders
Affects Versions: 2.8.2
Reporter: Gary Gregory
Assignee: Gary Gregory


Update JavaMail from 1.5.5 to 1.5.6.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Closed] (LOG4J2-1869) Update Kafka client from 0.10.1.1 to 0.10.2.0

2017-04-09 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1869.

Resolution: Fixed
  Assignee: Gary Gregory

In Git master.

> Update Kafka client from 0.10.1.1 to 0.10.2.0
> -
>
> Key: LOG4J2-1869
> URL: https://issues.apache.org/jira/browse/LOG4J2-1869
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8.2
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
>
> Update Kafka client from 0.10.1.1 to 0.10.2.0



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: Jenkins and Maven 3.5.0

2017-04-09 Thread Gary Gregory
I was thinking of just using 3.5.0.

Gary

On Apr 9, 2017 6:48 AM, "Apache"  wrote:

> Why? There is no reason our build process has to support every maven
> release.
>
> Sent from my iPad
>
> On Apr 8, 2017, at 5:44 PM, Matt Sicker  wrote:
>
> Now that Maven 3.5.0 is out, whenever Infra adds it to Jenkins, would it
> make sense to switch to it there? I know in theory everything seems to work
> with any version of Maven 3.x, but I'm also wondering if it's worth setting
> up Jenkins like we did for Windows with multiple versions to catch any
> strange build issues sooner rather than later.
>
> --
> Matt Sicker 
>
>


Re: Jenkins and Maven 3.5.0

2017-04-08 Thread Gary Gregory
Sure, why not? Let's eat our own Apache dog food. Fresh too!

Gary

On Apr 8, 2017 5:44 PM, "Matt Sicker"  wrote:

> Now that Maven 3.5.0 is out, whenever Infra adds it to Jenkins, would it
> make sense to switch to it there? I know in theory everything seems to work
> with any version of Maven 3.x, but I'm also wondering if it's worth setting
> up Jenkins like we did for Windows with multiple versions to catch any
> strange build issues sooner rather than later.
>
> --
> Matt Sicker 
>


[jira] [Created] (LOG4J2-1869) Update Kafka client from 0.10.1.1 to 0.10.2.0

2017-04-07 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1869:


 Summary: Update Kafka client from 0.10.1.1 to 0.10.2.0
 Key: LOG4J2-1869
 URL: https://issues.apache.org/jira/browse/LOG4J2-1869
 Project: Log4j 2
  Issue Type: Improvement
  Components: Appenders
Affects Versions: 2.8.2
Reporter: Gary Gregory


Update Kafka client from 0.10.1.1 to 0.10.2.0



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Created] (LOG4J2-1868) Update ZeroMQ's JeroMQ from 0.3.6 to 0.4.0

2017-04-07 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1868:


 Summary: Update ZeroMQ's JeroMQ from 0.3.6 to 0.4.0
 Key: LOG4J2-1868
 URL: https://issues.apache.org/jira/browse/LOG4J2-1868
 Project: Log4j 2
  Issue Type: Improvement
Affects Versions: 2.8.2
Reporter: Gary Gregory


Update ZeroMQ's JeroMQ from 0.3.6 to 0.4.0



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Fwd: Build failed in Jenkins: Log4jWindows » Windows,JDK 1.8 (unlimited security) 64-bit Windows only #51

2017-04-07 Thread Gary Gregory
Note that I ran a full build before this commit (mvn clean install) and it
worked.

Gary

-- Forwarded message --
From: Apache Jenkins Server 
Date: Fri, Apr 7, 2017 at 5:08 PM
Subject: Build failed in Jenkins: Log4jWindows » Windows,JDK 1.8 (unlimited
security) 64-bit Windows only #51
To: log4j-dev@logging.apache.org


See 

Changes:

[ggregory] Upadate Apache Active MQ from 5.14.1 to 5.14.2 for testing.

--
[...truncated 383.81 KB...]
2017-04-08 00:06:43,683 main DEBUG PatternLayout$Builder(pattern="%m%n",
PatternSelector=null, Configuration(PropertiesConfigTest), Replace=null,
charset="null", alwaysWriteExceptions="null", disableAnsi="null",
noConsoleNoAnsi="null", header="null", footer="null")
2017-04-08 00:06:43,684 main DEBUG PluginManager 'Converter' found 41
plugins
2017-04-08 00:06:43,685 main DEBUG Building Plugin[name=appender,
class=org.apache.logging.log4j.core.appender.ConsoleAppender].
2017-04-08 00:06:43,696 main DEBUG ConsoleAppender$Builder(target="null",
follow="null", direct="null", bufferedIo="null", bufferSize="null",
immediateFlush="null", ignoreExceptions="null", PatternLayout(%m%n),
name="STDOUT", Configuration(PropertiesConfigTest), Filter=null)
2017-04-08 00:06:43,697 main WARN Unable to instantiate
org.fusesource.jansi.WindowsAnsiOutputStream
2017-04-08 00:06:43,698 main DEBUG Starting OutputStreamManager
SYSTEM_OUT.false.false
2017-04-08 00:06:43,698 main DEBUG Building Plugin[name=layout,
class=org.apache.logging.log4j.core.layout.PatternLayout].
2017-04-08 00:06:43,699 main DEBUG PatternLayout$Builder(pattern="%d %p
%C{1.} [%t] %m%n", PatternSelector=null, Configuration(PropertiesConfigTest),
Replace=null, charset="null", alwaysWriteExceptions="null",
disableAnsi="null", noConsoleNoAnsi="null", header="null", footer="null")
2017-04-08 00:06:43,744 main DEBUG Building Plugin[name=appender,
class=org.apache.logging.log4j.core.appender.FileAppender].
2017-04-08 00:06:43,763 main DEBUG
FileAppender$Builder(fileName="target/test-properties.log",
append="null", locking="null", advertise="null", advertiseUri="null",
createOnDemand="null", bufferedIo="false", bufferSize="null",
immediateFlush="null", ignoreExceptions="null", PatternLayout(%d %p %C{1.}
[%t] %m%n), name="File", Configuration(PropertiesConfigTest), Filter=null)
2017-04-08 00:06:43,763 main WARN The bufferSize is set to 8192 but
bufferedIo is false: false
2017-04-08 00:06:43,770 main DEBUG Starting FileManager
target/test-properties.log
2017-04-08 00:06:43,770 main DEBUG Building Plugin[name=filter,
class=org.apache.logging.log4j.core.filter.ThresholdFilter].
2017-04-08 00:06:43,773 main DEBUG createFilter(level="ERROR",
onMatch="null", onMismatch="null")
2017-04-08 00:06:43,773 main DEBUG Building Plugin[name=appender,
class=org.apache.logging.log4j.test.appender.ListAppender].
2017-04-08 00:06:43,777 main DEBUG ListAppender$Builder(name="List",
entryPerNewLine="null", raw="null", Layout=null, ThresholdFilter(ERROR))
2017-04-08 00:06:43,778 main DEBUG Building Plugin[name=appenders,
class=org.apache.logging.log4j.core.config.AppendersPlugin].
2017-04-08 00:06:43,778 main DEBUG createAppenders(={STDOUT, File, List})
2017-04-08 00:06:43,779 main DEBUG Building Plugin[name=filter,
class=org.apache.logging.log4j.core.filter.ThresholdFilter].
2017-04-08 00:06:43,779 main DEBUG createFilter(level="DEBUG",
onMatch="null", onMismatch="null")
2017-04-08 00:06:43,781 main DEBUG Configuration
org.apache.logging.log4j.core.config.properties.PropertiesConfiguration@31ef45e3
initialized
2017-04-08 00:06:43,782 main DEBUG Starting configuration
org.apache.logging.log4j.core.config.properties.PropertiesConfiguration@
31ef45e3
2017-04-08 00:06:43,783 main DEBUG Log4j2 ConfigurationScheduler starting 1
threads
2017-04-08 00:06:43,785 main DEBUG Started configuration
org.apache.logging.log4j.core.config.properties.PropertiesConfiguration@31ef45e3
OK.
2017-04-08 00:06:43,786 main DEBUG Shutting down OutputStreamManager
SYSTEM_OUT.false.false-1
2017-04-08 00:06:43,787 main DEBUG Shut down OutputStreamManager
SYSTEM_OUT.false.false-1, all resources released: true
2017-04-08 00:06:43,787 main DEBUG Appender DefaultConsole-1 stopped with
status true
2017-04-08 00:06:43,788 main DEBUG Stopped org.apache.logging.log4j.core.
config.DefaultConfiguration@7921b0a2 OK
2017-04-08 00:06:43,981 main DEBUG Registering MBean
org.apache.logging.log4j2:type=org.apache.logging.log4j.
core.PropertiesFileConfigTest
2017-04-08 00:06:43,990 main DEBUG Registering MBean
org.apache.logging.log4j2:type=org.apache.logging.log4j.
core.PropertiesFileConfigTest,component=StatusLogger
2017-04-08 00:06:43,993 main DEBUG Registering MBean
org.apache.logging.log4j2:type=org.apache.logging.log4j.

Re: Weird compilation error

2017-04-07 Thread Gary Gregory
Could be I'm going to run the build with each ActiveMQ release since what
we have and see what happens. I'll nuke the latest one I have just in case
it's junked.

Gary

On Fri, Apr 7, 2017 at 1:49 PM, Matt Sicker <boa...@gmail.com> wrote:

> Corrupted downloads perhaps? That's very odd!
>
> On 7 April 2017 at 15:48, Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> Hm,
>>
>> I had changed active mq testing from 5.14.1 to 5.14.4 and that yields:
>>
>> [ERROR] error: error reading C:\Users\ggregory\.m2\reposito
>> ry\org\apache\activemq\activemq-broker\5.14.4\activemq-broker-5.14.4.jar;
>> invalid LOC header (bad signature)
>> [ERROR] error: error reading C:\Users\ggregory\.m2\reposito
>> ry\org\apache\activemq\activemq-client\5.14.4\activemq-client-5.14.4.jar;
>> invalid LOC header (bad signature)
>>
>> and later the problems I initially showed.
>>
>> Odd!
>>
>> Gary
>>
>>
>> On Fri, Apr 7, 2017 at 1:41 PM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> I added to log4j-1.2-api:
>>>
>>> 
>>>   org.apache.logging.log4j
>>>   log4j-core
>>>   test
>>>   test
>>> 
>>>
>>> but that blows up Maven 3.3.9:
>>>
>>> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
>>> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
>>> must be unique: org.apache.logging.log4j:log4j-core:jar -> duplicate
>>> declaration of version (?) @ 
>>> org.apache.logging.log4j:log4j-core-its:[unknown-version],
>>> C:\vcs\git\apache\logging\logging-log4j2\log4j-core-its\pom.xml, line
>>> 50, column 17
>>> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
>>> must be unique: org.apache.logging.log4j:log4j-api:test-jar ->
>>> duplicate declaration of version (?) @ 
>>> org.apache.logging.log4j:log4j-core-its:[unknown-version],
>>> C:\vcs\git\apache\logging\logging-log4j2\log4j-core-its\pom.xml, line
>>> 114, column 17
>>> [ERROR] 'dependencies.dependency.version' for
>>> org.apache.logging.log4j:log4j-core:test is missing. @
>>> org.apache.logging.log4j:log4j-1.2-api:[unknown-version],
>>> C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\pom.xml, line
>>> 47, column 17
>>> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
>>> must be unique: org.apache.logging.log4j:log4j-core:jar -> duplicate
>>> declaration of version (?) @ 
>>> org.apache.logging.log4j:log4j-slf4j-impl:[unknown-version],
>>> C:\vcs\git\apache\logging\logging-log4j2\log4j-slf4j-impl\pom.xml, line
>>> 70, column 17
>>> [WARNING] 'parent.relativePath' of POM 
>>> org.apache.logging.log4j:log4j-bom:2.8.3-SNAPSHOT
>>> (C:\vcs\git\apache\logging\logging-log4j2\log4j-bom\pom.xml) points at
>>> org.apache.logging.log4j:log4j instead of org.apache.logging:logging-parent,
>>> please verify your project structure @ line 19, column 11
>>>  @
>>>
>>>
>>> Gary
>>>
>>> On Fri, Apr 7, 2017 at 1:34 PM, Gary Gregory <garydgreg...@gmail.com>
>>> wrote:
>>>
>>>> This is with Maven 3.3.9 though.
>>>>
>>>> Gary
>>>>
>>>> On Fri, Apr 7, 2017 at 1:11 PM, Matt Sicker <boa...@gmail.com> wrote:
>>>>
>>>>> Does it have a dependency on log4j-core:test? It should. Could be a
>>>>> bug in your beta version of Maven ;)
>>>>>
>>>>> On 7 April 2017 at 14:46, Gary Gregory <garydgreg...@gmail.com> wrote:
>>>>>
>>>>>> Hi All:
>>>>>>
>>>>>> I'm seeing this in master:
>>>>>>
>>>>>> [INFO] --- maven-bundle-plugin:3.2.0:manifest (default) @
>>>>>> log4j-1.2-api ---
>>>>>> [INFO]
>>>>>> [INFO] --- maven-resources-plugin:3.0.1:testResources
>>>>>> (default-testResources) @ log4j-1.2-api ---
>>>>>> [INFO] Using 'UTF-8' encoding to copy filtered resources.
>>>>>> [INFO] Copying 71 resources
>>>>>> [INFO] Copying 3 resources
>>>>>> [INFO] Copying 3 resources
>>>>>> [INFO]
>>>>>> [INFO] --- maven-compiler-plugin:3.6.0:testCompile
>>>>>> (default-testCompile) @ log4j-1.2-api ---
>>>>>> [INFO] Change

Re: Weird compilation error

2017-04-07 Thread Gary Gregory
Hm,

I had changed active mq testing from 5.14.1 to 5.14.4 and that yields:

[ERROR] error: error reading
C:\Users\ggregory\.m2\repository\org\apache\activemq\activemq-broker\5.14.4\activemq-broker-5.14.4.jar;
invalid LOC header (bad signature)
[ERROR] error: error reading
C:\Users\ggregory\.m2\repository\org\apache\activemq\activemq-client\5.14.4\activemq-client-5.14.4.jar;
invalid LOC header (bad signature)

and later the problems I initially showed.

Odd!

Gary


On Fri, Apr 7, 2017 at 1:41 PM, Gary Gregory <garydgreg...@gmail.com> wrote:

> I added to log4j-1.2-api:
>
> 
>   org.apache.logging.log4j
>   log4j-core
>   test
>   test
> 
>
> but that blows up Maven 3.3.9:
>
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
> must be unique: org.apache.logging.log4j:log4j-core:jar -> duplicate
> declaration of version (?) @ org.apache.logging.log4j:
> log4j-core-its:[unknown-version], C:\vcs\git\apache\logging\
> logging-log4j2\log4j-core-its\pom.xml, line 50, column 17
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
> must be unique: org.apache.logging.log4j:log4j-api:test-jar -> duplicate
> declaration of version (?) @ org.apache.logging.log4j:
> log4j-core-its:[unknown-version], C:\vcs\git\apache\logging\
> logging-log4j2\log4j-core-its\pom.xml, line 114, column 17
> [ERROR] 'dependencies.dependency.version' for 
> org.apache.logging.log4j:log4j-core:test
> is missing. @ org.apache.logging.log4j:log4j-1.2-api:[unknown-version],
> C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\pom.xml, line 47,
> column 17
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
> must be unique: org.apache.logging.log4j:log4j-core:jar -> duplicate
> declaration of version (?) @ org.apache.logging.log4j:
> log4j-slf4j-impl:[unknown-version], C:\vcs\git\apache\logging\
> logging-log4j2\log4j-slf4j-impl\pom.xml, line 70, column 17
> [WARNING] 'parent.relativePath' of POM 
> org.apache.logging.log4j:log4j-bom:2.8.3-SNAPSHOT
> (C:\vcs\git\apache\logging\logging-log4j2\log4j-bom\pom.xml) points at
> org.apache.logging.log4j:log4j instead of org.apache.logging:logging-parent,
> please verify your project structure @ line 19, column 11
>  @
>
>
> Gary
>
> On Fri, Apr 7, 2017 at 1:34 PM, Gary Gregory <garydgreg...@gmail.com>
> wrote:
>
>> This is with Maven 3.3.9 though.
>>
>> Gary
>>
>> On Fri, Apr 7, 2017 at 1:11 PM, Matt Sicker <boa...@gmail.com> wrote:
>>
>>> Does it have a dependency on log4j-core:test? It should. Could be a bug
>>> in your beta version of Maven ;)
>>>
>>> On 7 April 2017 at 14:46, Gary Gregory <garydgreg...@gmail.com> wrote:
>>>
>>>> Hi All:
>>>>
>>>> I'm seeing this in master:
>>>>
>>>> [INFO] --- maven-bundle-plugin:3.2.0:manifest (default) @
>>>> log4j-1.2-api ---
>>>> [INFO]
>>>> [INFO] --- maven-resources-plugin:3.0.1:testResources
>>>> (default-testResources) @ log4j-1.2-api ---
>>>> [INFO] Using 'UTF-8' encoding to copy filtered resources.
>>>> [INFO] Copying 71 resources
>>>> [INFO] Copying 3 resources
>>>> [INFO] Copying 3 resources
>>>> [INFO]
>>>> [INFO] --- maven-compiler-plugin:3.6.0:testCompile
>>>> (default-testCompile) @ log4j-1.2-api ---
>>>> [INFO] Changes detected - recompiling the module!
>>>> [INFO] Compiling 20 source files to C:\vcs\git\apache\logging\logg
>>>> ing-log4j2\log4j-1.2-api\target\test-classes
>>>> [INFO] -
>>>> [WARN] COMPILATION WARNING :
>>>> [INFO] -
>>>> [WARN] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\t
>>>> est\java\org\apache\log4j\layout\Log4j1XmlLayoutTest.java:[66,16]
>>>> [deprecation] setContextMap(Map<String,String>) in Builder has been
>>>> deprecated
>>>> [WARN] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\t
>>>> est\java\org\apache\log4j\pattern\Log4j1MdcPatternConverterTest.java:[70,16]
>>>> [deprecation] setContextMap(Map<String,String>) in Builder has been
>>>> deprecated
>>>> [INFO] 2 warnings
>>>> [INFO] -
>>>> [INFO] -
>>>> [ERROR] COMPILATION ERROR

Re: Weird compilation error

2017-04-07 Thread Gary Gregory
I added to log4j-1.2-api:


  org.apache.logging.log4j
  log4j-core
  test
  test


but that blows up Maven 3.3.9:

[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: org.apache.logging.log4j:log4j-core:jar -> duplicate
declaration of version (?) @
org.apache.logging.log4j:log4j-core-its:[unknown-version],
C:\vcs\git\apache\logging\logging-log4j2\log4j-core-its\pom.xml, line 50,
column 17
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: org.apache.logging.log4j:log4j-api:test-jar -> duplicate
declaration of version (?) @
org.apache.logging.log4j:log4j-core-its:[unknown-version],
C:\vcs\git\apache\logging\logging-log4j2\log4j-core-its\pom.xml, line 114,
column 17
[ERROR] 'dependencies.dependency.version' for
org.apache.logging.log4j:log4j-core:test is missing. @
org.apache.logging.log4j:log4j-1.2-api:[unknown-version],
C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\pom.xml, line 47,
column 17
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)'
must be unique: org.apache.logging.log4j:log4j-core:jar -> duplicate
declaration of version (?) @
org.apache.logging.log4j:log4j-slf4j-impl:[unknown-version],
C:\vcs\git\apache\logging\logging-log4j2\log4j-slf4j-impl\pom.xml, line 70,
column 17
[WARNING] 'parent.relativePath' of POM
org.apache.logging.log4j:log4j-bom:2.8.3-SNAPSHOT
(C:\vcs\git\apache\logging\logging-log4j2\log4j-bom\pom.xml) points at
org.apache.logging.log4j:log4j instead of
org.apache.logging:logging-parent, please verify your project structure @
line 19, column 11
 @


Gary

On Fri, Apr 7, 2017 at 1:34 PM, Gary Gregory <garydgreg...@gmail.com> wrote:

> This is with Maven 3.3.9 though.
>
> Gary
>
> On Fri, Apr 7, 2017 at 1:11 PM, Matt Sicker <boa...@gmail.com> wrote:
>
>> Does it have a dependency on log4j-core:test? It should. Could be a bug
>> in your beta version of Maven ;)
>>
>> On 7 April 2017 at 14:46, Gary Gregory <garydgreg...@gmail.com> wrote:
>>
>>> Hi All:
>>>
>>> I'm seeing this in master:
>>>
>>> [INFO] --- maven-bundle-plugin:3.2.0:manifest (default) @ log4j-1.2-api
>>> ---
>>> [INFO]
>>> [INFO] --- maven-resources-plugin:3.0.1:testResources
>>> (default-testResources) @ log4j-1.2-api ---
>>> [INFO] Using 'UTF-8' encoding to copy filtered resources.
>>> [INFO] Copying 71 resources
>>> [INFO] Copying 3 resources
>>> [INFO] Copying 3 resources
>>> [INFO]
>>> [INFO] --- maven-compiler-plugin:3.6.0:testCompile
>>> (default-testCompile) @ log4j-1.2-api ---
>>> [INFO] Changes detected - recompiling the module!
>>> [INFO] Compiling 20 source files to C:\vcs\git\apache\logging\logg
>>> ing-log4j2\log4j-1.2-api\target\test-classes
>>> [INFO] -
>>> [WARN] COMPILATION WARNING :
>>> [INFO] -
>>> [WARN] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\t
>>> est\java\org\apache\log4j\layout\Log4j1XmlLayoutTest.java:[66,16]
>>> [deprecation] setContextMap(Map<String,String>) in Builder has been
>>> deprecated
>>> [WARN] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\t
>>> est\java\org\apache\log4j\pattern\Log4j1MdcPatternConverterTest.java:[70,16]
>>> [deprecation] setContextMap(Map<String,String>) in Builder has been
>>> deprecated
>>> [INFO] 2 warnings
>>> [INFO] -
>>> [INFO] -
>>> [ERROR] COMPILATION ERROR :
>>> [INFO] -
>>> [ERROR] warning: No processor claimed any of these annotations:
>>> org.junit.AfterClass,org.junit.Before,org.junit.runners.Para
>>> meterized.Parameters,org.junit.Rule,org.junit.ClassRule,org.
>>> junit.After,org.junit.runner.RunWith,org.junit.BeforeClass,
>>> org.junit.Test
>>> C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\t
>>> est\java\org\apache\log4j\LogWithMDCTest.java:[19,37] error: cannot
>>> find symbol
>>>   symbol:   class LoggerContextRule
>>>   location: package org.apache.logging.log4j.junit
>>> [ERROR] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\t
>>> est\java\org\apache\log4j\LogWithMDCTest.java:[20,45] error: package
>>> org.apache.logging.log4j.test.appender does not exist
>>> [ERR

Re: Weird compilation error

2017-04-07 Thread Gary Gregory
This is with Maven 3.3.9 though.

Gary

On Fri, Apr 7, 2017 at 1:11 PM, Matt Sicker <boa...@gmail.com> wrote:

> Does it have a dependency on log4j-core:test? It should. Could be a bug in
> your beta version of Maven ;)
>
> On 7 April 2017 at 14:46, Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> Hi All:
>>
>> I'm seeing this in master:
>>
>> [INFO] --- maven-bundle-plugin:3.2.0:manifest (default) @ log4j-1.2-api
>> ---
>> [INFO]
>> [INFO] --- maven-resources-plugin:3.0.1:testResources
>> (default-testResources) @ log4j-1.2-api ---
>> [INFO] Using 'UTF-8' encoding to copy filtered resources.
>> [INFO] Copying 71 resources
>> [INFO] Copying 3 resources
>> [INFO] Copying 3 resources
>> [INFO]
>> [INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile)
>> @ log4j-1.2-api ---
>> [INFO] Changes detected - recompiling the module!
>> [INFO] Compiling 20 source files to C:\vcs\git\apache\logging\logg
>> ing-log4j2\log4j-1.2-api\target\test-classes
>> [INFO] -
>> [WARN] COMPILATION WARNING :
>> [INFO] -
>> [WARN] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\
>> test\java\org\apache\log4j\layout\Log4j1XmlLayoutTest.java:[66,16]
>> [deprecation] setContextMap(Map<String,String>) in Builder has been
>> deprecated
>> [WARN] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\
>> test\java\org\apache\log4j\pattern\Log4j1MdcPatternConverterTest.java:[70,16]
>> [deprecation] setContextMap(Map<String,String>) in Builder has been
>> deprecated
>> [INFO] 2 warnings
>> [INFO] -
>> [INFO] -
>> [ERROR] COMPILATION ERROR :
>> [INFO] -
>> [ERROR] warning: No processor claimed any of these annotations:
>> org.junit.AfterClass,org.junit.Before,org.junit.runners.
>> Parameterized.Parameters,org.junit.Rule,org.junit.
>> ClassRule,org.junit.After,org.junit.runner.RunWith,org.
>> junit.BeforeClass,org.junit.Test
>> C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\
>> test\java\org\apache\log4j\LogWithMDCTest.java:[19,37] error: cannot
>> find symbol
>>   symbol:   class LoggerContextRule
>>   location: package org.apache.logging.log4j.junit
>> [ERROR] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\
>> test\java\org\apache\log4j\LogWithMDCTest.java:[20,45] error: package
>> org.apache.logging.log4j.test.appender does not exist
>> [ERROR] C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\
>> test\java\org\apache\log4j\LogWithMDCTest.java:[36,24] error: cannot
>> find symbol
>>   symbol:   class LoggerContextRule
>>   location: class LogWithMDCTest
>>
>> Any thoughts?
>>
>> Gary
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>>
>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
>> JUnit in Action, Second Edition
>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>
>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
>> Spring Batch in Action
>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker <boa...@gmail.com>
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Weird compilation error

2017-04-07 Thread Gary Gregory
Hi All:

I'm seeing this in master:

[INFO] --- maven-bundle-plugin:3.2.0:manifest (default) @ log4j-1.2-api ---
[INFO]
[INFO] --- maven-resources-plugin:3.0.1:testResources
(default-testResources) @ log4j-1.2-api ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 71 resources
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @
log4j-1.2-api ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 20 source files to
C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\target\test-classes
[INFO] -
[WARN] COMPILATION WARNING :
[INFO] -
[WARN]
C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\test\java\org\apache\log4j\layout\Log4j1XmlLayoutTest.java:[66,16]
[deprecation] setContextMap(Map) in Builder has been
deprecated
[WARN]
C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\test\java\org\apache\log4j\pattern\Log4j1MdcPatternConverterTest.java:[70,16]
[deprecation] setContextMap(Map) in Builder has been
deprecated
[INFO] 2 warnings
[INFO] -
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] warning: No processor claimed any of these annotations:
org.junit.AfterClass,org.junit.Before,org.junit.runners.Parameterized.Parameters,org.junit.Rule,org.junit.ClassRule,org.junit.After,org.junit.runner.RunWith,org.junit.BeforeClass,org.junit.Test
C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\test\java\org\apache\log4j\LogWithMDCTest.java:[19,37]
error: cannot find symbol
  symbol:   class LoggerContextRule
  location: package org.apache.logging.log4j.junit
[ERROR]
C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\test\java\org\apache\log4j\LogWithMDCTest.java:[20,45]
error: package org.apache.logging.log4j.test.appender does not exist
[ERROR]
C:\vcs\git\apache\logging\logging-log4j2\log4j-1.2-api\src\test\java\org\apache\log4j\LogWithMDCTest.java:[36,24]
error: cannot find symbol
  symbol:   class LoggerContextRule
  location: class LogWithMDCTest

Any thoughts?

Gary

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Yet another logging facade

2017-04-06 Thread Gary Gregory
A quick review of the document appears to have SLF4J as a requirement.
Shame about that.

Gary

On Thu, Apr 6, 2017 at 5:34 PM, Ralph Goers 
wrote:

> Where does one comment on these?
>
> The problem is that they mention Java 8 support, but SLF4J doesn’t take
> advantage of any Java 8 features yet. No support for Lamda’s.  From what I
> am seeing the next release will support running in Java 9 and will leverage
> StackWalker and support Java modules but Ceki hasn’t mentioned if he is
> going to add to the API to support things users have been asking for.
>
> I’d hate to see them base their standard on what was then the current
> release of SLF4J and then for it to be enhanced and they are stuck with a
> limited API.
>
> I wonder how much input, if any, Ceki had in this.
>
> As a side note, he also changed the binding mechanism and I am not sure if
> it is backward compatible, soI have a feeling log4j-slf4j-impl will need
> changes to support that version.
>
> Ralph
>
>
> On Apr 6, 2017, at 4:00 PM, Remko Popma  wrote:
>
> Good find. I noticed that the document points to Apache Sling and says
> "uses the most common parts today used for logging: SLF4J for clients and
> logback for processing."  Seems like Sling decided that in 2013 and never
> looked back. Which is fine, but I believe Log4j2 has changed the landscape
> the last 4 years.
>
> Sent from my iPhone
>
> On Apr 7, 2017, at 6:08, Matt Sicker  wrote:
>
> OSGi is looking at updating their logging API:
>
> https://github.com/osgi/design/blob/master/rfcs/
> rfc0219/rfc-0219-LogService-Update.pdf
>
> We might want to provide feedback.
>
> --
> Matt Sicker 
>
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[jira] [Commented] (LOG4J2-1866) Add default value to MdcPatternConverter

2017-04-06 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959186#comment-15959186
 ] 

Gary Gregory commented on LOG4J2-1866:
--

Patches with unit tests are welcome :-)

> Add default value to MdcPatternConverter 
> -
>
> Key: LOG4J2-1866
> URL: https://issues.apache.org/jira/browse/LOG4J2-1866
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Pattern Converters
>Affects Versions: 2.8.2
>Reporter: Izek Greenfield
>  Labels: converter, mdc, pattern
>
> When using %X in a pattern I can't define default value if the value does not 
> exist in MDC.
> I will be great to be able to define one like:
> {code:title=pattern|borderStyle=solid}
> %X{key}{hello}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: MessageLayout

2017-04-04 Thread Gary Gregory
Roger that! Thank you all for your comments. Flume with unique keys it is.

Gary

On Mon, Apr 3, 2017 at 10:15 PM, Ralph Goers <ralph.go...@dslextreme.com>
wrote:

> Again, if you use an async logger you will lose whatever is in the memory
> buffer when the server stops or crashes. If you log directly to Flume you
> are guaranteed that the audit event is written when the logging call
> returns and your application can count on that.
>
> The only thing you really need to be aware of is that in an HA
> configuration it is possible to end up with multiple instances of the event
> in the final repository so you need to make sure your events include a
> unique key that can be used to remove duplicates.
>
> Ralph
>
> On Apr 3, 2017, at 8:40 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Thanks Matt. With the Flume appender, do I still need to use an async
> logger to get the best perf?
>
> Gary
>
> On Mon, Apr 3, 2017 at 8:31 PM, Matt Sicker <boa...@gmail.com> wrote:
>
>> Clarifications: other than the file appenders, the flume appender is
>> probably the most reliable appender.
>>
>> And for the direct appender config, that's also with fully async loggers.
>> I've been considering putting together a small blog post about the most
>> efficient log4j2.xml configurations.
>>
>> On 3 April 2017 at 22:01, Matt Sicker <boa...@gmail.com> wrote:
>>
>>> The Flume appender can persist messages within the same process to files
>>> before sending them to other agents. I don't think any other appender can
>>> guarantee that.
>>>
>>> Personally, I've been using direct console appenders lately and using
>>> graylog to slurp stdout on docker containers, but I'm not the one who set
>>> all that up. Either way, the most reliable way to log things outside of
>>> files is Flume.
>>>
>>> On 3 April 2017 at 19:45, Gary Gregory <garydgreg...@gmail.com> wrote:
>>>
>>>> Wait a sec. A JMS provider can guarantee message delivery. How can
>>>> events be lost once they are in the provider? Are you saying that using an
>>>> async logger is 'unsafe' because the events in the ring buffer go away if
>>>> the JVM goes down?
>>>>
>>>> Ideally I want to publish and forget, with the publish part
>>>> asynchronous, call the API, and it returns right away.
>>>>
>>>> Is there no way to do that with our JMS Appender?
>>>>
>>>> Gary
>>>>
>>>> On Mon, Apr 3, 2017 at 5:38 PM, Ralph Goers <ralph.go...@dslextreme.com
>>>> > wrote:
>>>>
>>>>> What’s the point though when all you have to do is specify the pattern
>>>>> layout with “%m%ex{none}”?
>>>>>
>>>>> How can you do auditing with the async logger? You may lose events
>>>>> with that.
>>>>>
>>>>> Your use case is exactly why I wrote the FlumeAppender. It is very
>>>>> much like JMS but a whole lot faster and guarantees events aren’t lost.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Apr 3, 2017, at 5:03 PM, Gary Gregory <garydgreg...@gmail.com>
>>>>> wrote:
>>>>>
>>>>> Right. I want to post to JMS message objects I've serialized to JSON.
>>>>> All I care about is the message.
>>>>>
>>>>> I log these events to a specially named logger with a specially named
>>>>> marker. These are the only events that should be published to JMS (I use a
>>>>> filter and the one marker). I am in charge of the message format and it is
>>>>> consumed on the other JMS side by a specialized agent which I also 
>>>>> control.
>>>>>
>>>>> IOW, I am using the Log4j infrastructure as the simplest way to send
>>>>> custom messages over to JMS. These are not traditional logging events,
>>>>> rather a kind of auditing system. I leverage the Log4j async logger as
>>>>> well. No need to deal with the JMS API.
>>>>>
>>>>> Gary
>>>>>
>>>>> On Mon, Apr 3, 2017 at 4:07 PM, Remko Popma <remko.po...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> So, exceptions are swallowed and no newlines are rendered?
>>>>>> Interesting.
>>>>>> What's the use case?
>>>>>>
>>>>>> Sent from my iPhone
>>>>>>
>>>>>> On Apr 

Re: MessageLayout

2017-04-03 Thread Gary Gregory
Thanks Matt. With the Flume appender, do I still need to use an async
logger to get the best perf?

Gary

On Mon, Apr 3, 2017 at 8:31 PM, Matt Sicker <boa...@gmail.com> wrote:

> Clarifications: other than the file appenders, the flume appender is
> probably the most reliable appender.
>
> And for the direct appender config, that's also with fully async loggers.
> I've been considering putting together a small blog post about the most
> efficient log4j2.xml configurations.
>
> On 3 April 2017 at 22:01, Matt Sicker <boa...@gmail.com> wrote:
>
>> The Flume appender can persist messages within the same process to files
>> before sending them to other agents. I don't think any other appender can
>> guarantee that.
>>
>> Personally, I've been using direct console appenders lately and using
>> graylog to slurp stdout on docker containers, but I'm not the one who set
>> all that up. Either way, the most reliable way to log things outside of
>> files is Flume.
>>
>> On 3 April 2017 at 19:45, Gary Gregory <garydgreg...@gmail.com> wrote:
>>
>>> Wait a sec. A JMS provider can guarantee message delivery. How can
>>> events be lost once they are in the provider? Are you saying that using an
>>> async logger is 'unsafe' because the events in the ring buffer go away if
>>> the JVM goes down?
>>>
>>> Ideally I want to publish and forget, with the publish part
>>> asynchronous, call the API, and it returns right away.
>>>
>>> Is there no way to do that with our JMS Appender?
>>>
>>> Gary
>>>
>>> On Mon, Apr 3, 2017 at 5:38 PM, Ralph Goers <ralph.go...@dslextreme.com>
>>> wrote:
>>>
>>>> What’s the point though when all you have to do is specify the pattern
>>>> layout with “%m%ex{none}”?
>>>>
>>>> How can you do auditing with the async logger? You may lose events with
>>>> that.
>>>>
>>>> Your use case is exactly why I wrote the FlumeAppender. It is very much
>>>> like JMS but a whole lot faster and guarantees events aren’t lost.
>>>>
>>>> Ralph
>>>>
>>>> On Apr 3, 2017, at 5:03 PM, Gary Gregory <garydgreg...@gmail.com>
>>>> wrote:
>>>>
>>>> Right. I want to post to JMS message objects I've serialized to JSON.
>>>> All I care about is the message.
>>>>
>>>> I log these events to a specially named logger with a specially named
>>>> marker. These are the only events that should be published to JMS (I use a
>>>> filter and the one marker). I am in charge of the message format and it is
>>>> consumed on the other JMS side by a specialized agent which I also control.
>>>>
>>>> IOW, I am using the Log4j infrastructure as the simplest way to send
>>>> custom messages over to JMS. These are not traditional logging events,
>>>> rather a kind of auditing system. I leverage the Log4j async logger as
>>>> well. No need to deal with the JMS API.
>>>>
>>>> Gary
>>>>
>>>> On Mon, Apr 3, 2017 at 4:07 PM, Remko Popma <remko.po...@gmail.com>
>>>> wrote:
>>>>
>>>>> So, exceptions are swallowed and no newlines are rendered?
>>>>> Interesting.
>>>>> What's the use case?
>>>>>
>>>>> Sent from my iPhone
>>>>>
>>>>> On Apr 4, 2017, at 7:30, Gary Gregory <garydgreg...@gmail.com> wrote:
>>>>>
>>>>> Hi All,
>>>>>
>>>>> I am considering a new layout called "MessageLayout" which would be
>>>>> synonymous with:. Thoughts?
>>>>>
>>>>> Gary
>>>>>
>>>>> --
>>>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>>>
>>>>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
>>>>> JUnit in Action, Second Edition
>>>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>>>>
>>>>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
>>>>> Spring Batch in Action
>

Re: MessageLayout

2017-04-03 Thread Gary Gregory
Wait a sec. A JMS provider can guarantee message delivery. How can events
be lost once they are in the provider? Are you saying that using an async
logger is 'unsafe' because the events in the ring buffer go away if the JVM
goes down?

Ideally I want to publish and forget, with the publish part asynchronous,
call the API, and it returns right away.

Is there no way to do that with our JMS Appender?

Gary

On Mon, Apr 3, 2017 at 5:38 PM, Ralph Goers <ralph.go...@dslextreme.com>
wrote:

> What’s the point though when all you have to do is specify the pattern
> layout with “%m%ex{none}”?
>
> How can you do auditing with the async logger? You may lose events with
> that.
>
> Your use case is exactly why I wrote the FlumeAppender. It is very much
> like JMS but a whole lot faster and guarantees events aren’t lost.
>
> Ralph
>
> On Apr 3, 2017, at 5:03 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Right. I want to post to JMS message objects I've serialized to JSON. All
> I care about is the message.
>
> I log these events to a specially named logger with a specially named
> marker. These are the only events that should be published to JMS (I use a
> filter and the one marker). I am in charge of the message format and it is
> consumed on the other JMS side by a specialized agent which I also control.
>
> IOW, I am using the Log4j infrastructure as the simplest way to send
> custom messages over to JMS. These are not traditional logging events,
> rather a kind of auditing system. I leverage the Log4j async logger as
> well. No need to deal with the JMS API.
>
> Gary
>
> On Mon, Apr 3, 2017 at 4:07 PM, Remko Popma <remko.po...@gmail.com> wrote:
>
>> So, exceptions are swallowed and no newlines are rendered? Interesting.
>> What's the use case?
>>
>> Sent from my iPhone
>>
>> On Apr 4, 2017, at 7:30, Gary Gregory <garydgreg...@gmail.com> wrote:
>>
>> Hi All,
>>
>> I am considering a new layout called "MessageLayout" which would be
>> synonymous with:. Thoughts?
>>
>> Gary
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>>
>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
>> JUnit in Action, Second Edition
>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>
>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
>> Spring Batch in Action
>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: MessageLayout

2017-04-03 Thread Gary Gregory
Right. I want to post to JMS message objects I've serialized to JSON. All I
care about is the message.

I log these events to a specially named logger with a specially named
marker. These are the only events that should be published to JMS (I use a
filter and the one marker). I am in charge of the message format and it is
consumed on the other JMS side by a specialized agent which I also control.

IOW, I am using the Log4j infrastructure as the simplest way to send custom
messages over to JMS. These are not traditional logging events, rather a
kind of auditing system. I leverage the Log4j async logger as well. No need
to deal with the JMS API.

Gary

On Mon, Apr 3, 2017 at 4:07 PM, Remko Popma <remko.po...@gmail.com> wrote:

> So, exceptions are swallowed and no newlines are rendered? Interesting.
> What's the use case?
>
> Sent from my iPhone
>
> On Apr 4, 2017, at 7:30, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Hi All,
>
> I am considering a new layout called "MessageLayout" which would be
> synonymous with:. Thoughts?
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


MessageLayout

2017-04-03 Thread Gary Gregory
Hi All,

I am considering a new layout called "MessageLayout" which would be
synonymous with:. Thoughts?

Gary

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Deep Dive into Java 9’s Stack-Walking API

2017-04-03 Thread Gary Gregory
On a biz trip to the NL for a week, then a vacation to the UK and France
for two weeks ;-)

G

On Apr 2, 2017 10:35 PM, "Ralph Goers" <ralph.go...@dslextreme.com> wrote:

> Where have you been?  I posted performance benchmarks based on that a week
> or two ago. See all my updates to LOG4J2-1359.
>
> I have already implemented StackWalker support on branch java9NoMultiRelease.
> I started on a branch for LOG4J2-1359 but trouble with the Multi-Release
> jar made me rethink it so I reimplemented it on the new branch. Once I have
> support for modules I will be merging it back into the LOG4J2-1359 branch
> and looking for a code review. In the meantime you are free to look at the
> java9NoMultiRelease branch.
>
> Ralph
>
>
> On Apr 2, 2017, at 10:03 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> FYI: https://www.sitepoint.com/deep-dive-into-java-9s-stack-walking-api/
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http://ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


Deep Dive into Java 9’s Stack-Walking API

2017-04-02 Thread Gary Gregory
FYI: https://www.sitepoint.com/deep-dive-into-java-9s-stack-walking-api/

Gary

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: [VOTE] Release Log4j 2.8.2 rc1

2017-04-02 Thread Gary Gregory
... and thank you Matt for picking up RM duty this time around.

I look forward to getting 2.8.2 out the door and seeing what we have in
store for 2.9!

Gary

On Sun, Apr 2, 2017 at 2:08 PM, Matt Sicker  wrote:

> This is a vote to release Log4j 2.8.2. Please download, test, and cast
> your votes on this mailing list.
>
> [] +1, release the artifacts
>
> [] -1, don't release because...
>
> The vote will remain open for 72 hours at least. All votes are welcome,
> and we encourage everyone to test the release, but only Logging PMC votes
> are counted towards the "official" vote count. As always, at least 3 +1s
> and more +1s than -1s are required.
>
> Changes in this version include:
>
> New
> Features
>
>- LOG4J2-1863 : Add
>support for filtering input in TcpSocketServer and UdpSocketServer.
>- LOG4J2-1848 : Add
>JSON encoding support to EncodingPatternConverter %encode{}.
>- LOG4J2-1843 : Add
>support for appending common suffix to each line of throwable stack trace.
>Thanks to Zilong Song.
>- LOG4J2-1838 : Add
>support for appending common suffix to each line of extended and root
>throwable stack trace. Thanks to Zilong Song.
>
>
> Fixed
> Bugs
>
>- LOG4J2-1861 : Fix
>JavaDoc on org.apache.logging.log4j.ThreadContext about inheritance.
>- LOG4J2-1862 : Fix
>JavaDoc about @Order and OrderComparator ordering. Thanks to wangyuntao.
>- LOG4J2-1849 :
>Fixed daylight savings time issue with FixedDateFormat.
>- LOG4J2-1850 : Fix
>CassandraRule and unit tests on Windows. Thanks to Ludovic Hochet.
>- LOG4J2-1840 : Fix
>typo in %replace converter documentation. Thanks to Pradeep Balasundaram.
>- LOG4J2-1846 :
>Handle when LogEvent.getLoggerName() returns null in
>LoggerNameLevelRewritePolicy.
>- LOG4J2-1845 :
>Handle when LogEvent.getLoggerName() returns null in KafkaAppender.
>- LOG4J2-1853 : The
>default value of RandomAccessFileAppender.Builder append field is
>wrong. Thanks to wangyuntao.
>- LOG4J2-1835 : Fix
>documentation about the licensing for JeroMQ.
>- LOG4J2-1836 :
>Update the API version to 2.6.0.
>- LOG4J2-1831 :
>NullPointerException in HtmlLayout. Thanks to Edward Serebrinskiy.
>- LOG4J2-1820 :
>Log4j 2.8 can lose exceptions when a security manager is present. Thanks to
>Jason Tedor.
>
>
> 
> Changes
>
>- LOG4J2-1827 :
>Move integration tests to their own module to speed up build.
>- LOG4J2-1856 :
>Update Jackson from 2.8.6 to 2.8.7.
>
> Tag: log4j-2.8.2-rc1
>
> Web site: https://rgoers.github.io/log4j2-site/
>
> Artifacts: https://repository.apache.org/content/
> repositories/orgapachelogging-1026/
>
> You can download all the artifacts via the command line:
>
> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate
> https://repository.apache.org/content/repositories/orgapachelogging-1026/
>
> --
> Matt Sicker 
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action



Re: [VOTE] Release Log4j 2.8.2 rc1

2017-04-02 Thread Gary Gregory
+1

MD5, SHA1, ASC OK.

Following BUILDING.md:

RAT check OK
CLIRR check on API OK
mvn clean install OK
CLIRR check on 1.2 API OK

mvn site OK but with some Javadoc warnings:

[WARNING] C:\temp\rc\apache-log4j-2.8.2-src\log4j-api\src\main\java\
org\apache\logging\log4j\ThreadContext.java:49: warning -
DefaultThreadContextMap#INHERITABLE_MAP (referenced by @value tag) is an
unknown reference.
[WARNING] C:\temp\rc\apache-log4j-2.8.2-src\log4j-api\src\main\java\
org\apache\logging\log4j\status\StatusLogger.java:52: warning -
SimpleLoggerContext#SYSTEM_PREFIX (referenced by @value tag) is an unknown
reference.

OK: mvn site:stage-deploy
-DstagingSiteURL=file:///%HOMEDRIVE%%HOMEPATH%/log4j

Using:

Apache Maven 3.5.0-beta-1 (214540c2ae5431645bb927d6dc5498ebafc27359;
2017-03-20T09:58:41-07:00)
Maven home: C:\Java\apache-maven-3.5.0-beta-1\bin\..
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

Gary

On Sun, Apr 2, 2017 at 2:08 PM, Matt Sicker  wrote:

> This is a vote to release Log4j 2.8.2. Please download, test, and cast
> your votes on this mailing list.
>
> [] +1, release the artifacts
>
> [] -1, don't release because...
>
> The vote will remain open for 72 hours at least. All votes are welcome,
> and we encourage everyone to test the release, but only Logging PMC votes
> are counted towards the "official" vote count. As always, at least 3 +1s
> and more +1s than -1s are required.
>
> Changes in this version include:
>
> New
> Features
>
>- LOG4J2-1863 : Add
>support for filtering input in TcpSocketServer and UdpSocketServer.
>- LOG4J2-1848 : Add
>JSON encoding support to EncodingPatternConverter %encode{}.
>- LOG4J2-1843 : Add
>support for appending common suffix to each line of throwable stack trace.
>Thanks to Zilong Song.
>- LOG4J2-1838 : Add
>support for appending common suffix to each line of extended and root
>throwable stack trace. Thanks to Zilong Song.
>
>
> Fixed
> Bugs
>
>- LOG4J2-1861 : Fix
>JavaDoc on org.apache.logging.log4j.ThreadContext about inheritance.
>- LOG4J2-1862 : Fix
>JavaDoc about @Order and OrderComparator ordering. Thanks to wangyuntao.
>- LOG4J2-1849 :
>Fixed daylight savings time issue with FixedDateFormat.
>- LOG4J2-1850 : Fix
>CassandraRule and unit tests on Windows. Thanks to Ludovic Hochet.
>- LOG4J2-1840 : Fix
>typo in %replace converter documentation. Thanks to Pradeep Balasundaram.
>- LOG4J2-1846 :
>Handle when LogEvent.getLoggerName() returns null in
>LoggerNameLevelRewritePolicy.
>- LOG4J2-1845 :
>Handle when LogEvent.getLoggerName() returns null in KafkaAppender.
>- LOG4J2-1853 : The
>default value of RandomAccessFileAppender.Builder append field is
>wrong. Thanks to wangyuntao.
>- LOG4J2-1835 : Fix
>documentation about the licensing for JeroMQ.
>- LOG4J2-1836 :
>Update the API version to 2.6.0.
>- LOG4J2-1831 :
>NullPointerException in HtmlLayout. Thanks to Edward Serebrinskiy.
>- LOG4J2-1820 :
>Log4j 2.8 can lose exceptions when a security manager is present. Thanks to
>Jason Tedor.
>
>
> 
> Changes
>
>- LOG4J2-1827 :
>Move integration tests to their own module to speed up build.
>- LOG4J2-1856 :
>Update Jackson from 2.8.6 to 2.8.7.
>
> Tag: log4j-2.8.2-rc1
>
> Web site: https://rgoers.github.io/log4j2-site/
>
> Artifacts: https://repository.apache.org/content/repositorie
> s/orgapachelogging-1026/
>
> You can download all the artifacts via the command line:
>
> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate
> 

Re: Upcoming release planning

2017-03-31 Thread Gary Gregory
Go for it :-)

Gary

On Mar 31, 2017 8:19 AM, "Matt Sicker"  wrote:

> I'd like to see two releases happen soon:
>
> log4j-api-scala v11: let's get this out the door soon
> log4j-core 2.8.2: we have bugfixes ready and I'd also like to see a
> release of this before we move on to major 2.9 work
>
> What do you all think? I can do most of the scala release myself, though
> I'm not sure how to handle the site deployment part, so I'll need some help
> there. As for the core release, I've done it once before, so if Ralph
> doesn't have time to handle it, I can try it out again myself.
>
> --
> Matt Sicker 
>


[jira] [Closed] (LOG4J2-1856) Update Jackson from 2.8.6 to 2.8.7.

2017-03-25 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1856.

   Resolution: Fixed
Fix Version/s: 2.8.2

In Git master.

> Update Jackson from 2.8.6 to 2.8.7.
> ---
>
> Key: LOG4J2-1856
> URL: https://issues.apache.org/jira/browse/LOG4J2-1856
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8.1
>Reporter: Gary Gregory
> Fix For: 2.8.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Created] (LOG4J2-1856) Update Jackson from 2.8.6 to 2.8.7.

2017-03-25 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1856:


 Summary: Update Jackson from 2.8.6 to 2.8.7.
 Key: LOG4J2-1856
 URL: https://issues.apache.org/jira/browse/LOG4J2-1856
 Project: Log4j 2
  Issue Type: Improvement
  Components: Appenders
Affects Versions: 2.8.1
Reporter: Gary Gregory






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1071) Allow for bufferSize=0 in SMTP appender

2017-03-25 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942130#comment-15942130
 ] 

Gary Gregory commented on LOG4J2-1071:
--

Patches welcome :-)

> Allow for bufferSize=0 in SMTP appender
> ---
>
> Key: LOG4J2-1071
> URL: https://issues.apache.org/jira/browse/LOG4J2-1071
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.3
>Reporter: Benjamin Jaton
>Priority: Minor
>
> From the doc:
> "The number of logging events delivered in this e-mail depend on the value of 
> BufferSize option. The SMTPAppender keeps only the last BufferSize logging 
> events in its cyclic buffer. This keeps memory requirements at a reasonable 
> level while still delivering useful application context. All events in the 
> buffer are included in the email. The buffer will contain the most recent 
> events of level TRACE to WARN preceding the event that triggered the email."
> https://logging.apache.org/log4j/2.x/manual/appenders.html#SMTPAppender
> The bufferSize is the number of messages preceding the message that triggered 
> the event. They might be completely unrelated. One may not want to include 
> them in the email at all, so having a bufferSize of 0 makes sense.
> This is however disallowed in the code:
> Caused by: java.lang.IllegalArgumentException: The maxSize argument (0) is 
> not a positive integer.
>   at 
> org.apache.logging.log4j.core.util.CyclicBuffer.(CyclicBuffer.java:41)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.(SmtpManager.java:70)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager$SMTPManagerFactory.createManager(SmtpManager.java:338)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager$SMTPManagerFactory.createManager(SmtpManager.java:299)
>   at 
> org.apache.logging.log4j.core.appender.AbstractManager.getManager(AbstractManager.java:71)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.getSMTPManager(SmtpManager.java:124)
>   at 
> org.apache.logging.log4j.core.appender.SmtpAppender.createAppender(SmtpAppender.java:142)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Resolved] (LOG4J2-1853) The default value of RandomAccessFileAppender.Builder append field is wrong

2017-03-25 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory resolved LOG4J2-1853.
--
   Resolution: Fixed
Fix Version/s: 2.8.2

Closes #66. Please verify and close this Jira.

> The default value of RandomAccessFileAppender.Builder append field is wrong
> ---
>
> Key: LOG4J2-1853
> URL: https://issues.apache.org/jira/browse/LOG4J2-1853
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: wangyuntao
> Fix For: 2.8.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: org.apache.logging.log4j.ThreadContext.pop()

2017-03-07 Thread Gary Gregory
On Sun, Mar 5, 2017 at 6:43 PM, Matt Sicker <boa...@gmail.com> wrote:

> Looking at the code for trim(int), it seems to do the opposite actually:
>
> https://github.com/apache/logging-log4j2/blob/master/
> log4j-api/src/main/java/org/apache/logging/log4j/spi/
> MutableThreadContextStack.java#L102
>
> You'd have to keep the old depth before pushing, then restoring it with
> the old depth to trim it back down.
>
> I'd support adding a pop(int) or similar method provided you can come up
> with a better name than ContextStack2 or some other silly interface update.
>

Bleh, I forgot about that part. I do not think there is a better name.

Gary

>
> On 5 March 2017 at 20:11, Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> IIRC this is just old code mindlessly ported from log4j 1.
>>
>> Gary
>>
>>
>> On Mar 5, 2017 6:17 PM, "Matt Sicker" <boa...@gmail.com> wrote:
>>
>> I'm interested to hear what you use the stack instead of map for in the
>> first place.
>>
>> There's already a method for this, though: ThreadContext.trim(int).
>>
>> On 5 March 2017 at 09:52, Gary Gregory <garydgreg...@gmail.com> wrote:
>>
>>> When I want to pop the ThreadContext more than once I do:
>>>
>>> ThreadContext.pop();
>>> ThreadContext.pop();
>>> ThreadContext.pop();
>>> ThreadContext.pop();
>>>
>>> Instead I'd like to update some legacy code to:
>>>
>>> ThreadContext.pop(4);
>>>
>>> (I know, I know, I should update that old code to push()/clear())
>>>
>>> Thoughts on adding pop(int)?
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>>>
>>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
>>> JUnit in Action, Second Edition
>>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>>
>>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
>>> Spring Batch in Action
>>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> Matt Sicker <boa...@gmail.com>
>>
>>
>>
>
>
> --
> Matt Sicker <boa...@gmail.com>
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[jira] [Commented] (LOG4J2-1753) java.lang.ClassNotFoundException: org.apache.logging.log4j.core.util.ExecutorServices when running the OSGi tests

2017-03-07 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900861#comment-15900861
 ] 

Gary Gregory commented on LOG4J2-1753:
--

[~jvz] The tests pass now so that solves the reported issue. Let's see what 
[~lhochet] says.

> java.lang.ClassNotFoundException: 
> org.apache.logging.log4j.core.util.ExecutorServices when running the OSGi 
> tests
> -
>
> Key: LOG4J2-1753
> URL: https://issues.apache.org/jira/browse/LOG4J2-1753
> Project: Log4j 2
>  Issue Type: Bug
>Reporter: Ludovic HOCHET
> Attachments: patch-log4j2-1753.diff
>
>
> When running the OSGi tests for LOG4J2-1664, a new 
> java.lang.ClassNotFoundException: 
> org.apache.logging.log4j.core.util.ExecutorServices (for both Felix and 
> Equinox) appeared recently.
> Here is the Felix stack trace:
> {noformat}
> ERROR StatusLogger Failed to preload ExecutorServices class.
>  java.lang.ClassNotFoundException: *** Class 
> 'org.apache.logging.log4j.core.util.ExecutorServices' was not found because 
> bundle org.apache.logging.log4j.api [1] does not import 
> 'org.apache.logging.log4j.core.util' even though bundle 
> org.apache.logging.log4j.core [2] does export it. To resolve this issue, add 
> an import for 'org.apache.logging.log4j.core.util' to bundle 
> org.apache.logging.log4j.api [1]. ***
>   at 
> org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:2011)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:264)
>   at 
> org.apache.logging.log4j.util.LoaderUtil.loadClass(LoaderUtil.java:141)
>   at 
> org.apache.logging.log4j.core.LoggerContext.(LoggerContext.java:74)
>   at 
> org.apache.logging.log4j.core.osgi.BundleContextSelector.locateContext(BundleContextSelector.java:67)
>   at 
> org.apache.logging.log4j.core.osgi.BundleContextSelector.getContext(BundleContextSelector.java:53)
>   at 
> org.apache.logging.log4j.core.selector.ClassLoaderContextSelector.getContext(ClassLoaderContextSelector.java:57)
>   at 
> org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:147)
>   at 
> org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:45)
>   at org.apache.logging.log4j.LogManager.getContext(LogManager.java:194)
>   at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:551)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.apache.logging.log4j.osgi.tests.AbstractLoadBundleTest.log(AbstractLoadBundleTest.java:100)
>   at 
> org.apache.logging.log4j.osgi.tests.AbstractLoadBundleTest.testSimpleLogInAnOsgiContext(AbstractLoadBundleTest.java:279)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.r

Re: [VOTE] Combine the project user and dev mailing lists into user@ and dev@

2017-03-07 Thread Gary Gregory
On Mar 8, 2017 5:28 AM, "Matt Sicker"  wrote:

I may be missing some mailing lists considering I just subscribed to half
of them less than five minutes ago.

This is a vote to merge the various Apache Logging Services mailing lists.
The proposal is to combine them as follows:

log4j-dev@, log4php-dev@, log4net-dev@, log4cxx-dev@ ->
d...@logging.apache.org


+1

log4j-user@, log4php-user@, log4net-user@, log4cxx-user@, general@ ->
u...@logging.apache.org


-0 Stefan makes a good point IMO.

Gary


commits@ and private@ remain the same as before.

The proposal would also suggest that the old emails become aliases for the
combined email names so as not to lose any future emails. To distinguish
between projects, a subject tag can be added such as:

[java]
[net]
[cxx]
[php]

Though I wouldn't think such a tag is required, though it should help in
gaining the attention of the appropriate audience.

Voting:

+1: Yes, combine the mailing lists!
+0: Go ahead, don't care that much.
-0: Don't like it, but not vetoing it.
-1: No, don't do that! I have a better idea!

This vote follows the same "lazy consensus" (at least 3 +1 binding, no
-1/vetoes) we use for general releases and whatnot. The vote will be open
for at least 72 hours.

-- 
Matt Sicker 


[jira] [Closed] (LOG4J2-1804) Rolling file %i based rolling broken in 2.8

2017-03-06 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1804.


Closing as fixed in 2.8.1.

> Rolling file %i based rolling broken in 2.8
> ---
>
> Key: LOG4J2-1804
> URL: https://issues.apache.org/jira/browse/LOG4J2-1804
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders
>Affects Versions: 2.8
>Reporter: Brendan Miller
>Assignee: Ralph Goers
> Fix For: 2.8.1
>
> Attachments: LOG4J2-1804.junit.and.fix.patch, LOG4J2-1804.junit.patch
>
>
> Log files do not seem to be rolling up to the max number of files as 
> specified in DefaultRolloverStrategy while utilizing a 
> SizeBasedTriggeringPolicy. It is just rolling just to 1 file.
> Simple repro:
> log4j2.xml
> {code}
> 
> 
> 
>   fileName="__logs__/rolling.log"
>  filePattern="__logs__/rolling.log.%i"
>  immediateFlush="true">
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}
> MyApp.scala:
> {code}
> import scala.util.Random
> import org.apache.logging.log4j.LogManager
> object MyApp extends App {
>   val log = LogManager.getLogger(this.getClass)
>   var counter = 0L
>   var bytes = new Array[Byte](1000)
>   while (true) {
> Random.nextBytes(bytes)
> log.info(f"Log statement: $counter%08x ${bytes.mkString}")
> counter += 1
> Thread.sleep(5)
>   }
> }
> {code}
> If you run that against 2.7, things roll fine. If you run that against 2.8, 
> you'll only see rolling.log & rolling.log.1 in the __logs__ folder.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: org.apache.logging.log4j.ThreadContext.pop()

2017-03-05 Thread Gary Gregory
IIRC this is just old code mindlessly ported from log4j 1.

Gary


On Mar 5, 2017 6:17 PM, "Matt Sicker" <boa...@gmail.com> wrote:

I'm interested to hear what you use the stack instead of map for in the
first place.

There's already a method for this, though: ThreadContext.trim(int).

On 5 March 2017 at 09:52, Gary Gregory <garydgreg...@gmail.com> wrote:

> When I want to pop the ThreadContext more than once I do:
>
> ThreadContext.pop();
> ThreadContext.pop();
> ThreadContext.pop();
> ThreadContext.pop();
>
> Instead I'd like to update some legacy code to:
>
> ThreadContext.pop(4);
>
> (I know, I know, I should update that old code to push()/clear())
>
> Thoughts on adding pop(int)?
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <boa...@gmail.com>


org.apache.logging.log4j.ThreadContext.pop()

2017-03-05 Thread Gary Gregory
When I want to pop the ThreadContext more than once I do:

ThreadContext.pop();
ThreadContext.pop();
ThreadContext.pop();
ThreadContext.pop();

Instead I'd like to update some legacy code to:

ThreadContext.pop(4);

(I know, I know, I should update that old code to push()/clear())

Thoughts on adding pop(int)?

Gary

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Performance page for next release.

2017-03-03 Thread Gary Gregory
I think we should keep the current doc pages on the site perhaps under a
different heading. This would be interesting for people who cannot keep up
with the latest.

Gary

On Fri, Mar 3, 2017 at 1:20 PM, Remko Popma  wrote:

> Yes but only the JMH benchmarks. Is that acceptable?
>
> The latency tests and the non-JMH Async Logger tests are too involved...
>
> One thing to bear in mind, we carefully documented the versions of the
> libraries we compared against with our benchmark results. The fact that
> newer versions of these libraries are now available does not invalidate
> those results. It just means that our performance page is not up to date
> with the latest version. We can try to stay up to date but in my opinion
> it's okay to let some time elapse if we're busy with other things.
>
> Anyway, if just the JMH tests are ok, I'll try to do this in the next
> month.
>
> Remko
>
> Sent from my iPhone
>
> > On Mar 3, 2017, at 17:24, Ralph Goers 
> wrote:
> >
> > Remko,
> >
> > Would it be possible for you to update the performance page for the next
> release? I am uncomfortable with some of the results because I know they
> have changed since 2.6.
> >
> > Ralph
> >
> > -
> > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
> > For additional commands, e-mail: log4j-dev-h...@logging.apache.org
> >
>
> -
> To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
> For additional commands, e-mail: log4j-dev-h...@logging.apache.org
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[jira] [Commented] (LOG4J2-1834) Handle when LogEvent.getLoggerName() returns null properly

2017-03-03 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894007#comment-15894007
 ] 

Gary Gregory commented on LOG4J2-1834:
--

Not sure, the Javadoc for the method says {{null}} is an expected value though.

> Handle when LogEvent.getLoggerName() returns null properly
> --
>
> Key: LOG4J2-1834
> URL: https://issues.apache.org/jira/browse/LOG4J2-1834
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8.1
>Reporter: Mikael Ståldal
>
> * KafkaAppender
> * LoggerNameLevelRewritePolicy
> * LoggerPatternConverter



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-03-01 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891505#comment-15891505
 ] 

Gary Gregory commented on LOG4J2-1820:
--

The bottom line is that we use GitHub as a read-only mirror for now as most 
Apache projects do. If there is some git command line incantation to use with 
the patch URL, please do post it here so we can document this someplace.

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
>Assignee: Gary Gregory
> Fix For: 2.8.2
>
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch, 
> 0002-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-03-01 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891172#comment-15891172
 ] 

Gary Gregory commented on LOG4J2-1820:
--

Yes, I just got the patch from the URL, copied it to the clipboard and applied 
the patch in Eclipse (EGit).

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
>Assignee: Gary Gregory
> Fix For: 2.8.2
>
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch, 
> 0002-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Resolved] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-03-01 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory resolved LOG4J2-1820.
--
   Resolution: Fixed
 Assignee: Gary Gregory
Fix Version/s: 2.8.2

Please verify and close.

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
>Assignee: Gary Gregory
> Fix For: 2.8.2
>
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch, 
> 0002-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: [VOTE] Release Log4j 2.8.1-rc1

2017-03-01 Thread Gary Gregory
I land at AMS on March 5 9 AM. Almost!

Gary

On Tue, Feb 28, 2017 at 11:28 PM, Remko Popma <remko.po...@gmail.com> wrote:

>
>
> On Wed, Mar 1, 2017 at 4:07 AM, Gary Gregory <garydgreg...@gmail.com>
> wrote:
>
>> How long are you in Amsterdam? I might be in Dordrecht (1 hour by train
>> IIRC) next week for work.
>>
>
> We are flying back to Tokyo on the afternoon of Saturday the 4th.
> It would be fun to meet in person! Are you in Europe now?
>
>
>>
>> Gary
>>
>> On Mon, Feb 27, 2017 at 11:36 PM, Remko Popma <remko.po...@gmail.com>
>> wrote:
>>
>>> FYI I won't be able to start reviewing until Wednesday (likely evening
>>> Amsterdam time).
>>>
>>> On Mon, Feb 27, 2017 at 3:09 Ralph Goers <ralph.go...@dslextreme.com>
>>> wrote:
>>>
>>>> This is a vote to release Log4j 2.8.1 the next version of the Log4j 2
>>>> project.
>>>>
>>>> Please download, test, and cast your votes on the log4j developers list.
>>>> [] +1, release the artifacts
>>>> [] -1, don't release because...
>>>>
>>>> The vote will remain open for 72 hours (or more if required). All
>>>> votes are welcome and we encourage everyone to test the release, but only
>>>> Logging PMC votes are “officially” counted. As always, at least 3 +1 votes
>>>> and more positive than negative votes are required.
>>>>
>>>> Changes in this version include:
>>>>
>>>> <https://github.com/apache/logging-log4j2/blob/fae030ae021790d3127eb5d273141c2ecd1f82e5/RELEASE-NOTES.md#new-features>New
>>>> Features
>>>>
>>>>- LOG4J2-1823 <https://issues.apache.org/jira/browse/LOG4J2-1823>:
>>>>Remove deprecation on MessageSupplier lambda functions in Logger API.
>>>>- LOG4J2-1807 <https://issues.apache.org/jira/browse/LOG4J2-1807>:
>>>>[core] Add and implement LogEvent.toImmutable().
>>>>
>>>>
>>>> <https://github.com/apache/logging-log4j2/blob/fae030ae021790d3127eb5d273141c2ecd1f82e5/RELEASE-NOTES.md#fixed-bugs>Fixed
>>>> Bugs
>>>>
>>>>- LOG4J2-1804 <https://issues.apache.org/jira/browse/LOG4J2-1804>:
>>>>Allow %i in file pattern to be preceded with characters other than just
>>>>'-'. Thanks to Pierrick Hymbert.
>>>>- LOG4J2-1816 <https://issues.apache.org/jira/browse/LOG4J2-1816>:
>>>>Change minOccur to minOccurs in Log4j-config.xsd. Thanks to 
>>>> shubhankar1100.
>>>>- LOG4J2-1803 <https://issues.apache.org/jira/browse/LOG4J2-1803>:
>>>>Fix Maven POM to ensure JMH generated classes in log4j-perf are 
>>>> included in
>>>>benchmarks jar.
>>>>- LOG4J2-1800 <https://issues.apache.org/jira/browse/LOG4J2-1800>:
>>>>Report errors when sending to Kafka when using syncSend=false. Thanks to
>>>>Vincent Tieleman.
>>>>- LOG4J2-1805 <https://issues.apache.org/jira/browse/LOG4J2-1805>:
>>>>Fixed rare race condition in FixedDateFormat, made
>>>>FixedDateFormat::millisSinceMidnight method public.
>>>>- LOG4J2-1799 <https://issues.apache.org/jira/browse/LOG4J2-1799>:
>>>>Fixed bug in PropertiesUtil::getCharsetProperty that caused
>>>>UnsupportedCharsetException for ConsoleAppender. Thanks to Eduard
>>>>Gizatullin.
>>>>- LOG4J2-1806 <https://issues.apache.org/jira/browse/LOG4J2-1806>:
>>>>Fix Javadoc for DefaultRolloverStrategy::purgeAscending Thanks to
>>>>challarao.
>>>>- LOG4J2-1818 <https://issues.apache.org/jira/browse/LOG4J2-1818>:
>>>>Fix rollover to work when filePattern contains no directory components.
>>>>Thanks to xkr47.
>>>>
>>>>
>>>> <https://github.com/apache/logging-log4j2/blob/fae030ae021790d3127eb5d273141c2ecd1f82e5/RELEASE-NOTES.md#changes>
>>>> Changes
>>>>
>>>>- LOG4J2-1822 <https://issues.apache.org/jira/browse/LOG4J2-1822>:
>>>>Update SLF4J to 1.7.24.
>>>>- LOG4J2-1812 <https://issues.apache.org/jira/browse/LOG4J2-1812>:
>>>>Improved error message when log4j 2 configuration file not found.
>>>>- LOG4J2-1810 <https://issues.apache.org/jira/browse/LOG4J2-1810>:
>>>>Update to use Logback 1.1.10 and then Logback 1.2 for tests.
>>>>  

[jira] [Commented] (LOG4J2-1831) NullPointerException in HtmlLayout

2017-03-01 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890872#comment-15890872
 ] 

Gary Gregory commented on LOG4J2-1831:
--

I can see the problem and it's simple to fix. There might be other places in 
log4j in general where 
{{org.apache.logging.log4j.core.LogEvent.getLoggerName()}} returns {{null}} and 
causes problems.

> NullPointerException in HtmlLayout
> --
>
> Key: LOG4J2-1831
> URL: https://issues.apache.org/jira/browse/LOG4J2-1831
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Layouts
>Affects Versions: 2.8
>Reporter: Edward Serebrinskiy
> Fix For: 2.8.2
>
>
> Got following NullPointerException by using SMTP appender.
> {code}
> AsyncLogger error handling event seq=233, value='[ERROR calling class 
> org.apache.logging.log4j.core.async.RingBufferLogEvent.toString(): 
> java.lang.NullPointerException]':
> org.apache.logging.log4j.core.appender.AppenderLoggingException: An exception 
> occurred processing Appender Mail
>   at 
> org.apache.logging.log4j.core.appender.DefaultErrorHandler.error(DefaultErrorHandler.java:75)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.handleAppenderError(AppenderControl.java:165)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:158)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:129)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:120)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:84)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:448)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:433)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:417)
>   at 
> org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:79)
>   at 
> org.apache.logging.log4j.core.async.AsyncLogger.actualAsyncLog(AsyncLogger.java:337)
>   at 
> org.apache.logging.log4j.core.async.RingBufferLogEvent.execute(RingBufferLogEvent.java:156)
>   at 
> org.apache.logging.log4j.core.async.RingBufferLogEventHandler.onEvent(RingBufferLogEventHandler.java:45)
>   at 
> org.apache.logging.log4j.core.async.RingBufferLogEventHandler.onEvent(RingBufferLogEventHandler.java:29)
>   at 
> com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:129)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: org.apache.logging.log4j.LoggingException: Error occurred while 
> sending email
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.sendEvents(SmtpManager.java:175)
>   at 
> org.apache.logging.log4j.core.appender.SmtpAppender.append(SmtpAppender.java:181)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
>   ... 15 more
> Caused by: java.lang.NullPointerException
>   at 
> org.apache.logging.log4j.core.layout.HtmlLayout.toSerializable(HtmlLayout.java:170)
>   at 
> org.apache.logging.log4j.core.layout.HtmlLayout.toSerializable(HtmlLayout.java:50)
>   at 
> org.apache.logging.log4j.core.layout.AbstractStringLayout.toByteArray(AbstractStringLayout.java:301)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.writeBuffer(SmtpManager.java:204)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.writeContent(SmtpManager.java:190)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.formatContentToBytes(SmtpManager.java:182)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.sendEvents(SmtpManager.java:163)
>   ... 17 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Resolved] (LOG4J2-1831) NullPointerException in HtmlLayout

2017-03-01 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory resolved LOG4J2-1831.
--
   Resolution: Fixed
 Assignee: Gary Gregory
Fix Version/s: 2.8.2

Please verify and close.

> NullPointerException in HtmlLayout
> --
>
> Key: LOG4J2-1831
> URL: https://issues.apache.org/jira/browse/LOG4J2-1831
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Layouts
>Affects Versions: 2.8
>Reporter: Edward Serebrinskiy
>    Assignee: Gary Gregory
> Fix For: 2.8.2
>
>
> Got following NullPointerException by using SMTP appender.
> {code}
> AsyncLogger error handling event seq=233, value='[ERROR calling class 
> org.apache.logging.log4j.core.async.RingBufferLogEvent.toString(): 
> java.lang.NullPointerException]':
> org.apache.logging.log4j.core.appender.AppenderLoggingException: An exception 
> occurred processing Appender Mail
>   at 
> org.apache.logging.log4j.core.appender.DefaultErrorHandler.error(DefaultErrorHandler.java:75)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.handleAppenderError(AppenderControl.java:165)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:158)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:129)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:120)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:84)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:448)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:433)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:417)
>   at 
> org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:79)
>   at 
> org.apache.logging.log4j.core.async.AsyncLogger.actualAsyncLog(AsyncLogger.java:337)
>   at 
> org.apache.logging.log4j.core.async.RingBufferLogEvent.execute(RingBufferLogEvent.java:156)
>   at 
> org.apache.logging.log4j.core.async.RingBufferLogEventHandler.onEvent(RingBufferLogEventHandler.java:45)
>   at 
> org.apache.logging.log4j.core.async.RingBufferLogEventHandler.onEvent(RingBufferLogEventHandler.java:29)
>   at 
> com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:129)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: org.apache.logging.log4j.LoggingException: Error occurred while 
> sending email
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.sendEvents(SmtpManager.java:175)
>   at 
> org.apache.logging.log4j.core.appender.SmtpAppender.append(SmtpAppender.java:181)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
>   ... 15 more
> Caused by: java.lang.NullPointerException
>   at 
> org.apache.logging.log4j.core.layout.HtmlLayout.toSerializable(HtmlLayout.java:170)
>   at 
> org.apache.logging.log4j.core.layout.HtmlLayout.toSerializable(HtmlLayout.java:50)
>   at 
> org.apache.logging.log4j.core.layout.AbstractStringLayout.toByteArray(AbstractStringLayout.java:301)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.writeBuffer(SmtpManager.java:204)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.writeContent(SmtpManager.java:190)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.formatContentToBytes(SmtpManager.java:182)
>   at 
> org.apache.logging.log4j.core.net.SmtpManager.sendEvents(SmtpManager.java:163)
>   ... 17 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: [VOTE] Release Log4j 2.8.1-rc1

2017-02-28 Thread Gary Gregory
+1

>From src zip distribution: ASC, MD4, SHA1 OK.

Following BUILDING.md.

RAT check OK.
CLIRR check OK on log4j-api.

FAILS: mvn clean install

PASSES: mvn clean install -pl !log4j-nosql
(this is a known issue)

PASSES: mvn site

Using

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: C:\Java\apache-maven-3.3.9\bin\..
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

Gary


On Sun, Feb 26, 2017 at 6:09 PM, Ralph Goers 
wrote:

> This is a vote to release Log4j 2.8.1 the next version of the Log4j 2
> project.
>
> Please download, test, and cast your votes on the log4j developers list.
> [] +1, release the artifacts
> [] -1, don't release because...
>
> The vote will remain open for 72 hours (or more if required). All
> votes are welcome and we encourage everyone to test the release, but only
> Logging PMC votes are “officially” counted. As always, at least 3 +1 votes
> and more positive than negative votes are required.
>
> Changes in this version include:
>
> New
> Features
>
>- LOG4J2-1823 :
>Remove deprecation on MessageSupplier lambda functions in Logger API.
>- LOG4J2-1807 :
>[core] Add and implement LogEvent.toImmutable().
>
>
> Fixed
> Bugs
>
>- LOG4J2-1804 :
>Allow %i in file pattern to be preceded with characters other than just
>'-'. Thanks to Pierrick Hymbert.
>- LOG4J2-1816 :
>Change minOccur to minOccurs in Log4j-config.xsd. Thanks to shubhankar1100.
>- LOG4J2-1803 : Fix
>Maven POM to ensure JMH generated classes in log4j-perf are included in
>benchmarks jar.
>- LOG4J2-1800 :
>Report errors when sending to Kafka when using syncSend=false. Thanks to
>Vincent Tieleman.
>- LOG4J2-1805 :
>Fixed rare race condition in FixedDateFormat, made 
> FixedDateFormat::millisSinceMidnight
>method public.
>- LOG4J2-1799 :
>Fixed bug in PropertiesUtil::getCharsetProperty that caused
>UnsupportedCharsetException for ConsoleAppender. Thanks to Eduard
>Gizatullin.
>- LOG4J2-1806 : Fix
>Javadoc for DefaultRolloverStrategy::purgeAscending Thanks to
>challarao.
>- LOG4J2-1818 : Fix
>rollover to work when filePattern contains no directory components. Thanks
>to xkr47.
>
>
> 
> Changes
>
>- LOG4J2-1822 :
>Update SLF4J to 1.7.24.
>- LOG4J2-1812 :
>Improved error message when log4j 2 configuration file not found.
>- LOG4J2-1810 :
>Update to use Logback 1.1.10 and then Logback 1.2 for tests.
>- LOG4J2-1819 :
>Update Jackson from 2.8.5 to 2.8.6.
>
> Tag:
>
> a)  for a new copy do "git clone 
> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then "git 
> checkout tags/log4j-2.8.1-rc1”
> b) for an existing working copy to “git pull” and then “git checkout 
> tags/log4j-2.8.1-rc1”
>
> Web Site:  
> http://rgoers.github.io/log4j2-site/index.html
>
> Artifacts: 
> https://repository.apache.org/content/repositories/orgapachelogging-1025
>
> You may download all the artifacts by executing:
>
> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate 
> https://repository.apache.org/content/repositories/orgapachelogging-1025/org/apache/logging/log4j/
>
> Ralph
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition

Re: [VOTE] Release Log4j 2.8.1-rc1

2017-02-28 Thread Gary Gregory
How long are you in Amsterdam? I might be in Dordrecht (1 hour by train
IIRC) next week for work.

Gary

On Mon, Feb 27, 2017 at 11:36 PM, Remko Popma  wrote:

> FYI I won't be able to start reviewing until Wednesday (likely evening
> Amsterdam time).
>
> On Mon, Feb 27, 2017 at 3:09 Ralph Goers 
> wrote:
>
>> This is a vote to release Log4j 2.8.1 the next version of the Log4j 2
>> project.
>>
>> Please download, test, and cast your votes on the log4j developers list.
>> [] +1, release the artifacts
>> [] -1, don't release because...
>>
>> The vote will remain open for 72 hours (or more if required). All
>> votes are welcome and we encourage everyone to test the release, but only
>> Logging PMC votes are “officially” counted. As always, at least 3 +1 votes
>> and more positive than negative votes are required.
>>
>> Changes in this version include:
>>
>> New
>> Features
>>
>>- LOG4J2-1823 :
>>Remove deprecation on MessageSupplier lambda functions in Logger API.
>>- LOG4J2-1807 :
>>[core] Add and implement LogEvent.toImmutable().
>>
>>
>> Fixed
>> Bugs
>>
>>- LOG4J2-1804 :
>>Allow %i in file pattern to be preceded with characters other than just
>>'-'. Thanks to Pierrick Hymbert.
>>- LOG4J2-1816 :
>>Change minOccur to minOccurs in Log4j-config.xsd. Thanks to 
>> shubhankar1100.
>>- LOG4J2-1803 :
>>Fix Maven POM to ensure JMH generated classes in log4j-perf are included 
>> in
>>benchmarks jar.
>>- LOG4J2-1800 :
>>Report errors when sending to Kafka when using syncSend=false. Thanks to
>>Vincent Tieleman.
>>- LOG4J2-1805 :
>>Fixed rare race condition in FixedDateFormat, made 
>> FixedDateFormat::millisSinceMidnight
>>method public.
>>- LOG4J2-1799 :
>>Fixed bug in PropertiesUtil::getCharsetProperty that caused
>>UnsupportedCharsetException for ConsoleAppender. Thanks to Eduard
>>Gizatullin.
>>- LOG4J2-1806 :
>>Fix Javadoc for DefaultRolloverStrategy::purgeAscending Thanks to
>>challarao.
>>- LOG4J2-1818 :
>>Fix rollover to work when filePattern contains no directory components.
>>Thanks to xkr47.
>>
>>
>> 
>> Changes
>>
>>- LOG4J2-1822 :
>>Update SLF4J to 1.7.24.
>>- LOG4J2-1812 :
>>Improved error message when log4j 2 configuration file not found.
>>- LOG4J2-1810 :
>>Update to use Logback 1.1.10 and then Logback 1.2 for tests.
>>- LOG4J2-1819 :
>>Update Jackson from 2.8.5 to 2.8.6.
>>
>> Tag:
>>
>> a)  for a new copy do "git clone 
>> https://git-wip-us.apache.org/repos/asf/logging-log4j2.git; and then "git 
>> checkout tags/log4j-2.8.1-rc1”
>> b) for an existing working copy to “git pull” and then “git checkout 
>> tags/log4j-2.8.1-rc1”
>>
>> Web Site:  
>> http://rgoers.github.io/log4j2-site/index.html
>>
>> Artifacts: 
>> https://repository.apache.org/content/repositories/orgapachelogging-1025
>>
>> You may download all the artifacts by executing:
>>
>> wget -e robots=off --cut-dirs=7 -nH -r -p -np --no-check-certificate 
>> https://repository.apache.org/content/repositories/orgapachelogging-1025/org/apache/logging/log4j/
>>
>> Ralph
>>
>>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action

[jira] [Commented] (LOG4J2-1828) add support for prudent mode in Log4j 2

2017-02-28 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888682#comment-15888682
 ] 

Gary Gregory commented on LOG4J2-1828:
--

Is this just having a "lock" mode on/off?

> add support for prudent mode in Log4j 2
> ---
>
> Key: LOG4J2-1828
> URL: https://issues.apache.org/jira/browse/LOG4J2-1828
> Project: Log4j 2
>  Issue Type: Improvement
>Reporter: Erik Weathers
>Priority: Minor
>
> As discussed in LOG4J2-174, there is a feature from logback called ["prudent 
> mode"|https://logback.qos.ch/manual/appenders.html#prudent] which is not 
> available in Log4j 2.  This feature allows multiple JVMs to write to the same 
> log file at the same time, albeit with a [few 
> restrictions|https://logback.qos.ch/manual/appenders.html#prudentWithRolling].
> Please see LOG4J2-174 for a discussion on some alternative approaches you 
> might consider if you want prudent mode but this ticket isn't yet fixed in 
> the version of Log4j 2 you are using.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1807) [core] Add and implement LogEvent.toImmutable()

2017-02-25 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884304#comment-15884304
 ] 

Gary Gregory commented on LOG4J2-1807:
--

Sounds reasonable.

> [core] Add and implement LogEvent.toImmutable()
> ---
>
> Key: LOG4J2-1807
> URL: https://issues.apache.org/jira/browse/LOG4J2-1807
> Project: Log4j 2
>  Issue Type: New Feature
>Affects Versions: 2.8.1
>    Reporter: Gary Gregory
>Assignee: Gary Gregory
> Attachments: logging-log4j2.patch
>
>
> [core] Add and implement LogEvent.asImmutable()
> {code:java}
> /**
>  * Returns an immutable version of this log event, which MAY BE a copy of 
> this event.
>  *  
>  * @return an immutable version of this log event
>  */
> LogEvent asImmutable();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: Undeprecating MessageSupplier

2017-02-24 Thread Gary Gregory
Makes sense. We should make we Javadoc all that.

On Feb 24, 2017 10:07 AM, "Matt Sicker"  wrote:

> In log4j-api, the interface MessageSupplier has been deprecated ever since
> we realized that we didn't need it and could just use Supplier for
> lambda support. However, now that I've actually tried to use this in my own
> Java 8 project, I noticed that by default, the following will call the
> deprecated method:
>
> logger.info(() -> new MapMessage(convertForLogging(fields)));
>
> However, if I cast it, it'll call the non-deprecated form:
>
> logger.info((Supplier) () -> new MapMessage(convertForLogging(
> fields)));
>
> This isn't ideal. I propose we simply undeprecate MessageSupplier as it's
> the more specific form that javac will use by default anyways. We should
> note that it won't be available in a hypothetical 3.0 API, but I'd imagine
> that hypothetical API would just use Java 8's Supplier functional interface
> instead as well.
>
> --
> Matt Sicker 
>


[jira] [Commented] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-02-24 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883407#comment-15883407
 ] 

Gary Gregory commented on LOG4J2-1820:
--

When I apply the patch I get this failure:

Tests in error:
  
ThrowableProxyTest.testLogStackTraceWithClassLoaderThatWithCauseSecurityException:179
 ╗ NoSuchAlgorithm

I ran:

mvn clean install -pl !log4j-nosql

I am on Windows and Java 7:

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 
2015-11-10T08:41:47-08:00)
Maven home: C:\Java\apache-maven-3.3.9\bin\..
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"


> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: Roadmap for 2.8.1

2017-02-24 Thread Gary Gregory
I think we can do 2.8.1 with our current bug fixes. Moving modules around
feels like a 2.9 item to me but that's just me. I really like the idea of
making bug fixes available ASAP. The only issue I see that fixing now is
the null classloader issue for which we have a patch but it does not work
for me (see JIRA).

Gary

On Thu, Feb 23, 2017 at 8:07 PM, Matt Sicker  wrote:

> I'm hoping we can get this released soon as we have some bugfixes and such
> ready to go. I also want to move forward with 2.9 changes but don't really
> want to deal with creating a 2.9 branch or forking master into a 2.8
> branch. Let's go over anything left to do for 2.8.1:
>
> * Integrated log4j-api-scala website into main site
> * Remove scala modules from logging-log4j2 repo
> * Release scala modules from logging-log4j-scala repo (presumably shortly
> after releasing 2.8.1 of core?)
>
> I also have ideas on what we can shoot for in 2.9 and beyond, but that's
> for another day. I think getting everything working properly in Java 9
> would be a good thing to start doing soon so we can figure out if our APIs
> will still work properly in the future or if we need to break backwards
> compatibility. Although, multi-jar support could help in migrating the API
> if needed for 9+, though that would be a rather unorthodox abuse of the
> feature.
>
> --
> Matt Sicker 
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition



JUnit in Action, Second Edition



Spring Batch in Action


Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[jira] [Commented] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-02-22 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879767#comment-15879767
 ] 

Gary Gregory commented on LOG4J2-1820:
--

[~jvz]: Do you feel we have consensus that [~jasontedor]'s patch is OK?

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-02-21 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877459#comment-15877459
 ] 

Gary Gregory commented on LOG4J2-1820:
--

More generally, how can we parameterize the unit tests to run a second time 
(optionally I suppose) with a security manager? It seems like we need something 
more than a JUnit Rule.

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-02-21 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877457#comment-15877457
 ] 

Gary Gregory commented on LOG4J2-1820:
--

Hi All,

It seems that we do not need to worry about cases like 
{{org.apache.logging.log4j.core.config.xml.XmlConfiguration.XmlConfiguration(LoggerContext,
 ConfigurationSource):152}}

But what about 
{{org.apache.logging.log4j.core.selector.ClassLoaderContextSelector.getContext(String,
 ClassLoader, boolean, URI):74}}, should that go through LoaderUtils or be in a 
try/catch?

Could 
{{org.apache.logging.log4j.web.Log4jWebInitializerImpl.initializeJndi(String)}} 
be trouble then?

Gary

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-02-21 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877426#comment-15877426
 ] 

Gary Gregory commented on LOG4J2-1820:
--

What about the other 31 call sites we have to {{Class.getClassLoader()}}? 
Wouldn't these need special care as well? Should the try/catch be abstracted in 
a utility method?

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Comment Edited] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-02-21 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877426#comment-15877426
 ] 

Gary Gregory edited comment on LOG4J2-1820 at 2/22/17 3:53 AM:
---

What about the other 31 call sites we have to {{Class.getClassLoader()}}? 
Wouldn't these need special care as well? Should the try/catch be abstracted in 
a utility method? (I'm not separating test from main in the 31 count, it's just 
what Eclipse reports.)


was (Author: garydgregory):
What about the other 31 call sites we have to {{Class.getClassLoader()}}? 
Wouldn't these need special care as well? Should the try/catch be abstracted in 
a utility method?

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1820) Log4j 2.8 can lose exceptions when a security manager is present

2017-02-21 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877130#comment-15877130
 ] 

Gary Gregory commented on LOG4J2-1820:
--

I'll try to take a look tonight, Does a full build pass? Like 'mvn clean 
install'?

> Log4j 2.8 can lose exceptions when a security manager is present
> 
>
> Key: LOG4J2-1820
> URL: https://issues.apache.org/jira/browse/LOG4J2-1820
> Project: Log4j 2
>  Issue Type: Bug
>Affects Versions: 2.8
>Reporter: Jason Tedor
> Attachments: 
> 0001-Handle-security-exception-on-getting-class-loader.patch
>
>
> When Log4j is rendering an exception, it can attempt to access a class loader 
> that it does not have permissions to access when a security manager is 
> present.
> I have a patch and a failing test case for this; I will submit it shortly.
> This is similar to LOG4J2-1560.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-548) Log4j 2.0 with JBoss EAP 6.2

2017-02-17 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872725#comment-15872725
 ] 

Gary Gregory commented on LOG4J2-548:
-

Thank you for your patch Eric. 

Did you try a full build to make sure all the unit tests pass? 'mvn clean 
install'

Thank you,
Gary

> Log4j 2.0 with  JBoss EAP 6.2
> -
>
> Key: LOG4J2-548
> URL: https://issues.apache.org/jira/browse/LOG4J2-548
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.0-rc1, 2.1
> Environment: EJB 3.1 , JBoss EAP 6.2 , Windows 7 , Eclipse Kepler 
>Reporter: Shehata
>Assignee: Ralph Goers
> Attachments: LOG4J2-548 - evictors.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When trying to use log4j 2.0-rc1 with EJB3.1 i got Error Message:
> "ERROR StatusLogger Could not search jar file 
> 'jboss-eap-6.2\standalone\deployments\Log4J2Ear.ear\lib\log4j-core-2.0-rc1.jar\org\apache\logging\log4j\core'
>  for classes matching criteria: annotated with @Plugin file not found"
> after debugging the application found that the problem is located in :
> org.apache.logging.log4j.core.config.plugins.ResolverUtil
> method: findInPackage --> line number 247
> the protocol used in the jar is vfs not vfszip



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Commented] (LOG4J2-1807) [core] Add and implement LogEvent.toImmutable()

2017-02-17 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872252#comment-15872252
 ] 

Gary Gregory commented on LOG4J2-1807:
--

I agree that it is not perfect. What do you suggest?

> [core] Add and implement LogEvent.toImmutable()
> ---
>
> Key: LOG4J2-1807
> URL: https://issues.apache.org/jira/browse/LOG4J2-1807
> Project: Log4j 2
>  Issue Type: New Feature
>Affects Versions: 2.8.1
>    Reporter: Gary Gregory
>Assignee: Gary Gregory
> Attachments: logging-log4j2.patch
>
>
> [core] Add and implement LogEvent.asImmutable()
> {code:java}
> /**
>  * Returns an immutable version of this log event, which MAY BE a copy of 
> this event.
>  *  
>  * @return an immutable version of this log event
>  */
> LogEvent asImmutable();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Closed] (LOG4J2-1819) Update Jackson from 2.8.5 to 2.8.6

2017-02-17 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1819.

Resolution: Fixed

In Git master.

> Update Jackson from 2.8.5 to 2.8.6
> --
>
> Key: LOG4J2-1819
> URL: https://issues.apache.org/jira/browse/LOG4J2-1819
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.8.1
>
>
> Update Jackson from 2.8.5 to 2.8.6.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Reopened] (LOG4J2-1819) Update Jackson from 2.8.5 to 2.8.6

2017-02-17 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory reopened LOG4J2-1819:
--

> Update Jackson from 2.8.5 to 2.8.6
> --
>
> Key: LOG4J2-1819
> URL: https://issues.apache.org/jira/browse/LOG4J2-1819
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.8.1
>
>
> Update Jackson from 2.8.5 to 2.8.6.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1819) Update Jackson from 2.8.5 to 2.8.6

2017-02-17 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1819:
-
Affects Version/s: (was: 2.7)
   2.8

> Update Jackson from 2.8.5 to 2.8.6
> --
>
> Key: LOG4J2-1819
> URL: https://issues.apache.org/jira/browse/LOG4J2-1819
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.8.1
>
>
> Update Jackson from 2.8.5 to 2.8.6.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Closed] (LOG4J2-1819) Update Jackson from 2.8.5 to 2.8.6

2017-02-17 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1819.

   Resolution: Fixed
Fix Version/s: 2.8.1

> Update Jackson from 2.8.5 to 2.8.6
> --
>
> Key: LOG4J2-1819
> URL: https://issues.apache.org/jira/browse/LOG4J2-1819
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.8
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.8.1
>
>
> Update Jackson from 2.8.5 to 2.8.6.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Created] (LOG4J2-1819) Update Jackson from 2.8.5 to 2.8.6

2017-02-17 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1819:


 Summary: Update Jackson from 2.8.5 to 2.8.6
 Key: LOG4J2-1819
 URL: https://issues.apache.org/jira/browse/LOG4J2-1819
 Project: Log4j 2
  Issue Type: Improvement
  Components: Appenders
Affects Versions: 2.7
Reporter: Gary Gregory
Assignee: Gary Gregory


Update Jackson from 2.8.5 to 2.8.6.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Resolved] (LOG4J2-1807) [core] Add and implement LogEvent.toImmutable()

2017-02-16 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory resolved LOG4J2-1807.
--
Resolution: Fixed

In git master. 

[~rem...@yahoo.com], would you care to review?

Gary

> [core] Add and implement LogEvent.toImmutable()
> ---
>
> Key: LOG4J2-1807
> URL: https://issues.apache.org/jira/browse/LOG4J2-1807
> Project: Log4j 2
>  Issue Type: New Feature
>Affects Versions: 2.8.1
>    Reporter: Gary Gregory
>Assignee: Gary Gregory
> Attachments: logging-log4j2.patch
>
>
> [core] Add and implement LogEvent.asImmutable()
> {code:java}
> /**
>  * Returns an immutable version of this log event, which MAY BE a copy of 
> this event.
>  *  
>  * @return an immutable version of this log event
>  */
> LogEvent asImmutable();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1807) [core] Add and implement LogEvent.toImmutable()

2017-02-16 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1807:
-
Affects Version/s: 2.8.1

> [core] Add and implement LogEvent.toImmutable()
> ---
>
> Key: LOG4J2-1807
> URL: https://issues.apache.org/jira/browse/LOG4J2-1807
> Project: Log4j 2
>  Issue Type: New Feature
>Affects Versions: 2.8.1
>    Reporter: Gary Gregory
>Assignee: Gary Gregory
> Attachments: logging-log4j2.patch
>
>
> [core] Add and implement LogEvent.asImmutable()
> {code:java}
> /**
>  * Returns an immutable version of this log event, which MAY BE a copy of 
> this event.
>  *  
>  * @return an immutable version of this log event
>  */
> LogEvent asImmutable();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Resolved] (LOG4J2-1818) Fix rollover to work when filePattern contains no directory components

2017-02-16 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory resolved LOG4J2-1818.
--
   Resolution: Fixed
Fix Version/s: 2.8.1

Fixed in Git master.

> Fix rollover to work when filePattern contains no directory components
> --
>
> Key: LOG4J2-1818
> URL: https://issues.apache.org/jira/browse/LOG4J2-1818
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders
>Affects Versions: 2.8
>Reporter: Gary Gregory
>    Assignee: Gary Gregory
> Fix For: 2.8.1
>
>
> See https://github.com/apache/logging-log4j2/pull/59
> Prior to this patch, the following config threw NPE at parent.mkdirs() 
> because parent was null when using e.g.:
> {code:xml}
>   fileName="foo.log"
>  filePattern="foo-%d{-MM-dd}-%i.log.gz"
>  immediateFlush="false">
> {code}
> while this config did not:
> {code:xml}
>   fileName="foo.log"
>  filePattern="./foo-%d{-MM-dd}-%i.log.gz"
>  immediateFlush="false">
> {code}
> e.g. by adding ./ in front of the filePattern value.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Created] (LOG4J2-1818) Fix rollover to work when filePattern contains no directory components

2017-02-16 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1818:


 Summary: Fix rollover to work when filePattern contains no 
directory components
 Key: LOG4J2-1818
 URL: https://issues.apache.org/jira/browse/LOG4J2-1818
 Project: Log4j 2
  Issue Type: Bug
  Components: Appenders
Affects Versions: 2.8
Reporter: Gary Gregory
Assignee: Gary Gregory


See https://github.com/apache/logging-log4j2/pull/59

Prior to this patch, the following config threw NPE at parent.mkdirs() because 
parent was null when using e.g.:

{code:xml}

{code}

while this config did not:

{code:xml}

{code}

e.g. by adding ./ in front of the filePattern value.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: RollingAppenderSizeTest failures

2017-02-14 Thread Gary Gregory
What about CassandraCQLUnit (see
https://groups.google.com/forum/#!topic/cassandra-unit-users/eeDycBfMfng)

?

Gary

On Fri, Feb 3, 2017 at 12:50 PM, Matt Sicker <boa...@gmail.com> wrote:

> If embedded Cassandra doesn't work in Windows, then a JUnit
> Assume.assumeFalse(isWindows()) could be added to the beginning of the
> test. We have an isWindows() method somewhere in log4j-core or -api.
>
> On 3 February 2017 at 14:27, Apache <ralph.go...@dslextreme.com> wrote:
>
>> They almost always seem to be platform specific, and almost always
>> something to do with Windows. On the last one I find it odd that it
>> mentions cassandra-env.sh. Obviously a shell script won’t normally run on
>> windows, but I think I looked at that error several days ago and it seemed
>> like no shell script should be involved.
>>
>> Ralph
>>
>> On Feb 3, 2017, at 1:10 PM, Matt Sicker <boa...@gmail.com> wrote:
>>
>> That's strange. I never tested that integration test in Windows, so
>> perhaps it's platform-specific? Anyways, the equivalent Mongo integration
>> test is @Ignore'd due to requiring a running Mongo, and the Cassandra test
>> works similarly although it starts up Cassandra within the JVM for you.
>>
>> On 3 February 2017 at 13:10, Gary Gregory <garydgreg...@gmail.com> wrote:
>>
>>> And if I ignore THAT OSGi test, I then fail in nosql :-(
>>>
>>> [INFO] --- maven-failsafe-plugin:2.19.1:integration-test
>>> (integration-tests) @ log4j-nosql ---
>>>
>>> ---
>>>  T E S T S
>>> ---
>>> Running org.apache.logging.log4j.nosql.appender.cassandra.CassandraA
>>> ppenderIT
>>> ERROR StatusLogger No log4j2 configuration file found. Using default
>>> configuration: logging only errors to the console.
>>> 11:00:39.333 [Log4j2-TF-1-Cassandra-1] ERROR
>>> org.apache.cassandra.service.StartupChecks - cassandra.jmx.local.port
>>> missing from cassandra-env.sh, unable to start local JMX service.
>>> ERROR StatusLogger No log4j2 configuration file found. Using default
>>> configuration: logging only errors to the console.
>>>
>>> Results :
>>>
>>> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
>>>
>>> [INFO]
>>> [INFO] --- maven-failsafe-plugin:2.19.1:verify (verify) @ log4j-nosql
>>> ---
>>> [INFO] 
>>> 
>>> [INFO] Reactor Summary:
>>> [INFO]
>>> [INFO] Apache Log4j NoSQL . FAILURE [
>>> 27.242 s]
>>> [INFO] Apache Log4J Performance Tests . SKIPPED
>>> [INFO] Apache Log4j Streaming Interface ... SKIPPED
>>> [INFO] Apache Log4j JUL Adapter ... SKIPPED
>>> [INFO] Apache Log4j Liquibase Binding . SKIPPED
>>> [INFO] Apache Log4j Scala 2.10 wrapper for Log4j API .. SKIPPED
>>> [INFO] 
>>> 
>>> [INFO] BUILD FAILURE
>>> [INFO] 
>>> 
>>> [INFO] Total time: 29.063 s
>>> [INFO] Finished at: 2017-02-03T11:00:55-08:00
>>> [INFO] Final Memory: 49M/691M
>>> [INFO] 
>>> 
>>> [ERROR] Failed to execute goal 
>>> org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:verify
>>> (verify) on project log4j-nosql: There was a timeout or other error in the
>>> fork -> [Help 1]
>>> [ERROR]
>>> [ERROR] To see the full stack trace of the errors, re-run Maven with the
>>> -e switch.
>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>>> [ERROR]
>>> [ERROR] For more information about the errors and possible solutions,
>>> please read the following articles:
>>> [ERROR] [Help 1] http://cwiki.apache.org/conflu
>>> ence/display/MAVEN/MojoExecutionException
>>>
>>> Thoughts?
>>>
>>> Gary
>>>
>>> On Fri, Feb 3, 2017 at 10:06 AM, Gary Gregory <garydgreg...@gmail.com>
>>> wrote:
>>>
>>>> If I @Ignore that one test, then I get (mvn clean install):
>>>>
>>>> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.842
>>>> sec - in o

Re: RollingAppenderSizeTest failures

2017-02-14 Thread Gary Gregory
OK, the rolling test is fixed. Now, the OSGi module does not build.

Gary

On Tue, Feb 14, 2017 at 5:08 PM, Remko Popma <remko.po...@gmail.com> wrote:

> The new test failure (can't open zip) looks like a one-off...
>
> Sent from my iPhone
>
> On Feb 15, 2017, at 9:58, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> On Tue, Feb 14, 2017 at 3:22 PM, Apache <ralph.go...@dslextreme.com>
> wrote:
>
>> What problem before what?
>>
>> RollingAppenderSizeTest was failing because I was manually trying to
>> delete files instead of letting the Rule do it.
>>
>
> My mistake. I did not know that the issue was as simple as that.
>
> Gary
>
>
>>
>> Ralph
>>
>> On Feb 14, 2017, at 2:56 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
>>
>> Was the problem before that threads where not finishing normally on test
>> completion? Could this be the same kind of issue?
>>
>> Gary
>>
>> On Tue, Feb 14, 2017 at 1:28 PM, Apache <ralph.go...@dslextreme.com>
>> wrote:
>>
>>> I got a Windows 10 VM installed and was able to reproduce the problem
>>> and fix it. However, now the build is failing with
>>>
>>> Failed tests:
>>>   GcFreeAsynchronousLoggingTest.testNoAllocationDuringSteadyStateLogging:34
>>> Error opening zip file or JAR manifest missing :
>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-a
>>> llocation-instrumenter\java-allocation-instrumenter\3.0.1\ja
>>> va-allocation-instrumenter-3.0.1.jar
>>>  expected:<[FATAL o.a.l.l.c.GcFreeAsynchronousLoggingTest [main] value1
>>> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
>>> logged to the console]> but was:<[Error opening zip file or JAR manifest
>>> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-a
>>> llocation-instrumenter\java-allocation-instrumenter\3.0.1\ja
>>> va-allocation-instrumenter-3.0.1.jar]>
>>>   GcFreeMixedSyncAyncLoggingTest.testNoAllocationDuringSteadyStateLogging:30
>>> Error opening zip file or JAR manifest missing :
>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-a
>>> llocation-instrumenter\java-allocation-instrumenter\3.0.1\ja
>>> va-allocation-instrumenter-3.0.1.jar
>>>  expected:<[FATAL o.a.l.l.c.GcFreeMixedSyncAyncLoggingTest [main]
>>> value1 {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message
>>> is logged to the console]> but was:<[Error opening zip file or JAR manifest
>>> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-a
>>> llocation-instrumenter\java-allocation-instrumenter\3.0.1\ja
>>> va-allocation-instrumenter-3.0.1.jar]>
>>>   GcFreeSynchronousLoggingTest.testNoAllocationDuringSteadyStateLogging:30
>>> Error opening zip file or JAR manifest missing :
>>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-a
>>> llocation-instrumenter\java-allocation-instrumenter\3.0.1\ja
>>> va-allocation-instrumenter-3.0.1.jar
>>>  expected:<[FATAL o.a.l.l.c.GcFreeSynchronousLoggingTest [main] value1
>>> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
>>> logged to the console]> but was:<[Error opening zip file or JAR manifest
>>> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-a
>>> llocation-instrumenter\java-allocation-instrumenter\3.0.1\ja
>>> va-allocation-instrumenter-3.0.1.jar]>
>>>
>>> Ralph
>>>
>>> On Feb 13, 2017, at 12:13 PM, Apache <ralph.go...@dslextreme.com> wrote:
>>>
>>> No. I plan to figure out why it is breaking.
>>>
>>> Ralph
>>>
>>> On Feb 13, 2017, at 11:02 AM, Gary Gregory <garydgreg...@gmail.com>
>>> wrote:
>>>
>>> My hope was that Ralph would revert his commit that broke the build on
>>> Windows.
>>>
>>> Gary
>>>
>>> On Mon, Feb 13, 2017 at 10:01 AM, Gary Gregory <garydgreg...@gmail.com>
>>> wrote:
>>>
>>>> Maven just works as in on Windows. I have the Maven bin folder on my
>>>> PATH, that's it, it contains mvn.cmd.
>>>>
>>>> Gary
>>>>
>>>> On Mon, Feb 13, 2017 at 9:45 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>>
>>>>> Well, that's step one! My only Windows computer is for videogames, so
>>>>> I'm not really experienced with development in such an environment these
>>>>> days. If you can figure

Re: RollingAppenderSizeTest failures

2017-02-14 Thread Gary Gregory
On Tue, Feb 14, 2017 at 3:22 PM, Apache <ralph.go...@dslextreme.com> wrote:

> What problem before what?
>
> RollingAppenderSizeTest was failing because I was manually trying to
> delete files instead of letting the Rule do it.
>

My mistake. I did not know that the issue was as simple as that.

Gary


>
> Ralph
>
> On Feb 14, 2017, at 2:56 PM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Was the problem before that threads where not finishing normally on test
> completion? Could this be the same kind of issue?
>
> Gary
>
> On Tue, Feb 14, 2017 at 1:28 PM, Apache <ralph.go...@dslextreme.com>
> wrote:
>
>> I got a Windows 10 VM installed and was able to reproduce the problem and
>> fix it. However, now the build is failing with
>>
>> Failed tests:
>>   GcFreeAsynchronousLoggingTest.testNoAllocationDuringSteadyStateLogging:34
>> Error opening zip file or JAR manifest missing :
>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-
>> allocation-instrumenter\java-allocation-instrumenter\3.0.1\
>> java-allocation-instrumenter-3.0.1.jar
>>  expected:<[FATAL o.a.l.l.c.GcFreeAsynchronousLoggingTest [main] value1
>> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
>> logged to the console]> but was:<[Error opening zip file or JAR manifest
>> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-
>> allocation-instrumenter\java-allocation-instrumenter\3.0.1\
>> java-allocation-instrumenter-3.0.1.jar]>
>>   GcFreeMixedSyncAyncLoggingTest.testNoAllocationDuringSteadyStateLogging:30
>> Error opening zip file or JAR manifest missing :
>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-
>> allocation-instrumenter\java-allocation-instrumenter\3.0.1\
>> java-allocation-instrumenter-3.0.1.jar
>>  expected:<[FATAL o.a.l.l.c.GcFreeMixedSyncAyncLoggingTest [main] value1
>> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
>> logged to the console]> but was:<[Error opening zip file or JAR manifest
>> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-
>> allocation-instrumenter\java-allocation-instrumenter\3.0.1\
>> java-allocation-instrumenter-3.0.1.jar]>
>>   GcFreeSynchronousLoggingTest.testNoAllocationDuringSteadyStateLogging:30
>> Error opening zip file or JAR manifest missing :
>> C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-
>> allocation-instrumenter\java-allocation-instrumenter\3.0.1\
>> java-allocation-instrumenter-3.0.1.jar
>>  expected:<[FATAL o.a.l.l.c.GcFreeSynchronousLoggingTest [main] value1
>> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
>> logged to the console]> but was:<[Error opening zip file or JAR manifest
>> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\java-
>> allocation-instrumenter\java-allocation-instrumenter\3.0.1\
>> java-allocation-instrumenter-3.0.1.jar]>
>>
>> Ralph
>>
>> On Feb 13, 2017, at 12:13 PM, Apache <ralph.go...@dslextreme.com> wrote:
>>
>> No. I plan to figure out why it is breaking.
>>
>> Ralph
>>
>> On Feb 13, 2017, at 11:02 AM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>> My hope was that Ralph would revert his commit that broke the build on
>> Windows.
>>
>> Gary
>>
>> On Mon, Feb 13, 2017 at 10:01 AM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> Maven just works as in on Windows. I have the Maven bin folder on my
>>> PATH, that's it, it contains mvn.cmd.
>>>
>>> Gary
>>>
>>> On Mon, Feb 13, 2017 at 9:45 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>
>>>> Well, that's step one! My only Windows computer is for videogames, so
>>>> I'm not really experienced with development in such an environment these
>>>> days. If you can figure out how to get the mvnw.cmd script to work in
>>>> Windows, that'd be great.
>>>>
>>>> On 13 February 2017 at 11:26, Gary Gregory <garydgreg...@gmail.com>
>>>> wrote:
>>>>
>>>>> Thank you for setting that up Matt. I can see the same failures on
>>>>> https://builds.apache.org/job/Log4jWindows/ as I do locally.
>>>>>
>>>>> Gary
>>>>>
>>>>> On Sun, Feb 12, 2017 at 11:11 PM, Matt Sicker <boa...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Also, using a similar multi-config Jenkins job, we can set up JDK 7,
>>&

Re: RollingAppenderSizeTest failures

2017-02-14 Thread Gary Gregory
Was the problem before that threads where not finishing normally on test
completion? Could this be the same kind of issue?

Gary

On Tue, Feb 14, 2017 at 1:28 PM, Apache <ralph.go...@dslextreme.com> wrote:

> I got a Windows 10 VM installed and was able to reproduce the problem and
> fix it. However, now the build is failing with
>
> Failed tests:
>   GcFreeAsynchronousLoggingTest.testNoAllocationDuringSteadyStateLogging:34
> Error opening zip file or JAR manifest missing : C:\Users\Ralph%20Goers\.m2\
> repository\com\google\code\java-allocation-instrumenter\
> java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar
>  expected:<[FATAL o.a.l.l.c.GcFreeAsynchronousLoggingTest [main] value1
> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
> logged to the console]> but was:<[Error opening zip file or JAR manifest
> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\
> java-allocation-instrumenter\java-allocation-instrumenter\
> 3.0.1\java-allocation-instrumenter-3.0.1.jar]>
>   GcFreeMixedSyncAyncLoggingTest.testNoAllocationDuringSteadyStateLogging:30
> Error opening zip file or JAR manifest missing : C:\Users\Ralph%20Goers\.m2\
> repository\com\google\code\java-allocation-instrumenter\
> java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar
>  expected:<[FATAL o.a.l.l.c.GcFreeMixedSyncAyncLoggingTest [main] value1
> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
> logged to the console]> but was:<[Error opening zip file or JAR manifest
> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\
> java-allocation-instrumenter\java-allocation-instrumenter\
> 3.0.1\java-allocation-instrumenter-3.0.1.jar]>
>   GcFreeSynchronousLoggingTest.testNoAllocationDuringSteadyStateLogging:30
> Error opening zip file or JAR manifest missing : C:\Users\Ralph%20Goers\.m2\
> repository\com\google\code\java-allocation-instrumenter\
> java-allocation-instrumenter\3.0.1\java-allocation-instrumenter-3.0.1.jar
>  expected:<[FATAL o.a.l.l.c.GcFreeSynchronousLoggingTest [main] value1
> {aKey=value1, key2=value2, prop1=value1, prop2=value2} This message is
> logged to the console]> but was:<[Error opening zip file or JAR manifest
> missing : C:\Users\Ralph%20Goers\.m2\repository\com\google\code\
> java-allocation-instrumenter\java-allocation-instrumenter\
> 3.0.1\java-allocation-instrumenter-3.0.1.jar]>
>
> Ralph
>
> On Feb 13, 2017, at 12:13 PM, Apache <ralph.go...@dslextreme.com> wrote:
>
> No. I plan to figure out why it is breaking.
>
> Ralph
>
> On Feb 13, 2017, at 11:02 AM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> My hope was that Ralph would revert his commit that broke the build on
> Windows.
>
> Gary
>
> On Mon, Feb 13, 2017 at 10:01 AM, Gary Gregory <garydgreg...@gmail.com>
> wrote:
>
>> Maven just works as in on Windows. I have the Maven bin folder on my
>> PATH, that's it, it contains mvn.cmd.
>>
>> Gary
>>
>> On Mon, Feb 13, 2017 at 9:45 AM, Matt Sicker <boa...@gmail.com> wrote:
>>
>>> Well, that's step one! My only Windows computer is for videogames, so
>>> I'm not really experienced with development in such an environment these
>>> days. If you can figure out how to get the mvnw.cmd script to work in
>>> Windows, that'd be great.
>>>
>>> On 13 February 2017 at 11:26, Gary Gregory <garydgreg...@gmail.com>
>>> wrote:
>>>
>>>> Thank you for setting that up Matt. I can see the same failures on
>>>> https://builds.apache.org/job/Log4jWindows/ as I do locally.
>>>>
>>>> Gary
>>>>
>>>> On Sun, Feb 12, 2017 at 11:11 PM, Matt Sicker <boa...@gmail.com> wrote:
>>>>
>>>>> Also, using a similar multi-config Jenkins job, we can set up JDK 7,
>>>>> 8, and 9pre Linux builds as well.
>>>>>
>>>>> On 13 February 2017 at 01:08, Matt Sicker <boa...@gmail.com> wrote:
>>>>>
>>>>>> Sorry for the deluge of build emails, forgot to disable that.
>>>>>>
>>>>>> Anyways, I got the build running for Windows: <
>>>>>> https://builds.apache.org/job/Log4jWindows/>. I have it set to run
>>>>>> daily for now as there's only two windows VMs and I don't want to hog 
>>>>>> them.
>>>>>>
>>>>>> Ok, I have no idea why the mvnw script isn't running on there
>>>>>> properly, but I did manage to find the proper incantation to run mvn on
>>>>>> that Wind

[jira] [Commented] (LOG4J2-1814) Wrapper Generate$ExtendedLogger name inconvenient on Linux

2017-02-13 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865090#comment-15865090
 ] 

Gary Gregory commented on LOG4J2-1814:
--

Can we just cut to the chase and give the class a decent name, maybe 
{{ExtendedLoggerGenerator}}? It could just turn around and call 
{{Generate$ExtendedLogger}} if the design for that is all good.

> Wrapper Generate$ExtendedLogger name inconvenient on Linux 
> ---
>
> Key: LOG4J2-1814
> URL: https://issues.apache.org/jira/browse/LOG4J2-1814
> Project: Log4j 2
>  Issue Type: Improvement
>Reporter: Remko Popma
>Assignee: Remko Popma
>
> The $ExtendedLogger is interpreted as an environment variable. 
> {code}
> $ java -cp log4j-core-2.8.jar 
> org.apache.logging.log4j.core.tools.Generate$ExtendedLogger \
>  com.mycomp.ExtLogger DIAG=350 NOTICE=450 VERBOSE=550 > 
> com/mycomp/ExtLogger.java
> Error: Main method not found in class 
> org.apache.logging.log4j.core.tools.Generate, please define the main method 
> {code}
> The workaround is to quote the class name:
> {code}
> $ java -cp log4j-core-2.8.jar 
> "org.apache.logging.log4j.core.tools.Generate$ExtendedLogger" \
>  com.mycomp.ExtLogger DIAG=350 NOTICE=450 VERBOSE=550 > 
> com/mycomp/ExtLogger.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: RollingAppenderSizeTest failures

2017-02-13 Thread Gary Gregory
My hope was that Ralph would revert his commit that broke the build on
Windows.

Gary

On Mon, Feb 13, 2017 at 10:01 AM, Gary Gregory <garydgreg...@gmail.com>
wrote:

> Maven just works as in on Windows. I have the Maven bin folder on my PATH,
> that's it, it contains mvn.cmd.
>
> Gary
>
> On Mon, Feb 13, 2017 at 9:45 AM, Matt Sicker <boa...@gmail.com> wrote:
>
>> Well, that's step one! My only Windows computer is for videogames, so I'm
>> not really experienced with development in such an environment these days.
>> If you can figure out how to get the mvnw.cmd script to work in Windows,
>> that'd be great.
>>
>> On 13 February 2017 at 11:26, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> Thank you for setting that up Matt. I can see the same failures on
>>> https://builds.apache.org/job/Log4jWindows/ as I do locally.
>>>
>>> Gary
>>>
>>> On Sun, Feb 12, 2017 at 11:11 PM, Matt Sicker <boa...@gmail.com> wrote:
>>>
>>>> Also, using a similar multi-config Jenkins job, we can set up JDK 7, 8,
>>>> and 9pre Linux builds as well.
>>>>
>>>> On 13 February 2017 at 01:08, Matt Sicker <boa...@gmail.com> wrote:
>>>>
>>>>> Sorry for the deluge of build emails, forgot to disable that.
>>>>>
>>>>> Anyways, I got the build running for Windows: <
>>>>> https://builds.apache.org/job/Log4jWindows/>. I have it set to run
>>>>> daily for now as there's only two windows VMs and I don't want to hog 
>>>>> them.
>>>>>
>>>>> Ok, I have no idea why the mvnw script isn't running on there
>>>>> properly, but I did manage to find the proper incantation to run mvn on
>>>>> that Windows VM. This project has examples: <
>>>>> https://builds.apache.org/job/infra-test-maven-windows/>.
>>>>>
>>>>> On 12 February 2017 at 23:10, Matt Sicker <boa...@gmail.com> wrote:
>>>>>
>>>>>> Well, I've got some sort of thing working across a rather
>>>>>> unintentionally wide variety of environments. Turns out getting the 
>>>>>> Windows
>>>>>> builds to work might be simplified by including a maven wrapper because I
>>>>>> don't really know how these VMs are set up.
>>>>>>
>>>>>> On 12 February 2017 at 22:52, Matt Sicker <boa...@gmail.com> wrote:
>>>>>>
>>>>>>> JAVA_HOME not defined correctly on almost all the environments. Well
>>>>>>> now...
>>>>>>>
>>>>>>> On 12 February 2017 at 22:50, Matt Sicker <boa...@gmail.com> wrote:
>>>>>>>
>>>>>>>> I've set up a basic test matrix for Java 7 and 8 on Linux and
>>>>>>>> Windows here: <https://builds.apache.org/job/Log4j/>
>>>>>>>>
>>>>>>>> Let's see how this works.
>>>>>>>>
>>>>>>>> On 12 February 2017 at 22:40, Matt Sicker <boa...@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> I'm not really sure how to go about fixing the tests, but I was
>>>>>>>>> thinking of setting up a Jenkins job for multi-environment testing to 
>>>>>>>>> try
>>>>>>>>> and catch these issues sooner.
>>>>>>>>>
>>>>>>>>> On 12 February 2017 at 22:16, Gary Gregory <garydgreg...@gmail.com
>>>>>>>>> > wrote:
>>>>>>>>>
>>>>>>>>>> Any chance building on Windows gets solved soon-ish?
>>>>>>>>>>
>>>>>>>>>> Gary
>>>>>>>>>>
>>>>>>>>>> On Thu, Feb 2, 2017 at 6:05 PM, Gary Gregory <
>>>>>>>>>> garydgreg...@gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Git bisec says:
>>>>>>>>>>>
>>>>>>>>>>> *a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a is the first bad
>>>>>>>>>>> commit*
>>>>>>>>>>> commit a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a
>>>>>>>>>>> Author: Ralph Goers <ralph.go...@dslextreme.com>
>>>>>>>>

Re: RollingAppenderSizeTest failures

2017-02-13 Thread Gary Gregory
Maven just works as in on Windows. I have the Maven bin folder on my PATH,
that's it, it contains mvn.cmd.

Gary

On Mon, Feb 13, 2017 at 9:45 AM, Matt Sicker <boa...@gmail.com> wrote:

> Well, that's step one! My only Windows computer is for videogames, so I'm
> not really experienced with development in such an environment these days.
> If you can figure out how to get the mvnw.cmd script to work in Windows,
> that'd be great.
>
> On 13 February 2017 at 11:26, Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> Thank you for setting that up Matt. I can see the same failures on
>> https://builds.apache.org/job/Log4jWindows/ as I do locally.
>>
>> Gary
>>
>> On Sun, Feb 12, 2017 at 11:11 PM, Matt Sicker <boa...@gmail.com> wrote:
>>
>>> Also, using a similar multi-config Jenkins job, we can set up JDK 7, 8,
>>> and 9pre Linux builds as well.
>>>
>>> On 13 February 2017 at 01:08, Matt Sicker <boa...@gmail.com> wrote:
>>>
>>>> Sorry for the deluge of build emails, forgot to disable that.
>>>>
>>>> Anyways, I got the build running for Windows: <
>>>> https://builds.apache.org/job/Log4jWindows/>. I have it set to run
>>>> daily for now as there's only two windows VMs and I don't want to hog them.
>>>>
>>>> Ok, I have no idea why the mvnw script isn't running on there properly,
>>>> but I did manage to find the proper incantation to run mvn on that Windows
>>>> VM. This project has examples: <https://builds.apache.org/job
>>>> /infra-test-maven-windows/>.
>>>>
>>>> On 12 February 2017 at 23:10, Matt Sicker <boa...@gmail.com> wrote:
>>>>
>>>>> Well, I've got some sort of thing working across a rather
>>>>> unintentionally wide variety of environments. Turns out getting the 
>>>>> Windows
>>>>> builds to work might be simplified by including a maven wrapper because I
>>>>> don't really know how these VMs are set up.
>>>>>
>>>>> On 12 February 2017 at 22:52, Matt Sicker <boa...@gmail.com> wrote:
>>>>>
>>>>>> JAVA_HOME not defined correctly on almost all the environments. Well
>>>>>> now...
>>>>>>
>>>>>> On 12 February 2017 at 22:50, Matt Sicker <boa...@gmail.com> wrote:
>>>>>>
>>>>>>> I've set up a basic test matrix for Java 7 and 8 on Linux and
>>>>>>> Windows here: <https://builds.apache.org/job/Log4j/>
>>>>>>>
>>>>>>> Let's see how this works.
>>>>>>>
>>>>>>> On 12 February 2017 at 22:40, Matt Sicker <boa...@gmail.com> wrote:
>>>>>>>
>>>>>>>> I'm not really sure how to go about fixing the tests, but I was
>>>>>>>> thinking of setting up a Jenkins job for multi-environment testing to 
>>>>>>>> try
>>>>>>>> and catch these issues sooner.
>>>>>>>>
>>>>>>>> On 12 February 2017 at 22:16, Gary Gregory <garydgreg...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Any chance building on Windows gets solved soon-ish?
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>> On Thu, Feb 2, 2017 at 6:05 PM, Gary Gregory <
>>>>>>>>> garydgreg...@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Git bisec says:
>>>>>>>>>>
>>>>>>>>>> *a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a is the first bad commit*
>>>>>>>>>> commit a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a
>>>>>>>>>> Author: Ralph Goers <ralph.go...@dslextreme.com>
>>>>>>>>>> Date:   Tue Jan 24 14:48:34 2017 -0700
>>>>>>>>>>
>>>>>>>>>> Use an ExecutorService to verify shutdown of the async threads
>>>>>>>>>>
>>>>>>>>>> :04 04 ad3cb23efafeaab2f7e934e249c8e53ff7dcf86f
>>>>>>>>>> 056bbb158f43602fb2a4e8c74c5bcff29e5e5fe5 M  log4j-core
>>>>>>>>>> bisect run success
>>>>>>>>>>
>>>>>>>&g

Re: RollingAppenderSizeTest failures

2017-02-13 Thread Gary Gregory
Thank you for setting that up Matt. I can see the same failures on
https://builds.apache.org/job/Log4jWindows/ as I do locally.

Gary

On Sun, Feb 12, 2017 at 11:11 PM, Matt Sicker <boa...@gmail.com> wrote:

> Also, using a similar multi-config Jenkins job, we can set up JDK 7, 8,
> and 9pre Linux builds as well.
>
> On 13 February 2017 at 01:08, Matt Sicker <boa...@gmail.com> wrote:
>
>> Sorry for the deluge of build emails, forgot to disable that.
>>
>> Anyways, I got the build running for Windows: <
>> https://builds.apache.org/job/Log4jWindows/>. I have it set to run daily
>> for now as there's only two windows VMs and I don't want to hog them.
>>
>> Ok, I have no idea why the mvnw script isn't running on there properly,
>> but I did manage to find the proper incantation to run mvn on that Windows
>> VM. This project has examples: <https://builds.apache.org/job
>> /infra-test-maven-windows/>.
>>
>> On 12 February 2017 at 23:10, Matt Sicker <boa...@gmail.com> wrote:
>>
>>> Well, I've got some sort of thing working across a rather
>>> unintentionally wide variety of environments. Turns out getting the Windows
>>> builds to work might be simplified by including a maven wrapper because I
>>> don't really know how these VMs are set up.
>>>
>>> On 12 February 2017 at 22:52, Matt Sicker <boa...@gmail.com> wrote:
>>>
>>>> JAVA_HOME not defined correctly on almost all the environments. Well
>>>> now...
>>>>
>>>> On 12 February 2017 at 22:50, Matt Sicker <boa...@gmail.com> wrote:
>>>>
>>>>> I've set up a basic test matrix for Java 7 and 8 on Linux and Windows
>>>>> here: <https://builds.apache.org/job/Log4j/>
>>>>>
>>>>> Let's see how this works.
>>>>>
>>>>> On 12 February 2017 at 22:40, Matt Sicker <boa...@gmail.com> wrote:
>>>>>
>>>>>> I'm not really sure how to go about fixing the tests, but I was
>>>>>> thinking of setting up a Jenkins job for multi-environment testing to try
>>>>>> and catch these issues sooner.
>>>>>>
>>>>>> On 12 February 2017 at 22:16, Gary Gregory <garydgreg...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Any chance building on Windows gets solved soon-ish?
>>>>>>>
>>>>>>> Gary
>>>>>>>
>>>>>>> On Thu, Feb 2, 2017 at 6:05 PM, Gary Gregory <garydgreg...@gmail.com
>>>>>>> > wrote:
>>>>>>>
>>>>>>>> Git bisec says:
>>>>>>>>
>>>>>>>> *a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a is the first bad commit*
>>>>>>>> commit a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a
>>>>>>>> Author: Ralph Goers <ralph.go...@dslextreme.com>
>>>>>>>> Date:   Tue Jan 24 14:48:34 2017 -0700
>>>>>>>>
>>>>>>>> Use an ExecutorService to verify shutdown of the async threads
>>>>>>>>
>>>>>>>> :04 04 ad3cb23efafeaab2f7e934e249c8e53ff7dcf86f
>>>>>>>> 056bbb158f43602fb2a4e8c74c5bcff29e5e5fe5 M  log4j-core
>>>>>>>> bisect run success
>>>>>>>>
>>>>>>>>
>>>>>>>> I'm not sure what needs to be reverted or changed but there you
>>>>>>>> have it (I have to get back to a customer issue now).
>>>>>>>>
>>>>>>>> If you want to do this yourself you can run:
>>>>>>>>
>>>>>>>> git bisect start HEAD log4j-2.7
>>>>>>>>
>>>>>>>> (I was not sure how far back to go so I picked 2.7. It turns out I
>>>>>>>> could have used 2.8. Then in a script called ..\run.cmd I have:
>>>>>>>>
>>>>>>>> call mvn clean
>>>>>>>> call mvn -DskipTests -pl log4j-api install
>>>>>>>> mvn -Dtest=RollingAppenderSizeTest -pl log4j-core test
>>>>>>>>
>>>>>>>> and run:
>>>>>>>>
>>>>>>>> git bisect run ..\run.cmd
>>>>>>>>
>>>>>>>> which gives you the output at the start of this message.
>>>>>>>>
>>>>

[jira] [Commented] (LOG4J2-1813) Provide shorter and more intuitive way to switch on Log4j internal debug logging

2017-02-13 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863148#comment-15863148
 ] 

Gary Gregory commented on LOG4J2-1813:
--

Yeah, the "EBUG" is not pretty. 

I had a question about this topic recently from a co-worker who was baffled by 
our crazy long property name instead of a Log4j 1-like "log4j2.debug"

> Provide shorter and more intuitive way to switch on Log4j internal debug 
> logging
> 
>
> Key: LOG4J2-1813
> URL: https://issues.apache.org/jira/browse/LOG4J2-1813
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Configurators
>Affects Versions: 2.8
>Reporter: Remko Popma
>Assignee: Remko Popma
> Fix For: 2.8.1
>
>
> People find it difficult to troubleshoot Log4j 2 configuration issues. Many 
> people don't know what the "status" attribute is for at the beginning of the 
> configuration:
> {code}
>  ...
> {code}
> In addition, the above setting does not take effect until the configuration 
> file is found. If users have trouble making Log4j 2 find their configuration 
> file, the above does not help.
> In such cases, users can enable internal status logging by setting system 
> property {{org.apache.logging.log4j.simplelog.StatusLogger.level}} to 
> {{TRACE}}.
> This is problematic because:
> * It is not well-known (documented in the FAQ and on the configuration page 
> but many people don't know about this feature)
> * The name is a bit... lengthy :-) 
> * Apparently people don't intuitively grasp that "status logging" means the 
> internal log4j 2 debug logging facility.
> * It is confusing that there are two phases (before config file found and 
> after), and the status logger level can be different and needs to be 
> specified separately
> I propose we add a short, intuitive system property that results in _all_ 
> internal Log4j 2 status logging to be printed to the console. When set, this 
> property should even override the configuration status attribute in my 
> opinion.
> Something like {{-Dlog4j2.debug}} (without even requiring a value) would be 
> good, but I'm open to any suggestions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: RollingAppenderSizeTest failures

2017-02-12 Thread Gary Gregory
Any chance building on Windows gets solved soon-ish?

Gary

On Thu, Feb 2, 2017 at 6:05 PM, Gary Gregory <garydgreg...@gmail.com> wrote:

> Git bisec says:
>
> *a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a is the first bad commit*
> commit a0f4f4db5e8e88e56eaa148d81c2ba91df606e2a
> Author: Ralph Goers <ralph.go...@dslextreme.com>
> Date:   Tue Jan 24 14:48:34 2017 -0700
>
> Use an ExecutorService to verify shutdown of the async threads
>
> :04 04 ad3cb23efafeaab2f7e934e249c8e53ff7dcf86f
> 056bbb158f43602fb2a4e8c74c5bcff29e5e5fe5 M  log4j-core
> bisect run success
>
>
> I'm not sure what needs to be reverted or changed but there you have it (I
> have to get back to a customer issue now).
>
> If you want to do this yourself you can run:
>
> git bisect start HEAD log4j-2.7
>
> (I was not sure how far back to go so I picked 2.7. It turns out I could
> have used 2.8. Then in a script called ..\run.cmd I have:
>
> call mvn clean
> call mvn -DskipTests -pl log4j-api install
> mvn -Dtest=RollingAppenderSizeTest -pl log4j-core test
>
> and run:
>
> git bisect run ..\run.cmd
>
> which gives you the output at the start of this message.
>
> Gary
>
>
> On Thu, Feb 2, 2017 at 5:01 PM, Gary Gregory <garydgreg...@gmail.com>
> wrote:
>
>> I get:
>>
>> Tests in error:
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>   RollingAppenderSizeTest.cleanup:115->cleanFolder:189 ╗ FileSystem
>> target\rolli...
>>
>> Tests run: 1879, Failures: 0, Errors: 10, Skipped: 30
>>
>> using:
>>
>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>> 2015-11-10T08:41:47-08:00)
>> Maven home: C:\Java\apache-maven-3.3.9\bin\..
>> Java version: 1.7.0_80, vendor: Oracle Corporation
>> Java home: C:\Program Files\Java\jdk1.7.0_80\jre
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"
>>
>> Anyone else?
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>>
>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
>> JUnit in Action, Second Edition
>> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>>
>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
>> Spring Batch in Action
>> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie

Re: Remko travel plans

2017-02-12 Thread Gary Gregory
NL is great. Enjoy!

Gary

On Feb 12, 2017 6:31 AM, "Remko Popma"  wrote:

> I will be travelling to Holland between Feb 15 and March 5th, with
> sporadic internet access at times, so I may be slow to reply during this
> period.
>
> Remko
>


Re: Regarding Checkstyle, PMD, and formatting

2017-02-10 Thread Gary Gregory
On Fri, Feb 10, 2017 at 11:01 AM, Apache <ralph.go...@dslextreme.com> wrote:

> Well, smalltalk might be nicer but we code in Java. I prefer to always use
> parens unless all the operators are the same. I’m old so I can never
> remember the precedence order.
>

I'm all for parens. It makes maintenance so much easier. You write the code
once, and it is read forever more. Might as well make your *intentions* be
crystal clear.

Gary


>
> Ralph
>
> On Feb 10, 2017, at 11:32 AM, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> On Fri, Feb 10, 2017 at 8:07 AM, Matt Sicker <boa...@gmail.com> wrote:
>
>> The "unnecessary parenthesis" rule is somewhat annoying. While it has
>> good intentions, it'll also flag something like this:
>>
>> foo || (bar && baz)
>>
>> Sure, && has higher precedence than || (had to look it up just now), but
>> who can remember those kinds of rules anyways?
>>
>
> It's one of the many things Smalltalk got right. Left to right, simple as
> that. Different, yes, but simple.
>
> Gary
>
>
>>
>> On 10 February 2017 at 09:36, Remko Popma <remko.po...@gmail.com> wrote:
>>
>>> +1 on braces
>>>
>>> On Sat, Feb 11, 2017 at 12:35 AM, Apache <ralph.go...@dslextreme.com>
>>> wrote:
>>>
>>>> You don’t really have to use final everywhere. If you don’t, Gary will
>>>> fix it ;-)
>>>>
>>>> Actually, I really do prefer most of our check style rules, but not
>>>> enough to yell and scream about it. The one that bothers me the most is
>>>> that I want braces wherever they are optional.
>>>>
>>>> Ralph
>>>>
>>>> On Feb 10, 2017, at 8:09 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>>
>>>> At work, I've switched from final everywhere to final everywhere but
>>>> local variables while maintaining effective finality instead. I just wish
>>>> Java had final be the default.
>>>>
>>>> On 10 February 2017 at 05:34, Remko Popma <remko.po...@gmail.com>
>>>> wrote:
>>>>
>>>>> Generally agree except that we agreed that the final qualifier was
>>>>> optional.  This may not be easy (or possible?) to verify automatically
>>>>> anyway.
>>>>>
>>>>> Otherwise all looks reasonable.
>>>>>
>>>>> Sent from my iPhone
>>>>>
>>>>> On Feb 10, 2017, at 17:55, Mikael Ståldal <mikael.stal...@magine.com>
>>>>> wrote:
>>>>>
>>>>> Seems reasonable.
>>>>>
>>>>> On Fri, Feb 10, 2017 at 5:56 AM, Gary Gregory <garydgreg...@gmail.com>
>>>>>  wrote:
>>>>>
>>>>>> I agree with all that! :-)
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>
>>>>>> On Feb 9, 2017 7:05 PM, "Matt Sicker" <boa...@gmail.com> wrote:
>>>>>>
>>>>>> I was browsing through the site and took a look at the component
>>>>>> reports. Checkstyle alone seems close to pointless as there are over 200
>>>>>> errors in log4j-api alone. log4j-core has over 2000 errors. Even new 
>>>>>> files
>>>>>> that were formatted with our formatter settings such as the
>>>>>> CassandraAppender plugin have import ordering errors. I also disagree 
>>>>>> with
>>>>>> some of the rules configured, but that doesn't really matter when we 
>>>>>> don't
>>>>>> enforce it in the first place.
>>>>>>
>>>>>> Anyways, what's the point of configuring this and adding checkstyle
>>>>>> comments yet not even using it? The only project I've come across in the
>>>>>> wild so far that has checkstyle configured properly was Spring Boot, and
>>>>>> your pull request has to pass the checkstyle check to even be mergeable.
>>>>>>
>>>>>> Perhaps if we wish to actually use it, we could loosen the rules down
>>>>>> to a much smaller set that actually matches the formatter settings in
>>>>>> src/ide/. If the rules matched our code base, then we could also have
>>>>>> Jenkins run checkstyle checks which would keep us informed when we mess 
>>>>>> up,
>>>>>> and it would also be useful for pu

Re: Regarding Checkstyle, PMD, and formatting

2017-02-10 Thread Gary Gregory
On Fri, Feb 10, 2017 at 8:07 AM, Matt Sicker <boa...@gmail.com> wrote:

> The "unnecessary parenthesis" rule is somewhat annoying. While it has good
> intentions, it'll also flag something like this:
>
> foo || (bar && baz)
>
> Sure, && has higher precedence than || (had to look it up just now), but
> who can remember those kinds of rules anyways?
>

It's one of the many things Smalltalk got right. Left to right, simple as
that. Different, yes, but simple.

Gary


>
> On 10 February 2017 at 09:36, Remko Popma <remko.po...@gmail.com> wrote:
>
>> +1 on braces
>>
>> On Sat, Feb 11, 2017 at 12:35 AM, Apache <ralph.go...@dslextreme.com>
>> wrote:
>>
>>> You don’t really have to use final everywhere. If you don’t, Gary will
>>> fix it ;-)
>>>
>>> Actually, I really do prefer most of our check style rules, but not
>>> enough to yell and scream about it. The one that bothers me the most is
>>> that I want braces wherever they are optional.
>>>
>>> Ralph
>>>
>>> On Feb 10, 2017, at 8:09 AM, Matt Sicker <boa...@gmail.com> wrote:
>>>
>>> At work, I've switched from final everywhere to final everywhere but
>>> local variables while maintaining effective finality instead. I just wish
>>> Java had final be the default.
>>>
>>> On 10 February 2017 at 05:34, Remko Popma <remko.po...@gmail.com> wrote:
>>>
>>>> Generally agree except that we agreed that the final qualifier was
>>>> optional.  This may not be easy (or possible?) to verify automatically
>>>> anyway.
>>>>
>>>> Otherwise all looks reasonable.
>>>>
>>>> Sent from my iPhone
>>>>
>>>> On Feb 10, 2017, at 17:55, Mikael Ståldal <mikael.stal...@magine.com>
>>>> wrote:
>>>>
>>>> Seems reasonable.
>>>>
>>>> On Fri, Feb 10, 2017 at 5:56 AM, Gary Gregory <garydgreg...@gmail.com>
>>>> wrote:
>>>>
>>>>> I agree with all that! :-)
>>>>>
>>>>> Gary
>>>>>
>>>>>
>>>>> On Feb 9, 2017 7:05 PM, "Matt Sicker" <boa...@gmail.com> wrote:
>>>>>
>>>>> I was browsing through the site and took a look at the component
>>>>> reports. Checkstyle alone seems close to pointless as there are over 200
>>>>> errors in log4j-api alone. log4j-core has over 2000 errors. Even new files
>>>>> that were formatted with our formatter settings such as the
>>>>> CassandraAppender plugin have import ordering errors. I also disagree with
>>>>> some of the rules configured, but that doesn't really matter when we don't
>>>>> enforce it in the first place.
>>>>>
>>>>> Anyways, what's the point of configuring this and adding checkstyle
>>>>> comments yet not even using it? The only project I've come across in the
>>>>> wild so far that has checkstyle configured properly was Spring Boot, and
>>>>> your pull request has to pass the checkstyle check to even be mergeable.
>>>>>
>>>>> Perhaps if we wish to actually use it, we could loosen the rules down
>>>>> to a much smaller set that actually matches the formatter settings in
>>>>> src/ide/. If the rules matched our code base, then we could also have
>>>>> Jenkins run checkstyle checks which would keep us informed when we mess 
>>>>> up,
>>>>> and it would also be useful for pull requests (I've had to reformat many
>>>>> patches in the past).
>>>>>
>>>>> Related, there's the style guide <https://logging.apache.org/lo
>>>>> g4j/2.x/javastyle.html> which I'm pretty sure I've never even looked
>>>>> at before. This could also be normalized with our formatter files. I've
>>>>> generally thought of our code style summarized as:
>>>>>
>>>>> * 4 space indent
>>>>> * use final
>>>>> * no star imports outside tests (and those should generally be static
>>>>> imports)
>>>>> * imports should be in some sort of alphabetical order (this is really
>>>>> difficult to match between IntelliJ and Eclipse for some reason; I've had
>>>>> rather obnoxious fights about this in the past thanks to
>>>>> import-order-induced merge conflicts)
>>>>> * try to stick to unix line 

Re: Regarding Checkstyle, PMD, and formatting

2017-02-10 Thread Gary Gregory
On Fri, Feb 10, 2017 at 7:35 AM, Apache <ralph.go...@dslextreme.com> wrote:

> You don’t really have to use final everywhere. If you don’t, Gary will fix
> it ;-)
>

:-)


>
> Actually, I really do prefer most of our check style rules, but not enough
> to yell and scream about it. The one that bothers me the most is that I
> want braces wherever they are optional.
>

+1

Gary


>
> Ralph
>
> On Feb 10, 2017, at 8:09 AM, Matt Sicker <boa...@gmail.com> wrote:
>
> At work, I've switched from final everywhere to final everywhere but local
> variables while maintaining effective finality instead. I just wish Java
> had final be the default.
>
> On 10 February 2017 at 05:34, Remko Popma <remko.po...@gmail.com> wrote:
>
>> Generally agree except that we agreed that the final qualifier was
>> optional.  This may not be easy (or possible?) to verify automatically
>> anyway.
>>
>> Otherwise all looks reasonable.
>>
>> Sent from my iPhone
>>
>> On Feb 10, 2017, at 17:55, Mikael Ståldal <mikael.stal...@magine.com>
>> wrote:
>>
>> Seems reasonable.
>>
>> On Fri, Feb 10, 2017 at 5:56 AM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> I agree with all that! :-)
>>>
>>> Gary
>>>
>>>
>>> On Feb 9, 2017 7:05 PM, "Matt Sicker" <boa...@gmail.com> wrote:
>>>
>>> I was browsing through the site and took a look at the component
>>> reports. Checkstyle alone seems close to pointless as there are over 200
>>> errors in log4j-api alone. log4j-core has over 2000 errors. Even new files
>>> that were formatted with our formatter settings such as the
>>> CassandraAppender plugin have import ordering errors. I also disagree with
>>> some of the rules configured, but that doesn't really matter when we don't
>>> enforce it in the first place.
>>>
>>> Anyways, what's the point of configuring this and adding checkstyle
>>> comments yet not even using it? The only project I've come across in the
>>> wild so far that has checkstyle configured properly was Spring Boot, and
>>> your pull request has to pass the checkstyle check to even be mergeable.
>>>
>>> Perhaps if we wish to actually use it, we could loosen the rules down to
>>> a much smaller set that actually matches the formatter settings in
>>> src/ide/. If the rules matched our code base, then we could also have
>>> Jenkins run checkstyle checks which would keep us informed when we mess up,
>>> and it would also be useful for pull requests (I've had to reformat many
>>> patches in the past).
>>>
>>> Related, there's the style guide <https://logging.apache.org/lo
>>> g4j/2.x/javastyle.html> which I'm pretty sure I've never even looked at
>>> before. This could also be normalized with our formatter files. I've
>>> generally thought of our code style summarized as:
>>>
>>> * 4 space indent
>>> * use final
>>> * no star imports outside tests (and those should generally be static
>>> imports)
>>> * imports should be in some sort of alphabetical order (this is really
>>> difficult to match between IntelliJ and Eclipse for some reason; I've had
>>> rather obnoxious fights about this in the past thanks to
>>> import-order-induced merge conflicts)
>>> * try to stick to unix line endings, but we're rather mixed still
>>> * every file needs a license header unless it's impossible to include
>>> comments
>>> * use CamelCaseClassNames, even for acronyms
>>> * no hungarian notation or other distracting naming conventions
>>> * otherwise stick to typical Sun style that everyone basically
>>> recognizes (that the JDK doesn't even use itself)
>>>
>>> --
>>> Matt Sicker <boa...@gmail.com>
>>>
>>>
>>>
>>
>>
>> --
>> [image: MagineTV]
>>
>> *Mikael Ståldal*
>> Senior software developer
>>
>> *Magine TV*
>> mikael.stal...@magine.com
>> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com
>> <http://www.magine.com/>
>>
>> Privileged and/or Confidential Information may be contained in this
>> message. If you are not the addressee indicated in this message
>> (or responsible for delivery of the message to such a person), you may
>> not copy or deliver this message to anyone. In such case,
>> you should destroy this message and kindly notify the sender by reply
>> email.
>>
>>
>
&g

Re: Regarding Checkstyle, PMD, and formatting

2017-02-10 Thread Gary Gregory
On Fri, Feb 10, 2017 at 7:09 AM, Matt Sicker <boa...@gmail.com> wrote:

> At work, I've switched from final everywhere to final everywhere but local
> variables while maintaining effective finality instead. I just wish Java
> had final be the default.
>

+1

Java is just noisy by design, it's the way it is.

Gary


>
> On 10 February 2017 at 05:34, Remko Popma <remko.po...@gmail.com> wrote:
>
>> Generally agree except that we agreed that the final qualifier was
>> optional.  This may not be easy (or possible?) to verify automatically
>> anyway.
>>
>> Otherwise all looks reasonable.
>>
>> Sent from my iPhone
>>
>> On Feb 10, 2017, at 17:55, Mikael Ståldal <mikael.stal...@magine.com>
>> wrote:
>>
>> Seems reasonable.
>>
>> On Fri, Feb 10, 2017 at 5:56 AM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> I agree with all that! :-)
>>>
>>> Gary
>>>
>>>
>>> On Feb 9, 2017 7:05 PM, "Matt Sicker" <boa...@gmail.com> wrote:
>>>
>>> I was browsing through the site and took a look at the component
>>> reports. Checkstyle alone seems close to pointless as there are over 200
>>> errors in log4j-api alone. log4j-core has over 2000 errors. Even new files
>>> that were formatted with our formatter settings such as the
>>> CassandraAppender plugin have import ordering errors. I also disagree with
>>> some of the rules configured, but that doesn't really matter when we don't
>>> enforce it in the first place.
>>>
>>> Anyways, what's the point of configuring this and adding checkstyle
>>> comments yet not even using it? The only project I've come across in the
>>> wild so far that has checkstyle configured properly was Spring Boot, and
>>> your pull request has to pass the checkstyle check to even be mergeable.
>>>
>>> Perhaps if we wish to actually use it, we could loosen the rules down to
>>> a much smaller set that actually matches the formatter settings in
>>> src/ide/. If the rules matched our code base, then we could also have
>>> Jenkins run checkstyle checks which would keep us informed when we mess up,
>>> and it would also be useful for pull requests (I've had to reformat many
>>> patches in the past).
>>>
>>> Related, there's the style guide <https://logging.apache.org/lo
>>> g4j/2.x/javastyle.html> which I'm pretty sure I've never even looked at
>>> before. This could also be normalized with our formatter files. I've
>>> generally thought of our code style summarized as:
>>>
>>> * 4 space indent
>>> * use final
>>> * no star imports outside tests (and those should generally be static
>>> imports)
>>> * imports should be in some sort of alphabetical order (this is really
>>> difficult to match between IntelliJ and Eclipse for some reason; I've had
>>> rather obnoxious fights about this in the past thanks to
>>> import-order-induced merge conflicts)
>>> * try to stick to unix line endings, but we're rather mixed still
>>> * every file needs a license header unless it's impossible to include
>>> comments
>>> * use CamelCaseClassNames, even for acronyms
>>> * no hungarian notation or other distracting naming conventions
>>> * otherwise stick to typical Sun style that everyone basically
>>> recognizes (that the JDK doesn't even use itself)
>>>
>>> --
>>> Matt Sicker <boa...@gmail.com>
>>>
>>>
>>>
>>
>>
>> --
>> [image: MagineTV]
>>
>> *Mikael Ståldal*
>> Senior software developer
>>
>> *Magine TV*
>> mikael.stal...@magine.com
>> Grev Turegatan 3  | 114 46 Stockholm, Sweden  |   www.magine.com
>>
>> Privileged and/or Confidential Information may be contained in this
>> message. If you are not the addressee indicated in this message
>> (or responsible for delivery of the message to such a person), you may
>> not copy or deliver this message to anyone. In such case,
>> you should destroy this message and kindly notify the sender by reply
>> email.
>>
>>
>
>
> --
> Matt Sicker <boa...@gmail.com>
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Regarding Checkstyle, PMD, and formatting

2017-02-09 Thread Gary Gregory
I agree with all that! :-)

Gary


On Feb 9, 2017 7:05 PM, "Matt Sicker"  wrote:

I was browsing through the site and took a look at the component reports.
Checkstyle alone seems close to pointless as there are over 200 errors in
log4j-api alone. log4j-core has over 2000 errors. Even new files that were
formatted with our formatter settings such as the CassandraAppender plugin
have import ordering errors. I also disagree with some of the rules
configured, but that doesn't really matter when we don't enforce it in the
first place.

Anyways, what's the point of configuring this and adding checkstyle
comments yet not even using it? The only project I've come across in the
wild so far that has checkstyle configured properly was Spring Boot, and
your pull request has to pass the checkstyle check to even be mergeable.

Perhaps if we wish to actually use it, we could loosen the rules down to a
much smaller set that actually matches the formatter settings in src/ide/.
If the rules matched our code base, then we could also have Jenkins run
checkstyle checks which would keep us informed when we mess up, and it
would also be useful for pull requests (I've had to reformat many patches
in the past).

Related, there's the style guide  which I'm pretty sure I've never even looked at
before. This could also be normalized with our formatter files. I've
generally thought of our code style summarized as:

* 4 space indent
* use final
* no star imports outside tests (and those should generally be static
imports)
* imports should be in some sort of alphabetical order (this is really
difficult to match between IntelliJ and Eclipse for some reason; I've had
rather obnoxious fights about this in the past thanks to
import-order-induced merge conflicts)
* try to stick to unix line endings, but we're rather mixed still
* every file needs a license header unless it's impossible to include
comments
* use CamelCaseClassNames, even for acronyms
* no hungarian notation or other distracting naming conventions
* otherwise stick to typical Sun style that everyone basically recognizes
(that the JDK doesn't even use itself)

-- 
Matt Sicker 


Re: Making copies of LogEvent to avoid no-GC problems

2017-02-05 Thread Gary Gregory
On Thu, Jan 26, 2017 at 2:45 PM, Remko Popma <remko.po...@gmail.com> wrote:

> Yes, makes sense to me.
> Remko
>

I have a patch attached here:
https://issues.apache.org/jira/browse/LOG4J2-1807

But I'd like to be able to build on Windows before committing it...

Gary


>
> Sent from my iPhone
>
> On Jan 27, 2017, at 3:32, Gary Gregory <garydgreg...@gmail.com> wrote:
>
> Hi All:
>
> Just like in our SMTP appender, I have a custom Appender which needs to
> track LogEvents. To do this without falling prey to all of our no-GC epic
> cleverness, the SMTP appender does this:
>
> public void add(LogEvent event) {
> if (event instanceof Log4jLogEvent && event.getMessage()
> instanceof ReusableMessage) {
> ((Log4jLogEvent) event).makeMessageImmutable();
> } else if (event instanceof MutableLogEvent) {
> event = ((MutableLogEvent) event).createMemento();
> }
> buffer.add(event);
> }
>
> The code in my Appender is functionally identical, I just use a different
> buffer type.
>
> This kind of Appender code is impossible to write correctly first IMO.
>
> My first implementation was just:
>
> public void add(LogEvent event) {
> buffer.add(event);
> }
>
> After a bug hunt by a colleague of mine, I thought the fix for our use
> case was 'simple':
>
> public void add(LogEvent event) {
> buffer.add(event instanceof MutableLogEvent ? ((MutableLogEvent)
> event).createMemento() : event);
> }
>
> But that was not complete!
>
> Our Appender now does the same thing the SMTP Appender does.
>
> Should we allow LogEvent to express this more cleanly? Maybe:
>
> public void add(LogEvent event) {
> buffer.add(event.asImmutableLogEvent());
> }
>
> Where MutableLogEvent.asImmutableLogEvent() just calls createMemento()
> and LogEvent changes its internal state by calling makeMessageImmutable()
> and returns 'this' since creating a new LogEvent is not needed.
>
> Thoughts?
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>
>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>
>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8=1789=9325=1617290459=as2=garygregory-20=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8=1789=9325=1935182021=as2=garygregory-20=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8=1789=9325=1935182951=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:ir-na.amazon-adsystem.com/e/ir?t=garygregory-20=am2=1=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: Logback performance improvements

2017-02-05 Thread Gary Gregory
If you want, I can run tests on Windows once the build works on Windows
again.

Let me know what args/command line...

Gary

On Feb 5, 2017 11:58 AM, "Apache"  wrote:

> I guess my MacBook Pro must fit in the Slow CPU/Fast Hard drive category.
> With Logback 1.10 and -t 4  now get
>
> Benchmark Mode  Samples
> Score   Error  Units
> o.a.l.l.p.j.FileAppenderBenchmark.julFilethrpt   20
> 98187.673 ±  4935.712  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j1File thrpt   20
> 842374.496 ±  6762.712  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j2File thrpt   20
> 1853062.583 ± 67032.225  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.log4j2RAF  thrpt   20
> 2036011.226 ± 53208.281  ops/s
> o.a.l.l.p.j.FileAppenderBenchmark.logbackFilethrpt   20
> 999667.438 ± 12074.003  ops/s
>
> I’ll have to try this on one my VMs at work. We don’t run anything
> directly on bare metal any more.
>
> Ralph
>
> On Feb 5, 2017, at 9:40 AM, Apache  wrote:
>
> Ceki finally fixed some of the performance problems in the FileAppender.
> See https://logback.qos.ch/news.html and https://docs.
> google.com/spreadsheets/d/1cpb5D7qnyye4W0RTlHUnXedYK98ca
> tNZytYIu5D91m0/edit#gid=0. I suspect we have a few optimizations we can
> make.
>
> Ralph
>
>
>


[jira] [Commented] (LOG4J2-1809) Add global configuration environment SPI

2017-02-05 Thread Gary Gregory (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853316#comment-15853316
 ] 

Gary Gregory commented on LOG4J2-1809:
--

It seems we are entering Apache Commons Configuration territory here. Should we 
have a bridge to it?

> Add global configuration environment SPI
> 
>
> Key: LOG4J2-1809
> URL: https://issues.apache.org/jira/browse/LOG4J2-1809
> Project: Log4j 2
>  Issue Type: New Feature
>  Components: API
>Reporter: Matt Sicker
>Assignee: Matt Sicker
>
> Create a service provider interface for global configuration property 
> sources. Currently, we support two built in sources: properties loaded from a 
> classpath resource file named "log4j2.component.properties" and from system 
> properties. This feature will abstract those two sources into an SPI with 
> default implementations of those two sources as well as environment variables.
> This SPI should be specified through the standard 
> [ServiceLoader|https://docs.oracle.com/javase/8/docs/api/java/util/ServiceLoader.html]
>  API so as to make this simpler to support for users in any environment.
> Related to LOG4J2-1431.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: RollingAppenderSizeTest failures

2017-02-03 Thread Gary Gregory
I have customers that develop on Windows and then deploy to everything from
Windows Server boxes (more than you think), AIX, Linux, Linux on Z, you
name it.

G

On Fri, Feb 3, 2017 at 2:52 PM, Apache <ralph.go...@dslextreme.com> wrote:

> Yeah - the idea of using Java on Windows seems like it would be an
> anti-pattern to me.
>
> Ralph
>
> On Feb 3, 2017, at 3:37 PM, Matt Sicker <boa...@gmail.com> wrote:
>
> I mean when it comes down to production use of Cassandra, I really doubt
> anyone is using it on Windows. Then again, I've never seen Windows Server
> used for big data clusters in the first place, so I suppose it's possible.
>
> On 3 February 2017 at 16:23, Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> I hope running Cassandra on Windows is not a problem. I seems like a
>> normal set up: https://www.datastax.com/2012/01/getting-started-with-ap
>> ache-cassandra-on-windows-the-easy-way
>>
>> G
>>
>> On Fri, Feb 3, 2017 at 12:10 PM, Matt Sicker <boa...@gmail.com> wrote:
>>
>>> That's strange. I never tested that integration test in Windows, so
>>> perhaps it's platform-specific? Anyways, the equivalent Mongo integration
>>> test is @Ignore'd due to requiring a running Mongo, and the Cassandra test
>>> works similarly although it starts up Cassandra within the JVM for you.
>>>
>>> On 3 February 2017 at 13:10, Gary Gregory <garydgreg...@gmail.com>
>>> wrote:
>>>
>>>> And if I ignore THAT OSGi test, I then fail in nosql :-(
>>>>
>>>> [INFO] --- maven-failsafe-plugin:2.19.1:integration-test
>>>> (integration-tests) @ log4j-nosql ---
>>>>
>>>> ---
>>>>  T E S T S
>>>> ---
>>>> Running org.apache.logging.log4j.nosql.appender.cassandra.CassandraA
>>>> ppenderIT
>>>> ERROR StatusLogger No log4j2 configuration file found. Using default
>>>> configuration: logging only errors to the console.
>>>> 11:00:39.333 [Log4j2-TF-1-Cassandra-1] ERROR
>>>> org.apache.cassandra.service.StartupChecks - cassandra.jmx.local.port
>>>> missing from cassandra-env.sh, unable to start local JMX service.
>>>> ERROR StatusLogger No log4j2 configuration file found. Using default
>>>> configuration: logging only errors to the console.
>>>>
>>>> Results :
>>>>
>>>> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
>>>>
>>>> [INFO]
>>>> [INFO] --- maven-failsafe-plugin:2.19.1:verify (verify) @ log4j-nosql
>>>> ---
>>>> [INFO] 
>>>> 
>>>> [INFO] Reactor Summary:
>>>> [INFO]
>>>> [INFO] Apache Log4j NoSQL . FAILURE [
>>>> 27.242 s]
>>>> [INFO] Apache Log4J Performance Tests . SKIPPED
>>>> [INFO] Apache Log4j Streaming Interface ... SKIPPED
>>>> [INFO] Apache Log4j JUL Adapter ... SKIPPED
>>>> [INFO] Apache Log4j Liquibase Binding . SKIPPED
>>>> [INFO] Apache Log4j Scala 2.10 wrapper for Log4j API .. SKIPPED
>>>> [INFO] 
>>>> 
>>>> [INFO] BUILD FAILURE
>>>> [INFO] 
>>>> 
>>>> [INFO] Total time: 29.063 s
>>>> [INFO] Finished at: 2017-02-03T11:00:55-08:00
>>>> [INFO] Final Memory: 49M/691M
>>>> [INFO] --------
>>>> 
>>>> [ERROR] Failed to execute goal 
>>>> org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:verify
>>>> (verify) on project log4j-nosql: There was a timeout or other error in the
>>>> fork -> [Help 1]
>>>> [ERROR]
>>>> [ERROR] To see the full stack trace of the errors, re-run Maven with
>>>> the -e switch.
>>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>>>> [ERROR]
>>>> [ERROR] For more information about the errors and possible solutions,
>>>> please read the following articles:
>>>> [ERROR] [Help 1] http://cwiki.apache.org/conflu
>>>> ence/display/MAVEN/MojoExecutionException
>>>>
>>>>

Re: RollingAppenderSizeTest failures

2017-02-03 Thread Gary Gregory
I hope running Cassandra on Windows is not a problem. I seems like a normal
set up:
https://www.datastax.com/2012/01/getting-started-with-apache-cassandra-on-windows-the-easy-way

G

On Fri, Feb 3, 2017 at 12:10 PM, Matt Sicker <boa...@gmail.com> wrote:

> That's strange. I never tested that integration test in Windows, so
> perhaps it's platform-specific? Anyways, the equivalent Mongo integration
> test is @Ignore'd due to requiring a running Mongo, and the Cassandra test
> works similarly although it starts up Cassandra within the JVM for you.
>
> On 3 February 2017 at 13:10, Gary Gregory <garydgreg...@gmail.com> wrote:
>
>> And if I ignore THAT OSGi test, I then fail in nosql :-(
>>
>> [INFO] --- maven-failsafe-plugin:2.19.1:integration-test
>> (integration-tests) @ log4j-nosql ---
>>
>> ---
>>  T E S T S
>> ---
>> Running org.apache.logging.log4j.nosql.appender.cassandra.CassandraA
>> ppenderIT
>> ERROR StatusLogger No log4j2 configuration file found. Using default
>> configuration: logging only errors to the console.
>> 11:00:39.333 [Log4j2-TF-1-Cassandra-1] ERROR
>> org.apache.cassandra.service.StartupChecks - cassandra.jmx.local.port
>> missing from cassandra-env.sh, unable to start local JMX service.
>> ERROR StatusLogger No log4j2 configuration file found. Using default
>> configuration: logging only errors to the console.
>>
>> Results :
>>
>> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
>>
>> [INFO]
>> [INFO] --- maven-failsafe-plugin:2.19.1:verify (verify) @ log4j-nosql ---
>> [INFO] 
>> 
>> [INFO] Reactor Summary:
>> [INFO]
>> [INFO] Apache Log4j NoSQL . FAILURE [
>> 27.242 s]
>> [INFO] Apache Log4J Performance Tests . SKIPPED
>> [INFO] Apache Log4j Streaming Interface ... SKIPPED
>> [INFO] Apache Log4j JUL Adapter ... SKIPPED
>> [INFO] Apache Log4j Liquibase Binding . SKIPPED
>> [INFO] Apache Log4j Scala 2.10 wrapper for Log4j API .. SKIPPED
>> [INFO] 
>> 
>> [INFO] BUILD FAILURE
>> [INFO] 
>> 
>> [INFO] Total time: 29.063 s
>> [INFO] Finished at: 2017-02-03T11:00:55-08:00
>> [INFO] Final Memory: 49M/691M
>> [INFO] 
>> 
>> [ERROR] Failed to execute goal 
>> org.apache.maven.plugins:maven-failsafe-plugin:2.19.1:verify
>> (verify) on project log4j-nosql: There was a timeout or other error in the
>> fork -> [Help 1]
>> [ERROR]
>> [ERROR] To see the full stack trace of the errors, re-run Maven with the
>> -e switch.
>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> [ERROR]
>> [ERROR] For more information about the errors and possible solutions,
>> please read the following articles:
>> [ERROR] [Help 1] http://cwiki.apache.org/conflu
>> ence/display/MAVEN/MojoExecutionException
>>
>> Thoughts?
>>
>> Gary
>>
>> On Fri, Feb 3, 2017 at 10:06 AM, Gary Gregory <garydgreg...@gmail.com>
>> wrote:
>>
>>> If I @Ignore that one test, then I get (mvn clean install):
>>>
>>> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.842
>>> sec - in org.apache.logging.log4j.osgi.tests.equinox.EquinoxLoadApiBu
>>> ndleTest
>>> at org.junit.internal.runners.statements.InvokeMethod.evaluate(
>>> InvokeMethod.java:17)
>>> at org.junit.internal.runners.statements.RunBefores.evaluate(Ru
>>> nBefores.java:26)
>>> at org.junit.rules.ExternalResource$1.evaluate(ExternalResource
>>> .java:48)
>>> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>>> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>>> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit
>>> 4ClassRunner.java:78)
>>> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit
>>> 4ClassRunner.java:57)
>>> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>>> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:
>>> 71)
>>> at org

  1   2   3   4   5   6   7   8   9   10   >