Re: Space at the end of a math inset
On Wed, May 08, 2002 at 06:54:10PM +0200, Lars Gullik Bjønnes wrote: | If there are more people who want that than there are who don't... Is this really a problem? Not a problem. Not for 1.2.0 at least... I'd say no. It saves a keystroke in common situations... the complaint is certainly valid... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: PATCH: fix bug 387
On 11-May-2002 John Levon wrote: This patch fixes #387 as the insettext should not call the edit() call for non highly editable insets. Yes, works for me. btw, the two-dialogs on right click bug is back *again* :( ??? Where? Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Every morning is a Smirnoff morning.
Re: Space at the end of a math inset
On Thu, May 09, 2002 at 09:33:51AM +0200, Juergen Vigna wrote: Not really as long as we document it. I agree completely. When should we change behaviour if not with a new release? The old behaviour was not wrong... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: Space at the end of a math inset
On Thu, May 09, 2002 at 02:42:42PM +0300, Dekel Tsur wrote: Here is a patch that fixes the problem. It is quite simple. I think a better way would be to return with 'UNDISPATCHED' from mathed's dispatch(). Otherwise you start putting mathed specific code (leave inset on space _is_ mathed specific) outside src/mathed. Not nice. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: Space at the end of a math inset
On 13-May-2002 Andre Poenitz wrote: On Thu, May 09, 2002 at 09:33:51AM +0200, Juergen Vigna wrote: Not really as long as we document it. I agree completely. When should we change behaviour if not with a new release? The old behaviour was not wrong... I didn't express my opinion about the space feature I just expressed my opinion about when is the time to eventually change behaviour and this surely is between releases (or with a new one) and not inside a release (in a minor upgrade). Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ The first 90% of a project takes 90% of the time, the last 10% takes the other 90% of the time.
Re: Space at the end of a math inset
On 13-May-2002 Andre Poenitz wrote: On Thu, May 09, 2002 at 02:42:42PM +0300, Dekel Tsur wrote: Here is a patch that fixes the problem. It is quite simple. I think a better way would be to return with 'UNDISPATCHED' from mathed's dispatch(). Otherwise you start putting mathed specific code (leave inset on space _is_ mathed specific) outside src/mathed. Not nice. We don't have the bases for this right now and it would mean changing also core code to do it! This was one of the reasons I did not give a positive answer when I heard about it. We would need a FINISHED_RIGHT | UNDISPATCHED status to do this, but I surely don't want to change this now. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Advertising is a valuable economic factor because it is the cheapest way of selling goods, particularly if the goods are worthless. -- Sinclair Lewis
Re: Tooltips.
-BEGIN PGP SIGNED MESSAGE- On Sunday 12 May 2002 20:33, Herbert Voss wrote: Joao Luis Meloni Assirati wrote: lyx-devel/src/frontends/xforms/ChangeLog said: 2002-05-09 Angus Leeming [EMAIL PROTECTED] * Tooltips.C: enable tooltips by default. I'm using the latest cvs version with xforms-0., and although my lyx comes up with the help-Tooltips button checked, tooltips don't show. In order to enable tooltips, I have to uncheck, then recheck the tooltips button. at this time the tooltips are only available for some gui's: Bibtex, Citation, Sendto and Texinfo And for this it works like expected for me But it is exactly like he is saying. The toolkits are enabled, only if one disables them first! And I am using xforms-0.89. Kornel - -- Kornel Benko [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: PGP 6.5.8 iQCVAwUBPN9vCLewfbDGmeqhAQGmowQAyWBcmpcXLhveihnfG5f9RehCAxIk1HnS P5Ms3kP2G2y2YMvEhHWAJB2NLI4FiMBwvewDewnvqByVFKCREhhX933MuhTjoWwZ W/GhCpy+YzF+TdD2ZfMdVXbo9QGvRzVM8Yz03hNGgWJ/9ftcPKSqGdsKAXSy5Fvx VPNJuNSFKeg= =yoE5 -END PGP SIGNATURE-
Re: crash when pasting formula...
On Saturday 11 May 2002 17:22, John Levon wrote: On Fri, May 10, 2002 at 10:56:38AM +0200, Piroux Geoffroy wrote: I don't know if this bug have been reported but I don't have time to check it: if you select an _entire_ row in a eqnarray and if you try to paste into an inline or a display formula the program crash. Obviously, this problem doesn't append when the row is not selected. I can't cause this to happen with current CVS. Can you give us some detialed steps to reproduce with a testcase ? thanks john
Re: crash when pasting formula...
On Saturday 11 May 2002 17:22, John Levon wrote: On Fri, May 10, 2002 at 10:56:38AM +0200, Piroux Geoffroy wrote: I don't know if this bug have been reported but I don't have time to check it: if you select an _entire_ row in a eqnarray and if you try to paste into an inline or a display formula the program crash. Obviously, this problem doesn't append when the row is not selected. I can't cause this to happen with current CVS. Can you give us some detialed steps to reproduce with a testcase ? thanks john The steps are as follow: 1) copy the content of an inline formula by Ctrl-c,it doesn't matter which one 2) create an empty eqnarray : Crtl-Shift-m followed by Ctrl-Enter 3) select with the mouse (or Shift-rightarrow) the three boxes in the eqnarray formula. The three boxes are now filled with blue 4) then paste the clipboard Ctrl-v For me lyx crash each time with the message at the console : out of memory Remark you can start directly from the second step, it carsh also. geo
Re: crash when pasting formula...
On Fri, May 10, 2002 at 10:56:38AM +0200, Piroux Geoffroy wrote: I don't know if this bug have been reported but I don't have time to check it: if you select an _entire_ row in a eqnarray and if you try to paste into an inline or a display formula the program crash. Obviously, this problem doesn't append when the row is not selected. I can't reproduce this. Could you please create detailed instructions on how to get the crash starting from an empty document? Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
citation observation
Insert a citation of the form
author={Odland, J. and Faulkner, D}
results in the citation box showing
Odl and Faulkner (1981)
This is both for the little button, and the Insert-Citation box.
The latex output is fine. Seems the citation box is matching on the and
part, for when to insert and in the box.
Rod
_
rpinna|Zoeggeler denies Hackl four straight luge golds
civil.uwa|
.edu.au | ABC news headline, 2002
[bugzilla-daemon@bugzilla.lyx.org: [Bug 396] New: mathed doesn't handle \multicolomn]
- Forwarded message from [EMAIL PROTECTED] -
Summary: mathed doesn't handle \multicolomn
Product: LyX
Version: 1.2.0pre1
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: mathed
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
QAContact: [EMAIL PROTECTED]
Let reLyX convert the following tex-document to a
lyx-document.\documentclass{article}\begin{document}\[ \begin{array}{rcl}1 + 2 = 3
\\\multicolumn{3}{c}{45 \leq 6 }\end{array} \]\end{document}lyx1.6fix4 will
handle the lyx-document, if you don't edit the formula.lyx1.2pre5 will insert the two
nonexistent columns ( ), and upset latex.This might seem to be a reLyX-Bug. But
\multicolumn is a sensible feature in an array environment, so mathed should be able
to handle it.
--- You are receiving this mail because: ---
While this _is_ a mathed problem this won't be fixed soon.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)
Re: [Devel] A few more bugs
Herbert Voss [EMAIL PROTECTED] writes:
| http://www.lyx.org/help/
| Index: src/frontends/controllers/biblio.C
| ===
| RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/controllers/biblio.C,v
| retrieving revision 1.25
| diff -u -r1.25 biblio.C
| --- src/frontends/controllers/biblio.C26 Apr 2002 14:35:04 - 1.25
| +++ src/frontends/controllers/biblio.C10 May 2002 12:04:42 -
| @@ -379,24 +379,36 @@
| string keyvalue;
| // at first we delete all characters right of '%' and
| // replace tabs through a space and remove leading spaces
| + // we read the data line by line so that the \n are
| + // ignored, too.
| string data_;
| int Entries = 0;
| string dummy = token(data,'\n', Entries);
| while (!dummy.empty()) {
| dummy = subst(dummy, '\t', ' ');// no tabs
| - dummy = frontStrip(dummy); // no leading spaces
| + dummy = frontStrip(dummy); // no leading spaces
| + // ignore lines with a beginning '%' or ignore all right of %
| string::size_type const idx =
| dummy.empty() ? string::npos : dummy.find('%');
| - if (idx != string::npos) {
| - // ignore lines with a beginning '%'
| - if (idx 0) {
| - data_ += dummy.substr(0,data.find('%'));
| - }
| - } else {
| - data_ += dummy;
| + if (idx != string::npos)
| + if (idx 0)// ignore all right of %
| + dummy = dummy.substr(
| + 0, dummy.length() - dummy.find('%'));
(What a horrible variable name...)
dummy.erase(dummy.find('%'), string::npos); // possibly + 1 or - 1
| + else// ignore all
| + dummy = ;
dummy.erase();
also this if clause is just not needed:
dummy.erase(idx, string::npos);
should cover it all.
| + // do we have a new token or a new line of
| + // the same one? In the first case we ignore
| + // the \n and in the second we replace it
| + // with a space
| + if (!dummy.empty()) {
| + if (!contains(dummy, =))
| + data_ += (' ' + dummy);
| + else
| + data_ += dummy;
This check looks wrong... what if dummy == =equal or equal=, it
does not seem that it is unimportant where in the string the '=' is.
| }
| dummy = token(data, '\n', ++Entries);
| }
| +
| // replace double commas with for easy scanning
| data = subst(data_, ,,, \\);
|
| @@ -409,9 +421,18 @@
| data += ','; // now we have same behaviour for all entries
| // because the last one is blah ... }
| Entries = 0;
| - dummy = token(data, ',', Entries);
| - while (!contains(lowercase(dummy), findkey) !dummy.empty())
| - dummy = token(data, ',', ++Entries);
| + bool found = false;
| + // parsing of title and booktitle is different from the
| + // others, because booktitle contains title
| + do {
| + dummy = token(data, ',', Entries++);
| + if (!dummy.empty()) {
| + found = contains(lowercase(dummy), findkey);
| + if (findkey == title
| + contains(lowercase(dummy), booktitle))
| + found = false;
| + }
| + } while (!found !dummy.empty());
| if (dummy.empty())
| // no such keyword
| return string();
| @@ -421,10 +442,10 @@
| // Therefore we read all until the next = character, which follows a
| // new keyword
| keyvalue = dummy;
| - dummy = token(data, ',', ++Entries);
| + dummy = token(data, ',', Entries++);
| while (!contains(dummy, '=') !dummy.empty()) {
| keyvalue += (',' + dummy);
| - dummy = token(data, ',', ++Entries);
| + dummy = token(data, ',', Entries++);
| }
|
| // replace double with originals ,, (two commas)
--
Lgb
Re: crash when pasting formula...
-BEGIN PGP SIGNED MESSAGE- On Monday 13 May 2002 09:56, Piroux Geoffroy wrote: The steps are as follow: 1) copy the content of an inline formula by Ctrl-c,it doesn't matter which one 2) create an empty eqnarray : Crtl-Shift-m followed by Ctrl-Enter 3) select with the mouse (or Shift-rightarrow) the three boxes in the eqnarray formula. The three boxes are now filled with blue 4) then paste the clipboard Ctrl-v I cannot reproduce it here. Selecting parts of the formula works ok. Selecting the whole formula does not work, but there is no crash. Kornel - -- Kornel Benko [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: PGP 6.5.8 iQCVAwUBPN92tLewfbDGmeqhAQEn9wQAkv8m1gZKe+HHgnj2fkgxx/IzzoJjwVMI ALIM9IED5JTQEsxMHmNAGaVUmKe7QDoLuNDt2e7zH8s9cuW0yusRBmi74cSDNLCc 9THNOe8YkkUGw0gYIVGoasfs5N0ZEx07pEWlIZ6xMzKf/oV4mwV1i+yWSYieredU YS70jnyiBYg= =plRU -END PGP SIGNATURE-
Re: compilation of lyx-1.2.0pre5
John Levon [EMAIL PROTECTED] writes: | p.s. I will find some time to test Jug's pending patches soon, | probably. That would be nice. -- Lgb
Re: obscure file conversion problem
Herbert Voss [EMAIL PROTECTED] writes: | Garst R. Reese wrote: Lars Gullik Bjønnes wrote: Did you test with different files with same name? In same dir and in different dirs? How does one make different files with same name in same dir? | that's very easy, with some kind of magic ... :-) I could have said same name except from extension. -- Lgb
Re: Space at the end of a math inset
On Mon, May 13, 2002 at 09:39:14AM +0200, Juergen Vigna wrote: We don't have the bases for this right now and it would mean changing also core code to do it! This was one of the reasons I did not give a positive answer when I heard about it. We would need a FINISHED_RIGHT | UNDISPATCHED status to do this, but I surely don't want to change this now. Indeed. So it's a WONT FIX for 1.2.0. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: Patch to bug #338
Dekel Tsur [EMAIL PROTECTED] writes:
| I think that this bug is critical, since a 1.1.6 document that contains
| an URL inset inside footnote inside \author{}, will not work in 1.2.0!
Get some people to test it and then we'll see.
--
Lgb
Re: PATCH: fix bug 387
John Levon [EMAIL PROTECTED] writes: | On Thu, May 09, 2002 at 03:23:44PM +0200, Juergen Vigna wrote: This patch fixes #387 as the insettext should not call the edit() call for non highly editable insets. | Yes, works for me. | btw, the two-dialogs on right click bug is back *again* :( Caused by this patch? -- Lgb
Re: crash when pasting formula...
On Mon, May 13, 2002 at 09:56:49AM +0200, Piroux Geoffroy wrote:
For me lyx crash each time with the message at the console : out of memory
Remark you can start directly from the second step, it carsh also.
Ok, I see it now. The attached patch should fix the crash.
There is a user-unfriendly part in it as it does not erease the contents of
the selection first, but this would either meen copying almost everything
from erase() to paste() or to fiddle around with the cutpaste mechanism
which is the correct way but I won't do right now.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)
Index: math_cursor.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/math_cursor.C,v
retrieving revision 1.258
diff -u -p -r1.258 math_cursor.C
--- math_cursor.C 8 May 2002 16:17:57 - 1.258
+++ math_cursor.C 13 May 2002 08:34:45 -
-130,7 +130,7 struct Selection
{
if (data_.nargs() == 1) {
// single cell/part of cell
- cursor.insert(data_.cell(0));
+ cursor.paste(data_.cell(0));
} else {
// mulitple cells
idx_type idx; // index of upper left cell
Re: PATCH: fix bug 387
On 13-May-2002 Lars Gullik Bjønnes wrote:
John Levon [EMAIL PROTECTED] writes:
| On Thu, May 09, 2002 at 03:23:44PM +0200, Juergen Vigna wrote:
This patch fixes #387 as the insettext should not call the edit() call
for non highly editable insets.
| Yes, works for me.
| btw, the two-dialogs on right click bug is back *again* :(
Caused by this patch?
I don't think so. InsetCollapsable::insetButtonRelease() is returning
false when it should return the variable ret, which tells us that
a sub-inset already opened a layout dialog.
I commited this fix:
Index: src/insets/insetcollapsable.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insetcollapsable.C,v
retrieving revision 1.105
diff -u -p -r1.105 insetcollapsable.C
--- src/insets/insetcollapsable.C 9 May 2002 13:43:39 - 1.105
+++ src/insets/insetcollapsable.C 13 May 2002 08:46:53 -
@@ -355,7 +355,7 @@ bool InsetCollapsable::insetButtonReleas
if ((button == 3) !ret) {
return showInsetDialog(bv);
}
- return false;
+ return ret;
}
Jug
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Don't despair; your ideal lover is waiting for you around the corner.
Re: Space at the end of a math inset
Andre Poenitz [EMAIL PROTECTED] writes: | On Wed, May 08, 2002 at 06:54:10PM +0200, Lars Gullik Bjønnes wrote: | If there are more people who want that than there are who don't... Is this really a problem? | Not a problem. Not for 1.2.0 at least... I'd say no. | It saves a keystroke in common situations... the complaint is certainly | valid... If it is a one-liner to fix, then ok, else no. -- Lgb
Re: PATCH: fix bug 387
On 13-May-2002 Lars Gullik Bjønnes wrote: And that also helped the bug-reporters? ??? I don't understand what you mean here. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Live in a world of your own, but always welcome visitors.
Re: PATCH: fix bug 387
Juergen Vigna [EMAIL PROTECTED] writes: | On 13-May-2002 Lars Gullik Bjønnes wrote: And that also helped the bug-reporters? | ??? I don't understand what you mean here. A double-open bug was reproted, you claim that the patch you checked in should fix this, and I wonder it got fixed for the original reporter as well. -- Lgb
Re: PATCH: fix bug 387
On 13-May-2002 Lars Gullik Bjønnes wrote: | ??? I don't understand what you mean here. A double-open bug was reproted, you claim that the patch you checked in should fix this, and I wonder it got fixed for the original reporter as well. I fail to see the double open bug? What bugs are you refering too? If you mean that there is another bug open which tells us that we're only opening the tabular-layout if we click on a insetUrl in another cell then this is a different matter and in a sense it is not a bug (but have a look at the comments). Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ A box without hinges, key, or lid, Yet golden treasure inside is hid. -- J.R.R. Tolkien
Re: PATCH: fix bug 387
Juergen Vigna [EMAIL PROTECTED] writes: | On 13-May-2002 Lars Gullik Bjønnes wrote: | ??? I don't understand what you mean here. A double-open bug was reproted, you claim that the patch you checked in should fix this, and I wonder it got fixed for the original reporter as well. | I fail to see the double open bug? What bugs are you refering too? | If you mean that there is another bug open which tells us that we're | only opening the tabular-layout if we click on a insetUrl in another | cell then this is a different matter and in a sense it is not a bug | (but have a look at the comments). Ok, then I want to know what problem, and when it can be triggered, the patch that you committed fixed. -- Lgb
Re: PATCH: fix bug 387
On 13-May-2002 Lars Gullik Bjønnes wrote: | I fail to see the double open bug? What bugs are you refering too? | If you mean that there is another bug open which tells us that we're | only opening the tabular-layout if we click on a insetUrl in another | cell then this is a different matter and in a sense it is not a bug | (but have a look at the comments). Ok, then I want to know what problem, and when it can be triggered, the patch that you committed fixed. I closed the bug after commiting the fix, there was also a testcase there. The bug was #395. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ All the world's a stage and most of us are desperately unrehearsed. -- Sean O'Casey
RE: Assorted pre5 issues
On 13-May-2002 Walter H. van Holst wrote: - Searching text is incredibly slow. The whole searching process seems to be displayed in slow-motion, including expansion and collapsing all footnotes. We know and this will probably not change for 1.2.x. - I have managed to freeze LyX by selecting a bunch of paragraphs, changing it from 'normal' to 'enumerate', selecting one item, changing it to 'itemize' and then selecting the whole group again, changing it to 'itemize'. Well here we need an example .lyx file and a receipt to trigger the bug otherwise it's quite impossible to fix it. Thanks anyway for your comments! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ But Huey, you PROMISED! Tell 'em I lied.
1.2.0 (again)
Could we get that beast out the door _now_ _or_ revoke the freeze? If necessary, declare 1.2 unstable and broken (we know it is not, but it is not perfect either...) We have not had real progress for three months or so, and quite a few bug fixes submitted during this time were in fact clumsy workarounds instead of real solutions adding to the trouble to get it Right later. The current freeze is hurting (at least me) much more than having no 1.2 whatsoever. I am fairly convinced that we would have a better CVS version today if we had just kept moving as in the months before the freeze had there been not that goal of a perfect 1.2 hanging around. Basically we wasted three months of time to gain ... well... what exactly? A few annoyed developpers is the biggest chunk I can see. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: Space at the end of a math inset
Andre Poenitz [EMAIL PROTECTED] writes: | On Mon, May 13, 2002 at 01:00:28PM +0300, Dekel Tsur wrote: Indeed. So it's a WONT FIX for 1.2.0. I disagree. Removing this feature in 1.2.0 and adding it back in 1.3.0 will cause confusion to the users. I agree that the code in my patch is not pretty. So what? | *shrug* | You have a point, Lars has a point. | If it were not freezing I'd go for a proper fix. Actually, I don't think | your fix (ugly or not) would hurt right now, but if we start putting | patches that big in again, we won't have a 1.2 in the next century. | Right now I consider 1.2 as a release for the masses (i.e. text-only | people) and there is enough wrong with the math stuff that I'd expect | heavy math users to switch to 1.3 CVS anyway. | So I'd just leave it as it is and press for a short 1.3 cycle... Agree. -- Lgb
Re: 1.2.0 (again)
Andre Poenitz [EMAIL PROTECTED] writes: | Could we get that beast out the door _now_ _or_ revoke the freeze? | If necessary, declare 1.2 unstable and broken (we know it is not, but | it is not perfect either...) | We have not had real progress for three months or so, and quite a few | bug fixes submitted during this time were in fact clumsy workarounds | instead of real solutions adding to the trouble to get it Right later. | The current freeze is hurting (at least me) much more than having no 1.2 | whatsoever. | I am fairly convinced that we would have a better CVS version today if we | had just kept moving as in the months before the freeze had there been not | that goal of a perfect 1.2 hanging around. Basically we wasted three | months of time to gain ... well... what exactly? A few annoyed developpers | is the biggest chunk I can see. I have a couple of patches from Jürgen that I want in. But IMHO we are there now, but of course IMHO we have been there for weeks... -- Lgb
Re: 1.2.0 (again)
On Mon, May 13, 2002 at 12:44:46PM +0200, Lars Gullik Bjønnes wrote: I have a couple of patches from Jürgen that I want in. But IMHO we are there now, but of course IMHO we have been there for weeks... Put them in, wait three days, release it. And if Juergen's patches break anything, hit him hard with a big stick in Porto. Or make him pay the beer or so... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Which patches for 1.2.0
? .math_cursor.h.swp
? .math_hullinset.C.swp
Index: math_cursor.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/math_cursor.C,v
retrieving revision 1.257
diff -u -p -r1.257 math_cursor.C
--- math_cursor.C 22 Apr 2002 16:31:14 - 1.257
+++ math_cursor.C 8 May 2002 08:13:05 -
@@ -16,6 +16,7 @@
*/
#include config.h
+#include lyxrc.h
#ifdef __GNUG__
#pragma implementation
@@ -436,6 +437,7 @@ void MathCursor::plainInsert(MathAtom co
void MathCursor::insert(char c, MathTextCodes t)
{
//lyxerr inserting ' c '\n;
+ selClearOrDel();
plainInsert(MathAtom(new MathCharInset(c, t)));
}
@@ -454,7 +456,7 @@ void MathCursor::insert(MathAtom const
if (t-nargs())
selCut();
else
- selDel();
+ selClearOrDel();
}
plainInsert(t);
@@ -653,7 +655,7 @@ void MathCursor::selCopy()
dump(selCopy);
if (selection_) {
theSelection.grab(*this);
- selClear();
+ //selClear();
}
}
@@ -686,6 +688,7 @@ void MathCursor::selDel()
void MathCursor::selPaste()
{
dump(selPaste);
+ selClearOrDel();
theSelection.paste(*this);
//theSelection.grab(*this);
//selClear();
@@ -720,6 +723,15 @@ void MathCursor::selClear()
}
+void MathCursor::selClearOrDel()
+{
+ if (lyxrc.auto_region_delete)
+ selDel();
+ else
+ selClear();
+}
+
+
void MathCursor::selGet(MathArray ar)
{
dump(selGet);
@@ -1475,12 +1487,13 @@ bool MathCursor::interpret(char c)
return true;
}
- if (selection_) {
+ // just clear selection on pressing the space par
+ if (selection_ c == ' ') {
selClear();
- if (c == ' ')
- return true;
- // fall through in the other cases
+ return true;
}
+
+ selClearOrDel();
if (lastcode_ == LM_TC_TEXTRM || par()-asBoxInset()) {
// suppress direct insertion of two spaces in a row
Index: math_cursor.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/math_cursor.h,v
retrieving revision 1.104
diff -u -p -r1.104 math_cursor.h
--- math_cursor.h 26 Mar 2002 12:38:59 - 1.104
+++ math_cursor.h 8 May 2002 08:13:05 -
@@ -148,6 +148,8 @@ public:
void selStart();
///
void selClear();
+ /// clears or deletes selection depending on lyxrc setting
+ void selClearOrDel();
///
void selGet(MathArray ar);
///
bug338patch.gz
Description: GNU Zip compressed data
bug394patch.gz
Description: GNU Zip compressed data
bug394patch2.gz
Description: GNU Zip compressed data
Index: src/buffer.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/buffer.C,v
retrieving revision 1.334
diff -u -p -r1.334 buffer.C
--- src/buffer.C 8 May 2002 12:58:14 - 1.334
+++ src/buffer.C 10 May 2002 07:49:28 -
@@ -284,10 +284,11 @@ string last_inset_read;
#ifndef NO_COMPABILITY
struct ErtComp
{
- ErtComp() : active(false), in_tabular(false) {
+ ErtComp() : active(false), fromlayout(false), in_tabular(false) {
}
string contents;
bool active;
+ bool fromlayout;
bool in_tabular;
LyXFont font;
};
@@ -320,6 +321,7 @@ bool Buffer::readLyXformat2(LyXLex lex
#ifndef NO_COMPABILITY
ert_comp.contents.erase();
ert_comp.active = false;
+ ert_comp.fromlayout = false;
ert_comp.in_tabular = false;
#endif
int pos = 0;
@@ -401,16 +403,55 @@ bool Buffer::readLyXformat2(LyXLex lex
#ifndef NO_COMPABILITY
+
+Inset * Buffer::isErtInset(Paragraph * par, int pos) const
+{
+ Inset * inset;
+ if ((par-getChar(pos) == Paragraph::META_INSET)
+ (inset = par-getInset(pos))
+ (inset-lyxCode() == Inset::ERT_CODE))
+ {
+ return inset;
+ }
+ return 0;
+}
+
void Buffer::insertErtContents(Paragraph * par, int pos, bool set_inactive)
{
- if (!ert_comp.contents.empty()) {
+ string str = frontStrip(strip(ert_comp.contents, ' '), ' ');
+ if (!str.empty()) {
lyxerr[Debug::INSETS] ERT contents:\n'
- ert_comp.contents ' endl;
- Inset * inset = new InsetERT(params, params.language,
- ert_comp.contents, true);
- par-insertInset(pos++, inset, ert_comp.font);
- ert_comp.contents.erase();
+ str ' endl;
+ // check if we have already an ert inset a position earlier
+ // if this is the case then we should insert the contents
+ // inside the other ertinset as it is stupid to have various
+ // ert in a row.
+ Inset * inset;
+ if ((pos 0) (inset=isErtInset(par, pos-1))) {
+ // get the last paragraph from the inset before
+ Paragraph * last = inset-firstParagraph();
+ while(last-next())
+last = last-next();
+ // create the new paragraph after the last one
+ Paragraph * par = new Paragraph(last);
+ par-layout(textclasslist[params.textclass].defaultLayoutName());
+ par-setInsetOwner(last-inInset());
+ // set the contents
+ LyXFont font(LyXFont::ALL_INHERIT, params.language);
+ string::const_iterator cit = str.begin();
+ string::const_iterator end = str.end();
+ pos_type pos = 0;
+ for (; cit != end;
Re: Which patches for 1.2.0
[I wonder where that text I added on that mail went] These are the patches that I am considering for 1.2.0, and I really like to _not_ apply as many as possible of them. Which of those patches are _really_ needed? -- Lgb
Re: crash when pasting formula...
Andre Poenitz [EMAIL PROTECTED] writes: | On Mon, May 13, 2002 at 09:56:49AM +0200, Piroux Geoffroy wrote: For me lyx crash each time with the message at the console : out of memory Remark you can start directly from the second step, it carsh also. | Ok, I see it now. The attached patch should fix the crash. Missing changelog. -- Lgb
Re: Patch to bug #338
Dekel Tsur [EMAIL PROTECTED] writes:
| I think that this bug is critical, since a 1.1.6 document that contains
| an URL inset inside footnote inside \author{}, will not work in 1.2.0!
Missing changelog for the buffer changes.
--
Lgb
Re: Patch: Fix problem with spanish
Dekel Tsur [EMAIL PROTECTED] writes: | Lyx put the language extra options in the preamble before loading babel. | The attached patch fixes this bug. Missing changelog. -- Lgb
Re: auto delete region
Andre Poenitz [EMAIL PROTECTED] writes: | I've come up with a patch of my own. Would be nice if someone else could | try it out and report success or not. I think I won't apply the previous | ione as it does not catch all cases as far as I can tell. Missing changelog. -- Lgb
Re: pre5
Juergen Vigna [EMAIL PROTECTED] writes: | On 07-May-2002 Lars Gullik Bjønnes wrote: | What about the patch for the indent paragraph code I sent? I didn't | see any comments from you? Can you please send it again so I have an updated version? | Here we go. Missing changelog. -- Lgb
Re: 1.2.0 (again)
On 13-May-2002 Lars Gullik Bjønnes wrote: | I am fairly convinced that we would have a better CVS version today if we | had just kept moving as in the months before the freeze had there been not | that goal of a perfect 1.2 hanging around. Basically we wasted three | months of time to gain ... well... what exactly? A few annoyed developpers | is the biggest chunk I can see. I would say IMO your partly right. A lot of the fixes I made where real fixes which I would have done in 1.3.0 asup. I have a couple of patches from Jürgen that I want in. But IMHO we are there now, but of course IMHO we have been there for weeks... That was my thinking always. We will have a 1.2.1 and maybe later fix releases, but I think we did the right thing to fix at least the worst of the official bugs BEFORE releasing 1.2.0. Maybe I would not have spent that much effort in makeing 1.2.0 better if I could have worked on a 1.3.0. Then maybe we would have things in like in 1.1.6 which cannot be fixed in fix releases because the need too much changes to the code. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Actually, what I'd like is a little toy spaceship!!
RE: Which patches for 1.2.0
On 13-May-2002 Lars Gullik Bjønnes wrote: These are the patches under consideration: The only patches I have open are: (real bugfixes which should go in IMO) fixbug387.patch fixbug390.patch And one which you decided should go in only in 1.2.1: ertlabel.patch Some of the patches you have in the list are already in: ertcomp6.patch parindent.patch I would also like the patch of Dekel for the deault float placement in the Dialog, but if you don't like it we can put it inside 1.2.1 also. The one fixing the output in \thanks should go inside 1.2.0 IMO For others I cannot say. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Adding sound to movies would be like putting lipstick on the Venus de Milo. -- actress Mary Pickford, 1925
Re: [Devel] A few more bugs
Lars Gullik Bjønnes wrote:
| + if (idx != string::npos)
| + if (idx 0)// ignore all right of %
| + dummy = dummy.substr(
| + 0, dummy.length() - dummy.find('%'));
(What a horrible variable name...)
look into text.C, then you see what's horrible ...
dummy.erase(dummy.find('%'), string::npos); // possibly + 1 or - 1
| + else// ignore all
| + dummy = ;
dummy.erase();
also this if clause is just not needed:
dummy.erase(idx, string::npos);
should cover it all.
seems so, but it does bang with this line
dummy.erase(dummy.find('%'), string::npos);
lyx: /usr/include/g++/std/bastring.cc:192: class
basic_stringchar,string_char_traitschar,__default_alloc_templatetrue,0
basic_stringchar,string_char_traitschar,__default_alloc_templatetrue,0
::replace(unsigned int, unsigned int, unsigned int, char): Assertion
`!(pos len)' failed.
Aborted
| + // do we have a new token or a new line of
| + // the same one? In the first case we ignore
| + // the \n and in the second we replace it
| + // with a space
| + if (!dummy.empty()) {
| + if (!contains(dummy, =))
| + data_ += (' ' + dummy);
| + else
| + data_ += dummy;
This check looks wrong... what if dummy == =equal or equal=, it
does not seem that it is unimportant where in the string the '=' is.
I do not understand. I want to know if there is a =, nothing
more
Herbert
--
http://www.lyx.org/help/
Re: [Devel] A few more bugs
Herbert Voss [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| + if (idx != string::npos) | +if
(idx 0)// ignore all right of %
| + dummy = dummy.substr(
| + 0, dummy.length() - dummy.find('%'));
(What a horrible variable name...)
| look into text.C, then you see what's horrible ...
dummy.erase(dummy.find('%'), string::npos); // possibly + 1 or - 1
| + else// ignore all
| + dummy = ;
dummy.erase();
also this if clause is just not needed:
dummy.erase(idx, string::npos);
should cover it all.
| seems so, but it does bang with this line
| dummy.erase(dummy.find('%'), string::npos);
if (idx != string::npos)
dummy.erase(idx);
--
Lgb
Re: pre5
On Mon, May 13, 2002 at 02:01:23PM +0200, Lars Gullik Bjønnes wrote: Missing changelog. Hm... looks as if I was mis-interpreting missing changelog as ok to apply if ChangeLog is written as well Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: [Devel] A few more bugs
Herbert Voss [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| + if (idx != string::npos) | +if
(idx 0)// ignore all right of %
| + dummy = dummy.substr(
| + 0, dummy.length() - dummy.find('%'));
(What a horrible variable name...)
| look into text.C, then you see what's horrible ...
With regard to variable names?
--
Lgb
Re: [Devel] A few more bugs
Lars Gullik Bjønnes wrote:
Herbert Voss [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| + if (idx != string::npos) | +if
(idx 0)// ignore all right of %
| + dummy = dummy.substr(
| + 0, dummy.length() - dummy.find('%'));
(What a horrible variable name...)
| look into text.C, then you see what's horrible ...
With regard to variable names?
to everything
Herbert
--
http://www.lyx.org/help/
Re: [Devel] A few more bugs
a new patch which also fices the bug from
http://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg37844.html
Herbert
--
http://www.lyx.org/help/
Index: src/frontends/controllers/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/controllers/ChangeLog,v
retrieving revision 1.172
diff -u -r1.172 ChangeLog
--- src/frontends/controllers/ChangeLog 1 May 2002 14:43:37 - 1.172
+++ src/frontends/controllers/ChangeLog 13 May 2002 12:52:16 -
@@ -1,3 +1,11 @@
+2002-05-13 Herbert Voss [EMAIL PROTECTED]
+
+ * biblio.C (getAbbreviatedAuthor): fix bug with and for Authors
+ like Odland, G. and ...
+ (parseBibTeX): fix bug with title and booktitle
+ and replace a \n with a space when one entry has more than
+ one line
+
2002-05-01 Angus Leeming [EMAIL PROTECTED]
* ControlCharacter.C: use ignore and reset as the identifiers, not
Index: src/frontends/controllers/biblio.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/controllers/biblio.C,v
retrieving revision 1.25
diff -u -r1.25 biblio.C
--- src/frontends/controllers/biblio.C 26 Apr 2002 14:35:04 - 1.25
+++ src/frontends/controllers/biblio.C 13 May 2002 12:52:16 -
@@ -205,7 +205,7 @@
return author;
}
- vectorstring authors = getVectorFromString(author, and);
+ vectorstring authors = getVectorFromString(author, and);
if (!authors.empty()) {
author.erase();
@@ -379,24 +379,32 @@
string keyvalue;
// at first we delete all characters right of '%' and
// replace tabs through a space and remove leading spaces
+ // we read the data line by line so that the \n are
+ // ignored, too.
string data_;
int Entries = 0;
string dummy = token(data,'\n', Entries);
while (!dummy.empty()) {
dummy = subst(dummy, '\t', ' ');// no tabs
- dummy = frontStrip(dummy); // no leading spaces
+ dummy = frontStrip(dummy); // no leading spaces
+ // ignore lines with a beginning '%' or ignore all right of %
string::size_type const idx =
dummy.empty() ? string::npos : dummy.find('%');
- if (idx != string::npos) {
- // ignore lines with a beginning '%'
- if (idx 0) {
- data_ += dummy.substr(0,data.find('%'));
- }
- } else {
- data_ += dummy;
+ if (idx != string::npos)
+ dummy.erase(idx, string::npos);
+ // do we have a new token or a new line of
+ // the same one? In the first case we ignore
+ // the \n and in the second we replace it
+ // with a space
+ if (!dummy.empty()) {
+ if (!contains(dummy, =))
+ data_ += (' ' + dummy);
+ else
+ data_ += dummy;
}
dummy = token(data, '\n', ++Entries);
}
+
// replace double commas with for easy scanning
data = subst(data_, ,,, \\);
@@ -409,9 +417,18 @@
data += ','; // now we have same behaviour for all entries
// because the last one is blah ... }
Entries = 0;
- dummy = token(data, ',', Entries);
- while (!contains(lowercase(dummy), findkey) !dummy.empty())
- dummy = token(data, ',', ++Entries);
+ bool found = false;
+ // parsing of title and booktitle is different from the
+ // others, because booktitle contains title
+ do {
+ dummy = token(data, ',', Entries++);
+ if (!dummy.empty()) {
+ found = contains(lowercase(dummy), findkey);
+ if (findkey == title
+ contains(lowercase(dummy), booktitle))
+ found = false;
+ }
+ } while (!found !dummy.empty());
if (dummy.empty())
// no such keyword
return string();
@@ -421,10 +438,10 @@
// Therefore we read all until the next = character, which follows a
// new keyword
keyvalue = dummy;
- dummy = token(data, ',', ++Entries);
+ dummy = token(data, ',', Entries++);
while (!contains(dummy, '=') !dummy.empty()) {
keyvalue += (',' + dummy);
- dummy = token(data, ',', ++Entries);
+ dummy = token(data, ',', Entries++);
}
// replace double with originals ,, (two commas)
Re: [Devel] A few more bugs
Herbert Voss [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
Herbert Voss [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| + if (idx != string::npos) | +if
(idx 0) // ignore all right of %
| + dummy = dummy.substr(
| + 0, dummy.length() - dummy.find('%'));
(What a horrible variable name...)
| look into text.C, then you see what's horrible ...
With regard to variable names?
| to everything
Then it is not a relevant answer to my critisim.
--
Lgb
Re: pre5
Andre Poenitz [EMAIL PROTECTED] writes: | On Mon, May 13, 2002 at 02:01:23PM +0200, Lars Gullik Bjønnes wrote: Missing changelog. | Hm... looks as if I was mis-interpreting missing changelog as ok to | apply if ChangeLog is written as well That is kindo correct, but I also want(ed) it applied in a way so that it is easy to revert the patch if needed. -- Lgb
FWD: [Bug 393] Text remains selected after paste.
Well I think I'm not able to reply him. So the ones which regarded this as being the choosen way may be able to reply him. Jug -Fwd: [EMAIL PROTECTED]- Date: 13 May 2002 12:32:52 - From: bugzilla-daemon [EMAIL PROTECTED] To: jug [EMAIL PROTECTED] Subject: [Bug 393] Text remains selected after paste. http://bugzilla.lyx.org/show_bug.cgi?id=393 --- Additional Comments From [EMAIL PROTECTED] 2002-05-14 00:32 --- Well, if you just check all the text editors available, or the most popular ones, can you please find how many have that select after paste feature? Can you please ask people who want this feature to explain what exactly the editing actions that require the feature? If you follow the discussion on the user list, many people have agreed this is at least a very annoying feature. Thank you. --End of forwarded message- -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ I don't know who my grandfather was; I am much more concerned to know what his grandson will be. -- Abraham Lincoln
Re: crash when pasting formula...
On Monday 13 May 2002 10:37, Andre Poenitz wrote: On Mon, May 13, 2002 at 09:56:49AM +0200, Piroux Geoffroy wrote: For me lyx crash each time with the message at the console : out of memory Remark you can start directly from the second step, it carsh also. Ok, I see it now. The attached patch should fix the crash. well, there is no more crash. thanks, geo -- Institut de Physique Théorique Université Catholique de Louvain 2, chemin du Cyclotron B-1348 Louvain-la-Neuve, Belgium Tel.: +32.10.47.32.79 - Fax : +32.10.47.24.14 mailto:[EMAIL PROTECTED] ~ 'v' // \\ Powered by GNU/Linux-ppc. /( )\ http://lfs.linux-provider.net/ #112 ^'^
Re: Which patches for 1.2.0
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
These are now the patches up for consideration,
Id like to know which ones are tested and working, and also absolutely
needed in 1.2.0. Several of these also miss a Changelog.
? .math_cursor.h.swp
? .math_hullinset.C.swp
Index: math_cursor.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/math_cursor.C,v
retrieving revision 1.257
diff -u -p -r1.257 math_cursor.C
--- math_cursor.C 22 Apr 2002 16:31:14 - 1.257
+++ math_cursor.C 8 May 2002 08:13:05 -
@@ -16,6 +16,7 @@
*/
#include config.h
+#include lyxrc.h
#ifdef __GNUG__
#pragma implementation
@@ -436,6 +437,7 @@ void MathCursor::plainInsert(MathAtom co
void MathCursor::insert(char c, MathTextCodes t)
{
//lyxerr inserting ' c '\n;
+ selClearOrDel();
plainInsert(MathAtom(new MathCharInset(c, t)));
}
@@ -454,7 +456,7 @@ void MathCursor::insert(MathAtom const
if (t-nargs())
selCut();
else
- selDel();
+ selClearOrDel();
}
plainInsert(t);
@@ -653,7 +655,7 @@ void MathCursor::selCopy()
dump(selCopy);
if (selection_) {
theSelection.grab(*this);
- selClear();
+ //selClear();
}
}
@@ -686,6 +688,7 @@ void MathCursor::selDel()
void MathCursor::selPaste()
{
dump(selPaste);
+ selClearOrDel();
theSelection.paste(*this);
//theSelection.grab(*this);
//selClear();
@@ -720,6 +723,15 @@ void MathCursor::selClear()
}
+void MathCursor::selClearOrDel()
+{
+ if (lyxrc.auto_region_delete)
+ selDel();
+ else
+ selClear();
+}
+
+
void MathCursor::selGet(MathArray ar)
{
dump(selGet);
@@ -1475,12 +1487,13 @@ bool MathCursor::interpret(char c)
return true;
}
- if (selection_) {
+ // just clear selection on pressing the space par
+ if (selection_ c == ' ') {
selClear();
- if (c == ' ')
- return true;
- // fall through in the other cases
+ return true;
}
+
+ selClearOrDel();
if (lastcode_ == LM_TC_TEXTRM || par()-asBoxInset()) {
// suppress direct insertion of two spaces in a row
Index: math_cursor.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/math_cursor.h,v
retrieving revision 1.104
diff -u -p -r1.104 math_cursor.h
--- math_cursor.h 26 Mar 2002 12:38:59 - 1.104
+++ math_cursor.h 8 May 2002 08:13:05 -
@@ -148,6 +148,8 @@ public:
void selStart();
///
void selClear();
+ /// clears or deletes selection depending on lyxrc setting
+ void selClearOrDel();
///
void selGet(MathArray ar);
///
bug338patch.gz
Description: GNU Zip compressed data
bug394patch.gz
Description: GNU Zip compressed data
bug394patch2.gz
Description: GNU Zip compressed data
Index: src/insets/insettext.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insettext.C,v
retrieving revision 1.291
diff -u -p -r1.291 insettext.C
--- src/insets/insettext.C 1 May 2002 22:17:08 - 1.291
+++ src/insets/insettext.C 9 May 2002 13:22:05 -
@@ -695,7 +695,10 @@ void InsetText::edit(BufferView * bv, in
lt = getLyXText(bv);
clear = true;
}
- if (!checkAndActivateInset(bv, x, tmp_y, button)) {
+ // we put here -1 and not button as now the button in the
+ // edit call should not be needed we will fix this in 1.3.x
+ // cycle hopefully (Jug 20020509)
+ if (!checkAndActivateInset(bv, x, tmp_y, -1)) {
lt-setCursorFromCoordinates(bv, x - drawTextXOffset,
y + insetAscent);
lt-cursor.x_fix(lt-cursor.x());
@@ -2067,7 +2070,12 @@ bool InsetText::checkAndActivateInset(Bu
int dummyx = x;
int dummyy = y + insetAscent;
Inset * inset = bv-checkInsetHit(getLyXText(bv), dummyx, dummyy);
-
+ // we only do the edit() call if the inset was hit by the mouse
+ // or if it is a highly editable inset. So we should call this
+ // function from our own edit with button 0.
+ if (button 0 !isHighlyEditableInset(inset))
+ return false;
+
if (inset) {
if (x 0)
x = insetWidth;
Index: src/text.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v
retrieving revision 1.247
diff -u -p -r1.247 text.C
--- src/text.C 8 May 2002 12:58:16 - 1.247
+++ src/text.C 9 May 2002 14:58:59 -
@@ -1755,6 +1755,12 @@ void LyXText::breakParagraph(BufferView
keep_layout = 2;
else
keep_layout = layout.isEnvironment();
+
+ // we need to set this before we insert the paragraph. IMO the
+ // breakParagraph call should return a bool if it inserts the
+ // paragraph before or behind and we should react on that one
+ // but we can fix this in 1.3.0 (Jug 20020509)
+ bool const isempty = (layout.keepempty !cursor.par()-size());
cursor.par()-breakParagraph(bview-buffer()-params, cursor.pos(),
keep_layout);
@@ -1807,7 +1813,7 @@ void LyXText::breakParagraph(BufferView
/* This check is necessary. Otherwise the new
Re: Which patches for 1.2.0
On 13-May-2002 Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: These are now the patches up for consideration, Id like to know which ones are tested and working, and also absolutely needed in 1.2.0. Several of these also miss a Changelog. Well same as my previous mail. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Don't you wish you had more energy... or less ambition?
Re: Which patches for 1.2.0
Juergen Vigna [EMAIL PROTECTED] writes: | On 13-May-2002 Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: These are now the patches up for consideration, Id like to know which ones are tested and working, and also absolutely needed in 1.2.0. Several of these also miss a Changelog. | Well same as my previous mail. And do you have ChangeLogs in all of yours? -- Lgb
Symlink bug
Dear LyX-developers,
LyX 1.2.0cvs still does abort if the binary is called via a relative(!)
symbolic link. I've the following directory structure:
/usr/local/bin/: lyx-1.2.0 - ../stow/lyx-1.2.0/bin/lyx-1.2.0
/usr/local/stow/lyx-1.2.0/bin/: lyx-1.2.0
(LyX was configured with --prefix=/usr/local/stow/lyx-1.2.0, the
symbolic link was created by GNU stow.)
Invoking lyx-1.2.0 /usr/local/bin/lyx-1.2.0 with a current working
directory which is not(!) /usr/local/bin leads to an Abort due to a failed
assertion which was triggered in:
FileInfo.C:
bool FileInfo::isLink() const
{
lyx::Assert(isOK());
return S_ISLNK(buf.st_mode);
}
isLink is called in the first iteration of the following do ... while loop:
lyx_main.C:
void LyX::init(bool gui)
{
...bool followlink;
do {
// Path of binary/../share/name of binary/
searchpath += NormalizePath(AddPath(binpath, ../share/) +
OnlyFilename(binname)) + ';';
Bug manifests here:
// Follow Symlinks
FileInfo file(fullbinpath, true); - fullbinpath is
../stow/lyx-1.2.0/bin/lyx-1.2.0
followlink = file.isLink(); - Triggers failing assertion
This code is never reached:
if (followlink) {
lyxerr directory fullbinpath
is a link endl;
string link;
if (LyXReadLink(fullbinpath, link)) {
fullbinpath = link;
binpath = MakeAbsPath(OnlyPath(fullbinpath));
}
else {
followlink = false;
}
}
} while (followlink);
...
}
The constructor of FileInfo yields an internal errors status
which is triggered when calling isLink afterwards.
I suppose the problem is that, when lstat is invoked in the
constructor of FileInfo the current working directory is
not the one to which the relative symlink is relative to and
therefore lstat fails.
(If I cd first to the directory where the relative symbolic link
resides (e.g. /usr/local/bin), the constructor call is successfull and
everything works fine!)
Hence, some sort of MakeAbsPath call might be needed prior to invoking
the FileInfo constructor.
ciao,
Helmut
P.S.: Since I'm not subscribed to this list, you'd better CC to me, if you
need further information from me.
--
Helmut Neukirchen mailto:[EMAIL PROTECTED]
Institute for Telematics http://www.itm.mu-luebeck.de
University of Luebeck phone: +49 451 500 4867
Ratzeburger Allee 160, D-23538 Luebeck, Germany fax: +49 451 500 3722
autodelregion
With ChangeLog entry...
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)
Index: ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/ChangeLog,v
retrieving revision 1.224
diff -u -p -r1.224 ChangeLog
--- ChangeLog 13 May 2002 12:42:03 - 1.224
+++ ChangeLog 13 May 2002 15:32:49 -
@@ -1,6 +1,10 @@
2002-05-13 André Pönitz [EMAIL PROTECTED]
+ * math_cursor.[Ch]: honor lyxrc setting for auto_delete_region
+
+2002-05-13 André Pönitz [EMAIL PROTECTED]
+
* math_cursor.C: fix crash on paste as reported by Piroux Geoffroy
2002-04-24 Juergen Vigna [EMAIL PROTECTED]
Index: math_cursor.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/math_cursor.C,v
retrieving revision 1.259
diff -u -p -r1.259 math_cursor.C
--- math_cursor.C 13 May 2002 12:42:03 - 1.259
+++ math_cursor.C 13 May 2002 15:32:49 -
@@ -16,6 +16,7 @@
*/
#include config.h
+#include lyxrc.h
#ifdef __GNUG__
#pragma implementation
@@ -436,6 +437,7 @@ void MathCursor::plainInsert(MathAtom co
void MathCursor::insert(char c, MathTextCodes t)
{
//lyxerr inserting ' c '\n;
+ selClearOrDel();
plainInsert(MathAtom(new MathCharInset(c, t)));
}
@@ -454,7 +456,7 @@ void MathCursor::insert(MathAtom const
if (t-nargs())
selCut();
else
- selDel();
+ selClearOrDel();
}
plainInsert(t);
@@ -653,7 +655,7 @@ void MathCursor::selCopy()
dump(selCopy);
if (selection_) {
theSelection.grab(*this);
- selClear();
+ //selClear();
}
}
@@ -686,6 +688,7 @@ void MathCursor::selDel()
void MathCursor::selPaste()
{
dump(selPaste);
+ selClearOrDel();
theSelection.paste(*this);
//theSelection.grab(*this);
//selClear();
@@ -720,6 +723,15 @@ void MathCursor::selClear()
}
+void MathCursor::selClearOrDel()
+{
+ if (lyxrc.auto_region_delete)
+ selDel();
+ else
+ selClear();
+}
+
+
void MathCursor::selGet(MathArray ar)
{
dump(selGet);
@@ -1478,12 +1490,13 @@ bool MathCursor::interpret(char c)
return true;
}
- if (selection_) {
+ // just clear selection on pressing the space par
+ if (selection_ c == ' ') {
selClear();
- if (c == ' ')
- return true;
- // fall through in the other cases
+ return true;
}
+
+ selClearOrDel();
if (lastcode_ == LM_TC_TEXTRM || par()-asBoxInset()) {
// suppress direct insertion of two spaces in a row
Index: math_cursor.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/math_cursor.h,v
retrieving revision 1.104
diff -u -p -r1.104 math_cursor.h
--- math_cursor.h 26 Mar 2002 12:38:59 - 1.104
+++ math_cursor.h 13 May 2002 15:32:49 -
@@ -148,6 +148,8 @@ public:
void selStart();
///
void selClear();
+ /// clears or deletes selection depending on lyxrc setting
+ void selClearOrDel();
///
void selGet(MathArray ar);
///
Re: [test]
Angus Leeming wrote: On Monday 13 May 2002 3:54 pm, Lars Gullik Bjønnes wrote: Angus Leeming [EMAIL PROTECTED] writes: | On Wednesday 08 May 2002 11:07 am, Lars Gullik Bjønnes wrote: Ok, there is a newserver up and running with a gateway to the lyx mailing lists now. | | Shouldn't this go on the web site? Sure, just add it there. I don't have php installed here, so can't test this addition to news.inc properly. Perhaps you'd do that for me? Feel free to improve it too! applied with some changes( \ for inside the news-tags. Herbert -- http://www.lyx.org/help/
Re: Which patches for 1.2.0
Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: These are now the patches up for consideration, Id like to know which ones are tested and working, and also absolutely needed in 1.2.0. Several of these also miss a Changelog. - keepvert.patch - whbug.patch are both not critical and tested by others. Herbert -- http://www.lyx.org/help/
Re: citation observation
Rod Pinna wrote:
Insert a citation of the form
author={Odland, J. and Faulkner, D}
results in the citation box showing
Odl and Faulkner (1981)
This is both for the little button, and the Insert-Citation box.
The latex output is fine. Seems the citation box is matching on the and
part, for when to insert and in the box.
fixed in latest cvs
Herbert
--
http://www.lyx.org/help/
Re: obscure file conversion problem
Rod Pinna wrote: Hi all, Just applied this patch, and it appears to solve my, er, philosophical disagreement. It also checked it by moving haivng a repeated graph, with the same name, with another float between the first occurrence and the second occurrence, and that appears to behave correctly. Lars, than this patch should be applied Herbert -- http://www.lyx.org/help/
Re: Patch to bug #338
On Mon, May 13, 2002 at 01:59:03PM +0200, Lars Gullik Bjønnes wrote:
Dekel Tsur [EMAIL PROTECTED] writes:
| I think that this bug is critical, since a 1.1.6 document that contains
| an URL inset inside footnote inside \author{}, will not work in 1.2.0!
Missing changelog for the buffer changes.
2002-05-11 Dekel Tsur [EMAIL PROTECTED]
* buffer.C (latexParagraphs): Add new argument (moving_arg).
Re: Patch: Fix problem with spanish
On Mon, May 13, 2002 at 02:00:32PM +0200, Lars Gullik Bjønnes wrote: Dekel Tsur [EMAIL PROTECTED] writes: | Lyx put the language extra options in the preamble before loading babel. | The attached patch fixes this bug. Missing changelog. 2002-05-09 Dekel Tsur [EMAIL PROTECTED] * LaTeXFeatures.C (getBabelOptions): New method (getMacros): Move some code to getBabelOptions. * buffer.C (makeLaTeXFile): Put babel options after loading babel.
[orestes@tsc.upc.es] Feedback from www.lyx.org
---BeginMessage--- Orestes Mas ([EMAIL PROTECTED]) entered the following feedback message on the LyX home page: Please, note a bug in XHTML code of your LyX website main page: The third site in the mirrors site list section is commented out, but the comment tag isn't closed, causing the page to be truncated at this point (at least in my case, using Mozilla in Linux). Thanks. Orestes Mas ---End Message---
Re: [Devel] A few more bugs
On Mon, May 13, 2002 at 02:53:38PM +0200, Herbert Voss wrote: | look into text.C, then you see what's horrible ... With regard to variable names? to everything Just because existing code sucks so much doesn't mean new code should. That way we never improve. regards john -- So what you're saying is screw the disabled and you want us to do the same ? No thanks... - Ian Hixie, bug 25537
Re: PATCH: fix bug 387
On Mon, May 13, 2002 at 11:13:53AM +0200, Lars Gullik Bjønnes wrote: A double-open bug was reproted, you claim that the patch you checked in should fix this, and I wonder it got fixed for the original reporter as well. Apologies for the confusion. I hoped the btw... would indicate my ambivalence as to whether the original patch (or others) had caused the problem (which I opened in bugzilla). I suppose I am a sucky QA :) john -- So what you're saying is screw the disabled and you want us to do the same ? No thanks... - Ian Hixie, bug 25537
Re: Which patches for 1.2.0
On Mon, May 13, 2002 at 04:46:58PM +0200, Lars Gullik Bjønnes wrote: These are now the patches up for consideration, Id like to know which ones are tested and working, and also absolutely needed in 1.2.0. Several of these also miss a Changelog. Let's set a date : we release 1.2.0 on Friday: no if's, no but's. It is the only way. I have already tried a couple of these patches. currently I'm Mac-disabled, but tomorrow I will do some serious testing and find what must be applied IMO. Do we have a proper patch for Dekel's python script + UPGRADING ? regards john -- So what you're saying is screw the disabled and you want us to do the same ? No thanks... - Ian Hixie, bug 25537
Re: FWD: [Bug 393] Text remains selected after paste.
On Mon, May 13, 2002 at 03:05:52PM +0200, Juergen Vigna wrote: Well I think I'm not able to reply him. So the ones which regarded this as being the choosen way may be able to reply him. I chose it, and I was wrong. Let's fix it in 1.2.1 (sorry Max) regards john -- So what you're saying is screw the disabled and you want us to do the same ? No thanks... - Ian Hixie, bug 25537
why amsmath as default ?
Hello,
In the book layout style, lyx seems to use amsmath (via, i.e.,
\usepackage{amsmath}) whenever document contains equations(in-line, or
display style equations). Is this feature intended, or a bug ? I use
lyx-1.2.0cvs.
The reason why I ask this queation is that I cannot break multi-line
equations in amsmath style. Can anybody teach me how to break multi-line
equations in amsmath?
Thank you for help,
--cghan
PROPEROUS
Dear The Next PROSPEROUS NO BUY or SALE ! NO GAMBLE ! NO RECRUITE ! NO Presentation NO SKILLS REQUIRED ! NO CALLING ! NO MEETINGS ! NO PRODUCT SELLING ! NO INVENTORY TO STOCK ! NO MAILING ! NO WORK ! NO SCAMS ! Hot Bonus 100 % Only 10 to 20 May 2002 1 Month your money Increase 100 % - 3 Months being 800 % Very Fast and SURE Do not worry about anything! All is just wonderful and do not doubt that the next year will be just as prosperous for the game as this one ! http://www.benhur.intl-ltd.com If I Lie, You can call Spammer and blow my Business With respects,Waqil
Re: Which patches for 1.2.0
Herbert Voss wrote:
Lars Gullik Bjønnes wrote:
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
These are now the patches up for consideration,
Id like to know which ones are tested and working, and also absolutely
needed in 1.2.0. Several of these also miss a Changelog.
- keepvert.patch
- whbug.patch
are both not critical and tested by others.
and here comes again the tested graphics patch which fixes
several bugs
Herbert
--
http://www.lyx.org/help/
Index: src/insets/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/ChangeLog,v
retrieving revision 1.416
diff -u -r1.416 ChangeLog
--- src/insets/ChangeLog13 May 2002 08:49:43 - 1.416
+++ src/insets/ChangeLog14 May 2002 05:51:54 -
@@ -1,3 +1,11 @@
+2002-05-14 Herbert Voss [EMAIL PROTECTED]
+
+ * insetgraphics.C (prepareFile): allow files with same name
+ in different dirs
+ (readFigInset): set the flags from old figinset in the right
+ manner
+ (findTargetFormat): more comments
+
2002-05-13 Juergen Vigna [EMAIL PROTECTED]
* insetcollapsable.C (insetButtonRelease): returned wrong return
Index: src/insets/insetgraphics.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insetgraphics.C,v
retrieving revision 1.108
diff -u -r1.108 insetgraphics.C
--- src/insets/insetgraphics.C 3 May 2002 11:56:49 - 1.108
+++ src/insets/insetgraphics.C 14 May 2002 05:51:55 -
@@ -574,22 +574,21 @@
// lyxrc.pdf_mode means:
// Are we creating a PDF or a PS file?
// (Should actually mean, are we using latex or pdflatex).
- lyxerr[Debug::GRAPHICS] findTargetFormat: lyxrc.pdf_mode =
-lyxrc.pdf_mode std::endl;
if (lyxrc.pdf_mode) {
+ lyxerr[Debug::GRAPHICS] findTargetFormat: PDF mode\n;
if (contains(suffix,ps) || suffix == pdf)
return pdf;
- else if (suffix == jpg)
+ else if (suffix == jpg) // pdflatex can use jpeg
return suffix;
else
- return png;
+ return png; // and also png
}
// If it's postscript, we always do eps.
lyxerr[Debug::GRAPHICS] findTargetFormat: PostScript mode\n;
- if (suffix != ps)
- return eps;
+ if (suffix != ps) // any other than ps
+ return eps; // is changed to eps
else
- return ps;
+ return suffix; // let ps untouched
}
} // Anon. namespace
@@ -602,14 +601,19 @@
string const orig_file = params().filename;
string const orig_file_with_path =
MakeAbsPath(orig_file, buf-filePath());
+ lyxerr[Debug::GRAPHICS] prepareFile: orig_file endl
+ with path: orig_file_with_path endl;
if (!IsFileReadable(orig_file_with_path))
return orig_file;
// If the file is compressed and we have specified that it should not be
// uncompressed, then just return its name and let LaTeX do the rest!
- bool const zipped = zippedFile(orig_file);
+ bool const zipped = zippedFile(orig_file_with_path);
+ if (zipped)
+ lyxerr[Debug::GRAPHICS] it's a zipped file\n;
if (zipped params().noUnzip) {
+ lyxerr[Debug::GRAPHICS] pass file unzipped to LaTeX\n;
return orig_file;
}
@@ -627,9 +631,23 @@
// Perform all these manipulations on a temporary file if possible.
// If we are not using a temp dir, then temp_file contains the
- // original file.
- string temp_file = MakeAbsPath(OnlyFilename(orig_file), buf-tmppath);
-
+ // original file.
+ // to allow files with the same name in different dirs
+ // we manipulate the original file any.dir/file.ext
+ // to any_dir_file.ext! changing the dots in the
+ // dirname is important for the use of ChangeExtension
+ string temp_file(orig_file);
+ if (lyxrc.use_tempdir) {
+ string const ext_tmp = GetExtension(orig_file);
+ // without ext and /
+ temp_file = subst(
+ ChangeExtension(temp_file, string()), /, _);
+ // without . and again with ext
+ temp_file = ChangeExtension(
+ subst(temp_file, ., _), ext_tmp);
+ // now we have any_dir_file.ext
+ temp_file = MakeAbsPath(temp_file, buf-tmppath);
+ }
lyxerr[Debug::GRAPHICS]
InsetGraphics::prepareFile. The temp file is:
temp_file endl;
@@ -673,7 +691,11 @@
}
// Ascertain
Re: A IE 6.0 patch
kayvan wrote: hey Kayvan, are you working with Outlook?? :-) Herbert -- http://www.lyx.org/help/
Re: [orestes@tsc.upc.es] Feedback from www.lyx.org
Please, note a bug in XHTML code of your LyX website main page: The third site in the mirrors site list section is commented out, but the comment tag isn't closed, causing the page to be truncated at this point (at least in my case, using Mozilla in Linux). fixed herbert
Re: Space at the end of a math inset
On Wed, May 08, 2002 at 06:54:10PM +0200, Lars Gullik Bjønnes wrote: > | If there are more people who want that than there are who don't... > > Is this really a problem? Not a problem. Not for 1.2.0 at least... > I'd say "no". It saves a keystroke in common situations... the complaint is certainly valid... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: PATCH: fix bug 387
On 11-May-2002 John Levon wrote: >> This patch fixes #387 as the insettext should not call the edit() call >> for non highly editable insets. > > Yes, works for me. > > btw, the two-dialogs on right click bug is back *again* :( ??? Where? Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Every morning is a Smirnoff morning.
Re: Space at the end of a math inset
On Thu, May 09, 2002 at 09:33:51AM +0200, Juergen Vigna wrote: > > Not really as long as we document it. > > I agree completely. When should we change behaviour if not with a > new release? The old behaviour was not "wrong"... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: Space at the end of a math inset
On Thu, May 09, 2002 at 02:42:42PM +0300, Dekel Tsur wrote:
> Here is a patch that fixes the problem.
> It is quite simple.
I think a better way would be to return with 'UNDISPATCHED' from mathed's
dispatch(). Otherwise you start putting mathed specific code ("leave inset
on _is_ mathed specific") outside src/mathed. Not nice.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)
Re: Space at the end of a math inset
On 13-May-2002 Andre Poenitz wrote: > On Thu, May 09, 2002 at 09:33:51AM +0200, Juergen Vigna wrote: >> > Not really as long as we document it. >> >> I agree completely. When should we change behaviour if not with a >> new release? > > The old behaviour was not "wrong"... I didn't express my opinion about the "space" feature I just expressed my opinion about when is the time to eventually "change" behaviour and this surely is between releases (or with a new one) and not inside a release (in a minor upgrade). Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ The first 90% of a project takes 90% of the time, the last 10% takes the other 90% of the time.
Re: Space at the end of a math inset
On 13-May-2002 Andre Poenitz wrote:
> On Thu, May 09, 2002 at 02:42:42PM +0300, Dekel Tsur wrote:
>> Here is a patch that fixes the problem.
>> It is quite simple.
>
> I think a better way would be to return with 'UNDISPATCHED' from mathed's
> dispatch(). Otherwise you start putting mathed specific code ("leave inset
> on _is_ mathed specific") outside src/mathed. Not nice.
We don't have the bases for this right now and it would mean changing
also "core" code to do it! This was one of the reasons I did not give
a positive answer when I heard about it. We would need a "FINISHED_RIGHT |
UNDISPATCHED" status to do this, but I surely don't want to change this
now.
Jug
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Advertising is a valuable economic factor because it is the cheapest
way of selling goods, particularly if the goods are worthless.
-- Sinclair Lewis
Re: Tooltips.
-BEGIN PGP SIGNED MESSAGE- On Sunday 12 May 2002 20:33, Herbert Voss wrote: > Joao Luis Meloni Assirati wrote: > > lyx-devel/src/frontends/xforms/ChangeLog said: > >>2002-05-09 Angus Leeming <[EMAIL PROTECTED]> > >>* Tooltips.C: enable tooltips by default. > > > > I'm using the latest cvs version with xforms-0., and although my lyx > > comes up with the help->Tooltips button checked, tooltips don't show. In > > order to enable tooltips, I have to uncheck, then recheck the tooltips > > button. > > at this time the tooltips are only available for some > > gui's: Bibtex, Citation, Sendto and Texinfo > > And for this it works like expected for me But it is exactly like he is saying. The toolkits are enabled, only if one disables them first! And I am using xforms-0.89. Kornel - -- Kornel Benko [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: PGP 6.5.8 iQCVAwUBPN9vCLewfbDGmeqhAQGmowQAyWBcmpcXLhveihnfG5f9RehCAxIk1HnS P5Ms3kP2G2y2YMvEhHWAJB2NLI4FiMBwvewDewnvqByVFKCREhhX933MuhTjoWwZ W/GhCpy+YzF+TdD2ZfMdVXbo9QGvRzVM8Yz03hNGgWJ/9ftcPKSqGdsKAXSy5Fvx VPNJuNSFKeg= =yoE5 -END PGP SIGNATURE-
Re: crash when pasting formula...
On Saturday 11 May 2002 17:22, John Levon wrote: > On Fri, May 10, 2002 at 10:56:38AM +0200, Piroux Geoffroy wrote: > > I don't know if this bug have been reported but I don't have time to > > check it: if you select an _entire_ row in a eqnarray and if you try to > > paste into an inline or a display formula the program crash. Obviously, > > this problem doesn't append when the row is not selected. > > I can't cause this to happen with current CVS. Can you give us some > detialed steps to reproduce with a testcase ? > > thanks > john
Re: crash when pasting formula...
On Saturday 11 May 2002 17:22, John Levon wrote: > On Fri, May 10, 2002 at 10:56:38AM +0200, Piroux Geoffroy wrote: > > I don't know if this bug have been reported but I don't have time to > > check it: if you select an _entire_ row in a eqnarray and if you try to > > paste into an inline or a display formula the program crash. Obviously, > > this problem doesn't append when the row is not selected. > > I can't cause this to happen with current CVS. Can you give us some > detialed steps to reproduce with a testcase ? > > thanks > john The steps are as follow: 1) copy the content of an inline formula by Ctrl-c,it doesn't matter which one 2) create an empty eqnarray : Crtl-Shift-m followed by Ctrl-Enter 3) select with the mouse (or Shift-rightarrow) the three boxes in the eqnarray formula. The three boxes are now filled with blue 4) then paste the clipboard Ctrl-v For me lyx crash each time with the message at the console : "out of memory" Remark you can start directly from the second step, it carsh also. geo
Re: crash when pasting formula...
On Fri, May 10, 2002 at 10:56:38AM +0200, Piroux Geoffroy wrote: > I don't know if this bug have been reported but I don't have time to check it: > if you select an _entire_ row in a eqnarray and if you try to paste into an > inline or a display formula the program crash. Obviously, this problem > doesn't append when the row is not selected. I can't reproduce this. Could you please create detailed instructions on how to get the crash starting from an empty document? Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
citation observation
Insert a citation of the form
author={Odland, J. and Faulkner, D}
results in the citation box showing
Odl and Faulkner (1981)
This is both for the little button, and the Insert->Citation box.
The latex output is fine. Seems the citation box is matching on the "and"
part, for when to insert and in the box.
Rod
_
rpinna|"Zoeggeler denies Hackl four straight luge golds"
@civil.uwa|
.edu.au | ABC news headline, 2002
[bugzilla-daemon@bugzilla.lyx.org: [Bug 396] New: mathed doesn't handle \multicolomn]
- Forwarded message from [EMAIL PROTECTED] -
Summary: mathed doesn't handle \multicolomn
Product: LyX
Version: 1.2.0pre1
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: mathed
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
QAContact: [EMAIL PROTECTED]
Let reLyX convert the following tex-document to a
lyx-document.\documentclass{article}\begin{document}\[ \begin{array}{rcl}1 + 2 & = & 3
\\\multicolumn{3}{c}{4 < 5 \leq 6 }\end{array} \]\end{document}lyx1.6fix4 will
handle the lyx-document, if you don't edit the formula.lyx1.2pre5 will insert the two
nonexistent columns (& &), and upset latex.This might seem to be a reLyX-Bug. But
\multicolumn is a sensible feature in an array environment, so mathed should be able
to handle it.
--- You are receiving this mail because: ---
While this _is_ a mathed problem this won't be fixed soon.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)
Re: [Devel] A few more bugs
Herbert Voss <[EMAIL PROTECTED]> writes:
| http://www.lyx.org/help/
| Index: src/frontends/controllers/biblio.C
| ===
| RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/controllers/biblio.C,v
| retrieving revision 1.25
| diff -u -r1.25 biblio.C
| --- src/frontends/controllers/biblio.C26 Apr 2002 14:35:04 - 1.25
| +++ src/frontends/controllers/biblio.C10 May 2002 12:04:42 -
| @@ -379,24 +379,36 @@
| string keyvalue;
| // at first we delete all characters right of '%' and
| // replace tabs through a space and remove leading spaces
| + // we read the data line by line so that the \n are
| + // ignored, too.
| string data_;
| int Entries = 0;
| string dummy = token(data,'\n', Entries);
| while (!dummy.empty()) {
| dummy = subst(dummy, '\t', ' ');// no tabs
| - dummy = frontStrip(dummy); // no leading spaces
| + dummy = frontStrip(dummy); // no leading spaces
| + // ignore lines with a beginning '%' or ignore all right of %
| string::size_type const idx =
| dummy.empty() ? string::npos : dummy.find('%');
| - if (idx != string::npos) {
| - // ignore lines with a beginning '%'
| - if (idx > 0) {
| - data_ += dummy.substr(0,data.find('%'));
| - }
| - } else {
| - data_ += dummy;
| + if (idx != string::npos)
| + if (idx > 0)// ignore all right of %
| + dummy = dummy.substr(
| + 0, dummy.length() - dummy.find('%'));
(What a horrible variable name...)
dummy.erase(dummy.find('%'), string::npos); // possibly + 1 or - 1
| + else// ignore all
| + dummy = "";
dummy.erase();
also this if clause is just not needed:
dummy.erase(idx, string::npos);
should cover it all.
| + // do we have a new token or a new line of
| + // the same one? In the first case we ignore
| + // the \n and in the second we replace it
| + // with a space
| + if (!dummy.empty()) {
| + if (!contains(dummy, "="))
| + data_ += (' ' + dummy);
| + else
| + data_ += dummy;
This check looks wrong... what if dummy == "=equal" or "equal=", it
does not seem that it is unimportant where in the string the '=' is.
| }
| dummy = token(data, '\n', ++Entries);
| }
| +
| // replace double commas with "" for easy scanning
| data = subst(data_, ",,", "\"\"");
|
| @@ -409,9 +421,18 @@
| data += ','; // now we have same behaviour for all entries
| // because the last one is "blah ... }"
| Entries = 0;
| - dummy = token(data, ',', Entries);
| - while (!contains(lowercase(dummy), findkey) && !dummy.empty())
| - dummy = token(data, ',', ++Entries);
| + bool found = false;
| + // parsing of title and booktitle is different from the
| + // others, because booktitle contains title
| + do {
| + dummy = token(data, ',', Entries++);
| + if (!dummy.empty()) {
| + found = contains(lowercase(dummy), findkey);
| + if (findkey == "title" &&
| + contains(lowercase(dummy), "booktitle"))
| + found = false;
| + }
| + } while (!found && !dummy.empty());
| if (dummy.empty())
| // no such keyword
| return string();
| @@ -421,10 +442,10 @@
| // Therefore we read all until the next "=" character, which follows a
| // new keyword
| keyvalue = dummy;
| - dummy = token(data, ',', ++Entries);
| + dummy = token(data, ',', Entries++);
| while (!contains(dummy, '=') && !dummy.empty()) {
| keyvalue += (',' + dummy);
| - dummy = token(data, ',', ++Entries);
| + dummy = token(data, ',', Entries++);
| }
|
| // replace double "" with originals ,, (two commas)
--
Lgb
Re: crash when pasting formula...
-BEGIN PGP SIGNED MESSAGE- On Monday 13 May 2002 09:56, Piroux Geoffroy wrote: > The steps are as follow: > 1) copy the content of an inline formula by Ctrl-c,it doesn't matter which > one 2) create an empty eqnarray : Crtl-Shift-m followed by Ctrl-Enter > 3) select with the mouse (or Shift-rightarrow) the three boxes in the > eqnarray formula. The three boxes are now filled with blue > 4) then paste the clipboard Ctrl-v I cannot reproduce it here. Selecting parts of the formula works ok. Selecting the whole formula does not work, but there is no crash. Kornel - -- Kornel Benko [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: PGP 6.5.8 iQCVAwUBPN92tLewfbDGmeqhAQEn9wQAkv8m1gZKe+HHgnj2fkgxx/IzzoJjwVMI ALIM9IED5JTQEsxMHmNAGaVUmKe7QDoLuNDt2e7zH8s9cuW0yusRBmi74cSDNLCc 9THNOe8YkkUGw0gYIVGoasfs5N0ZEx07pEWlIZ6xMzKf/oV4mwV1i+yWSYieredU YS70jnyiBYg= =plRU -END PGP SIGNATURE-
Re: compilation of lyx-1.2.0pre5
John Levon <[EMAIL PROTECTED]> writes: | p.s. I will find some time to test Jug's pending patches soon, | probably. That would be nice. -- Lgb
Re: obscure file conversion problem
Herbert Voss <[EMAIL PROTECTED]> writes: | Garst R. Reese wrote: > >> Lars Gullik Bjønnes wrote: >> >>>Did you test with different files with same name? In same dir and in >>>different dirs? >>> >> How does one make different files with same name in same dir? > > | that's very easy, with some kind of magic ... :-) I could have said same name except from extension. -- Lgb
Re: Space at the end of a math inset
On Mon, May 13, 2002 at 09:39:14AM +0200, Juergen Vigna wrote: > We don't have the bases for this right now and it would mean changing > also "core" code to do it! This was one of the reasons I did not give > a positive answer when I heard about it. We would need a "FINISHED_RIGHT | > UNDISPATCHED" status to do this, but I surely don't want to change this > now. Indeed. So it's a "WONT FIX" for 1.2.0. Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson)
Re: Patch to bug #338
Dekel Tsur <[EMAIL PROTECTED]> writes:
| I think that this bug is critical, since a 1.1.6 document that contains
| an URL inset inside footnote inside \author{}, will not work in 1.2.0!
Get some people to test it and then we'll see.
--
Lgb
Re: PATCH: fix bug 387
John Levon <[EMAIL PROTECTED]> writes: | On Thu, May 09, 2002 at 03:23:44PM +0200, Juergen Vigna wrote: > >> This patch fixes #387 as the insettext should not call the edit() call >> for non highly editable insets. > | Yes, works for me. > | btw, the two-dialogs on right click bug is back *again* :( Caused by this patch? -- Lgb
Re: crash when pasting formula...
On Mon, May 13, 2002 at 09:56:49AM +0200, Piroux Geoffroy wrote:
> For me lyx crash each time with the message at the console : "out of memory"
> Remark you can start directly from the second step, it carsh also.
Ok, I see it now. The attached patch should fix the crash.
There is a user-unfriendly part in it as it does not erease the contents of
the selection first, but this would either meen copying almost everything
from erase() to paste() or to fiddle around with the cut mechanism
which is the correct way but I won't do right now.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)
Index: math_cursor.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/math_cursor.C,v
retrieving revision 1.258
diff -u -p -r1.258 math_cursor.C
--- math_cursor.C 8 May 2002 16:17:57 - 1.258
+++ math_cursor.C 13 May 2002 08:34:45 -
@@ -130,7 +130,7 @@ struct Selection
{
if (data_.nargs() == 1) {
// single cell/part of cell
- cursor.insert(data_.cell(0));
+ cursor.paste(data_.cell(0));
} else {
// mulitple cells
idx_type idx; // index of upper left cell
Re: PATCH: fix bug 387
On 13-May-2002 Lars Gullik Bjønnes wrote:
> John Levon <[EMAIL PROTECTED]> writes:
>
>| On Thu, May 09, 2002 at 03:23:44PM +0200, Juergen Vigna wrote:
>>
>>> This patch fixes #387 as the insettext should not call the edit() call
>>> for non highly editable insets.
>>
>| Yes, works for me.
>>
>| btw, the two-dialogs on right click bug is back *again* :(
>
> Caused by this patch?
I don't think so. InsetCollapsable::insetButtonRelease() is returning
"false" when it should return the variable "ret", which tells us that
a sub-inset already opened a "layout" dialog.
I commited this fix:
Index: src/insets/insetcollapsable.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insetcollapsable.C,v
retrieving revision 1.105
diff -u -p -r1.105 insetcollapsable.C
--- src/insets/insetcollapsable.C 9 May 2002 13:43:39 - 1.105
+++ src/insets/insetcollapsable.C 13 May 2002 08:46:53 -
@@ -355,7 +355,7 @@ bool InsetCollapsable::insetButtonReleas
if ((button == 3) && !ret) {
return showInsetDialog(bv);
}
- return false;
+ return ret;
}
Jug
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Don't despair; your ideal lover is waiting for you around the corner.
Re: Space at the end of a math inset
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, May 08, 2002 at 06:54:10PM +0200, Lars Gullik Bjønnes wrote: >> | If there are more people who want that than there are who don't... >> >> Is this really a problem? > | Not a problem. Not for 1.2.0 at least... > >> I'd say "no". > | It saves a keystroke in common situations... the complaint is certainly | valid... If it is a one-liner to fix, then ok, else no. -- Lgb
Re: PATCH: fix bug 387
On 13-May-2002 Lars Gullik Bjønnes wrote: > And that also helped the bug-reporters? ??? I don't understand what you mean here. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Live in a world of your own, but always welcome visitors.
Re: PATCH: fix bug 387
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 13-May-2002 Lars Gullik Bjønnes wrote: > >> And that also helped the bug-reporters? > | ??? I don't understand what you mean here. A double-open bug was reproted, you claim that the patch you checked in should fix this, and I wonder it got fixed for the original reporter as well. -- Lgb
Re: PATCH: fix bug 387
On 13-May-2002 Lars Gullik Bjønnes wrote: >| ??? I don't understand what you mean here. > > A double-open bug was reproted, you claim that the patch you checked > in should fix this, and I wonder it got fixed for the original > reporter as well. I fail to see the double open bug? What bugs are you refering too? If you mean that there is another bug open which tells us that we're only opening the tabular-layout if we click on a insetUrl in another cell then this is a different matter and in a sense it is not a bug (but have a look at the comments). Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ A box without hinges, key, or lid, Yet golden treasure inside is hid. -- J.R.R. Tolkien
Re: PATCH: fix bug 387
Juergen Vigna <[EMAIL PROTECTED]> writes: | On 13-May-2002 Lars Gullik Bjønnes wrote: > >>| ??? I don't understand what you mean here. >> >> A double-open bug was reproted, you claim that the patch you checked >> in should fix this, and I wonder it got fixed for the original >> reporter as well. > | I fail to see the double open bug? What bugs are you refering too? | If you mean that there is another bug open which tells us that we're | only opening the tabular-layout if we click on a insetUrl in another | cell then this is a different matter and in a sense it is not a bug | (but have a look at the comments). Ok, then I want to know what problem, and when it can be triggered, the patch that you committed fixed. -- Lgb
Re: PATCH: fix bug 387
On 13-May-2002 Lars Gullik Bjønnes wrote: >| I fail to see the double open bug? What bugs are you refering too? >| If you mean that there is another bug open which tells us that we're >| only opening the tabular-layout if we click on a insetUrl in another >| cell then this is a different matter and in a sense it is not a bug >| (but have a look at the comments). > > Ok, then I want to know what problem, and when it can be triggered, > the patch that you committed fixed. I closed the bug after commiting the fix, there was also a testcase there. The bug was #395. Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ All the world's a stage and most of us are desperately unrehearsed. -- Sean O'Casey
RE: Assorted pre5 issues
On 13-May-2002 Walter H. van Holst wrote: > - Searching text is incredibly slow. The whole searching process seems > to be displayed in slow-motion, including expansion and collapsing all > footnotes. We know and this will probably not change for 1.2.x. > - I have managed to freeze LyX by selecting a bunch of paragraphs, > changing it from 'normal' to 'enumerate', selecting one item, changing > it to 'itemize' and then selecting the whole group again, changing it > to 'itemize'. Well here we need an example .lyx file and a receipt to trigger the bug otherwise it's quite impossible to fix it. Thanks anyway for your comments! Jug -- -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED] Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450253 I-39100 Bozen Web: http://www.sad.it/~jug -._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._ "But Huey, you PROMISED!" "Tell 'em I lied."
