Re: List of notes not in beta1

[Kornel Benko]

Am Samstag, 21. Oktober 2017 um 00:36:35, schrieb racoon 
> On 20.10.2017 17:06, Kornel Benko wrote:
> > Am Freitag, 20. Oktober 2017 um 16:39:01, schrieb racoon 
> >> On 20.10.2017 12:20, Kornel Benko wrote:
> >>> Am Freitag, 20. Oktober 2017 um 08:50:57, schrieb racoon 
>  On 19.10.2017 15:25, Kornel Benko wrote:
> > Am Donnerstag, 19. Oktober 2017 um 14:00:27, schrieb racoon 
> > 
> >> My documents do not show the "Notes" list in the Outline pane in beta1.
> >> Is that a bug?
> >>
> >> Daniel
> >
> > Insert a note first?
> >
> > Kornel
> >
>  Yes, I have plenty of them. Does your question suggest that it works for
>  you?
> 
>  Daniel
> >>>
> >>> Yes, I tried with every note type.
> >>>
> >>>   Kornel
> >>
> >> That is strange then.
> >>
> >> Daniel
> >
> > What about MWE?
> >
> > Kornel
> >
>
> Attached. Also a screenshot of what I (not) see.

I see. It is not, what I experience.
Left-clicking on the 'Table of Contents' field, I see the attached.

> Maybe I messed up my UI with some customizations? Is there a way to edit
> the lists that show up?

Don't know. I never had a problem. This is with QT5.8, linux. And with QT4 it 
works too here.

> Daniel

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: Windows: bring window to front

[racoon]

On 17.10.2017 14:07, Enrico Forestieri wrote:

On Tue, Oct 17, 2017 at 11:50:23AM +0300, racoon wrote:

On 17.10.2017 06:42, Scott Kostyshak wrote:

On Mon, Oct 16, 2017 at 01:09:34PM +, racoon wrote:

Hi,

Is the patch for http://www.lyx.org/trac/ticket/10469 already in beta1? If
so, it seems not to work. If not, maybe it can make it to rc1?


The patch is in beta1. If the feature doesn't work, then that means the
fix didn't work for you.


Yes, when opening LyX files from the explorer, LyX still does not come to
the top.

Strange, I thought I tested the patch before and it worked. But I probably
did not try it from the explorer but rather from the command line. I am not
sure there is a difference wrt the problem.


It works for me. Make sure that you have "Single Instance" checked and
"LyXServer pipe" defined in the preferences.


I have it checked and defined, respectively. (Though I am wondering why 
"Single instance" should make a difference at all and "LyXServer pipe" 
at least for opening documents from the explorer.)


But it doesn't work. Just to be sure, you tested on Windows beta1, right?

Daniel

Re: List of notes not in beta1

[racoon]

On 20.10.2017 23:20, Andrew Parsloe wrote:



On 20/10/2017 6:50 p.m., racoon wrote:

On 19.10.2017 15:25, Kornel Benko wrote:
Am Donnerstag, 19. Oktober 2017 um 14:00:27, schrieb racoon 


My documents do not show the "Notes" list in the Outline pane in beta1.
Is that a bug?

Daniel


Insert a note first?

Kornel

Yes, I have plenty of them. Does your question suggest that it works 
for you?


Daniel

I'm using beta1 on windows7. The current document includes notes and 
there *is* a Notes option in the Outliner. (I need to use the slider to 
bring it into view.) When I choose it, a list of notes is presented.


Andrew


Thanks. Well, I guess there must be something wrong with my 
configuration then...


Daniel

Re: List of notes not in beta1

[racoon]

On 20.10.2017 17:06, Kornel Benko wrote:

Am Freitag, 20. Oktober 2017 um 16:39:01, schrieb racoon 

On 20.10.2017 12:20, Kornel Benko wrote:

Am Freitag, 20. Oktober 2017 um 08:50:57, schrieb racoon 

On 19.10.2017 15:25, Kornel Benko wrote:

Am Donnerstag, 19. Oktober 2017 um 14:00:27, schrieb racoon 

My documents do not show the "Notes" list in the Outline pane in beta1.
Is that a bug?

Daniel


Insert a note first?

Kornel


Yes, I have plenty of them. Does your question suggest that it works for
you?

Daniel


Yes, I tried with every note type.

Kornel


That is strange then.

Daniel


What about MWE?

Kornel



Attached. Also a screenshot of what I (not) see.

Maybe I messed up my UI with some customizations? Is there a way to edit 
the lists that show up?


Daniel


a_note.lyx
Description: application/lyx

Re: Ticket #3072: incomplete booktabs support: optional arguments of \cmidrule not supported

[racoon]

On 20.10.2017 23:56, Scott Kostyshak wrote:

Please make sure to add your thoughts to the ticket, so they don't get
lost.


Done. http://www.lyx.org/trac/ticket/3072#comment:11

Daniel

Re: Make the math package loading automatic

[Scott Kostyshak]

On Thu, Oct 19, 2017 at 01:07:29PM +, Jean-Pierre Chrétien wrote:
> Le 07/05/2017 à 21:58, Jean-Pierre Chrétien a écrit :
> 
> > 
> > What do you think? Should I parse the files to find \usepackage{xxx}
> > command in preambles, where xxx is one of the ten math packages managed
> > by math options
> 
> I did not find any occurrence.
> 
> > or is it sufficient to have no ctest failure?
> > 
> 
> I reran the test procedure of these changes in math options on recent master
> and documented it precisely in ticket #10661. The changes seem safe to me,
> and below is the beginning of a commit appropriate to perform them. Can it
> go to master ?
> It is also candidate to 2.3.x (and maybe to 2.2.x too).

Thanks for your work on this, Jean-Pierre, and for your detailed notes
on the ticket. Do you have a full patch for the 2.3.x branch? If you do
not want to send a large file to the list, you can send it to me
privately.

That way I can run the ctests just to double-check.

Scott


signature.asc
Description: PGP signature

Re: Ticket #3072: incomplete booktabs support: optional arguments of \cmidrule not supported

[Scott Kostyshak]

On Fri, Oct 20, 2017 at 08:13:53AM +, racoon wrote:
> On 20.10.2017 11:06, racoon wrote:
> > For example, if a column with a \cmidrule underneath is set to "align
> > center" then this should be inherited by its \cmidrule, i.e.
> > 
> > \cmidrule(c){...}
> Or maybe if all columns just below a \cmidrule are set to "align center"? In
> this way it is still possible to use some other custom distribution of
> columns.

Please make sure to add your thoughts to the ticket, so they don't get
lost.

Scott


signature.asc
Description: PGP signature

Re: Trac and 2.3.x

[Scott Kostyshak]

On Wed, Oct 18, 2017 at 08:56:50PM +, Richard Heck wrote:
> I realized a day or two ago that I wasn't myself sure how we are or
> should be using the "fixed in master" and "fixed in stable" statuses in
> Trac now that we have the 2.3.x branch. I.e., if something is fixed in
> the master branch and in 2.3.x, how is that to be noted? Are things
> "fixed in stable" when they are fixed in 2.3.x? Or are they only "fixed
> in stable" when they are fixed in 2.2.x? I'd suppose it was the latter,
> but that might make it difficult to know which bugs we can close when
> 2.3.0 is released.
> 
> Here's a proposal:
> 
> (i) Use "fixed in master" to mean precisely that.
> 
> (ii) If a bug is fixed in 2.3.x, then mark it "fixed in stable". If it's
> intended for 2.2.x but has not yet been pushed to 2.2.x, then set the
> milestone to 2.2.x. If it's not intended for 2.2.x, then set the
> milestone to 2.3.0.
> 
> (iii) If a bug is fixed in 2.2.x (as well as 2.3.x), then set the
> milestone to 2.2.4.
> 
> Thus: A bug marked "fixed in stable" with milestone 2.2.4 is one that
> has been fixed in 2.2.x; a bug marked "fixed in stable" with milestone
> NOT 2.2.4 has not been fixed in 2.2.x, and if the milestone is 2.3.0,
> then it is not going to be fixed in 2.2.x.
> 
> Thoughts?
> 
> Another idea might be temporarily to use some keyword. I have a dim
> memory we might have done that before.

Thanks for bringing up this topic. It is indeed tricky. Both ideas seem
reasonable to me.

Scott


signature.asc
Description: PGP signature

Re: compilation of LyX 2.3 fails with Python 3.6.2

[Scott Kostyshak]

On Wed, Oct 18, 2017 at 01:18:16PM +, Kornel Benko wrote:

> > OK to commit to 2.3. branch?
> 
> Scott?

Go ahead.

Thanks,

Scott


signature.asc
Description: PGP signature

Re: List of notes not in beta1

[Andrew Parsloe]

On 20/10/2017 6:50 p.m., racoon wrote:

On 19.10.2017 15:25, Kornel Benko wrote:
Am Donnerstag, 19. Oktober 2017 um 14:00:27, schrieb racoon 


My documents do not show the "Notes" list in the Outline pane in beta1.
Is that a bug?

Daniel


Insert a note first?

Kornel

Yes, I have plenty of them. Does your question suggest that it works 
for you?


Daniel

I'm using beta1 on windows7. The current document includes notes and 
there *is* a Notes option in the Outliner. (I need to use the slider to 
bring it into view.) When I choose it, a list of notes is presented.


Andrew

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Re: Initial view of document (master)

[Pavel Sanda]

Jean-Marc Lasgouttes wrote:
> Le 19/10/2017 ?? 15:05, Pavel Sanda a écrit :
>> Pavel Sanda wrote:
>>> d) Editing problems
>>> Don't see how to produce solid recipy but something is wrong with editing 
>>> as well.
>> Try couple times this one:
>> 1. open user guid, uncheck disable editing
>> 2. go to in front of "i" in "What is LyX"
>> 3. hit delete
>> 4. in most cases the character does not disappear although deleted once 
>> you move caret
>
> This (and the insert note crash) are fixed in this latest version. I send 
> it because I will not have much time on it until next Tuesday.

After some testing:
- initial thread report present
- a is present
- b is fixed
- c mostly fixed, ghost c3*** still remains

Given that none of the remaining is critical I'd say go and commit,
I'll start new threads for new issues.
Pavel

Re: List of notes not in beta1

[Kornel Benko]

Am Freitag, 20. Oktober 2017 um 16:39:01, schrieb racoon 
> On 20.10.2017 12:20, Kornel Benko wrote:
> > Am Freitag, 20. Oktober 2017 um 08:50:57, schrieb racoon 
> >> On 19.10.2017 15:25, Kornel Benko wrote:
> >>> Am Donnerstag, 19. Oktober 2017 um 14:00:27, schrieb racoon 
> >>> 
>  My documents do not show the "Notes" list in the Outline pane in beta1.
>  Is that a bug?
> 
>  Daniel
> >>>
> >>> Insert a note first?
> >>>
> >>>   Kornel
> >>>
> >> Yes, I have plenty of them. Does your question suggest that it works for
> >> you?
> >>
> >> Daniel
> > 
> > Yes, I tried with every note type.
> > 
> > Kornel
> 
> That is strange then.
> 
> Daniel

What about MWE?

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: List of notes not in beta1

[racoon]

On 20.10.2017 12:20, Kornel Benko wrote:

Am Freitag, 20. Oktober 2017 um 08:50:57, schrieb racoon 

On 19.10.2017 15:25, Kornel Benko wrote:

Am Donnerstag, 19. Oktober 2017 um 14:00:27, schrieb racoon 

My documents do not show the "Notes" list in the Outline pane in beta1.
Is that a bug?

Daniel


Insert a note first?

Kornel


Yes, I have plenty of them. Does your question suggest that it works for
you?

Daniel


Yes, I tried with every note type.

Kornel


That is strange then.

Daniel

Re: Initial view of document (master)

[Jean-Marc Lasgouttes]

Le 19/10/2017 à 15:05, Pavel Sanda a écrit :

Pavel Sanda wrote:

d) Editing problems
Don't see how to produce solid recipy but something is wrong with editing as 
well.


Try couple times this one:
1. open user guid, uncheck disable editing
2. go to in front of "i" in "What is LyX"
3. hit delete
4. in most cases the character does not disappear although deleted once you 
move caret


This (and the insert note crash) are fixed in this latest version. I 
send it because I will not have much time on it until next Tuesday.


I do know that the "save after mouse wheel" bug is still present, but I 
have not manage to fix it yet. I did not have time to look at the other 
bugs.


JMarc
From 29d3eb6e0f67829774ff91dd5f06d0063c11d841 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes 
Date: Wed, 11 Oct 2017 18:00:48 +0200
Subject: [PATCH] Allow multiple calls to processUpdateFlags before redraw

The goal of this commit is to ensure that a processUpdateFlags call
that requires no redraw will not override a previous one that did
require a redraw.

To this end, the semantics of the flag argument is now different: its
value is now OR'ed with a private update_flags_ variable. This
variable is only reset after the buffer view has actually been
redrawn.

A new Update::ForceRedraw flag has been added. It requires a full
redraw but no metrics computation. It is not used in the main code
(yet), but avoids to compute metrics repeatedly in consecutive
processUpdateFlags calls.

The process is now as follows:
- the Force flag is honored (full metrics computation) and replaced
  with ForceDraw.
- the FitCursor flag is honored and removed from the flags.
- the SinglePar update is added if ForceDraw is not in flags and only
  the current par has been modified.

The remaining flags are only then added to the BufferView update
flags, and the update strategy is computed for the next paint event.

Finally the dubious call to updateMacros in updateMetrics has been
removed for performance reasons.
---
 development/PAINTING_ANALYSIS |  21 +++--
 src/BufferView.cpp| 176 ++
 src/BufferView.h  |   9 ++-
 src/TextMetrics.cpp   |   7 +-
 src/update_flags.h|  14 +++-
 5 files changed, 125 insertions(+), 102 deletions(-)

diff --git a/development/PAINTING_ANALYSIS b/development/PAINTING_ANALYSIS
index f734edb..ec3566e 100644
--- a/development/PAINTING_ANALYSIS
+++ b/development/PAINTING_ANALYSIS
@@ -60,12 +60,6 @@ cursor.
 
 * Clean-up of drawing code
 
-The goal is to make painting with drawing disable fast enough that it
-can be used after every metrics computation. Then we can separate real
-drawing from metrics.
-
-Other changes are only clean-ups.
-
 ** When a paragraph ends with a newline, compute correctly the height of the extra row.
 ** Merging bv::updateMetrics and tm::metrics
 
@@ -76,7 +70,7 @@ insets. We should re-use the bv::updateMetrics logic:
  + transfer all the logic of bv::updateMetrics to tm.
  + Main InsetText should not be special.
 
-The difficuly for a tall table cell for example, is that it may be
+The difficulty for a tall table cell for example, is that it may be
 necessary to break the whole contents to know the width of the cell.
 
 
@@ -113,11 +107,19 @@ DecorationUpdate). It triggers a recomputation of the metrics when either:
existing metrics. Note that the Update::SinglePar flag is *never*
taken into account.
 
+If a computation of metrics has taken place, Force is removed from the
+flags and ForceDraw is added instead.
+
+It is OK to call processUptateFlags several times before an update. In
+this case, the effects are cumulative.processUpdateFlags execute the
+metrics-related actions, but defers the actual drawing to the next
+paint event.
+
 The screen is drawn (with appropriate update strategy), except when
 update flag is Update::None.
 
 
-** Metrics computation
+** Metrics computation (and nodraw drawing phase)
 
 This is triggered by bv::updateMetrics, which calls tm::redoParagraph for
 all visible paragraphs. Some Paragraphs above or below the screen (needed
@@ -127,6 +129,9 @@ tm::redoParagraph will call Inset::metrics for each inset. In the case
 of text insets, this will invoke recursively tm::metrics, which redoes
 all the paragraphs of the inset.
 
+At the end of the function, bv::updatePosCache is called. It triggers
+a repaint of the document with a NullPainter (a painter that does
+nothing). This has the effect of caching all insets positions.
 
 ** Drawing the work area.
 
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 53d374f..153ab2d 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -228,7 +228,8 @@ enum ScreenUpdateStrategy {
 
 struct BufferView::Private
 {
-	Private(BufferView & bv) : update_strategy_(NoScreenUpdate),
+	Private(BufferView & bv) : update_strategy_(FullScreenUpdate),
+		update_flags_(Update::Force),
 		wh_(0), cursor_(bv),
 		

Re: make lyx versions distinguishable in desktop menus

[Kornel Benko]

Am Donnerstag, 19. Oktober 2017 um 14:03:49, schrieb Pavel Sanda 
> Kornel Benko wrote:
> > Unix only:
> > Using suffixed lyx, we install the lyx-desktop for different versions with
> > different file name, but with the same 'Name'-entry.
> 
> Looks Ok. P

Pushed to master at e5d4ba8.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: List of notes not in beta1

[Kornel Benko]

Am Freitag, 20. Oktober 2017 um 08:50:57, schrieb racoon 
> On 19.10.2017 15:25, Kornel Benko wrote:
> > Am Donnerstag, 19. Oktober 2017 um 14:00:27, schrieb racoon 
> > 
> >> My documents do not show the "Notes" list in the Outline pane in beta1.
> >> Is that a bug?
> >>
> >> Daniel
> > 
> > Insert a note first?
> > 
> > Kornel
> > 
> Yes, I have plenty of them. Does your question suggest that it works for 
> you?
> 
> Daniel

Yes, I tried with every note type.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: Ticket #3072: incomplete booktabs support: optional arguments of \cmidrule not supported

[racoon]

On 20.10.2017 11:06, racoon wrote:
For example, if a column with a \cmidrule underneath is set to "align 
center" then this should be inherited by its \cmidrule, i.e.


\cmidrule(c){...}
Or maybe if all columns just below a \cmidrule are set to "align 
center"? In this way it is still possible to use some other custom 
distribution of columns.


Daniel

Ticket #3072: incomplete booktabs support: optional arguments of \cmidrule not supported

[racoon]

Maybe some arguments of \cmidrule could be set automatically without 
additional UI?


For example, if a column with a \cmidrule underneath is set to "align 
center" then this should be inherited by its \cmidrule, i.e.


\cmidrule(c){...}

Also, a \cmidrule should never stretch over more than one (multi)column. 
This makes possible to to have rules with small breaks in between.


See both cases here in action here:

https://tex.stackexchange.com/a/60604/36836

I know that this might not be the wanted result in all cases. But maybe 
it is what is wanted in almost all cases. And once a UI gets implemented 
to set these optional arguments, in the Border dialog or so, then this 
could override the default as outlined above.


Daniel

Show changes don't work properly with display math

[racoon]

Open and typeset the attached file with a deleted text immediately 
followed by a display math (the way one should typeset display math 
without extra space in LyX) and active show changes. It shows both the 
original results without deletions and the actual results.


Notes:
The main problem is shown at 2 compared to 1 where the display math is 
translated to the top.


But there is also a minor problem. When preceded by a new paragraph, as 
shown in 3 and 4, the display math is translated to the right and bottom 
which does not seem fully correct either.


(The result is independent of the enumerations.)

Daniel


show_changes_display_math.lyx
Description: application/lyx

Show changes don't work with URL (and maybe other insets)

[racoon]

Open and typeset the attached file with a deleted URL and active show 
changes. It shows both the actual and expected result.


Notes: While the current algorithm seems fine for some insets, like 
footnotes, it falters at other insets, like URL, which do not interpret 
its content as LaTeX code.


Daniel


show_changes_url.lyx
Description: application/lyx