Re: [LyX/master] Fix remaining path

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 10:25:53PM +, Uwe Stöhr wrote:
> El 27.10.2017 a las 00:17, Scott Kostyshak escribió:
> 
> > > No. it is just a dummy file as example.
> > 
> > I think we should at least be consistent, no? A localized version exists
> > for German. Should we remove that then?
> 
> to correct myself, you are right, it should be translated. And as I can see
> it is already translated to all languages.

I don't see the file for Japanese. I might just be misunderstanding
something. What is the file path to the Japanese localization of the
file DummyTextDocument.txt? The patch that you put in from Kornel causes
the Japanese EmbeddedObjects.lyx to use the English version of that
file, which to me makes sense because there is no Japanese
DummyTextDocument.txt. I just wonder whether we should let Koji know so
that he has the option to create a localized DummyTextDocument.txt, as
is already the case for German.

> > > However, Kornel's patch to Japanese EmbeddedObjects should go in before
> > > 2.3.0 final.
> > 
> > Go ahead and push now on 2.3.x, Kornel.
> 
> I already pushed this in together with the Sweave patch.

Thanks,

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Fix remaining path

[Uwe Stöhr]

El 27.10.2017 a las 00:17, Scott Kostyshak escribió:


No. it is just a dummy file as example.


I think we should at least be consistent, no? A localized version exists
for German. Should we remove that then?


to correct myself, you are right, it should be translated. And as I can 
see it is already translated to all languages.

However, Kornel's patch to Japanese EmbeddedObjects should go in before
2.3.0 final.


Go ahead and push now on 2.3.x, Kornel.


I already pushed this in together with the Sweave patch.

regards Uwe

Re: Freeze 2.3.x on Wednesday for rc1?

[Uwe Stöhr]

El 26.10.2017 a las 08:59, Guenter Milde escribió:


I had some off-list discussion with Uwe about the dash-documentation
resulting in some changes to his changes to my changes.

Currently, I implemented them with change tracking on -- this would need
Uwe's revision to accept the changes and distribute them to other languages
(except German that is included in my patch).


Hi Günter,

I was waiting for your patch but did not get it. I see But no problem 
because I will have some time next weekend and next week.


So I propose that you commit your patch with change tracking after RC1 
and I will have a look before 2.3.0 final.


regards Uwe

Re: [LyX/master] Fix remaining path

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 09:10:52PM +, Uwe Stöhr wrote:
> El 26.10.2017 a las 22:32, Scott Kostyshak escribió:
> 
> > Uwe, how should we signal to translators that this DummyTextDocument.txt
> > file should be translated?
> 
> No. it is just a dummy file as example.

I think we should at least be consistent, no? A localized version exists
for German. Should we remove that then?

> However, Kornel's patch to Japanese EmbeddedObjects should go in before
> 2.3.0 final.

Go ahead and push now on 2.3.x, Kornel.

Thanks,

Scott


signature.asc
Description: PGP signature

Re: Update on the 2.3.0rc1 situation

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 09:12:57PM +, Richard Heck wrote:
> On 10/26/2017 02:48 PM, Scott Kostyshak wrote:
> > On Wed, Oct 25, 2017 at 10:05:46PM +, Richard Heck wrote:
> >> The actual problem is the deletion of ZWSP characters, which 72a488d7
> >> said was needed "so that they don't accumulate". The concern here, I take
> >> it, is that reverting to a pre-2.3.x format and then re-importing might
> >> lead to a stack of these things. Why not just make sure that doesn't
> >> happen? I.e., check if there's a stack of them, and if so fix that?
> > Is this something you think we should consider for rc1?
> 
> I was echoing the complaint mentioned in the patch. Presumably it is now
> too late for rc1, but
> there might be some very simple patch that would solve this problem.

OK thanks.

Scott


signature.asc
Description: PGP signature

Re: Update on the 2.3.0rc1 situation

[Richard Heck]

On 10/26/2017 02:48 PM, Scott Kostyshak wrote:
> On Wed, Oct 25, 2017 at 10:05:46PM +, Richard Heck wrote:
>> The actual problem is the deletion of ZWSP characters, which 72a488d7
>> said was needed "so that they don't accumulate". The concern here, I take
>> it, is that reverting to a pre-2.3.x format and then re-importing might
>> lead to a stack of these things. Why not just make sure that doesn't
>> happen? I.e., check if there's a stack of them, and if so fix that?
> Is this something you think we should consider for rc1?

I was echoing the complaint mentioned in the patch. Presumably it is now
too late for rc1, but
there might be some very simple patch that would solve this problem.

Richard

Re: [LyX/master] Fix remaining path

[Uwe Stöhr]

El 26.10.2017 a las 22:32, Scott Kostyshak escribió:


Uwe, how should we signal to translators that this DummyTextDocument.txt
file should be translated?


No. it is just a dummy file as example.

However, Kornel's patch to Japanese EmbeddedObjects should go in before 
2.3.0 final.


regards Uwe

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

[Scott Kostyshak]

On Wed, Oct 25, 2017 at 05:26:25PM +, Scott Kostyshak wrote:

> What shall we do with this regarding rc1? If for some reason we do not
> put in Stephan's patch, can we at least put in some debug code or an
> assert or something to help us make progress on this in the future?

Bump. I'm not considering this an rc1 blocker, but if there's something
obvious we should try for rc1, please let me know.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 08:44:34PM +, Kornel Benko wrote:

> > > Thanks, Kornel. Why not put the string inside "diestack" instead of
> > > separate print?
> > 
> > I did it at first, but the string did not appear in the output. Will 
> > investigate why.
> > 
> > > Scott
> > 
> 
> Hm, must have been blinded.

Thanks for checking it out.

Scott


signature.asc
Description: PGP signature

Re: compilation of LyX 2.3 fails with Python 3.6.2

[Uwe Stöhr]

El 23.10.2017 a las 10:55, Kornel Benko escribió:


Question: Is it possible to have also the input-textfiles be utf-8 encoded?


Here on Windows all changelog files are UTF-8 encoded.


As it is now, the script converts them, which I think is OK.


OK then.

regards Uwe

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Kornel Benko]

Am Donnerstag, 26. Oktober 2017 um 22:32:52, schrieb Kornel Benko 

> Am Donnerstag, 26. Oktober 2017 um 16:30:14, schrieb Scott Kostyshak 
> 
> > On Thu, Oct 26, 2017 at 07:49:36PM +, Kornel Benko wrote:
> > > commit d63a866106a088fbf42504215a0a9193437e70de
> > > Author: Kornel Benko 
> > > Date:   Thu Oct 26 21:48:33 2017 +0200
> > > 
> > > Cmake export tests: Make test fail if there is some non-existant 
> > > sub-file
> > > ---
> > >  development/autotests/useSystemFonts.pl |7 +++
> > >  1 files changed, 7 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/development/autotests/useSystemFonts.pl 
> > > b/development/autotests/useSystemFonts.pl
> > > index 58006b0..61eee4d 100644
> > > --- a/development/autotests/useSystemFonts.pl
> > > +++ b/development/autotests/useSystemFonts.pl
> > > @@ -252,6 +252,13 @@ sub interpretedCopy()
> > > $res += $res1;
> > >   }
> > > }
> > > +   else {
> > > + if (! -e "$f") {
> > > +   # Non relative (e.g. with absolute path) file should exist
> > > +   print "File $f not found\n";
> > > +   diestack("");
> > > + }
> > > +   }
> > >   }
> > >   if ($foundrelative) {
> > > $rF->[$fidx] = join($separator, @{$filelist});
> > 
> > Thanks, Kornel. Why not put the string inside "diestack" instead of
> > separate print?
> 
> I did it at first, but the string did not appear in the output. Will 
> investigate why.
> 
> > Scott
> 

Hm, must have been blinded.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 08:32:52PM +, Kornel Benko wrote:

> I did it at first, but the string did not appear in the output. Will 
> investigate why.

I was just curious. If we do stay with print, let's at least print to
STDERR?

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Kornel Benko]

Am Donnerstag, 26. Oktober 2017 um 16:30:14, schrieb Scott Kostyshak 

> On Thu, Oct 26, 2017 at 07:49:36PM +, Kornel Benko wrote:
> > commit d63a866106a088fbf42504215a0a9193437e70de
> > Author: Kornel Benko 
> > Date:   Thu Oct 26 21:48:33 2017 +0200
> > 
> > Cmake export tests: Make test fail if there is some non-existant 
> > sub-file
> > ---
> >  development/autotests/useSystemFonts.pl |7 +++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/development/autotests/useSystemFonts.pl 
> > b/development/autotests/useSystemFonts.pl
> > index 58006b0..61eee4d 100644
> > --- a/development/autotests/useSystemFonts.pl
> > +++ b/development/autotests/useSystemFonts.pl
> > @@ -252,6 +252,13 @@ sub interpretedCopy()
> >   $res += $res1;
> > }
> >   }
> > + else {
> > +   if (! -e "$f") {
> > + # Non relative (e.g. with absolute path) file should exist
> > + print "File $f not found\n";
> > + diestack("");
> > +   }
> > + }
> > }
> > if ($foundrelative) {
> >   $rF->[$fidx] = join($separator, @{$filelist});
> 
> Thanks, Kornel. Why not put the string inside "diestack" instead of
> separate print?

I did it at first, but the string did not appear in the output. Will 
investigate why.

> Scott

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Fix remaining path

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 07:54:22PM +, Kornel Benko wrote:
> commit d5ec6356b844026ef65276dd022296baffe10111
> Author: Kornel Benko 
> Date:   Thu Oct 26 21:53:39 2017 +0200
> 
> Fix remaining path
> ---
>  lib/doc/ja/EmbeddedObjects.lyx |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/doc/ja/EmbeddedObjects.lyx b/lib/doc/ja/EmbeddedObjects.lyx
> index 460f5a0..1782cfb 100644
> --- a/lib/doc/ja/EmbeddedObjects.lyx
> +++ b/lib/doc/ja/EmbeddedObjects.lyx
> @@ -37929,7 +37929,7 @@ textvisiblespace
>  以下は，原文儘として挿入された子文書です． 
>  \begin_inset CommandInset include
>  LatexCommand verbatiminput
> -filename "DummyTextDocument.txt"
> +filename "../DummyTextDocument.txt"
>  
>  \end_inset
>  
> @@ -37944,7 +37944,7 @@ filename "DummyTextDocument.txt"
>  オプションを指定して，原文儘として挿入された子文書です． 
>  \begin_inset CommandInset include
>  LatexCommand verbatiminput*
> -filename "DummyTextDocument.txt"
> +filename "../DummyTextDocument.txt"
>  

Uwe, how should we signal to translators that this DummyTextDocument.txt
file should be translated?  For example, the file does exist in de/, but
not in ja/.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 07:49:36PM +, Kornel Benko wrote:
> commit d63a866106a088fbf42504215a0a9193437e70de
> Author: Kornel Benko 
> Date:   Thu Oct 26 21:48:33 2017 +0200
> 
> Cmake export tests: Make test fail if there is some non-existant sub-file
> ---
>  development/autotests/useSystemFonts.pl |7 +++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/development/autotests/useSystemFonts.pl 
> b/development/autotests/useSystemFonts.pl
> index 58006b0..61eee4d 100644
> --- a/development/autotests/useSystemFonts.pl
> +++ b/development/autotests/useSystemFonts.pl
> @@ -252,6 +252,13 @@ sub interpretedCopy()
> $res += $res1;
>   }
> }
> +   else {
> + if (! -e "$f") {
> +   # Non relative (e.g. with absolute path) file should exist
> +   print "File $f not found\n";
> +   diestack("");
> + }
> +   }
>   }
>   if ($foundrelative) {
> $rF->[$fidx] = join($separator, @{$filelist});

Thanks, Kornel. Why not put the string inside "diestack" instead of
separate print?

Scott


signature.asc
Description: PGP signature

2.3.x branch is frozen

[Scott Kostyshak]

Dear all,

The 2.3.x branch is frozen. There are a couple of dangling issues that
we might do something about for 2.3.0rc1. If you think we should
consider a patch for rc1, please let me know as soon as possible so I
can take a look.

Scott


signature.asc
Description: PGP signature

Re: Japanese docs: incorrect paths?

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 12:24:05AM +, Uwe Stöhr wrote:
> El 25.10.2017 a las 19:53, Scott Kostyshak escribió:
> 
> > Uwe, do you happen to have time to take a look at what is going wrong?
> 
> I fixes them now - I hope.
> Koji, there are now 2 untranslated image captions in sec. 4.6.2.
> 
> > Also, why don't missing images give an error when compiling? This way
> > our ctests would have caught this problem.
> 
> The problem is that I cannot see these things because I cannot compile
> Japanese documents.

Thanks for the quick fixes, Uwe! Hopefully Koji can test rc1 to make
sure everything looks good.

I can compile the Japanese docs (with dvipdfx, not with ps2pdf) so if
you ever want me to test something, let me know. And since I think you
have access to Linux, if you want help setting things up so that
compilation works, I think we would be able to figure it out.

Scott


signature.asc
Description: PGP signature

Re: Freeze 2.3.x on Wednesday for rc1?

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 06:59:51AM +, Guenter Milde wrote:
> Dear Scott,
> 
> On 2017-10-25, Scott Kostyshak wrote:
> 
> > [-- Type: text/plain, Encoding: quoted-printable --]
> 
> > On Tue, Oct 24, 2017 at 03:13:38PM +, Guenter Milde wrote:
> >> On 2017-10-22, Uwe Stöhr wrote:
> >> > El 22.10.2017 a las 20:08, Scott Kostyshak escribió:
> 
> ...
> 
> >> > I just checked the docs that all changes are now accepted.
> 
> >> There is still the pending patch with the dash documentation update.
> 
> > From what I understand, no one has objected to the documentation patch,
> > except for the part to RELEASE-NOTES (which I believe we have resolved).
> > Thus, unless I misunderstood something, please go ahead and commit to
> > 2.3.x.
> 
> I had some off-list discussion with Uwe about the dash-documentation
> resulting in some changes to his changes to my changes.
> 
> Currently, I implemented them with change tracking on -- this would need
> Uwe's revision to accept the changes and distribute them to other languages
> (except German that is included in my patch).
> 
> Therefore I rather ask again instead of pushing at this stage...

I see, thanks for your hesitation then. Since this is all just
documentation, I propose to just wait one day and then go ahead.

Does anyone object to this documentation patch?

Uwe, if no one object, will you have time to take a look and accept and
redistribute the changes?

I took a quick look at the patch. Thanks for adding notes to the
translators to change the wikipedia link to the appropriate language.

Scott


signature.asc
Description: PGP signature

Re: Update on the 2.3.0rc1 situation

[Scott Kostyshak]

On Wed, Oct 25, 2017 at 10:05:46PM +, Richard Heck wrote:
> On 10/24/2017 01:29 AM, Scott Kostyshak wrote:
> > On Mon, Oct 23, 2017 at 08:44:07AM +, Enrico Forestieri wrote:
> >> On Sun, Oct 22, 2017 at 09:36:56PM -0400, Richard Heck wrote:
> >>> On 10/22/2017 06:19 PM, Scott Kostyshak wrote:
>  On Sat, Oct 14, 2017 at 06:37:06AM +, Jürgen Spitzmüller wrote:
> 
> > Also, I think we should consider Günter's lyx2lyx patch [1], but I
> > didn't have time to thoroughly review it myself.
>  Will anyone have time to take a look at the patch by Wednesday?
> >>> I could look at the code from a code-triaging point of view, but I have
> >>> not followed
> >>> the controversy about this, so someone would need to tell me what the
> >>> code is supposed
> >>> to do.
> >> I don't think this is a change that should be performed at a RC1 stage,
> >> frankly. It is too risky and of dubious utility.
> > Thanks for bringing up this concern. The patch is not trivial. Further,
> > the patch only deals with backwards compatibility. From what I recall,
> > we place a higher importance on forward conversion, and although we do
> > make efforts to provide good backward compatibility, I believe that we
> > have at times knowingly not implemented certain functionality in our
> > backwards conversion. Indeed, our "Development" manual covers this:
> >
> >   While the conversion routine is required to produce a document that
> >   is equivalent to the old version, the requirements of the reversion
> >   are not that strict. If possible, try to produce a proper reversion,
> >   using ERT if needed, but for some features this might be too
> >   complicated. In this case, the minimum requirement of the reversion
> >   routine is that it produces a valid document which can be read by an
> >   older LyX. If absolutely needed, even data loss is allowed for the
> >   reversion.
> >
> > The current code (without the patch) clearly already satisfies the
> > "minimum requirement". All this to say: I don't think the patch is too
> > important for 2.3.0 and in my opinion I'm fine if we do not put it in.
> >
> > Since I don't think the patch is critical, and since we are hopefully a
> > couple of days from going forward with a freeze for RC1, I propose that
> > we should only consider this patch if a developer gives a "very
> > confident" +1, and if we have an extensive test suite. 
> 
> The whole lyx2lyx test suite issue is one we should sort out, but we don't
> have any such thing at this point.
> 
> I don't have a strong opinion on the issues that led to this patch, but
> it seems to me that we aredoing a lot here, too much for this late in the
> game.

OK let's take this off the list for 2.3.0 then.

> The actual problem is the deletion of ZWSP characters, which 72a488d7
> said was needed "so that they don't accumulate". The concern here, I take
> it, is that reverting to a pre-2.3.x format and then re-importing might
> lead to a stack of these things. Why not just make sure that doesn't
> happen? I.e., check if there's a stack of them, and if so fix that?

Is this something you think we should consider for rc1?

Thanks for taking a look,

Scott


signature.asc
Description: PGP signature

Re: LyX-Workarea: Background not shown correctly

[pdv]

On 25/10/2017 16:15, Patrick De Visschere wrote:


I do not like much the idea of just restricting the update area, since it seems 
very fragile. But we can return to it if needed. There are ways to get all the 
coordinates that we need.


I agree. The dimensions passed via update(x,y,w,h) and the actual area painted 
must match exactly. I cannot judge the penalty of the screen redraws. I doesn’t 
seem to hurt very much.
Nevertheless I have now something which works mostly. There are still problems 
when dragging a selection but I believe these can be solved by fine tuning. The 
other problem is that when opening a document the screen stil turns black.



I'm afraid the latter problem cannot (easily) be solved.
When opening a document (I used a simple one with 3 lines with 1 
character each) viewport()->update() is executed 4x.


2x with update_flags_=ForceDraw and update_strategy=FullScreenUpdate
and 2x with update_strategy=SingleParUpdate

Both FullScreenUpdates are initiated by 
TabWorkArea::on_currentTabChanged(), the second one following a 
QEvent::FocusIn.


Although the second call is redundant this is probably not an oversight.

Unfortunately since the screen has already been drawn after the first 
update(), the tm::drawPargraph code does not redraw it the 2nd time, but 
the screen has been erased by qt again after the second update().


pdv

Re: Freeze 2.3.x on Wednesday for rc1?

[Guenter Milde]

Dear Scott,

On 2017-10-25, Scott Kostyshak wrote:

> [-- Type: text/plain, Encoding: quoted-printable --]

> On Tue, Oct 24, 2017 at 03:13:38PM +, Guenter Milde wrote:
>> On 2017-10-22, Uwe Stöhr wrote:
>> > El 22.10.2017 a las 20:08, Scott Kostyshak escribió:

...

>> > I just checked the docs that all changes are now accepted.

>> There is still the pending patch with the dash documentation update.

> From what I understand, no one has objected to the documentation patch,
> except for the part to RELEASE-NOTES (which I believe we have resolved).
> Thus, unless I misunderstood something, please go ahead and commit to
> 2.3.x.

I had some off-list discussion with Uwe about the dash-documentation
resulting in some changes to his changes to my changes.

Currently, I implemented them with change tracking on -- this would need
Uwe's revision to accept the changes and distribute them to other languages
(except German that is included in my patch).

Therefore I rather ask again instead of pushing at this stage...

Thanks, Günter.