Re: [LyX/master] Show cursor correctly whn loading file
Am Donnerstag, 22. November 2018 15:05:53 CET schrieb Jean-Marc Lasgouttes : > commit 2dc84b69d5a040e6343e21606f1c16a7c0957383 > Author: Jean-Marc Lasgouttes > Date: Wed Nov 21 13:49:20 2018 +0100 > > Show cursor correctly whn loading file > > This is a fixup to 8d8988de4. When a file is loaded and the cursor is > set, it is required to first compute metrics to be able to scroll the > screen correctly. > > Fixes bug #11377. > --- Super! Works for me as expected. Kornel signature.asc Description: This is a digitally signed message part.
Re: Patch test with several minor dialog alignment fixes
Am Donnerstag, 22. November 2018 11:03:00 CET schrieb Daniel : > Paragraph dialog fixes attached. > > Daniel +1 Kornel signature.asc Description: This is a digitally signed message part.
Re: Patch test with several minor dialog alignment fixes
On 22/11/2018 10:41, Daniel wrote:
On 22/11/2018 10:38, Daniel wrote:
On 16/11/2018 15:41, Daniel wrote:
On 31/10/2018 18:20, Daniel wrote:
On 31/10/2018 17:46, Daniel wrote:
On 31/10/2018 15:25, Daniel wrote:
On 31/10/2018 07:57, Daniel wrote:
On 31/10/2018 07:24, Daniel wrote:
On 30/10/2018 21:23, Daniel wrote:
On 30/10/2018 17:37, Daniel wrote:
On 30/10/2018 16:46, Scott Kostyshak wrote:
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote:
Thanks for checking. The minimum height was actually a bit
imprecise. I
should have written: "fixed at minimum height". In current
master you can
increase the height but I couldn't see what is to be gained
by this and many
other apps have fixed height find dialogs.
Ah I see. Thanks for the explanation. Seems reasonable to me.
Great. When I find time, I go ahead and fix what seem to me
positioning issues in the other dialogs.
Daniel
Spellchecker dialog.
Thesaurus dialog.
Compare dialog.
Preferences dialog. (This might be a more controversial change.)
Messages Pane.
Search & Replace Advanced. A bit more extensive changes.
Just stumbled upon a misplaced spacer in the Table Insert dialog.
Patch and screen captures attached.
Daniel
I suggest a fixed minimum height for the Text Properties dialog.
Reasons:
- It cannot profit from greater height
- It might not have its minimum height initially and hence look
awkwardly stretched
Daniel
And the patch ...
Paragraph dialog fixes attached.
Daniel
>From ce562ab9c66b7b3bd0c5087101fc5c19ea761e68 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Thu, 22 Nov 2018 10:53:36 +0100
Subject: [PATCH] Paragraph dialog fixes: - Fixed minimum height - Non-flat
groups boxes
---
src/frontends/qt4/GuiParagraph.cpp | 3 +++
src/frontends/qt4/ui/ParagraphUi.ui | 15 ---
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/src/frontends/qt4/GuiParagraph.cpp
b/src/frontends/qt4/GuiParagraph.cpp
index b7e1050a3f..09690f7a9e 100644
--- a/src/frontends/qt4/GuiParagraph.cpp
+++ b/src/frontends/qt4/GuiParagraph.cpp
@@ -50,6 +50,9 @@ GuiParagraph::GuiParagraph(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(alignDefaultRB, SIGNAL(clicked()), this, SLOT(changed()));
connect(alignJustRB, SIGNAL(clicked()), this, SLOT(changed()));
connect(alignLeftRB, SIGNAL(clicked()), this, SLOT(changed()));
diff --git a/src/frontends/qt4/ui/ParagraphUi.ui
b/src/frontends/qt4/ui/ParagraphUi.ui
index 64d7139b2f..09b6c1b96f 100644
--- a/src/frontends/qt4/ui/ParagraphUi.ui
+++ b/src/frontends/qt4/ui/ParagraphUi.ui
@@ -22,9 +22,6 @@
Line spacing
-
- true
-
9
@@ -85,9 +82,6 @@
Alignment
-
- true
-
9
@@ -153,9 +147,6 @@
Label Width
-
- true
-
9
@@ -207,12 +198,6 @@
Qt::Vertical
-
-
- 351
- 16
-
-
--
2.17.0.windows.1
Re: [LyX/master] FindAdv: Optimization
Am Dienstag, 20. November 2018 19:18:52 CET schrieb Scott Kostyshak : ... > > That's the most scaring thing IMHO. > > If I would have known how many problems were waiting in the process, I would > > probably not have started. To mention, that the search is now faster and > > more accurate, > > does not feel adequate compared to the effort needed. > > > > > > That page is just for marketing (to get users excited about 2.4.x) but I > > > > think a lot of users are interested in advanced find, and it gets a lot > > > > of page views. > > > > Maybe, but that is not my feeling, given the sparse feedback I harvested so > > far. > > You mean feedback from developers? Yes. (But I am aware, that I too am not giving much feedback to improvements of others) > For me personally, it seems like a > nice feature, but I remember trying it a long time ago and the replace > ate something important so I got frustrated and haven't used it for a > long time. I think it's just a very hard feature to make robust. So > thanks for working on it. > > > > By the way, I didn't mean the above just for this commit. I meant > > > something that refers to all of the commits you've made, such as > > > "general improvements to advanced find, including..." > > > > I am open to any wording. If it were wrong, I feel confident enough to > > correct offending sentences ... > > Anyway, thanks for the nice words. > > Maybe something like "improvements to advanced find, including > increased speed and fixes to regular expression matching" ? Yes, could you add maybe the following? I fear, I don't have the write access. "Improvements to advanced find, including increased speed and fixes to matching respecting format" All of this is only made for format matching. Of course the most fixes are visible for regular expression handling. > Scott Kornel signature.asc Description: This is a digitally signed message part.
Re: Patch test with several minor dialog alignment fixes
On 22/11/2018 10:38, Daniel wrote:
On 16/11/2018 15:41, Daniel wrote:
On 31/10/2018 18:20, Daniel wrote:
On 31/10/2018 17:46, Daniel wrote:
On 31/10/2018 15:25, Daniel wrote:
On 31/10/2018 07:57, Daniel wrote:
On 31/10/2018 07:24, Daniel wrote:
On 30/10/2018 21:23, Daniel wrote:
On 30/10/2018 17:37, Daniel wrote:
On 30/10/2018 16:46, Scott Kostyshak wrote:
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote:
Thanks for checking. The minimum height was actually a bit
imprecise. I
should have written: "fixed at minimum height". In current
master you can
increase the height but I couldn't see what is to be gained
by this and many
other apps have fixed height find dialogs.
Ah I see. Thanks for the explanation. Seems reasonable to me.
Great. When I find time, I go ahead and fix what seem to me
positioning issues in the other dialogs.
Daniel
Spellchecker dialog.
Thesaurus dialog.
Compare dialog.
Preferences dialog. (This might be a more controversial change.)
Messages Pane.
Search & Replace Advanced. A bit more extensive changes.
Just stumbled upon a misplaced spacer in the Table Insert dialog.
Patch and screen captures attached.
Daniel
I suggest a fixed minimum height for the Text Properties dialog.
Reasons:
- It cannot profit from greater height
- It might not have its minimum height initially and hence look
awkwardly stretched
Daniel
And the patch ...
>From 48176e2a4f695a8e65033a1e4c58a6037cf80092 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Thu, 22 Nov 2018 10:40:09 +0100
Subject: [PATCH] Set fixed minimal height for Text Properties dialog.
---
src/frontends/qt4/GuiCharacter.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/frontends/qt4/GuiCharacter.cpp
b/src/frontends/qt4/GuiCharacter.cpp
index 8b7f3e83d3..bccd3e6115 100644
--- a/src/frontends/qt4/GuiCharacter.cpp
+++ b/src/frontends/qt4/GuiCharacter.cpp
@@ -211,6 +211,9 @@ GuiCharacter::GuiCharacter(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(buttonBox, SIGNAL(clicked(QAbstractButton *)),
this, SLOT(slotButtonBox(QAbstractButton *)));
connect(autoapplyCB, SIGNAL(stateChanged(int)), this,
--
2.17.0.windows.1
Re: Patch test with several minor dialog alignment fixes
On 16/11/2018 15:41, Daniel wrote: On 31/10/2018 18:20, Daniel wrote: On 31/10/2018 17:46, Daniel wrote: On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. Compare dialog. Preferences dialog. (This might be a more controversial change.) Messages Pane. Search & Replace Advanced. A bit more extensive changes. Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached. Daniel I suggest a fixed minimum height for the Text Properties dialog. Reasons: - It cannot profit from greater height - It might not have its minimum height initially and hence look awkwardly stretched Daniel
