Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools #1131

2018-12-25 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1131/


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 18:20, Jürgen Spitzmüller wrote:

Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel:

Thanks. But the buttons are misaligned now (see attachment).


Try again with recent master.

Jürgen



I'll give up. It was fun.

Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 16:29, Jürgen Spitzmüller wrote:

Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel:

Did you check whether those not on the list do actually have GBs?


Yes.



Daniel


And some are missing from your list, like FindAndReplaceUi.ui.


Thanks, added.

Jürgen



Okay, I'll give in.

Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 12:35 +0100 schrieb Jürgen Spitzmüller:
> Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel:
> > Thanks. But I like mine more (see attached screen shot).
> 
> I don't see the misalignment in your screenshot here on Linux. But I
> saw a misalignment with your patch. It maybe depends on the Qt style.

Try again with recent master.

Jürgen


signature.asc
Description: This is a digitally signed message part


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel:
> Thanks. But the buttons are misaligned now (see attachment).

Try again with recent master.

Jürgen


signature.asc
Description: This is a digitally signed message part


Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #1130

2018-12-25 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1130/Changes:

[spitz] Unify group box style across dialogs.

--
[...truncated 623 lines...]
  GEN  ui_ModulesUi.h
  GEN  ui_NomenclUi.h
  GEN  ui_NoteUi.h
  GEN  ui_NumberingUi.h
  GEN  ui_OutputUi.h
  GEN  ui_PageLayoutUi.h
  GEN  ui_ParagraphUi.h
  GEN  ui_PDFSupportUi.h
  GEN  ui_PhantomUi.h
  GEN  ui_PreambleUi.h
  GEN  ui_PrefColorsUi.h
  GEN  ui_PrefCompletionUi.h
  GEN  ui_PrefConvertersUi.h
  GEN  ui_PrefDocHandlingUi.h
  GEN  ui_PrefOutputUi.h
  GEN  ui_PrefDisplayUi.h
  GEN  ui_PrefEditUi.h
  GEN  ui_PrefFileformatsUi.h
  GEN  ui_PrefIdentityUi.h
  GEN  ui_PrefInputUi.h
  GEN  ui_PrefLanguageUi.h
  GEN  ui_PrefLatexUi.h
  GEN  ui_PrefPathsUi.h
  GEN  ui_PrefScreenFontsUi.h
  GEN  ui_PrefShortcutsUi.h
  GEN  ui_PrefSpellcheckerUi.h
  GEN  ui_PrefsUi.h
  GEN  ui_PrefUi.h
  GEN  ui_PrintindexUi.h
  GEN  ui_PrintNomenclUi.h
  GEN  ui_ProgressViewUi.h
  GEN  ui_RefUi.h
  GEN  ui_SearchUi.h
  GEN  ui_SendtoUi.h
  GEN  ui_ShortcutUi.h
  GEN  ui_ShowFileUi.h
  GEN  ui_SpellcheckerUi.h
  GEN  ui_SymbolsUi.h
  GEN  ui_TabularCreateUi.h
  GEN  ui_TabularUi.h
  GEN  ui_TexinfoUi.h
  GEN  ui_TextLayoutUi.h
  GEN  ui_ThesaurusUi.h
  GEN  ui_TocUi.h
  GEN  ui_ToggleWarningUi.h
  GEN  ui_ViewSourceUi.h
  GEN  ui_VSpaceUi.h
  GEN  ui_WorkAreaUi.h
  GEN  ui_WrapUi.h
  GEN  moc_Action.cpp
  GEN  moc_BulletsModule.cpp
  GEN  moc_CategorizedCombo.cpp
  GEN  moc_CustomizedWidgets.cpp
  GEN  moc_DialogView.cpp
  GEN  moc_DockView.cpp
  GEN  moc_EmptyTable.cpp
  GEN  moc_FancyLineEdit.cpp
  GEN  moc_FindAndReplace.cpp
  GEN  moc_FloatPlacement.cpp
  GEN  moc_GuiAbout.cpp
  GEN  moc_GuiApplication.cpp
  GEN  moc_GuiBibitem.cpp
  GEN  moc_GuiBibtex.cpp
  GEN  moc_GuiBox.cpp
  GEN  moc_GuiBranches.cpp
  GEN  moc_GuiBranch.cpp
  GEN  moc_GuiChanges.cpp
  GEN  moc_GuiCharacter.cpp
  GEN  moc_GuiCitation.cpp
  GEN  moc_GuiClipboard.cpp
  GEN  moc_GuiCommandBuffer.cpp
  GEN  moc_GuiCommandEdit.cpp
  GEN  moc_GuiCompare.cpp
  GEN  moc_GuiCompareHistory.cpp
  GEN  moc_GuiCompleter.cpp
  GEN  moc_GuiDelimiter.cpp
  GEN  moc_GuiDialog.cpp
  GEN  moc_GuiDocument.cpp
  GEN  moc_GuiErrorList.cpp
  GEN  moc_GuiERT.cpp
  GEN  moc_GuiExternal.cpp
  GEN  moc_GuiGraphics.cpp
  GEN  moc_GuiHSpace.cpp
  GEN  moc_GuiHyperlink.cpp
  GEN  moc_GuiInclude.cpp
  GEN  moc_GuiIndex.cpp
  GEN  moc_GuiIndices.cpp
  GEN  moc_GuiInfo.cpp
  GEN  moc_GuiLabel.cpp
  GEN  moc_GuiLine.cpp
  GEN  moc_GuiListings.cpp
  GEN  moc_GuiLog.cpp
  GEN  moc_GuiMathMatrix.cpp
  GEN  moc_GuiNomenclature.cpp
  GEN  moc_GuiNote.cpp
  GEN  moc_GuiParagraph.cpp
  GEN  moc_GuiPhantom.cpp
  GEN  moc_GuiPrefs.cpp
  GEN  moc_GuiPrintindex.cpp
  GEN  moc_GuiPrintNomencl.cpp
  GEN  moc_GuiProgress.cpp
  GEN  moc_GuiProgressView.cpp
  GEN  moc_GuiRef.cpp
  GEN  moc_GuiSearch.cpp
  GEN  moc_GuiSelection.cpp
  GEN  moc_GuiSelectionManager.cpp
  GEN  moc_GuiSendto.cpp
  GEN  moc_GuiSetBorder.cpp
  GEN  moc_GuiShowFile.cpp
  GEN  moc_GuiSpellchecker.cpp
  GEN  moc_GuiSymbols.cpp
  GEN  moc_GuiTabularCreate.cpp
  GEN  moc_GuiTabular.cpp
  GEN  moc_GuiTexinfo.cpp
  GEN  moc_GuiThesaurus.cpp
  GEN  moc_GuiToc.cpp
  GEN  moc_GuiToolbar.cpp
  GEN  moc_GuiView.cpp
  GEN  moc_GuiViewSource.cpp
  GEN  moc_GuiVSpace.cpp
  GEN  moc_GuiWorkArea.cpp
  GEN  moc_GuiWrap.cpp
  GEN  moc_IconPalette.cpp
  GEN  moc_InGuiThread.cpp
  GEN  moc_InsertTableWidget.cpp
  GEN  moc_InsetParamsDialog.cpp
  GEN  moc_InsetParamsWidget.cpp
  GEN  moc_LayoutBox.cpp
  GEN  moc_LengthCombo.cpp
  GEN  moc_LyXFileDialog.cpp
  GEN  moc_Menus.cpp
  GEN  moc_PanelStack.cpp
  GEN  moc_TocModel.cpp
  GEN  moc_TocWidget.cpp
  GEN  moc_ToolTipFormatter.cpp
  GEN  moc_Validator.cpp
  GEN  Resources.qrc
  GEN  Resources.cpp
make  all-am
make[6]: Entering directory '/build/workspace/src/frontends/qt4'
  CXX  ButtonPolicy.o
  CXX  Dialog.o
  CXX  Action.o
  CXX  BulletsModule.o
  CXX  ButtonController.o
  CXX  CategorizedCombo.o
  CXX  ColorCache.o
  CXX  CustomizedWidgets.o
  CXX  DialogView.o
  CXX  DockView.o
  CXX  EmptyTable.o
  CXX  FancyLineEdit.o
  CXX  FileDialog.o
  CXX  FindAndReplace.o
  CXX  FloatPlacement.o
  CXX  GuiAbout.o
  CXX  GuiAlert.o
  CXX  GuiApplication.o
  CXX  GuiBibitem.o
  CXX  GuiBibtex.o
  CXX  GuiBox.o
  CXX  GuiBranch.o
  CXX  GuiBranches.o
  CXX  

Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel:
> > Did you check whether those not on the list do actually have GBs?

Yes.

> > 
> > Daniel
> 
> And some are missing from your list, like FindAndReplaceUi.ui.

Thanks, added.

Jürgen



signature.asc
Description: This is a digitally signed message part


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:43 +0100 schrieb Daniel:
> 
> I am probably confused. Do you ask me to recreate my patch with
> current 
> master 

Yes, please.

> which you successfully applied before and found to be misaligned?

Yes.

Thanks
Jürgen

> 
> Daniel
> 


signature.asc
Description: This is a digitally signed message part


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 14:10, Daniel wrote:

On 25/12/2018 12:51, Daniel wrote:

On 25/12/2018 12:26, Jürgen Spitzmüller wrote:

Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel:

Thanks. But the buttons are misaligned now (see attachment).


Not for me (see attachment).


* the Cancel button needs to go on a line of its own.


I understand that this is a general rule of dialogs in LyX. However,
please consider an exception to this rule for the quick search and
replace dialog.


No.


That's hard to reason with. All apps I checked have the checkboxes 
aligned to minimize space.



BTW your patch (in the following message) does not apply to master.


If you remove your patch it should apply fine.



Merry Christmas
Jürgen



Merry Christmas to you too!
Daniel
I really like your critical approach. I think it is beneficial for the 
development of LyX.


But I hope you understand that I question something if I have seen it 
differently in many other parts of or up until now in LyX or in many 
other applications. And if I put my work and thought into something, 
then it leaves me frustrated when I get a "Thanks, but no." without 
further explanation. Maybe you don't have time to explain things but 
please say so if that is the case, then I can make a decision of whether 
something is worth my possible frustration. It might also be beneficial 
to clarify what the rules are. For example,


If it is best practice to put button boxes at the bottom of a dialog, 
then if a dialog has a button box it has to be at the bottom.


If that is the rule LyX by which you operate, then I can understand your 
reaction. Though I strongly disagree with the rule since best practices 
should be broken for good reasons.


I can also understand that you don't explain your decision against 
something if no reason has been given in favour of it. It might be too 
time consuming to explain everything proactively.


I hope clarifying this will help.

Daniel




If it is best practice to put button boxes at the bottom of a dialog, 
then if a dialog has a button box it has to be at the bottom.


To directly apply to the current problem it should have said,

If it is best practice to put button boxes in their own line, then if a 
dialog has a button box it has to be at in its own line.


Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 12:51, Daniel wrote:

On 25/12/2018 12:26, Jürgen Spitzmüller wrote:

Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel:

Thanks. But the buttons are misaligned now (see attachment).


Not for me (see attachment).


* the Cancel button needs to go on a line of its own.


I understand that this is a general rule of dialogs in LyX. However,
please consider an exception to this rule for the quick search and
replace dialog.


No.


That's hard to reason with. All apps I checked have the checkboxes 
aligned to minimize space.



BTW your patch (in the following message) does not apply to master.


If you remove your patch it should apply fine.



Merry Christmas
Jürgen



Merry Christmas to you too!
Daniel
I really like your critical approach. I think it is beneficial for the 
development of LyX.


But I hope you understand that I question something if I have seen it 
differently in many other parts of or up until now in LyX or in many 
other applications. And if I put my work and thought into something, 
then it leaves me frustrated when I get a "Thanks, but no." without 
further explanation. Maybe you don't have time to explain things but 
please say so if that is the case, then I can make a decision of whether 
something is worth my possible frustration. It might also be beneficial 
to clarify what the rules are. For example,


If it is best practice to put button boxes at the bottom of a dialog, 
then if a dialog has a button box it has to be at the bottom.


If that is the rule LyX by which you operate, then I can understand your 
reaction. Though I strongly disagree with the rule since best practices 
should be broken for good reasons.


I can also understand that you don't explain your decision against 
something if no reason has been given in favour of it. It might be too 
time consuming to explain everything proactively.


I hope clarifying this will help.

Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 13:46, Daniel wrote:

On 25/12/2018 13:22, Jürgen Spitzmüller wrote:

Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel:


It is not that only some of the GBs are out of line. Almost all are
non-flat.


I count only a minority where the flat designation was missing. Namely

   src/frontends/qt4/ui/CharacterUi.ui
   src/frontends/qt4/ui/CitationUi.ui
   src/frontends/qt4/ui/CompareUi.ui
   src/frontends/qt4/ui/ExternalUi.ui
   src/frontends/qt4/ui/FloatPlacementUi.ui
   src/frontends/qt4/ui/IncludeUi.ui
   src/frontends/qt4/ui/LaTeXUi.ui
   src/frontends/qt4/ui/ListingsUi.ui
   src/frontends/qt4/ui/MathMatrixUi.ui
   src/frontends/qt4/ui/PhantomUi.ui
   src/frontends/qt4/ui/PrefConvertersUi.ui
   src/frontends/qt4/ui/ProgressViewUi.ui
   src/frontends/qt4/ui/TabularUi.ui

Jürgen


Did you check whether those not on the list do actually have GBs?

Daniel


And some are missing from your list, like FindAndReplaceUi.ui. Even 
though it looks a bit ugly on Windows. I won't fight for this. Maybe it 
looks better on other systems, I couldn't tell.


Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 13:22, Jürgen Spitzmüller wrote:

Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel:


It is not that only some of the GBs are out of line. Almost all are
non-flat.


I count only a minority where the flat designation was missing. Namely

   src/frontends/qt4/ui/CharacterUi.ui
   src/frontends/qt4/ui/CitationUi.ui
   src/frontends/qt4/ui/CompareUi.ui
   src/frontends/qt4/ui/ExternalUi.ui
   src/frontends/qt4/ui/FloatPlacementUi.ui
   src/frontends/qt4/ui/IncludeUi.ui
   src/frontends/qt4/ui/LaTeXUi.ui
   src/frontends/qt4/ui/ListingsUi.ui
   src/frontends/qt4/ui/MathMatrixUi.ui
   src/frontends/qt4/ui/PhantomUi.ui
   src/frontends/qt4/ui/PrefConvertersUi.ui
   src/frontends/qt4/ui/ProgressViewUi.ui
   src/frontends/qt4/ui/TabularUi.ui

Jürgen


Did you check whether those not on the list do actually have GBs?

Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 13:26, Jürgen Spitzmüller wrote:

Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel:

Can you show me what my patch looks like on the style you use? Then
I
could try to figure out what went wrong with it.


If you send me a patch that applies to master, sure.

Jürgen


You wrote before


But I saw a misalignment with your patch.


I am probably confused. Do you ask me to recreate my patch with current 
master which you successfully applied before and found to be misaligned?


Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel:
> Can you show me what my patch looks like on the style you use? Then
> I 
> could try to figure out what went wrong with it.

If you send me a patch that applies to master, sure.

Jürgen

> 
> Daniel
> 


signature.asc
Description: This is a digitally signed message part


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel:
> 
> It is not that only some of the GBs are out of line. Almost all are 
> non-flat.

I count only a minority where the flat designation was missing. Namely

  src/frontends/qt4/ui/CharacterUi.ui
  src/frontends/qt4/ui/CitationUi.ui
  src/frontends/qt4/ui/CompareUi.ui
  src/frontends/qt4/ui/ExternalUi.ui
  src/frontends/qt4/ui/FloatPlacementUi.ui
  src/frontends/qt4/ui/IncludeUi.ui
  src/frontends/qt4/ui/LaTeXUi.ui
  src/frontends/qt4/ui/ListingsUi.ui
  src/frontends/qt4/ui/MathMatrixUi.ui
  src/frontends/qt4/ui/PhantomUi.ui
  src/frontends/qt4/ui/PrefConvertersUi.ui
  src/frontends/qt4/ui/ProgressViewUi.ui
  src/frontends/qt4/ui/TabularUi.ui

Jürgen


signature.asc
Description: This is a digitally signed message part


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 12:35, Jürgen Spitzmüller wrote:

Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel:

Thanks. But I like mine more (see attached screen shot).


I don't see the misalignment in your screenshot here on Linux. But I
saw a misalignment with your patch. It maybe depends on the Qt style.

Jürgen


Can you show me what my patch looks like on the style you use? Then I 
could try to figure out what went wrong with it.


Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 12:26, Jürgen Spitzmüller wrote:

Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel:

Thanks. But the buttons are misaligned now (see attachment).


Not for me (see attachment).


Sorry, forgot to comment on this. That the misalignment does not happen 
for you is because text fields in your window manager have the same 
height as push buttons. But that is not true on other operating systems, 
like Windows.


Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 12:26, Jürgen Spitzmüller wrote:

Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel:

Thanks. But the buttons are misaligned now (see attachment).


Not for me (see attachment).


* the Cancel button needs to go on a line of its own.


I understand that this is a general rule of dialogs in LyX. However,
please consider an exception to this rule for the quick search and
replace dialog.


No.


That's hard to reason with. All apps I checked have the checkboxes 
aligned to minimize space.



BTW your patch (in the following message) does not apply to master.


If you remove your patch it should apply fine.



Merry Christmas
Jürgen



Merry Christmas to you too!
Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 25/12/2018 12:28, Jürgen Spitzmüller wrote:

Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel:

Thanks. You changed the group box style to flat, right? I still
think
this isn't LyX standard.


It's LyX standard. We changed that some years ago. If some GBs are non-
flat, we should change that.

Jürgen


It is not that only some of the GBs are out of line. Almost all are 
non-flat.


I don't know why the decision was made to go away from the Qt default 
but at leat on Windows it would be a change for the worse. Also given 
that almost no dialogs of LyX follow LyX's standard, and no one seems to 
complain, I suggest to reconsider change. What's the benefit of it?


Daniel



Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel:
> Thanks. But I like mine more (see attached screen shot).

I don't see the misalignment in your screenshot here on Linux. But I
saw a misalignment with your patch. It maybe depends on the Qt style.

Jürgen


signature.asc
Description: This is a digitally signed message part


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel:
> Thanks. You changed the group box style to flat, right? I still
> think 
> this isn't LyX standard.

It's LyX standard. We changed that some years ago. If some GBs are non-
flat, we should change that.

Jürgen


signature.asc
Description: This is a digitally signed message part


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Jürgen Spitzmüller
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel:
> Thanks. But the buttons are misaligned now (see attachment). 

Not for me (see attachment).

> > * the Cancel button needs to go on a line of its own.
> 
> I understand that this is a general rule of dialogs in LyX. However, 
> please consider an exception to this rule for the quick search and 
> replace dialog. 

No.

BTW your patch (in the following message) does not apply to master.

Merry Christmas
Jürgen


signature.asc
Description: This is a digitally signed message part


Re: [LyX/master] Use symbols file to lookup entities for delimiters. Fixes bug #8280.

2018-12-25 Thread Kornel Benko
Am Montag, 24. Dezember 2018 22:19:56 CET schrieb Scott Kostyshak 
:
> On Fri, Jun 08, 2018 at 11:16:21PM -0400, Scott Kostyshak wrote:
> > On Sat, Apr 28, 2018 at 09:19:41PM +, Scott Kostyshak wrote:
> > > On Thu, Jun 30, 2016 at 02:40:30AM +, Richard Heck wrote:
> > > > commit 04b8f5cdc4b26105ea855fb9ec5b23227dfd55cb
> > > > Author: Richard Heck 
> > > > Date:   Wed Jun 29 22:39:42 2016 -0400
> > > > 
> > > > Use symbols file to lookup entities for delimiters. Fixes bug #8280.
> > > > 
> > > > Based upon work by Josh Hieronymus.
> > > > ---
> > > 
> > > > +docstring convertDelimToXMLEscape(docstring const & name)
> > > > +{
> > > > +   if (name.size() == 1) {
> > > > +   char_type const c = name[0];
> > > > +   if (c == '<')
> > > > +   return from_ascii("<");
> > > > +   else if (c == '>')
> > > > +   return from_ascii(">");
> > > > +   else
> > > > +   return name;
> > > > +   }
> > > > +   MathWordList const & words = mathedWordList();
> > > > +   MathWordList::const_iterator it = words.find(name);
> > > > +   if (it != words.end()) {
> > > > +   docstring const escape = it->second.xmlname;
> > > > +   return escape;
> > > > +   }
> > > > +   LYXERR0("Unable to find `" << name <<"' in the mathWordList.");
> > > > +   return name;
> > > > +}
> > > 
> > > If I open Math.lyx, select all, and copy, I get the following messages:
> > > 
> > >   mathed/MathStream.cpp (715): Unable to find `\{' in the mathWordList.
> > >   mathed/MathStream.cpp (715): Unable to find `\}' in the mathWordList.
> > > 
> > > I can reproduce to soon after this commit, so I'm guessing it has always
> > > been here.
> > > 
> > > Any ideas how to fix it?
> > 
> > Bump. Any ideas?
> 
> I can still reproduce on master. Is this worth opening a trac ticket?
> 
> Scott
> 

Easy to reproduce with attached. $\big\{\big\}$
Similar debug output also with $\Big\{\Big\}$ and so on.

Kornel


big.lyx
Description: application/lyx


signature.asc
Description: This is a digitally signed message part.


Re: Patch test with several minor dialog alignment fixes

2018-12-25 Thread Daniel

On 24/12/2018 22:45, Daniel wrote:

On 24/12/2018 14:48, Jürgen Spitzmüller wrote:

Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel:

On 29/10/2018 14:12, Daniel wrote:

Attached is a patch for the Find & Replace (Quick) dialog for
master. If
the patch is works, I could proceed with the other dialog fixes.


Sorry, reordered checkboxes for no good reason...


Finally applied to master, with some changes:

* the "Replace All" button didn't align well with the others (at least
in German l7n)


Thanks. But the buttons are misaligned now (see attachment). For some 
reason I cannot choose another UI language in master, so I can't test 
what it looks like in German.



* the Cancel button needs to go on a line of its own.


I understand that this is a general rule of dialogs in LyX. However, 
please consider an exception to this rule for the quick search and 
replace dialog. The reason are that


1) quick and search should use as limited space as possible because 
might float over the work area to make search results visisble


and

2) this is a very restricted button box with only one button anyway.

Daniel


Attached is another attempt at the Find & Replace (Quick) dialog (patch 
and screen shots). As you see from the shots, I managed to change 
languages too, so that should work as well. Thanks for checking that in 
the first place.


Daniel
From 876c8d8f6cbe1e0cd6a597f5823c6c6e01941d30 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller 
Date: Mon, 29 Oct 2018 14:08:34 +0100
Subject: [PATCH 1/2] Fix for Find & Replace (Quick) dialog: - fixed maximum
 height to minimum height - uncouple buttons from checkboxes

---
 src/frontends/qt4/GuiSearch.cpp  |   3 +
 src/frontends/qt4/ui/SearchUi.ui | 340 ---
 2 files changed, 174 insertions(+), 169 deletions(-)

diff --git a/src/frontends/qt4/GuiSearch.cpp b/src/frontends/qt4/GuiSearch.cpp
index dd1a002fed..02678fae60 100644
--- a/src/frontends/qt4/GuiSearch.cpp
+++ b/src/frontends/qt4/GuiSearch.cpp
@@ -47,6 +47,9 @@ GuiSearch::GuiSearch(GuiView & lv)
 {
setupUi(this);
 
+   // fix height to minimum
+   setFixedHeight(sizeHint().height());
+
connect(buttonBox, SIGNAL(clicked(QAbstractButton *)),
this, SLOT(slotButtonBox(QAbstractButton *)));
connect(findPB, SIGNAL(clicked()), this, SLOT(findClicked()));
diff --git a/src/frontends/qt4/ui/SearchUi.ui b/src/frontends/qt4/ui/SearchUi.ui
index ebc00e3cfc..7886d94de9 100644
--- a/src/frontends/qt4/ui/SearchUi.ui
+++ b/src/frontends/qt4/ui/SearchUi.ui
@@ -16,48 +16,10 @@
   
true
   
-  
-   
-
- 
-  Fi&nd:
- 
- 
-  findCO
- 
-
-   
-   
-
- 
-  
-   0
-   0
-  
- 
- 
-  Qt::StrongFocus
- 
- 
-  true
- 
- 
-  666
- 
- 
-  QComboBox::InsertAtTop
- 
- 
-  false
- 
- 
-  false
- 
-
-   
-   
-
- 
+  
+   
+
+ 
   

 false
@@ -70,151 +32,191 @@

   
  
- 
-  
-   
-false
+ 
+  
+   
+Fi&nd:
+   
+   
+findCO

+  
+ 
+ 
+  

-&Replace
+Repla&ce with:
+   
+   
+replaceCO

   
  
- 
-  
-   
+ 
+  
+   
+
+ 0
+ 0
+
+   
+   
+Qt::StrongFocus
+   
+   
+true
+   
+   
+666
+   
+   
+QComboBox::InsertAtTop
+   
+   
 false

-   
-Replace &All
+   
+false

   
  
- 
-  
-   
-QDialogButtonBox::Close
+ 
+  
+   
+
+ 0
+ 0
+
+   
+   
+true
+   
+   
+666
+   
+   
+QComboBox::InsertAtTop
+   
+   
+false
+   
+   
+false
+   
+  
+ 
+ 
+  
+   
+false
+   
+   
+&Replace

   
  
 

-   
-
- 
-  Repla&ce with:
- 
- 
-  replaceCO
- 
-
-   
-   
-
- 
-  
-   0
-   0
-  
- 
- 
-  true
- 
- 
-  666
- 
- 
-  QComboBox::InsertAtTop
- 
- 
-  false
- 
- 
-  false
- 
-
-   
-   
-
- 
-  Case &sensitive[[search]]
- 
-
-   
-   
-
- 
-  Qt::Horizontal
- 
- 
-  QSizePolicy::Expanding
- 
- 
-  
-   20
-   20
-  
- 
-
-   
-   
-
- 
-  Match w&hole words only
- 
-
-   
-   
-
- 
-  Search &backwards
- 
-
-   
-   
-
- 
-  Qt::Vertical
- 
- 
-  QSizePolicy::Expanding
- 
- 
-  
-   20
-   20
-  
- 
-
-   
-   
-
- 
-  Qt::Vertical
- 
- 
-  QSize