Re: [LyX/2.4.x] New status file, and status for last commit

2024-06-02 Thread Kornel Benko
Am Thu, 30 May 2024 12:17:15 -0400
schrieb Richard Kimberly Heck :

> On 5/30/24 02:46, Jürgen Spitzmüller wrote:
> > Am Mittwoch, dem 29.05.2024 um 14:50 + schrieb Richard Kimberly
> > Heck:  
> >> commit e80fdf38e4dc095316547371d22284676e2e6c7d
> >> Author: Richard Kimberly Heck 
> >> Date:   Wed May 29 10:49:58 2024 -0400
> >>
> >>      New status file, and status for last commit  
> > What is the relation of this (and the commit it documents) wrt the
> > 2.4.1-devel branch (which already has a status file)?  
> 
> If we need an quick (emergency) release, then 2.4.x will become 2.4.1. 
> This seemed a bad enough regression to include in such a release. If we 
> don't need a quick release, then I'll merge 2.4.1-devel into master, and 
> that will become 2.4.1.
> 
> Riki
> 
> 

This is very confusing.
If 2.4.x will become 2.4.1, what happens with 2.4.1~devel?

Kornel


pgpTRwygeqZbG.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


operator << for Cursor seems to not work

2024-05-30 Thread Kornel Benko
I see it while checking the output of
LYXERR(Debug::FINDVERBOSE, "Advancing pos: cur=" << cur);
The only output is
'lyxfind.cpp (4504): Advancing pos: cur='

Gdb never enters Cursor.cpp:164
LyXErr & operator<<(LyXErr & os, CursorData const & cur)

What changed? It worked at some time.

Kornel


pgpZGJWnVjJOj.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: CMake: LYX_PROGRAM_SUFFIX=OFF -> user dir .lyx or .lyx2.4?

2024-05-26 Thread Kornel Benko
Am Sun, 26 May 2024 08:52:30 +0200
schrieb Jean-Marc Lasgouttes :

> For a reference point, that is what happens with auto tools. However the macOS
> packaging usus the same convention as you describe.
> 
> Kornel, we should decide what is best :)

I prefer the suffix version of the  user dir. Suppose someone is forced to 
downgrade. In
this case it would be handy if the old user dir is unchanged.

> JMarc 
> 
> Le 26 mai 2024 04:52:40 GMT+02:00, Scott Kostyshak  a écrit 
> :
> >(not important for 2.4.0 release)
> >
> >
> >If I set:
> >
> >  -DLYX_PROGRAM_SUFFIX=OFF
> >
> >then the created binary is just "lyx" (as opposed to lyx24).
> >
> >However, the user directory is ~/.lyx2.4. In this case, shouldn't the user 
> >directory
> >be ~/.lyx?
> >
> >Scott

Kornel


pgpNK13X2buNR.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo wrong target dir?

2024-05-24 Thread Kornel Benko
Am Fri, 24 May 2024 12:21:07 -0400
schrieb Richard Kimberly Heck :
>> > On 5/23/24 16:22, Yu Jin wrote:
>> > > Am Do., 23. Mai 2024 um 22:06 Uhr schrieb Yu Jin:
...
> >> > > I found the issue. SYSTEM_DATADIR is set
> >> > > (https://git.lyx.org/gitweb/?p=lyx.git;a=blob;f=CMakeLists.txt;h=228ef34a2e431e8b9be724eab05fdb09c13c5937;hb=HEAD#l537)
> >> > > before CMAKE_INSTALL_PREFIX is set
> >> > > (https://git.lyx.org/gitweb/?p=lyx.git;a=blob;f=CMakeLists.txt;h=228ef34a2e431e8b9be724eab05fdb09c13c5937;hb=HEAD#l573).
> >> > > Then metainfo file is installed into the wrong SYSTEM_DATADIR here
> >> > > https://git.lyx.org/gitweb/?p=lyx.git;a=blob;f=development/cmake/Install.cmake;h=a901942b4adb88e92cd9663f091c826db37a60fa;hb=HEAD#l191
> >> >
> >> > Good work! Do you have a patch?
> >> >
> >> > Riki
> >> >
> >> 
> >> Eugene, could you try this?
> > 
> > Works and 2.4.x compiles successfully now.
> > 
> Go ahead and commit, Kornel, and I'll build the tarballs.
> 
> Riki

Done at ea74574d. Thanks Eugene.

Kornel


pgpH5pJeo5feL.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo wrong target dir?

2024-05-24 Thread Kornel Benko
Am Thu, 23 May 2024 22:14:37 -0400
schrieb Richard Kimberly Heck :

> On 5/23/24 16:22, Yu Jin wrote:
> > Am Do., 23. Mai 2024 um 22:06 Uhr schrieb Yu Jin :
> >
> > Am Do., 23. Mai 2024 um 10:05 Uhr schrieb Kornel Benko:
> >
> > Am Wed, 22 May 2024 19:09:05 +0200
> > schrieb Yu Jin:
> > > It would be no problem for me, but I think that this still
> > should be
> > > addressed and solved.
> > > Kornel, did you find anything useful in the output?
> >
> > No relevant differences. This implies (for me) that the
> > created CMakeCache.txt files
> > don't differ.
> >
> > Just checked to be sure, the CMakeCache.txt files are identical.
> >
> > So I have no idea, why the created project files could be
> > different. 
> >
> >
> > I found the issue. SYSTEM_DATADIR is set 
> > (https://git.lyx.org/gitweb/?p=lyx.git;a=blob;f=CMakeLists.txt;h=228ef34a2e431e8b9be724eab05fdb09c13c5937;hb=HEAD#l537)
> >  
> > before CMAKE_INSTALL_PREFIX is set 
> > (https://git.lyx.org/gitweb/?p=lyx.git;a=blob;f=CMakeLists.txt;h=228ef34a2e431e8b9be724eab05fdb09c13c5937;hb=HEAD#l573).
> >  
> > Then metainfo file is installed into the wrong SYSTEM_DATADIR here 
> > https://git.lyx.org/gitweb/?p=lyx.git;a=blob;f=development/cmake/Install.cmake;h=a901942b4adb88e92cd9663f091c826db37a60fa;hb=HEAD#l191
> 
> Good work! Do you have a patch?
> 
> Riki
> 

Eugene, could you try this?

Kornel
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 363f413153..024a1a619b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -524,12 +524,23 @@ if(LYX_BUNDLE)
 endif()
 
 if(LYX_INSTALL_PREFIX)
 	set(CMAKE_INSTALL_PREFIX ${LYX_INSTALL_PREFIX} CACHE PATH "LyX user's choice install prefix" FORCE)
 	set(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
+set(LYX_INSTALL_PREFIX ${LYX_INSTALL_PREFIX} CACHE PATH "LyX user's choice install prefix" FORCE)
 endif()
-set(LYX_INSTALL_PREFIX ${LYX_INSTALL_PREFIX} CACHE PATH "LyX user's choice install prefix" FORCE)
+if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
+ # see http://www.cmake.org/pipermail/cmake/2006-October/011559.html
+ if (UNIX)
+ # use the default "/usr/local"
+ # but respect the user-choice on the command-line
+ set(CMAKE_INSTALL_PREFIX "/usr/local" CACHE PATH "LyX default install prefix" FORCE)
+ endif()
+ if(WIN32)
+ set(CMAKE_INSTALL_PREFIX LYX_INSTALLED CACHE PATH "LyX default install prefix" FORCE)
+ endif()
+ endif()
 
 if(UNIX)
   set(SYSTEM_DATADIR "${CMAKE_INSTALL_PREFIX}/share")
 elseif(CMAKE_INSTALL_PREFIX MATCHES "/lyx${LYX_INSTALL_SUFFIX}$")
   string(REGEX REPLACE "/lyx${LYX_INSTALL_SUFFIX}$" "/share" SYSTEM_DATADIR ${CMAKE_INSTALL_PREFIX})
@@ -559,21 +570,10 @@ if(suffixing)
 	set(PACKAGE ${PACKAGE_BASE}${LYX_INSTALL_SUFFIX})
 else()
 	set(PACKAGE ${PACKAGE_BASE})
 endif()
 
-if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
-	# see http://www.cmake.org/pipermail/cmake/2006-October/011559.html
-	if (UNIX)
-		# use the default "/usr/local"
-		# but respect the user-choice on the command-line
-		set(CMAKE_INSTALL_PREFIX "/usr/local" CACHE PATH "LyX default install prefix" FORCE)
-	endif()
-endif()
-if(WIN32)
-	set(CMAKE_INSTALL_PREFIX LYX_INSTALLED CACHE PATH "LyX default install prefix" FORCE)
-endif()
 if(IS_ABSOLUTE)
 	set(CMAKE_INSTALL_PREFIX_ABSOLUTE ${CMAKE_INSTALL_PREFIX})
 else()
 	set(CMAKE_INSTALL_PREFIX_ABSOLUTE ${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_PREFIX})
 endif()


pgpX_tGkQrSgk.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo wrong target dir?

2024-05-23 Thread Kornel Benko
Am Wed, 22 May 2024 19:09:05 +0200
schrieb Yu Jin :

> Am Mi., 22. Mai 2024 um 15:56 Uhr schrieb Pavel Sanda:
> 
> > On Thu, May 16, 2024 at 10:35:45PM +0200, Yu Jin wrote:
> > > > > > You could check the value at CMakeLists.txt:575 (after being set on
> > > > line 573).
> > > > > > message(STATUS
> > "CMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}")
> > > > > >
> > > > > This is the output
> > > > > CMAKE_INSTALL_PREFIX=LYX_INSTALLED
> > > > > looks fine I guess.
> > > >
> > > > For me it looks wrong. (Should be full path).
> > > >
> > > > I am interested of the output when run the first time compared to run
> > on
> > > > second time.
> > > >
> > > Attached. Both runs in one file one after another.
> > >
> > > > Also are you compiling as bundle (I hope not)?
> > > >
> > > No.
> >
> > As I am not sensing anyone is heading towards investigating this
> > what if we release with the windows instruction to simply run
> > cmake twice?
> >
> 
> It would be no problem for me, but I think that this still should be
> addressed and solved.
> Kornel, did you find anything useful in the output?

No relevant differences. This implies (for me) that the created CMakeCache.txt 
files
don't differ. So I have no idea, why the created project files could be 
different.

Sorry
Kornel


pgp08LeYWdteZ.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Failing export tests

2024-05-20 Thread Kornel Benko
Am Mon, 20 May 2024 10:40:35 -0400
schrieb Scott Kostyshak :

> On Mon, May 20, 2024 at 03:11:41PM GMT, Kornel Benko wrote:
> > Am Mon, 20 May 2024 14:27:26 +0200
> > schrieb "Jürgen Spitzmüller" :
> >   
> > > Am Montag, dem 20.05.2024 um 11:40 +0200 schrieb Kornel Benko:  
> > > > Some russian documents fail  
> > > 
> > > They work for me if I set appropriate fonts. What error do you get?  
> > 
> > After rerunning the Russian tests, they passed here too. Interestingly the 
> > needed time
> > was way smaller (instead of about 1000s now they needed each 30-60s).  
> 
> The problem with those tests is that, from the little that I understand,
> LuaTeX does not generate the fonts needed. The reason they pass on your
> second try is that other engines do generate the fonts.
> 
> In lyx-tester I build the fonts manually before running the tests. It is
> hackish, but you can see it here:
> 
>   
> https://gitlab.com/scottkosty/lyx-tester/-/blob/master/lyx-tester?ref_type=heads#L561
> Probably a better hack would be to run the other tests first. e.g., we
> could add some dependencies like "pdf5 and dvi3 test for Russian
> documents must be run after the pdf2 tests", but I don't know if that's
> possible with the ctests.

I don't see a way to order the tests. Maybe run first run xelatex tests
 with '-R pdf4_systemF' and then run with added '-E pdf4_systemF'

> I asked a question for alternative workarounds:
> 
>   
> https://tex.stackexchange.com/questions/649259/can-i-ask-luatex-to-run-mktextfm

Not much help there :(

> By the way, this issue had stumped me for probably about a year before I
> figured it out, because it seemed random and not reproducible.
> 
> Scott

Kornel


pgp3LnIvm7L24.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Failing export tests

2024-05-20 Thread Kornel Benko
Am Mon, 20 May 2024 10:35:56 -0400
schrieb Scott Kostyshak :

> On Mon, May 20, 2024 at 04:17:02PM GMT, Jürgen Spitzmüller wrote:
> > Am Montag, dem 20.05.2024 um 15:11 +0200 schrieb Kornel Benko:  
> > > So the only remaining test is
> > > export/export/latex/languages/supported-languages_polyglossia-
> > > XeTeX_pdf4_systemF  
> > 
> > Compiles for me. What errors do you get? 
.
LaTeX.cpp (286): Run #1
This is XeTeX, Version 3.141592653-2.6-0.96 (TeX Live 2024) (preloaded 
format=xelatex)
 \write18 enabled.
entering extended mode
(./supported-languages_polyglossia-XeTeX_pdf4_systemF.tex
LaTeX2e <2023-11-01> patch level 1
L3 programming layer <2024-04-11>


xdvipdfmx:fatal: Invalid font: -1 (27)

...
No output PDF file written.
support/Systemcall.cpp (306): Systemcall: 'xelatex
"supported-languages_polyglossia-XeTeX.tex"' finished with exit code 1 This is 
XeTeX,
Version 3.141592653-2.6-0.96 (TeX Live 2024) (preloaded format=xelatex) 
restricted
\write18 enabled. entering extended mode
(./supported-languages_polyglossia-XeTeX.tex
LaTeX2e <2023-11-01> patch level 1
L3 programming layer <2024-04-11>


xdvipdfmx:fatal: Invalid font: -1 (27)

No output PDF file written.
support/Systemcall.cpp (306): Systemcall: 'xelatex
"supported-languages_polyglossia-XeTeX.tex"' finished with exit code 1 Error: 
LaTeX failed

The external program
xelatex 
finished with an error. It is recommended you fix the cause of the external 
program's
error (check the logs). 

The used program 'xdvipdfmx' is from TL24. I have not seen which font triggers 
the error.

> Compiles here also. At some point in the recent past (within a week or
> so), this test failed for me. But I think it was because I was using
> polyglossia dev (from GitHub). If that happens to be the case for you,
> Kornel, do a pull since it's been fixed. If you're using polyglossia
> stable it passes for me there also.
> 
> Scott

Using the version from TL. Updated TL before the test.
    # kpsewhich polyglossia.sty
/usr9/local/texlive/2024/texmf-dist/tex/latex/polyglossia/polyglossia.sty

Kornel


pgpSr4hcXretl.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Failing export tests

2024-05-20 Thread Kornel Benko
Am Mon, 20 May 2024 14:27:26 +0200
schrieb "Jürgen Spitzmüller" :

> Am Montag, dem 20.05.2024 um 11:40 +0200 schrieb Kornel Benko:
> > Some russian documents fail
> 
> They work for me if I set appropriate fonts. What error do you get?

After rerunning the Russian tests, they passed here too. Interestingly the 
needed time
was way smaller (instead of about 1000s now they needed each 30-60s).

> > Also failing American_Astronomical_Society
> 
> This is because \acknowledgements has been deprecated in favor of an
> environment, and the class errors out with a message printed in the
> document if you use it (not a brilliant idea, but there you go). See
> https://journals.aas.org/aastexguide/#acknowledgments
> 
> I suppose something like the attached is needed.
> 

Yes, this helps. At least the tests passed.

So the only remaining test is
export/export/latex/languages/supported-languages_polyglossia-XeTeX_pdf4_systemF

Kornel



pgphuxjTax2Aq.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


[LyX/master] Failing export tests

2024-05-20 Thread Kornel Benko

This part is OK, this means Knittr +beamer works
INVERTED.LYXBUGS_export/export/latex/lyxbugs/ed62816e-knitr-comment-beamer_dvi
INVERTED.LYXBUGS_export/export/latex/lyxbugs/ed62816e-knitr-comment-beamer_dvi3_systemF
INVERTED.LYXBUGS_export/export/latex/lyxbugs/ed62816e-knitr-comment-beamer_pdf
INVERTED.LYXBUGS_export/export/latex/lyxbugs/ed62816e-knitr-comment-beamer_pdf2
INVERTED.LYXBUGS_export/export/latex/lyxbugs/ed62816e-knitr-comment-beamer_pdf3
INVERTED.LYXBUGS_export/export/latex/lyxbugs/ed62816e-knitr-comment-beamer_pdf4_systemF
INVERTED.LYXBUGS_export/export/latex/lyxbugs/ed62816e-knitr-comment-beamer_pdf5_systemF

DEFAULTOUTPUT_export/export/latex/languages/supported-languages_polyglossia-XeTeX_pdf4_systemF

Some russian documents fail
export/doc/ru/Additional_dvi3_texF
export/doc/ru/Additional_pdf5_texF
export/doc/ru/EmbeddedObjects_dvi3_texF
export/doc/ru/EmbeddedObjects_pdf5_texF
export/doc/ru/Intro_dvi3_texF
export/doc/ru/Math_dvi3_texF
export/doc/ru/Math_pdf5_texF
export/doc/ru/Shortcuts_dvi3_texF
export/doc/ru/Shortcuts_pdf5_texF

Also failing American_Astronomical_Society
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_dvi
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_dvi3_texF
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_dvi3_systemF
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf2
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf3
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf4_systemF
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf5_texF
export/examples/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf5_systemF
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_dvi
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_dvi3_texF
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_dvi3_systemF
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf2
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf3
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf4_systemF
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf5_texF
export/templates/Articles/American_Astronomical_Society_%28AASTeX_v._6.3.1%29_pdf5_systemF

Kornel

PS:
Not tested exports using tex2lyx


pgpRuFIi3RFg2.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Sat, 18 May 2024 15:09:44 +0200
schrieb "Jürgen Spitzmüller" :

> Am Samstag, dem 18.05.2024 um 14:16 +0200 schrieb Kornel Benko:
> > Am Sat, 18 May 2024 13:58:21 +0200
> > schrieb Jean-Marc Lasgouttes :
> >   
> > > Le 18/05/2024 à 13:52, Kornel Benko a écrit :  
> > > > Test passes after the attached patch.    
> > > 
> > > The patch looks good. Is this where other variables are
> > > initialized, or 
> > > is it in the constructor here?
> > > 
> > > JMarc
> > >   
> > 
> > It is the constructor as I see it.
> > 
> > Kornel  
> 
> But why is this patch then not needed for use_booktabs for instance?
> This is also only initialized in the constructor.
> 

Maybe they are not used prior to be set. How should I know? I am reacting to 
the output of
valgrind only.

Kornel


pgptsxwyELbHl.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Sat, 18 May 2024 13:58:21 +0200
schrieb Jean-Marc Lasgouttes :

> Le 18/05/2024 à 13:52, Kornel Benko a écrit :
> > Test passes after the attached patch.  
> 
> The patch looks good. Is this where other variables are initialized, or 
> is it in the constructor here?
> 
> JMarc
> 

It is the constructor as I see it.

Kornel


pgpWKxtTnOtPg.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Sat, 18 May 2024 12:12:56 +0200
schrieb Kornel Benko :

> Am Fri, 17 May 2024 15:21:10 +0200
> schrieb Kornel Benko :
> 
> > > Did you try to run LyX under valgrind? It can be very useful in such 
> > > cases.
> > 
> > Will try later ... now grandpa duties
> >   
> > > JMarc
> > 
> > Kornel  
> 
> Ok there are plenty of errors. Using
>   # valgrind --track-origins=yes -s --log-file=xx bin/lyx2.5 \
> .../doc/es/UserGuide.23.lyx
> 
> the created file xx is
>   # ls -l xx 503595
>   # wc xx
>   3360  30798 503595 xx
> Too big to post, I suppose.
> 
> The output relevant to the runtime error is
> 
> ==5546== Conditional jump or move depends on uninitialised value(s)
> ==5546==at 0x4705C0F: lyx::Tabular::updateIndexes() 
> (InsetTabular.cpp:1070)
> ==5546==by 0x46FC58D: lyx::Tabular::init(lyx::Buffer*, unsigned long, 
> unsigned long)
> (InsetTabular.cpp:786) ==5546==by 0x46FB7EE: 
> lyx::Tabular::Tabular(lyx::Buffer*,
> unsigned long, unsigned long) (InsetTabular.cpp:762) ==5546==by 0x474F087:
> lyx::InsetTabular::InsetTabular(lyx::Buffer*, unsigned long, unsigned long)
> (InsetTabular.cpp:4495) ==5546==by 0x3E78AD4: 
> lyx::readInset(lyx::support::Lexer&,
> lyx::Buffer*) (factory.cpp:652) ==5546==by 0x3C73DB6:
> lyx::Text::readParToken(lyx::Paragraph&, lyx::support::Lexer&,
> std::__cxx11::basic_string, std::allocator 
> > const&,
> lyx::Font&, lyx::Change&, lyx::ErrorList&) (Text.cpp:476) ==5546==by 
> 0x3C79085:
> lyx::Text::readParagraph(lyx::Paragraph&, lyx::support::Lexer&, 
> lyx::ErrorList&)
> (Text.cpp:633) ==5546==by 0x3C920B2: lyx::Text::read(lyx::support::Lexer&,
> lyx::ErrorList&, lyx::InsetText*) (Text.cpp:2114) ==5546==by 0x47D74E3:
> lyx::InsetText::read(lyx::support::Lexer&) (InsetText.cpp:172) ==5546==by 
> 0x4412EEB:
> lyx::InsetCollapsible::read(lyx::support::Lexer&) (InsetCollapsible.cpp:161) 
> ==5546==
> by 0x447C4BD: lyx::InsetFloat::read(lyx::support::Lexer&) 
> (InsetFloat.cpp:330) ==5546==
>  by 0x3E79B33: lyx::readInset(lyx::support::Lexer&, lyx::Buffer*) 
> (factory.cpp:705)
> ==5546==  Uninitialised value was created by a heap allocation
> ==5546==at 0x8EE8013: operator new(unsigned long) 
> (vg_replace_malloc.c:422)
> ==5546==by 0x3E78A85: lyx::readInset(lyx::support::Lexer&, lyx::Buffer*)
> (factory.cpp:652)
> ==5546==by 0x3C73DB6: lyx::Text::readParToken(lyx::Paragraph&, 
> lyx::support::Lexer&,
> std::__cxx11::basic_string, std::allocator 
> > const&,
> lyx::Font&, lyx::Change&, lyx::ErrorList&) (Text.cpp:476) ==5546==by 
> 0x3C79085:
> lyx::Text::readParagraph(lyx::Paragraph&, lyx::support::Lexer&, 
> lyx::ErrorList&)
> (Text.cpp:633) ==5546==by 0x3C920B2: lyx::Text::read(lyx::support::Lexer&,
> lyx::ErrorList&, lyx::InsetText*) (Text.cpp:2114)
> ==5546==by 0x47D74E3: lyx::InsetText::read(lyx::support::Lexer&) 
> (InsetText.cpp:172)
> ==5546==by 0x4412EEB: lyx::InsetCollapsible::read(lyx::support::Lexer&)
> (InsetCollapsible.cpp:161)
> ==5546==by 0x447C4BD: lyx::InsetFloat::read(lyx::support::Lexer&)
> (InsetFloat.cpp:330) ==5546==by 0x3E79B33: 
> lyx::readInset(lyx::support::Lexer&,
> lyx::Buffer*) (factory.cpp:705)
> ==5546==by 0x3C73DB6: lyx::Text::readParToken(lyx::Paragraph&, 
> lyx::support::Lexer&,
> std::__cxx11::basic_string, std::allocator 
> > const&,
> lyx::Font&, lyx::Change&, lyx::ErrorList&) (Text.cpp:476) ==5546==by 
> 0x3C79085:
> lyx::Text::readParagraph(lyx::Paragraph&, lyx::support::Lexer&, 
> lyx::ErrorList&)
> (Text.cpp:633) ==5546==by 0x3C920B2: lyx::Text::read(lyx::support::Lexer&,
> lyx::ErrorList&, lyx::InsetText*) (Text.cpp:2114)
> ==5546==
> ...
> 
> The last line of xx states
> ==5546== ERROR SUMMARY: 164722 errors from 56 contexts (suppressed: 0 from 0)
> 
> What do you need me to do now?
> 
>   Kornel
> 
> 

Test passes after the attached patch.

Kornel
diff --git a/src/insets/InsetTabular.h b/src/insets/InsetTabular.h
index f6939c6eff..f2df88d501 100644
--- a/src/insets/InsetTabular.h
+++ b/src/insets/InsetTabular.h
@@ -897,11 +897,11 @@ public:
 	//
 	// for long tabulars
 	///
 	HAlignment longtabular_alignment;
 	//
-	bool is_long_tabular;
+	bool is_long_tabular = false;
 	/// endhead data
 	ltType endhead;
 	/// endfirsthead data
 	ltType endfirsthead;
 	/// endfoot data


pgpxH59kMqY8O.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Fri, 17 May 2024 15:21:10 +0200
schrieb Kornel Benko :

> > Did you try to run LyX under valgrind? It can be very useful in such cases. 
> >  
> 
> Will try later ... now grandpa duties
> 
> > JMarc  
> 
>   Kornel

Ok there are plenty of errors. Using
# valgrind --track-origins=yes -s --log-file=xx bin/lyx2.5 \
.../doc/es/UserGuide.23.lyx

the created file xx is
# ls -l xx 503595
# wc xx
3360  30798 503595 xx
Too big to post, I suppose.

The output relevant to the runtime error is

==5546== Conditional jump or move depends on uninitialised value(s)
==5546==at 0x4705C0F: lyx::Tabular::updateIndexes() (InsetTabular.cpp:1070)
==5546==by 0x46FC58D: lyx::Tabular::init(lyx::Buffer*, unsigned long, 
unsigned long)
(InsetTabular.cpp:786) ==5546==by 0x46FB7EE: 
lyx::Tabular::Tabular(lyx::Buffer*,
unsigned long, unsigned long) (InsetTabular.cpp:762) ==5546==by 0x474F087:
lyx::InsetTabular::InsetTabular(lyx::Buffer*, unsigned long, unsigned long)
(InsetTabular.cpp:4495) ==5546==by 0x3E78AD4: 
lyx::readInset(lyx::support::Lexer&,
lyx::Buffer*) (factory.cpp:652) ==5546==by 0x3C73DB6:
lyx::Text::readParToken(lyx::Paragraph&, lyx::support::Lexer&,
std::__cxx11::basic_string, std::allocator > 
const&,
lyx::Font&, lyx::Change&, lyx::ErrorList&) (Text.cpp:476) ==5546==by 
0x3C79085:
lyx::Text::readParagraph(lyx::Paragraph&, lyx::support::Lexer&, lyx::ErrorList&)
(Text.cpp:633) ==5546==by 0x3C920B2: lyx::Text::read(lyx::support::Lexer&,
lyx::ErrorList&, lyx::InsetText*) (Text.cpp:2114) ==5546==by 0x47D74E3:
lyx::InsetText::read(lyx::support::Lexer&) (InsetText.cpp:172) ==5546==by 
0x4412EEB:
lyx::InsetCollapsible::read(lyx::support::Lexer&) (InsetCollapsible.cpp:161) 
==5546==
by 0x447C4BD: lyx::InsetFloat::read(lyx::support::Lexer&) (InsetFloat.cpp:330) 
==5546==
 by 0x3E79B33: lyx::readInset(lyx::support::Lexer&, lyx::Buffer*) 
(factory.cpp:705)
==5546==  Uninitialised value was created by a heap allocation
==5546==at 0x8EE8013: operator new(unsigned long) (vg_replace_malloc.c:422)
==5546==by 0x3E78A85: lyx::readInset(lyx::support::Lexer&, lyx::Buffer*)
(factory.cpp:652)
==5546==by 0x3C73DB6: lyx::Text::readParToken(lyx::Paragraph&, 
lyx::support::Lexer&,
std::__cxx11::basic_string, std::allocator > 
const&, lyx::Font&, lyx::Change&, lyx::ErrorList&) (Text.cpp:476)
==5546==by 0x3C79085: lyx::Text::readParagraph(lyx::Paragraph&, 
lyx::support::Lexer&,
lyx::ErrorList&) (Text.cpp:633)
==5546==by 0x3C920B2: lyx::Text::read(lyx::support::Lexer&, lyx::ErrorList&,
lyx::InsetText*) (Text.cpp:2114)
==5546==by 0x47D74E3: lyx::InsetText::read(lyx::support::Lexer&) 
(InsetText.cpp:172)
==5546==by 0x4412EEB: lyx::InsetCollapsible::read(lyx::support::Lexer&)
(InsetCollapsible.cpp:161)
==5546==by 0x447C4BD: lyx::InsetFloat::read(lyx::support::Lexer&) 
(InsetFloat.cpp:330)
==5546==by 0x3E79B33: lyx::readInset(lyx::support::Lexer&, lyx::Buffer*)
(factory.cpp:705)
==5546==by 0x3C73DB6: lyx::Text::readParToken(lyx::Paragraph&, 
lyx::support::Lexer&,
std::__cxx11::basic_string, std::allocator > 
const&, lyx::Font&, lyx::Change&, lyx::ErrorList&) (Text.cpp:476)
==5546==by 0x3C79085: lyx::Text::readParagraph(lyx::Paragraph&, 
lyx::support::Lexer&,
lyx::ErrorList&) (Text.cpp:633)
==5546==by 0x3C920B2: lyx::Text::read(lyx::support::Lexer&, lyx::ErrorList&,
lyx::InsetText*) (Text.cpp:2114)
==5546==
...

The last line of xx states
==5546== ERROR SUMMARY: 164722 errors from 56 contexts (suppressed: 0 from 0)

What do you need me to do now?

Kornel




pgpP009Or2rtK.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-18 Thread Kornel Benko
Am Fri, 17 May 2024 13:18:44 -0400
schrieb Scott Kostyshak :

> On Fri, May 17, 2024 at 11:34:51AM GMT, Scott Kostyshak wrote:
> > On Fri, May 17, 2024 at 03:20:11PM GMT, Kornel Benko wrote:  
> > > Am Fri, 17 May 2024 08:46:53 -0400
> > > schrieb Scott Kostyshak :
> > >   
> > > > On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote:  
> >   
> > > > > I get this warning only if lyx is compiled with debugging enabled.  
> > > > 
> > > > g++ or clang? Which version?  
> > > 
> > > g++-12
> > >   
> > 
> > I have g++-12. How do I tell CMake to compile with debugging enabled?  
> 
> It seems I already have -g3, which I think eanbles debugging?
> 
> $ lyx --version
> LyX 2.5.0~devel (2024-05-16)
>   Git commit hash b469c142
> CMake Build
>   Host name:   Linux
>   Host processor:  x86_64
>   Build flags:  LYX_ENABLE_BUILD_TYPE(AUTO) LYX_CPACK(ON)
> LYX_LOCALVERSIONING(ON) LYX_INSTALL(ON) LYX_NLS(ON) 
> LYX_REQUIRE_SPELLCHECK(OFF)
> LYX_ASPELL(OFF) LYX_ENCHANT(ON) LYX_HUNSPELL(ON) LYX_RELEASE(OFF) 
> LYX_DEBUG(ON)
> LYX_NO_OPTIMIZE(OFF) LYX_ENABLE_ASSERTIONS(ON) LYX_PACKAGE_SUFFIX(ON)
> LYX_SUFFIX_VALUE() LYX_PCH(OFF) LYX_MERGE_FILES(OFF) LYX_MERGE_REBUILD(OFF)
> LYX_QUIET(OFF) LYX_INSTALL_PREFIX(OFF) LYX_BUNDLE(OFF) 
> LYX_ENABLE_URLTESTS(OFF)
> LYX_ENABLE_EXPORT_TESTS(ON) LYX_ENABLE_KEYTESTS(OFF) 
> LYX_ENABLE_VALGRIND_TESTS(OFF)
> LYX_DEBUG_SANITIZE(NONE) LYX_USE_QT(QT6) LYX_USE_IPO(OFF)
> LYX_DISABLE_CALLSTACK_PRINTING(OFF) LYX_EXTERNAL_Z(ON) LYX_EXTERNAL_DTL(ON)
> LYX_EXTERNAL_ICONV(ON) LYX_EXTERNAL_HUNSPELL(ON) LYX_EXTERNAL_MYTHES(ON)
> LYX_PROFILE(OFF) LYX_EXTERNAL_BOOST(OFF) LYX_PROGRAM_SUFFIX(OFF) 
> LYX_DEBUG_GLIBC(OFF)
> LYX_DEBUG_GLIBC_PEDANTIC(OFF) LYX_DEBUG_GLIBC_ASSERTIONS(OFF) 
> LYX_STDLIB_DEBUG(OFF) C++
> Compiler:GNU (12.3.0) C++ Compiler flags:  -Wall -Wextra
> -Wno-deprecated-copy --std=c++20 -DENABLE_ASSERTIONS=1 -fno-strict-aliasing 
> C++
> Compiler user flags: -O0 -g3 -D_DEBUG Qt version:  6.4.2 LyX 
> binary dir:
>   /usr/local/bin LyX files dir:   /usr/local/share/lyx/ $
> 
> What does your --version output look like?
> 
> Scott

There are in fact differences.
in Build flags:
Yours:  Mine:
LYX_ENABLE_BUILD_TYPE(AUTO) LYX_ENABLE_BUILD_TYPE(development)
LYX_REQUIRE_SPELLCHECK(OFF) LYX_REQUIRE_SPELLCHECK(ON)
LYX_ENABLE_URLTESTS(OFF)LYX_ENABLE_URLTESTS(ON)
LYX_ENABLE_KEYTESTS(OFF)LYX_ENABLE_KEYTESTS(ON)
LYX_DEBUG_SANITIZE(NONE)LYX_DEBUG_SANITIZE(UNSPECIFIED)
LYX_EXTERNAL_Z(ON)  LYX_EXTERNAL_Z(OFF)
LYX_EXTERNAL_DTL(ON)LYX_EXTERNAL_DTL(OFF)
LYX_EXTERNAL_HUNSPELL(ON)   LYX_EXTERNAL_HUNSPELL(OFF)
LYX_EXTERNAL_MYTHES(ON) LYX_EXTERNAL_MYTHES(OFF)
LYX_PROGRAM_SUFFIX(OFF) LYX_PROGRAM_SUFFIX(ON)
LYX_STDLIB_DEBUG(OFF)   LYX_STDLIB_DEBUG(ON)


Compiler flags added to mine: -fsanitize=undefined -fno-omit-frame-pointer
-D_GLIBCXX_ASSERTIONS -fno-strict-aliasing

QT version
6.4.2   6.2.4

LyX files dir:
/usr/local/share/lyx/   /usr/local/share/lyx2.4/

The last one is wrong output on my side. Should be '/usr/local/share/lyx2.5/' 
as lyx is
clearly using this path.
...
Was a remnant of used CMakeCache.txt. After removing and recreating the value 
is as it
should be.
Corrected at 6670870a.

Kornel


pgpTY1tSCJpsU.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-17 Thread Kornel Benko
Am Fri, 17 May 2024 15:01:08 +0200
schrieb Jean-Marc Lasgouttes :

> Le 17/05/2024 à 14:46, Scott Kostyshak a écrit :
> > On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote:  
> >> Am Fri, 17 May 2024 05:57:27 +0200
> >> schrieb "Jürgen Spitzmüller" :
> >>  
> >>> Am Donnerstag, dem 16.05.2024 um 22:19 +0200 schrieb Kornel Benko:  
> >>>> -- Error line = /usr2/src/lyx/lyx-
> >>>> git/src/insets/InsetTabular.cpp:1070:51: runtime
> >>>> error: load of value 110, which is not a valid value for type 'bool'
> >>>>
> >>>> Picky compiler ...  
> >>>
> >>> Aha. I don't get what it is complaining about, though.
> >>>  
> >>
> >> According to gdb, the value of 'is_long_tabular' == 110 here.
> >> Maybe the pointer to the struct where is_long_tabular is contained in is 
> >> not yet
> >> correct. I get this warning only if lyx is compiled with debugging enabled.
> >> I don't see, where such value is else coming from.  
> > 
> > g++ or clang? Which version?  
> 
> Did you try to run LyX under valgrind? It can be very useful in such cases.

Will try later ... now grandpa duties

> JMarc

Kornel



pgptAQTjuCWT7.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-17 Thread Kornel Benko
Am Fri, 17 May 2024 08:46:53 -0400
schrieb Scott Kostyshak :

> On Fri, May 17, 2024 at 12:04:49PM GMT, Kornel Benko wrote:
> > Am Fri, 17 May 2024 05:57:27 +0200
> > schrieb "Jürgen Spitzmüller" :
> >   
> > > Am Donnerstag, dem 16.05.2024 um 22:19 +0200 schrieb Kornel Benko:  
> > > > -- Error line = /usr2/src/lyx/lyx-
> > > > git/src/insets/InsetTabular.cpp:1070:51: runtime
> > > > error: load of value 110, which is not a valid value for type 'bool'
> > > > 
> > > > Picky compiler ...
> > > 
> > > Aha. I don't get what it is complaining about, though.
> > >   
> > 
> > According to gdb, the value of 'is_long_tabular' == 110 here.
> > Maybe the pointer to the struct where is_long_tabular is contained in is 
> > not yet
> > correct. I get this warning only if lyx is compiled with debugging enabled.
> > I don't see, where such value is else coming from.  
> 
> g++ or clang? Which version?

g++-12

> Scott

Kornel



pgpF0TafEDXN8.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-17 Thread Kornel Benko
Am Fri, 17 May 2024 05:57:27 +0200
schrieb "Jürgen Spitzmüller" :

> Am Donnerstag, dem 16.05.2024 um 22:19 +0200 schrieb Kornel Benko:
> > -- Error line = /usr2/src/lyx/lyx-
> > git/src/insets/InsetTabular.cpp:1070:51: runtime
> > error: load of value 110, which is not a valid value for type 'bool'
> > 
> > Picky compiler ...  
> 
> Aha. I don't get what it is complaining about, though.
> 

According to gdb, the value of 'is_long_tabular' == 110 here.
Maybe the pointer to the struct where is_long_tabular is contained in is not 
yet correct.
I get this warning only if lyx is compiled with debugging enabled.
I don't see, where such value is else coming from.

Kornel


pgpLlhEk8SW8x.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-16 Thread Kornel Benko
Am Thu, 16 May 2024 17:07:13 +0200
schrieb "Jürgen Spitzmüller" :

> Am Donnerstag, dem 16.05.2024 um 10:54 +0200 schrieb Kornel Benko:
> > With today's test, I get only
...
> > export/doc/es/UserGuide_lyx23 (Failed)

> 
> The export to these formats works well for me. What errors do you get?
> 

-- This implicitly checks load of
/usr9/BUILD/Mint21/BuildLyxGitQt6.2.4local-gcc12.3.0/autotests/out-home/AbC_VGvvKl/doc/es/UserGuide.lyx
-- Expected result file
"/usr9/BUILD/Mint21/BuildLyxGitQt6.2.4local-gcc12.3.0/autotests/out-home/AbC_VGvvKl/doc/es/UserGuide.23.lyx"
exists
-- Error line = /usr2/src/lyx/lyx-git/src/insets/InsetTabular.cpp:1070:51: 
runtime
error: load of value 110, which is not a valid value for type 'bool'

Picky compiler ...

Kornel



pgpRzbKbMi1Lh.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo wrong target dir?

2024-05-16 Thread Kornel Benko
Am Thu, 16 May 2024 21:08:55 +0200
schrieb Yu Jin :

> > I don't see it in linux though.
> > 
> > You could check the value at CMakeLists.txt:575 (after being set on line 
> > 573).
> >         message(STATUS "CMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}")
> > 
> This is the output
> CMAKE_INSTALL_PREFIX=LYX_INSTALLED 
> looks fine I guess.

For me it looks wrong. (Should be full path).

I am interested of the output when run the first time compared to run on second 
time.
Also are you compiling as bundle (I hope not)?

Kornel




pgpfLM_xpWiJO.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo wrong target dir?

2024-05-16 Thread Kornel Benko
Am Thu, 16 May 2024 11:01:36 +0200
schrieb Pavel Sanda :

> On Wed, May 15, 2024 at 05:00:28PM +0200, Yu Jin wrote:
> > > On Tue, May 14, 2024 at 06:16:49PM +0200, Yu Jin wrote:  
> > > > Why does it try to install that file into my Program Files dir and not  
> > > into  
> > > > CMAKE_INSTALL_PREFIX?  
> > >
> > > I do not know, but this file is part of linux infrastructure and can be
> > > dropped
> > > completely from windows.  
> > 
> > 
> > Strange thing is that the cmake_install.cmake file contains the code part
> > sent by me earlier only on the first CMake configure run into an empty
> > directory. When I reconfigure the code part is not present anymore and I
> > don't get the error message. So how to fix it?  
> 
> Kornel?
> 
> Pavel

No clue so far.

Kornel


pgpBiCUm6sqDG.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo wrong target dir?

2024-05-16 Thread Kornel Benko
Am Wed, 15 May 2024 17:00:28 +0200
schrieb Yu Jin :

> Am Di., 14. Mai 2024 um 20:21 Uhr schrieb Pavel Sanda:
> 
> > On Tue, May 14, 2024 at 06:16:49PM +0200, Yu Jin wrote:
> > > Why does it try to install that file into my Program Files dir and not
> > into
> > > CMAKE_INSTALL_PREFIX?
> >
> > I do not know, but this file is part of linux infrastructure and can be
> > dropped
> > completely from windows.
> 
> 
> Strange thing is that the cmake_install.cmake file contains the code part
> sent by me earlier only on the first CMake configure run into an empty
> directory. When I reconfigure the code part is not present anymore and I
> don't get the error message. So how to fix it?

Looks like CMAKE_INSTALL_PREFIX is used (from cmake default) before set by 
CMakeLists.txt.
On second run the correct value is used from cache.

I don't see it in linux though.

You could check the value at CMakeLists.txt:575 (after being set on line 573).
    message(STATUS "CMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}")

Kornel


pgpZ_qhvcT87f.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Tests failing on recent master

2024-05-16 Thread Kornel Benko
Am Tue, 14 May 2024 19:29:53 -0400
schrieb Scott Kostyshak :

> The following tests now fail (and used to pass not too long ago):
> 
>   export/export/latex/languages/supported-languages_babel_auto-legacy_dvi 
> (Failed)
>   export/export/latex/languages/supported-languages_babel_auto-legacy_pdf 
> (Failed)
>   export/export/latex/languages/supported-languages_babel_auto-legacy_pdf2 
> (Failed)
>   
> UNRELIABLE.NONSTANDARD_export/export/latex/languages/supported-languages_babel_auto-legacy_pdf3
> (Failed) export/doc/es/UserGuide_lyx22 (Failed)
>   export/doc/es/UserGuide_lyx23 (Failed)
>   export/doc/es/UserGuide_dvi (Failed)
>   export/doc/es/UserGuide_dvi3_texF (Failed)
>   export/doc/es/UserGuide_pdf (Failed)
>   DEFAULTOUTPUT_export/doc/es/UserGuide_pdf2 (Failed)
>   export/doc/es/UserGuide_pdf3 (Failed)
>   export/doc/es/UserGuide_pdf5_texF (Failed)
> 
> Scott

With today's test, I get only
export/doc/es/UserGuide_lyx16 (Failed)
export/doc/es/UserGuide_lyx20 (Failed)
export/doc/es/UserGuide_lyx21 (Failed)
export/doc/es/UserGuide_lyx22 (Failed)
export/doc/es/UserGuide_lyx23 (Failed)
check_load/doc/es/UserGuide (Failed)

Kornel


pgp6sHkUGNxyJ.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: BUG [Was Re: TESTING Tarballs for 2.4.0]

2024-05-15 Thread Kornel Benko
Am Tue, 14 May 2024 12:28:09 -0400
schrieb Richard Kimberly Heck :

> On 5/14/24 10:29, Pavel Sanda wrote:
> > On Tue, May 14, 2024 at 04:13:49PM +0200, Pavel Sanda wrote:  
> >> On Tue, May 14, 2024 at 03:27:13PM +0200, Pavel Sanda wrote:  
> >>> On Mon, May 13, 2024 at 05:48:40PM -0400, Richard Kimberly Heck wrote:  
> >>>> Tarballs for 2.4.0 are here:
> >>>>
> >>>>      http://ftp.lyx.org/pub/lyx/devel/lyx-2.4/  
> >>> Looks ok on stable and oldstable debian.  
> >> not a showstopper, but with little playing I see the following problem 
> >> with tables:
> >>
> >> 1. insert single cell table and lyx note into it
> >> 2. put cursor inside the cell, in front of the note
> >> 3. open table setting via context menu, mouse cursor should be close to 
> >> text cursor
> >> when opening 4. remove all frames via delete button & OK
> >> 5. the frames are removed, the console shows:  
> > sorry typo, the frames are *not* removed
> >  
> >> Lexer.cpp (902): Missing 'note'-tag in InsetNote::string2params. Got 
> >> tabular
> >> instead. Line: 0 Lexer.cpp (902): Missing 'Note'-tag in 
> >> InsetNote::string2params.
> >> Got tabular instead. Line: 0  
> 
> We are going to have to rebuild the tarballs, due to the cmake issue. Do 
> we want to address this?
> 
> Riki
> 
> 

Please wait until Eugene can compile.

Kornel


pgpASnxs1MWV1.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: TESTING Tarballs for 2.4.0

2024-05-15 Thread Kornel Benko
Am Tue, 14 May 2024 18:34:50 +0200
schrieb Yu Jin :

> Am Di., 14. Mai 2024 um 17:54 Uhr schrieb Kornel Benko:
> 

...

> > Corrected at 5eaa03a1, sorry.
> >
> 
> Well, the 2.4.x branch still does not compile:
> 
> Build started at 18:30...
> 1>-- Build started: Project: support (applications\LyX\support),
> Configuration: Debug x64 --
> 1>ConsoleApplication.cpp
> 1>Package.cpp
> 1>C:\lyx\master\src\support\Package.cpp(553,29): error C2065:
> 'LYX_DIR_VER': undeclared identifier
> 1>C:\lyx\master\src\support\Package.cpp(556,46): error C2065:
> 'LYX_DIR_VER': undeclared identifier
> 1>C:\lyx\master\src\support\Package.cpp(650,47): error C2065:
> 'LYX_DIR_VER': undeclared identifier
> 1>C:\lyx\master\src\support\Package.cpp(666,31): error C2065:
> 'LYX_USERDIR_VER': undeclared identifier
> 1>PathChanger.cpp
> 1>gzstream.cpp
> 1>C:\lyx\master\src\support\gzstream.cpp(92,19): warning C4244:
> 'initializing': conversion from '__int64' to 'int', possible loss of data
> 1>C:\lyx\master\src\support\gzstream.cpp(113,11): warning C4244:
> 'initializing': conversion from '__int64' to 'int', possible loss of data
> 1>gettext.cpp
> 1>Generating Code...
> 1>Done building project "support.vcxproj" -- FAILED.
> == Build: 0 succeeded, 1 failed, 2 up-to-date, 0 skipped ==
> == Build completed at 18:30 and took 03,018 seconds ==
> 
> or here
> 
> Build started at 18:33...
> 1>-- Build started: Project: LyX (applications\LyX\LyX), Configuration:
> Debug x64 --
> 1>version.cpp
> 1>C:\lyx\master\src\version.cpp(25,38): error C2065: 'NOTFOUND': undeclared
> identifier
> 1>C:\lyx\master\src\version.cpp(26,38): error C2065: 'NOTFOUND': undeclared
> identifier
> 1>Done building project "LyX.vcxproj" -- FAILED.
> == Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==
> == Build completed at 18:33 and took 00,368 seconds ==
> 
> not sure why it says NOTFOUND here, line 25 and 26 are actually:
> 
> extern const int lyx_version_major = LYX_MAJOR_VERSION;
> extern const int lyx_version_minor = LYX_MINOR_VERSION;
> 
> Those definitions are not found though.
> 

Thanks for the report. After the amend at 8edc87b6 these errors should go too.

Kornel


pgpuBMkcSRz2w.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: TESTING Tarballs for 2.4.0

2024-05-14 Thread Kornel Benko
Am Tue, 14 May 2024 17:41:46 +0200
schrieb Yu Jin :

> Am Mo., 13. Mai 2024 um 23:49 Uhr schrieb Richard Kimberly Heck:
> 
> > Hi, all,
> >
> > Tarballs for 2.4.0 are here:
> >
> >  http://ftp.lyx.org/pub/lyx/devel/lyx-2.4/
> >
> > Please test. Please let me know if I forgot to do or include anything.
> >
> > Hold off on binaries for now.
> >
> 
> Cmake fails, I get this error
> 
> C:\lyx>"C:\Program Files\CMake\bin\cmake.exe" -S lyx-2.4.0 -G "Visual
> Studio 17 2022" -A x64 -DLYX_EXTERNAL_DTL=0 -DLYX_USE_QT=QT6
> -DLYX_INSTALL=1 -DLYX_CONSOLE=0
> -DGNUWIN32_DIR=C:\lyx\lyx-windows-deps-msvc2023_64
> -DCMAKE_PREFIX_PATH=C:\Qt\6.7.0\msvc2019_64 -B "C:\lyx\lyx-2.4.0-build-64"
> CMake Deprecation Warning at CMakeLists.txt:7 (cmake_minimum_required):
>   Compatibility with CMake < 3.5 will be removed from a future version of
>   CMake.
> 
>   Update the VERSION argument  value or use a ... suffix to tell
>   CMake that the project does not need compatibility with older versions.
> 
> 
> -- TOP_SRC_DIR = C:/lyx/lyx-2.4.0
> --
> -- Building out-of-source
> -- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.22631.
> CMake Error at development/cmake/modules/LyXMacros.cmake:466 (message):
>   "C:/lyx/lyx-2.4.0/configure.ac": Unable to determine build-type from
> suffix
>   "" in AC_INIT macro
> Call Stack (most recent call first):
>   CMakeLists.txt:120 (determineversionandbuildtype)
> 
> 
> -- Configuring incomplete, errors occurred!
> 
> 

Corrected at 5eaa03a1, sorry.

Kornel


pgpTZtJcZcd3p.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Test failure after tlmgr update (not a LyX issue)

2024-05-06 Thread Kornel Benko
Am Sun, 5 May 2024 13:12:48 +0200
schrieb Kornel Benko :

> > > 
> > > See: https://tug.org/pipermail/tex-live/2024-May/050511.html
> > > 
> > > Udi
> > 
> > Thanks, Kornel and Udi. Indeed, after a new tlmgr update these tests
> > pass. Now the following tests fail for me:
> > 
> >   export/examples/ja/Modules/Braille_pdf5_systemF
> >   export/examples/ja/Welcome_pdf5_systemF
> >   export/doc/ja/Shortcuts_pdf5_systemF
> >   export/doc/ja/Formula-numbering_pdf5_systemF
> >   export/examples/ja/Modules/Multilingual_Captions_pdf5_systemF
> >   export/doc/ja/Tutorial_pdf5_systemF  
> 
> Same here.
> 
> > Perhaps my plan should be to wait a couple of weeks and see if the
> > failure persists before spending time checking them out.  
> 
> +1
> 
> > Scott  
> 
>   Kornel

Today's tl update: The reported tests succeeded now.

Kornel


pgpuRI6GieJ1Y.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Test failure after tlmgr update (not a LyX issue)

2024-05-05 Thread Kornel Benko
Am Sat, 4 May 2024 23:18:51 -0400
schrieb Scott Kostyshak :

> On Sat, May 04, 2024 at 09:57:22PM GMT, Udicoudco wrote:
> > On Sat, May 4, 2024, 9:46 PM Kornel Benko  wrote:
> >   
> > > Am Fri, 3 May 2024 10:31:42 -0400
> > > schrieb Scott Kostyshak :
> > >  
> > > > This is likely not a LyX issue so feel free to ignore.
> > > >
> > > > After a tlmgr update, the following tests now fail:
> > > >
> > > >   export/export/latex/languages/en-ja_platex_dvi3_systemF (Failed)
> > > >   export/export/latex/languages/en-ja_platex_pdf4_systemF (Failed)
> > > >   export/export/latex/languages/en-ja_platex_pdf5_systemF (Failed)
> > > >
> > > > I attach the file that corresponds to the pdf4_systemF test for
> > > > convenience.
> > > >
> > > > The LaTeX error I now get is the following:
> > > >
> > > >   ! Illegal parameter number in definition of \l__exp_internal_tl.
> > > >
> > > > I'm going to ask a question on tex.se to figure out where to report this
> > > > potential regression, but first I wanted to check in here and see if
> > > > anyone else can reproduce this error after a tlmgr update or if it might
> > > > be something local to my system (I have a few hacks in there).
> > > >
> > > > Scott  
> > >
> > > I don't have these errors. (TL24 updated today)
> > >  # ctest -R en-ja_platex_
> > > ...
> > > 100% tests passed, 0 tests failed out of 7
> > >
> > > Kornel
> > > --  
> > 
> > 
> > See: https://tug.org/pipermail/tex-live/2024-May/050511.html
> > 
> > Udi  
> 
> Thanks, Kornel and Udi. Indeed, after a new tlmgr update these tests
> pass. Now the following tests fail for me:
> 
>   export/examples/ja/Modules/Braille_pdf5_systemF
>   export/examples/ja/Welcome_pdf5_systemF
>   export/doc/ja/Shortcuts_pdf5_systemF
>   export/doc/ja/Formula-numbering_pdf5_systemF
>   export/examples/ja/Modules/Multilingual_Captions_pdf5_systemF
>   export/doc/ja/Tutorial_pdf5_systemF

Same here.

> Perhaps my plan should be to wait a couple of weeks and see if the
> failure persists before spending time checking them out.

+1

> Scott

Kornel


pgpAICvvwd_HP.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Test failure after tlmgr update (not a LyX issue)

2024-05-04 Thread Kornel Benko
Am Fri, 3 May 2024 10:31:42 -0400
schrieb Scott Kostyshak :

> This is likely not a LyX issue so feel free to ignore.
> 
> After a tlmgr update, the following tests now fail:
> 
>   export/export/latex/languages/en-ja_platex_dvi3_systemF (Failed)
>   export/export/latex/languages/en-ja_platex_pdf4_systemF (Failed)
>   export/export/latex/languages/en-ja_platex_pdf5_systemF (Failed)
> 
> I attach the file that corresponds to the pdf4_systemF test for
> convenience.
> 
> The LaTeX error I now get is the following:
> 
>   ! Illegal parameter number in definition of \l__exp_internal_tl.
> 
> I'm going to ask a question on tex.se to figure out where to report this
> potential regression, but first I wanted to check in here and see if
> anyone else can reproduce this error after a tlmgr update or if it might
> be something local to my system (I have a few hacks in there).
> 
> Scott

I don't have these errors. (TL24 updated today)
 # ctest -R en-ja_platex_
...
100% tests passed, 0 tests failed out of 7

Kornel


pgphPZ_OcE7Cm.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Minor performance issue on shift + down, shift + up on includes

2024-04-22 Thread Kornel Benko
Am Mon, 22 Apr 2024 14:47:10 -0400
schrieb Scott Kostyshak :

> To reproduce:
> 
> 1. Move the attached file in the lib/docs directory.
> 2. Open the file.
> 3. Put the cursor before, e.g., the Additional.lyx include.
> 4. Press Shift + Down (or Shift + Up).
> 
> Result is that there is a small pause before the selection is finished.
> Subsequent presses extending the selection in the same direction are
> almost instantaneous, so it's just the first one.
> 
> In case it's hard to notice, you can try the following, after (3) hold
> shift and then press Down. After the selection gets to the bottom, keep
> holding shift but change from holding Down to holding Up. You'll notice
> that the cursor gets stuck for a small amount of time at the anchor
> point.
> 
> Strangely, I can reproduce if I select with Shift + Right, which also
> selects all of the insets. This surprised me, and maybe it provides a
> clue.
> 
> Can anyone reproduce?
> 
> Scott

Same here.

Kornel


pgpbhN6bZ8P16.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX v2.4.0 RC4 -> Table styles??

2024-04-20 Thread Kornel Benko
Am Sat, 20 Apr 2024 12:54:16 -0400
schrieb Richard Kimberly Heck :

> On 4/20/24 12:50, Kornel Benko wrote:
> > Am Sat, 20 Apr 2024 17:54:42 +0200
> > schrieb "Jürgen Spitzmüller" :
> >  
> >> Am Samstag, dem 20.04.2024 um 10:54 +0200 schrieb Jürgen Spitzmüller:  
> >>> That's strange, you should have six different options. Do you have a
> >>> folder called "tabletemplates" in your system directory (that's the
> >>> directory that contains the "layouts", "templates" etc. folders?
> >>>
> >>> Is it possible that this directory is not installed on Windows?  
> >> More generally, it seems CMake does not install lib/tabletemplates.
> >>
> >> Kornel?
> >>  
> > Looks like I missed the directory :(  
> 
> Fine to fix it for 2.4.0, then.

Done.

> Riki
> 

Kornel



pgpxasRayPdYq.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX v2.4.0 RC4 -> Table styles??

2024-04-20 Thread Kornel Benko
Am Sat, 20 Apr 2024 19:22:03 +0200
schrieb Kornel Benko :

> Am Sat, 20 Apr 2024 12:54:16 -0400
> schrieb Richard Kimberly Heck :
> 
> > On 4/20/24 12:50, Kornel Benko wrote:  
> > > Am Sat, 20 Apr 2024 17:54:42 +0200
> > > schrieb "Jürgen Spitzmüller" :
> > >
> > >> Am Samstag, dem 20.04.2024 um 10:54 +0200 schrieb Jürgen Spitzmüller:
> > >>> That's strange, you should have six different options. Do you have a
> > >>> folder called "tabletemplates" in your system directory (that's the
> > >>> directory that contains the "layouts", "templates" etc. folders?
> > >>>
> > >>> Is it possible that this directory is not installed on Windows?
> > >> More generally, it seems CMake does not install lib/tabletemplates.
> > >>
> > >> Kornel?
> > >>
> > > Looks like I missed the directory :(
> > 
> > Fine to fix it for 2.4.0, then.
> > 
> > Riki
> > 
> >   
> 
> How is a lyx user supposed to use these files? (There is no hint in 'Open 
> example...' or
> 'New from Template...')
> E.g. installing under share/lyx2.5/tabletemplates (like the examples) 
> directory does not
> make them visible.
>   Kornel

Never mind. Found it under 'Insert->Table...'

Kornel


pgpYFZ4T6Qdf8.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX v2.4.0 RC4 -> Table styles??

2024-04-20 Thread Kornel Benko
Am Sat, 20 Apr 2024 12:54:16 -0400
schrieb Richard Kimberly Heck :

> On 4/20/24 12:50, Kornel Benko wrote:
> > Am Sat, 20 Apr 2024 17:54:42 +0200
> > schrieb "Jürgen Spitzmüller" :
> >  
> >> Am Samstag, dem 20.04.2024 um 10:54 +0200 schrieb Jürgen Spitzmüller:  
> >>> That's strange, you should have six different options. Do you have a
> >>> folder called "tabletemplates" in your system directory (that's the
> >>> directory that contains the "layouts", "templates" etc. folders?
> >>>
> >>> Is it possible that this directory is not installed on Windows?  
> >> More generally, it seems CMake does not install lib/tabletemplates.
> >>
> >> Kornel?
> >>  
> > Looks like I missed the directory :(  
> 
> Fine to fix it for 2.4.0, then.
> 
> Riki
> 
> 

How is a lyx user supposed to use these files? (There is no hint in 'Open 
example...' or
'New from Template...')
E.g. installing under share/lyx2.5/tabletemplates (like the examples) directory 
does not
make them visible.
Kornel


pgpD4lOAy3WZz.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX v2.4.0 RC4 -> Table styles??

2024-04-20 Thread Kornel Benko
Am Sat, 20 Apr 2024 17:54:42 +0200
schrieb "Jürgen Spitzmüller" :

> Am Samstag, dem 20.04.2024 um 10:54 +0200 schrieb Jürgen Spitzmüller:
> > That's strange, you should have six different options. Do you have a
> > folder called "tabletemplates" in your system directory (that's the
> > directory that contains the "layouts", "templates" etc. folders?
> > 
> > Is it possible that this directory is not installed on Windows?  
> 
> More generally, it seems CMake does not install lib/tabletemplates.
> 
> Kornel?
> 

Looks like I missed the directory :(

Kornel


pgp5ufl3oWa94.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-19 Thread Kornel Benko
Am Fri, 19 Apr 2024 11:12:41 +0200
schrieb Pavel Sanda :

> On Fri, Apr 19, 2024 at 11:03:55AM +0200, Kornel Benko wrote:
> > Looks like not so easy. The changes in are
> > development/cmake/modules/LyXMacros.cmake: easy managable
> > development/cmake/modules/FindCXX11Compiler.cmake: looks not difficult
> > CMakeLists.txt: Huge  
> 
> I thought the changes wouldn't be done in cmake, but in .cpp code,
> like getting rid of unary_function reported in the begininng of
> this thread, which we presumably don't use in 2.4 anymore(?).
> 
> Pavel

I'd prefer that too of course. But the settings for std= are done in cmake.
(Setting to C++11 was/is not successful)

Kornel


pgpOcuJBcdt7R.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-19 Thread Kornel Benko
Am Thu, 18 Apr 2024 16:43:25 +0200
schrieb Pavel Sanda :

> On Wed, Apr 17, 2024 at 09:22:34AM +0200, Kornel Benko wrote:
> > Am Tue, 16 Apr 2024 15:54:26 +0200
> > schrieb Yu Jin :
> >   
> > > > Alternatively you can try setting CMAKE_CXX_STANDARD directly.
> > > > Like in CMakeLists.txt:646
> > > > -if(NOT MSVC)
> > > > +if (MSVC)
> > > > +       set(CMAKE_CXX_STANDARD 11)
> > > > +else()
> > > > 
> > > > Since I cannot test for MSVC, it is untested.
> > > >   
> > > Does not seem to do anything, the standard set in Visual Studio is still 
> > > "Default
> > > (C++14)" and still the same error occurs. 
> > >   
> > 
> > Sorry Eugene, I would try to check for diff of the used cxx parameters in 
> > lyx2.3 and
> > lyx2.5 compilation. Other than that, I am out of suggestions.  
> 
> If we run out of ideas how to compile 2.3 with the current win compilers,
> how hard or complex patches would be backporting compilation fixes present
> in 2.4?
> 
> Pavel

Looks like not so easy. The changes in are
development/cmake/modules/LyXMacros.cmake: easy managable
development/cmake/modules/FindCXX11Compiler.cmake: looks not difficult
    CMakeLists.txt: Huge

If Eugene is able to compile lyx2.4 with qt5 then I'd still like to know the
differences of the used cxx parameters. Seems easier to make a patch then (at 
least for
Eugene's compiler)

Kornel




pgpK8VMiGdsWO.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Screwed display for table (all lyx versions)

2024-04-18 Thread Kornel Benko
Am Wed, 17 Apr 2024 23:36:30 +0200
schrieb Jean-Marc Lasgouttes :

> Le 06/04/2024 à 15:30, Scott Kostyshak a écrit :
> > On Sat, Apr 06, 2024 at 11:14:45AM GMT, Kornel Benko wrote:  
> >>
> >> The created pdf looks like I wanted.  
> > 
> > I can reproduce (the weird LyX display) on current master and on 2.3.x.  
> 
> I think this deserves a ticket. I can reproduce, and have no idea how 
> this thing works.
> 
> JMarc
> 

Done #13060

Kornel


pgpD1L61Lkrdb.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-17 Thread Kornel Benko
Am Tue, 16 Apr 2024 15:54:26 +0200
schrieb Yu Jin :

> > Alternatively you can try setting CMAKE_CXX_STANDARD directly.
> > Like in CMakeLists.txt:646
> > -if(NOT MSVC)
> > +if (MSVC)
> > +       set(CMAKE_CXX_STANDARD 11)
> > +else()
> > 
> > Since I cannot test for MSVC, it is untested.
> > 
> Does not seem to do anything, the standard set in Visual Studio is still 
> "Default
> (C++14)" and still the same error occurs. 
> 

Sorry Eugene, I would try to check for diff of the used cxx parameters in 
lyx2.3 and
lyx2.5 compilation. Other than that, I am out of suggestions.

Kornel


pgpYKe9Emn2GK.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-16 Thread Kornel Benko
Am Fri, 12 Apr 2024 21:50:28 +0200
schrieb Yu Jin :

> Am Fr., 12. Apr. 2024 um 09:56 Uhr schrieb Kornel Benko :
> 
> > Am Thu, 11 Apr 2024 17:13:20 +0200
> > schrieb Yu Jin:
> >
> > > Am Do., 11. Apr. 2024 um 10:17 Uhr schrieb Kornel Benko:
> > >
> > > > Am Wed, 10 Apr 2024 21:02:40 +0200
> > > > schrieb Yu Jin:
> > > >
> >
> > [snip]
> >
> > > > Please check ./development/cmake/modules/LyXMacros.cmake:471
> > > >
> > >
> > > On the 2.3.x branch there LyXMacros.cmake file only contains  403 lines.
> > >
> >
> >
> > I completely forgot the 2.3 branch.
> >
> > Please check development/cmake/modules/FindCXX11Compiler.cmake:47
> > and set CXX11_FLAG_CANDIDATES appropriate.
> > (You may also look at
> > # git log development/cmake/modules/FindCXX11Compiler.cmake
> > in lyx2.4 for changes prior to 2ec243d47)
> 
> 
> I either don't understand what I need to do or it does not help either. I
> put "--std=c++11" in there but it did not help, still the same error.

Alternatively you can try setting CMAKE_CXX_STANDARD directly.
Like in CMakeLists.txt:646
-if(NOT MSVC)
+if (MSVC)
+   set(CMAKE_CXX_STANDARD 11)
+else()

Since I cannot test for MSVC, it is untested.

Kornel


pgpGK_2rdgEf1.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Cursor painting gets stuck if space before end of inset

2024-04-12 Thread Kornel Benko
Am Fri, 12 Apr 2024 00:07:06 -0400
schrieb Scott Kostyshak :

> To reproduce:
> 
> 1. Open the attached file.
> 2. Put the cursor just after "testing" and before the space.
> 3. Press .
> 
> Result: it looks like the cursor is frozen for a second.

I do not see this.

> Similarly, if after (3) you do another quick  you can see two
> cursors painted for a split second.

This I could see.

> Can anyone reproduce?
> 
> Scott

Kornel


pgpnuh_HHdwf8.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-12 Thread Kornel Benko
Am Thu, 11 Apr 2024 17:13:20 +0200
schrieb Yu Jin :

> Am Do., 11. Apr. 2024 um 10:17 Uhr schrieb Kornel Benko :
> 
> > Am Wed, 10 Apr 2024 21:02:40 +0200
> > schrieb Yu Jin :
> >

[snip]

> > Please check ./development/cmake/modules/LyXMacros.cmake:471
> >
> 
> On the 2.3.x branch there LyXMacros.cmake file only contains  403 lines.
> 


I completely forgot the 2.3 branch.

Please check development/cmake/modules/FindCXX11Compiler.cmake:47
and set CXX11_FLAG_CANDIDATES appropriate.
(You may also look at
# git log development/cmake/modules/FindCXX11Compiler.cmake
in lyx2.4 for changes prior to 2ec243d47)


Kornel


pgpymarfqci1d.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: 2.3.x does not compile on Windows

2024-04-11 Thread Kornel Benko
Am Wed, 10 Apr 2024 21:02:40 +0200
schrieb Yu Jin :

> Am Mi., 10. Apr. 2024 um 16:02 Uhr schrieb Jean-Marc Lasgouttes :
> 
> > Le 09/04/2024 à 06:30, Yu Jin a écrit :
> > > Normally, unary_function and binary_function only disappeared in
> > C++17.
> > > Does C++14 work?
> > >
> > > Unfortunately not.
> >
> > Do you select the C++ level in Visual Studio or in cmake?
> >
> 
> I don't see any option in CMake regarding c++ level, I just execute
> configure and as far as I can see it does not set any explicit c++ level
> and default in the current Visual Studio is c++14 and there seems no way to
> use c++11.
> https://developercommunity.visualstudio.com/t/Need-C11-in-visual-studio-not-C11-or/10081597?space=8=idea=visualizer
> Manually setting '/std:c++11' command line switch also does not work, it
> actually says that this switch is unknown and will be ignored -> so again
> c++14 is used. And installing an older Visual Studio (Community) is also
> not an option, because Microsoft does not offer that (only Professional and
> Enterprise), so rip lyX 2.3.8 on Windows I guess, unless someone decides to
> cross compile it using MinGW or so.


Please check ./development/cmake/modules/LyXMacros.cmake:471
In the function lyxgetknowncmakestd() we use the info from cmake to get the 
correct c++
level (if the cmake version >= 3.9)

OTOH, if your cmake version is less 3.9, we try to check for 98, 11 and 14.
If that is the case for you, you could select your own values.

Kornel


pgphhlqi4rKM7.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Biginset branch has landed (sorry for the spam)

2024-04-10 Thread Kornel Benko
Am Wed, 10 Apr 2024 15:10:04 +0200
schrieb Jean-Marc Lasgouttes :

> Le 10/04/2024 à 15:09, Kornel Benko a écrit :
> > This patch definitely cured the behaviour here.  
> 
> Thanks for testing. Both for the math and the minibuffer examples? (this 
> is what I see, but I want to be sure).
> 
> The problem is that most of the biginset branch was developed and 
> debugged using the xcb platform, and it has very different behavior from 
> Wayland (or macOS, actually).
> 
> JMarc

I confess tested only the math example.
But the first 10 tries with the command buffer did OK too

Kornel


pgpPuickWyVUm.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Biginset branch has landed (sorry for the spam)

2024-04-10 Thread Kornel Benko
Am Wed, 10 Apr 2024 14:19:03 +0200
schrieb Jean-Marc Lasgouttes :

> Le 09/04/2024 à 22:26, Scott Kostyshak a écrit :
> > Bisect leads to here: 5e857883. Interestingly I bisected on the command
> > buffer recipe, but the commit talks about math but I guess they're
> > related issues.
> 
> What about this, which fixes up another commit?
> 
> JMarc
> 
> 

This patch definitely cured the behaviour here.

Kornel


pgpPNjMN6xe7k.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Compiling With Qt5

2024-04-06 Thread Kornel Benko
Am Sat, 6 Apr 2024 10:59:42 +0200
schrieb Pavel Sanda :

> On Sat, Apr 06, 2024 at 10:37:16AM +0200, Kornel Benko wrote:
> > In this commit I only fixed the the wrong casing of "Qt6Core_Found" to
> > "Qt6Core_FOUND". So this code was there for a long time, but was not 
> > working.  
> 
> Nevertheless, can we have cmake defaulting to qt5 for 2.4.x? P

Done at c971974f.

Kornel


pgppCy2jAKxcG.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Screwed display for table (all lyx versions)

2024-04-06 Thread Kornel Benko

The created pdf looks like I wanted.

Kornel


Funktionstasten.lyx
Description: application/lyx


pgpN4FCuRw8VY.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Compiling With Qt5

2024-04-06 Thread Kornel Benko
Am Fri, 5 Apr 2024 17:23:57 -0400
schrieb Richard Kimberly Heck :

> On 4/5/24 03:02, Kornel Benko wrote:
> > Am Thu, 4 Apr 2024 13:39:18 -0400
> > schrieb Richard Kimberly Heck :
> >  
> >> On 4/3/24 06:34, Jean-Marc Lasgouttes wrote:  
> >>> Le 03/04/2024 à 12:27, Pavel Sanda a écrit :  
> >>>> On Tue, Apr 02, 2024 at 09:54:22PM -0400, Richard Kimberly Heck wrote:  
> >>>>> Also, do we want Qt6 to be the default with 2.4.x? In master, that
> >>>>> might
> >>>>> make sense, but it seems odd to change that now.  
> >>>> I would not do that for 2.4 at this stage.  
> >>> I guess we could do that in a later 2.4 version, but this will need a
> >>> discussion.  
> >> I think it already is the default in the 2.4.x branch:
> >>
> >> ../lyx-2.4.x/build/ [2.4.x] > cmake ..
> >> CMake Deprecation Warning at CMakeLists.txt:7 (cmake_minimum_required):
> >>     Compatibility with CMake < 3.5 will be removed from a future version of
> >>     CMake.
> >>
> >>     Update the VERSION argument  value or use a ... suffix to 
> >> tell
> >>     CMake that the project does not need compatibility with older versions.
> >>
> >>
> >> -- TOP_SRC_DIR = /cvs/lyx/lyx-2.4.x  
> > We could use
> > # git cherry-pick 8d79860e
> > I omitted it in 2.4.x, because I did not want to mess ...  
> 
> Unless I'm misreading it, commit 993e784a6284a to 2.4.x makes Qt6 the 
> default (and that commit is also in 2.4.1-devel). When I run cmake on a 
> system with Qt6 installed, I get errors, since I don't have all the 
> devel files installed.
> 
> Riki
> 
> 

In this commit I only fixed the the wrong casing of "Qt6Core_Found" to 
"Qt6Core_FOUND".
So this code was there for a long time, but was not working.

The assumption is
if there is devel package for qt6core, all other needed devel packages 
are
also installed.

Committed at 7c8f3a5d on master. OK for 2.4.1 and/or 2.4.x?

Kornel


pgpztPkZud7zF.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: cmake build with qt6 (macos) does not include "plugins"

2024-04-05 Thread Kornel Benko
Am Thu, 21 Mar 2024 23:21:18 +0100
schrieb pdv :

> On 20/03/2024 11:26, Pavel Sanda wrote:
> > On Tue, Mar 19, 2024 at 04:02:34PM +0100, pdv wrote:  
> >> These steps have been added to my previous patch (new patch included) and I
> >> also derived the QT_PLUGINS_DIR and QT_LIBRARY_DIRS variables from the
> >> existing Qt6_DIR/Qt5_DIR variable, so they must not longer be supplied.  
> > 
> > I see there is some very old bug related to osx budles, pehaps it should be 
> > closed?
> > https://www.lyx.org/trac/ticket/9018
> >   
> >> I only tested this with Qt6.  
> > 
> > Unf we are staying out of Qt6 for mac because of serious issues we were not 
> > able to
> > solve (see bug https://www.lyx.org/trac/ticket/12641 ).
> > 
> > Pavel  
> 
> That will not be so easy (with cmake).
> The signing issue also holds for Qt5.
> 
> I've done my homework again.
> I realized that my previous solution (although it worked for me) was not 
> ideal. I can't remember why anymore but for Qt6 I copied just all the 
> plugins, which of course worked but was ineffective.
> 
> It's clear now that (for installing a bundle on macos with cmake) there 
> is no difference between Qt5 (supposed the version is GTE 5.10) and Qt6.
> 
> This makes things much simpler.
> 
> But at least with the latest macos tools (Sonoma and XCode15) a bundle 
> refuses to run if it 's not signed properly.
> 
> Both issues are solved with the patch included and have now been tested 
> with Qt5.15 and Qt6.7.
> 
> For completeness: I've checked the font-emph shortcut issue and, as 
> reported in the ticket mentioned, ^CmdE works with Qt5.15 but not with 
> Qt6.7. However the sequence ^C E does work. I don't know whether this is 
> intended as a workaround for this issue or was already implemented.
> 
> pdv

Committed at 4d02fb7a on master and 00d59c17 on 2.4.1-devel

Kornel


pgpwXEIkI6neQ.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Compiling With Qt5

2024-04-05 Thread Kornel Benko
Am Thu, 4 Apr 2024 13:39:18 -0400
schrieb Richard Kimberly Heck :

> On 4/3/24 06:34, Jean-Marc Lasgouttes wrote:
> > Le 03/04/2024 à 12:27, Pavel Sanda a écrit :  
> >> On Tue, Apr 02, 2024 at 09:54:22PM -0400, Richard Kimberly Heck wrote:  
> >>> Also, do we want Qt6 to be the default with 2.4.x? In master, that 
> >>> might
> >>> make sense, but it seems odd to change that now.  
> >>
> >> I would not do that for 2.4 at this stage.  
> >
> > I guess we could do that in a later 2.4 version, but this will need a 
> > discussion.  
> 
> I think it already is the default in the 2.4.x branch:
> 
> ../lyx-2.4.x/build/ [2.4.x] > cmake ..
> CMake Deprecation Warning at CMakeLists.txt:7 (cmake_minimum_required):
>    Compatibility with CMake < 3.5 will be removed from a future version of
>    CMake.
> 
>    Update the VERSION argument  value or use a ... suffix to tell
>    CMake that the project does not need compatibility with older versions.
> 
> 
> -- TOP_SRC_DIR = /cvs/lyx/lyx-2.4.x

We could use
# git cherry-pick 8d79860e
I omitted it in 2.4.x, because I did not want to mess ...

Kornel


pgpN0S_2B3Y1M.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-03 Thread Kornel Benko
Am Wed, 3 Apr 2024 14:53:06 +0200
schrieb Jean-Marc Lasgouttes :

> Le 02/04/2024 à 14:12, Kornel Benko a écrit :
> >> The first one looks like a matter of old gcc that does not like the {}
> >> constructor (don't remember the name).
> >>
> >> JMarc
> > 
> > If so, can something be done here?
> 
> This compiles fine here, can you check that it does for you too?
> 
> Also, I do not know how to test this code. Riki can you confirm that it 
> makes sense?
> 
> JMarc
> 
> 
> 

Compiles here too. The resulting executable seems also correct. Thanks.

Kornel


pgpcuJknwvQ4i.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-03 Thread Kornel Benko
Am Wed, 3 Apr 2024 12:43:59 +0200
schrieb Jean-Marc Lasgouttes :

> Le 02/04/2024 à 14:11, Kornel Benko a écrit :
> > Am Mon, 01 Apr 2024 20:24:10 +0100
> > schrieb José Matos :  
> >> What Qt version is available there?  
> > 
> > This is qt5.4.0. And probably you are right.  
> 
> This one should be fixed in master at 6260689fd552. Please confirm.
> 
> Riki, this will be candidate for 2.4.0.
> 
> JMarc
> 

Thanks, this one error is gone. Confirmed.

Kornel


pgp9r8pqWS2eb.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-03 Thread Kornel Benko
Am Tue, 2 Apr 2024 14:53:22 +0200
schrieb Jean-Marc Lasgouttes :

> Le 02/04/2024 à 14:12, Kornel Benko a écrit :
> >> The first one looks like a matter of old gcc that does not like the {}
> >> constructor (don't remember the name).
> >>
> >> JMarc  
> > 
> > If so, can something be done here?  
> 
> I can't right now, but basically yes.
> 
> JMarc
> 

Thanks, would be nice to have.

Kornel


pgpmBWFgKRa70.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Compiling With Qt5

2024-04-03 Thread Kornel Benko
Am Tue, 2 Apr 2024 21:54:22 -0400
schrieb Richard Kimberly Heck :

> On 4/2/24 21:19, Scott Kostyshak wrote:
> > On Tue, Apr 02, 2024 at 08:41:50PM GMT, Richard Kimberly Heck wrote:  
> >> I'm now getting:
> >>
> >> CMake Error at CMakeLists.txt:826 (find_package):
> >>    Could not find a package configuration file provided by "Qt6Svg" with 
> >> any
> >>    of the following names:
> >>
> >>      Qt6SvgConfig.cmake
> >>      qt6svg-config.cmake
> >>
> >>    Add the installation prefix of "Qt6Svg" to CMAKE_PREFIX_PATH or set
> >>    "Qt6Svg_DIR" to a directory containing one of the above files.  If
> >> "Qt6Svg"
> >>    provides a separate development package or SDK, be sure it has been
> >>    installed.
> >> Call Stack (most recent call first):
> >>    src/frontends/qt/CMakeLists.txt:50 (qt_use_modules)
> >>
> >> I guess I need to tell it to use Qt5? How do I do that with cmake?  
> > I think the following:
> >
> >cmake -DLYX_USE_QT="QT5"  
> 
> Got it, thanks. Is there something similar to "./configure --help" that 
> will tell me about these options?
> 
> Also, do we want Qt6 to be the default with 2.4.x? In master, that might 
> make sense, but it seems odd to change that now.
> 
> Riki
> 
> 

Given, that your lyx-source is at "/usr/src/lyx/master"
and you are in the build directory:
There is also the command
cmake-gui /usr/src/lyx/master

Click on 'Grouped' to display the settings ordered.

Kornel


pgp_G9ohscMTK.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-02 Thread Kornel Benko
Am Mon, 1 Apr 2024 21:29:00 +0200
schrieb Jean-Marc Lasgouttes :

> Le 01/04/2024 à 21:24, José Matos a écrit :
> > On Mon, 2024-04-01 at 20:44 +0200, Kornel Benko wrote:  
> >> Attached the the errors for src/frontends/qt/GuiRef.cpp and
> >> src/frontends/qt/GuiWorkArea.cpp.
> >>
> >> This is on a debian computer used by my wife, so I am somewhat
> >> reluctant to upgrade there.
> >> If I create a package on a different computer, the resulting
> >> executable does not run
> >> there because it expects many newer libraries.
> >>
> >>Kornel  
> > 
> > I suspect that the problem is the Qt version.
> > 
> > What Qt version is available there?  
> 
> The first one looks like a matter of old gcc that does not like the {} 
> constructor (don't remember the name).
> 
> JMarc

If so, can something be done here?

Kornel


pgp_QzxCF0ra_.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Errors compiling lyx2.4 with gcc 5.4.0

2024-04-02 Thread Kornel Benko
Am Mon, 01 Apr 2024 20:24:10 +0100
schrieb José Matos :

> On Mon, 2024-04-01 at 20:44 +0200, Kornel Benko wrote:
> > Attached the the errors for src/frontends/qt/GuiRef.cpp and
> > src/frontends/qt/GuiWorkArea.cpp.
> > 
> > This is on a debian computer used by my wife, so I am somewhat
> > reluctant to upgrade there.
> > If I create a package on a different computer, the resulting
> > executable does not run
> > there because it expects many newer libraries.
> > 
> > Kornel  
> 
> I suspect that the problem is the Qt version.
> 
> What Qt version is available there?

This is qt5.4.0. And probably you are right.

Kornel


pgpvfUSBLlc27.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Errors compiling lyx2.4 with gcc 5.4.0

2024-04-01 Thread Kornel Benko
Attached the the errors for src/frontends/qt/GuiRef.cpp and
src/frontends/qt/GuiWorkArea.cpp.

This is on a debian computer used by my wife, so I am somewhat reluctant to 
upgrade there.
If I create a package on a different computer, the resulting executable does 
not run
there because it expects many newer libraries.

Kornel


ErrorsGcc5.4.0
Description: Binary data


pgpbdwXc2LQli.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: SIGSEGV on current master

2024-03-30 Thread Kornel Benko
Am Sat, 30 Mar 2024 08:10:53 +
schrieb José Matos :

> On Fri, 2024-03-29 at 22:38 -0400, Scott Kostyshak wrote:
> > To reproduce:
> > 
> > 1. Start a new document.
> > 2. Start a math inset and put "x + y".
> > 3. Select x.
> > 4. Press ctrl + f to open find.
> > 5. Press .
> > 
> > The result for me is a SIGSEGV.
> > 
> > Can anyone else reproduce?
> > 
> > Scott
> 
> Yes, this is the backtrace is attached.
> 

Same here.

Kornel


pgpt4P6EXtiaZ.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: cmake build with qt6 (macos) does not include "plugins"

2024-03-23 Thread Kornel Benko
Am Thu, 21 Mar 2024 23:21:18 +0100
schrieb pdv :

> On 20/03/2024 11:26, Pavel Sanda wrote:
> > On Tue, Mar 19, 2024 at 04:02:34PM +0100, pdv wrote:  
> >> These steps have been added to my previous patch (new patch included) and I
> >> also derived the QT_PLUGINS_DIR and QT_LIBRARY_DIRS variables from the
> >> existing Qt6_DIR/Qt5_DIR variable, so they must not longer be supplied.  
> > 
> > I see there is some very old bug related to osx budles, pehaps it should be 
> > closed?
> > https://www.lyx.org/trac/ticket/9018
> >   
> >> I only tested this with Qt6.  
> > 
> > Unf we are staying out of Qt6 for mac because of serious issues we were not 
> > able to
> > solve (see bug https://www.lyx.org/trac/ticket/12641 ).
> > 
> > Pavel  
> 
> That will not be so easy (with cmake).
> The signing issue also holds for Qt5.
> 
> I've done my homework again.
> I realized that my previous solution (although it worked for me) was not 
> ideal. I can't remember why anymore but for Qt6 I copied just all the 
> plugins, which of course worked but was ineffective.
> 
> It's clear now that (for installing a bundle on macos with cmake) there 
> is no difference between Qt5 (supposed the version is GTE 5.10) and Qt6.
> 
> This makes things much simpler.
> 
> But at least with the latest macos tools (Sonoma and XCode15) a bundle 
> refuses to run if it 's not signed properly.
> 
> Both issues are solved with the patch included and have now been tested 
> with Qt5.15 and Qt6.7.
> 
> For completeness: I've checked the font-emph shortcut issue and, as 
> reported in the ticket mentioned, ^CmdE works with Qt5.15 but not with 
> Qt6.7. However the sequence ^C E does work. I don't know whether this is 
> intended as a workaround for this issue or was already implemented.
> 
> pdv

Committed at 58aca890.

Since
1.) It is tested on mac
2.) Uses cmake variable LYX_BUNDLE=ON (which is only used on mac so far as I 
can see)

I do not expect problems with other OP's.

Kornel 


pgpTxXvldb6VC.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: cmake build on macos (Sonoma, XCode) fails and remedy

2024-03-20 Thread Kornel Benko
Am Tue, 19 Mar 2024 15:31:00 +0100
schrieb pdv :

> Using the latest commit and building lyx with cmake on macos-sonoma with 
> xcode fails with multiple error messages like this one:
> 
> --
> CMake Error in po/CMakeLists.txt:
>The custom command generating
> 
>  /po/LyX2.4.cat.pot
> 
>is attached to multiple targets:
> 
>  translations
>  update-gmo
> 
>   but none of these is a common dependency of the other(s).  This is not
>   allowed by the Xcode "new build system".
> ---
> 
> These issues are solved by adding the following target dependencies 
> (patch included)
> 
>   add_dependencies(update-gmo translations)
>   add_dependencies(update-gmo update-po)
> 
>   add_dependencies(cleanupdatetex2lyxtests updatetex2lyxtests)
> 
> 
> pdv

It's in at 3f790725.

Kornel


pgpeiWA5bVpUU.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: cmake build with qt6 (macos) does not include "plugins"

2024-03-20 Thread Kornel Benko
Am Sat, 4 Nov 2023 18:05:42 +0100
schrieb pdv :

> On 04/11/2023 17:55, pdv wrote:
> > On 21/03/2023 19:27, Kornel Benko wrote:
> >> Am Tue, 21 Mar 2023 15:27:41 +0100
> >> schrieb pdv :
> >>
> >>> On 21/03/2023 11:00, Kornel Benko wrote:
> >>>> Am Mon, 20 Mar 2023 20:05:32 +0100
> >>>> schrieb pdv :
> >>>>> It's within the first if() else(), that's thus for qt6(see below). I
> >>>>> suppose this should work for all platforms, but I checked it on macos
> >>>>> only. Your patch is limited to APPLE and also works for me; If this
> >>>>> problem doesn't occur for other platforms, it's ok for me of course.
> >>>>
> >>>> Probably no one else is using the bundle option (-DLYX_BUNDLE=ON).
> >>>>
> >>>> If you could try to use cmake without this option, I'd be interested 
> >>>> if it works for
> >>>> you too.
> >>>
> >>> Apparently no problem. -DLYX_BUNDLE=OFF works too for me.
> >>>
> >>>> In this case we could get rid of it (probably).
> >>>>
> >>>> Kornel
> >>>>
> >>>
> >>>
> >>
> >> Good, so I will disable this option for lyx2.5 then.
> >>
> >> Kornel
> >>
> >>
> > I have build the latest lyx-master and I still need my (previous) patch 
> > to build a LyX.app which includes all required Qt6 frameworks (I want a 
> > stand-alone app).
> > 
> > I'm using a recent version of CMake and apparently versions older than 
> > 3.5 will not longer be supported. To get rid of the annoying warnings 
> > I've upped the minimum version from 3.1 to 3.5 (new patch included).
> > 
> > pdv
> > 
> Sorry, forgot to include the patch.

I have similar patch ( for all CMakeLists.txt) ready and only waiting for 2.4 
to be out.

Kornel


pgpmn8MSMhSUx.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: File compiles with 2.3.x but not with master

2024-01-16 Thread Kornel Benko
Am Tue, 16 Jan 2024 13:00:44 -0500
schrieb Scott Kostyshak :

> The attached .lyx file (put the my.cnf file in the same directory) compiles 
> with 2.3.x
> but not with master.
> 
> This issue was reported by Eberhard.
> 
> I currently can't compile old enough commits to bisect.
> 
> Can anyone take a look?
> 
> Scott

Sorry, I was unable to bisect to the start of lyx2.4.
The last commit I've seen that was 'bad' was
d50e02d07c546298ef26e7f39cf07b63c1f183b8
from Fri Dec 28 12:41:19 2018 +0100.

Kornel


pgp2z_dGwHtac.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Omit character activation with hanging package

2023-12-05 Thread Kornel Benko
Am Tue, 05 Dec 2023 18:36:55 +0100
schrieb "Jürgen Spitzmüller" :

> Am Dienstag, dem 05.12.2023 um 18:08 +0100 schrieb Kornel Benko:
> > Sorry, I really don't know how I could tell it is working with
> > \PassOptionsToPackage.  
> 
> I messed up the argument order. Should work now.
> 

Finally, yes it works. Thanks.

Kornel


pgpi9taSttOA6.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Omit character activation with hanging package

2023-12-05 Thread Kornel Benko
Am Tue,  5 Dec 2023 15:43:59 +0100 (CET)
schrieb Juergen Spitzmueller :

> commit ddc5fed0ad00a31d6a6df93c0def3e0da22d74eb
> Author: Juergen Spitzmueller 
> Date:   Tue Dec 5 17:07:10 2023 +0100
> 
> Omit character activation with hanging package
> 
> We do not use this feature anyway, and it breaks with other packages/
> languages that activate characters
> ---
>  lib/layouts/hanging.module |   11 +++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/layouts/hanging.module b/lib/layouts/hanging.module
> index 55c1a2e..c1bb258 100644
> --- a/lib/layouts/hanging.module
> +++ b/lib/layouts/hanging.module
> @@ -25,6 +25,17 @@ Style Hanging
>Preamble
>  \newlength{\lyxhang}
>  \IfFileExists{hanging.sty}{
> +  % Disable all character activation, as this interferes
> +  % with other packages and some languages
> +  \PassOptionsToPackage{hanging}{%
> +  notcomma,
> +  notperiod,
> +  notquote,
> +  notquery,
> +  notexcl,
> +  notcolon,
> +  notscolon
> +  }
>\usepackage{hanging}
>\newenvironment{hangparagraphs}
>  {%

Sorry, I really don't know how I could tell it is working with 
\PassOptionsToPackage.

Rechecking again and again. The only working version now is

\usepackage[notcomma,notperiod,notquote,notquery,notexcl,notcolon,notscolon]{hanging}

Sorry Jürgen to have mislead you.


pgpIue7UQ0Q9X.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-04 Thread Kornel Benko
Am Mon, 04 Dec 2023 12:47:59 +0100
schrieb "Jürgen Spitzmüller" :

> Am Montag, dem 04.12.2023 um 12:14 +0100 schrieb Jürgen Spitzmüller:
> > I am not sure which general solution would be best. Using notquote
> > generally seems to limit the functionality too strongly.  
> 
> On the other hand, the package authors themselves encourage to disable
> all character activation:
> 
> "The package also enables typesetting with hanging punctuation, by
> making punctuation characters active. This facility is best suppressed
> (it can interfere with other packages) — there are package options for
> suppressing each individual punctuation character. ‘Real’ attempts at
> hanging punction should nowadays use the microtype package, which takes
> advantage of the support offered in recent versions of pdfTeX."
> (https://www.ctan.org/pkg/hanging)
> 
> Also, we don't employ the hangpunct environment (which makes use of
> this) anyway. 
> 
> So I suggest we add to the module definition:
> 
> % Disable all character activation, as this interferes
> % with other packages and some languages
> \PassOptionsToPackage{hanging}{%
> notcomma,
> notperiod,
> notquote,
> notquery,
> notexcl,
> notcolon,
> notscolon
> }
> 
> 

Tested, seems to help. Thanks.

Kornel


pgpROsTe6vFJs.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-04 Thread Kornel Benko
Am Mon, 04 Dec 2023 12:14:10 +0100
schrieb "Jürgen Spitzmüller" :

> Am Montag, dem 04.12.2023 um 11:38 +0100 schrieb Kornel Benko:
> > Thanks, unfortunately adding
> > \usepackage[notquote]{hanging}
> > to the preamble led to
> > ! LaTeX Error: Option clash for package hanging.
> > , so that is not a good sollution.  
> 
> Adding "notquote" to the class options solves it for me.
> 
> I am not sure which general solution would be best. Using notquote
> generally seems to limit the functionality too strongly.
> 
> We could postpone the hanging loading code to \AtBeginDocument and
> query there whether slovak is loaded and act accordingly.
> 

Thanks, that would help at least for slovak ui. Czech-ui does not suffer here.

Kornel


pgprNnj5m57x5.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-04 Thread Kornel Benko
Am Mon, 04 Dec 2023 11:09:49 +0100
schrieb "Jürgen Spitzmüller" :

> Am Montag, dem 04.12.2023 um 10:55 +0100 schrieb Kornel Benko:
> > In fact, there are differences. My version loads also slovak.ldf and
> > babel-slovak.tex
> > Don't know, how that is happening. Sure, the UI is slovak, but that
> > should not go into the compilation.  
> 
> Via the info insets most probably. They are output in the respective UI
> language (which also makes sense as they refer to your current UI).
> 
> One possibility is that the hanging package interferes with some
> character activation done by babel-slovak. See
> https://tex.stackexchange.com/questions/61732/
> 

Thanks, unfortunately adding
\usepackage[notquote]{hanging}
to the preamble led to
! LaTeX Error: Option clash for package hanging.
, so that is not a good sollution.
The other one with
...
\usepackage{hanging}
\makeatletter
\def\latex@@rquote{^\bgroup\prim@s} % kernel meaning of math active quote
\let\hang@@h@ngrquote\h@ngrquote
\renewcommand{\h@ngrquote}{%
  \relax\ifmmode
\expandafter\latex@@rquote
  \else
\expandafter\hang@@h@ngrquote
  \fi}
\makeatother
...

did not help either.

Kornel


pgp5UKONR0J6p.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-04 Thread Kornel Benko
Am Mon, 4 Dec 2023 10:55:22 +0100
schrieb Kornel Benko :

> No output PDF file written.
> support/Systemcall.cpp (306): Systemcall: 'dvipdfmx -p a4  -o "Additional.pdf"
> "Additional.dvi"' finished with exit code 1
> 
> An error occurred while running:
> dvipdfmx -p a4  -o "Additional.pdf" "Additional.dvi"
> .
> should we install also the .eps files? I have only installed
> /usr/local/share/lyx2.4/images/oxygen/layout-paragraph.svgz
> 
> I am probably missing some converter.
> (The defined converter in lyxrc.default is
>   \converter svgz   eps"rsvg-convert -f ps -o $$o $$i"""
> )
> /usr/bin/rsvg-convert is installed.
> 
>   Kornel

AT least this one is solved. I had to reinstall 'ghostscript', /usr/bin/gs was 
defect.

Still the loading of slovak-files seems to make the compilation fail.

Kornel


pgppf4hJpDbrj.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-04 Thread Kornel Benko
Am Mon, 04 Dec 2023 09:41:11 +0100
schrieb "Jürgen Spitzmüller" :

> Am Montag, dem 04.12.2023 um 09:23 +0100 schrieb Kornel Benko:
> > Yes, I am sure. I tried to find what's wrong, maybe using files not
> > in TL23, but no.
> > 
> > The used statement is found in
> > /usr/local/texlive/2023/texmf-dist/tex/latex/hanging/hanging.sty
> > ...
> > '\gdef'{\futurelet\next\h@ngrqtest}'
> > ...
> > It is about quotations. BUT the created pdf-output seems to be OK
> > there.
> > BTW, I am getting this error even if I remove the quotations around
> > 'pretty'.
> > Is the error message somewhere cached?  
> 
> Add \listfiles to the preamble and compare the output in the log file
> with the following:
> 
> *File List*
>  scrbook.cls2023/07/07 v3.41 KOMA-Script document class (book)
> scrkbase.sty2023/07/07 v3.41 KOMA-Script package (KOMA-Script-
> dependent basics and keyval usage)
>  scrbase.sty2023/07/07 v3.41 KOMA-Script package (KOMA-Script-
> independent basics and keyval usage)
> scrlfile.sty2023/07/07 v3.41 KOMA-Script package (file load hooks)
> scrlfile-hook.sty2023/07/07 v3.41 KOMA-Script package (using LaTeX
> hooks)
>  scrlogo.sty2023/07/07 v3.41 KOMA-Script package (logo)
>   keyval.sty2022/05/29 v1.15 key=value parser (DPC)
> tocbasic.sty2023/07/07 v3.41 KOMA-Script package (handling toc-
> files)
>fleqn.clo2016/12/29 v1.2b Standard LaTeX option (flush left
> equations)
> scrsize12pt.clo2023/07/07 v3.41 KOMA-Script font size class option
> (12pt)
> typearea.sty2023/07/07 v3.41 KOMA-Script package (type area)
>  lmodern.sty2015/05/01 v1.6.1 Latin Modern Fonts
>  fontenc.sty2021/04/29 v2.0v Standard LaTeX package
>t1lmr.fd2015/05/01 v1.6.1 Font defs for Latin Modern
> textcomp.sty2020/02/02 v2.0n Standard LaTeX package
> inputenc.sty2021/02/14 v1.3d Input encoding file
>color.sty2022/01/06 v1.3d Standard LaTeX Color (DPC)
>color.cfg2016/01/02 v1.6 sample color configuration
>dvips.def2022/09/22 v3.1e Graphics/color driver for dvips
> dvipsnam.def2016/06/17 v3.0m Driver-dependent file (DPC,SPQR)
> mathcolor.ltx
>babel.sty2023/11/11 v3.97 The Babel package
>latin.ldf2021-06-27 v4.0 Latin support from the babel system
>  ngerman.ldf2021/02/27 v2.13 German support for babel (post-1996
> orthograph
> y)
>  english.ldf2017/06/06 v3.3r English support from the babel system
> babel-english.tex
> babel-ngerman.tex
> babel-latin.tex
>array.sty2023/10/16 v2.5g Tabular extension package (FMi)
> longtable.sty2023-11-01 v4.19 Multi-page Table package (DPC)
> booktabs.sty2020/01/12 v1.61803398 Publication quality tables
> fancybox.sty2010/05/15 1.4
> calc.sty2023/07/08 v4.3 Infix arithmetic (KKT,FJ)
>  url.sty2013/09/16  ver 3.4  Verb mode for urls, etc.
> enumitem.sty2019/06/20 v3.9 Customized lists
>   ifthen.sty2022/04/13 v1.1d Standard LaTeX ifthen package (DPC)
> multicol.sty2023/03/30 v1.9f multicolumn formatting (FMi)
> shapepar.sty2013/03/26 v 2.2x, Shaped paragraphs
>  amsmath.sty2023/05/13 v2.17o AMS math features
>  amstext.sty2021/08/26 v2.01 AMS text
>   amsgen.sty1999/11/30 v2.0 generic functions
>   amsbsy.sty1999/11/29 v1.2d Bold Symbols
>   amsopn.sty2022/04/08 v2.04 operator names
>   amsthm.sty2020/05/29 v2.20.6
>   xpatch.sty2020/03/25 v0.3a Extending etoolbox patching commands
>expl3.sty2023-11-09 L3 programming layer (loader) 
> l3backend-dvips.def2023-11-09 L3 backend support: dvips
>   xparse.sty2023-10-10 L3 Experimental document command parser
> etoolbox.sty2020/10/05 v2.5k e-TeX tools for LaTeX (JAW)
>  amssymb.sty2013/01/14 v3.01 AMS font symbols
> amsfonts.sty2013/01/14 v3.01 Basic AMSFonts support
>  makeidx.sty2021/10/04 v1.0m Standard LaTeX package
> graphicx.sty2021/09/16 v1.2d Enhanced LaTeX Graphics (DPC,SPQR)
> graphics.sty2022/03/10 v1.4e Standard LaTeX Graphics (DPC,SPQR)
> trig.sty2021/08/11 v1.11 sin cos tan (DPC)
> graphics.cfg2016/06/04 v1.11 sample graphics configuration
> ulem.sty2019/11/18
> hyperref.sty2023-11-26 v7.01g Hypertext links for LaTeX
>iftex.sty2022/02/03 v1.0f TeX engine tests
> infwarerr.sty2019/12/03 v1.5 Providing info/warning/error messages
> (HO)
> kvsetkeys.sty2022-10-05 v1.19 Key value parser (HO)
> kvdefinekeys.sty2019-12-19 v1.6 Define keys (HO)
> pdfescape.sty2019/12/09 v1.15 Implements pdfTeX's escape features
> (HO)
>  ltxcmds.sty2020-05-10 v1.25 LaTeX kernel commands for general use
> (HO)
> pdftexcmds.sty2020-06-27 v0.33 

Re: ctests failing on current master

2023-12-04 Thread Kornel Benko
Am Sun, 03 Dec 2023 14:18:52 +0100
schrieb "Jürgen Spitzmüller" :

> Am Sonntag, dem 03.12.2023 um 13:50 +0100 schrieb Kornel Benko:
> > Sure? View formats
> > pdf: PDF (ps2pdf)
> > ! Use of \next doesn't match its definition
> > '->\futurelet \next \h@ngrqtest   
> 
> Compiles without error here.
> 
> > pdf3: PDF (dvipdfm)
> > Same output  
> 
> This, too.
> 
> > This is with TL23.  
> 
> Same here (updated today).
> 
> Are you sure you are on most recent master?
> 

Yes, I am sure. I tried to find what's wrong, maybe using files not in TL23, 
but no.

The used statement is found in
/usr/local/texlive/2023/texmf-dist/tex/latex/hanging/hanging.sty
...
'\gdef'{\futurelet\next\h@ngrqtest}'
...
It is about quotations. BUT the created pdf-output seems to be OK there.
BTW, I am getting this error even if I remove the quotations around 'pretty'.
Is the error message somewhere cached?

Using different userdir does not help. Here I get conversion error from 
dvipdfmx instead.
Now I am lost.

Kornel


pgpTFLJZ7Z1NI.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-03 Thread Kornel Benko
Am Sun, 03 Dec 2023 13:29:12 +0100
schrieb "Jürgen Spitzmüller" :

> Am Sonntag, dem 03.12.2023 um 12:01 +0100 schrieb Kornel Benko:
> > From the 105 'Additional' export tests now only 16 are failing.
> > The following tests FAILED:  
> 
> I cannot reproduce any Additional failure in current master.
> 

Sure? View formats
pdf: PDF (ps2pdf)
! Use of \next doesn't match its definition
'->\futurelet \next \h@ngrqtest 

l.3413 T
here are a few ``pretty''
If you say, e.g., `\def\a1{...}', then you must always
put `1' after `\a', since control sequence names are
made up of letters only. The macro here has not been
followed by the required stuff, so I'm ignoring it.
...

pdf3: PDF (dvipdfm)
Same output

This is with TL23.

Kornel



pgpY2G4uYn2zM.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-03 Thread Kornel Benko
Am Sun, 03 Dec 2023 11:21:06 +0100
schrieb "Jürgen Spitzmüller" :

> Am Freitag, dem 01.12.2023 um 12:19 -0500 schrieb Scott Kostyshak:
> > The following ctests are failing on current master:  
> 
> Some of them (the Additional cases at least) should work again after
> ac5cc017179cdff61
> 

From the 105 'Additional' export tests now only 16 are failing.
The following tests FAILED:
1744 - export/doc/Additional_pdf (Failed)
1746 - export/doc/Additional_pdf3 (Failed)
2109 - export/doc/de/Additional_pdf (Failed)
2111 - export/doc/de/Additional_pdf3 (Failed)
2323 - export/doc/es/Additional_pdf (Failed)
2325 - export/doc/es/Additional_pdf3 (Failed)
2557 - export/doc/fr/Additional_pdf (Failed)
2559 - export/doc/fr/Additional_pdf3 (Failed)
2940 - export/doc/ja/Additional_lyx22 (Failed)
2941 - export/doc/ja/Additional_lyx23 (Failed)
2947 - UNRELIABLE.NONSTANDARD_export/doc/ja/Additional_pdf (Failed)
2948 - export/doc/ja/Additional_pdf3 (Failed)
3300 - export/doc/ru/Additional_dvi3_texF (Failed)
3302 - export/doc/ru/Additional_pdf (Failed)
3304 - export/doc/ru/Additional_pdf3 (Failed)
3306 - export/doc/ru/Additional_pdf5_texF (Failed)

Kornel


pgph5jxGyqR5j.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-03 Thread Kornel Benko
Am Sun, 03 Dec 2023 10:40:12 +0100
schrieb "Jürgen Spitzmüller" :

> Am Sonntag, dem 03.12.2023 um 09:32 + schrieb José Matos:
> > On Sun, 2023-12-03 at 10:07 +0100, Kornel Benko wrote:  
> > > The only difference in the "roundtrip" for style 'Enumerate' is
> > > 
> > > < Requires ""    1""  
> > > > Requires " 1"  
> > 
> > The first line seems problematic. Does that corresponds to 3
> > arguments?  
> 
> No. We read in the whole line (via eatLine()), so it's just an embedded
> quotation that does in practice not matter.
> 
> But it is fixed. I removed the extra quoting on ::write()
> 

Thanks. I wonder if some unified diff would be worth the struggle for the error 
message.

Kornel


pgpzrK09ZHT_2.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-03 Thread Kornel Benko
Am Sun, 03 Dec 2023 09:16:20 +0100
schrieb "Jürgen Spitzmüller" :

> Am Samstag, dem 02.12.2023 um 17:42 +0100 schrieb Kornel Benko:
> > Should I better know than you?   
> 
> I thought so, since you are using and improving the tests regularly.
> 
> > It is our code in ./src/tests/check_layout.cpp  
> 
> I can try to find out. Maybe the tests themselves should output more
> transparent error messages.
> 

Thanks. Yes, the messages are sub-optimal.

The only difference in the "roundtrip" for style 'Enumerate' is

< Requires ""1""
> Requires " 1"

Kornel


pgpkhkoP7bI9k.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-02 Thread Kornel Benko
Am Sat, 02 Dec 2023 17:22:32 +0100
schrieb "Jürgen Spitzmüller" :

> Am Samstag, dem 02.12.2023 um 17:16 +0100 schrieb Kornel Benko:
> > In the lyx-bin directory there should also exist the command
> > "check_layout".
> > The use is simple:
> > 
> > $ check_layout /usr2/src/lyx/lyx-
> > test/lib/layouts/powerdot.layout
> > (of course "usr2/src/lyx/lyx-test/lib/layouts/" is my own path)
> > Using
> > $ check_layout /usr2/src/lyx/lyx-
> > test/lib/layouts/powerdot.layout |& grep -i fail
> > I get
> > Round trip for style Enumerate failed:
> > Round trip for style EnumerateType1 failed:  
> 
> This does not answer my question: what does if TEST for?
> 

Should I better know than you? It is our code in ./src/tests/check_layout.cpp

Kornel


pgpl9XO8Kie7H.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-02 Thread Kornel Benko
Am Sat, 2 Dec 2023 17:16:45 +0100
schrieb Kornel Benko :

> Am Sat, 02 Dec 2023 16:07:15 +0100
> schrieb "Jürgen Spitzmüller" :
> 
> > Am Samstag, dem 02.12.2023 um 10:40 +0100 schrieb Kornel Benko:  
> > > Am Fri, 1 Dec 2023 12:19:31 -0500
> > > schrieb Scott Kostyshak :
> > > 
> > > > The following ctests are failing on current master:
> > > > 
> > > >    check_layout/memoir.layout (Failed)
> > > >    check_layout/powerdot.layout (Failed)
> > > 
> > > Bisecting for check_layout/powerdot.layout led to:
> > > 
> > > 3698281943611647738baba1b33a3bd08518e410 is the first bad commit
> > > commit 3698281943611647738baba1b33a3bd08518e410
> > > Author: Juergen Spitzmueller 
> > > Date:   Thu Nov 9 22:06:39 2023 +0100
> > > 
> > >     Read separated required arg without enquoting
> > 
> > I don't see what's wrong with that commit.
> > 
> > What does the check_layout test test? I don't get an error when loading
> > the powerdot example, for instance.
> >   
> 
> In the lyx-bin directory there should also exist the command "check_layout".
> The use is simple:
> 
>   $ check_layout /usr2/src/lyx/lyx-test/lib/layouts/powerdot.layout
> (of course "usr2/src/lyx/lyx-test/lib/layouts/" is my own path)
> Using
>   $ check_layout /usr2/src/lyx/lyx-test/lib/layouts/powerdot.layout |& 
> grep -i
> fail I get
> Round trip for style Enumerate failed:
> Round trip for style EnumerateType1 failed:
> 
>   Kornel

Also, try to view 'PDF (LuaTeX)'
The first error you get:
Missing number, treated as zero.
 {
  \small On the evening of the crime, he returned from the club exactly
A number should have been here; I inserted `0'.
(If you can't figure out why I needed to see a number,
look up `weird error' in the index to The TeXbook.)

Kornel


pgp7ibz8_YlQ_.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-02 Thread Kornel Benko
Am Sat, 02 Dec 2023 16:07:15 +0100
schrieb "Jürgen Spitzmüller" :

> Am Samstag, dem 02.12.2023 um 10:40 +0100 schrieb Kornel Benko:
> > Am Fri, 1 Dec 2023 12:19:31 -0500
> > schrieb Scott Kostyshak :
> >   
> > > The following ctests are failing on current master:
> > > 
> > >    check_layout/memoir.layout (Failed)
> > >    check_layout/powerdot.layout (Failed)  
> > 
> > Bisecting for check_layout/powerdot.layout led to:
> > 
> > 3698281943611647738baba1b33a3bd08518e410 is the first bad commit
> > commit 3698281943611647738baba1b33a3bd08518e410
> > Author: Juergen Spitzmueller 
> > Date:   Thu Nov 9 22:06:39 2023 +0100
> > 
> >     Read separated required arg without enquoting  
> 
> I don't see what's wrong with that commit.
> 
> What does the check_layout test test? I don't get an error when loading
> the powerdot example, for instance.
> 

In the lyx-bin directory there should also exist the command "check_layout".
The use is simple:

$ check_layout /usr2/src/lyx/lyx-test/lib/layouts/powerdot.layout
(of course "usr2/src/lyx/lyx-test/lib/layouts/" is my own path)
Using
$ check_layout /usr2/src/lyx/lyx-test/lib/layouts/powerdot.layout |& 
grep -i fail
I get
Round trip for style Enumerate failed:
Round trip for style EnumerateType1 failed:

Kornel


pgppeLk545HBP.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: ctests failing on current master

2023-12-02 Thread Kornel Benko
Am Fri, 1 Dec 2023 12:19:31 -0500
schrieb Scott Kostyshak :

> The following ctests are failing on current master:
> 
>   check_layout/memoir.layout (Failed)
>   check_layout/powerdot.layout (Failed)

Bisecting for check_layout/powerdot.layout led to:

3698281943611647738baba1b33a3bd08518e410 is the first bad commit
commit 3698281943611647738baba1b33a3bd08518e410
Author: Juergen Spitzmueller 
Date:   Thu Nov 9 22:06:39 2023 +0100

Read separated required arg without enquoting

 src/Layout.cpp | 2 +-
 src/insets/InsetLayout.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

>   check_layout/tcolorbox.module (Failed)
>   export/doc/Additional_lyx22 (Failed)
>   export/doc/Additional_lyx23 (Failed)

...

Did not check the remained cases. Hopefully the same reason.

Kornel


pgpGgWH_dBnB7.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find: ignore non-output content

2023-11-29 Thread Kornel Benko
Am Fri, 24 Nov 2023 13:24:55 -0500
schrieb Richard Kimberly Heck :

> On 11/24/23 07:23, Scott Kostyshak wrote:
> > In master, if I click on settings and then "Ignore non-output content",
> > notes should not be searched right? In the attached example, if I search
> > for "abc", it also searches the notes.  
> 
> Sounds like a bug.
> 
> Riki
> 
> 

Worse than that. It simply does not function in backward search and with
'Adhere to search string formatting of'
setting.

It only sort of works if the cursor is behind the last occurrence of the 
searched string.

Sorry, I tried to bisect, but failed.
I'd like to disable backward search in this case.

Kornel


pgpe6bRKnoya7.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: List of available classes

2023-11-12 Thread Kornel Benko
Am Sun, 12 Nov 2023 15:55:40 -0500
schrieb Scott Kostyshak :

> On Sun, Nov 12, 2023 at 06:40:02PM +0100, Jean-Pierre Chrétien wrote:
> > Dear developers,
> > 
> > While updating the French version of Additional.lyx, I wanted to check the
> > availability of KOMA-Script Report.
> > However, I can't scroll down the list of classes further than the Japanese
> > reports, I do not even see the Report (standard class).
> > 
> > lyx-2.4.0-RC1-devel recompiled after an update of the files at 8e619462.
> > 
> > In addition, the fonts of the menu bars are very small as well as those of
> > the lists of classes window. Where could I tune these fonts ?  
> 
> I might be able to reproduce. On my laptop, it seems cut off. I see the "up 
> arrow" to
> scroll up, but there is no "down arrow" visible.
> 
> @Kornel do you see a "down arrow"?
> 
> @Jean-Pierre do you see a down arrow? I'm guessing you do not and you scroll 
> down like
> I do with the mouse wheel/two-finger-scroll?
> 
> Scott

I see the down arrow, and it is functioning. Just tried.
Normally I use only the mouse-wheel there, so I wasn't even aware of the arrows.

Maybe it depends on the appearance

Mine is
Surface: Mint-Y-Aqua
Symbols: Mint-Y-Sand
Window-style: Mint-Y

Kornel



pgpTH2l_4QQzV.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: List of available classes

2023-11-12 Thread Kornel Benko
Am Sun, 12 Nov 2023 18:40:02 +0100
schrieb Jean-Pierre Chrétien :

> Dear developers,
> 
> While updating the French version of Additional.lyx, I wanted to check the 
> availability of KOMA-Script Report.
> However, I can't scroll down the list of classes further than the Japanese 
> reports, I do not even see the Report (standard class).
> 
> lyx-2.4.0-RC1-devel recompiled after an update of the files at 8e619462.
> 
> In addition, the fonts of the menu bars are very small as well as those of 
> the 
> lists of classes window. Where could I tune these fonts ?
> 

Cannot confirm here.

Kornel


pgpvjGWHy3J7n.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-11 Thread Kornel Benko
Am Sat, 11 Nov 2023 11:14:51 -0500
schrieb Scott Kostyshak :

> > diff --git a/development/cmake/post_install/CMakeLists.txt
> > b/development/cmake/post_install/CMakeLists.txt index 
> > 52a2f782af..f83cdaad0b 100644
> > --- a/development/cmake/post_install/CMakeLists.txt
> > +++ b/development/cmake/post_install/CMakeLists.txt
> > @@ -28,14 +28,18 @@ if(LYX_BUNDLE)
> >  endif()
> >  
> >  if(Qt5Core_FOUND)
> > -   file(GLOB QT_PLUGIN_DIRECTORIES "${QT_PLUGINS_DIR}/imageformats")
> > -   install(DIRECTORY ${QT_PLUGIN_DIRECTORIES} DESTINATION
> > "${qtplugin_dest_dir}/plugins/" COMPONENT Runtime REGEX "\\_debug\\.dylib$" 
> > EXCLUDE)
> > +   file(GLOB QT_PLUGIN_DIRECTORIES "${QT_PLUGINS_DIR}/imageformats")
> > +   install(DIRECTORY ${QT_PLUGIN_DIRECTORIES} DESTINATION
> > "${qtplugin_dest_dir}/plugins/" COMPONENT Runtime REGEX "\\_debug\\.dylib$" 
> > EXCLUDE)
> > if(APPLE) if(Qt5Core_VERSION VERSION_GREATER_EQUAL 5.10.0)
> > install_qt_plugin("Qt5::QMacStylePlugin")
> > endif()
> >  install_qt_plugin("Qt5::QCocoaIntegrationPlugin")
> > endif()
> > +else()
> > +# With QT6, just copy all the plugins
> > +file(GLOB QT_PLUGIN_DIRECTORIES "${QT_PLUGINS_DIR}/*")
> > +install(DIRECTORY ${QT_PLUGIN_DIRECTORIES} DESTINATION
> > "${qtplugin_dest_dir}/plugins/" COMPONENT Runtime REGEX "\\_debug\\.dylib$" 
> > EXCLUDE)
> > endif() 
> >  # Install code does the following:  
> 
> @Kornel seems like we might want this one in master?
> 
> Scott

Yes, I am only waiting for 2.4 be out. Nobody outside of MAC seems to use 
BUNDLE though.

Kornel


pgpRGXK9Zg_AU.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: New macros LYX_BEGIN_MUTE_GCC_WARNING and LYX_END_MUTE_GCC_WARNING not defined in cmake conf

2023-11-10 Thread Kornel Benko
Am Fri, 10 Nov 2023 14:40:01 +0100
schrieb Jean-Marc Lasgouttes :

> Le 10/11/2023 à 13:24, Kornel Benko a écrit :
> > Thanks, but
> > /usr2/src/lyx/lyx-git/src/Mover.h:18:10: fatal error: 
> > support/mute_warning.h: No such
> > file or directory 18 | #include "support/mute_warning.h"
> >|  ^~~~
> > 
> > Kornel  
> 
> Sigh. Fixed now.
> 
> JMarc
> 

Compiles fine, thanks.

Kornel


pgpTnRTUo7yvX.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: New macros LYX_BEGIN_MUTE_GCC_WARNING and LYX_END_MUTE_GCC_WARNING not defined in cmake conf

2023-11-10 Thread Kornel Benko
Am Fri, 10 Nov 2023 13:16:35 +0100
schrieb Jean-Marc Lasgouttes :

> Le 10/11/2023 à 12:58, Kornel Benko a écrit :
> > 
> > This of course breaks the compilation.
> > 
> > Please do not add new stuff at this stage.
> > 
> > Would it be possible to add the definitions into some header file instead?  
> 
> Sorry, I did not think of this (better) possibility.
> 
> Done now.
> 
> JMarc
> 

Thanks, but
/usr2/src/lyx/lyx-git/src/Mover.h:18:10: fatal error: support/mute_warning.h: 
No such
file or directory 18 | #include "support/mute_warning.h"
  |  ^~~~

Kornel


pgpDRA8uBxHII.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


New macros LYX_BEGIN_MUTE_GCC_WARNING and LYX_END_MUTE_GCC_WARNING not defined in cmake conf

2023-11-10 Thread Kornel Benko

This of course breaks the compilation.

Please do not add new stuff at this stage.

Would it be possible to add the definitions into some header file instead?

Kornel


pgpKxQrxIxltt.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Something's wrong today with git.lyx.org:lyx

2023-11-10 Thread Kornel Benko
Am Fri, 10 Nov 2023 12:13:12 +0100
schrieb Jean-Marc Lasgouttes :

> Le 10/11/2023 à 12:05, Kornel Benko a écrit :
> > 
> > On master I get
> > $ git pull
> > error: Could not read 343a9749abe4f32e67ef9aae9554ee4bd8dae1b4
> > remote: Counting objects: 42, done.
> > remote: Compressing objects: 100% (26/26), done.
> > remote: Total 26 (delta 22), reused 0 (delta 0)
> > Unpacking objects: 100% (26/26), 76.31 KiB | 375.00 KiB/s, done.
> > fatal: bad object refs/tags/1.6.2
> > error: git.lyx.org:lyx did not send all necessary objects  
> 
> It works well here. Note that it happens that I have to repeat 'pull' 
> commands because on first try I have errors like "unable to rebase on 
> multiple branches" or "cannot lock ref 'refs/remotes/origin/2.3.x'". 
> This is a bit mysterious.
> 
> JMarc
> 

Never mind, something went wrong with my filesystem. The directory 
.git/objects/34 was
unreadable. Fsck repaired it.

Kornel


pgp_dpdhzqNSz.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Something's wrong today with git.lyx.org:lyx

2023-11-10 Thread Kornel Benko

On master I get
$ git pull
error: Could not read 343a9749abe4f32e67ef9aae9554ee4bd8dae1b4
remote: Counting objects: 42, done.
remote: Compressing objects: 100% (26/26), done.
remote: Total 26 (delta 22), reused 0 (delta 0)
Unpacking objects: 100% (26/26), 76.31 KiB | 375.00 KiB/s, done.
fatal: bad object refs/tags/1.6.2
error: git.lyx.org:lyx did not send all necessary objects

Exit 1

Kornel


pgpMoSDbXiWd7.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: cmake build with qt6 (macos) does not include "plugins"

2023-11-04 Thread Kornel Benko
Am Sat, 4 Nov 2023 18:05:42 +0100
schrieb pdv :

> On 04/11/2023 17:55, pdv wrote:
> > On 21/03/2023 19:27, Kornel Benko wrote:
> >> Am Tue, 21 Mar 2023 15:27:41 +0100
> >> schrieb pdv :
> >>
> >>> On 21/03/2023 11:00, Kornel Benko wrote:
> >>>> Am Mon, 20 Mar 2023 20:05:32 +0100
> >>>> schrieb pdv :
> >>>>> It's within the first if() else(), that's thus for qt6(see below). I
> >>>>> suppose this should work for all platforms, but I checked it on macos
> >>>>> only. Your patch is limited to APPLE and also works for me; If this
> >>>>> problem doesn't occur for other platforms, it's ok for me of course.
> >>>>
> >>>> Probably no one else is using the bundle option (-DLYX_BUNDLE=ON).
> >>>>
> >>>> If you could try to use cmake without this option, I'd be interested 
> >>>> if it works for
> >>>> you too.
> >>>
> >>> Apparently no problem. -DLYX_BUNDLE=OFF works too for me.
> >>>
> >>>> In this case we could get rid of it (probably).
> >>>>
> >>>> Kornel
> >>>>
> >>>
> >>>
> >>
> >> Good, so I will disable this option for lyx2.5 then.
> >>
> >> Kornel
> >>
> >>
> > I have build the latest lyx-master and I still need my (previous) patch 
> > to build a LyX.app which includes all required Qt6 frameworks (I want a 
> > stand-alone app).
> > 
> > I'm using a recent version of CMake and apparently versions older than 
> > 3.5 will not longer be supported. To get rid of the annoying warnings 
> > I've upped the minimum version from 3.1 to 3.5 (new patch included).
> > 
> > pdv
> > 
> Sorry, forgot to include the patch.

Will be done for 2.4.x versions. Also for other CMakeLists.txt's in the 
lyx-sources.

Kornel


pgpqLBFtd8Hso.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: CMake fails on first configure

2023-10-22 Thread Kornel Benko
Am Sun, 22 Oct 2023 20:48:38 +0200
schrieb Yu Jin :

> Am So., 22. Okt. 2023 um 17:32 Uhr schrieb Kornel Benko:
> 
> > Am Sun, 22 Oct 2023 10:22:54 +0200
> > schrieb Yu Jin:
> >
> > > Am Sa., 21. Okt. 2023 um 22:00 Uhr schrieb Yu Jin:
> > >
> > > > Am Sa., 21. Okt. 2023 um 19:42 Uhr schrieb Kornel Benko:
> > > >
> > > >>
> > > >> What bothers me, is that the following configure is OK.
> > > >> For me that implies that the first configure already created
> > > >> CMakeCache.txt.
> > > >> Could you compare the first CMakeCache.txt with later created version?
> > > >> Normally I would
> > > >> expect they have same content.
> > > >>
> > > >
> > > > Well the following configure does not do any checks or try_compile, so
> > it
> > > > can't run into this error .
> > > >
> > >
> > > I think it comes from here:
> > >
> > https://git.lyx.org/?p=lyx.git;a=blob;f=development/cmake/ConfigureChecks.cmake;h=9062372c38e107156a7e561bce340045b0cd53e0;hb=0b5a9060c2afc3e68b3b055ec5b02db7d13458ab#l287
> > > set(CMAKE_REQUIRED_INCLUDES ${${QtVal}Core_INCLUDE_DIRS})
> > >
> > > I just added a message after this line for testing message(STATUS
> > "includes
> > > set: "${${QtVal}Core_INCLUDE_DIRS})
> > > and it returns:
> > > includes set:
> > >
> > C:/Qt/6.6.0/msvc2019_64/include/QtCoreC:/Qt/6.6.0/msvc2019_64/includeC:/Qt/6.6.0/msvc2019_64/include/QtZlib$<$>:>$<$>:C:/Qt/6.6.0/msvc2019_64/include/QtZlib/6.6.0>$<$>:C:/Qt/6.6.0/msvc2019_64/include/QtZlib/6.6.0/QtZlib>
> > >
> > > So exactly what is set in CMakeCache.txt of the try_compie project, so in
> > > the end it's set in ${Qt6Core_INCLUDE_DIRS}, which comes from Qt I
> > suppose,
> > > I guess I can make a minimal example with this and ask on the Qt forum...
> > >
> >
> > That asking the forum would be nice. And yes, Qt6Core_INCLUDE_DIRS comes
> > from Qt, not our
> >
> 
> What does it contain on Linux though? could you try with a simple
> message(STATUS  ${Qt6Core_INCLUDE_DIRS})
> ?

Qt6Core_INCLUDE_DIRS =
/usr/include/x86_64-linux-gnu/qt6/QtCore;/usr/include/x86_64-linux-gnu/qt6

This is also with cmake3.28

Kornel


pgpSX3ivibE0c.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: CMake fails on first configure

2023-10-22 Thread Kornel Benko
Am Sun, 22 Oct 2023 10:22:54 +0200
schrieb Yu Jin :

> Am Sa., 21. Okt. 2023 um 22:00 Uhr schrieb Yu Jin :
> 
> > Am Sa., 21. Okt. 2023 um 19:42 Uhr schrieb Kornel Benko:
> >
> >>
> >> What bothers me, is that the following configure is OK.
> >> For me that implies that the first configure already created
> >> CMakeCache.txt.
> >> Could you compare the first CMakeCache.txt with later created version?
> >> Normally I would
> >> expect they have same content.
> >>
> >
> > Well the following configure does not do any checks or try_compile, so it
> > can't run into this error .
> >
> 
> I think it comes from here:
> https://git.lyx.org/?p=lyx.git;a=blob;f=development/cmake/ConfigureChecks.cmake;h=9062372c38e107156a7e561bce340045b0cd53e0;hb=0b5a9060c2afc3e68b3b055ec5b02db7d13458ab#l287
> set(CMAKE_REQUIRED_INCLUDES ${${QtVal}Core_INCLUDE_DIRS})
> 
> I just added a message after this line for testing message(STATUS "includes
> set: "${${QtVal}Core_INCLUDE_DIRS})
> and it returns:
> includes set:
> C:/Qt/6.6.0/msvc2019_64/include/QtCoreC:/Qt/6.6.0/msvc2019_64/includeC:/Qt/6.6.0/msvc2019_64/include/QtZlib$<$>:>$<$>:C:/Qt/6.6.0/msvc2019_64/include/QtZlib/6.6.0>$<$>:C:/Qt/6.6.0/msvc2019_64/include/QtZlib/6.6.0/QtZlib>
> 
> So exactly what is set in CMakeCache.txt of the try_compie project, so in
> the end it's set in ${Qt6Core_INCLUDE_DIRS}, which comes from Qt I suppose,
> I guess I can make a minimal example with this and ask on the Qt forum...
> 

That asking the forum would be nice. And yes, Qt6Core_INCLUDE_DIRS comes from 
Qt, not our
doing.

Kornel


pgpjFUz8ByY70.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: CMake fails on first configure

2023-10-21 Thread Kornel Benko
Am Sat, 21 Oct 2023 13:47:13 +0200
schrieb Yu Jin :

> Am Sa., 21. Okt. 2023 um 08:42 Uhr schrieb Yu Jin :
> 
> > Am So., 15. Okt. 2023 um 22:32 Uhr schrieb Yu Jin  > >:
> >
> >> Am Mo., 2. Okt. 2023 um 21:51 Uhr schrieb Yu Jin:
> >>
> >>>
> >>> C:\Qt\6.5.2\msvc2019_64\include\QtGui\qtgui-config.h
> >>>
> >>
> >> Ping...
> >> I don't really understand what is wrong here, could some1 help out with a
> >> minimal example so I can ask the Qt forum?
> >>
> >> Git bisect leads to this
> >
> > https://git.lyx.org/?p=lyx.git;a=commitdiff;h=ebe4834684a523de15f55068a32b487cae251bea
> >
> > I ran cmake with --debug-trycompile and found some more infos, here is
> the error:
> 
> -- Looking for C++ include QtGui/qtgui-config.h
> CMake Debug Log at C:/Program
> Files/CMake/share/cmake-3.26/Modules/CheckIncludeFileCXX.cmake:94
> (try_compile):
>   Executing try_compile (HAVE_QTGUI_CONFIG_H) in:
> 
> C:/lyx/master-build-64/CMakeFiles/CMakeScratch/TryCompile-896vpl
> Call Stack (most recent call first):
>   development/cmake/ConfigureChecks.cmake:290 (check_include_file_cxx)
>   CMakeLists.txt:1146 (include)
> 
> 
> CMake Error at
> C:/lyx/master-build-64/CMakeFiles/CMakeScratch/TryCompile-896vpl/CMakeLists.txt:12
> (include_directories):
>   Error evaluating generator expression:
> 
> $
> 
>   Target "Qt6::ZlibPrivate" not found.
> 
> here is the File
> C:/lyx/master-build-64/CMakeFiles/CMakeScratch/TryCompile-896vpl/CMakeLists.txt:
> 
> cmake_minimum_required(VERSION 3.28.0.0)
> set(CMAKE_MODULE_PATH
> "C:/lyx/master/development/cmake/modules;C:/Qt/6.6.0/msvc2019_64/lib/cmake/Qt6;C:/Qt/6.6.0/msvc2019_64/lib/cmake/Qt6/3rdparty/extra-cmake-modules/find-modules;C:/Qt/6.6.0/msvc2019_64/lib/cmake/Qt6/3rdparty/kwin")
> cmake_policy(SET CMP0091 OLD)
> cmake_policy(SET CMP0141 OLD)
> cmake_policy(SET CMP0126 OLD)
> cmake_policy(SET CMP0128 OLD)
> project(CMAKE_TRY_COMPILE CXX)
> set(CMAKE_VERBOSE_MAKEFILE 1)
> set(CMAKE_CXX_FLAGS "/DWIN32 /D_WINDOWS /W3 /GR /EHsc")
> set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${COMPILE_DEFINITIONS}")
> set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${EXE_LINKER_FLAGS}")
> include_directories(${INCLUDE_DIRECTORIES})
> set(CMAKE_SUPPRESS_REGENERATION 1)
> link_directories(${LINK_DIRECTORIES})
> cmake_policy(SET CMP0065 OLD)
> cmake_policy(SET CMP0083 OLD)
> cmake_policy(SET CMP0155 OLD)
> include("${CMAKE_ROOT}/Modules/Internal/HeaderpadWorkaround.cmake")
> set(CMAKE_RUNTIME_OUTPUT_DIRECTORY
> "C:/lyx/master-build-64/CMakeFiles/CMakeScratch/ TryCompile-896vpl")
> add_executable(cmTC_cde46)
> target_sources(cmTC_cde46 PRIVATE
> 
> "C:/lyx/master-build-64/CMakeFiles/CMakeScratch/TryCompile-896vpl/CheckIncludeFile.cxx"
> )
> file(GENERATE OUTPUT
> "${CMAKE_BINARY_DIR}/cmTC_cde46_$>_loc"
>  CONTENT $)
> target_link_libraries(cmTC_cde46 ${LINK_LIBRARIES})
> 
> 
> So it fails on
> include_directories(${INCLUDE_DIRECTORIES})
> I have checked the file
> C:/lyx/master-build-64/CMakeFiles/CMakeScratch/TryCompile-896vpl/CMakeCache.txt:
> 
> //No help, variable specified on the command line.
> INCLUDE_DIRECTORIES:UNINITIALIZED=C:/Qt/6.6.0/msvc2019_64/include/QtCore;C:/Qt/6.6.0/msvc2019_64/include;C:/Qt/6.6.0/msvc2019_64/include/QtZlib;$<$>:>;$<$>:C:/Qt/6.6.0/msvc2019_64/include/QtZlib/6.6.0>;$<$>:C:/Qt/6.6.0/msvc2019_64/include/QtZlib/6.6.0/QtZlib>
> 
> Is this something variable specified by CMake or can we affect it? Maybe
> it's the same thing as in this thread?
> https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg218586.html
> For quick reminder we ended up doing this:
> https://git.lyx.org/?p=lyx.git;a=commitdiff;h=26a3a085

What bothers me, is that the following configure is OK.
For me that implies that the first configure already created CMakeCache.txt.
Could you compare the first CMakeCache.txt with later created version? Normally 
I would
expect they have same content.

Kornel


pgpECsqnVpJCH.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Big number of inverted docbook5 tests

2023-10-13 Thread Kornel Benko
Am Thu, 12 Oct 2023 13:59:17 +0200
schrieb Thibaut Cuvelier :

> On Thu, 12 Oct 2023, 11:11 Kornel Benko,  wrote:
> 
> >
> > Master trunk as of today:
> > I count 406 tests for docbook5. 149 of them are inverted.
> > Thibaut, is there a reason for such a huge ratio?
> 
> 
> There are two major reasons.
> - Many tests are for Beamer: someone would need to write the layouts for
> it, there is little from the other documents that can be used for Beamer.
> - There are modules that are hard to support (they would need a lot of
> custom code only for one module). Basically, that means that LaTeX and
> DocBook are vastly different in terms of concepts and levels of abstraction.
> I think I "documented" the inversion in the commit messages. Overall,
> having all tests pass would require tens of hours of work, which I
> preferred to invest in improving the quantity of the existing
> implementation.

Good reasons. We could also select some of them to be ignored, so they do not 
show
anymore.
Also, tests which are planed to not fail in the future, deserve entry in 
suspendedTests
too.

Kornel


pgpxRnhdGu45e.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Big number of inverted docbook5 tests

2023-10-12 Thread Kornel Benko

Master trunk as of today:
I count 406 tests for docbook5. 149 of them are inverted.
Thibaut, is there a reason for such a huge ratio?

Kornel


pgpS9OJRnHJ4_.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-09 Thread Kornel Benko
Am Mon, 9 Oct 2023 10:14:48 +0200
schrieb Pavel Sanda :

> On Sun, Oct 08, 2023 at 12:56:46PM +0200, Kornel Benko wrote:
> > I was not planing to strip that part. The propose was an example.
> > Plan is:
> > If lyx with cmake is configured with
> > -DLYX_PROGRAM_SUFFIX:BOOL=ON
> > the built executables have all a suffix. Only in this case should the 
> > rename happen.
> > org.lyx.LyX.metainfo.xml -> org.lyx.LyX2.4.metainfo.xml
> > 
> > In all other cmake-settings no rename is planed.  
> 
> I see, if the default is not touched then the suffix version is not much of a 
> problem
> IMHO. Pavel

Tested that it works also for the default case. Committed at b05d59ec.

Kornel


pgpLanP0BdJbt.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-08 Thread Kornel Benko
Am Fri, 6 Oct 2023 14:30:24 +0200
schrieb Pavel Sanda :

> On Fri, Oct 06, 2023 at 01:02:47PM +0200, Kornel Benko wrote:
> > > > I am using lyx2.3 and lyx2.4 in parallel installed. The problem will 
> > > > arise on
> > > > installing lyx2.5 later.
> > > > 
> > > > Installing without using the suffix should be no problem for you (e.g. 
> > > > no change)
> > > > My proposal would rename it to "LyX.metainfo.xml".
> > > > 
> > > 
> > > This conflict is, I believe, also present in autoconf builds. The 
> > > default there is to build without suffix. If I move to cmake for 
> > > openSUSE packages, it's very likely I will continue to build without 
> > > suffix.
> > > 
> > > Cor
> > >   
> > 
> > Sure, good for you. But not for my use case.  
> 
> It's not exactly great idea to ship differently named metainfo files
> when using autoconf vs cmake.
> Did you have at least investigated the implications of stripping org.lyx.
> prefix in the default case?
> 
> Pavel

I was not planing to strip that part. The propose was an example.
Plan is:
If lyx with cmake is configured with
-DLYX_PROGRAM_SUFFIX:BOOL=ON
the built executables have all a suffix. Only in this case should the rename 
happen.
org.lyx.LyX.metainfo.xml -> org.lyx.LyX2.4.metainfo.xml

In all other cmake-settings no rename is planed.

Kornel


pgpSn8cLFZyuH.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Kornel Benko
Am Fri, 6 Oct 2023 12:30:53 +0200
schrieb Cor Blom :

> Op 06-10-2023 om 12:14 schreef Kornel Benko:
> > Am Fri, 06 Oct 2023 10:53:25 +0100
> > schrieb José Matos :
> >   
> >> On Fri, 2023-10-06 at 11:09 +0200, Kornel Benko wrote:  
> >>> Should we rename this file on install to be able to install multiple
> >>> lyx-versions?
> >>> Like "org.lyx.LyX.metainfo.xml" -> "LyX2.4.metainfo.xml"
> >>> if using versioned suffixes?
> >>>
> >>>   Kornel  
> >>
> >> Using my blue hat here (Fedora). :-)
> >>
> >> Although I am not using cmake (yet!) I prefer to have the simple
> >> version. When I need to take care of another version I prefer to do it
> >> myself.
> >>
> >> Looking into the system directory (/usr/share/metainfo/) I do not see
> >> any versioned file.
> >>
> >> My two ¢.  
> > 
> > I am using lyx2.3 and lyx2.4 in parallel installed. The problem will arise 
> > on
> > installing lyx2.5 later.
> > 
> > Installing without using the suffix should be no problem for you (e.g. no 
> > change)
> > My proposal would rename it to "LyX.metainfo.xml".
> >   
> 
> This conflict is, I believe, also present in autoconf builds. The 
> default there is to build without suffix. If I move to cmake for 
> openSUSE packages, it's very likely I will continue to build without suffix.
> 
> Cor
> 

Sure, good for you. But not for my use case.

Kornel


pgpIySxJJXfN1.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Kornel Benko
Am Fri, 06 Oct 2023 10:53:25 +0100
schrieb José Matos :

> On Fri, 2023-10-06 at 11:09 +0200, Kornel Benko wrote:
> > Should we rename this file on install to be able to install multiple
> > lyx-versions?
> > Like "org.lyx.LyX.metainfo.xml" -> "LyX2.4.metainfo.xml"
> > if using versioned suffixes?
> > 
> > Kornel  
> 
> Using my blue hat here (Fedora). :-)
> 
> Although I am not using cmake (yet!) I prefer to have the simple
> version. When I need to take care of another version I prefer to do it
> myself.
> 
> Looking into the system directory (/usr/share/metainfo/) I do not see
> any versioned file.
> 
> My two ¢.

I am using lyx2.3 and lyx2.4 in parallel installed. The problem will arise on 
installing
lyx2.5 later.

Installing without using the suffix should be no problem for you (e.g. no 
change)
My proposal would rename it to "LyX.metainfo.xml".

Kornel


pgpfJfOZP2p_P.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Kornel Benko
Am Fri, 6 Oct 2023 10:30:14 +0200
schrieb Kornel Benko :

> Am Wed, 4 Oct 2023 10:57:08 +0200
> schrieb Cor Blom :
> 
> > Hi,
> > 
> > autoconf installs org.lyx.LyX.metainfo.xml automatically, but cmake does 
> > not. Intention, mistake, ...?
> > 
> > This is on openSUSE, building rpms using the buildservice.
> > 
> > Thanks,
> > 
> > Cor
> >   
> 
> Mistake. I was not aware of this file.
> 
>   Kornel

Should we rename this file on install to be able to install multiple 
lyx-versions?
Like "org.lyx.LyX.metainfo.xml" -> "LyX2.4.metainfo.xml"
if using versioned suffixes?

Kornel


pgpWTsb_b0uvX.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: metainfo and cmake

2023-10-06 Thread Kornel Benko
Am Wed, 4 Oct 2023 10:57:08 +0200
schrieb Cor Blom :

> Hi,
> 
> autoconf installs org.lyx.LyX.metainfo.xml automatically, but cmake does 
> not. Intention, mistake, ...?
> 
> This is on openSUSE, building rpms using the buildservice.
> 
> Thanks,
> 
> Cor
> 

Mistake. I was not aware of this file.

Kornel


pgp0TZUkmapYE.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: CMake fails on first configure

2023-09-30 Thread Kornel Benko
Am Sat, 30 Sep 2023 09:35:57 +0200
schrieb Yu Jin :

> Am So., 17. Sept. 2023 um 07:24 Uhr schrieb Yu Jin :
> 
> > Am So., 17. Sept. 2023 um 07:23 Uhr schrieb Yu Jin  > >:
> >
> >> When I configure for the first time (into an empty folder) I get this
> >> error:
> >>
> >> CMake Error at
> >> C:/lyx/master-build-64-qt6/CMakeFiles/CMakeScratch/TryCompile-re0snf/CMakeLists.txt:12
> >> (include_directories):
> >>   Error evaluating generator expression:
> >>
> >> $
> >>
> >>   Target "Qt6::ZlibPrivate" not found.
> >>
> >> (full log attached)
> >>
> > Log
> >
> >> If I ignore this error and click configure again it works. Looks like it
> >> only occurs with Qt6.
> >>
> >
> Nobody has an idea?? I found this in the  CMakeConfigureLog.yaml file:
>   -
> kind: "try_compile-v1"
> backtrace:
>   - "C:/Program
> Files/CMake/share/cmake-3.26/Modules/CheckIncludeFileCXX.cmake:94
> (try_compile)"
>   - "development/cmake/ConfigureChecks.cmake:290
> (check_include_file_cxx)"
>   - "CMakeLists.txt:1146 (include)"
> checks:
>   - "Looking for C++ include QtGui/qtgui-config.h"
> directories:
>   source:
> "C:/lyx/master-build-64-qt6/CMakeFiles/CMakeScratch/TryCompile-z4oq2c"
>   binary:
> "C:/lyx/master-build-64-qt6/CMakeFiles/CMakeScratch/TryCompile-z4oq2c"
> cmakeVariables:
>   CMAKE_CXX_FLAGS: "/DWIN32 /D_WINDOWS /W3 /GR /EHsc"
>   CMAKE_MODULE_PATH:
> "C:/lyx/master/development/cmake/modules;C:/Qt/6.5.2/msvc2019_64/lib/cmake/Qt6;C:/Qt/6.5.2/msvc2019_64/lib/cmake/Qt6/3rdparty/extra-cmake-modules/find-modules;C:/Qt/6.5.2/msvc2019_64/lib/cmake/Qt6/3rdparty/kwin"
> buildResult:
>   variable: "HAVE_QTGUI_CONFIG_H"
>   cached: true
>   stdout: |
>   exitCode: 1
> 
> (this is from another configure attempt). Of course the CMakeScratch folder
> is empty.

Where is the "QtGui/qtgui-config.h" located on your system?
Here it is under
/usr/include/x86_64-linux-gnu/qt6/QtGui/qtgui-config.h
The CMAKE_MODULE_PATH looks good (same as here but different system prefix), 
does not
contain "qt6" path.

Kornel 


pgp2AR2Wnxnzi.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Error with Qt 6 and autotools

2023-08-24 Thread Kornel Benko
Am Thu, 24 Aug 2023 13:27:36 +0200
schrieb Cor Blom :

> Op 24-08-2023 om 13:09 schreef Jean-Marc Lasgouttes:
> > Le 24/08/2023 à 09:38, Cor Blom a écrit :  
> >> Op 24-08-2023 om 00:50 schreef Jean-Marc Lasgouttes:  
> >>> Do you have a config.log? The configure mechanism for qt6 now relies 
> >>> on qmake, so there may be quirks.  
> >>
> >> [   22s] run "./configure && make"
> >> [   22s]
> >> [   22s] + TEXMF=/usr/share/texmf
> >> [   22s] + CONFIG_SHELL=/usr/bin/bash
> >> [   22s] + export CONFIG_SHELL  
> > ...
> > 
> > Thanks. There is nothing obviously wrong here.
> > 
> > Can I see src/frontends/qt/Makefile too?
> >   
> 
> See attached. I use a recent git checkout, so it should be the same as 
> the one in the git sources.
> 
> Cor

This is the wrong file. Should be 'Makefile', not 'Makefile.am'.
(To be found in the build-directory after the configuration-run)

Kornel


pgpdvDQpg3T0D.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


  1   2   3   4   5   6   7   8   9   10   >