Re: [LyX/master] Add "Open Containing Directory" button to the log dialog (#9211, #9834)
On Tue, Nov 03, 2015 at 04:14:55PM +, Guillaume Munch wrote: > Le 03/11/2015 16:10, Kornel Benko a écrit : > > > >It is the same, opens with gvim. But in the mean time I learned a new gvim > >command ':Ex[plore]', which > >shows the content of this directory. And one can select files (e.g. click on > >filenames) and open them. > > > >For me it is OK ... > > > > OK. Only thing is that I would be reassured to know that there is indeed > a setting in your system that determines that gvim must be chosen as a > file browser on purpose… Tested on Ubuntu and works as expected. Scott
Re: [LyX/master] Add "Open Containing Directory" button to the log dialog (#9211, #9834)
Am Dienstag, 3. November 2015 um 16:14:55, schrieb Guillaume Munch > Le 03/11/2015 16:10, Kornel Benko a écrit : > > > > It is the same, opens with gvim. But in the mean time I learned a new gvim > > command ':Ex[plore]', which > > shows the content of this directory. And one can select files (e.g. click > > on filenames) and open them. > > > > For me it is OK ... > > > > OK. Only thing is that I would be reassured to know that there is indeed > a setting in your system that determines that gvim must be chosen as a > file browser on purpose… Not that I was aware about. I never used gvim to browse for files. Using dolphin, nautilus, sometimes caja. But I have seen entries in lyxrc.default # egrep -w gvim lyxrc.defaults|wc --> 79 But no one of the entries looks like a directory format. Hm, I now checked the configuration... you are right. Now caja is called. Thanks. > >> > >> Guillaume > > Kornel signature.asc Description: This is a digitally signed message part.
Re: [LyX/master] Add "Open Containing Directory" button to the log dialog (#9211, #9834)
Le 03/11/2015 16:10, Kornel Benko a écrit : It is the same, opens with gvim. But in the mean time I learned a new gvim command ':Ex[plore]', which shows the content of this directory. And one can select files (e.g. click on filenames) and open them. For me it is OK ... OK. Only thing is that I would be reassured to know that there is indeed a setting in your system that determines that gvim must be chosen as a file browser on purpose… Guillaume Kornel Guillaume
Re: [LyX/master] Add "Open Containing Directory" button to the log dialog (#9211, #9834)
Am Dienstag, 3. November 2015 um 15:32:34, schrieb Guillaume Munch > Le 03/11/2015 07:35, Kornel Benko a écrit : > > Am Dienstag, 3. November 2015 um 04:57:45, schrieb Guillaume Munch > > > >> commit f441590c8e0b5e970fbdd656198ec4993dfecb43 > >> Author: Guillaume Munch > >> Date: Mon Nov 2 18:19:40 2015 + > >> > >> Add "Open Containing Directory" button to the log dialog (#9211, > >> #9834) > >> > >> It takes the place of the "Copy to Clipboard" button which was > >> redundant. > >> > > > > The 'Open Containing Directory' button displays an empty window here. > > The displayed path is correct, but the window looks like it belongs to > > 'gvim' (text editor). > > > > Is this really intended? > > > > Please test again at a0783e15. But if the displayed path is really > correct, I am afraid it does not fix it. > > If after that it still opens gvim, there isn't much that can be done on > the programmer's side since Qt is supposed to handle things. It seems > to be the recommended cross-platform method to open a directory. Then it > might be a configuration issue on your side. For instance, what does > "xdg-open " achieve on your system? > It is the same, opens with gvim. But in the mean time I learned a new gvim command ':Ex[plore]', which shows the content of this directory. And one can select files (e.g. click on filenames) and open them. For me it is OK ... > > Guillaume Kornel signature.asc Description: This is a digitally signed message part.
Re: [LyX/master] Add "Open Containing Directory" button to the log dialog (#9211, #9834)
Le 03/11/2015 08:32, Jean-Marc Lasgouttes a écrit : Le 03/11/2015 04:57, Guillaume Munch a écrit : commit f441590c8e0b5e970fbdd656198ec4993dfecb43 Author: Guillaume Munch Date: Mon Nov 2 18:19:40 2015 + Add "Open Containing Directory" button to the log dialog (#9211, #9834) It takes the place of the "Copy to Clipboard" button which was redundant. I get a new warning when compiling: GEN moc_GuiLog.cpp ../../../../master/src/frontends/qt4/ui/LogUi.ui: Warning: Tab-stop assignment: 'copyPB' is not a valid widget. JMarc Thanks, I should have caught that.
Re: [LyX/master] Add "Open Containing Directory" button to the log dialog (#9211, #9834)
Le 03/11/2015 07:35, Kornel Benko a écrit : Am Dienstag, 3. November 2015 um 04:57:45, schrieb Guillaume Munch commit f441590c8e0b5e970fbdd656198ec4993dfecb43 Author: Guillaume Munch Date: Mon Nov 2 18:19:40 2015 + Add "Open Containing Directory" button to the log dialog (#9211, #9834) It takes the place of the "Copy to Clipboard" button which was redundant. The 'Open Containing Directory' button displays an empty window here. The displayed path is correct, but the window looks like it belongs to 'gvim' (text editor). Is this really intended? Please test again at a0783e15. But if the displayed path is really correct, I am afraid it does not fix it. If after that it still opens gvim, there isn't much that can be done on the programmer's side since Qt is supposed to handle things. It seems to be the recommended cross-platform method to open a directory. Then it might be a configuration issue on your side. For instance, what does "xdg-open " achieve on your system? Guillaume
Re: [LyX/master] Add "Open Containing Directory" button to the log dialog (#9211, #9834)
Le 03/11/2015 04:57, Guillaume Munch a écrit : commit f441590c8e0b5e970fbdd656198ec4993dfecb43 Author: Guillaume Munch Date: Mon Nov 2 18:19:40 2015 + Add "Open Containing Directory" button to the log dialog (#9211, #9834) It takes the place of the "Copy to Clipboard" button which was redundant. I get a new warning when compiling: GEN moc_GuiLog.cpp ../../../../master/src/frontends/qt4/ui/LogUi.ui: Warning: Tab-stop assignment: 'copyPB' is not a valid widget. JMarc
