Re: [LyX/master] Introduce NeedCProtect -1 layout option

2024-05-12 Thread Jürgen Spitzmüller
Am Sonntag, dem 12.05.2024 um 19:04 +0200 schrieb Jürgen Spitzmüller:
> the documentation part manually later.

Done now. I have pasted the new English paragraph in a note to those
translated docs that already had the old version translated. 

-- 
Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Introduce NeedCProtect -1 layout option

2024-05-12 Thread Jürgen Spitzmüller
Am Sonntag, dem 12.05.2024 um 12:39 -0400 schrieb Richard Kimberly
Heck:
> Since it's a regression, I think you should go ahead. 

Thanks, I pulled the two code commits and do the documentation part
manually later.

> I assume it is otherwise safe?

Yes.

-- 
Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Introduce NeedCProtect -1 layout option

2024-05-12 Thread Richard Kimberly Heck

On 5/12/24 02:11, Jürgen Spitzmüller wrote:

Am Sonntag, dem 12.05.2024 um 05:53 + schrieb Juergen Spitzmueller:

commit 207eaeee9071cb828a2ab7f4680f8ff92e379af8
Author: Juergen Spitzmueller 
Date:   Sun May 12 07:52:16 2024 +0200

     Introduce NeedCProtect -1 layout option
 
     It turns out beamer frame does not allow \cprotect and errors if

it is     used. Hence we need to prevent it in this context entirely.

Riki, I am tempted to propose this for 2.4.0, although we are very late
in the game and this introduces a slight documentation addition.

The problem this fixes is that beamer frame errors if \cprotect is used
within. This can happen if you have an URL with an underscore or some
other special character within a command (e.g., \alert or \structure)
within a frame (see attached MWE). This is not an exceptional scenario
and I am surprised that I only encountered it yesterday with a
presentation that works with 2.3.x. :-(


Since it's a regression, I think you should go ahead. I assume it is 
otherwise safe?


Note that you'll need to commit to 2.4.x and master separately.

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Introduce NeedCProtect -1 layout option

2024-05-12 Thread Jürgen Spitzmüller
Am Sonntag, dem 12.05.2024 um 05:53 + schrieb Juergen Spitzmueller:
> commit 207eaeee9071cb828a2ab7f4680f8ff92e379af8
> Author: Juergen Spitzmueller 
> Date:   Sun May 12 07:52:16 2024 +0200
> 
>     Introduce NeedCProtect -1 layout option
>     
>     It turns out beamer frame does not allow \cprotect and errors if
> it is
>     used. Hence we need to prevent it in this context entirely.

Riki, I am tempted to propose this for 2.4.0, although we are very late
in the game and this introduces a slight documentation addition.

The problem this fixes is that beamer frame errors if \cprotect is used
within. This can happen if you have an URL with an underscore or some
other special character within a command (e.g., \alert or \structure)
within a frame (see attached MWE). This is not an exceptional scenario
and I am surprised that I only encountered it yesterday with a
presentation that works with 2.3.x. :-(

If you think this is too late for 2.4.0 it should go into 2.4.1. (or I
put in the thing as a hidden feature in 2.4.0 and add the documentation
for 2.4.1).

-- 
Jürgen


MWE.lyx
Description: application/lyx
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel