Re: [PATCH-updated] Paragraph Setting UI Bugs
Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. I prefer one click in this case. This particular dialog isn't that big, and the usual reason I bring it up is to change the alignment . . . Helge Hafting
Re: [PATCH-updated] Paragraph Setting UI Bugs
Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. I prefer one click in this case. This particular dialog isn't that big, and the usual reason I bring it up is to change the alignment . . . Helge Hafting
Re: [PATCH-updated] Paragraph Setting UI Bugs
Richard Heck wrote: I've committed this now, with a reference to this discussion. Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? Jürgen
Re: [PATCH-updated] Paragraph Setting UI Bugs
Jürgen Spitzmüller wrote: Richard Heck wrote: I've committed this now, with a reference to this discussion. Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2?
Re: [PATCH-updated] Paragraph Setting UI Bugs
Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. Jürgen
Re: [PATCH-updated] Paragraph Setting UI Bugs
Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. the current dialog is ugly as hell. the solution i proposed not only makes sense, it *also* looks better ;-) inline: par.png
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Sat, Jun 23, 2007 at 09:38:05AM +0200, Jürgen Spitzmüller wrote: Richard Heck wrote: I've committed this now, with a reference to this discussion. Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? If the room is there, radiobuttons are easier to use than comboboxes. Andre'
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Sat, Jun 23, 2007 at 10:40:59AM +0200, Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. I have. 1 is better. Andre'
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Sat, Jun 23, 2007 at 11:21:03AM +0200, Edwin Leuven wrote: Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. the current dialog is ugly as hell. the solution i proposed not only makes sense, it *also* looks better ;-) Would be fine with me., Andre'
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Saturday 23 June 2007 10:32:07 Andre Poenitz wrote: If the room is there, radiobuttons are easier to use than comboboxes. Andre' I agree. -- José Abílio
Re: [PATCH-updated] Paragraph Setting UI Bugs
Edwin Leuven wrote: Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? Another reason is that you can see at a glance what the permissible alignments are. Yet another is that enabling and disabling combobox entries is a total pain. You can't do it straightforwardly, so you have to have a lot of code to manage this. It's doable---but when I did it, people hated it. the solution i proposed not only makes sense, But what do you propose to do about Jurgen's worry? namely, that nothing counts as default when you have a multi-paragraph selection? I presume you can find out whether you have one via some addition to the controller, and in that case could forego the Default designation. But then you lose the opportunity to reset a bunch of paragraphs to Default all at once. That's a reason other than it makes sense in LaTeX, which I think means a lot to some power users (Helge and Joost, again). And I can see using this facility with child docs I'm including in multiple master docs: I want it centered, period, whatever I'm including it in. it *also* looks better ;-) Sure, but that can be done independently. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto inline: snap12.png
Re: [PATCH-updated] Paragraph Setting UI Bugs
Richard Heck wrote: > I've committed this now, with a reference to this discussion. Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? Jürgen
Re: [PATCH-updated] Paragraph Setting UI Bugs
Jürgen Spitzmüller wrote: Richard Heck wrote: I've committed this now, with a reference to this discussion. Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2?
Re: [PATCH-updated] Paragraph Setting UI Bugs
Edwin Leuven wrote: > > Could you remind me again about the reason why we use 5 radio buttons now > > instead of a combobox? > > 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. Jürgen
Re: [PATCH-updated] Paragraph Setting UI Bugs
Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? 1 click instead of 2? I'd prefer two clicks over the waste of space. But I have no strong opinion on this. the current dialog is ugly as hell. the solution i proposed not only makes sense, it *also* looks better ;-) <>
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Sat, Jun 23, 2007 at 09:38:05AM +0200, Jürgen Spitzmüller wrote: > Richard Heck wrote: > > I've committed this now, with a reference to this discussion. > > Could you remind me again about the reason why we use 5 radio buttons now > instead of a combobox? If the room is there, radiobuttons are easier to use than comboboxes. Andre'
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Sat, Jun 23, 2007 at 10:40:59AM +0200, Jürgen Spitzmüller wrote: > Edwin Leuven wrote: > > > Could you remind me again about the reason why we use 5 radio > > > buttons now instead of a combobox? > > > > 1 click instead of 2? > > I'd prefer two clicks over the waste of space. But I have no strong > opinion on this. I have. 1 is better. Andre'
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Sat, Jun 23, 2007 at 11:21:03AM +0200, Edwin Leuven wrote: > Jürgen Spitzmüller wrote: > >Edwin Leuven wrote: > >>>Could you remind me again about the reason why we use 5 radio buttons now > >>>instead of a combobox? > >>1 click instead of 2? > > > >I'd prefer two clicks over the waste of space. But I have no strong > >opinion on this. > > the current dialog is ugly as hell. > > the solution i proposed not only makes sense, it *also* looks better ;-) Would be fine with me., Andre'
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Saturday 23 June 2007 10:32:07 Andre Poenitz wrote: > If the room is there, radiobuttons are easier to use than comboboxes. > > Andre' I agree. -- José Abílio
Re: [PATCH-updated] Paragraph Setting UI Bugs
Edwin Leuven wrote: Jürgen Spitzmüller wrote: Edwin Leuven wrote: Could you remind me again about the reason why we use 5 radio buttons now instead of a combobox? Another reason is that you can see at a glance what the permissible alignments are. Yet another is that enabling and disabling combobox entries is a total pain. You can't do it straightforwardly, so you have to have a lot of code to manage this. It's doable---but when I did it, people hated it. the solution i proposed not only makes sense, But what do you propose to do about Jurgen's worry? namely, that nothing counts as default when you have a multi-paragraph selection? I presume you can find out whether you have one via some addition to the controller, and in that case could forego the "Default" designation. But then you lose the opportunity to reset a bunch of paragraphs to Default all at once. That's a reason other than "it makes sense in LaTeX", which I think means a lot to some power users (Helge and Joost, again). And I can see using this facility with child docs I'm including in multiple master docs: I want it centered, period, whatever I'm including it in. it *also* looks better ;-) Sure, but that can be done independently. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto <>
Re: [PATCH-updated] Paragraph Setting UI Bugs
José Matos wrote: OK. I think that the subject is important and I liked the discussion there, now let us move to other (critical) bugs. :-) Since I have to decide I opt for Richard's argument without any demerit for Edwin patch/solution. let me guess, you tossed a coin...?
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Friday 22 June 2007 17:59:21 Richard Heck wrote: José Matos wrote: On Friday 22 June 2007 17:42:34 Edwin Leuven wrote: did you have a look at this one? I had both under my radar. :-) What are the (minor) differences between both patches? Edwin's patch attempts to treat the alignment that happens to be the default (say, Justified) differently from the rest, by adding (Default) after it and doing away with a special Default button. There are two problems with this, I think. Quoting from the previous OK. I think that the subject is important and I liked the discussion there, now let us move to other (critical) bugs. :-) Since I have to decide I opt for Richard's argument without any demerit for Edwin patch/solution. -- José Abílio
[PATCH-updated] Paragraph Setting UI Bugs
This patch addresses the usability bugs discussed in this thread:
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg121160.html
and largely implements Helge's suggestions. (Helge often seems to have
good ideas on these things.) The main change is that the Default
button is now a radio button like the rest, so you don't have to uncheck
Default to be allowed to check something else.
The layout that happens to be the default isn't treated specially at
all. The idea here is that saying, Align this as default, whatever that
is is different from saying Center this, come what may, even if, in
the current layout, centering happens to be the default. This seems the
right behavior, as the option certainly exists in LaTeX. At the moment,
however, LyX itself ignores this difference: if you choose Left, and
that is the default, it's effectively the same as choosing Default,
due to a bug in Text::setParagraph(). That will be fixed at a later
stage. It may involve more than should be done prior to 1.5.0, and I
don't have the time right now, anyway.
As Jurgen also pointed out, trying to treat what is in fact the default
alignment differently runs into problems with multi-paragraph
selections, since there may be no common default in such cases. But the
more compelling reason, I think, is the one just given, which was due to
Helge.
OK to apply?
Richard
--
==
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
Index: src/frontends/qt4/QParagraph.cpp
===
--- src/frontends/qt4/QParagraph.cpp (revision 18853)
+++ src/frontends/qt4/QParagraph.cpp (working copy)
@@ -50,7 +50,7 @@
connect(applyPB, SIGNAL(clicked()), form_, SLOT(slotApply()));
connect(closePB, SIGNAL(clicked()), form_, SLOT(slotClose()));
connect(restorePB, SIGNAL(clicked()), form_, SLOT(slotRestore()));
- connect(alignDefaultCB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
+ connect(alignDefaultRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignJustRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignLeftRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignRightRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
@@ -77,10 +77,17 @@
items is used.
));
- radioMap[LYX_ALIGN_BLOCK] = alignJustRB;
- radioMap[LYX_ALIGN_LEFT] = alignLeftRB;
- radioMap[LYX_ALIGN_RIGHT] = alignRightRB;
+ radioMap[LYX_ALIGN_LAYOUT] = alignDefaultRB;
+ radioMap[LYX_ALIGN_BLOCK] = alignJustRB;
+ radioMap[LYX_ALIGN_LEFT] = alignLeftRB;
+ radioMap[LYX_ALIGN_RIGHT] = alignRightRB;
radioMap[LYX_ALIGN_CENTER] = alignCenterRB;
+
+/* labelMap[LYX_ALIGN_LAYOUT] = Default;
+ labelMap[LYX_ALIGN_BLOCK] = Justified;
+ labelMap[LYX_ALIGN_LEFT] = Left;
+ labelMap[LYX_ALIGN_RIGHT] = Right;
+ labelMap[LYX_ALIGN_CENTER] = Center; */
}
@@ -105,35 +112,37 @@
void QParagraphDialog::checkAlignmentRadioButtons() {
- if (alignDefaultCB-isChecked()) {
- QPRadioMap::const_iterator it = radioMap.begin();
- for (; it != radioMap.end(); ++it)
- it-second-setDisabled(true);
- } else {
- LyXAlignment alignPossible = form_-controller().alignPossible();
- QPRadioMap::const_iterator it = radioMap.begin();
- for (; it != radioMap.end(); ++it)
- it-second-setEnabled(it-first alignPossible);
+ LyXAlignment const alignPossible = form_-controller().alignPossible();
+ //LyXAlignment const defaultAlignment = form_-controller().alignDefault();
+ QPRadioMap::iterator it = radioMap.begin();
+ for (; it != radioMap.end(); ++it) {
+ LyXAlignment const align = it-first;
+ it-second-setEnabled((align alignPossible) ||
+ (align == LYX_ALIGN_LAYOUT));
+/* string label = labelMap[align];
+ if (align == LYX_ALIGN_LAYOUT)
+ label += () + labelMap[defaultAlignment] + );
+ it-second-setText(qt_(label));*/
}
}
-void QParagraphDialog::on_alignDefaultCB_toggled(bool)
-{
- checkAlignmentRadioButtons();
- alignmentToRadioButtons();
-}
-
-
void QParagraphDialog::alignmentToRadioButtons(LyXAlignment align)
{
- if (align == LYX_ALIGN_LAYOUT)
- align = form_-controller().alignDefault();
+ LyXAlignment const defaultAlignment = form_-controller().alignDefault();
+ if (align == LYX_ALIGN_LAYOUT || align == defaultAlignment) {
+ alignDefaultRB-blockSignals(true);
+ alignDefaultRB-setChecked(true);
+ alignDefaultRB-blockSignals(false);
+ return;
+ }
QPRadioMap::const_iterator it = radioMap.begin();
for (;it != radioMap.end(); ++it) {
if (align == it-first) {
+ it-second-blockSignals(true);
it-second-setChecked(true);
+ it-second-blockSignals(false);
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Friday 22 June 2007 17:28:06 Richard Heck wrote: OK to apply? OK. Richard -- José Abílio
Re: [PATCH-updated] Paragraph Setting UI Bugs
José Matos wrote:
On Friday 22 June 2007 17:28:06 Richard Heck wrote:
OK to apply?
did you have a look at this one?
Index: src/frontends/qt4/QParagraph.cpp
===
--- src/frontends/qt4/QParagraph.cpp (revision 18850)
+++ src/frontends/qt4/QParagraph.cpp (working copy)
@@ -50,7 +50,6 @@
connect(applyPB, SIGNAL(clicked()), form_, SLOT(slotApply()));
connect(closePB, SIGNAL(clicked()), form_, SLOT(slotClose()));
connect(restorePB, SIGNAL(clicked()), form_, SLOT(slotRestore()));
- connect(alignDefaultCB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignJustRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignLeftRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignRightRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
@@ -77,9 +76,9 @@
items is used.
));
- radioMap[LYX_ALIGN_BLOCK] = alignJustRB;
- radioMap[LYX_ALIGN_LEFT] = alignLeftRB;
- radioMap[LYX_ALIGN_RIGHT] = alignRightRB;
+ radioMap[LYX_ALIGN_BLOCK] = alignJustRB;
+ radioMap[LYX_ALIGN_LEFT] = alignLeftRB;
+ radioMap[LYX_ALIGN_RIGHT] = alignRightRB;
radioMap[LYX_ALIGN_CENTER] = alignCenterRB;
}
@@ -105,35 +104,44 @@
void QParagraphDialog::checkAlignmentRadioButtons() {
- if (alignDefaultCB-isChecked()) {
- QPRadioMap::const_iterator it = radioMap.begin();
- for (; it != radioMap.end(); ++it)
- it-second-setDisabled(true);
- } else {
- LyXAlignment alignPossible = form_-controller().alignPossible();
- QPRadioMap::const_iterator it = radioMap.begin();
- for (; it != radioMap.end(); ++it)
- it-second-setEnabled(it-first alignPossible);
+ LyXAlignment const alignPossible = form_-controller().alignPossible();
+ LyXAlignment const defaultAlignment = form_-controller().alignDefault();
+ QPRadioMap::iterator it = radioMap.begin();
+ for (; it != radioMap.end(); ++it) {
+ it-second-setEnabled((it-first alignPossible) ||
+ (it-first == LYX_ALIGN_LAYOUT));
+ string label;
+ switch (it-first) {
+ case LYX_ALIGN_BLOCK:
+label = Justified;
+break;
+ case LYX_ALIGN_LEFT:
+label = Left;
+break;
+ case LYX_ALIGN_CENTER:
+label = Center;
+break;
+ case LYX_ALIGN_RIGHT:
+label = Right;
+break;
+ }
+
+ if (it-first == defaultAlignment)
+ label += (Default);
+
+ it-second-setText(qt_(label));
}
}
-void QParagraphDialog::on_alignDefaultCB_toggled(bool)
-{
- checkAlignmentRadioButtons();
- alignmentToRadioButtons();
-}
-
-
void QParagraphDialog::alignmentToRadioButtons(LyXAlignment align)
{
- if (align == LYX_ALIGN_LAYOUT)
- align = form_-controller().alignDefault();
-
QPRadioMap::const_iterator it = radioMap.begin();
for (;it != radioMap.end(); ++it) {
if (align == it-first) {
+ it-second-blockSignals(true);
it-second-setChecked(true);
+ it-second-blockSignals(false);
return;
}
}
@@ -145,18 +153,18 @@
LyXAlignment QParagraphDialog::getAlignmentFromDialog()
{
- if (alignDefaultCB-isChecked())
- return LYX_ALIGN_LAYOUT;
+ LyXAlignment const defaultAlignment = form_-controller().alignDefault();
LyXAlignment alignment = LYX_ALIGN_NONE;
QPRadioMap::const_iterator it = radioMap.begin();
for (; it != radioMap.end(); ++it) {
if (it-second-isChecked()) {
- alignment = it-first;
+ if (it-first == defaultAlignment)
+alignment = LYX_ALIGN_LAYOUT;
+ else
+alignment = it-first;
break;
}
}
- if (alignment == form_-controller().alignDefault())
- return LYX_ALIGN_LAYOUT;
return alignment;
}
@@ -243,15 +251,8 @@
}
// alignment
- LyXAlignment newAlignment = params.align();
- LyXAlignment defaultAlignment = controller().alignDefault();
- bool alignmentIsDefault =
- newAlignment == LYX_ALIGN_LAYOUT || newAlignment == defaultAlignment;
- dialog_-alignDefaultCB-blockSignals(true);
- dialog_-alignDefaultCB-setChecked(alignmentIsDefault);
- dialog_-alignDefaultCB-blockSignals(false);
dialog_-checkAlignmentRadioButtons();
- dialog_-alignmentToRadioButtons(newAlignment);
+ dialog_-alignmentToRadioButtons(params.align());
//indentation
bool const canindent = controller().canIndent();
Index: src/frontends/qt4/QParagraph.h
===
--- src/frontends/qt4/QParagraph.h (revision 18850)
+++ src/frontends/qt4/QParagraph.h (working copy)
@@ -49,8 +49,6 @@
void change_adaptor();
///
void enableLinespacingValue(int);
- ///
- void on_alignDefaultCB_toggled(bool);
};
Index: src/frontends/qt4/ui/ParagraphUi.ui
===
--- src/frontends/qt4/ui/ParagraphUi.ui (revision 18850)
+++ src/frontends/qt4/ui/ParagraphUi.ui (working copy)
@@ -8,8 +8,8 @@
rect
x0/x
y0/y
-width373/width
-height203/height
+width346/width
+height226/height
/rect
/property
property name=sizePolicy
@@ -36,76 +36,14 @@
property name=spacing
Re: [PATCH-updated] Paragraph Setting UI Bugs
José Matos wrote: On Friday 22 June 2007 17:42:34 Edwin Leuven wrote: did you have a look at this one? I had both under my radar. :-) What are the (minor) differences between both patches? Edwin's patch attempts to treat the alignment that happens to be the default (say, Justified) differently from the rest, by adding (Default) after it and doing away with a special Default button. There are two problems with this, I think. Quoting from the previous message: [In my patch] The layout that happens to be the default isn't treated specially at all. The idea here is that saying, Align this as default, whatever that is is different from saying Center this, come what may, even if, in the current layout, centering happens to be the default. This seems the right behavior, as the option certainly exists in LaTeX. At the moment, however, LyX itself ignores this difference: if you choose Left, and that is the default, it's effectively the same as choosing Default, due to a bug in Text::setParagraph(). That will be fixed at a later stage. It may involve more than should be done prior to 1.5.0, and I don't have the time right now, anyway. Second: As Jurgen also pointed out, trying to treat what is in fact the default alignment differently runs into problems with multi-paragraph selections, since there may be no common default in such cases. This could presumably be handled, but you'd need to modify the controller so that it would report whether we have a multi-paragraph selection. And, in any event, the best reason is the first., which was first raised by Helge and has since been endorsed by Joost, Jurgen, and (I think) Alfredo. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Friday 22 June 2007 17:42:34 Edwin Leuven wrote: did you have a look at this one? I had both under my radar. :-) What are the (minor) differences between both patches? -- José Abílio
Re: [PATCH-updated] Paragraph Setting UI Bugs
Richard Heck wrote: What are the (minor) differences between both patches? there is a long thread on this but to summarize: the question is whether we want a separate default button for the rare situations in which we (1) change document layouts and (2) run into: 1 x is set and we change the default to x: 2 x (default) is set and the default changes: x in (just/left/center/right) ... i think adding ui for this is not necessary. the dialog would look as in attached. i makes explicit the default (and therefore allows to reset to the default) one needs to give it a serious try to figure out whether richards is to be preferred inline: par.png
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Friday 22 June 2007 18:21:52 Edwin Leuven wrote: let me guess, you tossed a coin...? Not on Fridays. :-) In case it matters both solutions are better than what we have now, and I am closer from Richard's reasoning in this case. Also after some time if no consensus is reached it is better to decide and move on. -- José Abílio
Re: [PATCH-updated] Paragraph Setting UI Bugs
José Matos wrote: On Friday 22 June 2007 18:21:52 Edwin Leuven wrote: let me guess, you tossed a coin...? Not on Fridays. :-) observational equivalent though... In case it matters both solutions are better than what we have now, sure and I am closer from Richard's reasoning in this case. i think this needs another thought, but it doesn't really matter since we can always change this later... Also after some time if no consensus is reached it is better to decide and move on. suffice to say that i disagree ...
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Fri, Jun 22, 2007 at 07:21:52PM +0200, Edwin Leuven wrote: José Matos wrote: OK. I think that the subject is important and I liked the discussion there, now let us move to other (critical) bugs. :-) Since I have to decide I opt for Richard's argument without any demerit for Edwin patch/solution. let me guess, you tossed a coin...? Even tossing coins makes sense from time to time. Andre'
Re: [PATCH-updated] Paragraph Setting UI Bugs
I've committed this now, with a reference to this discussion. Richard Richard Heck wrote: José Matos wrote: On Friday 22 June 2007 17:42:34 Edwin Leuven wrote: did you have a look at this one? I had both under my radar. :-) What are the (minor) differences between both patches? Edwin's patch attempts to treat the alignment that happens to be the default (say, Justified) differently from the rest, by adding (Default) after it and doing away with a special Default button. There are two problems with this, I think. Quoting from the previous message: [In my patch] The layout that happens to be the default isn't treated specially at all. The idea here is that saying, Align this as default, whatever that is is different from saying Center this, come what may, even if, in the current layout, centering happens to be the default. This seems the right behavior, as the option certainly exists in LaTeX. At the moment, however, LyX itself ignores this difference: if you choose Left, and that is the default, it's effectively the same as choosing Default, due to a bug in Text::setParagraph(). That will be fixed at a later stage. It may involve more than should be done prior to 1.5.0, and I don't have the time right now, anyway. Second: As Jurgen also pointed out, trying to treat what is in fact the default alignment differently runs into problems with multi-paragraph selections, since there may be no common default in such cases. This could presumably be handled, but you'd need to modify the controller so that it would report whether we have a multi-paragraph selection. And, in any event, the best reason is the first., which was first raised by Helge and has since been endorsed by Joost, Jurgen, and (I think) Alfredo. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
Re: [PATCH-updated] Paragraph Setting UI Bugs
José Matos wrote: OK. I think that the subject is important and I liked the discussion there, now let us move to other (critical) bugs. :-) Since I have to decide I opt for Richard's argument without any demerit for Edwin patch/solution. let me guess, you tossed a coin...?
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Friday 22 June 2007 17:59:21 Richard Heck wrote: > José Matos wrote: > > On Friday 22 June 2007 17:42:34 Edwin Leuven wrote: > >> did you have a look at this one? > > > > I had both under my radar. :-) > > > > What are the (minor) differences between both patches? > > Edwin's patch attempts to treat the alignment that happens to be the > default (say, Justified) differently from the rest, by adding > "(Default)" after it and doing away with a special "Default" button. > There are two problems with this, I think. Quoting from the previous OK. I think that the subject is important and I liked the discussion there, now let us move to other (critical) bugs. :-) Since I have to decide I opt for Richard's argument without any demerit for Edwin patch/solution. -- José Abílio
[PATCH-updated] Paragraph Setting UI Bugs
This patch addresses the usability bugs discussed in this thread:
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg121160.html
and largely implements Helge's suggestions. (Helge often seems to have
good ideas on these things.) The main change is that the "Default"
button is now a radio button like the rest, so you don't have to uncheck
Default to be allowed to check something else.
The layout that happens to be the default isn't treated specially at
all. The idea here is that saying, "Align this as default, whatever that
is" is different from saying "Center this, come what may", even if, in
the current layout, centering happens to be the default. This seems the
right behavior, as the option certainly exists in LaTeX. At the moment,
however, LyX itself ignores this difference: if you choose "Left", and
that is the default, it's effectively the same as choosing "Default",
due to a bug in Text::setParagraph(). That will be fixed at a later
stage. It may involve more than should be done prior to 1.5.0, and I
don't have the time right now, anyway.
As J"urgen also pointed out, trying to treat what is in fact the default
alignment differently runs into problems with multi-paragraph
selections, since there may be no common default in such cases. But the
more compelling reason, I think, is the one just given, which was due to
Helge.
OK to apply?
Richard
--
==
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
Index: src/frontends/qt4/QParagraph.cpp
===
--- src/frontends/qt4/QParagraph.cpp (revision 18853)
+++ src/frontends/qt4/QParagraph.cpp (working copy)
@@ -50,7 +50,7 @@
connect(applyPB, SIGNAL(clicked()), form_, SLOT(slotApply()));
connect(closePB, SIGNAL(clicked()), form_, SLOT(slotClose()));
connect(restorePB, SIGNAL(clicked()), form_, SLOT(slotRestore()));
- connect(alignDefaultCB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
+ connect(alignDefaultRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignJustRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignLeftRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignRightRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
@@ -77,10 +77,17 @@
" items is used."
));
- radioMap[LYX_ALIGN_BLOCK] = alignJustRB;
- radioMap[LYX_ALIGN_LEFT] = alignLeftRB;
- radioMap[LYX_ALIGN_RIGHT] = alignRightRB;
+ radioMap[LYX_ALIGN_LAYOUT] = alignDefaultRB;
+ radioMap[LYX_ALIGN_BLOCK] = alignJustRB;
+ radioMap[LYX_ALIGN_LEFT] = alignLeftRB;
+ radioMap[LYX_ALIGN_RIGHT] = alignRightRB;
radioMap[LYX_ALIGN_CENTER] = alignCenterRB;
+
+/* labelMap[LYX_ALIGN_LAYOUT] = "Default";
+ labelMap[LYX_ALIGN_BLOCK] = "Justified";
+ labelMap[LYX_ALIGN_LEFT] = "Left";
+ labelMap[LYX_ALIGN_RIGHT] = "Right";
+ labelMap[LYX_ALIGN_CENTER] = "Center"; */
}
@@ -105,35 +112,37 @@
void QParagraphDialog::checkAlignmentRadioButtons() {
- if (alignDefaultCB->isChecked()) {
- QPRadioMap::const_iterator it = radioMap.begin();
- for (; it != radioMap.end(); ++it)
- it->second->setDisabled(true);
- } else {
- LyXAlignment alignPossible = form_->controller().alignPossible();
- QPRadioMap::const_iterator it = radioMap.begin();
- for (; it != radioMap.end(); ++it)
- it->second->setEnabled(it->first & alignPossible);
+ LyXAlignment const alignPossible = form_->controller().alignPossible();
+ //LyXAlignment const defaultAlignment = form_->controller().alignDefault();
+ QPRadioMap::iterator it = radioMap.begin();
+ for (; it != radioMap.end(); ++it) {
+ LyXAlignment const align = it->first;
+ it->second->setEnabled((align & alignPossible) ||
+ (align == LYX_ALIGN_LAYOUT));
+/* string label = labelMap[align];
+ if (align == LYX_ALIGN_LAYOUT)
+ label += "()" + labelMap[defaultAlignment] + ")";
+ it->second->setText(qt_(label));*/
}
}
-void QParagraphDialog::on_alignDefaultCB_toggled(bool)
-{
- checkAlignmentRadioButtons();
- alignmentToRadioButtons();
-}
-
-
void QParagraphDialog::alignmentToRadioButtons(LyXAlignment align)
{
- if (align == LYX_ALIGN_LAYOUT)
- align = form_->controller().alignDefault();
+ LyXAlignment const defaultAlignment = form_->controller().alignDefault();
+ if (align == LYX_ALIGN_LAYOUT || align == defaultAlignment) {
+ alignDefaultRB->blockSignals(true);
+ alignDefaultRB->setChecked(true);
+ alignDefaultRB->blockSignals(false);
+ return;
+ }
QPRadioMap::const_iterator it = radioMap.begin();
for (;it != radioMap.end(); ++it) {
if (align == it->first) {
+ it->second->blockSignals(true);
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Friday 22 June 2007 17:28:06 Richard Heck wrote: > OK to apply? OK. > Richard -- José Abílio
Re: [PATCH-updated] Paragraph Setting UI Bugs
José Matos wrote:
On Friday 22 June 2007 17:28:06 Richard Heck wrote:
OK to apply?
did you have a look at this one?
Index: src/frontends/qt4/QParagraph.cpp
===
--- src/frontends/qt4/QParagraph.cpp (revision 18850)
+++ src/frontends/qt4/QParagraph.cpp (working copy)
@@ -50,7 +50,6 @@
connect(applyPB, SIGNAL(clicked()), form_, SLOT(slotApply()));
connect(closePB, SIGNAL(clicked()), form_, SLOT(slotClose()));
connect(restorePB, SIGNAL(clicked()), form_, SLOT(slotRestore()));
- connect(alignDefaultCB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignJustRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignLeftRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
connect(alignRightRB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
@@ -77,9 +76,9 @@
" items is used."
));
- radioMap[LYX_ALIGN_BLOCK] = alignJustRB;
- radioMap[LYX_ALIGN_LEFT] = alignLeftRB;
- radioMap[LYX_ALIGN_RIGHT] = alignRightRB;
+ radioMap[LYX_ALIGN_BLOCK] = alignJustRB;
+ radioMap[LYX_ALIGN_LEFT] = alignLeftRB;
+ radioMap[LYX_ALIGN_RIGHT] = alignRightRB;
radioMap[LYX_ALIGN_CENTER] = alignCenterRB;
}
@@ -105,35 +104,44 @@
void QParagraphDialog::checkAlignmentRadioButtons() {
- if (alignDefaultCB->isChecked()) {
- QPRadioMap::const_iterator it = radioMap.begin();
- for (; it != radioMap.end(); ++it)
- it->second->setDisabled(true);
- } else {
- LyXAlignment alignPossible = form_->controller().alignPossible();
- QPRadioMap::const_iterator it = radioMap.begin();
- for (; it != radioMap.end(); ++it)
- it->second->setEnabled(it->first & alignPossible);
+ LyXAlignment const alignPossible = form_->controller().alignPossible();
+ LyXAlignment const defaultAlignment = form_->controller().alignDefault();
+ QPRadioMap::iterator it = radioMap.begin();
+ for (; it != radioMap.end(); ++it) {
+ it->second->setEnabled((it->first & alignPossible) ||
+ (it->first == LYX_ALIGN_LAYOUT));
+ string label;
+ switch (it->first) {
+ case LYX_ALIGN_BLOCK:
+label = "Justified";
+break;
+ case LYX_ALIGN_LEFT:
+label = "Left";
+break;
+ case LYX_ALIGN_CENTER:
+label = "Center";
+break;
+ case LYX_ALIGN_RIGHT:
+label = "Right";
+break;
+ }
+
+ if (it->first == defaultAlignment)
+ label += " (Default)";
+
+ it->second->setText(qt_(label));
}
}
-void QParagraphDialog::on_alignDefaultCB_toggled(bool)
-{
- checkAlignmentRadioButtons();
- alignmentToRadioButtons();
-}
-
-
void QParagraphDialog::alignmentToRadioButtons(LyXAlignment align)
{
- if (align == LYX_ALIGN_LAYOUT)
- align = form_->controller().alignDefault();
-
QPRadioMap::const_iterator it = radioMap.begin();
for (;it != radioMap.end(); ++it) {
if (align == it->first) {
+ it->second->blockSignals(true);
it->second->setChecked(true);
+ it->second->blockSignals(false);
return;
}
}
@@ -145,18 +153,18 @@
LyXAlignment QParagraphDialog::getAlignmentFromDialog()
{
- if (alignDefaultCB->isChecked())
- return LYX_ALIGN_LAYOUT;
+ LyXAlignment const defaultAlignment = form_->controller().alignDefault();
LyXAlignment alignment = LYX_ALIGN_NONE;
QPRadioMap::const_iterator it = radioMap.begin();
for (; it != radioMap.end(); ++it) {
if (it->second->isChecked()) {
- alignment = it->first;
+ if (it->first == defaultAlignment)
+alignment = LYX_ALIGN_LAYOUT;
+ else
+alignment = it->first;
break;
}
}
- if (alignment == form_->controller().alignDefault())
- return LYX_ALIGN_LAYOUT;
return alignment;
}
@@ -243,15 +251,8 @@
}
// alignment
- LyXAlignment newAlignment = params.align();
- LyXAlignment defaultAlignment = controller().alignDefault();
- bool alignmentIsDefault =
- newAlignment == LYX_ALIGN_LAYOUT || newAlignment == defaultAlignment;
- dialog_->alignDefaultCB->blockSignals(true);
- dialog_->alignDefaultCB->setChecked(alignmentIsDefault);
- dialog_->alignDefaultCB->blockSignals(false);
dialog_->checkAlignmentRadioButtons();
- dialog_->alignmentToRadioButtons(newAlignment);
+ dialog_->alignmentToRadioButtons(params.align());
//indentation
bool const canindent = controller().canIndent();
Index: src/frontends/qt4/QParagraph.h
===
--- src/frontends/qt4/QParagraph.h (revision 18850)
+++ src/frontends/qt4/QParagraph.h (working copy)
@@ -49,8 +49,6 @@
void change_adaptor();
///
void enableLinespacingValue(int);
- ///
- void on_alignDefaultCB_toggled(bool);
};
Index: src/frontends/qt4/ui/ParagraphUi.ui
===
--- src/frontends/qt4/ui/ParagraphUi.ui (revision 18850)
+++ src/frontends/qt4/ui/ParagraphUi.ui (working copy)
@@ -8,8 +8,8 @@
0
0
-373
-203
+346
+226
@@ -36,76 +36,14 @@
6
-
-
-
- 0
+
+
+
+ Indent
Re: [PATCH-updated] Paragraph Setting UI Bugs
José Matos wrote: On Friday 22 June 2007 17:42:34 Edwin Leuven wrote: did you have a look at this one? I had both under my radar. :-) What are the (minor) differences between both patches? Edwin's patch attempts to treat the alignment that happens to be the default (say, Justified) differently from the rest, by adding "(Default)" after it and doing away with a special "Default" button. There are two problems with this, I think. Quoting from the previous message: [In my patch] The layout that happens to be the default isn't treated specially at all. The idea here is that saying, "Align this as default, whatever that is" is different from saying "Center this, come what may", even if, in the current layout, centering happens to be the default. This seems the right behavior, as the option certainly exists in LaTeX. At the moment, however, LyX itself ignores this difference: if you choose "Left", and that is the default, it's effectively the same as choosing "Default", due to a bug in Text::setParagraph(). That will be fixed at a later stage. It may involve more than should be done prior to 1.5.0, and I don't have the time right now, anyway. Second: As J"urgen also pointed out, trying to treat what is in fact the default alignment differently runs into problems with multi-paragraph selections, since there may be no common default in such cases. This could presumably be handled, but you'd need to modify the controller so that it would report whether we have a multi-paragraph selection. And, in any event, the best reason is the first., which was first raised by Helge and has since been endorsed by Joost, J"urgen, and (I think) Alfredo. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Friday 22 June 2007 17:42:34 Edwin Leuven wrote: > did you have a look at this one? I had both under my radar. :-) What are the (minor) differences between both patches? -- José Abílio
Re: [PATCH-updated] Paragraph Setting UI Bugs
Richard Heck wrote: What are the (minor) differences between both patches? there is a long thread on this but to summarize: the question is whether we want a separate default button for the rare situations in which we (1) change document layouts and (2) run into: 1 x is set and we change the default to x: 2 x (default) is set and the default changes: x in (just/left/center/right) ... i think adding ui for this is not necessary. the dialog would look as in attached. i makes explicit the default (and therefore allows to reset to the default) one needs to give it a serious try to figure out whether richards is to be preferred <>
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Friday 22 June 2007 18:21:52 Edwin Leuven wrote: > let me guess, you tossed a coin...? Not on Fridays. :-) In case it matters both solutions are better than what we have now, and I am closer from Richard's reasoning in this case. Also after some time if no consensus is reached it is better to decide and move on. -- José Abílio
Re: [PATCH-updated] Paragraph Setting UI Bugs
José Matos wrote: On Friday 22 June 2007 18:21:52 Edwin Leuven wrote: let me guess, you tossed a coin...? Not on Fridays. :-) observational equivalent though... In case it matters both solutions are better than what we have now, sure and I am closer from Richard's reasoning in this case. i think this needs another thought, but it doesn't really matter since we can always change this later... Also after some time if no consensus is reached it is better to decide and move on. suffice to say that i disagree ...
Re: [PATCH-updated] Paragraph Setting UI Bugs
On Fri, Jun 22, 2007 at 07:21:52PM +0200, Edwin Leuven wrote: > José Matos wrote: > >OK. I think that the subject is important and I liked the discussion > >there, now let us move to other (critical) bugs. :-) > > > >Since I have to decide I opt for Richard's argument without any > >demerit for Edwin patch/solution. > > let me guess, you tossed a coin...? Even tossing coins makes sense from time to time. Andre'
Re: [PATCH-updated] Paragraph Setting UI Bugs
I've committed this now, with a reference to this discussion. Richard Richard Heck wrote: José Matos wrote: On Friday 22 June 2007 17:42:34 Edwin Leuven wrote: did you have a look at this one? I had both under my radar. :-) What are the (minor) differences between both patches? Edwin's patch attempts to treat the alignment that happens to be the default (say, Justified) differently from the rest, by adding "(Default)" after it and doing away with a special "Default" button. There are two problems with this, I think. Quoting from the previous message: [In my patch] The layout that happens to be the default isn't treated specially at all. The idea here is that saying, "Align this as default, whatever that is" is different from saying "Center this, come what may", even if, in the current layout, centering happens to be the default. This seems the right behavior, as the option certainly exists in LaTeX. At the moment, however, LyX itself ignores this difference: if you choose "Left", and that is the default, it's effectively the same as choosing "Default", due to a bug in Text::setParagraph(). That will be fixed at a later stage. It may involve more than should be done prior to 1.5.0, and I don't have the time right now, anyway. Second: As J"urgen also pointed out, trying to treat what is in fact the default alignment differently runs into problems with multi-paragraph selections, since there may be no common default in such cases. This could presumably be handled, but you'd need to modify the controller so that it would report whether we have a multi-paragraph selection. And, in any event, the best reason is the first., which was first raised by Helge and has since been endorsed by Joost, J"urgen, and (I think) Alfredo. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ == Get my public key from http://sks.keyserver.penguin.de Hash: 0x1DE91F1E66FFBDEC Learn how to sign your email using Thunderbird and GnuPG at: http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
