Re: [Patch] Rename Invisible in View menu to Hidden|H.

2010-10-29 Thread John McCabe-Dansted 
On Fri, Oct 29, 2010 at 6:00 AM, RGH rgh...@comcast.net wrote:
 Committed, thanks.

 I'll tell you what I'd also like: A Close-this-document-set option, that
 would close the master and all its children, NOT hide them. If you're
 interested

 Richard

Thanks for the offer. I'll consider myself lucky if I get the features
I've already written into 2.0.X, such as the Citation GUI stuff:
  http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg162574.html

I think I won't try for a write/review/revise cycle before beta; even
for 2.1.x I should probably think about translating my perl stuff
(esp. the grammar checker), into python, so that it can be included.

-- 
John C. McCabe-Dansted

Re: [Patch] Rename "Invisible" in View menu to "Hidden|H".

2010-10-29 Thread John McCabe-Dansted 
On Fri, Oct 29, 2010 at 6:00 AM, RGH  wrote:
> Committed, thanks.
>
> I'll tell you what I'd also like: A Close-this-document-set option, that
> would close the master and all its children, NOT hide them. If you're
> interested
>
> Richard

Thanks for the offer. I'll consider myself lucky if I get the features
I've already written into 2.0.X, such as the Citation GUI stuff:
  http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg162574.html

I think I won't try for a write/review/revise cycle before beta; even
for 2.1.x I should probably think about translating my perl stuff
(esp. the grammar checker), into python, so that it can be included.

-- 
John C. McCabe-Dansted

Re: [Patch] Rename Invisible in View menu to Hidden|H.

2010-10-28 Thread RGH 

On 10/26/2010 01:12 AM, John McCabe-Dansted wrote:

On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüllersp...@lyx.org  wrote:
   

Please let me know of other issues. Note particularly that all fixes that
entail a string change should go in very soon, since we will turn to string
freeze soon.
 

Well this string change doesn't affect branch, but I think we should
rename Invisible as Hidden|H in the View menu as:
1) This allows a natural keyboard accelerator H (I is already used).
2) This matches the terminology Hide tab used in the context menu
when hiding the tab.

   

Committed, thanks.

I'll tell you what I'd also like: A Close-this-document-set option, that 
would close the master and all its children, NOT hide them. If you're 
interested


Richard

Re: [Patch] Rename "Invisible" in View menu to "Hidden|H".

2010-10-28 Thread RGH 

On 10/26/2010 01:12 AM, John McCabe-Dansted wrote:

On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüller  wrote:
   

Please let me know of other issues. Note particularly that all fixes that
entail a string change should go in very soon, since we will turn to string
freeze soon.
 

Well this string change doesn't affect branch, but I think we should
rename Invisible as Hidden|H in the View menu as:
1) This allows a natural keyboard accelerator "H" ("I" is already used).
2) This matches the terminology "Hide tab" used in the context menu
when hiding the tab.

   

Committed, thanks.

I'll tell you what I'd also like: A Close-this-document-set option, that 
would close the master and all its children, NOT hide them. If you're 
interested


Richard

Re: [Patch] Rename Invisible in View menu to Hidden|H.

2010-10-26 Thread Jürgen Spitzmüller 
John McCabe-Dansted wrote:
 On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüller sp...@lyx.org wrote:
  Please let me know of other issues. Note particularly that all fixes that
  entail a string change should go in very soon, since we will turn to
  string freeze soon.
 
 Well this string change doesn't affect branch, but I think we should
 rename Invisible as Hidden|H in the View menu as:
 1) This allows a natural keyboard accelerator H (I is already used).
 2) This matches the terminology Hide tab used in the context menu
 when hiding the tab.

This is a proposal for trunk, right?

Jürgen

Re: [Patch] Rename Invisible in View menu to Hidden|H.

2010-10-26 Thread John McCabe-Dansted 
On Tue, Oct 26, 2010 at 3:59 PM, Jürgen Spitzmüller sp...@lyx.org wrote:
 John McCabe-Dansted wrote:
 On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüller sp...@lyx.org wrote:
  Please let me know of other issues. Note particularly that all fixes that
  entail a string change should go in very soon, since we will turn to
  string freeze soon.

 Well this string change doesn't affect branch, but I think we should
 rename Invisible as Hidden|H in the View menu as:
 1) This allows a natural keyboard accelerator H (I is already used).
 2) This matches the terminology Hide tab used in the context menu
 when hiding the tab.

 This is a proposal for trunk, right?

Yes.

-- 
John C. McCabe-Dansted

Re: [Patch] Rename Invisible in View menu to Hidden|H.

2010-10-26 Thread Jürgen Spitzmüller 
John McCabe-Dansted wrote:
  This is a proposal for trunk, right?
 
 Yes.

OK. And FWIW, I agree with your proposal.

Jürgen

Re: [Patch] Rename "Invisible" in View menu to "Hidden|H".

2010-10-26 Thread Jürgen Spitzmüller 
John McCabe-Dansted wrote:
> On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüller  wrote:
> > Please let me know of other issues. Note particularly that all fixes that
> > entail a string change should go in very soon, since we will turn to
> > string freeze soon.
> 
> Well this string change doesn't affect branch, but I think we should
> rename Invisible as Hidden|H in the View menu as:
> 1) This allows a natural keyboard accelerator "H" ("I" is already used).
> 2) This matches the terminology "Hide tab" used in the context menu
> when hiding the tab.

This is a proposal for trunk, right?

Jürgen

Re: [Patch] Rename "Invisible" in View menu to "Hidden|H".

2010-10-26 Thread John McCabe-Dansted 
On Tue, Oct 26, 2010 at 3:59 PM, Jürgen Spitzmüller  wrote:
> John McCabe-Dansted wrote:
>> On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüller  wrote:
>> > Please let me know of other issues. Note particularly that all fixes that
>> > entail a string change should go in very soon, since we will turn to
>> > string freeze soon.
>>
>> Well this string change doesn't affect branch, but I think we should
>> rename Invisible as Hidden|H in the View menu as:
>> 1) This allows a natural keyboard accelerator "H" ("I" is already used).
>> 2) This matches the terminology "Hide tab" used in the context menu
>> when hiding the tab.
>
> This is a proposal for trunk, right?

Yes.

-- 
John C. McCabe-Dansted

Re: [Patch] Rename "Invisible" in View menu to "Hidden|H".

2010-10-26 Thread Jürgen Spitzmüller 
John McCabe-Dansted wrote:
> > This is a proposal for trunk, right?
> 
> Yes.

OK. And FWIW, I agree with your proposal.

Jürgen

[Patch] Rename Invisible in View menu to Hidden|H.

2010-10-25 Thread John McCabe-Dansted 
On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüller sp...@lyx.org wrote:
 Please let me know of other issues. Note particularly that all fixes that
 entail a string change should go in very soon, since we will turn to string
 freeze soon.

Well this string change doesn't affect branch, but I think we should
rename Invisible as Hidden|H in the View menu as:
1) This allows a natural keyboard accelerator H (I is already used).
2) This matches the terminology Hide tab used in the context menu
when hiding the tab.

-- 
John C. McCabe-Dansted
Index: frontends/qt4/Menus.cpp
===
--- frontends/qt4/Menus.cpp (revision 35426)
+++ frontends/qt4/Menus.cpp (working copy)
@@ -879,8 +879,8 @@

 void MenuDefinition::expandDocuments()
 {
-   MenuItem item(MenuItem::Submenu, qt_(Invisible));
-   item.setSubmenu(MenuDefinition(qt_(Invisible)));
+   MenuItem item(MenuItem::Submenu, qt_(Hidden|H));
+   item.setSubmenu(MenuDefinition(qt_(Hidden|H)));

Buffer * first = theBufferList().first();
if (first) {

[Patch] Rename "Invisible" in View menu to "Hidden|H".

2010-10-25 Thread John McCabe-Dansted 
On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüller  wrote:
> Please let me know of other issues. Note particularly that all fixes that
> entail a string change should go in very soon, since we will turn to string
> freeze soon.

Well this string change doesn't affect branch, but I think we should
rename Invisible as Hidden|H in the View menu as:
1) This allows a natural keyboard accelerator "H" ("I" is already used).
2) This matches the terminology "Hide tab" used in the context menu
when hiding the tab.

-- 
John C. McCabe-Dansted
Index: frontends/qt4/Menus.cpp
===
--- frontends/qt4/Menus.cpp (revision 35426)
+++ frontends/qt4/Menus.cpp (working copy)
@@ -879,8 +879,8 @@

 void MenuDefinition::expandDocuments()
 {
-   MenuItem item(MenuItem::Submenu, qt_("Invisible"));
-   item.setSubmenu(MenuDefinition(qt_("Invisible")));
+   MenuItem item(MenuItem::Submenu, qt_("Hidden|H"));
+   item.setSubmenu(MenuDefinition(qt_("Hidden|H")));

Buffer * first = theBufferList().first();
if (first) {