Re: 1.5.X patch candidates - next iteration
Jürgen Spitzmüller wrote: I'll comment only on those that I haven't approved last time. http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font copying http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization Alfredo asked for some expert review. After that, it can go in. (I've already approved that) They are safe IMHO. New --- http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission Already approved last time ... Yes, I know I promised to do that last time but I was waiting for my other patch to be committed. I'll try to backport it but this just a cosmetics change for branch, nothing critical. http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. Applicable to branch? In theory yes but this will have side effects within insets. OTOH, that may solve some of the not easily reproducible crashes that have been reported. http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for Conglomerate-style inset http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this time properly Not applicable to branch, I think. Remove both. Right. http://www.lyx.org/trac/changeset/20159 - remove recursive call Hm. Peter, is this something for branch? No. http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection(): use parMetrics() instead of direct access just in case. Should fix crash on selection with PageUp Abdel? No. http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable inset without button. Not applicable to branch, I think. Remove. Right. http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within insets. http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons with surrounding text. http://www.lyx.org/trac/changeset/20142 - Restore docked View source widget. http://www.lyx.org/trac/changeset/20143 - fix view source window title. http://www.lyx.org/trac/changeset/20144 - oups... http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really needed. http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget. Warning: still instable! http://www.lyx.org/trac/changeset/20177 - TextMetrics::draw(): withdraw first row ascent before drawing because the convention is that the baseline of a multirow text is the baseline of the first row. http://www.lyx.org/trac/changeset/20178 - fix outline dialog for non-Mac platform. All not applicable to branch, I think. Remove. And right. Abdel.
Re: 1.5.X patch candidates - next iteration
Michael Gerz wrote: http://www.lyx.org/trac/changeset/19473 - more verbose message I have backported this now http://www.lyx.org/trac/changeset/19747 - Delete include of config.h. This was needed only for the qt3 port. an this. Jürgen
Re: 1.5.X patch candidates - next iteration
Abdelrazak Younes wrote: http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font copying http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization Alfredo asked for some expert review. After that, it can go in. (I've already approved that) They are safe IMHO. Good. Alfredo, you can apply then. http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission Already approved last time ... Yes, I know I promised to do that last time but I was waiting for my other patch to be committed. I'll try to backport it but this just a cosmetics change for branch, nothing critical. Just to keep track, here are the fixes you still need to backport (and have OK to do so). No need to hurry, though: http://www.lyx.org/trac/changeset/19638 - redoParagraph() simplify the changed calculation http://www.lyx.org/trac/changeset/19868 - TextMetrics::redoParagraph(): we need to check the returned value of Inset::metrics() http://www.lyx.org/trac/changeset/19838 - Bug fix: correctly redraw a Row containing and inset which Dimension slightly changed http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. Applicable to branch? In theory yes but this will have side effects within insets. What kind of side effects? OTOH, that may solve some of the not easily reproducible crashes that have been reported. Which ones? Jürgen
Re: 1.5.X patch candidates - next iteration
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. Applicable to branch? In theory yes but this will have side effects within insets. What kind of side effects? I am not sure... maybe crashes, maybe cleared out text... In trunk, the only side effect (besides fixing the DEPM crash) was that I had to force full repaint in tabular cells. But a full repaint occurred anyway so no harm done. I'll tell you what, I'll produce a patch and let you test it and decide if it is safe or not. OTOH, that may solve some of the not easily reproducible crashes that have been reported. Which ones? Bo reported some crash IIRC. There were also problems with cursor positioning in table IIRC that may be solved by this. Abdel.
Re: 1.5.X patch candidates - next iteration
On Tue, 11 Sep 2007 07:58:09 +0200 [EMAIL PROTECTED] (Jürgen Spitzmüller) wrote: http://www.lyx.org/trac/changeset/20104 - Better error signaling Not applicable, I think. Martin? Not relevant, relates to inset configurability which is not in 1.5 - Martin
Re: 1.5.X patch candidates - next iteration
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes: Michael Gerz wrote: http://www.lyx.org/trac/changeset/19473 - more verbose message I have backported this now What happened to using documentation for such large explanations? Somebody thinks that configure --help is not unreadable enough? ;) Seriously, all help message would be candidate for the ame obfuscation. I do not really understand why boost has this special treatment. JMarc
Re: 1.5.X patch candidates - next iteration
On Monday 10 September 2007 21:30:11 Uwe Stöhr wrote: http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii character since LyX.py can't encode it at the moment This is not a fix but a workaround. This problem was trunk only. doc_toc.py is nevertheless broken in trunk and branch when handling non-ascii characters. Fixed in http://www.lyx.org/trac/changeset/20207 regards Uwe -- José Abílio
Re: 1.5.X patch candidates - next iteration
José Matos wrote: doc_toc.py is nevertheless broken in trunk and branch when handling non-ascii characters. Fixed in http://www.lyx.org/trac/changeset/20207 How about branch? Jürgen
Re: 1.5.X patch candidates - next iteration
On Tuesday 11 September 2007 10:11:58 Jürgen Spitzmüller wrote: How about branch? The change is safe may I apply it to the stable branch? Jürgen -- José Abílio
Re: 1.5.X patch candidates - next iteration
José Matos wrote: The change is safe may I apply it to the stable branch? Yes, please. Jürgen
Re: 1.5.X patch candidates - next iteration
On Tuesday 11 September 2007 10:31:55 Jürgen Spitzmüller wrote: Yes, please. Done. http://www.lyx.org/trac/changeset/20210 If other title translations are added to doc_toc.py that should be reported in status.15x. This patch is just an internal fix and since this does not change any output, I have not filled any new entry to status.15x. I hope this is OK. :-) Jürgen -- José Abílio
Re: 1.5.X patch candidates - next iteration
José Matos wrote: If other title translations are added to doc_toc.py that should be reported in status.15x. This patch is just an internal fix and since this does not change any output, I have not filled any new entry to status.15x. I hope this is OK. :-) Fine with me. Jürgen
Re: 1.5.X patch candidates - next iteration
Fixed in http://www.lyx.org/trac/changeset/20207 thanks Uwe
Re: 1.5.X patch candidates - next iteration
Jürgen Spitzmüller [EMAIL PROTECTED] writes: Alfredo asked for some expert review. After that, it can go in. (I've already approved that) They are safe IMHO. Good. Alfredo, you can apply then. Err, these went in some days ago (you said ok if IMO they were safe). So, in already. A/
Re: 1.5.X patch candidates - next iteration
Alfredo Braunstein wrote: Good. Alfredo, you can apply then. Err, these went in some days ago (you said ok if IMO they were safe). So, in already. Right, I remember now. You really need to fix the mailing list issue ... Jürgen
Re: 1.5.X patch candidates - next iteration
Abdelrazak Younes wrote:
Jürgen Spitzmüller wrote:
Abdelrazak Younes wrote:
http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset.
always clear the full text_metrics_ when doing a full update.
Applicable to branch?
In theory yes but this will have side effects within insets.
What kind of side effects?
I am not sure... maybe crashes, maybe cleared out text... In trunk, the
only side effect (besides fixing the DEPM crash) was that I had to force
full repaint in tabular cells. But a full repaint occurred anyway so no
harm done.
I'll tell you what, I'll produce a patch and let you test it and decide
if it is safe or not.
Well, I verified that there is no apparent side effect and I cannot see
how it could have anyway so I just committed it. The patch is short so
it can be reverted easily in case of problems but I really don't expect
any. I didn't put an entry in status.15x because I don't know what to put...
Abdel.
Author: younes
Date: Tue Sep 11 22:09:36 2007
New Revision: 20220
URL: http://www.lyx.org/trac/changeset/20220
Log:
BufferView: Be on the safe side: clear out all of text_metrics_ when
doing a full update.
Modified:
lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp
Modified: lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp
URL:
http://www.lyx.org/trac/file/lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp?rev=20220
==
--- lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp (original)
+++ lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp Tue Sep 11
22:09:36 2007
@@ -1097,9 +1097,6 @@
width_ = width;
height_ = height;
- // The complete text metrics will be redone.
- text_metrics_.clear();
-
if (buffer_)
resize();
}
@@ -1464,7 +1461,6 @@
void BufferView::updateMetrics(bool singlepar)
{
Text buftext = buffer_-text();
- TextMetrics tm = textMetrics(buftext);
pit_type size = int(buftext.paragraphs().size());
if (anchor_ref_ int(buftext.paragraphs().size() - 1)) {
@@ -1478,8 +1474,11 @@
// Clear out paragraph metrics to avoid having invalid metrics
// in the cache from paragraphs not relayouted below
- tm.clear();
- }
+ // The complete text metrics will be redone.
+ text_metrics_.clear();
+ }
+
+ TextMetrics tm = textMetrics(buftext);
// If the paragraph metrics has changed, we can not
// use the singlepar optimisation.
Re: 1.5.X patch candidates - next iteration
Jürgen Spitzmüller wrote: Just to keep track, here are the fixes you still need to backport (and have OK to do so). No need to hurry, though: http://www.lyx.org/trac/changeset/19868 - TextMetrics::redoParagraph(): we need to check the returned value of Inset::metrics() http://www.lyx.org/trac/changeset/19838 - Bug fix: correctly redraw a Row containing and inset which Dimension slightly changed I committed those two (in one commit because they are related). Abdel.
Re: 1.5.X patch candidates - next iteration
Jürgen Spitzmüller wrote: I'll comment only on those that I haven't approved last time. http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font copying http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization Alfredo asked for some expert review. After that, it can go in. (I've already approved that) They are safe IMHO. New --- http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission Already approved last time ... Yes, I know I promised to do that last time but I was waiting for my other patch to be committed. I'll try to backport it but this just a cosmetics change for branch, nothing critical. http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. Applicable to branch? In theory yes but this will have side effects within insets. OTOH, that may solve some of the not easily reproducible crashes that have been reported. http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for Conglomerate-style inset http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this time properly Not applicable to branch, I think. Remove both. Right. http://www.lyx.org/trac/changeset/20159 - remove recursive call Hm. Peter, is this something for branch? No. http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection(): use parMetrics() instead of direct access just in case. Should fix crash on selection with PageUp Abdel? No. http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable inset without button. Not applicable to branch, I think. Remove. Right. http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within insets. http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons with surrounding text. http://www.lyx.org/trac/changeset/20142 - Restore docked View source widget. http://www.lyx.org/trac/changeset/20143 - fix view source window title. http://www.lyx.org/trac/changeset/20144 - oups... http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really needed. http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget. Warning: still instable! http://www.lyx.org/trac/changeset/20177 - TextMetrics::draw(): withdraw first row ascent before drawing because the convention is that the baseline of a multirow text is the baseline of the first row. http://www.lyx.org/trac/changeset/20178 - fix outline dialog for non-Mac platform. All not applicable to branch, I think. Remove. And right. Abdel.
Re: 1.5.X patch candidates - next iteration
Michael Gerz wrote: > http://www.lyx.org/trac/changeset/19473 - more verbose message I have backported this now > http://www.lyx.org/trac/changeset/19747 - Delete include of config.h. > This was needed only for the qt3 port. an this. Jürgen
Re: 1.5.X patch candidates - next iteration
Abdelrazak Younes wrote: > >> http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font > >> copying > >> http://www.lyx.org/trac/changeset/20021 - enable some non-rtl > >> optimization > > > > Alfredo asked for some expert review. After that, it can go in. > > (I've already approved that) > > They are safe IMHO. Good. Alfredo, you can apply then. > >> http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): > >> remove the Buffer::changed() signal emission > > > > Already approved last time ... > > Yes, I know I promised to do that last time but I was waiting for my > other patch to be committed. I'll try to backport it but this just a > cosmetics change for branch, nothing critical. Just to keep track, here are the fixes you still need to backport (and have OK to do so). No need to hurry, though: http://www.lyx.org/trac/changeset/19638 - redoParagraph() simplify the changed calculation http://www.lyx.org/trac/changeset/19868 - TextMetrics::redoParagraph(): we need to check the returned value of Inset::metrics() http://www.lyx.org/trac/changeset/19838 - Bug fix: correctly redraw a Row containing and inset which Dimension slightly changed http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission > >> http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. > >> always clear the full text_metrics_ when doing a full update. > > > > Applicable to branch? > > In theory yes but this will have side effects within insets. What kind of side effects? > OTOH, that > may solve some of the not easily reproducible crashes that have been > reported. Which ones? Jürgen
Re: 1.5.X patch candidates - next iteration
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. Applicable to branch? In theory yes but this will have side effects within insets. What kind of side effects? I am not sure... maybe crashes, maybe cleared out text... In trunk, the only side effect (besides fixing the DEPM crash) was that I had to force full repaint in tabular cells. But a full repaint occurred anyway so no harm done. I'll tell you what, I'll produce a patch and let you test it and decide if it is safe or not. OTOH, that may solve some of the not easily reproducible crashes that have been reported. Which ones? Bo reported some crash IIRC. There were also problems with cursor positioning in table IIRC that may be solved by this. Abdel.
Re: 1.5.X patch candidates - next iteration
On Tue, 11 Sep 2007 07:58:09 +0200 [EMAIL PROTECTED] (Jürgen Spitzmüller) wrote: > > http://www.lyx.org/trac/changeset/20104 - Better error signaling > > Not applicable, I think. Martin? Not relevant, relates to inset configurability which is not in 1.5 - Martin
Re: 1.5.X patch candidates - next iteration
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes: > Michael Gerz wrote: >> http://www.lyx.org/trac/changeset/19473 - more verbose message > > I have backported this now What happened to using documentation for such large explanations? Somebody thinks that configure --help is not unreadable enough? ;) Seriously, all help message would be candidate for the ame obfuscation. I do not really understand why boost has this special treatment. JMarc
Re: 1.5.X patch candidates - next iteration
On Monday 10 September 2007 21:30:11 Uwe Stöhr wrote: > > http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii > character since LyX.py can't encode it at the moment > > This is not a fix but a workaround. This problem was trunk only. > > doc_toc.py is nevertheless broken in trunk and branch when handling > non-ascii characters. Fixed in http://www.lyx.org/trac/changeset/20207 > regards Uwe -- José Abílio
Re: 1.5.X patch candidates - next iteration
José Matos wrote: > > doc_toc.py is nevertheless broken in trunk and branch when handling > > non-ascii characters. > > Fixed in http://www.lyx.org/trac/changeset/20207 How about branch? Jürgen
Re: 1.5.X patch candidates - next iteration
On Tuesday 11 September 2007 10:11:58 Jürgen Spitzmüller wrote: > How about branch? The change is safe may I apply it to the stable branch? > Jürgen -- José Abílio
Re: 1.5.X patch candidates - next iteration
José Matos wrote: > The change is safe may I apply it to the stable branch? Yes, please. Jürgen
Re: 1.5.X patch candidates - next iteration
On Tuesday 11 September 2007 10:31:55 Jürgen Spitzmüller wrote: > Yes, please. Done. http://www.lyx.org/trac/changeset/20210 If other title translations are added to doc_toc.py that should be reported in status.15x. This patch is just an internal fix and since this does not change any output, I have not filled any new entry to status.15x. I hope this is OK. :-) > Jürgen -- José Abílio
Re: 1.5.X patch candidates - next iteration
José Matos wrote: > If other title translations are added to doc_toc.py that should be reported > in status.15x. This patch is just an internal fix and since this does not > change any output, I have not filled any new entry to status.15x. > > I hope this is OK. :-) Fine with me. Jürgen
Re: 1.5.X patch candidates - next iteration
> Fixed in http://www.lyx.org/trac/changeset/20207 thanks Uwe
Re: 1.5.X patch candidates - next iteration
Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: > > > Alfredo asked for some expert review. After that, it can go in. > > > (I've already approved that) > > > > They are safe IMHO. > > Good. Alfredo, you can apply then. Err, these went in some days ago (you said ok if IMO they were safe). So, in already. A/
Re: 1.5.X patch candidates - next iteration
Alfredo Braunstein wrote: > > Good. Alfredo, you can apply then. > > Err, these went in some days ago (you said ok if IMO they were safe). > So, in already. Right, I remember now. You really need to fix the mailing list issue ... Jürgen
Re: 1.5.X patch candidates - next iteration
Abdelrazak Younes wrote:
Jürgen Spitzmüller wrote:
Abdelrazak Younes wrote:
http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset.
always clear the full text_metrics_ when doing a full update.
Applicable to branch?
In theory yes but this will have side effects within insets.
What kind of side effects?
I am not sure... maybe crashes, maybe cleared out text... In trunk, the
only side effect (besides fixing the DEPM crash) was that I had to force
full repaint in tabular cells. But a full repaint occurred anyway so no
harm done.
I'll tell you what, I'll produce a patch and let you test it and decide
if it is safe or not.
Well, I verified that there is no apparent side effect and I cannot see
how it could have anyway so I just committed it. The patch is short so
it can be reverted easily in case of problems but I really don't expect
any. I didn't put an entry in status.15x because I don't know what to put...
Abdel.
Author: younes
Date: Tue Sep 11 22:09:36 2007
New Revision: 20220
URL: http://www.lyx.org/trac/changeset/20220
Log:
BufferView: Be on the safe side: clear out all of text_metrics_ when
doing a full update.
Modified:
lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp
Modified: lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp
URL:
http://www.lyx.org/trac/file/lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp?rev=20220
==
--- lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp (original)
+++ lyx-devel/branches/BRANCH_1_5_X/src/BufferView.cpp Tue Sep 11
22:09:36 2007
@@ -1097,9 +1097,6 @@
width_ = width;
height_ = height;
- // The complete text metrics will be redone.
- text_metrics_.clear();
-
if (buffer_)
resize();
}
@@ -1464,7 +1461,6 @@
void BufferView::updateMetrics(bool singlepar)
{
Text & buftext = buffer_->text();
- TextMetrics & tm = textMetrics();
pit_type size = int(buftext.paragraphs().size());
if (anchor_ref_ > int(buftext.paragraphs().size() - 1)) {
@@ -1478,8 +1474,11 @@
// Clear out paragraph metrics to avoid having invalid metrics
// in the cache from paragraphs not relayouted below
- tm.clear();
- }
+ // The complete text metrics will be redone.
+ text_metrics_.clear();
+ }
+
+ TextMetrics & tm = textMetrics();
// If the paragraph metrics has changed, we can not
// use the singlepar optimisation.
Re: 1.5.X patch candidates - next iteration
Jürgen Spitzmüller wrote: Just to keep track, here are the fixes you still need to backport (and have OK to do so). No need to hurry, though: http://www.lyx.org/trac/changeset/19868 - TextMetrics::redoParagraph(): we need to check the returned value of Inset::metrics() http://www.lyx.org/trac/changeset/19838 - Bug fix: correctly redraw a Row containing and inset which Dimension slightly changed I committed those two (in one commit because they are related). Abdel.
1.5.X patch candidates - next iteration
Hi, here comes a new list of 1.5.X patch candidates. Comments like remove patch XY from the list are welcome. IMHO the list is too large to handle. Regards, Michael Not urgent, not now (but not rejected) -- http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug http://www.lyx.org/trac/changeset/19409 - Get rid of a few warnings http://www.lyx.org/trac/changeset/19914 - single depth for preference items, fixes bug #4153 http://www.lyx.org/trac/changeset/20065 - make citation dialog usable with longer keys Approved by Jürgen -- Update to Boost 1.34.1 http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when using %s with integer arguments http://www.lyx.org/trac/changeset/19473 - more verbose message http://www.lyx.org/trac/changeset/19638 - redoParagraph() simplify the changed calculation http://www.lyx.org/trac/changeset/19747 - Delete include of config.h. This was needed only for the qt3 port. http://www.lyx.org/trac/changeset/19868 - TextMetrics::redoParagraph(): we need to check the returned value of Inset::metrics() http://www.lyx.org/trac/changeset/19838 - Bug fix: correctly redraw a Row containing and inset which Dimension slightly changed Supported by someone else - http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font copying http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization New --- http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission http://www.lyx.org/trac/changeset/19916 - Save the right timestamp and checksum of an opened file. http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. http://www.lyx.org/trac/changeset/20039 - Fix bug 4193 Revert ask for saving file before closing http://www.lyx.org/trac/changeset/20093 - Forgot this: windows backslash needs special treatment http://www.lyx.org/trac/changeset/20094 - Fix previous commit. I really do not understand why windows FileName() can not have backslash (assertion at line 49 of support/FileName.cpp) http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for Conglomerate-style inset http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this time properly http://www.lyx.org/trac/changeset/20104 - Better error signaling http://www.lyx.org/trac/changeset/20195 - unicodesymbols: workaround fix for an encoding bug in teTeX 3 /TeXLive 2005 http://www.lyx.org/trac/changeset/20185 - Helge's wrapfig patch http://www.lyx.org/trac/changeset/20153 - Fix crash when layout file cannot be read due to failure to call makeTextClass() in that case. http://www.lyx.org/trac/changeset/20159 - remove recursive call http://www.lyx.org/trac/changeset/20162 - fix some index/label issue http://www.lyx.org/trac/changeset/20165 - connect to the right slots... http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii character since LyX.py can't encode it at the moment Abdel' Stuff: - http://www.lyx.org/trac/changeset/19972 - Fix wrapping bug within inset. dim_.wid was not set! http://www.lyx.org/trac/changeset/19974 - correct dimension types. http://www.lyx.org/trac/changeset/19992 - Fix crash when selection begins or ends outside the visible screen. http://www.lyx.org/trac/changeset/20013 - get rid of (cyg)win path panel in prefs by moving it to the latex panel http://www.lyx.org/trac/changeset/20079 - Fix caption text y-positioning http://www.lyx.org/trac/changeset/20080 - Fix tabular text y-positioning http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection(): use parMetrics() instead of direct access just in case. Should fix crash on selection with PageUp http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable inset without button. http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within insets. http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons with surrounding text. http://www.lyx.org/trac/changeset/20142 - Restore docked View source widget. http://www.lyx.org/trac/changeset/20143 - fix view source window title. http://www.lyx.org/trac/changeset/20144 - oups... http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really needed. http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget. Warning: still instable! http://www.lyx.org/trac/changeset/20177 - TextMetrics::draw(): withdraw first row ascent before drawing because the convention is that the baseline of a multirow text is the baseline of the first row. http://www.lyx.org/trac/changeset/20178 - fix outline dialog for non-Mac platform.
Re: 1.5.X patch candidates - next iteration
http://www.lyx.org/trac/changeset/19916 - Save the right timestamp and checksum of an opened file. Already done. http://www.lyx.org/trac/changeset/20039 - Fix bug 4193 Revert ask for saving file before closing Already done. http://www.lyx.org/trac/changeset/20093 - Forgot this: windows backslash needs special treatment http://www.lyx.org/trac/changeset/20094 - Fix previous commit. I really do not understand why windows FileName() can not have backslash (assertion at line 49 of support/FileName.cpp) Not for 1.5.x. (Actually they are, but I am too lazy to maintain scons for 1.5.x as long as it works). Bo
Re: 1.5.X patch candidates - next iteration
On Mon, Sep 10, 2007 at 08:59:02PM +0200, Michael Gerz wrote: Hi, here comes a new list of 1.5.X patch candidates. Comments like remove patch XY from the list are welcome. IMHO the list is too large to handle. Regards, Michael Not urgent, not now (but not rejected) -- http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug http://www.lyx.org/trac/changeset/19409 - Get rid of a few warnings http://www.lyx.org/trac/changeset/19914 - single depth for preference items, fixes bug #4153 http://www.lyx.org/trac/changeset/20065 - make citation dialog usable with longer keys Approved by Jürgen -- Update to Boost 1.34.1 http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when using %s with integer arguments http://www.lyx.org/trac/changeset/19473 - more verbose message http://www.lyx.org/trac/changeset/19638 - redoParagraph() simplify the changed calculation http://www.lyx.org/trac/changeset/19747 - Delete include of config.h. This was needed only for the qt3 port. http://www.lyx.org/trac/changeset/19868 - TextMetrics::redoParagraph(): we need to check the returned value of Inset::metrics() http://www.lyx.org/trac/changeset/19838 - Bug fix: correctly redraw a Row containing and inset which Dimension slightly changed Supported by someone else - http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font copying http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization New --- http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission http://www.lyx.org/trac/changeset/19916 - Save the right timestamp and checksum of an opened file. http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. http://www.lyx.org/trac/changeset/20039 - Fix bug 4193 Revert ask for saving file before closing http://www.lyx.org/trac/changeset/20093 - Forgot this: windows backslash needs special treatment http://www.lyx.org/trac/changeset/20094 - Fix previous commit. I really do not understand why windows FileName() can not have backslash (assertion at line 49 of support/FileName.cpp) http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for Conglomerate-style inset http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this time properly I believe Abel reverted the stuff related to this. Someone verify that it works OK for all inset types (it seems to do for me) http://www.lyx.org/trac/changeset/20104 - Better error signaling http://www.lyx.org/trac/changeset/20195 - unicodesymbols: workaround fix for an encoding bug in teTeX 3 /TeXLive 2005 http://www.lyx.org/trac/changeset/20185 - Helge's wrapfig patch Apparently not... http://www.lyx.org/trac/changeset/20153 - Fix crash when layout file cannot be read due to failure to call makeTextClass() in that case. http://www.lyx.org/trac/changeset/20159 - remove recursive call http://www.lyx.org/trac/changeset/20162 - fix some index/label issue http://www.lyx.org/trac/changeset/20165 - connect to the right slots... http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii character since LyX.py can't encode it at the moment Abdel' Stuff: - http://www.lyx.org/trac/changeset/19972 - Fix wrapping bug within inset. dim_.wid was not set! http://www.lyx.org/trac/changeset/19974 - correct dimension types. http://www.lyx.org/trac/changeset/19992 - Fix crash when selection begins or ends outside the visible screen. All due to dumping wide(). Not relevant http://www.lyx.org/trac/changeset/20013 - get rid of (cyg)win path panel in prefs by moving it to the latex panel http://www.lyx.org/trac/changeset/20079 - Fix caption text y-positioning http://www.lyx.org/trac/changeset/20080 - Fix tabular text y-positioning Ditto http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection(): use parMetrics() instead of direct access just in case. Should fix crash on selection with PageUp http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable inset without button. I suppose ditto http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within insets. http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons with surrounding text. http://www.lyx.org/trac/changeset/20142 - Restore docked View source widget. http://www.lyx.org/trac/changeset/20143 - fix view source window title. http://www.lyx.org/trac/changeset/20144 - oups... http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really needed. http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget. Warning: still instable! http://www.lyx.org/trac/changeset/20177 - TextMetrics::draw(): withdraw first row ascent before drawing because the
Re: 1.5.X patch candidates - next iteration
On Mon, Sep 10, 2007 at 08:59:02PM +0200, Michael Gerz wrote: Hi, here comes a new list of 1.5.X patch candidates. Comments like remove patch XY from the list are welcome. IMHO the list is too large to handle. Regards, Michael Not urgent, not now (but not rejected) -- http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug http://www.lyx.org/trac/changeset/19409 - Get rid of a few warnings http://www.lyx.org/trac/changeset/19914 - single depth for preference items, fixes bug #4153 http://www.lyx.org/trac/changeset/20065 - make citation dialog usable with longer keys Approved by Jürgen -- Update to Boost 1.34.1 http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when using %s with integer arguments Someone with checked-out branch should just apply that. Andre'
Re: 1.5.X patch candidates - next iteration
http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when using %s with integer arguments Someone with checked-out branch should just apply that. Done. r20199. Bo
Re: 1.5.X patch candidates - next iteration
http://www.lyx.org/trac/changeset/20185 - Helge's wrapfig patch No, because file format change. http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii character since LyX.py can't encode it at the moment This is not a fix but a workaround. This problem was trunk only. doc_toc.py is nevertheless broken in trunk and branch when handling non-ascii characters. regards Uwe
Re: 1.5.X patch candidates - next iteration
Bo Peng wrote: Done. r20199. Thanks. Jürgen
Re: 1.5.X patch candidates - next iteration
I'll comment only on those that I haven't approved last time. Michael Gerz wrote: Not urgent, not now (but not rejected) -- http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug http://www.lyx.org/trac/changeset/19409 - Get rid of a few warnings http://www.lyx.org/trac/changeset/19914 - single depth for preference items, fixes bug #4153 remove these, please. http://www.lyx.org/trac/changeset/20065 - make citation dialog usable with longer keys Not necessary. Remove. Approved by Jürgen -- Update to Boost 1.34.1 http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when using %s with integer arguments In. Remove. Supported by someone else - http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font copying http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization Alfredo asked for some expert review. After that, it can go in. (I've already approved that) New --- http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission Already approved last time ... http://www.lyx.org/trac/changeset/19916 - Save the right timestamp and checksum of an opened file. In. Remove. http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. Applicable to branch? http://www.lyx.org/trac/changeset/20039 - Fix bug 4193 Revert ask for saving file before closing In. Remove. http://www.lyx.org/trac/changeset/20093 - Forgot this: windows backslash needs special treatment http://www.lyx.org/trac/changeset/20094 - Fix previous commit. I really do not understand why windows FileName() can not have backslash (assertion at line 49 of support/FileName.cpp) Remove (since Bo won't backport this). http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for Conglomerate-style inset http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this time properly Not applicable to branch, I think. Remove both. http://www.lyx.org/trac/changeset/20104 - Better error signaling Not applicable, I think. Martin? http://www.lyx.org/trac/changeset/20195 - unicodesymbols: workaround fix for an encoding bug in teTeX 3 /TeXLive 2005 Approved. Should go in today. http://www.lyx.org/trac/changeset/20185 - Helge's wrapfig patch Definitely not (file format change). Remove. http://www.lyx.org/trac/changeset/20153 - Fix crash when layout file cannot be read due to failure to call makeTextClass() in that case. Not applicable, I think. Richard? http://www.lyx.org/trac/changeset/20159 - remove recursive call Hm. Peter, is this something for branch? http://www.lyx.org/trac/changeset/20162 - fix some index/label issue Not applicable. Remove. http://www.lyx.org/trac/changeset/20165 - connect to the right slots... Not applicable. Remove. http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii character since LyX.py can't encode it at the moment Not applicable. Remove. Abdel' Stuff: - http://www.lyx.org/trac/changeset/19972 - Fix wrapping bug within inset. dim_.wid was not set! http://www.lyx.org/trac/changeset/19974 - correct dimension types. http://www.lyx.org/trac/changeset/19992 - Fix crash when selection begins or ends outside the visible screen. Not applicable. Remove all these. http://www.lyx.org/trac/changeset/20013 - get rid of (cyg)win path panel in prefs by moving it to the latex panel No. Remove. http://www.lyx.org/trac/changeset/20079 - Fix caption text y-positioning http://www.lyx.org/trac/changeset/20080 - Fix tabular text y-positioning Not applicable. Remove. http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection(): use parMetrics() instead of direct access just in case. Should fix crash on selection with PageUp Abdel? http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable inset without button. Not applicable to branch, I think. Remove. http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within insets. http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons with surrounding text. http://www.lyx.org/trac/changeset/20142 - Restore docked View source widget. http://www.lyx.org/trac/changeset/20143 - fix view source window title. http://www.lyx.org/trac/changeset/20144 - oups... http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really needed. http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget. Warning: still instable! http://www.lyx.org/trac/changeset/20177 - TextMetrics::draw(): withdraw first row ascent before drawing because the convention is that the baseline of a multirow text is the baseline of the first row. http://www.lyx.org/trac/changeset/20178 - fix outline dialog for non-Mac platform. All not applicable to branch, I think. Remove. Jürgen
1.5.X patch candidates - next iteration
Hi, here comes a new list of 1.5.X patch candidates. Comments like "remove patch XY from the list" are welcome. IMHO the list is too large to handle. Regards, Michael Not urgent, not now (but not rejected) -- http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug http://www.lyx.org/trac/changeset/19409 - Get rid of a few warnings http://www.lyx.org/trac/changeset/19914 - single depth for preference items, fixes bug #4153 http://www.lyx.org/trac/changeset/20065 - make citation dialog usable with longer keys Approved by Jürgen -- Update to Boost 1.34.1 http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when using %s with integer arguments http://www.lyx.org/trac/changeset/19473 - more verbose message http://www.lyx.org/trac/changeset/19638 - redoParagraph() simplify the changed calculation http://www.lyx.org/trac/changeset/19747 - Delete include of config.h. This was needed only for the qt3 port. http://www.lyx.org/trac/changeset/19868 - TextMetrics::redoParagraph(): we need to check the returned value of Inset::metrics() http://www.lyx.org/trac/changeset/19838 - Bug fix: correctly redraw a Row containing and inset which Dimension slightly changed Supported by someone else - http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font copying http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization New --- http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): remove the Buffer::changed() signal emission http://www.lyx.org/trac/changeset/19916 - Save the right timestamp and checksum of an opened file. http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. always clear the full text_metrics_ when doing a full update. http://www.lyx.org/trac/changeset/20039 - Fix bug 4193 Revert ask for saving file before closing http://www.lyx.org/trac/changeset/20093 - Forgot this: windows backslash needs special treatment http://www.lyx.org/trac/changeset/20094 - Fix previous commit. I really do not understand why windows FileName() can not have backslash (assertion at line 49 of support/FileName.cpp) http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for Conglomerate-style inset http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this time properly http://www.lyx.org/trac/changeset/20104 - Better error signaling http://www.lyx.org/trac/changeset/20195 - unicodesymbols: workaround fix for an encoding bug in teTeX 3 /TeXLive 2005 http://www.lyx.org/trac/changeset/20185 - Helge's wrapfig patch http://www.lyx.org/trac/changeset/20153 - Fix crash when layout file cannot be read due to failure to call makeTextClass() in that case. http://www.lyx.org/trac/changeset/20159 - remove recursive call http://www.lyx.org/trac/changeset/20162 - fix some index/label issue http://www.lyx.org/trac/changeset/20165 - connect to the right slots... http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii character since LyX.py can't encode it at the moment Abdel' Stuff: - http://www.lyx.org/trac/changeset/19972 - Fix wrapping bug within inset. dim_.wid was not set! http://www.lyx.org/trac/changeset/19974 - correct dimension types. http://www.lyx.org/trac/changeset/19992 - Fix crash when selection begins or ends outside the visible screen. http://www.lyx.org/trac/changeset/20013 - get rid of (cyg)win path panel in prefs by moving it to the latex panel http://www.lyx.org/trac/changeset/20079 - Fix caption text y-positioning http://www.lyx.org/trac/changeset/20080 - Fix tabular text y-positioning http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection(): use parMetrics() instead of direct access just in case. Should fix crash on selection with PageUp http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable inset without button. http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within insets. http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons with surrounding text. http://www.lyx.org/trac/changeset/20142 - Restore docked View source widget. http://www.lyx.org/trac/changeset/20143 - fix view source window title. http://www.lyx.org/trac/changeset/20144 - oups... http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really needed. http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget. Warning: still instable! http://www.lyx.org/trac/changeset/20177 - TextMetrics::draw(): withdraw first row ascent before drawing because the convention is that the baseline of a multirow text is the baseline of the first row. http://www.lyx.org/trac/changeset/20178 - fix outline dialog for non-Mac platform.
Re: 1.5.X patch candidates - next iteration
> http://www.lyx.org/trac/changeset/19916 - Save the right timestamp and > checksum of an opened file. Already done. > http://www.lyx.org/trac/changeset/20039 - Fix bug 4193 Revert ask for > saving file before closing Already done. > http://www.lyx.org/trac/changeset/20093 - Forgot this: windows backslash > needs special treatment > http://www.lyx.org/trac/changeset/20094 - Fix previous commit. I really > do not understand why windows FileName() can not have backslash > (assertion at line 49 of support/FileName.cpp) Not for 1.5.x. (Actually they are, but I am too lazy to maintain scons for 1.5.x as long as it works). Bo
Re: 1.5.X patch candidates - next iteration
On Mon, Sep 10, 2007 at 08:59:02PM +0200, Michael Gerz wrote: > Hi, > > here comes a new list of 1.5.X patch candidates. Comments like "remove > patch XY from the list" are welcome. IMHO the list is too large to handle. > > Regards, Michael > > > > Not urgent, not now (but not rejected) > -- > > http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug > http://www.lyx.org/trac/changeset/19409 - Get rid of a few warnings > http://www.lyx.org/trac/changeset/19914 - single depth for preference > items, fixes bug #4153 > http://www.lyx.org/trac/changeset/20065 - make citation dialog usable > with longer keys > > > Approved by Jürgen > -- > > Update to Boost 1.34.1 > http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when > using %s with integer arguments > http://www.lyx.org/trac/changeset/19473 - more verbose message > http://www.lyx.org/trac/changeset/19638 - redoParagraph() simplify the > changed calculation > http://www.lyx.org/trac/changeset/19747 - Delete include of config.h. > This was needed only for the qt3 port. > http://www.lyx.org/trac/changeset/19868 - TextMetrics::redoParagraph(): > we need to check the returned value of Inset::metrics() > http://www.lyx.org/trac/changeset/19838 - Bug fix: correctly redraw a > Row containing and inset which Dimension slightly changed > > > Supported by someone else > - > > http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font > copying > http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization > > > New > --- > > http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): > remove the Buffer::changed() signal emission > http://www.lyx.org/trac/changeset/19916 - Save the right timestamp and > checksum of an opened file. > http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. > always clear the full text_metrics_ when doing a full update. > http://www.lyx.org/trac/changeset/20039 - Fix bug 4193 Revert ask for > saving file before closing > http://www.lyx.org/trac/changeset/20093 - Forgot this: windows backslash > needs special treatment > http://www.lyx.org/trac/changeset/20094 - Fix previous commit. I really > do not understand why windows FileName() can not have backslash > (assertion at line 49 of support/FileName.cpp) > http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for > Conglomerate-style inset > http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this > time properly I believe Abel reverted the stuff related to this. Someone verify that it works OK for all inset types (it seems to do for me) > http://www.lyx.org/trac/changeset/20104 - Better error signaling > http://www.lyx.org/trac/changeset/20195 - unicodesymbols: workaround fix > for an encoding bug in teTeX 3 /TeXLive 2005 > http://www.lyx.org/trac/changeset/20185 - Helge's wrapfig patch Apparently not... > http://www.lyx.org/trac/changeset/20153 - Fix crash when layout file > cannot be read due to failure to call makeTextClass() in that case. > http://www.lyx.org/trac/changeset/20159 - remove recursive call > http://www.lyx.org/trac/changeset/20162 - fix some index/label issue > http://www.lyx.org/trac/changeset/20165 - connect to the right slots... > http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii > character since LyX.py can't encode it at the moment > > > Abdel' Stuff: > - > > http://www.lyx.org/trac/changeset/19972 - Fix wrapping bug within inset. > dim_.wid was not set! > http://www.lyx.org/trac/changeset/19974 - correct dimension types. > http://www.lyx.org/trac/changeset/19992 - Fix crash when selection > begins or ends outside the visible screen. All due to dumping wide(). Not relevant > http://www.lyx.org/trac/changeset/20013 - get rid of (cyg)win path panel > in prefs by moving it to the latex panel > http://www.lyx.org/trac/changeset/20079 - Fix caption text y-positioning > http://www.lyx.org/trac/changeset/20080 - Fix tabular text y-positioning Ditto > http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection(): > use parMetrics() instead of direct access just in case. Should fix crash > on selection with PageUp > http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable > inset without button. I suppose ditto > http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within > insets. > http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons > with surrounding text. > http://www.lyx.org/trac/changeset/20142 - Restore docked View source widget. > http://www.lyx.org/trac/changeset/20143 - fix view source window title. > http://www.lyx.org/trac/changeset/20144 - oups... > http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really > needed. > http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget. > Warning: still instable! >
Re: 1.5.X patch candidates - next iteration
On Mon, Sep 10, 2007 at 08:59:02PM +0200, Michael Gerz wrote: > Hi, > > here comes a new list of 1.5.X patch candidates. Comments like "remove > patch XY from the list" are welcome. IMHO the list is too large to handle. > > Regards, Michael > > > > Not urgent, not now (but not rejected) > -- > > http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug > http://www.lyx.org/trac/changeset/19409 - Get rid of a few warnings > http://www.lyx.org/trac/changeset/19914 - single depth for preference > items, fixes bug #4153 > http://www.lyx.org/trac/changeset/20065 - make citation dialog usable > with longer keys > > > Approved by Jürgen > -- > > Update to Boost 1.34.1 > http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when > using %s with integer arguments Someone with checked-out branch should just apply that. Andre'
Re: 1.5.X patch candidates - next iteration
> > http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when > > using %s with integer arguments > > Someone with checked-out branch should just apply that. Done. r20199. Bo
Re: 1.5.X patch candidates - next iteration
> http://www.lyx.org/trac/changeset/20185 - Helge's wrapfig patch No, because file format change. > http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii character since LyX.py can't encode it at the moment This is not a fix but a workaround. This problem was trunk only. doc_toc.py is nevertheless broken in trunk and branch when handling non-ascii characters. regards Uwe
Re: 1.5.X patch candidates - next iteration
Bo Peng wrote: > Done. r20199. Thanks. Jürgen
Re: 1.5.X patch candidates - next iteration
I'll comment only on those that I haven't approved last time. Michael Gerz wrote: > Not urgent, not now (but not rejected) > -- > > http://www.lyx.org/trac/changeset/19331 - Deal with a UI bug > http://www.lyx.org/trac/changeset/19409 - Get rid of a few warnings > http://www.lyx.org/trac/changeset/19914 - single depth for preference > items, fixes bug #4153 remove these, please. > http://www.lyx.org/trac/changeset/20065 - make citation dialog usable > with longer keys Not necessary. Remove. > Approved by Jürgen > -- > > Update to Boost 1.34.1 > http://www.lyx.org/trac/changeset/19472 - fix crash after assertion when > using %s with integer arguments In. Remove. > Supported by someone else > - > > http://www.lyx.org/trac/changeset/20016 - optimization: avoid some font > copying > http://www.lyx.org/trac/changeset/20021 - enable some non-rtl optimization Alfredo asked for some expert review. After that, it can go in. (I've already approved that) > New > --- > > http://www.lyx.org/trac/changeset/19867 - InsetCollapsable::setStatus(): > remove the Buffer::changed() signal emission Already approved last time ... > http://www.lyx.org/trac/changeset/19916 - Save the right timestamp and > checksum of an opened file. In. Remove. > http://www.lyx.org/trac/changeset/19919 - Fix DEPM crash within inset. > always clear the full text_metrics_ when doing a full update. Applicable to branch? > http://www.lyx.org/trac/changeset/20039 - Fix bug 4193 Revert ask for > saving file before closing In. Remove. > http://www.lyx.org/trac/changeset/20093 - Forgot this: windows backslash > needs special treatment > http://www.lyx.org/trac/changeset/20094 - Fix previous commit. I really > do not understand why windows FileName() can not have backslash > (assertion at line 49 of support/FileName.cpp) Remove (since Bo won't backport this). > http://www.lyx.org/trac/changeset/20102 - Fix y co-ordinate for > Conglomerate-style inset > http://www.lyx.org/trac/changeset/20103 - y-coord in Conglomerate, this > time properly Not applicable to branch, I think. Remove both. > http://www.lyx.org/trac/changeset/20104 - Better error signaling Not applicable, I think. Martin? > http://www.lyx.org/trac/changeset/20195 - unicodesymbols: workaround fix > for an encoding bug in teTeX 3 /TeXLive 2005 Approved. Should go in today. > http://www.lyx.org/trac/changeset/20185 - Helge's wrapfig patch Definitely not (file format change). Remove. > http://www.lyx.org/trac/changeset/20153 - Fix crash when layout file > cannot be read due to failure to call makeTextClass() in that case. Not applicable, I think. Richard? > http://www.lyx.org/trac/changeset/20159 - remove recursive call Hm. Peter, is this something for branch? > http://www.lyx.org/trac/changeset/20162 - fix some index/label issue Not applicable. Remove. > http://www.lyx.org/trac/changeset/20165 - connect to the right slots... Not applicable. Remove. > http://www.lyx.org/trac/changeset/20173 - doc_toc.py: remove non-ascii > character since LyX.py can't encode it at the moment Not applicable. Remove. > > Abdel' Stuff: > - > > http://www.lyx.org/trac/changeset/19972 - Fix wrapping bug within inset. > dim_.wid was not set! > http://www.lyx.org/trac/changeset/19974 - correct dimension types. > http://www.lyx.org/trac/changeset/19992 - Fix crash when selection > begins or ends outside the visible screen. Not applicable. Remove all these. > http://www.lyx.org/trac/changeset/20013 - get rid of (cyg)win path panel > in prefs by moving it to the latex panel No. Remove. > http://www.lyx.org/trac/changeset/20079 - Fix caption text y-positioning > http://www.lyx.org/trac/changeset/20080 - Fix tabular text y-positioning Not applicable. Remove. > http://www.lyx.org/trac/changeset/20081 - TextMetrics::drawSelection(): > use parMetrics() instead of direct access just in case. Should fix crash > on selection with PageUp Abdel? > http://www.lyx.org/trac/changeset/20082 - Fix drawing of collapsable > inset without button. Not applicable to branch, I think. Remove. > http://www.lyx.org/trac/changeset/20083 - Fix alignment of text within > insets. > http://www.lyx.org/trac/changeset/20101 - Nicely align inset buttons > with surrounding text. > http://www.lyx.org/trac/changeset/20142 - Restore docked View source > widget. http://www.lyx.org/trac/changeset/20143 - fix view source window > title. http://www.lyx.org/trac/changeset/20144 - oups... > http://www.lyx.org/trac/changeset/20146 - Dialog::name() is not really > needed. > http://www.lyx.org/trac/changeset/20147 - Restore docked outline widget. > Warning: still instable! > http://www.lyx.org/trac/changeset/20177 - TextMetrics::draw(): withdraw > first row ascent before drawing because the convention is that the > baseline of a multirow text is the baseline of the first row. > http://www.lyx.org/trac/changeset/20178 - fix outline
