Re: CMake issues for LyX 2.3.0

2018-02-27 Thread Kornel Benko
Am Montag, 26. Februar 2018 17:49:03 CET schrieb Uwe Stöhr :
> I see, the problem is that in the first run I cannot specify
> CMAKE_PREFIX_PATH

I tried, and it is possible. Simply use the button "Add Entry",
use for Name "CMAKE_PREFIX_PATH"
and the Type "PATH".

For the Value I suggest to use '/' instead of '\'.

And because we have many variables, i'd prefer also to check "Grouped" and 
"Advanced" buttons too.

Kornel


signature.asc
Description: This is a digitally signed message part.


Re: CMake issues for LyX 2.3.0

2018-02-26 Thread Kornel Benko
Am Montag, 26. Februar 2018 17:49:03 CET schrieb Uwe Stöhr :
> Am 26.02.2018 um 16:26 schrieb Kornel Benko:
> > For cmake in master (and in 2.3.x), the default is "AUTO". That is
> > 
> > Check first for QT5
> > if not found, try with QT4
> 
> Hi Kornel,
> 
> many thanks for having a look.
> 
> I see, the problem is that in the first run I cannot specify
> CMAKE_PREFIX_PATH
> For the workflow is:
> - start CMake and specify source and destination folder

Just to make clear ... you don't start cmake, but cmake-gui.
I normally never use the gui, so I didn't see the problem.

You could, for start, create the first CMakeCache.txt from a .bat file.
Starting cmake from the build-dir and specifying needed values in the command-
line should prepare for use later with cmake-gui.

> - run CMake's configure
> - I will be asked for a compiler and I select MSVC 2015
> 
> result: I get this error: ERROR: Could NOT find GNUWIN32, please set
> GNUWIN32_DIR
> 
> - I specify the GNUWIN32_DIR folder but cannot specify the
> CMAKE_PREFIX_PATH, because this setting does not yet exist, see the
> attached screenshot
> - I run CMake's configure again
> 
> result: now I get this error:
> CMake Error at development/cmake/modules/FindQt4.cmake:1037 (message):
>Qt qmake not found!
> see also the second attached screenshot. So you can see CMake looks for
> QT4 because I had no chance yet to specify CMAKE_PREFIX_PATH.
> 
> - first now I can CMAKE_PREFIX_PATH and do so
> - I note that LyX_USE_QT is set to "Qt4". Therefore I need to set it ti
> "Qt5" to match the CMAKE_PREFIX_PATH
> 
> result: now I get no longer an error and can run CMake's Generate
> command and start the compilation.

Yes, sorry for the trouble.

> thanks and regards
> Uwe

Kornel



signature.asc
Description: This is a digitally signed message part.


Re: CMake issues for LyX 2.3.0

2018-02-26 Thread Kornel Benko
Am Montag, 26. Februar 2018 15:22:15 CET schrieb Uwe Stöhr :
> I could successfully build LyX 2.3.0 from the tarball and the installer 
> is ready. Nevertheless there are some issues in CMake that we should 
> consider to change:
> 
> - after the compilation I get a subfolder named "LYX_INSTALLED". it 
> contains everything one needs to build the installer, except of two folders:
> ~\LYX_INSTALLED\Resources\dicts
>   ~\LYX_INSTALLED\Resources\thes
> both folders should be empty (will later be filled when the user 
> installs dictionaries), but they must exist. Currently I create them by 
> myself. In order to avoid problems CMake should create these 2 empty 
> folders automatically.

Will see, what I can do here. Be aware though, that cmake "normally" avoids to 
install empty folders. (That was my understanding, but I may be wrong).

Kornel


signature.asc
Description: This is a digitally signed message part.


Re: CMake issues for LyX 2.3.0

2018-02-26 Thread Kornel Benko
Am Montag, 26. Februar 2018 14:40:19 CET schrieb José Abílio Matos 
:
> On Monday, 26 February 2018 14.22.15 WET Uwe Stöhr wrote:
> > - the default in CMake for LYX_USE_QT is still Qt4, it should be Qt5
> 
> Note that this is also the default with the autotools (autoconf & co). So
> that is a global choice and it is not specific to cmake.
> 
> For 2.4 I think that the time has come to make Qt5 the default.

For cmake in master (and in 2.3.x), the default is "AUTO". That is
Check first for QT5
if not found, try with QT4
(Not found means: some needed devel files (like includes, executables, 
libraries) are not accessible)

> > - I set the CMAKE_PREFIX_PATH and CMake finds then automatically all Qt
> > libraries (see the attached screenshot). It does not find
> > QT_QMAKE_EXECUTABLE why? On my PC it is here:
> > C:\Qt\Qt5.9.4\5.9.4\msvc2015\bin

The search for QT5 is done by QT5-own cmake configuration files. They have to 
be 
installed.
The path 'C:\Qt\Qt5.9.4\5.9.4\msvc2015\bin' looks good though.

> Regards,

Kornel



signature.asc
Description: This is a digitally signed message part.


Re: CMake issues for LyX 2.3.0

2018-02-26 Thread José Abílio Matos
On Monday, 26 February 2018 14.22.15 WET Uwe Stöhr wrote:
> - the default in CMake for LYX_USE_QT is still Qt4, it should be Qt5

Note that this is also the default with the autotools (autoconf & co). So 
that is a global choice and it is not specific to cmake.

For 2.4 I think that the time has come to make Qt5 the default.

Regards,
-- 
José Abílio


CMake issues for LyX 2.3.0

2018-02-26 Thread Uwe Stöhr
I could successfully build LyX 2.3.0 from the tarball and the installer 
is ready. Nevertheless there are some issues in CMake that we should 
consider to change:


- after the compilation I get a subfolder named "LYX_INSTALLED". it 
contains everything one needs to build the installer, except of two folders:

 ~\LYX_INSTALLED\Resources\dicts
 ~\LYX_INSTALLED\Resources\thes
both folders should be empty (will later be filled when the user 
installs dictionaries), but they must exist. Currently I create them by 
myself. In order to avoid problems CMake should create these 2 empty 
folders automatically.


- the default in CMake for LYX_USE_QT is still Qt4, it should be Qt5

- I set the CMAKE_PREFIX_PATH and CMake finds then automatically all Qt 
libraries (see the attached screenshot). It does not find 
QT_QMAKE_EXECUTABLE why? On my PC it is here:

C:\Qt\Qt5.9.4\5.9.4\msvc2015\bin

- there are some other settings I don't understand, see the blue boxes 
in the attached screenshot. So for example ZLIB was found but ZLIB_FOUND 
is empty. The same is for MYTHES and HUNSPELL.
CMake checks for a doxygen executable. Is this really necessary or can 
this be removed?

What program is "Magic"?
Qt5X11Extras does not exist on Windows. Therefore CMake should not 
search for it, if this is technically possible.


- in the attached screenshot you also see some CMake warnings. If we can 
ignore them, then we should use the -Wno-dev flag as suggested by the 
warning text.


many thanks and regards
Uwe