Re: [LyX/master] Install a new compressor
Le 01/02/2018 à 18:21, Scott Kostyshak a écrit : On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote: Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller: Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc Lasgouttes: This makes much sense. You could probably move the new line to the other GuiWorkArea constructor... Yes, this seems to work as well. I have now pushed this fix to master. Thanks for the fix, Jürgen. Let's double-check with Guillaume and port to 2.3.x. Guillaume does this patch make sense to you? Scott Dear Scott, this looks good to me. I would not have proposed it for 2.3, but thank you for the live test, this is much appreciated. Guillaume
Re: [LyX/master] Install a new compressor
Le 01/02/2018 à 22:23, Scott Kostyshak a écrit : On Thu, Feb 01, 2018 at 07:19:03PM +, Guillaume MM wrote: Le 01/02/2018 à 18:21, Scott Kostyshak a écrit : On Thu, Feb 01, 2018 at 02:00:43PM +, Jürgen Spitzmüller wrote: Am Donnerstag, den 01.02.2018, 11:40 +0100 schrieb Jürgen Spitzmüller: Am Donnerstag, den 01.02.2018, 11:22 +0100 schrieb Jean-Marc Lasgouttes: This makes much sense. You could probably move the new line to the other GuiWorkArea constructor... Yes, this seems to work as well. I have now pushed this fix to master. Thanks for the fix, Jürgen. Let's double-check with Guillaume and port to 2.3.x. Guillaume does this patch make sense to you? Scott Dear Scott, this looks good to me. Thanks for taking a look. I would not have proposed it for 2.3, I'm pretty sure I know what you mean but I want to make 100% sure: You mean the new compressor in the first place (i.e. commit 789617b8), right? Conditional on us keeping that commit for 2.3.0, you do agree that it makes sense to backport the follow-up 5ce36019, right? Yes, you need Jürgen's fix. The new compressor is in 2.3.0rc2. If we do not receive any other reports that seem linked to it, do you agree that we should keep the compressor for 2.3.0? Or do you have reason to think there is a significant chance of a nasty bug that we might not encounter while testing that could be serious? The source of uncertainty is that it changes the behaviour on all platforms in a non-specific way. Just make sure it is well tested on all platforms. To test it, put the system in heavy load and check that LyX behaves nicely when overwhelmed with keyboard input, not necessarily with autorepeat. Thanks, Guillaume Thanks, Scott
Re: [LyX/2.3.x] Fix bug #9348
Hi,
The commit below introduces an incompatibility between lyx 2.3.1 and
2.3.2 that can affect users of math macros.
This was reported a while ago at
https://www.lyx.org/trac/ticket/9348#comment:17 with an example. The
difference results in extra red braces being introduced. The example
shows several cases where this changes the latex meaning and pdf output
in some cases, and causes compilation errors in other cases.
This is the sort of difference that can cause repeated issues, say, for
two people who use different stable versions to collaborate on the same
document.
Guillaume
Le 06/10/2018 à 12:51, Enrico Forestieri a écrit :
commit e94ea46be7e6738ff7ebdaca995c076a6fe649ef
Author: Enrico Forestieri
Date: Tue Apr 10 22:40:02 2018 +0200
Fix bug #9348
(cherry picked from commit 503f7db224c7afaa82ce1f0aea538bd2af0cf31a)
---
src/mathed/InsetMathBrace.h |2 --
status.23x |2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mathed/InsetMathBrace.h b/src/mathed/InsetMathBrace.h
index b28cd05..82393e9 100644
--- a/src/mathed/InsetMathBrace.h
+++ b/src/mathed/InsetMathBrace.h
@@ -29,8 +29,6 @@ public:
InsetMathBrace * asBraceInset() { return this; }
/// identifies brace insets
InsetMathBrace const * asBraceInset() const { return this; }
- /// we write extra braces in any case...
- bool extraBraces() const { return true; }
///
void metrics(MetricsInfo & mi, Dimension & dim) const;
///
diff --git a/status.23x b/status.23x
index 4874268..66ef597 100644
--- a/status.23x
+++ b/status.23x
@@ -127,6 +127,8 @@ What's new
- Fix issue with erroneous qualified citations (bug 11308).
+- Do not remove brace insets when parsing from latex (bug 9348).
+
* USER INTERFACE
