Re: [125062] trunk/dports/sysutils/ntp/Portfile

2014-09-04 Thread Daniel J. Luke
On Sep 4, 2014, at 1:24 AM, c...@macports.org wrote:
 
 ntp: add modeline, whitespace only, in preparation for #44874, ignoring 
 maintainer due to security issue

besides the fact that the reporter appears to be incorrect, and the port didn't 
need to be edited - the policy for 'broken' ports (7.3.1) has been that only 
minimal changes are to be made to fix the immediate problem (any other changes 
would require maintainer timeout or the port abandonment procedure).

If that's till the case, we should probably document it, and if it's not we 
should probably make that clear as well (I don't know when it would have 
changed, though).

--
Daniel J. Luke  
 
++  
  
| * dl...@geeklair.net * |  

| *-- http://www.geeklair.net -* |  

++  
  
|   Opinions expressed are mine and do not necessarily   |  

|  reflect the opinions of my employer.  |  

++



___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [125062] trunk/dports/sysutils/ntp/Portfile

2014-09-04 Thread Joshua Root
On 2014-9-4 23:51 , Daniel J. Luke wrote:
 On Sep 4, 2014, at 1:24 AM, c...@macports.org wrote:

 ntp: add modeline, whitespace only, in preparation for #44874, ignoring 
 maintainer due to security issue
 
 besides the fact that the reporter appears to be incorrect, and the port 
 didn't need to be edited - the policy for 'broken' ports (7.3.1) has been 
 that only minimal changes are to be made to fix the immediate problem (any 
 other changes would require maintainer timeout or the port abandonment 
 procedure).
 
 If that's till the case, we should probably document it, and if it's not we 
 should probably make that clear as well (I don't know when it would have 
 changed, though).

Yes, that hasn't changed. It's mentioned in 9.1 of
https://trac.macports.org/wiki/NewCommittersGuide#PortCommitterResponsibilities

- Josh
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [125071] trunk/dports/security

2014-09-04 Thread Ryan Schmidt
On Sep 4, 2014, at 8:53 AM, khindenb...@macports.org wrote:
 
 Revision
 125071
 Author
 khindenb...@macports.org
 Date
 2014-09-04 06:53:12 -0700 (Thu, 04 Sep 2014)
 Log Message
 
 easy-rsa: new port w/ maintainer #44287
 Added Paths
 
   • trunk/dports/security/easy-rsa/
   • trunk/dports/security/easy-rsa/Portfile
   • trunk/dports/security/easy-rsa/files/
   • trunk/dports/security/easy-rsa/files/patch-set-macports-paths.diff


 +destroot {
 +xinstall -d ${destroot}${prefix}/bin

No need to create this directory manually: MacPorts creates standard 
directories for you.


 --- trunk/dports/security/easy-rsa/files/patch-set-macports-paths.diff
 (rev 0)
 +++ trunk/dports/security/easy-rsa/files/patch-set-macports-paths.diff
 2014-09-04 13:53:12 UTC (rev 125071)
 @@ -0,0 +1,43 @@
 +--- easyrsa
  easyrsa
 +@@ -885,7 +885,7 @@ vars_setup() {
 + local vars=
 + 
 + # set up program path
 +-local prog_vars=${0%/*}/vars
 ++local prog_vars=/opt/local/share/easy-rsa

 +-set_var EASYRSA $PWD
 ++set_var EASYRSA /opt/local/share/easy-rsa

 +-#set_var EASYRSA$PWD
 ++#set_var EASYRSA/opt/local/share/easy-rsa

/opt/local must not be hardcoded in this file; arrange (e.g. via a 
placeholder and a post-patch reinplace) to use the value of the ${prefix} 
variable. I guess this will change the files that get installed, which would 
mean the port's revision should increase when this is fixed.



___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Configuration and environment check command (was: Re: [124047] trunk/base)

2014-09-04 Thread Eric Gallager
Does it have to parallel selfupdate? diagnose works perfectly well
by itself without the self in front of it...

On 8/26/14, Craig Treleaven ctrelea...@macports.org wrote:
 On Aug 25, 2014, at 6:35 AM, Rainer Müller rai...@macports.org wrote:
 
 However, I am not too happy with naming the command 'port doctor'. Many
 other commands used with port(1) are verbs, but using this as a verb
 carries the wrong message.
 
 I know where the naming comes from, but there is no need to match any
 other terminology and we should rather define our own coherent names.
 
 My proposal would be to rename this to 'port selfcheck' instead.
 
 I second the proposal. Selfcheck is a bit awkward, but it does parallel
 selfupdate nicely.
 
 Anything would be better than doctor, which is transparently
 derivative.
 
 'port selfexam' ?
 'port sefldiagnose' ?
 
 Just kidding, but they play on the medical theme...
 
 Craig
 
 ___
 macports-dev mailing list
 macports-dev@lists.macosforge.org
 https://lists.macosforge.org/mailman/listinfo/macports-dev
 
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Configuration and environment check command (was: Re: [124047] trunk/base)

2014-09-04 Thread Lawrence Velázquez
On Sep 4, 2014, at 5:07 PM, Eric Gallager eg...@gwmail.gwu.edu wrote:

 Does it have to parallel selfupdate? diagnose works perfectly well
 by itself without the self in front of it...

Of course it doesn't *have* to. But most of the port(1) verbs operate on ports 
and port names, whereas selfupdate operates on the MacPorts installation 
itself. So it would make sense to have a selfcheck that checks on the 
MacPorts environment itself, as a whole.

(I know, rev-upgrade and sync [and probably others] don't really operate on 
ports per se. It's a rough guideline.)

vq
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Configuration and environment check command (was: Re: [124047] trunk/base)

2014-09-04 Thread Ian Wadham

On 05/09/2014, at 9:59 AM, Lawrence Velázquez wrote:

 On Sep 4, 2014, at 5:07 PM, Eric Gallager eg...@gwmail.gwu.edu wrote:
 
 Does it have to parallel selfupdate? diagnose works perfectly well
 by itself without the self in front of it...
 
 Of course it doesn't *have* to. But most of the port(1) verbs operate on 
 ports and port names, whereas selfupdate operates on the MacPorts 
 installation itself. So it would make sense to have a selfcheck that checks 
 on the MacPorts environment itself, as a whole.

So why not checkself?  Cheers, Ian W.

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Configuration and environment check command (was: Re: [124047] trunk/base)

2014-09-04 Thread Lawrence Velázquez
On Sep 4, 2014, at 8:04 PM, Ian Wadham iandw...@gmail.com wrote:

 So why not checkself?  Cheers, Ian W.

Because it's not updateself, it's selfupdate.

vq
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Configuration and environment check command (was: Re: [124047] trunk/base)

2014-09-04 Thread Ian Wadham
On 05/09/2014, at 10:20 AM, Lawrence Velázquez wrote:

 On Sep 4, 2014, at 8:04 PM, Ian Wadham iandw...@gmail.com wrote:
 
 So why not checkself?  Cheers, Ian W.
 
 Because it's not updateself, it's selfupdate.

Well, I was also going to suggest updateself… : -)  the logic being that 
port
commands usually follow the sequence port do-something to-something,
but I realise selfupdate is deeply entrenched…

I suggested checkself because someone, IIRC, did not want to have to type
as far as the u if they required selfupdate.

Cheers, Ian W.


___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [125071] trunk/dports/security

2014-09-04 Thread Kurt Hindenburg


On 9/4/14, 1:36 PM, Ryan Schmidt wrote:

On Sep 4, 2014, at 8:53 AM, khindenb...@macports.org wrote:

Revision
125071
Author
khindenb...@macports.org
Date
2014-09-04 06:53:12 -0700 (Thu, 04 Sep 2014)
Log Message

easy-rsa: new port w/ maintainer #44287
Added Paths

• trunk/dports/security/easy-rsa/
• trunk/dports/security/easy-rsa/Portfile
• trunk/dports/security/easy-rsa/files/
• trunk/dports/security/easy-rsa/files/patch-set-macports-paths.diff



+destroot {
+xinstall -d ${destroot}${prefix}/bin

No need to create this directory manually: MacPorts creates standard 
directories for you.


fixed in r125083

--- trunk/dports/security/easy-rsa/files/patch-set-macports-paths.diff  
(rev 0)
+++ trunk/dports/security/easy-rsa/files/patch-set-macports-paths.diff  
2014-09-04 13:53:12 UTC (rev 125071)
@@ -0,0 +1,43 @@
+--- easyrsa
 easyrsa
+@@ -885,7 +885,7 @@ vars_setup() {
+   local vars=
+
+   # set up program path
+-  local prog_vars=${0%/*}/vars
++  local prog_vars=/opt/local/share/easy-rsa
+-  set_var EASYRSA $PWD
++  set_var EASYRSA /opt/local/share/easy-rsa
+-#set_var EASYRSA  $PWD
++#set_var EASYRSA  /opt/local/share/easy-rsa

/opt/local must not be hardcoded in this file; arrange (e.g. via a 
placeholder and a post-patch reinplace) to use the value of the ${prefix} variable. I 
guess this will change the files that get installed, which would mean the port's revision 
should increase when this is fixed.

fixed in r125085 - A diff of the previous and new files didn't show any 
difference so I didn't increase the revision.


Thanks
  Kurt


___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: [125071] trunk/dports/security

2014-09-04 Thread Ryan Schmidt

 On Sep 4, 2014, at 8:25 PM, Kurt Hindenburg wrote:
 
 /opt/local must not be hardcoded in this file; arrange (e.g. via a 
 placeholder and a post-patch reinplace) to use the value of the ${prefix} 
 variable. I guess this will change the files that get installed, which would 
 mean the port's revision should increase when this is fixed.
 
 fixed in r125085 - A diff of the previous and new files didn't show any 
 difference so I didn't increase the revision.

What's your MacPorts prefix? You'd only see a difference if your prefix is not 
/opt/local. But I guess since the port was just created, there's a good chance 
nobody with a nonstandard prefix has installed it yet, so increasing the 
revision probably isn't necessary in this case.



___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


Re: Configuration and environment check command

2014-09-04 Thread Ryan Schmidt

On Sep 4, 2014, at 7:39 PM, Ian Wadham wrote:

 but I realise selfupdate is deeply entrenched…

My preference would be to eventually eliminate sudo port selfupdate and 
replace it with sudo port upgrade MacPorts:

https://trac.macports.org/wiki/SummerOfCode#self-management

That's not how it works today, but I'd like it to.

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev


[125081] trunk/dports/python/py-celementtree/Portfile

2014-09-04 Thread Joshua Root
 Revision: 125081
   https://trac.macports.org/changeset/125081
 Author:   afb at macports.org
 Date: 2014-09-04 11:51:21 -0700 (Thu, 04 Sep 2014)
 Log Message:
 ---
 add py27-celementtree for py27-kid
 
 Modified Paths:
 --
 trunk/dports/python/py-celementtree/Portfile
 
 Modified: trunk/dports/python/py-celementtree/Portfile
 ===
 --- trunk/dports/python/py-celementtree/Portfile  2014-09-04 18:47:46 UTC 
 (rev 125080)
 +++ trunk/dports/python/py-celementtree/Portfile  2014-09-04 18:51:21 UTC 
 (rev 125081)
 @@ -20,7 +20,7 @@
  checksumssha1 b36c95fd90d53746424c10db45b102b8fab260b8
  use_zip  yes
  
 -python.versions  25 26
 +python.versions  25 26 27

The homepage says:

 cElementTree is included with Python 2.5 and later, as xml.etree.cElementTree.

Does kid not work with the included version for some reason?

- Josh
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev